1 2015-11-13T00:06:00  <gmaxwell> phantomcircuit: I hate to expand your patch, but in net.h there is a comment about fRelay which you should probably revise slightly to make it sound like until a filter load isn't the only use.
  2 2015-11-13T00:06:41  <phantomcircuit> gmaxwell, oh the humanity!
  3 2015-11-13T00:16:31  *** PRab has quit IRC
  4 2015-11-13T00:16:57  *** PaulCapestany has quit IRC
  5 2015-11-13T00:22:19  *** PaulCapestany has joined #bitcoin-core-dev
  6 2015-11-13T00:29:21  <phantomcircuit> gmaxwell, ok comment changed
  7 2015-11-13T00:52:47  <phantomcircuit> gmaxwell, i couldn't figure out a sane way to use the constant (which is defined in main.h) in net.cpp
  8 2015-11-13T01:00:35  <sipa> phantomcircuit: pass that true/false based on blocksonly as a parameter to PushVersion
  9 2015-11-13T01:01:33  <phantomcircuit> sipa, PushVersion is called from the constructor of CNode::CNode
 10 2015-11-13T01:01:38  <phantomcircuit> er from...
 11 2015-11-13T01:01:40  <phantomcircuit> words
 12 2015-11-13T01:01:56  <sipa> aaargh
 13 2015-11-13T01:02:25  <phantomcircuit> lol yeah that's why i just gave up and left it as a constant constant
 14 2015-11-13T01:02:29  <sipa> can you ehm... add an Start method to CNode or so?
 15 2015-11-13T01:02:29  <gmaxwell> it what?
 16 2015-11-13T01:04:25  *** Ylbam has quit IRC
 17 2015-11-13T01:05:55  <phantomcircuit> sipa, the "clean" way is to add a fVersionSent flag and then check that in SendMessages
 18 2015-11-13T01:06:04  <phantomcircuit> you wont send anything until you get a verack anyways
 19 2015-11-13T01:08:16  * phantomcircuit lols at CNode flags
 20 2015-11-13T01:30:00  <dcousens> #d
 21 2015-11-13T01:30:03  <dcousens> nvm
 22 2015-11-13T02:01:04  *** randy-waterhouse has quit IRC
 23 2015-11-13T02:11:33  *** Thireus has quit IRC
 24 2015-11-13T02:15:06  *** Thireus has joined #bitcoin-core-dev
 25 2015-11-13T02:26:35  *** CodeShark has quit IRC
 26 2015-11-13T02:26:56  *** CodeShark has joined #bitcoin-core-dev
 27 2015-11-13T02:29:35  *** skyraider has quit IRC
 28 2015-11-13T02:32:43  *** sipa_ has joined #bitcoin-core-dev
 29 2015-11-13T02:32:57  *** skyraider has joined #bitcoin-core-dev
 30 2015-11-13T02:32:58  *** sipa has quit IRC
 31 2015-11-13T02:37:00  *** Apocalyptic has quit IRC
 32 2015-11-13T02:37:00  *** lecusemble has quit IRC
 33 2015-11-13T02:37:02  *** guruvan has quit IRC
 34 2015-11-13T02:37:03  *** gavinandresen has quit IRC
 35 2015-11-13T02:44:16  *** guruvan has joined #bitcoin-core-dev
 36 2015-11-13T02:44:16  *** gavinandresen has joined #bitcoin-core-dev
 37 2015-11-13T02:44:22  *** lecusemble has joined #bitcoin-core-dev
 38 2015-11-13T02:45:04  *** Apocalyptic has joined #bitcoin-core-dev
 39 2015-11-13T03:01:28  *** dcousens has quit IRC
 40 2015-11-13T03:05:44  *** dcousens has joined #bitcoin-core-dev
 41 2015-11-13T03:06:28  <dcousens> anyone here use any blockchain analyser tools?
 42 2015-11-13T03:06:53  <dcousens> sorry, will go to bitcoin-dev
 43 2015-11-13T03:42:18  *** skyraider has quit IRC
 44 2015-11-13T03:48:18  <petertodd> CodeShark: lol, and now you made me realise gmaxwell could equally be talking about my MMR ideas - the reinvention cycle just went meta full circle!
 45 2015-11-13T03:53:44  *** Thireus has quit IRC
 46 2015-11-13T03:58:36  *** PRab has joined #bitcoin-core-dev
 47 2015-11-13T04:00:46  <jcorgan>  /cl
 48 2015-11-13T04:01:41  *** Thireus has joined #bitcoin-core-dev
 49 2015-11-13T04:14:15  *** zooko has quit IRC
 50 2015-11-13T04:25:20  *** dgenr8 has quit IRC
 51 2015-11-13T04:29:38  <gmaxwell> is someone going to update univalue in master?
 52 2015-11-13T04:29:41  *** dgenr8 has joined #bitcoin-core-dev
 53 2015-11-13T04:46:37  *** fanquake has joined #bitcoin-core-dev
 54 2015-11-13T04:57:10  * Luke-Jr wonders if we should increase the number of blocks for Core wallet to consider transactions confirmed.
 55 2015-11-13T04:57:17  <gmaxwell> oh wow, intel mpx when used changes the ABI and makes all pointers bounds checked.
 56 2015-11-13T04:58:29  <Luke-Jr> gmaxwell: 128-bit wide?
 57 2015-11-13T05:00:25  <gmaxwell> no, it's done in an odd way that makes mixed systems possible.
 58 2015-11-13T05:01:09  <gmaxwell> basically there is a seperate bounds table. though dealing with it is still part of the abi.
 59 2015-11-13T05:02:29  <gmaxwell> https://www.kernel.org/doc/Documentation/x86/intel_mpx.txt
 60 2015-11-13T05:03:33  <Luke-Jr> oh nice, compiling with MPX gracefully noops on old CPUs
 61 2015-11-13T05:59:30  *** jtimon has quit IRC
 62 2015-11-13T06:00:06  <CodeShark> if I whitelist a node, other than network/transport issues or misbehaving, is there ever any conceivable situation where the node could get disconnected by bitcoin core
 63 2015-11-13T06:02:39  <CodeShark> ?
 64 2015-11-13T06:03:53  <CodeShark> actually, even in the event of misbehaving
 65 2015-11-13T06:10:47  <cfields> gitian-builders: 0.11.2 detached sigs are pushed
 66 2015-11-13T06:11:06  <cfields> 0.10.4 is waiting on one more match
 67 2015-11-13T06:11:46  <fanquake> WIll push up shortly
 68 2015-11-13T06:11:53  <fanquake> mich is the only one so far?
 69 2015-11-13T06:13:14  <cfields> his and mine
 70 2015-11-13T06:13:47  <cfields> er.. i forgot to push
 71 2015-11-13T06:15:21  <cfields> ok, done
 72 2015-11-13T06:17:53  *** arowser has quit IRC
 73 2015-11-13T06:19:15  <fanquake> ok, signed sigs PR'd
 74 2015-11-13T06:19:24  <fanquake> will build 0.10.4
 75 2015-11-13T06:20:05  <fanquake> hopefully for the last time..
 76 2015-11-13T06:20:38  *** jgarzik has joined #bitcoin-core-dev
 77 2015-11-13T06:33:55  *** pmienk has quit IRC
 78 2015-11-13T06:35:42  <Luke-Jr> I wish gitian had a way to pull the yml from the git repo directly, so I didn't need to close out my main git working dir just to build..
 79 2015-11-13T06:45:43  *** pmienk has joined #bitcoin-core-dev
 80 2015-11-13T07:10:58  <fanquake> cfields pushed 0.10.4 sigs
 81 2015-11-13T07:14:11  <cfields> fanquake: great, thanks! all matches. Pushing up the 10.4 detached sig now
 82 2015-11-13T07:23:17  <cfields> gitian builders/fanquake: https://bitcoincore.org/cfields/bitcoin-0.10.4/signature.tar.gz
 83 2015-11-13T07:27:16  <fanquake> cfields great. Sigs PR'd
 84 2015-11-13T07:29:18  <cfields> fanquake: thanks a bunch. Off to bed now
 85 2015-11-13T07:43:50  *** Thireus has quit IRC
 86 2015-11-13T07:49:20  <sipa_> Luke-Jr: you can, i forget how
 87 2015-11-13T07:49:26  <Luke-Jr> !
 88 2015-11-13T07:49:57  <sipa_> i wrote a patch for that years ago, which i kept using, but it isn't necessary anymore
 89 2015-11-13T07:54:00  <gmaxwell> So sipa updated this PR https://github.com/bitcoin/bitcoin/pull/6983  but I can't figure out what changed
 90 2015-11-13T08:01:43  *** Thireus has joined #bitcoin-core-dev
 91 2015-11-13T08:09:00  <sipa_> gmaxwell: i rebased it
 92 2015-11-13T08:09:22  <sipa_> it conflicted with the PIE change in Makefile.am
 93 2015-11-13T08:09:50  <sipa_> only the full validation pull conflicted, but Ibdidn't bother looking and rebased both
 94 2015-11-13T08:16:20  *** mably has joined #bitcoin-core-dev
 95 2015-11-13T08:26:23  *** dcousens has quit IRC
 96 2015-11-13T08:40:24  *** mably has quit IRC
 97 2015-11-13T08:40:53  <BlueMatt> jonasschnelli's pgp key isnt signed at all :(
 98 2015-11-13T08:43:27  *** fkhan has quit IRC
 99 2015-11-13T08:45:45  *** mably has joined #bitcoin-core-dev
100 2015-11-13T08:48:30  <wumpus> we should definitely change that
101 2015-11-13T08:49:44  *** CodeShark_ has joined #bitcoin-core-dev
102 2015-11-13T08:56:05  *** fkhan has joined #bitcoin-core-dev
103 2015-11-13T08:56:26  *** pmienk has quit IRC
104 2015-11-13T08:56:32  *** aburan28 has quit IRC
105 2015-11-13T08:58:53  <BlueMatt> where in .ch is jonasschnelli anyway? could probably go meet up with sipa, if no one else
106 2015-11-13T09:00:08  <CodeShark_> in europe, nothing is very far away (except russia) :p
107 2015-11-13T09:01:05  <wumpus> he has met up with sipa a few times IIRC
108 2015-11-13T09:01:16  <wumpus> and he was in Montreal. I can confirm jonasschnelli is a real person :p
109 2015-11-13T09:02:25  *** Arnavion has quit IRC
110 2015-11-13T09:02:38  <BlueMatt> wumpus: yes, he was around then
111 2015-11-13T09:03:41  *** Ylbam has joined #bitcoin-core-dev
112 2015-11-13T09:03:45  <sipa_> BlueMatt: not in Zurich
113 2015-11-13T09:04:52  <CodeShark_> there are counties in california with a bigger area than switzerland :p
114 2015-11-13T09:05:02  *** mably has quit IRC
115 2015-11-13T09:05:35  *** Arnavion has joined #bitcoin-core-dev
116 2015-11-13T09:06:23  <CodeShark_> or at least one county
117 2015-11-13T09:06:32  <CodeShark_> san bernadino county is larger than switzerland by area
118 2015-11-13T09:08:46  <CodeShark_> incidentally, san francisco is the smallest county in california by area
119 2015-11-13T09:11:31  <GitHub86> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/38ed190eefcc...24c4841d1686
120 2015-11-13T09:11:31  <GitHub86> bitcoin/master 01afa80 Wladimir J. van der Laan: doc: Remove mention of pulltester from README.md...
121 2015-11-13T09:11:32  <GitHub86> bitcoin/master 24c4841 Wladimir J. van der Laan: Merge pull request #6998...
122 2015-11-13T09:11:41  <GitHub153> [bitcoin] laanwj closed pull request #6998: doc: Remove mention of pulltester from README.md (master...2015_11_readme_pull_pulltester) https://github.com/bitcoin/bitcoin/pull/6998
123 2015-11-13T09:12:35  *** pmienk has joined #bitcoin-core-dev
124 2015-11-13T09:35:39  *** jl2012 has quit IRC
125 2015-11-13T09:36:08  *** jl2012 has joined #bitcoin-core-dev
126 2015-11-13T09:45:21  *** rubensayshi has joined #bitcoin-core-dev
127 2015-11-13T09:51:26  *** CodeShark_ has quit IRC
128 2015-11-13T10:35:33  *** isis has quit IRC
129 2015-11-13T10:45:04  *** CodeShark_ has joined #bitcoin-core-dev
130 2015-11-13T10:45:12  *** CodeShark_ has quit IRC
131 2015-11-13T10:58:29  *** isis has joined #bitcoin-core-dev
132 2015-11-13T11:03:24  <GitHub28> [bitcoin] laanwj opened pull request #7003: doc: Add non-style-related development guidelines (master...2015_11_development_guidelines) https://github.com/bitcoin/bitcoin/pull/7003
133 2015-11-13T11:03:31  <fanquake> Looking forward ot being able to attend one of the meetups some day
134 2015-11-13T11:03:43  <wumpus> where are you based fanquake?
135 2015-11-13T11:03:53  <fanquake> Western Australia
136 2015-11-13T11:04:03  <fanquake> To far away from everywhere
137 2015-11-13T11:04:14  <wumpus> whoa, you could say so :)
138 2015-11-13T11:05:04  <wumpus> development is pretty distributed over the world as it is, that's nice
139 2015-11-13T11:05:08  <fanquake> Yea, even inside West Aus, I used to live on a farm 100km from the nearest city.
140 2015-11-13T11:05:30  <fanquake> So building precision agriculture software atm.
141 2015-11-13T11:05:56  <fanquake> Only place we wouldn't have a developer might be in asia?
142 2015-11-13T11:06:06  <jonasschnelli> BlueMatt: yes. I need to get my gpg key signed... will try to get some signatures within the next days.
143 2015-11-13T11:06:14  <wumpus> cool. I think agriculture is one place where software can still change a lot
144 2015-11-13T11:06:52  <wumpus> did you see my PM about gpg keys jonasschnelli?
145 2015-11-13T11:06:53  <fanquake> absolutely, the adoption cycle is quite slow also, lots of oppoutunity for innovation.
146 2015-11-13T11:08:05  <wumpus> no I don't think we have anyone in Asia, maybe some drive-by contributores  but no one who stuck around
147 2015-11-13T11:34:55  <GitHub106> [bitcoin] jonasschnelli opened pull request #7004: update jonasschnellis gpg key (master...2015/11/signing_key_jonasschnelli) https://github.com/bitcoin/bitcoin/pull/7004
148 2015-11-13T11:36:53  <sdaftuar> \
149 2015-11-13T11:40:02  *** d_t has quit IRC
150 2015-11-13T11:41:14  <Luke-Jr> jonasschnelli: why a new key? :/
151 2015-11-13T11:41:29  <michagogo> Hm, the signer failed on 0.11.2
152 2015-11-13T11:41:46  <wumpus> michagogo: what error?
153 2015-11-13T11:42:50  <michagogo> tar: signature/osx: Cannot read: Is a directory
154 2015-11-13T11:43:14  <michagogo> Maybe it's because I just signed 0.10.4
155 2015-11-13T11:43:41  <wumpus> weird - are you using the commands from the right build process, and descriptors from the right version?
156 2015-11-13T11:43:42  <michagogo> I rm'd the flag file that tells my script it can reuse the existing target for the mac signer, rerunning now
157 2015-11-13T11:44:00  <michagogo> I should be -- I have a script that does all that
158 2015-11-13T11:44:15  <michagogo> (checks out the tag, etc)
159 2015-11-13T11:44:27  <michagogo> And yeah, I have separate versions for 0.10 and 0.11
160 2015-11-13T11:44:47  <Luke-Jr> sdaftuar: where is the debug file for the test?
161 2015-11-13T11:44:48  <michagogo> (I probably could have made it one script, but I was lazy/in a hurry when I made it)
162 2015-11-13T11:45:11  <michagogo> Anyway, it's running again now with a fresh vm
163 2015-11-13T11:46:05  <wumpus> yes I have a series of scripts for those things too, lots of subtle differenes
164 2015-11-13T11:48:09  <michagogo> Hm, wt
165 2015-11-13T11:48:10  <michagogo> f
166 2015-11-13T11:48:23  <michagogo> http://paste.ubuntu.com/13246889/
167 2015-11-13T11:48:47  <michagogo> OH
168 2015-11-13T11:48:48  <michagogo> wait
169 2015-11-13T11:48:54  * michagogo check something
170 2015-11-13T11:48:56  <michagogo> checks*
171 2015-11-13T11:49:30  * wumpus blames his lack of ruby chops for, instead of attacking gitian directly, writing tons of wrapper scripts around it :-)
172 2015-11-13T11:49:59  <michagogo> Dammit
173 2015-11-13T11:50:12  <michagogo> The 0.10 build clobbered the 0.11 unsigned package
174 2015-11-13T11:50:28  <michagogo> Got a copy? (don't worry, I'll check the hash)
175 2015-11-13T11:50:36  *** d_t has joined #bitcoin-core-dev
176 2015-11-13T11:51:02  <wumpus> hm not sure I don't have it anymore, which one do you need mac or win or both?
177 2015-11-13T11:51:16  <michagogo> Mac
178 2015-11-13T11:51:35  <michagogo> (we don't do detached win signing for 0.10, thankfully)
179 2015-11-13T11:51:49  <michagogo> fanquake: around?
180 2015-11-13T11:52:01  <michagogo> Do you have a copy of the 0.11.2 Mac unsigned tarball?
181 2015-11-13T11:52:55  <michagogo> I wish the way gitian did inputs didn't force us to have unversioned filenames
182 2015-11-13T11:54:03  <wumpus> agreed
183 2015-11-13T11:59:16  *** d_t has quit IRC
184 2015-11-13T11:59:32  <Luke-Jr> michagogo: eh, they're not unversioned
185 2015-11-13T11:59:35  <Luke-Jr> http://luke.dashjr.org/programs/bitcoin/files/bitcoind/0.11.2/
186 2015-11-13T11:59:56  <wumpus> would be nice to fix some long-running complaints about how gitian handles things some time (also the "output files are nuked" on next run), if I wasn't already completely overloaded
187 2015-11-13T12:00:12  <wumpus> Luke-Jr: not al, but the intermediate files for signing have to be
188 2015-11-13T12:00:31  <michagogo> bitcoin-osx-unsigned.tar.gz
189 2015-11-13T12:00:48  <Luke-Jr> the file gitian generates is bitcoin-0.11.2-osx-unsigned.tar.gz
190 2015-11-13T12:01:29  <michagogo> The input is unversioned
191 2015-11-13T12:01:38  <wumpus> Luke-Jr: you're right
192 2015-11-13T12:01:42  <michagogo> Maybe I could move the unsigned bundle,
193 2015-11-13T12:01:53  <wumpus> but to copy it into inputs, it needs to be made unversions
194 2015-11-13T12:02:01  <michagogo> And then copy it to the generic name prebuild
195 2015-11-13T12:02:19  <michagogo> That would probably work, actually
196 2015-11-13T12:02:50  <wumpus> 0.11.2 binaries are live: https://bitcoin.org/bin/bitcoin-core-0.11.2/
197 2015-11-13T12:03:43  <Luke-Jr> wumpus: ! but we don't have 3 sigs yet
198 2015-11-13T12:03:57  <Luke-Jr> (on the signed bins, that is)
199 2015-11-13T12:04:12  <wumpus> OK, won't do the official announcement (and merge it on the site) yet, then
200 2015-11-13T12:04:19  <michagogo> Luke-Jr: we will momentarily
201 2015-11-13T12:06:08  <michagogo> (Thanks, grabbed the unsigned bundle)
202 2015-11-13T12:07:00  <michagogo> wumpus: you could kick off the Travis rebuild on the PR for the site
203 2015-11-13T12:09:59  <wumpus> still have to fill in the torrent magnet link anyhow
204 2015-11-13T12:10:19  <michagogo> wumpus: can do that after
205 2015-11-13T12:10:23  <michagogo> Uh, wtf?
206 2015-11-13T12:10:42  <michagogo> gzip: stdin: not in gzip formal
207 2015-11-13T12:10:49  <michagogo> Format
208 2015-11-13T12:10:59  * michagogo checks something
209 2015-11-13T12:11:54  <michagogo> Hmm.
210 2015-11-13T12:12:47  <michagogo> Oh, that was me being stupid
211 2015-11-13T12:12:52  * michagogo sighs
212 2015-11-13T12:13:08  <michagogo> I took the dmg instead of the tarvall
213 2015-11-13T12:13:49  <midnightmagic> :-/
214 2015-11-13T12:14:01  <midnightmagic> my gitian sigs aren't matching up anymore.
215 2015-11-13T12:14:12  <midnightmagic> but I have to go to bed, so I'll debug it tomorrow.
216 2015-11-13T12:14:28  <michagogo> Okay, THIS time it should work
217 2015-11-13T12:22:51  * michagogo points at the PR page
218 2015-11-13T12:27:47  <GitHub22> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/24c4841d1686...d2e987aa1929
219 2015-11-13T12:27:48  <GitHub22> bitcoin/master b27e81f MarcoFalke: [net] Cleanup maxuploadtarget...
220 2015-11-13T12:27:48  <GitHub22> bitcoin/master 9c3ee3b MarcoFalke: [doc] Add -maxuploadtarget release notes
221 2015-11-13T12:27:49  <GitHub22> bitcoin/master d2e987a Wladimir J. van der Laan: Merge pull request #6958...
222 2015-11-13T12:27:52  <GitHub8> [bitcoin] laanwj closed pull request #6958: [trivial] Cleanup maxuploadtarget (doc & log) (master...MarcoFalke-2015-maxupload) https://github.com/bitcoin/bitcoin/pull/6958
223 2015-11-13T12:37:18  *** jtimon has joined #bitcoin-core-dev
224 2015-11-13T12:40:27  *** ParadoxSpiral has joined #bitcoin-core-dev
225 2015-11-13T13:12:38  <michagogo> Merged \o/
226 2015-11-13T13:14:25  <wumpus> yes, sent announcement mail
227 2015-11-13T13:16:24  <michagogo> https://www.reddit.com/r/Bitcoin/comments/3snpg9/bitcoin_core_version_0112_released_bringing_the/ as well
228 2015-11-13T13:16:44  <michagogo> Erm, oops, forgot the website doesn't update in realtime
229 2015-11-13T13:16:54  <wumpus> takes a few minutes at most
230 2015-11-13T13:23:59  *** Thireus has quit IRC
231 2015-11-13T13:24:34  <wumpus> site is updated
232 2015-11-13T13:27:43  <michagogo> Are you opped in #bitcoin?
233 2015-11-13T13:27:58  <michagogo> (for the topic)
234 2015-11-13T13:37:56  <michagogo> wumpus: hm, my torrent client is telling me the demonii tracker doesn't exist
235 2015-11-13T13:40:25  *** sipa_ is now known as sipa
236 2015-11-13T13:42:57  <wumpus> "Seeding to 0 of 0 peers" hmm maybe the torrent tracker needs some time to spin up too
237 2015-11-13T13:47:30  <wumpus> and all the trackers except tracker.coppersurfer.tk give me "Connection failed"
238 2015-11-13T13:50:53  *** sipa has quit IRC
239 2015-11-13T13:50:53  *** sipa has joined #bitcoin-core-dev
240 2015-11-13T13:52:22  <fanquake> wumpus Who should be adding their key to trusted-keys?
241 2015-11-13T13:52:43  <wumpus> fanquake: people that merge things
242 2015-11-13T13:53:37  <fanquake> Is Jonass being given GH merge access?
243 2015-11-13T13:53:42  <wumpus> yep
244 2015-11-13T13:54:30  <wumpus> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2015-November/011728.html
245 2015-11-13T14:29:16  *** jtimon has quit IRC
246 2015-11-13T14:30:56  *** Guyver2 has joined #bitcoin-core-dev
247 2015-11-13T14:40:37  <jonasschnelli> [12:41:14]  <Luke-Jr>	jonasschnelli: why a new key? :/        <-- the new key is not really new, It's just the one that I use for bitcoin-dev posts, etc. The "old" key is used for non-bitcoin software-projects (and sadly, i have used it for gitian signatures)
248 2015-11-13T14:47:43  *** Thireus has joined #bitcoin-core-dev
249 2015-11-13T15:11:39  <sdaftuar> Luke-Jr: around?
250 2015-11-13T15:16:29  *** Thireus has quit IRC
251 2015-11-13T15:21:58  *** Thireus has joined #bitcoin-core-dev
252 2015-11-13T15:25:12  *** zooko has joined #bitcoin-core-dev
253 2015-11-13T15:25:33  *** d_t has joined #bitcoin-core-dev
254 2015-11-13T15:33:15  <GitHub147> [bitcoin] jgarzik opened pull request #7005: Add MAINTAINERS file, a user guide to code subsystems (master...2015_maintainer) https://github.com/bitcoin/bitcoin/pull/7005
255 2015-11-13T15:34:19  *** treehug88 has joined #bitcoin-core-dev
256 2015-11-13T15:38:38  *** Thireus has quit IRC
257 2015-11-13T15:38:46  <GitHub21> [bitcoin] jonasschnelli opened pull request #7006: [Qt] add startup option to reset Qt settings (master...2015/11/qt_resetsettings) https://github.com/bitcoin/bitcoin/pull/7006
258 2015-11-13T15:52:09  <GitHub104> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d2e987aa1929...4f09b77c7fa5
259 2015-11-13T15:52:10  <GitHub104> bitcoin/master 1d84107 Pieter Wuille: Squashed 'src/secp256k1/' changes from 22f60a6..2bfb82b...
260 2015-11-13T15:52:10  <GitHub104> bitcoin/master 9e475d5 Pieter Wuille: Update libsecp256k1
261 2015-11-13T15:52:11  <GitHub104> bitcoin/master 48edf57 Pieter Wuille: Update key.cpp to new secp256k1 API
262 2015-11-13T15:52:14  <GitHub8> [bitcoin] sipa closed pull request #6983: Update libsecp256k1 (master...secp256k1new) https://github.com/bitcoin/bitcoin/pull/6983
263 2015-11-13T15:52:29  <GitHub75> [bitcoin] morcos opened pull request #7007: Fix bug in unit mempool_tests unit test (master...unitTestBugFix) https://github.com/bitcoin/bitcoin/pull/7007
264 2015-11-13T15:54:56  *** fanquake has quit IRC
265 2015-11-13T16:06:59  <GitHub121> [bitcoin] morcos opened pull request #7008: Lower bound priority (master...lowerBoundPriority) https://github.com/bitcoin/bitcoin/pull/7008
266 2015-11-13T16:08:18  <morcos> Luke-Jr: When you get a chance, please see #7008.  I think you had indicated that if at least originally in chain inputs age, that would be close enough.  Upon further reflection, I think this is a much better compromise than trying to put through the full #6357 dynamic priority calculation.  (it's basically a small subset)
267 2015-11-13T16:11:19  <wumpus> jonasschnelli: you can set the 'GUI' label yourself now :) say on https://github.com/bitcoin/bitcoin/pull/7006
268 2015-11-13T16:11:52  <jonasschnelli> wumpus: hah. Right. I missed that. Done!
269 2015-11-13T16:21:23  <btcdrak> sipa: wonderful!
270 2015-11-13T16:46:41  *** Thireus has joined #bitcoin-core-dev
271 2015-11-13T17:04:19  *** rubensayshi has quit IRC
272 2015-11-13T17:22:35  *** Thireus has quit IRC
273 2015-11-13T17:37:58  <GitHub165> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4f09b77c7fa5...d3565604e3d9
274 2015-11-13T17:37:58  <GitHub165> bitcoin/master a78e6ea Alex Morcos: Fix bug in mempool_tests unit test
275 2015-11-13T17:37:59  <GitHub165> bitcoin/master d356560 Wladimir J. van der Laan: Merge pull request #7007...
276 2015-11-13T17:38:08  <GitHub155> [bitcoin] laanwj closed pull request #7007: Fix bug in mempool_tests unit test (master...unitTestBugFix) https://github.com/bitcoin/bitcoin/pull/7007
277 2015-11-13T17:55:53  *** zooko has quit IRC
278 2015-11-13T18:24:49  *** zooko has joined #bitcoin-core-dev
279 2015-11-13T19:08:32  <Luke-Jr> sdaftuar:
280 2015-11-13T19:09:49  <sdaftuar> Luke-Jr: i wanted to follow up on the issue you reported with that bip65-cltv-p2p test this morning.  i updated the issue with my observations
281 2015-11-13T19:10:33  <Luke-Jr> k, catching up on emails now, so I haven't seen it yet
282 2015-11-13T19:15:53  *** jtimon has joined #bitcoin-core-dev
283 2015-11-13T19:21:02  <Luke-Jr> sdaftuar: I don't have any env vars set related to Bitcoin
284 2015-11-13T19:21:28  <sdaftuar> odd.  any ideas why it's running the wrong binary?
285 2015-11-13T19:21:42  <Luke-Jr> maybe because the build never puts bitcoind in the checkout dir..
286 2015-11-13T19:21:52  <Luke-Jr> why is that the default?
287 2015-11-13T19:22:10  <sdaftuar> er, i think i meant checkout-dir/src
288 2015-11-13T19:22:23  <sdaftuar> anyway not sure, that's how all the rpc tests have ever worked as far as i know
289 2015-11-13T19:22:43  <Luke-Jr> well, setting BITCOIND to $PWD/src/bitcoind fixes it
290 2015-11-13T19:23:12  <sdaftuar> ok cool
291 2015-11-13T19:23:45  <sdaftuar> oh -- i think you're supposed to run the rpc-tests from the rpc-tests directory.  does that also fix it?
292 2015-11-13T19:25:42  * Luke-Jr waits for his new build to finish to test that
293 2015-11-13T19:26:27  *** zooko has quit IRC
294 2015-11-13T19:32:36  <GitHub138> [bitcoin] gmaxwell pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/dbd2c135ddb96bdc3a4e870c2371cb1fac227135
295 2015-11-13T19:32:36  <GitHub138> bitcoin/master dbd2c13 Gregory Maxwell: Merge pull request #6990...
296 2015-11-13T19:32:43  <GitHub117> [bitcoin] gmaxwell closed pull request #6990: http: speed up shutdown (master...2015_11_threadexit) https://github.com/bitcoin/bitcoin/pull/6990
297 2015-11-13T19:37:57  *** d_t has quit IRC
298 2015-11-13T19:40:54  *** d_t has joined #bitcoin-core-dev
299 2015-11-13T19:43:11  <gmaxwell> Is the torcontrol port password basically ever empty?
300 2015-11-13T20:02:00  <morcos> I asked this in bitcion-mining but got no response.  I'm 95% sure this couldn't have been caused by my changes to CreateNewBlock, but of the 20 testnet blocks I mined, one was invalid
301 2015-11-13T20:02:15  <morcos> ERROR: CheckBlock(): hashMerkleRoot mismatch
302 2015-11-13T20:02:28  <morcos> Anybody have any idea why that might have happened?
303 2015-11-13T20:02:55  <morcos> It was invalid after being submitted by the miner, not in the TestBlockValidity from CreateNewBlock
304 2015-11-13T20:02:55  <gmaxwell> eerk
305 2015-11-13T20:03:27  <morcos> yeah thats kind of my response
306 2015-11-13T20:03:29  <gmaxwell> Not a known behavior. Possibly that the transmission from the miner got truncated?
307 2015-11-13T20:03:38  <gmaxwell> phantomcircuit: seen anything like that? ^
308 2015-11-13T20:43:11  *** zooko has joined #bitcoin-core-dev
309 2015-11-13T20:46:22  *** Thireus has joined #bitcoin-core-dev
310 2015-11-13T20:55:24  <GitHub157> [bitcoin] petertodd opened pull request #7010: Fix fundrawtransaction handling of includeWatching (master...2015-11-fix-fundrawtransaction-bugs) https://github.com/bitcoin/bitcoin/pull/7010
311 2015-11-13T21:16:32  *** PaulCapestany has quit IRC
312 2015-11-13T21:17:12  *** treehug88 has quit IRC
313 2015-11-13T21:20:14  *** Guyver2 has quit IRC
314 2015-11-13T21:24:21  *** PaulCapestany has joined #bitcoin-core-dev
315 2015-11-13T21:25:39  <phantomcircuit> morcos, what where you using to mine?
316 2015-11-13T21:25:54  <morcos> phantomcircuit: antminer s7
317 2015-11-13T21:26:19  <kanzure> BlueMatt: strange that fundrawtransaction with watchonlys/includewatching has been so difficult to get correct
318 2015-11-13T21:26:34  <kanzure> BlueMatt: maybe we're trying to stuff too much into that function
319 2015-11-13T21:27:05  <phantomcircuit> morcos, what stratum software?
320 2015-11-13T21:27:22  <phantomcircuit> unless you were running bfgminer w/ getblocktemplate you need something else in the middle
321 2015-11-13T21:27:28  <BlueMatt> kanzure: hmm? the latest bugs have been in the rpc wrapper for the function
322 2015-11-13T21:27:30  <morcos> phantomcircuit: i was using the installed cgminer 4.8 to connect directly to bitcoind
323 2015-11-13T21:27:35  <BlueMatt> kanzure: the actual function was rather doable
324 2015-11-13T21:27:48  <kanzure> BlueMatt: well, ok. fair. comment rescinded.
325 2015-11-13T21:27:53  <morcos> it seems to support getblocktemplate
326 2015-11-13T21:27:59  <BlueMatt> kanzure: and, really, there's only been one actual bug? (the assume-if-argument-bool-is-true)
327 2015-11-13T21:28:14  <phantomcircuit> morcos, i doubt very much that cgminer correctly implements getblocktemplate
328 2015-11-13T21:28:29  <kanzure> BlueMatt: the previous implementation had some issues too. but your version fixed those.
329 2015-11-13T21:28:49  <kanzure> BlueMatt: but yes your point about the rpc wrapper is sufficient to explain this.
330 2015-11-13T21:28:52  <gmaxwell> phantomcircuit: would be useful to know how it doesn't assuming it doesn't.
331 2015-11-13T21:29:10  <morcos> phantomcircuit: ok...  maybe i'll stick some stratum software in the middle then and try that instead.  what would you recommend
332 2015-11-13T21:29:15  <gmaxwell> phantomcircuit: not just cgminer but whatever is on the miner, dunno about s7 but prior ones have all been really old versions.
333 2015-11-13T21:29:19  <phantomcircuit> morcos, need a tcpdump of the rpc calls to diagnose
334 2015-11-13T21:30:19  <phantomcircuit> morcos, eloipool
335 2015-11-13T21:30:31  *** PaulCapestany has quit IRC
336 2015-11-13T21:30:32  <BlueMatt> kanzure: yea, the previous version did, but thats what code review is for :) (it forces us to not implement hacky things and to do it The Right Way (tm) so that we fix subtle bugs)
337 2015-11-13T21:30:50  <morcos> phantomcircuit: i was trying to play around with that, and the debugging from cgminer is either a flood or nothing useful.   now i'm hacking up bitcoind to try to just dump any submitted blocks anyway, so if it happens again i can manually inspect the block
338 2015-11-13T21:31:24  <morcos> for what its worth, it mostly seems to mine fine
339 2015-11-13T21:31:30  <Luke-Jr> morcos: cgminer's GBT "support" is /probably/ broken
340 2015-11-13T21:31:32  <gmaxwell> morcos: might be a worthwhile thing to just support as an option. savesubmitblocks=1
341 2015-11-13T21:32:06  <Luke-Jr> morcos: I'd suggest BFGMiner over Eloipool FWIW
342 2015-11-13T21:32:08  <phantomcircuit> morcos, to debug i'd also need the block templates though, so a tcpdump would be best
343 2015-11-13T21:32:09  <morcos> gmaxwell: ha ha, well i'll let someone else write that, my version has already coredumped a few times
344 2015-11-13T21:32:46  *** PaulCapestany has joined #bitcoin-core-dev
345 2015-11-13T21:33:13  <morcos> phantomcircuit: ok, well its not happening often enough for that right now.. maybe i'll hack up something to decrease the difficulty or do somehting on regtest, but at this point its all going to have to wait for next week
346 2015-11-13T21:33:41  <morcos> thanks for your help... i'll ping you when i have more info.   also.  stop orphaning my testnet blocks!
347 2015-11-13T21:34:08  <phantomcircuit> morcos, ha
348 2015-11-13T21:34:36  <phantomcircuit> an excellent demonstration of what low block intervals do to centralization :P
349 2015-11-13T21:39:05  *** PaulCapestany has quit IRC
350 2015-11-13T21:39:44  <GitHub38> [bitcoin] petertodd opened pull request #7011: Add mediantime to getblockchaininfo (master...2015-11-add-mediantime-to-getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/7011
351 2015-11-13T21:40:56  *** PaulCapestany has joined #bitcoin-core-dev
352 2015-11-13T21:43:25  *** skyraider has joined #bitcoin-core-dev
353 2015-11-13T21:43:55  *** bsm1175321 has quit IRC
354 2015-11-13T21:44:11  *** bsm1175321 has joined #bitcoin-core-dev
355 2015-11-13T21:50:32  *** molly has quit IRC
356 2015-11-13T21:52:03  *** molly has joined #bitcoin-core-dev
357 2015-11-13T21:55:15  *** paveljanik has quit IRC
358 2015-11-13T22:09:07  <morcos> Luke-Jr: any chance you got to look at 7008?
359 2015-11-13T22:09:45  <morcos> I'm hoping you are ok with closing the dynamicPriority pull (6357) and focusing attention on something more likely to be ok with everyone
360 2015-11-13T22:10:16  <Luke-Jr> morcos: not planning to, as I strongly prefer #6357
361 2015-11-13T22:10:33  <phantomcircuit> CodeShark, can you comment on issue 7012 ?
362 2015-11-13T22:10:50  <morcos> Luke-Jr: hmm, ok then maybe i misunderstood you the other day
363 2015-11-13T22:11:16  <Luke-Jr> morcos: I may have said something suggesting this, before I understood 6357 to be inexpensive
364 2015-11-13T22:11:41  <morcos> I thought you did not like using starting priority as an approximation, but that you thought priority where aging did happen but only affected originally confirmed inputs was ok
365 2015-11-13T22:12:09  <Luke-Jr> morcos: it's okay, if the alternative is expensive.
366 2015-11-13T22:12:21  <Luke-Jr> but if it's not expensive, there is no reason to cheat on it
367 2015-11-13T22:12:46  <morcos> Luke-Jr: well fundamentally part of my problem is just merge conflicts
368 2015-11-13T22:13:03  <morcos> I want to fix the issue you pointed out with sigops having a default value
369 2015-11-13T22:13:22  <morcos> but both priority pulls and sdaftuars mempool reorg pull all change the signature of TxMemPoolEntry constructor
370 2015-11-13T22:13:26  <Luke-Jr> morcos: my plan right now, is to deep-review 6357 and write tests (unless you get to that first)
371 2015-11-13T22:13:48  <morcos> 6357 is tested by having the priority recalced in mempool.check
372 2015-11-13T22:14:02  <morcos> but yes more tests couldn't hurt
373 2015-11-13T22:14:32  <Luke-Jr> morcos: I mean unit tests
374 2015-11-13T22:14:36  <Luke-Jr> something Travis will detect breaking
375 2015-11-13T22:15:05  <morcos> If I rebased 6357 on top of 7008, would you be willing to get 7008 merged.  its really a precursor anyway, and the change to the constructor is the same.
376 2015-11-13T22:15:49  <morcos> i'm going away at the end of next week, and i need to get all these merge conflicts sorted so we can get the createnewblock pull merged
377 2015-11-13T22:16:43  <morcos> i'm perfectly happy with 6357, but lets not let the perfect be the enemy of the good..  getting 7008 in at least lets us do everything else.  if we also get 6357, then great. but we haven't held up progress
378 2015-11-13T22:21:10  <GitHub74> [bitcoin] petertodd opened pull request #7013: Remove LOCK(cs_main) from decodescript (master...2015-11-remove-cs-main-from-decodescript) https://github.com/bitcoin/bitcoin/pull/7013
379 2015-11-13T22:34:29  <Luke-Jr> morcos: I'm not willing to ACK the createnewblock pull until 6357 is merged, so I'm not sure what the point is.
380 2015-11-13T22:34:56  <Luke-Jr> rebasing 6357 on top of 7008 may be better just structually though
381 2015-11-13T22:35:43  *** bsm1175321 has quit IRC
382 2015-11-13T22:42:30  <morcos> Luke-Jr: I'm not sure whether or not 6357 will get merged.  If not, the original plan was to put createnewblock pull back to the way I first had it.  so it still calls the CCoinsViewCache GetPriority function which is right but slow.
383 2015-11-13T22:42:55  <morcos> this will preserve the ability to do old policy, but limit a significant part of the speed up to code that does not use that policy
384 2015-11-13T22:44:19  <morcos> to be clear, i'm happy for you or anyone else to appropriate the pulls and do the right thing, but i won't be around to make the changes past the first 4 days of next week
385 2015-11-13T22:44:39  <morcos> so i'd like to leave things in the most likely to be merged state before that point.
386 2015-11-13T22:45:45  <Luke-Jr> morcos: maybe push branches for each possibility, and I'll do what I can to keep things moving?
387 2015-11-13T22:47:02  *** PaulCapestany has quit IRC
388 2015-11-13T22:48:46  *** PaulCapestany has joined #bitcoin-core-dev
389 2015-11-13T22:55:28  *** PaulCapestany has quit IRC
390 2015-11-13T22:56:06  *** PaulCapestany has joined #bitcoin-core-dev
391 2015-11-13T22:56:33  *** zooko has quit IRC
392 2015-11-13T23:07:05  *** d_t has quit IRC
393 2015-11-13T23:07:29  *** bitdevsnyc has joined #bitcoin-core-dev
394 2015-11-13T23:08:21  *** d_t has joined #bitcoin-core-dev
395 2015-11-13T23:46:45  *** bitdevsnyc has quit IRC
396 2015-11-13T23:47:27  *** d_t has quit IRC
397 2015-11-13T23:52:02  *** d_t has joined #bitcoin-core-dev
398 2015-11-13T23:52:18  *** skyraider has quit IRC