1 2015-12-04T00:01:13  <GitHub68> [bitcoin] jameshilliard opened pull request #7167: Move TestBlockValidity into a background thread (master...TBVBackground) https://github.com/bitcoin/bitcoin/pull/7167
  2 2015-12-04T00:36:19  <phantomcircuit> so we should probably reconsider a block that's marked invalid once for every valid header on top of it (since we cant tell if the blocks on top are invalid)
  3 2015-12-04T00:36:30  <phantomcircuit> that might help with the "my system is shitty and randomly flips bits" people
  4 2015-12-04T00:41:02  <gmaxwell> I'm not really comfortable with people running wallets on such systems; not at least until we add a fair bit more protection.
  5 2015-12-04T00:44:47  <tulip> maybe just run CheckBlock in a loop until the bit happens to flip back.
  6 2015-12-04T01:04:51  <phantomcircuit> gmaxwell, fair
  7 2015-12-04T01:05:02  <phantomcircuit> tulip, har
  8 2015-12-04T01:20:17  *** Ylbam has quit IRC
  9 2015-12-04T01:23:04  *** Tera2342 has quit IRC
 10 2015-12-04T01:29:29  *** tulip has quit IRC
 11 2015-12-04T01:35:06  *** tulip- has joined #bitcoin-core-dev
 12 2015-12-04T01:36:42  *** tulip- has quit IRC
 13 2015-12-04T01:37:01  *** tulip- has joined #bitcoin-core-dev
 14 2015-12-04T01:38:10  *** tulip- has quit IRC
 15 2015-12-04T01:38:10  *** tulip- has joined #bitcoin-core-dev
 16 2015-12-04T01:39:50  *** tulp has joined #bitcoin-core-dev
 17 2015-12-04T01:51:14  *** belcher has quit IRC
 18 2015-12-04T01:57:33  *** tulp has quit IRC
 19 2015-12-04T02:08:22  *** tulp has joined #bitcoin-core-dev
 20 2015-12-04T02:08:31  *** tulp has left #bitcoin-core-dev
 21 2015-12-04T02:08:36  *** tulp has joined #bitcoin-core-dev
 22 2015-12-04T02:30:28  *** tulp is now known as tulip
 23 2015-12-04T03:05:35  *** CodeShark_ has joined #bitcoin-core-dev
 24 2015-12-04T03:15:34  *** zookolaptop has quit IRC
 25 2015-12-04T03:36:35  *** aj has quit IRC
 26 2015-12-04T03:43:59  *** aj has joined #bitcoin-core-dev
 27 2015-12-04T04:14:56  <GitHub149> [bitcoin] tadasvaranavicius opened pull request #7168: Fix socket recv buffer bug (master...fix_network_buffer_bug) https://github.com/bitcoin/bitcoin/pull/7168
 28 2015-12-04T04:23:11  *** droark has joined #bitcoin-core-dev
 29 2015-12-04T04:35:53  <GitHub179> [bitcoin] tadasvaranavicius closed pull request #7168: Fix socket recv buffer bug (master...fix_network_buffer_bug) https://github.com/bitcoin/bitcoin/pull/7168
 30 2015-12-04T04:48:41  *** nkuttler has quit IRC
 31 2015-12-04T04:49:51  *** nkuttler has joined #bitcoin-core-dev
 32 2015-12-04T05:02:28  *** droark has quit IRC
 33 2015-12-04T05:06:04  *** pmienk has quit IRC
 34 2015-12-04T05:08:27  *** roasbeef has joined #bitcoin-core-dev
 35 2015-12-04T05:20:41  *** pmienk has joined #bitcoin-core-dev
 36 2015-12-04T05:24:31  *** therealnanotube is now known as nanotube
 37 2015-12-04T05:28:34  *** instagibbs has quit IRC
 38 2015-12-04T05:32:32  *** raedah has joined #bitcoin-core-dev
 39 2015-12-04T05:41:30  *** instagibbs has joined #bitcoin-core-dev
 40 2015-12-04T06:16:14  *** raedah has quit IRC
 41 2015-12-04T06:20:35  *** moley has joined #bitcoin-core-dev
 42 2015-12-04T06:22:31  *** arowser has quit IRC
 43 2015-12-04T06:23:19  *** arowser has joined #bitcoin-core-dev
 44 2015-12-04T06:23:39  *** moli has quit IRC
 45 2015-12-04T06:32:35  *** dcousens has joined #bitcoin-core-dev
 46 2015-12-04T06:33:27  *** instagibbs has quit IRC
 47 2015-12-04T06:34:01  <dcousens> gmaxwell: rpc is still slow as *insert crude culturally relevant derogitory comment here*
 48 2015-12-04T06:34:25  <dcousens> at least, in terms of parsing the whole blockchain over it :P
 49 2015-12-04T06:38:36  *** instagibbs has joined #bitcoin-core-dev
 50 2015-12-04T06:43:05  *** raedah has joined #bitcoin-core-dev
 51 2015-12-04T06:54:26  *** raedah has quit IRC
 52 2015-12-04T06:57:45  *** droark has joined #bitcoin-core-dev
 53 2015-12-04T07:02:23  *** dcousens has quit IRC
 54 2015-12-04T07:17:21  <GitHub136> [bitcoin] paveljanik opened pull request #7169: [Trivial] Disable compiler warnings about unused functions (master...20151204_scheduler_tests_warning) https://github.com/bitcoin/bitcoin/pull/7169
 55 2015-12-04T07:28:58  *** paveljanik has joined #bitcoin-core-dev
 56 2015-12-04T07:28:58  *** paveljanik has joined #bitcoin-core-dev
 57 2015-12-04T08:06:51  *** davec has quit IRC
 58 2015-12-04T08:12:34  *** davec has joined #bitcoin-core-dev
 59 2015-12-04T08:43:43  <GitHub164> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5548d9cb11c8...792259278e4f
 60 2015-12-04T08:43:43  <GitHub164> bitcoin/master 6aadc75 Gregory Maxwell: Disconnect on mempool requests from peers when over the upload limit....
 61 2015-12-04T08:43:44  <GitHub164> bitcoin/master 7922592 Wladimir J. van der Laan: Merge pull request #7166...
 62 2015-12-04T08:43:47  <GitHub147> [bitcoin] laanwj closed pull request #7166: Disconnect on mempool requests from peers when over the upload limit. (master...mempool_p2p_when_overlimit) https://github.com/bitcoin/bitcoin/pull/7166
 63 2015-12-04T08:45:02  <GitHub63> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/6ba25d28868146d5d6dbd671881db3a58f549567
 64 2015-12-04T08:45:03  <GitHub63> bitcoin/0.12 6ba25d2 Gregory Maxwell: Disconnect on mempool requests from peers when over the upload limit....
 65 2015-12-04T08:45:26  *** paveljanik has quit IRC
 66 2015-12-04T08:51:11  *** arowser has quit IRC
 67 2015-12-04T08:51:24  *** arowser has joined #bitcoin-core-dev
 68 2015-12-04T08:57:02  *** Ylbam has joined #bitcoin-core-dev
 69 2015-12-04T08:58:46  *** Amnez777 has quit IRC
 70 2015-12-04T08:58:46  *** Amnez777 has joined #bitcoin-core-dev
 71 2015-12-04T09:42:49  <jonasschnelli> wumpus: the message header size is always 24 bytes, correct?
 72 2015-12-04T09:44:04  <wumpus> jonasschnelli: I don't know the exact value by heart, let me see
 73 2015-12-04T09:44:19  <jonasschnelli> hmm... another magic number.
 74 2015-12-04T09:44:50  <jonasschnelli> i think i can use CMessageHeader::COMMAND_SIZE, etc.
 75 2015-12-04T09:44:55  <wumpus> CMessageHeader::HEADER_SIZE
 76 2015-12-04T09:45:12  <jonasschnelli> Right! Thanks
 77 2015-12-04T09:45:18  <wumpus> and yes, should be 24
 78 2015-12-04T09:48:50  <wumpus> jonasschnelli: did you forget it for  mapSendBytesPerCmd[std::string(pszCommand)] += nSize; ?
 79 2015-12-04T09:50:32  <jonasschnelli> wumpus: Thanks! right. there it's also required because of nSize = ssSend.size() - CMessageHeader::HEADER_SIZE
 80 2015-12-04T09:50:39  <jonasschnelli> pushed
 81 2015-12-04T09:51:01  <jonasschnelli> I'm also testing it now
 82 2015-12-04T09:51:03  <wumpus> yeah that's where I noticed (verack is outgoing message)
 83 2015-12-04T09:51:17  <wumpus> +also
 84 2015-12-04T09:52:05  *** baldur has quit IRC
 85 2015-12-04T09:53:51  <jonasschnelli> Yes. Now it's correct. The bytesrecv/bytessent (totals per node) matches now the sum of the aggregated values.
 86 2015-12-04T09:54:30  <wumpus> nice!
 87 2015-12-04T09:54:46  *** ParadoxSpiral has joined #bitcoin-core-dev
 88 2015-12-04T09:58:25  <wumpus> maybe we want an 'other' catch-all for received commands that we don't recognize otherwise?
 89 2015-12-04T09:59:43  <wumpus> (say someone is bombarding us with large packets that we don't recognize, right now it won't show up in bytesrecv_per_cmd) - of course we have the total already, so this may be unnecessary, I don't know
 90 2015-12-04T09:59:43  <jonasschnelli> wumpus: hmm.. yes. Would be nice... and it would not introduce a mem DOS attack (if combined to one map key "other").
 91 2015-12-04T09:59:55  <wumpus> right :)
 92 2015-12-04T10:00:10  <jonasschnelli> others = total - <sum of aggregated>, ...
 93 2015-12-04T10:00:20  <jonasschnelli> we could just render that in the rpc output.
 94 2015-12-04T10:00:44  <wumpus> but it may be good to report, it's nice if numbers add up
 95 2015-12-04T10:01:24  <wumpus> the problem is that any string up to 12(?) chars can be an actual command name
 96 2015-12-04T10:01:32  <jonasschnelli> Yeah. Sure. Let me add it. I think this number is very helpful to detect strange nodes.
 97 2015-12-04T10:02:21  <wumpus> so is this the command 'other' or ... an other command... lol ok that doesn't matter much I guess, as 'other' would, being an unknown command, also go into the category 'other' . Hmm.
 98 2015-12-04T10:02:59  <jonasschnelli> use "*other*" instead of "other"? or to much magic?
 99 2015-12-04T10:03:12  <wumpus> making it distinct makes sense yes
100 2015-12-04T10:03:54  <wumpus> I even mean even though *other* is strictly a valid command name, no one is ever actually going to agree on using that
101 2015-12-04T10:04:04  <wumpus> yes makes sense
102 2015-12-04T10:05:22  *** baldur has joined #bitcoin-core-dev
103 2015-12-04T10:08:52  <wumpus> this is nice, it allows for doing a (simple kind of, better than looking at subvers) behavioral profiling of peers
104 2015-12-04T10:09:47  <wumpus> some peers do nothing except connect and ping! :o
105 2015-12-04T10:10:01  <jonasschnelli> Yes. I wrote this to analyze the traffic before I wrote maxuploadtarget PR.
106 2015-12-04T10:10:24  <jonasschnelli> And it would allow to do some clever throttling based on this data.
107 2015-12-04T10:22:14  <wumpus> jonasschnelli: would it be a reasonable compromise to have `logAllowIncomingCmds` available via RPC somewhere (say `getnetworkinfo`)? This avoids having to add empty rows to every peer.
108 2015-12-04T10:23:25  <jonasschnelli> wumpus: yes. That would be useful and reduce the whole rpc response size.
109 2015-12-04T10:23:41  <jonasschnelli> getpeerinfo looks after a command that is ideal to poll... so reducing size there is fine
110 2015-12-04T10:24:02  <wumpus> (and still accomplishes the same, the stats collector can know the total set of messages accepted by the peer)
111 2015-12-04T10:24:12  <wumpus> right - it makes sense to try to save space there
112 2015-12-04T10:26:29  <jonasschnelli> wumpus: Okay. Switch to your find("other") approach, but i need to pre-populate "*other*" as well (which is fine): https://github.com/bitcoin/bitcoin/pull/6589/files#diff-9a82240fe7dfe86564178691cc57f2f1R2358
113 2015-12-04T10:28:01  <wumpus> jonasschnelli: maybe static const std::string NET_COMMAND_OTHER="*other*";
114 2015-12-04T10:28:03  *** Thireus1 has joined #bitcoin-core-dev
115 2015-12-04T10:28:28  <wumpus> jonasschnelli: then explicitly mapRecvBytesPerCmd[NET_COMMAND_OTHER] = 0;   and use the constant in the other place too
116 2015-12-04T10:28:51  <jonasschnelli> Yeah. Better. Cleaner.
117 2015-12-04T10:28:59  <wumpus> jonasschnelli: given how critical it is that it exist, don't think adding it to logAllowIncomingCmds is a good idea, someone may just remove it and crash everything
118 2015-12-04T10:29:25  <wumpus> jonasschnelli: maybe add an assert(i != mapRecvBytesPerCmd.end()); before the increase just incase :p
119 2015-12-04T10:29:32  *** Thireus has quit IRC
120 2015-12-04T10:29:36  <jonasschnelli> Yeah. Good idea.
121 2015-12-04T10:31:40  <wumpus> (ideally we would have constants for all net commands and use those in the code instead of hardcoded strings, this avoids typos and such, but far out of scope of your pull)
122 2015-12-04T10:33:35  <jonasschnelli> Indeed
123 2015-12-04T10:41:13  <jonasschnelli> wumpus: Added a commit that hides the 0 entries... need to add the command list to getnetworkinfo.. will do soon.
124 2015-12-04T10:41:21  * wumpus must have the craziest multi-stage bitcoind launch command "nice -+19 screen -d -m gdb -x run.gdbscript -args ./bitcoind -datadir=/usb/bitcoin"  (run.gdbscript is http://stackoverflow.com/a/5286038/216357 )
125 2015-12-04T10:42:16  <jonasschnelli> hah
126 2015-12-04T10:42:22  <wumpus> maybe I should propose it for #7111 "Recommend how to run bitcoind in a production environment"? *ducks*
127 2015-12-04T10:42:49  <jonasschnelli> you forgot the while 1 loop (in case it crashes)
128 2015-12-04T10:42:55  <wumpus> hahahhahaah
129 2015-12-04T10:43:02  <jonasschnelli> ;-)
130 2015-12-04T10:44:58  *** CodeShark_ has quit IRC
131 2015-12-04T11:15:36  *** paveljanik has joined #bitcoin-core-dev
132 2015-12-04T11:15:36  *** paveljanik has joined #bitcoin-core-dev
133 2015-12-04T11:24:17  <wumpus> jonasschnelli: hm I got a "bitcoind: net.cpp:703: bool CNode::ReceiveMsgBytes(const char*, unsigned int): Assertion `i != mapRecvBytesPerCmd.end()' failed."
134 2015-12-04T11:25:57  <wumpus> jonasschnelli: you're not prepopulating NET_COMMAND_OTHER, either need to re-add it to logAllowIncomingCmds, either add it or (I think preferably) add it explicilty with  mapRecvBytesPerCmd[NET_COMMAND_OTHER] = 0
135 2015-12-04T11:29:59  *** Thireus1 has quit IRC
136 2015-12-04T11:30:13  *** Thireus has joined #bitcoin-core-dev
137 2015-12-04T11:39:31  *** Thireus1 has joined #bitcoin-core-dev
138 2015-12-04T11:42:50  *** Thireus has quit IRC
139 2015-12-04T12:01:51  *** dcousens has joined #bitcoin-core-dev
140 2015-12-04T12:10:17  *** droark has quit IRC
141 2015-12-04T12:18:49  <jonasschnelli> wumpus: Fixed (force pushed)
142 2015-12-04T12:26:06  <GitHub74> [bitcoin] laanwj opened pull request #7170: tests: Disable Tor interaction (master...2015_12_tests_nolistentor) https://github.com/bitcoin/bitcoin/pull/7170
143 2015-12-04T12:26:56  <GitHub73> [bitcoin] laanwj opened pull request #7171: test: remove necessity to call create_callback_map (master...2015_12_p2p_test_no_cbmap) https://github.com/bitcoin/bitcoin/pull/7171
144 2015-12-04T12:48:13  *** afk11 has joined #bitcoin-core-dev
145 2015-12-04T12:50:09  <wumpus> jonasschnelli: great
146 2015-12-04T13:09:35  <wumpus> "bytesrecv_per_cmd": { "reject": 140788, } whoa some nodes send a  lot of reject
147 2015-12-04T13:10:33  <wumpus> that's a lot for a message we don't use at all
148 2015-12-04T13:12:36  <tulip> are people setting the "reason" string?
149 2015-12-04T13:13:15  <wumpus> I don't know, going to log the contents
150 2015-12-04T13:15:31  <afk11> hmm, I am getting reject messages this morning using electrum
151 2015-12-04T13:15:38  <afk11> the one that comes with tails :/ not great.
152 2015-12-04T13:16:03  <afk11> "Your transaction was rejected by the network, please upgrade away to > electrum 2.6"
153 2015-12-04T13:16:48  <wumpus> at least that message is clear on what to do (but I don't believe it has to do with P2P network reject messages)
154 2015-12-04T13:16:59  <tulip> that's unrelated.
155 2015-12-04T13:17:20  <tulip> that'll be to do with low-s signatures, older versions of Electrum generate now-invalid signatures.
156 2015-12-04T13:20:50  *** afk11 has quit IRC
157 2015-12-04T13:22:01  <wumpus> we should have made reject messages optional, eg like announce headers, a 'enablerejects' message that has to be received before the node starts sending them
158 2015-12-04T13:22:53  <wumpus> only a small extract of what nodes are sending: http://www.hastebin.com/imipusiqan.txt
159 2015-12-04T13:26:00  <tulip> I'm not sure why the server software doesn't just re-pack the points in the signature, guess there's a good reason.
160 2015-12-04T13:35:20  <wumpus> some nodes do that, but it has some other drawbacks, effectively it's malleating transactions
161 2015-12-04T13:39:57  *** evoskuil has joined #bitcoin-core-dev
162 2015-12-04T14:01:55  <GitHub93> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/f31955d9da152e5e849575f0297f8fe1904cbfbc
163 2015-12-04T14:01:55  <GitHub93> bitcoin/0.12 f31955d Gregory Maxwell: Replace setInventoryKnown with a rolling bloom filter....
164 2015-12-04T14:43:24  *** tulip has quit IRC
165 2015-12-04T14:43:56  *** tulip has joined #bitcoin-core-dev
166 2015-12-04T14:49:06  *** evoskuil has quit IRC
167 2015-12-04T14:51:27  *** jtimon has quit IRC
168 2015-12-04T14:58:51  *** moley is now known as moli
169 2015-12-04T15:07:58  *** Guyver2 has joined #bitcoin-core-dev
170 2015-12-04T16:19:54  *** tripleslash has quit IRC
171 2015-12-04T16:57:54  *** tripleslash has joined #bitcoin-core-dev
172 2015-12-04T17:03:55  *** tripleslash_p has joined #bitcoin-core-dev
173 2015-12-04T17:04:20  *** tripleslash has quit IRC
174 2015-12-04T17:04:48  *** Thireus1 has quit IRC
175 2015-12-04T17:05:02  *** Thireus has joined #bitcoin-core-dev
176 2015-12-04T17:08:34  *** tripleslash_p has quit IRC
177 2015-12-04T17:33:18  *** PaulCapestany has quit IRC
178 2015-12-04T17:34:06  <Thireus> I received this a couple of hours ago: "WARNING: check your network connection, 5 blocks received in the last 4 hours (24 expected)" on my full nodes
179 2015-12-04T17:34:42  <Thireus> there seem to be some TX flood going on, has anyone else been impacted as well?
180 2015-12-04T17:34:51  *** PaulCapestany has joined #bitcoin-core-dev
181 2015-12-04T17:35:01  <Thireus> c.f. block https://tradeblock.com/bitcoin/block/386689
182 2015-12-04T17:46:53  *** ParadoxSpiral_ has joined #bitcoin-core-dev
183 2015-12-04T17:50:06  *** ParadoxSpiral has quit IRC
184 2015-12-04T18:41:35  *** tulip has quit IRC
185 2015-12-04T18:42:56  *** tulip has joined #bitcoin-core-dev
186 2015-12-04T19:26:32  *** treehug88 has joined #bitcoin-core-dev
187 2015-12-04T19:55:09  <Squidicuz>  Thireus getting the same thing
188 2015-12-04T20:47:18  <tulip> Thireus: that seems to be buggy. other people have encountered the same thing.
189 2015-12-04T20:58:26  <Squidicuz> I rebooted the services and it is okay for now :S
190 2015-12-04T20:59:00  <Squidicuz> what does that message mean though?  I can't be blocks behind when minig O_o
191 2015-12-04T20:59:35  <Squidicuz> apologies if this is the wrong channel, i just realized where I is.
192 2015-12-04T21:08:59  *** arowser has quit IRC
193 2015-12-04T21:09:21  *** arowser has joined #bitcoin-core-dev
194 2015-12-04T21:09:55  *** treehug88 has quit IRC
195 2015-12-04T21:14:14  *** evoskuil has joined #bitcoin-core-dev
196 2015-12-04T21:28:49  *** Guyver2_ has joined #bitcoin-core-dev
197 2015-12-04T21:29:10  *** Guyver2 has quit IRC
198 2015-12-04T21:30:38  *** opitka has joined #bitcoin-core-dev
199 2015-12-04T22:08:24  *** coco has joined #bitcoin-core-dev
200 2015-12-04T22:13:51  <tulip> Squidicuz: it's probably on topic, if you aren't falling behind triggering that is definitely a bug. someone has encountered that before recently.
201 2015-12-04T22:15:38  <Squidicuz> the node did not seem behind when i checked on it.  i restarted and havent gotten the messgae since.  the logs shows that bitcoind timed out a few times prior.
202 2015-12-04T22:16:08  <tulip> timed out?
203 2015-12-04T22:20:07  *** paveljanik has quit IRC
204 2015-12-04T22:21:37  <Squidicuz> yes.  my connection to bitcoind timed out, I mean.
205 2015-12-04T22:22:01  <Squidicuz> for getBlockTemplate
206 2015-12-04T22:25:41  *** coco has quit IRC
207 2015-12-04T23:03:06  *** coco has joined #bitcoin-core-dev
208 2015-12-04T23:10:31  *** coco has quit IRC
209 2015-12-04T23:36:14  *** ghtdak has quit IRC
210 2015-12-04T23:53:28  *** randy-waterhouse has joined #bitcoin-core-dev