12015-12-08T00:05:36  *** xiangfu has joined #bitcoin-core-dev
  22015-12-08T00:11:16  <phantomcircuit> wumpus, opinion on modifying CONTIBUTORS.md to include "Reviewers should include the id of the commits which they reviewed in their comments."
  32015-12-08T00:14:40  <GitHub148> [bitcoin] pstratem opened pull request #7185: Note that reviewers should mention the id of the commits they reviewed. (master...2015-12-07-contributingackcommit) https://github.com/bitcoin/bitcoin/pull/7185
  42015-12-08T00:14:47  *** Thireus has quit IRC
  52015-12-08T00:19:36  *** Thireus has joined #bitcoin-core-dev
  62015-12-08T00:30:07  *** midnightmagic has joined #bitcoin-core-dev
  72015-12-08T00:32:31  *** Ylbam has quit IRC
  82015-12-08T01:06:12  *** Ylbam has joined #bitcoin-core-dev
  92015-12-08T01:08:31  <GitHub197> [bitcoin] pstratem closed pull request #5989: improve addr/inv trickle logic (master...trickle_fix) https://github.com/bitcoin/bitcoin/pull/5989
 102015-12-08T01:09:31  <GitHub36> [bitcoin] pstratem closed pull request #6745: Net: Remove "Address refresh broadcast" logic. (master...addr_known_reset) https://github.com/bitcoin/bitcoin/pull/6745
 112015-12-08T01:11:52  *** bitdevsnyc has joined #bitcoin-core-dev
 122015-12-08T01:13:37  *** Thireus has quit IRC
 132015-12-08T01:14:50  <Luke-Jr> phantomcircuit: s/id/commithash/
 142015-12-08T01:15:24  <phantomcircuit> Luke-Jr, please comment on pr mentioning commithash
 152015-12-08T01:15:26  * phantomcircuit runs
 162015-12-08T01:34:26  *** Tera2342 has joined #bitcoin-core-dev
 172015-12-08T01:40:47  *** bitdevsnyc has quit IRC
 182015-12-08T01:41:20  *** bitdevsnyc has joined #bitcoin-core-dev
 192015-12-08T01:46:30  *** dcousens has joined #bitcoin-core-dev
 202015-12-08T01:59:06  *** evoskuil has quit IRC
 212015-12-08T02:04:27  *** xiangfu has quit IRC
 222015-12-08T02:06:33  *** tripleslash has joined #bitcoin-core-dev
 232015-12-08T02:16:21  *** evoskuil has joined #bitcoin-core-dev
 242015-12-08T02:31:16  <morcos> phantomcircuit: i apologize for the ultra bikeshed, but isn't it a bit annoying to print out two memory usage stats right next to each other, one 1000-based and one 1024-based
 252015-12-08T02:48:05  *** PaulCapestany has quit IRC
 262015-12-08T02:48:24  <phantomcircuit> morcos, fixed
 272015-12-08T02:49:48  *** PaulCapestany has joined #bitcoin-core-dev
 282015-12-08T03:17:19  *** Ylbam has quit IRC
 292015-12-08T03:29:40  <Luke-Jr> gmaxwell: for blocks 300031..309685 (excluding outliers), of 2,701,513 total non-generation transactions, approximately 160,289 (5.93%) were mined by priority
 302015-12-08T03:34:54  <morcos> Luke-Jr: and how many of those would not have made it in by fee?  (what do you mean excluding outliers?)
 312015-12-08T03:36:15  <Luke-Jr> morcos: excluding blocks which my code was unable to determine the priority/fee boundary
 322015-12-08T03:43:05  <aj> Luke-Jr: can you tell how much of a discount they got? (ie, delta between the max/avg fee priority txs paid, versus min/avg fee non-priority txs paid)
 332015-12-08T03:47:34  *** xiangfu has joined #bitcoin-core-dev
 342015-12-08T04:08:49  <dcousens>  Luke-Jr: were those blocks full?
 352015-12-08T04:09:28  <Luke-Jr> dcousens: unlikely
 362015-12-08T04:09:48  <dcousens> Luke-Jr: so how can you definitively say they wouldn't have been included otherwise?
 372015-12-08T04:10:15  <Luke-Jr> dcousens: I can't, and it doesn't seem relevant.
 382015-12-08T04:10:39  <dcousens> Luke-Jr: " were mined by
 392015-12-08T04:10:40  <dcousens>                  priority"
 402015-12-08T04:10:45  <Luke-Jr> if impossible requests are made, I'm just going to go back to "onus of proof is on the remove-priority camp" :P
 412015-12-08T04:11:00  <Luke-Jr> dcousens: yes, that's true regardless of whether they would have been included otherwise
 422015-12-08T04:11:36  <dcousens> Luke-Jr: haha, agreed that onus on proof is definitely on remove-priority
 432015-12-08T04:12:49  <dcousens> simply because, if its being used, then, maybe the altruism is worth keeping
 442015-12-08T04:31:11  *** arowser has quit IRC
 452015-12-08T04:31:42  *** arowser has joined #bitcoin-core-dev
 462015-12-08T04:37:43  *** dcousens has quit IRC
 472015-12-08T04:37:52  <gmaxwell> Luke-Jr: I think people are just trying to get clarity on what you measured and now.
 482015-12-08T04:38:05  <gmaxwell> how*
 492015-12-08T04:38:26  <gmaxwell> 5% certantly sounds like more than just only benefiting old timers!
 502015-12-08T04:40:29  *** bitdevsnyc has quit IRC
 512015-12-08T04:41:04  *** bitdevsnyc has joined #bitcoin-core-dev
 522015-12-08T04:45:26  *** evoskuil has quit IRC
 532015-12-08T04:55:20  <Luke-Jr> gmaxwell: this is specifically the results I am finding from http://codepad.org/VCZUhPe3
 542015-12-08T05:09:39  *** evoskuil has joined #bitcoin-core-dev
 552015-12-08T05:52:06  *** evoskuil has quit IRC
 562015-12-08T05:53:40  *** evoskuil has joined #bitcoin-core-dev
 572015-12-08T06:07:47  <GitHub132> [bitcoin] jtimon reopened pull request #7091: Consensus build package (master...consensus-build) https://github.com/bitcoin/bitcoin/pull/7091
 582015-12-08T06:27:31  *** Tera2342 has quit IRC
 592015-12-08T06:45:06  *** Thireus has joined #bitcoin-core-dev
 602015-12-08T06:51:47  *** bitdevsnyc has quit IRC
 612015-12-08T06:52:08  *** Ylbam has joined #bitcoin-core-dev
 622015-12-08T07:04:40  *** paveljanik has joined #bitcoin-core-dev
 632015-12-08T07:04:40  *** paveljanik has joined #bitcoin-core-dev
 642015-12-08T07:06:46  *** evoskuil has quit IRC
 652015-12-08T07:11:40  *** evoskuil has joined #bitcoin-core-dev
 662015-12-08T07:14:07  <GitHub171> [bitcoin] luke-jr opened pull request #7186: Backports for 0.10.5 (updated to dc0305d) (0.10...backports-for-0.10.5) https://github.com/bitcoin/bitcoin/pull/7186
 672015-12-08T07:18:46  *** evoskuil has quit IRC
 682015-12-08T07:29:29  *** Thireus has quit IRC
 692015-12-08T07:49:33  *** JackH has joined #bitcoin-core-dev
 702015-12-08T07:54:47  *** evoskuil has joined #bitcoin-core-dev
 712015-12-08T07:58:25  *** JackH has quit IRC
 722015-12-08T08:20:49  *** Thireus has joined #bitcoin-core-dev
 732015-12-08T08:31:35  *** berndj has quit IRC
 742015-12-08T08:32:43  *** jtimon has joined #bitcoin-core-dev
 752015-12-08T08:53:46  *** evoskuil has quit IRC
 762015-12-08T08:54:30  *** evoskuil has joined #bitcoin-core-dev
 772015-12-08T09:05:33  *** paveljanik has quit IRC
 782015-12-08T09:05:35  <GitHub1> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc0305d15aa0...16ccb74ef2e0
 792015-12-08T09:05:35  <GitHub1> bitcoin/master e3bc5e0 Wladimir J. van der Laan: net: Account for `sendheaders` `verack` messages...
 802015-12-08T09:05:36  <GitHub1> bitcoin/master 16ccb74 Wladimir J. van der Laan: Merge pull request #7180...
 812015-12-08T09:19:44  *** randy-waterhouse has quit IRC
 822015-12-08T09:23:20  <GitHub88> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/16ccb74ef2e0...0800092fc252
 832015-12-08T09:23:20  <GitHub121> [bitcoin] laanwj closed pull request #4906: Issue#1643: Coinselection prunes extraneous inputs from ApproximateBestSubset (master...Fix-#1643) https://github.com/bitcoin/bitcoin/pull/4906
 842015-12-08T09:23:21  <GitHub88> bitcoin/master 5c03483 AlSzacrel: Coinselection prunes extraneous inputs from ApproximateBestSubset...
 852015-12-08T09:23:21  <GitHub88> bitcoin/master af9510e Murch: Moved set reduction to the end of ApproximateBestSubset to reduce performance impact
 862015-12-08T09:23:22  <GitHub88> bitcoin/master fc0f52d Murch: Added a test for the pruning of extraneous inputs after ApproximateBestSet
 872015-12-08T09:25:01  *** Tera2342 has joined #bitcoin-core-dev
 882015-12-08T09:25:40  *** jtimon has quit IRC
 892015-12-08T09:39:15  *** droark has joined #bitcoin-core-dev
 902015-12-08T09:52:26  *** evoskuil has quit IRC
 912015-12-08T09:52:26  *** [1]evoskuil has joined #bitcoin-core-dev
 922015-12-08T09:59:25  *** Guyver2 has joined #bitcoin-core-dev
 932015-12-08T10:30:46  *** [1]evoskuil has quit IRC
 942015-12-08T10:46:01  *** evoskuil has joined #bitcoin-core-dev
 952015-12-08T10:59:56  *** molz has joined #bitcoin-core-dev
 962015-12-08T11:03:08  *** moli has quit IRC
 972015-12-08T11:20:06  *** evoskuil has quit IRC
 982015-12-08T11:46:21  *** warren has quit IRC
 992015-12-08T11:47:16  *** warren has joined #bitcoin-core-dev
1002015-12-08T12:35:59  *** jonasschnelli has quit IRC
1012015-12-08T12:36:54  *** jonasschnelli has joined #bitcoin-core-dev
1022015-12-08T12:39:32  *** jonasschnelli has quit IRC
1032015-12-08T12:40:24  *** jonasschnelli_ has joined #bitcoin-core-dev
1042015-12-08T12:47:26  *** droark has quit IRC
1052015-12-08T12:52:10  *** ParadoxSpiral has joined #bitcoin-core-dev
1062015-12-08T13:47:59  *** afk11 has joined #bitcoin-core-dev
1072015-12-08T14:25:39  *** arowser has quit IRC
1082015-12-08T14:26:07  *** arowser has joined #bitcoin-core-dev
1092015-12-08T14:27:26  *** Tera2342 has quit IRC
1102015-12-08T14:49:11  *** treehug88 has joined #bitcoin-core-dev
1112015-12-08T14:57:10  *** Thireus1 has joined #bitcoin-core-dev
1122015-12-08T15:00:06  *** Thireus has quit IRC
1132015-12-08T15:40:13  *** dermoth has joined #bitcoin-core-dev
1142015-12-08T15:54:55  *** fkhan has quit IRC
1152015-12-08T15:58:35  *** Thireus1 has quit IRC
1162015-12-08T16:09:54  *** fkhan has joined #bitcoin-core-dev
1172015-12-08T16:14:11  *** evoskuil has joined #bitcoin-core-dev
1182015-12-08T16:45:37  <wumpus> curious, two nodes w/ /bitcoinj:0.12.2/ send almost 150kB of ping messages in less than a day:   "ping": 145376,   that's... abnormal at the least
1192015-12-08T16:46:35  <wumpus> one vps at linode and one at fdcserver.net
1202015-12-08T16:48:56  <wumpus> looking at their conntimes about ~10.5 bytes of ping traffic per second
1212015-12-08T16:49:54  *** zookolaptop has joined #bitcoin-core-dev
1222015-12-08T16:50:28  <wumpus> (for normal nodes this is ~0.15)
1232015-12-08T16:50:50  <wumpus> I wonder why...
1242015-12-08T17:00:47  <tulip> wumpus: just from observation nodes seem to ping an awful lot. even if you just did a pong a second ago you can end up pinging again in the next. maybe we could have a cool down for pings just to reduce the chat a bit?
1252015-12-08T17:01:13  <wumpus> I'm seeing none of this behavior from bitcoin core nodes
1262015-12-08T17:01:34  <tulip> I'm not sure anything stops wonky node implementations from going crazy with pings.
1272015-12-08T17:01:48  <wumpus> either this is some specific abuse/attack, or a bug in a certain spy node implementation :-)
1282015-12-08T17:02:37  <tulip> hm well you'll ping late if you're loaded down right? maybe there's some cpu usage related leakage somewhere.
1292015-12-08T17:03:56  <tulip> it would reveal your process block time for example, as you don't reply to pings while doing that. you'll end up dropping your peers if you sit for 20 minutes reorganising for example.
1302015-12-08T17:04:29  <tulip> I don't see that as useful information. buggy is probably more realistic and more likely.
1312015-12-08T17:09:02  *** molly has joined #bitcoin-core-dev
1322015-12-08T17:12:36  *** molz has quit IRC
1332015-12-08T17:24:40  *** afk11 has quit IRC
1342015-12-08T17:49:26  *** evoskuil has quit IRC
1352015-12-08T17:56:47  *** paveljanik has joined #bitcoin-core-dev
1362015-12-08T17:56:48  *** paveljanik has joined #bitcoin-core-dev
1372015-12-08T17:57:01  *** Thireus has joined #bitcoin-core-dev
1382015-12-08T17:59:36  *** molz has joined #bitcoin-core-dev
1392015-12-08T18:03:02  *** molly has quit IRC
1402015-12-08T18:10:45  *** MarcoFalke has joined #bitcoin-core-dev
1412015-12-08T18:30:43  *** JackH has joined #bitcoin-core-dev
1422015-12-08T18:48:18  *** MarcoFalke has quit IRC
1432015-12-08T19:06:46  *** JackH has quit IRC
1442015-12-08T19:18:17  *** MarcoFalke has joined #bitcoin-core-dev
1452015-12-08T19:24:13  <gmaxwell> wumpus: :(
1462015-12-08T19:24:24  <gmaxwell> wumpus: there is a privacy attack that looks like that.
1472015-12-08T19:24:46  <gmaxwell> In the current code, sending lots of pings destroys any trickle delays.
1482015-12-08T19:25:05  <gmaxwell> thus the patch from pieter that pulls back out the patch from phantomcircuit.
1492015-12-08T19:34:52  <gmaxwell> https://github.com/bitcoin/bitcoin/pull/7125
1502015-12-08T19:35:12  <gmaxwell> Sad to hear that its being actively exploited, happy that we already have a fix.
1512015-12-08T19:36:42  *** JackH has joined #bitcoin-core-dev
1522015-12-08T19:45:20  <GitHub96> [bitcoin] morcos opened pull request #7187: Keep reorgs fast for SequenceLocks checks (master...fastReorgBIP68) https://github.com/bitcoin/bitcoin/pull/7187
1532015-12-08T19:57:51  <gmaxwell> wumpus: same nodes seem to be connecting to everyone; also supporting that theory.
1542015-12-08T20:03:37  <GitHub65> [bitcoin] morcos closed pull request #7187: Keep reorgs fast for SequenceLocks checks (master...fastReorgBIP68) https://github.com/bitcoin/bitcoin/pull/7187
1552015-12-08T20:03:37  <GitHub133> [bitcoin] morcos reopened pull request #7187: Keep reorgs fast for SequenceLocks checks (master...fastReorgBIP68) https://github.com/bitcoin/bitcoin/pull/7187
1562015-12-08T21:04:07  *** fkhan has quit IRC
1572015-12-08T21:17:33  *** fkhan has joined #bitcoin-core-dev
1582015-12-08T21:18:06  <phantomcircuit> jonasschnelli_, ./configure doesn't detect qt4 on my debian jessie system
1592015-12-08T21:18:17  <phantomcircuit> i had to manually specify --with-gui=qt4
1602015-12-08T21:18:43  <MarcoFalke> Is qt5 installed as well?
1612015-12-08T21:19:42  <phantomcircuit> i dont think so
1622015-12-08T21:20:01  <phantomcircuit> dpkg-query: no packages found matching libqt*5*
1632015-12-08T21:21:02  <MarcoFalke> Only if both are installed it chooses qt5: https://github.com/bitcoin/bitcoin/pull/6938/files
1642015-12-08T21:21:12  <MarcoFalke> If qt4 is installed it chooses nothing
1652015-12-08T21:21:40  <phantomcircuit> ah
1662015-12-08T21:21:42  <phantomcircuit> hmm
1672015-12-08T21:21:43  <MarcoFalke> Not sure if a bug or feature
1682015-12-08T21:22:24  <phantomcircuit> MarcoFalke, definitely a bug
1692015-12-08T22:01:14  *** belcher has joined #bitcoin-core-dev
1702015-12-08T22:07:11  *** treehug88 has quit IRC
1712015-12-08T22:24:47  *** Guyver2 has quit IRC
1722015-12-08T22:25:34  *** ghtdak has quit IRC
1732015-12-08T22:26:02  *** ghtdak has joined #bitcoin-core-dev
1742015-12-08T22:54:16  *** ParadoxSpiral has quit IRC
1752015-12-08T23:06:58  *** tripleslash_s has joined #bitcoin-core-dev
1762015-12-08T23:07:37  *** tripleslash has quit IRC
1772015-12-08T23:15:12  <GitHub130> [bitcoin] smenglish opened pull request #7188: Update sha512.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7188
1782015-12-08T23:15:30  <MarcoFalke> phantomcircuit, mind to report a bug?
1792015-12-08T23:28:56  *** randy-waterhouse has joined #bitcoin-core-dev
1802015-12-08T23:30:43  *** evoskuil has joined #bitcoin-core-dev