12015-12-15T00:00:02  *** jannes has quit IRC
  22015-12-15T00:04:31  *** fkhan has joined #bitcoin-core-dev
  32015-12-15T00:05:06  *** go1111111 has quit IRC
  42015-12-15T00:09:38  *** morcos has joined #bitcoin-core-dev
  52015-12-15T00:19:23  *** Tera2342 has joined #bitcoin-core-dev
  62015-12-15T00:23:34  *** go1111111 has joined #bitcoin-core-dev
  72015-12-15T00:36:53  *** bitdevsnyc has joined #bitcoin-core-dev
  82015-12-15T00:37:28  *** zookolaptop has quit IRC
  92015-12-15T00:38:56  *** bitdevsn_ has quit IRC
 102015-12-15T00:43:36  *** Tera2342 has quit IRC
 112015-12-15T00:44:22  *** Tera2342 has joined #bitcoin-core-dev
 122015-12-15T00:59:57  *** Tera2342 has quit IRC
 132015-12-15T01:03:22  *** bitdevsnyc has quit IRC
 142015-12-15T01:05:04  *** bitdevsnyc has joined #bitcoin-core-dev
 152015-12-15T01:19:35  *** Tera2342 has joined #bitcoin-core-dev
 162015-12-15T01:31:28  *** Ylbam has quit IRC
 172015-12-15T01:32:47  <Luke-Jr> sipa: FYI, there are actually people and miners using master in production (albeit not many enough that it should be a problem)
 182015-12-15T02:13:02  *** Quent has quit IRC
 192015-12-15T02:37:49  <dcousens> sipa: indeed
 202015-12-15T02:37:53  <dcousens> uh, Luke-Jr*
 212015-12-15T02:38:20  <dcousens> but, those same cases are probably running custom policies anyway
 222015-12-15T02:40:08  *** tripleslash has joined #bitcoin-core-dev
 232015-12-15T02:47:43  *** bitdevsnyc has quit IRC
 242015-12-15T03:01:48  *** Tera2342 has quit IRC
 252015-12-15T03:03:43  <Luke-Jr> dcousens: yes, that guy's problem was clearly unrelated to these facts
 262015-12-15T03:06:32  *** afk11 has quit IRC
 272015-12-15T03:36:54  <sipa> Luke-Jr: ok, good to know?
 282015-12-15T03:37:39  <sipa> s/\?//
 292015-12-15T03:42:09  *** PaulCapestany has joined #bitcoin-core-dev
 302015-12-15T03:42:42  *** PaulCapestany has quit IRC
 312015-12-15T04:06:01  *** zookolaptop has joined #bitcoin-core-dev
 322015-12-15T04:12:47  *** challisto has joined #bitcoin-core-dev
 332015-12-15T04:12:48  *** challisto has joined #bitcoin-core-dev
 342015-12-15T04:19:55  *** bitdevsnyc has joined #bitcoin-core-dev
 352015-12-15T04:21:46  *** aj has joined #bitcoin-core-dev
 362015-12-15T04:24:38  *** bitdevsnyc has quit IRC
 372015-12-15T04:28:46  *** bitdevsnyc has joined #bitcoin-core-dev
 382015-12-15T04:36:17  <dcousens> Luke-Jr: why is the ECDSA mess in Fedora relevant?
 392015-12-15T04:36:47  <Luke-Jr> dcousens: because it's impossible to support building it against the OS as a result…………….nevermind, we switched to libsecp256k1
 402015-12-15T04:37:03  <dcousens> right
 412015-12-15T04:37:08  *** bitdevsn_ has joined #bitcoin-core-dev
 422015-12-15T04:40:08  *** bitdevsnyc has quit IRC
 432015-12-15T04:56:08  *** arowser has quit IRC
 442015-12-15T04:56:29  *** arowser has joined #bitcoin-core-dev
 452015-12-15T04:58:16  *** Thireus has quit IRC
 462015-12-15T05:46:42  *** Tera2342 has joined #bitcoin-core-dev
 472015-12-15T06:13:26  *** xiangfu has quit IRC
 482015-12-15T06:13:40  *** xiangfu has joined #bitcoin-core-dev
 492015-12-15T06:15:45  *** Quent has joined #bitcoin-core-dev
 502015-12-15T06:20:11  *** droark has joined #bitcoin-core-dev
 512015-12-15T06:20:48  *** bitdevsn_ has quit IRC
 522015-12-15T06:24:03  *** jl2012 has quit IRC
 532015-12-15T06:24:52  *** jl2012 has joined #bitcoin-core-dev
 542015-12-15T06:42:36  *** zookolaptop has quit IRC
 552015-12-15T06:58:57  *** Ylbam has joined #bitcoin-core-dev
 562015-12-15T07:40:17  *** dcousens has quit IRC
 572015-12-15T07:46:32  *** btcdrak has quit IRC
 582015-12-15T08:07:19  *** Thireus has joined #bitcoin-core-dev
 592015-12-15T08:09:31  *** midnightmagic has quit IRC
 602015-12-15T09:13:24  *** raedah has quit IRC
 612015-12-15T09:20:46  *** PaulCapestany has joined #bitcoin-core-dev
 622015-12-15T09:26:28  *** ParadoxSpiral has joined #bitcoin-core-dev
 632015-12-15T09:28:09  *** PaulCapestany has quit IRC
 642015-12-15T09:29:53  *** PaulCapestany has joined #bitcoin-core-dev
 652015-12-15T10:02:32  *** harding has quit IRC
 662015-12-15T10:24:14  *** randy-waterhouse has quit IRC
 672015-12-15T10:47:48  *** btcdrak has joined #bitcoin-core-dev
 682015-12-15T10:56:16  *** MarcoFalke has joined #bitcoin-core-dev
 692015-12-15T11:02:21  *** jgarzik has quit IRC
 702015-12-15T11:06:15  *** moli has quit IRC
 712015-12-15T11:07:53  *** moli has joined #bitcoin-core-dev
 722015-12-15T11:20:03  *** asoltys has quit IRC
 732015-12-15T11:27:41  *** laurentmt has joined #bitcoin-core-dev
 742015-12-15T11:28:15  *** laurentmt has quit IRC
 752015-12-15T11:38:43  <Luke-Jr> jonasschnelli: simple_prodname updated for more testing
 762015-12-15T12:02:42  <jonasschnelli> Luke-Jr: okay. Thanks,... will build again.
 772015-12-15T12:09:06  *** Tera2342 has quit IRC
 782015-12-15T12:13:09  *** MarcoFalke has quit IRC
 792015-12-15T12:13:42  *** MarcoFalke has joined #bitcoin-core-dev
 802015-12-15T12:35:01  *** afk11 has joined #bitcoin-core-dev
 812015-12-15T12:38:55  *** afk11 has quit IRC
 822015-12-15T12:43:58  <phantomcircuit> wumpus, i assume CWallet::fFileBacked is used for test harness stuff?
 832015-12-15T12:48:48  <jonasschnelli> phantomcircuit: IMO, the fFileBackend is legacy stuff and unused.
 842015-12-15T12:51:21  <phantomcircuit> jonasschnelli, it's used by the recovery code apparently
 852015-12-15T12:51:26  <phantomcircuit> CWallet dummyWallet;
 862015-12-15T12:53:13  *** Tera2342 has joined #bitcoin-core-dev
 872015-12-15T12:54:40  <jonasschnelli> phantomcircuit: that might be possible... right
 882015-12-15T12:57:29  <phantomcircuit> jonasschnelli, lol there's no good reason for it either
 892015-12-15T12:58:01  <phantomcircuit> and it's also used in wallet_tests.cpp
 902015-12-15T12:58:48  <jonasschnelli> wallet_test does use it over a file backend? not?
 912015-12-15T12:59:09  <jonasschnelli> test_bitcoin.cpp calls 'pwalletMain = new CWallet("wallet.dat");'
 922015-12-15T12:59:22  <phantomcircuit> jonasschnelli, src/wallet/wallet_tests.cpp
 932015-12-15T13:00:03  <jonasschnelli> Arg. Right: static CWallet wallet;
 942015-12-15T13:00:23  <jonasschnelli> Maybe for test reasons it could make sense... although, even there we could inject a tmp file
 952015-12-15T13:00:40  <jonasschnelli> (and get rid of the fFileBackend stuff)
 962015-12-15T13:17:16  <jonasschnelli> Luke-Jr: background has now to tiffs,... but does not appear on my mac. Maybe a DSStore problem? Why did you change the DS_Store file anyway? Because of the icon position (based on the filename)?
 972015-12-15T13:32:26  *** laurentmt has joined #bitcoin-core-dev
 982015-12-15T13:36:06  *** laurentmt has quit IRC
 992015-12-15T13:37:05  *** ParadoxSpiral_ has joined #bitcoin-core-dev
1002015-12-15T13:39:58  *** ParadoxSpiral has quit IRC
1012015-12-15T13:51:56  *** Cory has quit IRC
1022015-12-15T14:00:05  *** Quent1 has joined #bitcoin-core-dev
1032015-12-15T14:02:16  *** Quent has quit IRC
1042015-12-15T14:04:00  <GitHub138> [bitcoin] tnull opened pull request #7216: Removed offline testnet DNSSeed 'alexykot.me'. (master...delete_offline_dnsseed) https://github.com/bitcoin/bitcoin/pull/7216
1052015-12-15T14:15:35  *** Guest51235 has joined #bitcoin-core-dev
1062015-12-15T14:17:11  *** Guest51235 has quit IRC
1072015-12-15T14:18:52  *** midnightmagic has joined #bitcoin-core-dev
1082015-12-15T14:20:24  *** Cory has joined #bitcoin-core-dev
1092015-12-15T14:33:12  *** challisto has quit IRC
1102015-12-15T14:43:46  *** molz has joined #bitcoin-core-dev
1112015-12-15T14:44:16  *** ParadoxSpiral_ has left #bitcoin-core-dev
1122015-12-15T14:44:55  *** moli has quit IRC
1132015-12-15T15:22:13  *** afk11 has joined #bitcoin-core-dev
1142015-12-15T15:35:20  *** Tera2342 has quit IRC
1152015-12-15T15:37:18  *** Guyver2 has joined #bitcoin-core-dev
1162015-12-15T15:41:24  *** jgarzik has joined #bitcoin-core-dev
1172015-12-15T15:47:45  *** helo has quit IRC
1182015-12-15T15:48:51  *** helo_ is now known as helo
1192015-12-15T15:49:12  *** tripleslash has quit IRC
1202015-12-15T15:51:26  *** laurentmt has joined #bitcoin-core-dev
1212015-12-15T15:51:46  *** laurentmt has quit IRC
1222015-12-15T16:15:29  *** zookolaptop has joined #bitcoin-core-dev
1232015-12-15T16:45:27  *** Cory has quit IRC
1242015-12-15T16:51:22  *** Cory has joined #bitcoin-core-dev
1252015-12-15T17:08:07  *** jgarzik has quit IRC
1262015-12-15T17:28:55  *** tripleslash has joined #bitcoin-core-dev
1272015-12-15T17:31:25  *** Prattler has joined #bitcoin-core-dev
1282015-12-15T17:42:05  *** tripleslash has quit IRC
1292015-12-15T17:49:31  *** tripleslash has joined #bitcoin-core-dev
1302015-12-15T17:53:53  *** jgarzik has joined #bitcoin-core-dev
1312015-12-15T17:53:53  *** jgarzik has joined #bitcoin-core-dev
1322015-12-15T17:53:57  *** jgarzik has quit IRC
1332015-12-15T17:57:50  *** grayjedi has joined #bitcoin-core-dev
1342015-12-15T17:58:44  *** MarcoFalke has quit IRC
1352015-12-15T18:04:54  *** desantis has joined #bitcoin-core-dev
1362015-12-15T18:07:21  *** tripleslash has quit IRC
1372015-12-15T18:10:03  <sdaftuar> if anyone is up for reviewing 7062, it could use some review (one of last two PRs tagged for 0.12 that's not yet merged).
1382015-12-15T18:16:09  *** paveljanik has joined #bitcoin-core-dev
1392015-12-15T18:16:09  *** paveljanik has joined #bitcoin-core-dev
1402015-12-15T18:42:16  *** grayjedi has left #bitcoin-core-dev
1412015-12-15T18:44:49  *** desantis has quit IRC
1422015-12-15T18:45:28  *** desantis has joined #bitcoin-core-dev
1432015-12-15T19:22:27  *** desantis has quit IRC
1442015-12-15T19:23:04  *** desantis has joined #bitcoin-core-dev
1452015-12-15T19:23:25  *** desantis has quit IRC
1462015-12-15T19:42:47  *** ChainQuery-Ian has joined #bitcoin-core-dev
1472015-12-15T19:48:21  *** Quent1 is now known as Quent
1482015-12-15T19:50:31  *** desantis has joined #bitcoin-core-dev
1492015-12-15T19:51:39  *** desantis has quit IRC
1502015-12-15T19:51:59  *** desantis has joined #bitcoin-core-dev
1512015-12-15T19:53:19  *** treehug88 has joined #bitcoin-core-dev
1522015-12-15T19:58:56  *** desantis has left #bitcoin-core-dev
1532015-12-15T20:01:19  *** desantis has joined #bitcoin-core-dev
1542015-12-15T20:01:46  <desantis> honest question: How does this channel differ from bitcoin-dev?
1552015-12-15T20:03:07  <sipa> This is specifically about the Bitcoin Core software, and its implementation details
1562015-12-15T20:03:31  <sipa> #bitcoin-dev is more for development of the protocol
1572015-12-15T20:08:42  *** zookolaptop has quit IRC
1582015-12-15T20:12:08  *** Luke-Jr has quit IRC
1592015-12-15T20:12:45  *** Luke-Jr has joined #bitcoin-core-dev
1602015-12-15T20:17:16  <desantis> sipa: thanks!
1612015-12-15T20:23:05  *** desantis has quit IRC
1622015-12-15T20:23:26  <sdaftuar> why do blocks with more sigops than MAX_BLOCK_SIGOPS not get marked as failed (BLOCK_FAILED_VALID)?
1632015-12-15T20:23:37  *** desantis has joined #bitcoin-core-dev
1642015-12-15T20:24:40  *** desantis has quit IRC
1652015-12-15T20:24:56  *** desantis has joined #bitcoin-core-dev
1662015-12-15T20:33:13  <sipa> sdaftuar: thry should!
1672015-12-15T20:33:56  <sdaftuar> sipa: ah, good to know
1682015-12-15T20:46:57  <GitHub85> [bitcoin] sdaftuar opened pull request #7217: Mark blocks with too many sigops as failed (master...fix-sigops-rejection) https://github.com/bitcoin/bitcoin/pull/7217
1692015-12-15T20:57:29  *** desantis has quit IRC
1702015-12-15T20:57:49  *** desantis has joined #bitcoin-core-dev
1712015-12-15T20:58:16  *** zookolaptop has joined #bitcoin-core-dev
1722015-12-15T21:04:55  *** zookolaptop has quit IRC
1732015-12-15T21:11:19  *** zookolaptop has joined #bitcoin-core-dev
1742015-12-15T21:12:39  *** ChainQuery-Ian has quit IRC
1752015-12-15T21:28:02  *** zookolaptop has quit IRC
1762015-12-15T21:41:53  *** helo has quit IRC
1772015-12-15T21:46:20  *** helo has joined #bitcoin-core-dev
1782015-12-15T21:51:09  *** moli has joined #bitcoin-core-dev
1792015-12-15T21:52:10  *** molz has quit IRC
1802015-12-15T21:53:46  *** afk11 has quit IRC
1812015-12-15T21:54:15  *** raedah has joined #bitcoin-core-dev
1822015-12-15T21:59:32  *** bitdevsnyc has joined #bitcoin-core-dev
1832015-12-15T22:12:19  *** zookolaptop has joined #bitcoin-core-dev
1842015-12-15T22:15:18  *** Guyver2 has quit IRC
1852015-12-15T22:19:29  *** treehug88 has quit IRC
1862015-12-15T22:21:40  *** paveljanik has quit IRC
1872015-12-15T22:21:49  *** job_ has joined #bitcoin-core-dev
1882015-12-15T22:22:52  <job_> BlueMatt gmaxwell good seeing you guys last night. a few quick questions about getblocktemplate when you've got a sec
1892015-12-15T22:22:56  *** job_ is now known as jamesob
1902015-12-15T22:23:54  <BlueMatt> go for it
1912015-12-15T22:24:44  <jamesob> i) what, in particular, about getblocktemplate requires holding cs_main? is it just that CreateNewBlock needs it, or do we want a consistent snapshot of the txs to include in the template?
1922015-12-15T22:25:00  <sipa> yeah, consistent snapshot
1932015-12-15T22:25:09  <sipa> and later verification of the constructed block
1942015-12-15T22:25:19  <sipa> which needs access to the utxo set
1952015-12-15T22:25:45  <jamesob> okay, so we need a consistent view of the utxo set to validate the block template we've just constructed
1962015-12-15T22:27:07  <jamesob> ii) under what circumstances do we want to rebuild this blocktemplate cache we're talking about replacing the `CreateNewBlock` routine with?
1972015-12-15T22:27:10  <BlueMatt> jamesob: yes, CreateNewBlock needs a consistent snapshot of the utxo
1982015-12-15T22:27:21  <BlueMatt> so getblocktemplate shouldn't take cs_main, but CreateNewBlock will, ofc, have to
1992015-12-15T22:27:24  <jamesob> e.g. on new chain tip, on new txs, periodically?
2002015-12-15T22:27:50  <jamesob> or some/all of the above
2012015-12-15T22:27:53  <BlueMatt> hmm? no, keep CreateNewBlock, just cache its output in a field that getblocktemplate reads from
2022015-12-15T22:28:10  <BlueMatt> as for rebuilding, just call CreateNewBlock on a timer for now
2032015-12-15T22:28:15  <BlueMatt> we can get smarter later :)
2042015-12-15T22:28:26  <jamesob> right on
2052015-12-15T22:28:48  <jamesob> so should we start with a PR that moves CreateNewBlock to a time-rebuilt cache, then iterate from there?
2062015-12-15T22:28:50  <BlueMatt> and the timer can be aggressive as long as CreateNewBlock aggressively gives up cs_main and just fails when a new block is coming in
2072015-12-15T22:29:16  <BlueMatt> I'd assume all three things from last night can fit into one pr
2082015-12-15T22:29:26  <BlueMatt> I'd hope its not much code, though, again, I havent looked at it
2092015-12-15T22:29:42  <BlueMatt> problem with moving CNB to a background-thread by itself is you end up with way more cs_main time :(
2102015-12-15T22:29:57  <jamesob> it looks like there's gonna be some shuffling... might have to factor the innards of the rpc definition out into some separate bit that we can call from some scheduled routine
2112015-12-15T22:30:08  <jamesob> BlueMatt yeah, that's what I was thinking...
2122015-12-15T22:30:31  <jamesob> like, if we've got this thing acquiring cs_main on an aggressive regular schedule, that may cause MORE contention
2132015-12-15T22:30:32  <BlueMatt> yea, I figured half of the rpc code would have to be moved out
2142015-12-15T22:30:35  <BlueMatt> that wouldnt surprise me
2152015-12-15T22:31:02  <BlueMatt> yup, hence the requirement to drop cs_main and fail mid-process if there is "important" contention (ie a new block came in)
2162015-12-15T22:31:18  <BlueMatt> contention around cs_main for other things sucks, but doesnt matter too much to most users
2172015-12-15T22:31:59  <jamesob> ah, right. is there some existing pattern for saying "hey, this is a low-prio lock acquisition, allow interrupts"?
2182015-12-15T22:32:25  <BlueMatt> nope
2192015-12-15T22:32:33  <sipa> a large portion of the cs_main locking is actually due to ProcessMessage/SendMessage, which don't actually need cs_main (they could get their own locks that lock node-specific data)
2202015-12-15T22:32:35  <BlueMatt> (and dont go overengineering there, either, which would be easy to do)
2212015-12-15T22:32:45  <BlueMatt> ahhhhh, scope creep
2222015-12-15T22:32:49  <jamesob> heh
2232015-12-15T22:33:02  <BlueMatt> this one is wayyyy too easy to scope-creep on
2242015-12-15T22:33:17  <jamesob> don't worry, I'm just tryin' to hold onto my ass for now -- not going to go on any cosmic refactoring adventures ;)
2252015-12-15T22:33:32  <BlueMatt> adding a global boolean called fAboutToLockCSMainForBlockProcessing sucks, but.....more than that is gonna lead to bike shedding
2262015-12-15T22:35:27  *** fwfwefwef has joined #bitcoin-core-dev
2272015-12-15T22:35:28  <jamesob> so, I forget: your suggestion was to set fAboutToLock...=true once you're going to rebuild the cache, and drop out of the process if some other thread has set that flag to false, i.e. signifying that there's some more important op that needs that lock?
2282015-12-15T22:36:40  <BlueMatt> no, set the flag to true in ProcessMessage or AcceptNewBlock or wherever cs_main is first locked for block acceptance (from RPC or net, you really need to check both)
2292015-12-15T22:36:52  <BlueMatt> then CNB will poll that flag a bunch while its running, and if it sees it, bail out
2302015-12-15T22:36:55  *** fwfwefwef has quit IRC
2312015-12-15T22:37:08  <jamesob> gotcha
2322015-12-15T22:37:18  <BlueMatt> once you get cs_main for new block processing, you can then drop the flag and let the background CNB thread wait for its turn for cs_main
2332015-12-15T22:37:22  <sipa> note that such a flag technically would require its own lock :)
2342015-12-15T22:37:30  <BlueMatt> yup :(
2352015-12-15T22:37:44  <sipa> or an atomic bool (but c++11 isn't quite there yet...)
2362015-12-15T22:37:52  <BlueMatt> yea, this is muchhh nicer with atomics
2372015-12-15T22:37:59  <BlueMatt> since atomic bool is guaranteed to be lock-free
2382015-12-15T22:38:09  <sipa> is it?
2392015-12-15T22:38:11  <BlueMatt> fGonnaLockHereRealSoonNow = true; LOCK(cs_main); fGonnaLockHereRealSoonNow = false;
2402015-12-15T22:39:24  <BlueMatt> oops, no, sorry, atomic_flag is guaranteed, atomic_bool is not
2412015-12-15T22:39:31  <jamesob> cool. iii) how do we want to handle this periodic rebuild; is this going to hook into the CScheduler abstraction somehow, or would we dedicate a whole new thread for it (which I doubt)?
2422015-12-15T22:39:45  <sipa> use CScheduler
2432015-12-15T22:40:02  <jamesob> roger
2442015-12-15T22:44:49  *** molz has joined #bitcoin-core-dev
2452015-12-15T22:46:25  *** moli has quit IRC
2462015-12-15T22:46:59  *** tripleslash has joined #bitcoin-core-dev
2472015-12-15T22:49:54  <jamesob> good seeing you last night as well, sipa. hope you got some sleep :)
2482015-12-15T22:50:39  <sipa> i did!
2492015-12-15T22:55:04  *** belcher has joined #bitcoin-core-dev
2502015-12-15T22:56:26  *** jamesob has quit IRC
2512015-12-15T23:03:27  *** tripleslash has quit IRC
2522015-12-15T23:03:40  *** tripleslash has joined #bitcoin-core-dev
2532015-12-15T23:10:55  *** molz has quit IRC
2542015-12-15T23:12:51  *** randy-waterhouse has joined #bitcoin-core-dev
2552015-12-15T23:14:42  *** bitdevsn_ has joined #bitcoin-core-dev
2562015-12-15T23:17:31  *** desantis has quit IRC
2572015-12-15T23:17:51  *** bitdevsnyc has quit IRC
2582015-12-15T23:46:46  *** zookolaptop has quit IRC
2592015-12-15T23:47:14  *** moli has joined #bitcoin-core-dev