1 2015-12-17T00:01:47  *** ghtdak has quit IRC
  2 2015-12-17T00:24:25  *** ghtdak has joined #bitcoin-core-dev
  3 2015-12-17T00:28:06  *** adam3us has quit IRC
  4 2015-12-17T00:44:45  *** Tera2342 has joined #bitcoin-core-dev
  5 2015-12-17T00:46:45  *** zookolaptop has quit IRC
  6 2015-12-17T00:53:35  *** [1]evoskuil has joined #bitcoin-core-dev
  7 2015-12-17T00:55:46  *** evoskuil has quit IRC
  8 2015-12-17T00:55:46  *** [1]evoskuil is now known as evoskuil
  9 2015-12-17T00:56:10  *** JackH has quit IRC
 10 2015-12-17T00:56:58  <GitHub3> [bitcoin] sidhujag opened pull request #7224: bitcoin rename to syscoin (master...btcbase) https://github.com/bitcoin/bitcoin/pull/7224
 11 2015-12-17T00:57:38  *** Prattler has joined #bitcoin-core-dev
 12 2015-12-17T00:58:49  <GitHub152> [bitcoin] sidhujag closed pull request #7224: bitcoin rename to syscoin (master...btcbase) https://github.com/bitcoin/bitcoin/pull/7224
 13 2015-12-17T01:09:07  *** Tera2342 has quit IRC
 14 2015-12-17T01:11:07  *** zookolaptop has joined #bitcoin-core-dev
 15 2015-12-17T01:20:21  *** Tera2342 has joined #bitcoin-core-dev
 16 2015-12-17T01:23:15  *** zmanian_ has quit IRC
 17 2015-12-17T01:25:04  *** bitdevsnyc has joined #bitcoin-core-dev
 18 2015-12-17T01:25:33  *** zmanian_ has joined #bitcoin-core-dev
 19 2015-12-17T01:32:23  *** Cory has quit IRC
 20 2015-12-17T01:37:16  *** bitdevsnyc has quit IRC
 21 2015-12-17T01:37:54  *** bitdevsnyc has joined #bitcoin-core-dev
 22 2015-12-17T01:51:29  *** Ylbam has quit IRC
 23 2015-12-17T01:56:32  *** btcdrak has quit IRC
 24 2015-12-17T01:59:45  *** frankenmint has joined #bitcoin-core-dev
 25 2015-12-17T02:00:25  *** tripleslash has joined #bitcoin-core-dev
 26 2015-12-17T02:00:44  *** tripleslash is now known as Guest68066
 27 2015-12-17T02:00:53  *** Guest68066 has quit IRC
 28 2015-12-17T02:05:53  *** tripleslash has joined #bitcoin-core-dev
 29 2015-12-17T02:07:18  *** Quent1 has quit IRC
 30 2015-12-17T02:09:11  *** bitdevsn_ has joined #bitcoin-core-dev
 31 2015-12-17T02:12:35  *** bitdevsnyc has quit IRC
 32 2015-12-17T02:39:40  *** raedah has joined #bitcoin-core-dev
 33 2015-12-17T02:52:34  *** raedah has quit IRC
 34 2015-12-17T03:08:21  *** bitcoin783 has joined #bitcoin-core-dev
 35 2015-12-17T03:19:30  *** Tera2342 has quit IRC
 36 2015-12-17T03:53:19  *** laurentmt has joined #bitcoin-core-dev
 37 2015-12-17T03:53:32  *** laurentmt has quit IRC
 38 2015-12-17T03:57:59  *** BashCo has quit IRC
 39 2015-12-17T04:01:07  *** dermoth has joined #bitcoin-core-dev
 40 2015-12-17T04:09:27  *** bitcoin783 has quit IRC
 41 2015-12-17T04:23:48  *** jtimon has quit IRC
 42 2015-12-17T04:33:41  <Luke-Jr> jonasschnelli: btw, did you post that corrected DS_Store somewhere? just wanted to be sure you weren't waiting on me
 43 2015-12-17T04:40:35  *** bitdevsn_ has quit IRC
 44 2015-12-17T04:43:38  *** fanquake has joined #bitcoin-core-dev
 45 2015-12-17T04:44:29  *** btcdrak has joined #bitcoin-core-dev
 46 2015-12-17T04:46:14  *** Quent1 has joined #bitcoin-core-dev
 47 2015-12-17T04:50:15  *** fanquake has quit IRC
 48 2015-12-17T05:00:01  *** jgarzik has left #bitcoin-core-dev
 49 2015-12-17T05:00:09  *** dermoth has quit IRC
 50 2015-12-17T05:00:19  *** jgarzik has joined #bitcoin-core-dev
 51 2015-12-17T05:00:19  *** jgarzik has joined #bitcoin-core-dev
 52 2015-12-17T05:00:52  *** dermoth has joined #bitcoin-core-dev
 53 2015-12-17T05:02:04  *** Thireus1 has joined #bitcoin-core-dev
 54 2015-12-17T05:02:28  *** dcousens has joined #bitcoin-core-dev
 55 2015-12-17T05:04:06  *** Thireus has quit IRC
 56 2015-12-17T05:31:04  *** Cory has joined #bitcoin-core-dev
 57 2015-12-17T05:39:59  <dcousens> It'd be cool to see how much usage BIP65 has received over the last few days
 58 2015-12-17T05:41:29  <aj> dcousens: statistical difference in volume/size of p2sh outputs maybe?
 59 2015-12-17T05:41:48  *** Quent1 has quit IRC
 60 2015-12-17T05:51:11  *** BashCo has joined #bitcoin-core-dev
 61 2015-12-17T06:08:36  *** zookolaptop has quit IRC
 62 2015-12-17T06:11:46  *** jl2012 has quit IRC
 63 2015-12-17T06:12:40  *** nanotube has quit IRC
 64 2015-12-17T06:12:41  *** jl2012 has joined #bitcoin-core-dev
 65 2015-12-17T06:17:36  *** nanotube has joined #bitcoin-core-dev
 66 2015-12-17T06:34:57  *** Tera2342 has joined #bitcoin-core-dev
 67 2015-12-17T06:57:59  *** Ylbam has joined #bitcoin-core-dev
 68 2015-12-17T07:47:41  <jonasschnelli> Luke-Jr: no. Not yet. But isn't the current (0.11.2 release) a valid/clean DS_Store to compare against?
 69 2015-12-17T07:47:59  <Luke-Jr> jonasschnelli: it's clean, but not based on the generated one
 70 2015-12-17T07:48:18  <jonasschnelli> But i guess it only links to the filenames... which are identical... not?
 71 2015-12-17T07:48:35  <jonasschnelli> Did you try a gitian build with the "old" DS_Store?
 72 2015-12-17T07:48:49  <Luke-Jr> I didn't. I have no way to test either :p
 73 2015-12-17T07:49:10  <Luke-Jr> Bitcoin-Core is in DS_Store, so I doubt it will work with it changed
 74 2015-12-17T07:50:16  <jonasschnelli> But IIRC, you did not change the app name (you could, sure)? You might want to use a perl script with (http://search.cpan.org/~wiml/Mac-Finder-DSStore/DSStoreFormat.pod) during gitian build?
 75 2015-12-17T07:50:30  <jonasschnelli> Or extract the "cleverness" of the CPAN modules and write your own python script?
 76 2015-12-17T07:50:44  <Luke-Jr> I doubt it would be any better than the python ds_store module.
 77 2015-12-17T07:51:37  <jonasschnelli> ah.. there is one. Nice. Try with the python one then?
 78 2015-12-17T07:51:51  <jonasschnelli> I can try to find out, why the current background is not working...
 79 2015-12-17T07:51:53  <Luke-Jr> that's what this does..
 80 2015-12-17T07:52:08  <jonasschnelli> ah... ha. Okay. Let me see if i find the reason why it's not working.
 81 2015-12-17T07:52:49  <jonasschnelli> So you say, the your current PR does create the DS_Store with the python script? So positioning of the icons is done correct...
 82 2015-12-17T07:53:15  <Luke-Jr> yes
 83 2015-12-17T07:53:49  <jonasschnelli> `backgroundImageAlias`: `'\x00\x00\x00\x00[...]` <-- what the hell is that?
 84 2015-12-17T07:54:47  <Luke-Jr> a blob from the original DS_Store, modified by the mac_alias python module
 85 2015-12-17T08:03:57  <jonasschnelli> Luke-Jr: Hmm... I diffed the DS_Store and I guess it's very hard to fine the source of the problem,.. could be a missing 0x00 or similar. What if you try to build the DS_Store with http://dmgbuild.readthedocs.org/en/latest/example.html?
 86 2015-12-17T08:04:33  <Luke-Jr> I don't think that works on non-Mac
 87 2015-12-17T08:04:41  <Luke-Jr> can you upload the DS_Store for me to look at?
 88 2015-12-17T08:05:37  <jonasschnelli> I don't have a new one... i just compared yours against the 0.11.2 ones.
 89 2015-12-17T08:05:48  <jonasschnelli> I can't fix yours...
 90 2015-12-17T08:06:49  <Luke-Jr> O.o
 91 2015-12-17T08:07:05  <Luke-Jr> Mac won't let you change it? (copy out of the DMG first)
 92 2015-12-17T08:07:30  <jonasschnelli> https://bitbucket.org/al45tair/dmgbuild/src/b08746ed79385ccc512cc23342cf698c5ba0bd3e/dmgbuild/core.py?at=default&fileviewer=file-view-default#core.py-411
 93 2015-12-17T08:07:57  <Luke-Jr> Alias.for_file is Mac-only
 94 2015-12-17T08:08:26  <jonasschnelli> Luke-Jr: but `biplist.Data(alias.to_bytes())`?
 95 2015-12-17T08:08:59  <jonasschnelli> I can duplicate the dmg and make it writeable and make OSX create a new DS_Store. But i guess it would be identical to the one from 0.11.2
 96 2015-12-17T08:09:07  <jonasschnelli> (same files)
 97 2015-12-17T08:09:28  <Luke-Jr> not byte-for-byte - my hope is the delta might be smaller
 98 2015-12-17T08:10:49  <jonasschnelli> I think your PR does the right, thing, expect of the byte-fiddling, why could you not use "biplist.Data(alias.to_bytes())"?
 99 2015-12-17T08:11:48  <jonasschnelli> I guess you need this tool: https://github.com/wooster/biplist
100 2015-12-17T08:12:12  <Luke-Jr> biplist is builtin to Python nowadays I think
101 2015-12-17T08:12:14  <jonasschnelli> Because it looks like, your creating a plist manually...
102 2015-12-17T08:12:17  <Luke-Jr> trying that
103 2015-12-17T08:12:42  <Luke-Jr> pushed
104 2015-12-17T08:13:04  * jonasschnelli is building...
105 2015-12-17T08:13:50  <jonasschnelli> and again,.. thanks for doing that! A solution where no mac is involved (in case of changes in the app name, etc.) would be awesome!
106 2015-12-17T08:25:51  *** Guyver2 has joined #bitcoin-core-dev
107 2015-12-17T08:31:06  <jonasschnelli> Luke-Jr: NameError: name 'biplist' is not defined
108 2015-12-17T08:31:11  <jonasschnelli> make: *** [dist/.DS_Store] Error 1
109 2015-12-17T08:31:37  <jonasschnelli> I think you need a "import biplist"
110 2015-12-17T08:31:40  <Luke-Jr> doh
111 2015-12-17T08:31:57  * jonasschnelli is ready to rebuild..
112 2015-12-17T08:32:22  <Luke-Jr> pushed
113 2015-12-17T08:33:30  *** JackH has joined #bitcoin-core-dev
114 2015-12-17T08:38:04  <jonasschnelli> started..
115 2015-12-17T08:39:22  *** Quent1 has joined #bitcoin-core-dev
116 2015-12-17T08:40:26  *** morcos has quit IRC
117 2015-12-17T08:42:24  *** morcos has joined #bitcoin-core-dev
118 2015-12-17T08:47:22  *** Tera2342 has quit IRC
119 2015-12-17T08:48:10  *** Tera2342 has joined #bitcoin-core-dev
120 2015-12-17T08:51:34  *** dcousens has left #bitcoin-core-dev
121 2015-12-17T08:58:35  *** Ylbam has quit IRC
122 2015-12-17T09:05:12  <jonasschnelli> Luke-Jr: whohoo
123 2015-12-17T09:05:17  <jonasschnelli> Wroks...
124 2015-12-17T09:05:23  <Luke-Jr> nice
125 2015-12-17T09:05:32  <jonasschnelli> The font is different... but looks okay.
126 2015-12-17T09:05:34  <Luke-Jr> good catch with the biplist difference
127 2015-12-17T09:06:10  * Luke-Jr squashes
128 2015-12-17T09:06:18  <Luke-Jr> now the only problem is PIP in gitian <><
129 2015-12-17T09:06:24  <jonasschnelli> PIP?
130 2015-12-17T09:07:37  <Luke-Jr> Python package manager
131 2015-12-17T09:07:48  <Luke-Jr> pip install --user mac_alias ds_store cairosvg cssselect tinycss lxml
132 2015-12-17T09:08:06  *** morcos has quit IRC
133 2015-12-17T09:08:10  <Luke-Jr> this is what I need cfields help with
134 2015-12-17T09:08:24  <jonasschnelli> It worked over gitian in my case.. or where do you see problems?
135 2015-12-17T09:08:38  <jonasschnelli> Ah... got it. Why not including over depends/?
136 2015-12-17T09:09:42  <Luke-Jr> problem = PIP builds are not being cached; and some gitian VMs have no network access
137 2015-12-17T09:10:03  <Luke-Jr> depends/ is probably how to do it, but it doesn't seem capable right now of installing native stuff that Bitcoin picks up on
138 2015-12-17T09:10:04  *** morcos has joined #bitcoin-core-dev
139 2015-12-17T09:10:26  *** jl2012 has quit IRC
140 2015-12-17T09:14:13  *** jl2012 has joined #bitcoin-core-dev
141 2015-12-17T09:18:26  *** jl2012 has quit IRC
142 2015-12-17T09:40:27  <GitHub34> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7a5040155ed5...d22245f92375
143 2015-12-17T09:40:28  <GitHub34> bitcoin/master e18378e Elias Rohrer: Removed offline testnet DNSSeed 'alexykot.me'.
144 2015-12-17T09:40:28  <GitHub34> bitcoin/master d22245f Wladimir J. van der Laan: Merge pull request #7216...
145 2015-12-17T09:40:36  <GitHub63> [bitcoin] laanwj closed pull request #7216: Removed offline testnet DNSSeed 'alexykot.me'. (master...delete_offline_dnsseed) https://github.com/bitcoin/bitcoin/pull/7216
146 2015-12-17T09:41:31  <GitHub41> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/9572e4944a6130640477690f2158d373af8017cc
147 2015-12-17T09:41:32  <GitHub41> bitcoin/0.12 9572e49 Elias Rohrer: Removed offline testnet DNSSeed 'alexykot.me'....
148 2015-12-17T09:43:13  *** jl2012 has joined #bitcoin-core-dev
149 2015-12-17T09:45:53  *** Ylbam has joined #bitcoin-core-dev
150 2015-12-17T09:58:12  <GitHub104> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d22245f92375...cd3f12c61ca5
151 2015-12-17T09:58:13  <GitHub104> bitcoin/master 83cdcbd Wladimir J. van der Laan: test: don't override BITCOIND and BITCOINCLI if they're set...
152 2015-12-17T09:58:13  <GitHub104> bitcoin/master cd3f12c Wladimir J. van der Laan: Merge pull request #7209...
153 2015-12-17T09:58:17  <GitHub64> [bitcoin] laanwj closed pull request #7209: test: don't override BITCOIND and BITCOINCLI if they're set (master...2015_12_rpctests_setenviron) https://github.com/bitcoin/bitcoin/pull/7209
154 2015-12-17T09:59:17  <GitHub197> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/f3ad81220850a4158ab329f5279f7530cbb70a87
155 2015-12-17T09:59:18  <GitHub197> bitcoin/0.12 f3ad812 Wladimir J. van der Laan: test: don't override BITCOIND and BITCOINCLI if they're set...
156 2015-12-17T10:27:21  *** Guyver2 has quit IRC
157 2015-12-17T10:31:35  *** Tera2342 has quit IRC
158 2015-12-17T11:47:36  <Luke-Jr> jonasschnelli: still up?
159 2015-12-17T11:48:24  <jonasschnelli> Luke-Jr: sure. It's 12 o'clock (noon). :)
160 2015-12-17T11:48:56  <Luke-Jr> jonasschnelli: pushing a test commit to change the actual name; feel like checking that it works completely? :D
161 2015-12-17T11:48:59  *** Ylbam has quit IRC
162 2015-12-17T11:49:17  <Luke-Jr> (1 line changed; all other references are in docs/locale)
163 2015-12-17T11:49:42  <jonasschnelli> Yes. Pushed already?
164 2015-12-17T11:49:52  <Luke-Jr> yep
165 2015-12-17T11:50:56  * jonasschnelli is building...
166 2015-12-17T11:51:57  *** MarcoFalke has joined #bitcoin-core-dev
167 2015-12-17T11:53:08  *** jl2012 has quit IRC
168 2015-12-17T11:55:13  *** Ylbam has joined #bitcoin-core-dev
169 2015-12-17T11:56:52  <Luke-Jr> hmm, I think this build will fail
170 2015-12-17T11:57:08  <Luke-Jr> looking at the osx descriptor, it seems to assume bitcoin-* prefix in the filename
171 2015-12-17T11:58:04  *** jl2012 has joined #bitcoin-core-dev
172 2015-12-17T11:58:04  <Luke-Jr> hm, it succeeded I guess
173 2015-12-17T11:59:21  * Luke-Jr ponders why
174 2015-12-17T12:01:10  <jonasschnelli> its still building...
175 2015-12-17T12:04:49  <Luke-Jr> oh, it works because we don't actually use "Bitcoin Core" in filenames
176 2015-12-17T12:05:28  <Luke-Jr> oh well, not sure I care enough to dig into that
177 2015-12-17T12:06:35  *** Ylbam has quit IRC
178 2015-12-17T12:20:24  *** jl2012 has quit IRC
179 2015-12-17T12:30:21  <jonasschnelli> Luke-Jr: tested. Works prefect.
180 2015-12-17T12:30:26  <Luke-Jr> great
181 2015-12-17T12:31:04  *** jl2012 has joined #bitcoin-core-dev
182 2015-12-17T12:34:06  <jonasschnelli> But i guess it would also work if we would use different filename (now i think we just fake the name over the translations/i18n file)?
183 2015-12-17T12:40:08  *** Ylbam has joined #bitcoin-core-dev
184 2015-12-17T12:45:26  <Luke-Jr> ?
185 2015-12-17T12:48:22  <jonasschnelli> Luke-Jr: your TestyCOIN-Crazy projects still uses "Bitcoin-Qt.app" as filename (as you mentioned). But I guess the whole dmg process should also work if we would use a different filename? right?
186 2015-12-17T12:50:01  <Luke-Jr> jonasschnelli: probably not. but I meant the output DMG filename itself
187 2015-12-17T12:58:29  *** afk11 has joined #bitcoin-core-dev
188 2015-12-17T13:13:01  <MarcoFalke> wumpus, you synced the missing resources from #7158 to the 0.12 transifex branch?
189 2015-12-17T13:18:47  <MarcoFalke> They show as "untranslated" and have a "100% match" in "suggestions"
190 2015-12-17T13:18:54  <wumpus> yes
191 2015-12-17T13:25:31  *** MarcoFalke has quit IRC
192 2015-12-17T14:03:31  *** jgarzik has quit IRC
193 2015-12-17T14:09:52  *** jgarzik has joined #bitcoin-core-dev
194 2015-12-17T14:09:52  *** jgarzik has joined #bitcoin-core-dev
195 2015-12-17T14:14:37  *** laurentmt has joined #bitcoin-core-dev
196 2015-12-17T14:18:31  *** laurentmt has quit IRC
197 2015-12-17T14:18:47  *** zookolaptop has joined #bitcoin-core-dev
198 2015-12-17T14:23:26  <GitHub129> [bitcoin] laanwj closed pull request #7165: WIP: build: Enable C++11 in build, require C++11 compiler (master...2015_12_c++11) https://github.com/bitcoin/bitcoin/pull/7165
199 2015-12-17T14:23:48  <zookolaptop> !!
200 2015-12-17T14:23:48  <gribble> Error: "!" is not a valid command.
201 2015-12-17T14:23:53  <zookolaptop> I meant: Wow
202 2015-12-17T14:32:15  *** zookolaptop has quit IRC
203 2015-12-17T14:36:53  <wumpus> re: the c++11 stuff there is always a reason to require a new gcc, first it was gcc4.6+ then gcc4.8+ now gcc5.1+, I've given up on it, wake me up when we're at gcc 6 or so
204 2015-12-17T14:51:16  <morcos> wumpus: fwiw i was in favor of forging ahead with c++11.  at a certain point its just risk of an ordinary bug and not a consensus bug, and you can't avoid all bugs.
205 2015-12-17T14:53:54  <jgarzik> same here
206 2015-12-17T14:53:55  <wumpus> morcos: also there's no guarantee that there aren't bugs in the non-c++11 part of the compiler that e.g. influence consensus. It's never entirely without risks, but I'd say for c++11 it's worth it, especially as it helps getting rid of boost dependency for more of the consensus code.
207 2015-12-17T14:54:04  <wumpus> but I'm just tired of the eternal arguing
208 2015-12-17T14:54:53  <morcos> there do not seem to be many voices against...   what do sipa and gmaxwell think?
209 2015-12-17T14:56:13  <wumpus> AFAIK they're for, at least sipa has been asking for it for quite some time
210 2015-12-17T14:58:29  <morcos> i'm glad Luke-Jr raises a concern like that, and i'd want to know that more experienced devs than me have spent the time to think about the issue he raises.  but to say we avoid all risk is nonsensical.
211 2015-12-17T15:01:36  <wumpus> anyhow better luck in 6 months I guess
212 2015-12-17T15:02:07  <wumpus> it's not that urgent either...
213 2015-12-17T15:02:20  <wumpus> just hoped to get it over with
214 2015-12-17T15:03:55  <jgarzik> I definitely think this is too risk averse - There are incentives on the other side that make it work - Communicating ahead of time "we're switching to c++11" and then moving ahead should be fine - Users adjust because it's not a big hurdle to keep it working on our main supported platforms
215 2015-12-17T15:12:21  *** harding has joined #bitcoin-core-dev
216 2015-12-17T15:33:15  *** zookolaptop has joined #bitcoin-core-dev
217 2015-12-17T15:58:58  *** treehug88 has joined #bitcoin-core-dev
218 2015-12-17T15:59:20  *** fewfwe has joined #bitcoin-core-dev
219 2015-12-17T16:02:01  *** benjyz1 has joined #bitcoin-core-dev
220 2015-12-17T16:02:13  <benjyz1> heavy censorship on bitcoin-dev.. what is going on
221 2015-12-17T16:03:59  <jgarzik> off topic for this channel
222 2015-12-17T16:04:05  <wumpus> only development discussion here, please
223 2015-12-17T16:04:25  <benjyz1> ?
224 2015-12-17T16:04:35  <benjyz1> is this still opensource?
225 2015-12-17T16:04:57  <benjyz1> seriously... who is censoring my posts and why?
226 2015-12-17T16:05:09  <jgarzik> benjyz1, #bitcoin-dev please
227 2015-12-17T16:05:25  <wumpus> yeah license is unchanged https://github.com/bitcoin/bitcoin/blob/master/COPYING
228 2015-12-17T16:05:42  <benjyz1> my suggestion is to remove mailing list from readme then
229 2015-12-17T16:06:02  <benjyz1> or at least make censorship explicit somewhere
230 2015-12-17T16:06:25  <benjyz1> https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md
231 2015-12-17T16:06:28  <wumpus> "The developer mailing list should be used to discuss complicated or controversial changes before working on a patch set." seems OK te me, that's what the list is for
232 2015-12-17T16:07:01  <wumpus> it's moderated due to heavy abuse
233 2015-12-17T16:07:11  <benjyz1> k. and abuse is defined by ...
234 2015-12-17T16:07:56  <benjyz1> I'll propose a change to contributor policy and readme then
235 2015-12-17T16:08:03  <benjyz1> since its no longer accurate
236 2015-12-17T16:08:47  <wumpus> off topic things not related to bitcoin development, If it fits into the above category, you're a legit contributor and somehow got 'censored' feel free to send a complaint to me
237 2015-12-17T16:10:08  <benjyz1> ok. what is the "correct" place to discuss the above mentioned contributor policy?
238 2015-12-17T16:10:14  <benjyz1> your honour
239 2015-12-17T16:11:37  <wumpus> <jgarzik> benjyz1, #bitcoin-dev please
240 2015-12-17T16:12:09  *** benjyz1 has left #bitcoin-core-dev
241 2015-12-17T16:14:22  *** treehug88 has quit IRC
242 2015-12-17T16:30:11  <sdaftuar> all -- #7062 still needs review; it fixes prioritisetransaction to work correctly with mempool limiting and rbf and imo should go into 0.12.
243 2015-12-17T16:31:23  *** fewfwe has quit IRC
244 2015-12-17T16:36:59  *** treehug88 has joined #bitcoin-core-dev
245 2015-12-17T16:39:01  *** molz has joined #bitcoin-core-dev
246 2015-12-17T16:42:46  *** laurentmt has joined #bitcoin-core-dev
247 2015-12-17T16:42:55  *** moli has quit IRC
248 2015-12-17T16:43:58  *** treehug88 has quit IRC
249 2015-12-17T16:44:18  *** laurentmt has quit IRC
250 2015-12-17T16:44:22  <wumpus> thanks sdaftuar will take a look
251 2015-12-17T16:44:46  <sdaftuar> thanks!
252 2015-12-17T16:47:12  <instagibbs> Core uses UniValue for all json object stuff, correct?
253 2015-12-17T16:48:01  <jgarzik> instagibbs, yes
254 2015-12-17T16:49:13  <instagibbs> was it just to remove a dep? or improve functionality Core requires?
255 2015-12-17T16:49:24  <instagibbs> (latter is both I suppose)
256 2015-12-17T16:49:39  <jgarzik> instagibbs, reduces size of compiled code + runtime
257 2015-12-17T16:50:07  <jgarzik> instagibbs, it was faster in one micro-benchmark I made, but performance of json encode/decode was not the driving factor
258 2015-12-17T16:50:10  <wumpus> boost spirit wasn't a very good library for our purpose
259 2015-12-17T16:51:08  <wumpus> and other JSON libraries insist on e.g. parsing numbers as floats/doubles, whereas we need them as fixed point strings
260 2015-12-17T16:51:49  <wumpus> memory usage of univalue is also better esp. for deeply nested structures
261 2015-12-17T16:52:58  *** treehug88 has joined #bitcoin-core-dev
262 2015-12-17T16:53:24  <jgarzik> ah yes, number parsing was another key issue
263 2015-12-17T16:55:26  <instagibbs> Cool, thanks. I learned UniValue first, so trying to figure out history on it.
264 2015-12-17T17:00:41  <sipa> plus better compile time, i'm sure
265 2015-12-17T17:01:15  <sipa> spirit was templates all the way down to being able to choose your own container data structures
266 2015-12-17T17:09:50  *** Quent1 has quit IRC
267 2015-12-17T17:10:22  *** Quent has joined #bitcoin-core-dev
268 2015-12-17T17:17:26  *** d_t has quit IRC
269 2015-12-17T17:18:17  *** d_t has joined #bitcoin-core-dev
270 2015-12-17T17:18:29  <wumpus> yes, spirit was also notoriously bad for compile time, due to using templates to generate a scanner/lexer. I also expected dropping it would lower memory usage during compile, but for that it was apparently not the bottleneck
271 2015-12-17T17:22:54  *** molly has joined #bitcoin-core-dev
272 2015-12-17T17:26:05  *** molz has quit IRC
273 2015-12-17T17:43:25  *** adam3us has joined #bitcoin-core-dev
274 2015-12-17T17:43:39  *** paveljanik has joined #bitcoin-core-dev
275 2015-12-17T17:43:39  *** paveljanik has joined #bitcoin-core-dev
276 2015-12-17T18:08:02  <cfields> Luke-Jr: looking
277 2015-12-17T18:08:56  *** fwfewfew has joined #bitcoin-core-dev
278 2015-12-17T18:13:16  <cfields> Luke-Jr: what's missing in the bitcoin build itself? the python libs?
279 2015-12-17T18:14:53  *** brg444 has joined #bitcoin-core-dev
280 2015-12-17T18:21:46  *** go1111111 has quit IRC
281 2015-12-17T18:31:21  <sdaftuar> is it important that we call CheckBlock immediately in ProcessNewBlock and return failure before calling AcceptBlock?
282 2015-12-17T18:32:02  <sdaftuar> it turns out that call to CheckBlock causes us to not permanently mark blocks as failed even if they fail in CheckBlock
283 2015-12-17T18:32:08  *** jl2012 has quit IRC
284 2015-12-17T18:32:35  <sdaftuar> seems like we could just not call it there, and let AcceptBlock do its work?
285 2015-12-17T18:33:06  *** Ylbam has quit IRC
286 2015-12-17T18:33:21  *** jl2012 has joined #bitcoin-core-dev
287 2015-12-17T18:34:30  *** Ylbam has joined #bitcoin-core-dev
288 2015-12-17T18:35:50  <sipa> sdaftuar: interesting!
289 2015-12-17T18:36:13  <sipa> can't we instead make checkblock failure also mark it as invalid?
290 2015-12-17T18:36:43  <sdaftuar> we could, although i think at that point in the code it is possible for the block to not yet have been added to mapBlockIndex.  not 100% sure of that though
291 2015-12-17T18:36:54  <sdaftuar> but it would require duplicating the code from acceptblock
292 2015-12-17T18:37:04  <sdaftuar> seems suboptimal?
293 2015-12-17T18:38:39  <sdaftuar> it seems like we do extra work on every valid block to avoid doing slightly more work on invalid blocks
294 2015-12-17T18:38:44  <sdaftuar> i'm not sure that tradeoff makes sense?
295 2015-12-17T18:38:49  <sipa> oh i see
296 2015-12-17T18:39:17  <sipa> the question is whether a dos attacker gains something by us doing the check later
297 2015-12-17T18:39:20  <sdaftuar> right
298 2015-12-17T18:40:12  <sdaftuar> looks like the only thing we save is a call to AcceptBlockHeader.  i think that's fast?
299 2015-12-17T18:41:03  <sipa> i guess we go from no mapBlockIndex lookup to a lookup
300 2015-12-17T18:41:11  <sipa> i think that's negligable
301 2015-12-17T18:41:33  <sdaftuar> it's certainly negligible compared to bitcoind's current behavior, of repeatedly calling CheckBlock on failed blocks :)
302 2015-12-17T18:42:21  <sipa> agree
303 2015-12-17T18:43:20  <sdaftuar> ok i'll submit a PR to scrap that call to CheckBlock
304 2015-12-17T18:52:55  <cfields> Luke-Jr: what's the point of imagemagick_convert ?
305 2015-12-17T18:53:11  <GitHub173> [bitcoin] sdaftuar opened pull request #7225: Eliminate unnecessary call to CheckBlock (master...eliminate-extra-checkblock) https://github.com/bitcoin/bitcoin/pull/7225
306 2015-12-17T18:54:28  <sdaftuar> wumpus: i really like that comptool has a way to do reject-message testing, this is making tests better and helping uncover strange behaviors...
307 2015-12-17T18:54:43  <cfields> Luke-Jr: oh, it can't export to tiff?
308 2015-12-17T18:57:50  <jonasschnelli> cfields: Luke-Jr's name unify PR works really good. We might want to fix the osx application name ("Bitcoin-Qt").
309 2015-12-17T18:58:19  <cfields> jonasschnelli: yea, i really like the idea
310 2015-12-17T18:58:32  <cfields> jonasschnelli: what was the snag last time? we avoided changing the name for some rason
311 2015-12-17T18:58:34  <cfields> *reason
312 2015-12-17T18:59:31  <jonasschnelli> Yes. We kept bitcoin-qt because otherwise new versions would not overwrite old ones.
313 2015-12-17T18:59:48  <jonasschnelli> But IMO we could rename it once and tell the users to delete the old version (release notes).
314 2015-12-17T19:01:23  *** Amnez777 has quit IRC
315 2015-12-17T19:01:39  *** Amnez777 has joined #bitcoin-core-dev
316 2015-12-17T19:01:40  *** Amnez777 has quit IRC
317 2015-12-17T19:02:12  *** Amnez777 has joined #bitcoin-core-dev
318 2015-12-17T19:24:02  *** jron has joined #bitcoin-core-dev
319 2015-12-17T19:57:13  *** laurentmt has joined #bitcoin-core-dev
320 2015-12-17T19:57:38  *** laurentmt has quit IRC
321 2015-12-17T19:58:44  <GitHub109> [bitcoin] laanwj reopened pull request #7165: WIP: build: Enable C++11 in build, require C++11 compiler (master...2015_12_c++11) https://github.com/bitcoin/bitcoin/pull/7165
322 2015-12-17T20:01:01  <Luke-Jr> jonasschnelli: what's the harm in leaving it?
323 2015-12-17T20:01:27  <Luke-Jr> cfields: pretty much getting the Python stuff (more than just libs- we need cairosvg) installed in a way that configure will find it
324 2015-12-17T20:01:52  <jonasschnelli> Luke-Jr: the filename itself is still "Bitcoin-Qt.app",.. not ideal... but works.
325 2015-12-17T20:02:11  <Luke-Jr> jonasschnelli: I think it's semi-nice that it's not equivalent to the actual display name
326 2015-12-17T20:02:34  <Luke-Jr> but maybe I'm wrong
327 2015-12-17T20:02:40  <cfields> Luke-Jr: i think i've got a workaround for much of the python stuff
328 2015-12-17T20:02:55  <Luke-Jr> cfields: note that the versions in Ubuntu's repo are broken
329 2015-12-17T20:02:59  <cfields> Luke-Jr: in my tests, "rsvg" turned out to work much better
330 2015-12-17T20:03:13  <Luke-Jr> oh
331 2015-12-17T20:03:15  <jonasschnelli> Last time we didn't want to loose the possibility to drop the 0.11 release over the 0.10 release (overwrite old app).
332 2015-12-17T20:03:36  <cfields> Luke-Jr: uses the same underlying libs, but no need for python or imagemagick
333 2015-12-17T20:03:43  <Luke-Jr> I didn't try rsvg :D
334 2015-12-17T20:03:45  <cfields> (it exports to tiff itself)
335 2015-12-17T20:04:04  <jonasschnelli> Changing the whole name from Bitcoin-Qt.app to Bitcoin\ Core.app seems okay for me (with loosing the "replace" functionallity).
336 2015-12-17T20:04:10  <Luke-Jr> jonasschnelli: do users expect Bitcoin Core and Bitcoin LJR to overwrite each other, is the question IMO
337 2015-12-17T20:04:24  <GitHub22> [bitcoin] sdaftuar opened pull request #7226: Tests: Add more tests to p2p-fullblocktest (master...add-more-tests) https://github.com/bitcoin/bitcoin/pull/7226
338 2015-12-17T20:04:31  <jonasschnelli> But LRJ/Core are to different applications.. ;-)
339 2015-12-17T20:04:53  <cfields> jonasschnelli: so now what we have a renamed app, any chance it magically overwrites now?
340 2015-12-17T20:04:59  <jonasschnelli> s/to/two
341 2015-12-17T20:05:26  <jonasschnelli> cfields: nope. Only with an package installer (which sucks).
342 2015-12-17T20:05:38  <cfields> ok
343 2015-12-17T20:05:52  <jonasschnelli> But they need to remove the old app just >once<,... that's okay.
344 2015-12-17T20:06:05  <jonasschnelli> We could detect it in Qt and ask in a Dialog to delete the old app.
345 2015-12-17T20:06:50  <jonasschnelli> (but maybe just warn [one time], deleting outside of a app is not something we should do)
346 2015-12-17T20:07:31  <cfields> jonasschnelli: mm, i'm not a fan of that :)
347 2015-12-17T20:08:00  <cfields> if nothing else, i suspect osx wouldn't let us
348 2015-12-17T20:08:06  <jonasschnelli> Yeah. Same here. I think user can handle that pretty themselfs...
349 2015-12-17T20:08:35  <jonasschnelli> cfields: No. It think would it would just work. (unless we do sandboxing / app store things).
350 2015-12-17T20:08:59  <jonasschnelli> Apps can even move themself into the /Application folder....
351 2015-12-17T20:09:45  <cfields> jonasschnelli: my concern there is that you never know what new restrictions Apple will add in OSX+1
352 2015-12-17T20:09:59  <cfields> (unless it's explicitly allowed somewhere ofc)
353 2015-12-17T20:10:01  <jonasschnelli> hah. So true.
354 2015-12-17T20:14:15  <cfields> Luke-Jr: you want to try switching to rsvg? or should i push up some patches on top of yours?
355 2015-12-17T20:15:00  <Luke-Jr> cfields: I can try, sure; to be clear, it's called rsvg-convert on your system too, I hope? ;)
356 2015-12-17T20:15:29  <Luke-Jr> cfields: this doesn't help with the ds_store/mac_alias modules though, mind you
357 2015-12-17T20:15:56  <cfields> Luke-Jr: yes. rsvg is a symlink to rsvg-convert. and confirmed that rsvg-convert is available through homebrew on osx
358 2015-12-17T20:16:00  <cfields> Luke-Jr: understood
359 2015-12-17T20:16:05  <Luke-Jr> if [ -n "$OSX_SDK" ] <-- what do I change this to?
360 2015-12-17T20:17:30  <cfields> Luke-Jr: uhm, just check for "apple" inside of $HOST maybe?
361 2015-12-17T20:19:28  <Luke-Jr> if [[ "$HOST" =~ apple ]]
362 2015-12-17T20:19:29  <Luke-Jr> ?
363 2015-12-17T20:20:07  <cfields> sure, if that works (i was unaware of that syntax)
364 2015-12-17T20:20:49  <cfields> Luke-Jr: btw, why install ds_store via pip and then manually build/install?
365 2015-12-17T20:21:43  <Luke-Jr> cfields: PIP's ds_store is broken on Travis's old Ubuntu :|
366 2015-12-17T20:21:59  <cfields> oh
367 2015-12-17T20:22:06  <Luke-Jr> but it pulls in deps for us
368 2015-12-17T20:24:03  <cfields> Luke-Jr: ok yea, need to get those working in depends
369 2015-12-17T20:24:17  *** zookolaptop has quit IRC
370 2015-12-17T20:26:32  <Luke-Jr> cfields: can you help with that, while I do the rsvg bits? ;)
371 2015-12-17T20:26:41  <cfields> Luke-Jr: yep, working on it now
372 2015-12-17T20:26:45  <Luke-Jr> thx
373 2015-12-17T20:29:21  <Luke-Jr> cfields: eh, my rsvg-convert doesn't list tiff as supported..?
374 2015-12-17T20:29:36  <cfields> Luke-Jr: gentoo?
375 2015-12-17T20:29:39  <Luke-Jr> yes
376 2015-12-17T20:29:46  <cfields> Luke-Jr: +tiff maybe?
377 2015-12-17T20:30:12  <Luke-Jr> no such flag
378 2015-12-17T20:33:07  <cfields> Luke-Jr: dunno, works here :\
379 2015-12-17T20:33:56  <Luke-Jr> it's literally not in the source code
380 2015-12-17T20:35:10  *** Guyver2 has joined #bitcoin-core-dev
381 2015-12-17T20:35:35  *** BashCo_ has joined #bitcoin-core-dev
382 2015-12-17T20:36:40  <cfields> Luke-Jr: hmm, looks like it lied to me about saving as tiff :\
383 2015-12-17T20:38:16  *** BashCo has quit IRC
384 2015-12-17T20:40:05  <cfields> well that sucks. but it's still cleaner than using the python version
385 2015-12-17T20:40:20  <Luke-Jr> yes
386 2015-12-17T20:40:32  <Luke-Jr> maybe the Ubuntu versions will actually work :D
387 2015-12-17T20:40:45  <Luke-Jr> (trusty/gitian cairosvg had some weird brokenness)
388 2015-12-17T20:56:52  * Luke-Jr stabs rsvg-convert for accepting SVG on stdin, but only if it can be seek'd
389 2015-12-17T20:59:15  *** Cory has quit IRC
390 2015-12-17T21:06:35  *** Cory has joined #bitcoin-core-dev
391 2015-12-17T21:09:09  <Luke-Jr> cfields: ok, got this working (pushed)
392 2015-12-17T21:24:52  *** afk11 has quit IRC
393 2015-12-17T21:25:03  *** afk11 has joined #bitcoin-core-dev
394 2015-12-17T21:31:11  <cfields> Luke-Jr: why not using the release version of ds_store ?
395 2015-12-17T21:31:22  <cfields> (1.0.1)
396 2015-12-17T21:31:27  <Luke-Jr> [20:21:43] <Luke-Jr> cfields: PIP's ds_store is broken on Travis's old Ubuntu :|
397 2015-12-17T21:31:42  <cfields> ok. broken how?
398 2015-12-17T21:32:13  <cfields> ah, https://bitbucket.org/al45tair/ds_store/commits/c80c23706eae5f3b10c2fd32c419fa37709dbede
399 2015-12-17T21:40:22  <Luke-Jr> right
400 2015-12-17T21:42:53  *** afk11 has quit IRC
401 2015-12-17T21:44:25  <cfields> Luke-Jr: https://github.com/theuni/bitcoin/commit/be298535153f71fada029eef82850557ef6ce1d7
402 2015-12-17T21:44:37  <cfields> sorry, built that on top of 0.12 on accident
403 2015-12-17T21:45:11  <cfields> Luke-Jr: from makefile, might need to invoke via: PYTHONPATH=$(PYTHONPATH) python foo
404 2015-12-17T21:48:11  *** randy-waterhouse has joined #bitcoin-core-dev
405 2015-12-17T22:00:50  *** raedah has joined #bitcoin-core-dev
406 2015-12-17T22:07:53  *** treehug88 has quit IRC
407 2015-12-17T22:11:31  *** pmienk has quit IRC
408 2015-12-17T22:26:42  *** afk11 has joined #bitcoin-core-dev
409 2015-12-17T22:37:28  *** zookolaptop has joined #bitcoin-core-dev
410 2015-12-17T22:41:26  *** Ylbam has quit IRC
411 2015-12-17T22:43:31  *** Ylbam has joined #bitcoin-core-dev
412 2015-12-17T23:14:02  *** Guyver2 has quit IRC
413 2015-12-17T23:21:40  *** BlueMatt has left #bitcoin-core-dev
414 2015-12-17T23:32:05  *** laurentmt has joined #bitcoin-core-dev
415 2015-12-17T23:32:08  *** laurentmt has quit IRC
416 2015-12-17T23:52:30  *** afk11 has quit IRC
417 2015-12-17T23:52:43  *** afk11 has joined #bitcoin-core-dev