1 2016-04-19T00:06:56  *** Samdney has quit IRC
  2 2016-04-19T00:32:58  <phantomcircuit> cfields: what's the best way to add a new binary to the auto tools stuff? i tried copying bitcoin-tx stuff and renaming it but things exploded
  3 2016-04-19T00:33:18  <cfields> exploded?
  4 2016-04-19T00:33:52  <phantomcircuit> complained about things in script.h being redefined
  5 2016-04-19T00:33:55  <phantomcircuit> i'll try again
  6 2016-04-19T00:34:06  <cfields> phantomcircuit: i'd need to see what you tried
  7 2016-04-19T00:37:08  *** btcdrak has quit IRC
  8 2016-04-19T00:37:53  <phantomcircuit> and of course it worked this time
  9 2016-04-19T00:38:08  <phantomcircuit> only thing i did differently was git clean -fdx
 10 2016-04-19T00:38:16  <phantomcircuit> but i guess there's something cached that messed it up before
 11 2016-04-19T00:38:45  <gmaxwell> phantomcircuit: I told you talking to cfields would fix your problems.
 12 2016-04-19T00:39:08  <cfields> heh
 13 2016-04-19T00:40:23  <cfields> phantomcircuit: mm, there really shouldn't be any way for that to happen though, unless you're building with crazy options
 14 2016-04-19T00:40:46  <phantomcircuit>  --without-gui --disable-wallet
 15 2016-04-19T00:40:53  <phantomcircuit> nothing else
 16 2016-04-19T00:41:06  <cfields> i think there are some edge-cases where static libs don't get recreated when you're messing with the Makefiles though. Sounds like maybe you had objects linked in twice as a result of something like that
 17 2016-04-19T00:42:34  <cfields> gmaxwell: any chance you've ever investigated how often the opportunistic write in EndMessage() ends up being hit?
 18 2016-04-19T00:42:49  <gmaxwell> Not that I can recall.
 19 2016-04-19T00:43:02  <cfields> ok
 20 2016-04-19T00:45:27  <phantomcircuit> cfields: in general socket send() calls typically succeed completely or fail completely
 21 2016-04-19T00:48:04  <cfields> phantomcircuit: "completely" meaning it swallows the entire buffer it's handed?
 22 2016-04-19T00:48:47  *** fengling has joined #bitcoin-core-dev
 23 2016-04-19T00:49:04  <phantomcircuit> cfields, as long as the tcp buffer in the kernel is larger than the buffer being sent then it will complete
 24 2016-04-19T00:49:08  <BlueMatt> i mean it will if there is room in tcp buf
 25 2016-04-19T00:49:08  <gmaxwell> by 'general' he means on linux. on windows the default tcp socket buffers are like 8k.
 26 2016-04-19T00:49:40  <phantomcircuit> cfields: why do you ask though?
 27 2016-04-19T00:49:50  <cfields> right, i wouldn't think that would hold true in many cases
 28 2016-04-19T00:50:19  <cfields> phantomcircuit: mainly curious how often we're sending with an empty send queue, regardless of the msg/tcp buffer size
 29 2016-04-19T00:53:25  <phantomcircuit> cfields, yes im curious why you're curious
 30 2016-04-19T00:55:59  <cfields> phantomcircuit: the opportunistic send breaks my abstraction model. The connection manager needs to hold total send/recv stats, as opposed to static vars in CNode as it is now. Just thinking through how best to handle it.
 31 2016-04-19T00:56:46  <cfields> it's actually not a problem at all, but I'm writing some interim code movement for easier review
 32 2016-04-19T00:59:08  <cfields> (put more plainly, the issue is that the opportunistic send causes send() to be called from 2 threads)
 33 2016-04-19T00:59:48  <phantomcircuit> cfields: the opportunistic send thing can go away, it just means you'll have an extra memory copy
 34 2016-04-19T01:04:11  <cfields> phantomcircuit: my concern was that it's helpful as an optim to prioritize immediate sends (version msg after connect, for example) over others. I can't imagine it matters much, though.
 35 2016-04-19T01:05:30  <phantomcircuit> cfields, it means those things are sent after the recv handler completes
 36 2016-04-19T01:06:01  <phantomcircuit> although actually there could be a conditional triggered to get the thread that sends stuff to wake up when there's data available
 37 2016-04-19T01:06:38  <cfields> right
 38 2016-04-19T01:13:04  *** belcher has quit IRC
 39 2016-04-19T01:14:12  *** kexkey has joined #bitcoin-core-dev
 40 2016-04-19T01:22:34  *** kexkey has quit IRC
 41 2016-04-19T01:23:55  *** Chris_Stewart_5 has quit IRC
 42 2016-04-19T01:25:54  *** Kexkey has joined #bitcoin-core-dev
 43 2016-04-19T01:30:06  *** dermoth_ has quit IRC
 44 2016-04-19T01:30:47  *** dermoth_ has joined #bitcoin-core-dev
 45 2016-04-19T01:32:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 46 2016-04-19T01:32:59  *** Ylbam has quit IRC
 47 2016-04-19T01:49:37  *** go1111111 has joined #bitcoin-core-dev
 48 2016-04-19T01:56:49  *** Kexkey has quit IRC
 49 2016-04-19T02:00:15  *** dermoth_ has quit IRC
 50 2016-04-19T02:00:50  *** dermoth_ has joined #bitcoin-core-dev
 51 2016-04-19T02:28:13  *** Chris_Stewart_5 has quit IRC
 52 2016-04-19T02:31:36  *** jtimon has quit IRC
 53 2016-04-19T03:15:43  *** jtimon has joined #bitcoin-core-dev
 54 2016-04-19T03:35:09  *** harding has quit IRC
 55 2016-04-19T03:35:37  *** jtimon has quit IRC
 56 2016-04-19T03:36:09  *** harding has joined #bitcoin-core-dev
 57 2016-04-19T03:40:34  *** amiller has quit IRC
 58 2016-04-19T03:59:13  *** xiangfu has joined #bitcoin-core-dev
 59 2016-04-19T04:04:47  *** xiangfu has quit IRC
 60 2016-04-19T04:05:27  *** xiangfu has joined #bitcoin-core-dev
 61 2016-04-19T04:08:00  *** mrkent has quit IRC
 62 2016-04-19T04:09:03  *** Guest43084 has joined #bitcoin-core-dev
 63 2016-04-19T04:20:11  *** gijensen is now known as gijensen_
 64 2016-04-19T04:27:54  *** Guest43084 has quit IRC
 65 2016-04-19T04:33:24  *** xiangfu has quit IRC
 66 2016-04-19T04:35:04  *** amiller_ has joined #bitcoin-core-dev
 67 2016-04-19T04:40:18  *** paveljanik has quit IRC
 68 2016-04-19T04:44:48  *** TomMc has quit IRC
 69 2016-04-19T05:00:11  *** btcdrak has joined #bitcoin-core-dev
 70 2016-04-19T05:12:01  *** Alopex has quit IRC
 71 2016-04-19T05:13:07  *** Alopex has joined #bitcoin-core-dev
 72 2016-04-19T05:17:00  *** cryptocoder has quit IRC
 73 2016-04-19T05:21:50  *** BashCo has quit IRC
 74 2016-04-19T05:50:55  *** BashCo has joined #bitcoin-core-dev
 75 2016-04-19T05:56:20  *** cryptocoder has joined #bitcoin-core-dev
 76 2016-04-19T06:02:09  <GitHub89> [bitcoin] pstratem opened pull request #7907:  Optimize and Cleanup CScript::FindAndDelete (master...2016-04-17-findanddelete) https://github.com/bitcoin/bitcoin/pull/7907
 77 2016-04-19T06:13:23  *** frankenmint has quit IRC
 78 2016-04-19T06:15:22  *** d_t has quit IRC
 79 2016-04-19T06:26:17  *** [Author] has quit IRC
 80 2016-04-19T06:29:01  *** Alopex has quit IRC
 81 2016-04-19T06:30:06  *** Alopex has joined #bitcoin-core-dev
 82 2016-04-19T06:31:46  *** [Author] has joined #bitcoin-core-dev
 83 2016-04-19T06:33:45  *** mrkent_ has joined #bitcoin-core-dev
 84 2016-04-19T06:41:32  *** xiangfu has joined #bitcoin-core-dev
 85 2016-04-19T06:50:22  *** cryptocoder has quit IRC
 86 2016-04-19T06:51:53  *** mrkent_ has quit IRC
 87 2016-04-19T06:55:24  *** mrkent_ has joined #bitcoin-core-dev
 88 2016-04-19T07:12:52  *** xiangfu_ has joined #bitcoin-core-dev
 89 2016-04-19T07:17:52  *** xiangfu_ has quit IRC
 90 2016-04-19T07:18:01  *** Alopex has quit IRC
 91 2016-04-19T07:19:06  *** Alopex has joined #bitcoin-core-dev
 92 2016-04-19T07:22:24  <gmaxwell> something intresting...
 93 2016-04-19T07:22:30  <gmaxwell> $ grep 'received: notfound' ~/.bitcoin/debug.log | cut -d' ' -f1 | sort | uniq -c | sort -n
 94 2016-04-19T07:22:52  <gmaxwell>     145 2016-04-12
 95 2016-04-19T07:22:53  <gmaxwell>     296 2016-04-13
 96 2016-04-19T07:22:53  <gmaxwell>     728 2016-04-15
 97 2016-04-19T07:22:53  <gmaxwell>     938 2016-04-16
 98 2016-04-19T07:22:53  <gmaxwell>    1155 2016-04-17
 99 2016-04-19T07:22:55  <gmaxwell>    1384 2016-04-14
100 2016-04-19T07:22:58  <gmaxwell>    1863 2016-04-19
101 2016-04-19T07:23:00  <gmaxwell>    2832 2016-04-18
102 2016-04-19T07:23:05  <gmaxwell> 19 is low because we're only 7.5 hours into the day.
103 2016-04-19T07:23:29  <gmaxwell> but it's on track to be over 5000 based on that.
104 2016-04-19T07:26:05  <gmaxwell> Anyone else seeing this?
105 2016-04-19T07:28:04  <gmaxwell> anyone have debugnet logs going back betore the 11th?
106 2016-04-19T07:47:51  *** Ylbam has joined #bitcoin-core-dev
107 2016-04-19T07:54:26  *** Ylbam has quit IRC
108 2016-04-19T07:57:46  *** Ylbam has joined #bitcoin-core-dev
109 2016-04-19T08:02:03  *** adam3us has quit IRC
110 2016-04-19T08:02:41  *** adam3us has joined #bitcoin-core-dev
111 2016-04-19T08:07:27  *** jannes has joined #bitcoin-core-dev
112 2016-04-19T08:24:10  <GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d28995018003...fc9e3346e674
113 2016-04-19T08:24:10  <GitHub26> bitcoin/master a3310b4 Wladimir J. van der Laan: txdb: Fix assert crash in new UTXO set cursor...
114 2016-04-19T08:24:11  <GitHub26> bitcoin/master fc9e334 Wladimir J. van der Laan: Merge #7904: txdb: Fix assert crash in new UTXO set cursor...
115 2016-04-19T08:24:20  <GitHub13> [bitcoin] laanwj closed pull request #7904: txdb: Fix assert crash in new UTXO set cursor (master...2016_04_fix_utxo_iterator) https://github.com/bitcoin/bitcoin/pull/7904
116 2016-04-19T08:25:35  <GitHub161> [bitcoin] laanwj closed pull request #7894: [Qt] Use CURRENCY_UNIT for BitcoinUnits. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/7894
117 2016-04-19T08:26:29  <GitHub160> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc9e3346e674...fa9d86f8c4f4
118 2016-04-19T08:26:30  <GitHub160> bitcoin/master fa05e22 MarcoFalke: [qa] pull-tester: Don't mute zmq ImportError
119 2016-04-19T08:26:30  <GitHub160> bitcoin/master faa4f22 MarcoFalke: [qa] pull-tester: Exit early when no tests are run
120 2016-04-19T08:26:31  <GitHub160> bitcoin/master fae1f4e MarcoFalke: [qa] rpc-tests: Fix link in comment and label error msg
121 2016-04-19T08:26:39  <GitHub131> [bitcoin] laanwj closed pull request #7851: [qa] pull-tester: Don't mute zmq ImportError (master...Mf1604-qaUnmuteError) https://github.com/bitcoin/bitcoin/pull/7851
122 2016-04-19T08:45:10  <GitHub170> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa9d86f8c4f4...4205ad7ca2b1
123 2016-04-19T08:45:10  <GitHub170> bitcoin/master 87049e8 mrbandrews: Speed up getchaintips.
124 2016-04-19T08:45:11  <GitHub170> bitcoin/master 4205ad7 Wladimir J. van der Laan: Merge #7827: Speed up getchaintips....
125 2016-04-19T08:45:19  <GitHub49> [bitcoin] laanwj closed pull request #7827: Speed up getchaintips. (master...ba-fix-chaintips) https://github.com/bitcoin/bitcoin/pull/7827
126 2016-04-19T08:50:05  <GitHub49> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/4205ad7ca2b1...187186b0fe03
127 2016-04-19T08:50:06  <GitHub49> bitcoin/master de39c95 Wladimir J. van der Laan: test: move accounting_tests and rpc_wallet_tests to wallet/test...
128 2016-04-19T08:50:07  <GitHub49> bitcoin/master f4eae2d Wladimir J. van der Laan: test: Create test fixture for wallet...
129 2016-04-19T08:50:07  <GitHub49> bitcoin/master a25a4f5 Wladimir J. van der Laan: wallet_ismine.h → script/ismine.h...
130 2016-04-19T08:50:16  <GitHub112> [bitcoin] laanwj closed pull request #7905: test: move accounting_tests and rpc_wallet_tests to wallet/test (master...2016_04_accounting_tests_to_wallet) https://github.com/bitcoin/bitcoin/pull/7905
131 2016-04-19T08:51:20  <wumpus> gmaxwell: no, don't have netdebug logs, but wow that's a huge increase
132 2016-04-19T08:51:31  <wumpus> that's the number of notfounds sent or received?
133 2016-04-19T08:51:55  <gmaxwell> thats recieved.
134 2016-04-19T08:52:55  <gmaxwell> my sending went up too... but I don't know if my sending counts are representative since I'm running #7840.
135 2016-04-19T08:53:16  *** xiangfu_ has joined #bitcoin-core-dev
136 2016-04-19T08:53:30  <gmaxwell>    1236 2016-04-11
137 2016-04-19T08:53:30  <gmaxwell>    3469 2016-04-12
138 2016-04-19T08:53:30  <gmaxwell>    2961 2016-04-13
139 2016-04-19T08:53:30  <gmaxwell>    5494 2016-04-14
140 2016-04-19T08:53:30  <gmaxwell>    6788 2016-04-15
141 2016-04-19T08:53:33  <gmaxwell>   14933 2016-04-16
142 2016-04-19T08:53:35  <gmaxwell>   10706 2016-04-17
143 2016-04-19T08:53:38  <gmaxwell>   10018 2016-04-18
144 2016-04-19T08:53:40  <gmaxwell>    5225 2016-04-19
145 2016-04-19T09:19:24  <phantomcircuit> gmaxwell: that's kind of weird
146 2016-04-19T09:19:29  <phantomcircuit> also
147 2016-04-19T09:19:33  <phantomcircuit> how did you notice this?
148 2016-04-19T09:19:35  <phantomcircuit> :)
149 2016-04-19T09:22:46  <wumpus> if it's anything like how I notice these things he just saw a lot of notfounds in his log, wondered what, and then decided to do statistics on them
150 2016-04-19T09:23:41  <gmaxwell> yea, I normally have debug logs scrolling by, and when I sense a glitch in the matrix I run stats.
151 2016-04-19T09:23:43  <wumpus> could be a few strangely-behaved peers, it's not sudden enough for a code change
152 2016-04-19T09:24:07  <gmaxwell> I'm seeing it on two nodes though the pattern is pretty different.
153 2016-04-19T09:24:11  <wumpus> (e.g. if we had suddenly started waiting longer before requesting a transaction inved to us, you'd see more of a sudden jump)
154 2016-04-19T09:24:53  <gmaxwell> it could be a side effect of some kind of denial of service happening to peers.
155 2016-04-19T09:25:46  <gmaxwell> but ... pretty huge delay to see notfounds. It also could be some party trying to deanonymize the network graph by doing some mutually exclusive propagation stunts.
156 2016-04-19T09:26:21  <sipa> are the tx or block notfounds?
157 2016-04-19T09:26:27  <gmaxwell> tx.
158 2016-04-19T09:26:50  <sipa> i don't understand... *your* are the one running 7840
159 2016-04-19T09:27:01  <gmaxwell> I think it's unrelated to 7840.
160 2016-04-19T09:27:36  <gmaxwell> On the _sending_ not founds, that could be due to 7840. But recieving, no.
161 2016-04-19T09:27:39  <sipa> ah
162 2016-04-19T09:28:00  <gmaxwell> also I've been running 7840 for a while; and this seems to have ramped.
163 2016-04-19T09:29:40  <gmaxwell> e.g. for deanon, step 1 give all nodes except two nodes TX A while giving those nodes node A'.  Then step 2. create B which is a derivative of A', and give to one of them, and you'll learn if they're directly connected.
164 2016-04-19T09:30:07  <gmaxwell> and I'm sure there are lots of other variations on that, including more efficient ones, regardless, they'll likely cause a lot of NOTFOUNDS.
165 2016-04-19T09:30:43  <gmaxwell> Also, because GETDATA since the introduction of the mempool RPC will return things that aren't in the relay pool, someone could be using GETDATA to bypass inv delays.
166 2016-04-19T09:30:56  <gmaxwell> (man, that mempool message is the privacy leak that keeps on giving)
167 2016-04-19T09:33:07  <sipa> so you think this is a deanonymization technique?
168 2016-04-19T09:36:02  <gmaxwell> maybe, seeing if I can get more or less evidence for that.
169 2016-04-19T09:41:19  <GitHub199> [bitcoin] laanwj closed pull request #7625: Bugfix: Check for bench_bitcoin being enabled where needed, and skip UniValue dependency when unused (master...bugfix_bench_checks) https://github.com/bitcoin/bitcoin/pull/7625
170 2016-04-19T09:43:52  <gmaxwell> I really can't tell, the highest notfound sending peers I have claim to be 0.11.x.
171 2016-04-19T09:44:18  <gmaxwell> but it's not confined to a few peers.
172 2016-04-19T09:44:31  <gmaxwell> notfounds could also be cause by blocks which are mining many doublespends.
173 2016-04-19T09:44:47  <gmaxwell> since the block will evict the transactions from mempools.
174 2016-04-19T09:50:08  *** mrkent_ has quit IRC
175 2016-04-19T10:02:25  *** AaronvanW has joined #bitcoin-core-dev
176 2016-04-19T10:02:59  *** Ylbam has quit IRC
177 2016-04-19T10:18:00  *** AaronvanW has quit IRC
178 2016-04-19T10:20:07  *** Ylbam has joined #bitcoin-core-dev
179 2016-04-19T10:27:46  *** fengling has quit IRC
180 2016-04-19T10:55:52  *** xiangfu_ has quit IRC
181 2016-04-19T11:45:09  *** laurentmt has joined #bitcoin-core-dev
182 2016-04-19T11:47:04  *** laurentmt has quit IRC
183 2016-04-19T11:54:50  *** xiangfu has quit IRC
184 2016-04-19T11:55:08  *** AaronvanW has joined #bitcoin-core-dev
185 2016-04-19T11:55:09  *** AaronvanW has joined #bitcoin-core-dev
186 2016-04-19T12:05:42  *** Giszmo has joined #bitcoin-core-dev
187 2016-04-19T12:08:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
188 2016-04-19T12:17:28  *** jtimon has joined #bitcoin-core-dev
189 2016-04-19T12:19:58  *** assder has quit IRC
190 2016-04-19T12:19:59  *** cjcj has quit IRC
191 2016-04-19T12:22:52  *** jtimon has quit IRC
192 2016-04-19T12:42:14  *** assder has joined #bitcoin-core-dev
193 2016-04-19T12:42:40  *** jtimon has joined #bitcoin-core-dev
194 2016-04-19T12:44:59  *** galileopy has quit IRC
195 2016-04-19T12:58:52  <GitHub84> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/187186b0fe03...0e6fd5e4af31
196 2016-04-19T12:58:53  <GitHub84> bitcoin/master fa942c7 Joao Fonseca: Move method to check matches within arrays on util.py
197 2016-04-19T12:58:53  <GitHub84> bitcoin/master 5d217de Joao Fonseca: Add test to check spendable and unspendable UTXO on RPC listunspent
198 2016-04-19T12:58:54  <GitHub84> bitcoin/master 0e6fd5e Wladimir J. van der Laan: Merge #7822: Add listunspent() test for spendable/unspendable UTXO...
199 2016-04-19T12:59:02  <GitHub40> [bitcoin] laanwj closed pull request #7822: Add listunspent() test for spendable/unspendable UTXO (master...support/add-test-listunspent) https://github.com/bitcoin/bitcoin/pull/7822
200 2016-04-19T13:32:25  *** Amnez777 has quit IRC
201 2016-04-19T13:39:03  *** cryptapus_ has joined #bitcoin-core-dev
202 2016-04-19T13:39:15  *** cryptapus_ is now known as cryptapus
203 2016-04-19T13:45:05  <GitHub37> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e6fd5e4af31...a1eb344ba8f4
204 2016-04-19T13:45:07  <GitHub37> bitcoin/master de821d5 Jonas Schnelli: [ZMQ] refactor message string
205 2016-04-19T13:45:07  <GitHub37> bitcoin/master 0b25a9f Jonas Schnelli: [ZMQ] append a message sequence number to every ZMQ notification
206 2016-04-19T13:45:07  <GitHub37> bitcoin/master a1eb344 Wladimir J. van der Laan: Merge #7762: [ZMQ] append a message sequence number to every ZMQ notification...
207 2016-04-19T13:45:11  <GitHub76> [bitcoin] laanwj closed pull request #7762: [ZMQ] append a message sequence number to every ZMQ notification (master...2016/03/zmq_seq) https://github.com/bitcoin/bitcoin/pull/7762
208 2016-04-19T13:47:31  *** murch has joined #bitcoin-core-dev
209 2016-04-19T13:50:35  *** Guyver2 has joined #bitcoin-core-dev
210 2016-04-19T13:51:37  *** TomMc has joined #bitcoin-core-dev
211 2016-04-19T13:52:34  *** cryptapus has quit IRC
212 2016-04-19T13:58:21  *** BashCo has quit IRC
213 2016-04-19T13:58:56  *** zooko has joined #bitcoin-core-dev
214 2016-04-19T13:59:07  *** cryptapus has joined #bitcoin-core-dev
215 2016-04-19T13:59:07  *** cryptapus has joined #bitcoin-core-dev
216 2016-04-19T14:08:50  *** galileopy has joined #bitcoin-core-dev
217 2016-04-19T14:11:19  <GitHub29> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1eb344ba8f4...04a29373571d
218 2016-04-19T14:11:19  <GitHub29> bitcoin/master fabbf80 MarcoFalke: [ui] Move InitError, InitWarning, AmountErrMsg
219 2016-04-19T14:11:20  <GitHub29> bitcoin/master fa10ce6 MarcoFalke: Move ui_interface.cpp to libbitcoin_server_a_SOURCES...
220 2016-04-19T14:11:20  <GitHub29> bitcoin/master 04a2937 Wladimir J. van der Laan: Merge #7787: [Moveonly] Create ui_interface.cpp...
221 2016-04-19T14:11:24  <GitHub145> [bitcoin] laanwj closed pull request #7787: [Moveonly] Create ui_interface.cpp (master...Mf1604-move-ui-helpers) https://github.com/bitcoin/bitcoin/pull/7787
222 2016-04-19T14:20:00  *** BashCo has joined #bitcoin-core-dev
223 2016-04-19T14:21:58  *** mkarrer has joined #bitcoin-core-dev
224 2016-04-19T14:33:58  <NicolasDorier> I was investigating https://github.com/sipa/bitcoin/issues/73
225 2016-04-19T14:34:12  <NicolasDorier> it seems the error does not come from the segwit branch, but is a current bug
226 2016-04-19T14:34:28  <NicolasDorier> basically, sendtoaddress is called in rpc
227 2016-04-19T14:34:59  <NicolasDorier> between the call to CWallet::CreateTransaction and CWallet::CommitTransaction, there can be a reorg resulting in a smaller chain
228 2016-04-19T14:35:18  <NicolasDorier> if it happens, the CommitTransaction will fails because of nLockTime
229 2016-04-19T14:35:30  *** galileopy has quit IRC
230 2016-04-19T14:35:35  <NicolasDorier> however, when the next block is found the "failed transaction" get broadcasted
231 2016-04-19T14:35:48  <NicolasDorier> this may result in people sending twice the money by mistake.
232 2016-04-19T14:36:07  <NicolasDorier> I noticed that CreateTransaction use chainActive without holding cs_main
233 2016-04-19T14:36:22  <sipa> ho!
234 2016-04-19T14:37:05  <NicolasDorier> nor any parent, it seems
235 2016-04-19T14:37:28  <NicolasDorier> relevant link : https://github.com/bitcoin/bitcoin/blob/d28995018003db699b0b528f5e97e9002c3feeb9/src/wallet/rpcwallet.cpp#L365
236 2016-04-19T14:39:17  <NicolasDorier> I think the way to fix this bug is to lock the chain at the caller method
237 2016-04-19T14:39:47  <NicolasDorier> which is SendMoney (https://github.com/bitcoin/bitcoin/blob/d28995018003db699b0b528f5e97e9002c3feeb9/src/wallet/rpcwallet.cpp#L365)
238 2016-04-19T14:40:20  <NicolasDorier> however, ::CommitTransaction get the lock. I don't know if we can lock two times cs_main in the same thread.
239 2016-04-19T14:40:48  <sipa> yes, we can
240 2016-04-19T14:40:54  <sipa> it's a recursive lock
241 2016-04-19T14:41:52  <NicolasDorier> ok so that should do it. I'll try that and ask T909 to try again
242 2016-04-19T14:44:31  <NicolasDorier> mmmh no I'm wrong
243 2016-04-19T14:44:38  <NicolasDorier> the lock is taken in the top rpc method
244 2016-04-19T14:44:43  <NicolasDorier> so not that :/
245 2016-04-19T14:49:58  <NicolasDorier> mmh, https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2012
246 2016-04-19T14:50:10  <NicolasDorier> there is one chance on 100 that the transaction is not final it seems
247 2016-04-19T14:50:21  <NicolasDorier> ah no...
248 2016-04-19T14:50:53  <NicolasDorier> since it should be included in next block seems I'm wrong on the cause
249 2016-04-19T14:57:35  *** Amnez777 has joined #bitcoin-core-dev
250 2016-04-19T14:58:06  <sipa> NicolasDorier: where does this 1 in 100 number come from?
251 2016-04-19T14:58:26  <NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2019
252 2016-04-19T14:58:50  <NicolasDorier> in the case of the bug we got 0
253 2016-04-19T14:59:46  <sipa> that branch has a chance of 1 in 100 to trigger
254 2016-04-19T14:59:56  <sipa> so there is a chance of 90.1%
255 2016-04-19T15:00:08  <sipa> that nLocktime equals the current height
256 2016-04-19T15:00:25  *** zooko has quit IRC
257 2016-04-19T15:00:30  <sipa> and in that case it should still be acceptable to the mempool (which uses chainactive+1 to finality check)
258 2016-04-19T15:01:08  <NicolasDorier> oh yes indeed... ok I continue searching...
259 2016-04-19T15:01:59  *** cryptapus has quit IRC
260 2016-04-19T15:03:38  <morcos> gmaxwell: i took a look at 4 different nodes, i didn't see much consistency in how many notfounds i received.  3 of the nodes were generally quite small, a few hundred a day.
261 2016-04-19T15:04:47  <morcos> gmaxwell: one of the nodes received several thousand a day and 19k on 4-16, but still received 6-7k on 4-10 and 4-11, so it seems more variance than a clear increase
262 2016-04-19T15:05:01  <morcos> might be interesting to understand what causes more of them
263 2016-04-19T15:06:32  *** murch has quit IRC
264 2016-04-19T15:06:36  *** frankenmint has joined #bitcoin-core-dev
265 2016-04-19T15:08:19  *** SteveTaylor has joined #bitcoin-core-dev
266 2016-04-19T15:08:33  *** pedrobranco has joined #bitcoin-core-dev
267 2016-04-19T15:13:59  *** cryptapus has joined #bitcoin-core-dev
268 2016-04-19T15:14:00  *** cryptapus has joined #bitcoin-core-dev
269 2016-04-19T15:20:34  <NicolasDorier> btw, I think it is risky to add a transaction to the wallet before it has been accepted by the mempool (https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2285)
270 2016-04-19T15:21:25  <sipa> i agree
271 2016-04-19T15:22:35  *** galileopy has joined #bitcoin-core-dev
272 2016-04-19T15:22:49  <GitHub10> [bitcoin] sipa opened pull request #7910: Segregated witness (master...segwit-master) https://github.com/bitcoin/bitcoin/pull/7910
273 2016-04-19T15:22:54  <morcos> NicolasDorier: sipa: why is that necessarily risky?  it seems to me we should move the other direction.  separating wh
274 2016-04-19T15:22:57  <morcos> woo hoo!
275 2016-04-19T15:23:30  *** pedrobranco has quit IRC
276 2016-04-19T15:23:32  <morcos> (continued) ether a tx is broadcast or in the mempool from its inclusion in your wallet.  And then having some way of informing the wallet of its status
277 2016-04-19T15:23:38  *** pedrobranco has joined #bitcoin-core-dev
278 2016-04-19T15:24:00  <GitHub166> [bitcoin] jonasschnelli closed pull request #7404: [WIP] Segregated Witness (0.12...segwit) https://github.com/bitcoin/bitcoin/pull/7404
279 2016-04-19T15:24:51  <jonasschnelli> \o/
280 2016-04-19T15:25:11  <sipa> ugh, github messes up the commit list
281 2016-04-19T15:25:16  <NicolasDorier> morcos: there is this bug https://github.com/sipa/bitcoin/issues/73, I'll find out what happen later, but the problem is that the transaction is rejected by mempool but still added to wallet transactions. Then after one block, the transaction is rebroadcasted but this time accepted to mempool. The caller of sendtoaddress got an error and thought the money
282 2016-04-19T15:25:17  <NicolasDorier> was not sent, and retried the command, resulting in sending money two times
283 2016-04-19T15:25:56  <sipa> morcos: i guess it could be 1) "probe" the mempool whether it would be accepted 2) add to wallet 3) broadcast
284 2016-04-19T15:26:15  <morcos> sipa: awesome work on segwit, i guess i know where i'm spending my time this week
285 2016-04-19T15:26:17  <NicolasDorier> "probing the mempool" could be also useful for verifytransaction
286 2016-04-19T15:27:11  <sipa> i'm not sure whether i should maintain both the 0.12 and master branch independently now, or just work on master, get that review, and then backport again
287 2016-04-19T15:27:12  <morcos> NicolasDorier: ah, ok so i agree, that we need to clean up the behavior, hadn't read that issue before.  but it definitely shouldn't be ambigious whether a tx is broadcast or not.
288 2016-04-19T15:27:41  <morcos> sipa: do you have both branches ready now?
289 2016-04-19T15:28:05  <sipa> yes
290 2016-04-19T15:28:09  <morcos> i kind of think we should have as much of a merge freeze as possible and just all buckle down to review segwit
291 2016-04-19T15:28:17  <morcos> so that would speak to getting both branches out now
292 2016-04-19T15:28:55  *** galileopy has quit IRC
293 2016-04-19T15:29:11  <morcos> it would be nice if the 0.12 branch got some review from fresh eyes, instead of people just trying to verify its a correct backport.  with this much code thats prone to failure
294 2016-04-19T15:29:14  <sipa> the reasoning against two branches is that it has a higher chance of resulting in unreviewed mistakes in 0.12
295 2016-04-19T15:29:46  <sipa> the reasoning against just master-based review is that it may interfere with for example the py3 changes
296 2016-04-19T15:30:51  <morcos> personally i think it makes sense if some of us concentrate review on 0.12 and then take a look at master to see if we think its a proper forward port, and some of us work in the opposite direction.
297 2016-04-19T15:31:10  <morcos> whenever a bug is found or a change made in one..  then you can port it to the other
298 2016-04-19T15:31:28  <morcos> but it should really be up to you and wumpus i guess to figrue out how to best do this
299 2016-04-19T15:31:50  <morcos> merging other stuff in the middle, just seems like a mistake though...  lets get segwit merged
300 2016-04-19T15:32:17  *** cryptocoder has joined #bitcoin-core-dev
301 2016-04-19T15:32:56  <sipa> open question: do i "fake" the author dates of the commits to make github show it in the correct order?
302 2016-04-19T15:34:04  <morcos> sipa: meh
303 2016-04-19T16:10:20  <instagibbs> sipa, you doubled the "Since github shows" statement
304 2016-04-19T16:11:04  <sipa> instagibbs: thanks, fixed
305 2016-04-19T16:11:41  *** frankenmint has quit IRC
306 2016-04-19T16:12:02  *** frankenmint has joined #bitcoin-core-dev
307 2016-04-19T16:13:32  <instagibbs> really glad to see this pull
308 2016-04-19T16:23:45  *** Guyver2_ has joined #bitcoin-core-dev
309 2016-04-19T16:26:47  *** Guyver2 has quit IRC
310 2016-04-19T16:26:49  *** Guyver2_ is now known as Guyver2
311 2016-04-19T16:28:48  *** cryptocoder has quit IRC
312 2016-04-19T16:34:30  *** cryptocoder has joined #bitcoin-core-dev
313 2016-04-19T16:39:27  *** amiller_ has quit IRC
314 2016-04-19T16:39:34  <btcdrak> nice work sipa!
315 2016-04-19T16:40:45  *** Guyver2_ has joined #bitcoin-core-dev
316 2016-04-19T16:41:07  *** Guest87203 has joined #bitcoin-core-dev
317 2016-04-19T16:44:52  *** Guyver2 has quit IRC
318 2016-04-19T16:45:00  *** Guyver2_ is now known as Guyver2
319 2016-04-19T16:47:08  *** laurentmt has joined #bitcoin-core-dev
320 2016-04-19T16:47:46  *** laurentmt has quit IRC
321 2016-04-19T16:49:28  <Chris_Stewart_5> ^^^^\
322 2016-04-19T16:54:37  <instagibbs> can someone share their segnet node ip/seed?
323 2016-04-19T16:54:55  <instagibbs> also, how to run segnet regtest?
324 2016-04-19T16:55:06  <sipa> bitcoin.sipa.be is a node, and run with -segnet
325 2016-04-19T16:55:45  <instagibbs> oh nevermind, it managed to find peers after a bit
326 2016-04-19T16:56:32  *** Guyver2 has quit IRC
327 2016-04-19T17:02:41  *** Amnez777 has quit IRC
328 2016-04-19T17:07:59  *** Guyver2 has joined #bitcoin-core-dev
329 2016-04-19T17:08:31  *** Amnez777 has joined #bitcoin-core-dev
330 2016-04-19T17:17:11  *** paveljanik has joined #bitcoin-core-dev
331 2016-04-19T17:17:11  *** paveljanik has joined #bitcoin-core-dev
332 2016-04-19T17:24:07  *** AaronvanW has quit IRC
333 2016-04-19T17:53:41  *** slackircbridge has joined #bitcoin-core-dev
334 2016-04-19T18:00:33  *** zooko has joined #bitcoin-core-dev
335 2016-04-19T18:05:28  *** galileopy has joined #bitcoin-core-dev
336 2016-04-19T18:11:19  *** cryptapus__ has joined #bitcoin-core-dev
337 2016-04-19T18:15:11  *** cryptapus has quit IRC
338 2016-04-19T18:16:24  *** cryptapus__ is now known as cryptapus
339 2016-04-19T18:19:29  *** d_t has joined #bitcoin-core-dev
340 2016-04-19T18:19:55  *** cryptapus__ has joined #bitcoin-core-dev
341 2016-04-19T18:23:27  *** cryptapus has quit IRC
342 2016-04-19T18:24:02  *** cryptapus__ is now known as cryptapus
343 2016-04-19T18:29:40  *** pedrobranco has quit IRC
344 2016-04-19T18:30:58  *** cryptapus has quit IRC
345 2016-04-19T18:31:07  *** cryptapus has joined #bitcoin-core-dev
346 2016-04-19T18:31:08  *** cryptapus has joined #bitcoin-core-dev
347 2016-04-19T18:33:16  *** cryptapus__ has joined #bitcoin-core-dev
348 2016-04-19T18:33:16  *** cryptapus__ has joined #bitcoin-core-dev
349 2016-04-19T18:35:54  *** cryptapus_ has joined #bitcoin-core-dev
350 2016-04-19T18:35:54  *** cryptapus_ has joined #bitcoin-core-dev
351 2016-04-19T18:36:38  *** cryptapus has quit IRC
352 2016-04-19T18:37:05  *** arowser has quit IRC
353 2016-04-19T18:37:21  *** arowser has joined #bitcoin-core-dev
354 2016-04-19T18:39:19  *** cryptapus__ has quit IRC
355 2016-04-19T18:40:52  <GitHub181> [bitcoin] theuni opened pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911
356 2016-04-19T18:48:26  *** d_t has quit IRC
357 2016-04-19T18:49:09  *** pedrobranco has joined #bitcoin-core-dev
358 2016-04-19T18:53:47  *** pedrobranco has quit IRC
359 2016-04-19T18:59:41  *** zooko has quit IRC
360 2016-04-19T19:06:05  *** roasbeef_ is now known as roasbeef
361 2016-04-19T19:08:34  *** TomMc has quit IRC
362 2016-04-19T19:26:08  *** frankenmint has quit IRC
363 2016-04-19T19:26:47  *** moli has joined #bitcoin-core-dev
364 2016-04-19T19:29:16  *** molly has quit IRC
365 2016-04-19T19:32:05  *** molz has joined #bitcoin-core-dev
366 2016-04-19T19:34:46  *** moli has quit IRC
367 2016-04-19T19:37:12  *** frankenmint has joined #bitcoin-core-dev
368 2016-04-19T19:38:08  *** cryptapus_ is now known as cryptapus
369 2016-04-19T19:49:51  <sdaftuar> Should BIP61 be interpreted to mean that reject messages with code 0x01 (REJECT_MALFORMED) should NOT have a hash payload, even if the message that triggered the reject is "block" or "tx"?
370 2016-04-19T19:57:10  *** TomMc has joined #bitcoin-core-dev
371 2016-04-19T20:03:59  *** TomMc has quit IRC
372 2016-04-19T20:04:34  *** cryptapus has quit IRC
373 2016-04-19T20:10:47  *** Guyver2 has quit IRC
374 2016-04-19T20:16:31  *** AaronvanW has joined #bitcoin-core-dev
375 2016-04-19T20:23:01  *** mrkent_ has joined #bitcoin-core-dev
376 2016-04-19T20:35:47  *** LeMiner has joined #bitcoin-core-dev
377 2016-04-19T20:36:31  <GitHub79> [bitcoin] sdaftuar opened pull request #7912: Tests: Fix deserialization of reject messages (master...fix-mininode-reject) https://github.com/bitcoin/bitcoin/pull/7912
378 2016-04-19T20:55:30  *** jannes has quit IRC
379 2016-04-19T21:01:45  *** mrkent__ has joined #bitcoin-core-dev
380 2016-04-19T21:01:53  *** mrkent_ has quit IRC
381 2016-04-19T21:06:57  <GitHub192> [bitcoin] yurizhykin opened pull request #7913: Fix for incorrect locking in GetPubKey() (keystore.cpp) (master...getpubkey-locking-fix) https://github.com/bitcoin/bitcoin/pull/7913
382 2016-04-19T21:08:18  *** zooko has joined #bitcoin-core-dev
383 2016-04-19T21:13:33  *** mrkent_ has joined #bitcoin-core-dev
384 2016-04-19T21:16:31  *** mrkent__ has quit IRC
385 2016-04-19T21:22:15  *** TomMc has joined #bitcoin-core-dev
386 2016-04-19T21:30:00  *** frankenmint has quit IRC
387 2016-04-19T21:32:52  *** schmidty has joined #bitcoin-core-dev
388 2016-04-19T21:54:30  *** harding has quit IRC
389 2016-04-19T21:55:13  *** harding has joined #bitcoin-core-dev
390 2016-04-19T22:05:09  *** grimescapes has joined #bitcoin-core-dev
391 2016-04-19T22:15:20  *** xabbix__ has quit IRC
392 2016-04-19T22:19:24  *** Guest87203 has quit IRC
393 2016-04-19T22:19:38  *** AaronvanW has quit IRC
394 2016-04-19T22:25:41  *** xabbix__ has joined #bitcoin-core-dev
395 2016-04-19T22:26:38  *** Guest53522 has joined #bitcoin-core-dev
396 2016-04-19T22:29:16  *** frankenmint has joined #bitcoin-core-dev
397 2016-04-19T23:07:43  *** lightningbot has joined #bitcoin-core-dev
398 2016-04-19T23:08:52  *** aj has joined #bitcoin-core-dev
399 2016-04-19T23:11:35  *** randy-waterhouse has joined #bitcoin-core-dev
400 2016-04-19T23:32:53  *** frankenmint has joined #bitcoin-core-dev