1 2016-05-06T00:00:54  *** Alopex has quit IRC
  2 2016-05-06T00:07:41  *** fengling has joined #bitcoin-core-dev
  3 2016-05-06T00:10:07  *** Alopex has joined #bitcoin-core-dev
  4 2016-05-06T00:39:33  *** randy-waterhouse has joined #bitcoin-core-dev
  5 2016-05-06T00:47:02  *** jonasschnelli has quit IRC
  6 2016-05-06T00:47:51  *** alpalp has joined #bitcoin-core-dev
  7 2016-05-06T00:48:19  *** Chris_Stewart_5 has quit IRC
  8 2016-05-06T00:49:04  *** GAit has quit IRC
  9 2016-05-06T00:50:51  *** GAit has joined #bitcoin-core-dev
 10 2016-05-06T00:52:15  *** jonasschnelli has joined #bitcoin-core-dev
 11 2016-05-06T01:11:18  *** justanotheruser has quit IRC
 12 2016-05-06T01:15:02  *** justanotheruser has joined #bitcoin-core-dev
 13 2016-05-06T01:25:35  *** belcher has quit IRC
 14 2016-05-06T01:27:18  <GitHub63> [bitcoin] wtogami opened pull request #8013: doc: Fedora build requirements, add gcc-c++ and fix typo (master...fedora_build_readme2) https://github.com/bitcoin/bitcoin/pull/8013
 15 2016-05-06T01:27:20  *** Giszmo has quit IRC
 16 2016-05-06T01:29:15  *** Guest89961 has quit IRC
 17 2016-05-06T01:29:16  *** Guest89961 has joined #bitcoin-core-dev
 18 2016-05-06T01:29:22  *** Guest89961 is now known as sipa
 19 2016-05-06T01:32:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 20 2016-05-06T01:54:27  *** Chris_Stewart_5 has quit IRC
 21 2016-05-06T02:01:11  *** Ylbam has quit IRC
 22 2016-05-06T02:41:29  *** alpalp has quit IRC
 23 2016-05-06T03:02:44  <luke-jr> warren: I see no valid use case for that patch…
 24 2016-05-06T03:05:52  <luke-jr> morcos: right now, GBT is broken in 0.12.1 due to BIP9
 25 2016-05-06T03:06:53  <luke-jr> cfields: there is a PR for the GBT BIP9 changes already
 26 2016-05-06T03:07:03  <luke-jr> if that's what you were asking
 27 2016-05-06T03:09:37  <warren> luke-jr: I think it exposes the change address that is configurable in the coin control GUI
 28 2016-05-06T03:10:10  <luke-jr> warren: once per startup, which makes no sense unless you're starting bitcoind JUST to send once
 29 2016-05-06T03:10:29  <warren> luke-jr: right, which is why Matt thought it made more sense as an RPC option
 30 2016-05-06T03:10:38  <luke-jr> yeah, probably
 31 2016-05-06T03:10:46  <warren> in any case it isn't my problem
 32 2016-05-06T03:10:51  <luke-jr> I *think* There's a PR open for it too
 33 2016-05-06T03:10:55  <warren> oh?
 34 2016-05-06T03:12:26  <luke-jr> https://github.com/bitcoin/bitcoin/pull/7518
 35 2016-05-06T03:14:29  <warren> That doesn't help sendtoaddress right?
 36 2016-05-06T03:14:48  <luke-jr> of course not, it doesn't make sense for sendtoaddress
 37 2016-05-06T03:14:56  <luke-jr> sendtoaddress is a simple RPC for normal users
 38 2016-05-06T03:15:04  <luke-jr> normal users should never be messing with change addresses
 39 2016-05-06T03:17:35  <sipa> for fundrawtransaction it may make sense
 40 2016-05-06T03:17:43  <sipa> (i'm surprised it doesn't already have it?0
 41 2016-05-06T03:17:49  <luke-jr> yes, that's what the PR does
 42 2016-05-06T03:18:27  <luke-jr> note it is merged
 43 2016-05-06T03:30:51  <warren> In discussion with cfields today we decided it would be nice and not too difficult to improve the makefiles and gitian such that "make rpm" and "make deb" would work and be used during the ordinary gitian-linux process.  It can spit out deterministic deb and rpm's during the existing gitian build process.  They can be subsequently GPG signed in a similar manner to the OSX and Windows installers.
 44 2016-05-06T03:32:44  <warren> After this is done I will make the recommendation to Fedora that they do NOT want to build and maintain their own Bitcoin RPM, mostly because they EOL distros very quickly and people will be stuck with old versions of Bitcoin.  Installing Bitcoin should be a conscious process not subject to auto-update either.
 45 2016-05-06T03:40:16  <GitHub1> [bitcoin] Tyler-Hardin opened pull request #8014: Qt: Sort transactions by date (master...sort-by-date) https://github.com/bitcoin/bitcoin/pull/8014
 46 2016-05-06T03:55:48  <luke-jr> warren: how will that deal with ABI issues between distros?
 47 2016-05-06T04:10:57  *** BashCo_ has joined #bitcoin-core-dev
 48 2016-05-06T04:13:07  *** BashCo has quit IRC
 49 2016-05-06T04:16:22  <GitHub62> [bitcoin] 21E14 opened pull request #8015: CCoinsViewErrorCatcher raison-d-etre (master...wrapper) https://github.com/bitcoin/bitcoin/pull/8015
 50 2016-05-06T04:40:18  *** xiangfu has joined #bitcoin-core-dev
 51 2016-05-06T04:48:57  *** GAit has quit IRC
 52 2016-05-06T04:49:29  *** GAit has joined #bitcoin-core-dev
 53 2016-05-06T04:52:36  *** kadoban has quit IRC
 54 2016-05-06T05:39:17  *** fengling has quit IRC
 55 2016-05-06T05:40:53  *** xiangfu has quit IRC
 56 2016-05-06T06:04:09  <warren> luke-jr: you don't, the gitian build contains static libraries
 57 2016-05-06T06:04:41  <warren> If you use "make rpm" or "make deb" on your own distro you get a dynamic binary.
 58 2016-05-06T06:06:14  *** PRab_ has joined #bitcoin-core-dev
 59 2016-05-06T06:07:31  *** PRab has quit IRC
 60 2016-05-06T06:07:45  *** PRab_ is now known as PRab
 61 2016-05-06T06:18:01  *** xiangfu has joined #bitcoin-core-dev
 62 2016-05-06T06:21:07  *** fengling has joined #bitcoin-core-dev
 63 2016-05-06T06:24:17  *** xiangfu has quit IRC
 64 2016-05-06T06:37:42  *** gill3s has joined #bitcoin-core-dev
 65 2016-05-06T06:39:47  *** jannes has joined #bitcoin-core-dev
 66 2016-05-06T06:43:50  *** BashCo_ has quit IRC
 67 2016-05-06T06:44:00  *** gill3s has quit IRC
 68 2016-05-06T06:44:01  *** gill3s has joined #bitcoin-core-dev
 69 2016-05-06T06:52:57  *** fengling has quit IRC
 70 2016-05-06T06:53:45  *** murch has joined #bitcoin-core-dev
 71 2016-05-06T06:58:58  *** fengling has joined #bitcoin-core-dev
 72 2016-05-06T07:03:05  *** BashCo has joined #bitcoin-core-dev
 73 2016-05-06T07:04:03  *** jtimon has quit IRC
 74 2016-05-06T07:34:35  *** Guyver2 has joined #bitcoin-core-dev
 75 2016-05-06T07:37:07  *** gevs has quit IRC
 76 2016-05-06T07:49:31  *** gevs has joined #bitcoin-core-dev
 77 2016-05-06T07:53:57  *** jonasschnelli has quit IRC
 78 2016-05-06T07:53:57  *** jonasschnelli has joined #bitcoin-core-dev
 79 2016-05-06T07:58:51  *** gill3s has quit IRC
 80 2016-05-06T08:03:28  <GitHub138> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/006cdf64dc93...efee32f38110
 81 2016-05-06T08:03:28  <GitHub138> bitcoin/master 99e7075 Wladimir J. van der Laan: Break circular dependency main ↔ txdb...
 82 2016-05-06T08:03:29  <GitHub138> bitcoin/master efee32f Wladimir J. van der Laan: Merge #7815: Break circular dependency main ↔ txdb...
 83 2016-05-06T08:03:33  <GitHub95> [bitcoin] laanwj closed pull request #7815: Break circular dependency main ↔ txdb (master...2016_04_break_txdb_main_dep) https://github.com/bitcoin/bitcoin/pull/7815
 84 2016-05-06T08:04:29  <GitHub58> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/efee32f38110...65aecda52d0d
 85 2016-05-06T08:04:29  <GitHub58> bitcoin/master e53e7c5 Kaz Wesley: don't run ThreadMessageHandler at lowered priority...
 86 2016-05-06T08:04:30  <GitHub58> bitcoin/master 65aecda Wladimir J. van der Laan: Merge #8011: don't run ThreadMessageHandler at lowered priority...
 87 2016-05-06T08:04:38  *** MarcoFalke has joined #bitcoin-core-dev
 88 2016-05-06T08:04:39  <GitHub178> [bitcoin] laanwj closed pull request #8011: don't run ThreadMessageHandler at lowered priority (master...priority) https://github.com/bitcoin/bitcoin/pull/8011
 89 2016-05-06T08:14:34  *** To7 has quit IRC
 90 2016-05-06T08:32:11  <jonasschnelli> Is that only my observation? A full sync with BitcoinD is much faster then with Bitcoin-Qt?
 91 2016-05-06T08:32:19  <jonasschnelli> Doing measurements now.
 92 2016-05-06T08:42:24  *** xiangfu has joined #bitcoin-core-dev
 93 2016-05-06T08:49:26  *** GAit has quit IRC
 94 2016-05-06T08:49:47  *** GAit has joined #bitcoin-core-dev
 95 2016-05-06T08:50:33  <paveljanik> some UI locks?
 96 2016-05-06T08:51:13  *** wangchun has quit IRC
 97 2016-05-06T08:51:58  *** wangchun has joined #bitcoin-core-dev
 98 2016-05-06T08:53:28  <jonasschnelli> paveljanik: probably. But it feels like losing 50% of the sync "performance". Will have some ~numbers soon.
 99 2016-05-06T08:54:04  <paveljanik> 50% is a bit too much, yes.
100 2016-05-06T08:57:05  *** wangchun has quit IRC
101 2016-05-06T08:57:32  *** wangchun has joined #bitcoin-core-dev
102 2016-05-06T09:02:31  *** AaronvanW has joined #bitcoin-core-dev
103 2016-05-06T09:09:07  *** fengling has quit IRC
104 2016-05-06T09:09:47  *** Ylbam has joined #bitcoin-core-dev
105 2016-05-06T09:10:38  <GitHub170> [bitcoin] paveljanik opened pull request #8016: Fix multithread CScheduler and reenable test (master...20160506_multithread_CScheduler) https://github.com/bitcoin/bitcoin/pull/8016
106 2016-05-06T09:10:55  *** GAit has quit IRC
107 2016-05-06T09:11:04  *** GAit has joined #bitcoin-core-dev
108 2016-05-06T09:12:49  *** pedrobranco has joined #bitcoin-core-dev
109 2016-05-06T09:22:04  <GitHub19> [bitcoin] jonasschnelli closed pull request #7830: [Wallet] Add cloned wallet, remove accounts, reset version (master...2016/04/wallet2) https://github.com/bitcoin/bitcoin/pull/7830
110 2016-05-06T09:24:47  <GitHub83> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65aecda52d0d...77b637f20e8c
111 2016-05-06T09:24:47  <GitHub83> bitcoin/master fa389d4 MarcoFalke: [qa] Switch to py3
112 2016-05-06T09:24:48  <GitHub83> bitcoin/master 77b637f Wladimir J. van der Laan: Merge #7814: [qa] Switch to py3...
113 2016-05-06T09:24:51  <GitHub87> [bitcoin] laanwj closed pull request #7814: [qa] Switch to py3 (master...Mf1604-qaPy3) https://github.com/bitcoin/bitcoin/pull/7814
114 2016-05-06T09:27:11  *** Guyver2 has quit IRC
115 2016-05-06T09:33:39  *** MarcoFalke has quit IRC
116 2016-05-06T09:33:52  *** MarcoFalke has joined #bitcoin-core-dev
117 2016-05-06T09:47:54  *** blur3d has joined #bitcoin-core-dev
118 2016-05-06T09:51:17  *** Arnavion has quit IRC
119 2016-05-06T09:51:54  <paveljanik> MarcoFalke, python3: httplib not found -> http.client?
120 2016-05-06T09:52:09  *** Arnavion has joined #bitcoin-core-dev
121 2016-05-06T09:52:23  <MarcoFalke> You need to check out the specific commit
122 2016-05-06T09:52:40  <MarcoFalke> git checkout fa6cd636c05fa18afbfc35e4e8ad0e7e69c0ae35
123 2016-05-06T09:52:50  <paveljanik> yup, already known
124 2016-05-06T09:53:05  <paveljanik> I'm 5 minutes late after fanquake ;-)
125 2016-05-06T09:53:09  <paveljanik> I'll wait :-)
126 2016-05-06T10:12:17  *** Giszmo has joined #bitcoin-core-dev
127 2016-05-06T10:22:24  *** xiangfu has quit IRC
128 2016-05-06T10:25:05  <MarcoFalke> So why does travis fail all pulls with ImportError: No module named 'zmq'?
129 2016-05-06T10:25:47  <paveljanik> MarcoFalke, python-qmz not installed.
130 2016-05-06T10:26:04  <paveljanik> I'm just about to write to you, that we should make a conditional in the zmq tests to prevent this ;-)
131 2016-05-06T10:26:50  <paveljanik> README.md contains: sudo apt-get install python-zmq
132 2016-05-06T10:27:43  <paveljanik> and of course install this module in travis
133 2016-05-06T10:30:32  <MarcoFalke> https://github.com/bitcoin/bitcoin/blob/65aecda52d0d2179f77d675dc305225a1566c48f/.travis.yml#L46 https://github.com/bitcoin/bitcoin/blob/77b637f20e8cb91cf007bf416b603ca362385cdb/.travis.yml#L46
134 2016-05-06T10:30:48  <MarcoFalke> It is installed
135 2016-05-06T10:30:54  <MarcoFalke> Am I missing something?
136 2016-05-06T10:34:33  <paveljanik> Is there a log from the travis initialization to check?
137 2016-05-06T10:35:49  <paveljanik> and is there such module available at all? ;-)
138 2016-05-06T10:35:54  * paveljanik doesn't know...
139 2016-05-06T10:36:07  <MarcoFalke> Oh the cache is messed up
140 2016-05-06T10:36:25  <MarcoFalke> It fetches from master (which is py3) but the pulls are still py2
141 2016-05-06T10:36:28  <MarcoFalke> Just a guess
142 2016-05-06T10:38:59  <paveljanik> yes, maybe.
143 2016-05-06T10:41:20  <paveljanik> Does it help to rebase such PR?
144 2016-05-06T10:42:03  <GitHub91> [bitcoin] jonasschnelli opened pull request #8018: Autofind rpc tests --srcdir (master...2016/05/fix_test_srcdir) https://github.com/bitcoin/bitcoin/pull/8018
145 2016-05-06T10:42:21  <MarcoFalke> I am trying to avoid rebase but, hmm
146 2016-05-06T10:43:36  <paveljanik> ah
147 2016-05-06T10:44:24  <MarcoFalke> rebased
148 2016-05-06T10:51:43  *** achow101 has quit IRC
149 2016-05-06T11:24:33  *** Samdney has joined #bitcoin-core-dev
150 2016-05-06T11:29:10  *** randy-waterhouse has quit IRC
151 2016-05-06T11:46:36  *** Samdney has quit IRC
152 2016-05-06T12:06:01  *** paveljanik has quit IRC
153 2016-05-06T12:11:48  *** ghtdak has quit IRC
154 2016-05-06T12:12:16  *** ghtdak has joined #bitcoin-core-dev
155 2016-05-06T12:14:35  *** laurentmt has joined #bitcoin-core-dev
156 2016-05-06T12:15:16  *** laurentmt has quit IRC
157 2016-05-06T12:27:28  <jonasschnelli> I was wrong. Bitcoin-Qt full sync takes ~ same amount of time as it takes with bitcoind.
158 2016-05-06T12:44:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
159 2016-05-06T12:49:07  *** GAit has quit IRC
160 2016-05-06T12:49:30  *** GAit has joined #bitcoin-core-dev
161 2016-05-06T13:27:19  *** Chris_Stewart_5 has quit IRC
162 2016-05-06T13:27:52  *** MrHodl has quit IRC
163 2016-05-06T13:28:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
164 2016-05-06T13:32:22  *** TomMc has joined #bitcoin-core-dev
165 2016-05-06T13:46:21  <wumpus> jonasschnelli: phew :)
166 2016-05-06T13:47:06  <wumpus> I'd understand if it is somewhat slower, I mean a GUI thread does produce some extra load, but doubling the time is absurd
167 2016-05-06T13:49:26  <GitHub17> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/77b637f20e8c...fbedc09b2d09
168 2016-05-06T13:49:26  <GitHub17> bitcoin/master b3d18ba Warren Togami: doc: Fedora build requirements, add gcc-c++ and fix typo
169 2016-05-06T13:49:27  <GitHub17> bitcoin/master fbedc09 Wladimir J. van der Laan: Merge #8013: doc: Fedora build requirements, add gcc-c++ and fix typo...
170 2016-05-06T13:49:36  <GitHub171> [bitcoin] laanwj closed pull request #8013: doc: Fedora build requirements, add gcc-c++ and fix typo (master...fedora_build_readme2) https://github.com/bitcoin/bitcoin/pull/8013
171 2016-05-06T13:51:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
172 2016-05-06T13:55:36  *** pedrobranco has quit IRC
173 2016-05-06T13:56:47  *** pedrobranco has joined #bitcoin-core-dev
174 2016-05-06T13:57:24  <wumpus> looks like there are some travis failures regarding zmq https://travis-ci.org/bitcoin/bitcoin/jobs/128251961
175 2016-05-06T13:57:52  <MarcoFalke> It is some travis issue if you ask me
176 2016-05-06T13:58:22  <wumpus> seems likely, as it doesn't seem to be consistent
177 2016-05-06T13:58:40  *** pedrobranco has quit IRC
178 2016-05-06T13:58:47  *** pedrobranco has joined #bitcoin-core-dev
179 2016-05-06T14:00:43  *** GAit has quit IRC
180 2016-05-06T14:01:18  <MarcoFalke> It is consistent for all pulls that were in the travis queue at the time the py3 pull was merged
181 2016-05-06T14:01:32  <MarcoFalke> Some broken cache logic, probably
182 2016-05-06T14:05:44  *** pedrobranco has quit IRC
183 2016-05-06T14:07:44  *** Chris_Stewart_5 has quit IRC
184 2016-05-06T14:10:43  *** Samdney has joined #bitcoin-core-dev
185 2016-05-06T14:13:08  *** cryptapus_afk is now known as cryptapus
186 2016-05-06T14:35:38  *** TomMc has quit IRC
187 2016-05-06T14:36:27  <luke-jr> warren: well then you haven't eliminated the reason for distros to package it..
188 2016-05-06T14:44:29  *** pedrobranco has joined #bitcoin-core-dev
189 2016-05-06T14:46:22  *** pedrobranco has quit IRC
190 2016-05-06T14:50:47  *** TomMc has joined #bitcoin-core-dev
191 2016-05-06T15:06:11  *** BashCo has quit IRC
192 2016-05-06T15:09:24  *** BashCo has joined #bitcoin-core-dev
193 2016-05-06T15:10:25  *** pedrobranco has joined #bitcoin-core-dev
194 2016-05-06T15:14:10  *** BashCo has quit IRC
195 2016-05-06T15:14:34  *** pedrobranco has quit IRC
196 2016-05-06T15:16:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
197 2016-05-06T15:22:16  *** Chris_Stewart_5 has quit IRC
198 2016-05-06T15:25:39  <GitHub137> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fbedc09b2d09...fbd84788e676
199 2016-05-06T15:25:39  <GitHub137> bitcoin/master b06f6a9 JeremyRand: Fixed invalid example paths in gitian-building.md...
200 2016-05-06T15:25:40  <GitHub137> bitcoin/master fbd8478 Wladimir J. van der Laan: Merge #8009: Docs: Fixed invalid example paths in gitian-building.md...
201 2016-05-06T15:25:50  <GitHub195> [bitcoin] laanwj closed pull request #8009: Docs: Fixed invalid example paths in gitian-building.md (master...doc-gitian-building-offline-paths-fix) https://github.com/bitcoin/bitcoin/pull/8009
202 2016-05-06T15:37:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
203 2016-05-06T15:48:35  *** Chris_Stewart_5 has quit IRC
204 2016-05-06T15:52:19  *** PaulCape_ has quit IRC
205 2016-05-06T15:52:41  *** PaulCapestany has joined #bitcoin-core-dev
206 2016-05-06T15:53:54  *** PaulCapestany has quit IRC
207 2016-05-06T15:54:03  *** pedrobranco has joined #bitcoin-core-dev
208 2016-05-06T15:56:15  *** PaulCapestany has joined #bitcoin-core-dev
209 2016-05-06T16:00:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
210 2016-05-06T16:00:28  *** pedrobranco has quit IRC
211 2016-05-06T16:14:15  *** pedrobranco has joined #bitcoin-core-dev
212 2016-05-06T16:16:49  *** murch has quit IRC
213 2016-05-06T16:18:50  *** BashCo has joined #bitcoin-core-dev
214 2016-05-06T16:27:28  *** crescendo has quit IRC
215 2016-05-06T16:27:31  *** adam3us has quit IRC
216 2016-05-06T16:28:13  *** crescendo has joined #bitcoin-core-dev
217 2016-05-06T16:28:23  *** sdaftuar has quit IRC
218 2016-05-06T16:28:40  *** kinlo has quit IRC
219 2016-05-06T16:28:40  *** instagibbs has quit IRC
220 2016-05-06T16:28:54  *** maaku has joined #bitcoin-core-dev
221 2016-05-06T16:29:09  *** sdaftuar has joined #bitcoin-core-dev
222 2016-05-06T16:29:25  *** kinlo has joined #bitcoin-core-dev
223 2016-05-06T16:30:43  <maaku> I saw in the meeting logs that a back dated start date for segwit on testnet was accepted
224 2016-05-06T16:30:52  *** instagibbs has joined #bitcoin-core-dev
225 2016-05-06T16:31:05  <maaku> This potentially causes severe problems for people who are doing ongoing integration testing of their own services on testnet
226 2016-05-06T16:31:41  <maaku> I hope that this decision is reconsidered (or a delay to activation is added)
227 2016-05-06T16:31:51  <jl2012> maaku, I think BIP68 also backdated?
228 2016-05-06T16:31:53  *** Amnez777 has quit IRC
229 2016-05-06T16:32:02  <maaku> jl2012: which was also a mistake
230 2016-05-06T16:32:19  *** adam3us has joined #bitcoin-core-dev
231 2016-05-06T16:33:01  <maaku> the delay can be short, e.g. a few weeks. but it shouldn't be zero
232 2016-05-06T16:33:44  <maaku> that is placing a potential forking situation on people who have been absorbed in their own work, with absolutely no warning
233 2016-05-06T16:35:12  *** pedrobranco has quit IRC
234 2016-05-06T16:35:20  *** Amnez777 has joined #bitcoin-core-dev
235 2016-05-06T16:36:01  *** pedrobranco has joined #bitcoin-core-dev
236 2016-05-06T16:36:16  <jl2012> you mean some people are already testing segwit on testnet?
237 2016-05-06T16:38:44  *** arowser has quit IRC
238 2016-05-06T16:39:20  *** arowser has joined #bitcoin-core-dev
239 2016-05-06T16:39:59  <maaku> jl2012: I mean that with a back-dated start date segwit could activate within hours if someone decided to throw some hash power at it
240 2016-05-06T16:40:51  *** pedrobranco has quit IRC
241 2016-05-06T16:40:54  <jl2012> same before we had bip9
242 2016-05-06T16:40:55  <maaku> wihch is not unlikely
243 2016-05-06T16:41:08  <maaku> jl2012: ...
244 2016-05-06T16:41:25  <maaku> because we fucked up in the past does not mean we should continue to be fuckups
245 2016-05-06T16:41:42  *** Chris_Stewart_5 has quit IRC
246 2016-05-06T16:41:56  <maaku> set a data of May 15th or something and make a loud announcement, so people have at least a little bit of time to make sure they're not affected
247 2016-05-06T16:42:32  *** pedrobranco has joined #bitcoin-core-dev
248 2016-05-06T16:44:02  *** earlest has joined #bitcoin-core-dev
249 2016-05-06T16:46:01  <sipa> maaku: that's reasonable, but testnet is always subject to wide hashrate swings and forks
250 2016-05-06T16:46:04  *** laurentmt has joined #bitcoin-core-dev
251 2016-05-06T16:46:35  *** bysherper has joined #bitcoin-core-dev
252 2016-05-06T16:46:54  <sipa> and it's not like the code for segwit is merged... there isn't even a branch with those activation times included at this point
253 2016-05-06T16:47:34  *** muuqwaul has quit IRC
254 2016-05-06T16:47:42  <maaku> yeah but still, we should try not to add to the noise
255 2016-05-06T16:48:33  *** maaku has left #bitcoin-core-dev
256 2016-05-06T16:49:34  *** earlest has quit IRC
257 2016-05-06T16:50:39  *** pedrobranco has quit IRC
258 2016-05-06T16:54:34  *** TomMc has quit IRC
259 2016-05-06T16:57:42  <sipa> sdaftuar: do you think there are pitfalls when converted the txid index of CTxMempool:mapTx to a hashed-based one?
260 2016-05-06T17:00:00  <sdaftuar> sipa: hmm, i'm not sure i sufficiently explored it, but i don't recall thinking it would be problematic
261 2016-05-06T17:00:26  <sipa> i remember trying, and failing
262 2016-05-06T17:00:36  <sdaftuar> yeah so probably i was missing something then :)
263 2016-05-06T17:01:23  <sdaftuar> maybe kazcw wants to take a stab at it!  the setSpends thing is cool
264 2016-05-06T17:03:50  *** blur3d has quit IRC
265 2016-05-06T17:10:04  *** Eliel_ has quit IRC
266 2016-05-06T17:11:22  *** pedrobranco has joined #bitcoin-core-dev
267 2016-05-06T17:15:03  *** laurentmt has quit IRC
268 2016-05-06T17:23:14  *** molz has joined #bitcoin-core-dev
269 2016-05-06T17:25:28  *** moli has quit IRC
270 2016-05-06T17:28:29  <GitHub166> [bitcoin] instagibbs opened pull request #8019: Remove state arg from ReconsiderBlock (master...reblarg) https://github.com/bitcoin/bitcoin/pull/8019
271 2016-05-06T17:31:16  *** MarcoFalke has quit IRC
272 2016-05-06T17:37:49  *** pedrobranco has quit IRC
273 2016-05-06T17:41:21  *** Eliel has joined #bitcoin-core-dev
274 2016-05-06T17:41:45  *** arowser has quit IRC
275 2016-05-06T17:42:11  *** arowser has joined #bitcoin-core-dev
276 2016-05-06T17:50:10  *** earlest has joined #bitcoin-core-dev
277 2016-05-06T17:53:46  *** bysherper has quit IRC
278 2016-05-06T17:55:40  *** BashCo_ has joined #bitcoin-core-dev
279 2016-05-06T17:58:24  *** BashCo has quit IRC
280 2016-05-06T18:00:00  <jl2012> maaku, no matter what we do, when no one is mining, an attacker can easily fork the network by mining a long non-segwit chain after activation
281 2016-05-06T18:00:36  <jl2012> unless we have hashrate to keep the chain growing, which is burning money
282 2016-05-06T18:04:33  <BlueMatt> hmmm...sipa so I need to keep around a list of node pointers I can send messages to in main.cpp...would be a huge shame to put CNode* back in logic there :/
283 2016-05-06T18:04:33  <BlueMatt> any ideas
284 2016-05-06T18:04:33  <BlueMatt> or, wait, who introduced NodeId
285 2016-05-06T18:06:19  *** GAit has joined #bitcoin-core-dev
286 2016-05-06T18:07:28  <gmaxwell> jl2012: maaku's concern is that you we should give people time to update so their nodes will ignore that fork.
287 2016-05-06T18:07:33  <gmaxwell> I don't share the concern.
288 2016-05-06T18:08:02  <gmaxwell> (or rather, I share it but believe that we will end up giving them adequate time, without having to delay further.)
289 2016-05-06T18:09:55  <jl2012> i hope to see it live on testnet as early as possible, so we could start testing the dynamics of upgraded and non-upgraded nodes
290 2016-05-06T18:10:22  <jl2012> and I'm sure it will be attacked, intentionally or unintentionally
291 2016-05-06T18:11:09  <jl2012> unless we keep mining it
292 2016-05-06T18:11:39  <gmaxwell> jl2012: if nodes are already upgraded to enforce, then _full nodes_ (which is 99% of what exists on testnet) won't notice any such attack.
293 2016-05-06T18:12:36  <jl2012> but the point to test it on testnet is to examine the interaction between upgraded and non-upgraded nodes
294 2016-05-06T18:12:48  <jl2012> if we just want upgraded nodes, we already have segnet
295 2016-05-06T18:14:48  <jl2012> and if upgraded nodes have minority hashrate, we are actually implementing a segnet under the name of testnet
296 2016-05-06T18:14:56  <instagibbs> jl2012, you can do that in segnet too
297 2016-05-06T18:15:39  <gmaxwell> we can also spin up a new testnet that is mixed.
298 2016-05-06T18:16:03  <gmaxwell> which would not disrupt other people's testing that is unrelated to segwit.
299 2016-05-06T18:17:18  <jl2012> actually I'm running a non-upgraded node on the segwit. Probably the only one
300 2016-05-06T18:17:24  *** pedrobranco has joined #bitcoin-core-dev
301 2016-05-06T18:19:23  *** jannes has quit IRC
302 2016-05-06T18:20:51  <sipa> BlueMatt: i introduced nodeid
303 2016-05-06T18:21:34  *** pedrobranco has quit IRC
304 2016-05-06T18:22:07  <sipa> BlueMatt: but perhaps net can have a function to send a particular message to a list of nodeids
305 2016-05-06T18:23:06  <sipa> BlueMatt: alternatively, you can keep a list of CNode* pointers around, but you'll need cleanup logic in FinalizeNode to remove any reference to a node when it disappears
306 2016-05-06T18:24:23  <BlueMatt> sipa: yea, I mean i was thinking about CNode* references...but that kinda defeats the purpose of NodeId
307 2016-05-06T18:24:29  <BlueMatt> sipa: in fact, any solution kinda defeats the purpose of NodeId...might as well kill NodeId if we have back-and-forward references between CNodes and NodeIds
308 2016-05-06T18:27:24  *** Dizzle has joined #bitcoin-core-dev
309 2016-05-06T18:30:28  *** BashCo has joined #bitcoin-core-dev
310 2016-05-06T18:31:39  <sipa> BlueMatt: i disagree
311 2016-05-06T18:31:44  <sipa> BlueMatt: net should not expose CNode
312 2016-05-06T18:31:55  <sipa> and only expose abstract identifiers
313 2016-05-06T18:32:24  <sipa> the fact that you need back-and-forth references is a side effect of the logic now being split between net and main
314 2016-05-06T18:32:47  *** BashCo_ has quit IRC
315 2016-05-06T18:33:36  <BlueMatt> sipa: so you mean that we /should/ have an interface to send to a nodeid, because we shouldn't expose CNode at all, and pfrom should, in fact, be a nodeid?
316 2016-05-06T18:33:39  *** GAit has quit IRC
317 2016-05-06T18:33:45  <sipa> BlueMatt: yup
318 2016-05-06T18:34:09  <sipa> but i expect that code to undergo very significant changes after cory's net changes
319 2016-05-06T18:34:43  <BlueMatt> meh, I mean /all/ processing should happen in net imo...the fact that main knows /anything/ about the p2p protocol is bad
320 2016-05-06T18:34:43  <BlueMatt> but, indeed, its kinda all up in the air as cory refactors net
321 2016-05-06T18:35:15  <BlueMatt> I'll add a CNode* ref for now, with the expectation that it will dissapear soonish
322 2016-05-06T18:36:49  <sdaftuar> sipa: fyi, according to morcos it worked relatively easily to convert mapTx's txid index to an unordered_map.
323 2016-05-06T18:37:14  <sipa> sdaftuar: oh, sorry to not report back; yes, it was trivial :)
324 2016-05-06T18:37:28  <sipa> doing it as part of a slighly larger change
325 2016-05-06T18:37:35  <sdaftuar> cool!
326 2016-05-06T18:54:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
327 2016-05-06T18:56:03  *** Amnez777 has quit IRC
328 2016-05-06T18:58:23  *** Amnez777 has joined #bitcoin-core-dev
329 2016-05-06T19:04:30  *** achow101 has joined #bitcoin-core-dev
330 2016-05-06T19:20:03  *** earlest has quit IRC
331 2016-05-06T19:48:09  *** Dizzle has quit IRC
332 2016-05-06T20:01:25  <GitHub88> [bitcoin] sipa opened pull request #8020: Use SipHash-2-4 for various non-cryptographic hashes (master...siphash) https://github.com/bitcoin/bitcoin/pull/8020
333 2016-05-06T20:16:02  *** muuqwaul has joined #bitcoin-core-dev
334 2016-05-06T20:21:49  *** Amnez777 has quit IRC
335 2016-05-06T20:22:31  *** Amnez777 has joined #bitcoin-core-dev
336 2016-05-06T20:34:37  <phantomcircuit> sipa: why the macro implementation?
337 2016-05-06T20:34:45  *** Guyver2 has joined #bitcoin-core-dev
338 2016-05-06T20:39:39  <sipa> phantomcircuit: copy paste
339 2016-05-06T20:39:52  <sipa> sugfestion for something better
340 2016-05-06T20:41:15  <phantomcircuit> sipa: that was my guess, no suggestion at the moment
341 2016-05-06T20:43:22  <phantomcircuit> sipa: is it safe to use hashed_unique like that in the mempool code?
342 2016-05-06T20:43:38  <phantomcircuit> well i guess it is in so much as a collision just means you're missing a tx from the mempool
343 2016-05-06T20:45:49  *** earlest has joined #bitcoin-core-dev
344 2016-05-06T20:49:03  *** muuqwaul has quit IRC
345 2016-05-06T20:53:35  <sipa> phantomcircuit: the key for the mempool is still full txid
346 2016-05-06T20:54:16  <sipa> the 64-bit hash is just internally used in the multi_index implementation, to decide what bucket an entry goes into
347 2016-05-06T20:54:26  <sipa> but buckets can hold multiple items without problems
348 2016-05-06T20:58:44  *** belcher has joined #bitcoin-core-dev
349 2016-05-06T21:08:49  <phantomcircuit> sipa: ah ok, that's not clear from just the diff guess i needed more context
350 2016-05-06T21:09:25  <phantomcircuit> ah right the thing "really" being indexed is CTxMemPoolEntry
351 2016-05-06T21:09:36  *** paveljanik has joined #bitcoin-core-dev
352 2016-05-06T21:23:57  *** AaronvanW has quit IRC
353 2016-05-06T21:46:47  *** GAit has joined #bitcoin-core-dev
354 2016-05-06T22:11:38  *** paveljanik has quit IRC
355 2016-05-06T22:15:01  *** Alopex has quit IRC
356 2016-05-06T22:16:06  *** Alopex has joined #bitcoin-core-dev
357 2016-05-06T22:38:57  *** pedrobranco has joined #bitcoin-core-dev
358 2016-05-06T22:43:11  *** pedrobranco has quit IRC
359 2016-05-06T22:43:24  *** pedrobranco has joined #bitcoin-core-dev
360 2016-05-06T22:56:43  *** Giszmo has quit IRC
361 2016-05-06T23:02:30  *** spudowiar has joined #bitcoin-core-dev
362 2016-05-06T23:09:49  *** Guyver2 has quit IRC
363 2016-05-06T23:13:00  *** Cory has quit IRC
364 2016-05-06T23:14:27  *** Giszmo has joined #bitcoin-core-dev
365 2016-05-06T23:14:49  *** Pasha has joined #bitcoin-core-dev
366 2016-05-06T23:20:54  *** Chris_Stewart_5 has quit IRC
367 2016-05-06T23:21:43  *** Pasha is now known as Cory
368 2016-05-06T23:28:07  *** pedrobranco has quit IRC
369 2016-05-06T23:34:06  *** BashCo_ has joined #bitcoin-core-dev
370 2016-05-06T23:36:04  *** BashCo has quit IRC
371 2016-05-06T23:42:30  *** pedrobranco has joined #bitcoin-core-dev