1 2016-05-18T00:01:04  *** PRab has joined #bitcoin-core-dev
  2 2016-05-18T00:47:26  <petertodd> luke-jr: but that's unrelated to the opt-in rbf detection; I agree that in general we want to display doublespends
  3 2016-05-18T00:48:00  <luke-jr> petertodd: well, I mean if we're displaying "replacable" as an indication
  4 2016-05-18T00:50:45  <petertodd> luke-jr: right, but I'm only talking about incoming txs
  5 2016-05-18T01:05:04  *** dermoth__ has quit IRC
  6 2016-05-18T01:05:40  *** dermoth__ has joined #bitcoin-core-dev
  7 2016-05-18T01:19:01  *** Alopex has quit IRC
  8 2016-05-18T01:20:06  *** Alopex has joined #bitcoin-core-dev
  9 2016-05-18T01:21:11  *** Ylbam has quit IRC
 10 2016-05-18T01:29:35  *** alpalp has quit IRC
 11 2016-05-18T01:29:47  *** alpalp has joined #bitcoin-core-dev
 12 2016-05-18T01:29:48  *** alpalp has joined #bitcoin-core-dev
 13 2016-05-18T01:30:33  <GitHub150> [bitcoin] theuni opened pull request #8067: travis: use slim generic image, and some fixups (master...travis-generic-image) https://github.com/bitcoin/bitcoin/pull/8067
 14 2016-05-18T01:32:42  *** molz has joined #bitcoin-core-dev
 15 2016-05-18T01:36:03  *** moli has quit IRC
 16 2016-05-18T01:40:42  *** belcher has quit IRC
 17 2016-05-18T01:44:29  *** Chris_Stewart_5 has quit IRC
 18 2016-05-18T01:49:20  <GitHub3> [bitcoin] TheBlueMatt opened pull request #8068: Compact Blocks (master...udp) https://github.com/bitcoin/bitcoin/pull/8068
 19 2016-05-18T01:52:56  *** alpalp has quit IRC
 20 2016-05-18T01:53:59  *** alpalp has joined #bitcoin-core-dev
 21 2016-05-18T02:01:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 22 2016-05-18T02:04:40  *** Michail1 has quit IRC
 23 2016-05-18T02:07:14  *** Chris_Stewart_5 has quit IRC
 24 2016-05-18T02:23:32  *** Giszmo has quit IRC
 25 2016-05-18T02:25:05  *** Giszmo has joined #bitcoin-core-dev
 26 2016-05-18T02:34:01  *** Michail1 has joined #bitcoin-core-dev
 27 2016-05-18T02:36:51  *** TomMc has quit IRC
 28 2016-05-18T02:38:07  *** alpalp has quit IRC
 29 2016-05-18T02:40:12  *** Michail1 has quit IRC
 30 2016-05-18T02:50:27  *** Michail1 has joined #bitcoin-core-dev
 31 2016-05-18T03:21:01  *** Alopex has quit IRC
 32 2016-05-18T03:22:07  *** Alopex has joined #bitcoin-core-dev
 33 2016-05-18T03:44:01  *** Alopex has quit IRC
 34 2016-05-18T03:45:06  *** Alopex has joined #bitcoin-core-dev
 35 2016-05-18T04:16:40  *** justanotheruser has quit IRC
 36 2016-05-18T04:17:40  <BlueMatt> sipa/gmaxwell
 37 2016-05-18T04:17:55  <BlueMatt> so I was just going back and checking, and the new varint stuff doesnt help anywhere that matters
 38 2016-05-18T04:19:08  *** justanotheruser has joined #bitcoin-core-dev
 39 2016-05-18T04:19:49  <BlueMatt> its an extra few kb in getblocktxn, but thats not really critical-path since that is still one-per-block-per-node
 40 2016-05-18T04:20:37  <BlueMatt> its only like 10 or 20 bytes in cmpctblock, which is the all-important potentially-multiple-times-per-block
 41 2016-05-18T04:22:30  <BlueMatt> gmaxwell: since you're the one with no b/w at home, how much would you care if there is an extra few kb (if even that) in getblocktxn?
 42 2016-05-18T04:22:39  <BlueMatt> somehow I had thought it was a savings in cmpctblock
 43 2016-05-18T04:24:04  <sipa> i'm fine with sticking to the existing varint scheme
 44 2016-05-18T04:24:11  <luke-jr> "one" <.<
 45 2016-05-18T04:24:33  <luke-jr> BlueMatt: How is blocktxn not part of the critical path?
 46 2016-05-18T04:26:55  *** Giszmo has quit IRC
 47 2016-05-18T04:27:38  *** zooko has quit IRC
 48 2016-05-18T04:56:01  *** Alopex has quit IRC
 49 2016-05-18T04:57:07  *** Alopex has joined #bitcoin-core-dev
 50 2016-05-18T05:05:09  *** jl2012_ has joined #bitcoin-core-dev
 51 2016-05-18T05:11:03  *** paveljanik has joined #bitcoin-core-dev
 52 2016-05-18T05:11:04  *** paveljanik has joined #bitcoin-core-dev
 53 2016-05-18T05:11:37  *** Pat_Boy has joined #bitcoin-core-dev
 54 2016-05-18T05:12:54  *** Evel-Knievel has quit IRC
 55 2016-05-18T05:12:55  *** amiller has quit IRC
 56 2016-05-18T05:12:55  *** jl2012 has quit IRC
 57 2016-05-18T05:12:55  *** da2ce7_mobile has quit IRC
 58 2016-05-18T05:12:55  *** PatBoy has quit IRC
 59 2016-05-18T05:12:57  *** spudowiar has quit IRC
 60 2016-05-18T05:12:59  *** JackH has quit IRC
 61 2016-05-18T05:13:02  *** Pat_Boy is now known as PatBoy
 62 2016-05-18T05:13:03  *** jl2012_ is now known as jl2012
 63 2016-05-18T05:13:36  *** Evel-Knievel has joined #bitcoin-core-dev
 64 2016-05-18T05:13:47  *** JackH has joined #bitcoin-core-dev
 65 2016-05-18T05:14:56  *** amiller_ has joined #bitcoin-core-dev
 66 2016-05-18T05:15:48  *** spudowiar has joined #bitcoin-core-dev
 67 2016-05-18T05:16:45  *** da2ce7_mobile has joined #bitcoin-core-dev
 68 2016-05-18T05:24:01  *** Alopex has quit IRC
 69 2016-05-18T05:25:07  *** Alopex has joined #bitcoin-core-dev
 70 2016-05-18T05:27:43  *** pet_rock has quit IRC
 71 2016-05-18T05:57:37  *** tErik_mc has joined #bitcoin-core-dev
 72 2016-05-18T06:00:03  <BlueMatt> luke-jr: I said getblocktxn
 73 2016-05-18T06:00:18  <BlueMatt> luke-jr: meh, do you care about an extra few kb once per block?
 74 2016-05-18T06:00:26  <luke-jr> right, but that's before blocktxn
 75 2016-05-18T06:00:32  <BlueMatt> indeed?
 76 2016-05-18T06:00:41  <luke-jr> I don't know if it matters; it may not.
 77 2016-05-18T06:02:01  <BlueMatt> it'll be an extra packet or two
 78 2016-05-18T06:02:17  <BlueMatt> and it doesnt effect udp stuff
 79 2016-05-18T06:13:14  *** gribble has quit IRC
 80 2016-05-18T06:20:22  *** jannes has quit IRC
 81 2016-05-18T06:22:31  *** gribble has joined #bitcoin-core-dev
 82 2016-05-18T06:26:01  *** Alopex has quit IRC
 83 2016-05-18T06:26:22  *** gabridome has joined #bitcoin-core-dev
 84 2016-05-18T06:27:06  *** Alopex has joined #bitcoin-core-dev
 85 2016-05-18T06:37:48  *** gabridome has quit IRC
 86 2016-05-18T06:43:26  <jonasschnelli> luke-jr, petertodd: would you silently ignore (list as normal) incoming RBF txes?
 87 2016-05-18T06:43:58  <luke-jr> jonasschnelli: sure. they are no different in any practical sense than any other incoming txs
 88 2016-05-18T06:44:18  <jonasschnelli> except that they can be replaced.. :)
 89 2016-05-18T06:44:29  <luke-jr> all unconfirmed txs can be replaced.
 90 2016-05-18T06:44:40  <jonasschnelli> Sure. But they don't signal it explicit.
 91 2016-05-18T06:44:44  <luke-jr> irrelevant.
 92 2016-05-18T06:45:08  <jonasschnelli> So why do we have RBF then?
 93 2016-05-18T06:45:12  <luke-jr> because politics
 94 2016-05-18T06:45:20  <luke-jr> if you mean BIP 125
 95 2016-05-18T06:45:27  <luke-jr> RBF in general is just common sense really
 96 2016-05-18T06:46:21  <luke-jr> double spending was always easy for the criminal uses. RBF makes it practical for legitimate users too.
 97 2016-05-18T06:46:39  <luke-jr> BIP 125 is necessary to get around anti-RBF trolls.
 98 2016-05-18T06:48:20  <jonasschnelli> I don't care about politics and trolls. All I care is about a mempool rule that was written down in a Bip (125) and if a tx matches that bip rule (nSequence), it should be visible somewhere (can also be in the tx details once you doubleclick a tx).
 99 2016-05-18T06:49:57  <luke-jr> I don't care if you have the unenforcable nSequence stuff in the tx debug info window you get by double clicking it. I just don't think it should be presented to end users and relevant.
100 2016-05-18T06:50:15  <luke-jr> mempool policy is not a rule, and is a per-node decision
101 2016-05-18T06:50:38  <jonasschnelli> I kinda agree. 0-conf should be listed a 0-conf... maybe a slightly different icon (but same color attributes)?
102 2016-05-18T06:51:10  <luke-jr> there are plenty of nodes and even some miners who do RBF ignoring BIP 125 signalling, and that's not a problem.
103 2016-05-18T06:51:27  <luke-jr> there's no such thing as 0-conf, it's unconfirmed ;)
104 2016-05-18T06:51:50  <luke-jr> unconfirmed should of course be presented differently from confirmed, but AFAIK we already do that
105 2016-05-18T06:52:07  <jonasschnelli> luke-jr: requesting BIP number assignment for Peer-to-Peer Communication Encryption (https://github.com/bitcoin/bips/pull/362/files) (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-April/012599.html)
106 2016-05-18T06:52:24  <luke-jr> jonasschnelli: just encryption? or auth too?
107 2016-05-18T06:52:26  <jonasschnelli> Number assignment for "Authentication" is not required at this point.
108 2016-05-18T06:52:34  <jonasschnelli> (needs further discussion)
109 2016-05-18T06:53:03  <luke-jr> k, 151 for encryption
110 2016-05-18T06:53:13  <jonasschnelli> Super. Thanks!
111 2016-05-18T06:53:26  <luke-jr> I guess split the PR up so 151 can be merged alone..?
112 2016-05-18T06:54:44  <jonasschnelli> Yes. I'll remove the auth BIP from the PR and update the enc bip
113 2016-05-18T07:04:45  *** tErik_mc1 has joined #bitcoin-core-dev
114 2016-05-18T07:04:46  *** tErik_mc1 has joined #bitcoin-core-dev
115 2016-05-18T07:05:16  *** tErik_mc1 has joined #bitcoin-core-dev
116 2016-05-18T07:05:17  *** tErik_mc1 has joined #bitcoin-core-dev
117 2016-05-18T07:05:50  *** tErik_mc1 has joined #bitcoin-core-dev
118 2016-05-18T07:05:50  *** tErik_mc1 has joined #bitcoin-core-dev
119 2016-05-18T07:06:23  *** tErik_mc1 has joined #bitcoin-core-dev
120 2016-05-18T07:06:23  *** tErik_mc1 has joined #bitcoin-core-dev
121 2016-05-18T07:06:55  *** tErik_mc1 has joined #bitcoin-core-dev
122 2016-05-18T07:06:55  *** tErik_mc1 has joined #bitcoin-core-dev
123 2016-05-18T07:07:27  *** tErik_mc1 has joined #bitcoin-core-dev
124 2016-05-18T07:07:28  *** tErik_mc1 has joined #bitcoin-core-dev
125 2016-05-18T07:07:56  *** Guest75560 has joined #bitcoin-core-dev
126 2016-05-18T07:08:40  *** tErik_mc has quit IRC
127 2016-05-18T07:12:02  *** Alopex has quit IRC
128 2016-05-18T07:13:07  *** Alopex has joined #bitcoin-core-dev
129 2016-05-18T07:22:43  *** Guyver2 has joined #bitcoin-core-dev
130 2016-05-18T07:25:59  *** Ylbam has joined #bitcoin-core-dev
131 2016-05-18T07:31:01  *** Alopex has quit IRC
132 2016-05-18T07:32:06  *** Alopex has joined #bitcoin-core-dev
133 2016-05-18T07:35:26  *** droark has quit IRC
134 2016-05-18T07:38:30  <gmaxwell> BlueMatt: I'm sad to continue propagating the old varints in the protocol into more places. They're gratitiously inefficient for no reason... but I don't think the difference between the two really makes a meaningful bandwidth difference in this case.
135 2016-05-18T07:39:03  <gmaxwell> (the differential encoding otoh makes a huge difference)
136 2016-05-18T07:40:19  <sipa> gmaxwell: git btw uses little-endian varints, we use big endian ones
137 2016-05-18T07:44:35  <gmaxwell> BlueMatt: I believe use of the bitcoin one will never cause a increase in packet count, even in the worst case with a 2MB sw block.
138 2016-05-18T07:45:17  <BlueMatt> gmaxwell: it could with cmpctblock :p
139 2016-05-18T07:46:00  <gmaxwell> yes, there it could. but not in getblocktxn
140 2016-05-18T07:46:34  <gmaxwell> consider to get the 3 byte CompactSize, you'd need to have deltas of 254 or more. Well if you have 4000 btc, you can only have 15 such deltas.
141 2016-05-18T07:46:54  <gmaxwell> s/btc/txn/
142 2016-05-18T07:48:05  <BlueMatt> those extra few bytes...you never know :p
143 2016-05-18T07:48:30  <gmaxwell> Well in any case if we cared the fact that small ranges take a whole byte is the real problem. :)
144 2016-05-18T07:48:41  <gmaxwell> but I wasn't going to suggest you include a range coder.
145 2016-05-18T07:50:04  <gmaxwell> Though someday when we do a compactblk v2 that uses set reconcil. we'd need a range coder to efficiently encode the transaction ordering...
146 2016-05-18T07:53:05  <gmaxwell> BlueMatt: in any case, make whatever change you need to make so that I never again hear someone arguing that it should use "UTF-8".
147 2016-05-18T07:53:53  <BlueMatt> ..........
148 2016-05-18T07:53:54  <BlueMatt> "I wasn't going to suggest"....you keep saying this...........
149 2016-05-18T07:54:32  <BlueMatt> i mean i dont really give a shit about people making statements that are highly disconnected from reality...just that after having implemented it, I'm not sure its worth the protocol-complexity
150 2016-05-18T07:56:39  <gmaxwell> BlueMatt: yea, yank it out. I agree.
151 2016-05-18T08:02:29  <gmaxwell> https://people.xiph.org/~greg/temp/perm.tar.gz   permutation encoder that I started writing using the range coder from the daala video codec (which is a fast and efficient multiply free range coder with a nice API), which gets within about 0.5% of information thoretic efficiency. (e.g. it takes 1074 bytes to encode a permutation for 1000 elements).
152 2016-05-18T08:08:31  <gmaxwell> BlueMatt: the spec should say what happens if you send non-canonical CompactSize encodings.
153 2016-05-18T08:13:28  *** AaronvanW has joined #bitcoin-core-dev
154 2016-05-18T08:14:58  <BlueMatt> gmaxwell: i will point out that undefined behavior may eat cats, including non-canonical CompactSize :)
155 2016-05-18T08:15:17  *** davec has quit IRC
156 2016-05-18T08:16:50  *** BCBot has quit IRC
157 2016-05-18T08:20:37  *** davec has joined #bitcoin-core-dev
158 2016-05-18T08:29:29  *** AaronvanW has quit IRC
159 2016-05-18T08:34:55  *** AaronvanW has joined #bitcoin-core-dev
160 2016-05-18T08:42:01  *** CodeShark_ has joined #bitcoin-core-dev
161 2016-05-18T08:42:44  *** jl2012_ has joined #bitcoin-core-dev
162 2016-05-18T08:42:51  *** Taek42 has joined #bitcoin-core-dev
163 2016-05-18T08:44:07  *** kadoban_ has joined #bitcoin-core-dev
164 2016-05-18T08:44:45  *** Madars has joined #bitcoin-core-dev
165 2016-05-18T08:44:47  *** nickler_ has joined #bitcoin-core-dev
166 2016-05-18T08:44:47  *** jyap_ has joined #bitcoin-core-dev
167 2016-05-18T08:44:53  *** michagogo_ has joined #bitcoin-core-dev
168 2016-05-18T08:45:05  *** cfields_ has joined #bitcoin-core-dev
169 2016-05-18T08:45:19  *** Eliel_ has joined #bitcoin-core-dev
170 2016-05-18T08:45:39  *** TD--Linux has joined #bitcoin-core-dev
171 2016-05-18T08:45:39  *** jl2012 has quit IRC
172 2016-05-18T08:45:44  *** GreenIsMyPepper has quit IRC
173 2016-05-18T08:45:45  *** jyap has quit IRC
174 2016-05-18T08:45:46  *** CodeShark has quit IRC
175 2016-05-18T08:45:47  *** Madars_ has quit IRC
176 2016-05-18T08:45:49  *** michagogo has quit IRC
177 2016-05-18T08:45:50  *** spudowiar has quit IRC
178 2016-05-18T08:45:50  *** musalbas has quit IRC
179 2016-05-18T08:45:51  *** donal has quit IRC
180 2016-05-18T08:45:51  *** teward has quit IRC
181 2016-05-18T08:45:54  *** Eliel has quit IRC
182 2016-05-18T08:45:56  *** nsh has quit IRC
183 2016-05-18T08:45:57  *** kadoban has quit IRC
184 2016-05-18T08:45:59  *** nickler has quit IRC
185 2016-05-18T08:45:59  *** cfields has quit IRC
186 2016-05-18T08:46:02  *** TD-Linux has quit IRC
187 2016-05-18T08:46:03  *** Taek has quit IRC
188 2016-05-18T08:46:05  *** GreenIsMyPepper has joined #bitcoin-core-dev
189 2016-05-18T08:46:07  *** jl2012_ is now known as jl2012
190 2016-05-18T08:46:07  *** jyap_ is now known as jyap
191 2016-05-18T08:46:08  *** musalbas- is now known as musalbas
192 2016-05-18T08:46:09  *** jyap has quit IRC
193 2016-05-18T08:46:09  *** jyap has joined #bitcoin-core-dev
194 2016-05-18T08:46:19  *** lysobit- has joined #bitcoin-core-dev
195 2016-05-18T08:47:23  *** CodeShark_ is now known as CodeShark
196 2016-05-18T08:48:18  *** wallet42 has quit IRC
197 2016-05-18T08:48:28  *** spudowiar has joined #bitcoin-core-dev
198 2016-05-18T08:49:22  *** NicolasDorier has quit IRC
199 2016-05-18T08:49:36  *** eragmus has quit IRC
200 2016-05-18T08:49:49  *** teward has joined #bitcoin-core-dev
201 2016-05-18T08:51:02  *** nsh- has joined #bitcoin-core-dev
202 2016-05-18T08:52:55  <gmaxwell> jonasschnelli: sure the rpc and such shows the BIP125 replacability status. My only concern was that we not do something like printing a warning.
203 2016-05-18T08:53:18  <gmaxwell> jonasschnelli: because a warning would be material misinformation (as it would imply that transactions without the warning were more safe)
204 2016-05-18T08:54:04  <jonasschnelli> Yes. I agree. I think we should use a slighly different transaction icon (which should not imply a warning)
205 2016-05-18T08:54:11  <gmaxwell> jonasschnelli: though there are a dozen other characteristics we don't show anywhere in the UI that are often more interesting... we don't show when a transaction uses nlocktime.. we don't show the sighash flasgs of its signatures (for the latter, not even in the RPC).
206 2016-05-18T08:54:35  <gmaxwell> So I dunno why there would be an indicator icoin for 125 replacablity when there isn't one for nlocktime.
207 2016-05-18T08:55:22  <jonasschnelli> Yes. We should be careful with what we add to the gui level. Maybe I was to focused on bip125 and thought its important to see it "everywhere". But right,... its not.
208 2016-05-18T08:56:30  <jonasschnelli> IMO https://github.com/bitcoin/bitcoin/pull/7826 is more important. Because the GUI/current master does not list mempool conflicts as conflicts.
209 2016-05-18T08:56:38  *** NicolasDorier has joined #bitcoin-core-dev
210 2016-05-18T08:56:39  *** pedrobranco has joined #bitcoin-core-dev
211 2016-05-18T08:56:45  <jonasschnelli> Only conflicts with transactions in blocks
212 2016-05-18T08:56:58  <jonasschnelli> screenshots: https://github.com/bitcoin/bitcoin/pull/7826#issuecomment-206424972
213 2016-05-18T08:57:04  *** michagogo_ is now known as michagogo
214 2016-05-18T08:57:18  <gmaxwell> oh thats no good. The RPC gets that right.
215 2016-05-18T08:57:40  *** eragmus has joined #bitcoin-core-dev
216 2016-05-18T08:58:07  *** wallet42 has joined #bitcoin-core-dev
217 2016-05-18T08:58:38  <gmaxwell> jonasschnelli: hm. so a downside of that X if it's only mempool conflicted is that it sort of suggests the conflict can't actually go through.
218 2016-05-18T08:59:19  *** pedrobranco has quit IRC
219 2016-05-18T08:59:34  *** pedrobranco has joined #bitcoin-core-dev
220 2016-05-18T08:59:49  <jonasschnelli> gmaxwell: the "X" then would show that this transaction is replaced by another one.
221 2016-05-18T08:59:58  <jonasschnelli> gmaxwell: But maybe there are better ways to deal with that.
222 2016-05-18T09:00:06  <jonasschnelli> And yes. RPC does handle this, GUI currently not.
223 2016-05-18T09:00:48  <gmaxwell> which can lead to funds loss, e.g. say I pay Alice and then do something stupid with my wallet and pay Bob.   The payment to bob is conflicted with the alice transaction in my own mempool.  The Bob payment has an X.   Bob is whining that I haven't paid him, so then I go to pay him again, since that txn is "bad" (it has an X).   Then both bob payments go through.
224 2016-05-18T09:02:16  <GitHub116> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c3f8ddcaa11...5e374f73060d
225 2016-05-18T09:02:17  <GitHub116> bitcoin/master 0b1295b Pieter Wuille: Add SipHash-2-4 primitives to hash
226 2016-05-18T09:02:17  <GitHub116> bitcoin/master 382c871 Pieter Wuille: Use SipHash-2-4 for CCoinsCache index...
227 2016-05-18T09:02:18  <GitHub116> bitcoin/master 8cc9cfe Pieter Wuille: Switch CTxMempool::mapTx to use a hash index for txids
228 2016-05-18T09:02:24  *** Arnavion has quit IRC
229 2016-05-18T09:02:33  <jonasschnelli> gmaxwell: Hmm... how could you create a conflict with the GUI?
230 2016-05-18T09:02:39  *** Arnavion has joined #bitcoin-core-dev
231 2016-05-18T09:02:56  <gmaxwell> jonasschnelli: you can do it by loading two copies of the same wallet at once.
232 2016-05-18T09:02:58  <jonasschnelli> IMO it would only be possible with the rawtx* API
233 2016-05-18T09:03:01  <gmaxwell> or using raw txn.
234 2016-05-18T09:03:10  <gmaxwell> or by loading a wallet backup.
235 2016-05-18T09:03:35  <gmaxwell> Or by exporting a private key and using it in something else.
236 2016-05-18T09:04:02  <jonasschnelli> Same problem would be present on RPC listtransaction I guess.
237 2016-05-18T09:04:12  <gmaxwell> Obviously we try hard to make this difficult to do, but I've seen users do it unintentionally.
238 2016-05-18T09:04:27  <jonasschnelli> I don't see a easy solution to this.
239 2016-05-18T09:04:43  <gmaxwell> listtransactions though still will show you the confirmcount of 0. The additional information hopefully would reduce misunderstandings.
240 2016-05-18T09:04:51  <gmaxwell> I would suggest a ! instead of an X.
241 2016-05-18T09:04:56  <jonasschnelli> But I see there is a big value in attributing mempool conflicts (with RBF now).
242 2016-05-18T09:05:15  <jonasschnelli> Yes. Something different then a "X"
243 2016-05-18T09:05:19  <gmaxwell> "!" suggests there is something going wrong here without as much implication that it is dead.
244 2016-05-18T09:05:26  <gmaxwell> or something else.  Traffic cone. :)
245 2016-05-18T09:05:53  <gmaxwell> (for a transaction at -6 confirms ... then I would say an X is okay! :) )
246 2016-05-18T09:06:11  <jonasschnelli> But I guess the "!" transaction would never disappear.
247 2016-05-18T09:06:44  <jonasschnelli> Once the replaced transaction got mined, the original-replaced transaction would still be in the wallet.
248 2016-05-18T09:06:50  <jonasschnelli> This might lead to user confusion.
249 2016-05-18T09:07:24  <jonasschnelli> A right-click-context menu "hide transaction" for some transactions would be good IMO
250 2016-05-18T09:07:42  <gmaxwell> sure, so long as there is a way to 'show hidden transactions'
251 2016-05-18T09:08:05  <jonasschnelli> Yes... would be required. Maybe over the options.
252 2016-05-18T09:09:05  <gmaxwell> A good general UI design principle is that it should never be possible to do something that can't be undone... unless it's at least behind a confirmation.
253 2016-05-18T09:09:28  *** jannes has joined #bitcoin-core-dev
254 2016-05-18T09:09:35  <jonasschnelli> Yes. Especially if its a bookkeeping transaction list.
255 2016-05-18T09:09:53  <gmaxwell> and I think for this having a show/hide and a show hidden in the options menu.. would be okay. Perhaps even an automatically hide conflicted txn with -6 or more anti-confirmations. :)
256 2016-05-18T09:11:01  <jonasschnelli> Good point!
257 2016-05-18T09:11:20  <jonasschnelli> Also autohide "!" (mempool conflicts) once the replacement has been mined.
258 2016-05-18T09:18:04  *** binns has quit IRC
259 2016-05-18T09:19:46  *** binns has joined #bitcoin-core-dev
260 2016-05-18T09:27:26  <GitHub126> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e374f73060d...457b9df6b595
261 2016-05-18T09:27:26  <GitHub126> bitcoin/master fe80102 Matthew English: changing "(tests are) automatically run" to correspond to the earlier instance of "run automatically (on the build server)"
262 2016-05-18T09:27:27  <GitHub126> bitcoin/master 457b9df Wladimir J. van der Laan: Merge #8031: improvement to readability...
263 2016-05-18T09:27:36  <GitHub191> [bitcoin] laanwj closed pull request #8031: improvement to readability (master...patch-3) https://github.com/bitcoin/bitcoin/pull/8031
264 2016-05-18T09:54:05  <GitHub152> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/457b9df6b595...ed749bdb6480
265 2016-05-18T09:54:06  <GitHub152> bitcoin/master fb26bf0 Patrick Strateman: CAddrMan::Deserialize handle corrupt serializations better.
266 2016-05-18T09:54:06  <GitHub152> bitcoin/master ed749bd Wladimir J. van der Laan: Merge #7932: CAddrMan::Deserialize handle corrupt serializations better....
267 2016-05-18T09:54:15  <GitHub57> [bitcoin] laanwj closed pull request #7932: CAddrMan::Deserialize handle corrupt serializations better. (master...2016-04-23-addrman-deserialize-limits) https://github.com/bitcoin/bitcoin/pull/7932
268 2016-05-18T09:56:50  *** paveljanik has quit IRC
269 2016-05-18T10:13:26  <GitHub84> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed749bdb6480...83121cca7573
270 2016-05-18T10:13:27  <GitHub84> bitcoin/master 52cbce2 Cory Fields: net: don't import std namespace...
271 2016-05-18T10:13:27  <GitHub84> bitcoin/master 9faa490 Cory Fields: net: remove unused set
272 2016-05-18T10:13:28  <GitHub84> bitcoin/master 563f375 Cory Fields: net: use the exposed GetNodeSignals() rather than g_signals directly
273 2016-05-18T10:13:36  <GitHub163> [bitcoin] laanwj closed pull request #7906: net: prerequisites for p2p encapsulation changes (master...net-refactor-prerequisites) https://github.com/bitcoin/bitcoin/pull/7906
274 2016-05-18T10:16:24  <GitHub77> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/83121cca7573...c74837b724d1
275 2016-05-18T10:16:25  <GitHub77> bitcoin/master e5764e6 Wladimir J. van der Laan: doc: Remove outdated qt4 install information from README.md...
276 2016-05-18T10:16:26  <GitHub77> bitcoin/master 6075bc4 Wladimir J. van der Laan: doc: 32 and 64 bit packages are seperate
277 2016-05-18T10:16:26  <GitHub77> bitcoin/master c74837b Wladimir J. van der Laan: Merge #8048: doc: Remove outdated qt4 install information from README.md...
278 2016-05-18T10:16:36  <GitHub148> [bitcoin] laanwj closed pull request #8048: doc: Remove outdated qt4 install information from README.md (master...2016_05_doc_noqt4) https://github.com/bitcoin/bitcoin/pull/8048
279 2016-05-18T10:18:31  <GitHub163> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/c3aedca2df890916aee78351dbb24bada9887c64
280 2016-05-18T10:18:31  <GitHub163> bitcoin/0.12 c3aedca Wladimir J. van der Laan: doc: Remove outdated qt4 install information from README.md...
281 2016-05-18T10:28:39  <GitHub23> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c74837b724d1...8e8bebc040a9
282 2016-05-18T10:28:40  <GitHub23> bitcoin/master f93c2a1 Daniel Kraft: net: Avoid duplicate getheaders requests....
283 2016-05-18T10:28:41  <GitHub23> bitcoin/master 8e8bebc Wladimir J. van der Laan: Merge #8054: net: Avoid duplicate getheaders requests....
284 2016-05-18T10:28:50  <GitHub41> [bitcoin] laanwj closed pull request #8054: net: Avoid duplicate getheaders requests. (master...per-client-duplicate-getheaders) https://github.com/bitcoin/bitcoin/pull/8054
285 2016-05-18T10:31:54  <GitHub120> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/8e8bebc040a9...239d41986454
286 2016-05-18T10:31:56  <GitHub120> bitcoin/master d253ec4 Pieter Wuille: Make ProcessNewBlock dbp const and update comment
287 2016-05-18T10:31:56  <GitHub120> bitcoin/master 316623f Pieter Wuille: Switch reindexing to AcceptBlock in-loop and ActivateBestChain afterwards
288 2016-05-18T10:31:57  <GitHub120> bitcoin/master fb8fad1 Pieter Wuille: Optimize ActivateBestChain for long chains
289 2016-05-18T10:32:02  <GitHub49> [bitcoin] laanwj closed pull request #7917: Optimize reindex (master...betterreindex) https://github.com/bitcoin/bitcoin/pull/7917
290 2016-05-18T11:29:25  *** kadoban_ has quit IRC
291 2016-05-18T11:32:41  *** gabridome has joined #bitcoin-core-dev
292 2016-05-18T11:36:04  *** ghtdak has quit IRC
293 2016-05-18T11:48:32  *** pedrobranco has quit IRC
294 2016-05-18T11:50:36  *** ghtdak has joined #bitcoin-core-dev
295 2016-05-18T11:51:03  *** pedrobranco has joined #bitcoin-core-dev
296 2016-05-18T11:52:59  *** arowser has quit IRC
297 2016-05-18T11:53:27  *** arowser has joined #bitcoin-core-dev
298 2016-05-18T12:04:06  *** pedrobranco has quit IRC
299 2016-05-18T12:05:33  *** gevs has quit IRC
300 2016-05-18T12:08:25  *** laurentmt has joined #bitcoin-core-dev
301 2016-05-18T12:13:56  *** gevs has joined #bitcoin-core-dev
302 2016-05-18T12:13:57  *** gevs has joined #bitcoin-core-dev
303 2016-05-18T12:18:20  *** gabridome has quit IRC
304 2016-05-18T12:28:00  *** pedrobranco has joined #bitcoin-core-dev
305 2016-05-18T12:28:53  *** cryptapus_ has joined #bitcoin-core-dev
306 2016-05-18T12:31:38  *** pedrobranco has quit IRC
307 2016-05-18T12:32:35  *** pedrobranco has joined #bitcoin-core-dev
308 2016-05-18T12:33:21  *** Guyver2 has quit IRC
309 2016-05-18T12:44:21  *** cryptapus_ is now known as cryptapus
310 2016-05-18T12:54:17  *** laurentmt has quit IRC
311 2016-05-18T12:54:39  *** laurentmt has joined #bitcoin-core-dev
312 2016-05-18T12:58:15  *** laurentmt has quit IRC
313 2016-05-18T13:04:19  *** pedrobranco has quit IRC
314 2016-05-18T13:09:49  *** pet_rock has joined #bitcoin-core-dev
315 2016-05-18T13:11:36  *** hrusti has joined #bitcoin-core-dev
316 2016-05-18T13:21:27  *** pedrobranco has joined #bitcoin-core-dev
317 2016-05-18T13:28:20  *** TomMc has joined #bitcoin-core-dev
318 2016-05-18T13:41:53  *** JackH has quit IRC
319 2016-05-18T13:43:27  *** xiangfu has joined #bitcoin-core-dev
320 2016-05-18T13:57:32  *** pedrobranco has quit IRC
321 2016-05-18T13:59:37  *** pedrobranco has joined #bitcoin-core-dev
322 2016-05-18T14:01:34  *** xiangfu has quit IRC
323 2016-05-18T14:03:10  *** xiangfu has joined #bitcoin-core-dev
324 2016-05-18T14:09:06  *** xiangfu has quit IRC
325 2016-05-18T14:19:22  *** xiangfu has joined #bitcoin-core-dev
326 2016-05-18T14:20:15  *** Inaltoasinistra has joined #bitcoin-core-dev
327 2016-05-18T14:22:58  *** Giszmo has joined #bitcoin-core-dev
328 2016-05-18T14:35:44  *** Guyver2 has joined #bitcoin-core-dev
329 2016-05-18T14:57:12  *** xiangfu has quit IRC
330 2016-05-18T15:03:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
331 2016-05-18T15:09:39  *** Chris_Stewart_5 has quit IRC
332 2016-05-18T15:10:34  *** MarcoFalke has joined #bitcoin-core-dev
333 2016-05-18T15:12:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
334 2016-05-18T15:15:34  *** gabridome has joined #bitcoin-core-dev
335 2016-05-18T15:19:37  *** gabridome has quit IRC
336 2016-05-18T15:31:24  *** paveljanik has joined #bitcoin-core-dev
337 2016-05-18T15:48:27  *** zooko has joined #bitcoin-core-dev
338 2016-05-18T16:08:31  <GitHub40> [bitcoin] EthanHeilman opened pull request #8070: Remove non-determinism which is breaking net_tests #8069 (master...bug) https://github.com/bitcoin/bitcoin/pull/8070
339 2016-05-18T16:09:46  *** Taek42 is now known as Taek
340 2016-05-18T16:16:02  *** molz has quit IRC
341 2016-05-18T16:16:25  *** molz has joined #bitcoin-core-dev
342 2016-05-18T16:30:54  *** Chris_Stewart_5 has quit IRC
343 2016-05-18T16:32:56  *** MarcoFalke has quit IRC
344 2016-05-18T16:54:20  *** zooko has quit IRC
345 2016-05-18T17:00:50  <GitHub123> [bitcoin] morcos closed pull request #7716: [0.11] Backport BIP9 and softfork for BIP's 68,112,113 (0.11...backportBIP9SoftFork) https://github.com/bitcoin/bitcoin/pull/7716
346 2016-05-18T17:05:56  *** Gnar has joined #bitcoin-core-dev
347 2016-05-18T17:05:59  <Gnar> shitcoins
348 2016-05-18T17:14:18  *** earlest has joined #bitcoin-core-dev
349 2016-05-18T17:17:34  *** bysherper has quit IRC
350 2016-05-18T17:19:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
351 2016-05-18T17:25:13  *** Gnar has left #bitcoin-core-dev
352 2016-05-18T17:57:23  *** molly has joined #bitcoin-core-dev
353 2016-05-18T18:00:34  *** molz has quit IRC
354 2016-05-18T18:05:20  *** Chris_Stewart_5 has quit IRC
355 2016-05-18T18:09:15  *** jonasschnelli has quit IRC
356 2016-05-18T18:11:06  *** jonasschnelli has joined #bitcoin-core-dev
357 2016-05-18T18:14:00  *** laurentmt has joined #bitcoin-core-dev
358 2016-05-18T18:16:32  *** laurentmt has quit IRC
359 2016-05-18T18:20:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
360 2016-05-18T18:20:58  *** moli has joined #bitcoin-core-dev
361 2016-05-18T18:24:13  *** molly has quit IRC
362 2016-05-18T18:32:25  *** gabridome has joined #bitcoin-core-dev
363 2016-05-18T18:32:26  *** TD--Linux is now known as TD-Linux
364 2016-05-18T18:32:26  *** TD-Linux has joined #bitcoin-core-dev
365 2016-05-18T18:36:29  *** molz has joined #bitcoin-core-dev
366 2016-05-18T18:40:10  *** moli has quit IRC
367 2016-05-18T18:50:52  *** jtimon has joined #bitcoin-core-dev
368 2016-05-18T18:50:55  *** jtimon has quit IRC
369 2016-05-18T18:51:25  *** gabridome has quit IRC
370 2016-05-18T18:53:34  *** pedrobranco has quit IRC
371 2016-05-18T18:54:39  *** zooko has joined #bitcoin-core-dev
372 2016-05-18T19:02:44  *** belcher has joined #bitcoin-core-dev
373 2016-05-18T19:05:26  *** zooko` has joined #bitcoin-core-dev
374 2016-05-18T19:07:04  *** zooko has quit IRC
375 2016-05-18T19:17:40  *** gabridome has joined #bitcoin-core-dev
376 2016-05-18T19:19:04  *** jannes has quit IRC
377 2016-05-18T19:20:34  *** gabridome has quit IRC
378 2016-05-18T19:24:31  *** pedrobranco has joined #bitcoin-core-dev
379 2016-05-18T19:29:01  *** pedrobranco has quit IRC
380 2016-05-18T19:30:23  *** kadoban_ has joined #bitcoin-core-dev
381 2016-05-18T19:34:17  <luke-jr> jonasschnelli: https://travis-ci.org/bitcoin/bips/builds/131230516
382 2016-05-18T19:37:13  <jonasschnelli> Okay. Force pushed something... lets have a look. Thanks @luke-jr
383 2016-05-18T19:38:37  *** kadoban_ is now known as kadoban
384 2016-05-18T19:38:44  <jonasschnelli> Looks good now: https://travis-ci.org/bitcoin/bips/builds/131233173
385 2016-05-18T19:55:52  *** cryptapus has quit IRC
386 2016-05-18T20:01:04  <morcos> i'm getting this intermittant testing error: test/net_tests.cpp(92): error in "caddrdb_read": check addrman1.size() == 3 failed   (also in line 102)
387 2016-05-18T20:01:07  *** bysherper has joined #bitcoin-core-dev
388 2016-05-18T20:01:54  <paveljanik> morcos, #8070
389 2016-05-18T20:02:15  <paveljanik> and #8069 8)
390 2016-05-18T20:02:53  <morcos> paveljanik: thanks!
391 2016-05-18T20:04:04  *** earlest has quit IRC
392 2016-05-18T20:10:27  *** Chris_Stewart_5 has quit IRC
393 2016-05-18T20:27:48  <cjcj> Will compact blocks make it into 0.13?
394 2016-05-18T20:40:05  <gmaxwell> cjcj: why do you ask?
395 2016-05-18T20:40:17  <cjcj> Curiosity
396 2016-05-18T20:41:11  <gmaxwell> Hopefully. No guarentees can be made for things that aren't in yet.
397 2016-05-18T20:54:32  *** cryptapus_afk is now known as cryptapus
398 2016-05-18T20:55:57  *** spudowiar has quit IRC
399 2016-05-18T20:58:34  *** gabridome has joined #bitcoin-core-dev
400 2016-05-18T21:00:06  *** earlest has joined #bitcoin-core-dev
401 2016-05-18T21:03:04  *** bysherper has quit IRC
402 2016-05-18T21:23:50  *** zooko` has quit IRC
403 2016-05-18T21:27:47  *** Gnar has joined #bitcoin-core-dev
404 2016-05-18T21:27:50  <Gnar> shticoins
405 2016-05-18T21:29:02  *** ChanServ sets mode: +o sipa
406 2016-05-18T21:29:11  *** sipa sets mode: +b *!*Gnar@unaffiliated/gnar
407 2016-05-18T21:29:11  *** Gnar was kicked by sipa (Gnar)
408 2016-05-18T21:29:24  *** sipa sets mode: -o sipa
409 2016-05-18T21:35:25  *** pmienk has quit IRC
410 2016-05-18T21:38:37  *** gabridome has quit IRC
411 2016-05-18T21:44:41  *** bysherper has joined #bitcoin-core-dev
412 2016-05-18T21:47:33  *** earlest has quit IRC
413 2016-05-18T21:48:42  *** raedah has quit IRC
414 2016-05-18T21:52:19  *** [Author] has quit IRC
415 2016-05-18T21:56:15  *** spudowiar has joined #bitcoin-core-dev
416 2016-05-18T22:01:40  *** Guyver2 has quit IRC
417 2016-05-18T22:13:46  <bad_duck> It might be a good idea to replace this link (wget -P inputs http://downloads.sourceforge.net/project/osslsigncode/osslsigncode/osslsigncode-1.7.1.tar.gz )
418 2016-05-18T22:13:59  <bad_duck> with an https version, here -> https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md
419 2016-05-18T22:14:23  <bad_duck> the links seems to work in https too
420 2016-05-18T22:17:19  *** kadoban has quit IRC
421 2016-05-18T22:20:43  *** Alopex has quit IRC
422 2016-05-18T22:22:31  *** kadoban has joined #bitcoin-core-dev
423 2016-05-18T22:26:06  *** Alopex has joined #bitcoin-core-dev
424 2016-05-18T22:29:33  *** kadoban has quit IRC
425 2016-05-18T22:30:24  *** pedrobranco has joined #bitcoin-core-dev
426 2016-05-18T22:31:20  *** supasonic has joined #bitcoin-core-dev
427 2016-05-18T22:31:21  *** bsm117532 has quit IRC
428 2016-05-18T22:32:26  *** kadoban has joined #bitcoin-core-dev
429 2016-05-18T22:35:05  *** pedrobranco has quit IRC
430 2016-05-18T22:59:56  *** laurentmt has joined #bitcoin-core-dev
431 2016-05-18T23:19:14  <phantomcircuit> bad_duck: it doesn't matter, the file downloaded is checked against a hash
432 2016-05-18T23:24:17  <bad_duck> phantomcircuit: ok, thx!
433 2016-05-18T23:25:11  *** alpalp has joined #bitcoin-core-dev
434 2016-05-18T23:30:06  *** laurentmt has quit IRC