1 2016-05-27T00:01:13  *** Ylbam has quit IRC
  2 2016-05-27T00:01:40  *** PaulCapestany has quit IRC
  3 2016-05-27T00:02:22  *** Guyver2 has quit IRC
  4 2016-05-27T00:04:59  *** pedrobranco has joined #bitcoin-core-dev
  5 2016-05-27T00:09:45  *** pedrobranco has quit IRC
  6 2016-05-27T00:17:53  *** fengling has joined #bitcoin-core-dev
  7 2016-05-27T00:22:39  *** fengling has quit IRC
  8 2016-05-27T00:23:50  *** kadoban has quit IRC
  9 2016-05-27T00:49:38  *** fengling has joined #bitcoin-core-dev
 10 2016-05-27T01:16:49  *** PaulCapestany has joined #bitcoin-core-dev
 11 2016-05-27T01:19:46  *** PaulCape_ has quit IRC
 12 2016-05-27T01:53:14  *** pedrobranco has joined #bitcoin-core-dev
 13 2016-05-27T01:57:38  *** pedrobranco has quit IRC
 14 2016-05-27T02:41:51  *** PaulCape_ has joined #bitcoin-core-dev
 15 2016-05-27T02:45:01  *** PaulCapestany has quit IRC
 16 2016-05-27T02:46:44  <GitHub117> [bitcoin] yurizhykin opened pull request #8107: bench: Added base58 encoding/decoding benchmarks (master...benchmarks) https://github.com/bitcoin/bitcoin/pull/8107
 17 2016-05-27T02:47:50  *** achow101 has quit IRC
 18 2016-05-27T02:57:48  *** dermoth__ has joined #bitcoin-core-dev
 19 2016-05-27T03:00:33  *** tucenaber has quit IRC
 20 2016-05-27T03:01:52  *** dermoth_ has quit IRC
 21 2016-05-27T03:03:51  *** PaulCapestany has joined #bitcoin-core-dev
 22 2016-05-27T03:06:20  *** Giszmo has quit IRC
 23 2016-05-27T03:07:01  *** PaulCape_ has quit IRC
 24 2016-05-27T03:12:06  *** kadoban has joined #bitcoin-core-dev
 25 2016-05-27T03:41:15  *** pedrobranco has joined #bitcoin-core-dev
 26 2016-05-27T03:43:22  *** Chris_Stewart_5 has quit IRC
 27 2016-05-27T03:46:04  *** pedrobranco has quit IRC
 28 2016-05-27T03:59:57  *** PaulCape_ has joined #bitcoin-core-dev
 29 2016-05-27T04:03:07  *** PaulCapestany has quit IRC
 30 2016-05-27T04:06:09  *** tucenaber has joined #bitcoin-core-dev
 31 2016-05-27T04:44:39  *** fengling has quit IRC
 32 2016-05-27T04:52:30  *** PaulCapestany has joined #bitcoin-core-dev
 33 2016-05-27T04:55:22  *** PaulCape_ has quit IRC
 34 2016-05-27T05:17:01  *** PaulCape_ has joined #bitcoin-core-dev
 35 2016-05-27T05:20:07  *** PaulCapestany has quit IRC
 36 2016-05-27T05:29:35  *** pedrobranco has joined #bitcoin-core-dev
 37 2016-05-27T05:33:57  *** pedrobranco has quit IRC
 38 2016-05-27T05:34:47  *** fengling has joined #bitcoin-core-dev
 39 2016-05-27T05:37:49  *** molz has joined #bitcoin-core-dev
 40 2016-05-27T05:39:39  *** fengling has quit IRC
 41 2016-05-27T05:41:05  *** moli has quit IRC
 42 2016-05-27T05:42:35  *** PaulCapestany has joined #bitcoin-core-dev
 43 2016-05-27T05:43:09  *** fengling has joined #bitcoin-core-dev
 44 2016-05-27T05:45:25  *** PaulCape_ has quit IRC
 45 2016-05-27T05:50:31  <GitHub166> [bitcoin] paveljanik opened pull request #8108: Trivial: Remove unused local variable shadowing upper local (master...20160527_trivial_sighash_tests) https://github.com/bitcoin/bitcoin/pull/8108
 46 2016-05-27T06:04:06  <GitHub57> [bitcoin] paveljanik opened pull request #8109: Do not shadow member variables (master...20160527_shadow_httpserver) https://github.com/bitcoin/bitcoin/pull/8109
 47 2016-05-27T06:05:23  *** MrHodl has joined #bitcoin-core-dev
 48 2016-05-27T06:05:23  *** fuc has quit IRC
 49 2016-05-27T06:09:37  *** PaulCape_ has joined #bitcoin-core-dev
 50 2016-05-27T06:12:55  *** PaulCapestany has quit IRC
 51 2016-05-27T06:13:59  *** fengling has quit IRC
 52 2016-05-27T06:22:31  <GitHub90> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/425278d17bd0...06bd4f637f15
 53 2016-05-27T06:22:31  <GitHub90> bitcoin/master fa57b0c MarcoFalke: [qa] test_framework: Append portseed to tmpdir...
 54 2016-05-27T06:22:32  <GitHub90> bitcoin/master 06bd4f6 MarcoFalke: Merge #8098: [qa] test_framework: Append portseed to tmpdir...
 55 2016-05-27T06:22:41  <GitHub20> [bitcoin] MarcoFalke closed pull request #8098: [qa] test_framework: Append portseed to tmpdir (master...Mf1605-qatmpdir) https://github.com/bitcoin/bitcoin/pull/8098
 56 2016-05-27T06:37:11  *** PaulCapestany has joined #bitcoin-core-dev
 57 2016-05-27T06:40:25  *** PaulCape_ has quit IRC
 58 2016-05-27T06:49:20  <GitHub193> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/06bd4f637f15...a80de1511316
 59 2016-05-27T06:49:20  <GitHub193> bitcoin/master 13c4558 Pavel Janík: Remove unused local variable shadowing upper local
 60 2016-05-27T06:49:21  <GitHub193> bitcoin/master a80de15 MarcoFalke: Merge #8108: Trivial: Remove unused local variable shadowing upper local...
 61 2016-05-27T06:49:32  <GitHub95> [bitcoin] MarcoFalke closed pull request #8108: Trivial: Remove unused local variable shadowing upper local (master...20160527_trivial_sighash_tests) https://github.com/bitcoin/bitcoin/pull/8108
 62 2016-05-27T06:50:41  *** fengling has joined #bitcoin-core-dev
 63 2016-05-27T07:02:25  *** Amnez777 has quit IRC
 64 2016-05-27T07:02:49  *** PaulCape_ has joined #bitcoin-core-dev
 65 2016-05-27T07:05:43  *** PaulCapestany has quit IRC
 66 2016-05-27T07:06:19  *** fengling has quit IRC
 67 2016-05-27T07:07:02  *** fengling has joined #bitcoin-core-dev
 68 2016-05-27T07:17:36  *** pedrobranco has joined #bitcoin-core-dev
 69 2016-05-27T07:22:00  *** pedrobranco has quit IRC
 70 2016-05-27T07:27:40  *** AaronvanW has joined #bitcoin-core-dev
 71 2016-05-27T07:29:42  *** kxie has quit IRC
 72 2016-05-27T07:31:53  *** PaulCapestany has joined #bitcoin-core-dev
 73 2016-05-27T07:34:52  *** PaulCape_ has quit IRC
 74 2016-05-27T07:41:09  *** Evel-Knievel has quit IRC
 75 2016-05-27T07:42:37  *** Evel-Knievel has joined #bitcoin-core-dev
 76 2016-05-27T07:49:04  *** Arnavion has quit IRC
 77 2016-05-27T07:49:22  *** Ylbam has joined #bitcoin-core-dev
 78 2016-05-27T07:49:31  *** Arnavion has joined #bitcoin-core-dev
 79 2016-05-27T07:50:12  *** AtashiCon has quit IRC
 80 2016-05-27T07:50:57  *** AtashiCon has joined #bitcoin-core-dev
 81 2016-05-27T07:59:27  *** PaulCape_ has joined #bitcoin-core-dev
 82 2016-05-27T08:02:22  *** PaulCapestany has quit IRC
 83 2016-05-27T08:03:47  <GitHub4> [bitcoin] fanquake opened pull request #8110: [Doc] Add benchmarking notes (master...mention_bench) https://github.com/bitcoin/bitcoin/pull/8110
 84 2016-05-27T08:18:14  *** Guyver2 has joined #bitcoin-core-dev
 85 2016-05-27T08:22:38  *** Amnez777 has joined #bitcoin-core-dev
 86 2016-05-27T08:25:05  *** frankenmint has joined #bitcoin-core-dev
 87 2016-05-27T08:30:37  *** xiangfu has joined #bitcoin-core-dev
 88 2016-05-27T08:38:44  *** donal has joined #bitcoin-core-dev
 89 2016-05-27T08:52:02  *** assder has quit IRC
 90 2016-05-27T09:00:44  *** rubensayshi has quit IRC
 91 2016-05-27T09:02:33  *** rubensayshi has joined #bitcoin-core-dev
 92 2016-05-27T09:05:53  *** pedrobranco has joined #bitcoin-core-dev
 93 2016-05-27T09:10:09  *** pedrobranco has quit IRC
 94 2016-05-27T09:20:55  *** jcorgan has quit IRC
 95 2016-05-27T09:21:41  *** Guyver2 has quit IRC
 96 2016-05-27T09:26:54  <paveljanik> kanzure, how many parallel discussion are you able to type? Thanks for the Zurich log! I'll read it all weekend ;-)
 97 2016-05-27T09:28:59  *** pedrobranco has joined #bitcoin-core-dev
 98 2016-05-27T09:30:51  *** kadoban has quit IRC
 99 2016-05-27T09:45:12  <sipa> paveljanik: on tuesday we were separated into groups, and kanzure was only in one at a time
100 2016-05-27T09:45:24  <sipa> eh, on saturday
101 2016-05-27T09:45:38  <sipa> otherwise, i think he transcribed most
102 2016-05-27T09:46:27  <paveljanik> anyway, unbelievable :-)
103 2016-05-27T09:46:44  <sipa> and he types faster than most people can speak
104 2016-05-27T09:47:01  <sipa> happy that the transcript is useful
105 2016-05-27T09:47:15  <sipa> i've wanted to go through it and annotate with context and clarifications
106 2016-05-27T09:47:20  <sipa> but it's so huge...
107 2016-05-27T09:47:47  <paveljanik> 13 printed pages of 4 A4 on 1 A4...
108 2016-05-27T09:50:40  <sipa> feel free to ask questions though
109 2016-05-27T09:50:45  <sipa> it's sometimes hard to follow
110 2016-05-27T09:51:00  <sipa> spoken word is not always very consistent :)
111 2016-05-27T09:51:40  <paveljanik> thanks. I'll read it in the silent evening, in the wild, without connectivity 8)
112 2016-05-27T10:11:28  *** AaronvanW has quit IRC
113 2016-05-27T10:13:06  *** AaronvanW has joined #bitcoin-core-dev
114 2016-05-27T10:13:07  *** AaronvanW has joined #bitcoin-core-dev
115 2016-05-27T10:54:54  *** fengling has quit IRC
116 2016-05-27T11:04:57  *** frankenmint has quit IRC
117 2016-05-27T11:05:19  *** frankenmint has joined #bitcoin-core-dev
118 2016-05-27T11:10:43  *** achow101 has joined #bitcoin-core-dev
119 2016-05-27T11:23:58  *** cryptapus_afk is now known as cryptapus
120 2016-05-27T11:36:40  *** jannes has joined #bitcoin-core-dev
121 2016-05-27T11:39:40  *** jtimon has joined #bitcoin-core-dev
122 2016-05-27T12:19:35  *** gabridome_ has joined #bitcoin-core-dev
123 2016-05-27T12:24:41  *** xiangfu has quit IRC
124 2016-05-27T12:24:56  *** gabridome_ has quit IRC
125 2016-05-27T12:44:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
126 2016-05-27T12:45:59  *** ghounds has joined #bitcoin-core-dev
127 2016-05-27T12:50:44  *** Chris_Stewart_5 has quit IRC
128 2016-05-27T13:14:09  *** roger_ has quit IRC
129 2016-05-27T13:24:13  *** paveljanik has quit IRC
130 2016-05-27T13:32:03  <cfields_> jonasschnelli: ping
131 2016-05-27T13:32:09  <jonasschnelli> cfields_: pong
132 2016-05-27T13:32:19  <cfields_> jonasschnelli: ooh, that was quick :)
133 2016-05-27T13:32:23  <jonasschnelli> latency?
134 2016-05-27T13:32:25  <jonasschnelli> :-)
135 2016-05-27T13:33:00  <cfields_> jonasschnelli: i'd be grateful if i could get a quick opinion on the qt part of the net refactor, when you have a few min to spare
136 2016-05-27T13:33:20  <jonasschnelli> cfields_: sure... is there a PR or a branch I can look at?
137 2016-05-27T13:33:32  <cfields_> jonasschnelli: for now, qt is using one global everywhere. That works for now, but it's not ideal. I'm not sure where to start with passing it around properly
138 2016-05-27T13:33:47  <sipa> cfields_: clientmodel ?
139 2016-05-27T13:34:02  <sipa> and perhaps walletmodel
140 2016-05-27T13:34:03  <cfields_> sipa: that seemed too easy, i was hoping that'd be the answer :)
141 2016-05-27T13:34:26  <cfields_> jonasschnelli: https://github.com/theuni/bitcoin/commits/net-refactor13
142 2016-05-27T13:34:31  * jonasschnelli is looking at the code...
143 2016-05-27T13:34:48  <cfields_> jonasschnelli: https://github.com/theuni/bitcoin/commit/52b8c0758f0be0f0163b7f8c773f3fa5990e0ac5 as an example of how it was done for the wallet code
144 2016-05-27T13:35:35  <cfields_> (that's no ideal, i discussed some potential future work with wumpus. I think you've previously discussed more of a pull model for broadcasting txs, this would fit in nicely with that)
145 2016-05-27T13:35:52  *** donal has quit IRC
146 2016-05-27T13:36:01  <jonasschnelli> cfields_: So, CConnman is the p2p abstraction from the wallet perspective?
147 2016-05-27T13:36:16  <jonasschnelli> Ideally I'd like to see a node abstraction from the wallet perspective.
148 2016-05-27T13:36:20  <cfields_> jonasschnelli: yes
149 2016-05-27T13:36:33  <jonasschnelli> like node->estimatefee, node->broadcastsomething, etc.
150 2016-05-27T13:36:43  <jonasschnelli> but your step seems right.
151 2016-05-27T13:36:59  * jonasschnelli is looking how we interact with that in the GUI part
152 2016-05-27T13:37:14  <cfields_> jonasschnelli: well, this takes care of the 2nd, but not the first. For ex, you may be running without networking, but still want to commit a tx for later broadcasting
153 2016-05-27T13:37:27  <cfields_> jonasschnelli: sec for an example there
154 2016-05-27T13:38:26  <cfields_> sipa: btw, I know I owe you some reviews/acks/PRs. Not forgotten.
155 2016-05-27T13:38:49  <jonasschnelli> cfields_: the GUI also uses wallet->CommitTransaction directly
156 2016-05-27T13:38:56  <jonasschnelli> walletmodel.cpp
157 2016-05-27T13:39:03  <cfields_> jonasschnelli: https://github.com/theuni/bitcoin/commit/1a39dd2c4c054bab1aa5fcfce4b2d0ef13d5a69f#diff-b2fd932827da713e319b8f797b7b3795
158 2016-05-27T13:39:08  <sipa> it should not!
159 2016-05-27T13:39:12  <cfields_> there's a good simple example
160 2016-05-27T13:40:14  <cfields_> jonasschnelli: for now, I'm just using a global there because I'm not sure how to pass the instance properly. Should it be as sipa suggested, in clientmodel?
161 2016-05-27T13:40:14  <jonasschnelli> cfields_: looks good!
162 2016-05-27T13:40:52  <sipa> cfields_: none of the gui code should know anything core related, ideally
163 2016-05-27T13:40:58  <sipa> so certainly not about connman
164 2016-05-27T13:41:11  <jonasschnelli> I think walletmodel is fine...
165 2016-05-27T13:41:26  <gmaxwell> "developers adding conman to bitcoin core"
166 2016-05-27T13:41:32  <sipa> i think the connman connnnman
167 2016-05-27T13:42:03  <gmaxwell> :P
168 2016-05-27T13:42:27  <cfields_> sipa: hmm, why not? It's cleanly separated from the rest of bitcoin, and knows nothing of transactions/blocks/etc. Seems abstract enough for the gui to deal with directly?
169 2016-05-27T13:42:43  <jonasschnelli> cfields_: so right? the wallet does not keep track of the conman?
170 2016-05-27T13:42:57  <cfields_> sipa: or do you have in mind an abstraction layer on top of that?
171 2016-05-27T13:43:26  <jonasschnelli> the wallet object itself is not capable of broadcasting a transaction?
172 2016-05-27T13:44:26  <cfields_> jonasschnelli: for now, the wallet is passed an instance of connman. Ideally in the next refactor round, we'd switch to a pull model, where the application layer requests tx's to be broadcast, and sends them to its connman instance
173 2016-05-27T13:44:30  <jonasschnelli> What about having some glue-code that abstracts the "node". Chain could be <core>-<connman>-<node-api>-<GUI/clientmodel>-<GUI/gui>?
174 2016-05-27T13:45:09  <cfields_> cfields_: maybe the pull model ^^ is what you had in mind?
175 2016-05-27T13:46:05  <jonasschnelli> cfields_: g_connman is a global singleton?
176 2016-05-27T13:46:47  <cfields_> jonasschnelli: by node, you mean a remote peer like CNode? I'm not sure what you mean by that chain, really
177 2016-05-27T13:47:02  <gmaxwell> ConnmanWrapperFactorySingleton.
178 2016-05-27T13:47:19  *** TomMc has joined #bitcoin-core-dev
179 2016-05-27T13:47:24  <cfields_> jonasschnelli: It's a global now simply for convenience. The global needs to go away though, that's the part I'm working on
180 2016-05-27T13:47:52  <jonasschnelli> cfields_: Sorry. Confusing. With "node glue code" I was not thinking of a CNode object,... with "node glue code" I was more thinking of a full-node abstraction that could expose "boardcast", "estimatefee", "syncblocks", etc.
181 2016-05-27T13:48:23  <jonasschnelli> cfields_: maybe for now you access g_connman from clientmodel.cpp and broadcast from there?
182 2016-05-27T13:48:33  <cfields_> jonasschnelli: the global is used only in the qt code and rpc, simply because I haven't done the work yet to pass the instance properly. It's a temporary hack.
183 2016-05-27T13:48:39  <jonasschnelli> Or an alternative solution would be to use g_connman from walletmodel.cpp
184 2016-05-27T13:49:17  <jonasschnelli> Ideally the wallet should only share base classes and only talk to the core code over a single api (node-glue-code).
185 2016-05-27T13:49:28  <cfields_> ok, thanks. I'll have a look at that.
186 2016-05-27T13:49:37  <jonasschnelli> the api/glue-code could then once be replaced with RPC/ZMQ or similar.
187 2016-05-27T13:49:39  <cfields_> jonasschnelli: yes, I see what you're getting at
188 2016-05-27T13:50:07  <jonasschnelli> [15:47:01]  <gmaxwell>	ConnmanWrapperFactorySingleton.
189 2016-05-27T13:50:07  <sipa> cfields_: why does the gui itself need to know anything about connman?
190 2016-05-27T13:50:08  <jonasschnelli> lol
191 2016-05-27T13:50:21  <sipa> cfields_: all interactions with it should already be going through clientmodel
192 2016-05-27T13:50:31  <jonasschnelli> sipa: because there is no glue-code. :)
193 2016-05-27T13:50:51  <cfields_> sipa: i'm pretty sure the problem is simply that I have no idea how the gui code is structured
194 2016-05-27T13:51:11  <jonasschnelli> cfields_: the idea is that clientmodel "talks" to the core objects.
195 2016-05-27T13:51:42  <jonasschnelli> But IIRC there are many places where the GUI talks directly with a core object/instance.
196 2016-05-27T13:51:43  <cfields_> i see. So rather than using g_connman to ban a peer, it should be requesting that the clientmodel bans on its behalf?
197 2016-05-27T13:51:52  <jonasschnelli> cfields_: Yes!
198 2016-05-27T13:52:31  <cfields_> jonasschnelli: light bulb! That makes perfect sense. I should just be extending that, then.
199 2016-05-27T13:52:33  <sipa> cfields_: yes!
200 2016-05-27T13:53:14  <jonasschnelli> If all core interaction goes over clientmodel.cpp, we have great readability and good base for detaching possibilities.
201 2016-05-27T13:54:03  <cfields_> sipa: when you said "clientmodel", i agreed because my plan was just to stuff a connman instance in there and call it as needed. I see now what you really meant.
202 2016-05-27T13:54:23  <cfields_> jonasschnelli: roger.
203 2016-05-27T13:54:26  <cfields_> sipa / jonasschnelli: thanks a bunch, that was very helpful.
204 2016-05-27T13:54:40  <jonasschnelli> np, thanks for asking
205 2016-05-27T13:55:42  <cfields_> jonasschnelli: could I convince you to allow the g_connman hack for now, with a plan to fix it up in a follow-up PR? I'm afraid it'll never get merged if I try to get it all in the first go.
206 2016-05-27T13:55:55  <cfields_> (rpc needs to be dealt with similarly, and that will be less fun)
207 2016-05-27T13:57:12  <sipa> i think keeping a global initially is fine
208 2016-05-27T13:58:34  <jonasschnelli> Yes. IMO there are no multiple connman's possible for now? If so, then I don't see a reason to make it _not_ global.
209 2016-05-27T13:59:10  <cfields_> jonasschnelli: yes, it was written with the intention of using multiple connmans in the future
210 2016-05-27T13:59:20  <cfields_> though obviously we only have 1 now
211 2016-05-27T13:59:29  <cfields_> s/using/being able to use/
212 2016-05-27T13:59:33  <jonasschnelli> cfields_: maybe later with have a global conmanMan. :)
213 2016-05-27T13:59:46  <cfields_> haha
214 2016-05-27T14:00:32  <sipa> abstractconmanfactory
215 2016-05-27T14:02:35  <gmaxwell> BBC, is that you?
216 2016-05-27T14:16:06  <sipa> ?
217 2016-05-27T14:16:34  *** jcorgan has joined #bitcoin-core-dev
218 2016-05-27T14:16:38  <instagibbs> sipa doesn't catch anything but pure tech puns, sorry
219 2016-05-27T14:17:06  *** frankenmint has quit IRC
220 2016-05-27T14:17:42  <luke-jr> ugh @ calling part of Core by a well-known OS component?
221 2016-05-27T14:29:02  *** Giszmo has joined #bitcoin-core-dev
222 2016-05-27T14:34:47  <GitHub122> [bitcoin] CodeShark closed pull request #8101: Disable mining on nonrelease branches. (master...disable_mining_on_nonrelease_branches) https://github.com/bitcoin/bitcoin/pull/8101
223 2016-05-27T14:38:08  <sipa> luke-jr: ?
224 2016-05-27T14:38:23  <luke-jr> sipa: connman
225 2016-05-27T14:38:40  <luke-jr> https://01.org/connman
226 2016-05-27T14:46:28  <cfields_> luke-jr: it's CConnman :)
227 2016-05-27T14:47:13  <luke-jr> >_<
228 2016-05-27T14:48:11  <luke-jr> more importantly: I can still build without glib, right? <.<
229 2016-05-27T14:48:39  <cfields_> heh, yes
230 2016-05-27T14:52:28  *** ghounds has quit IRC
231 2016-05-27T14:59:35  *** ebfull has joined #bitcoin-core-dev
232 2016-05-27T15:00:34  *** ghounds has joined #bitcoin-core-dev
233 2016-05-27T15:01:35  <ebfull> sipa: at the moment we're stuck with old libsecp256k1 code (from before 0.12 where it was updated from upstream and enabled for verification)
234 2016-05-27T15:01:42  <ebfull> did that code support verification of compact signatures?
235 2016-05-27T15:01:56  <jonasschnelli> ebfull: yes. it does
236 2016-05-27T15:02:38  <jonasschnelli> ebfull: use secp256k1_ecdsa_verify
237 2016-05-27T15:02:53  <jonasschnelli> ebfull: the signatures are in a struct called secp256k1_ecdsa_signature
238 2016-05-27T15:03:09  <jonasschnelli> you can "fill it up" with a compact signature over secp256k1_ecdsa_signature_parse_compact
239 2016-05-27T15:03:13  <ebfull> this was before `secp256k1_ecdsa_signature` was introduced
240 2016-05-27T15:03:18  <ebfull> as far as i can tell
241 2016-05-27T15:03:18  <jonasschnelli> or with a def: secp256k1_ecdsa_signature_parse_der
242 2016-05-27T15:03:28  <ebfull> at least in the exposed api
243 2016-05-27T15:03:31  <jonasschnelli> s/def/DER
244 2016-05-27T15:04:10  <jonasschnelli> Not sure what version you use... but it is like this since ~6month.
245 2016-05-27T15:04:25  <ebfull> yeah, from before that :)
246 2016-05-27T15:04:56  <ebfull> secp256k1_ecdsa_verify doesn't appear to parse the compact signatures unless my code is wrong
247 2016-05-27T15:07:16  <ebfull> or maybe it requires a version byte at the beginning :)
248 2016-05-27T15:12:51  <sipa> ebfull: of course it does support it
249 2016-05-27T15:13:02  <sipa> ebfull: it's used for signature verification
250 2016-05-27T15:17:25  *** davec has quit IRC
251 2016-05-27T15:17:47  *** davec has joined #bitcoin-core-dev
252 2016-05-27T15:17:54  *** frankenmint has joined #bitcoin-core-dev
253 2016-05-27T15:23:15  *** frankenmint has quit IRC
254 2016-05-27T15:23:45  <ebfull> sipa: maybe i'm using the wrong terminology. in the old code, secp256k1_ecdsa_sign_compact produces a 64-byte (r, s), which secp256k1_ecdsa_sig_parse (as used by secp256k1_ecdsa_verify) does not appear to parse
255 2016-05-27T15:24:09  <ebfull> i can see how to use the new api to do it, but not the old api
256 2016-05-27T15:26:12  <sipa> ebfull: 0.12 used libsecp for message signature validation, which used compact format
257 2016-05-27T15:26:22  <sipa> so just look up how that worked
258 2016-05-27T15:26:33  <ebfull> we're using the libsecp from before that :(
259 2016-05-27T15:26:36  <sipa> oh
260 2016-05-27T15:26:40  <sipa> well, update it
261 2016-05-27T15:26:46  <sipa> we fixed bugs
262 2016-05-27T15:27:19  <ebfull> i'll have to explore the feasibility of that
263 2016-05-27T15:29:09  <ebfull> last time i looked into it i had a rough time following the trail of github UI bugs in the pull requests involved
264 2016-05-27T15:30:42  *** cryptapus_ has joined #bitcoin-core-dev
265 2016-05-27T15:35:21  *** cryptapus_ has quit IRC
266 2016-05-27T15:36:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
267 2016-05-27T15:42:22  *** molz has quit IRC
268 2016-05-27T15:42:47  *** molz has joined #bitcoin-core-dev
269 2016-05-27T15:42:53  <Chris_Stewart_5> sipa: After generating script_tests.json.gen do you need to manually copy it over to data/script_tests.json?
270 2016-05-27T15:52:57  <sipa> yup
271 2016-05-27T15:53:17  <sipa> ebfull: meh, just copy it over
272 2016-05-27T15:56:05  <ebfull> at that point i think it's probably way easier for us to use ed25519 for what we're implementing anyway
273 2016-05-27T16:16:54  *** kelar has quit IRC
274 2016-05-27T16:41:03  *** bsm1175321 has quit IRC
275 2016-05-27T16:50:45  *** Chris_Stewart_5 has quit IRC
276 2016-05-27T16:54:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
277 2016-05-27T17:01:04  *** raedah has quit IRC
278 2016-05-27T17:14:02  *** raedah has joined #bitcoin-core-dev
279 2016-05-27T17:15:07  *** ghounds has quit IRC
280 2016-05-27T17:18:22  *** bsm1175321 has joined #bitcoin-core-dev
281 2016-05-27T17:20:21  *** TomMc has quit IRC
282 2016-05-27T17:28:00  *** bsm1175321 has quit IRC
283 2016-05-27T17:34:51  *** sadfsadffads has joined #bitcoin-core-dev
284 2016-05-27T17:39:43  *** MarcoFalke has joined #bitcoin-core-dev
285 2016-05-27T17:47:30  *** luke-jr has quit IRC
286 2016-05-27T17:48:31  *** luke-jr has joined #bitcoin-core-dev
287 2016-05-27T17:53:56  *** luke-jr has quit IRC
288 2016-05-27T17:55:10  *** luke-jr has joined #bitcoin-core-dev
289 2016-05-27T18:02:09  *** ghounds has joined #bitcoin-core-dev
290 2016-05-27T18:07:41  *** luke-jr has joined #bitcoin-core-dev
291 2016-05-27T18:10:20  *** luke-jr has quit IRC
292 2016-05-27T18:11:10  *** luke-jr has joined #bitcoin-core-dev
293 2016-05-27T18:11:56  *** kadoban has joined #bitcoin-core-dev
294 2016-05-27T18:16:51  *** Chris_Stewart_5 has quit IRC
295 2016-05-27T18:26:19  *** ghounds has quit IRC
296 2016-05-27T18:31:09  *** luke-jr has quit IRC
297 2016-05-27T18:31:44  *** luke-jr has joined #bitcoin-core-dev
298 2016-05-27T18:35:14  *** luke-jr has quit IRC
299 2016-05-27T18:35:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
300 2016-05-27T18:35:51  *** luke-jr has joined #bitcoin-core-dev
301 2016-05-27T18:51:55  <BlueMatt> lol bitcoin core under valgrind is an absolute shitshow now
302 2016-05-27T18:52:19  <BlueMatt> I turn around and two minutes later valgrind is all like "More than 1000 different errors detected. Go fix your program!"
303 2016-05-27T18:52:25  <sipa> ouch :(
304 2016-05-27T18:52:34  <sipa> i haven't run valgrind in a while
305 2016-05-27T18:52:55  <Lightsword> memory leaks everywhere?
306 2016-05-27T18:53:19  <BlueMatt> uninitialized values everywhere
307 2016-05-27T18:53:29  <BlueMatt> its actually probably just C++11 confusing valgrind
308 2016-05-27T18:53:55  <MarcoFalke> I tried pre-cpp11 and had a similar number of complaints
309 2016-05-27T18:54:02  <BlueMatt> ouch
310 2016-05-27T18:54:14  <BlueMatt> sipa: also lots from secp
311 2016-05-27T19:03:34  *** ghounds has joined #bitcoin-core-dev
312 2016-05-27T19:10:02  *** Alopex has quit IRC
313 2016-05-27T19:11:07  *** Alopex has joined #bitcoin-core-dev
314 2016-05-27T19:18:20  *** BashCo_ has joined #bitcoin-core-dev
315 2016-05-27T19:19:04  *** BashCo has quit IRC
316 2016-05-27T19:19:47  *** cryptapus_ has joined #bitcoin-core-dev
317 2016-05-27T19:20:01  *** frankenmint has joined #bitcoin-core-dev
318 2016-05-27T19:24:15  *** cryptapus_ has quit IRC
319 2016-05-27T19:24:38  *** Amnez777 has quit IRC
320 2016-05-27T19:24:48  *** frankenmint has quit IRC
321 2016-05-27T19:25:47  *** moli has joined #bitcoin-core-dev
322 2016-05-27T19:26:01  *** ghounds has quit IRC
323 2016-05-27T19:27:40  *** molz has quit IRC
324 2016-05-27T19:27:41  *** Chris_Stewart_5 has quit IRC
325 2016-05-27T19:29:00  *** molz has joined #bitcoin-core-dev
326 2016-05-27T19:29:22  <BlueMatt> lolnvm
327 2016-05-27T19:29:38  <BlueMatt> just make random not use openssl and literally every single warning goes away
328 2016-05-27T19:30:55  <cfields_> BlueMatt: there's a build-switch for openssl
329 2016-05-27T19:31:06  <cfields_> BlueMatt: it seeds with uninit data by default
330 2016-05-27T19:31:09  *** moli has quit IRC
331 2016-05-27T19:31:17  <BlueMatt> cfields_: yes, I would have to rebuild openssl for that
332 2016-05-27T19:31:43  <BlueMatt> cfields_: its impressive how far some of the errors go, though....everything anywhere that is seeded with random values, so you get lots of shit in ccoins/mempool/bloom/etc
333 2016-05-27T19:32:20  <cfields_> heh
334 2016-05-27T19:32:59  <cfields_> boost tends to piss off sanitizing tools as well
335 2016-05-27T19:33:18  <BlueMatt> havent seen anything blow up except on shutdown yet
336 2016-05-27T19:34:56  *** raedah has quit IRC
337 2016-05-27T19:45:57  *** jtimon has quit IRC
338 2016-05-27T19:50:27  *** Guyver2 has joined #bitcoin-core-dev
339 2016-05-27T20:06:52  *** raedah has joined #bitcoin-core-dev
340 2016-05-27T20:33:12  *** Amnez777 has joined #bitcoin-core-dev
341 2016-05-27T21:00:35  <kanzure> "Multi-party channels" https://lists.linuxfoundation.org/pipermail/lightning-dev/2016-May/000543.html
342 2016-05-27T21:07:16  *** MarcoFalke has quit IRC
343 2016-05-27T21:11:08  *** AaronvanW has quit IRC
344 2016-05-27T21:42:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
345 2016-05-27T22:21:01  *** Alopex has quit IRC
346 2016-05-27T22:22:06  *** Alopex has joined #bitcoin-core-dev
347 2016-05-27T22:28:33  *** cryptapus is now known as cryptapus_afk
348 2016-05-27T22:35:32  *** Chris_Stewart_5 has quit IRC
349 2016-05-27T22:37:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
350 2016-05-27T22:51:18  *** Guyver2 has quit IRC
351 2016-05-27T23:17:25  *** Cory has quit IRC
352 2016-05-27T23:21:29  *** Chris_Stewart_5 has quit IRC
353 2016-05-27T23:29:12  *** justanotheruser has quit IRC
354 2016-05-27T23:30:47  *** Cory has joined #bitcoin-core-dev
355 2016-05-27T23:37:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
356 2016-05-27T23:50:18  *** gevs_ has joined #bitcoin-core-dev
357 2016-05-27T23:53:54  *** gevs has quit IRC
358 2016-05-27T23:55:28  *** achow101 has quit IRC
359 2016-05-27T23:56:45  *** AaronvanW has joined #bitcoin-core-dev
360 2016-05-27T23:57:29  *** achow101 has joined #bitcoin-core-dev
361 2016-05-27T23:59:52  *** kadoban has quit IRC