12016-05-30T00:21:14 *** Ylbam has quit IRC
22016-05-30T00:23:57 *** alpalp has quit IRC
32016-05-30T01:07:24 *** belcher has quit IRC
42016-05-30T01:17:05 *** belcher has joined #bitcoin-core-dev
52016-05-30T01:27:58 *** Squidicc has joined #bitcoin-core-dev
62016-05-30T01:28:22 *** xiangfu has joined #bitcoin-core-dev
72016-05-30T01:30:08 *** Squidicuz has quit IRC
82016-05-30T01:32:36 *** jarret has joined #bitcoin-core-dev
92016-05-30T01:35:12 *** dermoth has quit IRC
102016-05-30T01:36:00 *** dermoth has joined #bitcoin-core-dev
112016-05-30T01:44:46 *** Squidicc is now known as squidicuz
122016-05-30T02:04:03 *** Chris_Stewart_5 has quit IRC
132016-05-30T02:15:21 *** fengling has joined #bitcoin-core-dev
142016-05-30T02:22:59 *** randy-waterhouse has joined #bitcoin-core-dev
152016-05-30T02:37:30 *** cryptapus_afk has quit IRC
162016-05-30T03:13:16 *** cryptapus_afk has joined #bitcoin-core-dev
172016-05-30T03:20:26 *** Giszmo1 has joined #bitcoin-core-dev
182016-05-30T03:20:26 *** Giszmo has quit IRC
192016-05-30T03:28:56 *** belcher has quit IRC
202016-05-30T03:39:01 *** Alopex has quit IRC
212016-05-30T03:40:06 *** Alopex has joined #bitcoin-core-dev
222016-05-30T03:49:50 *** shesek has joined #bitcoin-core-dev
232016-05-30T04:29:41 *** fengling has quit IRC
242016-05-30T04:40:20 *** molz has joined #bitcoin-core-dev
252016-05-30T04:40:49 *** achow101 has quit IRC
262016-05-30T04:42:55 *** moli has quit IRC
272016-05-30T04:47:41 *** [Author] has quit IRC
282016-05-30T04:51:06 *** fengling has joined #bitcoin-core-dev
292016-05-30T05:06:09 *** [Author] has joined #bitcoin-core-dev
302016-05-30T05:10:38 *** molz has quit IRC
312016-05-30T05:10:59 *** molz has joined #bitcoin-core-dev
322016-05-30T05:19:01 *** Alopex has quit IRC
332016-05-30T05:20:06 *** Alopex has joined #bitcoin-core-dev
342016-05-30T05:30:01 *** Alopex has quit IRC
352016-05-30T05:31:07 *** Alopex has joined #bitcoin-core-dev
362016-05-30T06:06:45 *** Giszmo1 has quit IRC
372016-05-30T06:14:57 *** bustd_soket has quit IRC
382016-05-30T06:15:11 *** assder has joined #bitcoin-core-dev
392016-05-30T06:16:00 *** BashCo has quit IRC
402016-05-30T06:23:44 *** randy-waterhouse has quit IRC
412016-05-30T06:27:01 *** bustd_soket has joined #bitcoin-core-dev
422016-05-30T06:33:25 *** grassass has joined #bitcoin-core-dev
432016-05-30T06:48:52 *** grassass has quit IRC
442016-05-30T06:49:11 *** randy-waterhouse has joined #bitcoin-core-dev
452016-05-30T06:52:12 *** paveljanik has quit IRC
462016-05-30T06:54:11 *** BashCo has joined #bitcoin-core-dev
472016-05-30T07:15:24 *** BashCo has quit IRC
482016-05-30T07:27:24 *** p15 has joined #bitcoin-core-dev
492016-05-30T07:28:11 *** p15 has quit IRC
502016-05-30T07:33:16 *** Naphex has joined #bitcoin-core-dev
512016-05-30T07:34:01 *** fengling has quit IRC
522016-05-30T07:34:23 *** gevs_ has quit IRC
532016-05-30T07:34:28 *** fengling has joined #bitcoin-core-dev
542016-05-30T07:36:37 <wumpus> interesting, I have a bitcoind that hangs at "Loading banlist..."
552016-05-30T07:37:33 <wumpus> well it responds to RPC requests with that
562016-05-30T07:39:44 <wumpus> it does actually seem to be syncing with the network
572016-05-30T07:40:47 <wumpus> ok initialization completed now, seems to be a case of misreporting what it is doing
582016-05-30T07:41:46 *** fengling_ has joined #bitcoin-core-dev
592016-05-30T07:42:21 *** fengling has quit IRC
602016-05-30T07:53:48 *** gevs has joined #bitcoin-core-dev
612016-05-30T07:53:59 *** gevs has joined #bitcoin-core-dev
622016-05-30T07:55:56 *** Ylbam has joined #bitcoin-core-dev
632016-05-30T08:08:07 *** G1lius has joined #bitcoin-core-dev
642016-05-30T08:08:14 *** randy-waterhouse has quit IRC
652016-05-30T08:15:01 *** Alopex has quit IRC
662016-05-30T08:16:06 *** Alopex has joined #bitcoin-core-dev
672016-05-30T08:28:06 *** randy-waterhouse has joined #bitcoin-core-dev
682016-05-30T08:45:32 *** Guyver2 has joined #bitcoin-core-dev
692016-05-30T09:05:21 *** justanotheruser has quit IRC
702016-05-30T09:07:49 *** p15 has joined #bitcoin-core-dev
712016-05-30T09:08:06 *** randy-waterhouse has quit IRC
722016-05-30T09:12:11 *** AaronvanW has joined #bitcoin-core-dev
732016-05-30T09:12:12 *** AaronvanW has quit IRC
742016-05-30T09:12:12 *** AaronvanW has joined #bitcoin-core-dev
752016-05-30T09:35:02 *** jannes has joined #bitcoin-core-dev
762016-05-30T09:46:04 *** p15 has quit IRC
772016-05-30T09:49:41 *** fengling_ has quit IRC
782016-05-30T09:56:12 *** fengling_ has joined #bitcoin-core-dev
792016-05-30T09:58:39 *** laurentmt has joined #bitcoin-core-dev
802016-05-30T09:58:59 *** laurentmt has quit IRC
812016-05-30T10:01:01 *** fengling_ has quit IRC
822016-05-30T10:07:16 *** fengling_ has joined #bitcoin-core-dev
832016-05-30T10:14:26 <GitHub101> [bitcoin] jonasnick opened pull request #8118: Reduce unnecessary hashing in signrawtransaction (master...faster-signraw) https://github.com/bitcoin/bitcoin/pull/8118
842016-05-30T10:39:45 <GitHub154> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ff2c8d29f6b...61b86848b163
852016-05-30T10:39:45 <GitHub154> bitcoin/master 619d569 Pieter Wuille: Benchmark SipHash
862016-05-30T10:39:46 <GitHub154> bitcoin/master 61b8684 Wladimir J. van der Laan: Merge #8111: Benchmark SipHash...
872016-05-30T10:40:00 <GitHub166> [bitcoin] laanwj closed pull request #8111: Benchmark SipHash (master...benchsiphash) https://github.com/bitcoin/bitcoin/pull/8111
882016-05-30T10:40:17 <GitHub141> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/61b86848b163...989df7ecf3a1
892016-05-30T10:40:17 <GitHub141> bitcoin/master fc95f6e Chris Moore: fix typo in help text...
902016-05-30T10:40:18 <GitHub141> bitcoin/master 989df7e Wladimir J. van der Laan: Merge #7896: fix typo in help text...
912016-05-30T10:40:22 <GitHub103> [bitcoin] laanwj closed pull request #7896: fix typo in help text (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7896
922016-05-30T10:43:20 *** BashCo has joined #bitcoin-core-dev
932016-05-30T10:46:51 *** G1lius has quit IRC
942016-05-30T10:58:03 *** JackH has quit IRC
952016-05-30T11:06:19 <GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/989df7ecf3a1...52b803e09b16
962016-05-30T11:06:19 <GitHub29> bitcoin/master 5fac1f3 Yuri Zhykin: bench: Added base58 encoding/decoding benchmarks
972016-05-30T11:06:20 <GitHub29> bitcoin/master 52b803e Wladimir J. van der Laan: Merge #8107: bench: Added base58 encoding/decoding benchmarks...
982016-05-30T11:06:28 <GitHub51> [bitcoin] laanwj closed pull request #8107: bench: Added base58 encoding/decoding benchmarks (master...benchmarks) https://github.com/bitcoin/bitcoin/pull/8107
992016-05-30T11:20:51 *** laurentmt has joined #bitcoin-core-dev
1002016-05-30T11:29:42 <GitHub138> [bitcoin] fanquake opened pull request #8119: [trivial] Add .DSYM to .gitignore (master...ignore_debug) https://github.com/bitcoin/bitcoin/pull/8119
1012016-05-30T11:30:37 *** xiangfu has quit IRC
1022016-05-30T11:42:50 *** laurentmt has quit IRC
1032016-05-30T11:44:01 *** fengling_ has quit IRC
1042016-05-30T11:55:42 *** fengling_ has joined #bitcoin-core-dev
1052016-05-30T12:00:29 *** belcher has joined #bitcoin-core-dev
1062016-05-30T12:05:41 *** fengling_ has quit IRC
1072016-05-30T12:12:10 *** bustd_soket has quit IRC
1082016-05-30T12:17:42 *** bustd_soket has joined #bitcoin-core-dev
1092016-05-30T12:28:23 *** Squidicc has joined #bitcoin-core-dev
1102016-05-30T12:31:34 *** squidicuz has quit IRC
1112016-05-30T12:34:57 *** dermoth has quit IRC
1122016-05-30T12:35:38 *** dermoth has joined #bitcoin-core-dev
1132016-05-30T12:45:56 <GitHub15> [bitcoin] fanquake opened pull request #8121: [Doc] Update implemented BIPs list (master...missing_bips) https://github.com/bitcoin/bitcoin/pull/8121
1142016-05-30T13:20:03 *** frankenmint has joined #bitcoin-core-dev
1152016-05-30T13:27:16 *** frankenmint has quit IRC
1162016-05-30T13:31:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1172016-05-30T13:37:42 *** Chris_Stewart_5 has quit IRC
1182016-05-30T13:39:52 *** G1lius has joined #bitcoin-core-dev
1192016-05-30T13:40:55 <GitHub73> [bitcoin] sipa opened pull request #8123: Use std::atomic for fRequestShutdown and fReopenDebugLog (master...notsigbutatomic) https://github.com/bitcoin/bitcoin/pull/8123
1202016-05-30T13:45:33 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1212016-05-30T13:57:14 *** frankenmint has joined #bitcoin-core-dev
1222016-05-30T14:00:15 <GitHub196> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/52b803e09b16...950be19727a5
1232016-05-30T14:00:16 <GitHub196> bitcoin/master fa2637a Pieter Wuille: Always require OS randomness when generating secret keys
1242016-05-30T14:00:16 <GitHub196> bitcoin/master 628cf14 Pieter Wuille: Don't use assert for catching randomness failures
1252016-05-30T14:00:17 <GitHub196> bitcoin/master 950be19 Pieter Wuille: Merge #7891: Always require OS randomness when generating secret keys...
1262016-05-30T14:00:17 <GitHub132> [bitcoin] sipa closed pull request #7891: Always require OS randomness when generating secret keys (master...betterrng) https://github.com/bitcoin/bitcoin/pull/7891
1272016-05-30T14:13:57 *** tucenaber has quit IRC
1282016-05-30T14:17:54 *** Chris_Stewart_5 has quit IRC
1292016-05-30T14:29:39 *** Giszmo has joined #bitcoin-core-dev
1302016-05-30T14:33:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1312016-05-30T14:38:43 *** justanotheruser has joined #bitcoin-core-dev
1322016-05-30T14:54:06 *** achow101 has joined #bitcoin-core-dev
1332016-05-30T15:24:05 *** TomMc has joined #bitcoin-core-dev
1342016-05-30T15:30:04 *** rubensayshi has joined #bitcoin-core-dev
1352016-05-30T15:43:55 <gmaxwell> \O/ (randomness)
1362016-05-30T15:48:03 *** frankenmint has quit IRC
1372016-05-30T15:53:35 *** Chris_Stewart_5 has quit IRC
1382016-05-30T16:04:20 <GitHub170> [bitcoin] sipa opened pull request #8126: std::shared_ptr based CTransaction storage in mempool (master...sharedmempool) https://github.com/bitcoin/bitcoin/pull/8126
1392016-05-30T16:05:17 *** murch has joined #bitcoin-core-dev
1402016-05-30T16:06:29 *** TomMc has quit IRC
1412016-05-30T16:09:15 <gmaxwell> \O/
1422016-05-30T16:12:41 <luke-jr> O.o
1432016-05-30T16:14:27 <sipa> ^^
1442016-05-30T16:17:11 <sipa> gmaxwell: it also conflicts with a few of your PRs, but it should simplify them
1452016-05-30T16:18:14 <gmaxwell> I don't mind.
1462016-05-30T16:18:51 <btcdrak> a rebase is a small price to pay for randomness
1472016-05-30T16:19:07 <btcdrak> the new currency shall be called rebases.
1482016-05-30T16:19:37 <gmaxwell> sipa: Is CTxMempool::CompareDepthAndScore dead code after the change that puts int in the Comparitor directly?
1492016-05-30T16:19:55 <luke-jr> might be useful to have a typedef though?
1502016-05-30T16:20:18 <gmaxwell> btcdrak: Sipa and I were commenting there about the shared_ptr change.
1512016-05-30T16:20:46 <luke-jr> CTransactionRef or something?
1522016-05-30T16:21:37 <gmaxwell> I kinda like knowing that its a shared_ptr, but... nevermind my taste.
1532016-05-30T16:22:16 <luke-jr> I don't feel strongly about this, was mainly thinking if we ever had to go back to pre-C++11 for some reason
1542016-05-30T16:22:26 <luke-jr> which seems unlikely
1552016-05-30T16:24:15 <sipa> luke-jr: sounds fine... std::shared_ptr<const Ctransaction> is a bit awkward to type
1562016-05-30T16:24:27 <sipa> on the aother hand... auto works well :)
1572016-05-30T16:24:51 <sipa> gmaxwell: no, still used from the heapifier in message handling
1582016-05-30T16:26:20 <luke-jr> 'auto' certainly tells even less that it is a shared_ptr :P
1592016-05-30T16:27:02 <luke-jr> so if the long type is going to encourage using auto everywhere, perhaps gmaxwell's goal is actually better suited by a typedef as well
1602016-05-30T16:27:39 <gmaxwell> I think I'm going to have to give up on editing this code using an editor that can't go and read faraway prototypes. Auto for return types is pretty useful, but it currently results in me grepping to go find out what the type actually is.
1612016-05-30T16:28:04 * sipa abandons his rewrite to increase usage of auto
1622016-05-30T16:28:35 <gmaxwell> I hope not. Don't change what you're doing because of my very C-like preferences.
1632016-05-30T16:28:51 <sipa> it's a valid argument
1642016-05-30T16:29:26 <gmaxwell> I think it is best when the return type is obvious. E.g. functions that give you an iterator.
1652016-05-30T16:29:40 <sipa> we could of course go back to strict hungarian notation :D
1662016-05-30T16:29:46 * luke-jr understood that as abandoning "a PR intentionally doing nothing but changing stuff to 'auto' where possible"
1672016-05-30T16:30:00 <sipa> luke-jr: oh, no, i mean improving my current shared_ptr PR
1682016-05-30T16:30:05 <luke-jr> oh, ok
1692016-05-30T16:31:21 <gmaxwell> sipa: is there something we can do at shutdown to tell if all the txn have been freed? even in just some debugging build?
1702016-05-30T16:32:39 <sipa> gmaxwell: how could they not?
1712016-05-30T16:32:39 <luke-jr> CTx constructor could increment a global, and destructor decrement it?
1722016-05-30T16:33:01 <sipa> luke-jr: yup
1732016-05-30T16:33:26 <sipa> an atomic global :)
1742016-05-30T16:33:36 <sipa> and on every decrement, print to stderr
1752016-05-30T16:35:00 <gmaxwell> in the current code, they couldn't AFAICT. But if we leaked some object with a shared ptr we'd leak the transaction. It's generally pretty hard to leak shared_ptr... but seems prudent to check for.
1762016-05-30T16:35:07 <gmaxwell> Yea, that would work.
1772016-05-30T16:36:52 <sipa> also: the glibc implementation of std::shared_ptr is not readable
1782016-05-30T16:40:55 <gmaxwell> BlueMatt: thoughts on #8126 ? would you like to rebase compactblocks on that?
1792016-05-30T16:46:53 <sipa> with --patience i get much more readable diffs often
1802016-05-30T16:49:41 *** BashCo has quit IRC
1812016-05-30T17:16:56 <gmaxwell> http://blog.invisiblethings.org/2016/05/30/build-security.html < on build enviroment security.
1822016-05-30T17:28:40 *** jtimon has quit IRC
1832016-05-30T17:38:00 *** BashCo has joined #bitcoin-core-dev
1842016-05-30T17:39:48 *** frankenmint has joined #bitcoin-core-dev
1852016-05-30T17:49:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1862016-05-30T18:02:13 *** MarcoFalke has joined #bitcoin-core-dev
1872016-05-30T18:06:45 *** Chris_Stewart_5 has quit IRC
1882016-05-30T18:08:00 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1892016-05-30T18:10:07 *** frankenmint has quit IRC
1902016-05-30T18:48:08 *** G1lius has quit IRC
1912016-05-30T18:59:43 *** moli has joined #bitcoin-core-dev
1922016-05-30T19:02:03 *** molz has quit IRC
1932016-05-30T19:02:59 *** molz has joined #bitcoin-core-dev
1942016-05-30T19:05:10 *** moli has quit IRC
1952016-05-30T19:05:56 *** frankenmint has joined #bitcoin-core-dev
1962016-05-30T19:15:05 *** moli has joined #bitcoin-core-dev
1972016-05-30T19:17:06 *** molz has quit IRC
1982016-05-30T19:29:01 *** justanotheruser has quit IRC
1992016-05-30T19:36:20 *** molz has joined #bitcoin-core-dev
2002016-05-30T19:38:34 *** moli has quit IRC
2012016-05-30T19:42:15 *** molly has joined #bitcoin-core-dev
2022016-05-30T19:44:25 *** molz has quit IRC
2032016-05-30T19:47:35 *** MarcoFalke has left #bitcoin-core-dev
2042016-05-30T19:49:26 <BlueMatt> gmaxwell: I probably will after its merged, sure
2052016-05-30T19:50:41 *** moli has joined #bitcoin-core-dev
2062016-05-30T19:53:31 *** molly has quit IRC
2072016-05-30T20:00:38 <btcdrak> BlueMatt: could you say so on the ticket so people arent waiting for it?
2082016-05-30T20:05:41 *** justanotheruser has joined #bitcoin-core-dev
2092016-05-30T20:10:01 <BlueMatt> btcdrak: who's waiting for what?
2102016-05-30T20:17:05 <sipa> it shouldn't interfere with review of compact blocks otherwise
2112016-05-30T20:17:18 <sipa> just the refcounting in the mempool can go away
2122016-05-30T20:34:10 *** frankenmint has quit IRC
2132016-05-30T20:37:58 *** kadoban has joined #bitcoin-core-dev
2142016-05-30T20:44:42 *** justanotheruser has quit IRC
2152016-05-30T21:03:52 *** AaronvanW has quit IRC
2162016-05-30T21:10:45 *** murch has quit IRC
2172016-05-30T21:27:49 *** Guyver2 has quit IRC
2182016-05-30T21:32:59 <gmaxwell> BlueMatt: you might want to review sipa's patch (or try the rebase) to make sure it won't get in your way.
2192016-05-30T21:35:17 *** frankenmint has joined #bitcoin-core-dev
2202016-05-30T21:35:36 <sipa> i'll do the rebase for you, if it helps things forward
2212016-05-30T21:41:16 *** frankenmint has quit IRC
2222016-05-30T21:45:34 *** spudowiar has quit IRC
2232016-05-30T21:49:20 *** spudowiar has joined #bitcoin-core-dev
2242016-05-30T21:51:28 *** jarret has quit IRC
2252016-05-30T21:58:46 *** slackircbridge has quit IRC
2262016-05-30T22:00:03 *** slackircbridge has joined #bitcoin-core-dev
2272016-05-30T22:27:24 <gmaxwell> sipa: might be a good review excercise even if matt doesn't want to use the result.
2282016-05-30T22:30:21 <gmaxwell> Opinion piece against most uses of unit tests that I think makes some nice points: http://rbcs-us.com/documents/Why-Most-Unit-Testing-is-Waste.pdf (the biggest exceptions he makes are cases where there is a clear formal defintion of correctness that can be tested against for the function, and also when the tests are realistically able to completely test the function; otherwise he favors system
2292016-05-30T22:30:27 <gmaxwell> tests and gives arguments from a number of angles).
2302016-05-30T22:31:15 *** jannes has quit IRC
2312016-05-30T22:41:28 *** jarret has joined #bitcoin-core-dev
2322016-05-30T22:46:17 *** jarret has quit IRC
2332016-05-30T22:46:32 *** jarret has joined #bitcoin-core-dev
2342016-05-30T22:51:28 *** jarret has quit IRC
2352016-05-30T22:53:18 *** slackircbridge has quit IRC
2362016-05-30T22:54:35 *** slackircbridge has joined #bitcoin-core-dev
2372016-05-30T23:11:08 *** slackircbridge has quit IRC
2382016-05-30T23:12:25 *** slackircbridge has joined #bitcoin-core-dev
2392016-05-30T23:20:09 *** justanotheruser has joined #bitcoin-core-dev
2402016-05-30T23:26:00 *** belcher has quit IRC
2412016-05-30T23:27:38 *** belcher has joined #bitcoin-core-dev
2422016-05-30T23:54:28 *** gevs has quit IRC