1 2016-06-03T00:11:15  *** belcher has quit IRC
  2 2016-06-03T00:11:29  *** belcher has joined #bitcoin-core-dev
  3 2016-06-03T00:13:31  *** belcher has quit IRC
  4 2016-06-03T00:20:03  *** fengling has joined #bitcoin-core-dev
  5 2016-06-03T00:24:44  *** fengling has quit IRC
  6 2016-06-03T00:44:17  *** kadoban has quit IRC
  7 2016-06-03T00:54:15  *** TomMc has quit IRC
  8 2016-06-03T00:58:48  *** fengling has joined #bitcoin-core-dev
  9 2016-06-03T01:05:18  *** dermoth has quit IRC
 10 2016-06-03T01:05:58  *** dermoth has joined #bitcoin-core-dev
 11 2016-06-03T01:08:14  *** TomMc has joined #bitcoin-core-dev
 12 2016-06-03T01:11:16  *** grassass has quit IRC
 13 2016-06-03T01:22:02  *** Alopex has quit IRC
 14 2016-06-03T01:23:07  *** Alopex has joined #bitcoin-core-dev
 15 2016-06-03T01:35:06  *** dermoth has quit IRC
 16 2016-06-03T01:38:07  *** dermoth has joined #bitcoin-core-dev
 17 2016-06-03T01:40:08  *** Giszmo has quit IRC
 18 2016-06-03T02:00:24  *** grassass has joined #bitcoin-core-dev
 19 2016-06-03T02:01:15  *** Ylbam has quit IRC
 20 2016-06-03T02:08:24  *** jtimon has quit IRC
 21 2016-06-03T02:09:14  *** skang404 has quit IRC
 22 2016-06-03T02:20:36  *** calibre720 has joined #bitcoin-core-dev
 23 2016-06-03T02:58:13  *** kadoban has joined #bitcoin-core-dev
 24 2016-06-03T03:08:49  *** Chris_Stewart_5 has quit IRC
 25 2016-06-03T03:24:24  *** TheFactory7 has quit IRC
 26 2016-06-03T03:26:31  *** TomMc has quit IRC
 27 2016-06-03T03:32:01  *** Alopex has quit IRC
 28 2016-06-03T03:33:06  *** Alopex has joined #bitcoin-core-dev
 29 2016-06-03T03:52:01  *** Alopex has quit IRC
 30 2016-06-03T03:53:07  *** Alopex has joined #bitcoin-core-dev
 31 2016-06-03T03:59:09  *** achow101 has quit IRC
 32 2016-06-03T04:24:02  *** Alopex has quit IRC
 33 2016-06-03T04:25:07  *** Alopex has joined #bitcoin-core-dev
 34 2016-06-03T04:34:52  *** moli has quit IRC
 35 2016-06-03T04:35:45  *** xiangfu has joined #bitcoin-core-dev
 36 2016-06-03T04:42:27  *** moli has joined #bitcoin-core-dev
 37 2016-06-03T05:03:45  *** moli has quit IRC
 38 2016-06-03T05:05:46  *** grassass has quit IRC
 39 2016-06-03T05:05:54  *** gevs has quit IRC
 40 2016-06-03T05:07:09  *** moli has joined #bitcoin-core-dev
 41 2016-06-03T05:18:37  *** gevs has joined #bitcoin-core-dev
 42 2016-06-03T05:18:37  *** gevs has joined #bitcoin-core-dev
 43 2016-06-03T05:29:01  *** Alopex has quit IRC
 44 2016-06-03T05:30:06  *** Alopex has joined #bitcoin-core-dev
 45 2016-06-03T05:39:27  *** grassass has joined #bitcoin-core-dev
 46 2016-06-03T05:41:01  *** Alopex has quit IRC
 47 2016-06-03T05:42:06  *** Alopex has joined #bitcoin-core-dev
 48 2016-06-03T06:18:52  <GitHub68> [bitcoin] pstratem opened pull request #8142: Improve CWallet API  with new GetAccountPubkey function. (master...2016-06-02-cwallet-getaccountpubkey) https://github.com/bitcoin/bitcoin/pull/8142
 49 2016-06-03T06:36:21  *** Ylbam has joined #bitcoin-core-dev
 50 2016-06-03T06:42:42  *** paveljanik has quit IRC
 51 2016-06-03T06:54:01  <GitHub160> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a82f03393a32...ae5575ba41c8
 52 2016-06-03T06:54:01  <GitHub160> bitcoin/master f45f51e Pieter Wuille: Fix interrupted HTTP RPC connection workaround for Python 3.5+
 53 2016-06-03T06:54:02  <GitHub160> bitcoin/master ae5575b MarcoFalke: Merge #8139: Fix interrupted HTTP RPC connection workaround for Python 3.5+...
 54 2016-06-03T06:54:11  <GitHub177> [bitcoin] MarcoFalke closed pull request #8139: Fix interrupted HTTP RPC connection workaround for Python 3.5+ (master...fixwalletbackup) https://github.com/bitcoin/bitcoin/pull/8139
 55 2016-06-03T07:09:24  *** fengling has quit IRC
 56 2016-06-03T07:11:42  *** fengling has joined #bitcoin-core-dev
 57 2016-06-03T07:16:45  *** BashCo has quit IRC
 58 2016-06-03T07:21:46  *** JackH has quit IRC
 59 2016-06-03T07:24:54  *** frankenmint has quit IRC
 60 2016-06-03T07:28:28  *** calibre720 has quit IRC
 61 2016-06-03T07:32:24  *** fengling has quit IRC
 62 2016-06-03T07:42:07  *** calibre720 has joined #bitcoin-core-dev
 63 2016-06-03T07:48:29  *** erasmospunk has joined #bitcoin-core-dev
 64 2016-06-03T07:50:13  *** Guyver2 has joined #bitcoin-core-dev
 65 2016-06-03T07:50:14  *** frankenmint has joined #bitcoin-core-dev
 66 2016-06-03T07:58:24  *** ibrightly has quit IRC
 67 2016-06-03T07:58:24  *** binns has quit IRC
 68 2016-06-03T07:58:24  *** zmanian__ has quit IRC
 69 2016-06-03T07:58:25  *** CodeShark has quit IRC
 70 2016-06-03T07:58:25  *** NicolasDorier has quit IRC
 71 2016-06-03T08:16:25  *** BashCo has joined #bitcoin-core-dev
 72 2016-06-03T08:20:18  *** jannes has joined #bitcoin-core-dev
 73 2016-06-03T08:22:39  *** calibre720 has quit IRC
 74 2016-06-03T08:30:28  *** fengling has joined #bitcoin-core-dev
 75 2016-06-03T08:32:00  *** calibre720 has joined #bitcoin-core-dev
 76 2016-06-03T08:35:01  *** goregrin1 has joined #bitcoin-core-dev
 77 2016-06-03T08:36:03  *** Ylbam_ has joined #bitcoin-core-dev
 78 2016-06-03T08:36:19  *** limpkin_ has joined #bitcoin-core-dev
 79 2016-06-03T08:37:26  *** mturquette_ has joined #bitcoin-core-dev
 80 2016-06-03T08:38:50  *** OxADADA_ has joined #bitcoin-core-dev
 81 2016-06-03T08:39:06  *** limpkin has quit IRC
 82 2016-06-03T08:39:06  *** Ylbam has quit IRC
 83 2016-06-03T08:39:07  *** goregrind has quit IRC
 84 2016-06-03T08:39:08  *** OxADADA has quit IRC
 85 2016-06-03T08:39:08  *** arubi has quit IRC
 86 2016-06-03T08:39:08  *** mturquette has quit IRC
 87 2016-06-03T08:39:10  *** Ylbam_ is now known as Ylbam
 88 2016-06-03T08:40:49  *** mturquette_ is now known as mturquette
 89 2016-06-03T08:49:15  *** arubi has joined #bitcoin-core-dev
 90 2016-06-03T08:52:35  *** Guyver2 has quit IRC
 91 2016-06-03T08:54:59  *** binns has joined #bitcoin-core-dev
 92 2016-06-03T09:00:36  *** ibrightly has joined #bitcoin-core-dev
 93 2016-06-03T09:00:47  *** zmanian__ has joined #bitcoin-core-dev
 94 2016-06-03T09:07:59  *** erasmospunk has quit IRC
 95 2016-06-03T09:12:08  *** CodeShark has joined #bitcoin-core-dev
 96 2016-06-03T09:12:43  *** davec has quit IRC
 97 2016-06-03T09:13:03  *** davec has joined #bitcoin-core-dev
 98 2016-06-03T09:13:42  *** NicolasDorier has joined #bitcoin-core-dev
 99 2016-06-03T09:28:06  *** laurentmt has joined #bitcoin-core-dev
100 2016-06-03T09:36:56  *** kadoban has quit IRC
101 2016-06-03T09:50:01  *** moli has quit IRC
102 2016-06-03T09:55:22  *** laurentmt has quit IRC
103 2016-06-03T09:56:05  *** laurentmt has joined #bitcoin-core-dev
104 2016-06-03T09:56:40  *** MarcoFalke has joined #bitcoin-core-dev
105 2016-06-03T10:02:07  *** CodeShark has quit IRC
106 2016-06-03T10:02:07  *** NicolasDorier has quit IRC
107 2016-06-03T10:02:07  *** binns has quit IRC
108 2016-06-03T10:02:08  *** ibrightly has quit IRC
109 2016-06-03T10:02:08  *** zmanian__ has quit IRC
110 2016-06-03T10:03:51  *** blkdb has quit IRC
111 2016-06-03T10:07:09  *** blkdb has joined #bitcoin-core-dev
112 2016-06-03T10:09:06  *** laurentmt has quit IRC
113 2016-06-03T10:11:49  *** frankenmint has quit IRC
114 2016-06-03T10:12:23  *** frankenmint has joined #bitcoin-core-dev
115 2016-06-03T10:15:20  *** binns has joined #bitcoin-core-dev
116 2016-06-03T10:16:14  *** wangchun has quit IRC
117 2016-06-03T10:23:05  *** blkdb has quit IRC
118 2016-06-03T10:24:38  *** renlord has joined #bitcoin-core-dev
119 2016-06-03T10:24:43  *** ibrightly has joined #bitcoin-core-dev
120 2016-06-03T10:24:54  *** zmanian__ has joined #bitcoin-core-dev
121 2016-06-03T10:24:56  *** blkdb has joined #bitcoin-core-dev
122 2016-06-03T10:25:35  *** renlord has left #bitcoin-core-dev
123 2016-06-03T10:35:02  *** mkarrer has joined #bitcoin-core-dev
124 2016-06-03T10:35:56  *** CodeShark has joined #bitcoin-core-dev
125 2016-06-03T10:37:48  *** NicolasDorier has joined #bitcoin-core-dev
126 2016-06-03T10:40:31  *** moli has joined #bitcoin-core-dev
127 2016-06-03T10:44:00  *** jtimon has joined #bitcoin-core-dev
128 2016-06-03T10:48:58  *** tucenaber has quit IRC
129 2016-06-03T10:49:45  *** wangchun has joined #bitcoin-core-dev
130 2016-06-03T11:02:07  *** tucenaber has joined #bitcoin-core-dev
131 2016-06-03T11:02:07  *** tucenaber has joined #bitcoin-core-dev
132 2016-06-03T11:03:50  *** Yv7trNY has joined #bitcoin-core-dev
133 2016-06-03T11:10:27  *** xiangfu has quit IRC
134 2016-06-03T11:20:28  *** Thireus1 has joined #bitcoin-core-dev
135 2016-06-03T11:23:24  *** fengling has quit IRC
136 2016-06-03T11:35:12  *** goregrin1 has quit IRC
137 2016-06-03T11:35:50  *** goregrind has joined #bitcoin-core-dev
138 2016-06-03T11:37:13  <MarcoFalke> Why is travis not picking up any pulls?
139 2016-06-03T11:58:26  <MarcoFalke> temporarily down, apparently. Working again...
140 2016-06-03T12:00:39  <phantomcircuit> MarcoFalke, the docker repo is broken
141 2016-06-03T12:00:46  <phantomcircuit> https://github.com/docker/docker/issues/23203
142 2016-06-03T12:00:53  <phantomcircuit> also dat issue number
143 2016-06-03T12:04:07  *** murch has joined #bitcoin-core-dev
144 2016-06-03T12:05:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
145 2016-06-03T12:06:39  *** fengling has joined #bitcoin-core-dev
146 2016-06-03T12:11:24  *** fengling has quit IRC
147 2016-06-03T12:15:49  *** MarcoFalke has left #bitcoin-core-dev
148 2016-06-03T12:24:39  *** TomMc has joined #bitcoin-core-dev
149 2016-06-03T12:32:09  *** gabridome has quit IRC
150 2016-06-03T12:44:18  *** MrHodl has quit IRC
151 2016-06-03T12:44:40  *** molz has joined #bitcoin-core-dev
152 2016-06-03T12:45:24  *** gabridome has joined #bitcoin-core-dev
153 2016-06-03T12:47:51  *** moli has quit IRC
154 2016-06-03T12:54:48  *** gabridome has quit IRC
155 2016-06-03T12:55:39  *** Chris_Stewart_5 has quit IRC
156 2016-06-03T13:08:06  *** fengling has joined #bitcoin-core-dev
157 2016-06-03T13:09:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
158 2016-06-03T13:09:50  *** erasmospunk has joined #bitcoin-core-dev
159 2016-06-03T13:12:24  *** fengling has quit IRC
160 2016-06-03T13:14:38  *** cryptapus_afk is now known as cryptapus
161 2016-06-03T13:20:49  *** gabridome has joined #bitcoin-core-dev
162 2016-06-03T13:30:01  <GitHub175> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae5575ba41c8...c141c14c9f5f
163 2016-06-03T13:30:02  <GitHub175> bitcoin/master efb54ba Kaz Wesley: lock cs_main for State/Misbehaving...
164 2016-06-03T13:30:02  <GitHub175> bitcoin/master 719de56 Kaz Wesley: lock cs_main for chainActive...
165 2016-06-03T13:30:03  <GitHub175> bitcoin/master c141c14 Wladimir J. van der Laan: Merge #7942: locking for Misbehave() and other cs_main locking fixes...
166 2016-06-03T13:30:11  <GitHub84> [bitcoin] laanwj closed pull request #7942: locking for Misbehave() and other cs_main locking fixes (master...locking) https://github.com/bitcoin/bitcoin/pull/7942
167 2016-06-03T13:36:02  *** Chris_Stewart_5 has quit IRC
168 2016-06-03T13:48:08  <GitHub142> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c141c14c9f5f...8c1e49ba13a8
169 2016-06-03T13:48:09  <GitHub142> bitcoin/master 3b35e48 Jonas Schnelli: [RPC] add feerate option to fundrawtransaction
170 2016-06-03T13:48:09  <GitHub142> bitcoin/master 04eaa90 Jonas Schnelli: Add more clear interface for CoinControl.h regarding individual feerate
171 2016-06-03T13:48:10  <GitHub142> bitcoin/master 8c1e49b Wladimir J. van der Laan: Merge #7967: [RPC] add feerate option to fundrawtransaction...
172 2016-06-03T13:48:15  <GitHub162> [bitcoin] laanwj closed pull request #7967: [RPC] add feerate option to fundrawtransaction (master...2016/04/fund_fee) https://github.com/bitcoin/bitcoin/pull/7967
173 2016-06-03T13:51:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
174 2016-06-03T13:53:54  <GitHub157> [bitcoin] fanquake closed pull request #8119: [trivial] Add .DSYM to .gitignore (master...ignore_debug) https://github.com/bitcoin/bitcoin/pull/8119
175 2016-06-03T13:56:08  <GitHub35> [bitcoin] laanwj closed pull request #7995: main: Make version bits GUI warning clearer to translators (master...2016_05_minor_message_change) https://github.com/bitcoin/bitcoin/pull/7995
176 2016-06-03T13:57:43  <sipa> \o/ 4 pages of pull requests
177 2016-06-03T14:00:17  *** ozanyurt has joined #bitcoin-core-dev
178 2016-06-03T14:00:24  <wumpus> :o
179 2016-06-03T14:02:53  <wumpus> luke-jr: I disagree with #8132, we should be adding backwards compatibility code for pulls that were never merged. Also this creates a downward spiral, making it harder and harder to merge because more code is added to be compatible with older versions of the same pull request
180 2016-06-03T14:05:49  <gmaxwell> I demand backwards compatiblity code for functionality I had in a dream.
181 2016-06-03T14:06:54  <wumpus> definitely, that should be the next step
182 2016-06-03T14:07:05  <wumpus> although it's a bit disconcerting that you dream about bitcoind functionality :)
183 2016-06-03T14:07:20  <sipa> at least we should be backward compatible with the future features we envision!
184 2016-06-03T14:07:28  <sipa> wait...
185 2016-06-03T14:08:13  <gmaxwell> am I the only person here that dreams about Bitcoin?
186 2016-06-03T14:08:29  <GitHub94> [bitcoin] instagibbs opened pull request #8143: comment nit: miners don't vote (master...notavote) https://github.com/bitcoin/bitcoin/pull/8143
187 2016-06-03T14:08:36  <sipa> i don't usually remember my dreams
188 2016-06-03T14:08:52  <gmaxwell> reorg?
189 2016-06-03T14:08:58  *** fengling has joined #bitcoin-core-dev
190 2016-06-03T14:09:36  <sipa> i guess a reorg is somewhat like a deja vu in the matrix
191 2016-06-03T14:09:58  <instagibbs> replay attack maybe
192 2016-06-03T14:11:58  <ozanyurt> hello can I ask key signing question here?
193 2016-06-03T14:12:19  <sipa> is it related to bitcoin development?
194 2016-06-03T14:12:34  <ozanyurt> no thanks :)
195 2016-06-03T14:12:46  <ozanyurt> it is related to my bitcoin development
196 2016-06-03T14:13:55  <sipa> this channel is about development of bitcoin core
197 2016-06-03T14:14:21  <ozanyurt> ok
198 2016-06-03T14:14:48  <instagibbs> ozanyurt, try #bitcoin
199 2016-06-03T14:15:12  <ozanyurt> I will do, thanks
200 2016-06-03T14:15:44  *** fengling has quit IRC
201 2016-06-03T14:23:16  *** Thireus1 has quit IRC
202 2016-06-03T14:24:11  *** Thireus1 has joined #bitcoin-core-dev
203 2016-06-03T14:24:33  <Chris_Stewart_5> Are BIP141,143,144 finalized? Or is this witness program extra byte thing going to affect one of them?
204 2016-06-03T14:25:18  <sipa> it affects 141
205 2016-06-03T14:26:15  <sipa> oh, the limit is not included in bip141
206 2016-06-03T14:26:26  <instagibbs> yes it is
207 2016-06-03T14:26:42  <instagibbs> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#witness-program
208 2016-06-03T14:27:03  <sipa> oh yes
209 2016-06-03T14:29:42  <Chris_Stewart_5> Thanks -- this is only a hardfork to testnet correct? I was tryign to follow the dev meeting yesterday
210 2016-06-03T14:30:07  *** Thireus1 has quit IRC
211 2016-06-03T14:33:42  *** Giszmo has joined #bitcoin-core-dev
212 2016-06-03T14:34:39  *** MarcoFalke has joined #bitcoin-core-dev
213 2016-06-03T14:35:18  *** paveljanik has joined #bitcoin-core-dev
214 2016-06-03T14:35:18  *** paveljanik has joined #bitcoin-core-dev
215 2016-06-03T14:37:05  <sipa> jl2012: feel Chris_Stewart_5 indeed
216 2016-06-03T14:39:41  <sipa> uh
217 2016-06-03T14:40:03  <sipa> jl2012: feel like updating bip141 for the program size extension?
218 2016-06-03T14:40:09  <sipa> Chris_Stewart_5: indeed
219 2016-06-03T14:47:58  *** molz has quit IRC
220 2016-06-03T14:48:28  *** molz has joined #bitcoin-core-dev
221 2016-06-03T14:49:05  *** Yv7trNY has quit IRC
222 2016-06-03T14:50:15  <Chris_Stewart_5> sipa: I have to say that is one of the strangest comments i've been tagged on in irc :-)
223 2016-06-03T14:50:45  <sipa> you clearly need to spend more time on irc then
224 2016-06-03T14:50:48  <sipa> :)
225 2016-06-03T14:52:23  <instagibbs> so, will this relaxation only effect v1+?
226 2016-06-03T14:52:53  <instagibbs> v0 explicitly restricts sizes to 20 and 32
227 2016-06-03T14:56:58  *** Yv7trNY has joined #bitcoin-core-dev
228 2016-06-03T14:58:14  <sipa> instagibbs: unnecessary complication to do that
229 2016-06-03T14:59:27  *** gabridome has quit IRC
230 2016-06-03T15:01:24  <instagibbs> "do that" meaning to not do it for all versions?
231 2016-06-03T15:01:50  <sipa> i mean: adding code to make it only affect v1+ would be unnecessarily hard
232 2016-06-03T15:02:13  <sipa> if you mean whether a naive relaxation will only affect v1+? no
233 2016-06-03T15:02:20  <instagibbs> yep thanks
234 2016-06-03T15:08:00  *** frankenmint has quit IRC
235 2016-06-03T15:09:14  <instagibbs> hm, so the bip is slightly misleading then, if v1-16 was actually size restricted for the witness to 32 bytes max
236 2016-06-03T15:10:01  <sipa> A scriptPubKey (or redeemScript as defined in BIP16/P2SH) that consists of a 1-byte push opcode (for 0 to 16) followed by a data push between 2 and 32 bytes gets a new special meaning. The value of the first push is called the "version byte". The following byte vector pushed is called the "witness program".
237 2016-06-03T15:10:38  <instagibbs> I know that, I'm reading later in the text, but I suppose it's actually no contradictory
238 2016-06-03T15:11:21  <instagibbs> "If the version byte is 1 to 16, no further interpretation of the witness program or witness happens, and there is no size restriction for the witness."
239 2016-06-03T15:11:30  <instagibbs> perhaps "no further size restriction"
240 2016-06-03T15:12:05  <instagibbs> oh, witness, not program?
241 2016-06-03T15:12:16  *** fengling has joined #bitcoin-core-dev
242 2016-06-03T15:12:17  <instagibbs> not a big deal either way
243 2016-06-03T15:14:20  <luke-jr> wumpus: gmaxwell: sipa: that one was merged in Knots, and therefore there are wallets in the wild using it.
244 2016-06-03T15:17:05  *** fengling has quit IRC
245 2016-06-03T15:19:48  <gmaxwell> how did my dreams end up in knots?
246 2016-06-03T15:21:01  <wumpus> I've had dreams about bitcoin sometimes, though usually about things going wrong
247 2016-06-03T15:21:25  <wumpus> luke-jr: I understand, but this is quite awkward
248 2016-06-03T15:21:50  <btcdrak> knots is its own thing...
249 2016-06-03T15:22:25  <wumpus> I just don't like merging the first version of something then already having to handle an older version of it; it's not like the wallet isn't enough of a mess as it is
250 2016-06-03T15:22:59  <wumpus> so my question is, doesn't this backwards compatible logic belong in knots but not in bitcoin core?
251 2016-06-03T15:23:31  <luke-jr> wumpus: depends on how badly it breaks Core to omit it
252 2016-06-03T15:24:32  <wumpus> well I agree, though there's a limit up to what core will support other people's wallet changes
253 2016-06-03T15:24:44  <wumpus> it shouldn't crash at least, agred
254 2016-06-03T15:24:50  <wumpus> (or otherwise lose private keys)
255 2016-06-03T15:25:18  <luke-jr> the only other possibility I see is it destroying the info, so crash/error seems the least problematic result
256 2016-06-03T15:25:20  *** Thireus1 has joined #bitcoin-core-dev
257 2016-06-03T15:25:47  <luke-jr> whatever it is, downgrading would have the same effect, so probably should figure out what it is
258 2016-06-03T15:25:50  <wumpus> what was the use case why you wanted to merge this so badly before it was finished?
259 2016-06-03T15:26:03  <wumpus> this is more like sidegrading than downgrading though
260 2016-06-03T15:26:19  <wumpus> downgrading to a version that doesn't support the functionality at all works
261 2016-06-03T15:26:21  <luke-jr> there wasn't any reason at the time to see that it would be changed significantly. it had stagnated for months IIRC
262 2016-06-03T15:26:32  *** iniana has quit IRC
263 2016-06-03T15:26:35  *** gabridome has joined #bitcoin-core-dev
264 2016-06-03T15:27:33  <wumpus> in any case you made it more complex to merge because there's even more scenarios to consider
265 2016-06-03T15:29:02  <luke-jr> it seems that is the result, yes
266 2016-06-03T15:31:50  <wumpus> I do think we want the functionality, especially with deterministic wallets, we want to be able to detect if there's e.g. any imported keys
267 2016-06-03T15:32:25  <luke-jr> unfortunately, foresight is not as good as hindsight; had I known it'd complicate things, I'd have held off - as you say, there was no great urgency
268 2016-06-03T15:33:00  <wumpus> well it makes clear how careful we need to be with wallet format changes
269 2016-06-03T15:33:19  <wumpus> if any little change needs to be supported forever, even if it never made it into an release
270 2016-06-03T15:34:09  <luke-jr> I wonder if we should change the key storage to be like wtx, which uses a key/value map
271 2016-06-03T15:34:12  <wumpus> that was kind of my reason to hold off on it a bit in the first place, I wanted to be sure not to introduce a problem like this where we'd need a second version
272 2016-06-03T15:34:55  <wumpus> going from 8 to 32 bits seemed to be a good idea for future extensibility in that regard, although possilbly it's not needed I don't know...
273 2016-06-03T15:36:08  <wumpus> I suppose we can always make a version 2 and add this migration code *IF* we need 32 bits
274 2016-06-03T15:36:19  <gmaxwell> "now we can start packing data from the keys inthe version to save space!"
275 2016-06-03T15:36:22  <wumpus> instead of doing an upgrade for something we're not sure we'll eer need
276 2016-06-03T15:36:39  <luke-jr> hmm
277 2016-06-03T15:36:50  <wumpus> ah I see jonasschnelli already proposes that
278 2016-06-03T15:37:04  * luke-jr email down so hasn't caught up on anything yet today :<
279 2016-06-03T15:37:37  <sipa> i moved ctaes to bitcoin-core
280 2016-06-03T15:37:50  <wumpus> gmaxwell: hah, I imagine that's what it was like in the 80's where every bit counted
281 2016-06-03T15:38:14  <jonasschnelli> sipa: ack: +1
282 2016-06-03T15:38:18  <wumpus> sipa: nice
283 2016-06-03T15:38:48  <wumpus> 8-bit bitfields even sounds very retro, maybe the bitcoind port to MSX can make progress now :)
284 2016-06-03T15:39:05  <jonasschnelli> :-)
285 2016-06-03T15:39:32  <sipa> we can stop treating the wallet encrypted keys as padded cbc, and get 12 of storage :p
286 2016-06-03T15:39:35  <jonasschnelli> Yes. It was my "limited space" that made me use 8bit in the first place. We should really use 32bits for a such thing.
287 2016-06-03T15:40:08  <jonasschnelli> BTW: is there a reason for not having a function to decrypt the wallet?
288 2016-06-03T15:40:15  <jonasschnelli> I mean permanently decrypt.
289 2016-06-03T15:40:16  <sipa> jonasschnelli: yes
290 2016-06-03T15:40:17  <wumpus> jonasschnelli: just trying to avoid this awkward upgrade scenario
291 2016-06-03T15:40:26  <wumpus> there should be no need to do that ever
292 2016-06-03T15:40:48  <jonasschnelli> There is no upgrade scenario right now because we haven't merged anything regarding key-metadata
293 2016-06-03T15:40:55  <sipa> jonasschnelli: if we'd design it from scratch, i think wallets would always be encrypted (though perhaps with an option to have an empty key)
294 2016-06-03T15:41:03  *** wangchun has quit IRC
295 2016-06-03T15:41:09  <jonasschnelli> But I think a 32bit bitmap for key metadata could make sense for a wallet upgrade.
296 2016-06-03T15:41:22  <jonasschnelli> Can be use to determin where the key came from, if it's HD generaded, etc.
297 2016-06-03T15:41:33  <jonasschnelli> sipa: Good point.
298 2016-06-03T15:42:13  <jonasschnelli> Should I take a second attempt use use LogDB for the wallet database?
299 2016-06-03T15:42:31  <jonasschnelli> I have factored out logdb as a standalone C library: https://github.com/liblogdb/liblogdb
300 2016-06-03T15:42:57  <jonasschnelli> So we could use a simple subset for bitcoin-core (not a subtree, more like 2-3 files like ctaes)
301 2016-06-03T15:43:51  <jonasschnelli> I could even add callbacks for the hashing to avoid duplicated sha256 implementation.
302 2016-06-03T15:44:54  <wumpus> I agree with sipa. Optionally allowing an empty key would be ok, it would still avoid some file system leaks
303 2016-06-03T15:45:45  <jonasschnelli> Right. I also think we should support *full*-wallet-encryption.
304 2016-06-03T15:46:04  *** fanquake has joined #bitcoin-core-dev
305 2016-06-03T15:46:18  <jonasschnelli> (require unlock of level 1 when staring Bitcoin-Qt/bitcoind)
306 2016-06-03T15:46:29  <jonasschnelli> (require unlock for level 2 when signing stuff)
307 2016-06-03T15:46:30  <luke-jr> (IMO wallet encryption is mostly a PR stunt from 2011, and we should focus on hardware wallet support.)
308 2016-06-03T15:46:40  <jonasschnelli> luke-jr: +1.
309 2016-06-03T15:46:49  <gmaxwell> I worry multiple passwords means the user will forget the signing one and not realize there are two.
310 2016-06-03T15:46:50  *** fanquake has quit IRC
311 2016-06-03T15:46:55  <jonasschnelli> I once started to specify the "detached signing".
312 2016-06-03T15:47:08  <jonasschnelli> Sadly there is no standard API for hardware wallets...
313 2016-06-03T15:47:08  <gmaxwell> we really don't want to make the data loss worse from wallet encryption, I'd rather have it gone than that.
314 2016-06-03T15:47:44  <jonasschnelli> gmaxwell: maybe the data loss is also because we don't offer a clear recovery-process during encryption.
315 2016-06-03T15:47:50  <luke-jr> gmaxwell: could we have them be the same, and only cache the decryption key (not the passphrase) at runtime?
316 2016-06-03T15:48:00  <jonasschnelli> Like allowing the user to write somthing down or print out a "backup" key or something.
317 2016-06-03T15:48:28  <gmaxwell> I suggested an idea a while back that we just define an interface where we fork a process that speaks a bitcoin-core specific protocol to bitcoin... then speaks whatever the wallet needs to speak, and can open up UIs and whatnot.
318 2016-06-03T15:48:54  <gmaxwell> e.g.  signhardware=bobpocketwallet-qt.exe
319 2016-06-03T15:49:18  <wumpus> I'm not sure about full wallet encryption, you can always store the wallet on an encrypted volume that's likely safer
320 2016-06-03T15:49:31  <wumpus> (you can store your other secret files there too.)
321 2016-06-03T15:49:32  <jonasschnelli> I was thinking after more torwards TCP/IP httpd interface
322 2016-06-03T15:49:51  <wumpus> I doubt the bitcoin wallet metadata is the only metadata you'd want to hide
323 2016-06-03T15:49:51  <jonasschnelli> signhardware=http://x:y@127.0.0.1:8888
324 2016-06-03T15:50:01  <gmaxwell> wumpus: the model I like is where you use the signing key to derrive an access key (e.g. H(KDF(passphrase)) = viewkey)  and then you simply save the viewkey on disk in a seperate file.
325 2016-06-03T15:50:02  <wumpus> yes, support for hardware key storage and signing would be nice
326 2016-06-03T15:50:25  <gmaxwell> wumpus: then if you backup/restore (e.g. to the 'cloud') you'll need to enter your passphrase once to unlock.
327 2016-06-03T15:50:35  <wumpus> (or "isolated CPU conclave" if that's what you prefer)
328 2016-06-03T15:50:44  <gmaxwell> but your backups are still confidential without extra steps.
329 2016-06-03T15:50:52  <jonasschnelli> Each hdwallet could offer a tiny daemon (httpd) that listens for requested sign processes and build up a UI once a signing-request comes in.
330 2016-06-03T15:50:57  <jl2012> sipa: what's the decision?
331 2016-06-03T15:51:02  <jonasschnelli> hdwallet=hardwarewallet
332 2016-06-03T15:51:08  <sipa> jl2012: 40 bytes
333 2016-06-03T15:51:17  <wumpus> gmaxwell: yes, that is a good idea.
334 2016-06-03T15:51:17  <gmaxwell> Yea, on your local meachine metadata privacy is almost totally pointless, your browser cache tells anyone with your computer almost anything you did with the bitcoin wallet.
335 2016-06-03T15:51:24  <gmaxwell> but for backup it's useful.
336 2016-06-03T15:51:32  <wumpus> two passwords is too much for most people
337 2016-06-03T15:51:48  <jonasschnelli> Yes. That's true.
338 2016-06-03T15:51:57  <jl2012> Ok, will do it tomorrow
339 2016-06-03T15:52:17  <jonasschnelli> Maybe encrypting the disk is the way to go.
340 2016-06-03T15:52:19  <wumpus> well the wallet encryption is for local security I suppose. Backups you'd certainly want fully encrypted, I agree
341 2016-06-03T15:52:28  <wumpus> OTOH that doesn't need to be wallet.dat format
342 2016-06-03T15:53:01  <gmaxwell> encrypting your disk is a great idea. I've encrypted all my disks since .. uh.. 1998?  WD sent me back an RMA drive with someone elses data... often when a drive fails you can't zeroize it first.. sooo.
343 2016-06-03T15:53:37  <gmaxwell> wumpus: thats true, wrt format.
344 2016-06-03T15:53:42  <luke-jr> I prefer to encrypt only my sensitive data, so I can un-decrypt it when I step away
345 2016-06-03T15:54:09  <wumpus> I encrypt my disks too, except for 'junk' partitions like where I store zillions of copies of the blockchain
346 2016-06-03T15:54:38  <jonasschnelli> heh
347 2016-06-03T15:54:41  <wumpus> I suppose with a newer CPU with encrypt/decrypt instructions the overhead is so low that you don't really care and just encrypt everything
348 2016-06-03T15:54:58  *** erasmospunk has quit IRC
349 2016-06-03T15:55:23  <wumpus> (I do always encrypt swap with random key too)
350 2016-06-03T15:56:55  <wumpus> in any case, for backups encrypting the full thing makes a lot of sense, certainly for cloud backups
351 2016-06-03T15:58:51  <wumpus> dropbox must have a lot of wallet metadata
352 2016-06-03T16:01:03  <luke-jr> for backups, definitely want to encrypt the whole thing IMO
353 2016-06-03T16:01:53  *** wangchun has joined #bitcoin-core-dev
354 2016-06-03T16:05:01  *** BashCo has quit IRC
355 2016-06-03T16:06:09  <wumpus> yes
356 2016-06-03T16:06:37  <wumpus> I just encrypt my entire backups so such functionality in bitcoind wouldn't help me much, but I guess some people would be helped by it
357 2016-06-03T16:08:45  *** frankenmint has joined #bitcoin-core-dev
358 2016-06-03T16:11:37  <gmaxwell> encrypting it is also good for metadata preservation, e.g. evenutally we could have some ftp or webdav or whatever kids uses these days, url in the config you could set to push a new backup every time your metadata changes.
359 2016-06-03T16:11:54  *** calibre720 has quit IRC
360 2016-06-03T16:12:21  <luke-jr> well, hopefully that new BIP metadata storage thing works out..
361 2016-06-03T16:13:40  *** frankenmint has quit IRC
362 2016-06-03T16:13:55  *** fengling has joined #bitcoin-core-dev
363 2016-06-03T16:14:30  <sipa> can't we just store the metadata in a dht cloud blockchain, with rainbow tables for security?
364 2016-06-03T16:16:42  <wumpus> and render the rainbow tables in actual rainbow colors in the GUI
365 2016-06-03T16:16:46  <wumpus> with dancing unicorns
366 2016-06-03T16:18:27  <wumpus> nothing protects your wallet better than distributed colorful random cloud technology
367 2016-06-03T16:18:44  *** fengling has quit IRC
368 2016-06-03T16:18:47  <sipa> copied from a random github repository
369 2016-06-03T16:20:31  <luke-jr> …
370 2016-06-03T16:21:24  <gmaxwell> back it up by finding a random pull reqest and then open up a copy against a fork of the origin project with the data added...
371 2016-06-03T16:21:31  <gmaxwell> non-zero probablity that they merge it.
372 2016-06-03T16:24:13  *** Yv7trNY has quit IRC
373 2016-06-03T16:25:53  *** calibre720 has joined #bitcoin-core-dev
374 2016-06-03T16:30:33  <sipa> a certain linux thorvalds quote comes to mind
375 2016-06-03T16:31:09  *** achow101 has joined #bitcoin-core-dev
376 2016-06-03T16:31:59  *** BashCo has joined #bitcoin-core-dev
377 2016-06-03T16:33:38  *** molz has quit IRC
378 2016-06-03T16:38:02  <sipa> s/linux/linus/
379 2016-06-03T16:38:27  * gmaxwell waits for the lastname
380 2016-06-03T16:39:25  <sipa> s/lastname/last name/
381 2016-06-03T16:42:39  *** Yv7trNY has joined #bitcoin-core-dev
382 2016-06-03T16:56:46  <GitHub154> [bitcoin] MarcoFalke opened pull request #8144: [rpc] fundrawtransaction: Fix help text (master...Mf1606-rpcDoc) https://github.com/bitcoin/bitcoin/pull/8144
383 2016-06-03T17:02:41  *** Thireus1 has quit IRC
384 2016-06-03T17:04:58  *** Yv7trNY has quit IRC
385 2016-06-03T17:09:34  *** frankenmint has joined #bitcoin-core-dev
386 2016-06-03T17:14:15  *** frankenmint has quit IRC
387 2016-06-03T17:15:29  *** fengling has joined #bitcoin-core-dev
388 2016-06-03T17:19:44  *** fengling has quit IRC
389 2016-06-03T17:26:59  <cfields_> MarcoFalke/wumpus: re: #8133, suggestions for how to fixup the import paths? I used a quick hack for the first one, but since we need another, i'd rather avoid adding more hacks on top
390 2016-06-03T17:27:54  <MarcoFalke> Would also help if there was a comment for the hack, so it is easier to understand when looked at later.
391 2016-06-03T17:28:08  <MarcoFalke> Did you manage to look at the python issue?
392 2016-06-03T17:28:28  <MarcoFalke> I can try to play a bit locally when that's fixed
393 2016-06-03T17:29:18  <cfields_> MarcoFalke: yea, it's the same issue that the "a few ugly hacks" commit fixes, just a different place.
394 2016-06-03T17:29:43  <cfields_> MarcoFalke: ok, maybe easier if i just apply another ugly hack for now, and you can run cleanup afterwards? :)
395 2016-06-03T17:30:08  <MarcoFalke> If I can figure out something better ;)
396 2016-06-03T17:30:59  <cfields_> MarcoFalke: the underlying issue is that the scripts in the read-only srcdir need to import a script from the builddir, which is in an unknown location
397 2016-06-03T17:31:22  <MarcoFalke> ok
398 2016-06-03T17:31:59  <cfields_> the hack fix is to assume we're running from builddir, and add the path of the to-import files relative to pwd before doing the actual import
399 2016-06-03T17:36:26  <cfields_> MarcoFalke: aha, wait. we already have the path set in the makefile. The problem is the .pyc lingering around in srcdir
400 2016-06-03T17:36:38  <cfields_> (that's why travis passed)
401 2016-06-03T17:43:51  <cfields_> ok. since we require python3 now, i don't think that's a problem. looks like it should just be a one-time delete.
402 2016-06-03T17:58:49  *** Thireus1 has joined #bitcoin-core-dev
403 2016-06-03T18:10:18  *** frankenmint has joined #bitcoin-core-dev
404 2016-06-03T18:14:52  *** frankenmint has quit IRC
405 2016-06-03T18:15:53  *** TomMc has quit IRC
406 2016-06-03T18:16:10  *** fengling has joined #bitcoin-core-dev
407 2016-06-03T18:21:04  *** fengling has quit IRC
408 2016-06-03T18:23:57  *** laurentmt has joined #bitcoin-core-dev
409 2016-06-03T18:26:09  *** Thireus1 has quit IRC
410 2016-06-03T18:28:17  *** laurentmt has quit IRC
411 2016-06-03T18:32:24  <MarcoFalke> cfields_: I am missing the background but what about adding the rm *pyc to `make clean`?
412 2016-06-03T18:32:52  <MarcoFalke> The same pycs need to be removed in the qa folder, I guess
413 2016-06-03T18:32:57  <MarcoFalke> (Same error)
414 2016-06-03T18:33:07  <cfields_> MarcoFalke: 'make clean' now removes __pycache__, which does just that
415 2016-06-03T18:33:59  <cfields_> MarcoFalke: it's just the old python2 .pyc's that are trouble. More specifically, only when the .pyc exists and the .py is in a different path (builddir/srcdir)
416 2016-06-03T18:34:47  <MarcoFalke> When I first tried to build out of dir, it told me to do 'make distclean' in the src dir.
417 2016-06-03T18:35:21  <cfields_> MarcoFalke: you got another error in qa? tests_config.pyc i'm guessing?
418 2016-06-03T18:35:25  <MarcoFalke> So keeping the code to remove pyc's in `make clean` temporarily would make sense
419 2016-06-03T18:35:46  <MarcoFalke> jup, test_config
420 2016-06-03T18:35:50  <cfields_> MarcoFalke: aha, good point!
421 2016-06-03T18:36:16  <cfields_> MarcoFalke: so adding those 2 files to the distclean would solve it in a more obvious way.
422 2016-06-03T18:36:43  <MarcoFalke> I guess so
423 2016-06-03T18:38:20  <MarcoFalke> Also there is pyc's in qa/rpc-tests/test_framework/ like __init__.pyc
424 2016-06-03T18:38:26  <MarcoFalke> I am assuming they don't hurt?
425 2016-06-03T18:40:04  <cfields_> MarcoFalke: I believe it's only the ones that don't exist in srcdir (the pre-processed files)
426 2016-06-03T18:43:12  <cfields_> MarcoFalke: pushed with that change instead. thanks for the reminder about the forced distclean.
427 2016-06-03T18:43:29  <MarcoFalke> testing...
428 2016-06-03T18:45:11  <cfields_> MarcoFalke: it might cause the same error for you now, but remember that you're passed the forced distclean. You can do another to simulate.
429 2016-06-03T18:47:59  <MarcoFalke> distclean works
430 2016-06-03T18:50:19  <cfields_> ok great. thanks for testing!
431 2016-06-03T18:55:03  <MarcoFalke> copying rpc-test.py instead of linking would be considred bad practice?
432 2016-06-03T18:59:08  *** Naphex has quit IRC
433 2016-06-03T19:00:16  <cfields_> MarcoFalke: we could, but I was afraid it'd get confusing.
434 2016-06-03T19:17:47  *** fengling has joined #bitcoin-core-dev
435 2016-06-03T19:22:44  *** fengling has quit IRC
436 2016-06-03T19:32:14  *** Yv7trNY has joined #bitcoin-core-dev
437 2016-06-03T19:36:01  *** TomMc has joined #bitcoin-core-dev
438 2016-06-03T19:39:50  <sipa> would it help to move roc-test.py to the roc-tests directory?
439 2016-06-03T19:45:09  *** Yv7trNY has quit IRC
440 2016-06-03T19:48:55  *** Chris_Stewart_5 has quit IRC
441 2016-06-03T19:50:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
442 2016-06-03T19:51:21  *** Thireus1 has joined #bitcoin-core-dev
443 2016-06-03T20:19:16  *** fengling has joined #bitcoin-core-dev
444 2016-06-03T20:23:34  *** MarcoFalke has quit IRC
445 2016-06-03T20:24:04  *** fengling has quit IRC
446 2016-06-03T20:27:28  *** Chris_Stewart_5 has quit IRC
447 2016-06-03T20:35:18  *** limpkin_ is now known as limpkin
448 2016-06-03T20:43:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
449 2016-06-03T20:48:35  *** jujumax_ has joined #bitcoin-core-dev
450 2016-06-03T20:51:14  *** Guyver2 has joined #bitcoin-core-dev
451 2016-06-03T21:11:30  *** jujumax_ has quit IRC
452 2016-06-03T21:13:19  *** laurentmt has joined #bitcoin-core-dev
453 2016-06-03T21:19:51  *** laurentmt has quit IRC
454 2016-06-03T21:20:50  *** fengling has joined #bitcoin-core-dev
455 2016-06-03T21:21:22  *** cryptapus is now known as cryptapus_afk
456 2016-06-03T21:24:26  *** jannes has quit IRC
457 2016-06-03T21:24:43  *** Thireus1 has quit IRC
458 2016-06-03T21:25:44  *** fengling has quit IRC
459 2016-06-03T21:32:35  * luke-jr doing some rather extensive testing with 8133 FWIW
460 2016-06-03T21:43:01  *** Chris_Stewart_5 has quit IRC
461 2016-06-03T21:43:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
462 2016-06-03T21:49:09  *** ozanyurt has quit IRC
463 2016-06-03T21:55:36  *** Chris_Stewart_5 has quit IRC
464 2016-06-03T22:06:59  *** frankenmint has joined #bitcoin-core-dev
465 2016-06-03T22:12:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
466 2016-06-03T22:12:31  *** frankenmint has quit IRC
467 2016-06-03T22:22:25  *** fengling has joined #bitcoin-core-dev
468 2016-06-03T22:27:04  *** fengling has quit IRC
469 2016-06-03T22:44:05  *** AaronvanW has quit IRC
470 2016-06-03T22:51:50  *** TomMc has quit IRC
471 2016-06-03T23:05:28  *** TomMc has joined #bitcoin-core-dev
472 2016-06-03T23:06:44  *** murch has quit IRC
473 2016-06-03T23:12:40  *** moli has joined #bitcoin-core-dev
474 2016-06-03T23:23:53  *** fengling has joined #bitcoin-core-dev
475 2016-06-03T23:28:24  *** fengling has quit IRC
476 2016-06-03T23:37:55  *** TomMc has quit IRC
477 2016-06-03T23:46:07  *** Guyver2 has quit IRC
478 2016-06-03T23:53:16  *** ibrightly has quit IRC
479 2016-06-03T23:55:43  *** ibrightly has joined #bitcoin-core-dev
480 2016-06-03T23:57:28  *** AaronvanW has joined #bitcoin-core-dev