12016-06-03T00:11:15  *** belcher has quit IRC
  22016-06-03T00:11:29  *** belcher has joined #bitcoin-core-dev
  32016-06-03T00:13:31  *** belcher has quit IRC
  42016-06-03T00:20:03  *** fengling has joined #bitcoin-core-dev
  52016-06-03T00:24:44  *** fengling has quit IRC
  62016-06-03T00:44:17  *** kadoban has quit IRC
  72016-06-03T00:54:15  *** TomMc has quit IRC
  82016-06-03T00:58:48  *** fengling has joined #bitcoin-core-dev
  92016-06-03T01:05:18  *** dermoth has quit IRC
 102016-06-03T01:05:58  *** dermoth has joined #bitcoin-core-dev
 112016-06-03T01:08:14  *** TomMc has joined #bitcoin-core-dev
 122016-06-03T01:11:16  *** grassass has quit IRC
 132016-06-03T01:22:02  *** Alopex has quit IRC
 142016-06-03T01:23:07  *** Alopex has joined #bitcoin-core-dev
 152016-06-03T01:35:06  *** dermoth has quit IRC
 162016-06-03T01:38:07  *** dermoth has joined #bitcoin-core-dev
 172016-06-03T01:40:08  *** Giszmo has quit IRC
 182016-06-03T02:00:24  *** grassass has joined #bitcoin-core-dev
 192016-06-03T02:01:15  *** Ylbam has quit IRC
 202016-06-03T02:08:24  *** jtimon has quit IRC
 212016-06-03T02:09:14  *** skang404 has quit IRC
 222016-06-03T02:20:36  *** calibre720 has joined #bitcoin-core-dev
 232016-06-03T02:58:13  *** kadoban has joined #bitcoin-core-dev
 242016-06-03T03:08:49  *** Chris_Stewart_5 has quit IRC
 252016-06-03T03:24:24  *** TheFactory7 has quit IRC
 262016-06-03T03:26:31  *** TomMc has quit IRC
 272016-06-03T03:32:01  *** Alopex has quit IRC
 282016-06-03T03:33:06  *** Alopex has joined #bitcoin-core-dev
 292016-06-03T03:52:01  *** Alopex has quit IRC
 302016-06-03T03:53:07  *** Alopex has joined #bitcoin-core-dev
 312016-06-03T03:59:09  *** achow101 has quit IRC
 322016-06-03T04:24:02  *** Alopex has quit IRC
 332016-06-03T04:25:07  *** Alopex has joined #bitcoin-core-dev
 342016-06-03T04:34:52  *** moli has quit IRC
 352016-06-03T04:35:45  *** xiangfu has joined #bitcoin-core-dev
 362016-06-03T04:42:27  *** moli has joined #bitcoin-core-dev
 372016-06-03T05:03:45  *** moli has quit IRC
 382016-06-03T05:05:46  *** grassass has quit IRC
 392016-06-03T05:05:54  *** gevs has quit IRC
 402016-06-03T05:07:09  *** moli has joined #bitcoin-core-dev
 412016-06-03T05:18:37  *** gevs has joined #bitcoin-core-dev
 422016-06-03T05:18:37  *** gevs has joined #bitcoin-core-dev
 432016-06-03T05:29:01  *** Alopex has quit IRC
 442016-06-03T05:30:06  *** Alopex has joined #bitcoin-core-dev
 452016-06-03T05:39:27  *** grassass has joined #bitcoin-core-dev
 462016-06-03T05:41:01  *** Alopex has quit IRC
 472016-06-03T05:42:06  *** Alopex has joined #bitcoin-core-dev
 482016-06-03T06:18:52  <GitHub68> [bitcoin] pstratem opened pull request #8142: Improve CWallet API  with new GetAccountPubkey function. (master...2016-06-02-cwallet-getaccountpubkey) https://github.com/bitcoin/bitcoin/pull/8142
 492016-06-03T06:36:21  *** Ylbam has joined #bitcoin-core-dev
 502016-06-03T06:42:42  *** paveljanik has quit IRC
 512016-06-03T06:54:01  <GitHub160> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a82f03393a32...ae5575ba41c8
 522016-06-03T06:54:01  <GitHub160> bitcoin/master f45f51e Pieter Wuille: Fix interrupted HTTP RPC connection workaround for Python 3.5+
 532016-06-03T06:54:02  <GitHub160> bitcoin/master ae5575b MarcoFalke: Merge #8139: Fix interrupted HTTP RPC connection workaround for Python 3.5+...
 542016-06-03T06:54:11  <GitHub177> [bitcoin] MarcoFalke closed pull request #8139: Fix interrupted HTTP RPC connection workaround for Python 3.5+ (master...fixwalletbackup) https://github.com/bitcoin/bitcoin/pull/8139
 552016-06-03T07:09:24  *** fengling has quit IRC
 562016-06-03T07:11:42  *** fengling has joined #bitcoin-core-dev
 572016-06-03T07:16:45  *** BashCo has quit IRC
 582016-06-03T07:21:46  *** JackH has quit IRC
 592016-06-03T07:24:54  *** frankenmint has quit IRC
 602016-06-03T07:28:28  *** calibre720 has quit IRC
 612016-06-03T07:32:24  *** fengling has quit IRC
 622016-06-03T07:42:07  *** calibre720 has joined #bitcoin-core-dev
 632016-06-03T07:48:29  *** erasmospunk has joined #bitcoin-core-dev
 642016-06-03T07:50:13  *** Guyver2 has joined #bitcoin-core-dev
 652016-06-03T07:50:14  *** frankenmint has joined #bitcoin-core-dev
 662016-06-03T07:58:24  *** ibrightly has quit IRC
 672016-06-03T07:58:24  *** binns has quit IRC
 682016-06-03T07:58:24  *** zmanian__ has quit IRC
 692016-06-03T07:58:25  *** CodeShark has quit IRC
 702016-06-03T07:58:25  *** NicolasDorier has quit IRC
 712016-06-03T08:16:25  *** BashCo has joined #bitcoin-core-dev
 722016-06-03T08:20:18  *** jannes has joined #bitcoin-core-dev
 732016-06-03T08:22:39  *** calibre720 has quit IRC
 742016-06-03T08:30:28  *** fengling has joined #bitcoin-core-dev
 752016-06-03T08:32:00  *** calibre720 has joined #bitcoin-core-dev
 762016-06-03T08:35:01  *** goregrin1 has joined #bitcoin-core-dev
 772016-06-03T08:36:03  *** Ylbam_ has joined #bitcoin-core-dev
 782016-06-03T08:36:19  *** limpkin_ has joined #bitcoin-core-dev
 792016-06-03T08:37:26  *** mturquette_ has joined #bitcoin-core-dev
 802016-06-03T08:38:50  *** OxADADA_ has joined #bitcoin-core-dev
 812016-06-03T08:39:06  *** limpkin has quit IRC
 822016-06-03T08:39:06  *** Ylbam has quit IRC
 832016-06-03T08:39:07  *** goregrind has quit IRC
 842016-06-03T08:39:08  *** OxADADA has quit IRC
 852016-06-03T08:39:08  *** arubi has quit IRC
 862016-06-03T08:39:08  *** mturquette has quit IRC
 872016-06-03T08:39:10  *** Ylbam_ is now known as Ylbam
 882016-06-03T08:40:49  *** mturquette_ is now known as mturquette
 892016-06-03T08:49:15  *** arubi has joined #bitcoin-core-dev
 902016-06-03T08:52:35  *** Guyver2 has quit IRC
 912016-06-03T08:54:59  *** binns has joined #bitcoin-core-dev
 922016-06-03T09:00:36  *** ibrightly has joined #bitcoin-core-dev
 932016-06-03T09:00:47  *** zmanian__ has joined #bitcoin-core-dev
 942016-06-03T09:07:59  *** erasmospunk has quit IRC
 952016-06-03T09:12:08  *** CodeShark has joined #bitcoin-core-dev
 962016-06-03T09:12:43  *** davec has quit IRC
 972016-06-03T09:13:03  *** davec has joined #bitcoin-core-dev
 982016-06-03T09:13:42  *** NicolasDorier has joined #bitcoin-core-dev
 992016-06-03T09:28:06  *** laurentmt has joined #bitcoin-core-dev
1002016-06-03T09:36:56  *** kadoban has quit IRC
1012016-06-03T09:50:01  *** moli has quit IRC
1022016-06-03T09:55:22  *** laurentmt has quit IRC
1032016-06-03T09:56:05  *** laurentmt has joined #bitcoin-core-dev
1042016-06-03T09:56:40  *** MarcoFalke has joined #bitcoin-core-dev
1052016-06-03T10:02:07  *** CodeShark has quit IRC
1062016-06-03T10:02:07  *** NicolasDorier has quit IRC
1072016-06-03T10:02:07  *** binns has quit IRC
1082016-06-03T10:02:08  *** ibrightly has quit IRC
1092016-06-03T10:02:08  *** zmanian__ has quit IRC
1102016-06-03T10:03:51  *** blkdb has quit IRC
1112016-06-03T10:07:09  *** blkdb has joined #bitcoin-core-dev
1122016-06-03T10:09:06  *** laurentmt has quit IRC
1132016-06-03T10:11:49  *** frankenmint has quit IRC
1142016-06-03T10:12:23  *** frankenmint has joined #bitcoin-core-dev
1152016-06-03T10:15:20  *** binns has joined #bitcoin-core-dev
1162016-06-03T10:16:14  *** wangchun has quit IRC
1172016-06-03T10:23:05  *** blkdb has quit IRC
1182016-06-03T10:24:38  *** renlord has joined #bitcoin-core-dev
1192016-06-03T10:24:43  *** ibrightly has joined #bitcoin-core-dev
1202016-06-03T10:24:54  *** zmanian__ has joined #bitcoin-core-dev
1212016-06-03T10:24:56  *** blkdb has joined #bitcoin-core-dev
1222016-06-03T10:25:35  *** renlord has left #bitcoin-core-dev
1232016-06-03T10:35:02  *** mkarrer has joined #bitcoin-core-dev
1242016-06-03T10:35:56  *** CodeShark has joined #bitcoin-core-dev
1252016-06-03T10:37:48  *** NicolasDorier has joined #bitcoin-core-dev
1262016-06-03T10:40:31  *** moli has joined #bitcoin-core-dev
1272016-06-03T10:44:00  *** jtimon has joined #bitcoin-core-dev
1282016-06-03T10:48:58  *** tucenaber has quit IRC
1292016-06-03T10:49:45  *** wangchun has joined #bitcoin-core-dev
1302016-06-03T11:02:07  *** tucenaber has joined #bitcoin-core-dev
1312016-06-03T11:02:07  *** tucenaber has joined #bitcoin-core-dev
1322016-06-03T11:03:50  *** Yv7trNY has joined #bitcoin-core-dev
1332016-06-03T11:10:27  *** xiangfu has quit IRC
1342016-06-03T11:20:28  *** Thireus1 has joined #bitcoin-core-dev
1352016-06-03T11:23:24  *** fengling has quit IRC
1362016-06-03T11:35:12  *** goregrin1 has quit IRC
1372016-06-03T11:35:50  *** goregrind has joined #bitcoin-core-dev
1382016-06-03T11:37:13  <MarcoFalke> Why is travis not picking up any pulls?
1392016-06-03T11:58:26  <MarcoFalke> temporarily down, apparently. Working again...
1402016-06-03T12:00:39  <phantomcircuit> MarcoFalke, the docker repo is broken
1412016-06-03T12:00:46  <phantomcircuit> https://github.com/docker/docker/issues/23203
1422016-06-03T12:00:53  <phantomcircuit> also dat issue number
1432016-06-03T12:04:07  *** murch has joined #bitcoin-core-dev
1442016-06-03T12:05:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1452016-06-03T12:06:39  *** fengling has joined #bitcoin-core-dev
1462016-06-03T12:11:24  *** fengling has quit IRC
1472016-06-03T12:15:49  *** MarcoFalke has left #bitcoin-core-dev
1482016-06-03T12:24:39  *** TomMc has joined #bitcoin-core-dev
1492016-06-03T12:32:09  *** gabridome has quit IRC
1502016-06-03T12:44:18  *** MrHodl has quit IRC
1512016-06-03T12:44:40  *** molz has joined #bitcoin-core-dev
1522016-06-03T12:45:24  *** gabridome has joined #bitcoin-core-dev
1532016-06-03T12:47:51  *** moli has quit IRC
1542016-06-03T12:54:48  *** gabridome has quit IRC
1552016-06-03T12:55:39  *** Chris_Stewart_5 has quit IRC
1562016-06-03T13:08:06  *** fengling has joined #bitcoin-core-dev
1572016-06-03T13:09:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1582016-06-03T13:09:50  *** erasmospunk has joined #bitcoin-core-dev
1592016-06-03T13:12:24  *** fengling has quit IRC
1602016-06-03T13:14:38  *** cryptapus_afk is now known as cryptapus
1612016-06-03T13:20:49  *** gabridome has joined #bitcoin-core-dev
1622016-06-03T13:30:01  <GitHub175> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae5575ba41c8...c141c14c9f5f
1632016-06-03T13:30:02  <GitHub175> bitcoin/master efb54ba Kaz Wesley: lock cs_main for State/Misbehaving...
1642016-06-03T13:30:02  <GitHub175> bitcoin/master 719de56 Kaz Wesley: lock cs_main for chainActive...
1652016-06-03T13:30:03  <GitHub175> bitcoin/master c141c14 Wladimir J. van der Laan: Merge #7942: locking for Misbehave() and other cs_main locking fixes...
1662016-06-03T13:30:11  <GitHub84> [bitcoin] laanwj closed pull request #7942: locking for Misbehave() and other cs_main locking fixes (master...locking) https://github.com/bitcoin/bitcoin/pull/7942
1672016-06-03T13:36:02  *** Chris_Stewart_5 has quit IRC
1682016-06-03T13:48:08  <GitHub142> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c141c14c9f5f...8c1e49ba13a8
1692016-06-03T13:48:09  <GitHub142> bitcoin/master 3b35e48 Jonas Schnelli: [RPC] add feerate option to fundrawtransaction
1702016-06-03T13:48:09  <GitHub142> bitcoin/master 04eaa90 Jonas Schnelli: Add more clear interface for CoinControl.h regarding individual feerate
1712016-06-03T13:48:10  <GitHub142> bitcoin/master 8c1e49b Wladimir J. van der Laan: Merge #7967: [RPC] add feerate option to fundrawtransaction...
1722016-06-03T13:48:15  <GitHub162> [bitcoin] laanwj closed pull request #7967: [RPC] add feerate option to fundrawtransaction (master...2016/04/fund_fee) https://github.com/bitcoin/bitcoin/pull/7967
1732016-06-03T13:51:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1742016-06-03T13:53:54  <GitHub157> [bitcoin] fanquake closed pull request #8119: [trivial] Add .DSYM to .gitignore (master...ignore_debug) https://github.com/bitcoin/bitcoin/pull/8119
1752016-06-03T13:56:08  <GitHub35> [bitcoin] laanwj closed pull request #7995: main: Make version bits GUI warning clearer to translators (master...2016_05_minor_message_change) https://github.com/bitcoin/bitcoin/pull/7995
1762016-06-03T13:57:43  <sipa> \o/ 4 pages of pull requests
1772016-06-03T14:00:17  *** ozanyurt has joined #bitcoin-core-dev
1782016-06-03T14:00:24  <wumpus> :o
1792016-06-03T14:02:53  <wumpus> luke-jr: I disagree with #8132, we should be adding backwards compatibility code for pulls that were never merged. Also this creates a downward spiral, making it harder and harder to merge because more code is added to be compatible with older versions of the same pull request
1802016-06-03T14:05:49  <gmaxwell> I demand backwards compatiblity code for functionality I had in a dream.
1812016-06-03T14:06:54  <wumpus> definitely, that should be the next step
1822016-06-03T14:07:05  <wumpus> although it's a bit disconcerting that you dream about bitcoind functionality :)
1832016-06-03T14:07:20  <sipa> at least we should be backward compatible with the future features we envision!
1842016-06-03T14:07:28  <sipa> wait...
1852016-06-03T14:08:13  <gmaxwell> am I the only person here that dreams about Bitcoin?
1862016-06-03T14:08:29  <GitHub94> [bitcoin] instagibbs opened pull request #8143: comment nit: miners don't vote (master...notavote) https://github.com/bitcoin/bitcoin/pull/8143
1872016-06-03T14:08:36  <sipa> i don't usually remember my dreams
1882016-06-03T14:08:52  <gmaxwell> reorg?
1892016-06-03T14:08:58  *** fengling has joined #bitcoin-core-dev
1902016-06-03T14:09:36  <sipa> i guess a reorg is somewhat like a deja vu in the matrix
1912016-06-03T14:09:58  <instagibbs> replay attack maybe
1922016-06-03T14:11:58  <ozanyurt> hello can I ask key signing question here?
1932016-06-03T14:12:19  <sipa> is it related to bitcoin development?
1942016-06-03T14:12:34  <ozanyurt> no thanks :)
1952016-06-03T14:12:46  <ozanyurt> it is related to my bitcoin development
1962016-06-03T14:13:55  <sipa> this channel is about development of bitcoin core
1972016-06-03T14:14:21  <ozanyurt> ok
1982016-06-03T14:14:48  <instagibbs> ozanyurt, try #bitcoin
1992016-06-03T14:15:12  <ozanyurt> I will do, thanks
2002016-06-03T14:15:44  *** fengling has quit IRC
2012016-06-03T14:23:16  *** Thireus1 has quit IRC
2022016-06-03T14:24:11  *** Thireus1 has joined #bitcoin-core-dev
2032016-06-03T14:24:33  <Chris_Stewart_5> Are BIP141,143,144 finalized? Or is this witness program extra byte thing going to affect one of them?
2042016-06-03T14:25:18  <sipa> it affects 141
2052016-06-03T14:26:15  <sipa> oh, the limit is not included in bip141
2062016-06-03T14:26:26  <instagibbs> yes it is
2072016-06-03T14:26:42  <instagibbs> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#witness-program
2082016-06-03T14:27:03  <sipa> oh yes
2092016-06-03T14:29:42  <Chris_Stewart_5> Thanks -- this is only a hardfork to testnet correct? I was tryign to follow the dev meeting yesterday
2102016-06-03T14:30:07  *** Thireus1 has quit IRC
2112016-06-03T14:33:42  *** Giszmo has joined #bitcoin-core-dev
2122016-06-03T14:34:39  *** MarcoFalke has joined #bitcoin-core-dev
2132016-06-03T14:35:18  *** paveljanik has joined #bitcoin-core-dev
2142016-06-03T14:35:18  *** paveljanik has joined #bitcoin-core-dev
2152016-06-03T14:37:05  <sipa> jl2012: feel Chris_Stewart_5 indeed
2162016-06-03T14:39:41  <sipa> uh
2172016-06-03T14:40:03  <sipa> jl2012: feel like updating bip141 for the program size extension?
2182016-06-03T14:40:09  <sipa> Chris_Stewart_5: indeed
2192016-06-03T14:47:58  *** molz has quit IRC
2202016-06-03T14:48:28  *** molz has joined #bitcoin-core-dev
2212016-06-03T14:49:05  *** Yv7trNY has quit IRC
2222016-06-03T14:50:15  <Chris_Stewart_5> sipa: I have to say that is one of the strangest comments i've been tagged on in irc :-)
2232016-06-03T14:50:45  <sipa> you clearly need to spend more time on irc then
2242016-06-03T14:50:48  <sipa> :)
2252016-06-03T14:52:23  <instagibbs> so, will this relaxation only effect v1+?
2262016-06-03T14:52:53  <instagibbs> v0 explicitly restricts sizes to 20 and 32
2272016-06-03T14:56:58  *** Yv7trNY has joined #bitcoin-core-dev
2282016-06-03T14:58:14  <sipa> instagibbs: unnecessary complication to do that
2292016-06-03T14:59:27  *** gabridome has quit IRC
2302016-06-03T15:01:24  <instagibbs> "do that" meaning to not do it for all versions?
2312016-06-03T15:01:50  <sipa> i mean: adding code to make it only affect v1+ would be unnecessarily hard
2322016-06-03T15:02:13  <sipa> if you mean whether a naive relaxation will only affect v1+? no
2332016-06-03T15:02:20  <instagibbs> yep thanks
2342016-06-03T15:08:00  *** frankenmint has quit IRC
2352016-06-03T15:09:14  <instagibbs> hm, so the bip is slightly misleading then, if v1-16 was actually size restricted for the witness to 32 bytes max
2362016-06-03T15:10:01  <sipa> A scriptPubKey (or redeemScript as defined in BIP16/P2SH) that consists of a 1-byte push opcode (for 0 to 16) followed by a data push between 2 and 32 bytes gets a new special meaning. The value of the first push is called the "version byte". The following byte vector pushed is called the "witness program".
2372016-06-03T15:10:38  <instagibbs> I know that, I'm reading later in the text, but I suppose it's actually no contradictory
2382016-06-03T15:11:21  <instagibbs> "If the version byte is 1 to 16, no further interpretation of the witness program or witness happens, and there is no size restriction for the witness."
2392016-06-03T15:11:30  <instagibbs> perhaps "no further size restriction"
2402016-06-03T15:12:05  <instagibbs> oh, witness, not program?
2412016-06-03T15:12:16  *** fengling has joined #bitcoin-core-dev
2422016-06-03T15:12:17  <instagibbs> not a big deal either way
2432016-06-03T15:14:20  <luke-jr> wumpus: gmaxwell: sipa: that one was merged in Knots, and therefore there are wallets in the wild using it.
2442016-06-03T15:17:05  *** fengling has quit IRC
2452016-06-03T15:19:48  <gmaxwell> how did my dreams end up in knots?
2462016-06-03T15:21:01  <wumpus> I've had dreams about bitcoin sometimes, though usually about things going wrong
2472016-06-03T15:21:25  <wumpus> luke-jr: I understand, but this is quite awkward
2482016-06-03T15:21:50  <btcdrak> knots is its own thing...
2492016-06-03T15:22:25  <wumpus> I just don't like merging the first version of something then already having to handle an older version of it; it's not like the wallet isn't enough of a mess as it is
2502016-06-03T15:22:59  <wumpus> so my question is, doesn't this backwards compatible logic belong in knots but not in bitcoin core?
2512016-06-03T15:23:31  <luke-jr> wumpus: depends on how badly it breaks Core to omit it
2522016-06-03T15:24:32  <wumpus> well I agree, though there's a limit up to what core will support other people's wallet changes
2532016-06-03T15:24:44  <wumpus> it shouldn't crash at least, agred
2542016-06-03T15:24:50  <wumpus> (or otherwise lose private keys)
2552016-06-03T15:25:18  <luke-jr> the only other possibility I see is it destroying the info, so crash/error seems the least problematic result
2562016-06-03T15:25:20  *** Thireus1 has joined #bitcoin-core-dev
2572016-06-03T15:25:47  <luke-jr> whatever it is, downgrading would have the same effect, so probably should figure out what it is
2582016-06-03T15:25:50  <wumpus> what was the use case why you wanted to merge this so badly before it was finished?
2592016-06-03T15:26:03  <wumpus> this is more like sidegrading than downgrading though
2602016-06-03T15:26:19  <wumpus> downgrading to a version that doesn't support the functionality at all works
2612016-06-03T15:26:21  <luke-jr> there wasn't any reason at the time to see that it would be changed significantly. it had stagnated for months IIRC
2622016-06-03T15:26:32  *** iniana has quit IRC
2632016-06-03T15:26:35  *** gabridome has joined #bitcoin-core-dev
2642016-06-03T15:27:33  <wumpus> in any case you made it more complex to merge because there's even more scenarios to consider
2652016-06-03T15:29:02  <luke-jr> it seems that is the result, yes
2662016-06-03T15:31:50  <wumpus> I do think we want the functionality, especially with deterministic wallets, we want to be able to detect if there's e.g. any imported keys
2672016-06-03T15:32:25  <luke-jr> unfortunately, foresight is not as good as hindsight; had I known it'd complicate things, I'd have held off - as you say, there was no great urgency
2682016-06-03T15:33:00  <wumpus> well it makes clear how careful we need to be with wallet format changes
2692016-06-03T15:33:19  <wumpus> if any little change needs to be supported forever, even if it never made it into an release
2702016-06-03T15:34:09  <luke-jr> I wonder if we should change the key storage to be like wtx, which uses a key/value map
2712016-06-03T15:34:12  <wumpus> that was kind of my reason to hold off on it a bit in the first place, I wanted to be sure not to introduce a problem like this where we'd need a second version
2722016-06-03T15:34:55  <wumpus> going from 8 to 32 bits seemed to be a good idea for future extensibility in that regard, although possilbly it's not needed I don't know...
2732016-06-03T15:36:08  <wumpus> I suppose we can always make a version 2 and add this migration code *IF* we need 32 bits
2742016-06-03T15:36:19  <gmaxwell> "now we can start packing data from the keys inthe version to save space!"
2752016-06-03T15:36:22  <wumpus> instead of doing an upgrade for something we're not sure we'll eer need
2762016-06-03T15:36:39  <luke-jr> hmm
2772016-06-03T15:36:50  <wumpus> ah I see jonasschnelli already proposes that
2782016-06-03T15:37:04  * luke-jr email down so hasn't caught up on anything yet today :<
2792016-06-03T15:37:37  <sipa> i moved ctaes to bitcoin-core
2802016-06-03T15:37:50  <wumpus> gmaxwell: hah, I imagine that's what it was like in the 80's where every bit counted
2812016-06-03T15:38:14  <jonasschnelli> sipa: ack: +1
2822016-06-03T15:38:18  <wumpus> sipa: nice
2832016-06-03T15:38:48  <wumpus> 8-bit bitfields even sounds very retro, maybe the bitcoind port to MSX can make progress now :)
2842016-06-03T15:39:05  <jonasschnelli> :-)
2852016-06-03T15:39:32  <sipa> we can stop treating the wallet encrypted keys as padded cbc, and get 12 of storage :p
2862016-06-03T15:39:35  <jonasschnelli> Yes. It was my "limited space" that made me use 8bit in the first place. We should really use 32bits for a such thing.
2872016-06-03T15:40:08  <jonasschnelli> BTW: is there a reason for not having a function to decrypt the wallet?
2882016-06-03T15:40:15  <jonasschnelli> I mean permanently decrypt.
2892016-06-03T15:40:16  <sipa> jonasschnelli: yes
2902016-06-03T15:40:17  <wumpus> jonasschnelli: just trying to avoid this awkward upgrade scenario
2912016-06-03T15:40:26  <wumpus> there should be no need to do that ever
2922016-06-03T15:40:48  <jonasschnelli> There is no upgrade scenario right now because we haven't merged anything regarding key-metadata
2932016-06-03T15:40:55  <sipa> jonasschnelli: if we'd design it from scratch, i think wallets would always be encrypted (though perhaps with an option to have an empty key)
2942016-06-03T15:41:03  *** wangchun has quit IRC
2952016-06-03T15:41:09  <jonasschnelli> But I think a 32bit bitmap for key metadata could make sense for a wallet upgrade.
2962016-06-03T15:41:22  <jonasschnelli> Can be use to determin where the key came from, if it's HD generaded, etc.
2972016-06-03T15:41:33  <jonasschnelli> sipa: Good point.
2982016-06-03T15:42:13  <jonasschnelli> Should I take a second attempt use use LogDB for the wallet database?
2992016-06-03T15:42:31  <jonasschnelli> I have factored out logdb as a standalone C library: https://github.com/liblogdb/liblogdb
3002016-06-03T15:42:57  <jonasschnelli> So we could use a simple subset for bitcoin-core (not a subtree, more like 2-3 files like ctaes)
3012016-06-03T15:43:51  <jonasschnelli> I could even add callbacks for the hashing to avoid duplicated sha256 implementation.
3022016-06-03T15:44:54  <wumpus> I agree with sipa. Optionally allowing an empty key would be ok, it would still avoid some file system leaks
3032016-06-03T15:45:45  <jonasschnelli> Right. I also think we should support *full*-wallet-encryption.
3042016-06-03T15:46:04  *** fanquake has joined #bitcoin-core-dev
3052016-06-03T15:46:18  <jonasschnelli> (require unlock of level 1 when staring Bitcoin-Qt/bitcoind)
3062016-06-03T15:46:29  <jonasschnelli> (require unlock for level 2 when signing stuff)
3072016-06-03T15:46:30  <luke-jr> (IMO wallet encryption is mostly a PR stunt from 2011, and we should focus on hardware wallet support.)
3082016-06-03T15:46:40  <jonasschnelli> luke-jr: +1.
3092016-06-03T15:46:49  <gmaxwell> I worry multiple passwords means the user will forget the signing one and not realize there are two.
3102016-06-03T15:46:50  *** fanquake has quit IRC
3112016-06-03T15:46:55  <jonasschnelli> I once started to specify the "detached signing".
3122016-06-03T15:47:08  <jonasschnelli> Sadly there is no standard API for hardware wallets...
3132016-06-03T15:47:08  <gmaxwell> we really don't want to make the data loss worse from wallet encryption, I'd rather have it gone than that.
3142016-06-03T15:47:44  <jonasschnelli> gmaxwell: maybe the data loss is also because we don't offer a clear recovery-process during encryption.
3152016-06-03T15:47:50  <luke-jr> gmaxwell: could we have them be the same, and only cache the decryption key (not the passphrase) at runtime?
3162016-06-03T15:48:00  <jonasschnelli> Like allowing the user to write somthing down or print out a "backup" key or something.
3172016-06-03T15:48:28  <gmaxwell> I suggested an idea a while back that we just define an interface where we fork a process that speaks a bitcoin-core specific protocol to bitcoin... then speaks whatever the wallet needs to speak, and can open up UIs and whatnot.
3182016-06-03T15:48:54  <gmaxwell> e.g.  signhardware=bobpocketwallet-qt.exe
3192016-06-03T15:49:18  <wumpus> I'm not sure about full wallet encryption, you can always store the wallet on an encrypted volume that's likely safer
3202016-06-03T15:49:31  <wumpus> (you can store your other secret files there too.)
3212016-06-03T15:49:32  <jonasschnelli> I was thinking after more torwards TCP/IP httpd interface
3222016-06-03T15:49:51  <wumpus> I doubt the bitcoin wallet metadata is the only metadata you'd want to hide
3232016-06-03T15:49:51  <jonasschnelli> signhardware=http://x:y@127.0.0.1:8888
3242016-06-03T15:50:01  <gmaxwell> wumpus: the model I like is where you use the signing key to derrive an access key (e.g. H(KDF(passphrase)) = viewkey)  and then you simply save the viewkey on disk in a seperate file.
3252016-06-03T15:50:02  <wumpus> yes, support for hardware key storage and signing would be nice
3262016-06-03T15:50:25  <gmaxwell> wumpus: then if you backup/restore (e.g. to the 'cloud') you'll need to enter your passphrase once to unlock.
3272016-06-03T15:50:35  <wumpus> (or "isolated CPU conclave" if that's what you prefer)
3282016-06-03T15:50:44  <gmaxwell> but your backups are still confidential without extra steps.
3292016-06-03T15:50:52  <jonasschnelli> Each hdwallet could offer a tiny daemon (httpd) that listens for requested sign processes and build up a UI once a signing-request comes in.
3302016-06-03T15:50:57  <jl2012> sipa: what's the decision?
3312016-06-03T15:51:02  <jonasschnelli> hdwallet=hardwarewallet
3322016-06-03T15:51:08  <sipa> jl2012: 40 bytes
3332016-06-03T15:51:17  <wumpus> gmaxwell: yes, that is a good idea.
3342016-06-03T15:51:17  <gmaxwell> Yea, on your local meachine metadata privacy is almost totally pointless, your browser cache tells anyone with your computer almost anything you did with the bitcoin wallet.
3352016-06-03T15:51:24  <gmaxwell> but for backup it's useful.
3362016-06-03T15:51:32  <wumpus> two passwords is too much for most people
3372016-06-03T15:51:48  <jonasschnelli> Yes. That's true.
3382016-06-03T15:51:57  <jl2012> Ok, will do it tomorrow
3392016-06-03T15:52:17  <jonasschnelli> Maybe encrypting the disk is the way to go.
3402016-06-03T15:52:19  <wumpus> well the wallet encryption is for local security I suppose. Backups you'd certainly want fully encrypted, I agree
3412016-06-03T15:52:28  <wumpus> OTOH that doesn't need to be wallet.dat format
3422016-06-03T15:53:01  <gmaxwell> encrypting your disk is a great idea. I've encrypted all my disks since .. uh.. 1998?  WD sent me back an RMA drive with someone elses data... often when a drive fails you can't zeroize it first.. sooo.
3432016-06-03T15:53:37  <gmaxwell> wumpus: thats true, wrt format.
3442016-06-03T15:53:42  <luke-jr> I prefer to encrypt only my sensitive data, so I can un-decrypt it when I step away
3452016-06-03T15:54:09  <wumpus> I encrypt my disks too, except for 'junk' partitions like where I store zillions of copies of the blockchain
3462016-06-03T15:54:38  <jonasschnelli> heh
3472016-06-03T15:54:41  <wumpus> I suppose with a newer CPU with encrypt/decrypt instructions the overhead is so low that you don't really care and just encrypt everything
3482016-06-03T15:54:58  *** erasmospunk has quit IRC
3492016-06-03T15:55:23  <wumpus> (I do always encrypt swap with random key too)
3502016-06-03T15:56:55  <wumpus> in any case, for backups encrypting the full thing makes a lot of sense, certainly for cloud backups
3512016-06-03T15:58:51  <wumpus> dropbox must have a lot of wallet metadata
3522016-06-03T16:01:03  <luke-jr> for backups, definitely want to encrypt the whole thing IMO
3532016-06-03T16:01:53  *** wangchun has joined #bitcoin-core-dev
3542016-06-03T16:05:01  *** BashCo has quit IRC
3552016-06-03T16:06:09  <wumpus> yes
3562016-06-03T16:06:37  <wumpus> I just encrypt my entire backups so such functionality in bitcoind wouldn't help me much, but I guess some people would be helped by it
3572016-06-03T16:08:45  *** frankenmint has joined #bitcoin-core-dev
3582016-06-03T16:11:37  <gmaxwell> encrypting it is also good for metadata preservation, e.g. evenutally we could have some ftp or webdav or whatever kids uses these days, url in the config you could set to push a new backup every time your metadata changes.
3592016-06-03T16:11:54  *** calibre720 has quit IRC
3602016-06-03T16:12:21  <luke-jr> well, hopefully that new BIP metadata storage thing works out..
3612016-06-03T16:13:40  *** frankenmint has quit IRC
3622016-06-03T16:13:55  *** fengling has joined #bitcoin-core-dev
3632016-06-03T16:14:30  <sipa> can't we just store the metadata in a dht cloud blockchain, with rainbow tables for security?
3642016-06-03T16:16:42  <wumpus> and render the rainbow tables in actual rainbow colors in the GUI
3652016-06-03T16:16:46  <wumpus> with dancing unicorns
3662016-06-03T16:18:27  <wumpus> nothing protects your wallet better than distributed colorful random cloud technology
3672016-06-03T16:18:44  *** fengling has quit IRC
3682016-06-03T16:18:47  <sipa> copied from a random github repository
3692016-06-03T16:20:31  <luke-jr> …
3702016-06-03T16:21:24  <gmaxwell> back it up by finding a random pull reqest and then open up a copy against a fork of the origin project with the data added...
3712016-06-03T16:21:31  <gmaxwell> non-zero probablity that they merge it.
3722016-06-03T16:24:13  *** Yv7trNY has quit IRC
3732016-06-03T16:25:53  *** calibre720 has joined #bitcoin-core-dev
3742016-06-03T16:30:33  <sipa> a certain linux thorvalds quote comes to mind
3752016-06-03T16:31:09  *** achow101 has joined #bitcoin-core-dev
3762016-06-03T16:31:59  *** BashCo has joined #bitcoin-core-dev
3772016-06-03T16:33:38  *** molz has quit IRC
3782016-06-03T16:38:02  <sipa> s/linux/linus/
3792016-06-03T16:38:27  * gmaxwell waits for the lastname
3802016-06-03T16:39:25  <sipa> s/lastname/last name/
3812016-06-03T16:42:39  *** Yv7trNY has joined #bitcoin-core-dev
3822016-06-03T16:56:46  <GitHub154> [bitcoin] MarcoFalke opened pull request #8144: [rpc] fundrawtransaction: Fix help text (master...Mf1606-rpcDoc) https://github.com/bitcoin/bitcoin/pull/8144
3832016-06-03T17:02:41  *** Thireus1 has quit IRC
3842016-06-03T17:04:58  *** Yv7trNY has quit IRC
3852016-06-03T17:09:34  *** frankenmint has joined #bitcoin-core-dev
3862016-06-03T17:14:15  *** frankenmint has quit IRC
3872016-06-03T17:15:29  *** fengling has joined #bitcoin-core-dev
3882016-06-03T17:19:44  *** fengling has quit IRC
3892016-06-03T17:26:59  <cfields_> MarcoFalke/wumpus: re: #8133, suggestions for how to fixup the import paths? I used a quick hack for the first one, but since we need another, i'd rather avoid adding more hacks on top
3902016-06-03T17:27:54  <MarcoFalke> Would also help if there was a comment for the hack, so it is easier to understand when looked at later.
3912016-06-03T17:28:08  <MarcoFalke> Did you manage to look at the python issue?
3922016-06-03T17:28:28  <MarcoFalke> I can try to play a bit locally when that's fixed
3932016-06-03T17:29:18  <cfields_> MarcoFalke: yea, it's the same issue that the "a few ugly hacks" commit fixes, just a different place.
3942016-06-03T17:29:43  <cfields_> MarcoFalke: ok, maybe easier if i just apply another ugly hack for now, and you can run cleanup afterwards? :)
3952016-06-03T17:30:08  <MarcoFalke> If I can figure out something better ;)
3962016-06-03T17:30:59  <cfields_> MarcoFalke: the underlying issue is that the scripts in the read-only srcdir need to import a script from the builddir, which is in an unknown location
3972016-06-03T17:31:22  <MarcoFalke> ok
3982016-06-03T17:31:59  <cfields_> the hack fix is to assume we're running from builddir, and add the path of the to-import files relative to pwd before doing the actual import
3992016-06-03T17:36:26  <cfields_> MarcoFalke: aha, wait. we already have the path set in the makefile. The problem is the .pyc lingering around in srcdir
4002016-06-03T17:36:38  <cfields_> (that's why travis passed)
4012016-06-03T17:43:51  <cfields_> ok. since we require python3 now, i don't think that's a problem. looks like it should just be a one-time delete.
4022016-06-03T17:58:49  *** Thireus1 has joined #bitcoin-core-dev
4032016-06-03T18:10:18  *** frankenmint has joined #bitcoin-core-dev
4042016-06-03T18:14:52  *** frankenmint has quit IRC
4052016-06-03T18:15:53  *** TomMc has quit IRC
4062016-06-03T18:16:10  *** fengling has joined #bitcoin-core-dev
4072016-06-03T18:21:04  *** fengling has quit IRC
4082016-06-03T18:23:57  *** laurentmt has joined #bitcoin-core-dev
4092016-06-03T18:26:09  *** Thireus1 has quit IRC
4102016-06-03T18:28:17  *** laurentmt has quit IRC
4112016-06-03T18:32:24  <MarcoFalke> cfields_: I am missing the background but what about adding the rm *pyc to `make clean`?
4122016-06-03T18:32:52  <MarcoFalke> The same pycs need to be removed in the qa folder, I guess
4132016-06-03T18:32:57  <MarcoFalke> (Same error)
4142016-06-03T18:33:07  <cfields_> MarcoFalke: 'make clean' now removes __pycache__, which does just that
4152016-06-03T18:33:59  <cfields_> MarcoFalke: it's just the old python2 .pyc's that are trouble. More specifically, only when the .pyc exists and the .py is in a different path (builddir/srcdir)
4162016-06-03T18:34:47  <MarcoFalke> When I first tried to build out of dir, it told me to do 'make distclean' in the src dir.
4172016-06-03T18:35:21  <cfields_> MarcoFalke: you got another error in qa? tests_config.pyc i'm guessing?
4182016-06-03T18:35:25  <MarcoFalke> So keeping the code to remove pyc's in `make clean` temporarily would make sense
4192016-06-03T18:35:46  <MarcoFalke> jup, test_config
4202016-06-03T18:35:50  <cfields_> MarcoFalke: aha, good point!
4212016-06-03T18:36:16  <cfields_> MarcoFalke: so adding those 2 files to the distclean would solve it in a more obvious way.
4222016-06-03T18:36:43  <MarcoFalke> I guess so
4232016-06-03T18:38:20  <MarcoFalke> Also there is pyc's in qa/rpc-tests/test_framework/ like __init__.pyc
4242016-06-03T18:38:26  <MarcoFalke> I am assuming they don't hurt?
4252016-06-03T18:40:04  <cfields_> MarcoFalke: I believe it's only the ones that don't exist in srcdir (the pre-processed files)
4262016-06-03T18:43:12  <cfields_> MarcoFalke: pushed with that change instead. thanks for the reminder about the forced distclean.
4272016-06-03T18:43:29  <MarcoFalke> testing...
4282016-06-03T18:45:11  <cfields_> MarcoFalke: it might cause the same error for you now, but remember that you're passed the forced distclean. You can do another to simulate.
4292016-06-03T18:47:59  <MarcoFalke> distclean works
4302016-06-03T18:50:19  <cfields_> ok great. thanks for testing!
4312016-06-03T18:55:03  <MarcoFalke> copying rpc-test.py instead of linking would be considred bad practice?
4322016-06-03T18:59:08  *** Naphex has quit IRC
4332016-06-03T19:00:16  <cfields_> MarcoFalke: we could, but I was afraid it'd get confusing.
4342016-06-03T19:17:47  *** fengling has joined #bitcoin-core-dev
4352016-06-03T19:22:44  *** fengling has quit IRC
4362016-06-03T19:32:14  *** Yv7trNY has joined #bitcoin-core-dev
4372016-06-03T19:36:01  *** TomMc has joined #bitcoin-core-dev
4382016-06-03T19:39:50  <sipa> would it help to move roc-test.py to the roc-tests directory?
4392016-06-03T19:45:09  *** Yv7trNY has quit IRC
4402016-06-03T19:48:55  *** Chris_Stewart_5 has quit IRC
4412016-06-03T19:50:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4422016-06-03T19:51:21  *** Thireus1 has joined #bitcoin-core-dev
4432016-06-03T20:19:16  *** fengling has joined #bitcoin-core-dev
4442016-06-03T20:23:34  *** MarcoFalke has quit IRC
4452016-06-03T20:24:04  *** fengling has quit IRC
4462016-06-03T20:27:28  *** Chris_Stewart_5 has quit IRC
4472016-06-03T20:35:18  *** limpkin_ is now known as limpkin
4482016-06-03T20:43:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4492016-06-03T20:48:35  *** jujumax_ has joined #bitcoin-core-dev
4502016-06-03T20:51:14  *** Guyver2 has joined #bitcoin-core-dev
4512016-06-03T21:11:30  *** jujumax_ has quit IRC
4522016-06-03T21:13:19  *** laurentmt has joined #bitcoin-core-dev
4532016-06-03T21:19:51  *** laurentmt has quit IRC
4542016-06-03T21:20:50  *** fengling has joined #bitcoin-core-dev
4552016-06-03T21:21:22  *** cryptapus is now known as cryptapus_afk
4562016-06-03T21:24:26  *** jannes has quit IRC
4572016-06-03T21:24:43  *** Thireus1 has quit IRC
4582016-06-03T21:25:44  *** fengling has quit IRC
4592016-06-03T21:32:35  * luke-jr doing some rather extensive testing with 8133 FWIW
4602016-06-03T21:43:01  *** Chris_Stewart_5 has quit IRC
4612016-06-03T21:43:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4622016-06-03T21:49:09  *** ozanyurt has quit IRC
4632016-06-03T21:55:36  *** Chris_Stewart_5 has quit IRC
4642016-06-03T22:06:59  *** frankenmint has joined #bitcoin-core-dev
4652016-06-03T22:12:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4662016-06-03T22:12:31  *** frankenmint has quit IRC
4672016-06-03T22:22:25  *** fengling has joined #bitcoin-core-dev
4682016-06-03T22:27:04  *** fengling has quit IRC
4692016-06-03T22:44:05  *** AaronvanW has quit IRC
4702016-06-03T22:51:50  *** TomMc has quit IRC
4712016-06-03T23:05:28  *** TomMc has joined #bitcoin-core-dev
4722016-06-03T23:06:44  *** murch has quit IRC
4732016-06-03T23:12:40  *** moli has joined #bitcoin-core-dev
4742016-06-03T23:23:53  *** fengling has joined #bitcoin-core-dev
4752016-06-03T23:28:24  *** fengling has quit IRC
4762016-06-03T23:37:55  *** TomMc has quit IRC
4772016-06-03T23:46:07  *** Guyver2 has quit IRC
4782016-06-03T23:53:16  *** ibrightly has quit IRC
4792016-06-03T23:55:43  *** ibrightly has joined #bitcoin-core-dev
4802016-06-03T23:57:28  *** AaronvanW has joined #bitcoin-core-dev