1 2016-06-07T00:11:28  *** AaronvanW has joined #bitcoin-core-dev
  2 2016-06-07T00:15:36  *** Giszmo has joined #bitcoin-core-dev
  3 2016-06-07T00:19:10  *** CubicEarth has joined #bitcoin-core-dev
  4 2016-06-07T00:21:16  *** Ylbam has quit IRC
  5 2016-06-07T00:21:34  *** molz has joined #bitcoin-core-dev
  6 2016-06-07T00:24:45  *** molly has quit IRC
  7 2016-06-07T00:25:05  *** belcher has joined #bitcoin-core-dev
  8 2016-06-07T00:28:52  *** CubicEarth has quit IRC
  9 2016-06-07T00:42:57  <GitHub8> [bitcoin] tatobg opened pull request #8155: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/8155
 10 2016-06-07T00:43:39  <GitHub28> [bitcoin] sipa closed pull request #8155: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/8155
 11 2016-06-07T00:50:56  *** Arnavion has quit IRC
 12 2016-06-07T00:51:00  *** Arnavion3 has joined #bitcoin-core-dev
 13 2016-06-07T00:51:04  *** Arnavion3 is now known as Arnavion
 14 2016-06-07T00:57:33  *** afk11 has quit IRC
 15 2016-06-07T00:59:24  *** CubicEarth has joined #bitcoin-core-dev
 16 2016-06-07T01:00:55  *** frankenmint has quit IRC
 17 2016-06-07T01:03:07  *** afk11 has joined #bitcoin-core-dev
 18 2016-06-07T01:03:07  *** afk11 has quit IRC
 19 2016-06-07T01:03:07  *** afk11 has joined #bitcoin-core-dev
 20 2016-06-07T01:06:48  *** supasonic has quit IRC
 21 2016-06-07T01:07:38  *** luke-jr has joined #bitcoin-core-dev
 22 2016-06-07T01:09:07  *** CubicEarth has quit IRC
 23 2016-06-07T01:33:04  *** supasonic has joined #bitcoin-core-dev
 24 2016-06-07T01:35:10  *** dermoth has quit IRC
 25 2016-06-07T01:38:12  *** dermoth has joined #bitcoin-core-dev
 26 2016-06-07T01:40:11  *** CubicEarth has joined #bitcoin-core-dev
 27 2016-06-07T02:01:47  *** frankenmint has joined #bitcoin-core-dev
 28 2016-06-07T02:05:08  *** fengling has joined #bitcoin-core-dev
 29 2016-06-07T02:07:16  *** frankenmint has quit IRC
 30 2016-06-07T02:09:59  *** jarret has joined #bitcoin-core-dev
 31 2016-06-07T02:12:32  *** adiabat has joined #bitcoin-core-dev
 32 2016-06-07T02:12:58  *** frankenmint has joined #bitcoin-core-dev
 33 2016-06-07T02:18:23  *** nets1n has quit IRC
 34 2016-06-07T02:18:39  *** xiangfu has joined #bitcoin-core-dev
 35 2016-06-07T02:29:54  *** belcher has quit IRC
 36 2016-06-07T02:40:39  *** raedah has quit IRC
 37 2016-06-07T02:41:43  *** raedah has joined #bitcoin-core-dev
 38 2016-06-07T02:43:33  *** supasonic has quit IRC
 39 2016-06-07T02:53:33  *** nets1n has joined #bitcoin-core-dev
 40 2016-06-07T03:01:48  *** ryanrobertson21 has joined #bitcoin-core-dev
 41 2016-06-07T03:02:45  *** ryanrobertson21 has left #bitcoin-core-dev
 42 2016-06-07T03:03:29  *** masterroshi has joined #bitcoin-core-dev
 43 2016-06-07T03:08:30  *** xiangfu has quit IRC
 44 2016-06-07T03:09:52  *** xiangfu has joined #bitcoin-core-dev
 45 2016-06-07T03:20:01  *** Giszmo has quit IRC
 46 2016-06-07T03:21:13  *** Giszmo has joined #bitcoin-core-dev
 47 2016-06-07T03:24:27  *** achow101 has quit IRC
 48 2016-06-07T03:30:31  *** frankenmint has quit IRC
 49 2016-06-07T03:31:26  *** masterroshi has quit IRC
 50 2016-06-07T03:39:42  *** frankenmint has joined #bitcoin-core-dev
 51 2016-06-07T04:14:01  *** Alopex has quit IRC
 52 2016-06-07T04:15:06  *** Alopex has joined #bitcoin-core-dev
 53 2016-06-07T04:17:33  *** grassass has joined #bitcoin-core-dev
 54 2016-06-07T04:20:07  *** nets1n has quit IRC
 55 2016-06-07T04:20:32  *** xiangfu has quit IRC
 56 2016-06-07T04:21:04  *** jiggalator has joined #bitcoin-core-dev
 57 2016-06-07T04:33:02  *** Alopex has quit IRC
 58 2016-06-07T04:34:07  *** Alopex has joined #bitcoin-core-dev
 59 2016-06-07T04:39:47  *** supasonic has joined #bitcoin-core-dev
 60 2016-06-07T04:46:38  *** CubicEarth has quit IRC
 61 2016-06-07T04:47:11  *** CubicEarth has joined #bitcoin-core-dev
 62 2016-06-07T04:47:38  *** CubicEarth has quit IRC
 63 2016-06-07T04:48:07  *** CubicEarth has joined #bitcoin-core-dev
 64 2016-06-07T04:50:28  *** CubicEarth has quit IRC
 65 2016-06-07T04:50:30  *** CubicEar_ has joined #bitcoin-core-dev
 66 2016-06-07T04:51:39  *** CubicEarth has joined #bitcoin-core-dev
 67 2016-06-07T04:57:43  *** blur3d has joined #bitcoin-core-dev
 68 2016-06-07T05:11:54  *** paveljanik has quit IRC
 69 2016-06-07T05:21:37  *** frankenmint has quit IRC
 70 2016-06-07T05:28:53  *** frankenmint has joined #bitcoin-core-dev
 71 2016-06-07T05:41:39  *** Ylbam has joined #bitcoin-core-dev
 72 2016-06-07T06:01:20  *** xiangfu has joined #bitcoin-core-dev
 73 2016-06-07T06:03:54  *** BashCo has quit IRC
 74 2016-06-07T06:04:34  *** Evel-Knievel has joined #bitcoin-core-dev
 75 2016-06-07T06:07:01  *** Ylbam has quit IRC
 76 2016-06-07T06:07:10  *** jl2012 has quit IRC
 77 2016-06-07T06:08:24  *** Ylbam has joined #bitcoin-core-dev
 78 2016-06-07T06:08:30  *** jl2012 has joined #bitcoin-core-dev
 79 2016-06-07T06:15:22  *** shesek has joined #bitcoin-core-dev
 80 2016-06-07T06:18:28  *** xiangfu has quit IRC
 81 2016-06-07T06:28:57  *** blur3d has quit IRC
 82 2016-06-07T06:30:18  *** BashCo has joined #bitcoin-core-dev
 83 2016-06-07T06:31:53  *** frankenmint has quit IRC
 84 2016-06-07T06:36:34  *** jtimon has quit IRC
 85 2016-06-07T06:40:17  *** frankenmint has joined #bitcoin-core-dev
 86 2016-06-07T06:42:26  *** frankenmint has quit IRC
 87 2016-06-07T06:56:05  *** Giszmo has quit IRC
 88 2016-06-07T06:59:06  <GitHub25> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/52c3f348bec3...cfc6da0b1b81
 89 2016-06-07T06:59:06  <GitHub25> bitcoin/master fa51a1d MarcoFalke: [init] Make feefilter option debug option
 90 2016-06-07T06:59:07  <GitHub25> bitcoin/master cfc6da0 Wladimir J. van der Laan: Merge #8151: [init] Make feefilter option debug option...
 91 2016-06-07T06:59:17  <GitHub52> [bitcoin] laanwj closed pull request #8151: [init] Make feefilter option debug option (master...Mf1606-feefilterDebug) https://github.com/bitcoin/bitcoin/pull/8151
 92 2016-06-07T07:31:03  *** CubicEarth has quit IRC
 93 2016-06-07T07:31:16  *** CubicEarth has joined #bitcoin-core-dev
 94 2016-06-07T07:31:54  *** CubicEarth has joined #bitcoin-core-dev
 95 2016-06-07T07:34:04  *** CubicEarth has quit IRC
 96 2016-06-07T07:34:37  *** CubicEarth has joined #bitcoin-core-dev
 97 2016-06-07T07:36:11  *** CubicEarth has joined #bitcoin-core-dev
 98 2016-06-07T07:37:45  *** CubicEar_ has joined #bitcoin-core-dev
 99 2016-06-07T07:37:45  *** CubicEarth has quit IRC
100 2016-06-07T07:45:38  *** CubicEar_ has quit IRC
101 2016-06-07T07:45:54  *** CubicEarth has joined #bitcoin-core-dev
102 2016-06-07T07:48:41  *** CubicEarth has quit IRC
103 2016-06-07T07:49:09  *** CubicEarth has joined #bitcoin-core-dev
104 2016-06-07T07:54:35  *** CubicEarth has quit IRC
105 2016-06-07T07:55:01  *** CubicEarth has joined #bitcoin-core-dev
106 2016-06-07T07:56:02  *** ghtdak has quit IRC
107 2016-06-07T07:57:17  *** ghtdak has joined #bitcoin-core-dev
108 2016-06-07T07:57:41  *** droark has quit IRC
109 2016-06-07T08:04:00  *** MarcoFalke has joined #bitcoin-core-dev
110 2016-06-07T08:04:51  *** jannes has joined #bitcoin-core-dev
111 2016-06-07T08:07:13  *** CubicEar_ has joined #bitcoin-core-dev
112 2016-06-07T08:08:09  *** CubicEarth has quit IRC
113 2016-06-07T08:08:20  *** adiabat has quit IRC
114 2016-06-07T08:10:23  *** kadoban has quit IRC
115 2016-06-07T08:11:14  *** jiggalator has quit IRC
116 2016-06-07T08:12:53  *** jiggalator has joined #bitcoin-core-dev
117 2016-06-07T08:34:26  *** supasonic has quit IRC
118 2016-06-07T08:36:22  *** frankenmint has joined #bitcoin-core-dev
119 2016-06-07T08:44:37  *** jiggalator has quit IRC
120 2016-06-07T08:53:30  *** PatBoy has quit IRC
121 2016-06-07T08:54:02  *** PatBoy has joined #bitcoin-core-dev
122 2016-06-07T09:18:27  <GitHub147> [bitcoin] jpdffonseca opened pull request #8158: Simplify calls to retrieve credit and balance (master...enhancement/unification-wallet-balance) https://github.com/bitcoin/bitcoin/pull/8158
123 2016-06-07T09:45:46  *** jiggalator has joined #bitcoin-core-dev
124 2016-06-07T09:48:00  <MarcoFalke> jonasschnelli: VNULL is already a valid type
125 2016-06-07T09:48:32  <MarcoFalke> Let's not change its meaning to VANY just for checkObj
126 2016-06-07T09:49:19  <MarcoFalke> I could change it to a cpp union but it will still be a wrapper, I assume
127 2016-06-07T09:49:45  <jonasschnelli> MarcoFalke: yes. Fair enought...
128 2016-06-07T09:50:07  *** jiggalator has quit IRC
129 2016-06-07T10:00:20  *** ozanyurt has quit IRC
130 2016-06-07T10:00:26  *** ozanyurt_ has joined #bitcoin-core-dev
131 2016-06-07T10:02:07  *** molz has quit IRC
132 2016-06-07T10:02:28  *** molz has joined #bitcoin-core-dev
133 2016-06-07T10:09:30  *** Ginnarr has joined #bitcoin-core-dev
134 2016-06-07T10:10:39  *** molly has joined #bitcoin-core-dev
135 2016-06-07T10:13:41  *** molz has quit IRC
136 2016-06-07T10:15:50  *** CubicEar_ has quit IRC
137 2016-06-07T10:16:20  *** CubicEarth has joined #bitcoin-core-dev
138 2016-06-07T10:17:41  *** G1lius has joined #bitcoin-core-dev
139 2016-06-07T10:22:47  *** Amnez777 has quit IRC
140 2016-06-07T10:26:32  *** Amnez777 has joined #bitcoin-core-dev
141 2016-06-07T10:29:36  *** CubicEarth has quit IRC
142 2016-06-07T10:46:41  *** jiggalator has joined #bitcoin-core-dev
143 2016-06-07T10:52:01  *** jiggalator has quit IRC
144 2016-06-07T11:19:19  *** Samdney has joined #bitcoin-core-dev
145 2016-06-07T11:20:44  *** fengling has quit IRC
146 2016-06-07T11:24:53  *** Ginnarr has quit IRC
147 2016-06-07T11:37:18  *** molly is now known as moli
148 2016-06-07T11:38:35  *** cryptapus has joined #bitcoin-core-dev
149 2016-06-07T11:38:35  *** cryptapus has joined #bitcoin-core-dev
150 2016-06-07T11:48:28  *** jiggalator has joined #bitcoin-core-dev
151 2016-06-07T11:52:39  *** jiggalator has quit IRC
152 2016-06-07T11:55:44  *** rubensayshi has joined #bitcoin-core-dev
153 2016-06-07T12:35:00  <GitHub9> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cfc6da0b1b81...9b6a48c2e996
154 2016-06-07T12:35:00  <GitHub9> bitcoin/master bd0f413 Jonas Nick: Reduce unnecessary hashing in signrawtransaction
155 2016-06-07T12:35:01  <GitHub9> bitcoin/master 9b6a48c Wladimir J. van der Laan: Merge #8118: Reduce unnecessary hashing in signrawtransaction...
156 2016-06-07T12:35:12  <GitHub145> [bitcoin] laanwj closed pull request #8118: Reduce unnecessary hashing in signrawtransaction (master...faster-signraw) https://github.com/bitcoin/bitcoin/pull/8118
157 2016-06-07T12:49:15  *** jiggalator has joined #bitcoin-core-dev
158 2016-06-07T12:53:52  *** jiggalator has quit IRC
159 2016-06-07T13:05:37  *** jtimon has joined #bitcoin-core-dev
160 2016-06-07T13:06:08  *** Samdney has left #bitcoin-core-dev
161 2016-06-07T13:07:46  *** achow101 has joined #bitcoin-core-dev
162 2016-06-07T13:26:01  <GitHub75> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b6a48c2e996...22e0b3567623
163 2016-06-07T13:26:01  <GitHub75> bitcoin/master 8b78486 Jonas Schnelli: Log/report in 10% steps during VerifyDB
164 2016-06-07T13:26:02  <GitHub75> bitcoin/master 22e0b35 Wladimir J. van der Laan: Merge #8136: Log/report in 10% steps during VerifyDB...
165 2016-06-07T13:26:11  <GitHub153> [bitcoin] laanwj closed pull request #8136: Log/report in 10% steps during VerifyDB (master...2016/06/init_checkblocks) https://github.com/bitcoin/bitcoin/pull/8136
166 2016-06-07T13:27:07  *** grassass has quit IRC
167 2016-06-07T13:31:41  *** paveljanik has joined #bitcoin-core-dev
168 2016-06-07T13:40:49  <GitHub104> [bitcoin] jmcorgan reopened pull request #8148: Backport leveldb build integration to 0.12 (0.12...0.12) https://github.com/bitcoin/bitcoin/pull/8148
169 2016-06-07T13:40:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
170 2016-06-07T13:42:25  *** grassass has joined #bitcoin-core-dev
171 2016-06-07T13:50:00  *** jiggalator has joined #bitcoin-core-dev
172 2016-06-07T13:50:23  <GitHub146> [bitcoin] iblis17 opened pull request #8159: PR demo (master...iblis-demo) https://github.com/bitcoin/bitcoin/pull/8159
173 2016-06-07T13:50:33  <GitHub50> [bitcoin] iblis17 closed pull request #8159: PR demo (master...iblis-demo) https://github.com/bitcoin/bitcoin/pull/8159
174 2016-06-07T13:53:42  *** Guyver2 has joined #bitcoin-core-dev
175 2016-06-07T13:55:08  *** jiggalator has quit IRC
176 2016-06-07T13:57:06  <sipa> wumpus: what do you think about including arm-linux-gnueabihf binaries in the distribution?
177 2016-06-07T13:59:41  <wumpus> sipa: yes we should definitely have ARMHF and ARM64 binary tarballs
178 2016-06-07T14:00:27  <wumpus> there was a pull doing this, but it was closed at some point (because it was the wrong way to do it) and no one picked it up
179 2016-06-07T14:01:36  <wumpus> hm I can't find it, may have been confused with something else, in any case it'd be welcome
180 2016-06-07T14:03:05  <wumpus> ah https://github.com/bitcoin/bitcoin/pull/7659
181 2016-06-07T14:21:02  <wumpus> created an issue for ithttps://github.com/bitcoin/bitcoin/issues/8162
182 2016-06-07T14:29:10  *** zooko has joined #bitcoin-core-dev
183 2016-06-07T14:31:16  *** Giszmo has joined #bitcoin-core-dev
184 2016-06-07T14:32:58  <jonasschnelli> wumpus: mind taking a look at https://github.com/bitcoin/bitcoin/pull/7957? Would be nice to have this merged. Simplifies RBF testing. :)
185 2016-06-07T14:39:43  *** frankenmint has quit IRC
186 2016-06-07T14:40:10  <wumpus> sure
187 2016-06-07T14:44:11  *** zooko has quit IRC
188 2016-06-07T14:45:10  <wumpus> jonasschnelli: should there be a test in src/test/data/bitcoin-util-test.json for the new -tx behavior?
189 2016-06-07T14:45:38  <jonasschnelli> wumpus: wasn't aware of a test script bit bitcoin-tx... i'll have a look
190 2016-06-07T14:46:11  <wumpus> yes not many people realize that :) it gets executed with `make test`
191 2016-06-07T14:46:15  <wumpus> eh make check
192 2016-06-07T14:46:30  <wumpus> by bitcoin-util-test.py
193 2016-06-07T14:46:37  <sipa> but only make check in the root, not make check in src/
194 2016-06-07T14:50:15  <sipa> i'd like to see some review on #8084 and #8065
195 2016-06-07T14:50:44  *** jiggalator has joined #bitcoin-core-dev
196 2016-06-07T14:50:44  <sipa> #8065 should be easy to test by monitoring fails added to addrman, and disconnecting your network cable
197 2016-06-07T14:50:57  *** zooko has joined #bitcoin-core-dev
198 2016-06-07T14:55:27  *** raedah has quit IRC
199 2016-06-07T14:55:40  *** jiggalator has quit IRC
200 2016-06-07T14:57:03  *** raedah has joined #bitcoin-core-dev
201 2016-06-07T15:03:18  *** cryptapus has quit IRC
202 2016-06-07T15:06:49  *** cryptapus has joined #bitcoin-core-dev
203 2016-06-07T15:07:37  *** jiggalator has joined #bitcoin-core-dev
204 2016-06-07T15:11:04  *** BashCo has quit IRC
205 2016-06-07T15:16:40  *** zooko has quit IRC
206 2016-06-07T15:18:41  *** jiggalator has quit IRC
207 2016-06-07T15:18:57  *** G1lius has quit IRC
208 2016-06-07T15:30:21  *** ozanyurt_ has quit IRC
209 2016-06-07T15:30:31  *** ozanyurt has joined #bitcoin-core-dev
210 2016-06-07T15:33:57  *** CubicEarth has joined #bitcoin-core-dev
211 2016-06-07T15:35:37  *** BashCo has joined #bitcoin-core-dev
212 2016-06-07T15:40:21  *** CubicEarth has quit IRC
213 2016-06-07T15:40:34  *** frankenmint has joined #bitcoin-core-dev
214 2016-06-07T15:44:56  *** frankenmint has quit IRC
215 2016-06-07T15:48:51  *** Guest26338 has quit IRC
216 2016-06-07T15:55:26  *** molz has joined #bitcoin-core-dev
217 2016-06-07T15:58:03  <jonasschnelli> sipa: was the seeder flag check correct (if (id >= 0 && (idToInfo[id].services & requestedFlags) == requestedFlags) {)?
218 2016-06-07T15:58:04  *** moli has quit IRC
219 2016-06-07T15:58:11  <jonasschnelli> https://github.com/sipa/bitcoin-seeder/pull/36#discussion_r65778140
220 2016-06-07T15:58:17  <jonasschnelli> haven't double checked
221 2016-06-07T15:59:50  <sipa> jonasschnelli: no, i don't understand why it can be correct
222 2016-06-07T15:59:55  <sipa> i'm fixing it now
223 2016-06-07T16:00:02  <sipa> (but maybe i'm missing something)
224 2016-06-07T16:00:10  <sipa> so feel free to explain why you think it is
225 2016-06-07T16:00:25  *** MarcoFalke has quit IRC
226 2016-06-07T16:04:05  <paveljanik> jonasschnelli, wumpus: in src/rpc, we shadow global tableRPC by the same-named argument to all Register*RPCCommands(CRPCTable &table). Before changing all names (by adding underscore), do we really want to pass the global in and then shadow it by the same named argument? What about removing the argument instead?
227 2016-06-07T16:04:46  <sipa> how about renaming the global? :)
228 2016-06-07T16:05:24  <paveljanik> there are millions of use of it outside the register part...
229 2016-06-07T16:06:16  <sipa> well, in an ideal world there would not be a global (or at least not one that's commonly used)
230 2016-06-07T16:06:54  <jonasschnelli> sipa: right. It should be the same like this line: https://github.com/sipa/bitcoin-seeder/pull/36/files#diff-623e3fd6da1a45222eeec71496747b31R185
231 2016-06-07T16:07:14  <jonasschnelli> Tell me if you want me to PR
232 2016-06-07T16:07:20  <sipa> i'll do it
233 2016-06-07T16:07:30  <jonasschnelli> thanks!
234 2016-06-07T16:09:05  <paveljanik> sipa, I prefer to rename argument names
235 2016-06-07T16:09:13  <sipa> paveljanik: ok
236 2016-06-07T16:09:28  <paveljanik> to e.g. t ;-)
237 2016-06-07T16:09:34  <paveljanik> to save a lot of bytes ;-)
238 2016-06-07T16:12:37  <sipa> paveljanik: an alternative is making the tableRPC global static (and not exposed from rpc/server.cpp), and instead add a function that just calls tableRPC.appendCommand
239 2016-06-07T16:12:51  <sipa> it's not shadowing if the global isn't visible
240 2016-06-07T16:13:46  <paveljanik> this can't work: qt/rpcconsole.cpp:        UniValue result = tableRPC.execute(
241 2016-06-07T16:14:01  <sipa> ok, a wrapper for that too :)
242 2016-06-07T16:14:55  <paveljanik> and now clang-fu it ;-)
243 2016-06-07T16:16:59  <wumpus> sipa: well the idea is to make it possible to have multiple rpc tables
244 2016-06-07T16:17:17  <wumpus> sipa: that's why tablerpc is an argument to Register* in the first place
245 2016-06-07T16:17:35  <paveljanik> yes
246 2016-06-07T16:17:37  <wumpus> this makes it possible to have multiple RPC entry points, at some point
247 2016-06-07T16:17:46  <jonasschnelli> Yes. The idea of the register is to avoid a superglobal dispatch table.
248 2016-06-07T16:17:48  <wumpus> probably it shouldn't be a global though
249 2016-06-07T16:17:55  <wumpus> agree with that
250 2016-06-07T16:18:00  <wumpus> but please don't hardcode tablerpc
251 2016-06-07T16:18:10  <jonasschnelli> The table itself should be a rpc-server object.
252 2016-06-07T16:18:25  <jonasschnelli> Modules should "register" callbacks.
253 2016-06-07T16:18:36  <paveljanik> I'm most inclned to rename arguments to t...
254 2016-06-07T16:19:09  <wumpus> in any case, let's not entangle this with the refactor to remove shadowing
255 2016-06-07T16:19:27  <sipa> paveljanik: whatever is easiest
256 2016-06-07T16:19:35  <sipa> indeed, they're orthogonal improvements
257 2016-06-07T16:20:11  *** adiabat has joined #bitcoin-core-dev
258 2016-06-07T16:20:12  <paveljanik> sure
259 2016-06-07T16:20:13  <paveljanik> will do
260 2016-06-07T16:20:20  <paveljanik> this as one PR.
261 2016-06-07T16:21:40  *** kadoban has joined #bitcoin-core-dev
262 2016-06-07T16:25:43  <GitHub19> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/22e0b3567623...79004d4ae671
263 2016-06-07T16:25:44  <GitHub19> bitcoin/master a946bb6 Jonas Schnelli: [RPC] createrawtransaction: add option to set the sequence number per input
264 2016-06-07T16:25:44  <GitHub19> bitcoin/master e59336f Jonas Schnelli: [bitcoin-tx] allow to set nSequence number over the in= command
265 2016-06-07T16:25:45  <GitHub19> bitcoin/master ae357d5 Jonas Schnelli: [Bitcoin-Tx] Add tests for sequence number support
266 2016-06-07T16:25:48  <GitHub140> [bitcoin] laanwj closed pull request #7957: [RPC][Bitcoin-TX] Add support for sequence number (master...2016/04/rbf_base) https://github.com/bitcoin/bitcoin/pull/7957
267 2016-06-07T16:26:24  *** zooko has joined #bitcoin-core-dev
268 2016-06-07T16:27:53  *** bsm1175321 has joined #bitcoin-core-dev
269 2016-06-07T16:40:51  *** supasonic has joined #bitcoin-core-dev
270 2016-06-07T16:41:18  *** frankenmint has joined #bitcoin-core-dev
271 2016-06-07T16:46:49  *** frankenmint has quit IRC
272 2016-06-07T16:52:47  <GitHub110> [bitcoin] paveljanik opened pull request #8163: Do not shadow global RPC table variable (tableRPC) (master...20160607_shadowing_rpc) https://github.com/bitcoin/bitcoin/pull/8163
273 2016-06-07T16:54:39  <sipa> jonasschnelli: https://github.com/sipa/bitcoin-seeder/pull/40/files
274 2016-06-07T16:55:29  <jonasschnelli> sipa: should we not provide a default whitelist?
275 2016-06-07T16:55:38  <sipa> jonasschnelli: there is one
276 2016-06-07T16:55:44  <jonasschnelli> Ah.. right
277 2016-06-07T16:55:45  <sipa> line 148
278 2016-06-07T16:55:59  <jonasschnelli> 1,5,9,13... hmm..
279 2016-06-07T16:56:37  <sipa> also, servicebits were already printed in dnsseed.dump
280 2016-06-07T16:56:50  <jonasschnelli> You don't want to add NODE_GETUTXO to the WL?
281 2016-06-07T16:56:55  <sipa> no
282 2016-06-07T16:57:11  <jonasschnelli> Okay. Right. Not by default.
283 2016-06-07T16:57:14  <sipa> you can enable it if you need it
284 2016-06-07T16:58:19  <jonasschnelli> ack
285 2016-06-07T17:00:49  *** Giszmo has quit IRC
286 2016-06-07T17:06:20  *** zooko has quit IRC
287 2016-06-07T17:07:49  *** gevs has quit IRC
288 2016-06-07T17:09:16  *** laurentmt has joined #bitcoin-core-dev
289 2016-06-07T17:18:01  *** Chris_Stewart_5 has quit IRC
290 2016-06-07T17:19:33  *** Giszmo has joined #bitcoin-core-dev
291 2016-06-07T17:21:20  *** gevs has joined #bitcoin-core-dev
292 2016-06-07T17:22:33  *** jiggalator has joined #bitcoin-core-dev
293 2016-06-07T17:31:04  *** cryptapus has quit IRC
294 2016-06-07T17:34:12  *** jiggalator has quit IRC
295 2016-06-07T17:35:05  *** laurentmt has quit IRC
296 2016-06-07T17:37:30  *** CubicEarth has joined #bitcoin-core-dev
297 2016-06-07T17:39:48  *** CubicEarth has quit IRC
298 2016-06-07T17:40:03  *** CubicEarth has joined #bitcoin-core-dev
299 2016-06-07T17:42:58  *** jiggalator has joined #bitcoin-core-dev
300 2016-06-07T17:43:18  *** jiggalator has quit IRC
301 2016-06-07T17:43:28  *** frankenmint has joined #bitcoin-core-dev
302 2016-06-07T17:44:05  *** cryptapus has joined #bitcoin-core-dev
303 2016-06-07T17:48:28  *** frankenmint has quit IRC
304 2016-06-07T17:53:35  *** CubicEarth has quit IRC
305 2016-06-07T17:56:09  *** CubicEarth has joined #bitcoin-core-dev
306 2016-06-07T18:02:02  <GitHub40> [bitcoin] jonasschnelli opened pull request #8164: [Tests] fix missing test fixtures in Makefile.test.include (master...2016/04/rbf_base) https://github.com/bitcoin/bitcoin/pull/8164
307 2016-06-07T18:02:06  <jonasschnelli> Travis is currently failing.
308 2016-06-07T18:02:11  <jonasschnelli> Was my fault... sorry.
309 2016-06-07T18:02:15  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/8164 should fix it.
310 2016-06-07T18:11:33  *** cryptapus has quit IRC
311 2016-06-07T18:13:52  *** CubicEarth has quit IRC
312 2016-06-07T18:18:36  *** supasonic has quit IRC
313 2016-06-07T18:20:10  *** cryptapus has joined #bitcoin-core-dev
314 2016-06-07T18:20:10  *** cryptapus has joined #bitcoin-core-dev
315 2016-06-07T18:22:36  *** CubicEarth has joined #bitcoin-core-dev
316 2016-06-07T18:24:58  *** cryptapus_ has joined #bitcoin-core-dev
317 2016-06-07T18:25:31  *** cryptapus has quit IRC
318 2016-06-07T18:27:06  *** cryptapus__ has joined #bitcoin-core-dev
319 2016-06-07T18:31:40  *** cryptapus_ has quit IRC
320 2016-06-07T18:32:21  *** CubicEarth has quit IRC
321 2016-06-07T18:32:47  *** cryptapus__ is now known as cryptapus
322 2016-06-07T18:48:13  *** CubicEarth has joined #bitcoin-core-dev
323 2016-06-07T18:51:45  <jonasschnelli> Hmm.. is this not 32bit save? uint32_t nSequenceIn=std::numeric_limits<unsigned int>::max();
324 2016-06-07T18:52:06  <jonasschnelli> https://travis-ci.org/bitcoin/bitcoin/jobs/135941357#L1909
325 2016-06-07T18:52:14  <jonasschnelli> (seems to fail on travis 32bit)
326 2016-06-07T18:52:21  * jonasschnelli is booting up 32bit linux
327 2016-06-07T18:55:27  <jonasschnelli> Ah.. i'm using atoi() for uint32_t,... not good.
328 2016-06-07T18:55:49  <sipa> on all our supported platforms int is 32 bit
329 2016-06-07T18:57:43  <jonasschnelli> sipa: Yes. But I guess atoi() throws away the unsigned? Does always use signed int IMO.
330 2016-06-07T18:58:02  <jonasschnelli> Trying now with std::stoul()
331 2016-06-07T19:02:33  *** mr_burdell has quit IRC
332 2016-06-07T19:05:02  *** Danco_ has joined #bitcoin-core-dev
333 2016-06-07T19:05:18  *** mr_burdell has joined #bitcoin-core-dev
334 2016-06-07T19:05:31  <Danco_> Hello may i make a GPU question here?
335 2016-06-07T19:06:02  <jonasschnelli> Danco_: depends if its bitcoin-core-dev relevant... but shoot!
336 2016-06-07T19:06:17  <Danco_>  Hello, i have a hardware  question about my GPU capacita, I have an AMD 4870x2, and i want to know how many Mhash/s could i make with it. I found in this link: https://en.bitcoin.it/wiki/Non-specialized_hardware_comparison its  between 180.6 and 203 Mhash... But i'm not quite sure,  But in this link : https://litecoin.info/Mining_hardware_comparison#AMD_.28ATI.29 its just 142kH/s, so i'm pretty confused.
337 2016-06-07T19:06:21  <Danco_> There it is
338 2016-06-07T19:06:46  <jonasschnelli> I guess the only way is by trying it yourself. :)
339 2016-06-07T19:06:59  <jonasschnelli> But GPU mining is history? right?
340 2016-06-07T19:07:15  <jonasschnelli> (at least on the bitcoin blockchain)
341 2016-06-07T19:07:20  <Danco_> For Litecoin is still useful.
342 2016-06-07T19:08:00  <btcdrak> Danco_: it's probably a question for #bitcoin-dev or #bitcoin. this channel is specifically for Bitcoin Core development.
343 2016-06-07T19:08:46  <Danco_> Ok ok i'll make it there :D thanks.
344 2016-06-07T19:08:49  *** Danco_ has left #bitcoin-core-dev
345 2016-06-07T19:20:24  *** CubicEarth has quit IRC
346 2016-06-07T19:21:44  *** jannes has quit IRC
347 2016-06-07T19:25:31  <GitHub70> [bitcoin] paveljanik opened pull request #8166: src/test: Do not shadow local variables (master...20160607_shadowing_tests) https://github.com/bitcoin/bitcoin/pull/8166
348 2016-06-07T19:25:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
349 2016-06-07T19:26:18  *** CubicEarth has joined #bitcoin-core-dev
350 2016-06-07T19:31:56  *** adiabat has quit IRC
351 2016-06-07T19:32:33  *** adiabat has joined #bitcoin-core-dev
352 2016-06-07T19:36:50  *** CubicEarth has quit IRC
353 2016-06-07T19:42:07  *** jiggalator has joined #bitcoin-core-dev
354 2016-06-07T19:59:08  *** CubicEarth has joined #bitcoin-core-dev
355 2016-06-07T20:02:00  *** jiggalator has quit IRC
356 2016-06-07T20:02:47  *** jiggalator has joined #bitcoin-core-dev
357 2016-06-07T20:14:20  *** jiggalator has quit IRC
358 2016-06-07T20:14:42  *** molz has quit IRC
359 2016-06-07T20:17:57  *** cryptapus has quit IRC
360 2016-06-07T20:20:54  *** jiggalator has joined #bitcoin-core-dev
361 2016-06-07T20:25:44  *** CubicEarth has quit IRC
362 2016-06-07T20:39:08  *** rubensayshi has quit IRC
363 2016-06-07T20:39:14  *** jiggalator has quit IRC
364 2016-06-07T20:41:21  *** raedah has quit IRC
365 2016-06-07T20:43:06  *** raedah has joined #bitcoin-core-dev
366 2016-06-07T20:47:58  <jonasschnelli> cfields_: https://github.com/bitcoin/bitcoin/pull/8164/files/86efa30ae3fd36aa77b19ff0f70bb89be9ec308e#r66149475
367 2016-06-07T20:48:16  <jonasschnelli> Why use strtoll instead of std::stoul?
368 2016-06-07T20:48:42  *** zooko has joined #bitcoin-core-dev
369 2016-06-07T20:49:58  <cfields_> jonasschnelli: typo. stoll would work, i was just making the point that i think it needs to be a long long to be completely safe
370 2016-06-07T20:50:28  <sipa> oh, i didn't know about stoll!
371 2016-06-07T20:51:05  <cfields_> jonasschnelli: feel free to ignore, I'm not familiar enough there to know if it's necessary to be paranoid there.
372 2016-06-07T20:51:17  <cfields_> - a "there"
373 2016-06-07T20:51:30  <jonasschnelli> cfields_: yeah. Me too. :)
374 2016-06-07T20:52:06  <cfields_> sipa: c++11's full of surprises :)
375 2016-06-07T20:52:29  <jonasschnelli> But I guess there are other placed in bitcoin-tx where we do not check for overflows (like vout, etc.)
376 2016-06-07T20:52:34  *** rubensayshi has joined #bitcoin-core-dev
377 2016-06-07T20:52:41  <jonasschnelli> Travis is currently failing on master.
378 2016-06-07T20:52:48  <jonasschnelli> So a quick review and merge of https://github.com/bitcoin/bitcoin/pull/8164 would be great.
379 2016-06-07T20:52:54  <cfields_> jonasschnelli: right, probably low on the list of real concerns
380 2016-06-07T20:54:18  *** jiggalator has joined #bitcoin-core-dev
381 2016-06-07T20:54:21  *** raedah has quit IRC
382 2016-06-07T20:55:01  <cfields_> jonasschnelli: sec, i'm looking up the actual failure. I'd hate mask real bugs there.
383 2016-06-07T20:55:09  *** jiggalator has quit IRC
384 2016-06-07T20:55:46  *** raedah has joined #bitcoin-core-dev
385 2016-06-07T21:01:40  *** raedah has quit IRC
386 2016-06-07T21:04:39  *** jiggalator has joined #bitcoin-core-dev
387 2016-06-07T21:16:17  <cfields_> jonasschnelli: ok, just tested. It's pretty easy to screw that up, especially if you're typing a seq by hand and add one too many digits. Silently inserting the wrong value is pretty nasty.
388 2016-06-07T21:16:23  <cfields_> jonasschnelli: http://pastebin.com/raw/Yz18syyR
389 2016-06-07T21:24:37  *** jiggalator has quit IRC
390 2016-06-07T21:27:36  *** jiggalator has joined #bitcoin-core-dev
391 2016-06-07T21:27:38  *** raedah has joined #bitcoin-core-dev
392 2016-06-07T21:34:04  *** zooko has quit IRC
393 2016-06-07T21:43:16  *** moli has joined #bitcoin-core-dev
394 2016-06-07T22:12:39  *** jiggalator has quit IRC
395 2016-06-07T22:23:25  *** molz has joined #bitcoin-core-dev
396 2016-06-07T22:25:03  *** Guyver2 has quit IRC
397 2016-06-07T22:26:41  *** moli has quit IRC
398 2016-06-07T22:52:40  *** blur3d has joined #bitcoin-core-dev
399 2016-06-07T23:37:30  <sipa> luke-jr: good thing BIP8 was never assigned https://en.wikipedia.org/wiki/BIP-8 (image what would happen if something related to error correction or checksums got that...)