1 2016-06-19T00:13:45  *** teward has quit IRC
  2 2016-06-19T00:20:45  *** teward has joined #bitcoin-core-dev
  3 2016-06-19T00:26:16  *** teward has quit IRC
  4 2016-06-19T00:30:52  *** teward has joined #bitcoin-core-dev
  5 2016-06-19T00:50:21  *** xiangfu has joined #bitcoin-core-dev
  6 2016-06-19T00:51:21  *** teward has quit IRC
  7 2016-06-19T00:57:31  *** teward has joined #bitcoin-core-dev
  8 2016-06-19T01:13:47  *** molz has joined #bitcoin-core-dev
  9 2016-06-19T01:15:49  *** moli has quit IRC
 10 2016-06-19T01:16:40  *** teward has quit IRC
 11 2016-06-19T01:20:48  *** moli has joined #bitcoin-core-dev
 12 2016-06-19T01:24:01  *** molly has joined #bitcoin-core-dev
 13 2016-06-19T01:24:04  *** molz has quit IRC
 14 2016-06-19T01:24:34  *** teward has joined #bitcoin-core-dev
 15 2016-06-19T01:26:33  *** moli has quit IRC
 16 2016-06-19T01:29:03  *** teward has quit IRC
 17 2016-06-19T01:30:26  *** xiangfu has quit IRC
 18 2016-06-19T01:30:56  *** moli has joined #bitcoin-core-dev
 19 2016-06-19T01:31:19  *** Ylbam has quit IRC
 20 2016-06-19T01:32:30  *** molly has quit IRC
 21 2016-06-19T01:35:22  *** teward has joined #bitcoin-core-dev
 22 2016-06-19T01:39:16  *** Alopex has quit IRC
 23 2016-06-19T01:40:09  *** achow101 has quit IRC
 24 2016-06-19T01:40:22  *** Alopex has joined #bitcoin-core-dev
 25 2016-06-19T01:42:54  *** teward has quit IRC
 26 2016-06-19T01:47:19  *** teward has joined #bitcoin-core-dev
 27 2016-06-19T01:58:11  *** Alopex has quit IRC
 28 2016-06-19T01:59:16  *** Alopex has joined #bitcoin-core-dev
 29 2016-06-19T02:05:25  *** jonasschnelli has quit IRC
 30 2016-06-19T02:08:03  *** teward has quit IRC
 31 2016-06-19T02:08:20  *** jonasschnelli has joined #bitcoin-core-dev
 32 2016-06-19T02:08:59  *** cjcj has quit IRC
 33 2016-06-19T02:08:59  *** assder has quit IRC
 34 2016-06-19T02:09:02  *** teward has joined #bitcoin-core-dev
 35 2016-06-19T02:16:50  *** teward has quit IRC
 36 2016-06-19T02:20:20  *** teward has joined #bitcoin-core-dev
 37 2016-06-19T02:25:46  *** achow101 has joined #bitcoin-core-dev
 38 2016-06-19T02:34:29  *** teward has quit IRC
 39 2016-06-19T02:37:47  *** alpalp has joined #bitcoin-core-dev
 40 2016-06-19T02:41:13  *** teward has joined #bitcoin-core-dev
 41 2016-06-19T02:41:29  *** Giszmo has joined #bitcoin-core-dev
 42 2016-06-19T02:42:30  *** achow101 has quit IRC
 43 2016-06-19T02:46:45  *** teward has quit IRC
 44 2016-06-19T02:54:42  *** teward has joined #bitcoin-core-dev
 45 2016-06-19T02:56:26  *** molz has joined #bitcoin-core-dev
 46 2016-06-19T02:59:13  *** moli has quit IRC
 47 2016-06-19T03:05:09  *** moli has joined #bitcoin-core-dev
 48 2016-06-19T03:05:15  *** teward has quit IRC
 49 2016-06-19T03:06:20  *** moli has quit IRC
 50 2016-06-19T03:06:43  *** moli has joined #bitcoin-core-dev
 51 2016-06-19T03:07:20  *** cheese_ has quit IRC
 52 2016-06-19T03:07:34  *** molz has quit IRC
 53 2016-06-19T03:11:32  *** teward has joined #bitcoin-core-dev
 54 2016-06-19T03:16:04  *** teward has quit IRC
 55 2016-06-19T03:22:35  *** molz has joined #bitcoin-core-dev
 56 2016-06-19T03:24:44  *** teward has joined #bitcoin-core-dev
 57 2016-06-19T03:25:04  *** moli has quit IRC
 58 2016-06-19T03:29:54  *** teward has quit IRC
 59 2016-06-19T03:32:04  *** teward has joined #bitcoin-core-dev
 60 2016-06-19T03:40:47  *** teward has quit IRC
 61 2016-06-19T03:41:30  *** teward has joined #bitcoin-core-dev
 62 2016-06-19T03:44:28  *** cryptapus_afk is now known as cryptapus
 63 2016-06-19T03:45:59  *** teward has quit IRC
 64 2016-06-19T03:47:52  *** teward has joined #bitcoin-core-dev
 65 2016-06-19T03:50:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 66 2016-06-19T03:52:29  *** teward has quit IRC
 67 2016-06-19T03:54:21  *** alpalp has quit IRC
 68 2016-06-19T03:54:30  *** teward has joined #bitcoin-core-dev
 69 2016-06-19T04:01:42  *** justanotheruser has quit IRC
 70 2016-06-19T04:03:14  *** jiggalator has joined #bitcoin-core-dev
 71 2016-06-19T04:03:20  *** justanotheruser has joined #bitcoin-core-dev
 72 2016-06-19T04:03:29  *** jiggalator has quit IRC
 73 2016-06-19T04:03:35  *** teward has quit IRC
 74 2016-06-19T04:15:55  *** teward has joined #bitcoin-core-dev
 75 2016-06-19T04:19:35  *** Chris_Stewart_5 has quit IRC
 76 2016-06-19T04:22:23  *** teward has quit IRC
 77 2016-06-19T04:25:38  *** jonasschnelli has quit IRC
 78 2016-06-19T04:25:40  *** nets1n has joined #bitcoin-core-dev
 79 2016-06-19T04:26:30  *** nets1n has quit IRC
 80 2016-06-19T04:26:55  *** jiggalator has joined #bitcoin-core-dev
 81 2016-06-19T04:28:54  *** jiggalator has quit IRC
 82 2016-06-19T04:29:28  *** nets1n has joined #bitcoin-core-dev
 83 2016-06-19T04:30:54  *** jonasschnelli has joined #bitcoin-core-dev
 84 2016-06-19T04:31:12  *** teward has joined #bitcoin-core-dev
 85 2016-06-19T04:31:26  *** jiggalator has joined #bitcoin-core-dev
 86 2016-06-19T04:33:02  *** jiggalator is now known as nets1n
 87 2016-06-19T04:44:00  *** teward has quit IRC
 88 2016-06-19T04:48:32  *** teward has joined #bitcoin-core-dev
 89 2016-06-19T05:03:17  *** cryptapus is now known as cryptapus_afk
 90 2016-06-19T05:17:23  *** Sosumi has joined #bitcoin-core-dev
 91 2016-06-19T05:32:36  *** nets1n has quit IRC
 92 2016-06-19T05:37:17  *** nets1n has joined #bitcoin-core-dev
 93 2016-06-19T05:49:46  *** moli has joined #bitcoin-core-dev
 94 2016-06-19T05:51:25  *** molz has quit IRC
 95 2016-06-19T06:08:54  *** Sosumi has quit IRC
 96 2016-06-19T06:10:36  *** molz has joined #bitcoin-core-dev
 97 2016-06-19T06:13:04  *** moli has quit IRC
 98 2016-06-19T06:37:24  *** nets1n has quit IRC
 99 2016-06-19T06:41:57  *** cjcj has joined #bitcoin-core-dev
100 2016-06-19T07:04:27  *** Alopex has quit IRC
101 2016-06-19T07:05:32  *** Alopex has joined #bitcoin-core-dev
102 2016-06-19T07:11:25  *** Giszmo has quit IRC
103 2016-06-19T07:19:35  *** gavinandresen has quit IRC
104 2016-06-19T07:21:27  *** gavinandresen has joined #bitcoin-core-dev
105 2016-06-19T07:26:56  *** jonasschnelli has quit IRC
106 2016-06-19T07:26:56  *** jonasschnelli has joined #bitcoin-core-dev
107 2016-06-19T07:30:30  *** Ylbam has joined #bitcoin-core-dev
108 2016-06-19T07:46:08  <wumpus> luke-jr: no, I don't
109 2016-06-19T07:54:46  <wumpus> luke-jr: we do test windows on travis AFAIK?
110 2016-06-19T08:00:49  *** moli has joined #bitcoin-core-dev
111 2016-06-19T08:03:22  *** molz has quit IRC
112 2016-06-19T08:03:37  <wumpus> e.g. cross-build for windows, then run the tests in wine
113 2016-06-19T08:04:14  <wumpus> but not sure this covers all the tests
114 2016-06-19T08:09:48  *** Guyver2 has joined #bitcoin-core-dev
115 2016-06-19T08:24:46  *** JackH has joined #bitcoin-core-dev
116 2016-06-19T08:57:28  *** molz has joined #bitcoin-core-dev
117 2016-06-19T09:00:00  *** moli has quit IRC
118 2016-06-19T09:07:59  *** Guyver2 has quit IRC
119 2016-06-19T10:03:57  *** whphhg has joined #bitcoin-core-dev
120 2016-06-19T11:06:15  *** laurentmt has joined #bitcoin-core-dev
121 2016-06-19T11:06:21  *** laurentmt has quit IRC
122 2016-06-19T11:19:05  *** alpalp has joined #bitcoin-core-dev
123 2016-06-19T12:19:45  *** Naphex has joined #bitcoin-core-dev
124 2016-06-19T12:32:05  *** Thireus has joined #bitcoin-core-dev
125 2016-06-19T13:04:28  *** Thireus has quit IRC
126 2016-06-19T13:21:04  *** musalbas has joined #bitcoin-core-dev
127 2016-06-19T13:43:20  <luke-jr> wumpus: the Trusty changes appear to have disabled the GUI build and WINE testing :/
128 2016-06-19T13:43:33  <luke-jr> ie, just builds bitcoind and doesn't test it
129 2016-06-19T13:51:22  <sipa> luke-jr: https://travis-ci.org/bitcoin/bitcoin/jobs/138611890#L2144
130 2016-06-19T13:51:24  <sipa> seems it does
131 2016-06-19T13:51:52  <luke-jr> hm
132 2016-06-19T13:52:07  <sipa> ah, but not the RPC tests
133 2016-06-19T13:52:30  <sipa> only comparison tool and unit tests
134 2016-06-19T13:54:03  <sipa> wumpus: https://github.com/bitcoin/bitcoin/pull/5677#issuecomment-136646964
135 2016-06-19T13:54:09  <sipa> wumpus: does that still apply?
136 2016-06-19T13:54:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
137 2016-06-19T13:55:01  <luke-jr> -      env: HOST=i686-w64-mingw32 PPA="ppa:ubuntu-wine/ppa" PACKAGES="nsis gcc-mingw-w64-i686 g++-mingw-w64-i686 binutils-mingw-w64-i686 mingw-w64-dev wine1.7 bc" RUN_TESTS=true GOAL="deploy" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" MAKEJOBS="-j2"
138 2016-06-19T13:55:02  <luke-jr> +      env: HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="nsis g++-mingw-w64-i686 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
139 2016-06-19T13:55:34  <luke-jr> I guess I misread the RUN_TESTS part, but what does the GOAL change imply?
140 2016-06-19T13:58:06  <sipa> i think it just means we don't build the installer
141 2016-06-19T14:55:36  *** alpalp has quit IRC
142 2016-06-19T15:11:55  <Chris_Stewart_5> sipa: Do you have any thoughts on property based checking? I'm starting to integrate it into a library I'm writing and it seems it would be useful in Bitcoin Core. I was looking at this library for C++
143 2016-06-19T15:11:57  <Chris_Stewart_5> https://github.com/emil-e/rapidcheck
144 2016-06-19T15:12:17  <Chris_Stewart_5> I'm wondering if there is any outright objections before I put more time into investigating this for Core..
145 2016-06-19T15:20:04  <wumpus> luke-jr: yes the GUI build is disabled for travis, for all platforms, that's intentional as there is still some caching issue
146 2016-06-19T15:21:07  <wumpus> sipa: no idea, could be that the RPC tests could be re-enabled, just no one has tried since
147 2016-06-19T15:21:49  <sipa> Chris_Stewart_5: no objections to the concept, but i have no experience with the code/logistics of integrating it
148 2016-06-19T15:22:56  <sipa> Chris_Stewart_5: perhaps you want to talk to Marco Falke (our qa maintainer)
149 2016-06-19T15:23:19  <wumpus> Chris_Stewart_5: I have no experience with it either, if you can apply it to improve test coverage of bitcoin core, why not try it
150 2016-06-19T15:23:55  <wumpus> at first glance it looks like a type of fuzzing, you could take a look at https://github.com/bitcoin/bitcoin/pull/7940
151 2016-06-19T15:24:07  <Chris_Stewart_5> Will do. Is it best to submit a pull request with a [WIP] on it, or just develop on my own branch and submit a pull request later on?
152 2016-06-19T15:25:02  <wumpus> that's really up to you
153 2016-06-19T15:25:35  <wumpus> in both cases you develop on your own branch, in the former cast it has somewhat more visibility, which is useful if you want other people's opinions about things
154 2016-06-19T15:33:10  <Chris_Stewart_5> good point, another question, is there any vetting process for dependencies that are being added to our src files?
155 2016-06-19T15:34:03  <Chris_Stewart_5> I get that this one isn't as crucial since it is test dependecy, but it would be important if a dependency was affect src files
156 2016-06-19T15:34:47  <Chris_Stewart_5> src meaning everything but the child test dir
157 2016-06-19T15:35:42  *** alpalp has joined #bitcoin-core-dev
158 2016-06-19T15:46:00  *** achow101 has joined #bitcoin-core-dev
159 2016-06-19T16:00:21  <sipa> Chris_Stewart_5: if you add a dependency, you need to make sure that it's available in the depends system (see the depends subdir), so that it's available to the deterministic build system
160 2016-06-19T16:01:48  <Chris_Stewart_5> Hmm ok. I'm just starting to look at this stuff. Doesn't look quite as simple as maven on the JVM :-). Cory is the build expert right?
161 2016-06-19T16:05:23  *** PRab has quit IRC
162 2016-06-19T16:05:34  <sipa> Chris_Stewart_5: indeed
163 2016-06-19T16:06:38  <sipa> Chris_Stewart_5: deterministic building is a pretty new concept, and there are few tools available to do it for you, so it's all pretty custom
164 2016-06-19T16:07:08  <sipa> Chris_Stewart_5: though, generally don't worry about that, if it's useful we'll find a way to integrate it
165 2016-06-19T16:08:50  <Chris_Stewart_5> sipa: Ok, I'm just going to hack it together to start and submit a pull request testing a few simple properties
166 2016-06-19T16:12:38  <GitHub4> [bitcoin] wbinns opened pull request #8224: readme: Revise 'an experimental new' phrasing in reference to Bitcoin (master...binns-update-readme) https://github.com/bitcoin/bitcoin/pull/8224
167 2016-06-19T16:13:21  *** netsinn has joined #bitcoin-core-dev
168 2016-06-19T16:25:20  *** netsinn has quit IRC
169 2016-06-19T16:40:56  *** laurentmt has joined #bitcoin-core-dev
170 2016-06-19T16:41:07  *** laurentmt has quit IRC
171 2016-06-19T16:43:00  *** netsin_ has joined #bitcoin-core-dev
172 2016-06-19T16:48:11  *** netsin_ has quit IRC
173 2016-06-19T16:48:34  *** netsinn has joined #bitcoin-core-dev
174 2016-06-19T16:48:55  *** Giszmo has joined #bitcoin-core-dev
175 2016-06-19T16:56:23  *** netsinn has quit IRC
176 2016-06-19T17:02:35  *** netsin_ has joined #bitcoin-core-dev
177 2016-06-19T17:23:39  *** moli has joined #bitcoin-core-dev
178 2016-06-19T17:23:51  *** molz has quit IRC
179 2016-06-19T17:27:16  *** alpalp has quit IRC
180 2016-06-19T17:38:31  *** Thireus has joined #bitcoin-core-dev
181 2016-06-19T17:43:18  *** zooko has quit IRC
182 2016-06-19T18:01:33  *** alpalp has joined #bitcoin-core-dev
183 2016-06-19T18:04:09  *** molz has joined #bitcoin-core-dev
184 2016-06-19T18:07:08  *** moli has quit IRC
185 2016-06-19T18:09:37  <Chris_Stewart_5> So i've created a file inside of package giving the instructions of how to build the library, what is the next step? I've tried to add the header to the test file and it fails.
186 2016-06-19T18:10:03  <Chris_Stewart_5> I've also added it to the first line in packages.mk
187 2016-06-19T18:12:03  <Chris_Stewart_5> See https://github.com/Christewart/bitcoin/commit/18638a532a8977d19a104f7fca76783b74d5e9fb
188 2016-06-19T18:17:31  *** moli has joined #bitcoin-core-dev
189 2016-06-19T18:17:49  *** Thireus has left #bitcoin-core-dev
190 2016-06-19T18:20:08  *** molz has quit IRC
191 2016-06-19T18:42:39  *** Ylbam_ has joined #bitcoin-core-dev
192 2016-06-19T18:43:29  *** michagogo_ has joined #bitcoin-core-dev
193 2016-06-19T18:45:07  *** pigeons_ has joined #bitcoin-core-dev
194 2016-06-19T18:45:26  *** frankenmint has joined #bitcoin-core-dev
195 2016-06-19T18:48:18  *** teward- has joined #bitcoin-core-dev
196 2016-06-19T18:48:33  *** Lightsword_ has joined #bitcoin-core-dev
197 2016-06-19T18:48:43  *** GreenIsMyPepper_ has joined #bitcoin-core-dev
198 2016-06-19T18:50:07  *** Giszmo has quit IRC
199 2016-06-19T18:50:07  *** musalbas has quit IRC
200 2016-06-19T18:50:08  *** Ylbam has quit IRC
201 2016-06-19T18:50:08  *** teward has quit IRC
202 2016-06-19T18:50:08  *** Lightsword has quit IRC
203 2016-06-19T18:50:09  *** face has quit IRC
204 2016-06-19T18:50:09  *** d9b4bef9 has quit IRC
205 2016-06-19T18:50:09  *** pigeons has quit IRC
206 2016-06-19T18:50:10  *** michagogo has quit IRC
207 2016-06-19T18:50:11  *** Guest31006 has quit IRC
208 2016-06-19T18:50:12  *** mn3monic has quit IRC
209 2016-06-19T18:50:13  *** GreenIsMyPepper has quit IRC
210 2016-06-19T18:50:13  *** Lightsword_ is now known as Lightsword
211 2016-06-19T18:50:13  *** Ylbam_ is now known as Ylbam
212 2016-06-19T18:50:13  *** teward- is now known as teward
213 2016-06-19T18:51:08  *** d9b4bef9 has joined #bitcoin-core-dev
214 2016-06-19T18:52:01  *** musalbas has joined #bitcoin-core-dev
215 2016-06-19T18:53:52  *** spudowiar has quit IRC
216 2016-06-19T18:56:04  *** face has joined #bitcoin-core-dev
217 2016-06-19T18:56:41  *** Guest31006 has joined #bitcoin-core-dev
218 2016-06-19T18:56:58  *** Giszmo has joined #bitcoin-core-dev
219 2016-06-19T18:57:19  *** michagogo_ is now known as michagogo
220 2016-06-19T18:59:17  *** Arnavion has quit IRC
221 2016-06-19T19:03:13  *** molz has joined #bitcoin-core-dev
222 2016-06-19T19:03:27  *** teward has quit IRC
223 2016-06-19T19:05:33  *** moli has quit IRC
224 2016-06-19T19:06:38  *** challisto has joined #bitcoin-core-dev
225 2016-06-19T19:06:38  *** challisto has joined #bitcoin-core-dev
226 2016-06-19T19:06:47  *** spudowiar has joined #bitcoin-core-dev
227 2016-06-19T19:08:16  *** Chris_Stewart_5 has quit IRC
228 2016-06-19T19:16:29  *** Giszmo has quit IRC
229 2016-06-19T19:16:35  *** teward has joined #bitcoin-core-dev
230 2016-06-19T19:32:10  *** moli has joined #bitcoin-core-dev
231 2016-06-19T19:34:00  *** molz has quit IRC
232 2016-06-19T19:34:29  *** Guyver2 has joined #bitcoin-core-dev
233 2016-06-19T19:36:31  *** molz has joined #bitcoin-core-dev
234 2016-06-19T19:38:33  *** moli has quit IRC
235 2016-06-19T20:03:43  *** Arnavion has joined #bitcoin-core-dev
236 2016-06-19T20:04:21  *** zooko has joined #bitcoin-core-dev
237 2016-06-19T20:07:32  *** davec_ has quit IRC
238 2016-06-19T20:08:11  *** davec_ has joined #bitcoin-core-dev
239 2016-06-19T20:29:18  *** frankenmint has quit IRC
240 2016-06-19T20:30:08  *** zooko has quit IRC
241 2016-06-19T20:39:16  *** mn3monic has joined #bitcoin-core-dev
242 2016-06-19T20:56:53  *** whphhg has quit IRC
243 2016-06-19T20:57:58  *** whphhg has joined #bitcoin-core-dev
244 2016-06-19T21:10:19  *** frankenmint has joined #bitcoin-core-dev
245 2016-06-19T21:35:56  *** Cheeseo has joined #bitcoin-core-dev
246 2016-06-19T21:36:22  *** cheese_ has joined #bitcoin-core-dev
247 2016-06-19T21:36:47  *** raedah has quit IRC
248 2016-06-19T21:37:29  *** raedah has joined #bitcoin-core-dev
249 2016-06-19T22:11:13  *** raedah has quit IRC
250 2016-06-19T22:11:57  *** raedah has joined #bitcoin-core-dev
251 2016-06-19T22:18:02  *** alpalp has quit IRC
252 2016-06-19T22:23:03  *** Giszmo has joined #bitcoin-core-dev
253 2016-06-19T22:35:48  *** frankenmint has quit IRC
254 2016-06-19T22:42:29  *** pigeons_ is now known as pigeons
255 2016-06-19T22:44:34  *** Guyver2 has quit IRC
256 2016-06-19T23:12:20  *** spudowiar has quit IRC
257 2016-06-19T23:15:37  *** spudowiar has joined #bitcoin-core-dev
258 2016-06-19T23:23:45  *** Guest31006 has quit IRC
259 2016-06-19T23:24:23  *** xiangfu has joined #bitcoin-core-dev
260 2016-06-19T23:26:20  *** Madars has joined #bitcoin-core-dev
261 2016-06-19T23:29:57  *** spudowiar has quit IRC
262 2016-06-19T23:31:37  *** spudowiar has joined #bitcoin-core-dev
263 2016-06-19T23:44:44  <GitHub63> [bitcoin] wbinns opened pull request #8226: contributing.md: Fix formatting (line lengths and smart quotes) (master...binns-contributing-formatting) https://github.com/bitcoin/bitcoin/pull/8226
264 2016-06-19T23:50:25  *** alpalp has joined #bitcoin-core-dev
265 2016-06-19T23:50:25  *** alpalp has joined #bitcoin-core-dev