1 2016-07-27T00:00:21  *** BashCo has quit IRC
  2 2016-07-27T00:01:14  <luke-jr> https://github.com/bitcoin/libblkmaker/pull/6 review requested
  3 2016-07-27T00:04:53  *** BashCo has joined #bitcoin-core-dev
  4 2016-07-27T00:14:11  *** belcher has quit IRC
  5 2016-07-27T00:19:29  *** Guest19449 has joined #bitcoin-core-dev
  6 2016-07-27T00:21:01  *** Guest19449 is now known as roidster
  7 2016-07-27T00:37:04  <phantomcircuit> wumpus: what else more do i need to do on https://github.com/bitcoin/bitcoin/pull/8152 ?
  8 2016-07-27T00:37:18  <phantomcircuit> jonasschnelli: same question ^
  9 2016-07-27T00:43:32  *** roidster has quit IRC
 10 2016-07-27T01:05:49  *** Ylbam has quit IRC
 11 2016-07-27T01:27:45  *** fengling has joined #bitcoin-core-dev
 12 2016-07-27T01:29:38  *** molly has quit IRC
 13 2016-07-27T01:30:05  *** moli has joined #bitcoin-core-dev
 14 2016-07-27T01:33:26  *** molz has joined #bitcoin-core-dev
 15 2016-07-27T01:36:05  *** moli has quit IRC
 16 2016-07-27T01:49:03  *** laurentmt has quit IRC
 17 2016-07-27T02:00:36  *** justanotheruser has quit IRC
 18 2016-07-27T02:05:35  *** justanotheruser has joined #bitcoin-core-dev
 19 2016-07-27T02:17:46  *** fengling has quit IRC
 20 2016-07-27T02:21:25  *** fengling has joined #bitcoin-core-dev
 21 2016-07-27T02:29:56  *** zooko has joined #bitcoin-core-dev
 22 2016-07-27T03:23:28  *** jtimon has quit IRC
 23 2016-07-27T03:49:43  *** pmienk has quit IRC
 24 2016-07-27T04:05:29  *** pmienk has joined #bitcoin-core-dev
 25 2016-07-27T04:17:37  *** Alopex has quit IRC
 26 2016-07-27T04:18:42  *** Alopex has joined #bitcoin-core-dev
 27 2016-07-27T04:28:21  *** Alopex has quit IRC
 28 2016-07-27T04:29:26  *** Alopex has joined #bitcoin-core-dev
 29 2016-07-27T04:39:02  *** anu0 has joined #bitcoin-core-dev
 30 2016-07-27T04:46:02  *** Alopex has quit IRC
 31 2016-07-27T04:47:07  *** Alopex has joined #bitcoin-core-dev
 32 2016-07-27T04:50:25  *** d_t has joined #bitcoin-core-dev
 33 2016-07-27T04:54:55  *** d_t has quit IRC
 34 2016-07-27T05:07:40  *** morcos has quit IRC
 35 2016-07-27T05:08:20  *** zxzzt has quit IRC
 36 2016-07-27T05:09:01  *** d_t has joined #bitcoin-core-dev
 37 2016-07-27T05:10:03  *** zxzzt has joined #bitcoin-core-dev
 38 2016-07-27T05:12:22  *** zooko has quit IRC
 39 2016-07-27T05:23:30  *** morcos has joined #bitcoin-core-dev
 40 2016-07-27T05:32:21  *** Alopex has quit IRC
 41 2016-07-27T05:33:27  *** Alopex has joined #bitcoin-core-dev
 42 2016-07-27T06:06:20  *** Yv7trNY has joined #bitcoin-core-dev
 43 2016-07-27T06:10:19  *** adiabat has joined #bitcoin-core-dev
 44 2016-07-27T06:25:10  *** Squidicc has joined #bitcoin-core-dev
 45 2016-07-27T06:28:40  *** squidicuz has quit IRC
 46 2016-07-27T06:28:41  *** Yv7trNY has quit IRC
 47 2016-07-27T06:35:12  *** Yv7trNY has joined #bitcoin-core-dev
 48 2016-07-27T06:35:41  *** BashCo has quit IRC
 49 2016-07-27T06:42:17  *** d_t has quit IRC
 50 2016-07-27T06:52:31  *** jl2012 has quit IRC
 51 2016-07-27T06:52:58  *** jl2012 has joined #bitcoin-core-dev
 52 2016-07-27T07:03:41  *** BashCo has joined #bitcoin-core-dev
 53 2016-07-27T07:05:16  *** Alopex has quit IRC
 54 2016-07-27T07:06:22  *** Alopex has joined #bitcoin-core-dev
 55 2016-07-27T07:17:40  *** Guyver2 has joined #bitcoin-core-dev
 56 2016-07-27T07:31:53  *** Ylbam has joined #bitcoin-core-dev
 57 2016-07-27T07:35:03  *** dgenr8 has quit IRC
 58 2016-07-27T07:35:07  *** AtashiCon has quit IRC
 59 2016-07-27T07:35:21  *** AtashiCon has joined #bitcoin-core-dev
 60 2016-07-27T07:39:24  *** dgenr8 has joined #bitcoin-core-dev
 61 2016-07-27T07:39:25  *** aalex_ has quit IRC
 62 2016-07-27T07:39:25  *** kanzure has quit IRC
 63 2016-07-27T07:39:26  *** kanzure has joined #bitcoin-core-dev
 64 2016-07-27T07:40:33  *** aalex_ has joined #bitcoin-core-dev
 65 2016-07-27T07:52:54  *** G1lius has quit IRC
 66 2016-07-27T08:11:12  *** kanzure has quit IRC
 67 2016-07-27T08:11:15  *** kanzure has joined #bitcoin-core-dev
 68 2016-07-27T08:13:07  *** mturquette has quit IRC
 69 2016-07-27T08:13:47  *** mturquette has joined #bitcoin-core-dev
 70 2016-07-27T08:31:22  *** Guyver2 has quit IRC
 71 2016-07-27T08:31:54  *** aalex_ has quit IRC
 72 2016-07-27T08:34:20  <jonasschnelli> phantomcircuit: Looks good. I really want to run some tests. I'll do that soon. But 8152 is definitively useful and will be merged soon.
 73 2016-07-27T08:35:33  *** aalex_ has joined #bitcoin-core-dev
 74 2016-07-27T08:38:26  *** kadoban has quit IRC
 75 2016-07-27T08:40:16  *** Yv7trNY has quit IRC
 76 2016-07-27T08:40:58  *** aalex_ has quit IRC
 77 2016-07-27T08:41:21  *** aalex_ has joined #bitcoin-core-dev
 78 2016-07-27T08:53:08  <jonasschnelli> wumpus: I think https://github.com/bitcoin/bitcoin/pull/8152 is ready for merge (into master)
 79 2016-07-27T08:55:13  <wumpus> thanks, taking a look
 80 2016-07-27T09:00:59  <wumpus> I'm still not entirely convinced that it won't reduce performance by causing more flushes to disk
 81 2016-07-27T09:01:28  *** aalex_ has quit IRC
 82 2016-07-27T09:01:50  <wumpus> e.g. the reason for passing those CWalletDB in the first place (it wasn't always that way) was to prevent extraneous flushes, as sipa says in that pull
 83 2016-07-27T09:03:18  <wumpus> but if anyone can convince me that that problem has been handled in another way I'm ok with merging it
 84 2016-07-27T09:03:30  <wumpus> (or even better, benchmarks)
 85 2016-07-27T09:04:25  <wumpus> jonasschnelli: re: 8407, I think the second commit makes the code unncesarily complex; I think we can already handle all upgrade scenarios without it
 86 2016-07-27T09:04:44  *** aalex_ has joined #bitcoin-core-dev
 87 2016-07-27T09:04:57  <jonasschnelli> wumpus: IMO 8152 is only a refactoring to avoid having CWalletDB access in rpc code.
 88 2016-07-27T09:05:12  <jonasschnelli> wumpus: re 8407, I agree. I will remove the second commit asap
 89 2016-07-27T09:06:30  <wumpus> yes avoiding CWalletDB access in the RPC code is great; but that could also have been accomplished by adding a wrapper method in CWallet
 90 2016-07-27T09:06:59  <wumpus> that passes through the wtx to AddToWallet and opens the walletdb
 91 2016-07-27T09:07:12  <wumpus> what I'm worried about is the internal uses of AddToWallet that do pass their own walletdb
 92 2016-07-27T09:08:16  <wumpus> eh - do those exist at all?
 93 2016-07-27T09:08:25  <jonasschnelli> wumpus: I have checked the internal AddToWallet uses. And it seems like they all open CWalletDB shortly before resulting in the ~same behavior.
 94 2016-07-27T09:09:03  <jonasschnelli> I think the change form (external calls) pwalletMain->AddToWallet(wtx, false, &walletdb); to  pwalletMain->AddToWallet(wtx); is good.
 95 2016-07-27T09:09:20  <jonasschnelli> It hides CWalletDB behind CWallet
 96 2016-07-27T09:09:24  *** davidlj95 has joined #bitcoin-core-dev
 97 2016-07-27T09:09:35  <wumpus> hmm I agree
 98 2016-07-27T09:09:37  <jonasschnelli> (for callers using AddToWallet)
 99 2016-07-27T09:10:01  <wumpus> LOL @ line 910
100 2016-07-27T09:10:03  <jonasschnelli> But as I said. I think its a refactoring PR
101 2016-07-27T09:10:34  <jonasschnelli> wumpus: you mean the return false at L910
102 2016-07-27T09:10:45  <wumpus> of wallet.cpp - that line could be deleted, no one is using that walletdb :-)
103 2016-07-27T09:10:58  <wumpus> CWalletDB walletdb(strWalletFile, "r+", false);    return AddToWallet(wtx);
104 2016-07-27T09:11:27  <wumpus> I'm looking at the merged version, line numbers may be off
105 2016-07-27T09:11:42  <jonasschnelli> Ah. Yes. That should be removed I guess.
106 2016-07-27T09:12:28  <wumpus> so what changes here is the parameters under which walletdb is opened
107 2016-07-27T09:12:55  <wumpus> for that AddWallet it used to be the ("r+", false), but now it wil open the walletdb inside AddToWallet with default parameters
108 2016-07-27T09:13:21  *** mkarrer has joined #bitcoin-core-dev
109 2016-07-27T09:14:11  <wumpus> ok, commented on the pull
110 2016-07-27T09:14:26  *** laurentmt has joined #bitcoin-core-dev
111 2016-07-27T09:14:48  *** laurentmt has quit IRC
112 2016-07-27T09:16:56  *** mkarrer_ has quit IRC
113 2016-07-27T09:23:36  *** TomMc has joined #bitcoin-core-dev
114 2016-07-27T09:32:54  *** TomMc has quit IRC
115 2016-07-27T09:33:02  *** Giszmo has joined #bitcoin-core-dev
116 2016-07-27T09:39:36  *** cdecker has joined #bitcoin-core-dev
117 2016-07-27T09:42:40  *** mkarrer has quit IRC
118 2016-07-27T09:43:17  *** mkarrer has joined #bitcoin-core-dev
119 2016-07-27T10:32:32  *** Ginnarr has joined #bitcoin-core-dev
120 2016-07-27T10:38:42  *** spudowiar has joined #bitcoin-core-dev
121 2016-07-27T11:03:57  *** BashCo_ has joined #bitcoin-core-dev
122 2016-07-27T11:07:15  *** BashCo has quit IRC
123 2016-07-27T11:22:12  *** cryptapus has joined #bitcoin-core-dev
124 2016-07-27T11:26:34  <jonasschnelli> I think this one is ready for merge https://github.com/bitcoin/bitcoin/pull/8206
125 2016-07-27T11:26:45  <jonasschnelli> Its a required 0.13 backport and relatively risk free
126 2016-07-27T11:34:40  *** davidlj95 has quit IRC
127 2016-07-27T11:44:39  *** spudowiar has quit IRC
128 2016-07-27T11:45:03  *** spudowiar1 has joined #bitcoin-core-dev
129 2016-07-27T11:47:28  *** spudowiar1 is now known as spudowiar
130 2016-07-27T11:53:13  *** spudowiar has quit IRC
131 2016-07-27T11:57:30  *** laurentmt has joined #bitcoin-core-dev
132 2016-07-27T12:13:01  *** Giszmo has quit IRC
133 2016-07-27T12:20:21  *** zooko has joined #bitcoin-core-dev
134 2016-07-27T12:24:33  *** anu1 has joined #bitcoin-core-dev
135 2016-07-27T12:25:22  *** Ginnarr has quit IRC
136 2016-07-27T12:27:52  *** anu0 has quit IRC
137 2016-07-27T12:37:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
138 2016-07-27T12:41:02  *** Chris_Stewart_5 has quit IRC
139 2016-07-27T12:41:14  <wumpus> jonasschnelli: yes I was planning to test it, will do so
140 2016-07-27T12:41:24  <jonasschnelli> Thanks
141 2016-07-27T12:45:06  *** fengling has quit IRC
142 2016-07-27T12:59:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
143 2016-07-27T13:02:12  <wumpus> jonasschnelli: a small nit: cVjNjjiDXCsTZKVP3VzjH3PPdNdeS7t51RXJ6rt99GgnzaTFtrxz 2016-07-27T13:00:33Z label= # addr=mfZRKaG9dfW5xEqUWiJFFFohe8XXoW297N hdkeypath: m/0'/0'/0'
144 2016-07-27T13:02:28  <wumpus> let's format it hdkeypath= instead of hdkeypath:
145 2016-07-27T13:02:33  <wumpus> that's more consistent
146 2016-07-27T13:02:47  <jonasschnelli> ah. right. Let me change that directly
147 2016-07-27T13:03:23  <wumpus> thanks
148 2016-07-27T13:03:43  <wumpus> apart from that it works, tested with a non-HD and a HD wallet
149 2016-07-27T13:03:59  <jonasschnelli> wumpus: what do you think about changing "oldhdmaster" to "inactivehdmaster"?
150 2016-07-27T13:04:15  <jonasschnelli> oldhdmaster sound not ideal
151 2016-07-27T13:04:28  <wumpus> yes seems more on-point
152 2016-07-27T13:04:39  <jonasschnelli> okay. Will change that as well
153 2016-07-27T13:04:51  *** Guyver2 has joined #bitcoin-core-dev
154 2016-07-27T13:05:08  <wumpus> it not so much matters whether old or new, just that it's not used at the moment
155 2016-07-27T13:05:49  <wumpus> or maybe a more heretical idea: number the master keys, and store what master key was used with the key metadata
156 2016-07-27T13:06:09  <wumpus> maybe for 0.14
157 2016-07-27T13:07:08  <jonasschnelli> wumpus: yes. Though about that. But would add nother "long" string to each line
158 2016-07-27T13:07:20  <jonasschnelli> or we could add an index to each master key (for simplification)
159 2016-07-27T13:08:05  <wumpus> yes indeed my idea was an index/handle, not the full master key id
160 2016-07-27T13:08:54  <wumpus> that would indeed be ugly, and would take up significant extra space in the metadata
161 2016-07-27T13:09:01  <jonasschnelli> Yes. This would make sense for 0.14 I guess.
162 2016-07-27T13:09:36  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/8206 is featureish and I think we only backport it to 0.13 because of possible complains because of lack of exporting the xpriv
163 2016-07-27T13:10:16  <wumpus> yes I agree we don't want to do this for 0.13
164 2016-07-27T13:10:19  <wumpus> it was just a wild idea
165 2016-07-27T13:10:39  <wumpus> for 8206 let's just fix the output format and merge it
166 2016-07-27T13:12:02  <jonasschnelli> wumpus: I think 8206 is ready now
167 2016-07-27T13:13:09  <wumpus> re-testing
168 2016-07-27T13:18:38  <wumpus> jonasschnelli: cRv7Mpp7w5vtf4y8joSPs6kwGZAuKfPa76GzhGS7Vecq3ss4t5Fh 2016-07-27T13:00:33Z reserve=1 # addr=mpEFHw5CXTi69tHcZm62x9DJgbQewP731j hdkeypath= m/0'/0'/1'
169 2016-07-27T13:18:46  <wumpus> I think that's a space too much after = :)
170 2016-07-27T13:19:09  <jonasschnelli> Damit... :) force pushed.
171 2016-07-27T13:19:32  <jonasschnelli> ah. Forgot "git add".
172 2016-07-27T13:19:40  <jonasschnelli> wumpus: now pushed
173 2016-07-27T13:26:13  <GitHub44> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/beadffae6d65...4d4970fe530a
174 2016-07-27T13:26:13  <GitHub44> bitcoin/master 77c912d Jonas Schnelli: [Wallet] add HD xpriv to dumpwallet
175 2016-07-27T13:26:14  <GitHub44> bitcoin/master 4d4970f Wladimir J. van der Laan: Merge #8206: [Wallet] Add HD xpriv to dumpwallet...
176 2016-07-27T13:26:18  <GitHub179> [bitcoin] laanwj closed pull request #8206: [Wallet] Add HD xpriv to dumpwallet (master...2016/06/hd_info) https://github.com/bitcoin/bitcoin/pull/8206
177 2016-07-27T13:27:16  <jonasschnelli> wumpus: does 77c912d apply cleanly to 0.13 (should)? Just tell me if you want me to open a PR against 0.13
178 2016-07-27T13:27:35  <wumpus> going to try
179 2016-07-27T13:29:25  <wumpus> seems to just apply
180 2016-07-27T13:41:25  <GitHub42> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/18b8ee1cd1b2c95faac53e49b9023200679f2bb1
181 2016-07-27T13:41:25  <GitHub42> bitcoin/0.13 18b8ee1 Jonas Schnelli: [Wallet] add HD xpriv to dumpwallet...
182 2016-07-27T13:41:31  *** fengling has joined #bitcoin-core-dev
183 2016-07-27T13:42:58  *** YOU-JI has joined #bitcoin-core-dev
184 2016-07-27T13:43:22  *** jtimon has joined #bitcoin-core-dev
185 2016-07-27T13:46:26  *** fengling has quit IRC
186 2016-07-27T13:48:56  *** Squidicc is now known as squidicuz
187 2016-07-27T13:52:53  <wumpus> 8389 needs rebase
188 2016-07-27T14:03:25  <jonasschnelli> rebased
189 2016-07-27T14:07:25  *** Chris_Stewart_5 has quit IRC
190 2016-07-27T14:09:10  *** YOU-JI has quit IRC
191 2016-07-27T14:21:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
192 2016-07-27T14:26:23  <wumpus> jonasschnelli: did you see my remark here: https://github.com/bitcoin/bitcoin/pull/8407/files#r72257114  ... I'm not sure what settings.value(strSettingsVersionKey) returns in the case !settings.contains(strSettingsVersionKey), but if it's garbage or raises an exception this may be problematic
193 2016-07-27T14:31:12  <jonasschnelli> wumpus: yes saw it. But I thought the second expression in the if gets not executed if the first one (.contains()) fails. It's an OR.
194 2016-07-27T14:31:51  <wumpus> yes that is true, but look inside the {} there is another settings.value(strSettingsVersionKey)
195 2016-07-27T14:32:02  <wumpus> if (settings.value(strSettingsVersionKey) < 130000 &&  ...
196 2016-07-27T14:32:22  <jonasschnelli> Ah. Right!
197 2016-07-27T14:32:45  <jonasschnelli> That needs to be fixed. Will do soon (afk/phone typing).
198 2016-07-27T14:32:56  <wumpus> yes, no hurry
199 2016-07-27T14:43:04  *** fengling has joined #bitcoin-core-dev
200 2016-07-27T14:44:48  *** laurentmt has quit IRC
201 2016-07-27T14:47:46  *** fengling has quit IRC
202 2016-07-27T14:59:09  *** zooko has quit IRC
203 2016-07-27T15:00:04  *** laurentmt has joined #bitcoin-core-dev
204 2016-07-27T15:00:05  *** laurentmt has quit IRC
205 2016-07-27T15:17:29  *** Chris_Stewart_5 has quit IRC
206 2016-07-27T15:28:48  *** TomMc has joined #bitcoin-core-dev
207 2016-07-27T15:33:46  *** murch has joined #bitcoin-core-dev
208 2016-07-27T15:39:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
209 2016-07-27T15:45:06  *** fengling has joined #bitcoin-core-dev
210 2016-07-27T15:47:04  *** Chris_Stewart_5 has quit IRC
211 2016-07-27T15:47:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
212 2016-07-27T15:50:06  *** fengling has quit IRC
213 2016-07-27T16:05:16  *** Cory has quit IRC
214 2016-07-27T16:08:12  *** murch has quit IRC
215 2016-07-27T16:17:12  *** Chris_Stewart_5 has quit IRC
216 2016-07-27T16:31:31  *** gijensen is now known as gijensen3
217 2016-07-27T16:33:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
218 2016-07-27T16:33:44  *** gijensen3 is now known as gijensen2
219 2016-07-27T16:33:53  <GitHub191> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/0179a39f9da1fa417a592e7bf3ebbb1390a292b9
220 2016-07-27T16:33:53  <GitHub191> bitcoin/0.13 0179a39 Wladimir J. van der Laan: qt: periodic translations update
221 2016-07-27T16:34:30  *** Cory has joined #bitcoin-core-dev
222 2016-07-27T16:35:34  *** gijensen2 is now known as gijensen3
223 2016-07-27T16:40:20  *** netzin has joined #bitcoin-core-dev
224 2016-07-27T16:43:25  *** slackircbridge1 has quit IRC
225 2016-07-27T16:43:31  *** slackircbridge has joined #bitcoin-core-dev
226 2016-07-27T16:46:32  *** fengling has joined #bitcoin-core-dev
227 2016-07-27T16:51:06  *** fengling has quit IRC
228 2016-07-27T16:52:10  *** laurentmt has joined #bitcoin-core-dev
229 2016-07-27T16:52:52  *** laurentmt has quit IRC
230 2016-07-27T16:56:55  *** Cory has quit IRC
231 2016-07-27T17:17:02  *** Cory has joined #bitcoin-core-dev
232 2016-07-27T17:33:32  *** aalex__ has joined #bitcoin-core-dev
233 2016-07-27T17:34:08  *** d_t has joined #bitcoin-core-dev
234 2016-07-27T17:34:52  *** aalex_ has quit IRC
235 2016-07-27T17:36:26  *** d_t has joined #bitcoin-core-dev
236 2016-07-27T17:44:24  *** jtimon has quit IRC
237 2016-07-27T17:47:31  *** fengling has joined #bitcoin-core-dev
238 2016-07-27T17:48:14  *** netzin has quit IRC
239 2016-07-27T17:52:26  *** fengling has quit IRC
240 2016-07-27T17:53:22  *** eenoch has quit IRC
241 2016-07-27T17:53:33  *** eenoch has joined #bitcoin-core-dev
242 2016-07-27T17:54:10  *** kadoban has joined #bitcoin-core-dev
243 2016-07-27T18:00:32  *** menix01 has quit IRC
244 2016-07-27T18:01:50  *** netzin has joined #bitcoin-core-dev
245 2016-07-27T18:02:45  *** goatpig has joined #bitcoin-core-dev
246 2016-07-27T18:03:36  <goatpig> hi
247 2016-07-27T18:04:09  <goatpig> you don't need the mask and flag when creating a tx with only segwit outputs, do you?
248 2016-07-27T18:04:27  <goatpig> as in, no segwit inputs redeeming, only creating segwit outputs
249 2016-07-27T18:04:32  <goatpig> non nested
250 2016-07-27T18:07:36  *** jtimon has joined #bitcoin-core-dev
251 2016-07-27T18:13:24  <luke-jr> goatpig: that is my understanding, correct
252 2016-07-27T18:14:01  <luke-jr> furthermore, I think you can even include such outputs in non-segwit blocks. albeit, they would be vulnerable to easy theft until segwit activates.
253 2016-07-27T18:14:18  <luke-jr> (but it's possible to mine non-segwit blocks even after segwit activates, so not entirely useless)
254 2016-07-27T18:15:10  <goatpig> in this case they would just behave as anyone can spend wouldn't they? at least until miners start enforcing segwit rules
255 2016-07-27T18:17:14  <luke-jr> right
256 2016-07-27T18:17:40  <goatpig> so the proper guideline would be to add mask and flag when creating non nested segwit outputs, regardless of inputs?
257 2016-07-27T18:18:08  <luke-jr> even after segwit activates, libblkmaker will produce non-segwit blocks if there are no witness-as-input transactions being mined
258 2016-07-27T18:18:16  <gmaxwell> Well they're non-standard currently.
259 2016-07-27T18:18:35  <luke-jr> goatpig: I don't understand your question there
260 2016-07-27T18:18:46  <goatpig> im thinking for after segwit is activated, I don't intent to allow ppl to create SW tx with Armory until a few weeks after that happens on the mainnet
261 2016-07-27T18:18:59  <luke-jr> IIRC, it's invalid to have dummy/flag if there's no witness data for inputs
262 2016-07-27T18:19:08  <goatpig> luke-jr: oic
263 2016-07-27T18:19:19  <luke-jr> (I could be wrong on that, but IIRC)
264 2016-07-27T18:19:42  <goatpig> wouldn't that mean that you can't mix regular and sw outputs in a same tx?
265 2016-07-27T18:19:58  <luke-jr> goatpig: no, you can have dummy/flag so long as at least one input needs witness data
266 2016-07-27T18:20:06  <goatpig> ok
267 2016-07-27T18:20:33  <goatpig> aight that sums it for me
268 2016-07-27T18:20:35  <goatpig> thanks for the help
269 2016-07-27T18:31:41  *** jannes has quit IRC
270 2016-07-27T18:45:37  *** laurentmt has joined #bitcoin-core-dev
271 2016-07-27T18:45:50  *** laurentmt has quit IRC
272 2016-07-27T18:49:03  *** fengling has joined #bitcoin-core-dev
273 2016-07-27T18:53:46  *** fengling has quit IRC
274 2016-07-27T19:08:44  *** OxADADA has quit IRC
275 2016-07-27T19:09:12  *** OxADADA has joined #bitcoin-core-dev
276 2016-07-27T19:46:10  <jtimon> mhmm, there's a bitcoinconsensus_SCRIPT_FLAGS_VERIFY_WITNESS but not a bitcoinconsensus_SCRIPT_VERIFY_CHECKSEQUENCEVERIFY in script/bitcoinconsensus.h...
277 2016-07-27T19:49:38  <sipa> jtimon: good point, we should fix that
278 2016-07-27T19:50:18  <jtimon> I'll PR it, just wanted to confirm first
279 2016-07-27T19:50:23  <jtimon> sipa: thanks
280 2016-07-27T19:50:40  *** fengling has joined #bitcoin-core-dev
281 2016-07-27T19:51:18  <jtimon> actually found out while adapting my consensus branch to ScriptFlagsFromConsensus()as discussed (WIP)
282 2016-07-27T19:55:06  *** fengling has quit IRC
283 2016-07-27T20:03:48  *** cryptapus has quit IRC
284 2016-07-27T20:03:50  *** goatpig has quit IRC
285 2016-07-27T20:13:06  *** d_t has quit IRC
286 2016-07-27T20:24:21  *** anu0 has joined #bitcoin-core-dev
287 2016-07-27T20:27:12  *** anu1 has quit IRC
288 2016-07-27T20:28:33  *** d_t has joined #bitcoin-core-dev
289 2016-07-27T20:36:34  *** Chris_Stewart_5 has quit IRC
290 2016-07-27T20:51:35  *** fengling has joined #bitcoin-core-dev
291 2016-07-27T20:53:12  *** owowo has quit IRC
292 2016-07-27T20:54:21  *** owowo has joined #bitcoin-core-dev
293 2016-07-27T20:56:26  *** fengling has quit IRC
294 2016-07-27T21:02:12  *** owowo has quit IRC
295 2016-07-27T21:08:57  *** BashCo_ has quit IRC
296 2016-07-27T21:13:39  <GitHub48> [bitcoin] jtimon opened pull request #8412: libconsensus: Expose a flag for BIP112 (master...0.13-consensus-bip112-flag) https://github.com/bitcoin/bitcoin/pull/8412
297 2016-07-27T21:14:09  <jtimon> does this little thing break rc1?
298 2016-07-27T21:23:57  *** droark has quit IRC
299 2016-07-27T21:25:21  *** BashCo has joined #bitcoin-core-dev
300 2016-07-27T21:31:22  *** owowo has joined #bitcoin-core-dev
301 2016-07-27T21:35:58  *** belcher has joined #bitcoin-core-dev
302 2016-07-27T21:49:36  <GitHub132> [bitcoin] jtimon opened pull request #8413: Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (master...0.13-consensus-last-params) https://github.com/bitcoin/bitcoin/pull/8413
303 2016-07-27T21:53:05  *** fengling has joined #bitcoin-core-dev
304 2016-07-27T21:57:46  *** fengling has quit IRC
305 2016-07-27T21:59:13  *** spudowiar has joined #bitcoin-core-dev
306 2016-07-27T22:13:30  *** Guyver2 has quit IRC
307 2016-07-27T22:18:01  <jtimon> btcdrak: quick question https://github.com/bitcoin/bitcoin/pull/8412#issuecomment-235738474
308 2016-07-27T22:19:21  *** TomMc has quit IRC
309 2016-07-27T22:26:57  <jtimon> never mind, updated without bip112 at the end
310 2016-07-27T22:32:45  *** TomMc has joined #bitcoin-core-dev
311 2016-07-27T22:37:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
312 2016-07-27T22:52:48  *** d_t has quit IRC
313 2016-07-27T22:54:05  *** fengling has joined #bitcoin-core-dev
314 2016-07-27T22:58:46  *** fengling has quit IRC
315 2016-07-27T23:32:16  *** cdecker has quit IRC
316 2016-07-27T23:32:27  <GitHub43> [bitcoin] kazcw opened pull request #8414: prepend license statement to indirectmap.h (master...indirectmap-license) https://github.com/bitcoin/bitcoin/pull/8414
317 2016-07-27T23:35:27  *** fengling has joined #bitcoin-core-dev
318 2016-07-27T23:55:02  *** netzin has quit IRC