1 2016-08-26T00:20:34  *** [Author] has quit IRC
  2 2016-08-26T00:32:21  *** belcher has quit IRC
  3 2016-08-26T00:32:30  *** Giszmo has quit IRC
  4 2016-08-26T00:33:40  *** Giszmo has joined #bitcoin-core-dev
  5 2016-08-26T00:47:40  <phantomcircuit> luke-jr, im looking at the wallet accounting tests (which afaict you wrote)
  6 2016-08-26T00:47:52  <phantomcircuit> im confused by things like vpwtx[0]->nTimeReceived = (unsigned int)1333333335;
  7 2016-08-26T00:48:11  <phantomcircuit> it seems like the unit test is mucking around with the internals of the wallet?
  8 2016-08-26T00:51:47  *** spudowiar has quit IRC
  9 2016-08-26T00:52:40  *** justanotheruser has quit IRC
 10 2016-08-26T00:53:19  *** justanotheruser has joined #bitcoin-core-dev
 11 2016-08-26T00:57:49  *** [Author] has joined #bitcoin-core-dev
 12 2016-08-26T01:08:43  *** arowser has joined #bitcoin-core-dev
 13 2016-08-26T01:21:04  *** achow101 has quit IRC
 14 2016-08-26T01:25:00  <GitHub143> [bitcoin] rebroad opened pull request #8595: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8595
 15 2016-08-26T01:28:47  <luke-jr> phantomcircuit: could be
 16 2016-08-26T01:39:41  *** pmienk has quit IRC
 17 2016-08-26T01:48:50  *** sanada` has joined #bitcoin-core-dev
 18 2016-08-26T01:50:23  *** btcdrak has quit IRC
 19 2016-08-26T01:50:40  *** sanada has quit IRC
 20 2016-08-26T01:51:19  *** pmienk has joined #bitcoin-core-dev
 21 2016-08-26T01:54:19  <kanzure> 16:54 < saurik> so, I just spent a bunch of time making certain I didn't miss anything via IRC, and I've also checked e-mail. were they intending to tell me anything? I am kind of in shock that of all projects, bitcoin, another open source project, is now continuing the pattern of "we found something mysterious that we fixed that we don't bother mentioning directly to upstream"
 22 2016-08-26T01:54:19  *** Samdney has left #bitcoin-core-dev
 23 2016-08-26T01:54:25  <kanzure> 18:53 < kanzure> saurik: bitcoin core just a bunch of people hanging out on irc doing stuff. so i pinged you about it.
 24 2016-08-26T01:54:49  <kanzure> i mean.. i don't expect how else to inform upstream other than sending messages :P.
 25 2016-08-26T01:55:40  <gmaxwell> mindrays.
 26 2016-08-26T01:56:09  <kanzure> shh don't tell them about my mind rays
 27 2016-08-26T01:57:38  *** Chris_Stewart_5 has quit IRC
 28 2016-08-26T01:57:47  <midnightmagic> i thought they were my mindrays
 29 2016-08-26T01:57:54  <midnightmagic> D-:
 30 2016-08-26T01:58:04  <Squidicuz> woah.. full frontal lobotomy button, and now mindrays?!
 31 2016-08-26T01:59:42  *** achow101 has joined #bitcoin-core-dev
 32 2016-08-26T02:02:37  <midnightmagic> we are.. groot?
 33 2016-08-26T02:05:05  <phantomcircuit> kanzure, what's he even talking about?
 34 2016-08-26T02:05:27  <kanzure> don't speak so ill of the lobotomy</nobel prize committee>
 35 2016-08-26T02:05:38  <kanzure> (actually i'm joking. no idea why that got the nobel prize.)
 36 2016-08-26T02:05:43  <kanzure> phantomcircuit: osx code signing O_o
 37 2016-08-26T02:06:04  <phantomcircuit> kanzure, you see you should have connected to his personal irc server
 38 2016-08-26T02:06:27  <kanzure> actually you're right, there really is an irc.saurik.com
 39 2016-08-26T02:07:08  <midnightmagic> :-o
 40 2016-08-26T02:12:07  <luke-jr> kanzure: a pull request? :P
 41 2016-08-26T02:13:30  <cfields_> kanzure: i fully intended to upstream it
 42 2016-08-26T02:13:51  <cfields_> kanzure: what channel? I'll ping him to discuss
 43 2016-08-26T02:16:28  <midnightmagic> I dunno if he really knows what it means to invite rando bitcoiners in to his IRC. :(
 44 2016-08-26T02:19:08  *** dcousens has joined #bitcoin-core-dev
 45 2016-08-26T02:19:32  <dcousens> is there any way to turn off pretty-printing in the bitcoind RPC JSON?
 46 2016-08-26T02:19:32  *** Giszmo has quit IRC
 47 2016-08-26T02:19:50  <kanzure> cfields_: pm
 48 2016-08-26T02:20:08  <cfields_> thanks
 49 2016-08-26T02:20:29  <kanzure> cfields_: btw i don't think it's urgent; i just found his response funny :).
 50 2016-08-26T02:21:39  <cfields_> kanzure: sure, i'd just like him to understand that I planned to PR it, but it's just a bunch of hard-coded hacks still
 51 2016-08-26T02:23:53  <phantomcircuit> dcousens, ?
 52 2016-08-26T02:25:15  <GitHub198> [bitcoin] rebroad opened pull request #8596: Feeler code and debugging. (master...FeelerFixes) https://github.com/bitcoin/bitcoin/pull/8596
 53 2016-08-26T02:31:55  <dcousens> phantomcircuit: nevermind, its just bitcoin-cli being smart :)
 54 2016-08-26T02:52:15  *** btcdrak has joined #bitcoin-core-dev
 55 2016-08-26T02:56:29  *** ryan-c has quit IRC
 56 2016-08-26T02:57:00  *** dcousens has quit IRC
 57 2016-08-26T02:59:01  *** dcousens has joined #bitcoin-core-dev
 58 2016-08-26T03:01:36  *** [Author] has quit IRC
 59 2016-08-26T03:01:36  *** fengling has quit IRC
 60 2016-08-26T03:05:55  *** ryan-c has joined #bitcoin-core-dev
 61 2016-08-26T03:06:05  *** [Author] has joined #bitcoin-core-dev
 62 2016-08-26T03:06:06  *** fengling has joined #bitcoin-core-dev
 63 2016-08-26T03:10:10  <phantomcircuit> dcousens, yeah i think univalue always produces a single line
 64 2016-08-26T03:10:44  <dcousens> phantomcircuit: yup, my bad, went into tcpdump and yeah its not pretty printed over the wire which is all I cared about
 65 2016-08-26T03:11:40  *** justanotheruser has quit IRC
 66 2016-08-26T03:11:58  *** justanotheruser has joined #bitcoin-core-dev
 67 2016-08-26T03:17:48  <phantomcircuit> dcousens, as someone who is very guilty of this
 68 2016-08-26T03:17:55  <phantomcircuit> i usually fine that if something looks dumb it is not
 69 2016-08-26T03:18:04  <phantomcircuit> except when it is
 70 2016-08-26T03:19:00  <dcousens> phantomcircuit: haha, yup.  I need to put the rubber duck back on my desk,  it usually gets most of my stupid questions before I branch out haha
 71 2016-08-26T03:35:56  *** tom3 has quit IRC
 72 2016-08-26T03:36:02  <phantomcircuit> luke-jr, indeed i think the unit tests are broken
 73 2016-08-26T03:36:12  <phantomcircuit> or rather are testing the behaviour too specifically
 74 2016-08-26T03:37:07  <luke-jr> "too specifically" is often subjective. ☺
 75 2016-08-26T03:38:34  *** moli has quit IRC
 76 2016-08-26T03:39:45  <gmaxwell> not really, ideally a test fails when the software is broken and only fails in those cases, passes when the software is not broken and only passes in those cases.
 77 2016-08-26T03:40:05  <gmaxwell> this is an objective standard you can judge a test against, even if its not usually achievable for most functions.
 78 2016-08-26T03:43:03  <gmaxwell> it can be useful, at times, to have test functions which define 'broken' as 'changes in any way at all'; but thats special and not usually a good requirement for tests; especially for functions which you intend to actually change.
 79 2016-08-26T03:53:31  *** Alopex has quit IRC
 80 2016-08-26T03:54:36  *** Alopex has joined #bitcoin-core-dev
 81 2016-08-26T03:55:50  <phantomcircuit> luke-jr, can you explain why it's testing wtx nTimeReceived ?
 82 2016-08-26T03:57:56  <luke-jr> gmaxwell: IMO there's a grey area smart times fall into. you don't care about the exact behaviour or even exact results per se, but you probably do need to test for exact results to know the results are sane.
 83 2016-08-26T03:58:50  <luke-jr> phantomcircuit: what file/module is this?
 84 2016-08-26T03:59:12  <gmaxwell> luke-jr: if you can't define "sane" better than "same as before" -- can anyone really know if the code is right or not? :P
 85 2016-08-26T03:59:17  <phantomcircuit> luke-jr, src/wallet/test/accounting_tests.cpp
 86 2016-08-26T03:59:19  <gmaxwell> (and could it ever be updated?)
 87 2016-08-26T04:00:14  <gmaxwell> I don't think it's necessarily bad to have tests that do nothing but tell you if something changed, but if thats all we have, then we don't really have tests that are useful for anything except maybe refactoring.
 88 2016-08-26T04:00:24  <luke-jr> gmaxwell: for example, some payment protocol could possibly provide better time estimate to a user that was offline at the time
 89 2016-08-26T04:00:50  <gmaxwell> Consider, you intentionally change a function.  Exact behavior tests fail, well "no shit"-- but was your change correct or not? the 'test' gives you no insight-- it just told you something you already knew.
 90 2016-08-26T04:02:37  <luke-jr> phantomcircuit: it's testing that nTimeReceived either does or doesn't influence the sorting order as it should[n't]
 91 2016-08-26T04:03:25  <luke-jr> gmaxwell: in this case, it's creating CWalletTxs, adding them to the wallet, and checking the sort comes out correct
 92 2016-08-26T04:04:43  <luke-jr> (I was wrong thinking it was doing smart fee stuff; it's sort order)
 93 2016-08-26T04:10:25  *** moli has joined #bitcoin-core-dev
 94 2016-08-26T04:14:06  *** fengling has quit IRC
 95 2016-08-26T04:17:02  *** fengling has joined #bitcoin-core-dev
 96 2016-08-26T04:17:59  <phantomcircuit> luke-jr, is there something that describes how the smart time stuff works?
 97 2016-08-26T04:20:08  <luke-jr> phantomcircuit: not besides the code, AFAIK. essentially when a new transaction is seen, it uses the earlier of the block time or received/current time, unless that's before the time of the most recent known transaction (within reason)
 98 2016-08-26T04:20:23  <luke-jr> if the most recent known transaction is newer, it won't go backward
 99 2016-08-26T04:20:30  <luke-jr> unless it's significantly earlier, IIRC 15 minutes or so
100 2016-08-26T04:20:54  *** achow101 has quit IRC
101 2016-08-26T04:39:46  *** fengling has quit IRC
102 2016-08-26T04:48:35  *** fengling has joined #bitcoin-core-dev
103 2016-08-26T04:54:06  *** Alopex has quit IRC
104 2016-08-26T04:55:12  *** Alopex has joined #bitcoin-core-dev
105 2016-08-26T04:56:54  <phantomcircuit> luke-jr, so you're simulating the blocktime?
106 2016-08-26T05:20:37  *** Alopex has quit IRC
107 2016-08-26T05:21:42  *** Alopex has joined #bitcoin-core-dev
108 2016-08-26T05:22:26  *** fengling has quit IRC
109 2016-08-26T05:29:44  *** dcousens has quit IRC
110 2016-08-26T05:54:33  *** paveljanik has quit IRC
111 2016-08-26T05:56:26  *** harrymm has quit IRC
112 2016-08-26T06:04:15  *** fengling has joined #bitcoin-core-dev
113 2016-08-26T06:12:51  *** harrymm has joined #bitcoin-core-dev
114 2016-08-26T06:19:40  *** mturquette has quit IRC
115 2016-08-26T06:19:59  *** mturquette has joined #bitcoin-core-dev
116 2016-08-26T06:21:28  *** crescendo has quit IRC
117 2016-08-26T06:21:52  *** crescendo has joined #bitcoin-core-dev
118 2016-08-26T06:26:12  *** harrymm has quit IRC
119 2016-08-26T06:30:23  *** btcdrak has quit IRC
120 2016-08-26T06:31:26  <jonasschnelli> gmaxwell: Though about the idea of the BLOB (encrypted key) stored in the wallet and passed to the signer. Do you propose that signing operations will be done in a separate process (or application) by handing over the required tx data and the encrypted private key?
121 2016-08-26T06:32:32  <gmaxwell> Yes. And the signer program has you confirm the transaction, enter the passphrase, returns the result.
122 2016-08-26T06:32:48  <gmaxwell> and it can have 100% mlocked memory, be highly sandboxed, etc.
123 2016-08-26T06:33:12  <jonasschnelli> How do the encrypted private keys get there in the first place?
124 2016-08-26T06:33:53  <gmaxwell> It generates them and gives the blob to the wallet, like you were thinking with 'getnewaddress'... but there would be an 'init' or 'initwallet' call.
125 2016-08-26T06:35:14  <jonasschnelli> So the signing device creates the encrypted keys,... what the reason of passing them to the wallet instead of keeping track (storing) them in the signers space?
126 2016-08-26T06:35:32  <jonasschnelli> *whats
127 2016-08-26T06:35:33  *** BashCo has quit IRC
128 2016-08-26T06:35:50  <jonasschnelli> Ah. mlocked mem
129 2016-08-26T06:35:54  <gmaxwell> because then you have two files to backup for you wallet, and now the signer needs filesystem access.
130 2016-08-26T06:36:06  *** fengling has quit IRC
131 2016-08-26T06:37:20  <jonasschnelli> gmaxwell: Yes. I think this would be a nice add-on. Would be nice if the transport layer would be flexible enough to also support hardware wallets.
132 2016-08-26T06:37:34  <jonasschnelli> Hardware wallet will probably not export encrypted private keys.
133 2016-08-26T06:37:41  <jonasschnelli> So the "blob" could be optional.
134 2016-08-26T06:37:43  <gmaxwell> Yes. Also third party co-signers... or at least extended to that eventually.
135 2016-08-26T06:38:10  <gmaxwell> yes, it would be optional, but-- I dunno, perhaps a reasonable way to construct a low cost hardware wallet-- why give it any flash? all rom. :)
136 2016-08-26T06:38:27  <jonasschnelli> IMO the main problem with co-signing is the missing infrastructure for the communication layer, how to pass partial-signed transaction to the co-signer, etc.
137 2016-08-26T06:38:56  <jonasschnelli> The problem with the blob storing encrypted keys is the backward and forward-security IMO
138 2016-08-26T06:39:23  <jonasschnelli> A leaked encryption password will result in compromising everything
139 2016-08-26T06:40:08  <GitHub61> [bitcoin] rebroad opened pull request #8597: [WIP] Move code from VERACK to VERSION (since VERACK is not requied) (master...NotDependentOnVerack) https://github.com/bitcoin/bitcoin/pull/8597
140 2016-08-26T06:40:14  <jonasschnelli> I'd personally prefer only keeping pub-keys in my wallet and sign on a different system where the priv-keys are not exposed to many I/Os
141 2016-08-26T06:40:33  *** harrymm has joined #bitcoin-core-dev
142 2016-08-26T06:55:43  *** fengling has joined #bitcoin-core-dev
143 2016-08-26T06:56:39  <luke-jr> phantomcircuit: I'm not sure - do smart fees even have tests?
144 2016-08-26T06:56:45  <luke-jr> smart times*
145 2016-08-26T06:56:55  *** BashCo has joined #bitcoin-core-dev
146 2016-08-26T07:05:03  <phantomcircuit> luke-jr, the accounting stuff appears to be th eonly thing testing them
147 2016-08-26T07:05:07  <phantomcircuit> and really it shouldn't be
148 2016-08-26T07:05:24  <phantomcircuit> it should at most be testing that they have the expected order
149 2016-08-26T07:06:31  <luke-jr> oh, the commit itself describes it: c3f95ef13f48d21db53992984976eac93e7a08fc
150 2016-08-26T07:12:26  *** fengling has quit IRC
151 2016-08-26T07:17:04  *** fengling has joined #bitcoin-core-dev
152 2016-08-26T07:27:30  *** laurentmt has joined #bitcoin-core-dev
153 2016-08-26T07:27:38  <GitHub134> [bitcoin] jonasschnelli closed pull request #8135: [OSX] fix make deploy when compiling on OSX (master...2016/06/makedeploy) https://github.com/bitcoin/bitcoin/pull/8135
154 2016-08-26T07:29:56  *** laurentmt has quit IRC
155 2016-08-26T07:31:15  *** JackH has joined #bitcoin-core-dev
156 2016-08-26T07:34:22  <GitHub48> [bitcoin] fivepiece opened pull request #8598: Fix displaying of invalid and non-minimal small pushes as numbers (master...fixasm) https://github.com/bitcoin/bitcoin/pull/8598
157 2016-08-26T07:35:17  <arubi> <- ^, if anyone has questions
158 2016-08-26T07:37:53  <jonasschnelli> arubi: just commented that some tests would be nice
159 2016-08-26T07:38:04  <arubi> yep.  I'll have a look!
160 2016-08-26T07:38:09  <jonasschnelli> thanks
161 2016-08-26T07:42:27  *** btcdrak has joined #bitcoin-core-dev
162 2016-08-26T07:44:34  <GitHub164> [bitcoin] laanwj closed pull request #8595: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8595
163 2016-08-26T07:45:10  *** isis has joined #bitcoin-core-dev
164 2016-08-26T07:50:18  <jonasschnelli> I'd like to merge https://github.com/bitcoin/bitcoin/pull/8371 soon... thanks for reviews
165 2016-08-26T07:52:52  *** neha has quit IRC
166 2016-08-26T07:55:06  *** neha has joined #bitcoin-core-dev
167 2016-08-26T07:55:42  *** Guyver2 has joined #bitcoin-core-dev
168 2016-08-26T07:59:59  *** arowser has quit IRC
169 2016-08-26T08:00:12  <jonasschnelli> sipa: Changing nCoinCacheUsage outside of the init process should be possible (assume covered under a LOCK)? What do you think in having two values, one for in-sync, one for catching up... maybe an additional -dbcacheinsync?
170 2016-08-26T08:00:51  *** kadoban has quit IRC
171 2016-08-26T08:01:12  <jonasschnelli> I guess sudden reduction of nCoinCacheUsage will just result in writing the state during the next FlushStateToDisk() while "overshooting" the new set target during the time until we do the next FlushStateToDisk()?
172 2016-08-26T08:01:27  *** arowser has joined #bitcoin-core-dev
173 2016-08-26T08:02:10  <sipa> use an atomic instead of a lock
174 2016-08-26T08:02:58  <jonasschnelli> sipa: Indeed. What do you think about -dbcacheinsync?
175 2016-08-26T08:03:37  <gmaxwell> I don't think I've ever seen a user report that would really be helped by that.
176 2016-08-26T08:03:40  <jonasschnelli> Not sure if we should change nCoinDBCache and nBlockTreeDBCache during "runtime"
177 2016-08-26T08:03:59  <gmaxwell> I think we'd be using a much larger dbcache except we want to work correctly on the common 2gb hosts and vpses.
178 2016-08-26T08:04:16  <gmaxwell> and those hosts would crash during sync if it was bigger during sync.
179 2016-08-26T08:04:37  <sipa> i actually would want a separate dbcache value in IBD on my phone :)
180 2016-08-26T08:04:39  <gmaxwell> now-- allowing the dbcache to use memory the mempool isn't using-- that would be a useful stunt.
181 2016-08-26T08:04:50  <GitHub129> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/53f8f226bd1d...6c9f1b8c2405
182 2016-08-26T08:04:50  <GitHub129> bitcoin/master 259ee09 R E Broadley: Show "end" instead of many zeros when getheaders request received with a hashStop of Null.
183 2016-08-26T08:04:51  <GitHub129> bitcoin/master 6c9f1b8 Wladimir J. van der Laan: Merge #8561: Show "end" instead of many zeros when getheaders request received with a hashStop of Null...
184 2016-08-26T08:04:54  <gmaxwell> but wouldn't need an option (hurray)
185 2016-08-26T08:05:05  <GitHub110> [bitcoin] laanwj closed pull request #8561: Show "end" instead of many zeros when getheaders request received with a hashStop of Null (master...LessGetheadersZeros) https://github.com/bitcoin/bitcoin/pull/8561
186 2016-08-26T08:05:25  <jonasschnelli> I started adding a DBCache option during the intro screen on the GUI... And I think users don't want to "waste" 2GB (example) during in-sync state... but they may want 2GB during IBD.
187 2016-08-26T08:05:57  <sipa> i think 2GB is not much anymore for most desktop systems
188 2016-08-26T08:06:09  <sipa> but there are others
189 2016-08-26T08:06:21  <gmaxwell> on systems where you're okay using that at ~any~ point, it's probably not a bad idea at all times. :(
190 2016-08-26T08:06:38  <gmaxwell> keep in mind too small a dbcache is responsible for some of the io thrashing users frequently complain about.
191 2016-08-26T08:06:50  <phantomcircuit> sipa, it would actually be nice to have a "stall" function for things which regularly overheat
192 2016-08-26T08:07:10  <sipa> phantomcircuit: you shouldn't run a full node on hardware that overheats
193 2016-08-26T08:07:29  <phantomcircuit> sipa, that covers virtually all phones and most laptops
194 2016-08-26T08:07:32  <gmaxwell> sipa: that excludes about 75% of laptops available commercially now.
195 2016-08-26T08:07:41  <jonasschnelli> ;-)
196 2016-08-26T08:07:43  <phantomcircuit> the thermal protection stuff isn't designed for continuous load
197 2016-08-26T08:07:50  <sipa> heh
198 2016-08-26T08:08:08  <gmaxwell> only a few makers actually build hardware that can stat sustained load. (your lenovo being such an example)
199 2016-08-26T08:08:16  <gmaxwell> s/stat/stand/
200 2016-08-26T08:08:33  <gmaxwell> though it doesn't crash when overheating.
201 2016-08-26T08:08:37  <gmaxwell> mostly.
202 2016-08-26T08:08:44  <phantomcircuit> gmaxwell, 10:1 his lenovo is not designed for continuous max load either
203 2016-08-26T08:08:59  <gmaxwell> phantomcircuit: the t-series are.
204 2016-08-26T08:09:12  <gmaxwell> the x1 isn't, as I'm sure you've noticed.
205 2016-08-26T08:09:13  <sipa> i have a w540
206 2016-08-26T08:09:18  <gmaxwell> sipa: those too.
207 2016-08-26T08:09:18  <phantomcircuit> i have indeed
208 2016-08-26T08:09:33  <phantomcircuit> the t series is not generally designed for max tdp actually
209 2016-08-26T08:09:36  <phantomcircuit> they're more like 80%
210 2016-08-26T08:09:41  <phantomcircuit> the x1 is maybe 50%
211 2016-08-26T08:09:49  <phantomcircuit> a w450 probably is
212 2016-08-26T08:09:52  <phantomcircuit> 540
213 2016-08-26T08:09:53  <phantomcircuit> whatever
214 2016-08-26T08:10:09  <gmaxwell> in any case, what about the suggestion I made about dbcache using unused mempool space?
215 2016-08-26T08:10:22  <gmaxwell> that basically matches the sync and cachup use case... and doesn't add parameters.
216 2016-08-26T08:10:23  <sipa> ugh.
217 2016-08-26T08:10:36  <phantomcircuit> gmaxwell, eh we should just fix this and have a unified "memory usage" thing
218 2016-08-26T08:10:41  <gmaxwell> It's only stupidly hard, have courage.
219 2016-08-26T08:10:43  <phantomcircuit> implement out own oom killer
220 2016-08-26T08:10:44  <phantomcircuit> :P
221 2016-08-26T08:10:49  <phantomcircuit> our
222 2016-08-26T08:10:56  <sipa> now normal transaction relay can trigger utxo flushing
223 2016-08-26T08:11:05  <sipa> actually, it already does
224 2016-08-26T08:11:22  <gmaxwell> yea, well if the flushing were ... less dumb, that wouldn't be a big deal.
225 2016-08-26T08:12:36  <gmaxwell> what I'm suggesting could be something kinda dumb, like, when the mempool goes over 10MB. take the 290 MB away from the dbcache, flushing once. and then go on with life.
226 2016-08-26T08:14:27  <phantomcircuit> gmaxwell, i tried making it less dumb and broke one of the unit tests
227 2016-08-26T08:14:32  <phantomcircuit> i dont think what i did was broken actually
228 2016-08-26T08:15:36  <gmaxwell> one can analyize the blockchain history to evaluate candidate eviction policies.
229 2016-08-26T08:16:07  <phantomcircuit> gmaxwell, yeah my eviction policy was random eviction
230 2016-08-26T08:16:12  <phantomcircuit> but even that broke the tests
231 2016-08-26T08:16:14  <phantomcircuit> so idk
232 2016-08-26T08:16:26  <gmaxwell> you need to carefully handle dirty entries.
233 2016-08-26T08:16:44  *** laurentmt has joined #bitcoin-core-dev
234 2016-08-26T08:20:27  <gmaxwell> phantomcircuit: random eviction is probably pretty bad. I was thinking of taking age, total value, remaining txouts, then fitting a piecewise linear model to create an eviction score that gives the best hitrate when tested against the historical chain with some simulated cache size.
235 2016-08-26T08:20:40  *** MarcoFalke has joined #bitcoin-core-dev
236 2016-08-26T08:20:57  *** laurentmt has quit IRC
237 2016-08-26T08:22:07  *** laurentmt has joined #bitcoin-core-dev
238 2016-08-26T08:22:34  *** neha has quit IRC
239 2016-08-26T08:24:30  *** Megaf has joined #bitcoin-core-dev
240 2016-08-26T08:24:44  *** neha has joined #bitcoin-core-dev
241 2016-08-26T08:29:18  <jonasschnelli> sipa: regarding your profiles idea: https://github.com/bitcoin/bitcoin/issues/8437, how could setting profile values make sense? I guess in bitcoin.conf would be ideal (not another file), this would mean, it must be something like -profile0-par or -profile1-maxconnections, etc.
242 2016-08-26T08:29:20  <phantomcircuit> gmaxwell, i just ignored dirty entries
243 2016-08-26T08:29:25  <phantomcircuit> still broke the unit tests
244 2016-08-26T08:30:16  *** murch has joined #bitcoin-core-dev
245 2016-08-26T08:34:20  <sipa> jonasschnelli: the profiles would just be hardcoded
246 2016-08-26T08:34:27  <gmaxwell> considering the tests work fine if you twiddle the dbcache size, you screwed something up. Perhaps you were dropping things while views existed.
247 2016-08-26T08:34:47  <sipa> the only option you have is selecting which profile to ude
248 2016-08-26T08:34:49  <jonasschnelli> sipa: this seems not to scale,..
249 2016-08-26T08:34:55  <sipa> how so?
250 2016-08-26T08:35:18  <jonasschnelli> If it covers DBCache, we would need to adjust the static value over time
251 2016-08-26T08:35:30  <sipa> why?
252 2016-08-26T08:36:00  <sipa> it corresponds to the amount of resources it can use
253 2016-08-26T08:36:30  <jonasschnelli> Lets say, we have a hardcoded profile "large", it could cover 2GB dbcache,.. in 3 years, the UTXO set is larger, computers have more RAM...
254 2016-08-26T08:36:47  <sipa> ok, then we occasionally update the profole
255 2016-08-26T08:36:53  <sipa> or add a "verylarge"
256 2016-08-26T08:36:57  <jonasschnelli> heh
257 2016-08-26T08:37:14  <sipa> allowing people to modify the profile seems to defeat the prupose
258 2016-08-26T08:37:16  <jonasschnelli> Not sure if I like hardcoded values...
259 2016-08-26T08:37:28  <sipa> why don't they just modify the settings directly?
260 2016-08-26T08:37:36  <jonasschnelli> Whats the advantage over -profile0-dbcache (could still have hardcoded defaults)
261 2016-08-26T08:37:56  <sipa> why would you have -profile0-dbcache, and not just... -dbcache ?
262 2016-08-26T08:38:08  <sipa> if you're going to override it, override it
263 2016-08-26T08:38:13  <jonasschnelli> Okay.. I see .. let me explain.
264 2016-08-26T08:38:22  <jonasschnelli> I'd like to have switchable profile...
265 2016-08-26T08:38:51  <jonasschnelli> Some users might want to run in blocksonly (or par=1) during a time when they want to use the system for different purposes
266 2016-08-26T08:39:04  <jonasschnelli> Then, switch back to a different profile when their system is idling
267 2016-08-26T08:39:04  <sipa> mobile phones used to have configurable profiles... for different times of the day, for special contants, ...
268 2016-08-26T08:39:16  <sipa> nobody used those as they take way too much time to maintain
269 2016-08-26T08:39:28  <gmaxwell> I feel like it's a mistake to optimize for users going in and twiddling detailed settings at runtime. Thats adding a feature less than 1% of users would use at all, and half of those who would use it would probably use it in confused ways.
270 2016-08-26T08:39:31  <jonasschnelli> Yes. You could set your "low bandwith" profile to take affect during 23:00 - 06:00 or so
271 2016-08-26T08:39:45  <sipa> and phones switched back to very simple things, like 3 preconfigured ones
272 2016-08-26T08:39:51  <jonasschnelli> Remember when we had the PR for "pause network activity"
273 2016-08-26T08:40:16  <jonasschnelli> I guess there are some users out there who like to change the resource consumption during runtime.
274 2016-08-26T08:40:23  <sipa> the point of profiles is to allow people to have more control with fewer tweakable
275 2016-08-26T08:40:27  <sipa> not mkre knobs
276 2016-08-26T08:40:44  <sipa> ok, so make the profile switchable at runtime
277 2016-08-26T08:41:32  <gmaxwell> jonasschnelli: yes, though often even that is someone trying to rationalize their suffering from something else we've screwed up.
278 2016-08-26T08:41:33  <jonasschnelli> Yes. Switchable during runtime makes sense... but I don't understand why there should be no optional -profile0-par, default overwrite option
279 2016-08-26T08:42:08  <gmaxwell> So for example, bandwidth bursts are distrubing their VoIP, so they ask for a pause. We can provide, but 1% of the users having the problem will find it and use it, the rest will suffer or just remove bitcoin.
280 2016-08-26T08:42:09  <sipa> jonasschnelli: pfft we could add that, but i think it's a waste of time
281 2016-08-26T08:42:55  <jonasschnelli> My goal is that people will not shut down bitcoin-qt in order to do a VoIP call (because restarting in pain in the ass).
282 2016-08-26T08:43:05  <gmaxwell> time spent setting up and maintaining knobs for a tiny pool of highly advanced users would usually be better spent figuring out the root issues that drive them to have any reason to customize at all.
283 2016-08-26T08:43:28  <jonasschnelli> Not sure if this feature would be for highly advanced users...
284 2016-08-26T08:43:43  <jonasschnelli> It could be a "turtle icon" somewhere with a tooltip "use less resources"...
285 2016-08-26T08:43:44  <gmaxwell> then we should fix it so that it doesn't screw up voip, _generally_, even when they don't know bitcoin is the cause, not by finding some obscure option.
286 2016-08-26T08:43:48  <sipa> jonasschnelli: that's why we have compact blocks and not pause network :)
287 2016-08-26T08:44:00  *** spudowiar has joined #bitcoin-core-dev
288 2016-08-26T08:44:22  <gmaxwell> if you've figured out that bitcoin is the cause you are already more advanced than we should hope for, usually once they've figured that out bitcoin is doomed. :P
289 2016-08-26T08:44:39  <jonasschnelli> Yes. But IMO is a fact that people have stopped running bitcoin-qt because of its extensive resource consumption. But maybe I'm wrong here.
290 2016-08-26T08:44:54  <gmaxwell> I feel like you're not listening to me. :(
291 2016-08-26T08:45:40  <jonasschnelli> I agree with fixing it in the first place... but some stuff is on a layer not controllable by our stack.. like QoS.
292 2016-08-26T08:45:49  <gmaxwell> I agree that they have, but they will continue to stop running it unless the resource consumption is improved--  adding some advanced profile things will save a few users, but not that many.
293 2016-08-26T08:46:07  <jonasschnelli> Partially agree on that.
294 2016-08-26T08:46:30  <gmaxwell> and exposing many settings to users actually complicates improving resource management, since we have to figure out how to handle changing the sensible parameters.
295 2016-08-26T08:46:37  <jonasschnelli> A non-dump dbcache option would be significant more worth then a dbcache profile option
296 2016-08-26T08:56:20  *** laurentmt has quit IRC
297 2016-08-26T08:56:33  <sipa> i don't think there is any problem with providing options to modify what the profiles correspond wth, and perhaps there is a good use for it... but having profiles in the first place is so much more valuable
298 2016-08-26T08:57:03  <sipa> right now, almost no user modify dbcache, and even less know that there are half a dozen other settings that affect memory usage
299 2016-08-26T08:57:17  <sipa> don't get carried away with configurability
300 2016-08-26T08:57:38  <sipa> the problem we're facing is that most users don't even touch the few settings we do have, adding more won't improve that
301 2016-08-26T08:57:52  <phantomcircuit> gmaxwell, hmm maybe i was dropping things while a view existed?
302 2016-08-26T08:57:53  <MarcoFalke> What about -maxtotalmem, and bitcoind will figure out how to use that  memory on it's own?
303 2016-08-26T08:57:55  <phantomcircuit> im not sure actually
304 2016-08-26T08:58:22  <sipa> MarcoFalke: except we don't have good accounting for all of the memory yet
305 2016-08-26T08:58:30  <jonasschnelli> Yes. Maybe in the GUI intro we can offer a switch between "low" (default), "moderate" (1GB cache,...) and "height" (3GB cache).
306 2016-08-26T08:58:48  <sipa> MarcoFalke: and it is pretty hard to do due to memory fragmentation etc
307 2016-08-26T08:58:59  <gmaxwell> consider, if _we_ knew how to set all these things, we'd set them and not bother writing and translating UI for them..  but if we don't know how to set them, the user almost certantly doesn't.
308 2016-08-26T08:59:22  <sipa> jonasschnelli: yes, that's what i propose
309 2016-08-26T08:59:32  <sipa> jonasschnelli: but it could affect a few more options than dbcache
310 2016-08-26T08:59:48  <gmaxwell> MarcoFalke: ultimately thats what we should have, but it's hard. (and probably can't be done without changing to jemalloc, ... memory accounting was a big reason firefox changed to jemalloc, in fact)
311 2016-08-26T08:59:49  <jonasschnelli> Okay. What happens if a user sets profile "hight" (3GiB) and has only 2GB wired ram?
312 2016-08-26T09:00:00  <jonasschnelli> sipa: yes. more options..
313 2016-08-26T09:00:09  <sipa> jonasschnelli: no, less options
314 2016-08-26T09:00:17  <sipa> jonasschnelli: there is low, medium, and high
315 2016-08-26T09:00:28  <jonasschnelli> yes. I meant more values that are affected by the profiles.
316 2016-08-26T09:00:36  <jonasschnelli> -par, -maxuploadtarget, etc.
317 2016-08-26T09:00:37  <sipa> and each corresponds to a preset oglf settings for mempool, dbcache, maxconnections, ...
318 2016-08-26T09:00:40  <sipa> exactly
319 2016-08-26T09:00:54  <sipa> we could do a quick test
320 2016-08-26T09:01:22  <sipa> but i don't know if physical memory is portably detectable
321 2016-08-26T09:02:04  <sipa> allocate a gilb and see how fast a random walk through it is? :)
322 2016-08-26T09:02:30  * jonasschnelli :|
323 2016-08-26T09:02:41  *** Megaf is now known as }[-_-]{
324 2016-08-26T09:03:09  <sipa> *gb
325 2016-08-26T09:03:22  <gmaxwell> too bad container objects basically force runtime allocation. :(
326 2016-08-26T09:04:21  <phantomcircuit> sipa, what are the assumptions CCoinsViewCache makes about it's contents?
327 2016-08-26T09:04:38  <phantomcircuit> if something isn't marked dirty i assumed it could just be removed
328 2016-08-26T09:04:40  <phantomcircuit> is this wrong?
329 2016-08-26T09:06:37  <sipa> yes, unless there is another view on top
330 2016-08-26T09:06:49  <sipa> in that case you are not allowed to modify it in any way
331 2016-08-26T09:15:54  <jonasschnelli> grml... bitcoind: sync.cpp:125: void potential_deadlock_detected(const std::pair<void*, void*>&, const LockStack&, const LockStack&): Assertion `onlyMaybeDeadlock' failed.
332 2016-08-26T09:15:54  <jonasschnelli> Aborted
333 2016-08-26T09:15:59  <jonasschnelli> current master
334 2016-08-26T09:16:22  <jonasschnelli> http://pastebin.com/YCVFK5KY
335 2016-08-26T09:17:05  <jonasschnelli> Before I updated to current master, it was running for a couple of weeks,.. just updated an ran into the deadlock assertion
336 2016-08-26T09:17:23  <sipa> jonasschnelli: open an issue so we don't forgrt
337 2016-08-26T09:17:35  <jonasschnelli> ok
338 2016-08-26T09:18:31  *** }[-_-]{ has quit IRC
339 2016-08-26T09:21:03  <GitHub123> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c9f1b8c2405...c19f8a4a7795
340 2016-08-26T09:21:04  <GitHub123> bitcoin/master 4c3e2cb R E Broadley: Show XTHIN in GUI
341 2016-08-26T09:21:04  <GitHub123> bitcoin/master c19f8a4 Wladimir J. van der Laan: Merge #8583: Show XTHIN in GUI...
342 2016-08-26T09:21:14  <GitHub63> [bitcoin] laanwj closed pull request #8583: Show XTHIN in GUI (master...ShowXTHINinGUI) https://github.com/bitcoin/bitcoin/pull/8583
343 2016-08-26T09:21:14  <jonasschnelli> sipa: maybe my fault.. I'm running https://github.com/bitcoin/bitcoin/pull/7685/files on top
344 2016-08-26T09:22:13  <GitHub197> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c19f8a4a7795...65837375d98b
345 2016-08-26T09:22:14  <GitHub197> bitcoin/master fab5ecb MarcoFalke: [wallet] rpc: Drop misleading option
346 2016-08-26T09:22:14  <GitHub197> bitcoin/master 6583737 Wladimir J. van der Laan: Merge #8581: [wallet] rpc: Drop misleading option...
347 2016-08-26T09:22:30  <GitHub156> [bitcoin] laanwj closed pull request #8581: [wallet] rpc: Drop misleading option (master...Mf1608-walletDropRpc) https://github.com/bitcoin/bitcoin/pull/8581
348 2016-08-26T09:33:41  <GitHub65> [bitcoin] MarcoFalke opened pull request #8600: [0.13.1]: Backport [wallet] rpc: Drop misleading option (0.13...Mf1608-walletRpcDropBackport) https://github.com/bitcoin/bitcoin/pull/8600
349 2016-08-26T09:47:41  *** Megaf has joined #bitcoin-core-dev
350 2016-08-26T10:01:02  *** Guyver2 has quit IRC
351 2016-08-26T10:13:46  *** [Author] has quit IRC
352 2016-08-26T10:17:05  *** spudowiar is now known as cc
353 2016-08-26T10:17:13  *** cc is now known as spudowiar
354 2016-08-26T10:17:32  <GitHub161> [bitcoin] laanwj opened pull request #8601: Add option to opt into full-RBF when sending funds (rebase) (master...2016_08_full_rbf_option) https://github.com/bitcoin/bitcoin/pull/8601
355 2016-08-26T10:17:51  <GitHub138> [bitcoin] laanwj closed pull request #7132: Add option to opt into full-RBF when sending funds (master...2015-11-opt-into-full-rbf-option) https://github.com/bitcoin/bitcoin/pull/7132
356 2016-08-26T10:35:02  *** moli has quit IRC
357 2016-08-26T10:43:58  *** cryptapus_afk has quit IRC
358 2016-08-26T10:47:51  * MarcoFalke likes sipa's new GitHub icon
359 2016-08-26T10:51:18  <phantomcircuit> sipa, how can you tell if there's another view on top?
360 2016-08-26T10:51:20  <phantomcircuit> also, why?
361 2016-08-26T10:54:42  *** cryptapus_afk has joined #bitcoin-core-dev
362 2016-08-26T10:57:53  <sipa> phantomcircuit: uh.. i can't say for sure. i've swapped out the understanding that resulting in that code :)
363 2016-08-26T10:58:18  <sipa> phantomcircuit: but there is an extensive random simulation test; if you can integrate your pruning into that, you're likely to find any errors
364 2016-08-26T10:58:36  <sipa> as to knowing when there is another view on top... don't call it from connectblock or anything below
365 2016-08-26T11:01:22  <phantomcircuit> sipa, hasModifier?
366 2016-08-26T11:02:31  <sipa> no
367 2016-08-26T11:02:42  <sipa> hasModifier is when there is a modifier :)
368 2016-08-26T11:03:04  <sipa> which is a RAII object to have an automatic cleanup after modifying an entry
369 2016-08-26T11:03:54  <sipa> still, these caches don't do any locking, so they're not safe to modify from multiple threads
370 2016-08-26T11:04:32  <sipa> and if you're doing cleanup from the same thread as the modifications are happening, you'll know when there is another cache on top just by the place of the code
371 2016-08-26T11:08:26  *** fengling has quit IRC
372 2016-08-26T11:24:38  <GitHub41> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65837375d98b...12892dbb9fb6
373 2016-08-26T11:24:38  <GitHub41> bitcoin/master fa6dc9f MarcoFalke: Remove unused variables
374 2016-08-26T11:24:38  <GitHub41> bitcoin/master 12892db Wladimir J. van der Laan: Merge #8590: Remove unused variables...
375 2016-08-26T11:24:52  <GitHub7> [bitcoin] laanwj closed pull request #8590: Remove unused variables (master...Mf1608-unusedCode) https://github.com/bitcoin/bitcoin/pull/8590
376 2016-08-26T11:27:24  <GitHub87> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/f2306fbe0142...122fdfdae915
377 2016-08-26T11:27:24  <GitHub87> bitcoin/0.13 526d2b0 MarcoFalke: [wallet] rpc: Drop misleading option...
378 2016-08-26T11:27:24  <GitHub7> [bitcoin] laanwj closed pull request #8600: [0.13.1]: Backport [wallet] rpc: Drop misleading option (0.13...Mf1608-walletRpcDropBackport) https://github.com/bitcoin/bitcoin/pull/8600
379 2016-08-26T11:27:25  <GitHub87> bitcoin/0.13 122fdfd Wladimir J. van der Laan: Merge #8600: [0.13.1]: Backport [wallet] rpc: Drop misleading option...
380 2016-08-26T11:36:12  <phantomcircuit> sipa, i was trying to make the change in ccoinsviewcache so it's triggered whenever usage goes above the limit
381 2016-08-26T11:37:34  <phantomcircuit> so it wouldn't know where it is
382 2016-08-26T11:38:12  <phantomcircuit> i guess i could add something to the constructor to call down to the base view and increment a counter in each
383 2016-08-26T11:38:36  <wumpus> btcdrak: do you have a plan for https://github.com/bitcoin/bitcoin/pull/7562?
384 2016-08-26T11:38:52  <wumpus> I think it's still relevant?
385 2016-08-26T11:40:01  <GitHub44> [bitcoin] laanwj closed pull request #8227: tests: Re-enable RPC tests for Windows (master...2016_05_win_reenable_rpc_tests) https://github.com/bitcoin/bitcoin/pull/8227
386 2016-08-26T11:42:03  <GitHub56> [bitcoin] fanquake opened pull request #8602: [trivial][doc] Mention ++i as preferred over i++ in dev notes (master...trvial-dev-notes) https://github.com/bitcoin/bitcoin/pull/8602
387 2016-08-26T11:43:20  *** cryptapus_afk is now known as cryptapus
388 2016-08-26T11:47:55  <sipa> can i haz ack on #8524 ?
389 2016-08-26T11:48:09  *** Megaf has quit IRC
390 2016-08-26T11:49:25  *** Megaf has joined #bitcoin-core-dev
391 2016-08-26T11:56:53  *** fengling has joined #bitcoin-core-dev
392 2016-08-26T12:01:26  *** fengling has quit IRC
393 2016-08-26T12:04:54  *** someone1337 has joined #bitcoin-core-dev
394 2016-08-26T12:10:02  *** someone1337 has quit IRC
395 2016-08-26T12:12:39  <GitHub9> [bitcoin] fanquake opened pull request #8603: [trivial][doc] Mention gpg --refresh-keys in release-process.md (master...release-process-refresh-keys) https://github.com/bitcoin/bitcoin/pull/8603
396 2016-08-26T12:17:16  *** moli has joined #bitcoin-core-dev
397 2016-08-26T12:24:23  *** [Author] has joined #bitcoin-core-dev
398 2016-08-26T12:27:45  *** fengling has joined #bitcoin-core-dev
399 2016-08-26T12:32:46  *** fengling has quit IRC
400 2016-08-26T12:44:20  *** Giszmo has joined #bitcoin-core-dev
401 2016-08-26T12:44:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
402 2016-08-26T12:59:55  *** jouke has quit IRC
403 2016-08-26T13:00:03  <phantomcircuit> sipa, ACK the number 8524 is excellent
404 2016-08-26T13:00:39  *** Samdney has joined #bitcoin-core-dev
405 2016-08-26T13:00:51  <phantomcircuit> sipa, is that a picture of you in a ball pit?
406 2016-08-26T13:01:49  *** jouke has joined #bitcoin-core-dev
407 2016-08-26T13:03:13  * sipa googles ball pit
408 2016-08-26T13:03:25  <sipa> phantomcircuit: yes
409 2016-08-26T13:29:39  *** fengling has joined #bitcoin-core-dev
410 2016-08-26T13:34:26  *** fengling has quit IRC
411 2016-08-26T13:38:14  *** tom3 has joined #bitcoin-core-dev
412 2016-08-26T13:46:07  <wumpus> heh, bitcoin can no longer be compiled with gcc 4.9.3 with OpenBSD's default max data segment limit of 1536MB
413 2016-08-26T13:46:15  <wumpus> (main.cpp)
414 2016-08-26T13:46:54  <sipa> FINALLY
415 2016-08-26T13:47:06  <wumpus> yes, a milestone
416 2016-08-26T13:47:41  <btcdrak> inb4 someone complains :)
417 2016-08-26T13:47:46  <wumpus> pushing the lmits of modern compiler technology
418 2016-08-26T13:54:31  <GitHub56> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12892dbb9fb6...fd37acaedab1
419 2016-08-26T13:54:31  <GitHub56> bitcoin/master c25083b fanquake: [trivial][doc] Mention gpg --refresh-keys in release-process.md
420 2016-08-26T13:54:32  <GitHub56> bitcoin/master fd37aca Wladimir J. van der Laan: Merge #8603: [trivial][doc] Mention gpg --refresh-keys in release-process.md...
421 2016-08-26T13:54:46  <GitHub169> [bitcoin] laanwj closed pull request #8603: [trivial][doc] Mention gpg --refresh-keys in release-process.md (master...release-process-refresh-keys) https://github.com/bitcoin/bitcoin/pull/8603
422 2016-08-26T13:54:55  <GitHub182> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd37acaedab1...bb566761fbe1
423 2016-08-26T13:54:55  <GitHub182> bitcoin/master ab53207 fanquake: [trivial][doc] Mention ++i as preferred to i++ in dev notes
424 2016-08-26T13:54:56  <GitHub182> bitcoin/master bb56676 Wladimir J. van der Laan: Merge #8602: [trivial][doc] Mention ++i as preferred over i++ in dev notes...
425 2016-08-26T13:55:06  <GitHub114> [bitcoin] laanwj closed pull request #8602: [trivial][doc] Mention ++i as preferred over i++ in dev notes (master...trvial-dev-notes) https://github.com/bitcoin/bitcoin/pull/8602
426 2016-08-26T13:55:36  <GitHub183> [bitcoin] laanwj closed pull request #8547: Update btcdrak key with new expiry dates (master...btcdrak-key) https://github.com/bitcoin/bitcoin/pull/8547
427 2016-08-26T13:59:11  <sipa> wth?
428 2016-08-26T13:59:11  <sipa> SyntaxError: Non-ASCII character '\xf0' in file /home/pw/git/bitcoin/qa/rpc-tests/test_framework/util.py on line 180, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
429 2016-08-26T14:04:20  <sipa> ah, i'm running with a python2 interpreter
430 2016-08-26T14:04:38  <sipa> those are still pretty weird characters to appear in source code...
431 2016-08-26T14:04:52  <cfields_> sipa: surely those chars are the least of your concerns, then? :)
432 2016-08-26T14:05:08  <wumpus> only python3 is supported for the RPC tests
433 2016-08-26T14:05:40  <sipa> yes, it works with python3
434 2016-08-26T14:05:40  <wumpus> for python2 it was necessary to define the character set at the top, python3 defaults to UTF-8
435 2016-08-26T14:05:59  <wumpus> (but yes, that's far from the only thing that prevents it from working in  2.x)
436 2016-08-26T14:06:14  <sipa> still, i'm baffled why we have unicode character u+1f4bb in our source code...
437 2016-08-26T14:06:35  <wumpus> probably to test RPC unicode support
438 2016-08-26T14:06:46  <cfields_> \xf0 does look suspiciously like typo'd hex
439 2016-08-26T14:07:20  <sipa> i doubt it: https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/test_framework/util.py#L170
440 2016-08-26T14:07:41  <cfields_> oh, huh
441 2016-08-26T14:07:52  <wumpus> that's to test that unicode characters work in username/password
442 2016-08-26T14:08:10  <cfields_> https://github.com/bitcoin/bitcoin/commit/fad184550e1c507a897be59169f9c5dabce8d652
443 2016-08-26T14:08:10  <sipa> ah
444 2016-08-26T14:10:24  <wumpus> if those funny characters work, then Chinese Russian etc certainly will (as they are in lower unicode planes)
445 2016-08-26T14:12:34  <cfields_> great. Soon every 13yr old's passwords will be filled with poop emojis, and we'll all have to account for that possibility.
446 2016-08-26T14:12:57  <wumpus> yes :-)
447 2016-08-26T14:13:32  <Chris_Stewart_5> lol
448 2016-08-26T14:14:11  <sipa> true ☺
449 2016-08-26T14:16:40  *** Samdney has quit IRC
450 2016-08-26T14:20:02  <kanzure> sipa: use "#encoding: utf8" at top of .py files for python2
451 2016-08-26T14:21:41  <wumpus> better to just not use python2 anymore :)
452 2016-08-26T14:22:30  <wumpus> but yes that works
453 2016-08-26T14:27:04  <kanzure> if you want to enforce definitely not using python2, then using a more explicit method might be good
454 2016-08-26T14:27:53  <kanzure> (import sys; sys.version_info.major)
455 2016-08-26T14:28:13  <GitHub154> [bitcoin] laanwj opened pull request #8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9 (master...2016_08_openbsd_update) https://github.com/bitcoin/bitcoin/pull/8604
456 2016-08-26T14:28:16  *** mkarrer has joined #bitcoin-core-dev
457 2016-08-26T14:29:21  <wumpus> I think there is a python version check in some scripts; though OTOH, most of them will probably error out on missing imports and other problems before they reach that
458 2016-08-26T14:31:11  *** fengling has joined #bitcoin-core-dev
459 2016-08-26T14:36:06  *** fengling has quit IRC
460 2016-08-26T14:49:08  *** jannes has quit IRC
461 2016-08-26T14:55:10  *** hybridsole has quit IRC
462 2016-08-26T15:01:42  *** hybridsole has joined #bitcoin-core-dev
463 2016-08-26T15:06:33  <phantomcircuit> sipa, i dont see why you cant remove things from a CCoinsCacheView (or whichever arrangement of words it is) which aren't dirty
464 2016-08-26T15:06:34  <phantomcircuit> like
465 2016-08-26T15:06:38  <phantomcircuit> logically that makes no sense
466 2016-08-26T15:08:30  <sipa> ok, maybe i'm wrong
467 2016-08-26T15:09:43  <phantomcircuit> you see now i am questioning my own sanity
468 2016-08-26T15:09:48  <phantomcircuit> god damned caching problems!
469 2016-08-26T15:15:23  <sipa> There are two hard things in computer science: cache invalidation, naming things, and off-by-one errors.
470 2016-08-26T15:30:03  *** laurentmt has joined #bitcoin-core-dev
471 2016-08-26T15:31:35  *** epopt has joined #bitcoin-core-dev
472 2016-08-26T15:32:45  *** fengling has joined #bitcoin-core-dev
473 2016-08-26T15:35:22  *** Samdney has joined #bitcoin-core-dev
474 2016-08-26T15:37:32  <instagibbs> are there any good summaries/discussions for tx relay DoS prevention in Core?
475 2016-08-26T15:37:46  *** fengling has quit IRC
476 2016-08-26T15:38:08  <instagibbs> esp wrt when certain things are checked in sequence
477 2016-08-26T15:38:42  *** jcorgan has quit IRC
478 2016-08-26T15:55:45  *** whphhg has quit IRC
479 2016-08-26T15:58:15  *** whphhg has joined #bitcoin-core-dev
480 2016-08-26T16:06:01  *** slackircbridge has quit IRC
481 2016-08-26T16:06:11  *** slackircbridge2 has joined #bitcoin-core-dev
482 2016-08-26T16:06:47  *** rinzes_ has joined #bitcoin-core-dev
483 2016-08-26T16:07:53  <rinzes_> I am trying to find out how to remove bitcoin core completely
484 2016-08-26T16:08:02  <rinzes_> windows 10
485 2016-08-26T16:09:02  <helo> rinzes_: #bitcoin
486 2016-08-26T16:09:04  <btcdrak> Control panel -> programs -> uninstall
487 2016-08-26T16:09:30  <rinzes_> will that remove the database and everything
488 2016-08-26T16:10:18  *** laurentmt has quit IRC
489 2016-08-26T16:13:46  <GitHub107> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bb566761fbe1...9a0ed08b40b1
490 2016-08-26T16:13:47  <GitHub107> bitcoin/master ff8d279 Pavel Janík: Do not shadow member variables
491 2016-08-26T16:13:47  <GitHub107> bitcoin/master 9a0ed08 Pieter Wuille: Merge #8109: Do not shadow member variables...
492 2016-08-26T16:13:51  <GitHub43> [bitcoin] sipa closed pull request #8109: Do not shadow member variables (master...20160527_shadow_httpserver) https://github.com/bitcoin/bitcoin/pull/8109
493 2016-08-26T16:16:39  *** rinzes_ has quit IRC
494 2016-08-26T16:17:20  *** laurentmt has joined #bitcoin-core-dev
495 2016-08-26T16:17:31  *** laurentmt has quit IRC
496 2016-08-26T16:29:30  *** BashCo has quit IRC
497 2016-08-26T16:29:57  *** BashCo has joined #bitcoin-core-dev
498 2016-08-26T16:34:08  *** fengling has joined #bitcoin-core-dev
499 2016-08-26T16:39:06  *** fengling has quit IRC
500 2016-08-26T17:03:12  *** kadoban has joined #bitcoin-core-dev
501 2016-08-26T17:11:01  *** davec has quit IRC
502 2016-08-26T17:18:34  <GitHub8> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a0ed08b40b1...c072b8fd95cd
503 2016-08-26T17:18:34  <GitHub8> bitcoin/master fa3d974 MarcoFalke: [doc] Update git-subtree-check.sh README
504 2016-08-26T17:18:35  <GitHub8> bitcoin/master c072b8f Pieter Wuille: Merge #8545: [doc] Update git-subtree-check.sh README...
505 2016-08-26T17:18:44  <GitHub93> [bitcoin] sipa closed pull request #8545: [doc] Update git-subtree-check.sh README (master...Mf1608-doc) https://github.com/bitcoin/bitcoin/pull/8545
506 2016-08-26T17:35:46  *** fengling has joined #bitcoin-core-dev
507 2016-08-26T17:40:46  *** fengling has quit IRC
508 2016-08-26T17:41:17  *** davec has joined #bitcoin-core-dev
509 2016-08-26T17:45:29  *** Megaf has quit IRC
510 2016-08-26T18:09:07  *** Guyver2_ has joined #bitcoin-core-dev
511 2016-08-26T18:10:12  <Lauda> Does the gitian build script from achow101 include everything now?
512 2016-08-26T18:13:25  <sipa> i believe it does
513 2016-08-26T18:14:09  <Lauda> I'll test now and post results then.
514 2016-08-26T18:14:10  <Lauda> Thanks
515 2016-08-26T18:20:58  *** BashCo has quit IRC
516 2016-08-26T18:34:40  *** pmienk has quit IRC
517 2016-08-26T18:37:16  *** fengling has joined #bitcoin-core-dev
518 2016-08-26T18:38:43  *** Guyver2_ is now known as Guyver2
519 2016-08-26T18:42:26  *** fengling has quit IRC
520 2016-08-26T18:44:20  *** JZA has joined #bitcoin-core-dev
521 2016-08-26T18:45:28  <arubi> I pushed a few unit tests ( https://github.com/bitcoin/bitcoin/pull/8598/commits ) that triggered an error in a specific travis build ( https://travis-ci.org/bitcoin/bitcoin/builds/155297369 ), I'm trying to build that environment to try and debug it, and I'd appreciate input as to what should I be looking for.  I was pretty surprised that adding tests caused something like that
522 2016-08-26T18:46:21  *** pmienk has joined #bitcoin-core-dev
523 2016-08-26T18:47:30  <arubi> specifically, it failed at: "Assertion failed: 449.99100000 != 999.980" when running 'qa/rpc-tests/segwit.py'
524 2016-08-26T18:48:32  <sipa> we've been seeing that test fail for a while
525 2016-08-26T18:48:56  <arubi> oh, so it might be that re-running it will pass then?
526 2016-08-26T18:51:04  <arubi> sipa, er, maybe I misunderstood.  it fails consistently?  I see other builds pass, and my previous pr passed
527 2016-08-26T18:53:14  <sipa> no, just occasionally
528 2016-08-26T18:54:11  <arubi> mhm.  well, the PR is ready then, if anyone finds it useful :)
529 2016-08-26T18:57:23  <sipa> great; will review in mmore detail
530 2016-08-26T18:57:39  <arubi> thanks!
531 2016-08-26T19:05:26  *** Megaf has joined #bitcoin-core-dev
532 2016-08-26T19:09:21  <GitHub103> [bitcoin] sipa opened pull request #8606: Fix some locks (master...lockfix) https://github.com/bitcoin/bitcoin/pull/8606
533 2016-08-26T19:10:01  <GitHub127> [bitcoin] MarcoFalke opened pull request #8607: [doc] Fix doxygen off-by-one comments, fix typos (master...Mf1608-trivial17) https://github.com/bitcoin/bitcoin/pull/8607
534 2016-08-26T19:15:02  *** BashCo has joined #bitcoin-core-dev
535 2016-08-26T19:15:49  <sipa> arubi: https://github.com/bitcoin/bitcoin/issues/8532
536 2016-08-26T19:16:30  *** achow101 has joined #bitcoin-core-dev
537 2016-08-26T19:16:49  *** spudowiar has quit IRC
538 2016-08-26T19:21:44  <arubi> sipa, I see, so this is some timing issue then?
539 2016-08-26T19:23:26  <arubi> I see tests passed now, phew :)
540 2016-08-26T19:30:32  *** Megaf has quit IRC
541 2016-08-26T19:46:45  *** Guyver2 has quit IRC
542 2016-08-26T19:48:10  *** achow101 has quit IRC
543 2016-08-26T19:55:37  <btcdrak> sipa: do you have any idea why changing the default transaction version to 2 would break these tests? https://gist.github.com/btcdrak/7aeeccf8b487d6058ab87e1d3fcf6c62
544 2016-08-26T20:01:40  *** mappum has quit IRC
545 2016-08-26T20:02:52  *** btcdrak has quit IRC
546 2016-08-26T20:03:30  *** eragmus has quit IRC
547 2016-08-26T20:13:48  *** pmienk has quit IRC
548 2016-08-26T20:16:43  *** pmienk has joined #bitcoin-core-dev
549 2016-08-26T20:23:26  <MarcoFalke> ugh
550 2016-08-26T20:23:45  <MarcoFalke> seeing segfaults while testing the stalling issue
551 2016-08-26T20:24:26  <sipa> can you run from gdb and inspect?
552 2016-08-26T20:24:54  <MarcoFalke> Would that work with trickle?
553 2016-08-26T20:25:01  <sipa> what is trickle?
554 2016-08-26T20:25:22  <sipa> ah, bandwidth manager
555 2016-08-26T20:25:36  <MarcoFalke> Jup, I need to simulate my "rural bandwith"
556 2016-08-26T20:25:43  <sipa> yes, you can run bitcoind normally, and then gdb bitcoind -p <pid>
557 2016-08-26T20:25:53  <MarcoFalke> ok
558 2016-08-26T20:25:56  <sipa> to attach to the existing process
559 2016-08-26T20:26:18  <sipa> when it segfaults, type 'bt' to see a backtrace
560 2016-08-26T20:26:23  * sipa afk for 5 minutes
561 2016-08-26T20:28:53  *** voids has joined #bitcoin-core-dev
562 2016-08-26T20:38:30  <gmaxwell> ::sigh:: "BU" ripped out the outbound connection limiting logic, so we can probably expect more ignorant users connecting to the whole darn network.
563 2016-08-26T20:40:18  *** fengling has joined #bitcoin-core-dev
564 2016-08-26T20:44:36  <luke-jr> :|
565 2016-08-26T20:45:06  *** fengling has quit IRC
566 2016-08-26T20:45:08  *** davec has quit IRC
567 2016-08-26T20:45:29  <gmaxwell> I'd try to encourage them to not do this, but they're so antagonistic towards me that I'm sure trying would just make them double down.
568 2016-08-26T20:45:48  *** davec has joined #bitcoin-core-dev
569 2016-08-26T20:47:11  *** mappum has joined #bitcoin-core-dev
570 2016-08-26T20:54:03  *** zooko has joined #bitcoin-core-dev
571 2016-08-26T21:03:19  *** eragmus has joined #bitcoin-core-dev
572 2016-08-26T21:10:23  *** btcdrak has joined #bitcoin-core-dev
573 2016-08-26T21:13:43  *** spudowiar has joined #bitcoin-core-dev
574 2016-08-26T21:15:04  *** Chris_Stewart_5 has quit IRC
575 2016-08-26T21:16:08  *** spudowiar has quit IRC
576 2016-08-26T21:16:20  *** spudowiar has joined #bitcoin-core-dev
577 2016-08-26T21:25:35  <MarcoFalke> sipa: Well, the trace does not look helpful? http://pastebin.ubuntu.com/23095029/
578 2016-08-26T21:26:13  <sipa> MarcoFalke: try 'thread apply all bt'
579 2016-08-26T21:28:26  <MarcoFalke> http://pastebin.ubuntu.com/23095049/
580 2016-08-26T21:28:31  <MarcoFalke> sipa: ^
581 2016-08-26T21:28:35  *** kyletorpey has joined #bitcoin-core-dev
582 2016-08-26T21:29:44  <sipa> MarcoFalke: that looks like a segfault inside trickle...
583 2016-08-26T21:30:49  <MarcoFalke> Ok, will try without trickle during the weekend
584 2016-08-26T21:36:25  <murch> sipa: I assume the P2WPKH is then 4 bytes/4 larger as well?
585 2016-08-26T21:37:57  <sipa> murch: presumably
586 2016-08-26T21:38:21  <murch> The sequence number is part of the discounted section, right?
587 2016-08-26T21:39:33  <sipa> no
588 2016-08-26T21:40:07  <sipa> since it is in non-witness inputs as well, it can't be discounted
589 2016-08-26T21:40:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
590 2016-08-26T21:41:54  *** fengling has joined #bitcoin-core-dev
591 2016-08-26T21:45:35  <luke-jr> hm, looks like AMD may beat Intel to SHA instructions
592 2016-08-26T21:46:02  <sipa> intel already has sha instructions?
593 2016-08-26T21:46:09  <luke-jr> sipa: not in any desktop CPU, AFAIK
594 2016-08-26T21:46:46  *** fengling has quit IRC
595 2016-08-26T21:47:30  <Lauda> http://i.imgur.com/jEid47S.png Does anyone have any ideas how to mitigate this?
596 2016-08-26T21:47:43  <Lauda> Seems an Upstart error is present in Ubuntu 14.0.4 and 15.10 in a VM.
597 2016-08-26T21:49:43  *** tom3 has quit IRC
598 2016-08-26T21:52:14  *** Chris_Stewart_5 has quit IRC
599 2016-08-26T21:54:16  *** cryptapus is now known as cryptapus_afk
600 2016-08-26T21:56:05  *** MarcoFalke has left #bitcoin-core-dev
601 2016-08-26T22:08:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
602 2016-08-26T22:09:29  *** spudowiar has quit IRC
603 2016-08-26T22:09:56  *** spudowiar1 has joined #bitcoin-core-dev
604 2016-08-26T22:10:18  *** spudowiar1 is now known as spudowiar
605 2016-08-26T22:17:46  * luke-jr wonders if there's a way to tell his node to only fetch blocks from CB peers
606 2016-08-26T22:22:34  *** achow101 has joined #bitcoin-core-dev
607 2016-08-26T22:26:15  *** zooko` has joined #bitcoin-core-dev
608 2016-08-26T22:43:11  *** fengling has joined #bitcoin-core-dev
609 2016-08-26T22:48:06  *** fengling has quit IRC
610 2016-08-26T22:50:49  *** zooko` has quit IRC
611 2016-08-26T22:51:24  *** zooko has quit IRC
612 2016-08-26T22:54:32  *** Alopex has quit IRC
613 2016-08-26T22:55:37  *** Alopex has joined #bitcoin-core-dev
614 2016-08-26T23:02:31  *** eragmus has quit IRC
615 2016-08-26T23:02:37  *** mappum has quit IRC
616 2016-08-26T23:03:40  *** btcdrak has quit IRC
617 2016-08-26T23:07:29  <murch> sipa: thanks
618 2016-08-26T23:15:09  *** eragmus has joined #bitcoin-core-dev
619 2016-08-26T23:19:59  *** mappum has joined #bitcoin-core-dev
620 2016-08-26T23:24:57  *** voids has quit IRC
621 2016-08-26T23:25:15  *** voids has joined #bitcoin-core-dev
622 2016-08-26T23:34:45  *** murch has quit IRC
623 2016-08-26T23:36:07  <gmaxwell> on PR #8606 did jonasschnelli find this before 0.13 was released and then we forgot it, or is this a new instance of a lock order inversion around cs_filter?
624 2016-08-26T23:36:38  *** CodeShark has quit IRC
625 2016-08-26T23:37:46  *** CodeShark has joined #bitcoin-core-dev
626 2016-08-26T23:44:47  *** fengling has joined #bitcoin-core-dev
627 2016-08-26T23:46:03  *** eragmus has quit IRC
628 2016-08-26T23:46:04  *** mappum has quit IRC
629 2016-08-26T23:49:46  *** fengling has quit IRC
630 2016-08-26T23:59:35  *** JZA has quit IRC