1 2016-09-06T00:12:24  *** fengling has joined #bitcoin-core-dev
  2 2016-09-06T00:16:46  *** fengling has quit IRC
  3 2016-09-06T00:24:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  4 2016-09-06T00:26:51  *** Ylbam has quit IRC
  5 2016-09-06T00:28:27  *** jtimon has quit IRC
  6 2016-09-06T00:43:17  *** jtimon has joined #bitcoin-core-dev
  7 2016-09-06T00:59:17  *** Alopex has quit IRC
  8 2016-09-06T00:59:39  *** jtimon has quit IRC
  9 2016-09-06T01:00:22  *** Alopex has joined #bitcoin-core-dev
 10 2016-09-06T01:13:26  *** fengling has joined #bitcoin-core-dev
 11 2016-09-06T01:18:06  *** fengling has quit IRC
 12 2016-09-06T01:29:01  *** Alopex has quit IRC
 13 2016-09-06T01:30:06  *** Alopex has joined #bitcoin-core-dev
 14 2016-09-06T01:30:07  *** aj has quit IRC
 15 2016-09-06T02:00:31  *** lightningbot has joined #bitcoin-core-dev
 16 2016-09-06T02:04:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 17 2016-09-06T02:07:45  *** fengling has joined #bitcoin-core-dev
 18 2016-09-06T02:09:06  *** TomMc has quit IRC
 19 2016-09-06T02:09:19  *** Chris_Stewart_5 has quit IRC
 20 2016-09-06T02:12:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 21 2016-09-06T02:31:10  *** Giszmo has quit IRC
 22 2016-09-06T02:37:01  *** Alopex has quit IRC
 23 2016-09-06T02:38:07  *** Alopex has joined #bitcoin-core-dev
 24 2016-09-06T03:02:17  *** Alopex has quit IRC
 25 2016-09-06T03:03:22  *** Alopex has joined #bitcoin-core-dev
 26 2016-09-06T03:03:38  *** [Author] has quit IRC
 27 2016-09-06T03:13:27  *** Alopex has quit IRC
 28 2016-09-06T03:14:32  *** Alopex has joined #bitcoin-core-dev
 29 2016-09-06T03:24:15  *** dcousens has joined #bitcoin-core-dev
 30 2016-09-06T03:28:06  *** kadoban has joined #bitcoin-core-dev
 31 2016-09-06T03:34:31  *** [Author] has joined #bitcoin-core-dev
 32 2016-09-06T03:39:45  *** Samdney has quit IRC
 33 2016-09-06T03:41:06  *** Alopex has quit IRC
 34 2016-09-06T03:42:11  *** Alopex has joined #bitcoin-core-dev
 35 2016-09-06T03:48:51  *** Chris_Stewart_5 has quit IRC
 36 2016-09-06T03:59:12  *** Alopex has quit IRC
 37 2016-09-06T04:00:17  *** Alopex has joined #bitcoin-core-dev
 38 2016-09-06T04:14:59  *** instagibbs has quit IRC
 39 2016-09-06T04:23:02  *** Alopex has quit IRC
 40 2016-09-06T04:24:07  *** Alopex has joined #bitcoin-core-dev
 41 2016-09-06T04:51:44  *** kadoban has quit IRC
 42 2016-09-06T05:09:14  *** dcousens has quit IRC
 43 2016-09-06T05:11:16  *** dcousens has joined #bitcoin-core-dev
 44 2016-09-06T05:22:01  *** Alopex has quit IRC
 45 2016-09-06T05:23:07  *** Alopex has joined #bitcoin-core-dev
 46 2016-09-06T05:24:08  *** spudowiar has quit IRC
 47 2016-09-06T05:33:17  *** Alopex has quit IRC
 48 2016-09-06T05:34:22  *** Alopex has joined #bitcoin-core-dev
 49 2016-09-06T05:55:03  *** mol has joined #bitcoin-core-dev
 50 2016-09-06T05:58:12  *** molz has quit IRC
 51 2016-09-06T05:58:44  *** Ylbam has joined #bitcoin-core-dev
 52 2016-09-06T06:12:06  *** Alopex has quit IRC
 53 2016-09-06T06:13:11  *** Alopex has joined #bitcoin-core-dev
 54 2016-09-06T06:40:56  *** instagibbs has joined #bitcoin-core-dev
 55 2016-09-06T06:55:55  *** BashCo has quit IRC
 56 2016-09-06T07:02:18  *** kyletorpey has quit IRC
 57 2016-09-06T07:13:35  *** BashCo has joined #bitcoin-core-dev
 58 2016-09-06T07:15:39  *** jtimon has joined #bitcoin-core-dev
 59 2016-09-06T07:26:24  *** jtimon has quit IRC
 60 2016-09-06T07:34:21  *** laurentmt has joined #bitcoin-core-dev
 61 2016-09-06T07:35:42  <gmaxwell> Anyone know what the status of cgminer solo mining segwit support is?
 62 2016-09-06T07:35:58  *** laurentmt has quit IRC
 63 2016-09-06T07:38:00  <sipa> Lightsword, cfields: ^
 64 2016-09-06T07:38:22  *** rubensayshi has joined #bitcoin-core-dev
 65 2016-09-06T07:51:09  <btcdrak> BlueMatt: you should do a presentation in Milan.
 66 2016-09-06T07:51:53  <gmaxwell> BlueMatt: I don't think fibre is at all obvious.
 67 2016-09-06T07:53:07  <sipa> by the time you've explained basic FEC, and how short ids are collision-resistant, you've already talked for half an hour
 68 2016-09-06T07:54:14  <sipa> oh, and tcp networking roundtrips
 69 2016-09-06T07:54:21  <gmaxwell> Head of line blocking of TCP and the hidden round trips at layer-3 is a good 15 minutes itself.
 70 2016-09-06T08:03:44  <Lightsword> gmaxwell, sipa, cgminer solo doesn’t support segwit yet not sure if anyone was planning on adding support
 71 2016-09-06T08:14:18  *** paveljanik has quit IRC
 72 2016-09-06T08:24:04  *** mol has quit IRC
 73 2016-09-06T09:02:31  <jonasschnelli> sipa: Do you tell me your secret how you measure consumed cpu cycled by a certain C function with gdb?
 74 2016-09-06T09:02:59  <sipa> jonasschnelli: don't benchmark while using gdb
 75 2016-09-06T09:03:29  <jonasschnelli> sipa: Ah. Okay. But how do you measure consumed cycles then?
 76 2016-09-06T09:03:46  <sipa> 1) run it many times (like benchmarking tools do)
 77 2016-09-06T09:04:15  <jonasschnelli> Using rdtsc?
 78 2016-09-06T09:04:21  <sipa> 2) use rdtsc asm instruction to read the time stamp counter on the CPU and lock your CPU to a single frequency; this gives you sub-nanosecond precision
 79 2016-09-06T09:04:48  <jonasschnelli> Okay... I'll give it a try
 80 2016-09-06T09:05:18  <sipa> the bitcoin and libsecp256k1 benchmark tools just run many times, and give you minimum, maximum and average run time
 81 2016-09-06T09:05:31  <sipa> i have a script that pins my cpu frequency to a single number
 82 2016-09-06T09:05:49  <sipa> and then i just stop other processes on my system until the the minimum and average are close enough to not matter
 83 2016-09-06T09:06:12  <jonasschnelli> I guess depending on rdtsc means a system under heavy load (not the tests) will result in biased results?
 84 2016-09-06T09:06:21  <jonasschnelli> Okay.
 85 2016-09-06T09:06:33  <sipa> rdtsc is only useful for microbenchmarks
 86 2016-09-06T09:06:43  <sipa> as it will occasionally incorporate the time of a context switch
 87 2016-09-06T09:06:48  <jonasschnelli> Do you have that CPU freq script in a gist or so?
 88 2016-09-06T09:07:02  <jonasschnelli> (though not sure if that works 1:1 on my OSX machine)
 89 2016-09-06T09:07:13  <sipa> /etc/init.d/cpufrequtils stop
 90 2016-09-06T09:07:14  <sipa> for A in $(seq 0 7); do cpufreq-set -c $A -g performance -d 2.6GHz -u 2.6GHz; done
 91 2016-09-06T09:07:25  <sipa> it's linux specific and cpu specific
 92 2016-09-06T09:07:36  <jonasschnelli> okay... I play with it. Thanks
 93 2016-09-06T09:08:18  <sipa> for bigger things i just add GetTimeMicros() before and after the code in bitcoind, and log the difference to debug.log
 94 2016-09-06T09:08:21  <jonasschnelli> would benchmarking in a "quite" VM (fresh install, headless almost no background processes) result in more comparable results?
 95 2016-09-06T09:08:34  <sipa> i wouldn't use VMs for benchmarking
 96 2016-09-06T09:09:14  <jonasschnelli> Yes. Right. The VM itself is already influent by the hosts processes.
 97 2016-09-06T09:12:28  *** dcousens has quit IRC
 98 2016-09-06T09:35:02  *** jannes has joined #bitcoin-core-dev
 99 2016-09-06T09:36:01  *** cryptapus has joined #bitcoin-core-dev
100 2016-09-06T09:36:01  *** cryptapus has joined #bitcoin-core-dev
101 2016-09-06T09:41:46  *** cryptapus has quit IRC
102 2016-09-06T09:45:10  *** cryptapus has joined #bitcoin-core-dev
103 2016-09-06T09:45:15  *** cryptapus has joined #bitcoin-core-dev
104 2016-09-06T09:46:34  <sipa> NicolasDorier: hmm, you have a use case of OP_CODESEP? :o
105 2016-09-06T10:36:26  *** fengling has quit IRC
106 2016-09-06T10:47:07  *** spudowiar has joined #bitcoin-core-dev
107 2016-09-06T10:58:20  *** Giszmo has joined #bitcoin-core-dev
108 2016-09-06T11:48:21  *** jtimon has joined #bitcoin-core-dev
109 2016-09-06T11:59:32  *** Samdney has joined #bitcoin-core-dev
110 2016-09-06T12:22:10  *** moli has joined #bitcoin-core-dev
111 2016-09-06T12:27:41  <NicolasDorier> sipa: yes
112 2016-09-06T12:28:01  <NicolasDorier> one sec, finding the case I wrote about in lightning discussion some time ago
113 2016-09-06T12:29:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
114 2016-09-06T12:29:36  <NicolasDorier> sipa: https://lists.linuxfoundation.org/pipermail/lightning-dev/2016-March/000457.html here (forget about R-Value, I was meaning revocation hash)
115 2016-09-06T12:29:40  <NicolasDorier> the basic idea
116 2016-09-06T12:30:01  <NicolasDorier> is that if you have a ScriptPubKey with 3 different path.
117 2016-09-06T12:30:13  <NicolasDorier> and one party wants to sign only for one specific path
118 2016-09-06T12:30:25  <NicolasDorier> without CODESEP, you need 3 different public key
119 2016-09-06T12:30:43  <NicolasDorier> with CODESEP, the signer can decide which path to sign by choosing the ScriptCode that interest him
120 2016-09-06T12:30:58  <sipa> but scriptcode is always from the last codesep to the end
121 2016-09-06T12:31:03  <sipa> so they'd always overlap
122 2016-09-06T12:31:38  <NicolasDorier> not always, depends if they are on same branch or not
123 2016-09-06T12:31:46  <NicolasDorier> if you have 2 branch with an OP_IF
124 2016-09-06T12:31:52  <NicolasDorier> you put a OP_CODESEP on each branch
125 2016-09-06T12:32:04  <NicolasDorier> then the signer decide which branch he agrees on signing
126 2016-09-06T12:32:19  <sipa> oh, right, only executed codeseps matter
127 2016-09-06T12:37:38  <NicolasDorier> sipa: Even if they are on single branch it can be useful actually, if Alice wants to sign until a certain point in the Script, and on certain condition, a second signature from her might be needed later down the path.
128 2016-09-06T12:38:12  <sipa> have you tested that?
129 2016-09-06T12:45:56  *** AaronvanW has joined #bitcoin-core-dev
130 2016-09-06T12:53:32  *** G1lius has joined #bitcoin-core-dev
131 2016-09-06T13:06:02  <btcdrak> I remembered a ML post about op_cs https://lists.linuxfoundation.org/pipermail/lightning-dev/2016-March/000455.html
132 2016-09-06T13:06:28  <sipa> btcdrak: NicolasDorier just linked to that as well
133 2016-09-06T13:06:46  <btcdrak> oh lol. I should read the entire log before replying :-p
134 2016-09-06T13:11:09  *** kadoban has joined #bitcoin-core-dev
135 2016-09-06T13:16:34  *** paveljanik has joined #bitcoin-core-dev
136 2016-09-06T13:20:35  <GitHub111> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e82fb872ff5c...d077f43f7ecf
137 2016-09-06T13:20:35  <GitHub111> bitcoin/master ff2ed7a mruddy: trivial: remove unnecessary variable fDaemon
138 2016-09-06T13:20:36  <GitHub111> bitcoin/master d077f43 Wladimir J. van der Laan: Merge #8663: trivial: remove unnecessary variable fDaemon...
139 2016-09-06T13:20:50  <GitHub96> [bitcoin] laanwj closed pull request #8663: trivial: remove unnecessary variable fDaemon (master...trivial_fDaemon) https://github.com/bitcoin/bitcoin/pull/8663
140 2016-09-06T13:24:13  <GitHub0> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d077f43f7ecf...8ea44405e76f
141 2016-09-06T13:24:13  <GitHub0> bitcoin/master 38acbf8 Doug: Remove unused Qt 4.6 patch....
142 2016-09-06T13:24:14  <GitHub0> bitcoin/master 8ea4440 Wladimir J. van der Laan: Merge #8645: Remove unused Qt 4.6 patch....
143 2016-09-06T13:24:23  <GitHub121> [bitcoin] laanwj closed pull request #8645: Remove unused Qt 4.6 patch. (master...master) https://github.com/bitcoin/bitcoin/pull/8645
144 2016-09-06T13:28:09  *** helo_ is now known as helo
145 2016-09-06T13:36:00  *** TomMc has joined #bitcoin-core-dev
146 2016-09-06T13:36:37  *** morcos has quit IRC
147 2016-09-06T13:52:05  *** cryptapus_ has joined #bitcoin-core-dev
148 2016-09-06T13:52:05  *** cryptapus_ has joined #bitcoin-core-dev
149 2016-09-06T13:52:32  *** cryptapus has quit IRC
150 2016-09-06T14:09:26  *** dcousens has joined #bitcoin-core-dev
151 2016-09-06T14:11:07  *** jtimon has quit IRC
152 2016-09-06T14:11:16  *** jtimon has joined #bitcoin-core-dev
153 2016-09-06T14:16:21  *** Guyver2 has joined #bitcoin-core-dev
154 2016-09-06T14:39:05  *** achow101_ has joined #bitcoin-core-dev
155 2016-09-06T14:41:35  *** Chris_Stewart_5 has quit IRC
156 2016-09-06T14:42:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
157 2016-09-06T14:43:12  *** morcos has joined #bitcoin-core-dev
158 2016-09-06T14:47:45  *** Chris_Stewart_5 has quit IRC
159 2016-09-06T14:48:02  *** Cheeseo has quit IRC
160 2016-09-06T14:48:32  *** achow101_ has quit IRC
161 2016-09-06T14:48:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
162 2016-09-06T14:50:42  *** Cheeseo has joined #bitcoin-core-dev
163 2016-09-06T14:50:43  *** Cheeseo has joined #bitcoin-core-dev
164 2016-09-06T14:56:33  *** achow101_ has joined #bitcoin-core-dev
165 2016-09-06T14:57:07  *** achow101_ has quit IRC
166 2016-09-06T15:24:41  *** cryptapus__ has joined #bitcoin-core-dev
167 2016-09-06T15:24:41  *** cryptapus__ has joined #bitcoin-core-dev
168 2016-09-06T15:25:32  *** cryptapus_ has quit IRC
169 2016-09-06T15:29:14  *** cryptapus__ is now known as cryptapus
170 2016-09-06T15:35:38  *** rubensayshi has quit IRC
171 2016-09-06T15:47:13  *** Guyver2_ has joined #bitcoin-core-dev
172 2016-09-06T15:50:34  *** Guyver2 has quit IRC
173 2016-09-06T15:50:38  *** Guyver2_ is now known as Guyver2
174 2016-09-06T16:00:39  *** Chris_Stewart_5 has quit IRC
175 2016-09-06T16:13:46  *** [Author] has quit IRC
176 2016-09-06T16:16:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
177 2016-09-06T16:21:41  *** BashCo has quit IRC
178 2016-09-06T16:22:01  *** [Author] has joined #bitcoin-core-dev
179 2016-09-06T16:40:25  *** instagibb has joined #bitcoin-core-dev
180 2016-09-06T16:41:26  *** instagibbs_ has joined #bitcoin-core-dev
181 2016-09-06T16:51:29  *** laurentmt has joined #bitcoin-core-dev
182 2016-09-06T16:54:59  *** laurentmt has quit IRC
183 2016-09-06T17:01:35  <jl2012> does signrawtransaction allow signing out-of-range SIGHASH_SINGLE? (i.e. the sighash = 1 bug)
184 2016-09-06T17:03:37  *** PaulCapestany has joined #bitcoin-core-dev
185 2016-09-06T17:07:04  *** PaulCape_ has quit IRC
186 2016-09-06T17:07:24  <instagibbs_> jl2012: it skips those
187 2016-09-06T17:07:41  <jl2012> so it won't complete and return error?
188 2016-09-06T17:08:02  <instagibbs_> afaict from the code just skips signing it
189 2016-09-06T17:08:13  <jl2012> thanks
190 2016-09-06T17:08:30  *** wangchun has quit IRC
191 2016-09-06T17:26:10  <btcdrak> https://github.com/bitcoin-core/bitcoincore.org/pull/208
192 2016-09-06T17:33:20  *** laurentmt has joined #bitcoin-core-dev
193 2016-09-06T17:35:38  *** BashCo has joined #bitcoin-core-dev
194 2016-09-06T17:41:55  *** laurentmt has quit IRC
195 2016-09-06T17:42:49  <instagibbs_> jonasschnelli: did https://github.com/bitcoin/bitcoin/pull/8606 fix your issue?
196 2016-09-06T17:49:13  *** wangchun has joined #bitcoin-core-dev
197 2016-09-06T17:53:34  *** pmienk_ has quit IRC
198 2016-09-06T17:57:17  *** spudowiar has quit IRC
199 2016-09-06T18:00:32  <cfields> jeremyrubin: is there a squashed version of your checkqueue coming up?
200 2016-09-06T18:04:57  *** bsm117532 has quit IRC
201 2016-09-06T18:06:00  *** tucenaber has quit IRC
202 2016-09-06T18:06:19  *** pmienk_ has joined #bitcoin-core-dev
203 2016-09-06T18:13:05  *** bsm117532 has joined #bitcoin-core-dev
204 2016-09-06T18:25:28  *** CocoBTC has joined #bitcoin-core-dev
205 2016-09-06T18:46:28  *** laurentmt has joined #bitcoin-core-dev
206 2016-09-06T19:28:08  *** spudowiar has joined #bitcoin-core-dev
207 2016-09-06T19:33:01  *** cryptapus has quit IRC
208 2016-09-06T19:42:59  *** spudowiar has quit IRC
209 2016-09-06T19:43:45  *** Chris_Stewart_5 has quit IRC
210 2016-09-06T19:47:16  *** G2lius has joined #bitcoin-core-dev
211 2016-09-06T19:51:01  *** G1lius has quit IRC
212 2016-09-06T19:55:29  *** laurentmt has quit IRC
213 2016-09-06T19:56:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
214 2016-09-06T20:00:16  <cfields> gmaxwell: I haven't looked at cgminer yet, but I can
215 2016-09-06T20:00:37  <sipa> i assume it will be similar to ckpool?
216 2016-09-06T20:01:24  *** jrayhawk_ is now known as jrayhawk
217 2016-09-06T20:02:42  *** Naphex has quit IRC
218 2016-09-06T20:06:30  <cfields> unsure
219 2016-09-06T20:06:37  *** achow101 has quit IRC
220 2016-09-06T20:06:57  *** achow101 has joined #bitcoin-core-dev
221 2016-09-06T20:08:56  *** Chris_Stewart_5 has quit IRC
222 2016-09-06T20:11:59  *** kyletorpey has joined #bitcoin-core-dev
223 2016-09-06T20:17:36  <phantomcircuit> sipa, doubt it
224 2016-09-06T20:19:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
225 2016-09-06T20:28:33  *** Chris_Stewart_5 has quit IRC
226 2016-09-06T20:37:41  *** Guyver2 has quit IRC
227 2016-09-06T20:38:16  *** belcher has quit IRC
228 2016-09-06T20:38:32  <GitHub117> [bitcoin] JeremyRubin opened pull request #8671: Minimal fix to slow prevector tests as stopgap measure (master...simple_faster_tests) https://github.com/bitcoin/bitcoin/pull/8671
229 2016-09-06T20:38:37  <GitHub186> [bitcoin] Cocosoft opened pull request #8672: Qt: Show transaction size in transaction details window (master...qttxsizeindetails) https://github.com/bitcoin/bitcoin/pull/8672
230 2016-09-06T20:41:00  *** belcher has joined #bitcoin-core-dev
231 2016-09-06T20:41:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
232 2016-09-06T20:42:02  <GitHub172> [bitcoin] JeremyRubin closed pull request #8650: Make tests much faster by replacing BOOST_CHECK with FAST_CHECK (master...faster_tests) https://github.com/bitcoin/bitcoin/pull/8650
233 2016-09-06T20:42:22  <GitHub82> [bitcoin] JeremyRubin closed pull request #8632: Speed up prevector tests by parallelization (master...faster_prevector_tests) https://github.com/bitcoin/bitcoin/pull/8632
234 2016-09-06T20:56:36  <GitHub122> [bitcoin] JeremyRubin opened pull request #8673: Trivial: Fix obvious assignment/equality error in test (master...fix_arith_tests_trivial) https://github.com/bitcoin/bitcoin/pull/8673
235 2016-09-06T21:02:55  *** musalbas has quit IRC
236 2016-09-06T21:04:54  *** musalbas has joined #bitcoin-core-dev
237 2016-09-06T21:05:59  *** belcher has quit IRC
238 2016-09-06T21:08:11  *** vega4 has joined #bitcoin-core-dev
239 2016-09-06T21:08:21  *** belcher has joined #bitcoin-core-dev
240 2016-09-06T21:19:06  *** JackH has joined #bitcoin-core-dev
241 2016-09-06T21:23:54  <jeremyrubin> cfields: it is available now
242 2016-09-06T21:24:10  <jeremyrubin> cfields: but I'm not PR'ing it until I can speed up the PrevectorTests
243 2016-09-06T21:25:02  <jeremyrubin> cfields: https://github.com/JeremyRubin/bitcoin/tree/lockfree-checkqueue-restructured
244 2016-09-06T21:25:38  <jeremyrubin> cfields: I guess I should say, until #8671 gets merged
245 2016-09-06T21:28:50  *** morcos has quit IRC
246 2016-09-06T21:31:30  *** spudowiar has joined #bitcoin-core-dev
247 2016-09-06T21:35:12  *** pavel_ has joined #bitcoin-core-dev
248 2016-09-06T21:35:42  *** paveljanik has quit IRC
249 2016-09-06T21:39:12  *** vega4 has quit IRC
250 2016-09-06T21:39:41  <luke-jr> cfields: were your ckpool changes accepted upstream?
251 2016-09-06T21:40:14  <cfields> jeremyrubin: perfect, thanks
252 2016-09-06T21:40:17  <cfields> luke-jr: yes
253 2016-09-06T21:44:29  *** belcher is now known as JM-IRCRelay
254 2016-09-06T21:44:35  *** JM-IRCRelay is now known as belcher
255 2016-09-06T21:53:36  <CocoBTC> luke-jr, I saw your reply to the PR, thanks.  I'm not entirely sure on where/how to get this value (size + feerate-based-on-weight), or what it is.  I'm still working on getting my head up-to-date with SegWit.
256 2016-09-06T21:54:02  <luke-jr> heh, I meant show both the size, and the feerate
257 2016-09-06T21:54:05  <luke-jr> not to add them ☺
258 2016-09-06T21:55:53  <luke-jr> basically you get the feerate with Fee / GetVirtualTransactionSize
259 2016-09-06T21:55:55  <CocoBTC> Lol! I see. That makes sense :)
260 2016-09-06T21:56:09  <CocoBTC> Right
261 2016-09-06T21:58:04  *** morcos has joined #bitcoin-core-dev
262 2016-09-06T22:05:25  <CocoBTC> Do I need to know/care about nSigOpCost?
263 2016-09-06T22:10:10  <luke-jr> hmm, not normally, but for incoming transactions it's possibly relevant
264 2016-09-06T22:10:16  <luke-jr> due to nSigOpsPerByte
265 2016-09-06T22:11:54  <luke-jr> ah, GetVirtualTransactionSize takes care of that for you
266 2016-09-06T22:12:01  <luke-jr> just you need to give it the right value as an argument
267 2016-09-06T22:12:23  <CocoBTC> Well it defaults to 0? Or maybe I read the code wrong.
268 2016-09-06T22:12:30  <CocoBTC> Right!
269 2016-09-06T22:12:51  <luke-jr> hmm.. I'm not sure it makes sense for it to have that default :x
270 2016-09-06T22:13:40  <luke-jr> looks like rawtx and the wallet currently don't provide it
271 2016-09-06T22:13:46  <luke-jr> probably okay for the wallet side because it's for sending
272 2016-09-06T22:14:04  <luke-jr> but you can't assume incoming are sane in this respect, so you'll need to provide it
273 2016-09-06T22:14:46  <CocoBTC> Okay! Thank you for your help.
274 2016-09-06T22:14:59  *** vega4 has joined #bitcoin-core-dev
275 2016-09-06T22:15:15  <luke-jr> np
276 2016-09-06T22:15:46  *** vega4 has quit IRC
277 2016-09-06T22:15:53  *** vega4 has joined #bitcoin-core-dev
278 2016-09-06T22:16:12  *** TomMc has quit IRC
279 2016-09-06T22:37:14  *** CocoBTC has quit IRC
280 2016-09-06T22:38:20  *** TomMc has joined #bitcoin-core-dev
281 2016-09-06T22:57:45  *** spudowiar has quit IRC
282 2016-09-06T23:01:13  *** Giszmo has quit IRC
283 2016-09-06T23:03:42  *** vega4 has quit IRC
284 2016-09-06T23:21:16  *** Giszmo has joined #bitcoin-core-dev
285 2016-09-06T23:46:27  *** jtimon has quit IRC
286 2016-09-06T23:51:59  *** justanotheruser has quit IRC