1 2016-11-14T00:34:28  *** takashi has joined #bitcoin-core-dev
  2 2016-11-14T01:08:52  *** AaronvanW has quit IRC
  3 2016-11-14T01:27:08  *** BCBot_ has joined #bitcoin-core-dev
  4 2016-11-14T01:27:27  *** BCBot has quit IRC
  5 2016-11-14T01:45:30  *** h1d has joined #bitcoin-core-dev
  6 2016-11-14T01:49:11  *** Alopex has quit IRC
  7 2016-11-14T01:50:16  *** Alopex has joined #bitcoin-core-dev
  8 2016-11-14T01:52:38  *** Ylbam has quit IRC
  9 2016-11-14T01:52:52  *** h1d has quit IRC
 10 2016-11-14T02:00:23  *** fengling has joined #bitcoin-core-dev
 11 2016-11-14T02:03:22  *** DigiByteDev has joined #bitcoin-core-dev
 12 2016-11-14T02:07:23  *** DigiByteDev_ has joined #bitcoin-core-dev
 13 2016-11-14T02:10:32  *** DigiByteDev has quit IRC
 14 2016-11-14T02:10:33  *** DigiByteDev_ is now known as DigiByteDev
 15 2016-11-14T02:12:08  *** DigiByteDev_ has joined #bitcoin-core-dev
 16 2016-11-14T02:14:37  *** DigiByteDev has quit IRC
 17 2016-11-14T02:14:50  *** DigiByteDev has joined #bitcoin-core-dev
 18 2016-11-14T02:15:29  *** Giszmo has quit IRC
 19 2016-11-14T02:16:52  *** moli has quit IRC
 20 2016-11-14T02:17:58  *** DigiByteDev_ has quit IRC
 21 2016-11-14T02:18:48  *** moli has joined #bitcoin-core-dev
 22 2016-11-14T02:20:19  *** DigiByteDev_ has joined #bitcoin-core-dev
 23 2016-11-14T02:23:44  *** DigiByteDev has quit IRC
 24 2016-11-14T02:24:02  *** DigiByteDev_ is now known as DigiByteDev
 25 2016-11-14T02:29:15  *** DigiByteDev has joined #bitcoin-core-dev
 26 2016-11-14T02:33:27  *** Alopex has quit IRC
 27 2016-11-14T02:33:59  *** DigiByteDev_ has joined #bitcoin-core-dev
 28 2016-11-14T02:34:32  *** Alopex has joined #bitcoin-core-dev
 29 2016-11-14T02:36:18  *** DigiByteDev has quit IRC
 30 2016-11-14T02:36:19  *** DigiByteDev_ is now known as DigiByteDev
 31 2016-11-14T02:37:17  *** DigiByteDev_ has joined #bitcoin-core-dev
 32 2016-11-14T02:40:45  *** DigiByteDev has quit IRC
 33 2016-11-14T02:40:58  *** DigiByteDev has joined #bitcoin-core-dev
 34 2016-11-14T02:43:28  *** DigiByteDev_ has quit IRC
 35 2016-11-14T02:45:02  *** Alopex has quit IRC
 36 2016-11-14T02:45:27  *** DigiByteDev_ has joined #bitcoin-core-dev
 37 2016-11-14T02:46:07  *** Alopex has joined #bitcoin-core-dev
 38 2016-11-14T02:48:15  *** DigiByteDev has quit IRC
 39 2016-11-14T02:48:55  *** DigiByteDev has joined #bitcoin-core-dev
 40 2016-11-14T02:51:48  *** DigiByteDev_ has quit IRC
 41 2016-11-14T02:52:44  *** DigiByteDev_ has joined #bitcoin-core-dev
 42 2016-11-14T02:55:48  *** DigiByteDev has quit IRC
 43 2016-11-14T02:56:30  *** DigiByteDev has joined #bitcoin-core-dev
 44 2016-11-14T02:58:01  *** btcdrak has quit IRC
 45 2016-11-14T02:59:15  *** DigiByteDev_ has quit IRC
 46 2016-11-14T02:59:57  *** DigiByteDev_ has joined #bitcoin-core-dev
 47 2016-11-14T03:03:00  *** DigiByteDev has quit IRC
 48 2016-11-14T03:03:49  *** DigiByteDev has joined #bitcoin-core-dev
 49 2016-11-14T03:06:13  *** DigiByteDev_ has quit IRC
 50 2016-11-14T03:06:42  *** DigiByteDev_ has joined #bitcoin-core-dev
 51 2016-11-14T03:09:25  *** DigiByteDev has quit IRC
 52 2016-11-14T03:10:23  *** DigiByteDev has joined #bitcoin-core-dev
 53 2016-11-14T03:13:20  *** DigiByteDev_ has quit IRC
 54 2016-11-14T03:15:00  *** DigiByteDev has quit IRC
 55 2016-11-14T03:33:48  *** jtimon has quit IRC
 56 2016-11-14T03:42:26  *** kadoban has joined #bitcoin-core-dev
 57 2016-11-14T04:18:14  *** DigiByteDev has joined #bitcoin-core-dev
 58 2016-11-14T04:21:52  *** DigiByteDev_ has joined #bitcoin-core-dev
 59 2016-11-14T04:25:13  *** DigiByteDev has quit IRC
 60 2016-11-14T04:25:46  *** DigiByteDev has joined #bitcoin-core-dev
 61 2016-11-14T04:28:18  *** DigiByteDev_ has quit IRC
 62 2016-11-14T04:29:15  *** DigiByteDev_ has joined #bitcoin-core-dev
 63 2016-11-14T04:32:00  *** DigiByteDev has quit IRC
 64 2016-11-14T04:33:01  *** DigiByteDev has joined #bitcoin-core-dev
 65 2016-11-14T04:35:41  *** DigiByteDev_ has quit IRC
 66 2016-11-14T04:37:47  *** DigiByteDev_ has joined #bitcoin-core-dev
 67 2016-11-14T04:40:22  *** DigiByteDev has quit IRC
 68 2016-11-14T04:42:01  *** Alopex has quit IRC
 69 2016-11-14T04:43:07  *** Alopex has joined #bitcoin-core-dev
 70 2016-11-14T04:54:16  *** dcousens has joined #bitcoin-core-dev
 71 2016-11-14T04:55:06  <dcousens> with P2WSH, can the scriptSig have non-push opcodes?
 72 2016-11-14T04:55:20  <dcousens> (the witness script Sig... "stack")
 73 2016-11-14T04:56:04  <dcousens> I'm looking at https://github.com/bitcoin/bitcoin/blob/e81df49644c21f835e25028ab4643aa9bf5ae8da/src/script/interpreter.cpp#L1367-L1397,  and it appears that it can
 74 2016-11-14T04:59:10  <dcousens> nevermind... its treated as stack not CScript, my bad
 75 2016-11-14T04:59:40  <aj> dcousens: yeah, the first item on the stack is the program which gets converted to a CScript, but that's it... ?
 76 2016-11-14T04:59:50  <dcousens> last item*?
 77 2016-11-14T05:00:09  *** kadoban has quit IRC
 78 2016-11-14T05:02:28  <sipa> last, indeed
 79 2016-11-14T05:02:31  <sipa> top of the stack
 80 2016-11-14T05:07:57  *** aalex has joined #bitcoin-core-dev
 81 2016-11-14T05:13:01  *** Alopex has quit IRC
 82 2016-11-14T05:14:06  *** Alopex has joined #bitcoin-core-dev
 83 2016-11-14T05:18:18  *** DigiByteDev_ has quit IRC
 84 2016-11-14T05:24:06  *** Alopex has quit IRC
 85 2016-11-14T05:25:12  *** Alopex has joined #bitcoin-core-dev
 86 2016-11-14T05:25:26  <aj> eh, i'm australian, can you blame me if i look at stacks upside down?
 87 2016-11-14T05:28:36  *** DigiByteDev has joined #bitcoin-core-dev
 88 2016-11-14T05:33:47  *** DigiByteDev_ has joined #bitcoin-core-dev
 89 2016-11-14T05:35:44  <bitcoin-git> [bitcoin] XertroV opened pull request #9154: Add recent checkpoints to remove CPU load during sync (master...f/new-checkpoints) https://github.com/bitcoin/bitcoin/pull/9154
 90 2016-11-14T05:36:10  *** DigiByteDev has quit IRC
 91 2016-11-14T05:36:33  <bitcoin-git> [bitcoin] fanquake closed pull request #9154: Add recent checkpoints to remove CPU load during sync (master...f/new-checkpoints) https://github.com/bitcoin/bitcoin/pull/9154
 92 2016-11-14T05:38:13  *** DigiByteDev_ has quit IRC
 93 2016-11-14T05:39:35  *** DigiByteDev has joined #bitcoin-core-dev
 94 2016-11-14T05:43:21  *** aalex has quit IRC
 95 2016-11-14T06:10:06  *** Alopex has quit IRC
 96 2016-11-14T06:10:35  *** fengling has quit IRC
 97 2016-11-14T06:11:01  *** paveljanik has quit IRC
 98 2016-11-14T06:11:11  *** Alopex has joined #bitcoin-core-dev
 99 2016-11-14T06:12:04  *** btcdrak has joined #bitcoin-core-dev
100 2016-11-14T06:13:03  *** fengling has joined #bitcoin-core-dev
101 2016-11-14T06:21:01  *** Alopex has quit IRC
102 2016-11-14T06:22:06  *** Alopex has joined #bitcoin-core-dev
103 2016-11-14T06:29:40  *** Ylbam has joined #bitcoin-core-dev
104 2016-11-14T06:40:16  *** Alopex has quit IRC
105 2016-11-14T06:41:21  *** Alopex has joined #bitcoin-core-dev
106 2016-11-14T06:44:22  <bitcoin-git> [bitcoin] carryforward opened pull request #9155: [trivial] update comments for tx weight (master...master) https://github.com/bitcoin/bitcoin/pull/9155
107 2016-11-14T06:52:59  *** thokon00 has quit IRC
108 2016-11-14T06:53:07  *** thokon00 has joined #bitcoin-core-dev
109 2016-11-14T07:27:49  *** DigiByteDev has quit IRC
110 2016-11-14T07:36:23  *** wolfspraul has quit IRC
111 2016-11-14T07:37:11  *** cjcj has joined #bitcoin-core-dev
112 2016-11-14T07:46:33  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/87ab49e4fe38...924745dd6f5f
113 2016-11-14T07:46:34  <bitcoin-git> bitcoin/master fa42e4a MarcoFalke: [qt] Make network disabled icon 50% opaque
114 2016-11-14T07:46:34  <bitcoin-git> bitcoin/master 924745d Jonas Schnelli: Merge #9145: [qt] Make network disabled icon 50% opaque...
115 2016-11-14T07:46:43  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9145: [qt] Make network disabled icon 50% opaque (master...Mf1611-qtNetworkIcon) https://github.com/bitcoin/bitcoin/pull/9145
116 2016-11-14T07:54:12  <gmaxwell> Anyone know where I can go to sign this? http://imgur.com/a/iv3m6 doesn't say much but it's pretty unobjectionable.
117 2016-11-14T07:57:11  <btcdrak> gmaxwell: no no, we're not allowed to sign that, because it's Roger Ver's attempt to snub Bitcoin Core. Looks like a more watered down version of the first leak http://pastebin.com/cgkqcWBS.
118 2016-11-14T07:58:47  <luke-jr> gmaxwell: I emailed them a few days ago asking and got no response
119 2016-11-14T08:09:16  *** Alopex has quit IRC
120 2016-11-14T08:10:21  *** Alopex has joined #bitcoin-core-dev
121 2016-11-14T08:11:56  <jonasschnelli> bench gives me something like: SHA256,36,0.030114054679871,0.032101750373840,0.031019667784373
122 2016-11-14T08:12:01  <jonasschnelli> Are the time values in ms?
123 2016-11-14T08:12:20  <jonasschnelli> And is the time value * count or per a single execution?
124 2016-11-14T08:14:25  <gmaxwell> microseconds, IIRC. and not per count, count is already divided out.
125 2016-11-14T08:14:59  <wumpus> count is divided out otherwise it'd be entirely pointless :) I don't know the unit hough
126 2016-11-14T08:15:48  <wumpus> the header row should really have unit indicators [ms] [s] or such
127 2016-11-14T08:16:15  <wumpus> appears to be seconds, looking at the code
128 2016-11-14T08:17:03  <gmaxwell> indeed.
129 2016-11-14T08:17:48  <gmaxwell> ... 30 microseconds is absurdly slow for sha256 unless that is testing someting non-obvious.
130 2016-11-14T08:18:15  <wumpus> doesn't it depend on how much data it is hashing per run?
131 2016-11-14T08:18:39  <gmaxwell> er 30 milliseconds.
132 2016-11-14T08:18:46  <gmaxwell> Yes, if it's a lot of data, indeed.
133 2016-11-14T08:18:59  <wumpus> and yes, hashing benchmarks are best expressed in MB/s or such
134 2016-11-14T08:19:41  <wumpus> would make sense at some point to split the bench into multiple tables, with one for hashing and CRCing algos
135 2016-11-14T08:20:18  <gmaxwell> sometimes we care about the time to hash a minimum size piece of data: thats the sigcache case, the hashes inside the hashtree, etc.
136 2016-11-14T08:20:39  <jonasschnelli> Then am I correct when I say for the values above it takes in avg 30ns per hash (need to lookup how mach data being hash)?
137 2016-11-14T08:20:58  <wumpus> right, probably there should be a specific benchmark for that
138 2016-11-14T08:21:06  <jonasschnelli> (what I'm trying to do is to compare it against ChaCha20Poly1305AEAD per byte at the end)
139 2016-11-14T08:21:38  <wumpus> well in that case you should absolutely compare MB/s not anything else
140 2016-11-14T08:21:41  <gmaxwell> jonasschnelli: no, it's seconds, and it's saying it takes 31 milliseconds for however much it's hashing (presumably a lot or something is broken)
141 2016-11-14T08:21:41  <jonasschnelli> BUFFER_SIZE = 1000*1000; (for the hash test)
142 2016-11-14T08:22:43  <jonasschnelli> 31 milliseconds per 1MB, right?
143 2016-11-14T08:22:44  <wumpus> e.g. something like I did here https://github.com/laanwj/crcbench
144 2016-11-14T08:23:01  <jonasschnelli> wumpus: thanks..
145 2016-11-14T08:23:21  <wumpus> jonasschnelli: yes
146 2016-11-14T08:24:28  <wumpus> 1000*1000/0.031019667784373  -> 32,237,611 bytes per second
147 2016-11-14T08:26:18  *** rubensayshi has joined #bitcoin-core-dev
148 2016-11-14T08:26:21  <gmaxwell> jonasschnelli: sounds like it, yes. which is only 32.2 MB/s which sounds quite slow.
149 2016-11-14T08:26:49  <jonasschnelli> -O0
150 2016-11-14T08:26:55  <gmaxwell> openssl speed sha256 on my sluggish laptop says 96,185,000 bytes/s.
151 2016-11-14T08:26:59  <gmaxwell> oh okay.
152 2016-11-14T08:27:15  <gmaxwell> well you -O0 is "make bencmarks worthless" :P
153 2016-11-14T08:27:18  <jonasschnelli> It's not the numbers i want to compare, just for understanding
154 2016-11-14T08:27:22  <wumpus> why would you compare benchmarks with O0?!
155 2016-11-14T08:27:33  <gmaxwell> s/you// :)
156 2016-11-14T08:27:42  <jonasschnelli> I just don't wanted to configure/compile again. :-)
157 2016-11-14T08:27:52  <jonasschnelli> Will to the benchmark on a different machine... and fix the clock, etc.
158 2016-11-14T08:28:23  <jonasschnelli> I guess benchmark on a Mac laptop with tons of applications open doesn't really make sense.
159 2016-11-14T08:28:27  <gmaxwell> Just don't use the results for _anything_ O0 radically changes the performance profile of different code.
160 2016-11-14T08:28:43  <jonasschnelli> Yes. I learned that from my IBD benchmarks. :)
161 2016-11-14T08:32:12  <gmaxwell> on the same sluggish laptop mentioned above our bench returns 0.02038276  which is about 49.06 milillion bytes/sec. So I suppose thats about what I'd expect vs OpenSSL given that we know our sha256 is slower than the faster ones using SSE2.
162 2016-11-14T08:41:57  *** aalex has joined #bitcoin-core-dev
163 2016-11-14T08:48:15  *** aalex has quit IRC
164 2016-11-14T08:51:20  <jonasschnelli> SHA -O3 on Skylark: SHA256,256,0.002107024192810,0.004232339560986,0.004217050969601
165 2016-11-14T08:51:50  <jonasschnelli> Same setup, ChaCha20Poly1305@openssh (own draft implementation): 0.00278858
166 2016-11-14T08:52:01  *** Ginnarr has joined #bitcoin-core-dev
167 2016-11-14T08:53:06  *** Ginnarr has quit IRC
168 2016-11-14T08:53:09  <gmaxwell> hm. thats not that impressive!
169 2016-11-14T08:53:24  <jonasschnelli> Well.. faster then I have expected.
170 2016-11-14T08:53:27  *** Ginnarr has joined #bitcoin-core-dev
171 2016-11-14T08:53:54  <gmaxwell> run "openssl speed sha256" on the same hardware.
172 2016-11-14T08:54:02  * jonasschnelli doing...
173 2016-11-14T08:54:30  <jonasschnelli> sha256           64116.34k   140875.75k   245123.77k   296262.31k   320731.87k
174 2016-11-14T08:55:52  <jonasschnelli> I took the ChaCha20Poly1305 from openssh: https://github.com/jonasschnelli/chacha20poly1305
175 2016-11-14T08:56:02  <gmaxwell> okay, bitcoin's sha256 is 237.1 million bytes per second, openssl is 320.7 million bytes per second.. and the chacha is 358.6 million bytes per second.  (openssl at slight disadvantage due to 8k vs 1m size, but it doesn't matter much)
176 2016-11-14T08:57:24  <gmaxwell> okay, not so bad, encrypt+auth, about 11% faster than highly optimized sha256 alone for large blocks.  IIRC the chacha/poly will have a bigger advantage for smaller messages.
177 2016-11-14T08:57:45  <jonasschnelli> Yes. Thats true.
178 2016-11-14T08:57:57  <gmaxwell> and better, it should wipe the floor with sha256 on arm.
179 2016-11-14T08:58:08  <jonasschnelli> Also, i'm not sure about the constant time properties of chacha20 here: https://github.com/jonasschnelli/chacha20poly1305/blob/master/chacha.c
180 2016-11-14T09:03:01  <gmaxwell> quick glance through shows all that to be constant time (other than the number of bytes going into it, of course) ... and the position counter carry. (odd that they did that, but it's just a counter)
181 2016-11-14T09:05:25  *** moli has quit IRC
182 2016-11-14T09:06:22  *** Ginnarr has quit IRC
183 2016-11-14T09:08:18  <jonasschnelli> gmaxwell: I guess the implementation above is more or less from DJB itself.
184 2016-11-14T09:08:41  <jonasschnelli> not sure if the openssh guys did modificate it, though
185 2016-11-14T09:08:47  *** aalex has joined #bitcoin-core-dev
186 2016-11-14T09:09:43  <gmaxwell> it looks fine to me.
187 2016-11-14T09:11:38  *** DigiByteDev has joined #bitcoin-core-dev
188 2016-11-14T09:13:43  *** Ginnarr has joined #bitcoin-core-dev
189 2016-11-14T09:14:17  *** jannes has joined #bitcoin-core-dev
190 2016-11-14T09:14:49  *** shesek has joined #bitcoin-core-dev
191 2016-11-14T09:15:05  *** aalex has quit IRC
192 2016-11-14T09:22:09  *** luke-jr has quit IRC
193 2016-11-14T09:22:29  *** luke-jr has joined #bitcoin-core-dev
194 2016-11-14T09:27:38  *** Ginnarr has quit IRC
195 2016-11-14T09:30:29  *** Ginnarr has joined #bitcoin-core-dev
196 2016-11-14T09:33:08  *** Ginnarr has quit IRC
197 2016-11-14T09:34:29  *** Guyver2 has joined #bitcoin-core-dev
198 2016-11-14T09:34:39  *** DigiByteDev has quit IRC
199 2016-11-14T09:36:02  *** laurentmt has joined #bitcoin-core-dev
200 2016-11-14T09:39:16  *** laurentmt has quit IRC
201 2016-11-14T09:42:58  *** arinaga has quit IRC
202 2016-11-14T09:52:17  *** AaronvanW has joined #bitcoin-core-dev
203 2016-11-14T09:52:17  *** AaronvanW has quit IRC
204 2016-11-14T09:52:17  *** AaronvanW has joined #bitcoin-core-dev
205 2016-11-14T09:59:08  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9156: Add compile and link options echo to configure (master...2016/11/configure) https://github.com/bitcoin/bitcoin/pull/9156
206 2016-11-14T11:33:43  *** fengling has quit IRC
207 2016-11-14T11:34:34  *** moli has joined #bitcoin-core-dev
208 2016-11-14T12:03:28  *** JackH has quit IRC
209 2016-11-14T12:06:18  *** JackH has joined #bitcoin-core-dev
210 2016-11-14T12:07:14  *** Giszmo has joined #bitcoin-core-dev
211 2016-11-14T12:30:42  *** fengling has joined #bitcoin-core-dev
212 2016-11-14T12:32:49  *** windsok has quit IRC
213 2016-11-14T12:35:23  *** fengling has quit IRC
214 2016-11-14T13:02:59  *** takashi has quit IRC
215 2016-11-14T13:07:37  *** jtimon has joined #bitcoin-core-dev
216 2016-11-14T13:15:30  *** windsok has joined #bitcoin-core-dev
217 2016-11-14T13:18:45  *** kadoban has joined #bitcoin-core-dev
218 2016-11-14T13:31:44  *** fengling has joined #bitcoin-core-dev
219 2016-11-14T13:32:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
220 2016-11-14T13:36:26  *** fengling has quit IRC
221 2016-11-14T14:03:12  *** paveljanik has joined #bitcoin-core-dev
222 2016-11-14T14:25:21  *** aalex has joined #bitcoin-core-dev
223 2016-11-14T14:25:44  *** aalex_ has joined #bitcoin-core-dev
224 2016-11-14T14:30:52  *** Chris_Stewart_5 has quit IRC
225 2016-11-14T14:32:43  *** fengling has joined #bitcoin-core-dev
226 2016-11-14T14:38:06  *** fengling has quit IRC
227 2016-11-14T14:44:06  *** aalex_ has quit IRC
228 2016-11-14T14:49:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
229 2016-11-14T14:51:03  *** Chris_Stewart_5 has quit IRC
230 2016-11-14T14:54:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
231 2016-11-14T15:14:13  *** murch has joined #bitcoin-core-dev
232 2016-11-14T15:14:28  *** cryptapus_afk has quit IRC
233 2016-11-14T15:21:14  *** cryptapus has joined #bitcoin-core-dev
234 2016-11-14T15:33:59  *** fengling has joined #bitcoin-core-dev
235 2016-11-14T15:36:06  *** Lauda has quit IRC
236 2016-11-14T15:37:31  *** Chris_Stewart_5 has quit IRC
237 2016-11-14T15:39:09  *** fengling has quit IRC
238 2016-11-14T15:41:33  *** murchandamus has joined #bitcoin-core-dev
239 2016-11-14T15:42:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
240 2016-11-14T15:43:36  *** murch has quit IRC
241 2016-11-14T15:44:35  *** Micha|iPhone has joined #bitcoin-core-dev
242 2016-11-14T15:44:36  *** Micha|iPhone has left #bitcoin-core-dev
243 2016-11-14T15:51:09  *** Chris_Stewart_5 has quit IRC
244 2016-11-14T15:53:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
245 2016-11-14T16:03:22  *** Lauda has joined #bitcoin-core-dev
246 2016-11-14T16:08:18  *** achow101_ has joined #bitcoin-core-dev
247 2016-11-14T16:13:08  *** Chris_Stewart_5 has quit IRC
248 2016-11-14T16:13:18  *** cryptapus_ has joined #bitcoin-core-dev
249 2016-11-14T16:13:19  *** cryptapus_ has joined #bitcoin-core-dev
250 2016-11-14T16:16:03  *** cryptapus_ has quit IRC
251 2016-11-14T16:16:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
252 2016-11-14T16:19:54  *** achow101 has quit IRC
253 2016-11-14T16:20:18  *** achow101_ is now known as achow101
254 2016-11-14T16:20:38  *** achow101 has joined #bitcoin-core-dev
255 2016-11-14T16:36:02  *** fengling has joined #bitcoin-core-dev
256 2016-11-14T16:36:16  *** achow101 has quit IRC
257 2016-11-14T16:38:35  *** achow101 has joined #bitcoin-core-dev
258 2016-11-14T16:40:49  *** fengling has quit IRC
259 2016-11-14T17:00:20  *** rubensayshi has quit IRC
260 2016-11-14T17:20:19  *** abpa has joined #bitcoin-core-dev
261 2016-11-14T17:37:04  *** fengling has joined #bitcoin-core-dev
262 2016-11-14T17:37:38  *** aalex has quit IRC
263 2016-11-14T17:39:50  *** aalex has joined #bitcoin-core-dev
264 2016-11-14T17:41:52  *** fengling has quit IRC
265 2016-11-14T17:47:09  <bitcoin-git> [bitcoin] Leviathn opened pull request #9158: Removal of "free transaction" logic from codebase (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9158
266 2016-11-14T18:07:08  *** wolfspraul has joined #bitcoin-core-dev
267 2016-11-14T18:07:43  *** wolfspraul has joined #bitcoin-core-dev
268 2016-11-14T18:17:10  <bitcoin-git> [bitcoin] Leviathn closed pull request #9158: Removal of "free transaction" logic from codebase (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9158
269 2016-11-14T18:22:25  *** Chris_Stewart_5 has quit IRC
270 2016-11-14T18:23:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
271 2016-11-14T18:25:07  *** laurentmt has joined #bitcoin-core-dev
272 2016-11-14T18:25:36  *** laurentmt has quit IRC
273 2016-11-14T18:35:51  <sdaftuar> sipa: are you planning to PR the rest of your shared-ptr-all-the-things branch soon?
274 2016-11-14T18:37:41  <sdaftuar> i have a change to the way we manage the mempool during reorgs, which i think would make sense to rebase on to your branch, wasn't sure if i should use #9125 or some later commit in your branch
275 2016-11-14T18:37:43  <gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
276 2016-11-14T18:38:04  *** fengling has joined #bitcoin-core-dev
277 2016-11-14T18:43:32  *** fengling has quit IRC
278 2016-11-14T18:43:43  <sipa> sdaftuar: several parts of that branch are included in #8580 now
279 2016-11-14T18:43:45  <gribble> https://github.com/bitcoin/bitcoin/issues/8580 | Make CTransaction actually immutable by sipa · Pull Request #8580 · bitcoin/bitcoin · GitHub
280 2016-11-14T18:44:09  <sipa> there is one more commit that makes ATMT take a shared_ptr
281 2016-11-14T18:46:03  <sdaftuar> yeah i was thinking i'd rebase on that one, as that'll help during processing of reorg'ed out transactions as well
282 2016-11-14T18:46:09  *** Chris_Stewart_5 has quit IRC
283 2016-11-14T18:49:16  <sipa> i could just push the one remaining patch into 8580, but it's already quite big
284 2016-11-14T18:50:20  <sdaftuar> no problem, i can be patient (and help review!)
285 2016-11-14T18:51:15  <sipa> i'll run a benchmark for those PRs soon
286 2016-11-14T19:01:11  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9159: [qa] Wait for specific block announcement in p2p-compactblocks (master...cmpct-announce-wait) https://github.com/bitcoin/bitcoin/pull/9159
287 2016-11-14T19:02:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
288 2016-11-14T19:03:21  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9160: [trivial] Fix hungarian variable name (master...hungarian) https://github.com/bitcoin/bitcoin/pull/9160
289 2016-11-14T19:26:55  *** Victorsueca has quit IRC
290 2016-11-14T19:28:15  *** MarcoFalke has joined #bitcoin-core-dev
291 2016-11-14T19:28:18  *** Victorsueca has joined #bitcoin-core-dev
292 2016-11-14T19:28:58  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/924745dd6f5f...b42291334651
293 2016-11-14T19:28:59  <bitcoin-git> bitcoin/master fd6bb70 Russell Yanofsky: [qa] Improve sync_blocks error messages.
294 2016-11-14T19:28:59  <bitcoin-git> bitcoin/master 05e57cc Russell Yanofsky: [qa] Fix sync_blocks timeout argument...
295 2016-11-14T19:29:00  <bitcoin-git> bitcoin/master 7943b13 Russell Yanofsky: [qa] Avoid 2 list comprehensions in sync_blocks
296 2016-11-14T19:29:08  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9136: sync_blocks cleanup (master...sync-clean) https://github.com/bitcoin/bitcoin/pull/9136
297 2016-11-14T19:31:17  *** eenoch has quit IRC
298 2016-11-14T19:31:20  *** aj has quit IRC
299 2016-11-14T19:37:47  *** wasi has quit IRC
300 2016-11-14T19:39:12  *** wasi has joined #bitcoin-core-dev
301 2016-11-14T19:39:23  *** fengling has joined #bitcoin-core-dev
302 2016-11-14T19:44:35  *** fengling has quit IRC
303 2016-11-14T19:46:55  *** aj has joined #bitcoin-core-dev
304 2016-11-14T19:47:15  *** eenoch has joined #bitcoin-core-dev
305 2016-11-14T20:00:57  *** belcher has quit IRC
306 2016-11-14T20:13:51  *** belcher has joined #bitcoin-core-dev
307 2016-11-14T20:17:55  *** belcher has quit IRC
308 2016-11-14T20:26:50  <morcos> What is the assumption for how the wallet supports txs for which some of the inputs are yours and some aren't?
309 2016-11-14T20:26:58  <morcos> I'm asking in context of the bumpfee command.
310 2016-11-14T20:27:40  <morcos> In particular is there a way to identify such wallet txs?
311 2016-11-14T20:40:26  *** fengling has joined #bitcoin-core-dev
312 2016-11-14T20:40:26  <morcos> As a crutch instead of properly supporting such txs, would people accept a wallet function IsAllFromMe(filter), that let you know if all of the inputs were from you? so you'd know if your calculation of Debits was correct
313 2016-11-14T20:41:40  <morcos> I'd use this in bumpfee to just do nothing if not all the inputs were from you, and in listtransactions and gettransaction to not output an erroneous fee calculation
314 2016-11-14T20:45:38  *** fengling has quit IRC
315 2016-11-14T20:55:16  <Victorsueca> what about this:
316 2016-11-14T20:55:57  <Victorsueca> instead of using the IsMine logic, when the bumpfee command is issued then check whether the needed private keys are available
317 2016-11-14T20:58:05  <Victorsueca> if not available then assume the transaction was not involve the user in a way that allows him to use bumpfee
318 2016-11-14T20:58:12  <Victorsueca> does*
319 2016-11-14T20:59:07  <Victorsueca> sounds less resource-consuming than checking the IsMine logic
320 2016-11-14T21:03:43  <morcos> The problem is even if you have all the keys to sign the tx, if not all the inputs are you, you can't actually calculate the proper fee.
321 2016-11-14T21:04:07  <morcos> This is why listtransactions and gettransaction return erroneous results
322 2016-11-14T21:41:35  *** fengling has joined #bitcoin-core-dev
323 2016-11-14T21:46:41  *** fengling has quit IRC
324 2016-11-14T22:07:13  *** Guyver2 has quit IRC
325 2016-11-14T22:42:36  *** fengling has joined #bitcoin-core-dev
326 2016-11-14T22:45:10  *** MarcoFalke has left #bitcoin-core-dev
327 2016-11-14T22:45:55  <Victorsueca> what would be the appropriate way to suggest a new GUI feature?
328 2016-11-14T22:46:36  *** cryptapus is now known as cryptapus_afk
329 2016-11-14T22:47:44  *** fengling has quit IRC
330 2016-11-14T22:56:50  *** go1111111 has joined #bitcoin-core-dev
331 2016-11-14T23:10:59  *** shinyg has joined #bitcoin-core-dev
332 2016-11-14T23:36:49  *** belcher has joined #bitcoin-core-dev
333 2016-11-14T23:37:56  *** dcousens has quit IRC
334 2016-11-14T23:43:56  *** fengling has joined #bitcoin-core-dev
335 2016-11-14T23:48:47  *** fengling has quit IRC
336 2016-11-14T23:52:31  <shinyg> Hi people, I was after a little assistance from those who know more about Bitcoin Core and those who support Wikipedia.
337 2016-11-14T23:53:16  <shinyg> I have recently expanded the Wikipedia article for Bitcoin Core by a factor of 10.  Could someone spend just a few minutes to see if there are any major ommission or errors?
338 2016-11-14T23:54:53  <shinyg> I have almost no programming skills so I ask here because I imagine there are a few experts around, apologies if this is too off-topic
339 2016-11-14T23:56:58  <achow101> shinyg: blockstream does not fund Bitcoin Core development at all. There are developers who work on Bitcoin Core who also have jobs at Blockstream. The people who actually partially fund development are the MIT DCI who actually pay some people to work on Core (wladimir, cory)
340 2016-11-14T23:57:40  <shinyg> got it
341 2016-11-14T23:58:10  *** tulip has joined #bitcoin-core-dev
342 2016-11-14T23:58:20  <achow101> also, IIRC bitcoin.org and the bitcoin foundation are no longer related