1 2016-11-22T00:18:54  *** wasi has quit IRC
  2 2016-11-22T00:27:03  *** JackH has quit IRC
  3 2016-11-22T01:14:09  *** mol is now known as moli
  4 2016-11-22T01:20:19  *** go1111111 has quit IRC
  5 2016-11-22T01:32:29  *** windsok has quit IRC
  6 2016-11-22T01:33:16  *** abpa has quit IRC
  7 2016-11-22T01:42:40  *** Ylbam has quit IRC
  8 2016-11-22T01:44:00  *** Chris_Stewart_5 has quit IRC
  9 2016-11-22T01:45:53  *** abpa has joined #bitcoin-core-dev
 10 2016-11-22T01:51:31  *** skyraider has quit IRC
 11 2016-11-22T01:56:17  *** abpa has quit IRC
 12 2016-11-22T02:00:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 13 2016-11-22T02:16:22  *** windsok has joined #bitcoin-core-dev
 14 2016-11-22T02:43:59  *** abpa has joined #bitcoin-core-dev
 15 2016-11-22T02:44:57  *** Cory has quit IRC
 16 2016-11-22T02:47:32  *** Pasha has joined #bitcoin-core-dev
 17 2016-11-22T02:54:26  *** Pasha is now known as Cory
 18 2016-11-22T02:55:28  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9199: Always drop the least preferred HB peer when adding a new one. (master...remove_high_bandwidth_zombies) https://github.com/bitcoin/bitcoin/pull/9199
 19 2016-11-22T02:58:39  *** abpa has quit IRC
 20 2016-11-22T03:04:22  *** vanishing-coins has joined #bitcoin-core-dev
 21 2016-11-22T03:04:31  <vanishing-coins> hey guys, I believe I have found a rather serious issue with 0.13.1 but I am trying to figure out what is causing it
 22 2016-11-22T03:04:34  *** brg444 has joined #bitcoin-core-dev
 23 2016-11-22T03:04:38  <vanishing-coins> the symptom is that as coins are being sent through standard sendtoaddress RPC calls, overtime some change gets 'lost' until the wallet trends to 0, and the true balance is only restored when restarting Bitcoind. I am not speaking hyperbolically
 24 2016-11-22T03:04:43  <vanishing-coins> coins are never 'lost' but bitcoind has to restart for the correct balance to be shown
 25 2016-11-22T03:05:00  <vanishing-coins> I help multiple clients manage their nodes and this is the second time that I have seen this happen
 26 2016-11-22T03:05:17  <vanishing-coins> both clients were running 0.12 before without issue, upgraded to 0.13.1 and HD wallets and both had the issue within 48 hours of upgrading
 27 2016-11-22T03:08:05  *** btcdrak has quit IRC
 28 2016-11-22T03:08:40  *** Giszmo has quit IRC
 29 2016-11-22T03:15:16  <vanishing-coins> both are running on m1.smalls on Amazon EC2
 30 2016-11-22T03:15:39  <vanishing-coins> 1.7 gigs of ram, is it possible that unexpected behavior manifest due to low RAM? what would I be grepping for in the debug.log if so
 31 2016-11-22T03:17:13  <vanishing-coins> the max memory pool is set to 300mb
 32 2016-11-22T03:23:22  *** jtimon has quit IRC
 33 2016-11-22T03:29:38  <instagibbs> vanishing-coins, do you have debug.log to share?
 34 2016-11-22T03:30:26  <instagibbs> it sounds awfully similar to if you somehow chain too many transactions in mempool, it can throw an error and "lose" coins until restart
 35 2016-11-22T03:32:36  <vanishing-coins> instagibbs i do
 36 2016-11-22T03:32:44  <vanishing-coins> and that is definitely very possible -- can you elaborate on that chaining issue?
 37 2016-11-22T03:32:54  <vanishing-coins> is that a product of having too small a memory pool? any link i can read up on?
 38 2016-11-22T03:32:55  <instagibbs> well a look at the debug log when this happens would be helpful
 39 2016-11-22T03:33:16  *** Chris_Stewart_5 has quit IRC
 40 2016-11-22T03:33:20  <instagibbs> no, sorry it's likely not the issue, just thinking out loud. debug.log sharing is best
 41 2016-11-22T03:33:48  *** jyap has quit IRC
 42 2016-11-22T03:39:35  *** jyap has joined #bitcoin-core-dev
 43 2016-11-22T03:39:35  *** jyap has joined #bitcoin-core-dev
 44 2016-11-22T03:44:06  *** DigiByteDev has joined #bitcoin-core-dev
 45 2016-11-22T03:44:35  *** jtimon has joined #bitcoin-core-dev
 46 2016-11-22T03:45:51  *** vanishing-coins has quit IRC
 47 2016-11-22T03:46:09  *** justanotheruser has quit IRC
 48 2016-11-22T03:47:13  *** justanotheruser has joined #bitcoin-core-dev
 49 2016-11-22T03:55:01  *** jtimon has quit IRC
 50 2016-11-22T03:56:21  <gmaxwell> instagibbs: that wouldn't be until restart, no, it would be until after some of the chain confirms and then the retransmit logic fires.
 51 2016-11-22T04:02:30  *** DigiByteDev has quit IRC
 52 2016-11-22T04:08:45  *** vanishing-coins has joined #bitcoin-core-dev
 53 2016-11-22T04:08:57  <vanishing-coins> hey sorry got disconnected
 54 2016-11-22T04:09:01  <vanishing-coins> I am uploading the debug.log now
 55 2016-11-22T04:10:29  <vanishing-coins> I also dropped memorypool size to 150 mb, and dbcache to 80
 56 2016-11-22T04:10:54  <vanishing-coins> but very strange all around that two completely separate instances on EC2 of the same type were running fine on 0.12 but both, within 72 hours of upgrading, had the same exact issue :/
 57 2016-11-22T04:23:11  *** vanishing-coins has quit IRC
 58 2016-11-22T04:26:06  *** brg444 has quit IRC
 59 2016-11-22T04:43:20  *** abpa has joined #bitcoin-core-dev
 60 2016-11-22T04:46:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 61 2016-11-22T04:47:10  *** molz has joined #bitcoin-core-dev
 62 2016-11-22T04:49:14  *** moli has quit IRC
 63 2016-11-22T04:50:18  *** DigiByteDev has joined #bitcoin-core-dev
 64 2016-11-22T04:51:56  *** Chris_Stewart_5 has quit IRC
 65 2016-11-22T05:10:19  *** Cory has quit IRC
 66 2016-11-22T05:11:33  *** Pasha has joined #bitcoin-core-dev
 67 2016-11-22T05:13:27  *** DigiByteDev has joined #bitcoin-core-dev
 68 2016-11-22T05:18:27  *** Pasha is now known as Cory
 69 2016-11-22T05:53:16  *** Alopex has quit IRC
 70 2016-11-22T05:54:21  *** Alopex has joined #bitcoin-core-dev
 71 2016-11-22T06:03:21  *** fanquake has joined #bitcoin-core-dev
 72 2016-11-22T06:21:40  <luke-jr> cfields: ping
 73 2016-11-22T06:21:52  <luke-jr> should we be doing UpdateUncommittedBlockStructures in GBT proposals? :x
 74 2016-11-22T06:22:52  <cfields> luke-jr: are gbt proposals used?
 75 2016-11-22T06:23:07  <luke-jr> cfields: that's currently how I'm trying to test :D
 76 2016-11-22T06:23:19  <cfields> luke-jr: heh, i've been using #9000
 77 2016-11-22T06:23:21  <gribble> https://github.com/bitcoin/bitcoin/issues/9000 | miner debugging: faux-mining by theuni · Pull Request #9000 · bitcoin/bitcoin · GitHub
 78 2016-11-22T06:23:44  <cfields> but, as long as they're there, yea, i suppose so
 79 2016-11-22T06:24:17  <cfields> luke-jr: which reminds me, in the same vein, i think vbrequired needs some segwit love too?
 80 2016-11-22T06:24:30  <luke-jr> ?
 81 2016-11-22T06:25:36  <cfields> luke-jr: i just glanced at it briefly tonight, vbrequired is hard-coded to 0 as far as i can tell?
 82 2016-11-22T06:25:44  <luke-jr> cfields: as it should be right now
 83 2016-11-22T06:25:56  <cfields> maybe i don't really understand what it's for, i just made a note to look deeper into it later
 84 2016-11-22T06:26:01  <cfields> (or ping you :p )
 85 2016-11-22T06:26:24  <gmaxwell> jonasschnelli: I think the GUI should say "X blocks behind" instead of "X days/weeks/months/years" -- the latter seems to be frequently misunderstood as how long the sync is going to take. .. or perhaps we could do something smarter than that.
 86 2016-11-22T06:26:47  <luke-jr> cfields: it's a constraint on the miner, vbs they *must* signal
 87 2016-11-22T06:27:30  <luke-jr> gmaxwell: the master/0.14 GUI currently has a real ETA
 88 2016-11-22T06:27:57  <cfields> luke-jr: ah, ok. I thought it was vbs they must understand. nm, then.
 89 2016-11-22T06:28:14  <luke-jr> cfields: that's "rules", since when they must understand it, there is no bit assigned anymore ;)
 90 2016-11-22T06:28:59  <cfields> luke-jr: yep, makes sense
 91 2016-11-22T06:29:08  <luke-jr> huh, serializing CTransaction can modify it? :o
 92 2016-11-22T06:29:31  <cfields> luke-jr: sorry, didn't mean to hijack. But we may as well fix up proposals if there's a use-case
 93 2016-11-22T06:29:39  <luke-jr> (it resizes the witness vector to match the input vector)
 94 2016-11-22T06:30:08  <luke-jr> cfields: well, I guess it's either that and/or make Eloipool submit witness-form gen tx
 95 2016-11-22T06:41:13  *** DigiByteDev has quit IRC
 96 2016-11-22T06:57:50  <wumpus> gmaxwell: it used to say 'N blocks behind' a long time ago, was switched after lots of people complaining that blocks aren't a good indication of anything, though I'm not sure the time is that useful either...
 97 2016-11-22T06:58:01  <wumpus> gmaxwell: there's been so much iteration on that damn progress bar at some point :p
 98 2016-11-22T06:58:33  <gmaxwell> I was thinking that as I typed it...
 99 2016-11-22T06:58:51  <wumpus> oh I remember now, that complaint was more like 'blocks are too technical!'
100 2016-11-22T06:59:00  <wumpus> 'show only blocks count in the debug interface and hover' well okay
101 2016-11-22T06:59:15  <gmaxwell> luke-jr: I was just looking at gui in master... got 'n days behind'. which sounds like how long it will take.
102 2016-11-22T06:59:17  <wumpus> maybe things changed with the blockchains hype
103 2016-11-22T07:00:10  <luke-jr> gmaxwell: so the ETA doesn't distract enough from it, you're saying? :x
104 2016-11-22T07:00:11  <gmaxwell> To be honest it might as well say "working hard at catching up! here is a spinner /-\_/-\..."
105 2016-11-22T07:00:15  <luke-jr> lol
106 2016-11-22T07:00:21  <gmaxwell> luke-jr: I didn't see it! :P
107 2016-11-22T07:00:23  <wumpus> here's dancing hamsters...
108 2016-11-22T07:00:36  <luke-jr> I wasn't even looking for it, yet saw and appreciated it :p
109 2016-11-22T07:01:06  <gmaxwell> but I've seen two reddit threads recently where they thought the x years behind was the catchup time, and one person on IRC. ... lemme go look
110 2016-11-22T07:01:15  <sipa> use this early in the chain when we don't have a good estimate yet: ¯\_(ツ)_/¯
111 2016-11-22T07:01:18  <wumpus> yes I believe you that people get confused about it
112 2016-11-22T07:01:18  <luke-jr> yeah, Core 0.13 doesn't have it yet
113 2016-11-22T07:02:03  <luke-jr> I once had a feature request for Knots to have a button to click to play an audible "to the moon" sound bite..
114 2016-11-22T07:02:07  <sipa> luke-jr: fixed in 8580
115 2016-11-22T07:02:31  <wumpus> it's not really telling what it is doing either, e.g. if it was more apparent that it was validating history then in that context 'X years behind' makes sense
116 2016-11-22T07:03:03  <luke-jr> someone want to make an animation of it checking the blocks? :p
117 2016-11-22T07:03:22  <gmaxwell> okay the progress popup box I just dismissed. maybe now that we have that we don't need the progress bar to say 'foo behind'?
118 2016-11-22T07:03:28  <wumpus> then again the new modal overlay with ETA and such is really nice and mitigates these concerns
119 2016-11-22T07:03:51  <luke-jr> gmaxwell: I suggest change the progress bar to "Synchronising (ETA <x>)" ☺
120 2016-11-22T07:03:58  <wumpus> luke-jr: +1
121 2016-11-22T07:04:02  <fanquake> I agree, the new overlay is a good improvement.
122 2016-11-22T07:04:25  <gmaxwell> luke-jr: that would be fine.
123 2016-11-22T07:04:31  <wumpus> luke-jr: haha an animation of someone retrieving books of transactions from a chain of blocks and checking them?
124 2016-11-22T07:05:26  *** Alina-malina has quit IRC
125 2016-11-22T07:05:26  *** Alina-malina has joined #bitcoin-core-dev
126 2016-11-22T07:05:28  <fanquake> wumpus or gmaxwell, have you seen any Boost related memory leaks during your testing?
127 2016-11-22T07:05:43  <gmaxwell> the popup is kind of a sea of grey on my screen.
128 2016-11-22T07:05:51  <fanquake> Sorry to change topic, but I seem to have fallen down some memory leaks rabbit holes.
129 2016-11-22T07:05:57  <gmaxwell> fanquake: no!
130 2016-11-22T07:06:01  <wumpus> fanquake: nope.
131 2016-11-22T07:06:21  <wumpus> fanquake: qt and ancillary GUI libs (Fontconfig etc) is the only thing leaking here
132 2016-11-22T07:06:54  <wumpus> and all the leaks apparent in other libraries downstream seem to come from there
133 2016-11-22T07:06:54  <fanquake> Hmm ok you see leaks from leveldb as well?
134 2016-11-22T07:06:59  <wumpus> no
135 2016-11-22T07:07:12  <luke-jr> wumpus: I was thinking more of a horizontal line of pages sized based on the block size, and a red line scanning over them ;)
136 2016-11-22T07:07:14  <wumpus> nothing in the core code
137 2016-11-22T07:07:26  <gmaxwell> No. There is a little bit from the openssl RNG.
138 2016-11-22T07:07:28  <wumpus> bitcoind is 100% leak clen
139 2016-11-22T07:07:40  <gmaxwell> but bitcoind itself is 100% leak clean for me.
140 2016-11-22T07:07:41  <luke-jr> wumpus: valgrind thinks the wallet code leaks
141 2016-11-22T07:07:58  <wumpus> (at least the normal exit path, I haven't tried all kinds of panic shutdown scenarios ofc)
142 2016-11-22T07:08:08  <luke-jr> it was around some BDB mess, so I didn't look far
143 2016-11-22T07:08:22  <luke-jr> (one time at startup)
144 2016-11-22T07:08:36  <wumpus> luke-jr: not seeing that here. But I use the system berkeleydb in Ubuntu 16.04
145 2016-11-22T07:08:43  <wumpus> not 4.8 or that shit :)
146 2016-11-22T07:09:42  <luke-jr> I use system 4.8 :P
147 2016-11-22T07:09:58  <fanquake> Ok, I'll post a few details in a sec.
148 2016-11-22T07:10:38  <wumpus> I honestly don't even know what version it is... lemme check. 5.3.
149 2016-11-22T07:11:40  <wumpus> in any case I don't think we can ever prevent all one-time leaks in the GUI code, too many moving parts
150 2016-11-22T07:12:36  <gmaxwell> they're mostly interesting to fix because sometimes they're actual bugs, and keeping down the inconsequential ones avoids hiding the actual bugs.
151 2016-11-22T07:12:48  <wumpus> the only reason they're annoying at all is that they clutter the overview, so you may miss repeated leaks
152 2016-11-22T07:13:07  <wumpus> right - I found an actual (minor) bug due to it with the rpc console thread
153 2016-11-22T07:14:10  <fanquake> What I'm seeing seems to be Boost related, somewhere in CCoinsViewCache::FetchCoins()
154 2016-11-22T07:15:03  <wumpus> do you see it with only the GUI, or with bitcoind too?
155 2016-11-22T07:15:40  <wumpus> (not seeing them in any case but maybe an OSX thing?)
156 2016-11-22T07:17:00  <fanquake> Have only tested with bitcoin-qt so far, I'll look at bitcoind now.
157 2016-11-22T07:22:15  *** Ylbam has joined #bitcoin-core-dev
158 2016-11-22T07:23:30  <fanquake> Here's a stack trace for the Boost leak, http://pastebin.com/V2QY8NT4 , not seeing anything on bitcoind so far (other than something related to berkely-db)
159 2016-11-22T07:23:33  <wumpus> the most sneaky leak (and also most bytes wasted) I fixed in #9190 was the openssl certstore one (https://github.com/bitcoin/bitcoin/pull/9190/commits/4b2c2888868cb49806cd734ea36e7f5b032c3b00) . OpenSSL's documentation is somewhat fuzzy about it, but the assumption there was wrong, that X509_STORE_add_cert really tkaes ownership
160 2016-11-22T07:23:34  <gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
161 2016-11-22T07:25:10  <wumpus> fanquake: what version of boost?
162 2016-11-22T07:25:20  <sipa> fanquake: is that with a clean shutdown?
163 2016-11-22T07:25:58  <fanquake> Boost 1.62.0
164 2016-11-22T07:26:08  <fanquake> That is without shutting down, just while it's running.
165 2016-11-22T07:26:23  <jonasschnelli> fanquake: I'm also compiling against Qt 5.7
166 2016-11-22T07:26:47  <wumpus> you can only see *leaks* after you've shut down
167 2016-11-22T07:26:56  <jonasschnelli> though I don't see the CCoinsViewCache::FetchCoins() leak
168 2016-11-22T07:27:50  <wumpus> profilers can't predict the future of what an application is going to do with some memory, so you can't be sure some memory won't be released until the end of the shutdown sequence
169 2016-11-22T07:28:29  <jonasschnelli> wumpus: I guess some leaks are detectable during runtime (when all pointers have lost the object)... not?
170 2016-11-22T07:28:30  <wumpus> (although it could use some heuristic like "does the application retain any pointers to it" but that's horribly imprecise at most for C++)
171 2016-11-22T07:28:45  <wumpus> jonasschnelli: not in general for unmanaged languages
172 2016-11-22T07:29:11  <wumpus> and managed languages tend to have garbage collectors anyway :-)
173 2016-11-22T07:29:20  <jonasschnelli> I guess it often leads to wrong detected leaks... (maybe losts).
174 2016-11-22T07:29:28  <luke-jr> wumpus: I think it can be done with sufficient accuracy that the alternative is undefined behaviour?
175 2016-11-22T07:29:36  <luke-jr> or at least very bad code :p
176 2016-11-22T07:30:10  <jonasschnelli> I also think the Leak detector fanquake and I are using (Apples "Instruments") are not really made for C++... It's perfect when analyzing objective-C code.
177 2016-11-22T07:30:23  * luke-jr actually finds runtime leak detection more useful than after exit, since many things use data but don't clean it up as well
178 2016-11-22T07:30:35  <fanquake> Ok, I'm probably using the wrong terminology here then. I don't have too much experience using these kind of tools.
179 2016-11-22T07:30:46  <wumpus> luke-jr: well that depends on your definition of 'bad code' I suppose, I'm just talking about theoretic properties not judging any particular use of cpu cycles :p
180 2016-11-22T07:30:49  <fanquake> jonas Yes, hat might also be a part of the problem.
181 2016-11-22T07:31:04  <luke-jr> wumpus: by bad code, I mean serializing the pointer in a uint8_t array or something
182 2016-11-22T07:31:17  <luke-jr> or XORing it
183 2016-11-22T07:31:22  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c577f2638b7...e4dbeb94998d
184 2016-11-22T07:31:23  <bitcoin-git> bitcoin/master 76af4eb Jonas Schnelli: [Qt] fix coincontrol sort issue
185 2016-11-22T07:31:23  <bitcoin-git> bitcoin/master 4231032 Wladimir J. van der Laan: [Qt] Clean up and fix coincontrol tree widget handling...
186 2016-11-22T07:31:24  <bitcoin-git> bitcoin/master e4dbeb9 Jonas Schnelli: Merge #9185: [Qt] fix coincontrol sort issue...
187 2016-11-22T07:31:35  <jonasschnelli> fanquake: But I was also surprised how many leaks I found with "Instruments" when writing pure C code.
188 2016-11-22T07:31:50  <jonasschnelli> Though, you need a sleep(100) at the end of your application/unit-tests.
189 2016-11-22T07:32:00  <jonasschnelli> Brews Valgrind is pretty broken on OSX:
190 2016-11-22T07:32:05  <jonasschnelli> s/:/.
191 2016-11-22T07:32:22  <luke-jr> LLVM also has a leak sanitizer
192 2016-11-22T07:32:30  <fanquake> jonass As far as I know it won't work at all for a while https://bugs.kde.org/show_bug.cgi?id=365327
193 2016-11-22T07:32:42  <fanquake> Neither does GDB
194 2016-11-22T07:32:48  <wumpus> luke-jr: yes but I don't think e.g. pointer bit flipping tricks are by definition bad code, it just depends on the context, the resources available etc
195 2016-11-22T07:33:42  <jonasschnelli> IMO all the CDB (BDB) leaks reported by "Instruments" are wrong reports...
196 2016-11-22T07:33:51  <fanquake> jonasschnelli so when we're looking at anything CWallet related in instruments (which is all I see looking at bitcoind) what are we seeing exactly?
197 2016-11-22T07:34:10  <fanquake> heh, just what I was wondering.
198 2016-11-22T07:34:17  <jonasschnelli> fanquake: tons of BDB leaks...
199 2016-11-22T07:34:20  <jonasschnelli> I guess >10MB
200 2016-11-22T07:34:28  <jonasschnelli> (for a 300tx regtext wallet)
201 2016-11-22T07:34:28  <wumpus> PSA: the macosx tools are wasting your time
202 2016-11-22T07:34:29  <wumpus> :-)
203 2016-11-22T07:34:39  <fanquake> :o
204 2016-11-22T07:34:53  <jonasschnelli> wumpus: there is also the time profiler in "Instrumenst"... this is really cool.
205 2016-11-22T07:34:58  <jonasschnelli> gpref like
206 2016-11-22T07:35:08  <jonasschnelli> gperf
207 2016-11-22T07:35:57  <jonasschnelli> wumpus: how did you detected the Qt leaks? IMO last time I used it on Bitcoin-Qt on Ubuntu I had to force shutdown my machine.. :)
208 2016-11-22T07:36:04  <wumpus> luke-jr: yes - LLVM sanitizers that's what I used in #9190, built from latest LLVM git even, I have to track that anyhow for some GPU stuff
209 2016-11-22T07:36:05  <gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
210 2016-11-22T07:36:43  <wumpus> jonasschnelli: ^
211 2016-11-22T07:36:50  <jonasschnelli> Yes. Thanks...
212 2016-11-22T07:37:40  <wumpus> CPPFLAGS="-ggdb -fsanitize=address -fno-omit-frame-pointer"   LDFLAGS="-fsanitize=address"
213 2016-11-22T07:38:24  <fanquake> So we can ignore all of the certificate related Qt stuff as well?
214 2016-11-22T07:39:03  <wumpus> it generates really nice rainbow console output, makes finding a use-after-free bug almost enjoyable
215 2016-11-22T07:39:48  <wumpus> fanquake: not sure about ignoring anything, but please if you report leaks make sure that you are talking about the allocation residue after quitting the application
216 2016-11-22T07:40:47  <fanquake> wumpus: Yep, have a bit better handle on this now. Looks like using some tools other than the native OS X stuff could be the way to go.
217 2016-11-22T07:43:26  <wumpus> jonasschnelli: but yes visual profilers can be really cool, at a previous employer for solaris we had one that showed exactly what an application was doing on each core in a timeline overview, that was really useful for checking efficiency of concurrency etc
218 2016-11-22T07:44:06  <wumpus> I kind of miss that in the linux toolset but I may be missing something, so many different tools and instrumentations
219 2016-11-22T07:47:06  *** baldur has quit IRC
220 2016-11-22T07:48:23  *** btcdrak has joined #bitcoin-core-dev
221 2016-11-22T07:51:30  *** wasi has joined #bitcoin-core-dev
222 2016-11-22T07:52:00  *** wasi has quit IRC
223 2016-11-22T07:52:30  *** wasi has joined #bitcoin-core-dev
224 2016-11-22T07:55:02  <sipa> dtrace?
225 2016-11-22T07:58:45  <wumpus> yes I think it was based on that
226 2016-11-22T08:00:32  <wumpus> but without having to actaully write dtrace scripts :)
227 2016-11-22T08:08:12  *** baldur has joined #bitcoin-core-dev
228 2016-11-22T08:13:08  <jonasschnelli> wumpus: when compiling with CPPFLAGS/LDFLAGS +"-fsanitize=address", I get Undefined symbols during liking (___asan_stack_malloc_5, etc.)? Any ideas?
229 2016-11-22T08:14:38  *** gielbier has quit IRC
230 2016-11-22T08:21:29  <wumpus> jonasschnelli: it should try to link against the asan runtime library
231 2016-11-22T08:21:59  <jonasschnelli> I passed -fasnitize=address as LDFLAGS ... hmm...
232 2016-11-22T08:22:03  *** wasi has quit IRC
233 2016-11-22T08:22:09  <jonasschnelli> *-fsanitize=address
234 2016-11-22T08:22:19  <wumpus> things like "libclang_rt.asan_cxx-i686.a"
235 2016-11-22T08:22:26  *** rubensayshi has joined #bitcoin-core-dev
236 2016-11-22T08:22:36  *** wasi has joined #bitcoin-core-dev
237 2016-11-22T08:23:01  <wumpus> I had to put compiler-rt in my llvm/clang build to get them in the first place, but I'd expect distro-build versions to have that enabled by default
238 2016-11-22T08:23:24  <wumpus> in any case yes passing that to the linker should try to link them automatically
239 2016-11-22T08:25:51  <jonasschnelli> hmm... libclang_rt.asan_osx_dynamic is present...
240 2016-11-22T08:29:11  <jonasschnelli> I guess OSX XCode clang uses a different linking approach in oder to support ASAN for all its supported platforms (iOS/ apple tv/ apple watch, etc.).
241 2016-11-22T08:29:28  <jonasschnelli> Probably better to use a self-compiled clang (or though homebrew)
242 2016-11-22T08:31:10  <fanquake> I know we already need documentation for lots of existing stuff, but this kind of debugging/configuration/dev tool type stuff would also be worth documenting. At least more than what we have now.
243 2016-11-22T08:31:45  <fanquake> It'd be nice to have *lots* of people running the identical binary, and similar tools.
244 2016-11-22T08:32:21  <jonasschnelli> I tried to add the ASAN to the cofigure.ac
245 2016-11-22T08:34:07  <wumpus> agree that tooling documentation would be useful, though none of this is specific to bitcoin core
246 2016-11-22T08:35:11  <wumpus> some projects have a wiki with this kind of auxiliary documentation
247 2016-11-22T08:36:03  <fanquake> Yes I'm assuming there must be similar projects, maybe something like Tor, that would already have alot of this kind of stuff written/documented somewhere.
248 2016-11-22T08:40:17  <paveljanik> fanquake, the documentation is generic for debugging tools...
249 2016-11-22T08:40:31  <paveljanik> and there already is a lot of such documentation.
250 2016-11-22T08:49:32  * wumpus is trying to add CPU cycles measure to the bench framework and probably stumbled on a subtle counting bug w/ rescaling the iteration count
251 2016-11-22T08:49:50  <wumpus> this can cause especially the 'min' time to be off
252 2016-11-22T08:55:42  <gmaxwell> wumpus: darn. I thought I'd tested that fairly well.
253 2016-11-22T09:00:50  <bitcoin-git> [bitcoin] laanwj opened pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
254 2016-11-22T09:08:15  <gmaxwell> oh pfft.
255 2016-11-22T09:08:26  <wumpus> yea :)
256 2016-11-22T09:16:11  *** paveljanik has quit IRC
257 2016-11-22T09:17:33  *** jannes has joined #bitcoin-core-dev
258 2016-11-22T09:28:35  <gmaxwell> wumpus: I guess I'd reasoned it would be 0 mod n due to the initial count, oh well.
259 2016-11-22T09:29:33  <wumpus> yes it's really subtle, I only discovered it because I was printing lots of debug info to debug the cycle counter, then saw the first run after a scale was off
260 2016-11-22T09:31:51  <wumpus> the use of floating point arithmetic in the benchmarking loop isn't too great either but I'll leave that for another time
261 2016-11-22T09:32:24  <gmaxwell> yea, esp on the kind of platforms that you really need to benchmark things on.
262 2016-11-22T09:33:32  <gmaxwell> I wanted to eliminate that too when I last touched it but I thought it would be too much at once. :)
263 2016-11-22T09:47:01  <wumpus> exactly
264 2016-11-22T09:52:38  *** laurentmt has joined #bitcoin-core-dev
265 2016-11-22T09:55:55  *** laurentmt has quit IRC
266 2016-11-22T09:56:32  <jouke> re IRC meeting: we use the account system
267 2016-11-22T09:59:01  *** d9b4bef9 has quit IRC
268 2016-11-22T10:00:07  *** d9b4bef9 has joined #bitcoin-core-dev
269 2016-11-22T10:01:29  *** echonaut has quit IRC
270 2016-11-22T10:01:35  *** echonaut7 has joined #bitcoin-core-dev
271 2016-11-22T10:10:13  <jouke> Basically the same use case as dooglus in https://github.com/bitcoin/bitcoin/issues/3816
272 2016-11-22T10:11:07  <wumpus> yes there needs to be an explanation how to do that without accounts / with the new labels API
273 2016-11-22T10:11:45  <jouke> Not something we can't do ourselves, but it was there, so why not use it :P
274 2016-11-22T10:12:23  <wumpus> and for that specific use case you don't really need accounts, just a way to track/group incoming payments using a label
275 2016-11-22T10:16:12  <jouke> And keep track of reorgs?
276 2016-11-22T10:24:24  *** jeroen has joined #bitcoin-core-dev
277 2016-11-22T10:27:35  <jouke> Again, not something we can't do ourselves and we've known that accounts are deprecated for a while, but I was reading the IRC meeting summary and someone was wondering if anyone talking to the devs was using accounts, so I started talking :P
278 2016-11-22T10:29:42  <Victorsueca> the whole accounts thing doesn't make a lot of sense
279 2016-11-22T10:30:36  <jouke> What do you mean Victorsueca?
280 2016-11-22T10:30:44  <Victorsueca> I received some bitcoins to a address labeled "Victor" and later spent them all
281 2016-11-22T10:31:09  <Victorsueca> now the account "Victor" still has the balance and the default "" account is in negative
282 2016-11-22T10:31:28  <Victorsueca> and I didn't use the move command
283 2016-11-22T10:31:53  <jouke> Victorsueca: because you didn't use "senfrom"?
284 2016-11-22T10:32:13  *** gielbier has joined #bitcoin-core-dev
285 2016-11-22T10:32:21  <Victorsueca> nope, didn't use that either
286 2016-11-22T10:32:41  <thermoman> sdaftuar: we do import privkeys every 2 or 3 days
287 2016-11-22T10:32:50  <jouke> That's why it's negative :).
288 2016-11-22T10:33:17  <jouke> Victorsueca: but I get why it's confusing, that's one of the reasons it's deprecated :)
289 2016-11-22T10:35:59  <Victorsueca> is it safe if I move all from bitcoin to "" or I would mess with the wallet balance calculation?
290 2016-11-22T10:36:07  <Victorsueca> from Victor*
291 2016-11-22T10:37:28  <jouke> Victorsueca: sendtoaddress only subtracts the amount from the default account, sendfrom subtracts the amount from a specific account. Victorsueca it's safe, but again, don't start using accounts, it will be removed in future versions.
292 2016-11-22T10:38:09  <Victorsueca> ahh nice
293 2016-11-22T10:47:29  <luke-jr> Victorsueca: it makes sense.
294 2016-11-22T10:48:02  <luke-jr> jouke: unless you're willing to *maintain* the account system, your usage isn't likely to change its removal
295 2016-11-22T10:48:18  <luke-jr> jouke: and even if you're willing to maintain it, I think the conclusion will be "please do it outside bitcoind"
296 2016-11-22T10:49:26  <jouke> luke-jr: I know.
297 2016-11-22T10:49:31  <Victorsueca> luke-jr: btw, I was wondering when will you be able to push segwit into bfgminer
298 2016-11-22T10:50:17  <luke-jr> Victorsueca: you mean libblkmaker :P
299 2016-11-22T10:50:22  <luke-jr> Victorsueca: testing would be helpful
300 2016-11-22T10:51:44  <Victorsueca> luke-jr: I would, but my Antminer U3 seems to only work on windows and I didn't find any instructions on how to cross-compile
301 2016-11-22T10:52:09  <luke-jr> review is helpful too
302 2016-11-22T10:52:25  <Victorsueca> don't know coding C++
303 2016-11-22T10:54:04  <luke-jr> https://github.com/bitcoin/libblkmaker/pull/6  https://github.com/luke-jr/eloipool/pull/15
304 2016-11-22T10:54:16  <luke-jr> Eloipool is Python <.<
305 2016-11-22T10:54:31  <luke-jr> will get you Windows bins for BFG in a min
306 2016-11-22T10:55:00  <Victorsueca> nice thanks
307 2016-11-22T10:57:44  <luke-jr> :| build failure, a few more min..
308 2016-11-22T10:58:15  <Victorsueca> hehhehe
309 2016-11-22T10:58:44  <Victorsueca> windoze will always be windoze
310 2016-11-22T11:02:59  <luke-jr> in this case, it is libgcrypt's fault
311 2016-11-22T11:03:13  <luke-jr> but that's okay because it shouldn't be using libgcrypt in the first place :P
312 2016-11-22T11:04:11  *** shesek has quit IRC
313 2016-11-22T11:07:57  <luke-jr> Victorsueca: http://luke.dashjr.org/tmp/code/webisect/webisect.php?dobuild=segwit
314 2016-11-22T11:09:38  <Victorsueca> nice, going to try it out
315 2016-11-22T11:10:30  <thermoman> gmaxwell, sipa, sdaftuar: https://github.com/bitcoin/bitcoin/issues/9201
316 2016-11-22T11:16:56  <luke-jr> Victorsueca: p.s. if you want to mine testnet with it, tmp.pool.bitcoin.dashjr.org port 3334 (stratum) or 8337 (GBT & getwork)
317 2016-11-22T11:17:22  <luke-jr> Victorsueca: no promises I don't kill it in a few hours tho, it's eating CPU time
318 2016-11-22T11:17:34  *** shesek has joined #bitcoin-core-dev
319 2016-11-22T11:17:37  <luke-jr> besides, better to solo mine :P
320 2016-11-22T11:17:51  <wumpus> jouke: no, with labels instead of accounts you don't have to manually keep track of reorgs, you can still check the total balance received to a label, for example. You just cannot do accounting, so move coins instead of addresses from one label to another
321 2016-11-22T11:18:41  <luke-jr> can't send from labels either :p
322 2016-11-22T11:18:52  <wumpus> right
323 2016-11-22T11:19:16  *** fanquake has left #bitcoin-core-dev
324 2016-11-22T11:21:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4dbeb94998d...55b2eddcc8fd
325 2016-11-22T11:21:04  <bitcoin-git> bitcoin/master e0a9cb2 Wladimir J. van der Laan: bench: Fix subtle counting issue when rescaling iteration count...
326 2016-11-22T11:21:05  <bitcoin-git> bitcoin/master 55b2edd Wladimir J. van der Laan: Merge #9200: bench: Fix subtle counting issue when rescaling iteration count...
327 2016-11-22T11:21:17  <bitcoin-git> [bitcoin] laanwj closed pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
328 2016-11-22T11:22:18  <Victorsueca> luke-jr: thanks, I will try to solo-mine for a while too to see if it signals segwit properly
329 2016-11-22T11:23:18  <bitcoin-git> [bitcoin] laanwj opened pull request #9202: bench: Add support for measuring CPU cycles (master...2016_11_bench_cpu_cycles) https://github.com/bitcoin/bitcoin/pull/9202
330 2016-11-22T11:45:12  *** abpa has quit IRC
331 2016-11-22T11:57:02  <Victorsueca> luke-jr: any tip on how to detect my Antminer U3? I've been following the instructions on README.ASIC ut it won't detect it
332 2016-11-22T11:57:10  <Victorsueca> but*
333 2016-11-22T11:57:23  <luke-jr> Victorsueca: the official drivers are installed? (not WinUSB/Zadig)
334 2016-11-22T11:59:28  <Victorsueca> ahh, It needs to be with the default driver?
335 2016-11-22T11:59:41  <Victorsueca> I have WinUSB
336 2016-11-22T12:02:11  <luke-jr> yes
337 2016-11-22T12:08:01  *** CubicEarth has quit IRC
338 2016-11-22T12:27:21  <Victorsueca> luke-jr: still not detecting it
339 2016-11-22T12:27:35  <luke-jr> with the options in README.ASIC?
340 2016-11-22T12:28:02  <Victorsueca> yep, and with the default sillabs driver
341 2016-11-22T12:28:09  <wumpus> this is not related to bitcoin core development, can you move this to #bitcoin?
342 2016-11-22T12:28:15  <Victorsueca> sure
343 2016-11-22T12:57:10  <bitcoin-git> [bitcoin] jnewbery opened pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
344 2016-11-22T13:08:31  *** CubicEarth has joined #bitcoin-core-dev
345 2016-11-22T13:12:50  <bitcoin-git> [bitcoin] jnewbery closed pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
346 2016-11-22T13:13:16  *** CubicEarth has quit IRC
347 2016-11-22T13:31:47  *** Giszmo has joined #bitcoin-core-dev
348 2016-11-22T13:46:34  *** laurentmt has joined #bitcoin-core-dev
349 2016-11-22T13:46:39  *** laurentmt has quit IRC
350 2016-11-22T13:48:47  <instagibbs> ;;later tell vanishing-coins Looks like you are trying to make dust, aka too-small outputs, and your wallet is refusing to send them
351 2016-11-22T13:48:48  <gribble> The operation succeeded.
352 2016-11-22T13:52:15  *** aalex__ has joined #bitcoin-core-dev
353 2016-11-22T13:58:48  *** aalex__ has quit IRC
354 2016-11-22T14:04:37  *** wasi has quit IRC
355 2016-11-22T14:04:59  *** BashCo has joined #bitcoin-core-dev
356 2016-11-22T14:05:09  *** wasi has joined #bitcoin-core-dev
357 2016-11-22T14:16:12  *** jtimon has joined #bitcoin-core-dev
358 2016-11-22T14:23:55  *** cryptapus has joined #bitcoin-core-dev
359 2016-11-22T14:23:55  *** cryptapus has joined #bitcoin-core-dev
360 2016-11-22T14:27:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
361 2016-11-22T14:31:57  *** cryptapus has quit IRC
362 2016-11-22T14:32:22  *** cryptapus has joined #bitcoin-core-dev
363 2016-11-22T14:33:04  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55b2eddcc8fd...ac489b24453c
364 2016-11-22T14:33:04  <bitcoin-git> bitcoin/master 1260c11 Pavel Janík: Mention the new network toggle functionality in the tooltip.
365 2016-11-22T14:33:04  <bitcoin-git> bitcoin/master ac489b2 Jonas Schnelli: Merge #9130: Mention the new network toggle functionality in the tooltip....
366 2016-11-22T14:33:17  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9130: Mention the new network toggle functionality in the tooltip. (master...20161111_disable_network_tooltip) https://github.com/bitcoin/bitcoin/pull/9130
367 2016-11-22T14:34:38  *** Guyver2 has joined #bitcoin-core-dev
368 2016-11-22T14:42:19  <nsh> toggles all network activity?
369 2016-11-22T14:42:22  <nsh> handy i guess
370 2016-11-22T14:42:44  *** aalex__ has joined #bitcoin-core-dev
371 2016-11-22T14:43:05  <jonasschnelli> nsh: The PR above is just a cosmetic one.
372 2016-11-22T14:43:20  <jonasschnelli> The actual toggle It's in master since some days
373 2016-11-22T14:43:31  <jonasschnelli> Just press the network-icon on the top right in the status bar.
374 2016-11-22T14:43:38  <jonasschnelli> (if you are using the GUI)
375 2016-11-22T14:43:39  * nsh nods
376 2016-11-22T14:45:43  *** laurentmt has joined #bitcoin-core-dev
377 2016-11-22T14:50:20  <wumpus> setnetworkactive through rpc
378 2016-11-22T14:52:01  *** laurentmt has quit IRC
379 2016-11-22T15:56:17  *** abpa has joined #bitcoin-core-dev
380 2016-11-22T15:58:07  *** abpa has quit IRC
381 2016-11-22T16:21:15  *** jeroen has quit IRC
382 2016-11-22T16:22:36  *** Chris_Stewart_5 has quit IRC
383 2016-11-22T16:54:25  *** instagibbs has quit IRC
384 2016-11-22T17:00:35  *** instagibbs has joined #bitcoin-core-dev
385 2016-11-22T17:03:21  *** rubensayshi has quit IRC
386 2016-11-22T17:05:42  *** abpa has joined #bitcoin-core-dev
387 2016-11-22T17:34:38  *** atroxes_ has joined #bitcoin-core-dev
388 2016-11-22T17:35:08  *** atroxes_ has quit IRC
389 2016-11-22T17:36:46  *** atroxes has quit IRC
390 2016-11-22T17:39:21  *** protomar has joined #bitcoin-core-dev
391 2016-11-22T17:58:54  *** abpa has quit IRC
392 2016-11-22T18:00:54  *** ryanofsky has quit IRC
393 2016-11-22T18:12:10  *** CubicEarth has joined #bitcoin-core-dev
394 2016-11-22T18:14:19  *** aalex__ is now known as aalex
395 2016-11-22T18:17:38  *** abpa has joined #bitcoin-core-dev
396 2016-11-22T18:22:14  <bitcoin-git> [bitcoin] instagibbs opened pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204
397 2016-11-22T18:23:18  *** ryanofsky has joined #bitcoin-core-dev
398 2016-11-22T18:29:26  *** abpa has quit IRC
399 2016-11-22T18:36:23  *** abpa has joined #bitcoin-core-dev
400 2016-11-22T18:38:13  *** paveljanik has joined #bitcoin-core-dev
401 2016-11-22T18:38:13  *** paveljanik has joined #bitcoin-core-dev
402 2016-11-22T18:41:01  *** abpa has quit IRC
403 2016-11-22T18:43:30  *** abpa has joined #bitcoin-core-dev
404 2016-11-22T18:43:41  *** laurentmt has joined #bitcoin-core-dev
405 2016-11-22T18:44:45  *** laurentmt has quit IRC
406 2016-11-22T18:55:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
407 2016-11-22T19:06:01  <bitcoin-git> [bitcoin] in3rsha opened pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205
408 2016-11-22T19:33:03  *** instagibbs has quit IRC
409 2016-11-22T19:33:49  *** instagibbs has joined #bitcoin-core-dev
410 2016-11-22T19:38:32  *** instagibbs has quit IRC
411 2016-11-22T19:43:21  *** instagibbs has joined #bitcoin-core-dev
412 2016-11-22T19:45:04  <adiabat> howdy, I've having trouble getting 0.13.1 synced up to testnet3
413 2016-11-22T19:45:09  <adiabat> running on a raspi2
414 2016-11-22T19:45:36  <adiabat> got a "EXCEPTION: St9bad_alloc" in debug.log
415 2016-11-22T19:45:50  <sipa> how much ram does that have?
416 2016-11-22T19:45:57  <adiabat> 1G
417 2016-11-22T19:46:24  <adiabat> I've gotten that exception in different places when deleting and starting over
418 2016-11-22T19:46:25  <sipa> hmm, maybe you need a bit of tweaking to reduce dbcache/mempool, and limit the number of peers?
419 2016-11-22T19:46:35  <sipa> it shouldn't be much
420 2016-11-22T19:46:49  <adiabat> this is all with 1 peer via connect= in the conf
421 2016-11-22T19:46:59  <adiabat> also I'm running txindex=1
422 2016-11-22T19:47:03  <sipa> ah
423 2016-11-22T19:48:15  <adiabat> it was working OK on 0.13.1 but that had been upgraded many times.  Then I broke my microSD card in half :(
424 2016-11-22T19:48:48  <adiabat> IBD from scratch on .13.1 on the pi may need different settings?
425 2016-11-22T19:50:06  <sipa> maybe... it clearly means OOM
426 2016-11-22T19:50:55  <adiabat> I'll try dbcache=64
427 2016-11-22T19:56:59  *** aalex_ has joined #bitcoin-core-dev
428 2016-11-22T19:57:12  *** cfields has quit IRC
429 2016-11-22T20:00:48  *** aalex has quit IRC
430 2016-11-22T20:00:48  *** cfields has joined #bitcoin-core-dev
431 2016-11-22T20:02:42  <adiabat> If this works (will know in ~24hrs) maybe we can put a readme or something.  With the arm binaries I think more people will try running on a pi2/pi3
432 2016-11-22T20:03:40  <adiabat> also far be it from me to complain but trashing the who DB requiring re-index on an OOM error is... unfortunate.
433 2016-11-22T20:03:48  <adiabat> (Not offering to fix that! heh)
434 2016-11-22T20:03:58  <adiabat> who = *whole
435 2016-11-22T20:05:08  <sipa> we should work on being able to dump the utxo set to a file and load it back
436 2016-11-22T20:07:51  <adiabat> I've never had bitcoind get in trouble with RAM on a regular x86 computer, and I've run it on PCs with 2G of RAM
437 2016-11-22T20:10:36  *** cysm has quit IRC
438 2016-11-22T20:15:21  <gmaxwell> 2GB is a lot more than 1GB. :)
439 2016-11-22T20:17:05  <adiabat> heh... I wonder what the least powerful full node is.  raspi is getting close maybe, but I'm sure someone out there has it running with 512MB
440 2016-11-22T20:17:41  <Victorsueca> adiabat: just download more ram ;)
441 2016-11-22T20:18:33  <sipa> it's not cisco hardware
442 2016-11-22T20:18:55  <pigeons> ramdoubler.exe
443 2016-11-22T20:31:22  <Chris_Stewart_5> Is the serialization format described in BIP141 only used when calculating a wtxid, or is this serialization format also used when propogating a tx across the p2p network?
444 2016-11-22T20:31:24  <Chris_Stewart_5> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#transaction-id
445 2016-11-22T20:32:02  <sipa> Chris_Stewart_5: see bip144 for that
446 2016-11-22T20:32:55  <Chris_Stewart_5> ahhh that makes a lot more sense :-)
447 2016-11-22T20:37:52  *** aalex__ has joined #bitcoin-core-dev
448 2016-11-22T20:41:53  *** aalex_ has quit IRC
449 2016-11-22T20:42:22  *** laurentmt has joined #bitcoin-core-dev
450 2016-11-22T20:42:43  *** laurentmt has quit IRC
451 2016-11-22T20:48:31  <instagibbs> too-many-bips problem :P
452 2016-11-22T20:48:52  <instagibbs> is there a zmq/rest test suite?
453 2016-11-22T21:29:58  *** jannes has quit IRC
454 2016-11-22T21:38:51  <bitcoin-git> [bitcoin] btcdrak opened pull request #9206: Make test constant consistent with consensus.h (master...consistency) https://github.com/bitcoin/bitcoin/pull/9206
455 2016-11-22T21:45:15  *** laurentmt has joined #bitcoin-core-dev
456 2016-11-22T21:51:40  *** laurentmt has quit IRC
457 2016-11-22T22:00:35  *** CubicEarth has quit IRC
458 2016-11-22T22:03:59  *** CubicEarth has joined #bitcoin-core-dev
459 2016-11-22T22:06:38  <jtimon> updated https://github.com/bitcoin/bitcoin/pull/9177 's description
460 2016-11-22T22:15:16  <jtimon> also if anyone is bored, you can fetch #8994 , grep and remove 'self.chain = "regtest"' and you should have 4 tests failing, ie p2p-comapctblocks.py,  segwit.py,  mempool_packages.py (extended) and  pruning.py (extended)
461 2016-11-22T22:15:17  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
462 2016-11-22T22:17:38  <jtimon> also please review #8855 (takes +86 −81 out of review from #8994 's +360 −201 and #9177 's +866 −286)
463 2016-11-22T22:17:40  <gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
464 2016-11-22T22:17:42  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
465 2016-11-22T22:17:44  <gribble> https://github.com/bitcoin/bitcoin/issues/9177 | NOMERGE: WIP: Support block signed custom testchains by jtimon · Pull Request #9177 · bitcoin/bitcoin · GitHub
466 2016-11-22T22:18:36  <jtimon> plus I wouldn't need to rebase every time a new test uses Params(std::string)
467 2016-11-22T22:18:59  <jtimon> </review begging>
468 2016-11-22T22:20:50  <jtimon> final note (I believe #8994 could be merged as it is modulo squash)
469 2016-11-22T22:20:52  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
470 2016-11-22T22:25:58  *** Guyver2 has quit IRC
471 2016-11-22T22:31:08  *** protomar has quit IRC
472 2016-11-22T22:36:03  <luke-jr> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/8877#discussion_r89126900 <-- ?
473 2016-11-22T23:36:52  *** laurentmt has joined #bitcoin-core-dev
474 2016-11-22T23:37:13  *** laurentmt has quit IRC