1 2016-12-14T00:04:57  *** chris__ has joined #bitcoin-core-dev
  2 2016-12-14T00:13:16  *** alpalp has joined #bitcoin-core-dev
  3 2016-12-14T00:15:23  *** jtimon has quit IRC
  4 2016-12-14T00:18:54  *** wasi has quit IRC
  5 2016-12-14T00:24:29  *** wasi has joined #bitcoin-core-dev
  6 2016-12-14T01:04:11  *** AaronvanW has quit IRC
  7 2016-12-14T01:34:39  *** PRab has joined #bitcoin-core-dev
  8 2016-12-14T01:34:45  <gmaxwell> jonasschnelli: want to go comment on http://bitcoin.stackexchange.com/questions/50125/failing-to-build-bitcoin-core-v0-13-1-on-debian-stretch and point out its fixed in master?
  9 2016-12-14T01:36:37  *** brg444 has quit IRC
 10 2016-12-14T01:37:54  *** brg444 has joined #bitcoin-core-dev
 11 2016-12-14T01:51:43  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9344: Do not run functions with necessary side-effects in assert() (master...assert_no_sideeffects) https://github.com/bitcoin/bitcoin/pull/9344
 12 2016-12-14T01:53:05  <BlueMatt> again? :(
 13 2016-12-14T01:53:20  <gmaxwell> looks like we missed some.
 14 2016-12-14T01:54:04  <sipa> or 2.
 15 2016-12-14T01:54:20  <gmaxwell> or 4.
 16 2016-12-14T01:54:37  <BlueMatt> missed, or re-added?
 17 2016-12-14T01:54:53  <gmaxwell> the flush ones are from 2013, didn't check the others.
 18 2016-12-14T01:54:54  <gmaxwell> looking
 19 2016-12-14T01:56:45  <gmaxwell> BlueMatt: the other two you introduced in 9c837d54.
 20 2016-12-14T01:57:02  <gmaxwell> You have have the brownpaper bag when 2013-sipa is done with it.
 21 2016-12-14T01:57:15  <BlueMatt> lol, oops
 22 2016-12-14T01:57:22  *** Ylbam has quit IRC
 23 2016-12-14T01:58:14  *** Chris_Stewart_5 has quit IRC
 24 2016-12-14T01:59:12  *** abpa has quit IRC
 25 2016-12-14T02:13:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 26 2016-12-14T02:14:11  *** Alopex has quit IRC
 27 2016-12-14T02:15:16  *** Alopex has joined #bitcoin-core-dev
 28 2016-12-14T02:46:17  *** Giszmo has quit IRC
 29 2016-12-14T02:49:02  *** warren has joined #bitcoin-core-dev
 30 2016-12-14T02:49:59  *** adam3us has joined #bitcoin-core-dev
 31 2016-12-14T02:52:08  *** Chris_Stewart_5 has quit IRC
 32 2016-12-14T02:54:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 33 2016-12-14T03:07:29  *** PRab has quit IRC
 34 2016-12-14T03:27:03  *** abpa has joined #bitcoin-core-dev
 35 2016-12-14T03:27:58  *** NielsvG has quit IRC
 36 2016-12-14T03:44:54  *** Chris_Stewart_5 has quit IRC
 37 2016-12-14T03:47:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 38 2016-12-14T03:54:36  *** NielsvG has joined #bitcoin-core-dev
 39 2016-12-14T03:54:37  *** NielsvG has joined #bitcoin-core-dev
 40 2016-12-14T03:55:46  *** abpa has quit IRC
 41 2016-12-14T04:06:17  *** alpalp has quit IRC
 42 2016-12-14T04:08:33  * luke-jr wonders if it would be useful to have a prune-to-slow-storage mode.
 43 2016-12-14T04:15:11  <adam3us> djb has a database called cdb (used in djbdns) that guarantees key->value lookup in 2 disk hits.  cost is it is slow to update (batch job)
 44 2016-12-14T04:15:49  <luke-jr> I just mean for block data. Instead of deleting, move it to a USB drive or smth
 45 2016-12-14T04:15:59  <luke-jr> maybe even a location that can be offline when you don't need it
 46 2016-12-14T04:16:18  <luke-jr> so when you want to restore an old backup or whatever, you just plug it in
 47 2016-12-14T04:17:07  <adam3us> yes. i am talking about something only semi-related. that utxo access latency (with sig checking disabled) is increasing due to less spam creating lower cache hit rates, and larger utxo hitting disk more.
 48 2016-12-14T04:18:24  <adam3us> so then maybe a three tier strategy could be old stuff in cdb, more recent (eg last 2months?) in current disk layout, plus memory cache. once per month do the batch to move another 1month chunk to the cdb compact/efficient lookup format.
 49 2016-12-14T04:18:48  <adam3us> cdb has constant time lookup, where general lookup is log n.
 50 2016-12-14T04:34:19  *** wasi has quit IRC
 51 2016-12-14T04:35:46  *** GAit has quit IRC
 52 2016-12-14T04:35:55  *** chris2000 has joined #bitcoin-core-dev
 53 2016-12-14T04:36:37  <Lightsword> are there any known issues getting master to compile on the latest osx?
 54 2016-12-14T04:38:48  *** chris200_ has quit IRC
 55 2016-12-14T04:43:29  *** GAit has joined #bitcoin-core-dev
 56 2016-12-14T04:44:44  *** wasi has joined #bitcoin-core-dev
 57 2016-12-14T04:47:15  *** alpalp has joined #bitcoin-core-dev
 58 2016-12-14T04:47:15  *** alpalp has joined #bitcoin-core-dev
 59 2016-12-14T04:52:56  *** alpalp has quit IRC
 60 2016-12-14T04:53:53  *** kadoban has quit IRC
 61 2016-12-14T04:55:33  <Lightsword> nvm was protobuf version issue
 62 2016-12-14T05:08:28  <luke-jr> why is secp256k1.c +x now?
 63 2016-12-14T05:08:37  <luke-jr> main_impl.h also
 64 2016-12-14T05:52:45  *** justanotheruser has quit IRC
 65 2016-12-14T05:54:19  *** wasi has quit IRC
 66 2016-12-14T05:55:19  *** wasi has joined #bitcoin-core-dev
 67 2016-12-14T06:02:26  *** justanotheruser has joined #bitcoin-core-dev
 68 2016-12-14T06:11:00  *** arubi has joined #bitcoin-core-dev
 69 2016-12-14T06:27:11  *** Alopex has quit IRC
 70 2016-12-14T06:28:16  *** Alopex has joined #bitcoin-core-dev
 71 2016-12-14T06:38:07  <phantomcircuit> instagibbs, are wallet transactions loaded into the mempool on restart?
 72 2016-12-14T06:38:11  <phantomcircuit> i didn't think they were
 73 2016-12-14T06:38:25  <phantomcircuit> wouldn't that break #9262
 74 2016-12-14T06:38:27  <gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
 75 2016-12-14T06:38:46  <gmaxwell> phantomcircuit: yes, they are.
 76 2016-12-14T06:38:55  <phantomcircuit> gmaxwell, hmm
 77 2016-12-14T06:39:01  <gmaxwell> (assuming the mempool would take them).
 78 2016-12-14T06:39:03  <gmaxwell> they do you say it would break 9262?
 79 2016-12-14T06:39:08  <phantomcircuit> they're not rebroadcast though right?
 80 2016-12-14T06:39:19  <gmaxwell> they're rebroadcast if they get into the mempool.
 81 2016-12-14T06:39:28  <phantomcircuit> if they're not in the mempool then checking their ancestor depth will always fail of course
 82 2016-12-14T06:40:18  <gmaxwell> Yea, I see what you're saying-- they're put into the mempool. (and IIRC the wallet will not try to spend them if they're unconfirmed and not in the mempool)
 83 2016-12-14T06:40:44  <phantomcircuit> hmm
 84 2016-12-14T06:40:48  <gmaxwell> (but I could be wrong there and instead remembering the behavior it should have instead of does have... :) )
 85 2016-12-14T06:50:12  *** aalex has quit IRC
 86 2016-12-14T06:50:53  *** aalex has joined #bitcoin-core-dev
 87 2016-12-14T06:51:24  *** wasi has quit IRC
 88 2016-12-14T06:58:12  *** wasi has joined #bitcoin-core-dev
 89 2016-12-14T07:00:11  *** dermoth has quit IRC
 90 2016-12-14T07:01:07  *** dermoth has joined #bitcoin-core-dev
 91 2016-12-14T07:05:01  *** chris__ has quit IRC
 92 2016-12-14T07:11:14  *** paveljanik has quit IRC
 93 2016-12-14T07:20:51  *** paveljanik has joined #bitcoin-core-dev
 94 2016-12-14T07:33:02  *** Chris_Stewart_5 has quit IRC
 95 2016-12-14T07:53:21  *** BashCo has quit IRC
 96 2016-12-14T07:53:56  *** BashCo has joined #bitcoin-core-dev
 97 2016-12-14T07:58:21  *** BashCo has quit IRC
 98 2016-12-14T08:10:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 99 2016-12-14T08:20:39  *** paveljanik has quit IRC
100 2016-12-14T08:26:58  *** BashCo has joined #bitcoin-core-dev
101 2016-12-14T08:33:15  <bitcoin-git> [bitcoin] laanwj closed pull request #9264: 0.13.2 backports (0.13...2016_12_backports_0_13) https://github.com/bitcoin/bitcoin/pull/9264
102 2016-12-14T08:33:52  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26fe5c98ab6a...82ccac739e2a
103 2016-12-14T08:33:52  <bitcoin-git> bitcoin/master da9cdd2 Gregory Maxwell: Do not run functions with necessary side-effects in assert()
104 2016-12-14T08:33:53  <bitcoin-git> bitcoin/master 82ccac7 Wladimir J. van der Laan: Merge #9344: Do not run functions with necessary side-effects in assert()...
105 2016-12-14T08:34:07  <bitcoin-git> [bitcoin] sipa opened pull request #9346: Batch construct batches (master...reusebatch) https://github.com/bitcoin/bitcoin/pull/9346
106 2016-12-14T08:34:52  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/82ccac739e2a...47e6a19e6b57
107 2016-12-14T08:34:52  <bitcoin-git> bitcoin/master ed6b377 Jonas Schnelli: [Qt] Console: add security warning
108 2016-12-14T08:34:53  <bitcoin-git> bitcoin/master 47e6a19 Wladimir J. van der Laan: Merge #9330: [Qt] Console: add security warning...
109 2016-12-14T08:35:07  <bitcoin-git> [bitcoin] laanwj closed pull request #9330: [Qt] Console: add security warning (master...2016/12/qt_add_sec) https://github.com/bitcoin/bitcoin/pull/9330
110 2016-12-14T08:35:27  <bitcoin-git> [bitcoin] laanwj closed pull request #9323: [0.13] Add release notes for wallet/mempool rejections. (PR #9302 and #9290) (0.13...mempool_relnote) https://github.com/bitcoin/bitcoin/pull/9323
111 2016-12-14T09:00:11  <phantomcircuit> gmaxwell, that is indeed the behaviour it has
112 2016-12-14T09:18:43  <bitcoin-git> [bitcoin] laanwj closed pull request #9211: [0.12 branch] Backports (0.12...Mf1611-back12) https://github.com/bitcoin/bitcoin/pull/9211
113 2016-12-14T09:25:54  <wumpus> what's the status on #9037? "Add test-before-evict discipline to addrman" looks like it's finished for a while but hasn't got any review yet
114 2016-12-14T09:25:56  <gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub
115 2016-12-14T09:28:31  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47e6a19e6b57...57e337d40e94
116 2016-12-14T09:28:31  <bitcoin-git> bitcoin/master f692fce Gregory Maxwell: Make RelayWalletTransaction attempt to AcceptToMemoryPool....
117 2016-12-14T09:28:32  <bitcoin-git> bitcoin/master 57e337d Pieter Wuille: Merge #9290: Make RelayWalletTransaction attempt to AcceptToMemoryPool....
118 2016-12-14T09:28:45  <bitcoin-git> [bitcoin] sipa closed pull request #9290: Make RelayWalletTransaction attempt to AcceptToMemoryPool. (master...resend_retries_mempool) https://github.com/bitcoin/bitcoin/pull/9290
119 2016-12-14T09:30:56  <phantomcircuit> gmaxwell, iirc SelectMinCoins can be supppper expensive
120 2016-12-14T09:31:06  <phantomcircuit> er SelectCoinsMinConf
121 2016-12-14T09:31:41  <gmaxwell> phantomcircuit: it has linear cost in the number of spendable coins below the amount you're sending.
122 2016-12-14T09:32:15  <phantomcircuit> ok
123 2016-12-14T09:32:24  <phantomcircuit> was that fixed from something much worse in the past?
124 2016-12-14T09:32:54  <gmaxwell> wumpus: fell off my radar before I finished review; I will review later today (your time).
125 2016-12-14T09:33:21  <gmaxwell> phantomcircuit: it used to call the IsFromMe stuff that could be O(terrible).
126 2016-12-14T09:33:30  <sipa> morcos: so, initial report (see https://github.com/sipa/bitcoin/commits/pertxoutcache)... gmaxwell benchmarked it, and it seems to make normal operation somewhat faster, but the cache memory usage larger resulting in more frequent flushes, and the flushes themselves are maybe 3x slower
127 2016-12-14T09:33:49  <sipa> so for large dbcache it seems to be a win, while for low dbcache sizes it clearly is not
128 2016-12-14T09:38:38  *** cjamthagen has joined #bitcoin-core-dev
129 2016-12-14T09:38:51  <gmaxwell> basically for largeish dbcache it looked ~15% faster than master until the moment where it flushed, then it took 2.5x longer... the cache also used about 20% more memory, so 20% less cache in a given size... so flushing more often and the further it went the performance change tended to a large slowdown. :(   The cache using more memory is perhaps something of an illusion of an effect, since a m
130 2016-12-14T09:38:57  <gmaxwell> ajor motivator of the change was to eliminate the existance of modified entries in the cache, which would make a good replacement policy possible instead of dumbly dumping the whole thing.
131 2016-12-14T09:39:14  <gmaxwell> so if the issue were only the 20% reduction in cache size, that much could easily be recovered by smarter cache handling that it makes possible.
132 2016-12-14T09:39:25  <gmaxwell> The flushing slowdown though... :(
133 2016-12-14T09:50:15  <wumpus> bah :(
134 2016-12-14T09:57:19  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57e337d40e94...b68685a16a81
135 2016-12-14T09:57:19  <bitcoin-git> bitcoin/master a13fa4c Matt Corallo: Remove unused CDiskBlockPos* argument from ProcessNewBlock
136 2016-12-14T09:57:20  <bitcoin-git> bitcoin/master b68685a Wladimir J. van der Laan: Merge #9273: Remove unused CDiskBlockPos* argument from ProcessNewBlock...
137 2016-12-14T09:57:36  <bitcoin-git> [bitcoin] laanwj closed pull request #9273: Remove unused CDiskBlockPos* argument from ProcessNewBlock (master...2016-12-remove-unused-pnb-param) https://github.com/bitcoin/bitcoin/pull/9273
138 2016-12-14T09:59:06  *** MarcoFalke has joined #bitcoin-core-dev
139 2016-12-14T10:06:25  *** AaronvanW has joined #bitcoin-core-dev
140 2016-12-14T10:06:26  *** AaronvanW has quit IRC
141 2016-12-14T10:06:26  *** AaronvanW has joined #bitcoin-core-dev
142 2016-12-14T10:09:45  *** JackH has joined #bitcoin-core-dev
143 2016-12-14T10:13:44  *** Lauda has quit IRC
144 2016-12-14T10:15:39  *** timothy has quit IRC
145 2016-12-14T10:19:56  *** Lauda has joined #bitcoin-core-dev
146 2016-12-14T10:26:36  *** Lauda has quit IRC
147 2016-12-14T10:26:41  *** rubensayshi has joined #bitcoin-core-dev
148 2016-12-14T10:29:02  *** Lauda has joined #bitcoin-core-dev
149 2016-12-14T10:29:36  *** timothy has joined #bitcoin-core-dev
150 2016-12-14T10:34:19  *** Victorsueca has joined #bitcoin-core-dev
151 2016-12-14T10:35:05  *** Victorsueca has quit IRC
152 2016-12-14T10:35:29  *** Victorsueca has joined #bitcoin-core-dev
153 2016-12-14T11:46:20  *** [Author] has quit IRC
154 2016-12-14T11:55:41  *** [Author] has joined #bitcoin-core-dev
155 2016-12-14T12:04:36  *** jtimon has joined #bitcoin-core-dev
156 2016-12-14T12:04:36  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #9347: [0.13.2] wallet backports (0.13...Mf1612-013back) https://github.com/bitcoin/bitcoin/pull/9347
157 2016-12-14T12:12:36  <MarcoFalke> I assume #9262 is no longer for backport?
158 2016-12-14T12:12:39  <gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
159 2016-12-14T12:12:55  <MarcoFalke> We already return the txid and try to reaccept to the mempool
160 2016-12-14T12:13:10  <MarcoFalke> Also, the default of 9262 is off, and who changes defaults anyway?
161 2016-12-14T12:27:06  *** BashCo_ has joined #bitcoin-core-dev
162 2016-12-14T12:30:38  *** BashCo has quit IRC
163 2016-12-14T12:37:28  *** alpalp has joined #bitcoin-core-dev
164 2016-12-14T12:37:28  *** alpalp has joined #bitcoin-core-dev
165 2016-12-14T13:05:29  *** kadoban has joined #bitcoin-core-dev
166 2016-12-14T13:18:26  <instagibbs> MarcoFalke: only the rejecting of transactions us off by default
167 2016-12-14T13:18:46  <instagibbs> That said I don't think it's necessary for backport
168 2016-12-14T13:28:26  *** laurentmt has joined #bitcoin-core-dev
169 2016-12-14T13:28:40  *** laurentmt has quit IRC
170 2016-12-14T14:00:06  *** alpalp has quit IRC
171 2016-12-14T14:16:14  *** To7 has quit IRC
172 2016-12-14T14:22:38  *** MarcoFalke has left #bitcoin-core-dev
173 2016-12-14T14:27:39  *** BashCo_ has quit IRC
174 2016-12-14T14:28:53  *** BashCo has joined #bitcoin-core-dev
175 2016-12-14T14:29:20  *** Giszmo has joined #bitcoin-core-dev
176 2016-12-14T14:45:34  <morcos> I don't think we should discuss 9262 for backport until after its merged...  if it's too late then, it's too late.
177 2016-12-14T14:46:10  <morcos> if it works right, its a less disruptive change for backport...  but, we don't want to take chances on the "if"
178 2016-12-14T14:49:50  *** paveljanik has joined #bitcoin-core-dev
179 2016-12-14T14:51:41  *** TomMc has joined #bitcoin-core-dev
180 2016-12-14T14:59:20  *** gribble has quit IRC
181 2016-12-14T15:05:04  *** Giszmo has quit IRC
182 2016-12-14T15:06:27  *** Giszmo has joined #bitcoin-core-dev
183 2016-12-14T15:08:01  *** gribble has joined #bitcoin-core-dev
184 2016-12-14T15:10:41  *** Guyver2 has joined #bitcoin-core-dev
185 2016-12-14T15:25:28  *** laurentmt has joined #bitcoin-core-dev
186 2016-12-14T15:26:09  *** goregrin1 has joined #bitcoin-core-dev
187 2016-12-14T15:27:16  *** BashCo_ has joined #bitcoin-core-dev
188 2016-12-14T15:27:42  *** goregrind has quit IRC
189 2016-12-14T15:29:21  *** laurentmt has quit IRC
190 2016-12-14T15:29:57  *** gluytium_ has quit IRC
191 2016-12-14T15:30:22  *** BashCo has quit IRC
192 2016-12-14T15:46:55  *** rafalcpp has quit IRC
193 2016-12-14T16:10:41  *** rafalcpp has joined #bitcoin-core-dev
194 2016-12-14T16:30:29  *** wvr has quit IRC
195 2016-12-14T16:34:02  <morcos> sigh... wumpus: i think i messed up with #9240 we might want to revert it
196 2016-12-14T16:34:05  <gribble> https://github.com/bitcoin/bitcoin/issues/9240 | Remove txConflicted by morcos · Pull Request #9240 · bitcoin/bitcoin · GitHub
197 2016-12-14T16:34:42  <morcos> I didn't properly think through notifications that would no longer happen because SyncTransaction was no longer being called
198 2016-12-14T16:35:30  <sipa> where else do we need notifications for conflicts?
199 2016-12-14T16:36:04  <morcos> I think there are 3 things that won't happen  1)zmqnotifications (but we dont' do those for other things that leave the mempool, so maybe doesn't matter)
200 2016-12-14T16:36:28  <morcos> 2) UI notifications or whatever NotifyTransactionChanged does  (haven't dived into this yet, but I also think this doesn't matter)
201 2016-12-14T16:36:35  <morcos> 3) -walletnotify notifications
202 2016-12-14T16:37:00  <morcos> 3) is tricky, b/c it might make more sense to call those from MarkConflicted in the wallet except for the case of someone paying you
203 2016-12-14T16:37:14  <sipa> but what we need for all of those is not conflicts
204 2016-12-14T16:37:27  <sipa> maybe we need a class of "reorged" transactions
205 2016-12-14T16:37:32  <morcos> someone paying you is not something you would identify in wallet conflict code as now being conflicted, but something you might want to know about in walletnotify
206 2016-12-14T16:37:43  <morcos> whats the definition of that if not conflict
207 2016-12-14T16:38:11  <wumpus> morcos: well that can happen, at least it's not one of the backported ones :)
208 2016-12-14T16:38:28  <sipa> reorged is previously confirmed transactions that are now no longer confirmed
209 2016-12-14T16:38:40  <morcos> sipa: you still are notified on those
210 2016-12-14T16:38:44  <sipa> conflicted is previously unconfirmed transactions that are now inconsistent with the tip
211 2016-12-14T16:39:03  <morcos> this is just mempool transactions that are now conflicted  (actually nothing to do with a reorg, just a new block that conflicts with it)
212 2016-12-14T16:39:10  <morcos> yeah sorry
213 2016-12-14T16:39:27  <sipa> yes, i'm questioning whether we need that
214 2016-12-14T16:39:37  <sipa> their confirmation count is not changing
215 2016-12-14T16:40:45  <sipa> oh, maybe we need it for wiping a cached balance?
216 2016-12-14T16:41:02  <morcos> i think it might be nicer to just have -walletnotify for any wallet transactions that left the mempool...  then it might not be necessary to distinguish if you can mark it conflicted or not
217 2016-12-14T16:41:07  <morcos> but thats difficult
218 2016-12-14T16:42:37  <morcos> sipa: i don't think so...   it doesn't add to your credit if its not from you, and if it spends your money, then well...  i suppose it could be a mixed debit tx that you don't identify...  but imo thats in the class of things we could never fully get anyway
219 2016-12-14T16:42:57  <morcos> i think my thinking was just about our own wallet code, which i think is still ok...  its the external notifications i hadn't considered
220 2016-12-14T16:43:24  <sipa> i didn't even know we sent notifications for left-mempool
221 2016-12-14T16:43:37  <morcos> we don't we send them for SyncTransaction
222 2016-12-14T16:43:49  <sipa> ?
223 2016-12-14T16:43:54  <morcos> which we were calling for things that left the mempool via conflict
224 2016-12-14T16:44:12  <morcos> we send them from SyncTransaction for anything that is InvolvingMe
225 2016-12-14T16:44:33  <morcos> SyncTransaction -> AddToWalletIfInvolvingMe -> AddToWallet
226 2016-12-14T16:44:42  *** rafalcpp has quit IRC
227 2016-12-14T16:44:42  <morcos> AddToWallet calls -walletnotify
228 2016-12-14T16:45:24  *** rafalcpp has joined #bitcoin-core-dev
229 2016-12-14T16:45:39  *** rafalcpp has joined #bitcoin-core-dev
230 2016-12-14T16:47:11  *** abpa has joined #bitcoin-core-dev
231 2016-12-14T16:47:18  <morcos> I was saying if you had a generic way of calling SyncTransaction for everything that left the mempool (for reasons other than being included in a block which is already covered) then that might be the most logical thing...
232 2016-12-14T16:47:50  <morcos> And I don't think it would be all that important to distinguish the reason it left, at least our own wallet isn't smart about that.
233 2016-12-14T16:48:06  <morcos> But that is not easy to do I don't think.
234 2016-12-14T16:48:59  <sipa> hmm, we could have a callback installed in the mempool
235 2016-12-14T16:49:15  <morcos> So maybe its important to still call SyncTransaction for txConflicted (the mempool conflict detection i removed) just so we get the -walletnotify for payments to us that have now been double spent / replaced / conflicted, what have you
236 2016-12-14T16:50:24  <sipa> ok
237 2016-12-14T16:51:36  <morcos> believe me i don't like txConflicted..  but i'm worried about accidentally making a change that somebody might be relying on for zero-conf doublespend detection
238 2016-12-14T16:52:22  <sipa> so you'll revert 9240 entirely, or keep txConflicts but remove its use in wallet conflicts checking
239 2016-12-14T16:53:21  <morcos> sipa: i think thats the same thing.  it wasn't doing anything in wallet conflicts checking.  so reverting 9240 entirely will not affect our wallet.
240 2016-12-14T16:54:07  <morcos> i think we should either revert it, or decide that there is a not that complicated better solution.
241 2016-12-14T16:55:39  <sipa> i see
242 2016-12-14T16:56:09  <morcos> perhaps its worth spending an hour thinking about whether SyncTransaction called from mempool.remove is the right thing to do regardless.. if not.. then revert 9240, if so, then do that before 0.14.
243 2016-12-14T16:56:25  *** To7 has joined #bitcoin-core-dev
244 2016-12-14T16:56:30  <sdaftuar> i'd be hesitant to make changes without thinking through a clear API for how all these callbacks ought to work, and documenting that
245 2016-12-14T17:07:26  *** TomMc has quit IRC
246 2016-12-14T17:08:58  *** Ylbam has joined #bitcoin-core-dev
247 2016-12-14T17:19:38  *** TomMc has joined #bitcoin-core-dev
248 2016-12-14T17:31:19  *** TomMc has quit IRC
249 2016-12-14T17:40:06  *** atroxes has quit IRC
250 2016-12-14T17:40:50  *** atroxes has joined #bitcoin-core-dev
251 2016-12-14T17:47:44  *** TomMc has joined #bitcoin-core-dev
252 2016-12-14T17:48:10  *** BashCo_ has quit IRC
253 2016-12-14T17:48:45  *** BashCo has joined #bitcoin-core-dev
254 2016-12-14T17:51:56  *** laurentmt has joined #bitcoin-core-dev
255 2016-12-14T17:53:23  *** laurentmt has quit IRC
256 2016-12-14T17:53:33  *** BashCo has quit IRC
257 2016-12-14T17:55:16  *** TomMc has quit IRC
258 2016-12-14T17:57:07  *** TomMc has joined #bitcoin-core-dev
259 2016-12-14T18:16:23  <bitcoin-git> [bitcoin] sipa opened pull request #9349: Make CScript (and prevector) c++11 movable. (master...movescript) https://github.com/bitcoin/bitcoin/pull/9349
260 2016-12-14T18:23:51  *** BashCo has joined #bitcoin-core-dev
261 2016-12-14T18:36:20  <bitcoin-git> [bitcoin] Christewart opened pull request #9350: Adding label for amount inside of tx_valid/tx_invalid.json (master...master) https://github.com/bitcoin/bitcoin/pull/9350
262 2016-12-14T18:45:38  *** laurentmt has joined #bitcoin-core-dev
263 2016-12-14T18:45:38  *** laurentmt has quit IRC
264 2016-12-14T18:46:27  *** wvr has joined #bitcoin-core-dev
265 2016-12-14T18:56:52  <morcos> sipa: wumpus: It turned out to be quite easy to track all mempool removals and call SyncTransaction on them.  However there are some tricky issues around edge cases involving reorgs where you might call the Sync for its removal after the Sync for it entering a block.
266 2016-12-14T18:57:08  <morcos> I don't believe this actually causes any issues..  but it'll take some time to think through it carefully
267 2016-12-14T18:57:59  <morcos> It would be my preference to do that, and try to document this code better..  As I think calling SyncTransaction (and thus walletnotify) on things that leave the mempool makes sense
268 2016-12-14T18:58:16  <morcos> And I think reverting 9240 is a step backwards towards cleaning this stuff up
269 2016-12-14T18:58:42  <morcos> But it depends on how risk averse you are for leaving it in its current state for a little while.
270 2016-12-14T18:59:23  <morcos> To summarize, I think the only regression is that -walletnotify isn't fired on transactions that were in the mempool and then evicted due to a tx in a new block conflicting them
271 2016-12-14T18:59:34  <morcos> i've got to run for the day shortly..
272 2016-12-14T19:02:24  *** TomMc has quit IRC
273 2016-12-14T19:03:11  *** chris2000 has quit IRC
274 2016-12-14T19:05:48  *** chris2000 has joined #bitcoin-core-dev
275 2016-12-14T19:16:44  *** TomMc has joined #bitcoin-core-dev
276 2016-12-14T20:12:49  *** snowden69 has joined #bitcoin-core-dev
277 2016-12-14T20:35:02  *** snowden69 has quit IRC
278 2016-12-14T20:35:23  *** snowden69 has joined #bitcoin-core-dev
279 2016-12-14T21:08:47  *** Guyver2 has quit IRC
280 2016-12-14T21:14:55  *** wasi has quit IRC
281 2016-12-14T21:27:37  *** Chris_Stewart_5 has quit IRC
282 2016-12-14T21:30:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
283 2016-12-14T21:32:03  *** MarcoFalke has joined #bitcoin-core-dev
284 2016-12-14T21:33:40  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9351: Remove CWalletTx::fFromMe member. (master...pr/atw-fromme) https://github.com/bitcoin/bitcoin/pull/9351
285 2016-12-14T21:39:02  *** Chris_Stewart_5 has quit IRC
286 2016-12-14T21:41:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
287 2016-12-14T22:07:41  *** MarcoFalke has left #bitcoin-core-dev
288 2016-12-14T22:09:15  *** abpa has quit IRC
289 2016-12-14T22:12:05  <bitcoin-git> [bitcoin] sdaftuar opened pull request #9352: Attempt reconstruction from all compact block announcements (master...optimistic-cb-2) https://github.com/bitcoin/bitcoin/pull/9352
290 2016-12-14T22:16:22  *** abpa has joined #bitcoin-core-dev
291 2016-12-14T22:34:10  *** belcher has quit IRC
292 2016-12-14T22:46:31  *** belcher has joined #bitcoin-core-dev
293 2016-12-14T22:47:42  *** jasonv77 has quit IRC
294 2016-12-14T22:58:44  *** MarcoFalke has joined #bitcoin-core-dev
295 2016-12-14T23:05:47  *** TomMc has quit IRC
296 2016-12-14T23:28:02  *** d9b4bef9 has quit IRC
297 2016-12-14T23:35:12  *** TomMc has joined #bitcoin-core-dev
298 2016-12-14T23:42:06  *** MykelSIlver has quit IRC
299 2016-12-14T23:42:23  *** MykelSIlver has joined #bitcoin-core-dev