1 2016-12-31T00:20:22  <morcos> the reason this doesn't happen with 9375 alone is that peer 0 hasn't requested that peer 1 be a HB peer, so the reorg isn't announced via the fast mechanism, i'm guessing 9400 changed that, but haven't looked into the details
  2 2016-12-31T00:29:31  *** harrymm has quit IRC
  3 2016-12-31T00:30:37  *** harrymm has joined #bitcoin-core-dev
  4 2016-12-31T01:08:31  <gmaxwell> I wondered if that might also force us to cache more than one block.
  5 2016-12-31T01:09:31  <gmaxwell> e.g. what happens if we get a second block instantly after the first, since they're tied will we still advertise the second?
  6 2016-12-31T01:10:10  *** juscamarena has quit IRC
  7 2016-12-31T01:10:50  *** juscamarena has joined #bitcoin-core-dev
  8 2016-12-31T01:10:50  *** juscamarena_ has joined #bitcoin-core-dev
  9 2016-12-31T01:18:22  *** juscamarena_ has quit IRC
 10 2016-12-31T01:26:42  *** Elysus1 has quit IRC
 11 2016-12-31T01:31:17  *** AaronvanW has quit IRC
 12 2016-12-31T01:37:12  *** kadoban has joined #bitcoin-core-dev
 13 2016-12-31T02:34:27  *** juscamarena has quit IRC
 14 2016-12-31T02:56:16  *** Elysus has joined #bitcoin-core-dev
 15 2016-12-31T02:57:25  *** Ylbam has quit IRC
 16 2016-12-31T02:59:38  *** arowser has quit IRC
 17 2016-12-31T03:01:22  *** fengling has quit IRC
 18 2016-12-31T03:03:36  *** xiangfu has quit IRC
 19 2016-12-31T03:04:22  *** xiangfu has joined #bitcoin-core-dev
 20 2016-12-31T03:05:24  *** arowser has joined #bitcoin-core-dev
 21 2016-12-31T03:06:34  <morcos> gmaxwell: that sounds annoying.  seems like maybe we need to rework the signals a bit.  maybe make BlockChecked always called after ProcessNewBlock and we can hold a cache of all blocks from NewPowValidBlock until BlockChecked.
 22 2016-12-31T03:06:38  <morcos> also always cache the tip
 23 2016-12-31T03:07:14  *** fengling has joined #bitcoin-core-dev
 24 2016-12-31T03:07:33  <morcos> but then we have to figure out where the right place to call MaybeSetPeer.. is
 25 2016-12-31T03:08:30  <morcos> But there is already another minor problem with the way the signals work now, mapBlockSource is never cleared of blocks which don't have BlockChecked called on them
 26 2016-12-31T03:09:31  <morcos> and valid blocks that don't become your tip don't get that I don't think..  probably rare enough not to matter much now, but if we want to be have an alternate block request mechanism for SPV/hybrid whatever or something..
 27 2016-12-31T03:20:35  *** juscamarena has joined #bitcoin-core-dev
 28 2016-12-31T05:01:38  *** laurentmt has joined #bitcoin-core-dev
 29 2016-12-31T05:42:03  *** kadoban has quit IRC
 30 2016-12-31T05:56:06  *** Alopex has quit IRC
 31 2016-12-31T05:57:11  *** Alopex has joined #bitcoin-core-dev
 32 2016-12-31T06:01:17  *** cannon-c has joined #bitcoin-core-dev
 33 2016-12-31T06:11:54  *** Chris_Stewart_5 has quit IRC
 34 2016-12-31T06:13:25  *** TomMc has quit IRC
 35 2016-12-31T06:25:33  *** Raccoon has joined #bitcoin-core-dev
 36 2016-12-31T06:25:46  *** Raccoon has left #bitcoin-core-dev
 37 2016-12-31T07:20:54  *** justanotheruser has quit IRC
 38 2016-12-31T07:29:43  <cfields> sipa: if you're here, please refresh your browser. You're reviewing stale commits :)
 39 2016-12-31T07:31:40  <sipa> :(
 40 2016-12-31T07:31:49  <sipa> i was reviewing from the app
 41 2016-12-31T07:32:49  <cfields> sipa: sorry. no clue what the app sees. I split them up into much more reviewable chunks, i hope.
 42 2016-12-31T07:33:18  <sipa> i see it now
 43 2016-12-31T07:33:27  <sipa> i guess it just caches a bit more aggressively
 44 2016-12-31T07:33:32  <sipa> no worries
 45 2016-12-31T07:33:49  <sipa> that's also why the result ends up with commit comments
 46 2016-12-31T07:33:53  <sipa> rather than PR comments
 47 2016-12-31T07:34:32  <cfields> ah, that's annoying. I was just looking at the page and saw no comments on the pr. Checked my mail on my phone on a whim.
 48 2016-12-31T07:35:16  <cfields> no worries though, i'll watch for that now
 49 2016-12-31T07:36:50  *** justanotheruser has joined #bitcoin-core-dev
 50 2016-12-31T07:49:58  *** fengling has quit IRC
 51 2016-12-31T08:00:06  *** Alopex has quit IRC
 52 2016-12-31T08:01:11  *** Alopex has joined #bitcoin-core-dev
 53 2016-12-31T08:13:25  *** wumpus_ has quit IRC
 54 2016-12-31T08:15:30  *** wumpus has joined #bitcoin-core-dev
 55 2016-12-31T08:33:06  *** Alopex has quit IRC
 56 2016-12-31T08:34:11  *** Alopex has joined #bitcoin-core-dev
 57 2016-12-31T08:48:48  <sipa> cfields: i was surprised to see that 2*buffersize was still there, tbh
 58 2016-12-31T08:50:03  <cfields> sipa: i couldn't really imagine a scenario where it could be hit. I just imagined a response of "belt and suspenders"
 59 2016-12-31T08:50:10  <cfields> should've asked :)
 60 2016-12-31T08:50:29  <sipa> yeah, belt and suspenders indeed
 61 2016-12-31T08:51:01  <cfields> will nuke it though. I've certainly never seen it. And I've done enough stupid things in tests that would've prompted it.
 62 2016-12-31T08:51:03  <sipa> but if you want to keep it, don't just turn it into fPauseSend
 63 2016-12-31T08:52:02  *** fengling has joined #bitcoin-core-dev
 64 2016-12-31T08:52:42  <cfields> well, I think the checking now should be tight enough. But I'll add some tests. I think the corks could've been quite broken and gone unnotiiced.
 65 2016-12-31T08:54:12  <sipa> if you set max send size below the block size, you'll hit it automatically :)
 66 2016-12-31T08:57:10  <cfields> see 30ad8c069bcaf4ef8b6bf17498386bcb42e39fc3 :(
 67 2016-12-31T08:58:15  <cfields> s/send/recv/ though
 68 2016-12-31T08:59:09  <sipa> yeah, i saw
 69 2016-12-31T09:02:52  <cfields> headed to bed, thanks for having a look
 70 2016-12-31T09:02:57  <cfields> and happy new year!
 71 2016-12-31T09:03:17  <wumpus> happy new year!
 72 2016-12-31T09:03:31  <cfields> wumpus: !
 73 2016-12-31T09:06:29  <cannon-c> New year not for another day
 74 2016-12-31T09:06:35  <cannon-c> Happy New Years Eve!
 75 2016-12-31T09:07:18  <wumpus> yes, same here, it's still a few hours to go, just not sure I'm going to speak to cfields before that
 76 2016-12-31T09:08:55  <cannon-c> must be in Australia
 77 2016-12-31T09:12:11  *** cannon-c has left #bitcoin-core-dev
 78 2016-12-31T09:12:29  *** cannon-c has joined #bitcoin-core-dev
 79 2016-12-31T09:15:02  *** d9b4bef9 has quit IRC
 80 2016-12-31T09:16:07  *** d9b4bef9 has joined #bitcoin-core-dev
 81 2016-12-31T09:28:52  *** cannon-c is now known as cannon-c_AFK
 82 2016-12-31T09:30:56  *** Ylbam has joined #bitcoin-core-dev
 83 2016-12-31T10:09:39  *** cannon-c_AFK is now known as cannon-oc
 84 2016-12-31T10:09:46  *** cannon-oc is now known as cannon-c
 85 2016-12-31T10:21:17  *** AaronvanW has joined #bitcoin-core-dev
 86 2016-12-31T10:21:18  *** AaronvanW has joined #bitcoin-core-dev
 87 2016-12-31T13:02:04  *** Elysus has quit IRC
 88 2016-12-31T13:06:40  *** Elysus has joined #bitcoin-core-dev
 89 2016-12-31T13:09:15  *** Elysus1 has joined #bitcoin-core-dev
 90 2016-12-31T13:12:29  *** fengling has quit IRC
 91 2016-12-31T13:13:20  *** Elysus has quit IRC
 92 2016-12-31T13:16:53  *** Elysus1 has quit IRC
 93 2016-12-31T13:17:49  *** Elysus has joined #bitcoin-core-dev
 94 2016-12-31T13:19:35  *** Elysus1 has joined #bitcoin-core-dev
 95 2016-12-31T13:23:10  *** Elysus has quit IRC
 96 2016-12-31T13:26:53  *** Elysus has joined #bitcoin-core-dev
 97 2016-12-31T13:30:02  *** Elysus1 has quit IRC
 98 2016-12-31T13:40:14  *** arowser has quit IRC
 99 2016-12-31T13:42:32  *** arowser has joined #bitcoin-core-dev
100 2016-12-31T14:00:11  *** Guyver2 has joined #bitcoin-core-dev
101 2016-12-31T14:14:26  *** Alopex has quit IRC
102 2016-12-31T14:15:32  *** Alopex has joined #bitcoin-core-dev
103 2016-12-31T14:19:25  <BlueMatt> morcos: hey, sorry, not been around much...
104 2016-12-31T14:19:31  <BlueMatt> morcos: I'm looking at the stuff now
105 2016-12-31T14:54:53  *** Guyver2 has quit IRC
106 2016-12-31T15:15:49  *** Distructo has joined #bitcoin-core-dev
107 2016-12-31T15:16:30  *** fengling has joined #bitcoin-core-dev
108 2016-12-31T15:16:43  *** arubi has quit IRC
109 2016-12-31T15:18:57  *** arubi has joined #bitcoin-core-dev
110 2016-12-31T15:21:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
111 2016-12-31T15:22:46  *** Distructo has quit IRC
112 2016-12-31T15:28:14  *** Chris_Stewart_5 has quit IRC
113 2016-12-31T15:44:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
114 2016-12-31T16:09:19  *** Sosumi has joined #bitcoin-core-dev
115 2016-12-31T16:14:17  *** justanotheruser has quit IRC
116 2016-12-31T16:15:47  *** laurentmt has quit IRC
117 2016-12-31T16:27:23  *** Chris_Stewart_5 has quit IRC
118 2016-12-31T17:17:41  *** PRab has quit IRC
119 2016-12-31T17:27:17  *** Elysus1 has joined #bitcoin-core-dev
120 2016-12-31T17:30:38  *** Elysus has quit IRC
121 2016-12-31T17:49:51  *** TomMc has joined #bitcoin-core-dev
122 2016-12-31T17:53:29  *** kadoban has joined #bitcoin-core-dev
123 2016-12-31T18:06:08  <bitcoin-git> [bitcoin] isle2983 opened pull request #9450: Increment MIT licence copyright header year on files modified in 2016 (master...PR-increment-year) https://github.com/bitcoin/bitcoin/pull/9450
124 2016-12-31T18:09:51  <bitcoin-git> [bitcoin] robmcl4 opened pull request #9451: CScript: remove redundant bounds check (master...remove_extra_bounds_check) https://github.com/bitcoin/bitcoin/pull/9451
125 2016-12-31T18:21:50  *** Guyver2 has joined #bitcoin-core-dev
126 2016-12-31T18:40:11  *** TomMc has quit IRC
127 2016-12-31T18:41:30  <bitcoin-git> [bitcoin] isle2983 opened pull request #9452: Use TravisCI to enforce copyright header rules for source files (master...PR-travisci-copyright-enforce) https://github.com/bitcoin/bitcoin/pull/9452
128 2016-12-31T18:57:45  *** AaronvanW has quit IRC
129 2016-12-31T19:15:40  <btcdrak> Happy New Year everyone
130 2016-12-31T19:20:48  *** Cheeseo has joined #bitcoin-core-dev
131 2016-12-31T19:20:52  *** Cheeseo has joined #bitcoin-core-dev
132 2016-12-31T19:31:18  *** justanotheruser has joined #bitcoin-core-dev
133 2016-12-31T19:41:40  <instagibbs> yes happy new years, hoping for another year of successful releases
134 2016-12-31T19:44:04  *** fengling has quit IRC
135 2016-12-31T19:45:09  <paveljanik> Yay!
136 2016-12-31T19:48:01  *** Cheeseo has quit IRC
137 2016-12-31T19:48:51  <btcdrak> let's tag 0.13.2 for New Year!
138 2016-12-31T19:50:25  *** Cheeseo has joined #bitcoin-core-dev
139 2016-12-31T19:50:25  *** Cheeseo has joined #bitcoin-core-dev
140 2016-12-31T20:04:54  <bitcoin-git> [bitcoin] jsmith-dev opened pull request #9453: Copyright notice year 2017 increment. Happy New Year! (master...master) https://github.com/bitcoin/bitcoin/pull/9453
141 2016-12-31T20:06:41  *** Cheeseo has quit IRC
142 2016-12-31T20:12:05  *** fengling has joined #bitcoin-core-dev
143 2016-12-31T20:15:09  *** Cheeseo has joined #bitcoin-core-dev
144 2016-12-31T20:31:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
145 2016-12-31T20:34:00  *** MarcoFalke has joined #bitcoin-core-dev
146 2016-12-31T20:39:30  *** jcorgan has quit IRC
147 2016-12-31T20:44:08  *** jcorgan has joined #bitcoin-core-dev
148 2016-12-31T20:56:15  *** Cheeseo has quit IRC
149 2016-12-31T21:12:32  *** Cheeseo has joined #bitcoin-core-dev
150 2016-12-31T21:31:09  *** Elysus1 has quit IRC
151 2016-12-31T21:32:57  *** kanu_ has joined #bitcoin-core-dev
152 2016-12-31T22:03:52  *** Sosumi has quit IRC
153 2016-12-31T22:09:28  *** nickler has quit IRC
154 2016-12-31T22:16:48  *** nickler has joined #bitcoin-core-dev
155 2016-12-31T23:31:55  *** Guyver2 has quit IRC