1 2017-01-14T00:03:48  <midnightmagic> In src/core_write.cpp:ScriptToAsmStr() there is a check for an integer printout with 0 <= vch.size() <= 4 -- otherwise it prints out a hex string. But for decodescript 6900, (decoding to OP_VERIFY 0) the vch.size() I believe for the second byte is 0, rather than an actual 0x00, and so the decode works apparently by accident..? Am I missing something?
  2 2017-01-14T00:05:55  *** justanotheruser has joined #bitcoin-core-dev
  3 2017-01-14T00:06:29  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3908fc472805...e126d0c12ca6
  4 2017-01-14T00:06:30  <bitcoin-git> bitcoin/master 997a98a Gregory Maxwell: Replace FindLatestBefore used by importmuti with FindEarliestAtLeast....
  5 2017-01-14T00:06:30  <bitcoin-git> bitcoin/master 4b06e41 Suhas Daftuar: Add unit test for FindEarliestAtLeast
  6 2017-01-14T00:06:31  <bitcoin-git> bitcoin/master e126d0c Pieter Wuille: Merge #9490: Replace FindLatestBefore used by importmuti with FindEarliestAtLeast....
  7 2017-01-14T00:06:42  <bitcoin-git> [bitcoin] sipa closed pull request #9490: Replace FindLatestBefore used by importmuti with FindEarliestAtLeast. (master...fix_find_latest_before) https://github.com/bitcoin/bitcoin/pull/9490
  8 2017-01-14T00:11:49  *** brg444 has joined #bitcoin-core-dev
  9 2017-01-14T00:21:03  *** xinxi has joined #bitcoin-core-dev
 10 2017-01-14T00:23:11  *** bsm117532 has joined #bitcoin-core-dev
 11 2017-01-14T00:25:19  *** xinxi has quit IRC
 12 2017-01-14T00:29:17  <cfields> sipa: good idea. I'm not exactly sure how to execute it though. I'd rather not trip up someone's manual efforts to enable sanitizers. Maybe add a --enable-sanitizers config option, off by default, that tries to turn on as many non-conflicting ones as possible?
 13 2017-01-14T00:29:42  <cfields> BlueMatt: woohoo! congrats on merge.
 14 2017-01-14T00:31:10  <sipa> cfields: we may need 2 or 3 separate builds with sanitizers, unfortunately
 15 2017-01-14T00:32:18  <sipa> cfields: but yes, optional sounds right
 16 2017-01-14T00:32:18  <cfields> sipa: right. Maybe there's no realistic way to add to configure, then? We can just handle with cflags for travis/gitian :(
 17 2017-01-14T00:32:34  *** brg444 has quit IRC
 18 2017-01-14T00:32:41  <sipa> you wouldn't want to enable sanitizers on production binaries, obviously
 19 2017-01-14T00:33:06  <cfields> right, it'd build both sets
 20 2017-01-14T00:33:42  <cfields> I suppose just doing it for travis would be a start
 21 2017-01-14T00:34:09  <cfields> we already have a slow, minimal build with debug cranked up for libstdc++.
 22 2017-01-14T00:36:39  <sipa> the sets you can do are 1) -fsanitize=address -fsanitize=undefined -fno-omit-frame-pointer 2) -fsanitize=thread 3) -fsanitize=memory (clang only, and requires rebuild of all dependencies)
 23 2017-01-14T00:36:56  <sipa> i've only played around with the first for now
 24 2017-01-14T00:38:59  <cfields> is no-omit-frame-pointer needed for correctness? or just helpful backtraces?
 25 2017-01-14T00:39:18  <sipa> i am not sure
 26 2017-01-14T00:39:38  <cfields> that one might be tricky since it's enabled at -O2, iirc. Not sure what "-fno-omit-frame-pointer -O2" turns into
 27 2017-01-14T00:39:42  <cfields> ok
 28 2017-01-14T00:40:35  <sipa> i think individual -f things override the -O defaults
 29 2017-01-14T00:41:13  <cfields> i would hope so. My fear is that it's order-based, like warnings.
 30 2017-01-14T00:41:20  <sipa> ah
 31 2017-01-14T00:41:24  <sipa> seems likely
 32 2017-01-14T00:42:07  <cfields> if so, that'd be tricky, since -Ox sneak in all over the place.
 33 2017-01-14T00:42:10  <cfields> will mess around with 'em
 34 2017-01-14T00:45:32  *** juscamarena has quit IRC
 35 2017-01-14T00:45:51  *** juscamarena has joined #bitcoin-core-dev
 36 2017-01-14T00:47:20  *** abpa has quit IRC
 37 2017-01-14T00:47:21  *** brg444 has joined #bitcoin-core-dev
 38 2017-01-14T00:47:28  *** Ylbam has quit IRC
 39 2017-01-14T00:59:07  <BlueMatt> cfields: yea, feels good to get a few things in for 0.14....do feel bad that I havent done enough review this week and am holding up things like bumpfee :'(
 40 2017-01-14T00:59:19  <BlueMatt> will at least finish this review before going out :/
 41 2017-01-14T00:59:33  * BlueMatt hopes ryanofsky has time to spare this weekend
 42 2017-01-14T01:00:44  <cfields> heh. it'd be a rookie move to make plans the weekend before freeze/release :)
 43 2017-01-14T01:00:59  <BlueMatt> well he is a rookie, after all :p
 44 2017-01-14T01:01:07  <sipa> like 'participating in the mit mystery hunt'
 45 2017-01-14T01:01:12  <BlueMatt> (at least in bitcoin)
 46 2017-01-14T01:01:21  <sipa> or 'agreeing to review workshop papers with deadline the 15th' ?
 47 2017-01-14T01:01:21  <BlueMatt> heh, yea, what were you and gmaxwell thinking, sipa????
 48 2017-01-14T01:01:23  <BlueMatt> :P
 49 2017-01-14T01:01:23  <cfields> sipa: ahah, that's this weekend?
 50 2017-01-14T01:01:54  <sipa> i'll be so happy when i get back to california on tuesday
 51 2017-01-14T01:02:13  <sipa> all this vacation thing is too stressful
 52 2017-01-14T01:02:55  <cfields> heh
 53 2017-01-14T01:04:41  <cfields> jeremyrubin: are you still pushing for your checkqueue rewrite? I'm rebasing the interruptible threads, and just remembered how terribly inefficient that is. There are some easy gains for sure. But I won't mess with it if it's being nuked anyway.
 54 2017-01-14T01:07:07  <gmaxwell> cfields: we should be careful with '--enable' because there are users that run ./configure and then turn on every enable.
 55 2017-01-14T01:08:24  <luke-jr> sipa: note that -fsanitize=memory also has weird LLVM/kernel matching issues, and is basically impossible on Travis currently (I used to use it)
 56 2017-01-14T01:08:49  <cfields> gmaxwell: well --enable-debug would already be hurting them pretty badly :)
 57 2017-01-14T01:08:50  <sipa> luke-jr: ah, good to know
 58 2017-01-14T01:09:40  <gmaxwell> cfields: yea agreed we should probably fix that -- though at least that one says 'debug'.
 59 2017-01-14T01:09:40  <luke-jr> sipa: cfields: also, we absolutely should NOT use -fsanitize=x with prod binaries. they are not intended for that, and add exploits
 60 2017-01-14T01:09:49  <sipa> luke-jr: absolutely!
 61 2017-01-14T01:10:03  <bitcoin-git> [bitcoin] practicalswift opened pull request #9549: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...) (master...avoid-potential-null-pointer-dereference-in-markblockasinflight) https://github.com/bitcoin/bitcoin/pull/9549
 62 2017-01-14T01:10:04  <gmaxwell> maybe making them -dev-debug -dev-sanatize-foo etc would be sufficient.
 63 2017-01-14T01:10:48  <gmaxwell> can someone tell him that if he thinks he actually has a possible null reref in code like that he should send it privately?
 64 2017-01-14T01:11:12  <gmaxwell> oh the description is okay
 65 2017-01-14T01:11:27  <gmaxwell> (ignore me)
 66 2017-01-14T01:11:37  <sipa> ideally i think those sanitize things should build separate binaries (bitcoind_san_X, test_bitcoin_san_X, ...)
 67 2017-01-14T01:11:52  <sipa> if that's at all possible
 68 2017-01-14T01:12:06  <sipa> maybe it's easier with a wrapper script around configure/make rather than inside the system
 69 2017-01-14T01:12:09  <luke-jr> is there a reason to special-case it at all? what's wrong with just passing CXXFLAGS?
 70 2017-01-14T01:12:35  <cfields> luke-jr: read the discussion above :)
 71 2017-01-14T01:12:47  <sipa> ideally, make check etc... build the multiple configurations and run all tests on all
 72 2017-01-14T01:13:02  <gmaxwell> As another side, we use the oneliners in our release notes but often our choice of them is really poor for this purpose.  Case in point ^ sounds like a serious crasher or even exploitable.
 73 2017-01-14T01:13:09  <luke-jr> cfields: I did skim it, but didn't see a rationale
 74 2017-01-14T01:15:00  <sipa> luke-jr: if we do it as a wrapper around (and just re-run configure and test for each of the sanitizers), it will just be passing CXXFLAGS/LDFLAGS
 75 2017-01-14T01:15:13  <cfields> luke-jr: i was kinda thinking same as you. Not sure it makes sense to handle in the build-system. as sipa said, maybe a wrapper makes more sense
 76 2017-01-14T01:15:22  <sipa> luke-jr: but it would be nice if it was completely integrated, so that the multiple tests/builds can run in parallel just from make, for exampe
 77 2017-01-14T01:15:53  <luke-jr> oh, for make check basically?
 78 2017-01-14T01:15:57  <sipa> right
 79 2017-01-14T01:16:09  <sipa> but make check should also run pull-tester/rpc-tests.py then
 80 2017-01-14T01:16:31  <sipa> i guess we can just start by doing it as a wrapper over the build system
 81 2017-01-14T01:17:24  <luke-jr> making make check run rpc tests shouldn't be hard, unlike sanitizers :P
 82 2017-01-14T01:19:53  *** moli_ has quit IRC
 83 2017-01-14T01:20:20  *** moli_ has joined #bitcoin-core-dev
 84 2017-01-14T01:21:11  <cfields> sipa: hmm, how do they interact with lto? it'd be nice if some of them could be enabled at link-time
 85 2017-01-14T01:22:20  *** xinxi has joined #bitcoin-core-dev
 86 2017-01-14T01:22:24  <sipa> cfields: they play well with lto, but you need to pass them both at compile and at link time, i think
 87 2017-01-14T01:22:42  <midnightmagic> Is a verbose transaction decode available through the rpc block decode interfaces..?
 88 2017-01-14T01:23:05  <sipa> decoderawtransaction?
 89 2017-01-14T01:24:10  <midnightmagic> sipa: The function interface has a txDetails bool which defaults to false but .. I don't know where it can be called with true through the rpc. Only the REST interface I think..?
 90 2017-01-14T01:24:27  <midnightmagic> blockToJSON() I mean.
 91 2017-01-14T01:24:52  <achow101> midnightmagic: you mean with something like getblock?
 92 2017-01-14T01:24:56  <midnightmagic> Yeah.
 93 2017-01-14T01:25:05  <achow101> no. but I have an open pr for that
 94 2017-01-14T01:25:32  <midnightmagic> ah, nice. \o thanks. I'll look for your PR then instead of doing my own.
 95 2017-01-14T01:26:23  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9550: Trim down the XP notice and say more about what we support. (master...we_got_it_already) https://github.com/bitcoin/bitcoin/pull/9550
 96 2017-01-14T01:26:58  <achow101> midnightmagic: #8704
 97 2017-01-14T01:27:00  <gribble> https://github.com/bitcoin/bitcoin/issues/8704 | [RPC] Transaction details in getblock by achow101 · Pull Request #8704 · bitcoin/bitcoin · GitHub
 98 2017-01-14T01:27:09  *** xinxi has quit IRC
 99 2017-01-14T01:28:09  <midnightmagic> excellent.
100 2017-01-14T01:29:44  <sipa> </mrburns>
101 2017-01-14T01:30:20  <gmaxwell> luke-jr: I really wish make check ran the rpc tests though the rpc tests have more dependencies than the oridnary builds.
102 2017-01-14T01:30:31  <gmaxwell> But I think we need to, because increasingly the useful tests are in rpctests.
103 2017-01-14T01:30:46  <gmaxwell> I think current make check has a poor ratio of excution time to sensitivity.
104 2017-01-14T02:06:37  <BlueMatt> morcos: getbalance("*", 1, True) is defined as a synonym of getbalance(), but bumpfee breaks that
105 2017-01-14T02:06:53  <BlueMatt> (note that I think bumpfee also breaks some account balance shit, but I didnt bother to audit that - do we care?)
106 2017-01-14T02:08:30  <BlueMatt> morcos / sdaftuar / ryanofsky: please add the following test-case https://0bin.net/paste/m91nHUQbD39EXaQ6#9fJ3bvAfAib5xWWwVdh3Ck0v7jQht1r8iDMQKQDpfTC
107 2017-01-14T02:08:32  <gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub
108 2017-01-14T02:08:37  <BlueMatt> no gribble
109 2017-01-14T02:10:27  <BlueMatt> (it currently fails on the last line of the test)
110 2017-01-14T02:10:45  <BlueMatt> note that if you move that test to be the last one run you'll get fun results - getbalance("*", 1, True) is negative!
111 2017-01-14T02:16:03  *** xinxi has joined #bitcoin-core-dev
112 2017-01-14T02:19:26  <instagibbs> BlueMatt, https://github.com/bitcoin/bitcoin/issues/8183 Perhaps still the case
113 2017-01-14T02:19:36  <instagibbs> they haven't been the same in a number of cases already :(
114 2017-01-14T02:20:16  <BlueMatt> hum, ok, that seems shit
115 2017-01-14T02:21:01  <BlueMatt> can we tag #8183 for 0.14, then, that is insane
116 2017-01-14T02:21:02  <gribble> https://github.com/bitcoin/bitcoin/issues/8183 | getbalance comment incorrect · Issue #8183 · bitcoin/bitcoin · GitHub
117 2017-01-14T02:21:08  <morcos> BlueMatt: I had assumed there might be an issue like that after you brought up your GUI question, and it was on my list to look into...
118 2017-01-14T02:21:08  <BlueMatt> we either need to fix it or fix the docs in getbalance
119 2017-01-14T02:21:21  <BlueMatt> they significantly imply that if you specify "*" as account you'll get sane results
120 2017-01-14T02:21:25  <morcos> i guess in my head i sometimes confuse getbalance "*" with something that has to do with accounts
121 2017-01-14T02:21:33  <morcos> but quite honestly getbalance "*" is a shit show
122 2017-01-14T02:21:37  <morcos> why do we even need it
123 2017-01-14T02:21:39  *** xinxi has quit IRC
124 2017-01-14T02:21:40  <instagibbs> yeah it's really bad
125 2017-01-14T02:21:40  <instagibbs> :)
126 2017-01-14T02:21:47  <instagibbs> i mean :(
127 2017-01-14T02:21:47  <morcos> i would suggest it should be deprecated with accounts
128 2017-01-14T02:21:48  <BlueMatt> getbalance "*" should throw an exception as "FUCK YOU, WE DEPRECATED THIS FOREVER AGO"
129 2017-01-14T02:21:57  <BlueMatt> it is marked deprecated the way i read the docs
130 2017-01-14T02:22:30  <BlueMatt> the fact that it returns insanity is gonna confuse someone, and it has been deprecated, so it should throw an exception as its known-unsafe and we likely wont fix it
131 2017-01-14T02:22:58  <morcos> From #9167 : "Note that the fee reported in the details and any other function which depends on ListTransactions is not changed as getbalance("*") depends on having incorrect negative fees calculated on mixed debit transactions in order to track the right balances."
132 2017-01-14T02:23:00  <gribble> https://github.com/bitcoin/bitcoin/issues/9167 | IsAllFromMe by morcos · Pull Request #9167 · bitcoin/bitcoin · GitHub
133 2017-01-14T02:23:40  <BlueMatt> I mean it may be deprecated, but that doesnt mean it gets to return insanity
134 2017-01-14T02:23:45  <BlueMatt> if its gonna return insanity, it needs to die
135 2017-01-14T02:25:36  <morcos> anyway got to go
136 2017-01-14T02:26:54  *** brg444 has quit IRC
137 2017-01-14T02:28:36  *** brg444 has joined #bitcoin-core-dev
138 2017-01-14T02:28:52  <BlueMatt> when you have to google C++ operator precedence in the process of review, something has gone horribly wrong :'(
139 2017-01-14T02:43:27  *** brg444 has quit IRC
140 2017-01-14T02:43:27  *** abpa has joined #bitcoin-core-dev
141 2017-01-14T02:44:47  <gmaxwell> BlueMatt: time to study operator precidence more! :)
142 2017-01-14T02:47:29  *** laurentmt has joined #bitcoin-core-dev
143 2017-01-14T02:48:11  *** xinxi has joined #bitcoin-core-dev
144 2017-01-14T02:50:14  <BlueMatt> clearly
145 2017-01-14T02:50:38  *** fanquake has joined #bitcoin-core-dev
146 2017-01-14T02:51:34  *** laurentmt has quit IRC
147 2017-01-14T02:57:23  *** xinxi has quit IRC
148 2017-01-14T03:02:32  *** xinxi has joined #bitcoin-core-dev
149 2017-01-14T03:03:21  *** veleiro has joined #bitcoin-core-dev
150 2017-01-14T03:07:20  *** AaronvanW has quit IRC
151 2017-01-14T03:12:46  *** xinxi has quit IRC
152 2017-01-14T03:14:08  <fanquake> cfields Made the required changes in 9469, and pulled in your commits. Any chance while your looking at Qt stuff, you can take a look at #9126. Have you seen that issue at all?
153 2017-01-14T03:14:09  <gribble> https://github.com/bitcoin/bitcoin/issues/9126 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
154 2017-01-14T03:17:56  *** xinxi has joined #bitcoin-core-dev
155 2017-01-14T03:18:15  *** brg444 has joined #bitcoin-core-dev
156 2017-01-14T03:29:07  *** btcdrak has quit IRC
157 2017-01-14T03:30:14  *** Chris_Stewart_5 has quit IRC
158 2017-01-14T03:42:40  <BlueMatt> I think #9484 is ready for merge
159 2017-01-14T03:42:42  <gribble> https://github.com/bitcoin/bitcoin/issues/9484 | Introduce assumevalid setting to skip validation presumed valid scripts. by gmaxwell · Pull Request #9484 · bitcoin/bitcoin · GitHub
160 2017-01-14T03:42:49  <BlueMatt> (just thought I'd mention it so it doesnt slip 0.14)
161 2017-01-14T03:44:35  <BlueMatt> gmaxwell: you were saying you'd be super dissapointed if some of the net fixes didnt make 0.14...well there is one bunch left from your pr that is at risk - #9535
162 2017-01-14T03:44:37  <gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub
163 2017-01-14T03:45:09  * BlueMatt does solomly swear all helgrind issues will be thoroughly debugged prior to release :p
164 2017-01-14T03:45:22  <BlueMatt> 9535 wont add any, but I know of a few still left
165 2017-01-14T03:47:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
166 2017-01-14T04:01:57  * sipa tests 9535 with -fsanitize=thread
167 2017-01-14T04:03:48  <BlueMatt> sipa: thar be dragons
168 2017-01-14T04:03:52  <BlueMatt> (not cause by 9535)
169 2017-01-14T04:04:02  <BlueMatt> d
170 2017-01-14T04:04:08  <sipa> yes, i expect it to fail (on master)
171 2017-01-14T04:04:09  <BlueMatt> can I buy a "d"?
172 2017-01-14T04:04:17  <BlueMatt> I can give you a list of places it will fail :p
173 2017-01-14T04:05:01  <BlueMatt> alright folks, I'm all reviewed-out...and likely wont have time tomorrow. apologize for those I didnt get to, but will try again on sunday
174 2017-01-14T04:05:45  <sipa> thanks!
175 2017-01-14T04:08:57  <sipa> ok, bitcoin-cli fails with -fsanitize=thread... i think there is some build config failure
176 2017-01-14T04:10:54  *** windsok has quit IRC
177 2017-01-14T04:16:43  *** chris200_ has joined #bitcoin-core-dev
178 2017-01-14T04:18:51  *** chris2000 has quit IRC
179 2017-01-14T04:20:39  *** Chris_Stewart_5 has quit IRC
180 2017-01-14T04:25:10  *** windsok has joined #bitcoin-core-dev
181 2017-01-14T04:28:25  <bitcoin-git> [bitcoin] 2HCHO opened pull request #9551: disable out of sync warnings for regtest network (master...ca4b90519c3c210f) https://github.com/bitcoin/bitcoin/pull/9551
182 2017-01-14T04:34:23  *** xinxi has quit IRC
183 2017-01-14T04:41:04  *** xinxi has joined #bitcoin-core-dev
184 2017-01-14T04:58:28  *** brg444 has quit IRC
185 2017-01-14T04:59:02  *** Alopex has quit IRC
186 2017-01-14T04:59:27  <cfields> sipa: yes, i'd expect that to be a bloodbath if it works. But there should be no new issues, i think
187 2017-01-14T04:59:51  <cfields> sipa: specifically, anything that uses CNodeStats is very racy.
188 2017-01-14T05:00:07  *** Alopex has joined #bitcoin-core-dev
189 2017-01-14T05:02:03  *** brg444 has joined #bitcoin-core-dev
190 2017-01-14T05:19:10  <sipa> cfields: i think it inteferes with some fortify/aslr/... we're using
191 2017-01-14T05:19:17  <sipa> bitcoin-cli has no threads
192 2017-01-14T05:29:33  <cfields> sipa: oh, yes, for sure
193 2017-01-14T05:29:55  <cfields> i read somewhere that FORTIFY is incompatible with some, sec for link
194 2017-01-14T05:30:34  <sipa> in fact, the compiler detector fails with -fsanitize=thread ("C++ compiler cannot produce binaries")
195 2017-01-14T05:31:15  <cfields> sipa: https://www.sourceware.org/ml/libc-alpha/2016-09/msg00080.html
196 2017-01-14T05:31:56  <cfields> comes from here: https://github.com/google/sanitizers/wiki/AddressSanitizer
197 2017-01-14T05:35:10  <cfields> fanquake: will have a look at 9126
198 2017-01-14T05:36:57  <cfields> (at some point this weekend)
199 2017-01-14T05:37:22  <fanquake> cfields cheers. Interesting build error on just the osx build of 9469. "Qt requires a C++11 compiler and yours does not seem to be that."
200 2017-01-14T05:38:44  <fanquake> Thought I might have messed up passing -c++std c++11. But that looks ok. https://travis-ci.org/bitcoin/bitcoin/jobs/191837557#L895
201 2017-01-14T05:41:59  <sipa> -std=c++11 ?
202 2017-01-14T05:51:28  *** btcdrak has joined #bitcoin-core-dev
203 2017-01-14T05:55:13  <cfields> fanquake: hmm, strange. it built fine for me locally
204 2017-01-14T05:55:38  *** xinxi has quit IRC
205 2017-01-14T05:55:38  <fanquake> cfields yes me too.
206 2017-01-14T05:56:19  <cfields> fanquake: ah, it's the damn .mm again
207 2017-01-14T05:57:24  <cfields> fanquake: i noticed something at one point and suspected that might happen
208 2017-01-14T05:57:31  <cfields> trying to remember
209 2017-01-14T05:59:17  <cfields> ah, right
210 2017-01-14T05:59:33  <cfields> fanquake: https://github.com/bitcoin/bitcoin/blob/master/depends/config.site.in#L66
211 2017-01-14T05:59:48  <cfields> mind nuking that line and giving it a try?
212 2017-01-14T06:01:31  <fanquake> cfields Have pushed that change up to GH.
213 2017-01-14T06:01:39  <fanquake> Will start a new build here also.
214 2017-01-14T06:01:47  *** xinxi has joined #bitcoin-core-dev
215 2017-01-14T06:02:38  <cfields> thanks
216 2017-01-14T06:04:02  <fanquake> Just realised I forgot you had two commits on top of mine, so that change is now part of your translations build commit.
217 2017-01-14T06:04:08  <cfields> fanquake: for the reasoning, see https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L62
218 2017-01-14T06:04:16  <fanquake> Can fixup later if the builds passed. Otherwise np.
219 2017-01-14T06:05:32  <cfields> fanquake: np. Though if this fixes, we probably want to commit it as a one-liner. It's a good backport candidate.
220 2017-01-14T06:06:26  <fanquake> cfields good point. Will split it out post builds passing.
221 2017-01-14T06:08:45  <cfields> fanquake: only reason i mention is that i had a theory at one point that it was the cause of the 10.7 back-compat breakage. Since it's responsible for intoducing c++03 abi objects into the 0.13 build.
222 2017-01-14T06:11:26  <fanquake> cfields ok. Just made note of it in a comment in that PR.
223 2017-01-14T06:11:36  *** xinxi has quit IRC
224 2017-01-14T06:14:49  <cfields> fanquake: thanks :)
225 2017-01-14T06:15:24  <fanquake> cfields I'll stop pestering now, you can go and enjoy the rest of your saturday heh
226 2017-01-14T06:17:26  *** xinxi has joined #bitcoin-core-dev
227 2017-01-14T06:18:02  <cfields> fanquake: heh, np. i meant to test that a long time ago, glad it came up either way
228 2017-01-14T06:18:31  <cfields> besides, this is what i enjoy :)
229 2017-01-14T06:19:53  <cfields> woohoo, success
230 2017-01-14T06:21:36  <fanquake> Awesome. I'll fixup that commit then.
231 2017-01-14T06:22:55  <cfields> great, thanks again!
232 2017-01-14T07:00:06  *** dermoth has quit IRC
233 2017-01-14T07:00:48  *** dermoth has joined #bitcoin-core-dev
234 2017-01-14T07:08:21  *** xinxi has quit IRC
235 2017-01-14T07:21:57  *** xinxi has joined #bitcoin-core-dev
236 2017-01-14T07:44:07  *** fanquake has quit IRC
237 2017-01-14T08:02:11  *** Alopex has quit IRC
238 2017-01-14T08:03:16  *** Alopex has joined #bitcoin-core-dev
239 2017-01-14T08:03:19  *** veleiro has quit IRC
240 2017-01-14T08:08:58  *** chjj has quit IRC
241 2017-01-14T08:10:21  *** chjj has joined #bitcoin-core-dev
242 2017-01-14T08:11:21  *** Ylbam has joined #bitcoin-core-dev
243 2017-01-14T08:38:47  *** jtimon has joined #bitcoin-core-dev
244 2017-01-14T08:53:40  *** jtimon has quit IRC
245 2017-01-14T09:17:34  <bitcoin-git> [bitcoin] jamesmacwhite opened pull request #9552: Add IPv6 support to qos.sh (master...qos-ipv6) https://github.com/bitcoin/bitcoin/pull/9552
246 2017-01-14T09:27:30  *** xinxi has quit IRC
247 2017-01-14T09:32:34  *** MarcoFalke has joined #bitcoin-core-dev
248 2017-01-14T09:32:50  *** xinxi has joined #bitcoin-core-dev
249 2017-01-14T09:35:32  *** [Author] has joined #bitcoin-core-dev
250 2017-01-14T09:41:12  *** jerryco has joined #bitcoin-core-dev
251 2017-01-14T09:41:19  <jerryco> hello
252 2017-01-14T09:41:46  <jerryco> how to install bitcoin-core centos ?
253 2017-01-14T09:43:57  <bitcoin-git> [bitcoin] practicalswift opened pull request #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; (master...std-max) https://github.com/bitcoin/bitcoin/pull/9553
254 2017-01-14T09:52:27  <MarcoFalke> jerryco: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions-fedora
255 2017-01-14T09:55:51  *** jerryco has quit IRC
256 2017-01-14T10:11:04  *** xinxi has quit IRC
257 2017-01-14T10:25:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e126d0c12ca6...8daf103fa138
258 2017-01-14T10:25:53  <bitcoin-git> bitcoin/master 988d300 practicalswift: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)
259 2017-01-14T10:25:53  <bitcoin-git> bitcoin/master 8daf103 MarcoFalke: Merge #9528: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)...
260 2017-01-14T10:26:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9528: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64) (master...rename-formateNiceTimeOffset) https://github.com/bitcoin/bitcoin/pull/9528
261 2017-01-14T10:31:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8daf103fa138...23281a4dc3af
262 2017-01-14T10:31:04  <bitcoin-git> bitcoin/master b348287 Alex Morcos: Clarify that prioritisetransaction remains supported
263 2017-01-14T10:31:05  <bitcoin-git> bitcoin/master 34ede12 Alex Morcos: Document fee estimation changes
264 2017-01-14T10:31:05  <bitcoin-git> bitcoin/master 23281a4 MarcoFalke: Merge #9531: Release notes for estimation changes...
265 2017-01-14T10:31:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9531: Release notes for estimation changes  (master...relnotes) https://github.com/bitcoin/bitcoin/pull/9531
266 2017-01-14T11:10:59  *** xinxi has joined #bitcoin-core-dev
267 2017-01-14T11:31:31  *** chjj has quit IRC
268 2017-01-14T11:55:51  *** chjj has joined #bitcoin-core-dev
269 2017-01-14T12:06:48  *** AaronvanW has joined #bitcoin-core-dev
270 2017-01-14T12:06:48  *** AaronvanW has joined #bitcoin-core-dev
271 2017-01-14T12:49:52  *** MarcoFalke has quit IRC
272 2017-01-14T12:54:41  *** xinxi has quit IRC
273 2017-01-14T12:56:04  *** xinxi has joined #bitcoin-core-dev
274 2017-01-14T13:47:30  *** Saucery has joined #bitcoin-core-dev
275 2017-01-14T14:02:54  *** Guyver2 has joined #bitcoin-core-dev
276 2017-01-14T14:29:58  *** Saucery has quit IRC
277 2017-01-14T14:30:11  *** laurentmt has joined #bitcoin-core-dev
278 2017-01-14T14:30:25  *** laurentmt has quit IRC
279 2017-01-14T14:34:00  *** jtimon has joined #bitcoin-core-dev
280 2017-01-14T14:43:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
281 2017-01-14T15:00:54  *** windsok has quit IRC
282 2017-01-14T15:16:19  *** Guyver2 has quit IRC
283 2017-01-14T15:18:38  *** laurentmt has joined #bitcoin-core-dev
284 2017-01-14T15:28:37  *** windsok has joined #bitcoin-core-dev
285 2017-01-14T15:33:05  *** windsok has quit IRC
286 2017-01-14T16:00:14  *** Chris_Stewart_5 has quit IRC
287 2017-01-14T16:07:01  *** d9b4bef9 has quit IRC
288 2017-01-14T16:08:08  *** d9b4bef9 has joined #bitcoin-core-dev
289 2017-01-14T16:11:29  *** windsok has joined #bitcoin-core-dev
290 2017-01-14T16:12:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
291 2017-01-14T16:22:52  *** laurentmt has quit IRC
292 2017-01-14T16:29:58  *** laurentmt has joined #bitcoin-core-dev
293 2017-01-14T16:30:02  *** laurentmt has quit IRC
294 2017-01-14T17:07:20  *** justanotheruser has quit IRC
295 2017-01-14T17:15:22  *** laurentmt has joined #bitcoin-core-dev
296 2017-01-14T17:23:32  *** laurentmt has quit IRC
297 2017-01-14T17:34:48  *** xinxi has quit IRC
298 2017-01-14T17:40:19  *** justanotheruser has joined #bitcoin-core-dev
299 2017-01-14T17:44:19  *** xinxi has joined #bitcoin-core-dev
300 2017-01-14T18:22:25  *** justan0theruser has joined #bitcoin-core-dev
301 2017-01-14T18:24:43  *** justanotheruser has quit IRC
302 2017-01-14T18:25:09  *** justan0theruser is now known as justanotheruser
303 2017-01-14T18:29:41  *** laurentmt has joined #bitcoin-core-dev
304 2017-01-14T18:51:47  <sipa> cfields: -fsanitize=thread "runs" with LDFLAGS="-no-pie"
305 2017-01-14T18:52:32  *** xinxi has quit IRC
306 2017-01-14T18:52:53  <luke-jr> sipa: only with newer compilers.. neither Gentoo-stable compiler supports sanitize=thread without PIE
307 2017-01-14T18:53:11  <luke-jr> and with PIE requires either a newer LLVM or older kernel
308 2017-01-14T18:53:11  *** justan0theruser has joined #bitcoin-core-dev
309 2017-01-14T18:53:30  <luke-jr> (neither of which are available on Travis)
310 2017-01-14T18:54:26  <luke-jr> the LLVM fix backports only so far as 3.8 FWIW (porting to 3.7 seemed difficult, at least)
311 2017-01-14T18:54:31  *** justanotheruser has quit IRC
312 2017-01-14T18:54:37  <sipa> luke-jr: using gcc 6.2
313 2017-01-14T18:55:15  <luke-jr> ok, just pointing out that isn't a reasonable min requirement ;)
314 2017-01-14T18:55:44  * luke-jr peers at Gentoo have 6.3 masked, but no other 6.x at all
315 2017-01-14T18:55:53  *** laurentmt has quit IRC
316 2017-01-14T19:14:17  *** PRab has joined #bitcoin-core-dev
317 2017-01-14T19:20:01  <bitcoin-git> [bitcoin] practicalswift opened pull request #9554: [test] Avoid potential NULL pointer dereference in addrman_tests.cpp (master...avoid-null-pointer-dereference-in-addrman_tests) https://github.com/bitcoin/bitcoin/pull/9554
318 2017-01-14T19:24:39  *** Netmage has joined #bitcoin-core-dev
319 2017-01-14T19:39:32  *** Cheeseo has joined #bitcoin-core-dev
320 2017-01-14T19:39:32  *** Cheeseo has joined #bitcoin-core-dev
321 2017-01-14T19:45:39  <bitcoin-git> [bitcoin] practicalswift opened pull request #9555: [test] Avoid triggering undefined behaviour in tx_invalid-test (transaction_tests.cpp) (master...avoid-ub-in-tx_invalid-test) https://github.com/bitcoin/bitcoin/pull/9555
322 2017-01-14T19:52:39  <Netmage> Hi, I use bitcoint-qt. The size of the block chain is overall 113 GB large. Is this a normal value for the current block chain ?
323 2017-01-14T19:52:57  *** xinxi has joined #bitcoin-core-dev
324 2017-01-14T19:53:45  <btcdrak> Netmage: sadly yes.
325 2017-01-14T19:54:50  <Netmage> ok, is there a good way to decrease the size ?
326 2017-01-14T19:55:06  <Netmage> Without having problems afterwards
327 2017-01-14T19:55:54  *** atroxes has quit IRC
328 2017-01-14T19:57:12  *** atroxes has joined #bitcoin-core-dev
329 2017-01-14T19:57:22  <BlueMatt> yes, luke-jr, Netcraft confirmed: gentoo is dead
330 2017-01-14T19:57:45  <BlueMatt> Netmage: look at the docs for the -prune option
331 2017-01-14T19:57:54  <luke-jr> Netmage: depends on if you need to restore old wallet backups etc
332 2017-01-14T19:58:16  <BlueMatt> luke-jr: ok, sooooo utack for #9499?
333 2017-01-14T19:58:18  <gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub
334 2017-01-14T20:00:33  <luke-jr> BlueMatt: I did not complete review of all the code; I'm not sure it's worth doing as-is, but I don't object to it.
335 2017-01-14T20:01:18  <BlueMatt> huh? folks have reported on the order of 10% fewer rtts!
336 2017-01-14T20:01:21  <BlueMatt> how is that not worth doing?
337 2017-01-14T20:01:52  <BlueMatt> (or more)
338 2017-01-14T20:02:09  <luke-jr> it just seemed like a lot of complexity for what appeared to be random caching; maybe I'm wrong
339 2017-01-14T20:02:14  *** xinxi has quit IRC
340 2017-01-14T20:02:39  <luke-jr> maybe in practice it happens to work out to be very effective
341 2017-01-14T20:02:39  <BlueMatt> most of that pr's "complexity" is copying one block of code.....
342 2017-01-14T20:02:54  <luke-jr> I did review that block
343 2017-01-14T20:03:05  <BlueMatt> but, yes, three independant benchmarks posted on the pr suggested its a huge win
344 2017-01-14T20:03:28  <luke-jr> ok, maybe it is! I'm not objecting
345 2017-01-14T20:04:01  <luke-jr> if my review matters for the merge, I can go back and finish it
346 2017-01-14T20:05:08  <BlueMatt> all reviews matter
347 2017-01-14T20:05:11  <BlueMatt> :)
348 2017-01-14T20:05:23  <luke-jr> maybe I should be doing this one commit-by-commit
349 2017-01-14T20:05:30  <BlueMatt> yes
350 2017-01-14T20:05:48  <BlueMatt> that tends to make most reviews easier :p
351 2017-01-14T20:12:23  <luke-jr> I'd be a lot more comfortable that there isn't an implicit mask in rebasing code, if plTxnReplaced were at the end of the function signature
352 2017-01-14T20:12:45  <luke-jr> s/mask/cast/
353 2017-01-14T20:14:24  <BlueMatt> I believe gcc would complain in any way you fuck that up?
354 2017-01-14T20:14:30  <luke-jr> checking..
355 2017-01-14T20:14:38  <BlueMatt> it should complain if you try to pass a bool into that pointer?
356 2017-01-14T20:15:18  <BlueMatt> i suppose unless, for some reason, you want to fOverrideMempoolLimit based on whether not a std::vector<CTransactionRef>* is non-null
357 2017-01-14T20:15:21  <BlueMatt> but......
358 2017-01-14T20:16:27  <luke-jr> yeah, probably safe
359 2017-01-14T20:23:42  <luke-jr> BlueMatt: c73554042886fb63fb48edf29cf827951edde341 needs a #include "netprocessing.h" in init.cpp I think
360 2017-01-14T20:24:22  <BlueMatt> init has an include net_processing?
361 2017-01-14T20:28:12  <luke-jr> right, nm
362 2017-01-14T20:29:14  *** xinxi has joined #bitcoin-core-dev
363 2017-01-14T20:36:57  *** xinxi has quit IRC
364 2017-01-14T20:42:07  *** AaronvanW has quit IRC
365 2017-01-14T20:47:18  <BlueMatt> cfields: is there a reason CConnman::ForNode calls the provided function with cs_vNodes still locked? that seems bad?
366 2017-01-14T20:47:57  <bitcoin-git> [bitcoin] practicalswift opened pull request #9556: Remove redundant semicolons (master...remove-redundant-braces) https://github.com/bitcoin/bitcoin/pull/9556
367 2017-01-14T20:55:46  <Chris_Stewart_5> If anyone is interested in #8469 and wants to get some internet points on SO: http://stackoverflow.com/questions/41539334/including-header-file-in-cpp-causes-nasty-error
368 2017-01-14T20:55:48  <gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
369 2017-01-14T21:08:07  *** Guyver2 has joined #bitcoin-core-dev
370 2017-01-14T21:16:24  <bitcoin-git> [bitcoin] practicalswift opened pull request #9557: Use static_cast<new_type>(...) instead of deprecated new_type(...) (functional cast) (master...avoid-functional-cast-expression) https://github.com/bitcoin/bitcoin/pull/9557
371 2017-01-14T21:25:00  *** Cheeseo has quit IRC
372 2017-01-14T21:33:33  *** xinxi has joined #bitcoin-core-dev
373 2017-01-14T21:42:07  *** xinxi has quit IRC
374 2017-01-14T21:42:31  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9558: Clarify assumptions made about when BlockCheck is called (master...2017-01-blockcheckeddocs) https://github.com/bitcoin/bitcoin/pull/9558
375 2017-01-14T21:48:15  *** Cheeseo has joined #bitcoin-core-dev
376 2017-01-14T21:48:15  *** Cheeseo has joined #bitcoin-core-dev
377 2017-01-14T22:08:52  <bitcoin-git> [bitcoin] 2HCHO closed pull request #9551: disable out of sync warnings for regtest network (master...ca4b90519c3c210f) https://github.com/bitcoin/bitcoin/pull/9551
378 2017-01-14T22:20:37  *** Saucery has joined #bitcoin-core-dev
379 2017-01-14T22:22:43  *** Cheeseo has quit IRC
380 2017-01-14T22:23:36  <bitcoin-git> [bitcoin] practicalswift opened pull request #9559: [net] Avoid possibility of NULL pointer dereference in ProcessMessage(...) (master...avoid-null-pointer-deref-in-processmessage) https://github.com/bitcoin/bitcoin/pull/9559
381 2017-01-14T22:38:52  *** xinxi has joined #bitcoin-core-dev
382 2017-01-14T22:46:09  *** xinxi has quit IRC
383 2017-01-14T23:03:02  *** d9b4bef9 has quit IRC
384 2017-01-14T23:04:07  <bitcoin-git> [bitcoin] practicalswift opened pull request #9560: [rpc] Avoid possibility of NULL pointer dereference in getblocktemplate(...) (master...avoid-null-pointer-dereference-in-rpc-blockchain) https://github.com/bitcoin/bitcoin/pull/9560
385 2017-01-14T23:04:15  *** d9b4bef9 has joined #bitcoin-core-dev
386 2017-01-14T23:09:48  *** waxwing has quit IRC
387 2017-01-14T23:37:58  <BlueMatt> man practicalswift needs to calm down a bit with this....bad timing, yo
388 2017-01-14T23:42:08  <sipa> release's on fire, yo
389 2017-01-14T23:43:08  *** xinxi has joined #bitcoin-core-dev
390 2017-01-14T23:43:26  <BlueMatt> yea, as in a bunch of stuff is cruisin' to miss :(
391 2017-01-14T23:43:31  <BlueMatt> sipa: how's mystery hung going?
392 2017-01-14T23:43:32  <BlueMatt> t
393 2017-01-14T23:47:17  <sipa> BlueMatt: first team finished at 4am this morning, shortest hunt ever
394 2017-01-14T23:47:28  <sipa> BlueMatt: our team finished early afternoon today
395 2017-01-14T23:48:49  <BlueMatt> oh shit, wow
396 2017-01-14T23:49:37  *** xinxi has quit IRC
397 2017-01-14T23:51:47  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9561: Wake message handling thread when we receive a new block (master...2017-01-wakeup-on-new-block) https://github.com/bitcoin/bitcoin/pull/9561
398 2017-01-14T23:53:35  <BlueMatt> ^ one-line change provides 100ms improvement in block-relay latency for non-compact-block peers :p
399 2017-01-14T23:58:39  *** Guyver2 has quit IRC