1 2017-01-16T00:06:03  *** Saucery has quit IRC
  2 2017-01-16T00:22:49  <BlueMatt> ryanofsky: yo
  3 2017-01-16T00:23:02  <BlueMatt> whats the status of listunspent in #8456
  4 2017-01-16T00:23:06  <gribble> https://github.com/bitcoin/bitcoin/issues/8456 | [RPC] Simplified bumpfee command. by mrbandrews · Pull Request #8456 · bitcoin/bitcoin · GitHub
  5 2017-01-16T00:31:44  *** Cheeseo has joined #bitcoin-core-dev
  6 2017-01-16T00:31:45  <BlueMatt> morcos: as pointed out on github, there are some uses for getbalance "*" that I dont think we can break yet (https://github.com/bitcoin/bitcoin/issues/8183#issuecomment-272598823) so I think this needs fixing in some way for bumpfee
  7 2017-01-16T00:49:02  *** xinxi has joined #bitcoin-core-dev
  8 2017-01-16T01:39:17  *** jtimon has quit IRC
  9 2017-01-16T01:43:10  <morcos> BlueMatt: I still haven't investigated thoroughly myself yet, but you left a comment on 8456 about getbalance ""?
 10 2017-01-16T01:43:26  <morcos> Forget about getbalance "", that's done, its been broken since 0.11, got worse in 0.12
 11 2017-01-16T01:43:56  <morcos> Regardless of bumpfee, it uses GetAccountBalance
 12 2017-01-16T01:44:07  <morcos> and that is unsupported
 13 2017-01-16T01:47:29  *** Ylbam has quit IRC
 14 2017-01-16T01:50:01  *** d9b4bef9 has quit IRC
 15 2017-01-16T01:50:56  <morcos> getbalance "*" is a different question, b/c i agree we need a way to return watch only balances..  so i think something should be done..
 16 2017-01-16T01:51:08  *** d9b4bef9 has joined #bitcoin-core-dev
 17 2017-01-16T01:51:52  <morcos> so to me it's a question of how much bumpfee messes up getbalance "*"
 18 2017-01-16T01:55:33  *** Cheeseo has quit IRC
 19 2017-01-16T01:57:37  *** xinxi has quit IRC
 20 2017-01-16T02:05:17  <morcos> BlueMatt: Wait a second...  How does bumpfee change the output of getbalance "*" anyway?
 21 2017-01-16T02:06:00  <morcos> Are you sure its not just broken for any time you have double spends in your wallet (until one of them is confirmed)
 22 2017-01-16T02:24:18  *** xinxi has joined #bitcoin-core-dev
 23 2017-01-16T02:31:37  *** xinxi has quit IRC
 24 2017-01-16T02:51:51  *** MarcoFalke has joined #bitcoin-core-dev
 25 2017-01-16T02:52:27  *** xinxi has joined #bitcoin-core-dev
 26 2017-01-16T03:11:05  *** droark has joined #bitcoin-core-dev
 27 2017-01-16T03:11:13  *** xinxi has quit IRC
 28 2017-01-16T03:12:44  *** MarcoFalke has quit IRC
 29 2017-01-16T03:17:07  *** xinxi has joined #bitcoin-core-dev
 30 2017-01-16T03:17:12  *** Alopex has quit IRC
 31 2017-01-16T03:18:17  *** Alopex has joined #bitcoin-core-dev
 32 2017-01-16T04:06:15  *** justanotheruser has quit IRC
 33 2017-01-16T04:10:26  *** Alopex has quit IRC
 34 2017-01-16T04:11:31  *** Alopex has joined #bitcoin-core-dev
 35 2017-01-16T04:40:52  *** justanotheruser has joined #bitcoin-core-dev
 36 2017-01-16T05:09:23  *** harrymm has quit IRC
 37 2017-01-16T05:12:53  *** harrymm has joined #bitcoin-core-dev
 38 2017-01-16T05:14:29  *** xinxi has quit IRC
 39 2017-01-16T05:16:00  *** xinxi has joined #bitcoin-core-dev
 40 2017-01-16T06:39:35  *** kadoban has quit IRC
 41 2017-01-16T07:04:02  *** cannon-c has joined #bitcoin-core-dev
 42 2017-01-16T07:18:43  *** Ylbam has joined #bitcoin-core-dev
 43 2017-01-16T08:10:33  *** waxwing has joined #bitcoin-core-dev
 44 2017-01-16T08:10:49  *** xinxi has quit IRC
 45 2017-01-16T08:15:02  *** BashCo_ has quit IRC
 46 2017-01-16T08:15:38  *** BashCo has joined #bitcoin-core-dev
 47 2017-01-16T08:20:00  *** BashCo has quit IRC
 48 2017-01-16T08:26:29  *** BitBully has joined #bitcoin-core-dev
 49 2017-01-16T08:31:38  *** xinxi has joined #bitcoin-core-dev
 50 2017-01-16T08:35:07  *** jannes has joined #bitcoin-core-dev
 51 2017-01-16T08:41:02  *** d9b4bef9 has quit IRC
 52 2017-01-16T08:41:29  *** BashCo has joined #bitcoin-core-dev
 53 2017-01-16T08:42:07  *** d9b4bef9 has joined #bitcoin-core-dev
 54 2017-01-16T08:52:59  *** BitBully has quit IRC
 55 2017-01-16T09:00:22  *** waxwing has quit IRC
 56 2017-01-16T09:12:25  *** waxwing has joined #bitcoin-core-dev
 57 2017-01-16T09:35:56  *** cannon-c is now known as cannon-c_AFK
 58 2017-01-16T09:46:35  *** xinxi has quit IRC
 59 2017-01-16T10:02:53  *** cannon-c_AFK is now known as cannon-c
 60 2017-01-16T10:19:05  *** davec has quit IRC
 61 2017-01-16T10:24:56  *** jtimon has joined #bitcoin-core-dev
 62 2017-01-16T10:34:19  <jonasschnelli> Ping BlueMatt luke-jr: https://github.com/bitcoin/bitcoin/pull/9294
 63 2017-01-16T10:41:41  <cannon-c> Quick question, I am looking to using bitcoin core in conjunction with ssss (Shamirs secret sharing scheme)
 64 2017-01-16T10:42:06  <cannon-c> to create fragmented seed backups which can be re-created using pre-defined threshold of number of shares
 65 2017-01-16T10:42:24  <cannon-c> Does Core already have something like this?
 66 2017-01-16T10:42:35  <cannon-c> I dont want to duplicate something that already exists
 67 2017-01-16T10:43:40  *** BitBully has joined #bitcoin-core-dev
 68 2017-01-16T10:44:47  <cannon-c> One use case, creating the xpriv on airgap system, with fragmented backup as contingency of access
 69 2017-01-16T10:44:58  <cannon-c> to family if something happens to me
 70 2017-01-16T10:45:42  <cannon-c> or great for distributed backups
 71 2017-01-16T10:47:00  *** xinxi has joined #bitcoin-core-dev
 72 2017-01-16T10:51:04  *** thermoman has quit IRC
 73 2017-01-16T10:53:44  *** Guyver2 has joined #bitcoin-core-dev
 74 2017-01-16T10:55:24  *** xinxi has quit IRC
 75 2017-01-16T11:19:14  *** trotski2000 has quit IRC
 76 2017-01-16T11:19:14  *** trotski2000 has joined #bitcoin-core-dev
 77 2017-01-16T11:19:14  *** trotski2000 has quit IRC
 78 2017-01-16T11:19:14  *** trotski2000 has joined #bitcoin-core-dev
 79 2017-01-16T11:22:17  *** xinxi has joined #bitcoin-core-dev
 80 2017-01-16T11:27:29  *** To7 has quit IRC
 81 2017-01-16T11:31:40  *** xinxi has quit IRC
 82 2017-01-16T11:33:29  *** BitBully has quit IRC
 83 2017-01-16T11:37:14  *** BitBully has joined #bitcoin-core-dev
 84 2017-01-16T11:37:16  *** xinxi has joined #bitcoin-core-dev
 85 2017-01-16T11:45:10  *** To7 has joined #bitcoin-core-dev
 86 2017-01-16T11:57:20  <btcdrak> jonasschnelli: testing
 87 2017-01-16T12:16:52  *** MarcoFalke has joined #bitcoin-core-dev
 88 2017-01-16T12:35:02  <jonasschnelli> btcdrak: thanks!
 89 2017-01-16T12:44:57  *** BitBully has quit IRC
 90 2017-01-16T12:52:14  *** MarcoFalke has quit IRC
 91 2017-01-16T13:14:47  *** laurentmt has joined #bitcoin-core-dev
 92 2017-01-16T13:16:23  *** BitBully has joined #bitcoin-core-dev
 93 2017-01-16T13:20:00  *** laurentmt has quit IRC
 94 2017-01-16T13:20:04  *** BitBully has quit IRC
 95 2017-01-16T13:35:35  *** xinxi has quit IRC
 96 2017-01-16T13:40:50  *** waxwing has quit IRC
 97 2017-01-16T13:43:57  *** xinxi has joined #bitcoin-core-dev
 98 2017-01-16T13:46:00  <morcos> wumpus: I think #9380 is *almost* ready for merge, ideally it would be merged in time to keep the translation strings for -blockmintxfee.   I think the only open question is if people prefer a different name for -dustrelayfee.
 99 2017-01-16T13:46:01  <gribble> https://github.com/bitcoin/bitcoin/issues/9380 | Separate different uses of minimum fees by morcos · Pull Request #9380 · bitcoin/bitcoin · GitHub
100 2017-01-16T13:50:52  *** BitBully has joined #bitcoin-core-dev
101 2017-01-16T13:58:28  *** BitBully has quit IRC
102 2017-01-16T14:00:09  *** waxwing has joined #bitcoin-core-dev
103 2017-01-16T14:00:23  <instagibbs> cannon-c, try #bitcoin
104 2017-01-16T14:00:48  *** cannon-c has quit IRC
105 2017-01-16T14:01:59  *** BitBully has joined #bitcoin-core-dev
106 2017-01-16T14:05:59  *** BitBully has quit IRC
107 2017-01-16T14:26:31  *** instagibbs has quit IRC
108 2017-01-16T14:26:50  *** laurentmt has joined #bitcoin-core-dev
109 2017-01-16T14:39:44  *** Chris_Stewart_5 has quit IRC
110 2017-01-16T14:58:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
111 2017-01-16T15:07:07  *** laurentmt has quit IRC
112 2017-01-16T15:08:36  *** dmrche has joined #bitcoin-core-dev
113 2017-01-16T15:12:38  *** xinxi has quit IRC
114 2017-01-16T15:18:06  *** Hmbryjb has joined #bitcoin-core-dev
115 2017-01-16T15:22:40  *** Hmbryjb has quit IRC
116 2017-01-16T15:24:31  *** Chris_Stewart_5 has quit IRC
117 2017-01-16T15:26:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
118 2017-01-16T16:08:50  *** Chris_Stewart_5 has quit IRC
119 2017-01-16T16:14:51  *** Netmage has joined #bitcoin-core-dev
120 2017-01-16T16:15:39  *** cryptapus_afk has quit IRC
121 2017-01-16T16:16:02  *** cryptapus_afk has joined #bitcoin-core-dev
122 2017-01-16T16:16:03  *** cryptapus_afk has joined #bitcoin-core-dev
123 2017-01-16T16:23:23  *** cryptapus_afk has quit IRC
124 2017-01-16T16:24:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
125 2017-01-16T16:35:56  *** PRab has quit IRC
126 2017-01-16T16:39:54  *** cryptapus has joined #bitcoin-core-dev
127 2017-01-16T16:39:54  *** cryptapus has joined #bitcoin-core-dev
128 2017-01-16T16:52:00  *** aalex has joined #bitcoin-core-dev
129 2017-01-16T17:08:56  *** jannes has quit IRC
130 2017-01-16T17:20:45  *** BashCo has quit IRC
131 2017-01-16T17:21:22  *** BashCo has joined #bitcoin-core-dev
132 2017-01-16T17:22:34  *** BitBully has joined #bitcoin-core-dev
133 2017-01-16T17:23:21  *** abpa has joined #bitcoin-core-dev
134 2017-01-16T17:26:02  *** BashCo has quit IRC
135 2017-01-16T17:29:05  *** BitBully has quit IRC
136 2017-01-16T17:40:55  *** BashCo has joined #bitcoin-core-dev
137 2017-01-16T17:47:35  *** davec has joined #bitcoin-core-dev
138 2017-01-16T17:49:26  *** kadoban has joined #bitcoin-core-dev
139 2017-01-16T17:51:56  *** waxwing has quit IRC
140 2017-01-16T17:54:18  *** Raptor186 has joined #bitcoin-core-dev
141 2017-01-16T17:58:59  *** cryptapus is now known as cryptapus_afk
142 2017-01-16T18:16:44  *** wvr has joined #bitcoin-core-dev
143 2017-01-16T18:17:33  <jtimon> morcos: re #9380 I would leave -dustrelayfee, or change to -dustfee maybe, no strong opinion on my part
144 2017-01-16T18:17:35  <gribble> https://github.com/bitcoin/bitcoin/issues/9380 | Separate different uses of minimum fees by morcos · Pull Request #9380 · bitcoin/bitcoin · GitHub
145 2017-01-16T18:29:27  *** Raptor186 has quit IRC
146 2017-01-16T18:33:37  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8a445c5651ed...dd98f0453824
147 2017-01-16T18:33:38  <bitcoin-git> bitcoin/master daec955 Alex Morcos: Introduce -blockmintxfee
148 2017-01-16T18:33:38  <bitcoin-git> bitcoin/master 7b1add3 Alex Morcos: Introduce -incrementalrelayfee
149 2017-01-16T18:33:39  <bitcoin-git> bitcoin/master eb30d1a Alex Morcos: Introduce -dustrelayfee
150 2017-01-16T18:33:52  <bitcoin-git> [bitcoin] laanwj closed pull request #9380: Separate different uses of minimum fees (master...minfees) https://github.com/bitcoin/bitcoin/pull/9380
151 2017-01-16T19:00:01  *** kadoban has quit IRC
152 2017-01-16T19:18:31  *** instagibbs has joined #bitcoin-core-dev
153 2017-01-16T19:23:49  *** PRab has joined #bitcoin-core-dev
154 2017-01-16T19:28:05  *** mol has quit IRC
155 2017-01-16T19:31:38  *** Chris_Stewart_5 has quit IRC
156 2017-01-16T19:35:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
157 2017-01-16T19:35:50  *** dmrche has quit IRC
158 2017-01-16T19:41:40  *** Chris_Stewart_5 has quit IRC
159 2017-01-16T19:50:37  <BlueMatt> morcos: the difference is that bumpfee takes us to a world where having "double spends" in your wallet is entirely supported
160 2017-01-16T19:50:58  <morcos> It's already supported once we merged BIP 152
161 2017-01-16T19:51:03  <morcos> uh
162 2017-01-16T19:51:04  <morcos> 125
163 2017-01-16T19:51:05  <morcos> whatever
164 2017-01-16T19:51:22  <BlueMatt> instead of, previously, you'd have to do something unsupported like run your wallet on multiple machines to get it
165 2017-01-16T19:51:24  <BlueMatt> hmm?
166 2017-01-16T19:51:27  <morcos> actually it was supported even before that
167 2017-01-16T19:51:36  <BlueMatt> only abandon transaction supported it?
168 2017-01-16T19:51:40  <BlueMatt> well, you generating them, that is
169 2017-01-16T19:51:43  <BlueMatt> you receiving them maybe
170 2017-01-16T19:51:49  <morcos> yeah exactly
171 2017-01-16T19:52:04  <BlueMatt> but now we are actively supporting you generating them
172 2017-01-16T19:52:07  <BlueMatt> which is a huge difference
173 2017-01-16T19:52:16  <BlueMatt> (is getbalance "*" broken for receiving double spends, too?)
174 2017-01-16T19:52:33  <morcos> and previously you could generate them yourself also...
175 2017-01-16T19:52:40  <BlueMatt> manually, sure
176 2017-01-16T19:52:50  <BlueMatt> but "unsupported, might break getbalance" is perfectly reasonable in that case
177 2017-01-16T19:53:02  <morcos> the only thing stopping you from doing it automatically would be if your mempool had your original spend
178 2017-01-16T19:53:05  <morcos> so the coins didn't show up
179 2017-01-16T19:53:27  <morcos> so if it came out of your mempool for any reason...  expired after 3 days for instance
180 2017-01-16T19:53:51  <BlueMatt> hmm? we re-add your txn to mempool?
181 2017-01-16T19:53:54  <morcos> nothing stopping you from double spending...  with 0.12, we made it so you had to abandon it first but that wasn't a requirement before that
182 2017-01-16T19:54:01  <BlueMatt> so only abandon would stop it?
183 2017-01-16T19:54:30  <morcos> i'm saying if you automatically created tx A, then A was evicted from your mempool, never made it in, or was expired
184 2017-01-16T19:54:30  <BlueMatt> i mean sure, if you manually createrawtransaction/signrawtransaction you could doublespend easily
185 2017-01-16T19:54:40  <BlueMatt> if it was expired it would be re-added
186 2017-01-16T19:54:45  <morcos> nothing would prevent you from doing an sendtoaddress and creating A' doublespend
187 2017-01-16T19:54:49  <morcos> no it wouldn't
188 2017-01-16T19:54:52  <morcos> we just added that
189 2017-01-16T19:54:52  <BlueMatt> oh?
190 2017-01-16T19:54:56  <BlueMatt> wait, what?
191 2017-01-16T19:55:06  <BlueMatt> we've always re-announced transactions on a regular basis?
192 2017-01-16T19:55:20  <morcos> reannounce txs already in your mempool
193 2017-01-16T19:55:47  <BlueMatt> I mean to be clear, I'm fine with some documentation noting that getbalance "*" is broken, and should not be used, and is made worse with bumpfee
194 2017-01-16T19:55:47  <morcos> i'm inflating my argument slightly, since before mempool limiting, things didn't really fall out of your mempool very much
195 2017-01-16T19:55:50  <BlueMatt> really?
196 2017-01-16T19:56:01  <BlueMatt> yea, ok, i suppose thats why
197 2017-01-16T19:56:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
198 2017-01-16T19:56:27  <morcos> See #9290
199 2017-01-16T19:56:29  <gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
200 2017-01-16T19:56:38  <BlueMatt> ahh
201 2017-01-16T19:57:27  <morcos> Anyway, i guess my point is its not fair to accept a bumpfee PR to take on fixing years of broken code just b/c it might lead to the bugs being exposed more...
202 2017-01-16T19:57:34  <morcos> the bugs are exposed more by allowing double spends
203 2017-01-16T19:57:39  <morcos> we've already crossed that bridge
204 2017-01-16T19:57:59  <morcos> its stupid to say we won't make it easier for you b/c our code is broken in some ways reporting on them
205 2017-01-16T19:58:15  <BlueMatt> well i believe the bugs are only currently exposed if you're doing something entirely unsupported (or, in the case fixed by #9290 by bugs which we need to/did fix)
206 2017-01-16T19:58:17  <gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
207 2017-01-16T19:58:39  <morcos> i don't really feel strongly about merging bumpfee for 0.14..   thats not really what i'm arguing about.. and i think your last minute concerns are a good reflection that it seems a bit rushed trying to get it in
208 2017-01-16T19:58:43  <BlueMatt> considering its deprecated I dont see why we cant just put a note in the docs and say "this is broken"
209 2017-01-16T19:59:04  <BlueMatt> (bumpfee "*", that is)
210 2017-01-16T19:59:09  <morcos> i just don't think that when we decide it is ready to merge we should be weighing it down with the responsiblity of fixign eveyrthing else
211 2017-01-16T19:59:41  <morcos> why don't you think bugs are exposed if you receive a double spend?
212 2017-01-16T19:59:44  <BlueMatt> agreed, totally get that, but in this case I do think we are exposing bugs which were only previously exposed if the user was doing something insane
213 2017-01-16T19:59:49  <morcos> a BIP 125 compatible one
214 2017-01-16T19:59:56  <BlueMatt> though, really, if bumpfee slips 0.14, we should just remove accounts for 0.14
215 2017-01-16T19:59:57  <morcos> thats not insance at all
216 2017-01-16T20:00:03  <BlueMatt> then bumpfee isnt exposing shit :p
217 2017-01-16T20:00:27  <BlueMatt> are the bugs exposed if you receive a bumpfee from someone else? I havent thought that far into it
218 2017-01-16T20:00:55  <morcos> ah
219 2017-01-16T20:00:58  <morcos> perhaps not...
220 2017-01-16T20:01:04  <BlueMatt> no, asking, i have no idea
221 2017-01-16T20:01:14  <BlueMatt> not saying i dont think they are, just havent looked
222 2017-01-16T20:01:26  <morcos> well the issue is 0-confirm things reduce your balance, regardless of whether they are in the mempool or not
223 2017-01-16T20:01:47  <morcos> if its a tx from someoen else, it won't add to yoru balance if its 0 confirm period...
224 2017-01-16T20:02:20  <morcos> but i bet getbalance "*" 0 is broken if you receive a double spend
225 2017-01-16T20:03:05  <BlueMatt> could see that, but getbalance "*" 1 can go negative with bumpfee, I believe
226 2017-01-16T20:03:14  <morcos> anyway... i just don't think bumpfee CHANGES anything about this...
227 2017-01-16T20:03:35  <BlueMatt> or maybe not?
228 2017-01-16T20:04:09  <morcos> lets just agree it shouldn't be fixed on the bumpfee PR...  i'll argue less (or none) about saying we shouldn't do a release with bumpfee before its fixed
229 2017-01-16T20:04:21  <BlueMatt> if I'm right (and might not be), during normal use of the wallet, getbalance "*" 1 is (probaboy, I think?) correct, and is currently the only way to get your balance if you include watchonly
230 2017-01-16T20:04:27  <BlueMatt> with bumpfee, I believe, this changes
231 2017-01-16T20:04:31  <BlueMatt> so it is no longer correct
232 2017-01-16T20:05:36  <BlueMatt> unrelatedly, did we document the listunspent changes for bumpfee?
233 2017-01-16T20:05:45  <BlueMatt> I do think that needs documentation, if no code changes
234 2017-01-16T20:06:19  <morcos> yeah.. i actually think we should probably just return the txs in listunspent
235 2017-01-16T20:06:34  <BlueMatt> both of them?
236 2017-01-16T20:06:36  <BlueMatt> that seems shit
237 2017-01-16T20:06:43  <morcos> its trivial to do b/c listunspent already passes a fOnlyConfirmed bool set to fallse to AvailableCoins that no other uses of it do
238 2017-01-16T20:06:52  <BlueMatt> (does it currently return abandoned tx or tx not in mempool?)
239 2017-01-16T20:06:59  <morcos> i think so
240 2017-01-16T20:07:13  <morcos> i don't know let me check
241 2017-01-16T20:07:53  <BlueMatt> no, it just calls AvailableCoins
242 2017-01-16T20:08:00  <BlueMatt> so only if its "trusted" and in mempool
243 2017-01-16T20:08:14  <morcos> no it doesn't check IsTrusted
244 2017-01-16T20:08:20  <morcos> but you are right it checks the mempool
245 2017-01-16T20:08:20  <BlueMatt> wait, no, wtf is fOnlyConfirmed
246 2017-01-16T20:08:30  <BlueMatt> oh, yes, you're right
247 2017-01-16T20:08:45  <morcos> which maybe is exactly what we want?
248 2017-01-16T20:09:34  <BlueMatt> I think if we add an fOnlyConfirmed to both of the replaces/replaced checks that would be least-surprising to users
249 2017-01-16T20:09:44  <morcos> agreed
250 2017-01-16T20:09:45  <BlueMatt> but, frankly, I'm open to anything that is documented
251 2017-01-16T20:10:43  <BlueMatt> would you like me to go finish review assuming that gets fixed? if we feel it could still be merged for 0.14 I'm happy to
252 2017-01-16T20:10:53  <BlueMatt> not sure how wumpus or sipa feel about it now
253 2017-01-16T20:12:11  <morcos> ehh...  if it was me, i'd put it in 0.14..  but i'm not going to advocate for it...   maybe gmaxwell feels strongly?
254 2017-01-16T20:12:32  <morcos> i think #9294 is maybe higher priority
255 2017-01-16T20:12:35  <gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
256 2017-01-16T20:12:35  <BlueMatt> I mean the way i have left to review this is to literally go read all of wallet and rpcwallet
257 2017-01-16T20:12:48  <BlueMatt> is that still waiting on fixes?
258 2017-01-16T20:12:57  <BlueMatt> oh, no, ok, will review that one at least
259 2017-01-16T20:13:04  <morcos> i don't know.. i just started reading BIP 32..   ha
260 2017-01-16T20:14:23  <sdaftuar> if we're concerned about bumpfee for 0.14, i think we could merge it and mark it as experimental?  i'm also ok with merging after the 0.14 split and use the 0.15 release cycle as time to get the bugs out while it simmers in master
261 2017-01-16T20:14:30  <BlueMatt> jonasschnelli: you around?
262 2017-01-16T20:15:04  <sdaftuar> i'd be concerned about holding it up further though for unreleated walelt bugs that it exposes
263 2017-01-16T20:15:25  <BlueMatt> sdaftuar: well the only thing I found so far that really is a problem, I think, is listunspent
264 2017-01-16T20:15:48  <BlueMatt> the getbalance "*" thing I really hate, but am not sure is a reasonable fix
265 2017-01-16T20:16:37  * BlueMatt is still hoping #9561 and #9535 get another last-minute review or two and get merged
266 2017-01-16T20:16:38  <gribble> https://github.com/bitcoin/bitcoin/issues/9561 | Wake message handling thread when we receive a new block by TheBlueMatt · Pull Request #9561 · bitcoin/bitcoin · GitHub
267 2017-01-16T20:16:40  <gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub
268 2017-01-16T20:16:42  <BlueMatt> but it seems like no one is around today :(
269 2017-01-16T20:16:46  <BlueMatt> damn holidays
270 2017-01-16T20:16:50  <BlueMatt> always getting in the way
271 2017-01-16T20:17:40  <sdaftuar> yeah i think listunspent could be a fix-by-documentation, at least for now.  makes more sense if we indicate bumpfee is an experimental feature?
272 2017-01-16T20:18:17  <BlueMatt> im fine with that
273 2017-01-16T20:18:50  <BlueMatt> though I think the above-discussed fix might also be sufficient
274 2017-01-16T20:20:25  <BlueMatt> would just need a quick pass to check all the other places fOnlyConfirmed is set in callers
275 2017-01-16T20:20:56  *** owowo has quit IRC
276 2017-01-16T20:23:20  *** Chris_Stewart_5 has quit IRC
277 2017-01-16T20:28:57  <morcos> BlueMatt: i already did that, only set by listunspent
278 2017-01-16T20:29:10  <BlueMatt> cool
279 2017-01-16T20:29:50  <morcos> what about #9499, that is a pretty big win if you ask me... especially without multiple block downloads
280 2017-01-16T20:29:52  <gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub
281 2017-01-16T20:30:26  <BlueMatt> yes, and probably has enough review to get a merge, I'd say
282 2017-01-16T20:33:11  <sipa> BlueMatt: i'll do another pass today
283 2017-01-16T20:33:16  <sipa> now meeting ethan
284 2017-01-16T20:33:17  <BlueMatt> thanks
285 2017-01-16T20:33:24  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/b0819c7e9b428631b806d97ff19beb2e218df31f
286 2017-01-16T20:33:24  <bitcoin-git> bitcoin/master b0819c7 Wladimir J. van der Laan: qt: periodic translations update
287 2017-01-16T20:33:27  <BlueMatt> cool, tell him i said hi
288 2017-01-16T20:39:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
289 2017-01-16T20:44:22  *** PaulCapestany has quit IRC
290 2017-01-16T20:47:16  *** CubicEarth has joined #bitcoin-core-dev
291 2017-01-16T20:47:25  <sipa> he says hello
292 2017-01-16T20:58:14  *** owowo has joined #bitcoin-core-dev
293 2017-01-16T21:03:58  *** CubicEarth has quit IRC
294 2017-01-16T21:04:11  *** instagibbs has quit IRC
295 2017-01-16T21:11:14  *** instagibbs has joined #bitcoin-core-dev
296 2017-01-16T21:13:12  * instagibbs attempting 9561 review
297 2017-01-16T21:13:23  <instagibbs> 9499 is def ready
298 2017-01-16T21:17:11  *** kvnn has joined #bitcoin-core-dev
299 2017-01-16T21:24:34  *** To7 has quit IRC
300 2017-01-16T21:30:10  <sipa> #9499
301 2017-01-16T21:30:13  <gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub
302 2017-01-16T21:30:17  <sipa> #9561
303 2017-01-16T21:30:19  <gribble> https://github.com/bitcoin/bitcoin/issues/9561 | Wake message handling thread when we receive a new block by TheBlueMatt · Pull Request #9561 · bitcoin/bitcoin · GitHub
304 2017-01-16T21:30:24  <sipa> agree
305 2017-01-16T21:31:34  <instagibbs> oops, I meant 9535
306 2017-01-16T21:31:49  <instagibbs> for my attempted review...
307 2017-01-16T21:32:21  <sipa> #9535
308 2017-01-16T21:32:23  <gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub
309 2017-01-16T21:38:45  <cfields> agree on all of those
310 2017-01-16T21:39:39  <BlueMatt> #9484 obv
311 2017-01-16T21:39:41  <gribble> https://github.com/bitcoin/bitcoin/issues/9484 | Introduce assumevalid setting to skip validation presumed valid scripts. by gmaxwell · Pull Request #9484 · bitcoin/bitcoin · GitHub
312 2017-01-16T21:40:48  <cfields> ah right, i need to sync up and ack the hash
313 2017-01-16T21:41:04  <cfields> (i'm sure it's fine :)
314 2017-01-16T21:42:17  <sipa> no, you should not be sure it is fine
315 2017-01-16T21:42:37  <sipa> (i, however, am)
316 2017-01-16T21:44:14  <BlueMatt> I did validate that hash prior to ack
317 2017-01-16T21:49:38  <BlueMatt> if we're willing to push a day, I think both #9294 and #8456 could make it, but not sure they're gonna make it today
318 2017-01-16T21:49:40  <gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
319 2017-01-16T21:49:42  <BlueMatt> well, maybe two days
320 2017-01-16T21:49:44  <gribble> https://github.com/bitcoin/bitcoin/issues/8456 | [RPC] Simplified bumpfee command. by mrbandrews · Pull Request #8456 · bitcoin/bitcoin · GitHub
321 2017-01-16T21:49:57  <BlueMatt> but i do think they're both super close
322 2017-01-16T22:07:54  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b0819c7e9b42...812714fd80e9
323 2017-01-16T22:07:55  <bitcoin-git> bitcoin/master e440ac7 Gregory Maxwell: Introduce assumevalid setting to skip presumed valid scripts....
324 2017-01-16T22:07:56  <bitcoin-git> bitcoin/master 7b5e3fe John Newbery: Add assumevalid testcase...
325 2017-01-16T22:07:56  <bitcoin-git> bitcoin/master 812714f Pieter Wuille: Merge #9484: Introduce assumevalid setting to skip validation presumed valid scripts....
326 2017-01-16T22:08:09  <bitcoin-git> [bitcoin] sipa closed pull request #9484: Introduce assumevalid setting to skip validation presumed valid scripts. (master...script_elide_verified) https://github.com/bitcoin/bitcoin/pull/9484
327 2017-01-16T22:22:15  *** waxwing has joined #bitcoin-core-dev
328 2017-01-16T22:39:37  *** kadoban has joined #bitcoin-core-dev
329 2017-01-16T22:40:15  *** Guyver2 has quit IRC
330 2017-01-16T22:58:51  <bitcoin-git> [bitcoin] theuni opened pull request #9566: threading: use std::chrono for timestamps (master...nuke-boost-chrono2) https://github.com/bitcoin/bitcoin/pull/9566
331 2017-01-16T23:14:45  *** cryptapus_afk is now known as cryptapus
332 2017-01-16T23:31:33  *** cryptapus is now known as cryptapus_afk
333 2017-01-16T23:47:34  *** wvr has quit IRC
334 2017-01-16T23:53:27  *** Chris_Stewart_5 has quit IRC
335 2017-01-16T23:58:35  *** abpa has quit IRC