1 2017-01-18T00:09:48  *** chjj has quit IRC
  2 2017-01-18T00:23:05  *** chjj has joined #bitcoin-core-dev
  3 2017-01-18T00:32:39  *** MarcoFalke has quit IRC
  4 2017-01-18T00:46:34  *** chjj has quit IRC
  5 2017-01-18T00:46:54  *** chjj has joined #bitcoin-core-dev
  6 2017-01-18T00:59:46  *** abpa has quit IRC
  7 2017-01-18T01:06:44  *** Chris_Stewart_5 has quit IRC
  8 2017-01-18T01:13:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  9 2017-01-18T01:16:06  *** Netmage has quit IRC
 10 2017-01-18T01:16:51  *** Netmage has joined #bitcoin-core-dev
 11 2017-01-18T01:21:37  *** shesek has quit IRC
 12 2017-01-18T01:22:22  *** stench has quit IRC
 13 2017-01-18T01:23:34  *** stench has joined #bitcoin-core-dev
 14 2017-01-18T01:27:29  *** Ylbam has quit IRC
 15 2017-01-18T01:27:34  <bitcoin-git> [bitcoin] pinheadmz opened pull request #9571: RPC: getblockchaininfo returns BIP signaling statistics  (master...master) https://github.com/bitcoin/bitcoin/pull/9571
 16 2017-01-18T01:27:38  *** BashCo has quit IRC
 17 2017-01-18T01:27:39  *** atroxes has quit IRC
 18 2017-01-18T01:29:13  *** BashCo has joined #bitcoin-core-dev
 19 2017-01-18T01:29:13  *** atroxes has joined #bitcoin-core-dev
 20 2017-01-18T01:35:41  *** laurentmt has joined #bitcoin-core-dev
 21 2017-01-18T01:35:45  *** laurentmt has quit IRC
 22 2017-01-18T01:36:13  *** [Author] has quit IRC
 23 2017-01-18T01:36:13  *** Magma has quit IRC
 24 2017-01-18T01:36:13  *** fengling has quit IRC
 25 2017-01-18T01:38:05  *** handlex has quit IRC
 26 2017-01-18T02:03:01  *** AaronvanW has quit IRC
 27 2017-01-18T02:12:05  *** CubicEarth has joined #bitcoin-core-dev
 28 2017-01-18T02:25:07  *** randy-waterhouse has joined #bitcoin-core-dev
 29 2017-01-18T02:25:15  *** Chris_Stewart_5 has quit IRC
 30 2017-01-18T02:25:27  *** randy-waterhouse has quit IRC
 31 2017-01-18T02:25:27  *** randy-waterhouse has joined #bitcoin-core-dev
 32 2017-01-18T02:27:50  *** Magma has joined #bitcoin-core-dev
 33 2017-01-18T02:29:19  *** [Author] has joined #bitcoin-core-dev
 34 2017-01-18T02:36:50  *** randy-waterhouse has quit IRC
 35 2017-01-18T02:41:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 36 2017-01-18T02:55:47  *** randy-waterhouse has joined #bitcoin-core-dev
 37 2017-01-18T02:56:35  *** randy-waterhouse has joined #bitcoin-core-dev
 38 2017-01-18T02:57:31  *** fengling has joined #bitcoin-core-dev
 39 2017-01-18T03:00:22  *** cheese_ has quit IRC
 40 2017-01-18T03:00:44  *** cheese_ has joined #bitcoin-core-dev
 41 2017-01-18T03:00:45  *** cheese_ has joined #bitcoin-core-dev
 42 2017-01-18T03:20:51  *** Squidicc has quit IRC
 43 2017-01-18T03:25:40  *** Chris_Stewart_5 has quit IRC
 44 2017-01-18T03:31:11  *** Alopex has quit IRC
 45 2017-01-18T03:32:17  *** Alopex has joined #bitcoin-core-dev
 46 2017-01-18T03:33:25  *** Squidicuz has joined #bitcoin-core-dev
 47 2017-01-18T03:39:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 48 2017-01-18T04:02:32  *** randy-waterhouse has quit IRC
 49 2017-01-18T04:04:05  *** droark has joined #bitcoin-core-dev
 50 2017-01-18T04:15:21  *** Alopex has quit IRC
 51 2017-01-18T04:16:27  *** Alopex has joined #bitcoin-core-dev
 52 2017-01-18T04:47:16  *** justan0theruser has joined #bitcoin-core-dev
 53 2017-01-18T04:49:16  *** justanotheruser has quit IRC
 54 2017-01-18T04:54:18  *** waxwing has joined #bitcoin-core-dev
 55 2017-01-18T04:57:26  *** CubicEarth has quit IRC
 56 2017-01-18T05:00:04  *** dermoth has quit IRC
 57 2017-01-18T05:00:45  *** dermoth has joined #bitcoin-core-dev
 58 2017-01-18T05:23:06  *** Alopex has quit IRC
 59 2017-01-18T05:24:12  *** Alopex has joined #bitcoin-core-dev
 60 2017-01-18T05:24:59  *** CubicEarth has joined #bitcoin-core-dev
 61 2017-01-18T05:34:07  *** Alopex has quit IRC
 62 2017-01-18T05:35:12  *** Alopex has joined #bitcoin-core-dev
 63 2017-01-18T06:12:26  *** aalex has joined #bitcoin-core-dev
 64 2017-01-18T06:19:48  *** aalex has quit IRC
 65 2017-01-18T06:21:24  *** bsm117532 has quit IRC
 66 2017-01-18T06:35:04  *** bsm117532 has joined #bitcoin-core-dev
 67 2017-01-18T06:45:31  *** jtimon has quit IRC
 68 2017-01-18T06:45:37  *** cheese_ has quit IRC
 69 2017-01-18T06:47:38  *** bsm117532 has quit IRC
 70 2017-01-18T06:48:59  *** Cheeseo has joined #bitcoin-core-dev
 71 2017-01-18T07:02:52  <jonasschnelli> BlueMatt: I'm working on the fixes for #9461
 72 2017-01-18T07:03:57  <gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub
 73 2017-01-18T07:36:02  *** shesek has joined #bitcoin-core-dev
 74 2017-01-18T07:39:49  *** Ylbam has joined #bitcoin-core-dev
 75 2017-01-18T07:45:33  *** kadoban has quit IRC
 76 2017-01-18T07:55:42  <bitcoin-git> [bitcoin] jl2012 opened pull request #9572: Skip witness sighash cache for non-segwit transactions (master...nocache) https://github.com/bitcoin/bitcoin/pull/9572
 77 2017-01-18T08:13:52  *** BashCo has quit IRC
 78 2017-01-18T08:14:56  *** MarcoFalke has joined #bitcoin-core-dev
 79 2017-01-18T08:20:36  *** paveljanik has quit IRC
 80 2017-01-18T08:35:50  *** BashCo has joined #bitcoin-core-dev
 81 2017-01-18T08:52:53  *** BashCo_ has joined #bitcoin-core-dev
 82 2017-01-18T08:56:11  *** BashCo has quit IRC
 83 2017-01-18T08:57:12  *** Samdney has joined #bitcoin-core-dev
 84 2017-01-18T09:02:08  *** Samdney has quit IRC
 85 2017-01-18T09:07:02  *** Samdney has joined #bitcoin-core-dev
 86 2017-01-18T09:26:05  *** CubicEarth has quit IRC
 87 2017-01-18T09:26:40  *** CubicEarth has joined #bitcoin-core-dev
 88 2017-01-18T09:43:25  *** jannes has joined #bitcoin-core-dev
 89 2017-01-18T09:45:12  *** timothy has quit IRC
 90 2017-01-18T09:56:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6696b4635ceb...b0b57a17306a
 91 2017-01-18T09:56:47  <bitcoin-git> bitcoin/master 95bab82 practicalswift: Remove unused Python imports
 92 2017-01-18T09:56:48  <bitcoin-git> bitcoin/master b0b57a1 MarcoFalke: Merge #9508: Remove unused Python imports...
 93 2017-01-18T09:57:02  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9508: Remove unused Python imports (master...remove-unused-python-import) https://github.com/bitcoin/bitcoin/pull/9508
 94 2017-01-18T10:00:35  *** wvr has quit IRC
 95 2017-01-18T10:00:39  *** Samdney has quit IRC
 96 2017-01-18T10:10:13  *** e4xit has joined #bitcoin-core-dev
 97 2017-01-18T10:14:15  *** wvr has joined #bitcoin-core-dev
 98 2017-01-18T10:15:39  *** MarcoFalke has quit IRC
 99 2017-01-18T10:23:57  *** AaronvanW has joined #bitcoin-core-dev
100 2017-01-18T10:26:39  *** CubicEarth has quit IRC
101 2017-01-18T10:38:44  *** CubicEarth has joined #bitcoin-core-dev
102 2017-01-18T10:41:05  *** chjj has quit IRC
103 2017-01-18T11:01:25  *** kittyP has joined #bitcoin-core-dev
104 2017-01-18T11:04:04  *** kittyP has left #bitcoin-core-dev
105 2017-01-18T11:15:11  *** Guyver2 has joined #bitcoin-core-dev
106 2017-01-18T11:27:28  *** chjj has joined #bitcoin-core-dev
107 2017-01-18T11:32:51  *** CubicEarth has quit IRC
108 2017-01-18T11:36:30  *** waxwing has quit IRC
109 2017-01-18T11:37:15  <bitcoin-git> [bitcoin] fanquake opened pull request #9574: [depends] Fix QT build on OSX (master...fix-osx-depends-build) https://github.com/bitcoin/bitcoin/pull/9574
110 2017-01-18T11:49:48  *** waxwing has joined #bitcoin-core-dev
111 2017-01-18T12:20:31  *** cryptapus has joined #bitcoin-core-dev
112 2017-01-18T12:20:31  *** cryptapus has joined #bitcoin-core-dev
113 2017-01-18T12:26:06  *** jtimon has joined #bitcoin-core-dev
114 2017-01-18T13:01:49  *** moli_ has quit IRC
115 2017-01-18T13:08:10  *** waxwing has quit IRC
116 2017-01-18T13:15:08  *** blueyez has joined #bitcoin-core-dev
117 2017-01-18T13:20:50  *** waxwing has joined #bitcoin-core-dev
118 2017-01-18T13:27:02  *** handlex has joined #bitcoin-core-dev
119 2017-01-18T13:38:34  *** handlex has quit IRC
120 2017-01-18T13:41:47  *** paveljanik has joined #bitcoin-core-dev
121 2017-01-18T13:41:47  *** paveljanik has joined #bitcoin-core-dev
122 2017-01-18T13:48:01  *** handlex has joined #bitcoin-core-dev
123 2017-01-18T13:49:54  *** moli_ has joined #bitcoin-core-dev
124 2017-01-18T14:03:43  *** laurentmt has joined #bitcoin-core-dev
125 2017-01-18T14:04:53  *** laurentmt has quit IRC
126 2017-01-18T14:09:11  *** rafalcpp has joined #bitcoin-core-dev
127 2017-01-18T14:15:13  <BlueMatt> cfields: yo
128 2017-01-18T14:16:13  <BlueMatt> where are we on #9212 and #9278? The fix for 9212 at https://github.com/bitcoinfibre/bitcoinfibre/commit/8e2c2cf418adb3dad1479c3f8890e0a2c8b6f709 has been in production for a while (albeit not on nodes with a ton of connection churn) so I'm reasonably confident in it, but iirc you were not a fan?
129 2017-01-18T14:16:15  <gribble> https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub
130 2017-01-18T14:16:16  <gribble> https://github.com/bitcoin/bitcoin/issues/9278 | test_bitcoin fails valgrind · Issue #9278 · bitcoin/bitcoin · GitHub
131 2017-01-18T14:18:20  <BlueMatt> for those bored, #9392 should be an easy fix
132 2017-01-18T14:18:21  <gribble> https://github.com/bitcoin/bitcoin/issues/9392 | Wallet ancestor sanity-check ignores sigops · Issue #9392 · bitcoin/bitcoin · GitHub
133 2017-01-18T14:48:03  *** aalex has joined #bitcoin-core-dev
134 2017-01-18T14:53:13  *** rafalcpp has quit IRC
135 2017-01-18T14:53:41  *** moli_ has quit IRC
136 2017-01-18T14:58:18  *** handlex has quit IRC
137 2017-01-18T15:08:38  *** Chris_Stewart_5 has quit IRC
138 2017-01-18T15:16:52  *** juscamarena has quit IRC
139 2017-01-18T15:17:03  *** blkdb has quit IRC
140 2017-01-18T15:17:13  *** blkdb has joined #bitcoin-core-dev
141 2017-01-18T15:17:22  *** berndj has quit IRC
142 2017-01-18T15:18:07  *** berndj has joined #bitcoin-core-dev
143 2017-01-18T15:18:33  *** jeremyru1in has joined #bitcoin-core-dev
144 2017-01-18T15:18:34  *** rabidus_ has joined #bitcoin-core-dev
145 2017-01-18T15:18:35  *** helo_ has joined #bitcoin-core-dev
146 2017-01-18T15:18:40  *** jeremyrubin has quit IRC
147 2017-01-18T15:18:41  *** jnewbery1 has quit IRC
148 2017-01-18T15:18:43  *** rabidus has quit IRC
149 2017-01-18T15:18:50  *** Anduck_ has joined #bitcoin-core-dev
150 2017-01-18T15:18:51  *** sipa_ has joined #bitcoin-core-dev
151 2017-01-18T15:18:58  *** kinlo_ has joined #bitcoin-core-dev
152 2017-01-18T15:18:58  *** helo has quit IRC
153 2017-01-18T15:18:58  *** kinlo has quit IRC
154 2017-01-18T15:19:11  *** kinlo_ is now known as kinlo
155 2017-01-18T15:19:22  *** paveljanik has quit IRC
156 2017-01-18T15:19:22  *** waxwing has quit IRC
157 2017-01-18T15:19:22  *** Alopex has quit IRC
158 2017-01-18T15:19:23  *** Evel-Knievel has quit IRC
159 2017-01-18T15:19:24  *** CodeShark has quit IRC
160 2017-01-18T15:19:25  *** jeremias1 has quit IRC
161 2017-01-18T15:19:25  *** cfields has quit IRC
162 2017-01-18T15:19:25  *** achow101 has quit IRC
163 2017-01-18T15:19:25  *** Anduck has quit IRC
164 2017-01-18T15:19:25  *** kanzure has quit IRC
165 2017-01-18T15:19:26  *** ensign_ has quit IRC
166 2017-01-18T15:19:26  *** sipa has quit IRC
167 2017-01-18T15:19:27  *** nsh has quit IRC
168 2017-01-18T15:19:27  *** lejitz has quit IRC
169 2017-01-18T15:19:27  *** jl2012 has quit IRC
170 2017-01-18T15:19:27  *** Taek has quit IRC
171 2017-01-18T15:20:07  *** achow101 has joined #bitcoin-core-dev
172 2017-01-18T15:22:47  *** cfields has joined #bitcoin-core-dev
173 2017-01-18T15:22:47  *** 7F1AAKHX0 has joined #bitcoin-core-dev
174 2017-01-18T15:22:47  *** paveljanik has joined #bitcoin-core-dev
175 2017-01-18T15:22:47  *** waxwing has joined #bitcoin-core-dev
176 2017-01-18T15:22:47  *** Alopex has joined #bitcoin-core-dev
177 2017-01-18T15:22:47  *** Evel-Knievel has joined #bitcoin-core-dev
178 2017-01-18T15:22:47  *** ensign_ has joined #bitcoin-core-dev
179 2017-01-18T15:22:47  *** Taek has joined #bitcoin-core-dev
180 2017-01-18T15:22:57  *** blueyez has quit IRC
181 2017-01-18T15:23:50  *** michagogo has quit IRC
182 2017-01-18T15:25:05  *** lejitz has joined #bitcoin-core-dev
183 2017-01-18T15:25:57  *** shesek has quit IRC
184 2017-01-18T15:26:08  *** cfields has quit IRC
185 2017-01-18T15:26:11  *** jl2012 has joined #bitcoin-core-dev
186 2017-01-18T15:26:23  *** cfields has joined #bitcoin-core-dev
187 2017-01-18T15:26:29  *** CodeShark has joined #bitcoin-core-dev
188 2017-01-18T15:27:32  *** nsh has joined #bitcoin-core-dev
189 2017-01-18T15:29:03  *** kanzure has joined #bitcoin-core-dev
190 2017-01-18T15:31:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
191 2017-01-18T15:31:44  *** michagogo has joined #bitcoin-core-dev
192 2017-01-18T15:32:36  *** cfields has quit IRC
193 2017-01-18T15:33:38  *** cfields has joined #bitcoin-core-dev
194 2017-01-18T15:36:50  *** blueyez has joined #bitcoin-core-dev
195 2017-01-18T15:46:30  *** moli_ has joined #bitcoin-core-dev
196 2017-01-18T16:02:07  *** laurentmt has joined #bitcoin-core-dev
197 2017-01-18T16:05:55  *** nickler has quit IRC
198 2017-01-18T16:06:03  *** nickler has joined #bitcoin-core-dev
199 2017-01-18T16:11:33  *** Anduck_ is now known as Anduck
200 2017-01-18T16:14:22  *** handlex has joined #bitcoin-core-dev
201 2017-01-18T16:15:21  *** laurentmt has quit IRC
202 2017-01-18T16:15:34  <cfields> BlueMatt: I didn't like that change at the time because 1. We weren't always disconnecting (or checking fDisconnect) as necessary at the time, and 2. It changes the "you can only send 1 version message" semantics a bit. 1. should be fixed since fedea8a14. I think your change is probably ok, but I think we should think through 2 a little.
203 2017-01-18T16:17:37  <BlueMatt> I know we also discussed moving off of the "nVersion is set means connected" to using the fSuccessfullyConnected flag again
204 2017-01-18T16:17:45  <BlueMatt> they're kinda confused and redundant atm
205 2017-01-18T16:18:39  <cfields> yea
206 2017-01-18T16:19:14  <cfields> that would be my preference, only issue there is defining "successfully connected"
207 2017-01-18T16:21:01  *** moli_ has quit IRC
208 2017-01-18T16:23:27  <cfields> BlueMatt: as a weird example, I think your change would allow for sending infinite version messages in which the addrMe portion fails to deserialize
209 2017-01-18T16:23:57  <cfields> so a peer could change their nVersion a bunch of times before locking it in
210 2017-01-18T16:24:15  <cfields> (i don't know what good that would do, but we certainly shouldn't be allowing that)
211 2017-01-18T16:24:44  <BlueMatt> I'd file that under "undefined behavior" I believe in that case we may be required to make a best effort to eat the sender's cat
212 2017-01-18T16:25:18  <BlueMatt> but short that, I'm not sure if we care that they can do that?
213 2017-01-18T16:25:32  <BlueMatt> as long as we actually gate on fSuccessfullyConnected
214 2017-01-18T16:25:53  <cfields> BlueMatt: right, that was my point. atm we don't in many places
215 2017-01-18T16:25:54  <BlueMatt> cfields: do you have time to look at that, or should I just whip something up with fSuccessfullyConnected after I finish review of one or two others?
216 2017-01-18T16:26:08  <BlueMatt> well atm we check nVersion != 0 pretty much everywhere, i think
217 2017-01-18T16:26:14  <BlueMatt> as a proxy for connectedness
218 2017-01-18T16:27:00  <cfields> BlueMatt: right, and in the above scenario, we don't consider them connected, but their nVersion is set.
219 2017-01-18T16:27:21  <BlueMatt> ok, so replace nVersion != 0 with fSuccessfullyConnected everywhere, i guess?
220 2017-01-18T16:29:07  <cfields> i think so.
221 2017-01-18T16:29:13  <BlueMatt> k
222 2017-01-18T16:29:18  <cfields> and at this point, we can remove the assert
223 2017-01-18T16:29:20  <BlueMatt> I'll do it after lunch if you havent gotten to it
224 2017-01-18T16:29:25  <BlueMatt> I'd prefer leaving it in?
225 2017-01-18T16:29:31  <BlueMatt> afaict its super easy to fix
226 2017-01-18T16:29:37  <BlueMatt> I'm incredibly confident in the above change
227 2017-01-18T16:29:48  <BlueMatt> (as its equivalent to the change I've been running for months now)
228 2017-01-18T16:30:19  <cfields> BlueMatt: point me at a node running it, let's see if i can bring it down :)
229 2017-01-18T16:31:00  <BlueMatt> the fibre nodes
230 2017-01-18T16:31:01  <BlueMatt> :p
231 2017-01-18T16:31:46  <cfields> heh
232 2017-01-18T16:31:54  *** Netmage has quit IRC
233 2017-01-18T16:32:49  *** bsm117532 has joined #bitcoin-core-dev
234 2017-01-18T16:34:02  <BlueMatt> I'll swap my public node to master soonish
235 2017-01-18T16:34:06  <BlueMatt> it gets a shitload of connection churn
236 2017-01-18T16:34:17  <BlueMatt> and fun spy nodes and shit which do batshit crazy things
237 2017-01-18T16:48:49  *** moli_ has joined #bitcoin-core-dev
238 2017-01-18T16:50:33  *** abpa has joined #bitcoin-core-dev
239 2017-01-18T16:52:08  <bitcoin-git> [bitcoin] practicalswift opened pull request #9575: [trivial] Add comment about unreachable code (master...never-executed-comment) https://github.com/bitcoin/bitcoin/pull/9575
240 2017-01-18T16:52:30  <BlueMatt> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/9461#discussion_r96680764
241 2017-01-18T16:52:53  *** BashCo_ has quit IRC
242 2017-01-18T16:53:28  *** BashCo has joined #bitcoin-core-dev
243 2017-01-18T16:58:09  *** BashCo has quit IRC
244 2017-01-18T17:01:36  <bitcoin-git> [bitcoin] practicalswift opened pull request #9576: [wallet] Remove redundant initialization (master...remove-redundant-initialization-ii) https://github.com/bitcoin/bitcoin/pull/9576
245 2017-01-18T17:11:54  *** waxwing has quit IRC
246 2017-01-18T17:12:51  *** waxwing has joined #bitcoin-core-dev
247 2017-01-18T17:15:01  *** echonaut has quit IRC
248 2017-01-18T17:15:16  *** echonaut has joined #bitcoin-core-dev
249 2017-01-18T17:26:07  <cfields> BlueMatt: ok, whipping something up on top of yours. Think I've got a full picture of it all in my head.
250 2017-01-18T17:32:53  *** kadoban has joined #bitcoin-core-dev
251 2017-01-18T17:33:49  *** BashCo has joined #bitcoin-core-dev
252 2017-01-18T17:34:23  *** waxwing has quit IRC
253 2017-01-18T17:36:45  <BlueMatt> cfields: ok, thanks, got distracted on other things
254 2017-01-18T17:46:18  *** Chris_Stewart_5 has quit IRC
255 2017-01-18T17:50:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
256 2017-01-18T17:50:50  *** waxwing has joined #bitcoin-core-dev
257 2017-01-18T17:51:12  *** jannes has quit IRC
258 2017-01-18T18:12:06  *** CubicEarth has joined #bitcoin-core-dev
259 2017-01-18T18:14:22  *** handlex has quit IRC
260 2017-01-18T18:17:37  *** isis has quit IRC
261 2017-01-18T18:19:10  *** waxwing has quit IRC
262 2017-01-18T18:33:40  *** handlex has joined #bitcoin-core-dev
263 2017-01-18T18:38:55  <BlueMatt> someone should tag #9569, #9371 and #9148 for 0.14 because they fix 0.14-tagged issues
264 2017-01-18T18:38:57  <gribble> https://github.com/bitcoin/bitcoin/issues/9569 | Setting -blocksonly sets -maxmempool to zero. by jnewbery · Pull Request #9569 · bitcoin/bitcoin · GitHub
265 2017-01-18T18:38:59  <gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub
266 2017-01-18T18:39:00  <gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub
267 2017-01-18T18:47:36  *** BitBully has joined #bitcoin-core-dev
268 2017-01-18T18:55:54  *** cryptapus has quit IRC
269 2017-01-18T18:58:20  <BlueMatt> sorry, that last one should be #9570
270 2017-01-18T18:58:21  <gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub
271 2017-01-18T19:06:17  <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/b0b57a17306a...6012967c4746
272 2017-01-18T19:06:18  <bitcoin-git> bitcoin/master 843c560 Pieter Wuille: Avoid unaligned access in crypto i/o
273 2017-01-18T19:06:19  <bitcoin-git> bitcoin/master f94f3e0 Pieter Wuille: Avoid integer overflows in scriptnum tests
274 2017-01-18T19:06:19  <bitcoin-git> bitcoin/master 6b03bfb Pieter Wuille: Fix memory leak in wallet tests
275 2017-01-18T19:06:35  <bitcoin-git> [bitcoin] laanwj closed pull request #9512: Fix various things -fsanitize complains about (master...sanitize) https://github.com/bitcoin/bitcoin/pull/9512
276 2017-01-18T19:08:32  <Chris_Stewart_5> Does some one mind merging in #9350? Pretty trivial, just fixing some documentation on tests
277 2017-01-18T19:08:34  <gribble> https://github.com/bitcoin/bitcoin/issues/9350 | [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json by Christewart · Pull Request #9350 · bitcoin/bitcoin · GitHub
278 2017-01-18T19:19:02  *** blueyez has quit IRC
279 2017-01-18T19:21:25  <morcos> wumpus: sipa: I updated #9371 in a way that I think accomplish both of our goals
280 2017-01-18T19:21:27  <gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub
281 2017-01-18T19:21:52  * BlueMatt likes it because I have future plans in the area...but will explain on the pr when I review in a minute :p
282 2017-01-18T19:29:38  *** BitBully has quit IRC
283 2017-01-18T19:32:07  *** CubicEarth has quit IRC
284 2017-01-18T19:34:50  <cfields> BlueMatt: hmm, looks like that could make your recent-tx cache significantly smarter
285 2017-01-18T19:36:55  *** blueyez has joined #bitcoin-core-dev
286 2017-01-18T19:38:07  <BlueMatt> yes, lots of ways it could be made smarter :)
287 2017-01-18T19:38:38  *** blueyez has quit IRC
288 2017-01-18T19:39:27  *** moli_ has quit IRC
289 2017-01-18T19:41:52  *** abpa has quit IRC
290 2017-01-18T19:50:05  *** abpa has joined #bitcoin-core-dev
291 2017-01-18T19:50:11  *** CubicEarth has joined #bitcoin-core-dev
292 2017-01-18T19:52:16  *** handlex has quit IRC
293 2017-01-18T19:57:20  <bitcoin-git> [bitcoin] jnewbery opened pull request #9577: Fix docstrings in qa tests (master...docstrings) https://github.com/bitcoin/bitcoin/pull/9577
294 2017-01-18T19:58:03  <BlueMatt> sipa_/wumpus: so I think the only way to fix the regression introduced in #7946 without giving up the gains it gave us is to introduce a second cs_wallet - cs_wallet_locked_before_cs_main
295 2017-01-18T19:58:06  <gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
296 2017-01-18T19:58:13  <BlueMatt> see https://github.com/bitcoin/bitcoin/pull/9570#issuecomment-273583506
297 2017-01-18T19:58:16  <BlueMatt> please dont kill me
298 2017-01-18T20:01:36  <cfields> morcos: ah, i missed your comment in the description. I guess i'm requesting choice #1 :)
299 2017-01-18T20:01:38  <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
300 2017-01-18T20:02:07  <BlueMatt> cfields: regarding SyncTransaction changes, see https://github.com/bitcoin/bitcoin/pull/9570/commits/bc4c4c66863fce718402a3f9b2da4e92c1898745
301 2017-01-18T20:02:19  <BlueMatt> I do remove the NOT_IN_BLOCK kludge ther
302 2017-01-18T20:02:19  <BlueMatt> e
303 2017-01-18T20:02:28  <BlueMatt> (but this introduces the need for a second wallet lock)
304 2017-01-18T20:02:52  <morcos> cfields: I'm trying to do the minimal required in 9371 to fix the regression though..  as it needs to be merged for 0.14...
305 2017-01-18T20:03:23  <cfields> morcos: ok, fair enough
306 2017-01-18T20:03:29  <morcos> so i don't want to do a new signal now b/c it will require thinking carefully about what should subscribe to it
307 2017-01-18T20:03:48  <morcos> but i'm fine dropping the SYNC_TRANASCTION_NOT_IN_BLOCK as BlueMatt did
308 2017-01-18T20:04:26  <cfields> ok, will look over that one too
309 2017-01-18T20:10:31  <sipa_> BlueMatt: i'm unclear about it... can you write a simple commit that does the cs_wallet_locked_before_cs_main ?
310 2017-01-18T20:10:46  <BlueMatt> sipa_: I think we can push off to 0.15, but I will do that, yes, one sec
311 2017-01-18T20:12:35  *** jtimon has quit IRC
312 2017-01-18T20:15:40  *** CubicEarth has quit IRC
313 2017-01-18T20:21:03  *** CubicEarth has joined #bitcoin-core-dev
314 2017-01-18T20:24:03  *** windsok has quit IRC
315 2017-01-18T20:29:51  *** juscamarena has joined #bitcoin-core-dev
316 2017-01-18T20:29:52  *** juscamarena_ has joined #bitcoin-core-dev
317 2017-01-18T20:30:45  *** handlex has joined #bitcoin-core-dev
318 2017-01-18T20:43:39  *** CubicEarth has quit IRC
319 2017-01-18T20:44:26  *** Victor_sueca has joined #bitcoin-core-dev
320 2017-01-18T20:47:38  *** Victorsueca has quit IRC
321 2017-01-18T20:51:13  *** windsok has joined #bitcoin-core-dev
322 2017-01-18T20:53:25  *** CubicEarth has joined #bitcoin-core-dev
323 2017-01-18T20:57:16  *** handlex has quit IRC
324 2017-01-18T21:00:01  *** CubicEarth has quit IRC
325 2017-01-18T21:07:24  *** jtimon has joined #bitcoin-core-dev
326 2017-01-18T21:07:37  <luke-jr> done with reviews I think. ping me if there's anything needed priority on before 0.14 freeze.
327 2017-01-18T21:09:06  *** CubicEarth has joined #bitcoin-core-dev
328 2017-01-18T21:13:45  *** waxwing has joined #bitcoin-core-dev
329 2017-01-18T21:15:48  *** isis has joined #bitcoin-core-dev
330 2017-01-18T21:24:11  *** wvr has quit IRC
331 2017-01-18T21:37:04  *** CubicEarth has quit IRC
332 2017-01-18T21:37:32  *** CubicEarth has joined #bitcoin-core-dev
333 2017-01-18T21:45:13  <BlueMatt> sipa_: see https://github.com/TheBlueMatt/bitcoin/commit/c99e4d107aac573e8de892d7592b04c685186e44
334 2017-01-18T21:45:57  <BlueMatt> specifically, this half-reverts #9570 to get to the behavior intended in #7946 without introducing the getbalance-etc-may-return-data-from-mid-block-processing regression
335 2017-01-18T21:45:59  <gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub
336 2017-01-18T21:46:01  <gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
337 2017-01-18T21:57:56  *** cryptapus_afk is now known as cryptapus
338 2017-01-18T22:04:40  <BlueMatt> someone wanna kick https://travis-ci.org/bitcoin/bitcoin/builds/193151086 ? looks like it failed due to travis timeout because it built dependancies and not because it failed
339 2017-01-18T22:15:37  *** moli_ has joined #bitcoin-core-dev
340 2017-01-18T22:27:17  *** bsm117532 has quit IRC
341 2017-01-18T22:31:20  <BlueMatt> https://github.com/bitcoin/bitcoin/blob/master/src/txmempool.cpp#L555 <-- that is wrong...100 block reorg and it could blow up (with the checkmempool debug instrumentation enabled)
342 2017-01-18T22:32:11  *** bsm117532 has joined #bitcoin-core-dev
343 2017-01-18T22:34:00  *** bsm1175322 has joined #bitcoin-core-dev
344 2017-01-18T22:35:27  *** bsm1175322 has quit IRC
345 2017-01-18T22:36:57  *** bsm117532 has quit IRC
346 2017-01-18T22:37:45  *** bsm117532 has joined #bitcoin-core-dev
347 2017-01-18T22:44:35  *** chjj has quit IRC
348 2017-01-18T22:55:26  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9578: Add missing mempool lock for CalculateMemPoolAncestors (master...2017-01-fix-missing-wallet-mempool-lock) https://github.com/bitcoin/bitcoin/pull/9578
349 2017-01-18T22:59:59  *** Guyver2 has quit IRC
350 2017-01-18T23:00:05  *** CubicEarth has quit IRC
351 2017-01-18T23:03:27  *** cryptapus is now known as cryptapus_afk
352 2017-01-18T23:08:30  *** face has quit IRC
353 2017-01-18T23:08:47  *** face has joined #bitcoin-core-dev
354 2017-01-18T23:10:24  <cfields> BlueMatt: ok, i've been staring at this for most of the day and i'm reasonably satisfied now. I'm good with your change with 2 tweaks
355 2017-01-18T23:11:13  <cfields> 1. deserialize the whole thing locally. Same change you made for nVersion, let's go ahead and do that for everything. That way we don't end up in a weird state if something throws
356 2017-01-18T23:11:43  *** CubicEarth has joined #bitcoin-core-dev
357 2017-01-18T23:11:49  <cfields> and 2. just a quick reordering that moves the assignment into CNode up a bit, and sets nVersion/fSuccessfullyConnected last.
358 2017-01-18T23:12:42  *** vidjogamer has joined #bitcoin-core-dev
359 2017-01-18T23:16:59  <cfields> BlueMatt: something like https://github.com/theuni/bitcoin/commit/ed60b005fa0b61ab4454e075e6c7d9a54e2c24a0 on top of yours
360 2017-01-18T23:20:40  *** LeMiner has quit IRC
361 2017-01-18T23:24:35  *** jtimon has quit IRC
362 2017-01-18T23:24:35  *** jl2012 has quit IRC
363 2017-01-18T23:24:35  *** lejitz has quit IRC
364 2017-01-18T23:24:37  *** atroxes has quit IRC
365 2017-01-18T23:24:55  *** jtimon has joined #bitcoin-core-dev
366 2017-01-18T23:24:56  *** jl2012 has joined #bitcoin-core-dev
367 2017-01-18T23:24:56  *** lejitz has joined #bitcoin-core-dev
368 2017-01-18T23:24:56  *** atroxes has joined #bitcoin-core-dev
369 2017-01-18T23:29:36  *** chjj has joined #bitcoin-core-dev
370 2017-01-18T23:45:40  *** CubicEarth has quit IRC
371 2017-01-18T23:47:30  *** chjj has quit IRC