1 2017-01-27T00:10:08  *** lightningbot has joined #bitcoin-core-dev
  2 2017-01-27T00:13:18  <jtimon> another question about gitian, why are there signed and unsigned builds for win and osx in https://github.com/bitcoin-core/gitian.sigs ? (according to the guide it seems I should build and sign the unsigned ones)
  3 2017-01-27T00:13:51  <sipa> jtimon: because the signed ones require a key that is not public
  4 2017-01-27T00:14:11  <sipa> so people can build the unsigned one, compare results, then the person with the key can produce the detached signatures
  5 2017-01-27T00:14:26  <sipa> and then people can build the signed one from the earlier unsigned result plus downloaded detached signature
  6 2017-01-27T00:15:42  <gmaxwell> I am proud to work with people who come up with such slick procedures. :)
  7 2017-01-27T00:16:43  <jtimon> why do the signed ones require a key that's not public?
  8 2017-01-27T00:17:37  <gmaxwell> jtimon: signed in this case refers to the windows and apple code signing keys.
  9 2017-01-27T00:17:47  <gmaxwell> which are used to prevent ugly warning boxes on those OSes.
 10 2017-01-27T00:17:58  <gmaxwell> to anyone who pays the piper. :P
 11 2017-01-27T00:18:02  <jtimon> ohh, right
 12 2017-01-27T00:20:37  <jtimon> I'm having problems building osx, I think I did all well, https://0bin.net/paste/U+Sqgot+Xk0VO-kL#cQl5R4xNHgCBRNxC5IoHZd7aW-dPJKTNO2ghEPVm0rz
 13 2017-01-27T00:21:20  <sipa> jtimon: you don't have the MacOSX SDK
 14 2017-01-27T00:21:25  <sipa> tar: MacOSX10.11.sdk.tar.gz: Cannot stat: No such file or directory
 15 2017-01-27T00:22:14  <jtimon> oh, I thought it would download it by itself or something, I see
 16 2017-01-27T00:22:52  <sipa> no, it can't, license issues
 17 2017-01-27T00:23:10  <sipa> you need to register for an mac developer account, i think
 18 2017-01-27T00:23:37  <jtimon> I see, thanks again
 19 2017-01-27T00:29:02  *** aguycalled has quit IRC
 20 2017-01-27T00:29:50  *** AaronvanW has quit IRC
 21 2017-01-27T00:30:07  *** aguycalled has joined #bitcoin-core-dev
 22 2017-01-27T00:34:09  *** AaronvanW has joined #bitcoin-core-dev
 23 2017-01-27T00:34:29  *** aguycalled has quit IRC
 24 2017-01-27T00:38:40  *** AaronvanW has quit IRC
 25 2017-01-27T00:49:55  *** echonaut2 has quit IRC
 26 2017-01-27T00:50:07  *** echonaut has joined #bitcoin-core-dev
 27 2017-01-27T00:50:37  *** belcher has quit IRC
 28 2017-01-27T00:54:30  <michagogo> Yep
 29 2017-01-27T00:54:43  <michagogo> You need to log into developer.apple.com
 30 2017-01-27T00:54:57  <michagogo> (You don't need the $99 membership, a free account is enough)
 31 2017-01-27T00:55:27  <michagogo> Then you need to download Xcode, and pull out the SDK directory from within that
 32 2017-01-27T00:55:52  <michagogo> Unfortunately that can only be done (as of the last I heard) on a Mac
 33 2017-01-27T00:57:46  <luke-jr> michagogo: I posted some doc to the git repo with non-Mac instructions IIRC
 34 2017-01-27T00:58:07  <michagogo> Oh, really?
 35 2017-01-27T00:58:10  * michagogo looks
 36 2017-01-27T00:58:46  <sipa> luke-jr: is it included in the bitcoin repo?
 37 2017-01-27T00:58:49  <sipa> +core
 38 2017-01-27T00:59:08  *** abpa has quit IRC
 39 2017-01-27T00:59:10  <luke-jr> https://github.com/bitcoin/bitcoin/blob/master/doc/README_osx.md
 40 2017-01-27T00:59:12  <luke-jr> sipa: yes ^
 41 2017-01-27T00:59:22  <luke-jr> "Alternatively, you can use 7zip and SleuthKit to extract the files one by one. The script contrib/macdeploy/extract-osx-sdk.sh automates this. First ensure the dmg file is in the current directory, and then run the script. You may wish to delete the intermediate 5.hfs file and MacOSX10.11.sdk (the directory) when you've confirmed the extraction succeeded." …
 42 2017-01-27T00:59:59  <michagogo> Ah, yes
 43 2017-01-27T01:00:00  <michagogo> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/extract-osx-sdk.sh
 44 2017-01-27T01:00:03  <michagogo> Nice!
 45 2017-01-27T01:01:33  <michagogo> August?
 46 2017-01-27T01:01:34  <sipa> luke-jr: ok, thanks
 47 2017-01-27T01:01:40  <michagogo> Wow, I've been out of the loop for a long time.
 48 2017-01-27T01:01:47  <sipa> luke-jr: i remember you finding this, but i wasn't aware it actually got pred
 49 2017-01-27T01:04:18  *** belcher has joined #bitcoin-core-dev
 50 2017-01-27T01:08:44  <bitcoin-git> [bitcoin] luke-jr opened pull request #9642: [Hardfork] Safe block size limit (master...bip-blksize) https://github.com/bitcoin/bitcoin/pull/9642
 51 2017-01-27T01:38:50  *** arubi has quit IRC
 52 2017-01-27T01:39:12  *** arubi has joined #bitcoin-core-dev
 53 2017-01-27T01:57:30  *** Ylbam has quit IRC
 54 2017-01-27T02:35:37  *** AaronvanW has joined #bitcoin-core-dev
 55 2017-01-27T02:40:09  *** AaronvanW has quit IRC
 56 2017-01-27T03:05:43  *** buddhaghosa has quit IRC
 57 2017-01-27T03:36:50  *** AaronvanW has joined #bitcoin-core-dev
 58 2017-01-27T03:41:39  *** AaronvanW has quit IRC
 59 2017-01-27T04:02:24  *** kyletorpey has joined #bitcoin-core-dev
 60 2017-01-27T04:02:39  *** chris200_ has joined #bitcoin-core-dev
 61 2017-01-27T04:05:29  *** chris2000 has quit IRC
 62 2017-01-27T04:21:23  *** PaulCape_ has quit IRC
 63 2017-01-27T04:34:44  *** PaulCapestany has joined #bitcoin-core-dev
 64 2017-01-27T04:37:34  *** AaronvanW has joined #bitcoin-core-dev
 65 2017-01-27T04:43:05  *** AaronvanW has quit IRC
 66 2017-01-27T04:44:50  *** shesek has quit IRC
 67 2017-01-27T04:59:59  *** chris2000 has joined #bitcoin-core-dev
 68 2017-01-27T05:00:07  *** dermoth has quit IRC
 69 2017-01-27T05:01:06  *** dermoth has joined #bitcoin-core-dev
 70 2017-01-27T05:02:47  *** chris200_ has quit IRC
 71 2017-01-27T05:39:03  *** neha___ has quit IRC
 72 2017-01-27T05:39:36  *** AaronvanW has joined #bitcoin-core-dev
 73 2017-01-27T05:40:56  *** chjj has quit IRC
 74 2017-01-27T05:43:16  *** moli_ has quit IRC
 75 2017-01-27T05:43:20  *** mol has joined #bitcoin-core-dev
 76 2017-01-27T05:43:49  *** AaronvanW has quit IRC
 77 2017-01-27T05:44:53  *** cannon-c has joined #bitcoin-core-dev
 78 2017-01-27T05:52:17  *** paveljanik has quit IRC
 79 2017-01-27T05:53:06  *** Cheeseo has joined #bitcoin-core-dev
 80 2017-01-27T05:55:43  *** RoyceX has quit IRC
 81 2017-01-27T05:56:56  *** paveljanik has joined #bitcoin-core-dev
 82 2017-01-27T05:56:56  *** paveljanik has joined #bitcoin-core-dev
 83 2017-01-27T06:01:05  *** paveljanik has quit IRC
 84 2017-01-27T06:19:56  *** Saucery has joined #bitcoin-core-dev
 85 2017-01-27T06:40:15  *** AaronvanW has joined #bitcoin-core-dev
 86 2017-01-27T06:44:50  *** AaronvanW has quit IRC
 87 2017-01-27T06:53:03  *** Ylbam has joined #bitcoin-core-dev
 88 2017-01-27T07:00:50  *** chjj has joined #bitcoin-core-dev
 89 2017-01-27T07:02:35  *** kyletorpey has quit IRC
 90 2017-01-27T07:20:39  *** aguycalled has joined #bitcoin-core-dev
 91 2017-01-27T07:26:16  *** zxzzt has quit IRC
 92 2017-01-27T07:26:20  *** sdaftuar has quit IRC
 93 2017-01-27T07:26:29  *** morcos has quit IRC
 94 2017-01-27T07:27:10  *** ryanofsky has quit IRC
 95 2017-01-27T07:28:15  *** zxzzt has joined #bitcoin-core-dev
 96 2017-01-27T07:28:15  *** sdaftuar has joined #bitcoin-core-dev
 97 2017-01-27T07:28:16  *** sdaftuar has joined #bitcoin-core-dev
 98 2017-01-27T07:28:34  *** morcos has joined #bitcoin-core-dev
 99 2017-01-27T07:32:55  *** testtesttest has quit IRC
100 2017-01-27T07:39:42  *** jtimon has quit IRC
101 2017-01-27T07:40:41  *** ryanofsky has joined #bitcoin-core-dev
102 2017-01-27T07:40:58  *** AaronvanW has joined #bitcoin-core-dev
103 2017-01-27T07:45:29  *** AaronvanW has quit IRC
104 2017-01-27T07:54:40  *** kadoban has quit IRC
105 2017-01-27T08:02:20  *** BashCo has quit IRC
106 2017-01-27T08:18:25  <bitcoin-git> [bitcoin] kallewoof opened pull request #9643: [refactor] Remove using namespace <xxx> from wallet/ & util* (master...no-using-namespace-wallet-util) https://github.com/bitcoin/bitcoin/pull/9643
107 2017-01-27T08:22:48  *** windsok has quit IRC
108 2017-01-27T08:26:21  *** paveljanik has joined #bitcoin-core-dev
109 2017-01-27T08:26:22  *** paveljanik has joined #bitcoin-core-dev
110 2017-01-27T08:30:44  *** BashCo has joined #bitcoin-core-dev
111 2017-01-27T08:31:22  *** aguycalled has quit IRC
112 2017-01-27T08:32:47  *** Saucery has quit IRC
113 2017-01-27T08:45:29  *** aguycalled has joined #bitcoin-core-dev
114 2017-01-27T08:52:15  *** windsok has joined #bitcoin-core-dev
115 2017-01-27T09:05:28  *** Guyver2 has joined #bitcoin-core-dev
116 2017-01-27T09:09:55  <bitcoin-git> [bitcoin] kallewoof opened pull request #9644: [refactor] Remove using namespace <xxx> from src/ (master...no-using-namespace-src) https://github.com/bitcoin/bitcoin/pull/9644
117 2017-01-27T09:23:04  <Eliel_> 25
118 2017-01-27T09:25:26  *** jannes has joined #bitcoin-core-dev
119 2017-01-27T09:36:16  *** e4xit has quit IRC
120 2017-01-27T09:36:40  *** isle2983 has quit IRC
121 2017-01-27T09:36:50  *** e4xit has joined #bitcoin-core-dev
122 2017-01-27T09:36:54  *** cannon-c is now known as cannon-c_AFK
123 2017-01-27T09:54:17  *** AaronvanW has joined #bitcoin-core-dev
124 2017-01-27T09:54:17  *** AaronvanW has joined #bitcoin-core-dev
125 2017-01-27T10:02:35  *** cannon-c_AFK is now known as cannon-c
126 2017-01-27T10:17:14  *** Guyver2 has quit IRC
127 2017-01-27T10:31:28  *** rgrant has joined #bitcoin-core-dev
128 2017-01-27T10:34:51  <rgrant> can someone point me at the function that backfills local blockchain blocks to include witness data if user upgrades to a segwit full node after segwit activation?
129 2017-01-27T10:53:43  <rgrant> it looks like BLOCK_OPT_WITNESS stores some activation data for the block, but it also looks like this is not queried to see if backfill is necessary.  i could also use some help tracking down what happens if a segwit-capable node only finds itself connected to non-segwit nodes while receiving a block.
130 2017-01-27T11:10:11  *** frabrunelle has quit IRC
131 2017-01-27T11:13:37  *** laurentmt has joined #bitcoin-core-dev
132 2017-01-27T11:18:01  *** laurentmt has quit IRC
133 2017-01-27T11:18:20  *** frabrunelle has joined #bitcoin-core-dev
134 2017-01-27T11:22:43  *** paveljanik has quit IRC
135 2017-01-27T11:30:48  *** gradient_ has joined #bitcoin-core-dev
136 2017-01-27T11:32:32  *** gradient_ has quit IRC
137 2017-01-27T11:33:10  *** gradientskier has joined #bitcoin-core-dev
138 2017-01-27T11:36:23  *** gradientskier has quit IRC
139 2017-01-27T11:42:45  *** waxwing has quit IRC
140 2017-01-27T11:54:00  *** rafalcpp has quit IRC
141 2017-01-27T12:13:09  *** isle2983 has joined #bitcoin-core-dev
142 2017-01-27T12:27:14  *** cannon-c has quit IRC
143 2017-01-27T12:34:16  *** BashCo has quit IRC
144 2017-01-27T12:34:53  *** BashCo has joined #bitcoin-core-dev
145 2017-01-27T12:41:48  *** aguycalled has quit IRC
146 2017-01-27T12:56:52  *** face has quit IRC
147 2017-01-27T13:03:00  *** waxwing has joined #bitcoin-core-dev
148 2017-01-27T13:17:57  <sdaftuar> rgrant: see RewindBlockIndex, in validation.cpp (assuming you're looking at master)
149 2017-01-27T13:27:59  <sdaftuar> rgrant: after segwit activates, segwit-capable nodes will only attempt to download blocks from segwit-capable peers (which is why 0.13.1 introduced outbound peering logic that would specifically seek out segwit-capable peers)
150 2017-01-27T13:36:31  *** JackH has quit IRC
151 2017-01-27T13:47:43  <rgrant> sdaftuar: thx!  it does use BLOCK_OPT_WITNESS, too.  not sure how i missed that in my search.
152 2017-01-27T14:40:05  *** windsok has quit IRC
153 2017-01-27T14:44:25  *** aguycalled has joined #bitcoin-core-dev
154 2017-01-27T14:59:01  *** d9b4bef9 has quit IRC
155 2017-01-27T15:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
156 2017-01-27T15:08:15  *** windsok has joined #bitcoin-core-dev
157 2017-01-27T15:15:00  *** oven has quit IRC
158 2017-01-27T15:16:59  *** oven has joined #bitcoin-core-dev
159 2017-01-27T15:18:00  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b4d2673b775...d9e4d1d9fbd9
160 2017-01-27T15:18:00  <bitcoin-git> bitcoin/master 04b8773 Jonas Schnelli: [Qt] fix transaction details output-index to reflect vout index
161 2017-01-27T15:18:01  <bitcoin-git> bitcoin/master d9e4d1d Wladimir J. van der Laan: Merge #9637: [Qt] fix transaction details output-index to reflect vout index...
162 2017-01-27T15:18:20  <bitcoin-git> [bitcoin] laanwj closed pull request #9637: [Qt] fix transaction details output-index to reflect vout index (master...2017/01/qt_vout) https://github.com/bitcoin/bitcoin/pull/9637
163 2017-01-27T15:24:10  *** rgrant has left #bitcoin-core-dev
164 2017-01-27T15:28:04  *** kadoban has joined #bitcoin-core-dev
165 2017-01-27T15:33:39  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d9e4d1d9fbd9...a7ea2f8fdbe9
166 2017-01-27T15:33:39  <bitcoin-git> bitcoin/master fab035f MarcoFalke: qa: Actually test assertions in pruning.py...
167 2017-01-27T15:33:40  <bitcoin-git> bitcoin/master a7ea2f8 Wladimir J. van der Laan: Merge #9638: qa: Actually test assertions in pruning.py...
168 2017-01-27T15:33:56  <bitcoin-git> [bitcoin] laanwj closed pull request #9638: qa: Actually test assertions in pruning.py (master...Mf1701-qaPruning_try) https://github.com/bitcoin/bitcoin/pull/9638
169 2017-01-27T16:41:14  *** neha__ has joined #bitcoin-core-dev
170 2017-01-27T16:46:09  *** jtimon has joined #bitcoin-core-dev
171 2017-01-27T16:46:25  *** aguycall_ has joined #bitcoin-core-dev
172 2017-01-27T16:46:52  *** aguycalled has quit IRC
173 2017-01-27T16:52:06  *** BashCo has quit IRC
174 2017-01-27T16:55:10  *** jtimon has quit IRC
175 2017-01-27T16:57:22  *** windsok has quit IRC
176 2017-01-27T16:57:23  *** abpa has joined #bitcoin-core-dev
177 2017-01-27T17:19:03  *** BashCo has joined #bitcoin-core-dev
178 2017-01-27T17:28:10  *** windsok has joined #bitcoin-core-dev
179 2017-01-27T17:51:32  *** jtimon has joined #bitcoin-core-dev
180 2017-01-27T18:27:19  *** oven has quit IRC
181 2017-01-27T19:09:22  *** instagibbs has joined #bitcoin-core-dev
182 2017-01-27T20:00:27  *** Guyver2 has joined #bitcoin-core-dev
183 2017-01-27T20:07:03  <luke-jr> is anyone else working on #9493? (I wish github let us self-assign stuff..)
184 2017-01-27T20:07:05  <gribble> https://github.com/bitcoin/bitcoin/issues/9493 | event_set_mem_functions is not available on all libevents · Issue #9493 · bitcoin/bitcoin · GitHub
185 2017-01-27T20:11:44  *** waxwing has quit IRC
186 2017-01-27T20:16:04  *** Kexkey has joined #bitcoin-core-dev
187 2017-01-27T20:19:47  <BlueMatt> luke-jr: looks like not? its either you or cfields probably
188 2017-01-27T20:19:53  *** norotartagen has quit IRC
189 2017-01-27T20:20:22  <cfields> luke-jr: last i looked you had a fix for it?
190 2017-01-27T20:20:56  *** norotartagen has joined #bitcoin-core-dev
191 2017-01-27T20:21:33  <cfields> yea, i assumed that define was all it took. If there's more to it, i'm happy to take a look
192 2017-01-27T20:32:10  <luke-jr> it's probably not difficult, just didn't want to step on any toes
193 2017-01-27T20:33:12  <luke-jr> just gotta figure out how to indicate a skipped test I guess
194 2017-01-27T20:47:46  *** Kexkey has quit IRC
195 2017-01-27T20:51:40  *** AaronvanW has quit IRC
196 2017-01-27T20:51:44  *** aguycall_ is now known as aguycalled
197 2017-01-27T20:52:16  *** AaronvanW has joined #bitcoin-core-dev
198 2017-01-27T20:56:29  *** AaronvanW has quit IRC
199 2017-01-27T21:04:49  *** abpa has quit IRC
200 2017-01-27T21:17:36  *** Kexkey_ has joined #bitcoin-core-dev
201 2017-01-27T21:21:03  *** Guyver2 has quit IRC
202 2017-01-27T21:23:05  *** Guyver2 has joined #bitcoin-core-dev
203 2017-01-27T21:36:57  *** waxwing has joined #bitcoin-core-dev
204 2017-01-27T21:48:10  *** Kexkey_ has quit IRC
205 2017-01-27T21:52:46  *** AaronvanW has joined #bitcoin-core-dev
206 2017-01-27T21:52:46  *** AaronvanW has joined #bitcoin-core-dev
207 2017-01-27T21:57:09  *** AaronvanW has quit IRC
208 2017-01-27T21:58:44  *** aguycalled has quit IRC
209 2017-01-27T21:59:11  *** aguycalled has joined #bitcoin-core-dev
210 2017-01-27T22:07:47  <BlueMatt> cfields: what do you want to do about hSocket?
211 2017-01-27T22:08:01  <cfields> BlueMatt: races, you mean?
212 2017-01-27T22:08:04  <BlueMatt> yes
213 2017-01-27T22:08:12  <BlueMatt> well "races"
214 2017-01-27T22:08:16  <BlueMatt> not that they actually are, but....
215 2017-01-27T22:08:29  <cfields> well, concurrent access
216 2017-01-27T22:09:29  <cfields> BlueMatt: going forward, it'll all be contained to one thread. So again, it's just a matter of what we do for 0.14
217 2017-01-27T22:09:44  <BlueMatt> it will?
218 2017-01-27T22:09:50  <cfields> sec, taking a look. iirc it's mostly just disconnection that's problematic?
219 2017-01-27T22:09:51  <BlueMatt> oh, you mean CloseSocketDisconnect will be? yea, ok
220 2017-01-27T22:10:05  <BlueMatt> its entirely only CloseSocketDisconnect thats problematic, iirc
221 2017-01-27T22:11:22  <cfields> oh, and optimistic sends
222 2017-01-27T22:12:33  *** aguycalled has quit IRC
223 2017-01-27T22:13:13  *** aguycalled has joined #bitcoin-core-dev
224 2017-01-27T22:13:45  <cfields> BlueMatt: with my async refactors, CloseSocketDisconnect always happens on the sockethandler thread, the others just set fDisconnect
225 2017-01-27T22:14:07  <BlueMatt> yea, ok, that sounds like what we /should/ do....but what about 0.14?
226 2017-01-27T22:14:08  <cfields> i wonder if we could do a simplified version of that for 0.14
227 2017-01-27T22:14:14  <BlueMatt> I havent looked, can we do that easily in 14?
228 2017-01-27T22:15:38  <cfields> uhmm, just looking at it quickly, it seems so
229 2017-01-27T22:16:11  <gmaxwell> if the behavior involved doesn't block, add a lock and move on.
230 2017-01-27T22:16:44  <BlueMatt> gmaxwell: might as well fix it right, though
231 2017-01-27T22:18:34  <cfields> BlueMatt: i think we'll still need a lock for the optimistic send :(
232 2017-01-27T22:18:46  <BlueMatt> oh valid point, yea, likely
233 2017-01-27T22:19:03  <BlueMatt> has anyone ever figured out how much optimistic send saves us?
234 2017-01-27T22:19:17  <BlueMatt> like, notifying the other thread and having it do the send is like a few extra syscalls
235 2017-01-27T22:19:18  <BlueMatt> so what
236 2017-01-27T22:21:08  <cfields> BlueMatt: i think the only downside is you can end up at the tail of the sendqueue for that loop as opposed to sending immediately
237 2017-01-27T22:21:27  <BlueMatt> "meh" ?
238 2017-01-27T22:21:32  <cfields> but with the locks cleaned up now, i doubt there's much consequence there
239 2017-01-27T22:21:45  <BlueMatt> oh, true, without the lock cleanups that would've been hell
240 2017-01-27T22:21:54  <cfields> BlueMatt: well i think that could've been substantial before, with a long hold on the send lock
241 2017-01-27T22:21:57  <BlueMatt> but, alright, lets call that a 0.15 optimization and just add a lock for 0.14?
242 2017-01-27T22:22:32  <cfields> BlueMatt: yes, afraid so :(
243 2017-01-27T22:22:42  <BlueMatt> ok, well shouldnt be a big deal
244 2017-01-27T22:23:07  <BlueMatt> if your send() is blocking, you have bigger problems :p
245 2017-01-27T22:23:33  <cfields> heh
246 2017-01-27T22:23:52  <cfields> true i suppose. Scope can basically be limited to send/recv/close, right?
247 2017-01-27T22:24:04  <BlueMatt> I'd hope so?
248 2017-01-27T22:24:16  <BlueMatt> I havent looked in a while
249 2017-01-27T22:24:49  <cfields> mm, worth looking at select/fd_set's safety guarantees
250 2017-01-27T22:25:17  <cfields> BlueMatt: heh, hint taken. I'll work up a patch for discussion.
251 2017-01-27T22:25:24  <BlueMatt> are we close()ing in CloseSocketDisconnect, or just disconnect()?
252 2017-01-27T22:25:29  <BlueMatt> sorry, wasnt a hint, just saying
253 2017-01-27T22:26:23  <BlueMatt> oh, hum, we are
254 2017-01-27T22:26:24  <BlueMatt> yea, that sucks
255 2017-01-27T22:26:32  <cfields> close/closesocket
256 2017-01-27T22:28:00  <BlueMatt> cfields: ouch, yea, then maybe we do need the full patch now, then
257 2017-01-27T22:28:14  <BlueMatt> to avoid calling CloseSocketDisconnect on any thread but ThreadSocketHandler
258 2017-01-27T22:28:47  <BlueMatt> hum...orrrr...no, because select will just return and we'll still get the lock when we recv or send?
259 2017-01-27T22:28:57  <BlueMatt> i mean i guess it should be fine, but might prefer not to?
260 2017-01-27T22:29:46  *** aguycall_ has joined #bitcoin-core-dev
261 2017-01-27T22:29:48  *** aguycalled has quit IRC
262 2017-01-27T22:40:14  <cfields> BlueMatt: just for the sake of covering all angles... this concurrent access isn't new, right? much more likely maybe, but i'm pretty sure this has always been the case
263 2017-01-27T22:41:59  <BlueMatt> yes, I believe this is very, very, very old
264 2017-01-27T22:42:11  <BlueMatt> but havent gone back to make sure
265 2017-01-27T23:04:19  *** molz_ has joined #bitcoin-core-dev
266 2017-01-27T23:06:41  *** mol has quit IRC
267 2017-01-27T23:09:33  *** molz_ has quit IRC
268 2017-01-27T23:09:55  *** molz_ has joined #bitcoin-core-dev
269 2017-01-27T23:10:27  *** AaronvanW has joined #bitcoin-core-dev
270 2017-01-27T23:14:13  *** gradientskier has joined #bitcoin-core-dev
271 2017-01-27T23:16:49  *** AaronvanW has quit IRC
272 2017-01-27T23:52:26  *** Guyver2 has quit IRC
273 2017-01-27T23:59:26  *** aguycall_ has quit IRC