1 2017-02-06T00:16:02  *** Alina-malina has quit IRC
  2 2017-02-06T00:17:11  *** Alina-malina has joined #bitcoin-core-dev
  3 2017-02-06T00:33:30  *** justan0theruser has joined #bitcoin-core-dev
  4 2017-02-06T00:35:49  *** justanotheruser has quit IRC
  5 2017-02-06T00:39:59  *** blkdb has quit IRC
  6 2017-02-06T00:42:56  *** profall has joined #bitcoin-core-dev
  7 2017-02-06T00:48:24  *** AaronvanW has quit IRC
  8 2017-02-06T01:18:29  *** Alina-malina has quit IRC
  9 2017-02-06T01:20:13  *** Alina-malina has joined #bitcoin-core-dev
 10 2017-02-06T01:26:08  *** Alina-malina has quit IRC
 11 2017-02-06T01:26:33  *** MarcoFalke has joined #bitcoin-core-dev
 12 2017-02-06T01:27:51  *** Alina-malina has joined #bitcoin-core-dev
 13 2017-02-06T01:38:05  *** MarcoFalke has quit IRC
 14 2017-02-06T02:07:26  *** instagibbs has quit IRC
 15 2017-02-06T02:07:32  *** Ylbam has quit IRC
 16 2017-02-06T02:30:26  *** ossifrage has joined #bitcoin-core-dev
 17 2017-02-06T02:31:26  <ossifrage> FYI, the usage for 'dumpwallet' really should say that the filename is an output file not an input file. I thought it was an 'input file' and you can imagine what happened...
 18 2017-02-06T02:39:31  <sipa> where is it called 'input file' ?
 19 2017-02-06T02:44:41  *** justan0theruser has quit IRC
 20 2017-02-06T02:45:23  *** justanotheruser has joined #bitcoin-core-dev
 21 2017-02-06T02:47:28  *** jtimon has quit IRC
 22 2017-02-06T02:55:18  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9693: Prevent integer overflow in ReadVarInt. (master...varint_maxsize) https://github.com/bitcoin/bitcoin/pull/9693
 23 2017-02-06T03:02:06  <gmaxwell> morcos: did you see https://github.com/bitcoin/bitcoin/issues/9645  ? sounds like a good point... and probably easy to do.
 24 2017-02-06T03:32:56  *** jamezz has quit IRC
 25 2017-02-06T03:41:32  *** Creeper has joined #bitcoin-core-dev
 26 2017-02-06T03:52:02  *** Creeper is now known as jamezz
 27 2017-02-06T03:59:55  *** justanotheruser has quit IRC
 28 2017-02-06T04:00:01  *** justan0theruser has joined #bitcoin-core-dev
 29 2017-02-06T04:36:30  <jl2012> MarcoFalke_: it works. Thanks
 30 2017-02-06T05:39:10  *** BashCo_ has joined #bitcoin-core-dev
 31 2017-02-06T05:41:35  *** BashCo has quit IRC
 32 2017-02-06T06:02:56  *** dcousens_ has quit IRC
 33 2017-02-06T06:09:36  *** dcousens_ has joined #bitcoin-core-dev
 34 2017-02-06T06:19:06  *** Alina-malina has quit IRC
 35 2017-02-06T06:19:07  *** Alina-malina has joined #bitcoin-core-dev
 36 2017-02-06T06:24:32  *** lclc has joined #bitcoin-core-dev
 37 2017-02-06T06:46:33  *** Ylbam has joined #bitcoin-core-dev
 38 2017-02-06T07:46:03  <wumpus> luke-jr: how would you propose to do that? allow, say, either an argument amount=1.23 or an argument amount_int=123000000?
 39 2017-02-06T07:48:20  <luke-jr> wumpus: I would propose that whenever named params are used, amounts are always satoshis.
 40 2017-02-06T07:48:21  <sipa> i suggest we at some point introduce a global amount_unit, which modifies the units all amounts are accepted and shown in
 41 2017-02-06T07:48:42  <sipa> which can be done at any time, in a backward compatible way
 42 2017-02-06T07:48:43  <wumpus> sipa: I had a pull open for that at some point
 43 2017-02-06T07:48:49  <sipa> ah!
 44 2017-02-06T07:49:26  <luke-jr> there should be no existing code using named params right now, so there's no need to be "compatible" with fractional numbers
 45 2017-02-06T07:49:29  <wumpus> there were even four options - satoshis as number, satoshis as string, BTC as number, BTC as string
 46 2017-02-06T07:49:57  <wumpus> it could be set using a configuration option, everything using AMountFrom* and *ToAmount would use this
 47 2017-02-06T07:50:31  <sipa> wumpus: well we already support both strings and numbers everywhere, no?
 48 2017-02-06T07:50:39  <wumpus> hardly any interest, though, so eventually rotted and closed. I think despite being a favourite discussion topic for developers, very people are actually concerned about these units on the RPC interface
 49 2017-02-06T07:51:07  <sipa> agre
 50 2017-02-06T07:51:10  <wumpus> arguably interoperability is best by just allowing one representation
 51 2017-02-06T07:51:15  <wumpus> and yes, strings are allowed as inputs
 52 2017-02-06T07:51:27  <wumpus> it would apply to both inputs and outputs though
 53 2017-02-06T07:51:47  <wumpus> in any case I think this is abit of a non-issue
 54 2017-02-06T07:52:17  <luke-jr> so NACK for 0.14? :x
 55 2017-02-06T07:52:29  <wumpus> heh :)
 56 2017-02-06T07:52:49  *** paveljanik has quit IRC
 57 2017-02-06T07:52:51  <sipa> i think it's way too late to change that for 0.14, and given that we already support strings as amount... i'm not sure it's necessary at all
 58 2017-02-06T07:53:09  <wumpus> agree
 59 2017-02-06T07:53:27  <luke-jr> sipa: only reason to push for it in 0.14 is to avoid having to ever support BTC amounts in named-params mode for backwards compat
 60 2017-02-06T07:53:41  <wumpus> let's please not conflate named-param with any other interface change
 61 2017-02-06T07:53:46  <sipa> luke-jr: well we'll always have to support it in non-named-params anyway
 62 2017-02-06T07:54:07  <luke-jr> wumpus: ok, then my idea is controversial and not worth spending more time on
 63 2017-02-06T07:54:36  <wumpus> I mean imagine it from the user point of view, you decide to change your RPC binding to use named arguments, and suddenly you have to use different units!
 64 2017-02-06T07:54:46  <luke-jr> seems logical to me ☺
 65 2017-02-06T08:07:22  *** BashCo_ has quit IRC
 66 2017-02-06T08:07:23  *** Evel-Laptop has joined #bitcoin-core-dev
 67 2017-02-06T08:08:01  *** BashCo has joined #bitcoin-core-dev
 68 2017-02-06T08:12:58  *** BashCo has quit IRC
 69 2017-02-06T08:19:00  <bitcoin-git> [bitcoin] theuni opened pull request #9695: net: fix a few races. Credit @TheBlueMatt (master...net-atomic) https://github.com/bitcoin/bitcoin/pull/9695
 70 2017-02-06T08:21:33  <cfields> blah, i really need to stop using "race" and "concurrent access" interchangeably
 71 2017-02-06T08:22:38  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/923dc447eaa8...fc67cd22f83f
 72 2017-02-06T08:22:38  <bitcoin-git> bitcoin/master ac719c9 Gregory Maxwell: Init ECC context for test_bitcoin_fuzzy....
 73 2017-02-06T08:22:39  <bitcoin-git> bitcoin/master fc67cd2 Wladimir J. van der Laan: Merge #9691: Init ECC context for test_bitcoin_fuzzy....
 74 2017-02-06T08:22:58  <bitcoin-git> [bitcoin] laanwj closed pull request #9691: Init ECC context for test_bitcoin_fuzzy. (master...fuzzy_initecc) https://github.com/bitcoin/bitcoin/pull/9691
 75 2017-02-06T08:30:40  *** BashCo has joined #bitcoin-core-dev
 76 2017-02-06T08:58:38  *** isle2983 has quit IRC
 77 2017-02-06T09:02:01  *** d9b4bef9 has quit IRC
 78 2017-02-06T09:05:07  *** d9b4bef9 has joined #bitcoin-core-dev
 79 2017-02-06T09:13:05  *** jannes has joined #bitcoin-core-dev
 80 2017-02-06T09:16:59  *** windsok has quit IRC
 81 2017-02-06T09:22:11  *** AaronvanW has joined #bitcoin-core-dev
 82 2017-02-06T09:24:58  *** Evel-Laptop has quit IRC
 83 2017-02-06T09:53:22  *** JackH has joined #bitcoin-core-dev
 84 2017-02-06T10:14:19  *** windsok has joined #bitcoin-core-dev
 85 2017-02-06T10:19:40  *** MarcoFalke has joined #bitcoin-core-dev
 86 2017-02-06T10:55:45  *** MarcoFalke has quit IRC
 87 2017-02-06T11:38:38  *** Soligor_ has joined #bitcoin-core-dev
 88 2017-02-06T11:39:53  *** Soligor has quit IRC
 89 2017-02-06T11:41:37  *** Soligor_ is now known as Soligor
 90 2017-02-06T11:44:18  *** Soligor has quit IRC
 91 2017-02-06T11:46:07  *** lclc has quit IRC
 92 2017-02-06T11:49:20  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc67cd22f83f...8d6447ecf79c
 93 2017-02-06T11:49:20  <bitcoin-git> bitcoin/master 4ec057d Russell Yanofsky: [wallet] Set correct metadata on bumpfee wallet transactions...
 94 2017-02-06T11:49:21  <bitcoin-git> bitcoin/master 8d6447e Wladimir J. van der Laan: Merge #9673: Set correct metadata on bumpfee wallet transactions...
 95 2017-02-06T11:49:40  <bitcoin-git> [bitcoin] laanwj closed pull request #9673: Set correct metadata on bumpfee wallet transactions (master...pr/bumpfee-meta) https://github.com/bitcoin/bitcoin/pull/9673
 96 2017-02-06T11:50:09  *** Guyver2 has joined #bitcoin-core-dev
 97 2017-02-06T12:12:50  *** niska has quit IRC
 98 2017-02-06T12:17:44  *** niska has joined #bitcoin-core-dev
 99 2017-02-06T12:23:28  *** dcousens_ has quit IRC
100 2017-02-06T12:24:12  *** lclc has joined #bitcoin-core-dev
101 2017-02-06T12:25:07  *** dcousens has joined #bitcoin-core-dev
102 2017-02-06T12:35:09  *** laurentmt has joined #bitcoin-core-dev
103 2017-02-06T12:35:33  *** laurentmt has quit IRC
104 2017-02-06T13:16:47  *** isle2983 has joined #bitcoin-core-dev
105 2017-02-06T13:20:31  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8d6447ecf79c...986ba005eda6
106 2017-02-06T13:20:31  <bitcoin-git> bitcoin/master 5f62e3e practicalswift: Fix typos
107 2017-02-06T13:20:32  <bitcoin-git> bitcoin/master 986ba00 Wladimir J. van der Laan: Merge #9651: Fix typos...
108 2017-02-06T13:20:50  <bitcoin-git> [bitcoin] laanwj closed pull request #9651: Fix typos (master...typos) https://github.com/bitcoin/bitcoin/pull/9651
109 2017-02-06T13:35:17  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/986ba005eda6...09e0c28f8566
110 2017-02-06T13:35:18  <bitcoin-git> bitcoin/master d45955f Jorge Timón: Net: CConnman: Make some methods const
111 2017-02-06T13:35:18  <bitcoin-git> bitcoin/master fc7f2ff Jorge Timón: Net: Make CNetMsgMaker more const
112 2017-02-06T13:35:19  <bitcoin-git> bitcoin/master 0729102 Jorge Timón: Net: pass interruptMsgProc as const where possible
113 2017-02-06T13:35:31  <bitcoin-git> [bitcoin] laanwj closed pull request #9659: Net: Turn some methods and params/variables const (master...0.14-net-more-const) https://github.com/bitcoin/bitcoin/pull/9659
114 2017-02-06T13:44:04  *** andytoshi has left #bitcoin-core-dev
115 2017-02-06T13:45:30  *** waxwing has quit IRC
116 2017-02-06T13:51:46  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/09e0c28f8566...40f7e27d25ff
117 2017-02-06T13:51:47  <bitcoin-git> bitcoin/master 7ea0ad5 Matt Corallo: Fail in DecodeHexTx if there is extra data at the end
118 2017-02-06T13:51:47  <bitcoin-git> bitcoin/master 922bea9 Matt Corallo: Better handle invalid parameters to signrawtransaction...
119 2017-02-06T13:51:48  <bitcoin-git> bitcoin/master 691710a Matt Corallo: [qa] Test that decoderawtransaction throws with extra data appended
120 2017-02-06T13:52:02  <bitcoin-git> [bitcoin] laanwj closed pull request #9650: Better handle invalid parameters to signrawtransaction (master...2017-01-better-signraw) https://github.com/bitcoin/bitcoin/pull/9650
121 2017-02-06T13:58:24  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/40f7e27d25ff...870cd2b58aba
122 2017-02-06T13:58:24  <bitcoin-git> bitcoin/master 39c77b0 Russell Yanofsky: Add documentation for CWalletTx::fFromMe member.
123 2017-02-06T13:58:25  <bitcoin-git> bitcoin/master 870cd2b Wladimir J. van der Laan: Merge #9378: [trivial] Add documentation for CWalletTx::fFromMe member....
124 2017-02-06T13:58:35  <bitcoin-git> [bitcoin] laanwj closed pull request #9378: [trivial] Add documentation for CWalletTx::fFromMe member. (master...pr/fromme-doc) https://github.com/bitcoin/bitcoin/pull/9378
125 2017-02-06T13:58:50  *** Soligor has joined #bitcoin-core-dev
126 2017-02-06T14:00:36  *** waxwing has joined #bitcoin-core-dev
127 2017-02-06T14:04:00  *** jtimon has joined #bitcoin-core-dev
128 2017-02-06T14:14:24  *** dcousens has quit IRC
129 2017-02-06T14:17:27  <achow101> how likely is the rc1 tag going to happen today?
130 2017-02-06T14:17:53  <bitcoin-git> [bitcoin] practicalswift opened pull request #9696: [trivial] Fix recently introduced typos in comments (master...fix-recently-introduced-typos) https://github.com/bitcoin/bitcoin/pull/9696
131 2017-02-06T14:29:09  *** jnewbery has joined #bitcoin-core-dev
132 2017-02-06T14:33:36  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9697: [Qt] simple fee bumper with user verification (master...2017/02/qt_bumpfee) https://github.com/bitcoin/bitcoin/pull/9697
133 2017-02-06T14:43:35  *** Chris_Stewart_5 has quit IRC
134 2017-02-06T14:52:27  *** instagibbs has joined #bitcoin-core-dev
135 2017-02-06T15:14:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/870cd2b58aba...02464da5e4aa
136 2017-02-06T15:14:47  <bitcoin-git> bitcoin/master d63ff62 Patrick Strateman: Make nWalletDBUpdated atomic to avoid a potential race.
137 2017-02-06T15:14:47  <bitcoin-git> bitcoin/master 02464da Wladimir J. van der Laan: Merge #9227: Make nWalletDBUpdated atomic to avoid a potential race....
138 2017-02-06T15:14:56  <bitcoin-git> [bitcoin] laanwj closed pull request #9227: Make nWalletDBUpdated atomic to avoid a potential race. (master...2016-11-26-nwalletdbupdated-race) https://github.com/bitcoin/bitcoin/pull/9227
139 2017-02-06T15:36:46  *** bsm117532 has quit IRC
140 2017-02-06T15:37:19  *** bsm117532 has joined #bitcoin-core-dev
141 2017-02-06T16:06:15  *** MarcoFalke_ has joined #bitcoin-core-dev
142 2017-02-06T16:17:46  *** lclc has quit IRC
143 2017-02-06T16:47:03  *** abpa has joined #bitcoin-core-dev
144 2017-02-06T17:02:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
145 2017-02-06T17:05:53  *** abpa has quit IRC
146 2017-02-06T17:07:19  *** abpa has joined #bitcoin-core-dev
147 2017-02-06T17:10:50  *** chjj has quit IRC
148 2017-02-06T17:35:49  *** BashCo has quit IRC
149 2017-02-06T18:16:52  *** BashCo has joined #bitcoin-core-dev
150 2017-02-06T19:06:19  <BlueMatt> hum...if you get a "Work queue depth exceeded" error from RPC bitcoin-cli will give you a "couldn't parse reply from server"
151 2017-02-06T19:37:52  *** chris2000 has joined #bitcoin-core-dev
152 2017-02-06T19:58:23  <bitcoin-git> [bitcoin] theuni opened pull request #9698: net: fix socket close race (master...fix-socket-disconnect2) https://github.com/bitcoin/bitcoin/pull/9698
153 2017-02-06T20:13:42  *** jtimon has quit IRC
154 2017-02-06T20:16:05  *** snowant has joined #bitcoin-core-dev
155 2017-02-06T20:25:57  <bitcoin-git> [bitcoin] droark opened pull request #9699: Remove contrib/debian/patches subdirectory (master...removedebpatches) https://github.com/bitcoin/bitcoin/pull/9699
156 2017-02-06T20:26:33  *** chris2000 has quit IRC
157 2017-02-06T20:26:56  *** moli_ has quit IRC
158 2017-02-06T20:32:29  *** protomar has joined #bitcoin-core-dev
159 2017-02-06T20:34:23  *** chjj has joined #bitcoin-core-dev
160 2017-02-06T20:42:34  *** chjj has quit IRC
161 2017-02-06T20:42:44  <arubi> what's "insecure" about the old binaries on bitcoin.org?  should fine to run on regtest right?
162 2017-02-06T20:43:13  <arubi> er, meaning : https://bitcoin.org/bin/insecure/
163 2017-02-06T20:43:32  <luke-jr> arubi: likely different on a case-by-case basis
164 2017-02-06T20:43:57  <luke-jr> https://bitcoin.org/bin/insecure/README.txt
165 2017-02-06T20:44:17  <arubi> ah I see, failed at rtfm.  thanks
166 2017-02-06T20:45:02  <arubi> yea that's what I figured, just the known issues throught the releases, cheers
167 2017-02-06T20:53:16  *** snowant has quit IRC
168 2017-02-06T20:56:53  *** chjj has joined #bitcoin-core-dev
169 2017-02-06T20:58:44  *** moli_ has joined #bitcoin-core-dev
170 2017-02-06T21:00:43  <bitcoin-git> [bitcoin] sdaftuar opened pull request #9700: Cache segwit signature hash components inside CTransaction to optimize validation performance (master...2017-02-segwit-hash-cache-2) https://github.com/bitcoin/bitcoin/pull/9700
171 2017-02-06T21:03:47  <arubi> I guess the 0.8.6 binary doesn't have -regtest (other nodes refusing connection and the switch is missing from -help), 0e4b31755 has it and says 0.8.2 beta in the readme, I guess it didn't become part of the binary until later :)
172 2017-02-06T21:04:48  <luke-jr> arubi: regtest isn't a network.. you shouldn't ever try to connect it to other nodes (besides in a test environment)
173 2017-02-06T21:05:30  <arubi> luke-jr, oh I'm well aware.  these are all local, running a local regtest network
174 2017-02-06T21:05:52  <luke-jr> I wouldn't be surprised if it was incompatible with different versions
175 2017-02-06T21:06:25  <arubi> 0.9.5+ worked, thought about trying the older versions
176 2017-02-06T21:07:35  <arubi> oh I guess only 0.10.0+ worked, I didn't try 0.9.5 yet.
177 2017-02-06T21:14:23  <arubi> 'connect() to 127.3.0.2:18444 failed after select(): Connection refused' :(, wonder if it's just issues in my config..
178 2017-02-06T21:14:42  <arubi> oh lol
179 2017-02-06T21:15:05  <arubi> yea, gotta star the daemons first..
180 2017-02-06T21:17:59  <arubi> anyway, for completeness, I can get 0.9.0 to connect, but not 0.8.6.  I guess I'm missing some milestone where regtest was actually released in 0.9.0 :)
181 2017-02-06T21:24:01  *** Giszmo has joined #bitcoin-core-dev
182 2017-02-06T21:32:28  *** Alina-malina has quit IRC
183 2017-02-06T21:33:05  <BlueMatt> sipa: yo
184 2017-02-06T21:33:26  <sipa> yo
185 2017-02-06T21:33:34  <BlueMatt> sipa: i think you're missing my point - the precalculations will be done in net/wallet, not that they need the data
186 2017-02-06T21:33:43  <sipa> that feels wrong
187 2017-02-06T21:33:52  <BlueMatt> because you want the data available during signing (it doesnt matter much, but its nice), and also in orphans
188 2017-02-06T21:34:06  <sipa> why do you need signature data for orphans?
189 2017-02-06T21:34:11  <sipa> you can't verify it
190 2017-02-06T21:34:14  <BlueMatt> so doing it transparently in the tx object is the cleanest way by far
191 2017-02-06T21:34:20  <sipa> i strongly disagree
192 2017-02-06T21:34:23  <BlueMatt> so that its available when you reconstruct the block
193 2017-02-06T21:34:27  <sipa> this is 1 step forward and a dozen backward
194 2017-02-06T21:34:50  <BlueMatt> the whole point of the patch is to have the data precalculated when the txn are floating around from various sources (orphan, mempool, recent rejects, etc)
195 2017-02-06T21:34:57  <BlueMatt> so that when they go into the block its great
196 2017-02-06T21:35:18  <BlueMatt> and its a serious win
197 2017-02-06T21:35:43  <sipa> there should be a way to keep it restricted to validation...
198 2017-02-06T21:35:52  <sipa> we're not putting wallet specific data in CTransaction either
199 2017-02-06T21:35:57  <BlueMatt> if you insist on CTransaction being a "dumb storage" object, then sdaftuar had a previous version that made CTransactionRef a "transaction and extra data" reference object
200 2017-02-06T21:36:15  <BlueMatt> its transaction-specific data...you need the sighashes when signing, too
201 2017-02-06T21:36:21  <BlueMatt> so the wallet does care about this data, technically
202 2017-02-06T21:36:39  <sipa> i mean we're not putting vfSpent or hashBlock in CTransaction
203 2017-02-06T21:36:40  <BlueMatt> and I would heasitate to call any hashes of the tx "validation-specific"
204 2017-02-06T21:36:52  <BlueMatt> sure, because those require otuside data
205 2017-02-06T21:36:54  <sipa> they're part of the consensus rules, and up
206 2017-02-06T21:36:57  <BlueMatt> this is all data which is entirely self-contained
207 2017-02-06T21:36:58  <sipa> not part of serialization
208 2017-02-06T21:37:10  <BlueMatt> nor is hash, would you like to not cache that?
209 2017-02-06T21:38:03  <sipa> well i don't like the hash there either
210 2017-02-06T21:38:11  <BlueMatt> where the hell else would you put it?
211 2017-02-06T21:38:25  <BlueMatt> its the "in-memory serialization"
212 2017-02-06T21:38:30  <BlueMatt> sure its duplicative, but its hella useful
213 2017-02-06T21:38:35  <BlueMatt> and so is witness hashes
214 2017-02-06T21:39:07  <BlueMatt> at some point this is, by far, the cleanest way to get a massive win, so I really disagree that it shouldn't be done
215 2017-02-06T21:39:47  <BlueMatt> if you insist on a "data storage class" we can do a wrapper around CTransaction with extra caches (like sdaftuar's original with CTransactionRef becomming a class)
216 2017-02-06T21:39:54  <sipa> i understand it may be needed now for a performance improvement
217 2017-02-06T21:39:59  <BlueMatt> this would also pull shared_ptr out of primitives/
218 2017-02-06T21:40:07  <sipa> but you seem to be arguing that it's overall an improvement and should be the goal
219 2017-02-06T21:40:13  <BlueMatt> I am, indeed
220 2017-02-06T21:40:16  *** sipa has left #bitcoin-core-dev
221 2017-02-06T21:40:33  <BlueMatt> ............
222 2017-02-06T21:47:34  *** Alina-malina has joined #bitcoin-core-dev
223 2017-02-06T21:48:29  <gmaxwell> Will http://www.codesynthesis.com/~boris/blog/2012/04/25/shared-ptr-aliasing-constructor/ let us have a wrapping object without an additional allocation overhead?
224 2017-02-06T21:50:13  <BlueMatt> doesnt seem like it?
225 2017-02-06T21:50:22  <cfields> gmaxwell: heh, i've looked at those a bunch for this purpose, but never seemed to come up with anything helpful
226 2017-02-06T21:50:37  <cfields> it sure _seems_ like it could help, though
227 2017-02-06T21:51:58  <BlueMatt> gmaxwell: if we were to turn CTransactionRef (or equivalent) into a primitive+cache object, we dont need to take extra overhead, though, I believe
228 2017-02-06T21:52:38  <BlueMatt> gmaxwell: it can be class CTransactionAndCachedValidationInfo { CTransaction tx; ValidationInfoCache cache; }; typedef CTransactionRef std::shared_ptr<CTransactionAndCachedValidationInfo>;
229 2017-02-06T21:53:04  <BlueMatt> it gets yucky when you ask what a block contains, though
230 2017-02-06T21:53:20  <BlueMatt> you end up with like templating CBlock to let it work with either type of transaction object.....
231 2017-02-06T21:55:24  *** Alina-malina has quit IRC
232 2017-02-06T21:55:48  <BlueMatt> (which is arguably not a layer violation and really doesnt blow up too much, since you pretty much always want the additional validation info in it - only exception is reading block from disk for sending to peer, which could be done via some other function)
233 2017-02-06T21:56:22  <BlueMatt> but is so damn ugly that I'd heasitate to ever recommend it
234 2017-02-06T22:02:13  *** Alina-malina has joined #bitcoin-core-dev
235 2017-02-06T22:12:44  *** jnewbery has quit IRC
236 2017-02-06T22:35:05  *** protomar has quit IRC
237 2017-02-06T22:35:34  *** jtimon has joined #bitcoin-core-dev
238 2017-02-06T23:05:05  *** Giszmo has quit IRC
239 2017-02-06T23:20:32  *** Giszmo has joined #bitcoin-core-dev
240 2017-02-06T23:27:38  *** rubensayshi_ has joined #bitcoin-core-dev
241 2017-02-06T23:27:47  *** wallet42_ has joined #bitcoin-core-dev
242 2017-02-06T23:28:03  *** mariorz_ has joined #bitcoin-core-dev
243 2017-02-06T23:28:06  *** trotski2000_ has joined #bitcoin-core-dev
244 2017-02-06T23:28:19  *** michagogo_ has joined #bitcoin-core-dev
245 2017-02-06T23:29:20  *** ratoder2 has joined #bitcoin-core-dev
246 2017-02-06T23:29:28  *** ratoder2 is now known as ratoder3
247 2017-02-06T23:29:45  *** wump has joined #bitcoin-core-dev
248 2017-02-06T23:30:00  *** neha has joined #bitcoin-core-dev
249 2017-02-06T23:31:15  *** aspect__ has joined #bitcoin-core-dev
250 2017-02-06T23:31:31  *** ratoder3 is now known as ratoder2
251 2017-02-06T23:32:40  *** mappum_ has joined #bitcoin-core-dev
252 2017-02-06T23:33:08  *** warren_ has joined #bitcoin-core-dev
253 2017-02-06T23:33:14  *** da2ce7_ has joined #bitcoin-core-dev
254 2017-02-06T23:34:26  *** waxwing has quit IRC
255 2017-02-06T23:34:26  *** F0sea has quit IRC
256 2017-02-06T23:34:26  *** nanotube has quit IRC
257 2017-02-06T23:34:26  *** ratoder has quit IRC
258 2017-02-06T23:34:26  *** wumpus has quit IRC
259 2017-02-06T23:34:26  *** neha__ has quit IRC
260 2017-02-06T23:34:27  *** baldur has quit IRC
261 2017-02-06T23:34:27  *** cdecker has quit IRC
262 2017-02-06T23:34:27  *** da2ce7 has quit IRC
263 2017-02-06T23:34:27  *** michagogo has quit IRC
264 2017-02-06T23:34:28  *** aspect_ has quit IRC
265 2017-02-06T23:34:28  *** mappum has quit IRC
266 2017-02-06T23:34:28  *** warren has quit IRC
267 2017-02-06T23:34:28  *** rubensayshi has quit IRC
268 2017-02-06T23:34:28  *** mariorz has quit IRC
269 2017-02-06T23:34:28  *** trotski2000 has quit IRC
270 2017-02-06T23:34:28  *** wallet42 has quit IRC
271 2017-02-06T23:35:10  *** F0sea has joined #bitcoin-core-dev
272 2017-02-06T23:35:10  *** cdecker has joined #bitcoin-core-dev
273 2017-02-06T23:35:17  *** rubensayshi_ is now known as rubensayshi
274 2017-02-06T23:35:22  *** aspect__ is now known as aspect_
275 2017-02-06T23:36:22  *** wallet42_ is now known as wallet42
276 2017-02-06T23:37:51  *** mappum_ is now known as mappum
277 2017-02-06T23:38:15  *** mariorz_ is now known as mariorz
278 2017-02-06T23:40:31  *** michagogo_ is now known as michagogo
279 2017-02-06T23:40:46  *** nanotube has joined #bitcoin-core-dev
280 2017-02-06T23:41:15  *** waxwing has joined #bitcoin-core-dev
281 2017-02-06T23:41:40  *** baldur has joined #bitcoin-core-dev
282 2017-02-06T23:51:59  *** ratoder2 is now known as ratoder
283 2017-02-06T23:56:10  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9701: Make bumpfee tests less fragile (master...pr/bumpfee-fragile) https://github.com/bitcoin/bitcoin/pull/9701
284 2017-02-06T23:58:47  *** mrkent has joined #bitcoin-core-dev