1 2017-02-22T01:00:33  *** abpa has quit IRC
  2 2017-02-22T01:33:35  *** AaronvanW has quit IRC
  3 2017-02-22T01:50:11  *** amiller has quit IRC
  4 2017-02-22T01:51:49  *** jtimon has quit IRC
  5 2017-02-22T01:58:48  *** jtimon has joined #bitcoin-core-dev
  6 2017-02-22T02:16:52  *** jtimon has quit IRC
  7 2017-02-22T02:44:00  *** Ylbam has quit IRC
  8 2017-02-22T02:47:04  *** goksinen_ has quit IRC
  9 2017-02-22T02:59:52  *** goksinen has joined #bitcoin-core-dev
 10 2017-02-22T03:07:29  *** goksinen has quit IRC
 11 2017-02-22T03:07:38  *** goksinen has joined #bitcoin-core-dev
 12 2017-02-22T03:08:05  *** Guest47306 has joined #bitcoin-core-dev
 13 2017-02-22T03:08:18  *** Guest47306 has joined #bitcoin-core-dev
 14 2017-02-22T03:08:18  *** Guest47306 is now known as amiller
 15 2017-02-22T03:36:56  *** Victor_sueca has joined #bitcoin-core-dev
 16 2017-02-22T03:39:16  *** Victorsueca has quit IRC
 17 2017-02-22T03:45:51  *** dodomojo has joined #bitcoin-core-dev
 18 2017-02-22T04:00:04  *** dermoth has quit IRC
 19 2017-02-22T04:00:49  *** dermoth has joined #bitcoin-core-dev
 20 2017-02-22T04:35:36  *** dodomojo has quit IRC
 21 2017-02-22T04:35:57  *** shesek has quit IRC
 22 2017-02-22T04:39:31  *** Giszmo has quit IRC
 23 2017-02-22T04:39:54  *** Giszmo has joined #bitcoin-core-dev
 24 2017-02-22T04:52:12  *** chris200_ has joined #bitcoin-core-dev
 25 2017-02-22T04:55:25  *** chris2000 has quit IRC
 26 2017-02-22T04:57:37  *** dgenr8 has quit IRC
 27 2017-02-22T04:58:03  *** dgenr8 has joined #bitcoin-core-dev
 28 2017-02-22T04:58:34  *** Giszmo has quit IRC
 29 2017-02-22T05:00:04  *** dermoth has quit IRC
 30 2017-02-22T05:00:55  *** dermoth has joined #bitcoin-core-dev
 31 2017-02-22T05:22:01  *** d9b4bef9 has quit IRC
 32 2017-02-22T05:23:09  *** d9b4bef9 has joined #bitcoin-core-dev
 33 2017-02-22T06:10:07  *** asoltys has joined #bitcoin-core-dev
 34 2017-02-22T06:24:29  <bitcoin-git> [bitcoin] benma opened pull request #9822: Refactor: Split part of AppInitMain() into a new function (master...appinitmain) https://github.com/bitcoin/bitcoin/pull/9822
 35 2017-02-22T06:45:33  *** city22 has joined #bitcoin-core-dev
 36 2017-02-22T06:59:08  *** chjj has quit IRC
 37 2017-02-22T07:01:36  *** paveljanik has quit IRC
 38 2017-02-22T07:06:39  *** yahtoo has joined #bitcoin-core-dev
 39 2017-02-22T07:09:39  <wumpus> jonasschnelli, others: any idea about OS-specific random API on OSX? I heard about "SecRandom" (https://opensource.apple.com/source/Security/Security-55471/sec/Security/SecRandom.h), is that what should be used?
 40 2017-02-22T07:09:53  <jonasschnelli> wumpus: Yes. That's simple
 41 2017-02-22T07:10:24  <wumpus> will try to add it to #9821. So SecRandomRef can be left NULL?
 42 2017-02-22T07:10:26  <gribble> https://github.com/bitcoin/bitcoin/issues/9821 | util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD by laanwj · Pull Request #9821 · bitcoin/bitcoin · GitHub
 43 2017-02-22T07:11:07  <jonasschnelli> Let me look at it...
 44 2017-02-22T07:11:15  <jonasschnelli> I know there are other projects that already did this
 45 2017-02-22T07:13:03  <sipa> that's a psuedo random number
 46 2017-02-22T07:13:12  <sipa> i believe we're looking for a pseudo random number!
 47 2017-02-22T07:13:51  <wumpus> kSecRandomDefault
 48 2017-02-22T07:14:32  <sipa> defining a new name for NULL through an external symbol?
 49 2017-02-22T07:14:34  <wumpus> very random, just happens to have all the bits turned off every time
 50 2017-02-22T07:14:46  <sipa> that's pretty inefficient!
 51 2017-02-22T07:14:46  <jonasschnelli> @function SecRandomCopyBytes
 52 2017-02-22T07:14:47  <jonasschnelli> 	@abstract Return count random bytes in *bytes, allocated by the caller.
 53 2017-02-22T07:14:47  <jonasschnelli>          It is critical to check the return value for error
 54 2017-02-22T07:15:08  <jonasschnelli> "Generates an array of cryptographically secure random bytes"
 55 2017-02-22T07:15:16  <jonasschnelli> IMO SecRandomCopyBytes is CPRNG
 56 2017-02-22T07:15:31  <wumpus> it's inefficient, though that is not really our worry here, this is the slow path
 57 2017-02-22T07:15:52  *** whphhg has quit IRC
 58 2017-02-22T07:16:04  <jonasschnelli> I think this is the way to go: "if (SecRandomCopyBytes(kSecRandomDefault, entropy.length, entropy.mutableBytes) != 0) return nil;"
 59 2017-02-22T07:16:09  <wumpus> jonasschnelli: I guess MacOSX also supports the sysctl(ARND), inherited from NetBSD?
 60 2017-02-22T07:16:55  <jonasschnelli> Yes. I think so. But not sure which makes more sense. Maybe add entropy from both?
 61 2017-02-22T07:17:07  *** lclc has joined #bitcoin-core-dev
 62 2017-02-22T07:17:50  <jonasschnelli> I quickly check what apples recommends (that doesn't say it the solution we should go()
 63 2017-02-22T07:18:08  <wumpus> I'd like to keep the GetOSRandom abtraction simple - just get random from the OS, whatever a good option is for that OS. Combining shouldn't make sense there
 64 2017-02-22T07:19:51  <wumpus> an alternative way of going about this would be to check all randomness sources that are available , and somehow call all of them every time and combine them, but I'm not sure whether that's voodoo coding or sensible paranoia
 65 2017-02-22T07:20:29  <wumpus> and note we already combine the output with randomness from other sources in an outer function
 66 2017-02-22T07:22:51  <jonasschnelli> wumpus: has the idea with using fortuna for mixing all sorts of entropy died?
 67 2017-02-22T07:23:03  <wumpus> using the MacOSX API doesn't mean anything scary like using objective c++ does it? all the examples I see have NSLog and NSMutableString etc in them
 68 2017-02-22T07:23:13  <jonasschnelli> No. It's pure C
 69 2017-02-22T07:23:31  <jonasschnelli> You need to link against the Security.frameowkr
 70 2017-02-22T07:23:36  <jonasschnelli> T
 71 2017-02-22T07:23:43  <jonasschnelli> We already link against other framework...
 72 2017-02-22T07:23:50  <wumpus> jonasschnelli: I don't know, but I don't see a reason to combine multiple random streams coming from the OS and portrayed as cryptographic APIs
 73 2017-02-22T07:24:20  *** whphhg has joined #bitcoin-core-dev
 74 2017-02-22T07:24:26  <jonasschnelli> wumpus: I think the only reason could be if you are enough paranoid. :)
 75 2017-02-22T07:24:54  <jonasschnelli> What speaks against using /dev/(u)random on OSX? Concurrency? It would be the simplest approach?
 76 2017-02-22T07:25:07  <jonasschnelli> Apples states that /dev/random is CPRNG
 77 2017-02-22T07:25:11  <wumpus> we already use /dev/urandom
 78 2017-02-22T07:25:30  <jonasschnelli> wumpus: So SecRandomCopyBytes would give additional entrtopy?
 79 2017-02-22T07:25:38  <wumpus> and that will remain the fallback if nothing else is availalbe, however in sandboxes it's not always available
 80 2017-02-22T07:26:06  <wumpus> that was what prompted this, not 'we don't trust /dev/urandom'
 81 2017-02-22T07:27:50  <wumpus> e.g. user created containers and chroots won't have the /dev/urandom device, some sandboxes (such as cluodabi/capsicum) don' t have file access at all (not that we can support those at the moment in bitcoin core). Direct system calls are the new way to get randomness from the OS.
 82 2017-02-22T07:29:06  <jonasschnelli> Apples says "This function reads from /dev/random to obtain an array of cryptographically-secure random bytes" about SecRandomCopyBytes
 83 2017-02-22T07:29:18  <wumpus> lol. okay, so it won't help :)
 84 2017-02-22T07:29:19  <jonasschnelli> Not sure what internal fallback mechanisms are provided
 85 2017-02-22T07:29:29  <jonasschnelli> I think that part is closed source
 86 2017-02-22T07:29:30  <wumpus> thanks for looking that up, that's very useful information
 87 2017-02-22T07:30:06  <jonasschnelli> Heres to code: https://opensource.apple.com/source/Security/Security-55179.11/sec/Security/SecFramework.c
 88 2017-02-22T07:30:56  <jonasschnelli> And yes. It reads from /dev/random :)
 89 2017-02-22T07:31:17  <jonasschnelli> If that's not available, it returns 0.
 90 2017-02-22T07:31:21  <wumpus> yup. So going through all the trouble to link another framework and calling it isn't worth it
 91 2017-02-22T07:31:27  <jonasschnelli> Yes.
 92 2017-02-22T07:33:01  <cfields> er, i don't think we link in frameworks for bitcoind do we?
 93 2017-02-22T07:33:11  <cfields> (seems the point's moot anyway now, though)
 94 2017-02-22T07:34:30  *** yahtoo has quit IRC
 95 2017-02-22T07:35:35  *** Victor_sueca is now known as Victorsueca
 96 2017-02-22T07:36:32  *** whphhg has quit IRC
 97 2017-02-22T07:36:45  <jonasschnelli> cfields: Good point. I guess only for the Qt parts.
 98 2017-02-22T07:36:57  <wumpus> a different thing I noticed is that our code is opening and closing the /dev/urandom device every call to GetOSRand. Nothing wrong with that in itself, though reserving a fd for it would mean it's always available.
 99 2017-02-22T07:38:02  <jonasschnelli> I wonder if it would make more sense to have the random
100 2017-02-22T07:38:06  <jonasschnelli> ...
101 2017-02-22T07:38:13  <jonasschnelli> the randomness thins abstracted into a library...
102 2017-02-22T07:38:27  <jonasschnelli> I think there are lots of other application that also wants to deal with this without openssl
103 2017-02-22T07:38:33  <wumpus> well it's abstracted to random.o now :-)
104 2017-02-22T07:38:48  *** jnewbery has quit IRC
105 2017-02-22T07:38:59  <wumpus> which is sort of a one-file randomness library. Idon't think it depends on any bitcoin specific things
106 2017-02-22T07:39:01  <jonasschnelli> Hah. indeed. What are the dependencies?
107 2017-02-22T07:39:03  <luke-jr> jonasschnelli: gnutls? :P
108 2017-02-22T07:39:12  * jonasschnelli stabs luke-jr
109 2017-02-22T07:40:57  <jonasschnelli> my testnet dns seeder will be down for a couple of hours (moving location)
110 2017-02-22T07:44:35  *** BashCo has quit IRC
111 2017-02-22T07:45:05  <wumpus> ok, thanks for letting us know
112 2017-02-22T07:57:50  <jonasschnelli> Does anyone know how I can avoid sudo password prompt in gbuild using LXC? I have added /usr/bin/lxc-start and execute to sudoers (nopassword)
113 2017-02-22T07:59:10  <Victorsueca> sudo -i ?
114 2017-02-22T07:59:34  <luke-jr> jonasschnelli: check syslog
115 2017-02-22T07:59:35  <wumpus> to have passwordless sudo you need to edit sudoers, you can either make all sudo use passwordless or specific commands
116 2017-02-22T07:59:55  <wumpus> I don't know the syntax by heart, though. Always have to look at up (and fail at leat three times at it)
117 2017-02-22T07:59:56  <jonasschnelli> But why does gbuild require root?
118 2017-02-22T07:59:58  <luke-jr> also, some distros have non-root LXC now
119 2017-02-22T08:00:09  <luke-jr> because LXC historically has required root
120 2017-02-22T08:00:18  <wumpus> jonasschnelli: spinning up a fully featured LXC container requires root
121 2017-02-22T08:00:32  <jonasschnelli> okay... I see.
122 2017-02-22T08:00:46  <wumpus> this is because the user creating the LXC container will be root in the container (without capabilities), which can be somewhat dangerous if there are security bugs in the kernel
123 2017-02-22T08:01:01  <luke-jr> (which there have been)
124 2017-02-22T08:01:29  <wumpus> and indeed as luke-jr says it is possible on more recent kernels to create a user LXC, but these have a few restrictions which I'm fairly sure we can't cope with right now
125 2017-02-22T08:01:36  <jonasschnelli> it's not just lxc-start and lxc-execute that requires root?
126 2017-02-22T08:01:59  <wumpus> it's just those no
127 2017-02-22T08:02:06  <wumpus> no->two
128 2017-02-22T08:02:10  <wumpus> maybe only lxc-execute
129 2017-02-22T08:02:38  <wumpus> not sure. I think there's an example of editing your sudoers file to allow this in gitian-building?
130 2017-02-22T08:02:49  <jonasschnelli> Yes. I have set those... still got the sudo promot
131 2017-02-22T08:03:34  <jonasschnelli> Ah! Wrong machine... damit
132 2017-02-22T08:03:51  <jonasschnelli> Can we have different shell background colors per host?!
133 2017-02-22T08:04:01  <wumpus> jonasschnelli: I have different prompt colors per host
134 2017-02-22T08:04:11  <wumpus> (even a script to randomly generate them :-)
135 2017-02-22T08:04:17  <jonasschnelli> wumpus: That is very clever... I need to do this as well...
136 2017-02-22T08:04:54  *** BashCo has joined #bitcoin-core-dev
137 2017-02-22T08:05:52  <wumpus> https://gist.github.com/laanwj/3c8c116fc763a149842a07070ca4d6cd
138 2017-02-22T08:06:08  <jonasschnelli> wumpus: thanks!
139 2017-02-22T08:06:47  <wumpus> setting terminal background is more involved; you can set it with the same escape sequences, however many programs will reset the background
140 2017-02-22T08:07:38  <jonasschnelli> I think the background switch should be done on the client side... but the prompt is good enought
141 2017-02-22T08:08:06  <wumpus> fairly sure tmux and some terminal emulators such as gnome=terminal have the option of having different profiles, so you could e.g. launch a different profile before ssh'ing. But yeah too much hassle
142 2017-02-22T08:08:25  <luke-jr> deterministic generation might be more useful
143 2017-02-22T08:08:44  <wumpus> KDE term had/has a nice feature where you could set an icon for the tab too
144 2017-02-22T08:09:04  <wumpus> luke-jr: but some combinations are ugly, so I determine them once when setting up the host then just write that into ~/.profile
145 2017-02-22T08:09:32  <luke-jr> too bad there's not a nice way to have it colour differently for local vs remote
146 2017-02-22T08:11:29  <wumpus> yes I started doing this consistently after shutting down the wrong host one time too many :-)
147 2017-02-22T08:12:12  <luke-jr> I disabled the rm command for root, and alias'd it with -i for my normal user :p
148 2017-02-22T08:12:49  <wumpus> that's a good idea. Some historical UNIXes had that as default IIRC
149 2017-02-22T08:13:10  <wumpus> well the -i thing. Don't know about disabling rm completely
150 2017-02-22T08:25:54  *** Lauda has joined #bitcoin-core-dev
151 2017-02-22T08:29:26  <Victorsueca> is there going to be a 0.14.0rc2 or is the rc1 definitive so far unless a critical issue appears in the wild?
152 2017-02-22T08:29:41  <wumpus> there have already been some issues to warrant rc2
153 2017-02-22T08:30:11  <wumpus> for example #9810
154 2017-02-22T08:30:12  <gribble> https://github.com/bitcoin/bitcoin/issues/9810 | 0.14 not loading mempool.dat? · Issue #9810 · bitcoin/bitcoin · GitHub
155 2017-02-22T08:32:25  <jonasschnelli> Gitian does by default avoid recompiling the dependencies on every build? Right?
156 2017-02-22T08:32:25  <wumpus> and #9817
157 2017-02-22T08:32:27  <gribble> https://github.com/bitcoin/bitcoin/issues/9817 | Fix segfault crash when shutdown the GUI in disablewallet mode by jonasschnelli · Pull Request #9817 · bitcoin/bitcoin · GitHub
158 2017-02-22T08:32:43  <wumpus> jonasschnelli: yes, the dependency caching system should make sure of that
159 2017-02-22T08:33:08  <Victorsueca> ahh how not, it had to be yet another thing windows copied and changed slightly to make it incompatible
160 2017-02-22T08:33:09  <wumpus> it will recompile if either the dependency definitions changed, or the compilation environment changed
161 2017-02-22T08:33:16  <Victorsueca> such CRLF
162 2017-02-22T08:33:25  <jonasschnelli> I wonder why that crash (https://github.com/bitcoin/bitcoin/issues/9814) happens
163 2017-02-22T08:33:27  <wumpus> Victorsueca: yep :/ the DOS legacy in this case
164 2017-02-22T08:34:29  <wumpus> jonasschnelli: yes it's weird
165 2017-02-22T08:35:21  <wumpus> jonasschnelli: it happens deep in the bowels of qt, in the X platform handling
166 2017-02-22T08:35:32  <jonasschnelli> Yes. Looks like.
167 2017-02-22T08:36:13  <jonasschnelli> I wonder if he would get the same crashed building 0.13.1 (I would say so).
168 2017-02-22T08:36:20  <jonasschnelli> *crashes
169 2017-02-22T08:36:38  <wumpus> jonasschnelli:  weird. it looks like both Thread 1 and Thread 2 are in libqxcb.so
170 2017-02-22T08:37:05  <wumpus> is some auxiliary thread trying to do rendering / change the GUI?
171 2017-02-22T08:38:01  <wumpus> ok on the other hand this is just "xcb_wait_for_event" so probably this is just the event loop
172 2017-02-22T08:38:16  <wumpus> no, doesn't seem worrying
173 2017-02-22T08:40:37  <wumpus> the traceback of Thread 1 is completely Qt and upstream libraries - none of our own code
174 2017-02-22T08:40:39  <jonasschnelli> wumpus: I can't find any link between the crash(es) and our code in both stack traces
175 2017-02-22T08:40:56  <jonasschnelli> I think we should recommend to try to compile against a different Qt version
176 2017-02-22T08:41:07  <wumpus> thread 1 is the GUI thread so should be the only one that matters here
177 2017-02-22T08:41:42  <wumpus> so this is either a race with cleaning up objects (deleteLater or such), or something in Qt/X11 itself. I suspect the second as it happens in the X library not in Qt.
178 2017-02-22T08:42:37  <wumpus> cfields: didn't we have some scary xcb compatibility issues before?
179 2017-02-22T08:43:02  <cfields> wumpus: heh, i was just clicking the above link with the same thought
180 2017-02-22T08:43:11  <cfields> wumpus: only applies to static qt builds
181 2017-02-22T08:43:28  <cfields> (it's qt's internal x stubs that cause that issue)
182 2017-02-22T08:44:51  <cfields> it's possible that qt manages to crash there in some ugly way if there's no display plugin available, though
183 2017-02-22T08:46:21  <cfields> (i haven't read the logs yet, if bitcoin-qt launches at all obviously that's not the culprit)
184 2017-02-22T08:46:52  *** chjj has joined #bitcoin-core-dev
185 2017-02-22T08:48:06  <cfields> wumpus: there was a touchscreen bug like that that rings a bell, though
186 2017-02-22T08:48:24  <cfields> wacom, iirc
187 2017-02-22T08:51:53  *** wvr has quit IRC
188 2017-02-22T08:53:05  <cfields> headed to bed, nnite
189 2017-02-22T09:01:20  *** mol has quit IRC
190 2017-02-22T09:11:35  *** JackH has joined #bitcoin-core-dev
191 2017-02-22T09:13:31  *** jannes has joined #bitcoin-core-dev
192 2017-02-22T09:17:38  *** Ylbam has joined #bitcoin-core-dev
193 2017-02-22T09:50:59  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #9823: qa: Set correct path for binaries in rpc tests (master...Mf1702-qaPath) https://github.com/bitcoin/bitcoin/pull/9823
194 2017-02-22T10:05:20  *** chjj has quit IRC
195 2017-02-22T10:08:09  *** chjj has joined #bitcoin-core-dev
196 2017-02-22T10:18:41  <jonasschnelli> wumpus: F.Y.I: "%sudo ALL=NOPASSWD: /usr/bin/lxc-execute" hasn't worked for me... I had to allow it per user "jonasschnelli    ALL=NOPASSWD:/usr/bin/lxc-execute".
197 2017-02-22T10:19:58  <wumpus> strange. It does seem to be the right syntax
198 2017-02-22T10:20:14  <jonasschnelli> The goup or per user line?
199 2017-02-22T10:20:32  <wumpus> oh, you're not in the sudo group?
200 2017-02-22T10:20:51  <wumpus> both
201 2017-02-22T10:20:56  <jonasschnelli> Ah... yes.. that could be the issue.. :)
202 2017-02-22T10:22:14  <jonasschnelli> Do I need to assign the LXC container specific amount of ram? Or does it share it with the host?
203 2017-02-22T10:22:24  <jonasschnelli> I try now -j5
204 2017-02-22T10:22:34  * jonasschnelli needs to go afk
205 2017-02-22T10:23:03  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #9824: qa: Check return code when stopping nodes (master...Mf1702-qaRet) https://github.com/bitcoin/bitcoin/pull/9824
206 2017-02-22T10:23:35  *** city22 has quit IRC
207 2017-02-22T10:26:09  <wumpus> jonasschnelli: LXC limits work in a different way, I've never set any at least
208 2017-02-22T10:27:33  <MarcoFalke> wumpus: Can you add jnewbery_ to the list of members on github?
209 2017-02-22T10:28:05  <MarcoFalke> Maybe also ryanofsky
210 2017-02-22T10:28:26  <wumpus> yes, good idea
211 2017-02-22T10:31:25  <wumpus> ok invited both to bitcoin and bitcoin-core
212 2017-02-22T10:33:34  *** AaronvanW has joined #bitcoin-core-dev
213 2017-02-22T10:35:43  <wumpus> re: release notes, would it make sense to group the two qt debug console changes?
214 2017-02-22T10:36:36  *** chjj has quit IRC
215 2017-02-22T10:36:53  *** laurentmt has joined #bitcoin-core-dev
216 2017-02-22T10:37:05  <wumpus> I mena "Nested RPC Commands in Debug Console"  and "Sensitive Data Is No Longer Stored In Debug Console History"
217 2017-02-22T10:37:16  <wumpus> we also have "GUI Changes"
218 2017-02-22T10:37:48  *** laurentmt has quit IRC
219 2017-02-22T10:38:17  <Victorsueca> that's a nice thing, I used to CTRL+L after typing sensitive data
220 2017-02-22T10:42:25  *** Guyver2 has joined #bitcoin-core-dev
221 2017-02-22T10:42:38  <wumpus> yes, it's certainly a nice thing, it's just spread out a bit haphazardly
222 2017-02-22T10:42:41  <wumpus> in the release notes
223 2017-02-22T10:49:18  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5628c70f2a44...92dd6c8dfdd6
224 2017-02-22T10:49:19  <bitcoin-git> bitcoin/master a87d02a Marko Bencun: use EXIT_ codes instead of magic numbers...
225 2017-02-22T10:49:19  <bitcoin-git> bitcoin/master 92dd6c8 Wladimir J. van der Laan: Merge #9815: Trivial: use EXIT_ codes instead of magic numbers...
226 2017-02-22T10:49:42  <bitcoin-git> [bitcoin] laanwj closed pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (master...exitcode) https://github.com/bitcoin/bitcoin/pull/9815
227 2017-02-22T10:52:10  *** chjj_ has joined #bitcoin-core-dev
228 2017-02-22T11:09:45  *** lclc has quit IRC
229 2017-02-22T11:12:02  *** d9b4bef9 has quit IRC
230 2017-02-22T11:13:07  *** d9b4bef9 has joined #bitcoin-core-dev
231 2017-02-22T11:14:58  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/92dd6c8dfdd6...5b583efaa721
232 2017-02-22T11:14:58  <bitcoin-git> bitcoin/master 3b4dd2a Peter Todd: Add seed.btc.petertodd.org to mainnet DNS seeds
233 2017-02-22T11:14:59  <bitcoin-git> bitcoin/master 5b583ef Wladimir J. van der Laan: Merge #9805: Add seed.btc.petertodd.org to mainnet DNS seeds...
234 2017-02-22T11:15:24  <bitcoin-git> [bitcoin] laanwj closed pull request #9805: Add seed.btc.petertodd.org to mainnet DNS seeds (master...2017-02-add-pt-mainnet-seed) https://github.com/bitcoin/bitcoin/pull/9805
235 2017-02-22T11:18:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b583efaa721...a8c575103815
236 2017-02-22T11:18:59  <bitcoin-git> bitcoin/master eaea2bb gubatron: Removed redundant parameter from mempool.PrioritiseTransaction...
237 2017-02-22T11:19:00  <bitcoin-git> bitcoin/master a8c5751 Wladimir J. van der Laan: Merge #9801: Removed redundant parameter from mempool.PrioritiseTransaction...
238 2017-02-22T11:19:18  <bitcoin-git> [bitcoin] laanwj closed pull request #9801: Removed redundant parameter from mempool.PrioritiseTransaction (master...refactor-mempool-prioritisetx) https://github.com/bitcoin/bitcoin/pull/9801
239 2017-02-22T11:43:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8c575103815...ba7220b5e82f
240 2017-02-22T11:43:30  <bitcoin-git> bitcoin/master e2e2f4c Russell Yanofsky: Return errors from importmulti if complete rescans are not successful
241 2017-02-22T11:43:31  <bitcoin-git> bitcoin/master ba7220b Wladimir J. van der Laan: Merge #9773: Return errors from importmulti if complete rescans are not successful...
242 2017-02-22T11:43:51  <bitcoin-git> [bitcoin] laanwj closed pull request #9773: Return errors from importmulti if complete rescans are not successful (master...pr/multicheck) https://github.com/bitcoin/bitcoin/pull/9773
243 2017-02-22T11:49:53  *** dodomojo has joined #bitcoin-core-dev
244 2017-02-22T11:59:29  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/9072395e5fddb1f2590138a179ab0868646a38a0
245 2017-02-22T11:59:30  <bitcoin-git> bitcoin/0.14 9072395 Russell Yanofsky: Return errors from importmulti if complete rescans are not successful...
246 2017-02-22T11:59:45  *** lclc has joined #bitcoin-core-dev
247 2017-02-22T12:02:15  *** chjj_ has quit IRC
248 2017-02-22T12:02:32  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ba7220b5e82f...1efc99c4dc4d
249 2017-02-22T12:02:33  <bitcoin-git> bitcoin/master bc8fd12 Alex Morcos: Remove harmless read of unusued priority estimates
250 2017-02-22T12:02:33  <bitcoin-git> bitcoin/master 1efc99c Wladimir J. van der Laan: Merge #9819: Remove harmless read of unusued priority estimates...
251 2017-02-22T12:02:52  <bitcoin-git> [bitcoin] laanwj closed pull request #9819: Remove harmless read of unusued priority estimates (master...removeExtraRead) https://github.com/bitcoin/bitcoin/pull/9819
252 2017-02-22T12:04:04  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1efc99c4dc4d...bed5b30a5622
253 2017-02-22T12:04:04  <bitcoin-git> bitcoin/master 9949ebf John Newbery: [Trivial] Remove incorrect help message from gettxoutproof()
254 2017-02-22T12:04:05  <bitcoin-git> bitcoin/master bed5b30 Wladimir J. van der Laan: Merge #9711: [Trivial] Remove incorrect help message from gettxoutproof()...
255 2017-02-22T12:04:21  <bitcoin-git> [bitcoin] laanwj closed pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (master...gettxoutproofhelp) https://github.com/bitcoin/bitcoin/pull/9711
256 2017-02-22T12:18:15  *** vicenteH has joined #bitcoin-core-dev
257 2017-02-22T12:19:05  *** dodomojo has quit IRC
258 2017-02-22T12:27:58  *** wvr has joined #bitcoin-core-dev
259 2017-02-22T12:35:44  *** marcoagner has joined #bitcoin-core-dev
260 2017-02-22T12:37:37  *** nOgAnOo has quit IRC
261 2017-02-22T12:37:38  *** pindarhk has quit IRC
262 2017-02-22T12:38:53  *** mariorz has quit IRC
263 2017-02-22T12:39:21  *** pindarhk has joined #bitcoin-core-dev
264 2017-02-22T12:40:40  *** marcoagner has quit IRC
265 2017-02-22T12:40:55  *** mariorz has joined #bitcoin-core-dev
266 2017-02-22T13:04:37  *** xHire has quit IRC
267 2017-02-22T13:04:37  *** Cory has quit IRC
268 2017-02-22T13:05:31  *** xHire has joined #bitcoin-core-dev
269 2017-02-22T13:07:12  *** Pasha has joined #bitcoin-core-dev
270 2017-02-22T13:13:38  *** btcdrak has quit IRC
271 2017-02-22T13:14:08  *** Pasha is now known as Cory
272 2017-02-22T13:14:30  *** btcdrak has joined #bitcoin-core-dev
273 2017-02-22T13:35:20  *** pindarhk has quit IRC
274 2017-02-22T13:35:41  *** pindarhk has joined #bitcoin-core-dev
275 2017-02-22T13:36:46  *** aguycalled has joined #bitcoin-core-dev
276 2017-02-22T13:36:47  *** pindarhk has quit IRC
277 2017-02-22T13:36:48  *** pindarhk has joined #bitcoin-core-dev
278 2017-02-22T13:40:12  *** aguycalled has quit IRC
279 2017-02-22T13:40:14  *** jnewbery_ has quit IRC
280 2017-02-22T13:40:43  *** aguycalled has joined #bitcoin-core-dev
281 2017-02-22T13:41:07  *** jnewbery has joined #bitcoin-core-dev
282 2017-02-22T13:41:49  *** whphhg has joined #bitcoin-core-dev
283 2017-02-22T13:58:11  *** Giszmo has joined #bitcoin-core-dev
284 2017-02-22T13:59:25  *** chjj_ has joined #bitcoin-core-dev
285 2017-02-22T14:02:16  *** Alina-malina_ has joined #bitcoin-core-dev
286 2017-02-22T14:05:18  *** moli_ has joined #bitcoin-core-dev
287 2017-02-22T14:05:25  *** Alina-malina_ has quit IRC
288 2017-02-22T14:05:25  *** Alina-malina_ has joined #bitcoin-core-dev
289 2017-02-22T14:05:32  *** BashCo_ has joined #bitcoin-core-dev
290 2017-02-22T14:06:08  *** Alina-malina has quit IRC
291 2017-02-22T14:06:15  *** Alina-malina_ is now known as Alina-malina
292 2017-02-22T14:06:40  *** Guest42592 has quit IRC
293 2017-02-22T14:08:56  *** chjj_ has quit IRC
294 2017-02-22T14:09:22  *** BashCo has quit IRC
295 2017-02-22T14:09:30  *** chjj_ has joined #bitcoin-core-dev
296 2017-02-22T14:10:58  *** aguycalled has quit IRC
297 2017-02-22T14:13:36  *** lclc has quit IRC
298 2017-02-22T14:15:57  *** aguycalled has joined #bitcoin-core-dev
299 2017-02-22T14:15:58  *** abhishekcs10_ has joined #bitcoin-core-dev
300 2017-02-22T14:16:15  <abhishekcs10_> Hello everyone :)
301 2017-02-22T14:16:51  <abhishekcs10_> I am new to bitcoin and eager to learn about it.
302 2017-02-22T14:19:37  *** lopp has joined #bitcoin-core-dev
303 2017-02-22T14:20:51  <lopp> I recently pulled down the changes for Bitcoin Core 0.14 into my Statoshi fork, but one of the metrics is no longer populating and I'm hoping someone can explain if this is by design or if I screwed up
304 2017-02-22T14:21:22  <lopp> the specific metric is the "block" inv message (MSG_BLOCK) that I'm populating here: https://github.com/jlopp/statoshi/blob/master/src/net_processing.cpp#L1571
305 2017-02-22T14:21:52  <lopp> the "MSG_TX" inv type metric is populating fine (several lines earlier)
306 2017-02-22T14:21:54  *** aguycalled has quit IRC
307 2017-02-22T14:22:02  <abhishekcs10_> I am having problem understanding following parameters in bitcoin/src/chainparams.cpp
308 2017-02-22T14:22:21  <abhishekcs10_> https://www.irccloud.com/pastebin/vVGQDoUJ
309 2017-02-22T14:34:08  *** jlopp has joined #bitcoin-core-dev
310 2017-02-22T14:34:24  *** nOgAnOo has joined #bitcoin-core-dev
311 2017-02-22T14:36:40  *** chjj_ has quit IRC
312 2017-02-22T14:49:33  <abhishekcs10_> How can I edit interblock timing
313 2017-02-22T14:50:33  <abhishekcs10_> Eg. Setting it to 1min retargetted every 5min
314 2017-02-22T14:54:26  *** city22 has joined #bitcoin-core-dev
315 2017-02-22T14:55:55  *** lclc has joined #bitcoin-core-dev
316 2017-02-22T15:14:39  <sdaftuar> lopp: i'm guessing that is because your peers are using headers or cmpctblocks to announce new blocks, rather than inv's
317 2017-02-22T15:15:14  <sdaftuar> lopp: if all your peers or 0.12 or later - i think? - then it's unlikely you'll get block invs, except in rare cases
318 2017-02-22T15:15:24  <sdaftuar> maybe 0.11 or later
319 2017-02-22T15:15:43  <jlopp> OK I figured it was likely due to protocol changes; my test node is behind a NAT that I don't port forward so it only has 8 peers
320 2017-02-22T15:16:22  <jlopp> I'll double check the peer versions
321 2017-02-22T15:16:24  <sdaftuar> oh yep that will do it then
322 2017-02-22T15:16:44  <sdaftuar> we have preferential peering logic that will make it unlikely for you to connect outbound to older peers (in preparation for segwit)
323 2017-02-22T15:16:52  <jlopp> ahhh
324 2017-02-22T15:17:12  <sdaftuar> so most likely all your peers are 0.13.1 or later
325 2017-02-22T15:19:49  <lopp> @sdaftuar confirmed; they're all 0.13.1+
326 2017-02-22T15:44:01  *** chjj_ has joined #bitcoin-core-dev
327 2017-02-22T15:49:16  *** udiWertheimer has joined #bitcoin-core-dev
328 2017-02-22T16:00:42  *** jlopp has quit IRC
329 2017-02-22T16:02:15  *** lclc has quit IRC
330 2017-02-22T16:12:29  *** paveljanik has joined #bitcoin-core-dev
331 2017-02-22T16:22:16  *** BashCo_ has quit IRC
332 2017-02-22T16:38:39  *** senior has joined #bitcoin-core-dev
333 2017-02-22T16:38:40  *** senior is now known as Guest82394
334 2017-02-22T16:39:41  *** BashCo has joined #bitcoin-core-dev
335 2017-02-22T16:53:43  *** abpa has joined #bitcoin-core-dev
336 2017-02-22T16:59:45  *** udiWertheimer has quit IRC
337 2017-02-22T16:59:45  *** city22 has quit IRC
338 2017-02-22T17:36:22  *** abhishekcs10_ has quit IRC
339 2017-02-22T17:40:57  *** udiWertheimer has joined #bitcoin-core-dev
340 2017-02-22T17:47:52  * BlueMatt . Now providing RaaS
341 2017-02-22T17:47:59  <BlueMatt> Review as a Service, that is
342 2017-02-22T17:48:24  <BlueMatt> in exchange for review of #9725
343 2017-02-22T17:48:32  <gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
344 2017-02-22T17:51:20  *** lopp has quit IRC
345 2017-02-22T17:52:28  *** jnewbery has quit IRC
346 2017-02-22T17:57:01  *** jnewbery has joined #bitcoin-core-dev
347 2017-02-22T18:12:17  *** tripleslash has joined #bitcoin-core-dev
348 2017-02-22T18:30:01  *** jtimon has joined #bitcoin-core-dev
349 2017-02-22T18:31:10  * luke-jr peers at https://testnet.smartbit.com.au/tx/ecb710d1cc86487dbdb3f24b893e7c1d3bb98290097f0f0600c32aaa13312e00
350 2017-02-22T18:34:15  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9827: Improve ScanForWalletTransactions return value (master...pr/scanret) https://github.com/bitcoin/bitcoin/pull/9827
351 2017-02-22T18:50:10  <luke-jr> fun, left my CTableView bitcoin tx log overnight and no substantial memory usage growth. :D
352 2017-02-22T18:50:51  <luke-jr> (I haven't implemented a limit to the log yet, but set it up to use only weak_ptrs)
353 2017-02-22T18:51:38  <luke-jr> thinking of making it use maybe 500 lines of non-weak ptrs, and up to 10000 lines of weak_ptrs, or something
354 2017-02-22T19:17:19  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9828: Avoid -Wshadow warnings in wallet_tests (master...pr/multishadow) https://github.com/bitcoin/bitcoin/pull/9828
355 2017-02-22T19:28:12  *** laurentmt has joined #bitcoin-core-dev
356 2017-02-22T19:58:45  *** moli_ has quit IRC
357 2017-02-22T19:59:04  *** moli_ has joined #bitcoin-core-dev
358 2017-02-22T20:02:49  *** laurentmt has quit IRC
359 2017-02-22T20:05:19  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9829: Fix importmulti returning rescan errors for wrong keys (master...pr/multiinc) https://github.com/bitcoin/bitcoin/pull/9829
360 2017-02-22T20:21:45  *** shesek has joined #bitcoin-core-dev
361 2017-02-22T20:23:08  *** GAit has quit IRC
362 2017-02-22T20:23:42  *** GAit has joined #bitcoin-core-dev
363 2017-02-22T20:32:17  *** jtimon has quit IRC
364 2017-02-22T20:52:36  *** Chris_Stewart_5 has quit IRC
365 2017-02-22T21:08:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
366 2017-02-22T21:14:01  *** Ylbam has quit IRC
367 2017-02-22T21:21:21  *** Chris_Stewart_5 has quit IRC
368 2017-02-22T21:21:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
369 2017-02-22T21:33:18  *** jtimon has joined #bitcoin-core-dev
370 2017-02-22T21:33:28  *** Guyver2 has quit IRC
371 2017-02-22T21:35:24  <jtimon> mhmm, in rpcwallet and rpcdump, ensure EnsureWalletIsAvailable( is called before showing the help. if the user selected help but the wallet is not available, the function will return NullUniValue instead of actually showing the help
372 2017-02-22T21:35:31  <jtimon> is this the desired behaviour?
373 2017-02-22T21:35:53  <jtimon> it seems not, and it's simple to fix
374 2017-02-22T21:42:00  <warren> I used linearize-data.py to generate in-order *.blk files.  I want to make the very deep historical blocks read-only at the filesystem level and hard-linked into the blocks/ directory to be used by multiple separate instances of bitcoind on the same machine.  It seems that bitcoind currently requires opening all *.blk files as writable so it is incompatible with this use case.  http://pastebin.com/DMUcTJuT  debug.log and relevant parts of b
375 2017-02-22T21:42:01  <warren> itcoind source.
376 2017-02-22T21:42:37  <warren> I could make a temporary hack for myself, but is there any reason to not support this in the future?
377 2017-02-22T21:46:01  *** Ylbam has joined #bitcoin-core-dev
378 2017-02-22T22:09:09  <luke-jr> jtimon: it's the intended behaviour, presumably so -wallet=0 behaves the same as if it was compiled without
379 2017-02-22T22:09:54  <luke-jr> (I don't mind if someone changes it though)
380 2017-02-22T22:18:02  <warren> oh, *.dat files
381 2017-02-22T22:18:14  <warren> blk*.dat
382 2017-02-22T22:33:24  *** neha has quit IRC
383 2017-02-22T22:44:00  <jtimon> luke-jr: I see, the other 2 options would be to either throw the error even if fHelp is true, or show the help even if the wallet is not available
384 2017-02-22T22:45:26  <luke-jr> wouldn't throwing an error break `help`?
385 2017-02-22T22:56:22  *** neha has joined #bitcoin-core-dev
386 2017-02-22T23:01:56  *** tussssss has joined #bitcoin-core-dev
387 2017-02-22T23:02:07  <tussssss> Buy/Sell ( Bitcoin - Perfect money - webmoney - western union - moneygram - skrill - neteller ) & giftcards/prepaids ( llike amazon-ebay etc... ) Contact Skype : rodrige.amin ICQ : 690490649
388 2017-02-22T23:02:11  *** tussssss has quit IRC
389 2017-02-22T23:19:23  <jtimon> luke-jr: help is already broken if the wallet is not available
390 2017-02-22T23:19:42  <jtimon> why are all these functions declared as extern? https://github.com/bitcoin/bitcoin/blob/master/src/rpc/server.h#L188
391 2017-02-22T23:20:31  <luke-jr> jtimon: is it? :/
392 2017-02-22T23:22:24  <jtimon> luke-jr: if the wallet is not available, the function returns NullUniValue before having the opportunity to check     if (fHelp || params.size() < 2 || params.size() > 6) (well, of course the exact check depends on the function)
393 2017-02-22T23:23:19  <luke-jr> jtimon: and `help` upon getting null just skips it, no?
394 2017-02-22T23:23:43  <jtimon> my preferred behaviour would be to only check if the wallet is available after checking if it should show the help, and when doing so, if it's not available just throw the error as if fHelp was false
395 2017-02-22T23:24:55  <jtimon> luke-jr: no, if fHelp=false, it returns false, EnsureWalletIsAvailable() returns false instead of throwing the error, thus the calling function returns NullUniValue before having the chance to check if the help should be shown
396 2017-02-22T23:25:33  <jtimon> I guess I'll just write my prefferred fix and see what people think
397 2017-02-22T23:25:35  <luke-jr> jtimon: …
398 2017-02-22T23:25:47  <luke-jr> jtimon: foomethod() returns null to help(), which just skips foomethod
399 2017-02-22T23:26:23  <jtimon> what help() function ?
400 2017-02-22T23:26:32  <luke-jr> rpc/server.cpp
401 2017-02-22T23:26:39  <luke-jr> std::string CRPCTable::help(const std::string& strCommand) const
402 2017-02-22T23:27:57  <jtimon> oh, no I don't mean the general help, I mean the help for a specific rpc call (or when you have an invalid number of parameters for that call)
403 2017-02-22T23:28:14  <jtimon> but let me read that method...
404 2017-02-22T23:30:16  <jtimon> I see, yeah, that's the point of returning null instead of launching the error or giving it the opportunity to get the help first
405 2017-02-22T23:30:23  <luke-jr> fHelp is only ever true via that method
406 2017-02-22T23:38:12  <jtimon> mhmm, if I start the deamon with -wallet=0 and then with the client do sendtoaddress --help it shows the doc...
407 2017-02-22T23:39:18  <jtimon> how can I make pwalletMain=NULL ?
408 2017-02-22T23:41:50  <jtimon> btw, IIRC we talked before about moving the rpc wallet stuff from BTC to satoshis, but it breaks the interface. Are we decided to never do that?
409 2017-02-22T23:42:03  <jtimon> would this be a good time?
410 2017-02-22T23:42:21  <luke-jr> `sendtoaddress --help` is simply an invalid address
411 2017-02-22T23:43:33  <jtimon> ?? then why it shows the help instead of "Invalid Bitcoin address"
412 2017-02-22T23:43:53  <ryanofsky> i know "sendfrom" RPC is deprecated, but is it also broken? I don't see 'fromaccount'
413 2017-02-22T23:44:00  <ryanofsky> argument actually used for coin selection
414 2017-02-22T23:56:39  <jeremyrubin> no that's not broken
415 2017-02-22T23:56:56  <jeremyrubin> As far as I understand, accounts were meant to be internal accounting
416 2017-02-22T23:57:05  <jeremyrubin> meaning negative balances could be reported
417 2017-02-22T23:57:47  <jeremyrubin> So if I spend 2 from account Y with real balance 1, Y's new balance should be -1
418 2017-02-22T23:59:21  <jeremyrubin> so account info has no bearing on coin selection
419 2017-02-22T23:59:39  <sipa> that ^
420 2017-02-22T23:59:51  <sipa> coins are independent from accounts
421 2017-02-22T23:59:56  <sipa> accounts only have a balance