12017-03-13T00:10:49 *** vogelito has joined #bitcoin-core-dev
22017-03-13T00:15:08 *** vogelito has quit IRC
32017-03-13T00:16:35 *** wudayoda has quit IRC
42017-03-13T00:18:27 *** jtimon has quit IRC
52017-03-13T00:47:39 <bitcoin-git> [bitcoin] maaku opened pull request #9981: Bloom: Consider witness script pushes in bloom filter check. (master...segwit-bloom-filter) https://github.com/bitcoin/bitcoin/pull/9981
62017-03-13T01:19:13 *** wudayoda has joined #bitcoin-core-dev
72017-03-13T01:20:44 *** grubles has quit IRC
82017-03-13T01:21:45 *** PRab has joined #bitcoin-core-dev
92017-03-13T01:24:01 *** wudayoda has quit IRC
102017-03-13T01:31:46 *** aalex__ has joined #bitcoin-core-dev
112017-03-13T01:32:48 *** grubles_ has joined #bitcoin-core-dev
122017-03-13T01:34:05 *** Ylbam has quit IRC
132017-03-13T01:40:49 *** Hisham has joined #bitcoin-core-dev
142017-03-13T01:41:29 <Hisham> Hello ?
152017-03-13T01:42:13 <Hisham> Any core developer online please ?
162017-03-13T01:48:44 <sipa> maybe!
172017-03-13T01:49:18 <bitcoin-git> [bitcoin] maaku closed pull request #9981: Bloom: Consider witness script pushes in bloom filter check. (master...segwit-bloom-filter) https://github.com/bitcoin/bitcoin/pull/9981
182017-03-13T01:49:49 <Hisham> Pieter Wuille
192017-03-13T01:50:13 <Hisham> At first, it's my pleasure to talk to you :)
202017-03-13T01:50:44 <Hisham> If you don't mind, I would like to discuss something with you regarding SegWit UASF
212017-03-13T01:51:09 <Hisham> Can we talk please ?
222017-03-13T01:53:00 <BlueMatt> dear god, dont ask to ask, just ask
232017-03-13T01:53:17 <Hisham> :S
242017-03-13T01:53:33 <Hisham> Guys, I know you are nice to people, c'mon, what happened ?
252017-03-13T01:54:05 *** dodomojo_ has joined #bitcoin-core-dev
262017-03-13T01:54:17 <Hisham> Maybe you are busy or something, does politeness and taking permission is considered a crime nowadays ?
272017-03-13T01:54:59 <BlueMatt> it is generally discouraged on irc
282017-03-13T01:55:09 <BlueMatt> text-based communication is slow enough already :(
292017-03-13T01:55:34 <Hisham> Ok I see and understand, no problem :)
302017-03-13T01:55:47 <BlueMatt> engineers, you know
312017-03-13T01:56:09 <Hisham> Here is one as well, Mechanical and a CNC programmer :)
322017-03-13T01:56:55 *** dodomojo has quit IRC
332017-03-13T01:57:08 <Hisham> I was going to be a colleague, but I had a nasty doctor who let me hate CS, Java to be precise.
342017-03-13T01:57:42 <gmaxwell> google for "don't ask to ask"-- beyond being wasteful, it's considered rude because it asks people to commit to an open ended conversation which they may not be interested in when they know the details.
352017-03-13T01:58:39 <gmaxwell> as far as your question, all the discussion on that has been on the mailing list, I don't think anyone here has been involved in it (though perhaps I'm incorrect, as I haven't been following it)
362017-03-13T01:59:06 <sipa> Hisham: just ask whatever you want to ask
372017-03-13T01:59:10 *** dodomojo has joined #bitcoin-core-dev
382017-03-13T01:59:31 <Hisham> Thanks for the clarification Gregory.
392017-03-13T01:59:48 <Hisham> But guys, for God sake take it easy on me.
402017-03-13T01:59:51 *** grubles_ is now known as grubles
412017-03-13T02:00:06 <sipa> yes, get to the point :)
422017-03-13T02:00:18 <Hisham> I will.
432017-03-13T02:02:11 <Hisham> I'm a normal old Bitcoiner since the days of CPU and browser mining but I've got highly involved at 2014, I've read a lot about Bitcoin and you can I'm my life is oriented to it for many reasons.
442017-03-13T02:02:22 *** dodomojo_ has quit IRC
452017-03-13T02:03:34 <Hisham> When I saw the blocksize debate, I felt that I can't stand on the sidelines and try to help or at least understand and engage in conversations, maybe I can do something for all the BS happening around us.
462017-03-13T02:04:17 <achow101> Hisham: please just ask your question. none of this preamble is necessary. I hate to break it to you, but no one cares about your backstory. Please just get straight to the point and ask your question.
472017-03-13T02:05:08 <Hisham> No problem, I understand, sorry.
482017-03-13T02:06:39 <Hisham> As some of you may witness, Shaloin Fry made what we can call a SegWit UASF.
492017-03-13T02:07:02 *** aalex__ has quit IRC
502017-03-13T02:07:05 <Hisham> As I understand, it needs consensus, if I'm not mistaken.
512017-03-13T02:07:34 <Hisham> How can we get this implemented if there is a chance for it to be implemented ?
522017-03-13T02:08:00 <sipa> no politics here, please
532017-03-13T02:08:10 <BlueMatt> Hisham: if you want a UASF to happen, go start talking to the community - talk to businesses and users
542017-03-13T02:08:15 <BlueMatt> such things are not for us to decide
552017-03-13T02:09:11 <BlueMatt> Hisham: relevant is bluematt.bitcoin.ninja/2017/02/28/bitcoin-trustlessness/ (and also #bitcoin, not really #bitcoin-core-dev)
562017-03-13T02:09:19 * BlueMatt does the shameless-self-promotion dance
572017-03-13T02:09:58 <Hisham> I understand, but from technical POV, is there a chance for intergation ?
582017-03-13T02:10:06 <Hisham> *integration ?
592017-03-13T02:10:11 <sipa> implementing it is absolutely trivial
602017-03-13T02:10:20 <sipa> the only question is whether we should
612017-03-13T02:10:35 <sipa> and generally the answer to that is "if it's clearly uncontroversial"
622017-03-13T02:10:36 <BlueMatt> i believe code was already written, as for people actually using that code....<BlueMatt> such things are not for us to decide
632017-03-13T02:11:46 <Hisham> Pieter, may you elaborate more please on this "if it's clearly uncontroversial"
642017-03-13T02:11:52 <Hisham> ?
652017-03-13T02:12:07 <BlueMatt> maybe this is a better topic for #bitcoin, its not really a development topic
662017-03-13T02:12:34 <Hisham> Ok, since I'm not welcomed form the beginning.
672017-03-13T02:12:49 <BlueMatt> Hisham: I'm happy to go discuss it further on #bitcoin
682017-03-13T02:13:26 <Hisham> Ok, can we talk there now please along with Pieter ?
692017-03-13T02:13:35 *** droark has quit IRC
702017-03-13T02:38:28 *** owowo has quit IRC
712017-03-13T02:44:03 *** owowo has joined #bitcoin-core-dev
722017-03-13T02:52:08 *** To7 has quit IRC
732017-03-13T02:52:49 *** dodomojo_ has joined #bitcoin-core-dev
742017-03-13T02:56:25 *** dodomojo has quit IRC
752017-03-13T03:18:17 *** wudayoda has joined #bitcoin-core-dev
762017-03-13T03:22:27 *** wudayoda has quit IRC
772017-03-13T03:23:19 *** kadoban has joined #bitcoin-core-dev
782017-03-13T03:24:48 *** dcousens_ has joined #bitcoin-core-dev
792017-03-13T03:44:51 *** vogelito has joined #bitcoin-core-dev
802017-03-13T03:49:08 *** vogelito has quit IRC
812017-03-13T04:00:23 *** dodomojo_ has quit IRC
822017-03-13T04:19:32 *** wudayoda has joined #bitcoin-core-dev
832017-03-13T04:23:57 *** wudayoda has quit IRC
842017-03-13T04:30:23 *** chris2000 has joined #bitcoin-core-dev
852017-03-13T04:31:52 *** vogelito has joined #bitcoin-core-dev
862017-03-13T04:33:27 *** chris200_ has quit IRC
872017-03-13T04:36:28 *** vogelito has quit IRC
882017-03-13T04:57:38 *** To7 has joined #bitcoin-core-dev
892017-03-13T05:10:47 *** PRab has quit IRC
902017-03-13T05:23:59 *** kadoban has quit IRC
912017-03-13T05:53:06 *** dodomojo has joined #bitcoin-core-dev
922017-03-13T05:57:48 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7e58b41bd7ce...f8a709161f37
932017-03-13T05:57:49 <bitcoin-git> bitcoin/master e007b24 Matt Corallo: Fix shutdown hang with >= 8 -addnodes set...
942017-03-13T05:57:49 <bitcoin-git> bitcoin/master 819b513 Matt Corallo: Add missing braces in semaphore posts in net
952017-03-13T05:57:50 <bitcoin-git> bitcoin/master f8a7091 Wladimir J. van der Laan: Merge #9953: Fix shutdown hang with >= 8 -addnodes set...
962017-03-13T05:58:02 *** dodomojo has quit IRC
972017-03-13T05:58:11 <bitcoin-git> [bitcoin] laanwj closed pull request #9953: Fix shutdown hang with >= 8 -addnodes set (master...2017-03-exit-with-addnode) https://github.com/bitcoin/bitcoin/pull/9953
982017-03-13T06:01:58 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8a709161f37...afcd7c0e52d8
992017-03-13T06:01:59 <bitcoin-git> bitcoin/master af61d9f Russell Yanofsky: Add COutput::fSafe member for safe handling of unconfirmed outputs...
1002017-03-13T06:02:00 <bitcoin-git> bitcoin/master dcf2112 NicolasDorier: Add safe flag to listunspent result
1012017-03-13T06:02:00 <bitcoin-git> bitcoin/master afcd7c0 Wladimir J. van der Laan: Merge #9830: Add safe flag to listunspent result...
1022017-03-13T06:02:17 <bitcoin-git> [bitcoin] laanwj closed pull request #9830: Add safe flag to listunspent result (master...listunspenttrusted) https://github.com/bitcoin/bitcoin/pull/9830
1032017-03-13T06:20:16 *** wudayoda has joined #bitcoin-core-dev
1042017-03-13T06:24:40 *** wudayoda has quit IRC
1052017-03-13T06:28:04 *** Alina-malina has quit IRC
1062017-03-13T06:32:41 *** droark has joined #bitcoin-core-dev
1072017-03-13T06:35:17 *** isis has joined #bitcoin-core-dev
1082017-03-13T06:37:15 *** droark has quit IRC
1092017-03-13T06:43:09 *** vogelito has joined #bitcoin-core-dev
1102017-03-13T06:45:13 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/afcd7c0e52d8...2cc0df1fcecc
1112017-03-13T06:45:14 <bitcoin-git> bitcoin/master 0068361 Cory Fields: release: add win detached sig creator and our cert chain...
1122017-03-13T06:45:14 <bitcoin-git> bitcoin/master f642753 Cory Fields: release: create a bundle for the new signing script...
1132017-03-13T06:45:15 <bitcoin-git> bitcoin/master 09fe2d9 Cory Fields: release: update docs to show basic codesigning procedure
1142017-03-13T06:45:27 <bitcoin-git> [bitcoin] laanwj closed pull request #9514: release: Windows signing script (master...win-signing-script) https://github.com/bitcoin/bitcoin/pull/9514
1152017-03-13T06:47:43 *** dodomojo has joined #bitcoin-core-dev
1162017-03-13T06:47:48 *** vogelito has quit IRC
1172017-03-13T06:49:07 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2cc0df1fcecc...fa99663bec1d
1182017-03-13T06:49:08 <bitcoin-git> bitcoin/master fd5e905 Matt Corallo: Make verify-commits.sh non-recursive
1192017-03-13T06:49:08 <bitcoin-git> bitcoin/master 8ed849f Matt Corallo: Fix travis failing to fetch keys from the sks keyserver pool...
1202017-03-13T06:49:09 <bitcoin-git> bitcoin/master efc06c2 Matt Corallo: If GNU sha512sum is missing, try perl shasum in verify-commits
1212017-03-13T06:49:27 <bitcoin-git> [bitcoin] laanwj closed pull request #9940: Fix verify-commits on OSX, update for new bad Tree-SHA512, point travis to different keyservers (master...2017-03-verify-commits-no-recursion) https://github.com/bitcoin/bitcoin/pull/9940
1222017-03-13T06:51:58 *** dodomojo has quit IRC
1232017-03-13T06:52:44 *** Ylbam has joined #bitcoin-core-dev
1242017-03-13T07:13:14 *** vogelito has joined #bitcoin-core-dev
1252017-03-13T07:17:28 *** vogelito has quit IRC
1262017-03-13T07:41:50 *** dodomojo has joined #bitcoin-core-dev
1272017-03-13T07:44:31 *** BashCo_ has quit IRC
1282017-03-13T07:46:13 *** dodomojo has quit IRC
1292017-03-13T07:48:16 *** aalex__ has joined #bitcoin-core-dev
1302017-03-13T07:56:16 *** harrymm1 has quit IRC
1312017-03-13T08:02:15 *** vogelito has joined #bitcoin-core-dev
1322017-03-13T08:06:58 *** vogelito has quit IRC
1332017-03-13T08:09:37 *** harrymm has joined #bitcoin-core-dev
1342017-03-13T08:09:46 *** BashCo has joined #bitcoin-core-dev
1352017-03-13T08:21:00 *** wudayoda has joined #bitcoin-core-dev
1362017-03-13T08:23:48 *** aalex__ has quit IRC
1372017-03-13T08:24:04 *** cbits has joined #bitcoin-core-dev
1382017-03-13T08:25:25 *** wudayoda has quit IRC
1392017-03-13T08:31:47 *** vogelito has joined #bitcoin-core-dev
1402017-03-13T08:33:52 *** cbits has quit IRC
1412017-03-13T08:36:26 *** vogelito has quit IRC
1422017-03-13T08:42:48 *** wangchun has quit IRC
1432017-03-13T08:43:10 *** JackH has joined #bitcoin-core-dev
1442017-03-13T08:43:52 *** wangchun has joined #bitcoin-core-dev
1452017-03-13T08:53:56 <bitcoin-git> [bitcoin] laanwj opened pull request #9983: tests: Convert selected tests to using named RPC arguments (master...2017_03_rpc_tests_named_arguments) https://github.com/bitcoin/bitcoin/pull/9983
1462017-03-13T09:01:23 *** vogelito has joined #bitcoin-core-dev
1472017-03-13T09:01:28 *** ChillazZ has joined #bitcoin-core-dev
1482017-03-13T09:06:22 *** vogelito has quit IRC
1492017-03-13T09:21:28 *** harrymm has quit IRC
1502017-03-13T09:23:59 *** jtimon has joined #bitcoin-core-dev
1512017-03-13T09:30:58 *** vogelito has joined #bitcoin-core-dev
1522017-03-13T09:35:01 *** chjj has quit IRC
1532017-03-13T09:35:57 *** vogelito has quit IRC
1542017-03-13T09:39:42 *** harrymm has joined #bitcoin-core-dev
1552017-03-13T09:51:00 *** vogelito has joined #bitcoin-core-dev
1562017-03-13T09:54:57 *** vogelito has quit IRC
1572017-03-13T10:01:31 *** dcousens_ has quit IRC
1582017-03-13T10:11:52 *** Hubert2 has joined #bitcoin-core-dev
1592017-03-13T10:12:10 *** Hubert2 has joined #bitcoin-core-dev
1602017-03-13T10:12:31 *** Hubert2 has joined #bitcoin-core-dev
1612017-03-13T10:15:32 *** Hubert2 has quit IRC
1622017-03-13T10:21:47 *** wudayoda has joined #bitcoin-core-dev
1632017-03-13T10:23:37 *** dodomojo has joined #bitcoin-core-dev
1642017-03-13T10:26:27 *** wudayoda has quit IRC
1652017-03-13T10:28:16 *** dodomojo has quit IRC
1662017-03-13T10:36:29 *** LeMiner2 has joined #bitcoin-core-dev
1672017-03-13T10:36:48 *** LeMiner has quit IRC
1682017-03-13T10:36:48 *** LeMiner2 is now known as LeMiner
1692017-03-13T10:40:57 *** laurentmt has joined #bitcoin-core-dev
1702017-03-13T10:41:18 *** laurentmt has quit IRC
1712017-03-13T10:43:11 *** Chris_Stewart_5 has quit IRC
1722017-03-13T10:43:44 *** laurentmt has joined #bitcoin-core-dev
1732017-03-13T10:45:04 *** Lyla has joined #bitcoin-core-dev
1742017-03-13T10:46:08 *** laurentmt has quit IRC
1752017-03-13T10:46:12 *** Lyla has quit IRC
1762017-03-13T10:51:31 *** Merlin2 has joined #bitcoin-core-dev
1772017-03-13T10:54:19 *** Merlin2 has quit IRC
1782017-03-13T10:59:44 *** Javon has joined #bitcoin-core-dev
1792017-03-13T11:02:46 *** Javon has quit IRC
1802017-03-13T11:05:22 *** isle2983 has quit IRC
1812017-03-13T11:05:41 *** Hisham has quit IRC
1822017-03-13T11:05:49 *** chjj has joined #bitcoin-core-dev
1832017-03-13T11:08:59 *** Effie has joined #bitcoin-core-dev
1842017-03-13T11:09:14 *** Christina has joined #bitcoin-core-dev
1852017-03-13T11:09:23 *** Effie has joined #bitcoin-core-dev
1862017-03-13T11:09:27 *** Effie has quit IRC
1872017-03-13T11:13:50 *** Mustafa2 has joined #bitcoin-core-dev
1882017-03-13T11:18:14 *** dodomojo has joined #bitcoin-core-dev
1892017-03-13T11:22:31 *** dodomojo has quit IRC
1902017-03-13T11:23:44 *** randy-waterhouse has joined #bitcoin-core-dev
1912017-03-13T11:24:06 *** randy-waterhouse has joined #bitcoin-core-dev
1922017-03-13T11:30:44 *** Mustafa2 has quit IRC
1932017-03-13T11:35:15 *** nejon has joined #bitcoin-core-dev
1942017-03-13T11:42:40 *** Giovanny has joined #bitcoin-core-dev
1952017-03-13T12:12:08 *** dodomojo has joined #bitcoin-core-dev
1962017-03-13T12:12:58 *** randy-waterhouse has quit IRC
1972017-03-13T12:16:05 *** str4d has quit IRC
1982017-03-13T12:16:28 *** dodomojo has quit IRC
1992017-03-13T12:22:29 *** Alina-malina has joined #bitcoin-core-dev
2002017-03-13T12:22:42 *** wudayoda has joined #bitcoin-core-dev
2012017-03-13T12:27:14 *** wudayoda has quit IRC
2022017-03-13T12:37:31 *** Alina-malina has quit IRC
2032017-03-13T12:37:31 *** Alina-malina has joined #bitcoin-core-dev
2042017-03-13T12:40:50 *** crescendo has quit IRC
2052017-03-13T12:59:48 *** Victorsueca has quit IRC
2062017-03-13T13:00:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2072017-03-13T13:01:12 *** Victorsueca has joined #bitcoin-core-dev
2082017-03-13T13:06:26 *** dodomojo has joined #bitcoin-core-dev
2092017-03-13T13:10:40 *** dodomojo has quit IRC
2102017-03-13T13:11:23 *** isle2983 has joined #bitcoin-core-dev
2112017-03-13T13:13:47 *** Giovanny has quit IRC
2122017-03-13T13:19:56 *** kexkey has joined #bitcoin-core-dev
2132017-03-13T13:21:34 *** aalex__ has joined #bitcoin-core-dev
2142017-03-13T13:21:45 *** wudayoda has joined #bitcoin-core-dev
2152017-03-13T13:22:46 *** otium has joined #bitcoin-core-dev
2162017-03-13T13:25:30 *** AaronvanW has quit IRC
2172017-03-13T13:27:18 *** wudayoda has quit IRC
2182017-03-13T13:32:36 *** wudayoda has joined #bitcoin-core-dev
2192017-03-13T13:37:30 *** wudayoda has quit IRC
2202017-03-13T13:41:07 *** kexkey has quit IRC
2212017-03-13T13:42:42 *** wudayoda has joined #bitcoin-core-dev
2222017-03-13T13:43:51 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa99663bec1d...8040ae6fc576
2232017-03-13T13:43:52 <bitcoin-git> bitcoin/master 3b092bd Wladimir J. van der Laan: util: Properly handle errors during log message formatting...
2242017-03-13T13:43:53 <bitcoin-git> bitcoin/master b651270 Wladimir J. van der Laan: util: Throw tinyformat::format_error on formatting error...
2252017-03-13T13:43:53 <bitcoin-git> bitcoin/master 8040ae6 Wladimir J. van der Laan: Merge #9963: util: Properly handle errors during log message formatting...
2262017-03-13T13:44:15 <bitcoin-git> [bitcoin] laanwj closed pull request #9963: util: Properly handle errors during log message formatting (master...2017_03_handle_exception_tinyformat) https://github.com/bitcoin/bitcoin/pull/9963
2272017-03-13T13:47:42 *** wudayoda has quit IRC
2282017-03-13T13:48:47 *** kadoban has joined #bitcoin-core-dev
2292017-03-13T13:54:59 *** otium has quit IRC
2302017-03-13T14:00:31 *** dodomojo has joined #bitcoin-core-dev
2312017-03-13T14:05:37 *** dodomojo has quit IRC
2322017-03-13T14:06:39 *** AaronvanW has joined #bitcoin-core-dev
2332017-03-13T14:11:43 *** MarcoFalke_lab has joined #bitcoin-core-dev
2342017-03-13T14:12:30 <MarcoFalke_lab> wumpus: I think you need to enable the verify commits pre push hook.
2352017-03-13T14:12:44 <MarcoFalke_lab> Alternatively, someone could fix the bug in github-merge
2362017-03-13T14:12:51 <wumpus> which bug?
2372017-03-13T14:13:24 <MarcoFalke_lab> It will calculate the hash of the files in the working directory, instead of the ones in git
2382017-03-13T14:14:13 <wumpus> right, that should be fixed
2392017-03-13T14:15:52 *** kexkey_ has joined #bitcoin-core-dev
2402017-03-13T14:16:01 *** d9b4bef9 has quit IRC
2412017-03-13T14:16:09 <wumpus> without that it's kind of useless and we should disable the hashing completely
2422017-03-13T14:16:32 <wumpus> seems easy enough to do though, just request the data from git
2432017-03-13T14:17:08 *** d9b4bef9 has joined #bitcoin-core-dev
2442017-03-13T14:17:27 <MarcoFalke_lab> Why not do the hard reset early? I mean at some point the script does the hard reset anyway, so the data is lost regardless
2452017-03-13T14:17:51 <wumpus> it shouldn't do any hard resets
2462017-03-13T14:17:59 *** kexkey_ is now known as kexkey
2472017-03-13T14:18:11 <MarcoFalke_lab> https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/github-merge.py#L290
2482017-03-13T14:18:50 <wumpus> okay, yeah I don't really like that solution. It should hash what is in git, not what is in the current working directory
2492017-03-13T14:19:47 <MarcoFalke_lab> ok, fine.
2502017-03-13T14:19:59 <wumpus> otherwise there's always a window for races
2512017-03-13T14:20:36 <MarcoFalke_lab> jup, it is the cleaner solution.
2522017-03-13T14:21:44 <wumpus> working on it now - apparently ls-files gives the blob ids, that can be passed as-is to git cat-file
2532017-03-13T14:22:36 <BlueMatt> wumpus: yes, iirc that was annoying but i dont remember why now....verify-commits does cat-file $COMMIT_ID:$FILE_PATH
2542017-03-13T14:23:17 <wumpus> BlueMatt: ah, that likely works just as well
2552017-03-13T14:23:28 *** Guyver2 has joined #bitcoin-core-dev
2562017-03-13T14:24:04 <BlueMatt> wumpus: if you can get it to work some other way, though, use that...I kinda liked how merge did the hashes via checkout and verify-commits used a different approach, but it really doesnt matter all that much
2572017-03-13T14:24:52 * BlueMatt doesnt have to deal with the merge script, so I get to argue for it to be harder to use all day long with no repurcussions, though :P
2582017-03-13T14:25:25 <wumpus> well how the sha is computed doesn't affect how hard it is to use, it does affect whether the output is correct, which is arguably very important
2592017-03-13T14:25:35 <BlueMatt> indeed
2602017-03-13T14:26:14 * BlueMatt is ok with the sha being less likely to match, if that also means its more likely to trip up if something strange happens (symlink detection gets broken, etc)
2612017-03-13T14:26:41 <BlueMatt> anyway, this is too inconsequential to nitpick over :P
2622017-03-13T14:27:19 <wumpus> I'm kind of annoyed at travis tripping up all the time though, if that keeps happening I'll hvae to disable the verify-commits check there. SO let's please just get it working
2632017-03-13T14:27:30 <BlueMatt> i think it should be good now
2642017-03-13T14:27:41 <BlueMatt> it failed a number of times just downloading the pubkeys because the sks pool was broken
2652017-03-13T14:27:52 <BlueMatt> but we changed to subset which appears to possibly be more stable
2662017-03-13T14:28:01 <BlueMatt> i do not believe we have otherwise failed in some time
2672017-03-13T14:28:17 <BlueMatt> hmmm, no, failed again this morning
2682017-03-13T14:28:21 <BlueMatt> I'll go take a look
2692017-03-13T14:28:43 <wumpus> according to MarcoFalke_lab it failed due to my merge script miscomputing the SHA
2702017-03-13T14:28:52 <MarcoFalke_lab> BlueMatt: It used the 'old' server url
2712017-03-13T14:29:10 <MarcoFalke_lab> The other failure was due to the wrong sha
2722017-03-13T14:29:10 <BlueMatt> that was once, looks like it also once failed to retreive pubkeys
2732017-03-13T14:29:11 <BlueMatt> wtf
2742017-03-13T14:29:26 <BlueMatt> how did it do that? it now points to subset???
2752017-03-13T14:29:45 <MarcoFalke_lab> BlueMatt: IIRC the subset-patch was not merged at that time
2762017-03-13T14:30:03 <BlueMatt> yes it was, the very top commit failed and the second-to-top merge was the subset change
2772017-03-13T14:30:11 <wumpus> what subset patch?
2782017-03-13T14:30:12 <BlueMatt> im super confused
2792017-03-13T14:30:26 <BlueMatt> wumpus: part of #9940 was to change the server gpg fetches the keys from
2802017-03-13T14:30:28 <gribble> https://github.com/bitcoin/bitcoin/issues/9940 | Fix verify-commits on OSX, update for new bad Tree-SHA512, point travis to different keyservers by TheBlueMatt · Pull Request #9940 · bitcoin/bitcoin · GitHub
2812017-03-13T14:30:47 <wumpus> ok, confusing
2822017-03-13T14:30:48 <MarcoFalke_lab> Right
2832017-03-13T14:31:00 <MarcoFalke_lab> Probably just a travis network hickup
2842017-03-13T14:31:09 <petertodd> BlueMatt: why not have the merge script get the pubkeys from the repo itself?
2852017-03-13T14:31:23 <BlueMatt> MarcoFalke_lab: no, look at the build, it tried to fetch from pool., not subset.pool.
2862017-03-13T14:31:43 <BlueMatt> petertodd: yea, I think thats the next step, I was thinking subset might help, but...
2872017-03-13T14:31:56 <BlueMatt> still need to do a --refresh-keys
2882017-03-13T14:32:02 <BlueMatt> but need a backup
2892017-03-13T14:32:23 <petertodd> BlueMatt: better to make the whole thing deterministic; if verify commits doesn't run because a key is missing, fix that!
2902017-03-13T14:33:07 <BlueMatt> oh, no, I'm wrong, github is listing me commits out of order
2912017-03-13T14:33:08 <BlueMatt> wtf
2922017-03-13T14:33:46 <wumpus> yes it does that, it uses a stupid sort ordering for commits
2932017-03-13T14:34:04 <wumpus> by date instead of chronologically according to the repo
2942017-03-13T14:34:04 <BlueMatt> oh, ok, yes, the failure occurred before the subset merge, and then another afterwards due to bad sha512
2952017-03-13T14:34:23 <BlueMatt> wumpus: well i was only looking at merge commits, i think github actually just had a hiccup
2962017-03-13T14:35:17 <BlueMatt> anyway, I restarted the build on the >=8 -addnode fix merge, which should pass this time, if there are any non-sha512-related failures we'll switch to pulling keys from in-repo
2972017-03-13T14:38:43 *** wudayoda has joined #bitcoin-core-dev
2982017-03-13T14:41:25 *** vFSgrcFGBJHg has joined #bitcoin-core-dev
2992017-03-13T14:43:27 *** wudayoda has quit IRC
3002017-03-13T14:45:35 *** MarcoFalke_lab has quit IRC
3012017-03-13T14:47:52 *** aalex__ has quit IRC
3022017-03-13T14:49:04 *** wudayoda has joined #bitcoin-core-dev
3032017-03-13T14:50:18 *** wudayoda has quit IRC
3042017-03-13T14:50:26 *** wudayoda has joined #bitcoin-core-dev
3052017-03-13T14:52:38 <wumpus> argh, git cat-file blob <blob> is slow compared to the current script
3062017-03-13T14:54:24 <wumpus> oh it can work in batch mode, that's cool
3072017-03-13T14:54:41 *** Blaise has joined #bitcoin-core-dev
3082017-03-13T14:54:42 *** dodomojo has joined #bitcoin-core-dev
3092017-03-13T14:54:52 <BlueMatt> wumpus: its hella slow
3102017-03-13T14:54:56 <BlueMatt> like, insanely slow
3112017-03-13T14:55:16 <wumpus> also in batch mode? I think the overhead right now is spawning a process for every file
3122017-03-13T14:55:40 <BlueMatt> hmm, not sure, didnt try, but you need to separate out different files for our current hash format
3132017-03-13T14:56:38 <wumpus> it prints a header per file
3142017-03-13T14:56:40 <wumpus> "84e7eb60d70d9fae3bdaae7f04f9f08fecaf2052 blob 150829"
3152017-03-13T14:56:48 <BlueMatt> ahh, ok
3162017-03-13T14:58:49 *** dodomojo has quit IRC
3172017-03-13T15:06:09 <wumpus> ooh it's fast in batch mode
3182017-03-13T15:07:25 <BlueMatt> argh, great, now i need to make verify-commits use batch mode
3192017-03-13T15:07:35 <BlueMatt> :P
3202017-03-13T15:15:10 <bitcoin-git> [bitcoin] laanwj opened pull request #9984: devtools: Make github-merge compute SHA512 from git, instead of worktree (master...2017_03_merge_hash_git) https://github.com/bitcoin/bitcoin/pull/9984
3212017-03-13T15:40:39 *** vogelito has joined #bitcoin-core-dev
3222017-03-13T15:43:07 *** vogelito has quit IRC
3232017-03-13T15:46:41 *** kexkey has quit IRC
3242017-03-13T15:48:33 *** vogelito has joined #bitcoin-core-dev
3252017-03-13T15:48:33 *** dodomojo has joined #bitcoin-core-dev
3262017-03-13T15:50:16 *** abpa has joined #bitcoin-core-dev
3272017-03-13T15:53:04 *** dodomojo has quit IRC
3282017-03-13T16:15:15 *** vogelito has quit IRC
3292017-03-13T16:16:44 *** vogelito has joined #bitcoin-core-dev
3302017-03-13T16:17:34 *** vogelito has joined #bitcoin-core-dev
3312017-03-13T16:18:14 *** vogelito has joined #bitcoin-core-dev
3322017-03-13T16:29:56 *** vogelito has joined #bitcoin-core-dev
3332017-03-13T16:45:06 <bitcoin-git> [bitcoin] NicolasDorier opened pull request #9985: [QT] Show more descriptive label for pay to yourself entries (master...watchonlylabel) https://github.com/bitcoin/bitcoin/pull/9985
3342017-03-13T16:48:44 *** wudayoda has quit IRC
3352017-03-13T16:49:56 *** goksinen has joined #bitcoin-core-dev
3362017-03-13T16:54:35 *** vogelito has quit IRC
3372017-03-13T17:21:43 *** vogelito has joined #bitcoin-core-dev
3382017-03-13T17:34:29 *** nemgun has joined #bitcoin-core-dev
3392017-03-13T17:36:34 *** vogelito has quit IRC
3402017-03-13T17:36:54 *** dodomojo has joined #bitcoin-core-dev
3412017-03-13T17:39:44 *** vogelito has joined #bitcoin-core-dev
3422017-03-13T17:41:01 *** vogelito has quit IRC
3432017-03-13T17:41:13 *** dodomojo has quit IRC
3442017-03-13T17:43:36 *** vogelito has joined #bitcoin-core-dev
3452017-03-13T17:59:25 *** BashCo has quit IRC
3462017-03-13T17:59:48 *** Victorsueca has quit IRC
3472017-03-13T18:00:01 *** BashCo has joined #bitcoin-core-dev
3482017-03-13T18:02:35 *** Victorsueca has joined #bitcoin-core-dev
3492017-03-13T18:04:20 *** BashCo has quit IRC
3502017-03-13T18:20:52 *** BashCo has joined #bitcoin-core-dev
3512017-03-13T18:24:43 *** wasi has quit IRC
3522017-03-13T18:31:04 *** dodomojo has joined #bitcoin-core-dev
3532017-03-13T18:35:28 *** dodomojo has quit IRC
3542017-03-13T18:56:30 *** vogelito has quit IRC
3552017-03-13T18:56:52 *** vogelito has joined #bitcoin-core-dev
3562017-03-13T19:16:20 *** nsh- is now known as nsh
3572017-03-13T19:24:49 *** vogelito has quit IRC
3582017-03-13T19:24:56 *** dodomojo has joined #bitcoin-core-dev
3592017-03-13T19:29:44 *** dodomojo has quit IRC
3602017-03-13T19:34:45 *** murchandamus11 has quit IRC
3612017-03-13T19:36:32 *** murchandamus has joined #bitcoin-core-dev
3622017-03-13T19:41:51 *** vogelito has joined #bitcoin-core-dev
3632017-03-13T19:58:48 *** vFSgrcFGBJHg has quit IRC
3642017-03-13T20:19:21 *** vogelito has quit IRC
3652017-03-13T20:29:34 *** vogelito has joined #bitcoin-core-dev
3662017-03-13T20:34:34 *** vogelito has quit IRC
3672017-03-13T20:35:05 <gmaxwell> Apparently IBD on 0.14 OOMs on 2GB (at least on an odroid c2, as expirenced by sipa and someone on reddit); due to the mempool loaning allowing it to achieve peak memory at IBD rather than sometime later.
3682017-03-13T20:35:20 <gmaxwell> I suppose it's better to crash during IBD rather than later...
3692017-03-13T20:39:54 <achow101> gmaxwell: someone has reported that in an issue and on bitcointalk too
3702017-03-13T20:40:41 <gmaxwell> achow101: well the answer for them right now is to lower their dbcache/maxmempool, I recommended 150/150.
3712017-03-13T20:41:01 <gmaxwell> It's not really a regression in 0.14, the same devices would eventually crash with 0.13.x, just later.
3722017-03-13T20:45:33 *** vogelito has joined #bitcoin-core-dev
3732017-03-13T20:46:08 <sipa> well, not necessarily, but they would with -dbcache=600
3742017-03-13T20:46:26 <sipa> so we've effectively just raised the default dbcache during IBD
3752017-03-13T20:51:05 <gmaxwell> sipa: say dbcache is 300, and mempool is 300.. eventually dbcache will be full and mempool will be full.... sooo similar peak memory usage, no?
3762017-03-13T20:51:23 <gmaxwell> (or would you argue that because the leveldb batch can result in 2x memory, that we should be adding half the mempool to the dbcache?)
3772017-03-13T20:56:09 <sipa> gmaxwell: right, that's what i'm saying
3782017-03-13T20:56:24 <sipa> with 300 MB dbcache + 300 MB mempool, you can use up to 900 MB at flush time
3792017-03-13T20:56:37 <sipa> with 600 MB dbcache + 0 MB mempool, you can use up to 1200 MB at flush time
3802017-03-13T20:57:22 <gmaxwell> so perhaps a patch we should do quickly and backport is to add half the unused memory to the dbcache. Can you see if that would make your odroid c2 successfully sync?
3812017-03-13T20:57:31 <sipa> BUT, we should probably halve the -dbcache setting as well, because someone who configures 2300 MB of dbcache does not expect the application to suddenly use 4600 MB, regardless of mempool borrowing
3822017-03-13T20:57:50 <gmaxwell> hm. so perhaps half the units, double the default?
3832017-03-13T20:57:58 <gmaxwell> halve*
3842017-03-13T20:58:17 <sipa> or just fix leveldb to not require the whole batch to be stored in a single std::string.
3852017-03-13T20:58:36 <gmaxwell> yea, but would we backport that for 0.14.1?
3862017-03-13T20:58:47 <sipa> depends on how trivial it is, i think
3872017-03-13T20:59:00 <gmaxwell> (I think we need to do something for 0.14.1 but it could be something dumb like halving the mempool loan)
3882017-03-13T21:00:03 <sipa> yeah, that would fix the 'unexpectedness' of the memory loaning
3892017-03-13T21:00:10 <sipa> but not the incorrectness of the estimate
3902017-03-13T21:03:21 <luke-jr> is there a reason to use dbcache post-sync?
3912017-03-13T21:04:06 <sipa> yes, much faster block verification
3922017-03-13T21:04:52 <sipa> even with sigcache
3932017-03-13T21:06:20 <luke-jr> but why not commit it after each post-sync block immediately?
3942017-03-13T21:06:33 <luke-jr> it doesn't grow that much from just one block, does it?
3952017-03-13T21:06:43 <sipa> it can grow by 20 MB or so from one block
3962017-03-13T21:06:48 *** afk11 has quit IRC
3972017-03-13T21:07:11 <sipa> and flushing slows down future blocks
3982017-03-13T21:07:16 <luke-jr> hmm
3992017-03-13T21:08:24 <sipa> with per-txout caching, the max (and typical) growth of the cache per block will be much less
4002017-03-13T21:08:36 <gmaxwell> much (most?) of dbcache's gains come from avoiding writes entirely for utxo that never need to make it to disk.
4012017-03-13T21:08:42 <sipa> indeed.
4022017-03-13T21:09:05 <sipa> though avoiding writes can always be moved out of the critical path of block validation
4032017-03-13T21:09:31 <sipa> in synced state, it still prevents recent utxos from needing to be read from disk
4042017-03-13T21:12:50 <nemgun> Hello guys, thank you for 0.14, i am resyncing, and it uses far less CPU
4052017-03-13T21:12:54 <luke-jr> sipa: aside from validation, that's probably useful for external tools accessing them via RPC?
4062017-03-13T21:13:45 <sipa> luke-jr: i believe gettxout will use the cache
4072017-03-13T21:13:56 *** afk11 has joined #bitcoin-core-dev
4082017-03-13T21:14:00 <sipa> luke-jr: gettxoutsetinfo always flushes to disk, and then iterates over the leveldb state
4092017-03-13T21:16:10 <TD-Linux> <gmaxwell> I suppose it's better to crash during IBD rather than later... <- yeah though super annoying when pruning.
4102017-03-13T21:19:15 <gmaxwell> oh my we should probably only be pruning after sync flushes.
4112017-03-13T21:20:57 <jouke> w/win 24
4122017-03-13T21:21:01 <jouke> >_<
4132017-03-13T21:21:38 <sipa> gmaxwell: we do
4142017-03-13T21:21:49 <sipa> pruning always triggers a flush
4152017-03-13T21:25:07 <TD-Linux> sipa, were you pruning on your c2? if so did you hit https://github.com/bitcoin/bitcoin/issues/9001
4162017-03-13T21:25:30 <sipa> TD-Linux: i'm not pruning (yet)
4172017-03-13T21:25:38 <sipa> 128GB microsd card ftw
4182017-03-13T21:36:43 *** goksinen has quit IRC
4192017-03-13T21:43:19 *** goksinen has joined #bitcoin-core-dev
4202017-03-13T21:52:52 *** owowo has quit IRC
4212017-03-13T22:24:34 *** nemgun has quit IRC
4222017-03-13T22:25:06 *** nemgun has joined #bitcoin-core-dev
4232017-03-13T22:25:11 *** nemgun1 has joined #bitcoin-core-dev
4242017-03-13T22:26:39 *** nemgun1 has quit IRC
4252017-03-13T22:26:39 *** nemgun has quit IRC
4262017-03-13T22:31:17 *** vogelito has quit IRC
4272017-03-13T22:33:12 *** Guyver2 has quit IRC
4282017-03-13T22:36:39 *** chjj has quit IRC
4292017-03-13T22:44:47 <luke-jr> I wonder if there's a safe way to catch bad_alloc, drop dbcache/mempool stuff, and resume cleanly?
4302017-03-13T22:50:14 *** afk11 has quit IRC
4312017-03-13T22:56:56 *** afk11 has joined #bitcoin-core-dev
4322017-03-13T22:58:25 *** vogelito has joined #bitcoin-core-dev
4332017-03-13T23:01:33 *** dodomojo has joined #bitcoin-core-dev
4342017-03-13T23:06:26 *** dodomojo has quit IRC
4352017-03-13T23:08:28 *** goksinen has quit IRC
4362017-03-13T23:11:17 *** goksinen has joined #bitcoin-core-dev
4372017-03-13T23:16:12 *** vogelito has quit IRC
4382017-03-13T23:16:39 *** vogelito has joined #bitcoin-core-dev
4392017-03-13T23:40:42 <bitcoin-git> [bitcoin] practicalswift opened pull request #9987: Remove unused code (master...remove-unused-code) https://github.com/bitcoin/bitcoin/pull/9987
4402017-03-13T23:55:25 *** dodomojo has joined #bitcoin-core-dev
4412017-03-13T23:59:38 *** abpa has quit IRC
4422017-03-13T23:59:56 *** dodomojo has quit IRC