1 2017-04-09T00:14:56  *** alpalp has joined #bitcoin-core-dev
  2 2017-04-09T00:14:56  *** alpalp has joined #bitcoin-core-dev
  3 2017-04-09T00:19:27  *** fremenWalking has joined #bitcoin-core-dev
  4 2017-04-09T00:30:05  *** Samdney has quit IRC
  5 2017-04-09T00:43:03  *** jtimon has joined #bitcoin-core-dev
  6 2017-04-09T00:59:08  *** Char0n has joined #bitcoin-core-dev
  7 2017-04-09T01:36:44  *** d_t has quit IRC
  8 2017-04-09T01:44:42  *** juscamarena has joined #bitcoin-core-dev
  9 2017-04-09T02:02:12  *** laurentmt has joined #bitcoin-core-dev
 10 2017-04-09T02:04:18  *** laurentmt has quit IRC
 11 2017-04-09T02:24:09  *** Ylbam has quit IRC
 12 2017-04-09T02:40:32  *** alpalp has quit IRC
 13 2017-04-09T02:50:24  *** vicenteH has quit IRC
 14 2017-04-09T03:05:40  *** jtimon has quit IRC
 15 2017-04-09T03:15:09  *** d_t has joined #bitcoin-core-dev
 16 2017-04-09T03:41:59  *** To7 has quit IRC
 17 2017-04-09T04:09:52  *** cryptapus has joined #bitcoin-core-dev
 18 2017-04-09T04:10:11  *** cryptapus is now known as cryptapus_afk
 19 2017-04-09T04:26:24  *** mol has joined #bitcoin-core-dev
 20 2017-04-09T04:29:28  *** molz_ has quit IRC
 21 2017-04-09T04:49:23  *** n1ce has quit IRC
 22 2017-04-09T04:49:36  *** justanotheruser has joined #bitcoin-core-dev
 23 2017-04-09T04:51:04  *** n1ce has joined #bitcoin-core-dev
 24 2017-04-09T04:52:01  *** cryptapus_afk has quit IRC
 25 2017-04-09T04:56:11  *** n1ce has quit IRC
 26 2017-04-09T04:56:13  *** cryptapus has joined #bitcoin-core-dev
 27 2017-04-09T04:56:14  *** cryptapus has joined #bitcoin-core-dev
 28 2017-04-09T04:56:38  *** cryptapus is now known as cryptapus_afk
 29 2017-04-09T05:24:52  *** btcdrak has quit IRC
 30 2017-04-09T06:28:26  *** juscamarena has quit IRC
 31 2017-04-09T06:28:49  *** juscamarena has joined #bitcoin-core-dev
 32 2017-04-09T06:31:03  *** juscamarena has joined #bitcoin-core-dev
 33 2017-04-09T06:37:04  *** juscamarena has quit IRC
 34 2017-04-09T06:37:20  *** dgenr8 has quit IRC
 35 2017-04-09T06:37:50  *** juscamarena has joined #bitcoin-core-dev
 36 2017-04-09T06:37:55  *** dgenr8 has joined #bitcoin-core-dev
 37 2017-04-09T06:39:39  *** CubicEarth has joined #bitcoin-core-dev
 38 2017-04-09T06:52:05  *** CubicEarth has quit IRC
 39 2017-04-09T06:53:03  *** juscamarena has quit IRC
 40 2017-04-09T06:56:24  *** juscamarena has joined #bitcoin-core-dev
 41 2017-04-09T06:58:24  *** juscamarena has quit IRC
 42 2017-04-09T06:58:57  *** juscamarena has joined #bitcoin-core-dev
 43 2017-04-09T06:59:12  *** btcdrak has joined #bitcoin-core-dev
 44 2017-04-09T07:03:27  *** juscamarena has quit IRC
 45 2017-04-09T07:04:05  *** juscamarena has joined #bitcoin-core-dev
 46 2017-04-09T07:05:50  *** Guyver2 has joined #bitcoin-core-dev
 47 2017-04-09T07:07:12  *** juscamarena has quit IRC
 48 2017-04-09T07:08:25  *** juscamarena has joined #bitcoin-core-dev
 49 2017-04-09T07:46:15  <wumpus> luke-jr: ok, feel free to change that
 50 2017-04-09T07:47:58  *** Ylbam has joined #bitcoin-core-dev
 51 2017-04-09T07:48:29  *** CubicEarth has joined #bitcoin-core-dev
 52 2017-04-09T07:51:30  *** Guyver2 has quit IRC
 53 2017-04-09T08:06:31  *** CubicEarth has quit IRC
 54 2017-04-09T08:11:23  *** d_t has quit IRC
 55 2017-04-09T08:26:44  *** juscamarena has quit IRC
 56 2017-04-09T08:31:25  *** juscamarena has joined #bitcoin-core-dev
 57 2017-04-09T08:47:10  *** juscamarena has quit IRC
 58 2017-04-09T09:01:41  *** PaulCapestany has quit IRC
 59 2017-04-09T09:18:14  *** PaulCapestany has joined #bitcoin-core-dev
 60 2017-04-09T09:41:21  *** vicenteH has joined #bitcoin-core-dev
 61 2017-04-09T10:22:20  *** AaronvanW has joined #bitcoin-core-dev
 62 2017-04-09T10:43:41  *** RCasatta has joined #bitcoin-core-dev
 63 2017-04-09T10:50:09  *** RCasatta has quit IRC
 64 2017-04-09T10:50:34  *** afk11 has quit IRC
 65 2017-04-09T10:50:35  *** ^arubi has quit IRC
 66 2017-04-09T10:50:35  *** wasi has quit IRC
 67 2017-04-09T10:51:50  *** jtimon has joined #bitcoin-core-dev
 68 2017-04-09T10:56:05  *** afk11 has joined #bitcoin-core-dev
 69 2017-04-09T10:58:13  *** arubi has joined #bitcoin-core-dev
 70 2017-04-09T11:31:06  <stevenroose> I haven't looked into Core's code too much, but I feel like there is quite a lack of code documentation..
 71 2017-04-09T11:31:08  <stevenroose> F.e. https://github.com/bitcoin/bitcoin/blob/f93f9b92969b4a3f77d3f1c2a30ba3bf558e0cac/src/txmempool.cpp#L759
 72 2017-04-09T11:31:22  <stevenroose> It says "compare" and returns a bool.
 73 2017-04-09T11:31:49  <stevenroose> Compare methods commonly return an int that is negative for <, 0 for == and positive for >
 74 2017-04-09T11:32:05  <stevenroose> Also, it might be useful to document what it is basing the comparison on
 75 2017-04-09T11:32:51  <stevenroose> Even thought the method name says depth and score, it doesn;t say if a higher depth and higher score mean higher ranking (which is then either true or false)
 76 2017-04-09T11:32:58  *** alpalp has joined #bitcoin-core-dev
 77 2017-04-09T11:32:58  *** alpalp has joined #bitcoin-core-dev
 78 2017-04-09T11:33:01  *** JackH_ is now known as JackH
 79 2017-04-09T11:38:09  *** Guest85725 has joined #bitcoin-core-dev
 80 2017-04-09T11:45:00  *** Guest85725 has quit IRC
 81 2017-04-09T12:03:19  *** Ruben has joined #bitcoin-core-dev
 82 2017-04-09T12:03:58  *** wasi has joined #bitcoin-core-dev
 83 2017-04-09T12:09:11  *** alpalp has quit IRC
 84 2017-04-09T12:28:04  *** felco has quit IRC
 85 2017-04-09T12:29:35  <sipa> stevenroose: in C++ a comparator is a function that acts like (a < b)
 86 2017-04-09T12:35:57  <gmaxwell> s/C++/stl/
 87 2017-04-09T12:41:53  *** Alina-malina has quit IRC
 88 2017-04-09T12:45:17  *** jtimon has quit IRC
 89 2017-04-09T12:46:38  *** Alina-malina has joined #bitcoin-core-dev
 90 2017-04-09T12:49:00  *** Alina-malina has quit IRC
 91 2017-04-09T12:49:00  *** Alina-malina has joined #bitcoin-core-dev
 92 2017-04-09T12:58:15  *** jouke has quit IRC
 93 2017-04-09T12:58:58  <sipa> gmaxwell: which is part of the C++ standard, but ok, other libraries can do things differently
 94 2017-04-09T13:00:23  *** jouke has joined #bitcoin-core-dev
 95 2017-04-09T13:06:15  *** Guyver2 has joined #bitcoin-core-dev
 96 2017-04-09T13:26:51  *** Ruben has quit IRC
 97 2017-04-09T13:30:43  *** Ruben has joined #bitcoin-core-dev
 98 2017-04-09T13:47:25  <sipa> gmaxwell: i guess i should have said "in c++ it is common practice to use comparators which compute the less-than relation"
 99 2017-04-09T13:50:13  *** d_t has joined #bitcoin-core-dev
100 2017-04-09T13:58:34  <gmaxwell> it just sounded weird to say "in C++"
101 2017-04-09T14:04:48  *** Samdney has joined #bitcoin-core-dev
102 2017-04-09T14:16:56  *** arowser has quit IRC
103 2017-04-09T14:18:10  *** Ruben has quit IRC
104 2017-04-09T14:18:12  *** moctos has joined #bitcoin-core-dev
105 2017-04-09T14:18:27  *** arowser has joined #bitcoin-core-dev
106 2017-04-09T14:19:27  *** mol has quit IRC
107 2017-04-09T14:22:49  *** moli_ has joined #bitcoin-core-dev
108 2017-04-09T14:23:35  *** moli_ has joined #bitcoin-core-dev
109 2017-04-09T14:43:30  *** moli_ has quit IRC
110 2017-04-09T14:43:48  <bitcoin-git> [bitcoin] sipa closed pull request #8087: Introduce CBlockchain and move CheckBlockHeader (master...2016-05-22-cblockchain) https://github.com/bitcoin/bitcoin/pull/8087
111 2017-04-09T14:44:04  *** moli_ has joined #bitcoin-core-dev
112 2017-04-09T15:36:15  *** jtimon has joined #bitcoin-core-dev
113 2017-04-09T15:55:02  *** Sosumi has joined #bitcoin-core-dev
114 2017-04-09T16:01:23  <bitcoin-git> [bitcoin] sipa closed pull request #9599: [WIP] Perform validation in a separate thread to message handling. (master...ValidationThread) https://github.com/bitcoin/bitcoin/pull/9599
115 2017-04-09T16:11:32  *** moctos has quit IRC
116 2017-04-09T16:11:35  *** Guyver2 has quit IRC
117 2017-04-09T16:23:26  *** RubenSomsen has joined #bitcoin-core-dev
118 2017-04-09T16:38:35  *** Ruben has joined #bitcoin-core-dev
119 2017-04-09T16:42:10  *** RubenSomsen has quit IRC
120 2017-04-09T16:46:34  *** RubenSomsen has joined #bitcoin-core-dev
121 2017-04-09T16:49:31  *** Ruben has quit IRC
122 2017-04-09T16:55:16  *** bitcoinreminder_ has joined #bitcoin-core-dev
123 2017-04-09T16:59:32  *** To7 has joined #bitcoin-core-dev
124 2017-04-09T17:00:52  *** Ruben has joined #bitcoin-core-dev
125 2017-04-09T17:04:31  *** RubenSomsen has quit IRC
126 2017-04-09T17:10:13  *** RubenSomsen has joined #bitcoin-core-dev
127 2017-04-09T17:13:10  *** Ruben has quit IRC
128 2017-04-09T17:26:36  *** Ruben has joined #bitcoin-core-dev
129 2017-04-09T17:28:11  *** RubenSomsen has quit IRC
130 2017-04-09T17:31:19  *** aantonop has joined #bitcoin-core-dev
131 2017-04-09T17:45:10  *** Ruben has quit IRC
132 2017-04-09T17:46:37  *** RubenSomsen has joined #bitcoin-core-dev
133 2017-04-09T17:56:06  *** Sosumi has quit IRC
134 2017-04-09T18:18:51  *** aantonop has quit IRC
135 2017-04-09T18:19:25  *** aantonop has joined #bitcoin-core-dev
136 2017-04-09T18:22:06  *** mol has joined #bitcoin-core-dev
137 2017-04-09T18:25:11  *** moli_ has quit IRC
138 2017-04-09T18:29:29  *** Giszmo has joined #bitcoin-core-dev
139 2017-04-09T18:30:17  *** aantonop has joined #bitcoin-core-dev
140 2017-04-09T18:39:50  *** d_t has joined #bitcoin-core-dev
141 2017-04-09T18:54:10  *** RubenSomsen has quit IRC
142 2017-04-09T19:04:53  *** dermoth has quit IRC
143 2017-04-09T19:05:00  *** dermoth_ has joined #bitcoin-core-dev
144 2017-04-09T19:05:30  *** dermoth_ is now known as dermoth
145 2017-04-09T19:14:10  *** Chris_Stewart_5 has quit IRC
146 2017-04-09T19:14:51  *** Giszmo has quit IRC
147 2017-04-09T19:19:32  *** dermoth has quit IRC
148 2017-04-09T19:29:47  *** Giszmo has joined #bitcoin-core-dev
149 2017-04-09T19:31:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
150 2017-04-09T19:32:08  *** dermoth has joined #bitcoin-core-dev
151 2017-04-09T19:36:53  *** aantonop has quit IRC
152 2017-04-09T19:37:34  *** owowo has quit IRC
153 2017-04-09T19:37:58  *** owowo has joined #bitcoin-core-dev
154 2017-04-09T19:43:53  *** aantonop has joined #bitcoin-core-dev
155 2017-04-09T19:44:52  *** aantonop has joined #bitcoin-core-dev
156 2017-04-09T19:48:26  *** dacox has quit IRC
157 2017-04-09T19:50:36  *** moli_ has joined #bitcoin-core-dev
158 2017-04-09T19:50:51  *** mol has quit IRC
159 2017-04-09T19:53:42  *** aantonop has quit IRC
160 2017-04-09T19:53:52  *** aantonop has joined #bitcoin-core-dev
161 2017-04-09T19:56:04  *** aantonop has joined #bitcoin-core-dev
162 2017-04-09T20:20:12  <stevenroose> well, fwiw, Go's sort.Interface.Less() method does the same thing, so I figured as much. but still "Less()" is more explanatory than "operator()". but thanks, I'm making sense of the code
163 2017-04-09T20:24:02  *** aantonop has quit IRC
164 2017-04-09T20:24:47  *** aantonop has joined #bitcoin-core-dev
165 2017-04-09T20:26:21  *** aantonop has quit IRC
166 2017-04-09T20:27:25  *** aantonop has joined #bitcoin-core-dev
167 2017-04-09T20:34:17  *** aantonop has quit IRC
168 2017-04-09T20:34:27  *** aantonop has joined #bitcoin-core-dev
169 2017-04-09T20:44:53  *** aantonop has quit IRC
170 2017-04-09T20:54:19  *** aantonop has joined #bitcoin-core-dev
171 2017-04-09T20:54:43  *** laurentmt has joined #bitcoin-core-dev
172 2017-04-09T21:22:02  *** felco has joined #bitcoin-core-dev
173 2017-04-09T22:01:09  *** marcoagner has joined #bitcoin-core-dev
174 2017-04-09T22:02:09  <sipa> stevenroose: and comments are always welcome :)
175 2017-04-09T22:26:05  *** aantonop has quit IRC
176 2017-04-09T22:33:05  *** arowser has quit IRC
177 2017-04-09T22:34:32  *** arowser has joined #bitcoin-core-dev
178 2017-04-09T22:36:10  *** marcoagner has quit IRC
179 2017-04-09T22:42:27  *** aantonop has joined #bitcoin-core-dev
180 2017-04-09T22:46:56  *** netsin has joined #bitcoin-core-dev
181 2017-04-09T22:48:34  *** netsin has quit IRC
182 2017-04-09T23:09:40  *** bsm1175321 has joined #bitcoin-core-dev
183 2017-04-09T23:09:51  *** jtimon has quit IRC
184 2017-04-09T23:10:34  *** laurentmt has quit IRC
185 2017-04-09T23:53:33  *** moctos has joined #bitcoin-core-dev
186 2017-04-09T23:53:39  *** moctos_ has joined #bitcoin-core-dev
187 2017-04-09T23:54:05  *** moctos has quit IRC
188 2017-04-09T23:54:05  *** moctos_ has quit IRC
189 2017-04-09T23:57:01  *** d9b4bef9 has quit IRC
190 2017-04-09T23:58:08  *** d9b4bef9 has joined #bitcoin-core-dev