1 2017-04-17T00:05:21  *** CubicEarth has quit IRC
  2 2017-04-17T00:14:05  *** str4d has joined #bitcoin-core-dev
  3 2017-04-17T00:29:23  *** AaronvanW has quit IRC
  4 2017-04-17T00:30:13  *** AaronvanW has joined #bitcoin-core-dev
  5 2017-04-17T00:34:40  *** AaronvanW has quit IRC
  6 2017-04-17T00:38:54  *** AaronvanW has joined #bitcoin-core-dev
  7 2017-04-17T00:46:27  *** AaronvanW has quit IRC
  8 2017-04-17T00:47:43  *** justan0theruser has joined #bitcoin-core-dev
  9 2017-04-17T00:50:32  *** justanotheruser has quit IRC
 10 2017-04-17T01:05:54  *** CubicEarth has joined #bitcoin-core-dev
 11 2017-04-17T01:06:21  <bitcoin-git> [bitcoin] jimmysong opened pull request #10219: Tests: Order Python Tests By Duration (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219
 12 2017-04-17T01:10:56  *** str4d has quit IRC
 13 2017-04-17T01:10:56  *** CubicEarth has quit IRC
 14 2017-04-17T01:11:09  *** tw2006 has joined #bitcoin-core-dev
 15 2017-04-17T01:15:55  *** tw2006 has quit IRC
 16 2017-04-17T01:20:27  *** dermoth has quit IRC
 17 2017-04-17T01:21:04  *** vicenteH has quit IRC
 18 2017-04-17T01:41:57  *** To7 has joined #bitcoin-core-dev
 19 2017-04-17T01:42:32  *** AaronvanW has joined #bitcoin-core-dev
 20 2017-04-17T01:47:07  *** AaronvanW has quit IRC
 21 2017-04-17T02:07:02  *** CubicEarth has joined #bitcoin-core-dev
 22 2017-04-17T02:11:52  *** CubicEarth has quit IRC
 23 2017-04-17T02:22:44  *** justan0theruser has quit IRC
 24 2017-04-17T02:24:30  *** justanotheruser has joined #bitcoin-core-dev
 25 2017-04-17T02:50:10  *** belcher has quit IRC
 26 2017-04-17T03:00:06  *** tw2006 has joined #bitcoin-core-dev
 27 2017-04-17T03:00:32  *** dodomojo has joined #bitcoin-core-dev
 28 2017-04-17T03:03:56  *** goksinen has quit IRC
 29 2017-04-17T03:04:48  *** tw2006 has quit IRC
 30 2017-04-17T03:07:45  *** CubicEarth has joined #bitcoin-core-dev
 31 2017-04-17T03:09:14  *** btcdrak has joined #bitcoin-core-dev
 32 2017-04-17T03:12:18  *** CubicEarth has quit IRC
 33 2017-04-17T03:37:22  *** baldur has quit IRC
 34 2017-04-17T03:43:21  *** AaronvanW has joined #bitcoin-core-dev
 35 2017-04-17T03:49:02  *** AaronvanW has quit IRC
 36 2017-04-17T03:50:13  *** CubicEarth has joined #bitcoin-core-dev
 37 2017-04-17T03:51:16  *** harrymm has quit IRC
 38 2017-04-17T03:59:05  *** dodomojo has quit IRC
 39 2017-04-17T04:49:11  *** tw2006 has joined #bitcoin-core-dev
 40 2017-04-17T04:53:36  *** tw2006 has quit IRC
 41 2017-04-17T05:05:28  *** crescendo has joined #bitcoin-core-dev
 42 2017-04-17T05:26:54  *** Kitkattatonix has joined #bitcoin-core-dev
 43 2017-04-17T05:34:34  *** RubenSomsen has joined #bitcoin-core-dev
 44 2017-04-17T05:45:29  *** AaronvanW has joined #bitcoin-core-dev
 45 2017-04-17T05:49:35  *** AaronvanW has quit IRC
 46 2017-04-17T06:04:41  *** Kitkattatonix has left #bitcoin-core-dev
 47 2017-04-17T06:07:13  *** afk11 has quit IRC
 48 2017-04-17T06:12:12  *** afk11 has joined #bitcoin-core-dev
 49 2017-04-17T06:16:49  *** belcher has joined #bitcoin-core-dev
 50 2017-04-17T06:17:13  *** belcher is now known as Guest80673
 51 2017-04-17T06:31:17  <wumpus> rc2 executables up https://bitcoin.org/bin/bitcoin-core-0.14.1/test.rc2/
 52 2017-04-17T06:36:50  *** SopaXorzTaker has joined #bitcoin-core-dev
 53 2017-04-17T06:38:01  *** tw2006 has joined #bitcoin-core-dev
 54 2017-04-17T06:42:53  *** tw2006 has quit IRC
 55 2017-04-17T06:44:53  <wumpus> don't think this will need a long testing time, given the minor changes relative to rc1
 56 2017-04-17T07:01:29  *** NewLiberty_ has joined #bitcoin-core-dev
 57 2017-04-17T07:01:30  *** d_t_ has joined #bitcoin-core-dev
 58 2017-04-17T07:03:58  *** NewLiberty has quit IRC
 59 2017-04-17T07:04:02  *** d_t has quit IRC
 60 2017-04-17T07:10:28  *** AaronvanW has joined #bitcoin-core-dev
 61 2017-04-17T07:17:14  *** AaronvanW has quit IRC
 62 2017-04-17T07:17:46  *** d_t_ has quit IRC
 63 2017-04-17T07:18:35  *** AaronvanW has joined #bitcoin-core-dev
 64 2017-04-17T07:31:02  *** vicenteH has joined #bitcoin-core-dev
 65 2017-04-17T07:42:15  *** AaronvanW has quit IRC
 66 2017-04-17T07:43:17  *** AaronvanW has joined #bitcoin-core-dev
 67 2017-04-17T08:08:36  <wumpus> is it just me or is test_runner.py really slow now on master?
 68 2017-04-17T08:09:26  <wumpus> huh only happens on one vm, must be me
 69 2017-04-17T08:19:05  *** AaronvanW has quit IRC
 70 2017-04-17T08:19:22  <wumpus> what I don't understand is that this is a much faster machine just much slower at running the tests
 71 2017-04-17T08:20:27  *** AaronvanW has joined #bitcoin-core-dev
 72 2017-04-17T08:20:42  <sipa> slow i/9?
 73 2017-04-17T08:20:49  <sipa> i/o?
 74 2017-04-17T08:24:46  <MarcoFalke> we should really collect statistics about the tests such as run time and then plot them over time.
 75 2017-04-17T08:25:09  <MarcoFalke> I think we had a regression in the wallet once that made the wallet test run really slow...
 76 2017-04-17T08:25:21  <wumpus> fast/old computer: 3.98user 1.26system 0:33.90elapsed 15%CPU (0avgtext+0avgdata 57976maxresident)k 8inputs+42776outputs (0major+107146minor)pagefaults 0swaps
 77 2017-04-17T08:25:34  <wumpus> slow/new computer: 7.29user 2.48system 1:42.07elapsed 9%CPU (0avgtext+0avgdata 57904maxresident)k 0inputs+45776outputs (0major+108208minor)pagefaults 0swaps
 78 2017-04-17T08:25:58  <wumpus> (both for fundrawtransaction test)
 79 2017-04-17T08:26:22  <wumpus> to me it looks like it's just spending more time waiting
 80 2017-04-17T08:27:00  *** tw2006 has joined #bitcoin-core-dev
 81 2017-04-17T08:27:41  <MarcoFalke> tearing down the nodes takes ages for tiny tests compared to the test's actual run time
 82 2017-04-17T08:29:54  <gmaxwell> unfortunately with the test running on shared vm infrastructure timings are probably not all that useful.
 83 2017-04-17T08:31:28  *** tw2006 has quit IRC
 84 2017-04-17T08:34:19  *** CubicEarth has quit IRC
 85 2017-04-17T08:41:20  <wumpus> it probably doesn't help rpc performance from python that authproxy calls log.debug for all data that comes in and goes out, pretty-printing everything even though usually it's discarded
 86 2017-04-17T08:41:35  <wumpus> (not likely the cause of my slowdown, just noticed)
 87 2017-04-17T08:42:43  *** AaronvanW has quit IRC
 88 2017-04-17T08:45:11  *** AaronvanW has joined #bitcoin-core-dev
 89 2017-04-17T08:55:34  <MarcoFalke> Indeed, no wall clock, but maybe cpu_time, memory_peak and io could help.
 90 2017-04-17T08:55:50  <wumpus> I'm on to something maybe, a getnewaddress call takes 0.013565 on the one system, 0.168683 (more than ten times as much) on the other. Could be slow i/o, but that slow?
 91 2017-04-17T08:56:10  <wumpus> this does not seem to extend to most other RPC calls (though havne't looked at them all)
 92 2017-04-17T08:56:33  <gmaxwell> well getnewaddress is syncing the wallet... so fsync time?
 93 2017-04-17T08:56:40  <sipa> we do a db sync operatiom after every new address
 94 2017-04-17T08:56:43  <sipa> jinx
 95 2017-04-17T08:57:32  <wumpus> if so we need a flag to disable that for the tests
 96 2017-04-17T08:58:29  <wumpus> fsync slow makes sense, I've noticed that before, I think it tries to sync the entire partition image
 97 2017-04-17T08:58:30  <gmaxwell> there is that eatmydata thing that could be used with tests.
 98 2017-04-17T08:59:14  <wumpus> cool, didn't know about that one
 99 2017-04-17T09:02:52  <sipa> s/partition/filesystem
100 2017-04-17T09:03:16  <sipa> i think? or is literally the disk block cache?
101 2017-04-17T09:03:36  <wumpus> yes, filesystem
102 2017-04-17T09:04:36  <wumpus> or not sure really
103 2017-04-17T09:04:56  <wumpus> it might as well be trying to sync the entire virtual disk to disk
104 2017-04-17T09:06:17  <sipa> but syncing of a filesystem needs dependency information between sectors, or you may end up with an inonsistent state
105 2017-04-17T09:06:37  <wumpus> I suspect it's something like that at least: fsync() inside the VM has file granularity, but qemu calling fsync() has complete file system granularity
106 2017-04-17T09:06:39  <sipa> so even if it's a disk level cache, it needs information from the filesystem to order the wrotes
107 2017-04-17T09:07:33  <wumpus> so not only the wallet is fsynced, but also all the other things the tests do such as writing tons of log files
108 2017-04-17T09:07:56  <wumpus> anyhow I'll try with the eatmydata and see if it resolves the slowdown
109 2017-04-17T09:08:35  *** AaronvanW has quit IRC
110 2017-04-17T09:09:57  *** AaronvanW has joined #bitcoin-core-dev
111 2017-04-17T09:10:55  <wumpus> yes!
112 2017-04-17T09:11:31  <wumpus> old computer: 3.73user 1.04system 0:39.09elapsed 12%CPU (0avgtext+0avgdata 61112maxresident)k 8inputs+9064outputs (0major+45873minor)pagefaults 0swaps
113 2017-04-17T09:11:43  <wumpus> new computer: 3.24user 0.78system 0:33.70elapsed 11%CPU (0avgtext+0avgdata 57832maxresident)k 0inputs+10472outputs (0major+108842minor)pagefaults 0swaps
114 2017-04-17T09:12:13  <wumpus> more than three times as fast as before
115 2017-04-17T09:12:39  <wumpus> wonder if this will help travis too
116 2017-04-17T09:14:19  *** Ylbam has joined #bitcoin-core-dev
117 2017-04-17T09:20:16  <bitcoin-git> [bitcoin] laanwj opened pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
118 2017-04-17T09:25:05  *** AaronvanW has quit IRC
119 2017-04-17T09:42:25  *** Guyver2 has joined #bitcoin-core-dev
120 2017-04-17T09:57:38  *** Guest80673 has quit IRC
121 2017-04-17T09:57:59  *** belcher has joined #bitcoin-core-dev
122 2017-04-17T09:58:00  *** belcher has quit IRC
123 2017-04-17T09:58:00  *** belcher has joined #bitcoin-core-dev
124 2017-04-17T10:00:40  *** To7 has quit IRC
125 2017-04-17T10:12:16  *** SopaXorzTaker has quit IRC
126 2017-04-17T10:13:51  *** SopaXorzTaker has joined #bitcoin-core-dev
127 2017-04-17T10:15:54  *** tw2006 has joined #bitcoin-core-dev
128 2017-04-17T10:20:35  *** tw2006 has quit IRC
129 2017-04-17T10:28:23  *** belcher has quit IRC
130 2017-04-17T10:54:55  *** btcdrak has quit IRC
131 2017-04-17T11:03:12  *** btcdrak has joined #bitcoin-core-dev
132 2017-04-17T11:03:42  *** Guyver2 has quit IRC
133 2017-04-17T11:18:45  <wumpus> so apparently on travis, eatmydata gives a 2x gain (thanks for testing MarcoFalke), not as good as in my VM (I may have some misconfiguration) but still nice
134 2017-04-17T11:19:36  <sipa> nice indeed!
135 2017-04-17T11:21:29  *** jannes has joined #bitcoin-core-dev
136 2017-04-17T11:30:11  <SopaXorzTaker> offtopic PSA
137 2017-04-17T11:30:24  <SopaXorzTaker> wumpus, sipa, the large bitcoin collider client script is untrustworthy
138 2017-04-17T11:30:38  <SopaXorzTaker> refrain from running it until the author gives explanations
139 2017-04-17T11:30:41  *** laurentmt has joined #bitcoin-core-dev
140 2017-04-17T11:31:30  <sipa> don't worry, i had no intention of running it
141 2017-04-17T11:33:54  *** RubenSomsen has quit IRC
142 2017-04-17T11:34:11  *** AaronvanW has joined #bitcoin-core-dev
143 2017-04-17T11:35:51  <SopaXorzTaker> PSA on reddit: https://www.reddit.com/r/Bitcoin/comments/65uoaq/do_not_run_the_large_bitcoin_collider_client_its/
144 2017-04-17T11:35:57  <SopaXorzTaker> just FYI
145 2017-04-17T11:38:35  *** AaronvanW has quit IRC
146 2017-04-17T11:43:29  *** AaronvanW has joined #bitcoin-core-dev
147 2017-04-17T11:52:02  *** AaronvanW has quit IRC
148 2017-04-17T11:52:16  *** AaronvanW has joined #bitcoin-core-dev
149 2017-04-17T11:55:03  *** jtimon has joined #bitcoin-core-dev
150 2017-04-17T11:58:57  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f4db00f9a548...c5e9e428a919
151 2017-04-17T11:58:58  <bitcoin-git> bitcoin/master 45f0961 Gregory Maxwell: Prevent integer overflow in ReadVarInt....
152 2017-04-17T11:58:58  <bitcoin-git> bitcoin/master c5e9e42 Pieter Wuille: Merge #9693: Prevent integer overflow in ReadVarInt....
153 2017-04-17T11:59:12  <bitcoin-git> [bitcoin] sipa closed pull request #9693: Prevent integer overflow in ReadVarInt. (master...varint_maxsize) https://github.com/bitcoin/bitcoin/pull/9693
154 2017-04-17T12:00:27  *** laurentmt has quit IRC
155 2017-04-17T12:04:49  *** tw2006 has joined #bitcoin-core-dev
156 2017-04-17T12:09:23  *** tw2006 has quit IRC
157 2017-04-17T12:16:00  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5e9e428a919...a077a90da88f
158 2017-04-17T12:16:00  <bitcoin-git> bitcoin/master b2c9254 Matt Corallo: Check interruptNet during dnsseed lookups
159 2017-04-17T12:16:01  <bitcoin-git> bitcoin/master a077a90 Pieter Wuille: Merge #10215: Check interruptNet during dnsseed lookups...
160 2017-04-17T12:16:23  <bitcoin-git> [bitcoin] sipa closed pull request #10215: Check interruptNet during dnsseed lookups (master...2017-04-dnsseed-break) https://github.com/bitcoin/bitcoin/pull/10215
161 2017-04-17T12:41:26  *** laurentmt has joined #bitcoin-core-dev
162 2017-04-17T12:46:44  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a077a90da88f...2584925077f9
163 2017-04-17T12:46:45  <bitcoin-git> bitcoin/master d89f8ad Matt Corallo: Make DisconnectBlock and ConnectBlock static in validation.cpp
164 2017-04-17T12:46:45  <bitcoin-git> bitcoin/master 9fececb Matt Corallo: Remove CValidationInterface::UpdatedTransaction...
165 2017-04-17T12:46:46  <bitcoin-git> bitcoin/master 2584925 Wladimir J. van der Laan: Merge #10178: Remove CValidationInterface::UpdatedTransaction...
166 2017-04-17T12:47:02  <bitcoin-git> [bitcoin] laanwj closed pull request #10178: Remove CValidationInterface::UpdatedTransaction (master...2017-01-wallet-cache-inmempool-2) https://github.com/bitcoin/bitcoin/pull/10178
167 2017-04-17T13:07:02  *** dermoth has joined #bitcoin-core-dev
168 2017-04-17T13:18:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
169 2017-04-17T13:27:45  *** tw2006 has joined #bitcoin-core-dev
170 2017-04-17T13:35:18  *** cryptapus_afk is now known as cryptapus
171 2017-04-17T13:39:47  <wumpus> SopaXorzTaker: good sleuthing, but no, you don't have to be afraid I run random scripts from the internet on anything important, let alone bitcoin-related ones
172 2017-04-17T13:39:51  *** d9b4bef9 has quit IRC
173 2017-04-17T13:40:57  *** d9b4bef9 has joined #bitcoin-core-dev
174 2017-04-17T13:50:05  <SopaXorzTaker> wumpus, yeah
175 2017-04-17T13:50:18  <SopaXorzTaker> but this script actually does remote code execution
176 2017-04-17T13:53:16  <wumpus> the whole premise is a bit scammy; it reminds me of the trojans in the 90's whose control component had a trojan too. So everyone using the trojan to grief other people got owned themselves too...
177 2017-04-17T13:55:06  <luke-jr> what is it even supposed to do?
178 2017-04-17T13:55:10  <wumpus> people running this script try to steal coins by generating random private keys. This is incredibly unlikely, and if it worked it'd be wrong in various ways
179 2017-04-17T13:55:18  <luke-jr> lol
180 2017-04-17T13:55:45  <luke-jr> bruteforcing privkeys is just ridiculous to attempt, but to do it with *Perl code*? lololol
181 2017-04-17T13:56:34  <luke-jr> at face value, it's obvious the only purpose is to be a backdoor
182 2017-04-17T13:56:41  <SopaXorzTaker> luke-jr, well
183 2017-04-17T13:56:56  <SopaXorzTaker> it's actually done with an inner C program which is natively compiled by the script
184 2017-04-17T13:57:08  <SopaXorzTaker> actually, the bruteforcing has some results
185 2017-04-17T13:57:16  <sipa> and it seems to have OpenCL code too
186 2017-04-17T13:57:21  <SopaXorzTaker> there were some addresses deliberately generated with weak PRNGs
187 2017-04-17T13:59:55  *** Cheeseo has joined #bitcoin-core-dev
188 2017-04-17T13:59:55  *** Cheeseo has joined #bitcoin-core-dev
189 2017-04-17T14:01:52  <wumpus> yes, if it mimimcs specific bad PRNGs (or bad brainwallets) instead of simply randomly generating keys it can certainly turn up something
190 2017-04-17T14:03:04  <sipa> including things put there by the script's author :)
191 2017-04-17T14:03:42  <SopaXorzTaker> wumpus, yes
192 2017-04-17T14:03:52  <SopaXorzTaker> there is a so-called puzzle transaction
193 2017-04-17T14:03:54  <SopaXorzTaker> with 32 BTC
194 2017-04-17T14:03:56  <SopaXorzTaker> look it up
195 2017-04-17T14:04:11  <SopaXorzTaker> each address uses a key one bit stronger than the previous one
196 2017-04-17T14:04:19  <SopaXorzTaker> (there's 256 addresses)
197 2017-04-17T14:04:30  <SopaXorzTaker> eg. 0000..0001
198 2017-04-17T14:04:36  <SopaXorzTaker> 0000..0011
199 2017-04-17T14:04:39  <SopaXorzTaker> 0000..0101
200 2017-04-17T14:04:43  <SopaXorzTaker> 0000..1011
201 2017-04-17T14:04:46  <SopaXorzTaker> and  so on
202 2017-04-17T14:06:46  <wumpus> yes, for the author it could be very profitable, and no need to bruteforce at all, just stealing all the wallets of people running this
203 2017-04-17T14:08:16  <wumpus> in a way it's the classical con, make people believe something that's too good to be true
204 2017-04-17T14:18:00  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf (master...2017-04-no-coinbase-display-lag) https://github.com/bitcoin/bitcoin/pull/10221
205 2017-04-17T14:24:44  *** To7 has joined #bitcoin-core-dev
206 2017-04-17T15:08:42  *** btcdrak has quit IRC
207 2017-04-17T15:11:14  *** btcdrak has joined #bitcoin-core-dev
208 2017-04-17T15:21:08  *** altoz has joined #bitcoin-core-dev
209 2017-04-17T15:22:56  *** altoz has left #bitcoin-core-dev
210 2017-04-17T15:23:42  *** altoz has joined #bitcoin-core-dev
211 2017-04-17T15:26:15  *** tw2006 has quit IRC
212 2017-04-17T15:28:27  *** tw2006 has joined #bitcoin-core-dev
213 2017-04-17T15:33:35  *** luke-jr has quit IRC
214 2017-04-17T15:33:36  *** tw2006 has quit IRC
215 2017-04-17T15:35:11  *** luke-jr has joined #bitcoin-core-dev
216 2017-04-17T15:35:59  *** str4d has joined #bitcoin-core-dev
217 2017-04-17T15:40:27  *** str4d has quit IRC
218 2017-04-17T15:46:39  *** abpa has joined #bitcoin-core-dev
219 2017-04-17T15:48:31  *** cryptapus is now known as cryptapus_afk
220 2017-04-17T16:13:39  <morcos> I'm happy enough to just exclude in all my bitcoin.conf files, but just want to see if everyone else is ok with the leveldb log spam...  it prints a lot of useless messages right at startup (where everythign else you care about is printed)
221 2017-04-17T16:17:37  <morcos> I'm not sure exactly what information we're expecting from the leveldb logging, so maybe there is a better solution that concentrates on that infomration or at least cleanly aggregating at startup..  it's not really clear to me how to make much use of what it does log
222 2017-04-17T16:20:01  <sipa> only when you enable the relevant debug category?
223 2017-04-17T16:20:17  <morcos> sipa: i assume, but my habit is to always enable all
224 2017-04-17T16:22:09  *** Giszmo has quit IRC
225 2017-04-17T16:22:18  *** Giszmo has joined #bitcoin-core-dev
226 2017-04-17T16:29:08  *** chjj has quit IRC
227 2017-04-17T16:29:30  *** tw2006 has joined #bitcoin-core-dev
228 2017-04-17T16:34:23  *** tw2006 has quit IRC
229 2017-04-17T16:37:37  <wumpus> the more debugging is added, the less useful it becomes to run with debug=all
230 2017-04-17T16:37:56  *** mol has joined #bitcoin-core-dev
231 2017-04-17T16:38:42  <wumpus> though I'm fine with a debug=alllowvolume or such if you want to add that, which excludes at least leveldb and libevent
232 2017-04-17T16:40:24  *** moli_ has quit IRC
233 2017-04-17T16:40:34  <wumpus> but usually the recommedation is to add debug categories only when troubleshooting a certain subsystem; this became even easier with the RPC call to turn on/off individual debug flags
234 2017-04-17T16:41:26  *** belcher has joined #bitcoin-core-dev
235 2017-04-17T16:41:28  *** belcher has quit IRC
236 2017-04-17T16:41:28  *** belcher has joined #bitcoin-core-dev
237 2017-04-17T16:42:33  *** chjj has joined #bitcoin-core-dev
238 2017-04-17T16:51:29  *** xiangfu has quit IRC
239 2017-04-17T16:51:53  *** fengling has quit IRC
240 2017-04-17T17:13:13  *** laurentmt has quit IRC
241 2017-04-17T17:20:24  *** laurentmt has joined #bitcoin-core-dev
242 2017-04-17T17:21:12  <jtimon> is there any advantage to Q_FOREACH over c++11 foreach?
243 2017-04-17T17:25:30  <wumpus> no
244 2017-04-17T17:26:37  <wumpus> fairly sure c++11 foreach will work with qt objects too
245 2017-04-17T17:26:51  *** d9b4bef9 has quit IRC
246 2017-04-17T17:27:56  *** d9b4bef9 has joined #bitcoin-core-dev
247 2017-04-17T17:28:50  *** d9b4bef9 has quit IRC
248 2017-04-17T17:29:56  *** d9b4bef9 has joined #bitcoin-core-dev
249 2017-04-17T17:36:12  <jtimon> wumpus: it seems performance can be worse in some cases: https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/
250 2017-04-17T17:37:08  <jtimon> I mean, not in a way that it can't be solved
251 2017-04-17T17:40:43  *** arubi has quit IRC
252 2017-04-17T17:40:51  *** arubi_ has joined #bitcoin-core-dev
253 2017-04-17T17:43:35  <sipa> hmm, seems to be about some specifics with Qt containers
254 2017-04-17T17:46:42  *** xiangfu has joined #bitcoin-core-dev
255 2017-04-17T17:50:53  *** fengling has joined #bitcoin-core-dev
256 2017-04-17T18:03:17  <jtimon> the reason I ask is because I was trying to remove PAIRTYPE and it seems Q_FOREACH requires it too, I'm not completely sure though, I'm compiling removing Q_FOREACH  first and then I'll try again without removing Q_FOREACH  in case we prefer to keep it, but only -j4 since I'm on the laptop...
257 2017-04-17T18:16:22  *** paveljanik has joined #bitcoin-core-dev
258 2017-04-17T18:17:45  <bitcoin-git> [bitcoin] jnewbery opened pull request #10222: [tests] test_runner - check unicode (master...test_runner_check_unicode) https://github.com/bitcoin/bitcoin/pull/10222
259 2017-04-17T18:18:25  *** tw2006 has joined #bitcoin-core-dev
260 2017-04-17T18:23:26  *** tw2006 has quit IRC
261 2017-04-17T18:46:42  *** d_t has joined #bitcoin-core-dev
262 2017-04-17T18:49:10  *** arubi_ is now known as arubi
263 2017-04-17T18:50:53  *** molz_ has joined #bitcoin-core-dev
264 2017-04-17T18:53:48  *** mol has quit IRC
265 2017-04-17T19:20:03  *** belcher has quit IRC
266 2017-04-17T19:20:39  *** talmai has joined #bitcoin-core-dev
267 2017-04-17T19:50:40  *** Dyaheon has quit IRC
268 2017-04-17T19:52:49  *** SopaXorzTaker has quit IRC
269 2017-04-17T19:53:29  *** jnewbery has quit IRC
270 2017-04-17T19:57:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2584925077f9...6ce733747e16
271 2017-04-17T19:57:18  <bitcoin-git> bitcoin/master a97ed80 John Newbery: [tests] test_runner - check unicode
272 2017-04-17T19:57:19  <bitcoin-git> bitcoin/master 6ce7337 MarcoFalke: Merge #10222: [tests] test_runner - check unicode...
273 2017-04-17T19:57:48  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10222: [tests] test_runner - check unicode (master...test_runner_check_unicode) https://github.com/bitcoin/bitcoin/pull/10222
274 2017-04-17T20:02:52  *** jtimon has quit IRC
275 2017-04-17T20:02:53  *** NewLiberty_ is now known as NewLiberty
276 2017-04-17T20:07:10  <BlueMatt> sipa: hey
277 2017-04-17T20:07:19  *** tw2006 has joined #bitcoin-core-dev
278 2017-04-17T20:11:53  *** tw2006 has quit IRC
279 2017-04-17T20:12:57  <BlueMatt> re: #10148's Clear() in ApplyTxInUndo: hmm, you may be right, anyway, dear god this is not trivial to reason about :/
280 2017-04-17T20:12:59  <gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
281 2017-04-17T20:13:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ce733747e16...50a1cc0f0aef
282 2017-04-17T20:13:45  <bitcoin-git> bitcoin/master c9e31c3 Warren Togami: Clarify importprivkey help text with example of blank label without rescan...
283 2017-04-17T20:13:45  <bitcoin-git> bitcoin/master 50a1cc0 MarcoFalke: Merge #10207: Clarify importprivkey help text ... example of blank label without rescan...
284 2017-04-17T20:14:07  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10207: Clarify importprivkey help text ... example of blank label without rescan (master...importprivkey) https://github.com/bitcoin/bitcoin/pull/10207
285 2017-04-17T20:20:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/50a1cc0f0aef...d86bb075bf6d
286 2017-04-17T20:20:28  <bitcoin-git> bitcoin/master c85b080 John Newbery: [test] add warnings to test_runner
287 2017-04-17T20:20:28  <bitcoin-git> bitcoin/master 08e51c1 John Newbery: [tests] Remove cache directory by default when running test_runner
288 2017-04-17T20:20:29  <bitcoin-git> bitcoin/master d86bb07 MarcoFalke: Merge #10197: [tests] Functional test warnings...
289 2017-04-17T20:20:47  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10197: [tests] Functional test warnings (master...functional_test_warnings) https://github.com/bitcoin/bitcoin/pull/10197
290 2017-04-17T20:23:05  *** rockhouse has quit IRC
291 2017-04-17T20:24:29  *** jnewbery has joined #bitcoin-core-dev
292 2017-04-17T20:28:40  <sipa> BlueMatt: i'm going to add a WIP to the title, i'm not confortable with merging until there are more substantial tests
293 2017-04-17T20:29:53  <BlueMatt> yea, I was starting to feel the same way....I mean alternatively we could drop the multi-head support and only support single-action (ie a series of connects/disconnects) between full flushes, which would simplify things and go back to a bit more how it was until you rewrote a bunch
294 2017-04-17T20:29:57  <BlueMatt> sipa: ^
295 2017-04-17T20:32:51  <sipa> BlueMatt: i think it is fine to only test the single-head case for now
296 2017-04-17T20:33:11  <sipa> at worst, the result is not backward compatible omce we need muktihead
297 2017-04-17T20:33:17  <sipa> *multi once
298 2017-04-17T20:33:25  <BlueMatt> sipa: well my point was just the implementation of the multi-head-handling case is complicated enough that it adds a ton of review burden
299 2017-04-17T20:33:33  <BlueMatt> esp pre-utxo-db-format-change
300 2017-04-17T20:34:00  <BlueMatt> may be easier to just do it single-head-only, then do utxo-db, then change to multi-head...if we break compat there its ok
301 2017-04-17T20:34:39  <sipa> the multihead code and pertxout are orthogonal, i think
302 2017-04-17T20:34:57  *** chjj has quit IRC
303 2017-04-17T20:35:38  <BlueMatt> i havent dug too much into pertxout yet, but shouldnt it simplify things, or is there still a concept of per-tx CCoins everywhere above the db?
304 2017-04-17T20:36:06  <BlueMatt> my assumption was the review for this would be much simpler if you dont have to think about making sure entire transaction objects are correct, instead of there just being add/remove-outputs
305 2017-04-17T20:36:37  <BlueMatt> at least i found it much easier to review prior to the latest changes, even ignoring the handle-disconnect stuff
306 2017-04-17T20:36:40  <gmaxwell> I think they turn out to be pretty much orthorgonal.
307 2017-04-17T20:37:23  <gmaxwell> okay thats a point.
308 2017-04-17T20:43:34  *** laurentmt1 has joined #bitcoin-core-dev
309 2017-04-17T20:43:59  <sipa> BlueMatt: the Clean call is indeed a possible violation of that orthogonality...
310 2017-04-17T20:44:20  <BlueMatt> that was my primary example, indeed
311 2017-04-17T20:44:36  *** laurentmt has quit IRC
312 2017-04-17T20:44:36  *** laurentmt1 is now known as laurentmt
313 2017-04-17T20:44:52  *** AaronvanW has quit IRC
314 2017-04-17T20:45:58  *** AaronvanW has joined #bitcoin-core-dev
315 2017-04-17T20:46:10  <sipa> i don't think there are any others, but it is a fair point that pertxout is breaking backward xcompatibility already, so perhaps attempting to already support multihead isn't actually worth it
316 2017-04-17T20:46:21  <sipa> but i think the complexity is mostly in testing
317 2017-04-17T20:46:52  <sipa> the difference in implementation between multihead and single head is just that loop and building of a set
318 2017-04-17T20:47:06  <BlueMatt> ok, i found the building of a set hard to reason about :p
319 2017-04-17T20:47:35  <sipa> fair enough, but you can reason about the cases that are relevant for single head?
320 2017-04-17T20:47:57  *** belcher has joined #bitcoin-core-dev
321 2017-04-17T20:47:59  *** belcher has quit IRC
322 2017-04-17T20:47:59  *** belcher has joined #bitcoin-core-dev
323 2017-04-17T20:48:33  <BlueMatt> probably? dunno, i was more tired today than previous days, so there may also be a skew there :p
324 2017-04-17T20:49:11  *** chjj has joined #bitcoin-core-dev
325 2017-04-17T20:49:13  <sipa> well, maybe it is best to explain the full algorithm and reasoning why it is correct in text in comments
326 2017-04-17T20:50:35  *** AaronvanW has quit IRC
327 2017-04-17T20:53:13  *** talmai has quit IRC
328 2017-04-17T21:06:13  *** talmai has joined #bitcoin-core-dev
329 2017-04-17T21:07:35  *** chjj has quit IRC
330 2017-04-17T21:21:00  *** chjj has joined #bitcoin-core-dev
331 2017-04-17T21:36:13  *** Dyaheon has joined #bitcoin-core-dev
332 2017-04-17T21:52:38  *** talmai has quit IRC
333 2017-04-17T21:56:17  *** tw2006 has joined #bitcoin-core-dev
334 2017-04-17T22:00:59  *** tw2006 has quit IRC
335 2017-04-17T22:08:45  *** AaronvanW has joined #bitcoin-core-dev
336 2017-04-17T22:14:37  *** Giszmo has quit IRC
337 2017-04-17T22:15:19  *** Giszmo has joined #bitcoin-core-dev
338 2017-04-17T22:21:13  *** AaronvanW has quit IRC
339 2017-04-17T22:23:23  *** AaronvanW has joined #bitcoin-core-dev
340 2017-04-17T22:27:27  *** justanotheruser has quit IRC
341 2017-04-17T22:30:35  *** AaronvanW has quit IRC
342 2017-04-17T22:31:13  *** justanotheruser has joined #bitcoin-core-dev
343 2017-04-17T22:33:05  *** jannes has quit IRC
344 2017-04-17T22:43:05  *** vicenteH has quit IRC
345 2017-04-17T23:03:00  *** root-servers_ has joined #bitcoin-core-dev
346 2017-04-17T23:19:43  *** chjj has quit IRC
347 2017-04-17T23:24:08  *** Dyaheon has quit IRC
348 2017-04-17T23:33:00  *** chjj has joined #bitcoin-core-dev
349 2017-04-17T23:34:44  *** root-servers_ has quit IRC
350 2017-04-17T23:37:36  *** d_t has quit IRC
351 2017-04-17T23:45:07  *** tw2006 has joined #bitcoin-core-dev
352 2017-04-17T23:49:47  *** tw2006 has quit IRC
353 2017-04-17T23:50:28  *** AaronvanW has joined #bitcoin-core-dev
354 2017-04-17T23:59:12  *** abpa has quit IRC