1 2017-04-18T00:16:44  *** Guest84617 has joined #bitcoin-core-dev
  2 2017-04-18T00:19:08  *** chjj has quit IRC
  3 2017-04-18T00:21:05  *** AaronvanW has quit IRC
  4 2017-04-18T00:21:06  *** laurentmt has quit IRC
  5 2017-04-18T00:24:08  *** AaronvanW has joined #bitcoin-core-dev
  6 2017-04-18T00:27:03  <bitcoin-git> [bitcoin] jimmysong opened pull request #10223: Tests: Refactor to create witness script creation function (master...refactor_blocktools_for_segwit) https://github.com/bitcoin/bitcoin/pull/10223
  7 2017-04-18T00:28:36  *** Dyaheon has joined #bitcoin-core-dev
  8 2017-04-18T00:30:57  *** Ylbam has quit IRC
  9 2017-04-18T00:32:53  *** chjj has joined #bitcoin-core-dev
 10 2017-04-18T00:33:58  *** AaronvanW has quit IRC
 11 2017-04-18T00:37:29  *** AaronvanW has joined #bitcoin-core-dev
 12 2017-04-18T00:39:14  *** d_t has joined #bitcoin-core-dev
 13 2017-04-18T00:43:55  *** Guest84617 has quit IRC
 14 2017-04-18T00:52:31  *** AaronvanW has quit IRC
 15 2017-04-18T00:54:55  *** AaronvanW has joined #bitcoin-core-dev
 16 2017-04-18T01:06:54  *** goksinen has joined #bitcoin-core-dev
 17 2017-04-18T01:08:24  *** goksinen has joined #bitcoin-core-dev
 18 2017-04-18T01:08:35  *** AaronvanW has quit IRC
 19 2017-04-18T01:12:21  *** AaronvanW has joined #bitcoin-core-dev
 20 2017-04-18T01:18:40  *** chjj has quit IRC
 21 2017-04-18T01:24:07  *** talmai has joined #bitcoin-core-dev
 22 2017-04-18T01:26:07  *** goksinen has quit IRC
 23 2017-04-18T01:26:34  *** goksinen has joined #bitcoin-core-dev
 24 2017-04-18T01:32:28  *** chjj has joined #bitcoin-core-dev
 25 2017-04-18T01:34:05  *** tw2006 has joined #bitcoin-core-dev
 26 2017-04-18T01:34:23  *** talmai has quit IRC
 27 2017-04-18T01:38:36  *** tw2006 has quit IRC
 28 2017-04-18T01:47:27  <bitcoin-git> [bitcoin] jimmysong opened pull request #10224: Tests: Add simple test for getaddednodeinfo (master...test_getaddednodeinfo) https://github.com/bitcoin/bitcoin/pull/10224
 29 2017-04-18T01:54:43  *** AaronvanW has quit IRC
 30 2017-04-18T01:56:13  *** d_t has quit IRC
 31 2017-04-18T01:56:57  *** AaronvanW has joined #bitcoin-core-dev
 32 2017-04-18T01:57:58  *** belcher has quit IRC
 33 2017-04-18T02:03:05  *** AaronvanW has quit IRC
 34 2017-04-18T02:05:04  *** AaronvanW has joined #bitcoin-core-dev
 35 2017-04-18T02:14:22  *** e4xit has quit IRC
 36 2017-04-18T02:14:46  *** AaronvanW has quit IRC
 37 2017-04-18T02:19:32  *** AaronvanW has joined #bitcoin-core-dev
 38 2017-04-18T02:21:42  *** talmai has joined #bitcoin-core-dev
 39 2017-04-18T02:27:17  *** ensign has quit IRC
 40 2017-04-18T02:27:45  *** nsh has quit IRC
 41 2017-04-18T02:31:24  <midnightmagic> sipa: What does the green spike represent here in your graph? http://bitcoin.sipa.be/ver9-50k.png
 42 2017-04-18T02:32:16  <achow101> midnightmagic: that's csv signalling
 43 2017-04-18T02:33:00  <midnightmagic> achow101: Thanks. I'm colourblind. I thought the blue line next to the first 144 block average was green.
 44 2017-04-18T02:33:14  *** ensign has joined #bitcoin-core-dev
 45 2017-04-18T02:34:44  *** nsh has joined #bitcoin-core-dev
 46 2017-04-18T02:36:43  *** AaronvanW has quit IRC
 47 2017-04-18T02:45:13  *** dermoth_ has joined #bitcoin-core-dev
 48 2017-04-18T02:45:42  *** dermoth has quit IRC
 49 2017-04-18T02:45:45  *** dermoth_ is now known as dermoth
 50 2017-04-18T03:16:27  *** baldur has joined #bitcoin-core-dev
 51 2017-04-18T03:21:06  *** baldur has quit IRC
 52 2017-04-18T03:23:00  *** tw2006 has joined #bitcoin-core-dev
 53 2017-04-18T03:27:36  *** tw2006 has quit IRC
 54 2017-04-18T03:32:40  *** str4d has joined #bitcoin-core-dev
 55 2017-04-18T03:42:10  *** str4d has quit IRC
 56 2017-04-18T04:15:30  <NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
 57 2017-04-18T04:17:45  <NicolasDorier> by "change to CCoinView" I mean only the method signatures to be per txout
 58 2017-04-18T04:18:12  <NicolasDorier> without changing any underlying storage
 59 2017-04-18T04:23:33  *** AaronvanW has joined #bitcoin-core-dev
 60 2017-04-18T04:26:36  *** SopaXorzTaker has joined #bitcoin-core-dev
 61 2017-04-18T04:27:54  *** goksinen has quit IRC
 62 2017-04-18T04:28:20  *** AaronvanW has quit IRC
 63 2017-04-18T04:36:09  *** baldur has joined #bitcoin-core-dev
 64 2017-04-18T05:04:37  *** AaronvanW has joined #bitcoin-core-dev
 65 2017-04-18T05:09:46  *** AaronvanW has quit IRC
 66 2017-04-18T05:11:55  *** tw2006 has joined #bitcoin-core-dev
 67 2017-04-18T05:13:58  *** AaronvanW has joined #bitcoin-core-dev
 68 2017-04-18T05:16:29  *** tw2006 has quit IRC
 69 2017-04-18T05:19:52  <sipa> NicolasDorier: there is no easy way first do one without the other, but i'll try
 70 2017-04-18T05:20:23  <sipa> NicolasDorier: and signatures have nothing to do with it
 71 2017-04-18T05:20:34  <NicolasDorier> I said method signature
 72 2017-04-18T05:20:53  <NicolasDorier> ie like GetCoins() is per Outpoint instead of uint256
 73 2017-04-18T05:21:09  <sipa> also, please review #10408 first
 74 2017-04-18T05:21:09  <gribble> https://github.com/bitcoin/bitcoin/issues/10408 | HTTP Error 404: Not Found
 75 2017-04-18T05:21:18  <sipa> ah yes, my apologies!
 76 2017-04-18T05:22:08  <NicolasDorier> you were in the wrong namespace => using OOP; :D
 77 2017-04-18T05:22:20  *** AaronvanW has quit IRC
 78 2017-04-18T05:22:45  <NicolasDorier> mmh 10408  does not exist
 79 2017-04-18T05:22:52  <NicolasDorier> ha
 80 2017-04-18T05:22:59  <NicolasDorier> https://github.com/bitcoin/bitcoin/pull/10148 you mean ?
 81 2017-04-18T05:26:13  <sipa> yes indeed
 82 2017-04-18T05:26:26  <sipa> sorry, i just woke up
 83 2017-04-18T05:27:18  *** paveljanik has quit IRC
 84 2017-04-18T05:27:25  *** pavel_ has joined #bitcoin-core-dev
 85 2017-04-18T05:27:45  *** AaronvanW has joined #bitcoin-core-dev
 86 2017-04-18T05:27:57  *** pavel_ has quit IRC
 87 2017-04-18T05:30:24  <NicolasDorier> sipa: I will try myself to just change CCoinView signature
 88 2017-04-18T05:30:35  <NicolasDorier> method signatures
 89 2017-04-18T05:30:52  <NicolasDorier> will make a PR if it is usable and indeed easier to review
 90 2017-04-18T05:31:35  <NicolasDorier> will try that today after reviewing https://github.com/bitcoin/bitcoin/pull/10148
 91 2017-04-18T05:31:42  <sipa> NicolasDorier: that's very nontrivial
 92 2017-04-18T05:31:54  <sipa> you'd need a translation layer with ths database
 93 2017-04-18T05:32:27  <sipa> if you create one, i'll happily include, though?
 94 2017-04-18T05:32:32  <sipa> s/?/!/
 95 2017-04-18T05:32:37  <NicolasDorier> ok I will try
 96 2017-04-18T05:33:25  <sipa> it may be easier to do the opposite; first change the db and then CCoinsView
 97 2017-04-18T05:35:40  <sipa> because all that needs is a loop at read or write time to merge the db records/split ccoims
 98 2017-04-18T05:36:38  <NicolasDorier> Not really related to the PR but tricky: https://github.com/bitcoin/bitcoin/blob/2584925077f9658b3953ad931b74779006e59807/src/validation.cpp#L1591 . fClean is passed either as pointer or return value. If pointer is used, return value is useless.
 99 2017-04-18T05:38:43  *** AaronvanW has quit IRC
100 2017-04-18T05:38:54  <sipa> no, the return value still indicates disk corruption
101 2017-04-18T05:39:05  <sipa> pfClean is only for database inconsistencies
102 2017-04-18T05:39:57  <sipa> i'll add a comment to explain
103 2017-04-18T05:41:10  *** AaronvanW has joined #bitcoin-core-dev
104 2017-04-18T05:42:38  <sipa> but thank you very much for having a look at these PRs
105 2017-04-18T05:42:50  <sipa> i know they're pretty invasive
106 2017-04-18T05:48:20  *** RubenSomsen has joined #bitcoin-core-dev
107 2017-04-18T05:50:35  *** AaronvanW has quit IRC
108 2017-04-18T06:05:52  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d86bb075bf6d...393160cf6cda
109 2017-04-18T06:05:53  <bitcoin-git> bitcoin/master 75a08e7 Kalle Alm: [wallet] Add support for aborting wallet transaction rescans.
110 2017-04-18T06:05:54  <bitcoin-git> bitcoin/master 9141622 Kalle Alm: [rpc] Add abortrescan command to RPC interface.
111 2017-04-18T06:05:54  <bitcoin-git> bitcoin/master 393160c Wladimir J. van der Laan: Merge #10208: [wallet] Rescan abortability...
112 2017-04-18T06:06:12  <bitcoin-git> [bitcoin] laanwj closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
113 2017-04-18T06:25:50  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/393160cf6cda...a86255b11633
114 2017-04-18T06:25:51  <bitcoin-git> bitcoin/master 846dc17 Kalle Alm: [doc] Wording fixes in CONTRIBUTING.md.
115 2017-04-18T06:25:51  <bitcoin-git> bitcoin/master 3ddd227 Kalle Alm: [doc] Add blob about finding reviewers.
116 2017-04-18T06:25:52  <bitcoin-git> bitcoin/master a86255b Wladimir J. van der Laan: Merge #10211: [doc] Contributor fixes & new "finding reviewers" section...
117 2017-04-18T06:26:08  <bitcoin-git> [bitcoin] laanwj closed pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
118 2017-04-18T06:29:03  *** AaronvanW has joined #bitcoin-core-dev
119 2017-04-18T06:29:34  *** Ylbam has joined #bitcoin-core-dev
120 2017-04-18T06:29:50  *** d9b4bef9 has quit IRC
121 2017-04-18T06:30:57  *** d9b4bef9 has joined #bitcoin-core-dev
122 2017-04-18T06:33:30  *** Giszmo has quit IRC
123 2017-04-18T06:34:20  *** AaronvanW has quit IRC
124 2017-04-18T06:40:57  *** AaronvanW has joined #bitcoin-core-dev
125 2017-04-18T06:49:27  <sipa> wumpus: not sure if you know this, but you can run with -reindex, make it process a couple block files, and then abort and restart with -reindex-chainstate
126 2017-04-18T06:49:45  <sipa> that will just make it fully process those couple files
127 2017-04-18T06:49:51  <wumpus> didn't know that, thanks
128 2017-04-18T06:50:05  *** AaronvanW has quit IRC
129 2017-04-18T06:51:02  *** talmai has quit IRC
130 2017-04-18T06:55:05  *** AaronvanW has joined #bitcoin-core-dev
131 2017-04-18T07:00:51  *** tw2006 has joined #bitcoin-core-dev
132 2017-04-18T07:05:24  *** tw2006 has quit IRC
133 2017-04-18T07:09:21  *** AaronvanW has quit IRC
134 2017-04-18T07:23:58  *** rockhouse has joined #bitcoin-core-dev
135 2017-04-18T07:24:24  *** rockhouse has joined #bitcoin-core-dev
136 2017-04-18T07:29:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a86255b11633...9111df9673be
137 2017-04-18T07:29:20  <bitcoin-git> bitcoin/master 637706d Jimmy Song: Tests: Put Extended tests first when they're included...
138 2017-04-18T07:29:20  <bitcoin-git> bitcoin/master 9111df9 MarcoFalke: Merge #10219: Tests: Order Python Tests Differently...
139 2017-04-18T07:29:30  *** SopaXorzTaker has quit IRC
140 2017-04-18T07:29:37  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10219: Tests: Order Python Tests Differently (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219
141 2017-04-18T07:29:49  *** SopaXorzTaker has joined #bitcoin-core-dev
142 2017-04-18T07:53:29  *** AaronvanW has joined #bitcoin-core-dev
143 2017-04-18T08:03:10  *** AaronvanW has quit IRC
144 2017-04-18T08:05:01  *** To7 has quit IRC
145 2017-04-18T08:13:32  <bitcoin-git> [bitcoin] kallewoof opened pull request #10225: [test] Add aborttrescan tests (master...abort-rescan-tests) https://github.com/bitcoin/bitcoin/pull/10225
146 2017-04-18T08:16:29  *** davec has quit IRC
147 2017-04-18T08:18:38  *** laurentmt has joined #bitcoin-core-dev
148 2017-04-18T08:20:15  *** laurentmt has quit IRC
149 2017-04-18T08:27:41  *** davec has joined #bitcoin-core-dev
150 2017-04-18T08:41:40  *** SopaXorzTaker has quit IRC
151 2017-04-18T08:45:44  *** d_t has joined #bitcoin-core-dev
152 2017-04-18T08:49:52  *** tw2006 has joined #bitcoin-core-dev
153 2017-04-18T08:54:45  *** tw2006 has quit IRC
154 2017-04-18T08:55:09  *** SopaXorzTaker has joined #bitcoin-core-dev
155 2017-04-18T09:28:34  *** laurentmt has joined #bitcoin-core-dev
156 2017-04-18T09:32:13  *** jannes has joined #bitcoin-core-dev
157 2017-04-18T09:42:22  *** thrasher` has quit IRC
158 2017-04-18T09:46:53  *** thrasher` has joined #bitcoin-core-dev
159 2017-04-18T09:49:44  *** vicenteH has joined #bitcoin-core-dev
160 2017-04-18T10:17:25  *** AaronvanW has joined #bitcoin-core-dev
161 2017-04-18T10:26:50  *** d9b4bef9 has quit IRC
162 2017-04-18T10:28:06  *** d9b4bef9 has joined #bitcoin-core-dev
163 2017-04-18T10:38:45  *** tw2006 has joined #bitcoin-core-dev
164 2017-04-18T10:43:26  *** tw2006 has quit IRC
165 2017-04-18T10:45:12  *** Guyver2 has joined #bitcoin-core-dev
166 2017-04-18T11:12:53  <SopaXorzTaker> Can anyone do me a favor?
167 2017-04-18T11:13:03  <SopaXorzTaker> please broadcast this nonstandard tx: 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000'
168 2017-04-18T11:13:23  <SopaXorzTaker> (remove the trailing quote, of course)
169 2017-04-18T11:17:20  <jonasschnelli> SopaXorzTaker: broadcast yourself?
170 2017-04-18T11:17:28  <wumpus> only makes sense to send it direct to miners, broadcasting it will just cause it to be ignored/rejected
171 2017-04-18T11:17:51  <wumpus> my nodes don't want it at least
172 2017-04-18T11:18:42  <jonasschnelli> Ah. It's non-std. Yes. maybe google the miners IP and use something like https://github.com/libbtc/libbtc#the-bitcoin-send-tx-cli
173 2017-04-18T11:22:28  <SopaXorzTaker> jonasschnelli, thanks
174 2017-04-18T11:22:32  <SopaXorzTaker> I alrready found that
175 2017-04-18T11:22:41  <SopaXorzTaker> I am currently doing just that, too
176 2017-04-18T11:29:05  *** petertodd has quit IRC
177 2017-04-18T11:29:26  <SopaXorzTaker> jonasschnelli, I can't
178 2017-04-18T11:29:34  <SopaXorzTaker> I will have to compile bitcoind
179 2017-04-18T11:29:57  <jonasschnelli> SopaXorzTaker: why?
180 2017-04-18T11:30:40  <SopaXorzTaker> lazy
181 2017-04-18T11:30:49  <SopaXorzTaker> Arch doesn't install it
182 2017-04-18T11:31:01  <SopaXorzTaker> and if it did, I'd have to download the blockchain
183 2017-04-18T11:31:09  <SopaXorzTaker> I have to compile it myself without the checks
184 2017-04-18T11:31:54  <sipa> no offence, but this channel is about development of bitcoin core
185 2017-04-18T11:32:09  <sipa> if you're not planning to even run it, why are you here?
186 2017-04-18T11:32:29  <SopaXorzTaker> I am compiling it now
187 2017-04-18T11:32:36  <SopaXorzTaker> that'd take a while
188 2017-04-18T11:32:38  <SopaXorzTaker> and I am bored
189 2017-04-18T11:33:05  <sipa> ok :)
190 2017-04-18T11:46:03  <SopaXorzTaker> tx e1995a7ee78fd11a24591e35f3a7d3cda92c6cf4126879a8e133377d85906284
191 2017-04-18T12:01:32  <SopaXorzTaker> sipa, could you do it
192 2017-04-18T12:01:43  <SopaXorzTaker> " sendrawtransaction 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000"
193 2017-04-18T12:01:51  <SopaXorzTaker> with a full blockchain, obviously
194 2017-04-18T12:02:27  <sipa> SopaXorzTaker: i tried, it would reject it because it's nonstandard
195 2017-04-18T12:02:39  <sipa> SopaXorzTaker: and modifying the code wouldn't help, as other peers would reject it too
196 2017-04-18T12:02:48  <sipa> you need to send it directly to miners, as you were told above
197 2017-04-18T12:04:40  <wumpus> yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
198 2017-04-18T12:11:56  *** To7 has joined #bitcoin-core-dev
199 2017-04-18T12:27:41  *** tw2006 has joined #bitcoin-core-dev
200 2017-04-18T12:32:12  *** tw2006 has quit IRC
201 2017-04-18T12:33:59  <bitcoin-git> [bitcoin] laanwj closed pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
202 2017-04-18T12:38:40  *** NewLiberty has quit IRC
203 2017-04-18T12:39:39  *** paveljanik has joined #bitcoin-core-dev
204 2017-04-18T12:39:39  *** paveljanik has joined #bitcoin-core-dev
205 2017-04-18T12:41:00  *** aguyonabike has joined #bitcoin-core-dev
206 2017-04-18T12:42:37  <aguyonabike> Hi, I'm not sure if this is the right place to ask this question, but could Segwit be changed to be covert-asicboost-compatible? The way I figure this could be done is similar to the extension blocks proposal, adding a special transaction "at the end" instead of using coinbase space for the witness commit
207 2017-04-18T12:44:43  <wumpus> yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
208 2017-04-18T12:45:09  <aguyonabike> sorry about it :) thanks
209 2017-04-18T12:46:41  <SopaXorzTaker> sipa, eligius doesn't reject
210 2017-04-18T12:46:52  <SopaXorzTaker> how do I feed that to a miner node?
211 2017-04-18T12:46:55  *** arubi has quit IRC
212 2017-04-18T12:47:19  *** arubi has joined #bitcoin-core-dev
213 2017-04-18T12:47:22  <wumpus> SopaXorzTaker: different channel please, this is not development related
214 2017-04-18T12:47:30  <SopaXorzTaker> sorry
215 2017-04-18T12:47:46  <wumpus> general questions like that belong in#bitcoin
216 2017-04-18T12:48:40  <wumpus> alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
217 2017-04-18T12:48:52  <wumpus> -being
218 2017-04-18T13:09:22  *** RubenSomsen has quit IRC
219 2017-04-18T13:09:52  *** RubenSomsen has joined #bitcoin-core-dev
220 2017-04-18T13:15:32  *** aguyonabike has quit IRC
221 2017-04-18T13:16:39  <SopaXorzTaker> offtopic: give an example of a miner node that I can feed the transaction to, please
222 2017-04-18T13:16:43  <SopaXorzTaker> wumpus, sipa ^
223 2017-04-18T13:16:51  <SopaXorzTaker> I can't find any
224 2017-04-18T13:17:08  <sipa> SopaXorzTaker: not here, offtopic
225 2017-04-18T13:17:51  <SopaXorzTaker> okay
226 2017-04-18T13:45:33  <wumpus> this is not a "highlight developers to get support" channel, last warning
227 2017-04-18T13:54:23  <SopaXorzTaker> wumpus, fine
228 2017-04-18T13:54:36  <SopaXorzTaker> and sorry for that
229 2017-04-18T14:03:15  <SopaXorzTaker> guys
230 2017-04-18T14:03:17  <SopaXorzTaker> oops
231 2017-04-18T14:12:49  *** Sosumi has joined #bitcoin-core-dev
232 2017-04-18T14:16:36  *** tw2006 has joined #bitcoin-core-dev
233 2017-04-18T14:20:11  <bincap> back to srs busines on other hand
234 2017-04-18T14:20:24  <bincap> luke-jr: laanwj was so kind and confirmed gitian for knots+bip148 https://github.com/magmaship/bitcoin-special-gitian.sigs/pull/1
235 2017-04-18T14:20:46  <bincap> dang wrong #bitcoin channel. Disregard that, moving to #bitcoin
236 2017-04-18T14:21:26  *** tw2006 has quit IRC
237 2017-04-18T14:24:32  *** bsm1175322 has joined #bitcoin-core-dev
238 2017-04-18T14:32:16  *** Giszmo has joined #bitcoin-core-dev
239 2017-04-18T14:35:12  *** tw2006 has joined #bitcoin-core-dev
240 2017-04-18T15:27:03  *** jtimon has joined #bitcoin-core-dev
241 2017-04-18T15:31:49  *** tripleslash has quit IRC
242 2017-04-18T15:34:07  *** tripleslash has joined #bitcoin-core-dev
243 2017-04-18T15:39:55  <bitcoin-git> [bitcoin] luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
244 2017-04-18T15:45:38  *** kexkey has joined #bitcoin-core-dev
245 2017-04-18T15:46:03  *** dclxvi has joined #bitcoin-core-dev
246 2017-04-18T15:54:39  *** abpa has joined #bitcoin-core-dev
247 2017-04-18T16:08:17  *** Soligor has quit IRC
248 2017-04-18T16:25:18  *** Cortney has quit IRC
249 2017-04-18T16:39:12  *** belcher has joined #bitcoin-core-dev
250 2017-04-18T16:39:15  *** belcher has quit IRC
251 2017-04-18T16:39:15  *** belcher has joined #bitcoin-core-dev
252 2017-04-18T17:21:45  <bitcoin-git> [bitcoin] jtimon opened pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
253 2017-04-18T17:22:40  *** annanay25 has quit IRC
254 2017-04-18T17:22:48  *** annanay25 has joined #bitcoin-core-dev
255 2017-04-18T17:45:37  *** petertodd has joined #bitcoin-core-dev
256 2017-04-18T18:01:17  *** LeMiner2 has joined #bitcoin-core-dev
257 2017-04-18T18:03:32  *** LeMiner has quit IRC
258 2017-04-18T18:04:44  *** Soligor has joined #bitcoin-core-dev
259 2017-04-18T18:06:23  *** laurentmt has quit IRC
260 2017-04-18T18:28:08  *** bsm1175322 has quit IRC
261 2017-04-18T18:34:05  *** bsm1175322 has joined #bitcoin-core-dev
262 2017-04-18T18:41:30  *** laurentmt has joined #bitcoin-core-dev
263 2017-04-18T18:44:32  *** aceat64 has joined #bitcoin-core-dev
264 2017-04-18T18:45:45  *** SopaXorzTaker has quit IRC
265 2017-04-18T19:01:26  *** laurentmt has quit IRC
266 2017-04-18T19:02:12  *** shesek has quit IRC
267 2017-04-18T19:05:10  *** talmai has joined #bitcoin-core-dev
268 2017-04-18T19:14:17  <jtimon> so what's next for #10189 ?
269 2017-04-18T19:14:18  <gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
270 2017-04-18T19:14:25  *** RubenSomsen has quit IRC
271 2017-04-18T19:15:28  <jtimon> I also read the topic on last meeting which I missed, it seems we agree that this facilitates review but doesn't replace it
272 2017-04-18T19:15:51  <BlueMatt> jtimon: I believe cfields has a few things to update on it?
273 2017-04-18T19:16:31  <jtimon> BlueMatt: apart from requiring a specific prefix (which can be done later), anything else?
274 2017-04-18T19:16:40  <BlueMatt> that was my only comment
275 2017-04-18T19:17:01  <BlueMatt> dont think it should be done in a separate pr, though? you dont want to gratuitously change it so that old commits are no longer verifyable for no reason
276 2017-04-18T19:17:08  <BlueMatt> (plus its super trivial)
277 2017-04-18T19:17:35  <cfields> sure, will add
278 2017-04-18T19:18:23  <jtimon> yeah, I actually didn't thought about making it mandatory for the script to be checked, just as a convention to put in the development notes with some explanation on how to use this, but ack on making the script check for the tittle prefix
279 2017-04-18T19:27:50  *** talmai has quit IRC
280 2017-04-18T19:28:46  *** Sosumi has quit IRC
281 2017-04-18T19:29:07  *** arubi has quit IRC
282 2017-04-18T19:29:32  *** arubi has joined #bitcoin-core-dev
283 2017-04-18T19:29:48  <jtimon> BlueMatt: ack on completing it further, thanks guys
284 2017-04-18T19:30:30  <jtimon> I'm also not sure if there's any blocker for #9494, maybe squashing #10119 into it?
285 2017-04-18T19:30:33  <gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
286 2017-04-18T19:30:33  <gribble> https://github.com/bitcoin/bitcoin/issues/10119 | Util: Remove ArgsManager wrappers: by jtimon · Pull Request #10119 · bitcoin/bitcoin · GitHub
287 2017-04-18T19:31:28  <jtimon> ping: jeremyrubin
288 2017-04-18T19:36:53  *** tripleslash has quit IRC
289 2017-04-18T19:42:32  *** NewLiberty has joined #bitcoin-core-dev
290 2017-04-18T19:44:04  *** talmai has joined #bitcoin-core-dev
291 2017-04-18T19:45:56  *** Dyaheon has quit IRC
292 2017-04-18T19:47:21  *** Dyaheon has joined #bitcoin-core-dev
293 2017-04-18T19:51:27  *** tripleslash has joined #bitcoin-core-dev
294 2017-04-18T20:07:54  *** talmai has quit IRC
295 2017-04-18T20:17:00  *** talmai has joined #bitcoin-core-dev
296 2017-04-18T20:23:14  <jtimon> btw, as much excited as I am about #10193, the part replacing BOOST_REVERSE_FOREACH isn't even compiling for prevector_tests.cpp (see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e ), and thus https://github.com/bitcoin/bitcoin/pull/10193/commits/d0cbbbe1147dfdf407087816a4e999990907a565 should be done either as it is
297 2017-04-18T20:23:16  <gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
298 2017-04-18T20:24:38  <jtimon> perhaps I should reduce the scope if I can't find a fix (and I'm still pretty clueless about why the code I "stole" from the interwebs isn't working)
299 2017-04-18T20:29:53  *** talmai has quit IRC
300 2017-04-18T20:33:28  *** talmai has joined #bitcoin-core-dev
301 2017-04-18T20:59:04  *** QBcrusher has joined #bitcoin-core-dev
302 2017-04-18T21:04:58  *** jl2012 has quit IRC
303 2017-04-18T21:21:21  *** tw2006 has quit IRC
304 2017-04-18T21:24:25  *** talmai has quit IRC
305 2017-04-18T21:25:27  *** shesek has joined #bitcoin-core-dev
306 2017-04-18T21:51:05  *** Dyaheon has quit IRC
307 2017-04-18T21:51:57  *** Dyaheon has joined #bitcoin-core-dev
308 2017-04-18T22:09:47  *** Guyver2 has quit IRC
309 2017-04-18T22:20:41  *** shesek has quit IRC
310 2017-04-18T22:36:12  *** bsm1175322 has quit IRC
311 2017-04-18T22:53:17  *** chjj has quit IRC
312 2017-04-18T23:03:52  *** Evel-Knievel has quit IRC
313 2017-04-18T23:04:38  *** Evel-Knievel has joined #bitcoin-core-dev
314 2017-04-18T23:06:52  *** chjj has joined #bitcoin-core-dev
315 2017-04-18T23:08:08  *** eenoch has quit IRC
316 2017-04-18T23:09:08  *** laurentmt has joined #bitcoin-core-dev
317 2017-04-18T23:09:22  *** eenoch has joined #bitcoin-core-dev
318 2017-04-18T23:10:34  *** tw2006 has joined #bitcoin-core-dev
319 2017-04-18T23:11:03  *** laurentmt has quit IRC
320 2017-04-18T23:14:00  *** shesek has joined #bitcoin-core-dev
321 2017-04-18T23:15:09  *** tw2006 has quit IRC
322 2017-04-18T23:32:59  <bitcoin-git> [bitcoin] theuni opened pull request #10228: build: regenerate bitcoin-config.h as necessary (master...fix-config-h) https://github.com/bitcoin/bitcoin/pull/10228
323 2017-04-18T23:45:53  *** arubi has quit IRC
324 2017-04-18T23:46:46  *** arubi has joined #bitcoin-core-dev
325 2017-04-18T23:51:23  *** jannes has quit IRC
326 2017-04-18T23:55:04  *** abpa has quit IRC