1 2017-05-23T00:00:00  *** talmai has joined #bitcoin-core-dev
  2 2017-05-23T00:21:40  *** talmai has quit IRC
  3 2017-05-23T00:28:16  *** yirabbit_ has quit IRC
  4 2017-05-23T00:33:09  *** talmai has joined #bitcoin-core-dev
  5 2017-05-23T00:33:26  *** yirabbit_ has joined #bitcoin-core-dev
  6 2017-05-23T00:39:49  *** yirabbit_ has quit IRC
  7 2017-05-23T00:40:17  *** Ylbam has quit IRC
  8 2017-05-23T00:40:31  *** talmai has quit IRC
  9 2017-05-23T00:46:25  *** yirabbit_ has joined #bitcoin-core-dev
 10 2017-05-23T01:24:06  *** AaronvanW has quit IRC
 11 2017-05-23T01:38:06  *** talmai has joined #bitcoin-core-dev
 12 2017-05-23T02:31:34  *** talmai has quit IRC
 13 2017-05-23T03:00:38  *** talmai has joined #bitcoin-core-dev
 14 2017-05-23T03:08:38  *** justan0theruser has joined #bitcoin-core-dev
 15 2017-05-23T03:10:48  *** justanotheruser has quit IRC
 16 2017-05-23T03:27:50  *** talmai has quit IRC
 17 2017-05-23T03:32:55  *** QBcrusher_ has joined #bitcoin-core-dev
 18 2017-05-23T03:32:57  *** RubenSomsen has joined #bitcoin-core-dev
 19 2017-05-23T03:35:19  *** QBcrusher has quit IRC
 20 2017-05-23T03:48:43  *** talmai has joined #bitcoin-core-dev
 21 2017-05-23T03:52:09  *** QBcrusher_ has quit IRC
 22 2017-05-23T03:59:30  *** yirabbit_ has quit IRC
 23 2017-05-23T04:06:33  *** RubenSomsen has quit IRC
 24 2017-05-23T04:07:07  *** sanada has quit IRC
 25 2017-05-23T04:15:20  *** sanada has joined #bitcoin-core-dev
 26 2017-05-23T04:19:08  *** JackH has quit IRC
 27 2017-05-23T04:22:44  *** rafalcpp has quit IRC
 28 2017-05-23T04:22:48  *** Dyaheon has quit IRC
 29 2017-05-23T04:23:27  *** rafalcpp has joined #bitcoin-core-dev
 30 2017-05-23T04:23:48  *** bincap has quit IRC
 31 2017-05-23T04:24:19  *** bincap has joined #bitcoin-core-dev
 32 2017-05-23T04:29:08  *** Dyaheon has joined #bitcoin-core-dev
 33 2017-05-23T04:35:01  *** yirabbit_ has joined #bitcoin-core-dev
 34 2017-05-23T04:39:05  *** yirabbit_ has quit IRC
 35 2017-05-23T05:09:40  *** RubenSomsen has joined #bitcoin-core-dev
 36 2017-05-23T05:14:10  *** RubenSomsen has quit IRC
 37 2017-05-23T05:14:28  *** RubenSomsen has joined #bitcoin-core-dev
 38 2017-05-23T05:26:39  *** QBcrusher has joined #bitcoin-core-dev
 39 2017-05-23T05:46:00  *** talmai has quit IRC
 40 2017-05-23T06:30:52  *** RubenSomsen has quit IRC
 41 2017-05-23T06:34:25  *** jannes has joined #bitcoin-core-dev
 42 2017-05-23T06:43:23  *** marcoagner has quit IRC
 43 2017-05-23T06:50:49  *** BashCo has quit IRC
 44 2017-05-23T06:55:26  *** marcoagner has joined #bitcoin-core-dev
 45 2017-05-23T06:57:14  *** RubenSomsen has joined #bitcoin-core-dev
 46 2017-05-23T07:10:55  *** paveljanik has quit IRC
 47 2017-05-23T07:12:25  *** BashCo has joined #bitcoin-core-dev
 48 2017-05-23T07:17:34  *** dgenr8 has quit IRC
 49 2017-05-23T07:17:58  *** dgenr8 has joined #bitcoin-core-dev
 50 2017-05-23T07:28:01  *** d9b4bef9 has quit IRC
 51 2017-05-23T07:29:07  *** d9b4bef9 has joined #bitcoin-core-dev
 52 2017-05-23T07:33:01  *** btcdrak has joined #bitcoin-core-dev
 53 2017-05-23T07:35:10  *** btcdrak has quit IRC
 54 2017-05-23T07:37:21  *** Ylbam has joined #bitcoin-core-dev
 55 2017-05-23T07:49:23  *** btcdrak has joined #bitcoin-core-dev
 56 2017-05-23T08:12:47  *** timothy has joined #bitcoin-core-dev
 57 2017-05-23T08:17:46  *** JackH has joined #bitcoin-core-dev
 58 2017-05-23T08:22:43  *** afk11 has joined #bitcoin-core-dev
 59 2017-05-23T08:24:14  *** AaronvanW has joined #bitcoin-core-dev
 60 2017-05-23T08:24:52  *** jtimon has quit IRC
 61 2017-05-23T08:25:10  *** Aaronvan_ has joined #bitcoin-core-dev
 62 2017-05-23T08:28:41  *** AaronvanW has quit IRC
 63 2017-05-23T08:46:01  *** kewde[m] has quit IRC
 64 2017-05-23T08:46:02  *** frabrunelle has quit IRC
 65 2017-05-23T08:46:03  *** herzmeister[m] has quit IRC
 66 2017-05-23T08:48:03  *** amiller has quit IRC
 67 2017-05-23T08:48:30  *** herzmeister[m] has joined #bitcoin-core-dev
 68 2017-05-23T08:51:27  *** Guest29397 has joined #bitcoin-core-dev
 69 2017-05-23T08:54:28  *** frabrunelle has joined #bitcoin-core-dev
 70 2017-05-23T08:54:28  *** kewde[m] has joined #bitcoin-core-dev
 71 2017-05-23T08:57:52  *** BashCo has quit IRC
 72 2017-05-23T09:02:55  *** BashCo has joined #bitcoin-core-dev
 73 2017-05-23T09:18:28  *** timothy has quit IRC
 74 2017-05-23T09:19:07  *** timothy has joined #bitcoin-core-dev
 75 2017-05-23T09:24:33  *** afk11 has quit IRC
 76 2017-05-23T09:24:46  *** afk11 has joined #bitcoin-core-dev
 77 2017-05-23T09:39:40  *** riemann has joined #bitcoin-core-dev
 78 2017-05-23T09:47:33  <jonasschnelli> The protocol wiki "https://en.bitcoin.it/wiki/Protocol_documentation" says:
 79 2017-05-23T09:47:34  <jonasschnelli> If all TxIn inputs have final (0xffffffff) sequence numbers then lock_time is irrelevant. Otherwise, the transaction may not be added to a block until after lock_time (see NLockTime).
 80 2017-05-23T09:47:44  <jonasschnelli> I guess this is wrong...
 81 2017-05-23T09:48:09  <jonasschnelli> IsFinalTx first checks the nLockTime (0 or < height/time) before checking the nSequence
 82 2017-05-23T09:48:17  <jonasschnelli> if someone confirms I can update the wiki
 83 2017-05-23T09:48:29  *** Dyaheon has quit IRC
 84 2017-05-23T09:49:19  *** Dyaheon has joined #bitcoin-core-dev
 85 2017-05-23T10:12:59  *** Guyver2 has joined #bitcoin-core-dev
 86 2017-05-23T10:16:36  *** kadoban has quit IRC
 87 2017-05-23T10:17:04  *** kadoban has joined #bitcoin-core-dev
 88 2017-05-23T10:22:05  <wumpus> jonasschnelli: the function will always return true when all sequence numbers are SEQUENCE_FINAL
 89 2017-05-23T10:23:08  <wumpus> but yes you're right it seems the other way around
 90 2017-05-23T10:23:40  <wumpus> when locktime is 0, or <height/time, the sequence numbers are irrelevant
 91 2017-05-23T10:25:18  <wumpus> hmm the logic as stated there is correct: *iff* all TxIn inputs have final, then no matter what locktime is, it will always be accepted
 92 2017-05-23T10:26:10  <wumpus> if not all TxIn inputs have final, then it depends on the locktime
 93 2017-05-23T10:27:22  <wumpus> it doesn't matter in what order the checks are for that, it can only return true and false after all, and it doesn't matter through which code path it does that
 94 2017-05-23T10:31:10  <jonasschnelli> wumpus: Indeed. Thanks for checking...
 95 2017-05-23T10:32:12  <wumpus> thanks for checking the docs, subtleties like this could result in lost money if they're wrong
 96 2017-05-23T10:43:58  <jonasschnelli> I guess a confusing element is that a tx can pass IsFinalTx() (in therefore has the term "final") even if it can be replaced by opt-in-RBF/BIP125
 97 2017-05-23T10:49:05  *** shesek has quit IRC
 98 2017-05-23T10:59:35  <wumpus> right - opt-in RBF is essentially a separate thing from finalness, even though it uses the sequence field too
 99 2017-05-23T11:04:42  *** shesek has joined #bitcoin-core-dev
100 2017-05-23T11:04:42  *** shesek has joined #bitcoin-core-dev
101 2017-05-23T11:23:37  *** laurentmt has joined #bitcoin-core-dev
102 2017-05-23T11:25:17  *** laurentmt has quit IRC
103 2017-05-23T11:41:18  *** jtimon has joined #bitcoin-core-dev
104 2017-05-23T11:44:27  *** RubenSomsen has quit IRC
105 2017-05-23T12:07:30  *** cryptapus_afk has quit IRC
106 2017-05-23T12:09:14  *** frabrunelle has quit IRC
107 2017-05-23T12:09:14  *** herzmeister[m] has quit IRC
108 2017-05-23T12:09:21  *** kewde[m] has quit IRC
109 2017-05-23T12:11:45  *** SopaXorzTaker has joined #bitcoin-core-dev
110 2017-05-23T12:11:49  *** kayamm has quit IRC
111 2017-05-23T12:11:49  *** BlueMatt has quit IRC
112 2017-05-23T12:11:49  *** phantomcircuit has quit IRC
113 2017-05-23T12:13:01  *** herzmeister[m] has joined #bitcoin-core-dev
114 2017-05-23T12:14:25  *** phantomcircuit has joined #bitcoin-core-dev
115 2017-05-23T12:14:40  *** kayamm has joined #bitcoin-core-dev
116 2017-05-23T12:14:40  *** kayamm has joined #bitcoin-core-dev
117 2017-05-23T12:14:50  *** BlueMatt has joined #bitcoin-core-dev
118 2017-05-23T12:17:55  *** kewde[m] has joined #bitcoin-core-dev
119 2017-05-23T12:17:55  *** frabrunelle has joined #bitcoin-core-dev
120 2017-05-23T12:28:28  *** Aaronvan_ has quit IRC
121 2017-05-23T12:44:43  *** AaronvanW has joined #bitcoin-core-dev
122 2017-05-23T12:44:43  *** AaronvanW has joined #bitcoin-core-dev
123 2017-05-23T12:45:14  *** felco_ has joined #bitcoin-core-dev
124 2017-05-23T12:48:19  *** felco_ is now known as felco
125 2017-05-23T12:57:12  *** BashCo has quit IRC
126 2017-05-23T13:02:11  *** BashCo has joined #bitcoin-core-dev
127 2017-05-23T13:34:30  <da2ce7> Is the fact that Bitcoin is under active exploit by the asicboost vulnerably a important consideration for the urgency of BIP148?
128 2017-05-23T13:34:53  <da2ce7> I would suggest that it should be at least something to consider.
129 2017-05-23T13:35:29  <da2ce7> Many developers have stated that they think that BIP148 is rushed, but remain silent on the fact that Bitcoin is under active exploit.
130 2017-05-23T13:38:53  <da2ce7> I have gained no negative responses to my post on the mailing list about classifying asicboost as a Security Vulnerability. Yet BIP148, a rapidly deployed partial-fix is rejected by many for being 'too rushed'.  I would suggest that any developers who states why it is 'too rushed' should state how the ongoing exploit of covert asicboost is the safer option.
131 2017-05-23T13:44:53  <wumpus> it's a difficult compromise
132 2017-05-23T13:47:10  <wumpus> it can still be too rushed, even if it addresses an immediate vulnerability; it depends on what outcome is worse, having stealth asicboost run for a few months longer (while BIP149 is being deployed) or a game of BIP148 chicken (which seems unavoidable in any case...).
133 2017-05-23T13:47:58  <timothy> da2ce7: why asicboot is a vulnerability?
134 2017-05-23T13:49:28  *** Sprh has joined #bitcoin-core-dev
135 2017-05-23T13:49:38  <da2ce7> timothy please see: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014349.html and the followup: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014353.html
136 2017-05-23T13:50:38  *** d_t has joined #bitcoin-core-dev
137 2017-05-23T13:55:01  *** d_t has quit IRC
138 2017-05-23T13:55:22  <da2ce7> wumpus, I agree: BIP148 may be, even then, too rushed (but I personally believe BIP148 is the safest option available, as I think there is a dramatic under estimation the damage of asicboost to Bitcoin). However, I haven't seen this considered in any of the significant anti-BIP148 responses to the mailing list.  Centrally not an analysis of the tradeoffs available.
139 2017-05-23T13:56:50  <da2ce7> for example gmaxwell states on multiple occasions "we should not rush", but doesn't expand upon this statement in the context of an actively exploited security vulnerability.
140 2017-05-23T13:56:58  <wumpus> "I think there is a dramatic under estimation the damage of asicboost to Bitcoin" in what way? because they overrepresent themselves, resulting in more mining centralization than would otherwise be the case?
141 2017-05-23T13:57:40  <da2ce7> Because it demands that in a short time, the only profitable miners are the miners who implement asicbosot.
142 2017-05-23T13:58:34  <da2ce7> One of the critical security properties of bitcoin is a well-distributed set of miners. AsicBoost dramatically breaks this assumtion.
143 2017-05-23T13:59:33  <da2ce7> Not even to mention the perverse incentives by the massive layer violations that asicboost encourages.
144 2017-05-23T14:00:00  <da2ce7> The choice of the ordering of transactions should have NO effect on the performance of a miner.
145 2017-05-23T14:04:25  <timothy> I think many ASICBOOST miners doesn't want soft-fork for asciboost itself
146 2017-05-23T14:07:17  <da2ce7> To me, it is clear why many miners don't like SegWit, because it breaks Covert AsicBoost.  This is a feature, not a bug, of SegWit. However it is just the first step of putting AsicBoost into the grave.
147 2017-05-23T14:08:04  <da2ce7> People will assume, quite correctly imho, that if you mine a non-segwit block, you are using AsicBoost.
148 2017-05-23T14:08:31  <da2ce7> Making it quite conspicuous.
149 2017-05-23T14:11:33  *** cryptapus_afk has joined #bitcoin-core-dev
150 2017-05-23T14:25:57  *** talmai has joined #bitcoin-core-dev
151 2017-05-23T14:26:10  *** RubenSomsen has joined #bitcoin-core-dev
152 2017-05-23T14:37:39  <luke-jr> jtimon: here is where I explain why BIP 149 is less safe (among other issues) vs BIP 148: https://www.reddit.com/r/Bitcoin/comments/69dm8e/what_is_segregated_witness_explanation_for/dh6dg3z/
153 2017-05-23T14:38:38  <Lauda> BIP148 is much better due to compatibility, indeed.
154 2017-05-23T14:39:02  <jtimon> luke-jr: "BIP 149 is the opposite: it leaves the question of successful softfork open until some unknown future point" I don't think this is correct
155 2017-05-23T14:39:32  <luke-jr> jtimon: well, it is.
156 2017-05-23T14:39:50  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4775167cb4b...e76a3927c3b0
157 2017-05-23T14:39:50  <bitcoin-git> bitcoin/master 2a8e35a Russell Yanofsky: Fix importwallet edge case rescan bug...
158 2017-05-23T14:39:51  <bitcoin-git> bitcoin/master e76a392 Wladimir J. van der Laan: Merge #10410: Fix importwallet edge case rescan bug...
159 2017-05-23T14:40:05  <jtimon> "BIP 148 is backward-compatible with segwit as already deployed in 0.13.1-0.14.1." so is bip149, bip149 is actually compatbile with pre-0.13 too
160 2017-05-23T14:40:31  <luke-jr> I think what I said there is perfectly clear.
161 2017-05-23T14:40:35  <bitcoin-git> [bitcoin] laanwj closed pull request #10410: Fix importwallet edge case rescan bug (master...pr/scanimp) https://github.com/bitcoin/bitcoin/pull/10410
162 2017-05-23T14:40:59  *** RubenSomsen has quit IRC
163 2017-05-23T14:41:02  <jtimon> luke-jr: hos is  4 July 2018 UTC (Epoch timestamp 1530662400) " some unknown future point" ?
164 2017-05-23T14:41:22  <luke-jr> jtimon: that's not when you'd find out
165 2017-05-23T14:41:33  *** RubenSomsen has joined #bitcoin-core-dev
166 2017-05-23T14:42:04  <jtimon> luke-jr: it can be made earlier by miners, that's true for bip148 as well
167 2017-05-23T14:42:28  <luke-jr> jtimon: with a BIP148-style *UASF*, you don't find out the outcome until a miner tries to steal segwit funds
168 2017-05-23T14:43:14  <jtimon> "there are plenty of "sharp edges" that could be encountered if we need to do it for segwit" what are those "sharp edges"? how don't they apply with the current bip9 deployment with respect to pre-sw nodes?
169 2017-05-23T14:43:46  <luke-jr> jtimon: re-deployment
170 2017-05-23T14:43:56  <luke-jr> pre-sw nodes don't *think* they know segwit
171 2017-05-23T14:44:06  <jtimon> "Very little research has been done into the work required to successfully and safely re-deploy segwit. " we knew bip9 deployments could be tried again if failed, I don't know what kind of research you want
172 2017-05-23T14:44:38  <luke-jr> yes, in general; but segwit is more complicated than merely another bip9 deployment
173 2017-05-23T14:44:39  <jtimon> pre-bip149 won't think segwit is activated
174 2017-05-23T14:45:02  <luke-jr> you need to ensure that
175 2017-05-23T14:45:12  <jtimon> I really see nothing special about redeployment
176 2017-05-23T14:45:24  <jtimon> you need to ensure what?
177 2017-05-23T14:45:25  <luke-jr> then you haven't thought it through
178 2017-05-23T14:45:35  <jtimon> happy to learn
179 2017-05-23T14:45:48  <luke-jr> you need to ensure 0.13.1-0.14.1 never get the witness data
180 2017-05-23T14:45:51  <luke-jr> which they will try to do
181 2017-05-23T14:46:02  <jtimon> not until activation
182 2017-05-23T14:46:50  <jtimon> if the bip9 activation gets in, great, if not, that won't happen for pre-bip149 nodes, what am I missing?
183 2017-05-23T14:50:27  *** talmai has quit IRC
184 2017-05-23T14:52:48  *** RubenSomsen has quit IRC
185 2017-05-23T14:58:13  *** riemann has quit IRC
186 2017-05-23T15:10:25  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/321419bc06fdc19e3713b2bcfc10c3c9bbbb8b62
187 2017-05-23T15:10:25  <bitcoin-git> bitcoin/0.14 321419b Russell Yanofsky: Fix importwallet edge case rescan bug...
188 2017-05-23T15:13:10  *** laurentmt has joined #bitcoin-core-dev
189 2017-05-23T15:16:46  *** laurentmt has quit IRC
190 2017-05-23T15:16:49  *** RubenSomsen has joined #bitcoin-core-dev
191 2017-05-23T15:18:22  *** paveljanik has joined #bitcoin-core-dev
192 2017-05-23T15:29:50  *** RubenSomsen has quit IRC
193 2017-05-23T15:34:59  *** BashCo has quit IRC
194 2017-05-23T15:35:23  *** BashCo has joined #bitcoin-core-dev
195 2017-05-23T15:38:07  *** AaronvanW has quit IRC
196 2017-05-23T15:42:33  *** laurentmt has joined #bitcoin-core-dev
197 2017-05-23T15:44:47  *** laurentmt has quit IRC
198 2017-05-23T15:49:01  *** abpa has joined #bitcoin-core-dev
199 2017-05-23T15:53:57  *** AaronvanW has joined #bitcoin-core-dev
200 2017-05-23T15:53:58  *** AaronvanW has joined #bitcoin-core-dev
201 2017-05-23T16:15:35  *** BashCo has quit IRC
202 2017-05-23T16:21:56  *** Guyver2 has quit IRC
203 2017-05-23T16:34:17  *** BashCo has joined #bitcoin-core-dev
204 2017-05-23T16:45:49  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e76a3927c3b0...15254e907e8c
205 2017-05-23T16:45:50  <bitcoin-git> bitcoin/master 399fb8f Matt Corallo: Add internal method to add new random data to our internal RNG state
206 2017-05-23T16:45:50  <bitcoin-git> bitcoin/master 888cce5 Matt Corallo: Add perf counter data to GetStrongRandBytes state in scheduler
207 2017-05-23T16:45:51  <bitcoin-git> bitcoin/master 15254e9 Wladimir J. van der Laan: Merge #10372: Add perf counter data to GetStrongRandBytes state in scheduler...
208 2017-05-23T16:46:24  <bitcoin-git> [bitcoin] laanwj closed pull request #10372: Add perf counter data to GetStrongRandBytes state in scheduler (master...2017-05-scheduler-rng) https://github.com/bitcoin/bitcoin/pull/10372
209 2017-05-23T16:46:49  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/15254e907e8c...433c57aa6f30
210 2017-05-23T16:46:49  <bitcoin-git> bitcoin/master e49b868 practicalswift: [qt] Remove excess logic...
211 2017-05-23T16:46:50  <bitcoin-git> bitcoin/master 433c57a Wladimir J. van der Laan: Merge #10421: [qt] Remove excess logic: Prefer "return foo;" to "if (foo) { return true; } else { return false; }"...
212 2017-05-23T16:47:23  <bitcoin-git> [bitcoin] laanwj closed pull request #10421: [qt] Remove excess logic: Prefer "return foo;" to "if (foo) { return true; } else { return false; }" (master...if-expr-return-true-else-return-false) https://github.com/bitcoin/bitcoin/pull/10421
213 2017-05-23T16:52:34  <bitcoin-git> [bitcoin] laanwj closed pull request #10336: Get actual path for EUID instead of HOME dir (master...contrib) https://github.com/bitcoin/bitcoin/pull/10336
214 2017-05-23T16:55:15  *** d_t has joined #bitcoin-core-dev
215 2017-05-23T17:01:19  *** timothy has quit IRC
216 2017-05-23T17:07:06  *** talmai has joined #bitcoin-core-dev
217 2017-05-23T17:12:52  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/433c57aa6f30...46771514fa86
218 2017-05-23T17:12:53  <bitcoin-git> bitcoin/master 557c9a6 Matthew Zipkin: RPC: getblockchaininfo: BIP9 stats...
219 2017-05-23T17:12:53  <bitcoin-git> bitcoin/master 4677151 Wladimir J. van der Laan: Merge #9571: RPC: getblockchaininfo returns BIP signaling statistics...
220 2017-05-23T17:33:32  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/46771514fa86...ce8176d0389c
221 2017-05-23T17:33:33  <bitcoin-git> bitcoin/master ef8ca17 Russell Yanofsky: [test] Add tests for some walletmodel functions...
222 2017-05-23T17:33:33  <bitcoin-git> bitcoin/master d944bd7 Russell Yanofsky: [qt] Move some WalletModel functions into CWallet...
223 2017-05-23T17:33:34  <bitcoin-git> bitcoin/master 429aa9e Russell Yanofsky: [test] Move some tests from qt -> wallet...
224 2017-05-23T17:33:53  <bitcoin-git> [bitcoin] laanwj closed pull request #10295: [qt] Move some WalletModel functions into CWallet (master...pr/ipc-move) https://github.com/bitcoin/bitcoin/pull/10295
225 2017-05-23T17:35:19  *** laurentmt has joined #bitcoin-core-dev
226 2017-05-23T17:35:26  *** laurentmt has quit IRC
227 2017-05-23T17:36:33  *** BCBot_ has joined #bitcoin-core-dev
228 2017-05-23T17:37:11  *** waxwing has quit IRC
229 2017-05-23T17:40:13  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce8176d0389c...7e96ecf075e8
230 2017-05-23T17:40:13  <bitcoin-git> bitcoin/master 5844609 practicalswift: [net] Avoid initialization to a value that is never read...
231 2017-05-23T17:40:14  <bitcoin-git> bitcoin/master 7e96ecf Wladimir J. van der Laan: Merge #9539: [net] Avoid initialization to a value that is never read...
232 2017-05-23T17:40:47  *** BCBot has quit IRC
233 2017-05-23T17:41:14  *** waxwing has joined #bitcoin-core-dev
234 2017-05-23T17:45:09  *** talmai has quit IRC
235 2017-05-23T17:47:59  *** laurentmt has joined #bitcoin-core-dev
236 2017-05-23T17:55:11  *** laurentmt has quit IRC
237 2017-05-23T17:59:03  *** LeMiner has joined #bitcoin-core-dev
238 2017-05-23T18:01:46  *** waxwing has quit IRC
239 2017-05-23T18:01:47  *** waxwing has joined #bitcoin-core-dev
240 2017-05-23T18:02:05  *** talmai has joined #bitcoin-core-dev
241 2017-05-23T18:09:36  *** SopaXorzTaker has quit IRC
242 2017-05-23T18:14:25  *** talmai has quit IRC
243 2017-05-23T18:29:58  *** talmai has joined #bitcoin-core-dev
244 2017-05-23T18:37:31  *** RubenSomsen has joined #bitcoin-core-dev
245 2017-05-23T18:41:46  *** talmai has quit IRC
246 2017-05-23T18:44:22  <bitcoin-git> [bitcoin] pinheadmz closed pull request #10385: RPC: getblock returns coinbase scriptsig (master...cbtext) https://github.com/bitcoin/bitcoin/pull/10385
247 2017-05-23T18:45:33  *** harrymm has quit IRC
248 2017-05-23T18:47:20  *** talmai has joined #bitcoin-core-dev
249 2017-05-23T18:53:04  *** Giszmo has quit IRC
250 2017-05-23T18:54:03  *** Giszmo has joined #bitcoin-core-dev
251 2017-05-23T19:00:02  *** harrymm has joined #bitcoin-core-dev
252 2017-05-23T19:25:12  *** arubi has quit IRC
253 2017-05-23T19:25:38  *** arubi has joined #bitcoin-core-dev
254 2017-05-23T19:33:49  <ryanofsky> could 10244 be swapped for 10295 in the review list https://github.com/bitcoin/bitcoin/projects/8, since 10295 is now merged?
255 2017-05-23T19:41:58  *** talmai has quit IRC
256 2017-05-23T19:50:55  *** BCBot_ has quit IRC
257 2017-05-23T19:51:25  *** BCBot has joined #bitcoin-core-dev
258 2017-05-23T20:05:33  *** RubenSomsen has quit IRC
259 2017-05-23T20:06:06  *** rgod has joined #bitcoin-core-dev
260 2017-05-23T20:19:47  *** Giszmo has quit IRC
261 2017-05-23T20:21:27  *** AaronvanW has quit IRC
262 2017-05-23T20:22:03  *** AaronvanW has joined #bitcoin-core-dev
263 2017-05-23T20:22:03  *** AaronvanW has joined #bitcoin-core-dev
264 2017-05-23T20:24:40  *** owowo has quit IRC
265 2017-05-23T20:31:13  *** belcher has joined #bitcoin-core-dev
266 2017-05-23T20:40:43  *** Giszmo has joined #bitcoin-core-dev
267 2017-05-23T20:42:30  *** jeremyru1in is now known as jeremyrubin
268 2017-05-23T20:48:54  *** belcher has quit IRC
269 2017-05-23T20:53:03  *** owowo has joined #bitcoin-core-dev
270 2017-05-23T21:05:47  *** cryptapus_afk is now known as cryptapus
271 2017-05-23T21:11:45  *** Sprh has quit IRC
272 2017-05-23T21:17:20  *** talmai has joined #bitcoin-core-dev
273 2017-05-23T21:22:46  *** talmai has quit IRC
274 2017-05-23T21:36:19  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f2f7e97e8cc2...4cb8757aae1a
275 2017-05-23T21:36:19  <bitcoin-git> bitcoin/master cb184b3 Gregory Sanders: Add constant for maximum stack size
276 2017-05-23T21:36:20  <bitcoin-git> bitcoin/master 4cb8757 Pieter Wuille: Merge #10313: [Consensus] Add constant for maximum stack size...
277 2017-05-23T21:36:56  <bitcoin-git> [bitcoin] sipa closed pull request #10313: [Consensus] Add constant for maximum stack size (master...stackconst) https://github.com/bitcoin/bitcoin/pull/10313
278 2017-05-23T21:44:30  *** cryptapus is now known as cryptapus_afk
279 2017-05-23T21:49:03  <gmaxwell> Why does the test framework have seperate init code for a 'clean' chain vs not?  I would have expected it to have a single clean init and then one or more standard setup functions.
280 2017-05-23T21:49:21  <gmaxwell> The way it's constructed now makes it hard to use the standard setup but perform some tests before it happens.
281 2017-05-23T21:50:07  <gmaxwell> E.g. I want to make the gettxoutsetinfo test also run before the setup and verify that the txout set starts empty.
282 2017-05-23T21:50:45  <sipa> you can write a test that doesn't use the default state, iirc?
283 2017-05-23T21:51:18  <gmaxwell> yes, but then you can't get the default state. so it's hard to write a test that does both. just seemed odd.
284 2017-05-23T22:00:05  <gmaxwell> I'll just reorg back...
285 2017-05-23T22:09:47  <bitcoin-git> [bitcoin] jameshilliard opened pull request #10444: Implement BIP91 Reduced threshold Segwit MASF (0.14...segsignal-v0.14.1) https://github.com/bitcoin/bitcoin/pull/10444
286 2017-05-23T22:10:18  *** eragmus_ is now known as eragmus
287 2017-05-23T22:11:06  <jnewbery> probably because _initialize_chain() is copying the datadir from the cache (or creating a new one if it doesn't exist). If you ran it after your initial tests, it'd break all your assumptions
288 2017-05-23T22:11:17  <bitcoin-git> [bitcoin] gmaxwell opened pull request #10445: Add test for empty chain and reorg consistency for gettxoutsetinfo. (master...test_more_gettxoutset) https://github.com/bitcoin/bitcoin/pull/10445
289 2017-05-23T22:13:25  <gmaxwell> oh that would be a good reason why, caching.
290 2017-05-23T22:13:26  <gmaxwell> okay.
291 2017-05-23T22:21:08  *** vicenteH has quit IRC
292 2017-05-23T22:34:38  *** RubenSomsen has joined #bitcoin-core-dev
293 2017-05-23T22:34:38  *** twistedline has quit IRC
294 2017-05-23T22:35:26  *** twistedline has joined #bitcoin-core-dev
295 2017-05-23T22:39:05  *** RubenSomsen has quit IRC
296 2017-05-23T22:47:08  *** jannes has quit IRC
297 2017-05-23T23:06:37  *** musalbas has quit IRC
298 2017-05-23T23:21:37  *** musalbas has joined #bitcoin-core-dev
299 2017-05-23T23:23:12  *** harrymm has quit IRC
300 2017-05-23T23:29:35  *** Dyaheon has quit IRC
301 2017-05-23T23:31:55  *** Dyaheon has joined #bitcoin-core-dev
302 2017-05-23T23:57:18  *** abpa has quit IRC