1 2017-06-03T00:05:49  <luke-jr> spudI think you'll get arguments for using pb at all
  2 2017-06-03T00:15:06  *** elkalamar has quit IRC
  3 2017-06-03T00:22:10  *** str4d has joined #bitcoin-core-dev
  4 2017-06-03T00:33:03  *** Giszmo has quit IRC
  5 2017-06-03T00:45:45  *** nemgun1 has quit IRC
  6 2017-06-03T01:03:56  *** Ylbam has quit IRC
  7 2017-06-03T01:11:06  *** elkalamar has joined #bitcoin-core-dev
  8 2017-06-03T01:23:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  9 2017-06-03T01:39:10  *** laurentmt has quit IRC
 10 2017-06-03T02:24:15  <cfields> wumpus: considering there's already an 0.14.1rc1, I'd prefer not to sign the binaries with incorrect version
 11 2017-06-03T02:24:57  <cfields> i'd say just go ahead with release without signature
 12 2017-06-03T02:26:58  *** Chris_Stewart_5 has quit IRC
 13 2017-06-03T02:30:44  *** RubenSomsen has joined #bitcoin-core-dev
 14 2017-06-03T02:43:10  *** PaulCapestany has quit IRC
 15 2017-06-03T02:47:23  *** juscamarena has joined #bitcoin-core-dev
 16 2017-06-03T02:47:23  *** juscamarena_ has joined #bitcoin-core-dev
 17 2017-06-03T02:47:37  *** juscamarena has quit IRC
 18 2017-06-03T03:09:01  *** d9b4bef9 has quit IRC
 19 2017-06-03T03:10:08  *** d9b4bef9 has joined #bitcoin-core-dev
 20 2017-06-03T03:14:37  *** jtimon has quit IRC
 21 2017-06-03T03:51:14  *** cryptapus_afk has quit IRC
 22 2017-06-03T04:16:26  *** kadoban has quit IRC
 23 2017-06-03T04:24:56  *** PaulCapestany has joined #bitcoin-core-dev
 24 2017-06-03T04:27:26  *** Squidicc has joined #bitcoin-core-dev
 25 2017-06-03T04:29:21  *** Squidicuz has quit IRC
 26 2017-06-03T04:40:08  *** Squidicuz has joined #bitcoin-core-dev
 27 2017-06-03T04:41:51  *** Squidicc has quit IRC
 28 2017-06-03T04:50:01  <bitcoin-git> [bitcoin] jimmysong opened pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515
 29 2017-06-03T04:51:00  *** goatturner has quit IRC
 30 2017-06-03T04:52:12  <achow101> does anyone know if the waitforblock/waitfornewblock RPCs are used or will be used sometime in the future?
 31 2017-06-03T04:52:47  <achow101> The PR that adds them says that they are for testing and travis, but I don't see anything which actually uses those commands.
 32 2017-06-03T04:52:55  <achow101> cfields: ^^^ (you're the one who added them)
 33 2017-06-03T04:55:03  *** cryptapus has joined #bitcoin-core-dev
 34 2017-06-03T04:55:07  *** cryptapus is now known as cryptapus_afk
 35 2017-06-03T05:04:40  *** Guest80280 has joined #bitcoin-core-dev
 36 2017-06-03T05:06:14  <bitcoin-git> [bitcoin] luke-jr opened pull request #10516: Backports for 0.14.2 (0.14...0.14.2_fixes) https://github.com/bitcoin/bitcoin/pull/10516
 37 2017-06-03T05:09:05  *** cryptapus_afk has quit IRC
 38 2017-06-03T05:16:58  *** cryptapus_afk has joined #bitcoin-core-dev
 39 2017-06-03T05:16:58  *** cryptapus_afk has joined #bitcoin-core-dev
 40 2017-06-03T05:36:08  *** Yogaqueef has joined #bitcoin-core-dev
 41 2017-06-03T05:37:28  *** goatturner has joined #bitcoin-core-dev
 42 2017-06-03T05:47:09  *** RubenSomsen has quit IRC
 43 2017-06-03T05:51:56  *** sahl has joined #bitcoin-core-dev
 44 2017-06-03T05:57:01  *** RubenSomsen has joined #bitcoin-core-dev
 45 2017-06-03T06:00:18  *** goatturneer has joined #bitcoin-core-dev
 46 2017-06-03T06:01:37  *** Guest80280 has quit IRC
 47 2017-06-03T06:03:59  *** goatturner has quit IRC
 48 2017-06-03T06:07:21  *** kanzure has quit IRC
 49 2017-06-03T06:09:14  *** kanzure has joined #bitcoin-core-dev
 50 2017-06-03T06:10:57  *** grubles has quit IRC
 51 2017-06-03T06:12:51  *** zeusa1mighty has joined #bitcoin-core-dev
 52 2017-06-03T06:13:13  *** zeusalmighty has quit IRC
 53 2017-06-03T06:15:40  *** grubles has joined #bitcoin-core-dev
 54 2017-06-03T06:15:40  *** grubles has joined #bitcoin-core-dev
 55 2017-06-03T06:22:57  *** RubenSomsen has quit IRC
 56 2017-06-03T06:28:16  *** paveljanik has quit IRC
 57 2017-06-03T06:30:10  *** beatrootfarmer has joined #bitcoin-core-dev
 58 2017-06-03T06:33:43  *** goatturner has joined #bitcoin-core-dev
 59 2017-06-03T06:33:51  *** goatturneer has quit IRC
 60 2017-06-03T06:37:02  *** beatrootfarmer has quit IRC
 61 2017-06-03T07:18:18  *** cryptapus_afk has quit IRC
 62 2017-06-03T07:18:44  *** cryptapus_afk has joined #bitcoin-core-dev
 63 2017-06-03T07:48:48  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517
 64 2017-06-03T07:50:17  *** cryptapus_afk has quit IRC
 65 2017-06-03T07:53:44  *** [Author] has quit IRC
 66 2017-06-03T07:54:47  *** cryptapus_afk has joined #bitcoin-core-dev
 67 2017-06-03T07:58:46  *** cryptapus_afk has quit IRC
 68 2017-06-03T08:01:15  *** [Author] has joined #bitcoin-core-dev
 69 2017-06-03T08:03:09  *** vicenteH has joined #bitcoin-core-dev
 70 2017-06-03T08:09:12  *** btcdrak has quit IRC
 71 2017-06-03T08:12:59  *** goatturneer has joined #bitcoin-core-dev
 72 2017-06-03T08:16:56  *** goatturner has quit IRC
 73 2017-06-03T08:18:12  *** Ylbam has joined #bitcoin-core-dev
 74 2017-06-03T08:28:35  *** beatrootfarmer has joined #bitcoin-core-dev
 75 2017-06-03T08:30:15  *** goatturner has joined #bitcoin-core-dev
 76 2017-06-03T08:32:23  *** goatturneer has quit IRC
 77 2017-06-03T08:34:02  *** beatrootfarmer has quit IRC
 78 2017-06-03T08:48:51  *** cryptapus_afk has joined #bitcoin-core-dev
 79 2017-06-03T09:01:54  *** cryptapus_afk has quit IRC
 80 2017-06-03T09:05:14  *** btcdrak has joined #bitcoin-core-dev
 81 2017-06-03T09:16:05  *** spudowiar has joined #bitcoin-core-dev
 82 2017-06-03T09:45:13  *** Guest80280 has joined #bitcoin-core-dev
 83 2017-06-03T09:51:08  *** tunafizz has quit IRC
 84 2017-06-03T09:51:34  *** tunafizz has joined #bitcoin-core-dev
 85 2017-06-03T09:56:34  *** tiagotrs has joined #bitcoin-core-dev
 86 2017-06-03T10:10:02  *** d9b4bef9 has quit IRC
 87 2017-06-03T10:11:08  *** d9b4bef9 has joined #bitcoin-core-dev
 88 2017-06-03T10:33:09  *** rockhouse has joined #bitcoin-core-dev
 89 2017-06-03T10:41:26  <spudowiar> luke-jr: I meant changing the use of Protocol Buffers in Payment Requests
 90 2017-06-03T10:43:08  <phantomcircuit> spudowiar, the payments protocol stuff is basically just broken
 91 2017-06-03T10:43:37  <spudowiar> I was just suggesting switching from Google Protocol Buffers to nanopb, because nanopb generates nicer code
 92 2017-06-03T10:43:53  <spudowiar> (It's a protoc plugin)
 93 2017-06-03T10:46:51  *** rockhouse has quit IRC
 94 2017-06-03T10:48:06  *** rockhouse has joined #bitcoin-core-dev
 95 2017-06-03T10:48:43  *** tiagotrs has quit IRC
 96 2017-06-03T10:49:16  *** rockhouse has quit IRC
 97 2017-06-03T10:49:16  *** rockhouse has joined #bitcoin-core-dev
 98 2017-06-03T10:56:22  *** chjj has quit IRC
 99 2017-06-03T11:07:47  <jonasschnelli> spudowiar: is nanopb a dropin replacement for protoc?
100 2017-06-03T11:08:29  *** SopaXorzTaker has joined #bitcoin-core-dev
101 2017-06-03T11:08:33  *** Guyver2 has joined #bitcoin-core-dev
102 2017-06-03T11:10:16  *** chjj has joined #bitcoin-core-dev
103 2017-06-03T11:10:51  *** gielbier has quit IRC
104 2017-06-03T11:12:51  <spudowiar> jonasschnelli: It's a plugin for protoc. It generates different code but nicer code. It's primarily designed for C and microcontrollers though so it might not be that good a fit. Something to take a look at though.
105 2017-06-03T11:13:16  <jonasschnelli> Thanks... will take a closer look soon.
106 2017-06-03T11:32:35  *** Yogaqueef has quit IRC
107 2017-06-03T11:45:09  <jonasschnelli> Just curios,.. whats the reason for including ctaes.c in aes.c and adding CT_AES to EXTRA_DIST? instead of compiling/linking it regularly?
108 2017-06-03T11:48:45  <spudowiar> Has anyone tested secp256k1 with ctgrind?
109 2017-06-03T11:49:18  <spudowiar> (Valgrind constant time checker by Adam Langley)
110 2017-06-03T11:50:01  <spudowiar> I mean libsecp256k1
111 2017-06-03T11:56:25  <spudowiar> Actually, looking at the Modern Crypto mailing list, looks gmaxwell or someone did something similar
112 2017-06-03T12:20:54  *** elkalamar has quit IRC
113 2017-06-03T12:29:37  *** jtimon has joined #bitcoin-core-dev
114 2017-06-03T12:32:50  *** spudowiar has quit IRC
115 2017-06-03T12:38:42  *** spudowiar has joined #bitcoin-core-dev
116 2017-06-03T12:40:11  <jtimon> jnewbery: perhaps if we can't agree on changing the current make check we can at least start by adding new targets that could replace it, check-functional, check-all or something
117 2017-06-03T12:40:40  <jtimon> I would love to run the functional tests from the makefile
118 2017-06-03T13:01:56  *** nemgun has joined #bitcoin-core-dev
119 2017-06-03T13:21:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
120 2017-06-03T13:25:40  *** RubenSomsen has joined #bitcoin-core-dev
121 2017-06-03T14:02:13  *** Guest80280 has quit IRC
122 2017-06-03T14:16:11  *** Guest80280 has joined #bitcoin-core-dev
123 2017-06-03T14:19:22  *** laurentmt has joined #bitcoin-core-dev
124 2017-06-03T14:29:04  <bitcoin-git> [bitcoin] biniek opened pull request #10518: Fix translation error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10518
125 2017-06-03T14:44:35  <cfields> achow101: they were needed at one point to fix a race with the wallet. They're probably unnecessary now.
126 2017-06-03T14:46:13  <cfields> jonasschnelli: it's a .c file, but we want to make sure it gets compiled as c++, to avoid accidentally mixing in c flags
127 2017-06-03T14:47:05  <cfields> jonasschnelli: because we add everything to cxxflags. We might forget to (for ex) add fPIC/fPIE to CFLAGS
128 2017-06-03T15:08:22  *** str4d has quit IRC
129 2017-06-03T15:16:22  <jonasschnelli> cfields: thanks. I see.
130 2017-06-03T15:16:27  *** chjj has quit IRC
131 2017-06-03T15:30:49  *** chjj has joined #bitcoin-core-dev
132 2017-06-03T15:51:53  <spudowiar> jonasschnelli: So, if Core RPC doesn't have a method for getting the xpub, should I just create one for my HWW support?
133 2017-06-03T15:52:13  <spudowiar> Basically, I'm going to do a HWW plugin that's either a command or a server and supports JSON-RPC
134 2017-06-03T15:52:46  <spudowiar> e.g. You could do `bitcoin-qt -hww-cmd=bitcoin-hww-trezor`
135 2017-06-03T15:53:08  <spudowiar> Or even `bitcoin-qt -hww-server=http://user:password@othermachine:8332` and connect to another bitcoind
136 2017-06-03T15:53:33  <spudowiar> So, I guess I should just create another method or smth
137 2017-06-03T15:58:57  *** Dyaheon has quit IRC
138 2017-06-03T15:59:41  *** Dyaheon has joined #bitcoin-core-dev
139 2017-06-03T16:22:05  *** chjj has quit IRC
140 2017-06-03T16:36:32  *** chjj has joined #bitcoin-core-dev
141 2017-06-03T16:36:46  <bitcoin-git> [bitcoin] achow101 opened pull request #10519: [RPC] Remove waitforblock and waitfornewblock (master...rm-waitforblock-rpcs) https://github.com/bitcoin/bitcoin/pull/10519
142 2017-06-03T16:38:07  <jonasschnelli> spudowiar: for HWW support, Core needs flexible keypath (BIP44) with support for pub-key-derivation (currently only hardened derivation is supported), there is a PR from NicolasDorier (check it out).
143 2017-06-03T16:38:28  <jonasschnelli> You don't want to mix xpriv with support for single child key private key exports
144 2017-06-03T16:39:05  <jonasschnelli> mixing non hardened derivation with private child key export is kinda careless
145 2017-06-03T16:52:55  <spudowiar> jonasschnelli: I have all the necessary patches from NicolasDorier applied to my tree
146 2017-06-03T16:53:15  <spudowiar> jonasschnelli: Anyway, the HWW plugin has an RPC method gethwwinfo
147 2017-06-03T16:53:23  <spudowiar> That contains some information about the hardware wallet
148 2017-06-03T16:53:28  <spudowiar> Like the xpub
149 2017-06-03T16:55:17  *** laurentmt has quit IRC
150 2017-06-03T16:56:05  <jonasschnelli> spudowiar: So you are adding those methods to Core? Or do you have a "middleware" between Core and the HWW?
151 2017-06-03T16:56:12  <jonasschnelli> Do you intend to PR that stuff?
152 2017-06-03T16:56:36  <spudowiar> So, I have a HWW plugin (a command called bitcoin-hww-trezor)
153 2017-06-03T16:56:49  <spudowiar> And CWallet starts that process
154 2017-06-03T16:57:21  <spudowiar> Then I can send RPC requests over stdio to the process and it can send RPC requests back to Core
155 2017-06-03T16:57:37  <spudowiar> So, when something is signed, it sends signrawtransaction to the HWW plugin
156 2017-06-03T16:57:52  <spudowiar> And the HWW plugin will do stuff like send validateaddress (to get the keypath) and decoderawtransaction, etc.
157 2017-06-03T16:58:13  <spudowiar> Also, there's a gethwwinfo which is sent by Core right at the start to get the xpub, etc.
158 2017-06-03T17:01:24  <jonasschnelli> cool stuff
159 2017-06-03T17:01:32  <spudowiar> Although this is quite a bit more complicated than my previous method so I'm not sure how good an idea it is
160 2017-06-03T17:01:53  <spudowiar> Previous method was just start the process when signing needs to happen and pipe a JSON representation of the transaction, with some metadata
161 2017-06-03T17:02:02  <jonasschnelli> IMO working with watchonlys on the Core side and send out the unsigned transaction to a plugin could make more sense?
162 2017-06-03T17:02:24  <spudowiar> That's what it does
163 2017-06-03T17:02:30  <jonasschnelli> ah! cool
164 2017-06-03T17:02:55  <spudowiar> So, if it's a hardware wallet, CWallet::IsMine will treat watch only as normal keys
166 2017-06-03T17:29:39  *** d_t has joined #bitcoin-core-dev
167 2017-06-03T17:31:23  *** Chris_Stewart_5 has quit IRC
168 2017-06-03T17:38:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
169 2017-06-03T18:03:52  *** Chris_Stewart_5 has quit IRC
170 2017-06-03T18:03:53  *** Dyaheon has quit IRC
171 2017-06-03T18:04:55  *** Dyaheon has joined #bitcoin-core-dev
172 2017-06-03T18:15:24  <bitcoin-git> [bitcoin] sipa closed pull request #10518: Fix translation error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10518
173 2017-06-03T18:29:21  *** Guest52697 has joined #bitcoin-core-dev
174 2017-06-03T18:38:01  *** RubenSomsen has quit IRC
175 2017-06-03T19:04:13  *** elkalamar has joined #bitcoin-core-dev
176 2017-06-03T19:05:50  *** davec has quit IRC
177 2017-06-03T19:10:44  *** laurentmt has joined #bitcoin-core-dev
178 2017-06-03T19:11:14  *** laurentmt has quit IRC
179 2017-06-03T19:17:25  *** davec has joined #bitcoin-core-dev
180 2017-06-03T19:17:46  <spudowiar> jonasschnelli: What do you think about using a file descriptor for the child? Because having bi directional JSON-RPC gets a bit messy
181 2017-06-03T19:18:08  <spudowiar> But I could do stdin, stdout and a file descriptor for a socket (to the Bitcoin daemon RPC server)
182 2017-06-03T19:18:17  <spudowiar> Hmm, maybe not actually
183 2017-06-03T19:18:31  <spudowiar> To be honest, only when you want to sign something should it handle the messages
184 2017-06-03T19:18:33  <spudowiar> nvm
185 2017-06-03T19:18:35  <spudowiar> :)
186 2017-06-03T19:23:14  <luke-jr> spudowiar: why do you need bi-directional?
187 2017-06-03T19:27:34  <spudowiar> luke-jr: Because then you can do "Bitcoin Core asks HWW signrawtransaction", "HWW asks Bitcoin Core gettransaction", "HWW responds to signrawtransaction"
188 2017-06-03T19:27:56  <luke-jr> ah
189 2017-06-03T19:29:25  <gmaxwell> spudowiar: I think it should be safe to assume the wallet needs the inputs and just pass them.
190 2017-06-03T19:29:45  <gmaxwell> it can just drop them if it doesn't need them.
191 2017-06-03T19:30:05  <spudowiar> gmaxwell: I was thinking of mimicking an API like signrawtransaction though
192 2017-06-03T19:30:42  <gmaxwell> apparently not, since that api doesn't have two way communication. :P
193 2017-06-03T19:31:02  <spudowiar> Well, it's going to be over stdio :)
194 2017-06-03T19:31:30  <spudowiar> It's basically mimicking the API, because you could just as easily have the HWW plugin connect to the Bitcoin Core over HTTP RPC
195 2017-06-03T19:31:42  <spudowiar> Except it's doing it over stdio
196 2017-06-03T19:31:52  <spudowiar> Which happens to be where the other call came from :)
197 2017-06-03T19:31:54  <sipa> thinking further, it seems strange that the HW/wrapper would need to know what it's missing
198 2017-06-03T19:32:15  <spudowiar> What do you mean?
199 2017-06-03T19:32:16  <sipa> especially if we ever get schnorr multisig or even aggregation
200 2017-06-03T19:32:42  <sipa> the signrawtransaction API is "pass it in partially signed transactions, and do with it what you can"
201 2017-06-03T19:33:05  <sipa> i think that's a good approach, also for HW wallets
202 2017-06-03T19:33:20  <spudowiar> Yeah, but it needs to have the input transactions
203 2017-06-03T19:33:25  <sipa> so pass them
204 2017-06-03T19:33:32  <sipa> the wallet knows whether the HW wallet needs them
205 2017-06-03T19:33:44  <spudowiar> Right, so don't bother with the JSON-RPC emulation then?
206 2017-06-03T19:33:56  <sipa> i think that's unnecessarily complicating the API
207 2017-06-03T19:34:19  <spudowiar> Well, I kept my old branch behind (without this stuff), so that's fine :)
208 2017-06-03T19:34:23  <spudowiar> This was just an experiment :)
209 2017-06-03T19:36:55  *** chjj has quit IRC
210 2017-06-03T19:43:51  *** spudowiar has quit IRC
211 2017-06-03T19:50:25  *** chjj has joined #bitcoin-core-dev
212 2017-06-03T20:29:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
213 2017-06-03T20:35:10  *** roidster has joined #bitcoin-core-dev
214 2017-06-03T20:35:10  *** roidster is now known as Guest64521
215 2017-06-03T20:36:15  *** d_t has quit IRC
216 2017-06-03T20:41:46  *** chjj has quit IRC
217 2017-06-03T20:55:01  *** chjj has joined #bitcoin-core-dev
218 2017-06-03T21:01:28  *** Chris_Stewart_5 has quit IRC
219 2017-06-03T21:27:27  *** Guest64521 is now known as roidster
220 2017-06-03T21:37:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
221 2017-06-03T21:42:08  <bitcoin-git> [bitcoin] practicalswift opened pull request #10521: Limit variable scope (master...tighten-scope) https://github.com/bitcoin/bitcoin/pull/10521
222 2017-06-03T21:47:08  *** chjj has quit IRC
223 2017-06-03T21:55:28  <bitcoin-git> [bitcoin] practicalswift opened pull request #10522: Remove unused variables (master...unused-strings) https://github.com/bitcoin/bitcoin/pull/10522
224 2017-06-03T21:57:52  *** Guest80280 has quit IRC
225 2017-06-03T21:59:48  *** roidster has quit IRC
226 2017-06-03T22:00:53  *** chjj has joined #bitcoin-core-dev
227 2017-06-03T22:34:58  *** Guest80280 has joined #bitcoin-core-dev
228 2017-06-03T22:35:39  *** Chris_Stewart_5 has quit IRC
229 2017-06-03T22:55:54  *** AaronvanW has quit IRC
230 2017-06-03T22:56:32  *** AaronvanW has joined #bitcoin-core-dev
231 2017-06-03T23:19:40  *** Guyver2 has quit IRC
232 2017-06-03T23:20:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
233 2017-06-03T23:20:18  <bitcoin-git> [bitcoin] practicalswift opened pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
234 2017-06-03T23:31:36  <bitcoin-git> [bitcoin] practicalswift opened pull request #10524: Fix incorrect format strings (master...u-for-unsigned-int) https://github.com/bitcoin/bitcoin/pull/10524
235 2017-06-03T23:33:31  *** justanotheruser has quit IRC
236 2017-06-03T23:34:56  *** belcher has joined #bitcoin-core-dev
237 2017-06-03T23:37:55  *** justanotheruser has joined #bitcoin-core-dev
238 2017-06-03T23:51:32  *** Yogaqueef has joined #bitcoin-core-dev
239 2017-06-03T23:53:12  *** Guest19621 has joined #bitcoin-core-dev
240 2017-06-03T23:56:27  *** Chris_Stewart_5 has quit IRC
241 2017-06-03T23:56:32  *** Guest19621 is now known as roidster
242 2017-06-03T23:58:31  *** str4d has joined #bitcoin-core-dev