1 2017-06-16T00:01:02  *** abpa has quit IRC
  2 2017-06-16T00:14:40  *** AaronvanW has quit IRC
  3 2017-06-16T00:15:38  *** apll has quit IRC
  4 2017-06-16T00:17:28  *** apll has joined #bitcoin-core-dev
  5 2017-06-16T00:21:17  *** mol has quit IRC
  6 2017-06-16T00:23:00  *** mol has joined #bitcoin-core-dev
  7 2017-06-16T00:46:27  *** Chris_Stewart_5 has quit IRC
  8 2017-06-16T00:47:22  <bitcoin-git> [bitcoin] gmaxwell opened pull request #10608: Add a comment explaining the use of MAX_BLOCK_BASE_SIZE. (master...size_comment) https://github.com/bitcoin/bitcoin/pull/10608
  9 2017-06-16T00:56:53  *** dabura667 has joined #bitcoin-core-dev
 10 2017-06-16T00:58:41  *** dabura667 has quit IRC
 11 2017-06-16T00:59:50  *** dabura667 has joined #bitcoin-core-dev
 12 2017-06-16T01:12:16  *** Ylbam has quit IRC
 13 2017-06-16T01:27:47  <NicolasDorier> wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 instagibbs achow101 : Sorry to ping you all, but since some dev are in Tokyo around end of july for some conferences, I thought it can be a good idea to have such occasion to have 1 or 2 days of pure bitcoin core
 14 2017-06-16T01:27:47  <NicolasDorier> coding/review/idea sharing together. If you are interested, come in the channel ##tokyocore . My company Digital Garage can give us a nice place to go for coding. Note: I certaintly forgot some name, if you are contributor and wish to come, you are defintively welcome. The 25 June we freeze the list.
 15 2017-06-16T01:31:37  <cfields> NicolasDorier: thanks for arranging!
 16 2017-06-16T01:33:49  *** Dyaheon has quit IRC
 17 2017-06-16T01:39:15  *** Dyaheon has joined #bitcoin-core-dev
 18 2017-06-16T02:04:22  *** AaronvanW has joined #bitcoin-core-dev
 19 2017-06-16T02:10:35  *** AaronvanW has quit IRC
 20 2017-06-16T02:18:46  <cfields> gitian builders: 0.14.2 detached sigs are up
 21 2017-06-16T02:21:59  *** ProfMac has quit IRC
 22 2017-06-16T02:24:08  *** elkalamar has quit IRC
 23 2017-06-16T03:28:23  *** ProfMac has joined #bitcoin-core-dev
 24 2017-06-16T03:56:10  *** RubenSomsen has quit IRC
 25 2017-06-16T04:06:29  *** Dyaheon has quit IRC
 26 2017-06-16T04:08:25  *** Dyaheon has joined #bitcoin-core-dev
 27 2017-06-16T04:33:40  <cfields> NicolasDorier: I just rsvpd as I was going to be there already. Thanks again.
 28 2017-06-16T04:47:49  *** ProfMac has quit IRC
 29 2017-06-16T04:57:13  <NicolasDorier> yay awesome
 30 2017-06-16T05:01:14  *** harding has quit IRC
 31 2017-06-16T05:37:43  *** [Author] has quit IRC
 32 2017-06-16T05:41:05  *** [Author] has joined #bitcoin-core-dev
 33 2017-06-16T05:42:22  *** RubenSomsen has joined #bitcoin-core-dev
 34 2017-06-16T06:07:52  *** AaronvanW has joined #bitcoin-core-dev
 35 2017-06-16T06:11:59  *** Ylbam has joined #bitcoin-core-dev
 36 2017-06-16T06:12:38  *** AaronvanW has quit IRC
 37 2017-06-16T06:29:32  *** ClockCat has joined #bitcoin-core-dev
 38 2017-06-16T06:35:31  *** goatpig has quit IRC
 39 2017-06-16T06:41:45  *** SopaXorzTaker has joined #bitcoin-core-dev
 40 2017-06-16T06:44:08  *** Cory has quit IRC
 41 2017-06-16T06:46:06  *** BashCo has quit IRC
 42 2017-06-16T06:47:27  *** Giszmo has quit IRC
 43 2017-06-16T06:48:39  *** ClockCat has quit IRC
 44 2017-06-16T06:56:12  *** Pasha has joined #bitcoin-core-dev
 45 2017-06-16T06:59:23  *** Pasha is now known as Cory
 46 2017-06-16T07:05:02  *** Giszmo has joined #bitcoin-core-dev
 47 2017-06-16T07:35:45  *** Guest___ has joined #bitcoin-core-dev
 48 2017-06-16T07:43:12  *** paveljanik has quit IRC
 49 2017-06-16T07:43:12  *** timothy has joined #bitcoin-core-dev
 50 2017-06-16T07:53:40  *** Guest___ has quit IRC
 51 2017-06-16T08:01:20  *** btcdrak has quit IRC
 52 2017-06-16T08:08:34  *** AaronvanW has joined #bitcoin-core-dev
 53 2017-06-16T08:12:53  *** AaronvanW has quit IRC
 54 2017-06-16T08:14:26  *** btcdrak has joined #bitcoin-core-dev
 55 2017-06-16T08:14:41  *** AaronvanW has joined #bitcoin-core-dev
 56 2017-06-16T08:14:51  *** btcdrak is now known as Guest48187
 57 2017-06-16T08:15:09  *** Guest48187 has joined #bitcoin-core-dev
 58 2017-06-16T08:15:40  *** btcdrak_ has joined #bitcoin-core-dev
 59 2017-06-16T08:16:14  *** btcdrak_ is now known as btcdrak
 60 2017-06-16T08:16:29  *** btcdrak has joined #bitcoin-core-dev
 61 2017-06-16T08:28:20  *** goatturneer has joined #bitcoin-core-dev
 62 2017-06-16T08:29:24  *** Giszmo has quit IRC
 63 2017-06-16T08:31:47  *** beatrootfarmer has quit IRC
 64 2017-06-16T08:33:40  *** LeMiner has quit IRC
 65 2017-06-16T08:34:36  *** RubenSomsen has quit IRC
 66 2017-06-16T08:35:06  *** Guyver2 has joined #bitcoin-core-dev
 67 2017-06-16T09:09:46  *** jouke has quit IRC
 68 2017-06-16T09:11:53  *** jouke has joined #bitcoin-core-dev
 69 2017-06-16T09:21:36  *** beatrootfarmer has joined #bitcoin-core-dev
 70 2017-06-16T09:24:53  *** goatturneer has quit IRC
 71 2017-06-16T09:38:18  *** RubenSomsen has joined #bitcoin-core-dev
 72 2017-06-16T09:50:27  <luke-jr> you know you're up too late when you don't remember what the bug you were trying to fix was. ._.
 73 2017-06-16T09:59:37  *** LeMiner has joined #bitcoin-core-dev
 74 2017-06-16T10:01:51  <wumpus> cfields: thanks, pushed 0.14.2 signed sigs
 75 2017-06-16T10:06:16  *** afk11 has quit IRC
 76 2017-06-16T10:06:58  *** afk11 has joined #bitcoin-core-dev
 77 2017-06-16T10:45:03  *** RubenSomsen has quit IRC
 78 2017-06-16T10:48:51  *** laurentmt has joined #bitcoin-core-dev
 79 2017-06-16T10:51:43  *** laurentmt has quit IRC
 80 2017-06-16T10:58:46  *** RubenSomsen has joined #bitcoin-core-dev
 81 2017-06-16T10:58:48  *** Guyver2_ has joined #bitcoin-core-dev
 82 2017-06-16T11:00:48  *** Guyver2 has quit IRC
 83 2017-06-16T11:00:52  *** Guyver2_ is now known as Guyver2
 84 2017-06-16T11:05:52  *** cryptapus_afk has quit IRC
 85 2017-06-16T11:08:23  *** RubenSomsen has quit IRC
 86 2017-06-16T11:34:14  *** laurentmt has joined #bitcoin-core-dev
 87 2017-06-16T11:35:23  *** annanay25 has quit IRC
 88 2017-06-16T11:35:32  *** annanay25 has joined #bitcoin-core-dev
 89 2017-06-16T11:51:05  <jonasschnelli> cfields: with be49a294a240ec81a901af1aaabbba2172d38dc1 I get only a single lock report... haven't looked at your code thourgh
 90 2017-06-16T11:51:08  <jonasschnelli> *though
 91 2017-06-16T11:56:27  *** BashCo has joined #bitcoin-core-dev
 92 2017-06-16T11:57:27  *** JackH has quit IRC
 93 2017-06-16T12:02:42  <jonasschnelli> wumpus: the pollBalanceThread is mainly responsible for UI freezes...
 94 2017-06-16T12:02:54  <jonasschnelli> If I disable that poll thread,.. stuff runs much better
 95 2017-06-16T12:05:26  *** arubi has quit IRC
 96 2017-06-16T12:05:26  *** afk11 has quit IRC
 97 2017-06-16T12:06:47  *** afk11 has joined #bitcoin-core-dev
 98 2017-06-16T12:06:56  *** arubi has joined #bitcoin-core-dev
 99 2017-06-16T12:18:06  *** apll has quit IRC
100 2017-06-16T12:18:58  *** dabura667 has quit IRC
101 2017-06-16T12:22:20  *** afk11 has quit IRC
102 2017-06-16T12:22:33  *** afk11 has joined #bitcoin-core-dev
103 2017-06-16T12:23:50  <jonasschnelli> ryanofsky: I'll give it a test (polling but keeping the cache)
104 2017-06-16T12:24:01  *** cryptapus_afk has joined #bitcoin-core-dev
105 2017-06-16T12:24:21  <jonasschnelli> ryanofsky: But what I don't understand is why we would/should do a TRY_LOCK on cs_main every 250ms
106 2017-06-16T12:25:08  <jonasschnelli> cfields: nighly gitian build crashes on OSX (not tested on WIN/LINUX): https://0bin.net/paste/8-QKc7g9psBmYIGJ#msAwcpNd1CtU4KdEObG7tN4PK0XiIAbiELdwUtJLzui
107 2017-06-16T12:25:33  *** Char0n has joined #bitcoin-core-dev
108 2017-06-16T12:57:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
109 2017-06-16T13:04:32  *** Guyver2 has quit IRC
110 2017-06-16T13:08:56  *** Guyver2 has joined #bitcoin-core-dev
111 2017-06-16T13:14:32  *** johnpark_pj has joined #bitcoin-core-dev
112 2017-06-16T13:17:47  *** goatturner has joined #bitcoin-core-dev
113 2017-06-16T13:18:40  *** beatrootfarmer has quit IRC
114 2017-06-16T13:29:46  <jonasschnelli> sipa: you said CCoinsViewDB::Upgrade() can be cancelled (and continued) any time. Is that correct?
115 2017-06-16T13:30:12  <jonasschnelli> Adding a check for ShutdownRequested() and break the while (and write the possible batch) would make sense then?
116 2017-06-16T13:32:46  *** laurentmt has quit IRC
117 2017-06-16T13:33:22  <michagogo> Will have 0.14.2 signed up shortly
118 2017-06-16T13:33:29  <michagogo> Doing a bit of VM maintenance
119 2017-06-16T13:33:55  <michagogo> Speaking of which: does anyone know what the status is of Gitian in Xenial?
120 2017-06-16T13:34:59  <michagogo> ISTR that for some reason we can't actually compile on Xenial and so the guest needs to remain Trusty, but can the Gitian (LXC) *host* be Xenial?
121 2017-06-16T13:36:26  <jonasschnelli> michagogo: Xenial should work fine IMO
122 2017-06-16T13:41:53  <sipa> jonasschnelli: i guess!
123 2017-06-16T13:42:07  <jonasschnelli> sipa: Seems to work here...
124 2017-06-16T13:42:29  <jonasschnelli> sipa: Can you tell me again how I can calculate the progress in that pcursor while loop?
125 2017-06-16T13:43:48  <sipa> i'll make a commit later
126 2017-06-16T13:43:52  <sipa> thanks for doing thid
127 2017-06-16T13:44:30  *** BashCo has quit IRC
128 2017-06-16T13:45:55  <jonasschnelli> okay. thanks
129 2017-06-16T13:52:48  <wumpus> jonasschnelli: interesting! I hadn't expected that, it should only update the balance if the TRY_ succeeds not freeze on the lock update
130 2017-06-16T13:53:21  <jonasschnelli> I don't know why currently but I know that its much faster with that PR
131 2017-06-16T13:53:27  <jonasschnelli> At least on OSX
132 2017-06-16T13:53:41  <jonasschnelli> Would be nice if someone could profile it on Linux / Win.
133 2017-06-16T13:54:06  <wumpus> but the try_lock on cs_main should not *itself* cause freezes
134 2017-06-16T13:54:43  <wumpus> if it runs the poll, and the lock is not available, the whole point would be that it doesn't spend time
135 2017-06-16T13:54:56  <wumpus> if that's not how it works it seems the whole TRY_ concept is broken
136 2017-06-16T13:55:22  <jonasschnelli> but what if the TRY_LOCK can acquire the lock every 250 ms and do the calculation...
137 2017-06-16T13:55:45  <wumpus> it should only do the computation if the balance is dirty, right?
138 2017-06-16T13:56:30  <wumpus> so in by far most cases if it gets the lock,  it immediately is supposed to notice the balance is not dirty, so doesn't recompute it
139 2017-06-16T13:56:35  <jonasschnelli> I tested three options, 1) master, 2) only atomic caches with polling, 3) like 2 but polling replaced with signal
140 2017-06-16T13:56:39  <wumpus> if only needs to be recomputed if something changed
141 2017-06-16T13:56:47  <jonasschnelli> wumpus: so, yes. It should only lock when the balances are dirty
142 2017-06-16T13:57:08  <jonasschnelli> But in my test, I sent 20 txes, so the balance was always dirty afterwards
143 2017-06-16T13:57:25  <jonasschnelli> I don't know why its much slower with the TRY_LOCK
144 2017-06-16T13:57:28  <wumpus> right
145 2017-06-16T13:57:53  <jonasschnelli> I guess it must be the QTimer / TryLock overhead?!
146 2017-06-16T13:57:54  <wumpus> well yes if it gets a transaction every 250ms, sure
147 2017-06-16T13:58:05  <ryanofsky> i'd think TRY_LOCK only when balances were dirty would give best of both worlds
148 2017-06-16T13:58:09  <jonasschnelli> I manually sent the tx... ~every 0.5s
149 2017-06-16T13:58:09  <wumpus> but GUI freezes happen anso to people that don't have anythign in their wallet
150 2017-06-16T13:58:12  <wumpus> on the first sync
151 2017-06-16T13:58:36  <jonasschnelli> ryanofsky: I though as well,.. but look at my profile results,.. they tell a different story
152 2017-06-16T13:58:47  <wumpus> so it can't be just something with transactions, though there's clearly something with transactions too...
153 2017-06-16T13:58:51  <ryanofsky> oh ok, i didn't see that listed as one your three tests
154 2017-06-16T13:59:04  <jonasschnelli> Look here: https://github.com/bitcoin/bitcoin/pull/10251#issuecomment-309021160
155 2017-06-16T13:59:40  <jonasschnelli> Master with only the atomic caches result in still 33% of the execution time in that poll function
156 2017-06-16T13:59:49  <wumpus> ok
157 2017-06-16T14:00:05  <jonasschnelli> While I can't find any call in my profiler running pure (all commits) of 10251
158 2017-06-16T14:00:06  <wumpus> 33% of the time for something that gets called 4 times per second?
159 2017-06-16T14:00:14  <wumpus> is that a very large wallet?
160 2017-06-16T14:00:15  <jonasschnelli> *any call that related to the balance update
161 2017-06-16T14:00:29  <jonasschnelli> wumpus: not really large,.. I only did generate 1100
162 2017-06-16T14:00:39  <jonasschnelli> depends what "large" is
163 2017-06-16T14:00:45  <wumpus> it's interesting that the balance computation is so slow
164 2017-06-16T14:00:58  <wumpus> well if so, that's already large, it seems
165 2017-06-16T14:00:59  <jonasschnelli> I guess we loop 6 times over the complete mapWallet
166 2017-06-16T14:01:05  <wumpus> oh wow
167 2017-06-16T14:01:16  <jonasschnelli> for all balance types...
168 2017-06-16T14:02:55  <wumpus> ok, yes then I understand why things are so slow, though I still don't understand why it recomputes also the times the balance was not updated
169 2017-06-16T14:03:13  <wumpus> it's as if the wallet is always dirty, even though only once in 0.5s a transaction arrives
170 2017-06-16T14:03:40  <jonasschnelli> I'm not sure if it recomputes then...
171 2017-06-16T14:03:45  <wumpus> because in principle, this should result in the same load: with the 0.25s poll, it should compute every time after a transaction comes it
172 2017-06-16T14:03:59  <jonasschnelli> But when it does,.. it seems to take much longer.. don't know why. Maybe because of the QTimer internals
173 2017-06-16T14:04:01  <wumpus> with the per-transaction notification, it also does
174 2017-06-16T14:04:20  <wumpus> what if the transaction rate is higher though, e.g. with 10 transactions per second the polling shoudl be faster
175 2017-06-16T14:04:33  <jonasschnelli> Yes. Indeed.
176 2017-06-16T14:04:46  <jonasschnelli> The signal should filter that out... min 250ms delta or something
177 2017-06-16T14:05:01  <wumpus> the fixed polling is also to reduce the maximum amount of work done
178 2017-06-16T14:05:11  <jonasschnelli> yes.. indeed.
179 2017-06-16T14:05:24  <wumpus> yes, it could, though if done not carefully it means the data is always one update behind
180 2017-06-16T14:05:39  <wumpus> (e.g. if you would naively do "process this update only if the last was >250ms ago")
181 2017-06-16T14:05:40  <jonasschnelli> Could it be the QTimer overhead?
182 2017-06-16T14:05:45  <wumpus> no, I don't believe that
183 2017-06-16T14:05:58  <wumpus> not at a 4Hz frequency
184 2017-06-16T14:06:13  <wumpus> if you remove the code from the handler but keep the timer, it'd probably be the same
185 2017-06-16T14:06:48  *** ProfMac has joined #bitcoin-core-dev
186 2017-06-16T14:07:19  <jonasschnelli> I guess we should then try to continue to measure the atomic cache commit on top of master (with the TRY_LOCK polling).
187 2017-06-16T14:07:40  <jonasschnelli> This is already much faster (I don't have numbers though)
188 2017-06-16T14:07:45  <jonasschnelli> s/is/feels/
189 2017-06-16T14:08:06  <wumpus> I'm really surprised by the result at least...
190 2017-06-16T14:08:11  <jonasschnelli> What could be that we falsely always set fForceCheckBalanceChanged
191 2017-06-16T14:08:24  <jonasschnelli> Could also be OSX only... who knows
192 2017-06-16T14:08:32  <jonasschnelli> But since we also have a windows issue...
193 2017-06-16T14:08:39  <jonasschnelli> I doubt it's OSX only
194 2017-06-16T14:09:09  <wumpus> btw: what is the advantage of having a dirty flag per kind of balance - won't every update to the wallet invalidate *all* of them?
195 2017-06-16T14:09:47  <wumpus> or are there changes that, say, only invalidate the immutable balance
196 2017-06-16T14:10:24  * jonasschnelli looking at the code again
197 2017-06-16T14:10:28  <ProfMac> I feel like this is the secret password to join a club:  a60d7c8dde9b77e7ff547976ce37db1fe98c71833003465befe650d6bc102b6b  bitcoin-0.14.1-aarch64-linux-gnu.tar.gz
198 2017-06-16T14:10:36  <wumpus> ProfMac: congrats!
199 2017-06-16T14:10:43  <wumpus> so you got it to work, awesome
200 2017-06-16T14:11:03  <ProfMac> I said bad things & stomped my foot a time or two.
201 2017-06-16T14:11:04  <jonasschnelli> ProfMac: nice one!
202 2017-06-16T14:11:07  <ryanofsky> i think dirty flag doesn't really make sense for qt, but it does make sense for rpc
203 2017-06-16T14:11:36  <wumpus> so the balance computations loop over all transactions?
204 2017-06-16T14:11:44  <wumpus> which is always done 6 times
205 2017-06-16T14:11:53  <jonasschnelli> wumpus: because each balance type has its own routine to calculate, we probably should have caches/dirty-flags per routine
206 2017-06-16T14:12:03  <jonasschnelli> wumpus: that's the root source!
207 2017-06-16T14:12:04  <wumpus> I wonder if it'd make sense to roll it into one routine, that computes all 6 balalnces in one pass
208 2017-06-16T14:12:13  <jonasschnelli> wumpus: +100
209 2017-06-16T14:12:25  <wumpus> it would be more cache friendly at least
210 2017-06-16T14:12:33  <jonasschnelli> I guess that was a "organic growing" issue... we added one type after another over tim,e
211 2017-06-16T14:12:55  <wumpus> the added overhead of, in that loop over every transaction, adding up one more number is probably neglible
212 2017-06-16T14:13:13  <jonasschnelli> indeed
213 2017-06-16T14:13:16  <wumpus> while LOCKing the wallet six times and iterating over its contents six times is probably bad
214 2017-06-16T14:13:34  <wumpus> in any case it's good that your PR already brings improvements
215 2017-06-16T14:13:39  <wumpus> then we should probably merge it
216 2017-06-16T14:13:44  <jonasschnelli> But now it comes...
217 2017-06-16T14:13:48  *** goatpig has joined #bitcoin-core-dev
218 2017-06-16T14:13:54  <jonasschnelli> We call GetDepthInMainChain for each mapWallet tx
219 2017-06-16T14:14:02  <jonasschnelli> Which does mapBlockIndex.find(hashBlock);
220 2017-06-16T14:14:26  <jonasschnelli> I tried multiple times to cache the height... but seems to be relatively difficult to do it right
221 2017-06-16T14:14:45  <wumpus> that would also be reduced with factor 6 if it were to be done in one go
222 2017-06-16T14:14:55  <jonasschnelli> Yes.
223 2017-06-16T14:15:40  <jonasschnelli> That would be related to 10251 but with a bigger ramification
224 2017-06-16T14:15:52  <wumpus> I mean *ideally* the wallet would compute balance incremementally
225 2017-06-16T14:15:56  <jonasschnelli> I think the pure atomic caches is a first step... even if we then can throw away all down to a sigle cache
226 2017-06-16T14:16:03  <jonasschnelli> wumpus: Yes.
227 2017-06-16T14:16:13  <jonasschnelli> It should keep basepoints at certain height/states
228 2017-06-16T14:16:20  <wumpus> but if we had to do a pass over the entire wallet it's by far best to do it only once
229 2017-06-16T14:16:41  <wumpus> right, it's extremely complex to get right, which is why it was never done
230 2017-06-16T14:16:53  <jonasschnelli> Indeed, ... and we should probably do in – as most things – in a background thread (GUI wise)
231 2017-06-16T14:17:18  <jonasschnelli> If the node coms where in a background thread, nobody would tackle this
232 2017-06-16T14:17:21  <wumpus> e.g. there are so many small things that can change how a transaction is counted
233 2017-06-16T14:17:40  <wumpus> right, if the computation was not in the GUI thread, it'd be much less bad
234 2017-06-16T14:17:48  <wumpus> there would be some unnoticable lag
235 2017-06-16T14:17:52  <ryanofsky> if you get rid of the dirty flag and compute balance with each transactions that effectively would move computation to a background thread. still might lock up gui because of holding cs_main though
236 2017-06-16T14:17:54  <wumpus> instead of the thing hanging and complaining
237 2017-06-16T14:18:23  <wumpus> ryanofsky: but that'd be crazy, it'd make receiving transactions quadratic
238 2017-06-16T14:18:32  <wumpus> ryanofsky: if every transactions received causes a scan over the entire wallet
239 2017-06-16T14:18:39  <wumpus> ryanofsky: that's why the dirty flag exists
240 2017-06-16T14:19:07  <jonasschnelli> Balances should only be calculated if the user wants them
241 2017-06-16T14:19:10  <ryanofsky> yes, what i meant above by dirty flag makes sense for rpc but not gui
242 2017-06-16T14:19:18  *** regina909_ has joined #bitcoin-core-dev
243 2017-06-16T14:19:19  <jonasschnelli> In the GUI, thats a bit different
244 2017-06-16T14:19:29  <wumpus> ryanofsky: right now it makes sense for the GUI too, as it's only polled 4 times per second
245 2017-06-16T14:19:33  <wumpus> ryanofsky: so it's naturally rate limited
246 2017-06-16T14:19:56  <wumpus> ryanofsky: if you get 400 transactions per second, it still only computes 4 times per second
247 2017-06-16T14:19:56  *** regina909_ has left #bitcoin-core-dev
248 2017-06-16T14:19:58  <ryanofsky> for gui users who are creating more than 4 transactions per second i guess
249 2017-06-16T14:20:06  <jonasschnelli> Modern GUI frameworks often poll/call updates when the according element is visible
250 2017-06-16T14:20:12  <wumpus> or "receiving"
251 2017-06-16T14:20:15  <wumpus> this happens during initial sync
252 2017-06-16T14:20:18  <wumpus> if you have a full wallet
253 2017-06-16T14:20:19  *** pandabull has joined #bitcoin-core-dev
254 2017-06-16T14:20:35  <ryanofsky> oh, that's true. dirty flag makes sense there too
255 2017-06-16T14:20:57  <wumpus> people always ignore initial sync for some reason, while that is the most common source of hangs, after initial sync the GUI is pretty ok
256 2017-06-16T14:20:57  <ryanofsky> anyway to be clear i'm not suggesting getting rid of dirty flag
257 2017-06-16T14:21:24  <wumpus> (initial sync or: more often, catching up after not running the node for a few days)
258 2017-06-16T14:21:32  <ryanofsky> i'm just saying one way to move balance computation to "background thread" instead of gui thread is to compute it on tx notifications in cases where that makes sense
259 2017-06-16T14:22:09  <wumpus> sure
260 2017-06-16T14:31:20  *** BashCo has joined #bitcoin-core-dev
261 2017-06-16T14:32:15  *** BashCo has left #bitcoin-core-dev
262 2017-06-16T14:34:46  *** BashCo has joined #bitcoin-core-dev
263 2017-06-16T14:50:26  <cfields> jonasschnelli: the lock report is printed when threads destruct. So, mostly at shutdown
264 2017-06-16T14:50:37  *** Guyver2_ has joined #bitcoin-core-dev
265 2017-06-16T14:50:37  <jonasschnelli> ah.. okay.. then my fault
266 2017-06-16T14:50:51  <jonasschnelli> cfields: have you seen the crash on OSX in current master over gitian
267 2017-06-16T14:51:22  <jonasschnelli> It must be one of the last 10 commits
268 2017-06-16T14:51:40  <jonasschnelli> could it be: https://github.com/bitcoin/bitcoin/commit/cb24c8539d1098d1a61605b452ecfa11a693320d
269 2017-06-16T14:51:49  <cfields> jonasschnelli: no, i haven't rebased my osx work in maybe ~1week, though
270 2017-06-16T14:51:57  <cfields> I'll fire one up now
271 2017-06-16T14:52:16  <jonasschnelli> The crash only happens when build via gitian
272 2017-06-16T14:52:23  <jonasschnelli> local builds are fine...
273 2017-06-16T14:52:23  <cfields> jonasschnelli: could also be the crc32 thing
274 2017-06-16T14:52:33  <jonasschnelli> But nighly build from 15th works
275 2017-06-16T14:52:37  <cfields> interesting
276 2017-06-16T14:52:39  <jonasschnelli> Most be the last 10 commits
277 2017-06-16T14:52:45  <cfields> jonasschnelli: you have binaries handy?
278 2017-06-16T14:52:53  <jonasschnelli> yes...
279 2017-06-16T14:52:57  <jonasschnelli> see: https://github.com/bitcoin/bitcoin/issues/10611
280 2017-06-16T14:53:07  <jonasschnelli> use my builders build 176 vs 175
281 2017-06-16T14:53:23  <cfields> perfect, thanks
282 2017-06-16T14:53:33  *** Guyver2 has quit IRC
283 2017-06-16T14:53:40  *** Guyver2_ is now known as Guyver2
284 2017-06-16T14:53:58  <cfields> argh, i never added the osx debug symbols, did i?
285 2017-06-16T14:54:06  *** BashCo has quit IRC
286 2017-06-16T14:54:46  <jonasschnelli> I guess no...
287 2017-06-16T14:55:38  <cfields> :(
288 2017-06-16T14:55:42  * cfields adds it to the list
289 2017-06-16T14:57:45  *** BashCo has joined #bitcoin-core-dev
290 2017-06-16T14:59:58  *** pandabull has quit IRC
291 2017-06-16T15:00:06  *** Dyaheon has quit IRC
292 2017-06-16T15:00:36  *** pandabull has joined #bitcoin-core-dev
293 2017-06-16T15:01:42  *** Dyaheon has joined #bitcoin-core-dev
294 2017-06-16T15:02:19  *** svx has joined #bitcoin-core-dev
295 2017-06-16T15:02:35  *** svx has left #bitcoin-core-dev
296 2017-06-16T15:04:01  *** pandabul_ has joined #bitcoin-core-dev
297 2017-06-16T15:05:05  *** pandabull has quit IRC
298 2017-06-16T15:07:48  <cfields> jonasschnelli / sipa: https://0bin.net/paste/+O0wEWXmLDshuG97#oQTOyc4av4get3wvsrwRNwbKaTO7ODBrTotk5nbXcf3
299 2017-06-16T15:08:41  *** pandabul_ has quit IRC
300 2017-06-16T15:10:06  *** BashCo has quit IRC
301 2017-06-16T15:12:41  *** BashCo has joined #bitcoin-core-dev
302 2017-06-16T15:16:01  *** chjj has quit IRC
303 2017-06-16T15:16:17  *** pandabull has joined #bitcoin-core-dev
304 2017-06-16T15:21:49  *** BashCo has quit IRC
305 2017-06-16T15:25:36  *** BashCo has joined #bitcoin-core-dev
306 2017-06-16T15:26:11  *** laurentmt has joined #bitcoin-core-dev
307 2017-06-16T15:29:24  *** chjj has joined #bitcoin-core-dev
308 2017-06-16T15:39:44  *** BashCo has quit IRC
309 2017-06-16T15:51:21  *** ovovo has joined #bitcoin-core-dev
310 2017-06-16T15:51:43  *** RubenSomsen has joined #bitcoin-core-dev
311 2017-06-16T15:52:27  *** abpa has joined #bitcoin-core-dev
312 2017-06-16T15:54:36  *** owowo has quit IRC
313 2017-06-16T15:54:56  *** BashCo has joined #bitcoin-core-dev
314 2017-06-16T16:02:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #10612: The young person's guide to the test_framework (master...templatefunctionaltest) https://github.com/bitcoin/bitcoin/pull/10612
315 2017-06-16T16:04:43  <Victorsueca> anybody else having issues when cross-compiling 0.14.2 for windows in ubuntu 14?
316 2017-06-16T16:06:06  <Victorsueca> I'm getting this thing on a machine that used to compile properly until now https://0bin.net/paste/q13F+WfsGqY4fkcW#4UXO33FPpzPvu7zb-Omj6zz8tHPGiAOH18/E5ti0xNO
317 2017-06-16T16:06:08  <gribble> https://github.com/bitcoin/bitcoin/issues/4 | Export/Import wallet in a human readable, future-proof format · Issue #4 · bitcoin/bitcoin · GitHub
318 2017-06-16T16:07:17  <sipa> Victorsueca: "issues" is pretty vague
319 2017-06-16T16:07:42  <Victorsueca> sipa: yeah, more specifically with miniupnpc apparently
320 2017-06-16T16:07:46  <Victorsueca> see the 0bin
321 2017-06-16T16:07:55  <sipa> oh, sorry i missed the link
322 2017-06-16T16:17:55  *** Guyver2 has quit IRC
323 2017-06-16T16:21:35  *** chjj has quit IRC
324 2017-06-16T16:30:34  *** spudowiar has joined #bitcoin-core-dev
325 2017-06-16T16:30:38  <spudowiar> o/ jnewbery
326 2017-06-16T16:35:24  *** chjj has joined #bitcoin-core-dev
327 2017-06-16T16:48:18  *** jnewbery has quit IRC
328 2017-06-16T16:48:31  *** jnewbery has joined #bitcoin-core-dev
329 2017-06-16T16:52:48  *** Giszmo has joined #bitcoin-core-dev
330 2017-06-16T17:02:09  *** cysm has quit IRC
331 2017-06-16T17:02:34  <cfields> jonasschnelli: ok, i think i have the crash worked out. I've taken the opportunity to learn more about asm
332 2017-06-16T17:02:47  *** _flow_ has quit IRC
333 2017-06-16T17:05:57  *** _flow_ has joined #bitcoin-core-dev
334 2017-06-16T17:06:17  *** cysm has joined #bitcoin-core-dev
335 2017-06-16T17:08:50  *** Evel-Knievel has quit IRC
336 2017-06-16T17:09:35  <sipa> cfields: my condolences
337 2017-06-16T17:10:11  <cfields> sipa: heh. my mistake for not diving in decades ago
338 2017-06-16T17:15:08  <cfields> sipa: clang is nice enough to use ebx for its stack canary, which cpuid clobbers. I'm trying to understand the PIC/ebx interaction fully before PRing something
339 2017-06-16T17:16:14  <cfields> (context: rdrand detection)
340 2017-06-16T17:16:52  <sipa> cfields: huh?
341 2017-06-16T17:16:57  <sipa> my PR avoids clobbering ebx...
342 2017-06-16T17:17:15  <cfields> more context: #10611
343 2017-06-16T17:17:16  <gribble> https://github.com/bitcoin/bitcoin/issues/10611 | Gitian build (current master) crashes on OSX · Issue #10611 · bitcoin/bitcoin · GitHub
344 2017-06-16T17:17:39  <cfields> sipa: my understanding is that the instruction still clobbers it, the compiler just isn't aware of that
345 2017-06-16T17:17:48  <sipa> it does not clobber it
346 2017-06-16T17:18:01  <sipa> the cpuid instruction clobbers it, but the whole asm block does not
347 2017-06-16T17:18:10  <sipa> it moves the old value to a temp register first, and restores it
348 2017-06-16T17:19:21  <cfields> grr, i was looking at my hacked up local source. I see that now, thanks.
349 2017-06-16T17:19:45  <sipa> can you show me objdump -dC libbitcoin_util_a-random.o ?
350 2017-06-16T17:20:24  <cfields> yea, sec, let me revert
351 2017-06-16T17:20:50  <cfields> please don't tell the problem/solution though, I'd like to work it out
352 2017-06-16T17:21:42  <sipa> i don't expect to learn anything interesting - just want to see if the clang compiler isn't doing something unexpected
353 2017-06-16T17:22:42  <cfields> https://pastebin.com/raw/tS1TUPe0
354 2017-06-16T17:24:54  <sipa> oooh!
355 2017-06-16T17:25:00  * sipa sees it
356 2017-06-16T17:26:14  <cfields> just tell me how deep i'm going to have to dive? :)
357 2017-06-16T17:27:53  <sipa> hint: we'll need different asm code for 32bit and 64bit
358 2017-06-16T17:28:43  *** chjj has quit IRC
359 2017-06-16T17:28:55  *** pandabull has quit IRC
360 2017-06-16T17:29:25  *** pandabull has joined #bitcoin-core-dev
361 2017-06-16T17:33:12  <cfields> full canary address doesn't get restored via mov?
362 2017-06-16T17:34:44  <sipa> indeed
363 2017-06-16T17:35:09  <sipa> see why?
364 2017-06-16T17:36:32  <cfields> vaguely. I'm so green I'm having trouble distinguishing values from addresses. Investigating.
365 2017-06-16T17:38:48  *** griswaalt has joined #bitcoin-core-dev
366 2017-06-16T17:39:39  <wumpus> oh, so the compiler isn't being told correctly what registers are being clobbered?
367 2017-06-16T17:40:10  <sipa> wumpus: if you tell the compiler yoi clobber ebx, it will complain saying that it needs ebx for PIC
368 2017-06-16T17:40:15  <sipa> and fail to compile
369 2017-06-16T17:40:29  <sipa> so the code there manually saves and restores ebx
370 2017-06-16T17:41:01  <sipa> i believe that is fixed in a later gcc
371 2017-06-16T17:41:07  <cfields> gcc5
372 2017-06-16T17:41:27  <cfields> i suppose it needs to be movq/rbx for 64bit instead?
373 2017-06-16T17:41:32  <sipa> indeed
374 2017-06-16T17:41:34  <wumpus> that seems kind of stupid, now you need to write the code in mind with the knowledge what every compiler might use for special things
375 2017-06-16T17:41:42  <sipa> wumpus: indeed :(
376 2017-06-16T17:41:56  <sipa> cfields: tmp needs to be a 64-bit int on 64-bit systems
377 2017-06-16T17:42:23  <cfields> sipa: i've seen lots of rantings about gcc's x86 pic handling in the past, i'm beginning to understand the hatred now
378 2017-06-16T17:42:32  <wumpus> (I suspect the cookie in ebx is not part of any official ABI convention, at least)
379 2017-06-16T17:43:00  *** chjj has joined #bitcoin-core-dev
380 2017-06-16T17:43:59  <cfields> well if you list ebx as a clobber, it sticks the cookie somewhere else. So my "fix" was totally accidental and wrong (and would ofc break on x86 pic).
381 2017-06-16T17:44:17  <sipa> cfields: oh you're able to list ebx as a clobber?
382 2017-06-16T17:44:20  <sipa> and it compiles?
383 2017-06-16T17:44:26  <wumpus> in its defense, handling PIC on x86 32 bit is a nightmare
384 2017-06-16T17:44:39  <sipa> in that case, we should probably do that on x86_64
385 2017-06-16T17:44:50  <wumpus> modern architectures, and even less modern ones, have been designed with PIC in mind, but x86 never was
386 2017-06-16T17:45:32  <cfields> sipa: yea
387 2017-06-16T17:46:05  <sipa> you want to write a pr?
388 2017-06-16T17:47:26  <cfields> sipa: sure, will be a while though. Still reading/experimenting/learning
389 2017-06-16T17:48:06  *** Giszmo has quit IRC
390 2017-06-16T17:50:40  <sipa> cfields: the issue is that the 32-bit ebx register and the 64-bit rbx register occupy the same space
391 2017-06-16T17:50:47  *** timothy has quit IRC
392 2017-06-16T17:51:01  <sipa> ebx is just a "view" of the lower 32 bits of rbx
393 2017-06-16T17:52:18  <cfields> that makes sense
394 2017-06-16T17:52:57  <sipa> and the "b" constraint can either mean ebx or rbx, depending on the size of the variable
395 2017-06-16T17:53:26  <sipa> there are 8-bit and 16-bit views too
396 2017-06-16T17:55:20  <cfields> so the compiler adapts the mov to the register size?
397 2017-06-16T17:55:27  <sipa> yup
398 2017-06-16T17:55:33  <sipa> the assembler, rather
399 2017-06-16T17:55:49  <cfields> ok, got it
400 2017-06-16T17:55:55  <cfields> thanks for the 101 :)
401 2017-06-16T17:56:28  *** Gnof has joined #bitcoin-core-dev
402 2017-06-16T18:07:31  <cfields> sipa: https://pastebin.com/raw/68f8cKHd ?
403 2017-06-16T18:13:59  <cfields> mm, apparently that's broken since cpuid overwrites eax
404 2017-06-16T18:15:48  <sipa> you can list eax as an input/outpit register
405 2017-06-16T18:16:01  <sipa> but i think just listing all 4 as outputs is easier
406 2017-06-16T18:16:28  <cfields> right, so:https://pastebin.com/BhBAHeFK
407 2017-06-16T18:16:31  <cfields> ok
408 2017-06-16T18:16:45  <cfields> will just do that. PRing. thanks again.
409 2017-06-16T18:29:27  *** SopaXorzTaker has quit IRC
410 2017-06-16T18:34:12  <Victorsueca> sipa: had to go for a while, any news on my issue? need extra debug info?
411 2017-06-16T18:37:59  <sipa> Victorsueca: i have no clue
412 2017-06-16T18:39:49  <achow101> Victorsueca: are you using WSL?
413 2017-06-16T18:40:20  <Victorsueca> achow101: yes, it has been working until now
414 2017-06-16T18:40:32  *** laurentmt has quit IRC
415 2017-06-16T18:40:46  <achow101> IIRC it wasn't working for the past few months
416 2017-06-16T18:40:54  <achow101> (at least not on my machines)
417 2017-06-16T18:40:58  <ProfMac> I successfully did a gitian build on 0.14.1.  It took days to grok the web pages, and about 7 hours to execute.  I have placed some shell scripts at https://github.com/a-mcintosh/gitian-bitcoin-shell-scripts and these scripts capture the workflow mentioned at https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#create-a-new-virtualbox-vm
418 2017-06-16T18:41:56  *** Evel-Knievel has joined #bitcoin-core-dev
419 2017-06-16T18:41:59  <jonasschnelli> 7h?!
420 2017-06-16T18:42:06  <jonasschnelli> DId you pass in -j2 or -j4?
421 2017-06-16T18:43:02  <Victorsueca> the last version i've built succefully on my WSL was 0.14.1, now I'm on the same machine and it won't do the depends for 0.14.2
422 2017-06-16T18:43:10  <achow101> Victorsueca: try https://github.com/bitcoin/bitcoin/issues/10269#issuecomment-307293086
423 2017-06-16T18:43:14  <ProfMac> lol.  At this point I'm so fatigued, I don't even know my own name.  It does seem pretty slow.  Have a look at the scripts and see if you spot any trouble.
424 2017-06-16T18:43:15  *** SopaXorzTaker has joined #bitcoin-core-dev
425 2017-06-16T18:43:33  <sipa> ProfMac: machine without hardware virtualization?
426 2017-06-16T18:44:41  *** pandabul_ has joined #bitcoin-core-dev
427 2017-06-16T18:44:57  <achow101> ProfMac: perhaps try using kvm instead of lxc? it will need to run on hardware and not in a vm though
428 2017-06-16T18:46:22  <Victorsueca> achow101: that seems to work \o/
429 2017-06-16T18:46:26  <Victorsueca> thanks
430 2017-06-16T18:46:28  <ProfMac> Probably just not configured correctly.  One of the scripts creates the virtualbox, so that can be corrected.  5.7 GiB RAM, Intel Core 2 Duo CPU E8400 @ 3.00 GHz x 2 Ubuntu 14.04 LTS 2.0 TB online.
431 2017-06-16T18:47:20  <ProfMac> what kind of build times to others have?  My impression was that it build the entire Trusty system from source during the process.
432 2017-06-16T18:47:40  *** pandabull has quit IRC
433 2017-06-16T18:48:27  <ProfMac> I don't know how to peek inside gitian-builder/target-trusty-amd64
434 2017-06-16T18:50:12  <jonasschnelli> ProfMac: my build times are at bitcoin.jonasschnelli.ch
435 2017-06-16T18:51:13  <ProfMac> Could I just make a new Trusty VM and do the build there?  If I restore a "bare" snapshot before each build, what do I give up?
436 2017-06-16T18:53:16  *** RubenSomsen has quit IRC
437 2017-06-16T18:54:08  <ProfMac> jonasschnelli, thanks, but I get a 403 forbidden when I drop that into an address bar.
438 2017-06-16T18:54:32  <jonasschnelli> https://bitcoin.jonasschnelli.ch
439 2017-06-16T18:54:40  <jonasschnelli> Oh.. the SSL forwarder seems broken
440 2017-06-16T18:55:35  <ProfMac> I'm at the page.  Nice homage to Matrix, unless like me you still see pink after a night at the CRT.
441 2017-06-16T18:56:00  *** Giszmo has joined #bitcoin-core-dev
442 2017-06-16T18:59:11  <ProfMac> Oh my.  21 minutes vs 7 hours.  LOL.
443 2017-06-16T18:59:46  *** frabrunelle has quit IRC
444 2017-06-16T18:59:56  *** draadpiraat[m] has quit IRC
445 2017-06-16T18:59:56  *** herzmeister[m] has quit IRC
446 2017-06-16T18:59:59  *** kewde[m] has quit IRC
447 2017-06-16T19:02:02  <bitcoin-git> [bitcoin] theuni opened pull request #10614: random: fix crash on some 64bit platforms (master...fix-osx-crash) https://github.com/bitcoin/bitcoin/pull/10614
448 2017-06-16T19:02:21  <cfields> jonasschnelli: ^^
449 2017-06-16T19:09:06  *** chjj has quit IRC
450 2017-06-16T19:09:07  <sipa> cfields: also, for reusable code (if we want to use hw sha instruction or something, you can use "xchg %1, %%ebx" instead of mov, and get the real ebx out
451 2017-06-16T19:09:36  <cfields> sipa: heh, i meant to ask about that. that's what gcc does internally
452 2017-06-16T19:09:54  <sipa> not suggesting to do that here, but it's hardly harder to write a generic "cpuid number -> give me a tuple of 4 uint32_t" function
453 2017-06-16T19:13:25  <cfields> sipa: you mean just drop the special case and always stash b?
454 2017-06-16T19:13:54  <sipa> cfields: i think your PR is fine
455 2017-06-16T19:14:12  <sipa> but maybe later if we ever have multiple things to query cpuid for
456 2017-06-16T19:14:25  <cfields> sipa: well i'm pretty sure I whined about it not being generic in your original PR :p
457 2017-06-16T19:15:19  <jonasschnelli> cfields: nice. Just started a build: https://bitcoin.jonasschnelli.ch/build/181
458 2017-06-16T19:15:37  <cfields> sipa: heh, yea: https://github.com/bitcoin/bitcoin/pull/10377#pullrequestreview-37172453
459 2017-06-16T19:21:41  *** ovovo is now known as owowo
460 2017-06-16T19:23:10  *** chjj has joined #bitcoin-core-dev
461 2017-06-16T19:28:52  *** Giszmo has quit IRC
462 2017-06-16T19:29:20  *** owowo has quit IRC
463 2017-06-16T19:33:58  *** SopaXorzTaker has quit IRC
464 2017-06-16T19:34:12  *** owowo has joined #bitcoin-core-dev
465 2017-06-16T19:35:44  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c2ab38bdd57a...7a74f88a26cf
466 2017-06-16T19:35:45  <bitcoin-git> bitcoin/master cc0ed26 Pavel Janík: Supress struct/class mismatch warnings introduced in #10284.
467 2017-06-16T19:35:45  <bitcoin-git> bitcoin/master 7a74f88 Pieter Wuille: Merge #10598: Supress struct/class mismatch warnings introduced in #10284...
468 2017-06-16T19:36:06  *** Dyaheon has quit IRC
469 2017-06-16T19:36:24  <bitcoin-git> [bitcoin] sipa closed pull request #10598: Supress struct/class mismatch warnings introduced in #10284 (master...20170615_FeeCalculation_structclass) https://github.com/bitcoin/bitcoin/pull/10598
470 2017-06-16T19:37:29  *** Dyaheon has joined #bitcoin-core-dev
471 2017-06-16T19:47:59  *** hihi has joined #bitcoin-core-dev
472 2017-06-16T19:50:59  <sipa> cfields: we're using gcc 4.8 for win and linux builds, which i think has a sufficiently mature LTO implementation; any opinion on using it in release builds?
473 2017-06-16T19:51:15  <sipa> i don't know the status of LTO in clang
474 2017-06-16T19:51:28  *** owowo has quit IRC
475 2017-06-16T19:52:16  <cfields> sipa: my main concern is that we could see a discrepancy between release binaries and what devs run
476 2017-06-16T19:52:40  <sipa> cfields: why?
477 2017-06-16T19:52:41  <cfields> as even with gcc7, linking still takes a long time. I don't think we could enable it by default, it'd have to be in gitian
478 2017-06-16T19:53:07  <sipa> it does take less memory too
479 2017-06-16T19:53:34  *** laurentmt has joined #bitcoin-core-dev
480 2017-06-16T19:53:36  <sipa> maybe a generic "optimized build" available from configure and one that isn't, and gitian uses optimized
481 2017-06-16T19:53:42  *** laurentmt has quit IRC
482 2017-06-16T19:53:45  <cfields> (not opposed, just considering the downsides)
483 2017-06-16T19:53:58  <sipa> it's a good point to bring up
484 2017-06-16T19:54:22  <sipa> i like that it categorically removes the concern about whether code needs to go in a header or not :)
485 2017-06-16T19:54:23  <cfields> sipa: yea, that sounds reasonable
486 2017-06-16T19:54:31  <cfields> heh
487 2017-06-16T19:54:58  *** RubenSomsen has joined #bitcoin-core-dev
488 2017-06-16T19:55:12  <cfields> speaking of which, i worked on pre-compiled headers a few days ago. Shaved roughly ~30% off of build time
489 2017-06-16T19:55:48  <cfields> sipa: another one of the big benefits is that our deps can be lto'd as well. I suspect static lto'd qt would be a big win for filesize
490 2017-06-16T19:55:55  <cfields> but again, that makes linking take forever
491 2017-06-16T19:56:44  *** owowo has joined #bitcoin-core-dev
492 2017-06-16T19:57:19  * cfields kicks off an lto'd qt build out of curiosity
493 2017-06-16T19:59:36  <TD-Linux> cfields, https://git.xiph.org/?p=opus.git;a=blob;f=celt/x86/x86cpu.c;h=080eb25e413d9e6587a419933d85ea9a6243b46e;hb=HEAD#l61
494 2017-06-16T20:00:41  <jonasschnelli> TD-Linux: hah. Always research first how other did it. ;)
495 2017-06-16T20:02:10  <jonasschnelli> *others
496 2017-06-16T20:02:33  *** spudowiar has quit IRC
497 2017-06-16T20:03:13  <cfields> heh, yep
498 2017-06-16T20:05:14  *** RubenSomsen has quit IRC
499 2017-06-16T20:09:13  <luke-jr> has anyone benchmarked LTO vs normal?
500 2017-06-16T20:14:41  *** pandabul_ has quit IRC
501 2017-06-16T20:21:42  *** Gnof has quit IRC
502 2017-06-16T20:22:04  *** pandabull has joined #bitcoin-core-dev
503 2017-06-16T20:22:16  *** dermoth has quit IRC
504 2017-06-16T20:23:07  *** pandabull has quit IRC
505 2017-06-16T20:23:44  *** pandabull has joined #bitcoin-core-dev
506 2017-06-16T20:24:32  <luke-jr> jonasschnelli: please add sources for companies you add to https://en.bitcoin.it/wiki/Segwit_support
507 2017-06-16T20:29:26  *** arubi has quit IRC
508 2017-06-16T20:29:32  *** dermoth has joined #bitcoin-core-dev
509 2017-06-16T20:30:22  *** arubi has joined #bitcoin-core-dev
510 2017-06-16T20:45:01  *** RubenSomsen has joined #bitcoin-core-dev
511 2017-06-16T20:49:08  *** dermoth has quit IRC
512 2017-06-16T20:53:04  <bitcoin-git> [bitcoin] luke-jr opened pull request #10615: RPC: Allow rpcauth configs to specify a 4th parameter naming a specific wallet (master...multiwallet_rpc) https://github.com/bitcoin/bitcoin/pull/10615
513 2017-06-16T21:18:40  *** chjj has quit IRC
514 2017-06-16T21:27:50  *** laurentmt has joined #bitcoin-core-dev
515 2017-06-16T21:28:12  *** laurentmt has quit IRC
516 2017-06-16T21:29:07  *** pandabull has quit IRC
517 2017-06-16T21:30:06  *** halo has joined #bitcoin-core-dev
518 2017-06-16T21:30:22  *** herzmeister[m] has joined #bitcoin-core-dev
519 2017-06-16T21:31:15  *** chjj has joined #bitcoin-core-dev
520 2017-06-16T21:34:08  *** kewde[m] has joined #bitcoin-core-dev
521 2017-06-16T21:34:09  *** frabrunelle has joined #bitcoin-core-dev
522 2017-06-16T21:34:15  *** draadpiraat[m] has joined #bitcoin-core-dev
523 2017-06-16T21:35:53  *** halo has quit IRC
524 2017-06-16T21:41:42  *** Dyaheon has quit IRC
525 2017-06-16T21:42:37  *** Dyaheon has joined #bitcoin-core-dev
526 2017-06-16T21:50:08  *** RubenSomsen has quit IRC
527 2017-06-16T21:53:57  *** RubenSomsen has joined #bitcoin-core-dev
528 2017-06-16T22:03:33  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7a74f88a26cf...d76e84a21416
529 2017-06-16T22:03:34  <bitcoin-git> bitcoin/master 131a8ce practicalswift: Make clang-format use C++11 features (e.g. A<A<int>> instead of A<A<int> >)
530 2017-06-16T22:03:34  <bitcoin-git> bitcoin/master d76e84a Pieter Wuille: Merge #10602: Make clang-format use C++11 features (e.g. A<A<int>> instead of A<A<int> >)...
531 2017-06-16T22:04:12  <bitcoin-git> [bitcoin] sipa closed pull request #10602: Make clang-format use C++11 features (e.g. A<A<int>> instead of A<A<int> >) (master...clang-format-cpp11) https://github.com/bitcoin/bitcoin/pull/10602
532 2017-06-16T22:08:30  *** shesek has quit IRC
533 2017-06-16T22:16:25  *** Aaronvan_ has joined #bitcoin-core-dev
534 2017-06-16T22:17:48  *** AaronvanW has quit IRC
535 2017-06-16T22:21:07  *** Giszmo has joined #bitcoin-core-dev
536 2017-06-16T22:24:44  *** chjj has quit IRC
537 2017-06-16T22:33:46  *** griswaalt has quit IRC
538 2017-06-16T22:34:20  *** griswaalt has joined #bitcoin-core-dev
539 2017-06-16T22:38:50  *** chjj has joined #bitcoin-core-dev
540 2017-06-16T22:42:58  <midnightmagic> eek why is there only two of us signing the windows signed executables :-P
541 2017-06-16T22:45:20  *** goatpig has quit IRC
542 2017-06-16T23:04:47  <cfields> sipa: I'm confused about https://github.com/bitcoin-core/leveldb/commit/196962ff01c39b4705d8117df5c3f8c205349950
543 2017-06-16T23:05:06  <cfields> how does that manage to link? there's no definition that returns zero
544 2017-06-16T23:05:22  <sipa> cfields: the implementation is in posix_sse.c
545 2017-06-16T23:05:30  <sipa> which apparently gets linked in
546 2017-06-16T23:06:07  <cfields> sipa: ah, that's our problem then. leveldb's build doesn't link that in
547 2017-06-16T23:06:16  <cfields> ...but that would mean windows is broken upstream
548 2017-06-16T23:06:24  <sipa> windows does not _exist_ upstream
549 2017-06-16T23:06:33  <cfields> oooooh :)
550 2017-06-16T23:07:02  <cfields> hehe, got it. will fix.
551 2017-06-16T23:08:28  <cfields> i see. so we patched up their build discovery stuff at one point, but stopped when we migrated it into our build
552 2017-06-16T23:08:47  <sipa> right, and we don't run the tests for the windows build
553 2017-06-16T23:09:58  <cfields> got it, thanks
554 2017-06-16T23:18:48  *** sanada` has joined #bitcoin-core-dev
555 2017-06-16T23:19:36  *** griswaal_ has joined #bitcoin-core-dev
556 2017-06-16T23:21:12  *** ananteri1 has joined #bitcoin-core-dev
557 2017-06-16T23:22:09  *** sdaftuar_ has joined #bitcoin-core-dev
558 2017-06-16T23:22:12  *** PaulCapestany has quit IRC
559 2017-06-16T23:24:44  *** ryanofsky_ has joined #bitcoin-core-dev
560 2017-06-16T23:25:04  *** phantomcircuit_ has joined #bitcoin-core-dev
561 2017-06-16T23:26:05  *** chjj has quit IRC
562 2017-06-16T23:26:13  *** griswaalt has quit IRC
563 2017-06-16T23:26:13  *** sanada has quit IRC
564 2017-06-16T23:26:14  *** Soligor has quit IRC
565 2017-06-16T23:26:14  *** [b__b] has quit IRC
566 2017-06-16T23:26:14  *** phantomcircuit has quit IRC
567 2017-06-16T23:26:14  *** ananteris has quit IRC
568 2017-06-16T23:26:14  *** ryanofsky has quit IRC
569 2017-06-16T23:26:14  *** AdrianG has quit IRC
570 2017-06-16T23:26:14  *** sdaftuar has quit IRC
571 2017-06-16T23:26:14  *** morcos has quit IRC
572 2017-06-16T23:26:21  *** ananteri1 is now known as ananteris
573 2017-06-16T23:26:24  *** [b__b] has joined #bitcoin-core-dev
574 2017-06-16T23:26:25  *** ananteris has quit IRC
575 2017-06-16T23:26:26  *** ananteris has joined #bitcoin-core-dev
576 2017-06-16T23:27:28  *** Dyaheon has quit IRC
577 2017-06-16T23:27:28  *** Soligor has joined #bitcoin-core-dev
578 2017-06-16T23:30:45  *** Dyaheon has joined #bitcoin-core-dev
579 2017-06-16T23:31:03  *** AdrianG has joined #bitcoin-core-dev
580 2017-06-16T23:35:40  *** morcos has joined #bitcoin-core-dev
581 2017-06-16T23:36:42  *** griswaal_ has quit IRC
582 2017-06-16T23:37:08  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d76e84a21416...de8db47b7ff3
583 2017-06-16T23:37:08  <bitcoin-git> bitcoin/master f2fb132 practicalswift: Net: Fix resource leak in ReadBinaryFile(...)...
584 2017-06-16T23:37:09  *** griswaalt has joined #bitcoin-core-dev
585 2017-06-16T23:37:09  <bitcoin-git> bitcoin/master de8db47 Pieter Wuille: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...)...
586 2017-06-16T23:37:35  <bitcoin-git> [bitcoin] sipa closed pull request #10587: Net: Fix resource leak in ReadBinaryFile(...) (master...fopen-not-followed-by-fclose-in-all-states-of-the-universe) https://github.com/bitcoin/bitcoin/pull/10587
587 2017-06-16T23:38:42  *** abpa has quit IRC
588 2017-06-16T23:40:17  *** chjj has joined #bitcoin-core-dev