1 2017-06-17T00:24:51 <bitcoin-git> [bitcoin] gmaxwell opened pull request #10618: Remove confusing MAX_BLOCK_BASE_SIZE. (master...size_b_gone) https://github.com/bitcoin/bitcoin/pull/10618 2 2017-06-17T00:26:18 *** Aaronvan_ has quit IRC 3 2017-06-17T00:34:06 *** chjj has quit IRC 4 2017-06-17T00:38:17 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de8db47b7ff3...cafe24f039e1 5 2017-06-17T00:38:17 <bitcoin-git> bitcoin/master 9af207c Cory Fields: random: fix crash on some 64bit platforms... 6 2017-06-17T00:38:18 <bitcoin-git> bitcoin/master cafe24f Pieter Wuille: Merge #10614: random: fix crash on some 64bit platforms... 7 2017-06-17T00:38:47 <bitcoin-git> [bitcoin] sipa closed pull request #10614: random: fix crash on some 64bit platforms (master...fix-osx-crash) https://github.com/bitcoin/bitcoin/pull/10614 8 2017-06-17T00:48:17 *** chjj has joined #bitcoin-core-dev 9 2017-06-17T01:20:36 *** chjj has quit IRC 10 2017-06-17T01:34:04 *** chjj has joined #bitcoin-core-dev 11 2017-06-17T01:39:22 *** chjj has quit IRC 12 2017-06-17T01:43:59 *** elkalamar has joined #bitcoin-core-dev 13 2017-06-17T01:46:26 *** unholymachine has quit IRC 14 2017-06-17T01:53:00 *** chjj has joined #bitcoin-core-dev 15 2017-06-17T01:54:40 *** BashCo has quit IRC 16 2017-06-17T02:21:38 *** Ylbam has quit IRC 17 2017-06-17T02:25:29 *** Chris_Stewart_5 has quit IRC 18 2017-06-17T02:27:10 *** AaronvanW has joined #bitcoin-core-dev 19 2017-06-17T02:32:10 *** AaronvanW has quit IRC 20 2017-06-17T02:37:41 *** RubenSomsen has quit IRC 21 2017-06-17T02:44:39 *** chjj has quit IRC 22 2017-06-17T02:58:17 *** chjj has joined #bitcoin-core-dev 23 2017-06-17T03:06:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev 24 2017-06-17T03:19:24 *** elkalamar has quit IRC 25 2017-06-17T03:26:01 *** d9b4bef9 has quit IRC 26 2017-06-17T03:27:07 *** d9b4bef9 has joined #bitcoin-core-dev 27 2017-06-17T03:28:08 *** Dyaheon has quit IRC 28 2017-06-17T03:30:33 *** Dyaheon has joined #bitcoin-core-dev 29 2017-06-17T03:50:35 *** chjj has quit IRC 30 2017-06-17T03:57:51 *** goatpig has joined #bitcoin-core-dev 31 2017-06-17T04:04:15 *** chjj has joined #bitcoin-core-dev 32 2017-06-17T04:18:33 *** MarcoFalke has quit IRC 33 2017-06-17T04:19:23 *** MarcoFalke has joined #bitcoin-core-dev 34 2017-06-17T04:45:33 *** Giszmo has quit IRC 35 2017-06-17T04:48:08 *** Chris_Stewart_5 has quit IRC 36 2017-06-17T05:34:57 *** Dyaheon has quit IRC 37 2017-06-17T05:35:13 *** Dyaheon has joined #bitcoin-core-dev 38 2017-06-17T06:00:27 *** chjj has quit IRC 39 2017-06-17T06:14:15 *** chjj has joined #bitcoin-core-dev 40 2017-06-17T06:25:12 *** afk11 has quit IRC 41 2017-06-17T06:26:07 *** afk11 has joined #bitcoin-core-dev 42 2017-06-17T06:26:40 *** AaronvanW has joined #bitcoin-core-dev 43 2017-06-17T06:30:57 *** AaronvanW has quit IRC 44 2017-06-17T06:58:46 *** paveljanik has joined #bitcoin-core-dev 45 2017-06-17T06:58:47 *** paveljanik has joined #bitcoin-core-dev 46 2017-06-17T07:00:43 *** shesek has joined #bitcoin-core-dev 47 2017-06-17T07:14:31 *** arthcp has joined #bitcoin-core-dev 48 2017-06-17T07:15:45 <jonasschnelli> luke-jr: the source for DigitalBitbox is my wiki diff. 49 2017-06-17T07:16:02 <jonasschnelli> :-) 50 2017-06-17T07:21:15 <luke-jr> jonasschnelli: I noticed another company did a simple PGP signed message on a pastebin ;) 51 2017-06-17T08:02:08 *** SopaXorzTaker has joined #bitcoin-core-dev 52 2017-06-17T08:04:22 <jonasschnelli> luke-jr: good idea. Though my bitcoin.it account looks authentic and it's public available that I am a co-founder of DigitalBitbox... though a tweet or pgp signed pastebin is a good idea.. will do 53 2017-06-17T08:09:21 <luke-jr> jonasschnelli: yes, but having to inspect history is a pain 54 2017-06-17T08:09:44 <jonasschnelli> Yeah 55 2017-06-17T08:11:08 *** AaronvanW has joined #bitcoin-core-dev 56 2017-06-17T08:11:31 *** Ylbam has joined #bitcoin-core-dev 57 2017-06-17T09:11:21 *** arthcp has quit IRC 58 2017-06-17T09:14:56 *** goofie_ has joined #bitcoin-core-dev 59 2017-06-17T09:19:39 *** arthcp has joined #bitcoin-core-dev 60 2017-06-17T09:58:30 *** arthcp has quit IRC 61 2017-06-17T10:15:45 *** Guyver2 has joined #bitcoin-core-dev 62 2017-06-17T10:19:27 *** chjj has quit IRC 63 2017-06-17T10:21:28 *** laurentmt has joined #bitcoin-core-dev 64 2017-06-17T10:22:15 *** laurentmt has quit IRC 65 2017-06-17T10:33:36 *** chjj has joined #bitcoin-core-dev 66 2017-06-17T10:44:58 *** unholymachine has joined #bitcoin-core-dev 67 2017-06-17T11:01:01 *** d9b4bef9 has quit IRC 68 2017-06-17T11:02:08 *** d9b4bef9 has joined #bitcoin-core-dev 69 2017-06-17T11:03:02 *** d9b4bef9 has quit IRC 70 2017-06-17T11:04:07 *** d9b4bef9 has joined #bitcoin-core-dev 71 2017-06-17T11:23:30 *** chjj has quit IRC 72 2017-06-17T11:28:22 <bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10619: Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (master...fix01) https://github.com/bitcoin/bitcoin/pull/10619 73 2017-06-17T11:37:32 *** chjj has joined #bitcoin-core-dev 74 2017-06-17T11:43:49 *** AaronvanW has quit IRC 75 2017-06-17T11:44:28 *** AaronvanW has joined #bitcoin-core-dev 76 2017-06-17T11:48:52 *** AaronvanW has quit IRC 77 2017-06-17T12:29:35 *** chjj has quit IRC 78 2017-06-17T12:42:48 *** chjj has joined #bitcoin-core-dev 79 2017-06-17T12:45:01 *** AaronvanW has joined #bitcoin-core-dev 80 2017-06-17T12:50:43 *** AaronvanW has quit IRC 81 2017-06-17T13:30:00 *** sbp has left #bitcoin-core-dev 82 2017-06-17T13:56:05 *** laurentmt has joined #bitcoin-core-dev 83 2017-06-17T14:09:50 *** Chris_Stewart_5 has joined #bitcoin-core-dev 84 2017-06-17T14:22:33 *** Guyver2 has quit IRC 85 2017-06-17T14:34:36 *** laurentmt has quit IRC 86 2017-06-17T15:03:01 *** d9b4bef9 has quit IRC 87 2017-06-17T15:04:07 *** d9b4bef9 has joined #bitcoin-core-dev 88 2017-06-17T15:16:20 *** owowo has quit IRC 89 2017-06-17T15:21:36 *** owowo has joined #bitcoin-core-dev 90 2017-06-17T15:35:08 *** helo has quit IRC 91 2017-06-17T15:37:09 *** helo has joined #bitcoin-core-dev 92 2017-06-17T16:00:50 <instagibbs> what is vchDefaultKey for? 93 2017-06-17T16:02:24 <instagibbs> checking if the wallet is fFirstRun only? 94 2017-06-17T16:06:25 <sipa> it used to mean much more 95 2017-06-17T16:06:33 <sipa> but now i guess that's pretty much it 96 2017-06-17T16:06:54 <instagibbs> we're burning m/0'/0'/0', which makes naive importing of hd wallets impossible if the first address is used 97 2017-06-17T16:07:08 <instagibbs> work around is obviously to manually import first address 98 2017-06-17T16:07:18 <instagibbs> (looking at #9728) 99 2017-06-17T16:07:21 <gribble> https://github.com/bitcoin/bitcoin/issues/9728 | Can create Watch Only HD wallet with -hdwatchonly by NicolasDorier Â· Pull Request #9728 Â· bitcoin/bitcoin Â· GitHub 100 2017-06-17T16:08:17 <instagibbs> Can we just fill it with some valid constant key instead, for backwards compatibility? 101 2017-06-17T16:17:58 *** SopaXorzTaker has quit IRC 102 2017-06-17T16:19:43 <instagibbs> oh I'm mistaken, it's silently used and added to the wallet. I think that's slightly surprising. 103 2017-06-17T16:22:07 *** SopaXorzTaker has joined #bitcoin-core-dev 104 2017-06-17T16:26:57 *** Dyaheon has quit IRC 105 2017-06-17T16:28:03 *** Dyaheon has joined #bitcoin-core-dev 106 2017-06-17T16:45:13 <jonasschnelli> instagibbs: getting rid of vchDefaultKey would be good... though its currently used to find out if its the wallet first run... 107 2017-06-17T16:45:37 <instagibbs> jonasschnelli, right, but any valid pubkey works 108 2017-06-17T16:45:47 *** Chris_Stewart_5 has quit IRC 109 2017-06-17T16:45:59 <instagibbs> just have new wallets put in a static pubkey, profit? 110 2017-06-17T16:46:21 <jonasschnelli> yes. that works 111 2017-06-17T16:47:11 <instagibbs> k sounds good 112 2017-06-17T16:47:59 *** AaronvanW has joined #bitcoin-core-dev 113 2017-06-17T16:52:11 *** AaronvanW has quit IRC 114 2017-06-17T17:39:00 *** dermoth_ has joined #bitcoin-core-dev 115 2017-06-17T17:39:19 *** dermoth_ is now known as dermoth 116 2017-06-17T17:58:23 *** goatturneer has joined #bitcoin-core-dev 117 2017-06-17T17:59:20 *** goatturner has quit IRC 118 2017-06-17T17:59:20 *** juscamarena_ has quit IRC 119 2017-06-17T17:59:22 *** juscamarena has joined #bitcoin-core-dev 120 2017-06-17T17:59:47 *** juscamarena is now known as Guest60098 121 2017-06-17T18:07:35 *** talmai has joined #bitcoin-core-dev 122 2017-06-17T18:10:37 *** NewBTCDev has joined #bitcoin-core-dev 123 2017-06-17T18:22:54 <NewBTCDev> Hello, new dev trying to build on windows. Getting a make error that I don't understand... Could someone please take a peek and point me in the right direction? Thanks. https://pastebin.com/nNHh1B0h 124 2017-06-17T18:35:04 <jonasschnelli> NewBTCDev: Building on Windows itself is heavy and not supported out-of-the-box (AFAIK)... try cross compile via Linux? 125 2017-06-17T18:35:33 <jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md#cross-compilation 126 2017-06-17T18:35:35 *** dermoth has quit IRC 127 2017-06-17T18:39:11 <NewBTCDev> Thanks Jonass, Those are the steps I'm taking. I'm also setting up a linux VM right now.... Will my life be a lot easier building on linux? I'm new to C++ projects 128 2017-06-17T18:40:04 *** dermoth has joined #bitcoin-core-dev 129 2017-06-17T18:44:37 <jonasschnelli> NewBTCDev: A lot easier (if you ask me) 130 2017-06-17T18:44:57 <jonasschnelli> Windows cross compile via mingw/depends is supereasy 131 2017-06-17T18:47:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev 132 2017-06-17T18:48:42 *** AaronvanW has joined #bitcoin-core-dev 133 2017-06-17T18:48:50 *** gijensen has quit IRC 134 2017-06-17T18:48:50 *** Taek has quit IRC 135 2017-06-17T18:48:50 *** kayamm has quit IRC 136 2017-06-17T18:48:50 *** thrasher` has quit IRC 137 2017-06-17T18:48:50 *** BobBarker has quit IRC 138 2017-06-17T18:48:51 *** sugarpuff has quit IRC 139 2017-06-17T18:48:51 *** lesderid has quit IRC 140 2017-06-17T18:48:51 *** nanotube has quit IRC 141 2017-06-17T18:48:51 *** ibrightly has quit IRC 142 2017-06-17T18:48:51 *** NicolasDorier has quit IRC 143 2017-06-17T18:48:51 *** ryan-c has quit IRC 144 2017-06-17T18:48:58 *** BobBarker has joined #bitcoin-core-dev 145 2017-06-17T18:49:01 *** k4y4mm has joined #bitcoin-core-dev 146 2017-06-17T18:49:01 *** gijensen has joined #bitcoin-core-dev 147 2017-06-17T18:49:31 *** lesderid has joined #bitcoin-core-dev 148 2017-06-17T18:49:39 *** thrasher` has joined #bitcoin-core-dev 149 2017-06-17T18:49:45 *** sugarpuff has joined #bitcoin-core-dev 150 2017-06-17T18:49:49 *** NicolasDorier has joined #bitcoin-core-dev 151 2017-06-17T18:49:58 *** Taek has joined #bitcoin-core-dev 152 2017-06-17T18:50:38 *** ibrightly has joined #bitcoin-core-dev 153 2017-06-17T18:51:58 *** ryan-c has joined #bitcoin-core-dev 154 2017-06-17T18:53:05 *** AaronvanW has quit IRC 155 2017-06-17T18:53:36 *** dermoth has quit IRC 156 2017-06-17T18:55:59 *** dermoth has joined #bitcoin-core-dev 157 2017-06-17T18:56:33 *** nanotube has joined #bitcoin-core-dev 158 2017-06-17T18:57:59 *** NewBTCDev has quit IRC 159 2017-06-17T18:58:29 <bitcoin-git> [bitcoin] instagibbs opened pull request #10621: Use fixed pubkey during wallet init for default key (master...staticdefault) https://github.com/bitcoin/bitcoin/pull/10621 160 2017-06-17T19:01:08 *** chjj has quit IRC 161 2017-06-17T19:01:53 *** Ylbam has quit IRC 162 2017-06-17T19:14:05 *** chjj has joined #bitcoin-core-dev 163 2017-06-17T19:15:27 *** dermoth has quit IRC 164 2017-06-17T19:20:15 *** dermoth has joined #bitcoin-core-dev 165 2017-06-17T19:39:13 *** dermoth has quit IRC 166 2017-06-17T19:39:13 *** Chris_Stewart_5 has quit IRC 167 2017-06-17T19:51:48 *** dermoth has joined #bitcoin-core-dev 168 2017-06-17T19:56:58 *** laurentmt has joined #bitcoin-core-dev 169 2017-06-17T20:01:23 *** laurentmt has quit IRC 170 2017-06-17T20:04:57 *** chjj has quit IRC 171 2017-06-17T20:19:36 *** chjj has joined #bitcoin-core-dev 172 2017-06-17T20:22:08 *** SopaXorzTaker has quit IRC 173 2017-06-17T20:26:22 *** dermoth has quit IRC 174 2017-06-17T20:32:22 *** dermoth has joined #bitcoin-core-dev 175 2017-06-17T20:49:32 *** AaronvanW has joined #bitcoin-core-dev 176 2017-06-17T20:51:50 *** Dyaheon has quit IRC 177 2017-06-17T20:53:57 *** AaronvanW has quit IRC 178 2017-06-17T20:54:55 *** Dyaheon has joined #bitcoin-core-dev 179 2017-06-17T21:09:41 *** dermoth has quit IRC 180 2017-06-17T21:21:56 *** dermoth has joined #bitcoin-core-dev 181 2017-06-17T21:25:45 *** gaf_ has quit IRC 182 2017-06-17T21:35:45 *** talmai has quit IRC 183 2017-06-17T21:46:52 *** dermoth has quit IRC 184 2017-06-17T21:47:55 *** dermoth has joined #bitcoin-core-dev 185 2017-06-17T22:24:40 *** justanotheruser has quit IRC 186 2017-06-17T22:26:06 *** justanotheruser has joined #bitcoin-core-dev 187 2017-06-17T22:28:07 *** justanotheruser has quit IRC 188 2017-06-17T22:28:29 *** justanotheruser has joined #bitcoin-core-dev 189 2017-06-17T22:30:35 *** marcoagner has quit IRC 190 2017-06-17T22:35:43 *** Ylbam has joined #bitcoin-core-dev 191 2017-06-17T22:36:11 *** gaf_ has joined #bitcoin-core-dev 192 2017-06-17T22:41:41 *** dermoth has quit IRC 193 2017-06-17T22:42:43 *** marcoagner has joined #bitcoin-core-dev 194 2017-06-17T22:48:06 *** dermoth has joined #bitcoin-core-dev 195 2017-06-17T22:50:10 *** AaronvanW has joined #bitcoin-core-dev 196 2017-06-17T22:50:33 <Lightsword> whatâs the function that serializes BIP34 height in core? 197 2017-06-17T22:55:03 *** AaronvanW has quit IRC 198 2017-06-17T22:58:33 *** Dyaheon has quit IRC 199 2017-06-17T22:59:05 *** Dyaheon has joined #bitcoin-core-dev 200 2017-06-17T23:01:17 <sipa> Lightsword: ContextualCheckBlock 201 2017-06-17T23:03:09 <Lightsword> sipa, thatâs only checking it right? I mean the function that does the length prefixed height serialization when mining a block 202 2017-06-17T23:08:28 *** gaf_ has quit IRC 203 2017-06-17T23:09:20 <Lightsword> trying to fix this height length serialization function in pool software https://bitbucket.org/ckolivas/ckpool/src/4718cea30af47963aa55dcc4c452b9b2f9768ff8/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1757:1774 doesnât work at some lower block numbers it seems 204 2017-06-17T23:21:11 <sipa> BlockAssembler::CreateNewBlock 205 2017-06-17T23:43:37 *** PaulCapestany has joined #bitcoin-core-dev 206 2017-06-17T23:44:00 <luke-jr> kallewoof: ping 207 2017-06-17T23:44:23 <luke-jr> Lightsword: probably it's missing the sign bit 208 2017-06-17T23:44:33 *** dermoth has quit IRC 209 2017-06-17T23:45:55 <luke-jr> Lightsword: the len2/len3 ought to be 32768 and 8388608 210 2017-06-17T23:46:03 <luke-jr> 0x8000 and 0x800000 211 2017-06-17T23:48:50 *** dermoth has joined #bitcoin-core-dev 212 2017-06-17T23:50:09 <Lightsword> luke-jr, ah, I recall having trouble with it at block heights even below 10 as well 213 2017-06-17T23:50:12 *** phantomcircuit_ is now known as phantomcircuit 214 2017-06-17T23:50:25 <Lightsword> luke-jr, if it was a sign bit issue wouldnât it not work at all? 215 2017-06-17T23:51:01 <phantomcircuit> Lightsword, iirc thre isn't any code in bitcoin to do the actual serialization 216 2017-06-17T23:51:05 <phantomcircuit> just to check that it's right 217 2017-06-17T23:51:06 <phantomcircuit> ? 218 2017-06-17T23:51:09 <phantomcircuit> i could be wrong 219 2017-06-17T23:51:20 <luke-jr> Lightsword: it would work on and off, but it's not 220 2017-06-17T23:51:22 <phantomcircuit> wait there has to be 221 2017-06-17T23:51:45 <luke-jr> phantomcircuit: it checks by serialising and comparing 222 2017-06-17T23:57:49 <Lightsword> luke-jr, see any other potential issues there?