1 2017-06-25T00:02:55  *** suryab has joined #bitcoin-core-dev
  2 2017-06-25T00:04:01  <suryab> Hi, i'm trying to calculate the fee rate of a transaction that is not in the mempool. I saw the way fees are traditionally calculated and can't do the mempool.info() route. Any suggestions?
  3 2017-06-25T00:05:27  <suryab> There also doesn't seem to be any functionality already there for getting the feerate out of a transaction.
  4 2017-06-25T00:11:11  <sipa> you can't get the feerate from a transaction
  5 2017-06-25T00:11:16  <sipa> you need the UTXOs it spends
  6 2017-06-25T00:11:18  <jtimon> suryab: I believe you are correct. Not only at the rpc level but not even at a lower level. https://github.com/bitcoin/bitcoin/pull/8498 would solve this or you can just CAmount nFees = view.GetValueIn(tx)- tx.GetValueOut();
  7 2017-06-25T00:11:33  <jtimon> right, there the utxos are in view
  8 2017-06-25T00:56:54  *** jamesob has joined #bitcoin-core-dev
  9 2017-06-25T01:07:44  *** jamesob has quit IRC
 10 2017-06-25T01:38:48  *** Ylbam has quit IRC
 11 2017-06-25T01:43:57  *** diteli_ has joined #bitcoin-core-dev
 12 2017-06-25T02:02:01  *** harrymm has quit IRC
 13 2017-06-25T02:26:27  *** jtimon has quit IRC
 14 2017-06-25T02:33:15  *** jtimon has joined #bitcoin-core-dev
 15 2017-06-25T02:33:27  *** jtimon has quit IRC
 16 2017-06-25T02:38:55  *** diteli_ has quit IRC
 17 2017-06-25T02:44:49  *** belcher_ has quit IRC
 18 2017-06-25T02:54:27  *** goofie_ has quit IRC
 19 2017-06-25T02:55:27  *** chjj has quit IRC
 20 2017-06-25T03:10:14  *** goofie_ has joined #bitcoin-core-dev
 21 2017-06-25T04:24:58  *** jtimon has joined #bitcoin-core-dev
 22 2017-06-25T04:50:05  *** suryab has quit IRC
 23 2017-06-25T05:06:55  <bitcoin-git> [bitcoin] jtimon closed pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717
 24 2017-06-25T05:07:04  *** chjj has joined #bitcoin-core-dev
 25 2017-06-25T05:16:10  <bitcoin-git> [bitcoin] jtimon reopened pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717
 26 2017-06-25T05:23:33  *** chjj has quit IRC
 27 2017-06-25T05:58:20  *** ProfMac_ has quit IRC
 28 2017-06-25T06:09:50  <jtimon> mhmm, it doesn't seem like https://travis-ci.org/bitcoin/bitcoin/jobs/246709867  and https://travis-ci.org/bitcoin/bitcoin/jobs/246709865 should have failed, but I'm on the laptop and I can't say for sure yet
 29 2017-06-25T06:27:15  *** harrymm has joined #bitcoin-core-dev
 30 2017-06-25T06:31:06  *** AaronvanW has quit IRC
 31 2017-06-25T06:31:44  *** AaronvanW has joined #bitcoin-core-dev
 32 2017-06-25T06:33:46  *** btcdrak has joined #bitcoin-core-dev
 33 2017-06-25T06:34:37  *** goofie_ has quit IRC
 34 2017-06-25T06:35:50  *** AaronvanW has quit IRC
 35 2017-06-25T06:45:58  *** harrymm has quit IRC
 36 2017-06-25T06:46:14  *** harrymm has joined #bitcoin-core-dev
 37 2017-06-25T07:19:03  *** chjj has joined #bitcoin-core-dev
 38 2017-06-25T07:24:54  *** Ylbam has joined #bitcoin-core-dev
 39 2017-06-25T07:27:39  *** neel has joined #bitcoin-core-dev
 40 2017-06-25T08:10:00  <jtimon> what's the simplest way to find out whoch commit deleted a given variable, say, pwalletMain
 41 2017-06-25T08:10:02  <jtimon> ?
 42 2017-06-25T08:11:44  <jcorgan> some unholy combination of git bisect and grep i'd suppose
 43 2017-06-25T08:13:28  <jtimon> I guess I can always ask how to do it from xmonad on #haskell
 44 2017-06-25T08:13:41  <wumpus> git log -p is usually my friend in those cases
 45 2017-06-25T08:14:14  <wumpus> find out what what commit it was last mentioned in, especially works if you can limit the scope to not the entire source code
 46 2017-06-25T08:15:24  <wumpus> though bisect and grep seems more elegant
 47 2017-06-25T08:18:54  *** goatpig has quit IRC
 48 2017-06-25T08:18:57  *** arubi has quit IRC
 49 2017-06-25T08:24:14  *** arubi has joined #bitcoin-core-dev
 50 2017-06-25T08:25:44  *** justanotheruser has quit IRC
 51 2017-06-25T08:26:07  *** justanotheruser has joined #bitcoin-core-dev
 52 2017-06-25T08:26:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bef02fb6ac9f...d609fd85ca41
 53 2017-06-25T08:26:34  <bitcoin-git> bitcoin/master b324b28 Jorge Timón: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()
 54 2017-06-25T08:26:34  <bitcoin-git> bitcoin/master d609fd8 Wladimir J. van der Laan: Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()...
 55 2017-06-25T08:26:51  *** goatpig has joined #bitcoin-core-dev
 56 2017-06-25T08:30:49  *** harrymm has quit IRC
 57 2017-06-25T08:31:03  *** harrymm has joined #bitcoin-core-dev
 58 2017-06-25T08:35:39  *** harrymm has quit IRC
 59 2017-06-25T08:44:33  *** arubi has quit IRC
 60 2017-06-25T08:47:54  *** Yogaqueef has joined #bitcoin-core-dev
 61 2017-06-25T08:48:54  <bitcoin-git> [bitcoin] jtimon opened pull request #10668: Pow: Introduce MaybeGenerateProof (master...b15-blocksign) https://github.com/bitcoin/bitcoin/pull/10668
 62 2017-06-25T08:49:39  *** arubi has joined #bitcoin-core-dev
 63 2017-06-25T08:50:19  <bitcoin-git> [bitcoin] jtimon closed pull request #10668: Pow: Introduce MaybeGenerateProof (master...b15-blocksign) https://github.com/bitcoin/bitcoin/pull/10668
 64 2017-06-25T08:56:14  <bitcoin-git> [bitcoin] jtimon opened pull request #10669: Pow: Introduce MaybeGenerateProof (master...b14-pow-maybe-prove) https://github.com/bitcoin/bitcoin/pull/10669
 65 2017-06-25T09:01:44  <bitcoin-git> [bitcoin] laanwj closed pull request #10282: Expire bitcoind & bitcoin-qt 7-8 years after its last change (master...timebomb) https://github.com/bitcoin/bitcoin/pull/10282
 66 2017-06-25T09:04:05  *** Giszmo has quit IRC
 67 2017-06-25T09:22:20  *** jtimon has quit IRC
 68 2017-06-25T09:52:50  *** neel has quit IRC
 69 2017-06-25T09:54:02  *** d9b4bef9 has quit IRC
 70 2017-06-25T09:55:08  *** d9b4bef9 has joined #bitcoin-core-dev
 71 2017-06-25T10:05:03  *** riemann has joined #bitcoin-core-dev
 72 2017-06-25T10:05:48  *** neel has joined #bitcoin-core-dev
 73 2017-06-25T10:06:06  *** harrymm has joined #bitcoin-core-dev
 74 2017-06-25T10:19:57  *** goofie_ has joined #bitcoin-core-dev
 75 2017-06-25T10:47:48  *** Guyver2 has joined #bitcoin-core-dev
 76 2017-06-25T11:04:54  *** sipa has quit IRC
 77 2017-06-25T11:22:30  *** SopaXorzTaker has joined #bitcoin-core-dev
 78 2017-06-25T11:43:32  <instagibbs> git log -p -M can help you track across renamings at least
 79 2017-06-25T11:55:39  *** belcher_ has joined #bitcoin-core-dev
 80 2017-06-25T11:56:10  *** goofie_ has quit IRC
 81 2017-06-25T12:46:38  *** laurentmt has joined #bitcoin-core-dev
 82 2017-06-25T12:56:14  *** goofie_ has joined #bitcoin-core-dev
 83 2017-06-25T12:59:15  *** laurentmt has quit IRC
 84 2017-06-25T13:14:58  *** goofie_ has quit IRC
 85 2017-06-25T13:20:33  *** goofie_ has joined #bitcoin-core-dev
 86 2017-06-25T13:23:26  *** btcdrak has quit IRC
 87 2017-06-25T13:33:26  *** goofie_ has quit IRC
 88 2017-06-25T13:53:02  *** d9b4bef9 has quit IRC
 89 2017-06-25T13:56:07  *** d9b4bef9 has joined #bitcoin-core-dev
 90 2017-06-25T14:17:41  *** laurentmt has joined #bitcoin-core-dev
 91 2017-06-25T14:18:25  *** laurentmt has quit IRC
 92 2017-06-25T14:18:52  *** Guyver2 has quit IRC
 93 2017-06-25T14:24:56  *** chjj has quit IRC
 94 2017-06-25T14:29:33  *** dermoth has quit IRC
 95 2017-06-25T14:30:02  *** dermoth has joined #bitcoin-core-dev
 96 2017-06-25T14:39:51  *** goofie_ has joined #bitcoin-core-dev
 97 2017-06-25T14:50:05  *** tiagotrs has joined #bitcoin-core-dev
 98 2017-06-25T14:58:13  *** Yogaqueef has quit IRC
 99 2017-06-25T15:06:08  *** ProfMac has joined #bitcoin-core-dev
100 2017-06-25T15:28:17  *** ProfMac is now known as ProfMac_
101 2017-06-25T15:43:27  *** sipa has joined #bitcoin-core-dev
102 2017-06-25T15:59:06  <earlz> Is there some way to force a node to rebroadcast it's mempool?
103 2017-06-25T16:09:04  <sipa> no
104 2017-06-25T16:09:52  <sipa> (peers can ask for a node's mempool using the bip35 'mempool' command, but it's never broadcast unadvertized)
105 2017-06-25T16:23:04  <earlz> is there any way to easily make that request from a Bitcoin Core node?
106 2017-06-25T16:23:11  <earlz> ie, an RPC command for it?
107 2017-06-25T16:24:11  <sipa> getrawmempool
108 2017-06-25T16:24:21  <sipa> oh, no
109 2017-06-25T16:24:32  <sipa> you meam make your node request it from another, no
110 2017-06-25T16:25:10  <earlz> ah lame, so you'd have to write code to get Bitcoin Core to do that
111 2017-06-25T16:27:45  <sipa> why do you need it?
112 2017-06-25T16:34:51  <earlz> Testing something and was see some difference between 2 node's mempool count
113 2017-06-25T16:35:32  *** laurentmt has joined #bitcoin-core-dev
114 2017-06-25T16:37:10  *** laurentmt has quit IRC
115 2017-06-25T16:37:54  <sipa> how would that help?
116 2017-06-25T16:39:06  <sipa> afaik the only reason you'd use that command on a full node is to get your mempool to converge faster to that of your peers
117 2017-06-25T16:39:28  <sipa> something that's much less needed now with mempool being saved to disk
118 2017-06-25T16:42:23  <earlz> If node A mempool is 200, and node B only has 100, and B is only connected to A, will the missing txs be broadcast to B through the mempool, or does rebroadcasting never happen naturally?
119 2017-06-25T16:49:26  *** Yogaqueef has joined #bitcoin-core-dev
120 2017-06-25T16:49:41  <sipa> no, only new transactions are relayed
121 2017-06-25T16:50:06  <sipa> and wallets rebroadcast their own transactions occasionally
122 2017-06-25T16:51:15  <earlz> What about when a wallet does a rebroadcast because it doesn't see it's tx in the network mempool? Would that cause it to spread to the greater network? (ie, if A has tx X, and B does a rebroadcast of X, does that cause A to also rebroadcast X to it's peers)
123 2017-06-25T16:53:13  *** vicenteH` has quit IRC
124 2017-06-25T16:53:32  *** vicenteH` has joined #bitcoin-core-dev
125 2017-06-25T16:55:55  <sipa> yes
126 2017-06-25T16:56:02  <sipa> wait, no
127 2017-06-25T16:56:16  <sipa> the rebroascast only happens to peers that don't already have the tx
128 2017-06-25T16:56:37  <sipa> they will of course relay it further
129 2017-06-25T16:57:15  <sipa> but if a node has a tx already, and sees it inved again, it is ignored
130 2017-06-25T17:05:38  *** neel_ has joined #bitcoin-core-dev
131 2017-06-25T17:07:15  *** goofie_ has quit IRC
132 2017-06-25T17:08:31  *** neel has quit IRC
133 2017-06-25T17:17:21  <earlz> ok thanks, I think this behavior makes sense to me now
134 2017-06-25T17:28:43  *** ProfMac_ is now known as ProfMac
135 2017-06-25T17:39:27  *** justanotheruser has quit IRC
136 2017-06-25T17:39:28  *** Dyaheon has quit IRC
137 2017-06-25T17:39:55  *** Dyaheon has joined #bitcoin-core-dev
138 2017-06-25T17:40:28  *** justanotheruser has joined #bitcoin-core-dev
139 2017-06-25T17:46:15  <ProfMac> This may interest this group:  I am trying to set up my own flavor of a deterministic build environment.  This uses the desktop Trusty (14.04.5) amd64 iso and a preseed file.  I am having trouble with preseeding.  I have set up a git with the scripts and the syslog, and hope to get help in #ubuntu-installer
140 2017-06-25T17:47:16  <ProfMac> An entry to my git is at https://github.com/a-mcintosh/Trusty-preseed/blob/master/syslog
141 2017-06-25T17:57:55  *** AaronvanW has joined #bitcoin-core-dev
142 2017-06-25T17:58:07  *** neel_ has quit IRC
143 2017-06-25T17:59:14  *** neel has joined #bitcoin-core-dev
144 2017-06-25T18:18:42  *** jamesob has joined #bitcoin-core-dev
145 2017-06-25T18:18:46  *** jamesob has quit IRC
146 2017-06-25T18:19:02  *** jamesob has joined #bitcoin-core-dev
147 2017-06-25T18:19:17  <jamesob> heyyyyy everybodyboydyboydy
148 2017-06-25T18:19:26  *** goatpig has quit IRC
149 2017-06-25T18:21:55  *** tiagotrs has quit IRC
150 2017-06-25T18:23:20  *** riemann has quit IRC
151 2017-06-25T18:24:25  <jamesob> (wrong window :)
152 2017-06-25T18:42:08  *** jamesob has quit IRC
153 2017-06-25T18:45:00  *** riemann has joined #bitcoin-core-dev
154 2017-06-25T19:02:08  *** Giszmo has joined #bitcoin-core-dev
155 2017-06-25T19:05:28  *** ProfMac is now known as ProfMac_
156 2017-06-25T19:43:47  *** jamesob has joined #bitcoin-core-dev
157 2017-06-25T19:46:44  *** laurentmt has joined #bitcoin-core-dev
158 2017-06-25T19:48:00  *** laurentmt has quit IRC
159 2017-06-25T19:48:38  *** tripleslash has quit IRC
160 2017-06-25T19:52:40  *** tripleslash has joined #bitcoin-core-dev
161 2017-06-25T19:53:03  *** tripleslash is now known as Guest34077
162 2017-06-25T19:57:53  *** johnwang412 has joined #bitcoin-core-dev
163 2017-06-25T20:00:28  *** dermoth has quit IRC
164 2017-06-25T20:00:54  *** dermoth has joined #bitcoin-core-dev
165 2017-06-25T20:16:08  *** Yogaqueef has quit IRC
166 2017-06-25T21:06:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
167 2017-06-25T21:08:14  *** neel_ has joined #bitcoin-core-dev
168 2017-06-25T21:08:15  *** neel has quit IRC
169 2017-06-25T21:08:33  *** goofie has joined #bitcoin-core-dev
170 2017-06-25T21:10:11  *** jtimon has joined #bitcoin-core-dev
171 2017-06-25T21:11:15  <jtimon> sipa: continuing here instead of the PR, I'm just curious about your thoughts
172 2017-06-25T21:11:58  <jtimon> I see what you are saying, you mean moving part of primitives/transaction.h to consensus/tx_verify or similar, I don't care much about it either way
173 2017-06-25T21:12:27  <jtimon> the libconsensus package (which is the encapsulation I care about the most) will have it either way
174 2017-06-25T21:15:50  *** Chris_Stewart_5 has quit IRC
175 2017-06-25T21:16:34  <jtimon> although data structures don't need to depend on consensus validation, consensus validation does depend on consensus data structures. Both primitives/transaction.h and primitives/block.h are already in LIBBITCOIN_CONSENSUS unlike consensus/tx_verify
176 2017-06-25T21:18:13  <jtimon> well, actually I didn't had any question left...
177 2017-06-25T21:19:17  <jtimon> I guess I'm just curious of what BlueMatt plans to put on LIBBITCOIN_CONSENSUS, I hope not validation.o and all its dependencies
178 2017-06-25T21:20:37  <sipa> jtimon: my thoughts are that serialization code shouldn't need to depend on consensus logic (which includes resource limits and weight calculation)... for example spv wallet code does not need a dependendy on anything consensus related, but it does need to be able to serialize/deserialize transactions
179 2017-06-25T21:21:05  <sipa> so i see primitives/* as a basic dependency for everything, while consensus/* is only needed for validation-related things
180 2017-06-25T21:21:35  <jtimon> ok, but you will still depend on the LIBBITCOIN_CONSENSUS package if you need anything from primitives
181 2017-06-25T21:21:51  <sipa> no, you shouldn't
182 2017-06-25T21:22:01  <jtimon> I guess we could do a primitives package on the makefile
183 2017-06-25T21:22:09  <sipa> right
184 2017-06-25T21:22:11  <jtimon> well, it's the way it is now
185 2017-06-25T21:22:23  <sipa> i don't really care about how the package layout is now
186 2017-06-25T21:22:33  <sipa> more about what inherent dependencies exist within the code
187 2017-06-25T21:23:58  <jtimon> I personally don't have a problem with anything wallet depending on the consensus package tough, pretty much the contrary, I wish more wallets depended on it
188 2017-06-25T21:25:07  <sipa> sure, but a hardware wallet glue utility shouldn't need more than just primitives
189 2017-06-25T21:25:22  <sipa> it seems unnecessary to have serialization code depend on consensus
190 2017-06-25T21:26:30  <jtimon> right, what I've thought more about iw what I would like LIBBITCOIN_CONSENSUS to have in total in the future, but separating some smaller packages shouldn't conflict with that
191 2017-06-25T21:26:51  <jtimon> primitiveslib ?
192 2017-06-25T21:27:09  <jtimon> oh, sorry, you mean internally
193 2017-06-25T21:28:06  <jtimon> yeah, sure, more encapsulation than what I thought I needed can't hurt
194 2017-06-25T21:30:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
195 2017-06-25T21:30:45  <sipa> or the primitives/* code can be compiled into multiple packages even, including consensus - i don't really care
196 2017-06-25T21:43:51  *** Dyaheon has quit IRC
197 2017-06-25T21:43:52  *** jtimon has quit IRC
198 2017-06-25T21:45:14  *** Dyaheon has joined #bitcoin-core-dev
199 2017-06-25T21:46:28  *** jamesob_ has joined #bitcoin-core-dev
200 2017-06-25T21:47:01  *** jamesob has quit IRC
201 2017-06-25T21:56:42  *** jamesob has joined #bitcoin-core-dev
202 2017-06-25T22:00:14  *** jamesob_ has quit IRC
203 2017-06-25T22:07:38  *** riemann has quit IRC
204 2017-06-25T22:08:41  *** btcdrak has joined #bitcoin-core-dev
205 2017-06-25T22:26:45  *** johnwang412 has quit IRC
206 2017-06-25T22:58:15  *** chjj has joined #bitcoin-core-dev
207 2017-06-25T23:00:05  *** BobBarker has left #bitcoin-core-dev
208 2017-06-25T23:19:13  *** vicenteH` has quit IRC
209 2017-06-25T23:26:26  *** chjj has quit IRC
210 2017-06-25T23:27:01  *** chjj has joined #bitcoin-core-dev
211 2017-06-25T23:58:20  *** chjj has quit IRC
212 2017-06-25T23:59:12  *** chjj has joined #bitcoin-core-dev