1 2017-07-07T00:06:24  *** Cheeseo has joined #bitcoin-core-dev
  2 2017-07-07T00:06:40  *** RoyceX has quit IRC
  3 2017-07-07T00:06:44  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10758: Fix some chainstate-init-order bugs. (master...2014-07-nonatomic-flush-fixes) https://github.com/bitcoin/bitcoin/pull/10758
  4 2017-07-07T00:10:57  <jtimon> jamesob just finally learning how to use docker on my own now. yeah, I think it could simplify development by not requiring to install the dependencies in your local system. perhaps it could help simplifying further the process for deterministic builds? maybe others prefer it on another repo, but I think it wouldn't hurt on contrib
  5 2017-07-07T00:11:04  <jtimon> in contrib
  6 2017-07-07T00:11:59  <jtimon> but I think you still need a VM for the deterministic builds...not sure
  7 2017-07-07T00:13:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  8 2017-07-07T00:14:04  *** tiagotrs has joined #bitcoin-core-dev
  9 2017-07-07T00:16:42  *** Murch has quit IRC
 10 2017-07-07T00:43:24  *** stalictite has quit IRC
 11 2017-07-07T00:50:38  *** RoyceX has joined #bitcoin-core-dev
 12 2017-07-07T00:53:48  *** Cheeseo has quit IRC
 13 2017-07-07T00:53:56  *** coredump_ has joined #bitcoin-core-dev
 14 2017-07-07T00:54:58  *** jamesob has joined #bitcoin-core-dev
 15 2017-07-07T01:01:01  *** tiagotrs_ has joined #bitcoin-core-dev
 16 2017-07-07T01:01:08  <jamesob> jtimon: is the need for deterministic builds obviated by the hash related to each docker image build? i.e. can we reference a single docker image in lieu of doing the vm builds?
 17 2017-07-07T01:01:13  *** chjj has quit IRC
 18 2017-07-07T01:02:35  <jtimon> no, I don't think docker's determinism is enough for bitcoin's deterministic builds is what I'm saying, but I'm no expert on either of them, just used them by following tutorials and reading other people's code
 19 2017-07-07T01:02:55  <jamesob> gotcha
 20 2017-07-07T01:03:08  <sipa> jamesob: i think we want to push it the other direction really... where the build becomes deterministic even when not run in any controlled environment
 21 2017-07-07T01:03:16  <sipa> (apart from compiler versions)
 22 2017-07-07T01:03:59  <jamesob> sipa: yeah, makes sense... relying on a single trusted image is probably the counterpoint to the purpose of the build process :)
 23 2017-07-07T01:04:01  *** tiagotrs has quit IRC
 24 2017-07-07T01:04:21  <sipa> jamesob: exactly
 25 2017-07-07T01:04:34  <jtimon> right, the point is everyone creating the same image on their own
 26 2017-07-07T01:04:55  <sipa> jamesob: and it's already the case for the OSX build pretty much (as it builds the compiler etc as part of the build process)
 27 2017-07-07T01:05:39  <jamesob> ah interesting
 28 2017-07-07T01:06:01  <jtimon> my doubt was if docker could maybe remove the need for a VM
 29 2017-07-07T01:06:39  <sipa> isn't docker effectively creating a VM?
 30 2017-07-07T01:06:47  <sipa> (/me docket noob)
 31 2017-07-07T01:06:51  <jamesob> I think there may be promise there... running a single container is less memory consumptive than, say, virtualbox afaik
 32 2017-07-07T01:07:06  <jamesob> and certainly much faster for anyone who has the docker daemon already running
 33 2017-07-07T01:07:06  <sipa> no need for virtualbox
 34 2017-07-07T01:07:45  <jtimon> I mean, in the deterministic build tutorial for bitcoin, which I found easy to follow, you are required to create a debian vm
 35 2017-07-07T01:08:18  <jtimon> perhaps that's just good habit, but it looked like a requirement
 36 2017-07-07T01:08:19  <sipa> sure, because that's easiest to make sure the environment matches
 37 2017-07-07T01:08:38  <sipa> but you can just use typical desktop linux environments as host
 38 2017-07-07T01:08:42  <jtimon> well, that's where I wonder if docker could simplify things
 39 2017-07-07T01:09:04  <sipa> i'm sure it can simlify things
 40 2017-07-07T01:09:23  <sipa> but i'm questioning how it could replace the need for a VM... when (afaik) it internally runs things in a VM
 41 2017-07-07T01:09:27  <jtimon> just use debian:jessie container or something
 42 2017-07-07T01:09:40  <jamesob> jtimon right
 43 2017-07-07T01:10:41  <jamesob> sipa docker is almost closer to a chroot than a VM IMO
 44 2017-07-07T01:11:02  <sipa> jamesob: so is LXC
 45 2017-07-07T01:11:23  <sipa> gitian right now has no need for a VM anywhere
 46 2017-07-07T01:11:29  <jamesob> yep -- I think docker used to ride on top of LXC; think they may have ditched it recently
 47 2017-07-07T01:11:36  <jamesob> gotcha
 48 2017-07-07T01:12:13  <sipa> the instructions tell you to create a debian VM because that's an easy way to get a system in a simple to describe state
 49 2017-07-07T01:12:49  <sipa> so if you can simplify that process with docker, feel free
 50 2017-07-07T01:13:23  <jamesob> cool, I'll take a look
 51 2017-07-07T01:13:57  <sipa> but at this point, i think can't avoid gitian
 52 2017-07-07T01:14:09  <sipa> so you'd describe some docker system in which gitian can be run
 53 2017-07-07T01:14:37  *** chjj has joined #bitcoin-core-dev
 54 2017-07-07T01:15:06  <jtimon> jamesob: yeah, if you modify the gitian guide to use docker instead of a VM and hopefully having to copy and paste less things I will be more than happy to try it locally
 55 2017-07-07T01:16:07  <jtimon> https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md
 56 2017-07-07T01:17:20  *** Chris_Stewart_5 has quit IRC
 57 2017-07-07T01:17:49  *** jamesob has quit IRC
 58 2017-07-07T01:17:52  <jtimon> mhmm, "LXC, see also Gitian host docker container[ https://github.com/gdm85/tenku/blob/master/docker/gitian-bitcoin-host/README.md ] .
 59 2017-07-07T01:18:59  <jtimon> perhaps that last link is what we're talking about and it's already done? then why the VM ?
 60 2017-07-07T01:22:05  *** Ylbam has quit IRC
 61 2017-07-07T01:48:07  <grubles> i think that is out of date (2015). i tried following it the other day and it seems some of the scripts are maybe in the wrong directories? (https://github.com/gdm85/tenku/blob/master/docker/gitian-bitcoin-host/scripts/spawn-gitian-bitcoin-host.sh in particular 404s as it is in the wrong dir)
 62 2017-07-07T01:57:43  *** tiagotrs_ has quit IRC
 63 2017-07-07T02:06:28  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10759: Fix multi_rpc test for hosts that dont default to utf8 (master...2017-07-fix-mult-rpc-test) https://github.com/bitcoin/bitcoin/pull/10759
 64 2017-07-07T02:40:01  *** dabura667 has joined #bitcoin-core-dev
 65 2017-07-07T02:42:02  *** d9b4bef9 has quit IRC
 66 2017-07-07T02:43:15  *** d9b4bef9 has joined #bitcoin-core-dev
 67 2017-07-07T02:45:43  *** RubenSomsen has joined #bitcoin-core-dev
 68 2017-07-07T02:50:22  *** stevenroose has quit IRC
 69 2017-07-07T02:51:13  *** Lauda_ has quit IRC
 70 2017-07-07T02:52:19  *** Lauda_ has joined #bitcoin-core-dev
 71 2017-07-07T02:53:08  *** stevenroose has joined #bitcoin-core-dev
 72 2017-07-07T03:04:37  *** arowser has quit IRC
 73 2017-07-07T03:10:45  *** arowser has joined #bitcoin-core-dev
 74 2017-07-07T03:11:28  *** chjj has quit IRC
 75 2017-07-07T03:16:44  *** florpadorp has quit IRC
 76 2017-07-07T03:22:58  *** chjj has joined #bitcoin-core-dev
 77 2017-07-07T03:24:58  *** RubenSomsen has quit IRC
 78 2017-07-07T04:16:11  *** chjj has quit IRC
 79 2017-07-07T04:21:20  *** Guest2_ has joined #bitcoin-core-dev
 80 2017-07-07T04:25:27  *** chjj has joined #bitcoin-core-dev
 81 2017-07-07T04:31:43  *** Dyaheon has quit IRC
 82 2017-07-07T04:34:12  *** Dyaheon has joined #bitcoin-core-dev
 83 2017-07-07T04:41:49  *** Guest2_ has quit IRC
 84 2017-07-07T04:56:13  *** jtimon has quit IRC
 85 2017-07-07T05:08:17  *** harrymm has quit IRC
 86 2017-07-07T05:09:28  *** harrymm has joined #bitcoin-core-dev
 87 2017-07-07T05:14:20  *** ivan has quit IRC
 88 2017-07-07T05:31:08  *** AaronvanW has quit IRC
 89 2017-07-07T05:32:01  *** echonaut has quit IRC
 90 2017-07-07T05:32:10  *** echonaut5 has joined #bitcoin-core-dev
 91 2017-07-07T05:48:15  *** AaronvanW has joined #bitcoin-core-dev
 92 2017-07-07T06:08:32  *** Ylbam has joined #bitcoin-core-dev
 93 2017-07-07T06:20:32  *** musalbas has quit IRC
 94 2017-07-07T06:35:16  *** musalbas has joined #bitcoin-core-dev
 95 2017-07-07T06:36:05  *** phantomcircuit has quit IRC
 96 2017-07-07T06:37:05  *** Apocalyptic has quit IRC
 97 2017-07-07T06:38:04  *** kcud_dab has quit IRC
 98 2017-07-07T06:38:05  *** Anduck has quit IRC
 99 2017-07-07T06:38:17  *** bad_duck has joined #bitcoin-core-dev
100 2017-07-07T06:38:18  *** Apocalyptic has joined #bitcoin-core-dev
101 2017-07-07T06:38:35  *** bitbee has quit IRC
102 2017-07-07T06:39:05  *** rabidus has quit IRC
103 2017-07-07T06:39:48  *** Anduck has joined #bitcoin-core-dev
104 2017-07-07T06:40:03  *** rabidus has joined #bitcoin-core-dev
105 2017-07-07T06:40:30  *** bitbee has joined #bitcoin-core-dev
106 2017-07-07T06:45:06  *** phantomcircuit has joined #bitcoin-core-dev
107 2017-07-07T07:15:50  *** coredump_ has quit IRC
108 2017-07-07T07:28:46  *** dabura667_ has joined #bitcoin-core-dev
109 2017-07-07T07:28:58  *** dabura667 has quit IRC
110 2017-07-07T07:37:08  *** Lurline has joined #bitcoin-core-dev
111 2017-07-07T07:49:46  *** SopaXorzTaker has joined #bitcoin-core-dev
112 2017-07-07T07:54:16  *** ula has joined #bitcoin-core-dev
113 2017-07-07T07:56:12  <bitcoin-git> [bitcoin] sipa opened pull request #10760: Avoid dereference-of-casted-pointer (master...20170707_avoidcastptr) https://github.com/bitcoin/bitcoin/pull/10760
114 2017-07-07T08:13:06  <bitcoin-git> [bitcoin] jnewbery opened pull request #10761: [tests] fix replace_by_fee.py (master...fix_replace_by_fee) https://github.com/bitcoin/bitcoin/pull/10761
115 2017-07-07T08:36:57  *** vicenteH has joined #bitcoin-core-dev
116 2017-07-07T09:02:28  *** jouke has quit IRC
117 2017-07-07T09:06:26  *** jouke has joined #bitcoin-core-dev
118 2017-07-07T09:06:26  *** jouke has quit IRC
119 2017-07-07T09:06:26  *** jouke has joined #bitcoin-core-dev
120 2017-07-07T09:45:08  *** timothy has joined #bitcoin-core-dev
121 2017-07-07T09:50:24  *** Lurline has quit IRC
122 2017-07-07T09:57:18  <jonasschnelli> For your info: promag (João Barbosa) does – AFAIK – work on reviewing stuff pretty much fulltime (he has just started, giving him some direction would be good in genereal I guess)
123 2017-07-07T10:04:18  <bitcoin-git> [bitcoin] jnewbery opened pull request #10762: [WIP] Remove Wallet dependencies from init.cpp (master...walletinit) https://github.com/bitcoin/bitcoin/pull/10762
124 2017-07-07T10:06:37  <wumpus> jonasschnelli: cool
125 2017-07-07T10:07:20  <jonasschnelli> Lets just hope he doesn't loose endurance. :)
126 2017-07-07T10:12:37  *** Clare has joined #bitcoin-core-dev
127 2017-07-07T10:16:00  *** riemann has joined #bitcoin-core-dev
128 2017-07-07T10:17:52  *** Clare has quit IRC
129 2017-07-07T10:28:13  *** tiagotrs has joined #bitcoin-core-dev
130 2017-07-07T10:28:13  *** tiagotrs has joined #bitcoin-core-dev
131 2017-07-07T10:41:52  *** Aaronvan_ has joined #bitcoin-core-dev
132 2017-07-07T10:42:56  *** AaronvanW has quit IRC
133 2017-07-07T10:43:01  *** d9b4bef9 has quit IRC
134 2017-07-07T10:44:08  *** d9b4bef9 has joined #bitcoin-core-dev
135 2017-07-07T11:00:14  *** Aaronvan_ is now known as AaronvanW
136 2017-07-07T11:01:05  *** tiagotrs has quit IRC
137 2017-07-07T11:02:50  *** coredump_ has joined #bitcoin-core-dev
138 2017-07-07T11:12:50  *** tiagotrs has joined #bitcoin-core-dev
139 2017-07-07T11:16:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5af657253498...ed88e3194c4b
140 2017-07-07T11:16:46  <bitcoin-git> bitcoin/master 9bbf600 darksh1ne: Use method name from __func__ macro...
141 2017-07-07T11:16:47  <bitcoin-git> bitcoin/master ed88e31 MarcoFalke: Merge #10744: Use method name via __func__ macro...
142 2017-07-07T11:17:20  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10744: Use method name via __func__ macro (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10744
143 2017-07-07T11:24:34  *** tiagotrs has quit IRC
144 2017-07-07T11:28:35  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed88e3194c4b...d3b58704d1d3
145 2017-07-07T11:28:35  <bitcoin-git> bitcoin/master 301fd51 John Newbery: [tests] fix replace_by_fee.py...
146 2017-07-07T11:28:36  <bitcoin-git> bitcoin/master d3b5870 MarcoFalke: Merge #10761: [tests] fix replace_by_fee.py...
147 2017-07-07T11:29:03  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10761: [tests] fix replace_by_fee.py (master...fix_replace_by_fee) https://github.com/bitcoin/bitcoin/pull/10761
148 2017-07-07T11:29:59  *** felco is now known as AMaisLeveBrisa
149 2017-07-07T11:32:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3b58704d1d3...1d4805ce0464
150 2017-07-07T11:32:07  <bitcoin-git> bitcoin/master bc7d103 Matt Corallo: Fix multi_rpc test for hosts that dont default to utf8...
151 2017-07-07T11:32:07  <bitcoin-git> bitcoin/master 1d4805c MarcoFalke: Merge #10759: Fix multi_rpc test for hosts that dont default to utf8...
152 2017-07-07T11:32:35  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10759: Fix multi_rpc test for hosts that dont default to utf8 (master...2017-07-fix-mult-rpc-test) https://github.com/bitcoin/bitcoin/pull/10759
153 2017-07-07T11:55:32  <jonasschnelli> Anyone know why I get this liner error in travis (doesn't happen with clang): https://travis-ci.org/bitcoin/bitcoin/jobs/246110728#L2103
154 2017-07-07T11:55:45  <jonasschnelli> Seems like a cirular dependency thing
155 2017-07-07T11:55:50  <jonasschnelli> *circular
156 2017-07-07T11:56:12  <jonasschnelli> HTTPReq_JSONRPC is implemented in httprpc.cpp which is part of bitcoind ....
157 2017-07-07T12:05:10  *** afk11 has quit IRC
158 2017-07-07T12:05:10  *** arubi has quit IRC
159 2017-07-07T12:07:32  *** afk11 has joined #bitcoin-core-dev
160 2017-07-07T12:08:06  *** dabura667_ has quit IRC
161 2017-07-07T12:10:11  *** arubi has joined #bitcoin-core-dev
162 2017-07-07T12:17:19  <wumpus> HTTPReq_JSONRPC is part of libbitcoin_server_a, which is valid to be used from wallet code
163 2017-07-07T12:17:23  <wumpus> I don't get the error either
164 2017-07-07T12:18:39  <jonasschnelli> Also have it on my Trusty 14.04 VM with gcc
165 2017-07-07T12:19:01  <jonasschnelli> maybe a bug with the function typedef
166 2017-07-07T12:19:22  <jonasschnelli> Question: what to do with the hybrid rpc calls (in terms of untangling the endpoints)...
167 2017-07-07T12:19:28  <wumpus> well the circular dependency between libbitcoin_server and libbitcoin_wallet, as you say
168 2017-07-07T12:20:04  <jonasschnelli> Example: I have set now signrawtx to the /v1/node side... but somehow you also want to be able to choose the wallet used for that call..
169 2017-07-07T12:20:09  <wumpus> I'd just ignore getinfo for the endpoints, we want to deprecate that anyway
170 2017-07-07T12:20:25  <wumpus> signrawtx maybe put it both on the node endpoint as the wallet endpoints?
171 2017-07-07T12:20:31  <wumpus> I don't know
172 2017-07-07T12:20:32  <jonasschnelli> Yes. Think so.
173 2017-07-07T12:20:46  <jonasschnelli> Maybe endpoint = "/v1/*" for now
174 2017-07-07T12:22:40  *** Guyver2 has joined #bitcoin-core-dev
175 2017-07-07T12:25:10  <jonasschnelli> The linker error: it's only test_bitcoin that has the linker error
176 2017-07-07T12:33:31  <wumpus> does test_bitcoin somehow link in a different order?
177 2017-07-07T12:38:36  <jonasschnelli> I don't know. Could it be some boost internal fixture template thing?
178 2017-07-07T12:39:01  <jonasschnelli> I guess no
179 2017-07-07T12:40:34  <jonasschnelli> wumpus: does the link order matters? see: https://0bin.net/paste/YVZoBu2vaap8-chr#wW2b3kICZ5rpRwZwvsTpxWJDeFIbrLM3Ng9OQYi24dY
180 2017-07-07T12:44:02  <jonasschnelli> wumpus: the only thing thats may be different for test_bitcoin is that we pass in a --static (but should not matter IMO)
181 2017-07-07T12:50:37  <bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10764: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10764
182 2017-07-07T12:54:59  *** coredump_ has quit IRC
183 2017-07-07T13:03:37  *** rafalcpp has joined #bitcoin-core-dev
184 2017-07-07T13:11:27  <bitcoin-git> [bitcoin] fanquake closed pull request #10764: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10764
185 2017-07-07T13:11:59  *** Dyaheon has quit IRC
186 2017-07-07T13:12:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
187 2017-07-07T13:13:16  *** Dyaheon has joined #bitcoin-core-dev
188 2017-07-07T13:39:16  *** JackH has quit IRC
189 2017-07-07T13:49:43  <wumpus> link order matters, when linking static libraries. The libraries that need symbols should come before the library it needs symbols from
190 2017-07-07T13:50:54  <wumpus> so the most general libraries (such as utilities etc) should end up last, the more specific ones first. This is complicated by circular dependencies, in which case it's pretty much a gamble whether it works.
191 2017-07-07T13:51:24  <wumpus> (it's linker dependent, so it makes sense that you see differences between OSes)
192 2017-07-07T13:52:39  *** Cheeseo has joined #bitcoin-core-dev
193 2017-07-07T14:00:10  <jonasschnelli> wumpus: oh, if I move $(LIBBITCOIN_WALLET) in front of $(LIBBITCOIN_SERVER) (in test_bitcoin) it works...
194 2017-07-07T14:16:55  <bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10765: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10765
195 2017-07-07T14:26:44  *** talmai has joined #bitcoin-core-dev
196 2017-07-07T14:31:08  *** Giszmo has joined #bitcoin-core-dev
197 2017-07-07T14:35:31  *** Cheeseo has quit IRC
198 2017-07-07T14:37:06  *** talmai has quit IRC
199 2017-07-07T14:40:02  *** d9b4bef9 has quit IRC
200 2017-07-07T14:41:08  *** d9b4bef9 has joined #bitcoin-core-dev
201 2017-07-07T14:42:02  *** d9b4bef9 has quit IRC
202 2017-07-07T14:43:14  *** d9b4bef9 has joined #bitcoin-core-dev
203 2017-07-07T14:43:44  *** talmai has joined #bitcoin-core-dev
204 2017-07-07T14:44:36  <jonasschnelli> Passes travis now https://github.com/bitcoin/bitcoin/pull/10650/commits/386c299270cd955aebc7984b319805ac7403e906
205 2017-07-07T14:48:45  <wumpus> great!
206 2017-07-07T14:52:13  *** Cheeseo has joined #bitcoin-core-dev
207 2017-07-07T14:52:27  *** belcher_ has quit IRC
208 2017-07-07T14:53:45  *** talmai has quit IRC
209 2017-07-07T14:55:00  *** belcher has joined #bitcoin-core-dev
210 2017-07-07T14:57:46  *** talmai has joined #bitcoin-core-dev
211 2017-07-07T15:00:26  <bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10766: Building Environment: Set ARFLAGS to cr (master...ARFLAGS) https://github.com/bitcoin/bitcoin/pull/10766
212 2017-07-07T15:00:28  <jonasschnelli> wumpus: have you made any thought on #10251? Should I reduce it to the CWallet only cache (remove the GUI stuff)?
213 2017-07-07T15:00:30  <gribble> https://github.com/bitcoin/bitcoin/issues/10251 | Add balances cache / GUI: use a signal instead of a poll thread by jonasschnelli · Pull Request #10251 · bitcoin/bitcoin · GitHub
214 2017-07-07T15:00:39  *** riemann has quit IRC
215 2017-07-07T15:01:56  *** Murch has joined #bitcoin-core-dev
216 2017-07-07T15:05:13  <bitcoin-git> [bitcoin] jnewbery opened pull request #10767: Clarify wallet initialization / destruction interface (master...walletinit2) https://github.com/bitcoin/bitcoin/pull/10767
217 2017-07-07T15:07:31  *** chjj has quit IRC
218 2017-07-07T15:20:33  *** chjj has joined #bitcoin-core-dev
219 2017-07-07T15:22:35  *** Dizzle has joined #bitcoin-core-dev
220 2017-07-07T15:23:57  *** bincap has quit IRC
221 2017-07-07T15:34:07  <bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10768: Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp (master...init-nStart) https://github.com/bitcoin/bitcoin/pull/10768
222 2017-07-07T15:39:27  *** vicenteH has quit IRC
223 2017-07-07T15:48:31  *** jtimon has joined #bitcoin-core-dev
224 2017-07-07T15:49:43  *** ivan has joined #bitcoin-core-dev
225 2017-07-07T16:36:00  *** ProfMac_ has quit IRC
226 2017-07-07T16:40:29  *** talmai has quit IRC
227 2017-07-07T16:41:43  *** BashCo has joined #bitcoin-core-dev
228 2017-07-07T16:42:24  *** ProfMac has quit IRC
229 2017-07-07T16:44:28  *** ProfMac has joined #bitcoin-core-dev
230 2017-07-07T16:47:54  *** spudowiar has joined #bitcoin-core-dev
231 2017-07-07T16:53:11  *** str4d has joined #bitcoin-core-dev
232 2017-07-07T16:58:18  *** timothy has quit IRC
233 2017-07-07T17:03:11  <spudowiar> What's the best way to check if a CTransaction is the same, apart from any scriptSigs?
234 2017-07-07T17:03:20  <spudowiar> e.g. Compare a signed transaction to an unsigned transaction
235 2017-07-07T17:04:12  *** Dyaheon has quit IRC
236 2017-07-07T17:04:45  <instagibbs> spudowiar, strip scriptsig/witness data and compare
237 2017-07-07T17:05:05  *** str4d has quit IRC
238 2017-07-07T17:07:05  *** Dyaheon has joined #bitcoin-core-dev
239 2017-07-07T17:09:22  *** BashCo has quit IRC
240 2017-07-07T17:16:42  *** BashCo has joined #bitcoin-core-dev
241 2017-07-07T17:17:04  *** chjj has quit IRC
242 2017-07-07T17:31:36  *** ProfMac has quit IRC
243 2017-07-07T17:35:49  *** laurentmt has joined #bitcoin-core-dev
244 2017-07-07T17:36:46  *** vicenteH has joined #bitcoin-core-dev
245 2017-07-07T17:39:13  <instagibbs> anyone know a good trick to figure out where bitcoind is spending it's time in? gdb attaching just gets me to the WaitForShutdown loop
246 2017-07-07T17:39:40  <instagibbs> looking at valgrind's callgrind but not sure if that's the right tool for what I'm looking for
247 2017-07-07T17:41:48  <gmaxwell> instagibbs: you're hung on shutdown and trying to find out where or?
248 2017-07-07T17:42:02  <gmaxwell> instagibbs: are you looking at all threads when you connect with gdb?
249 2017-07-07T17:42:09  <sipa> threall apply all bt
250 2017-07-07T17:42:12  <instagibbs> no, spikes in cpu usage fairly consistently on one machine
251 2017-07-07T17:42:16  <gmaxwell> thread apply all bt
252 2017-07-07T17:42:18  <instagibbs> sipa, thanks just found via googling
253 2017-07-07T17:44:01  *** chjj has joined #bitcoin-core-dev
254 2017-07-07T17:47:39  *** Guest5641 is now known as haakonn
255 2017-07-07T17:47:42  *** haakonn has joined #bitcoin-core-dev
256 2017-07-07T17:56:09  <midnightmagic> hrm. I thought there was another shortcut for that command.. like bt all or something.
257 2017-07-07T17:56:30  *** Giszmo has quit IRC
258 2017-07-07T17:59:07  *** Aaronvan_ has joined #bitcoin-core-dev
259 2017-07-07T18:02:04  *** AaronvanW has quit IRC
260 2017-07-07T18:02:35  *** bit_lySLH2uSZHed has joined #bitcoin-core-dev
261 2017-07-07T18:02:45  *** bit_lySLH2uSZHed has left #bitcoin-core-dev
262 2017-07-07T18:10:28  *** Cheeseo has quit IRC
263 2017-07-07T18:20:59  <spudowiar> instagibbs: Is there a utility function to do that or must I write it myself? :)
264 2017-07-07T18:22:07  *** chjj has quit IRC
265 2017-07-07T18:22:49  <instagibbs> don't think there's a utility function, although you could make one and upstream it for use in various places.
266 2017-07-07T18:23:43  <spudowiar> I'll leave it for now. But I want to add it later to check whether the hardware wallet returned the correct transaction
267 2017-07-07T18:24:51  *** arowser has quit IRC
268 2017-07-07T18:31:18  *** arowser has joined #bitcoin-core-dev
269 2017-07-07T18:35:00  *** chjj has joined #bitcoin-core-dev
270 2017-07-07T18:49:34  *** marcoagn1 has joined #bitcoin-core-dev
271 2017-07-07T18:50:09  *** marcoagner has quit IRC
272 2017-07-07T19:02:31  *** spudowiar has quit IRC
273 2017-07-07T19:02:44  *** Aaronvan_ has quit IRC
274 2017-07-07T19:09:06  *** AaronvanW has joined #bitcoin-core-dev
275 2017-07-07T19:12:18  *** abpa has joined #bitcoin-core-dev
276 2017-07-07T19:28:03  <jonasschnelli> Hmm.. why does the Gui still changes the global payTxFee when fiddling with the fee slider? I though we have fixed this,.. or is this intentional?
277 2017-07-07T19:28:49  <jonasschnelli> Maybe correct: we just set it to 0 when smartFees (the slider -> estimations) are enabled.
278 2017-07-07T19:59:52  <BlueMatt> oh shit #10651 needs to go for 15... sipa what are your thoughts on loop/array/shell garbage?
279 2017-07-07T19:59:53  <gribble> https://github.com/bitcoin/bitcoin/issues/10651 | Verify binaries from bitcoincore.org and bitcoin.org by TheBlueMatt · Pull Request #10651 · bitcoin/bitcoin · GitHub
280 2017-07-07T20:07:07  *** timothy has joined #bitcoin-core-dev
281 2017-07-07T20:08:18  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets (master...2017/07/qt_fee_slider) https://github.com/bitcoin/bitcoin/pull/10769
282 2017-07-07T20:09:12  <jonasschnelli> Added 0.15 milestone to 10651
283 2017-07-07T20:19:03  *** SopaXorzTaker has quit IRC
284 2017-07-07T20:19:53  *** Giszmo has joined #bitcoin-core-dev
285 2017-07-07T20:52:58  *** timothy has quit IRC
286 2017-07-07T20:53:29  *** laurentmt has quit IRC
287 2017-07-07T20:59:42  *** laurentmt has joined #bitcoin-core-dev
288 2017-07-07T21:07:16  *** BashCo has quit IRC
289 2017-07-07T21:07:53  *** BashCo has joined #bitcoin-core-dev
290 2017-07-07T21:12:01  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10770: Drop upgrade-cancel callback registration for a generic "cancelable" (master...2017-07-upgrade-cancel-nits) https://github.com/bitcoin/bitcoin/pull/10770
291 2017-07-07T21:23:37  *** laurentmt has quit IRC
292 2017-07-07T21:27:00  *** str4d has joined #bitcoin-core-dev
293 2017-07-07T21:29:39  *** str4d has quit IRC
294 2017-07-07T21:36:30  *** chjj has quit IRC
295 2017-07-07T21:41:21  *** Chris_Stewart_5 has quit IRC
296 2017-07-07T21:48:23  *** Cheeseo has joined #bitcoin-core-dev
297 2017-07-07T21:49:10  *** chjj has joined #bitcoin-core-dev
298 2017-07-07T21:57:39  *** Guyver2 has quit IRC
299 2017-07-07T22:17:53  <bitcoin-git> [bitcoin] practicalswift opened pull request #10771: Remove unused variables in shell scripts (master...unused-shell-variables) https://github.com/bitcoin/bitcoin/pull/10771
300 2017-07-07T22:21:49  *** spinza has quit IRC
301 2017-07-07T22:28:31  *** spinza has joined #bitcoin-core-dev
302 2017-07-07T22:30:11  *** Dizzle has quit IRC
303 2017-07-07T22:40:29  *** cheese_ has joined #bitcoin-core-dev
304 2017-07-07T22:41:57  *** spudowiar has joined #bitcoin-core-dev
305 2017-07-07T22:42:13  <spudowiar> Right, I'm going to have to change a lot of the RPC stuff to support hardware wallets
306 2017-07-07T22:43:05  *** Cheeseo has quit IRC
307 2017-07-07T22:44:18  *** abpa has quit IRC
308 2017-07-07T22:44:21  *** spudowiar has quit IRC
309 2017-07-07T22:51:25  *** chjj has quit IRC
310 2017-07-07T23:01:08  *** Guest2 has joined #bitcoin-core-dev
311 2017-07-07T23:02:03  *** Guest2 has quit IRC
312 2017-07-07T23:03:04  *** chjj has joined #bitcoin-core-dev
313 2017-07-07T23:12:44  *** RoyceX has quit IRC
314 2017-07-07T23:12:58  *** RoyceX has joined #bitcoin-core-dev
315 2017-07-07T23:15:43  *** vicenteH has quit IRC
316 2017-07-07T23:30:26  *** echonaut5 has quit IRC
317 2017-07-07T23:30:43  *** echonaut has joined #bitcoin-core-dev
318 2017-07-07T23:43:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
319 2017-07-07T23:49:17  *** clarkmoody has quit IRC
320 2017-07-07T23:49:42  *** clarkmoody has joined #bitcoin-core-dev