1 2017-07-16T00:00:09  *** PRab has joined #bitcoin-core-dev
  2 2017-07-16T00:00:33  *** davec has quit IRC
  3 2017-07-16T00:06:37  *** davec has joined #bitcoin-core-dev
  4 2017-07-16T00:11:12  <sipa> BlueMatt: i'm not
  5 2017-07-16T00:12:30  *** davec has quit IRC
  6 2017-07-16T00:13:07  <bitcoin-git> [bitcoin] practicalswift opened pull request #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.). (master...dont-pass-by-reference-for-cheaply-copied-types) https://github.com/bitcoin/bitcoin/pull/10839
  7 2017-07-16T00:13:27  *** nemgun1 has quit IRC
  8 2017-07-16T00:21:21  <fanquake> sipa same issue as before. Assertion failed: (consensus.hashGenesisBlock etc
  9 2017-07-16T00:22:44  <sipa> fanquake: ok, thank you
 10 2017-07-16T00:26:49  *** luke-jr has quit IRC
 11 2017-07-16T00:27:21  <bitcoin-git> [bitcoin] practicalswift opened pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840
 12 2017-07-16T00:37:40  *** luke-jr has joined #bitcoin-core-dev
 13 2017-07-16T00:46:22  *** goatpig has quit IRC
 14 2017-07-16T00:49:58  *** roidster has joined #bitcoin-core-dev
 15 2017-07-16T01:07:04  *** AsadSalman has joined #bitcoin-core-dev
 16 2017-07-16T01:08:09  <AsadSalman> Hi
 17 2017-07-16T01:08:32  <AsadSalman> I'm working in the bitcoin core, trying to get the amount of a transaction sent into the mempool
 18 2017-07-16T01:08:59  <AsadSalman> I'm logging all entries (working on regtestnet, btw)
 19 2017-07-16T01:09:40  <AsadSalman> http://imgur.com/a/olCNk
 20 2017-07-16T01:10:08  <AsadSalman> I am able to get a value out (as you can see in the screenshot)
 21 2017-07-16T01:10:21  <AsadSalman> but that is a sum of both CTxOut
 22 2017-07-16T01:10:58  <AsadSalman> I only want the amount I spent (which was 10BTC, i.e. 1,000,000,000 satoshi)
 23 2017-07-16T01:11:25  <AsadSalman> I don't know what the other CTxOut that is getting summed in is, and how do I get rid of it in the final sum?
 24 2017-07-16T01:11:32  <sipa> it's change
 25 2017-07-16T01:11:55  <AsadSalman> change? I'm not sure what you mean, could you elaborate?
 26 2017-07-16T01:12:04  <sipa> not here, try bitcoin.stackexchange.com
 27 2017-07-16T01:12:11  <sipa> or #bitcoin
 28 2017-07-16T01:12:44  <AsadSalman> okay! (sorry, I thought this would be an appropriate place to ask about core)
 29 2017-07-16T01:13:09  <sipa> your question is about how bitcoin transactions work
 30 2017-07-16T01:27:42  *** Murch has joined #bitcoin-core-dev
 31 2017-07-16T01:30:55  *** Murchone has joined #bitcoin-core-dev
 32 2017-07-16T01:31:10  *** Murch has quit IRC
 33 2017-07-16T01:35:46  *** Murchone has quit IRC
 34 2017-07-16T01:37:37  *** chjj has joined #bitcoin-core-dev
 35 2017-07-16T01:38:00  *** jamesob_ has joined #bitcoin-core-dev
 36 2017-07-16T01:39:13  *** jamesob has quit IRC
 37 2017-07-16T01:50:54  *** Ylbam has quit IRC
 38 2017-07-16T01:59:07  *** davec has joined #bitcoin-core-dev
 39 2017-07-16T02:04:31  *** sanada has joined #bitcoin-core-dev
 40 2017-07-16T02:07:17  *** AsadSalman has quit IRC
 41 2017-07-16T02:08:50  *** Murch has joined #bitcoin-core-dev
 42 2017-07-16T02:09:56  *** Murch has quit IRC
 43 2017-07-16T02:16:57  *** chjj has quit IRC
 44 2017-07-16T02:21:52  *** Chris_Stewart_5 has quit IRC
 45 2017-07-16T02:36:39  *** jamesob_ has quit IRC
 46 2017-07-16T02:37:14  *** jamesob has joined #bitcoin-core-dev
 47 2017-07-16T02:41:54  *** Murch has joined #bitcoin-core-dev
 48 2017-07-16T02:42:48  *** str4d has joined #bitcoin-core-dev
 49 2017-07-16T02:43:04  *** Murch has quit IRC
 50 2017-07-16T02:47:22  <gmaxwell> BlueMatt: on 10831 please review the rebase carefully, I'm sick and wouldn't even have done the rebase today but for merge window urgency.
 51 2017-07-16T02:59:23  *** Murch has joined #bitcoin-core-dev
 52 2017-07-16T03:04:47  *** Murch has quit IRC
 53 2017-07-16T03:16:32  *** Murch has joined #bitcoin-core-dev
 54 2017-07-16T03:19:35  *** Murch has quit IRC
 55 2017-07-16T03:31:26  *** justan0theruser has joined #bitcoin-core-dev
 56 2017-07-16T03:34:34  *** justanotheruser has quit IRC
 57 2017-07-16T03:46:55  *** justan0theruser has quit IRC
 58 2017-07-16T03:47:16  *** justanotheruser has joined #bitcoin-core-dev
 59 2017-07-16T03:49:37  *** blzin2 has joined #bitcoin-core-dev
 60 2017-07-16T03:51:08  *** handlex has joined #bitcoin-core-dev
 61 2017-07-16T03:56:03  *** blzin2 has quit IRC
 62 2017-07-16T03:58:28  <cfields> sipa: still crashes :(
 63 2017-07-16T03:58:44  *** wallet42 has quit IRC
 64 2017-07-16T03:58:46  *** robby938 has quit IRC
 65 2017-07-16T03:59:49  <cfields> sipa: i managed to get lldb to step into the asm, but it doesn't show me where I am when i single-step instructions, only that I'm in the asm block. So i have to step 1 instruction at a time and dump registers
 66 2017-07-16T04:00:49  <cfields> the explicit assignments will help though, since now I'll know where I'm looking
 67 2017-07-16T04:01:38  *** rubensayshi has quit IRC
 68 2017-07-16T04:03:03  *** Dyaheon has quit IRC
 69 2017-07-16T04:03:08  <sipa> cfields: so you do reach the asm block?
 70 2017-07-16T04:03:20  <sipa> can you count how many instructions inside you execute?
 71 2017-07-16T04:03:27  <cfields> sipa: yea, and past the zero-size check
 72 2017-07-16T04:04:54  <cfields> sipa: yea, i can do that. the recent changes should make it much easier, i'll poke some more
 73 2017-07-16T04:05:24  *** Dyaheon has joined #bitcoin-core-dev
 74 2017-07-16T04:10:42  <sipa> cfields: thanks for all the time you're spending on thid
 75 2017-07-16T04:11:18  <cfields> sipa: np. it's a big boost.
 76 2017-07-16T04:12:27  <sipa> cfields: for IBD it seems a 200-300 second reduction to block 450k
 77 2017-07-16T04:12:58  <sipa> at the tip the impact is probably larger, but harder to benchmark
 78 2017-07-16T04:14:03  <cfields> wow
 79 2017-07-16T04:14:29  *** chjj has joined #bitcoin-core-dev
 80 2017-07-16T04:14:50  *** blznblzn2 has joined #bitcoin-core-dev
 81 2017-07-16T04:15:22  <cfields> net-side will benefit at the tip too, though probably not enough to be relevant
 82 2017-07-16T04:15:49  <cfields> sipa: gcc docs says the value of inputs isn't allowed to change. i suppose values of pointers passed in are ok though?
 83 2017-07-16T04:16:09  <sipa> cfields: the only inputs are constants
 84 2017-07-16T04:16:24  <sipa> everything else is marked as an output
 85 2017-07-16T04:16:33  *** str4d has quit IRC
 86 2017-07-16T04:17:28  <cfields> oh right, nm
 87 2017-07-16T04:18:01  <gmaxwell> sha-ni is a bigger boost.
 88 2017-07-16T04:18:14  <sipa> yes, far larger
 89 2017-07-16T04:18:20  <sipa> close to 1000s reduction
 90 2017-07-16T04:18:32  <sipa> more like 800s
 91 2017-07-16T04:18:43  <sipa> (compared to master)
 92 2017-07-16T04:19:59  *** rubensayshi has joined #bitcoin-core-dev
 93 2017-07-16T04:20:16  <gmaxwell> cfields: I expect even just sse4 to make a very measurable improvement in compact block relay... that is mostly bottlenecked on sha2...
 94 2017-07-16T04:20:33  *** davec has quit IRC
 95 2017-07-16T04:21:15  <cfields> whoa
 96 2017-07-16T04:22:47  <cfields> have you benchmarked any benefit to adding a dedicated sha2d?
 97 2017-07-16T04:25:10  <sipa> cfields: can you show another disasm?
 98 2017-07-16T04:25:52  <gmaxwell> haven't though if we want further benefit I think what we really want is a hash tree that hashes multiple things at once,  parallel sse4 sha2 is significantly faster than one at a time... and it even looks like for sha-ni for max throughput you want to do at least two at a time.
 99 2017-07-16T04:27:12  <cfields> gmaxwell: yea, i was reading that paper (one of many?) yesterday
100 2017-07-16T04:27:16  <cfields> sipa: https://pastebin.com/raw/jY0EGwDB
101 2017-07-16T04:27:46  <cfields> stepping through it now
102 2017-07-16T04:28:23  <cfields> sipa: note that i haven't hand-modified any flags for that one, so the stack protector is in place where it hasn't been in other dumps
103 2017-07-16T04:29:59  <sipa> i can see
104 2017-07-16T04:30:03  <sipa> that
105 2017-07-16T04:32:51  *** chjj has quit IRC
106 2017-07-16T04:34:36  <sipa> cfields: during the entire execution, the rdi register should contain a pointer to the SHA256 state
107 2017-07-16T04:34:40  <sipa> and it should never change
108 2017-07-16T04:35:42  <sipa> there is not a single instruction in your disasm that modifies that register, so far so good
109 2017-07-16T04:36:07  <sipa> so the question is... is rdi actually pointing to the state?
110 2017-07-16T04:36:21  <gmaxwell> sipa: you could try taking cfields disasm and monkey patching it into a binary to try to reproduce he failure.
111 2017-07-16T04:36:47  <sipa> gmaxwell: nontrivial... linking information would be lost
112 2017-07-16T04:36:50  <cfields> sipa: actually, hold on. linker stuck a bunch of nops in the final binary...
113 2017-07-16T04:37:07  <cfields> let met give you a dump of that rather than a dump of just the object
114 2017-07-16T04:37:13  <sipa> cfields: ah, yes!
115 2017-07-16T04:37:36  <gmaxwell> linker replaced the object with foldgers crystals,  turns out we noticed.
116 2017-07-16T04:38:35  *** davec has joined #bitcoin-core-dev
117 2017-07-16T04:38:59  <cfields> uhmm, wtf
118 2017-07-16T04:39:31  <sipa> the linker replaced the object with foldgers crystals?
119 2017-07-16T04:39:44  <cfields> ok, i don't trust myself enough here to be a proxy debugger...
120 2017-07-16T04:39:48  <cfields> sec
121 2017-07-16T04:41:13  <cfields> I'm just going to send you the whole dasm. Got anywhere convenient for a 58mb text dump?
122 2017-07-16T04:42:30  <sipa> sure
123 2017-07-16T04:42:36  <sipa> mail?
124 2017-07-16T04:46:30  *** handlex has quit IRC
125 2017-07-16T04:47:44  <midnightmagic> lol
126 2017-07-16T04:49:35  *** corebob has joined #bitcoin-core-dev
127 2017-07-16T04:55:26  *** blznblzn2 has quit IRC
128 2017-07-16T04:56:05  *** blznblzn2 has joined #bitcoin-core-dev
129 2017-07-16T05:06:06  <sipa> gmaxwell: your foldgers crystals guess is surprisingly accurate
130 2017-07-16T05:09:19  <cfields> bingo!
131 2017-07-16T05:09:22  <cfields> got it.
132 2017-07-16T05:10:11  <sipa> oh?
133 2017-07-16T05:11:10  <cfields> now to figure out why :)
134 2017-07-16T05:11:11  <cfields> -Wl,-dead_strip
135 2017-07-16T05:11:49  <cfields> it's weird that if it's going to strip it, it doesn't strip the whole thing though
136 2017-07-16T05:12:44  <cfields> (to be clear, we use -Wl,-dead_strip by default. With that removed, it runs as expected)
137 2017-07-16T05:15:08  <sipa> cfields: give local labels a name that starts with L
138 2017-07-16T05:15:23  <sipa> that way the linker treats them as local labels rather than separate functions
139 2017-07-16T05:18:46  <cfields> sipa: works!
140 2017-07-16T05:19:30  <sipa> http://www.galloway.me.uk/2011/03/assembly-beware-local-label-names-with-dead_strip-option/
141 2017-07-16T05:19:36  <sipa> i found thst
142 2017-07-16T05:20:04  <cfields> hah! well that was some easy googling for once :)
143 2017-07-16T05:24:03  <cfields> sipa: do you see that documented anywhere?
144 2017-07-16T05:24:24  <sipa> nope
145 2017-07-16T05:27:09  *** roidster has quit IRC
146 2017-07-16T05:28:34  <bitcoin-git> [bitcoin] jnewbery opened pull request #10841: [rpc] Give users one final warning before depracating getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
147 2017-07-16T05:30:35  <cfields> sipa: https://sourceware.org/binutils/docs/as/Symbol-Names.html#Symbol-Names
148 2017-07-16T05:33:44  <sipa> ah
149 2017-07-16T05:36:04  <cfields> sipa: maybe safer to use digits instead, then? Reading the docs like a pedant, I assume some future linker could break win32 the same way.
150 2017-07-16T05:40:11  *** discreteunit has joined #bitcoin-core-dev
151 2017-07-16T05:44:35  <cfields> nope, that's crashy too
152 2017-07-16T06:22:37  <sipa> cfields: so, latest PR version works?
153 2017-07-16T06:24:15  <cfields> sipa: i don't think so, i think that matches what i tried
154 2017-07-16T06:24:33  <sipa> ?
155 2017-07-16T06:24:44  <cfields> sipa: i misread the docs, look at their example
156 2017-07-16T06:25:01  <cfields> "So for example, the first 1: may be named .L1C-B1, and the 44th 3: may be named .L3C-B44."
157 2017-07-16T06:25:25  <sipa> A local symbol is any symbol beginning with certain local label prefixes. By default, the local label prefix is `.L' for ELF systems or `L' for traditional a.out systems, but each target may have its own set of local label prefixes.
158 2017-07-16T06:25:32  <cfields> apparently the numbers aren't a replacement for the L prefix
159 2017-07-16T06:25:53  <sipa> you're looking at automatically generated names
160 2017-07-16T06:26:03  *** Squidicc has quit IRC
161 2017-07-16T06:26:10  <sipa> we don't need that; the asm syntax's %= guaranrees uniqueness already
162 2017-07-16T06:28:04  *** SopaXorzTaker has joined #bitcoin-core-dev
163 2017-07-16T06:28:37  <cfields> sipa: sorry, misread the diff
164 2017-07-16T06:29:33  <sipa> it won't work, i forgot to rename the jumps
165 2017-07-16T06:29:45  <cfields> yep, with those renamed, all good
166 2017-07-16T06:29:48  *** chjj has joined #bitcoin-core-dev
167 2017-07-16T06:39:18  <phantomcircuit> gmaxwell, btw when i did the walletdb stuff i was doing CWalletDB *pwalletdb=NULL and then initializing pwalletdb only if it was null instead of creating a new function
168 2017-07-16T07:05:36  *** discreteunit has quit IRC
169 2017-07-16T07:11:46  *** Ylbam has joined #bitcoin-core-dev
170 2017-07-16T07:13:52  *** Squidicuz has joined #bitcoin-core-dev
171 2017-07-16T07:14:06  *** Squidicuz has joined #bitcoin-core-dev
172 2017-07-16T08:27:29  *** afk11 has quit IRC
173 2017-07-16T08:45:25  *** RUrsu has joined #bitcoin-core-dev
174 2017-07-16T08:45:57  *** RUrsu has left #bitcoin-core-dev
175 2017-07-16T08:49:23  *** mryandao has joined #bitcoin-core-dev
176 2017-07-16T08:52:58  *** blznblzn2 has quit IRC
177 2017-07-16T09:09:24  *** SopaXorzTaker has quit IRC
178 2017-07-16T09:19:40  *** mmgen has joined #bitcoin-core-dev
179 2017-07-16T09:25:22  *** jtimon has joined #bitcoin-core-dev
180 2017-07-16T09:49:21  *** chjj has quit IRC
181 2017-07-16T09:50:01  *** d9b4bef9 has quit IRC
182 2017-07-16T09:51:16  *** d9b4bef9 has joined #bitcoin-core-dev
183 2017-07-16T10:06:51  *** corebob has quit IRC
184 2017-07-16T10:22:42  <bitcoin-git> [bitcoin] practicalswift opened pull request #10842: Fix incorrect Doxygen tag (@ince → @since) (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
185 2017-07-16T10:43:49  *** goatpig has joined #bitcoin-core-dev
186 2017-07-16T10:58:39  *** jtimon has quit IRC
187 2017-07-16T11:20:51  *** arowser has quit IRC
188 2017-07-16T11:27:00  *** arowser has joined #bitcoin-core-dev
189 2017-07-16T11:51:29  *** belcher has quit IRC
190 2017-07-16T11:55:47  *** belcher has joined #bitcoin-core-dev
191 2017-07-16T12:00:19  *** marcoagner has quit IRC
192 2017-07-16T12:00:46  *** marcoagner has joined #bitcoin-core-dev
193 2017-07-16T12:36:55  *** AaronvanW has joined #bitcoin-core-dev
194 2017-07-16T13:03:12  *** vicenteH has quit IRC
195 2017-07-16T13:04:52  *** CubicEarth has joined #bitcoin-core-dev
196 2017-07-16T13:07:43  <bitcoin-git> [bitcoin] practicalswift opened pull request #10843: Add attribute [[noreturn]] (C++11) to functions that will not return (master...noreturn) https://github.com/bitcoin/bitcoin/pull/10843
197 2017-07-16T13:09:50  *** SopaXorzTaker has joined #bitcoin-core-dev
198 2017-07-16T13:10:47  *** marcoagner has quit IRC
199 2017-07-16T13:20:48  *** hsmiths has quit IRC
200 2017-07-16T13:23:04  *** marcoagner has joined #bitcoin-core-dev
201 2017-07-16T13:28:53  *** belcher has quit IRC
202 2017-07-16T13:30:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
203 2017-07-16T13:31:52  *** laurentmt has joined #bitcoin-core-dev
204 2017-07-16T13:32:01  *** laurentmt has quit IRC
205 2017-07-16T13:39:15  *** belcher has joined #bitcoin-core-dev
206 2017-07-16T13:40:17  *** CubicEarth has quit IRC
207 2017-07-16T13:40:46  *** CubicEarth has joined #bitcoin-core-dev
208 2017-07-16T13:42:43  *** Guyver2 has joined #bitcoin-core-dev
209 2017-07-16T13:45:13  *** CubicEarth has quit IRC
210 2017-07-16T13:48:34  *** terjegun has joined #bitcoin-core-dev
211 2017-07-16T13:48:52  <terjegun> Hello! I was wondering, is there any reward for contributing translations to the project?
212 2017-07-16T13:50:13  <Lauda> No.
213 2017-07-16T13:50:38  <instagibbs> terjegun, satisfaction in knowing you helped others?
214 2017-07-16T13:53:00  *** terjegun has quit IRC
215 2017-07-16T13:55:10  <bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844
216 2017-07-16T13:58:08  *** CubicEarth has joined #bitcoin-core-dev
217 2017-07-16T14:02:35  *** CubicEarth has joined #bitcoin-core-dev
218 2017-07-16T14:08:18  *** vicenteH has joined #bitcoin-core-dev
219 2017-07-16T14:08:42  *** hsmiths has joined #bitcoin-core-dev
220 2017-07-16T14:19:44  *** Dyaheon has quit IRC
221 2017-07-16T14:21:44  *** Dyaheon has joined #bitcoin-core-dev
222 2017-07-16T14:23:56  *** CubicEarth has quit IRC
223 2017-07-16T15:17:58  *** harrymm has quit IRC
224 2017-07-16T15:34:06  *** fanquake has left #bitcoin-core-dev
225 2017-07-16T15:37:50  *** harrymm has joined #bitcoin-core-dev
226 2017-07-16T15:38:00  *** [b__b] has quit IRC
227 2017-07-16T16:18:07  *** Chris_Stewart_5 has quit IRC
228 2017-07-16T16:24:38  *** BashCo has quit IRC
229 2017-07-16T16:25:23  *** BashCo has joined #bitcoin-core-dev
230 2017-07-16T16:32:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
231 2017-07-16T16:47:34  *** sdaftuar has quit IRC
232 2017-07-16T16:47:34  *** zxzzt has quit IRC
233 2017-07-16T16:47:47  *** morcos has quit IRC
234 2017-07-16T16:49:00  *** zxzzt has joined #bitcoin-core-dev
235 2017-07-16T16:49:07  *** sdaftuar has joined #bitcoin-core-dev
236 2017-07-16T16:49:23  *** morcos has joined #bitcoin-core-dev
237 2017-07-16T16:49:56  <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
238 2017-07-16T17:10:31  *** mmgen has quit IRC
239 2017-07-16T17:16:11  *** deep-book-gk_ has joined #bitcoin-core-dev
240 2017-07-16T17:18:29  *** deep-book-gk_ has left #bitcoin-core-dev
241 2017-07-16T17:20:55  *** Aaronvan_ has joined #bitcoin-core-dev
242 2017-07-16T17:21:31  *** AaronvanW has quit IRC
243 2017-07-16T17:27:00  *** Cheeseo has joined #bitcoin-core-dev
244 2017-07-16T17:30:24  *** RoyceX has joined #bitcoin-core-dev
245 2017-07-16T17:33:30  *** Cheeseo has quit IRC
246 2017-07-16T17:37:11  *** [b__b] has joined #bitcoin-core-dev
247 2017-07-16T17:37:28  *** chjj has joined #bitcoin-core-dev
248 2017-07-16T17:38:05  *** mmgen has joined #bitcoin-core-dev
249 2017-07-16T17:39:36  *** AdrianG is now known as Aleph0
250 2017-07-16T17:40:33  *** harrymm has quit IRC
251 2017-07-16T17:44:20  <bitcoin-git> [bitcoin] practicalswift opened pull request #10845: Remove unreachable code (master...remove-unreachable-code) https://github.com/bitcoin/bitcoin/pull/10845
252 2017-07-16T17:50:13  *** mmgen has quit IRC
253 2017-07-16T17:54:25  *** Chris_Stewart_5 has quit IRC
254 2017-07-16T17:59:27  *** harrymm has joined #bitcoin-core-dev
255 2017-07-16T18:03:33  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846
256 2017-07-16T18:04:49  *** BashCo has quit IRC
257 2017-07-16T18:05:27  *** BashCo has joined #bitcoin-core-dev
258 2017-07-16T18:21:36  *** Murch has joined #bitcoin-core-dev
259 2017-07-16T18:24:57  <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846
260 2017-07-16T18:32:23  *** laurentmt has joined #bitcoin-core-dev
261 2017-07-16T18:36:53  *** Murch has quit IRC
262 2017-07-16T18:48:09  *** bincap has joined #bitcoin-core-dev
263 2017-07-16T18:51:14  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cfdda2503c9...ef37f2033c4a
264 2017-07-16T18:51:15  <bitcoin-git> bitcoin/master a9e82f6 Pieter Wuille: Use cpuid intrinsics instead of asm code
265 2017-07-16T18:51:15  <bitcoin-git> bitcoin/master 674848f Pieter Wuille: Clarify entropy source
266 2017-07-16T18:51:16  <bitcoin-git> bitcoin/master ef37f20 Pieter Wuille: Merge #10820: Use cpuid intrinsics instead of asm code...
267 2017-07-16T18:51:44  <bitcoin-git> [bitcoin] sipa closed pull request #10820: Use cpuid intrinsics instead of asm code (master...20170717_cpuid) https://github.com/bitcoin/bitcoin/pull/10820
268 2017-07-16T18:52:53  *** laurentmt has quit IRC
269 2017-07-16T18:56:32  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef37f2033c4a...b4d03be3cac0
270 2017-07-16T18:56:32  <bitcoin-git> bitcoin/master 912da1d René Nyffenegger: Use AC_ARG_VAR to set ARFLAGS....
271 2017-07-16T18:56:33  <bitcoin-git> bitcoin/master b4d03be Pieter Wuille: Merge #10766: Building Environment: Set ARFLAGS to cr...
272 2017-07-16T18:57:03  <bitcoin-git> [bitcoin] sipa closed pull request #10766: Building Environment: Set ARFLAGS to cr (master...ARFLAGS) https://github.com/bitcoin/bitcoin/pull/10766
273 2017-07-16T19:00:42  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4d03be3cac0...99c7db8731cc
274 2017-07-16T19:00:43  <bitcoin-git> bitcoin/master c53369c practicalswift: Remove duplicate include
275 2017-07-16T19:00:43  <bitcoin-git> bitcoin/master 99c7db8 Pieter Wuille: Merge #10840: Remove duplicate include...
276 2017-07-16T19:01:12  <bitcoin-git> [bitcoin] sipa closed pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840
277 2017-07-16T19:03:53  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99c7db8731cc...ad6fce67b9bb
278 2017-07-16T19:03:53  <bitcoin-git> bitcoin/master d0413c6 René Nyffenegger: Use range based for loop...
279 2017-07-16T19:03:54  <bitcoin-git> bitcoin/master ad6fce6 Pieter Wuille: Merge #10844: Use range based for loop...
280 2017-07-16T19:04:23  <bitcoin-git> [bitcoin] sipa closed pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844
281 2017-07-16T19:06:23  *** mmgen has joined #bitcoin-core-dev
282 2017-07-16T19:11:45  *** JackH has joined #bitcoin-core-dev
283 2017-07-16T19:13:48  *** arowser has quit IRC
284 2017-07-16T19:15:45  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad6fce67b9bb...565494619d80
285 2017-07-16T19:15:45  <bitcoin-git> bitcoin/master 6835cb0 practicalswift: Avoid static analyzer warnings regarding uninitialized arguments...
286 2017-07-16T19:15:46  <bitcoin-git> bitcoin/master 5654946 Pieter Wuille: Merge #10735: Avoid static analyzer warnings regarding uninitialized arguments...
287 2017-07-16T19:16:10  <bitcoin-git> [bitcoin] sipa closed pull request #10735: Avoid static analyzer warnings regarding uninitialized arguments (master...std-array) https://github.com/bitcoin/bitcoin/pull/10735
288 2017-07-16T19:19:56  *** arowser has joined #bitcoin-core-dev
289 2017-07-16T19:28:48  *** davec has quit IRC
290 2017-07-16T19:29:41  <sipa> do we know about this: https://bitcoin.stackexchange.com/questions/56750/autogen-sh-not-working-on-ubuntu-on-windows ?
291 2017-07-16T19:30:58  <BlueMatt> that seems to indicate it doesnt support "seg -e"???
292 2017-07-16T19:31:05  <BlueMatt> that sounds like an ubuntu-on-windows issue
293 2017-07-16T19:31:51  <sipa> I vaguely remember that there were known issues when building on Ubuntu-in-Windows, but I don't remember whether it was this.
294 2017-07-16T19:32:39  <BlueMatt> not this, no
295 2017-07-16T19:32:45  <BlueMatt> well, afair
296 2017-07-16T19:35:22  *** arowser has quit IRC
297 2017-07-16T19:39:50  *** davec has joined #bitcoin-core-dev
298 2017-07-16T19:41:38  *** arowser has joined #bitcoin-core-dev
299 2017-07-16T19:47:00  *** sam_c has joined #bitcoin-core-dev
300 2017-07-16T19:48:15  <cfields> IIRC the last round of problems was caused by an update that borked the default path
301 2017-07-16T19:51:08  <sipa> cfields: what is the option to make gcc emit every function in its own section?
302 2017-07-16T19:51:44  <cfields> sipa: ffunction-section
303 2017-07-16T19:51:59  <cfields> er, there's another s in there somewhere though
304 2017-07-16T19:52:24  <cfields> -ffunction-sections
305 2017-07-16T19:52:25  <sipa> do we enable -Wl,--gc-sections by default?
306 2017-07-16T19:52:31  <cfields> sipa: and you want to link with -gc-sections
307 2017-07-16T19:52:33  <cfields> no
308 2017-07-16T19:54:07  <sipa> any reason not to?
309 2017-07-16T19:56:29  <cfields> sipa: i think default-hidden-visibility accomplishes the same thing without the section bloat?
310 2017-07-16T19:59:39  <sipa> cfields: is that always set for us?
311 2017-07-16T20:00:40  *** arowser has quit IRC
312 2017-07-16T20:01:50  <sipa> cfields: a build with CFLAGS/CXXFLAGS/LDFLAGS all set to "-O2 -g0", results in a 6MB stripped bitcoind
313 2017-07-16T20:02:14  <sipa> cfields: a build with CFLAGS/CXXFLAGS/LDFLAGS all set to "-O2 -g0 -ffunction-sections -fdata-sections -Wl,--gc-sections", results in a 5.4MB stripped bitcoind
314 2017-07-16T20:03:37  <cfields> sipa: it's not set auto, --enable-reduced-exports
315 2017-07-16T20:03:41  *** jamesob has quit IRC
316 2017-07-16T20:03:44  <cfields> mind comparing with that?
317 2017-07-16T20:03:54  <gmaxwell> why don't we do that by default
318 2017-07-16T20:03:59  *** jamesob has joined #bitcoin-core-dev
319 2017-07-16T20:04:10  <cfields> gmaxwell: there's a visibility issue with some boost versions
320 2017-07-16T20:04:16  <gmaxwell> ah
321 2017-07-16T20:04:28  *** jamesob has quit IRC
322 2017-07-16T20:04:43  *** jamesob has joined #bitcoin-core-dev
323 2017-07-16T20:05:30  <sipa> cfields: that option makes no difference; 6.0MB again
324 2017-07-16T20:05:35  *** jamesob has joined #bitcoin-core-dev
325 2017-07-16T20:05:43  <cfields> huh
326 2017-07-16T20:06:05  *** jamesob has quit IRC
327 2017-07-16T20:06:23  *** jamesob has joined #bitcoin-core-dev
328 2017-07-16T20:06:35  <sipa> make clean && ./configure --with-incompatible-bdb --without-gui --enable-reduced-exports && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind
329 2017-07-16T20:06:39  <sipa> 6008256 src/bitcoind
330 2017-07-16T20:06:52  *** jamesob has quit IRC
331 2017-07-16T20:06:52  *** arowser has joined #bitcoin-core-dev
332 2017-07-16T20:07:08  *** jamesob has joined #bitcoin-core-dev
333 2017-07-16T20:07:31  <cfields> sipa: sounds promising then, though I'm kinda confused as to why
334 2017-07-16T20:07:40  *** jamesob has quit IRC
335 2017-07-16T20:07:58  <sipa> make clean && COMMON="-O2" && ./configure --with-incompatible-bdb --without-gui CFLAGS="$COMMON" CXXFLAGS="$COMMON" LDFLAGS="$COMMON" && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind
336 2017-07-16T20:07:58  *** jamesob has joined #bitcoin-core-dev
337 2017-07-16T20:08:05  <sipa> 6008256 src/bitcoind
338 2017-07-16T20:08:28  *** jamesob has quit IRC
339 2017-07-16T20:08:33  <sipa> ^ exactly the same
340 2017-07-16T20:08:44  *** jamesob has joined #bitcoin-core-dev
341 2017-07-16T20:08:49  <sipa> make clean && COMMON="-O2 -ffunction-sections -fdata-sections -Wl,--gc-sections" && ./configure --with-incompatible-bdb --without-gui CFLAGS="$COMMON" CXXFLAGS="$COMMON" LDFLAGS="$COMMON" && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind
342 2017-07-16T20:08:53  <sipa> 5397952 src/bitcoind
343 2017-07-16T20:09:16  *** jamesob has quit IRC
344 2017-07-16T20:09:49  *** jamesob has joined #bitcoin-core-dev
345 2017-07-16T20:10:00  <cfields> sipa: i wonder if there are any downsides wrt locality?
346 2017-07-16T20:10:31  <sipa> cfields: i can run a reindex benchmark
347 2017-07-16T20:12:35  *** arowser has quit IRC
348 2017-07-16T20:14:15  <sipa> cfields: should --enable-reduced-exports affect the CXXFLAGS/LDFLAGS that get printed in any way?
349 2017-07-16T20:14:24  *** jamesob has quit IRC
350 2017-07-16T20:14:49  <cfields> sipa: sigh, probably not
351 2017-07-16T20:15:03  <cfields> that needs to be cleaned up. There's lots of stuff not reported
352 2017-07-16T20:16:20  <gmaxwell> sipa: you mean when doing a V=1 build so you can see the arguments it actually uses
353 2017-07-16T20:16:30  <cfields> sipa: aurgh!
354 2017-07-16T20:17:24  <cfields> wait, hmm
355 2017-07-16T20:18:19  <cfields> sipa: sorry, i lied to you :(
356 2017-07-16T20:18:23  <cfields> --enable-reduce-exports
357 2017-07-16T20:18:54  <sipa> shouldn't it complain if i make a typo?
358 2017-07-16T20:19:01  *** arowser has joined #bitcoin-core-dev
359 2017-07-16T20:19:15  <cfields> sipa: it used to, but we can't anymore because config options get forwarded to subconfigs
360 2017-07-16T20:19:34  <sipa> heh, i always wondered how it dealt with that...
361 2017-07-16T20:21:43  <sipa> -rwxr-xr-x 1 pw pw   6008256 Jul 16 13:15 src/bitcoind-shasse-O2
362 2017-07-16T20:21:43  <sipa> -rwxr-xr-x 1 pw pw   5979584 Jul 16 13:21 src/bitcoind-shasse-O2reduce
363 2017-07-16T20:21:44  <sipa> -rwxr-xr-x 1 pw pw   5397952 Jul 16 13:19 src/bitcoind-shasse-O2sections
364 2017-07-16T20:22:06  <sipa> the middle one is with CXXFLAGS="-O2" --enable-reduce-exports
365 2017-07-16T20:23:03  *** SopaXorzTaker has quit IRC
366 2017-07-16T20:26:04  <sipa> benchmarking those 3
367 2017-07-16T20:26:07  <cfields> sipa: may as well try with -fdata-sections too
368 2017-07-16T20:27:17  <sipa> cfields: yeah, that's with both
369 2017-07-16T20:27:28  <gmaxwell> sipa: why would you expect a performance difference?
370 2017-07-16T20:27:41  <cfields> ah ok
371 2017-07-16T20:30:02  <sipa> gmaxwell: cfields asked if there could be a locality impact
372 2017-07-16T20:50:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/565494619d80...1fc783fc08bc
373 2017-07-16T20:50:25  <bitcoin-git> bitcoin/master 5618b7d Pavel Janík: Do not shadow upper local variable `state`.
374 2017-07-16T20:50:26  <bitcoin-git> bitcoin/master 1fc783f MarcoFalke: Merge #10739: test: Move variable `state` down where it is used...
375 2017-07-16T20:50:36  *** promag has joined #bitcoin-core-dev
376 2017-07-16T20:50:45  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10739: test: Move variable `state` down where it is used (master...20170704_Wshadow_txvalidationcache_tests) https://github.com/bitcoin/bitcoin/pull/10739
377 2017-07-16T20:51:52  *** mmgen has quit IRC
378 2017-07-16T20:53:27  *** Guyver2 has quit IRC
379 2017-07-16T20:53:35  *** sam_c has quit IRC
380 2017-07-16T20:55:37  <cfields> sipa: if we're using ffunction-sections, we can use -Wl,--icf=safe too
381 2017-07-16T20:56:07  *** sam_c has joined #bitcoin-core-dev
382 2017-07-16T20:56:37  <cfields> shaves off another ~70k for me
383 2017-07-16T20:56:39  <sipa> cfields: i don't see that in man ld
384 2017-07-16T20:56:53  <cfields> sipa: man ld.gold
385 2017-07-16T20:57:50  *** Aaronvan_ has quit IRC
386 2017-07-16T20:57:53  <sipa> ah
387 2017-07-16T21:00:16  *** arowser has quit IRC
388 2017-07-16T21:02:12  *** AaronvanW has joined #bitcoin-core-dev
389 2017-07-16T21:05:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
390 2017-07-16T21:06:25  *** arowser has joined #bitcoin-core-dev
391 2017-07-16T21:14:03  *** arowser has quit IRC
392 2017-07-16T21:19:29  <bincap> given two gitian.signs asserts (from two people) is there a quick command to compare if their out_manifest is identical?
393 2017-07-16T21:20:10  *** arowser has joined #bitcoin-core-dev
394 2017-07-16T21:23:30  <bitcoin-git> [bitcoin] practicalswift opened pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
395 2017-07-16T21:24:17  *** Squidicc has joined #bitcoin-core-dev
396 2017-07-16T21:25:52  *** arowser has quit IRC
397 2017-07-16T21:38:48  *** QBcrusher has joined #bitcoin-core-dev
398 2017-07-16T21:39:01  *** arowser has joined #bitcoin-core-dev
399 2017-07-16T21:40:46  *** arowser has quit IRC
400 2017-07-16T21:44:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1fc783fc08bc...3895e25a7736
401 2017-07-16T21:44:52  <bitcoin-git> bitcoin/master 2c2e90d practicalswift: Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.
402 2017-07-16T21:44:52  <bitcoin-git> bitcoin/master 3895e25 MarcoFalke: Merge #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching....
403 2017-07-16T21:45:18  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching. (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
404 2017-07-16T21:46:54  *** arowser has joined #bitcoin-core-dev
405 2017-07-16T21:59:03  *** arowser has quit IRC
406 2017-07-16T22:01:02  <Chris_Stewart_5> In the test framework, using node.generate() will propogate the block to another peer right?
407 2017-07-16T22:01:22  <sipa> it'll propagate to whatever other peer it is connected to
408 2017-07-16T22:01:45  <sipa> who will do the same
409 2017-07-16T22:02:08  <Chris_Stewart_5> Do I need to use some sort of sleep mechanism if I need it to propogate before runnign the next line?
410 2017-07-16T22:02:24  <sipa> no, you need to use wait_for_block
411 2017-07-16T22:02:31  <sipa> or something similar
412 2017-07-16T22:02:42  <Chris_Stewart_5> oh, cool. I'll check that out. Thanks.
413 2017-07-16T22:05:12  *** arowser has joined #bitcoin-core-dev
414 2017-07-16T22:05:28  *** BashCo has quit IRC
415 2017-07-16T22:06:04  *** BashCo has joined #bitcoin-core-dev
416 2017-07-16T22:08:38  *** promag has quit IRC
417 2017-07-16T22:11:17  *** jamesob has joined #bitcoin-core-dev
418 2017-07-16T22:14:29  *** rubensayshi has quit IRC
419 2017-07-16T22:16:13  *** jamesob has quit IRC
420 2017-07-16T22:21:33  *** marcoagner has quit IRC
421 2017-07-16T22:22:15  *** wallet42 has joined #bitcoin-core-dev
422 2017-07-16T22:26:19  *** marcoagner has joined #bitcoin-core-dev
423 2017-07-16T22:26:51  *** robby938 has joined #bitcoin-core-dev
424 2017-07-16T22:30:52  *** coredump_ has joined #bitcoin-core-dev
425 2017-07-16T22:31:58  *** rubensayshi has joined #bitcoin-core-dev
426 2017-07-16T22:33:41  <BlueMatt> cfields: gonna update 10809?
427 2017-07-16T22:35:22  <sipa> BlueMatt: care to investigate #10758?
428 2017-07-16T22:35:23  <gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
429 2017-07-16T22:35:43  <sipa> (it seems to forget progress when continuing a reindex)
430 2017-07-16T22:36:03  <BlueMatt> oh, yes, thats next on my list
431 2017-07-16T22:36:21  <sipa> actually, i may be an idiot there
432 2017-07-16T22:37:08  <BlueMatt> hmm, did that not used to happen? I have no idea
433 2017-07-16T22:38:19  <sipa> it is supposed to start over from scratch, but go faster through the parts it has already done
434 2017-07-16T22:39:51  <sipa> i guess the thing to make sure is that it does not wipe the block index when contonuing a reindex
435 2017-07-16T22:40:27  *** arowser has quit IRC
436 2017-07-16T22:41:01  <BlueMatt> it shouldnt, though
437 2017-07-16T22:41:02  <BlueMatt> hmm
438 2017-07-16T22:41:15  <BlueMatt> (thats the section where you commented on the comment you found confusing
439 2017-07-16T22:41:32  <BlueMatt> (it says explicitly that we dont want to clear the db even if we're setting fReindex unless its a new reindex...)
440 2017-07-16T22:42:32  <sipa> well i failed to understand what it was trying to say :)
441 2017-07-16T22:43:30  <BlueMatt> sipa: try now?
442 2017-07-16T22:43:32  <BlueMatt> (comment, that is)
443 2017-07-16T22:43:35  <BlueMatt> didnt change the code
444 2017-07-16T22:43:41  <sipa> ok, will have a look soon
445 2017-07-16T22:43:55  <BlueMatt> so, wait, do you think there is a bug that i should go hunt or do you think you mis-read?
446 2017-07-16T22:45:22  <sipa> i thought there was a bug, but i'm less sure now
447 2017-07-16T22:45:27  <sipa> i'll verify
448 2017-07-16T22:46:39  *** arowser has joined #bitcoin-core-dev
449 2017-07-16T22:48:52  *** marcoagner has quit IRC
450 2017-07-16T22:51:20  *** marcoagner has joined #bitcoin-core-dev
451 2017-07-16T22:53:33  <BlueMatt> hmmm...this client-side getinfo thing scares me
452 2017-07-16T22:54:01  <BlueMatt> our rpcs are always atomic elements, but if you start calling getinfo, then getwalletinfo, then getmininginfo separately, they could return results based on different views of the current chain
453 2017-07-16T22:54:06  <BlueMatt> which would be astoundingly confusing for users
454 2017-07-16T22:54:57  <sipa> i'm totally fine with deprecating and then deleting
455 2017-07-16T22:55:30  <BlueMatt> well I'm curious what the previously-mentioned "IRC discussion" was that resulted in the pr getting reopened
456 2017-07-16T22:55:46  <BlueMatt> i dont want to show up late to the party and shit on it and say it shouldnt happen, but I'm really uneasy about the idea
457 2017-07-16T22:58:17  <BlueMatt> sipa: do you want the asm sha in for 15?
458 2017-07-16T22:58:20  <BlueMatt> should i bother reviewing it?
459 2017-07-16T22:58:25  <BlueMatt> (yet)
460 2017-07-16T22:58:56  <sipa> BlueMatt: i think it's a great and easy performance win, and i think it's ready
461 2017-07-16T22:59:10  <sipa> whether we want it in 0.15 depends on reviewer interest
462 2017-07-16T23:00:19  <BlueMatt> k
463 2017-07-16T23:00:23  <BlueMatt> i'll try to get to it
464 2017-07-16T23:01:00  <sipa> awesome
465 2017-07-16T23:01:15  *** Aaronvan_ has joined #bitcoin-core-dev
466 2017-07-16T23:01:33  *** AaronvanW has quit IRC
467 2017-07-16T23:01:38  <cfields> BlueMatt: yea, will do in a bit. I'm frantically trying to bump qt atm.
468 2017-07-16T23:02:40  <cfields> +1 for sha asm in 0.15
469 2017-07-16T23:07:41  *** Aaronvan_ has quit IRC
470 2017-07-16T23:09:20  <cfields> sipa: any theories as to what slows down the lto build?
471 2017-07-16T23:10:33  *** ula has joined #bitcoin-core-dev
472 2017-07-16T23:11:41  <sipa> cfields: over-eager inlining across objects?
473 2017-07-16T23:13:06  *** RoyceX has quit IRC
474 2017-07-16T23:14:05  <cfields> makes sense
475 2017-07-16T23:14:11  <gmaxwell> sipa: wumpus had a comment about where the detection was being triggered for the asm.
476 2017-07-16T23:14:13  <cfields> i could see how it might make a mess of our serialization
477 2017-07-16T23:14:38  <sipa> gmaxwell: i've long since addressed that and commented about it
478 2017-07-16T23:14:42  <gmaxwell> I only haven't acked it because I didn't think the patch was in its final state yet... I've tried it on a few hosts, works as expected.
479 2017-07-16T23:14:45  <gmaxwell> sipa: oh
480 2017-07-16T23:15:35  <gmaxwell> oh I see there are more commits now
481 2017-07-16T23:15:56  <sipa> gmaxwell: where 'long' means 15 hours ago
482 2017-07-16T23:16:45  <sipa> it also prints which implementation is being used
483 2017-07-16T23:17:29  <sipa> the only unaddressed comment is BlueMatt's concern about printing copyright information for binary-only distributions
484 2017-07-16T23:17:52  <BlueMatt> we do it for openssl for qt - we have it in the about dialog or smth iirc
485 2017-07-16T23:18:08  <gmaxwell> I don't believe matt is correct in any case; we don't have a "binary only distribution" -- sure you don't have to download the source, but thats up to you.
486 2017-07-16T23:18:09  <sipa> easy enough to add something there, if needed
487 2017-07-16T23:18:17  <gmaxwell> BlueMatt: openssl is 4-clause BSD
488 2017-07-16T23:20:00  <cfields> \o/ a self-test
489 2017-07-16T23:20:54  <sipa> cfields: actually, you should test whether reintroducing the foldgers crystals bug in the sse asm causes it to select the basic sha256 implementation at run time
490 2017-07-16T23:20:57  <sipa> it should
491 2017-07-16T23:22:10  <gmaxwell> sipa: I was thinking of suggesting logging that failure, when cpu id and selftest disagree...
492 2017-07-16T23:22:16  <cfields> sipa: hmm, i wonder if we should still fail in that case though, and require a --software-sha256 flag or something
493 2017-07-16T23:22:27  <sipa> gmaxwell: the crypto code doesn't have access to logging
494 2017-07-16T23:22:34  <cfields> if that's happening in the wild, we really want to know about it
495 2017-07-16T23:23:06  <sipa> we could assert in case the selftest doesn't go as expected
496 2017-07-16T23:23:14  <sipa> i agree that this may hide bugs
497 2017-07-16T23:23:46  <sipa> though in a pretty safe way... i don't think it's easy to screw up SHA256 in a way that wouldn't be detectable with a single test
498 2017-07-16T23:24:37  <gmaxwell> sipa: one thing the selftest doesn't extensively test is sensitivity to alignent.
499 2017-07-16T23:24:44  <sipa> ok, i can fix that
500 2017-07-16T23:24:57  <sipa> i can also extend it to test 0 and/or 2 blocks rather than just a single block
501 2017-07-16T23:25:41  <BlueMatt> gmaxwell: hmm? bitcoin.org/bin has binary distributions
502 2017-07-16T23:25:47  <BlueMatt> we ship binary-only stuff, at least on windows
503 2017-07-16T23:25:52  <BlueMatt> iirc
504 2017-07-16T23:26:41  <sipa> BlueMatt: i think gmaxwell's point is that the source code is still available for those
505 2017-07-16T23:26:54  <sipa> i have no idea whether that matters, IANAL
506 2017-07-16T23:27:16  <BlueMatt> ah, ok
507 2017-07-16T23:27:19  <BlueMatt> wellt hen I dont care
508 2017-07-16T23:27:36  <BlueMatt> as long as his point isnt "we dont ship binary-only" and is instead "but source is freely available", then he would know :)
509 2017-07-16T23:27:51  <gmaxwell> BlueMatt: if it meant what you thought, it wouldn't be GPL compatible. You're interperting the license in the same way that 4-clause bsd is written.
510 2017-07-16T23:28:03  <BlueMatt> k :)
511 2017-07-16T23:28:34  <gmaxwell> BlueMatt: my point was we always make the source available.
512 2017-07-16T23:28:34  *** promag has joined #bitcoin-core-dev
513 2017-07-16T23:29:59  *** arowser has quit IRC
514 2017-07-16T23:30:19  <bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
515 2017-07-16T23:30:45  <BlueMatt> gmaxwell: we dont always *ship* the source along with the binary
516 2017-07-16T23:30:48  <BlueMatt> was my point
517 2017-07-16T23:30:56  <BlueMatt> as long as I'm misreading the liscense, I withdraw my concern :)
518 2017-07-16T23:31:05  <BlueMatt> we just make it available
519 2017-07-16T23:36:11  *** arowser has joined #bitcoin-core-dev
520 2017-07-16T23:53:54  <gmaxwell> sipa: not something to fix now, but I see that the multiblock code doesn't really make a heroic effort to transform multiple blocks at a time.  This may disavantage the avx2-rorx code, which really wants 2 blocks at a time (as it vector processes the initial expander in both blocks)
521 2017-07-16T23:54:54  <sipa> gmaxwell: that's not too hard to fix
522 2017-07-16T23:55:32  <gmaxwell> ya, I know. e.g. change the buffering to buffer two blocks.
523 2017-07-16T23:55:54  <sipa> yeah
524 2017-07-16T23:56:13  <gmaxwell> similar, the 8m rorx code is setup for 8 blocks.
525 2017-07-16T23:59:08  *** arowser has quit IRC