1 2017-07-18T00:01:26  *** promag has quit IRC
  2 2017-07-18T00:04:27  *** CubicEarth has quit IRC
  3 2017-07-18T00:09:10  *** goatpig has quit IRC
  4 2017-07-18T00:10:46  *** kexkey has quit IRC
  5 2017-07-18T00:28:34  <bitcoin-git> [bitcoin] jtimon opened pull request #10859: RPC: gettxout: Slightly improve doc and tests (master...b15-rpc-gettxout-mempool) https://github.com/bitcoin/bitcoin/pull/10859
  6 2017-07-18T00:29:32  *** chjj has quit IRC
  7 2017-07-18T00:38:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  8 2017-07-18T00:41:02  *** chjj has joined #bitcoin-core-dev
  9 2017-07-18T00:46:31  *** talmai has joined #bitcoin-core-dev
 10 2017-07-18T00:46:52  *** Guest38971 has joined #bitcoin-core-dev
 11 2017-07-18T00:49:24  *** jnewbery1 has quit IRC
 12 2017-07-18T00:50:13  *** chjj has quit IRC
 13 2017-07-18T00:54:11  *** chjj has joined #bitcoin-core-dev
 14 2017-07-18T00:56:58  *** Dyaheon has quit IRC
 15 2017-07-18T00:57:21  *** Dyaheon has joined #bitcoin-core-dev
 16 2017-07-18T00:57:47  *** arowser has quit IRC
 17 2017-07-18T01:03:12  *** PRab has quit IRC
 18 2017-07-18T01:04:29  *** arowser has joined #bitcoin-core-dev
 19 2017-07-18T01:07:47  <Guest38971> lets say I wanted my node to support bip148. What do I need to configure in order to allow this? I am currently running bitcoin core 0.14.2 am I just ammending a line of code into the config file? I just need a reference if possible or is it advised to just wait for a release from bitcoin core?. I do not know if this is the proper channel for this so I apologize in advance. Thank you very much for the help.
 20 2017-07-18T01:11:22  <sipa> Bitcoin Core at this point does not support BIP148
 21 2017-07-18T01:11:34  <sipa> There are forks of the codebase that do.
 22 2017-07-18T01:13:08  *** jamesob_ has quit IRC
 23 2017-07-18T01:18:34  *** belcher has quit IRC
 24 2017-07-18T01:19:06  *** Victor_sueca has joined #bitcoin-core-dev
 25 2017-07-18T01:20:40  *** Chris_Stewart_5 has quit IRC
 26 2017-07-18T01:20:49  *** Victorsueca has quit IRC
 27 2017-07-18T01:22:59  <Guest38971> Understood my question was hypethical.  My main concern is if I am running my node how can I test BIP148 suppost. I found a link that allows me to download bitcoin core with BIP148 support, but I did not know if this was trustworthy. Thank you
 28 2017-07-18T01:34:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 29 2017-07-18T01:50:28  *** QBcrusher_ has quit IRC
 30 2017-07-18T01:52:02  *** d9b4bef9 has quit IRC
 31 2017-07-18T01:53:08  *** d9b4bef9 has joined #bitcoin-core-dev
 32 2017-07-18T02:03:07  *** Murch has quit IRC
 33 2017-07-18T02:05:46  *** blznblzn2 has joined #bitcoin-core-dev
 34 2017-07-18T02:06:53  *** Chris_Stewart_5 has quit IRC
 35 2017-07-18T02:07:00  *** mappum_ has joined #bitcoin-core-dev
 36 2017-07-18T02:07:09  *** mmoya_ has joined #bitcoin-core-dev
 37 2017-07-18T02:08:23  *** michagogo_ has joined #bitcoin-core-dev
 38 2017-07-18T02:09:08  *** emzy_ has joined #bitcoin-core-dev
 39 2017-07-18T02:09:13  *** Bootvis_ has joined #bitcoin-core-dev
 40 2017-07-18T02:09:52  *** Lauda__ has joined #bitcoin-core-dev
 41 2017-07-18T02:09:59  *** niska` has joined #bitcoin-core-dev
 42 2017-07-18T02:12:53  *** Guest38971 has quit IRC
 43 2017-07-18T02:13:56  *** hsmiths has quit IRC
 44 2017-07-18T02:13:56  *** Lauda has quit IRC
 45 2017-07-18T02:13:57  *** michagogo has quit IRC
 46 2017-07-18T02:13:57  *** Bootvis has quit IRC
 47 2017-07-18T02:13:57  *** niska has quit IRC
 48 2017-07-18T02:13:57  *** emzy has quit IRC
 49 2017-07-18T02:13:57  *** bordeaux_facile has quit IRC
 50 2017-07-18T02:13:57  *** mappum has quit IRC
 51 2017-07-18T02:13:57  *** mmoya has quit IRC
 52 2017-07-18T02:14:15  *** michagogo_ is now known as michagogo
 53 2017-07-18T02:14:16  *** mmoya_ is now known as mmoya
 54 2017-07-18T02:14:25  *** mappum_ is now known as mappum
 55 2017-07-18T02:19:11  *** bordeaux_facile has joined #bitcoin-core-dev
 56 2017-07-18T02:30:22  *** Ylbam has quit IRC
 57 2017-07-18T02:32:19  *** harrymm has quit IRC
 58 2017-07-18T02:34:48  *** CubicEarth has joined #bitcoin-core-dev
 59 2017-07-18T02:39:37  <bitcoin-git> [bitcoin] ryanofsky closed pull request #10829: Simple, backwards compatible RPC multiwallet support. (master...pr/multiparam) https://github.com/bitcoin/bitcoin/pull/10829
 60 2017-07-18T02:44:01  *** roasbeef has quit IRC
 61 2017-07-18T02:50:32  *** harrymm has joined #bitcoin-core-dev
 62 2017-07-18T02:51:45  *** Arvidt has joined #bitcoin-core-dev
 63 2017-07-18T02:57:17  *** davec has quit IRC
 64 2017-07-18T02:58:56  *** roasbeef has joined #bitcoin-core-dev
 65 2017-07-18T03:01:33  *** Arvidt has quit IRC
 66 2017-07-18T03:01:35  *** Dyaheon has quit IRC
 67 2017-07-18T03:02:03  *** Dyaheon has joined #bitcoin-core-dev
 68 2017-07-18T03:03:02  *** justanotheruser has joined #bitcoin-core-dev
 69 2017-07-18T03:05:13  *** justan0theruser has quit IRC
 70 2017-07-18T03:07:46  *** justanotheruser has quit IRC
 71 2017-07-18T03:08:24  *** justanotheruser has joined #bitcoin-core-dev
 72 2017-07-18T03:08:42  *** BashCo has quit IRC
 73 2017-07-18T03:09:20  *** BashCo has joined #bitcoin-core-dev
 74 2017-07-18T03:12:45  *** ivan has joined #bitcoin-core-dev
 75 2017-07-18T03:23:28  *** fengling has joined #bitcoin-core-dev
 76 2017-07-18T03:24:37  *** fengling has quit IRC
 77 2017-07-18T03:25:28  *** fengling has joined #bitcoin-core-dev
 78 2017-07-18T03:33:47  *** justan0theruser has joined #bitcoin-core-dev
 79 2017-07-18T03:36:27  *** justan0theruser has quit IRC
 80 2017-07-18T03:36:56  *** justanotheruser has quit IRC
 81 2017-07-18T03:37:01  *** justan0theruser has joined #bitcoin-core-dev
 82 2017-07-18T04:04:12  *** hsmiths has joined #bitcoin-core-dev
 83 2017-07-18T04:05:22  *** Lauda__ is now known as Lauda
 84 2017-07-18T04:24:34  *** dabura667 has joined #bitcoin-core-dev
 85 2017-07-18T04:33:12  *** davec has joined #bitcoin-core-dev
 86 2017-07-18T05:13:15  *** CubicEarth has quit IRC
 87 2017-07-18T05:19:43  *** talmai has quit IRC
 88 2017-07-18T05:22:15  *** mmgen has joined #bitcoin-core-dev
 89 2017-07-18T05:25:51  *** d_t has quit IRC
 90 2017-07-18T05:45:31  *** arowser has quit IRC
 91 2017-07-18T05:53:36  *** arowser has joined #bitcoin-core-dev
 92 2017-07-18T05:57:44  *** arowser has quit IRC
 93 2017-07-18T05:58:25  *** mmgen has quit IRC
 94 2017-07-18T06:04:46  *** arowser has joined #bitcoin-core-dev
 95 2017-07-18T06:08:00  *** arowser has quit IRC
 96 2017-07-18T06:09:10  *** arowser has joined #bitcoin-core-dev
 97 2017-07-18T06:11:41  *** arowser has quit IRC
 98 2017-07-18T06:14:20  *** arowser has joined #bitcoin-core-dev
 99 2017-07-18T06:18:05  *** arowser has quit IRC
100 2017-07-18T06:24:12  *** arowser has joined #bitcoin-core-dev
101 2017-07-18T06:25:02  *** jouke has quit IRC
102 2017-07-18T06:27:10  *** jouke has joined #bitcoin-core-dev
103 2017-07-18T06:27:10  *** jouke has quit IRC
104 2017-07-18T06:27:10  *** jouke has joined #bitcoin-core-dev
105 2017-07-18T06:30:45  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75b5643c47c3...81560b07ce8a
106 2017-07-18T06:30:45  <bitcoin-git> bitcoin/master 077d01f Cory Fields: random: only use getentropy on openbsd
107 2017-07-18T06:30:46  <bitcoin-git> bitcoin/master 81560b0 Wladimir J. van der Laan: Merge #10855: random: only use getentropy on openbsd...
108 2017-07-18T06:31:14  <bitcoin-git> [bitcoin] laanwj closed pull request #10855: random: only use getentropy on openbsd (master...getentropy-openbsd) https://github.com/bitcoin/bitcoin/pull/10855
109 2017-07-18T06:44:42  <sipa> wumpus: how about a --sha256= option, which now defaults to basic, but can be changed to auto or a specific implementatio
110 2017-07-18T06:44:45  <sipa> ?
111 2017-07-18T06:44:46  *** Dyaheon has quit IRC
112 2017-07-18T06:45:49  *** Dyaheon has joined #bitcoin-core-dev
113 2017-07-18T06:46:15  <wumpus> sipa: if you want to go that way, it needs to be future-proof to be able to add more sha algorithms in the future and select multiple, I guess
114 2017-07-18T06:47:29  <wumpus> that's why I proposed a a generic 'experimental assembly' flag, which is not so specific
115 2017-07-18T06:47:40  <wumpus> but sure, that makes sense
116 2017-07-18T06:56:01  *** Victor_sueca is now known as Victorsueca
117 2017-07-18T07:10:37  *** BashCo has quit IRC
118 2017-07-18T07:11:15  *** BashCo has joined #bitcoin-core-dev
119 2017-07-18T07:14:36  <cfields> sipa: i think that's good to have either way. If nothing else, it makes benchmarking/comparing easier.
120 2017-07-18T07:15:38  <sipa> cfields: agree
121 2017-07-18T07:16:29  <gmaxwell> more complex is genreally less good because it's costly to test all the options.  --enable-expiremental-asm is also what we did in libsecp (and FWIW! how arm still is!)
122 2017-07-18T07:21:35  <sipa> gmaxwell: there are other advantages... like being able to run the tests and benchmarks on different hash function impls even if it's not the best available on your platform
123 2017-07-18T07:22:47  <wumpus> that doesn't need a compile time option
124 2017-07-18T07:23:44  <wumpus> e.g. bench could just cycle through all available sha algorithms
125 2017-07-18T07:24:09  <sipa> agree, like your branch did
126 2017-07-18T07:24:23  <wumpus> or some run-time override, if you want to do the other tests / a chain sync with it
127 2017-07-18T07:24:42  <wumpus> but maybe that's overkill to add an option for such a rare scenario
128 2017-07-18T07:25:08  <wumpus> but at least the tests should test all the possibilities (that run on the platform) I guess
129 2017-07-18T07:25:12  <sipa> wumpus: by --sha256 i meant a runtime option
130 2017-07-18T07:25:19  <wumpus> for basic sanity testing, not for running all tests
131 2017-07-18T07:26:03  <wumpus> okay
132 2017-07-18T07:26:14  <sipa> i'll keep it simple now
133 2017-07-18T07:29:19  *** ivan has quit IRC
134 2017-07-18T07:30:57  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81560b07ce8a...7b6e8bc44240
135 2017-07-18T07:30:57  <bitcoin-git> bitcoin/master 1fc8c3d Matt Corallo: No longer ever reuse keypool indexes...
136 2017-07-18T07:30:58  <bitcoin-git> bitcoin/master 7b6e8bc Wladimir J. van der Laan: Merge #10795: No longer ever reuse keypool indexes...
137 2017-07-18T07:31:06  <sipa> wumpus: oh, i see, you meant a compile time option
138 2017-07-18T07:31:08  <sipa> ack
139 2017-07-18T07:31:29  <bitcoin-git> [bitcoin] laanwj closed pull request #10795: No longer ever reuse keypool indexes (master...2017-07-wallet-keypool-overwrite) https://github.com/bitcoin/bitcoin/pull/10795
140 2017-07-18T07:34:41  *** coredump_ has quit IRC
141 2017-07-18T07:40:49  *** d_t has joined #bitcoin-core-dev
142 2017-07-18T07:45:00  *** blznblzn2 has quit IRC
143 2017-07-18T08:12:06  *** Ylbam has joined #bitcoin-core-dev
144 2017-07-18T08:14:01  *** harrymm has quit IRC
145 2017-07-18T08:21:08  *** paveljanik has quit IRC
146 2017-07-18T08:30:24  *** harrymm has joined #bitcoin-core-dev
147 2017-07-18T08:32:06  *** SopaXorzTaker has joined #bitcoin-core-dev
148 2017-07-18T08:35:51  *** timothy has joined #bitcoin-core-dev
149 2017-07-18T08:36:50  *** d_t has quit IRC
150 2017-07-18T08:38:28  *** Guyver2 has joined #bitcoin-core-dev
151 2017-07-18T08:40:10  *** ayy1337 has joined #bitcoin-core-dev
152 2017-07-18T08:57:35  *** bincap has quit IRC
153 2017-07-18T09:02:44  *** bincap has joined #bitcoin-core-dev
154 2017-07-18T09:05:34  *** tiagotrs has joined #bitcoin-core-dev
155 2017-07-18T09:06:50  *** tiagotrs has joined #bitcoin-core-dev
156 2017-07-18T09:09:50  *** coredump_ has joined #bitcoin-core-dev
157 2017-07-18T10:02:38  *** dabura667 has quit IRC
158 2017-07-18T10:12:49  *** sdfgsdfg has joined #bitcoin-core-dev
159 2017-07-18T10:13:07  *** spinza has quit IRC
160 2017-07-18T10:17:05  *** coredump_ has quit IRC
161 2017-07-18T10:18:59  *** spinza has joined #bitcoin-core-dev
162 2017-07-18T10:29:51  <wumpus> yes, I meant a compile-time option, sorry for not being clear
163 2017-07-18T10:38:14  *** mmgen has joined #bitcoin-core-dev
164 2017-07-18T10:39:47  *** Gudrun has joined #bitcoin-core-dev
165 2017-07-18T10:49:09  *** ayy1337|2 has joined #bitcoin-core-dev
166 2017-07-18T10:50:28  *** ayy1337 has quit IRC
167 2017-07-18T11:09:35  *** BashCo has quit IRC
168 2017-07-18T11:10:10  *** BashCo has joined #bitcoin-core-dev
169 2017-07-18T11:14:22  *** emzy_ is now known as emzy
170 2017-07-18T11:14:28  *** emzy has joined #bitcoin-core-dev
171 2017-07-18T11:49:52  *** Gudrun has quit IRC
172 2017-07-18T11:59:34  *** jannes has joined #bitcoin-core-dev
173 2017-07-18T12:04:36  <bitcoin-git> [bitcoin] practicalswift opened pull request #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition". (master...nEnd) https://github.com/bitcoin/bitcoin/pull/10862
174 2017-07-18T12:06:47  *** Magma has joined #bitcoin-core-dev
175 2017-07-18T12:10:34  *** jorge has joined #bitcoin-core-dev
176 2017-07-18T12:10:57  *** jorge is now known as Guest56804
177 2017-07-18T12:13:12  *** mryandao has quit IRC
178 2017-07-18T12:19:23  *** Dyaheon has quit IRC
179 2017-07-18T12:21:46  *** Dyaheon has joined #bitcoin-core-dev
180 2017-07-18T12:46:31  *** Aiden has joined #bitcoin-core-dev
181 2017-07-18T13:00:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
182 2017-07-18T13:07:51  <bitcoin-git> [bitcoin] corebob opened pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
183 2017-07-18T13:10:25  *** marcoagner has quit IRC
184 2017-07-18T13:11:31  *** goatpig has joined #bitcoin-core-dev
185 2017-07-18T13:13:21  <bitcoin-git> [bitcoin] practicalswift opened pull request #10864: Avoid redundant redeclaration of GetWarnings(const string&) (master...GetWarnings-in-warnings.h) https://github.com/bitcoin/bitcoin/pull/10864
186 2017-07-18T13:22:13  *** marcoagner has joined #bitcoin-core-dev
187 2017-07-18T13:23:31  *** davec has quit IRC
188 2017-07-18T13:24:18  *** mryandao has joined #bitcoin-core-dev
189 2017-07-18T13:28:53  <bitcoin-git> [bitcoin] corebob closed pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
190 2017-07-18T13:30:18  *** Aiden has quit IRC
191 2017-07-18T13:30:36  *** chjj has quit IRC
192 2017-07-18T13:30:43  *** Genesis2 has joined #bitcoin-core-dev
193 2017-07-18T13:41:06  *** davec has joined #bitcoin-core-dev
194 2017-07-18T13:44:04  *** chjj has joined #bitcoin-core-dev
195 2017-07-18T13:46:53  *** Genesis2 has quit IRC
196 2017-07-18T13:47:55  *** dabura667 has joined #bitcoin-core-dev
197 2017-07-18T13:49:47  *** corebob has quit IRC
198 2017-07-18T13:54:32  *** George has joined #bitcoin-core-dev
199 2017-07-18T13:59:07  *** George has quit IRC
200 2017-07-18T14:09:38  *** mmgen has quit IRC
201 2017-07-18T14:09:47  *** Kennedi has joined #bitcoin-core-dev
202 2017-07-18T14:11:21  *** jtimon has joined #bitcoin-core-dev
203 2017-07-18T14:20:13  *** mmgen has joined #bitcoin-core-dev
204 2017-07-18T14:20:16  *** RoyceX has quit IRC
205 2017-07-18T14:20:33  *** Cheeseo has joined #bitcoin-core-dev
206 2017-07-18T14:26:01  *** Dyaheon has quit IRC
207 2017-07-18T14:26:58  *** Dyaheon has joined #bitcoin-core-dev
208 2017-07-18T14:31:16  *** Kennedi has quit IRC
209 2017-07-18T14:33:17  <bitcoin-git> [bitcoin] corebob opened pull request #10865: Move CloseSocket out of SetSocketNonBlocking in netbase.cpp (master...20170718-refactor-1) https://github.com/bitcoin/bitcoin/pull/10865
210 2017-07-18T14:34:32  *** sdfgsdfg has quit IRC
211 2017-07-18T14:39:38  *** Murch has joined #bitcoin-core-dev
212 2017-07-18T14:47:13  *** Prudence has joined #bitcoin-core-dev
213 2017-07-18T14:50:02  <bitcoin-git> [bitcoin] practicalswift opened pull request #10866: Add mutex requirement for AddToCompactExtraTransactions(…) (master...lock-requirement-for-AddToCompactExtraTransactions) https://github.com/bitcoin/bitcoin/pull/10866
214 2017-07-18T14:50:46  <BlueMatt> wumpus: where did we land on freeze?
215 2017-07-18T14:57:10  *** dabura667 has quit IRC
216 2017-07-18T15:06:05  *** tiagotrs has quit IRC
217 2017-07-18T15:09:54  *** BashCo has quit IRC
218 2017-07-18T15:10:30  *** BashCo has joined #bitcoin-core-dev
219 2017-07-18T15:16:21  <wumpus> #10849 and #10571 seem ready to go in
220 2017-07-18T15:16:23  <gribble> https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
221 2017-07-18T15:16:25  <gribble> https://github.com/bitcoin/bitcoin/issues/10571 | [RPC]Move transaction combining from signrawtransaction to new RPC by achow101 · Pull Request #10571 · bitcoin/bitcoin · GitHub
222 2017-07-18T15:16:37  <wumpus>  #10579 has missed the window imo
223 2017-07-18T15:16:38  <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
224 2017-07-18T15:17:04  <wumpus> same for #9502
225 2017-07-18T15:17:06  <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
226 2017-07-18T15:18:20  <wumpus> I think the rest tagged for 0.15 qualifies as bug-fix, not feature
227 2017-07-18T15:18:26  <wumpus> BlueMatt: #10784 needs rebase btw
228 2017-07-18T15:18:27  <gribble> https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
229 2017-07-18T15:19:15  <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b6e8bc44240...bde4f937aebc
230 2017-07-18T15:19:16  <bitcoin-git> bitcoin/master dd2185c Jonas Schnelli: Register wallet endpoint
231 2017-07-18T15:19:17  <bitcoin-git> bitcoin/master 31e0720 Jonas Schnelli: Add wallet endpoint support to bitcoin-cli (-usewallet)
232 2017-07-18T15:19:17  <bitcoin-git> bitcoin/master 32c9710 Jonas Schnelli: Fix test_bitcoin circular dependency issue
233 2017-07-18T15:20:06  <bitcoin-git> [bitcoin] laanwj closed pull request #10849: Multiwallet: simplest endpoint support (master...2017/07/mw_endpoint_simple) https://github.com/bitcoin/bitcoin/pull/10849
234 2017-07-18T15:20:25  *** talmai has joined #bitcoin-core-dev
235 2017-07-18T15:21:17  <BlueMatt> wumpus: done
236 2017-07-18T15:22:08  <BlueMatt> wumpus: concept ack on 10571, I'm happy to see it merged now and I'll postumously ack it later today
237 2017-07-18T15:22:41  <wumpus> just found a bug in 10571
238 2017-07-18T15:23:11  <BlueMatt> heh, ok, nevermind, then
239 2017-07-18T15:23:30  <BlueMatt> no harm in pushing to 16 imo, no?
240 2017-07-18T15:23:32  <wumpus> a very minor one though just an error message
241 2017-07-18T15:24:27  <BlueMatt> up to you, we have a few weeks bugfix window anyway
242 2017-07-18T15:25:20  <wumpus> well it would be a waste with so many utacks, this is a trivial fix, will wait for achow101
243 2017-07-18T15:26:13  *** pandabull has joined #bitcoin-core-dev
244 2017-07-18T15:28:54  <wumpus> #10784 does need mention in release notes I guess
245 2017-07-18T15:28:55  <gribble> https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
246 2017-07-18T15:29:37  <BlueMatt> indeed
247 2017-07-18T15:30:26  * wumpus wishes people would do that immediately instead of leaving it until the end
248 2017-07-18T15:30:34  <wumpus> but ok, shouldn't hold up merge
249 2017-07-18T15:30:55  <BlueMatt> heh, sorry
250 2017-07-18T15:31:02  <BlueMatt> been a mad rush this last week or two
251 2017-07-18T15:31:32  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bde4f937aebc...9e8d6a3fb43a
252 2017-07-18T15:31:32  <bitcoin-git> bitcoin/master cf82a9e Matt Corallo: Do not allow users to get keys from keypool without reserving them...
253 2017-07-18T15:31:33  <bitcoin-git> bitcoin/master 9e8d6a3 Wladimir J. van der Laan: Merge #10784: Do not allow users to get keys from keypool without reserving them...
254 2017-07-18T15:32:08  <bitcoin-git> [bitcoin] laanwj closed pull request #10784: Do not allow users to get keys from keypool without reserving them (master...2017-07-keep-change) https://github.com/bitcoin/bitcoin/pull/10784
255 2017-07-18T15:40:42  *** jamesob_ has joined #bitcoin-core-dev
256 2017-07-18T15:46:39  *** dabura667 has joined #bitcoin-core-dev
257 2017-07-18T15:56:29  *** talmai has quit IRC
258 2017-07-18T15:59:50  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10867: Allow only a single -usewallet argument (master...2017/07/multiwallet_bitcoincli) https://github.com/bitcoin/bitcoin/pull/10867
259 2017-07-18T16:06:24  <bitcoin-git> [bitcoin] jnewbery opened pull request #10868: Remove -usewallet (master...remove_use_wallet) https://github.com/bitcoin/bitcoin/pull/10868
260 2017-07-18T16:10:29  <jonasschnelli> ^^
261 2017-07-18T16:11:03  *** AaronvanW has joined #bitcoin-core-dev
262 2017-07-18T16:11:58  *** AaronvanW has joined #bitcoin-core-dev
263 2017-07-18T16:25:45  <jonasschnelli> Hmm... isn't the whole wallet endpoint URI encoding really required if we only allow "CHARS_ALPHA_NUM + ".-_"" for wallet filenames?!
264 2017-07-18T16:26:01  <jonasschnelli> I guess it's not. Ping ryanofsky
265 2017-07-18T16:30:57  *** Chris_Stewart_5 has quit IRC
266 2017-07-18T16:31:26  <cfields> jonasschnelli: i wondered about that as well. I tried (unsuccessfully) to get wallets containing sneaky characters to load, and it failed as expected (though sometimes with a segfault that needs to be fixed). I fail to see why it's necessary
267 2017-07-18T16:32:24  <cfields> jonasschnelli: i assumed it was for more robust usage in the future
268 2017-07-18T16:34:10  <jonasschnelli> cfields: yes. That makes sense.
269 2017-07-18T16:35:50  <cfields> jonasschnelli: well that theory is based on absolutely nothing :)
270 2017-07-18T16:38:34  <jonasschnelli> Indeed
271 2017-07-18T16:43:20  *** Prudence has quit IRC
272 2017-07-18T16:55:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
273 2017-07-18T17:06:14  *** Bobby2 has joined #bitcoin-core-dev
274 2017-07-18T17:07:10  *** Bobby2 has quit IRC
275 2017-07-18T17:12:48  *** d_t has joined #bitcoin-core-dev
276 2017-07-18T17:25:55  *** timothy has quit IRC
277 2017-07-18T17:34:38  <ryanofsky> url encoding was suggested when there were still wallet ids. if you want to check for CHARS_ALPHA_NUM in bitcoin-cli instead of percent encoding, that seems fine, though a little more fragile (because maybe we will allow another class of characters in bitcoind and bitcoin-cli will break)
278 2017-07-18T17:35:55  *** dgenr8 has quit IRC
279 2017-07-18T17:36:49  <sipa> i'd rather leave it this way
280 2017-07-18T17:36:56  *** dgenr8 has joined #bitcoin-core-dev
281 2017-07-18T17:46:33  <morcos> wumpus: #10817 is not really a bug fix, but its ready for merge and adds a couple strings
282 2017-07-18T17:46:34  <gribble> https://github.com/bitcoin/bitcoin/issues/10817 | Redefine Dust and add a discard_rate by morcos · Pull Request #10817 · bitcoin/bitcoin · GitHub
283 2017-07-18T17:51:10  *** chjj has quit IRC
284 2017-07-18T17:53:54  *** AaronvanW has quit IRC
285 2017-07-18T17:54:32  *** AaronvanW has joined #bitcoin-core-dev
286 2017-07-18T18:00:01  *** dgenr8 has quit IRC
287 2017-07-18T18:03:11  *** chjj has joined #bitcoin-core-dev
288 2017-07-18T18:10:44  *** deep-book-gk_ has joined #bitcoin-core-dev
289 2017-07-18T18:11:06  *** dgenr8 has joined #bitcoin-core-dev
290 2017-07-18T18:12:43  *** deep-book-gk_ has left #bitcoin-core-dev
291 2017-07-18T18:16:07  *** jnewbery has quit IRC
292 2017-07-18T18:17:10  *** Soledad has joined #bitcoin-core-dev
293 2017-07-18T18:17:12  *** jnewbery has joined #bitcoin-core-dev
294 2017-07-18T18:21:52  *** Soledad has quit IRC
295 2017-07-18T18:25:36  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
296 2017-07-18T18:27:28  *** Chris_Stewart_5 has quit IRC
297 2017-07-18T18:28:02  *** THoVer has joined #bitcoin-core-dev
298 2017-07-18T18:28:59  *** laurentmt has joined #bitcoin-core-dev
299 2017-07-18T18:41:16  *** rookie_123_ has joined #bitcoin-core-dev
300 2017-07-18T18:49:41  *** jtimon has quit IRC
301 2017-07-18T18:52:04  *** arowser has quit IRC
302 2017-07-18T18:53:22  *** jtimon has joined #bitcoin-core-dev
303 2017-07-18T18:55:02  *** THoVer has quit IRC
304 2017-07-18T18:56:36  *** chjj has quit IRC
305 2017-07-18T18:58:18  *** arowser has joined #bitcoin-core-dev
306 2017-07-18T19:08:05  *** chjj has joined #bitcoin-core-dev
307 2017-07-18T19:09:32  <jtimon> jonasschnelli: I'm having problems explaining my suggestion in https://github.com/bitcoin/bips/pull/555
308 2017-07-18T19:09:41  <jtimon> do you understand my suggestion?
309 2017-07-18T19:09:51  <jtimon> perhaps you can help. communication is hard
310 2017-07-18T19:11:26  *** BashCo has quit IRC
311 2017-07-18T19:12:15  *** BashCo has joined #bitcoin-core-dev
312 2017-07-18T19:21:40  *** tiagotrs has joined #bitcoin-core-dev
313 2017-07-18T19:30:50  *** laurentmt has quit IRC
314 2017-07-18T19:35:34  *** AaronvanW has quit IRC
315 2017-07-18T19:36:10  *** AaronvanW has joined #bitcoin-core-dev
316 2017-07-18T19:40:34  *** AaronvanW has quit IRC
317 2017-07-18T19:42:28  <goatpig> jtimon: you to provide the outpoint with the address?
318 2017-07-18T19:42:31  <goatpig> want*
319 2017-07-18T19:44:21  *** paveljanik has joined #bitcoin-core-dev
320 2017-07-18T19:44:35  <jtimon> it seems I missunderstood this comment "The checksum should not contain any salted data. Otherwise with 30bits of non-cryptographic checksum one can easily calculate a TxID that is valid for more than one Network"
321 2017-07-18T19:45:21  <jtimon> he means that since it's only 30 bits of checksum, with 2^15 tries you can create a collision that is valid for more than 1 network.
322 2017-07-18T20:19:05  *** kinetiks has joined #bitcoin-core-dev
323 2017-07-18T20:20:35  *** pandabull has joined #bitcoin-core-dev
324 2017-07-18T20:28:36  *** promag has joined #bitcoin-core-dev
325 2017-07-18T20:35:45  *** AaronvanW has joined #bitcoin-core-dev
326 2017-07-18T20:50:02  *** promag has quit IRC
327 2017-07-18T20:50:39  *** AaronvanW has quit IRC
328 2017-07-18T20:51:15  *** AaronvanW has joined #bitcoin-core-dev
329 2017-07-18T20:51:16  *** rookie_123_ has quit IRC
330 2017-07-18T20:55:44  *** AaronvanW has quit IRC
331 2017-07-18T21:11:55  *** Dyaheon has quit IRC
332 2017-07-18T21:13:54  *** Dyaheon has joined #bitcoin-core-dev
333 2017-07-18T21:25:00  *** Murch has quit IRC
334 2017-07-18T21:25:38  *** Murch has joined #bitcoin-core-dev
335 2017-07-18T21:26:34  *** Murch has joined #bitcoin-core-dev
336 2017-07-18T21:26:49  *** Murch has quit IRC
337 2017-07-18T21:27:22  *** Murch has joined #bitcoin-core-dev
338 2017-07-18T21:35:40  *** tucenaber has joined #bitcoin-core-dev
339 2017-07-18T21:40:05  *** mmgen has quit IRC
340 2017-07-18T21:42:37  *** dabura667 has quit IRC
341 2017-07-18T21:46:28  *** kinetiks has quit IRC
342 2017-07-18T21:46:35  *** promag has joined #bitcoin-core-dev
343 2017-07-18T21:49:18  *** dermoth has quit IRC
344 2017-07-18T21:49:46  *** dermoth has joined #bitcoin-core-dev
345 2017-07-18T21:51:26  *** promag has quit IRC
346 2017-07-18T21:55:21  *** promag has joined #bitcoin-core-dev
347 2017-07-18T21:55:44  *** tiagotrs has quit IRC
348 2017-07-18T21:56:45  *** promag1 has joined #bitcoin-core-dev
349 2017-07-18T21:56:46  *** promag has quit IRC
350 2017-07-18T22:10:20  *** chjj has quit IRC
351 2017-07-18T22:13:20  *** Guest56804 has quit IRC
352 2017-07-18T22:19:49  <bitcoin-git> [bitcoin] achow101 opened pull request #10871: Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) (master...cli-getinfo) https://github.com/bitcoin/bitcoin/pull/10871
353 2017-07-18T22:22:38  *** chjj has joined #bitcoin-core-dev
354 2017-07-18T22:24:06  <bitcoin-git> [bitcoin] eklitzke opened pull request #10872: Docs: Syntax highlight shell commands in the building notes (master...hilite) https://github.com/bitcoin/bitcoin/pull/10872
355 2017-07-18T22:31:30  *** Guyver2 has quit IRC
356 2017-07-18T22:31:54  *** dabura667 has joined #bitcoin-core-dev
357 2017-07-18T22:33:23  *** AaronvanW has joined #bitcoin-core-dev
358 2017-07-18T22:41:20  *** dabura667 has quit IRC
359 2017-07-18T22:46:36  *** ivan has joined #bitcoin-core-dev
360 2017-07-18T22:55:54  *** promag1 has quit IRC
361 2017-07-18T22:56:25  *** DaggerHashimoto has quit IRC
362 2017-07-18T22:59:04  *** promag has joined #bitcoin-core-dev
363 2017-07-18T23:03:23  *** vicenteH has quit IRC
364 2017-07-18T23:10:57  *** BashCo has quit IRC
365 2017-07-18T23:11:33  *** BashCo has joined #bitcoin-core-dev
366 2017-07-18T23:12:47  *** discreteunit has joined #bitcoin-core-dev
367 2017-07-18T23:21:32  *** promag has quit IRC
368 2017-07-18T23:21:51  <jtimon> mhmm it's just me... http://downforeveryoneorjustme.com/github.com
369 2017-07-18T23:23:24  *** corebob has joined #bitcoin-core-dev
370 2017-07-18T23:23:33  *** discreteunit has quit IRC
371 2017-07-18T23:23:40  <jtimon> it's alive! now
372 2017-07-18T23:24:26  <sipa> status.github.com
373 2017-07-18T23:33:18  *** coredump_ has joined #bitcoin-core-dev
374 2017-07-18T23:33:58  <bitcoin-git> [bitcoin] eklitzke opened pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
375 2017-07-18T23:39:56  *** promag has joined #bitcoin-core-dev
376 2017-07-18T23:40:17  *** promag has left #bitcoin-core-dev
377 2017-07-18T23:45:18  *** AaronvanW has quit IRC
378 2017-07-18T23:45:53  *** AaronvanW has joined #bitcoin-core-dev
379 2017-07-18T23:50:05  *** AaronvanW has quit IRC
380 2017-07-18T23:57:07  *** jorge has joined #bitcoin-core-dev
381 2017-07-18T23:57:32  *** jorge is now known as Guest33550