1 2017-07-29T00:01:57  *** snkey has quit IRC
  2 2017-07-29T00:05:30  *** jamesob_ has joined #bitcoin-core-dev
  3 2017-07-29T00:09:50  *** jamesob_ has quit IRC
  4 2017-07-29T00:10:25  *** snkey has joined #bitcoin-core-dev
  5 2017-07-29T00:12:49  *** snq has quit IRC
  6 2017-07-29T00:25:25  <bitcoin-git> [bitcoin] achow101 opened pull request #10952: [wallet] Remove vchDefaultKey and have better first run detection (master...remove-defaultkey) https://github.com/bitcoin/bitcoin/pull/10952
  7 2017-07-29T00:47:36  *** jamesob has quit IRC
  8 2017-07-29T00:51:50  *** nejon has quit IRC
  9 2017-07-29T00:55:47  *** abpa has quit IRC
 10 2017-07-29T01:06:02  *** d9b4bef9 has quit IRC
 11 2017-07-29T01:14:08  *** Deacyded has quit IRC
 12 2017-07-29T01:14:26  *** Deacyded has joined #bitcoin-core-dev
 13 2017-07-29T01:15:11  *** Deacyde has joined #bitcoin-core-dev
 14 2017-07-29T01:16:18  *** nejon has joined #bitcoin-core-dev
 15 2017-07-29T01:36:28  *** justanotheruser has quit IRC
 16 2017-07-29T01:41:00  *** jamesob has joined #bitcoin-core-dev
 17 2017-07-29T01:45:25  *** justanotheruser has joined #bitcoin-core-dev
 18 2017-07-29T01:49:27  *** str4d has quit IRC
 19 2017-07-29T02:01:04  *** Deacydal has joined #bitcoin-core-dev
 20 2017-07-29T02:04:07  *** Deacyde has quit IRC
 21 2017-07-29T02:06:48  *** jamesob_ has joined #bitcoin-core-dev
 22 2017-07-29T02:10:50  *** jamesob_ has quit IRC
 23 2017-07-29T02:13:16  *** Deacydal is now known as Deacyde
 24 2017-07-29T02:16:54  *** snq has joined #bitcoin-core-dev
 25 2017-07-29T02:19:32  *** snkey has quit IRC
 26 2017-07-29T02:33:30  *** deep-book-gk_ has joined #bitcoin-core-dev
 27 2017-07-29T02:34:09  *** deep-book-gk_ has left #bitcoin-core-dev
 28 2017-07-29T02:38:25  *** MeshCollider has joined #bitcoin-core-dev
 29 2017-07-29T02:57:39  *** luke-jr has joined #bitcoin-core-dev
 30 2017-07-29T03:12:15  *** jamesob_ has joined #bitcoin-core-dev
 31 2017-07-29T03:13:37  *** Ylbam has quit IRC
 32 2017-07-29T03:21:07  *** MeshCollider has quit IRC
 33 2017-07-29T03:23:37  *** EagleTM has quit IRC
 34 2017-07-29T03:25:00  *** EagleTM has joined #bitcoin-core-dev
 35 2017-07-29T03:25:23  *** MeshCollider has joined #bitcoin-core-dev
 36 2017-07-29T03:45:38  *** deep-book-gk_ has joined #bitcoin-core-dev
 37 2017-07-29T03:48:16  *** deep-book-gk_ has left #bitcoin-core-dev
 38 2017-07-29T03:53:13  *** jannes has quit IRC
 39 2017-07-29T03:53:35  *** Alina-malina has quit IRC
 40 2017-07-29T03:55:14  *** d9b4bef9 has joined #bitcoin-core-dev
 41 2017-07-29T03:55:35  *** achow101 has quit IRC
 42 2017-07-29T03:59:17  *** MeshCollider has quit IRC
 43 2017-07-29T03:59:25  *** MeshCollider has joined #bitcoin-core-dev
 44 2017-07-29T04:03:19  *** Dyaheon has quit IRC
 45 2017-07-29T04:05:40  *** Dyaheon has joined #bitcoin-core-dev
 46 2017-07-29T04:06:20  *** achow101 has joined #bitcoin-core-dev
 47 2017-07-29T04:07:48  *** jeep-ss has quit IRC
 48 2017-07-29T04:12:42  *** jeep-ss has joined #bitcoin-core-dev
 49 2017-07-29T04:21:03  *** jeep-ss has quit IRC
 50 2017-07-29T04:36:23  *** vicenteH has quit IRC
 51 2017-07-29T04:36:23  *** vicenteH has joined #bitcoin-core-dev
 52 2017-07-29T05:01:52  *** Murch has quit IRC
 53 2017-07-29T05:02:30  *** chjj has joined #bitcoin-core-dev
 54 2017-07-29T05:02:34  *** J-wolf has joined #bitcoin-core-dev
 55 2017-07-29T05:23:21  *** J-wolf has quit IRC
 56 2017-07-29T05:40:55  *** vicenteH` has joined #bitcoin-core-dev
 57 2017-07-29T05:42:37  *** vicenteH has quit IRC
 58 2017-07-29T05:49:54  *** Alina-malina has joined #bitcoin-core-dev
 59 2017-07-29T05:54:17  *** Alina-malina has quit IRC
 60 2017-07-29T05:54:18  *** Alina-malina has joined #bitcoin-core-dev
 61 2017-07-29T05:55:32  *** Alina-malina has quit IRC
 62 2017-07-29T05:55:41  *** Alina-malina_ has joined #bitcoin-core-dev
 63 2017-07-29T06:15:00  *** SopaXorzTaker has quit IRC
 64 2017-07-29T06:21:42  *** Alina-malina_ has quit IRC
 65 2017-07-29T06:21:42  *** Alina-malina_ has joined #bitcoin-core-dev
 66 2017-07-29T06:21:51  *** Alina-malina_ is now known as Alina-malina
 67 2017-07-29T06:30:43  *** jamesob has quit IRC
 68 2017-07-29T06:49:39  *** [b__b] has joined #bitcoin-core-dev
 69 2017-07-29T06:59:00  *** SopaXorzTaker has joined #bitcoin-core-dev
 70 2017-07-29T07:48:08  *** justan0theruser has joined #bitcoin-core-dev
 71 2017-07-29T07:49:26  *** Drabiv has joined #bitcoin-core-dev
 72 2017-07-29T07:50:40  *** justanotheruser has quit IRC
 73 2017-07-29T07:50:51  *** Drabiv has quit IRC
 74 2017-07-29T08:00:22  *** justan0theruser has quit IRC
 75 2017-07-29T08:00:47  *** justanotheruser has joined #bitcoin-core-dev
 76 2017-07-29T08:02:15  *** riemann has joined #bitcoin-core-dev
 77 2017-07-29T08:12:29  *** J-wolf has joined #bitcoin-core-dev
 78 2017-07-29T08:26:22  *** miknotauro has joined #bitcoin-core-dev
 79 2017-07-29T08:46:19  *** d_t has quit IRC
 80 2017-07-29T09:12:49  *** vicenteH` is now known as vicenteH
 81 2017-07-29T09:19:52  *** Yogaqueef has joined #bitcoin-core-dev
 82 2017-07-29T09:26:29  *** SopaXorzTaker has quit IRC
 83 2017-07-29T09:27:21  *** SopaXorzTaker has joined #bitcoin-core-dev
 84 2017-07-29T09:33:37  *** cheese_ has joined #bitcoin-core-dev
 85 2017-07-29T09:36:51  *** Cheeseo has quit IRC
 86 2017-07-29T09:49:05  *** THoVer has joined #bitcoin-core-dev
 87 2017-07-29T10:01:52  *** Ylbam has joined #bitcoin-core-dev
 88 2017-07-29T10:18:01  *** AaronvanW has quit IRC
 89 2017-07-29T10:44:17  *** Giszmo has joined #bitcoin-core-dev
 90 2017-07-29T11:19:29  *** THoVer has quit IRC
 91 2017-07-29T11:25:56  *** twistedline has quit IRC
 92 2017-07-29T11:29:20  *** twistedline has joined #bitcoin-core-dev
 93 2017-07-29T11:38:50  *** Dojixo has joined #bitcoin-core-dev
 94 2017-07-29T12:18:35  *** Giszmo has quit IRC
 95 2017-07-29T12:21:04  *** Giszmo has joined #bitcoin-core-dev
 96 2017-07-29T12:22:07  *** riemann has quit IRC
 97 2017-07-29T12:30:04  *** miknotauro has quit IRC
 98 2017-07-29T12:39:31  *** miknotauro has joined #bitcoin-core-dev
 99 2017-07-29T12:44:10  *** miknotauro has quit IRC
100 2017-07-29T13:21:18  *** MeshCollider has quit IRC
101 2017-07-29T13:31:11  *** AaronvanW has joined #bitcoin-core-dev
102 2017-07-29T13:32:24  *** AaronvanW has joined #bitcoin-core-dev
103 2017-07-29T13:50:19  *** jeep-ss has joined #bitcoin-core-dev
104 2017-07-29T13:57:01  *** laurentmt has joined #bitcoin-core-dev
105 2017-07-29T13:59:33  *** luke-jr has quit IRC
106 2017-07-29T13:59:48  *** luke-jr has joined #bitcoin-core-dev
107 2017-07-29T14:00:33  *** [b__b] has quit IRC
108 2017-07-29T14:27:32  *** goatpig has joined #bitcoin-core-dev
109 2017-07-29T14:36:12  <sam_c> achow101: FYI wrt pr 10952, you can use git add -p to only add parts of the local changes
110 2017-07-29T14:36:25  <sam_c> achow101: this prevents whitespace or other unintentional changes from finding their way into commit.
111 2017-07-29T14:36:34  <sam_c> bit late for that one but good to know :)
112 2017-07-29T14:37:31  *** Deacydal has joined #bitcoin-core-dev
113 2017-07-29T14:38:39  *** Mordan has joined #bitcoin-core-dev
114 2017-07-29T14:40:07  *** Deacyde has quit IRC
115 2017-07-29T14:57:50  *** EagleTM has quit IRC
116 2017-07-29T15:33:42  *** Aaronvan_ has joined #bitcoin-core-dev
117 2017-07-29T15:34:58  *** Aaronvan_ has quit IRC
118 2017-07-29T15:35:04  *** AaronvanW has quit IRC
119 2017-07-29T15:39:52  *** Mordan has quit IRC
120 2017-07-29T15:54:57  *** Dojixo has quit IRC
121 2017-07-29T15:56:02  *** Guyver2 has joined #bitcoin-core-dev
122 2017-07-29T16:01:26  *** Z-Fighter has joined #bitcoin-core-dev
123 2017-07-29T16:03:26  *** snkey has joined #bitcoin-core-dev
124 2017-07-29T16:05:34  *** J-wolf has quit IRC
125 2017-07-29T16:06:07  *** snq has quit IRC
126 2017-07-29T16:10:27  *** praxeology1 has joined #bitcoin-core-dev
127 2017-07-29T16:11:15  *** praxeology1 has quit IRC
128 2017-07-29T16:12:10  *** praxeology has quit IRC
129 2017-07-29T16:12:56  *** praxeology1 has joined #bitcoin-core-dev
130 2017-07-29T16:19:28  *** jeep-ss has quit IRC
131 2017-07-29T16:21:19  *** J-wolf has joined #bitcoin-core-dev
132 2017-07-29T16:21:50  *** AaronvanW has joined #bitcoin-core-dev
133 2017-07-29T16:22:06  *** J-wolf_ has joined #bitcoin-core-dev
134 2017-07-29T16:22:58  *** Aaronvan_ has joined #bitcoin-core-dev
135 2017-07-29T16:23:44  *** Aaronva__ has joined #bitcoin-core-dev
136 2017-07-29T16:25:46  *** J-wolf has quit IRC
137 2017-07-29T16:26:48  *** AaronvanW has quit IRC
138 2017-07-29T16:27:34  *** Aaronvan_ has quit IRC
139 2017-07-29T16:28:09  *** d_t has joined #bitcoin-core-dev
140 2017-07-29T16:31:54  *** snq has joined #bitcoin-core-dev
141 2017-07-29T16:34:28  *** snkey has quit IRC
142 2017-07-29T16:37:25  *** snkey has joined #bitcoin-core-dev
143 2017-07-29T16:37:50  *** sanada has joined #bitcoin-core-dev
144 2017-07-29T16:39:48  *** snq has quit IRC
145 2017-07-29T16:40:03  *** SopaXorzTaker has quit IRC
146 2017-07-29T16:44:31  *** BashCo has joined #bitcoin-core-dev
147 2017-07-29T16:45:42  *** Aaronva__ has quit IRC
148 2017-07-29T16:46:20  *** AaronvanW has joined #bitcoin-core-dev
149 2017-07-29T16:46:57  *** BashCo_ has quit IRC
150 2017-07-29T16:50:55  *** jb55 has joined #bitcoin-core-dev
151 2017-07-29T16:51:28  *** AaronvanW has quit IRC
152 2017-07-29T16:57:18  *** jb55 has quit IRC
153 2017-07-29T17:07:57  *** praxeology1 has quit IRC
154 2017-07-29T17:18:12  *** jamesob has joined #bitcoin-core-dev
155 2017-07-29T17:30:24  *** Guyver2_ has joined #bitcoin-core-dev
156 2017-07-29T17:30:54  *** snq has joined #bitcoin-core-dev
157 2017-07-29T17:33:02  *** Guyver2 has quit IRC
158 2017-07-29T17:33:08  *** Guyver2_ is now known as Guyver2
159 2017-07-29T17:33:37  *** snkey has quit IRC
160 2017-07-29T17:35:56  *** Ylbam has quit IRC
161 2017-07-29T17:51:43  *** J-wolf_ has quit IRC
162 2017-07-29T17:55:10  *** snq has quit IRC
163 2017-07-29T18:04:40  *** SopaXorzTaker has joined #bitcoin-core-dev
164 2017-07-29T18:12:55  *** snq has joined #bitcoin-core-dev
165 2017-07-29T18:14:25  *** SopaXorzTaker has quit IRC
166 2017-07-29T18:14:45  *** SopaXorzTaker has joined #bitcoin-core-dev
167 2017-07-29T18:42:04  *** EagleTM has joined #bitcoin-core-dev
168 2017-07-29T19:11:17  *** laurentmt has quit IRC
169 2017-07-29T19:13:55  *** justan0theruser has joined #bitcoin-core-dev
170 2017-07-29T19:15:42  *** justanotheruser has quit IRC
171 2017-07-29T19:17:06  *** justan0theruser has quit IRC
172 2017-07-29T19:17:39  *** justanotheruser has joined #bitcoin-core-dev
173 2017-07-29T19:24:49  *** BashCo_ has joined #bitcoin-core-dev
174 2017-07-29T19:26:12  *** BashCo has quit IRC
175 2017-07-29T19:41:00  *** Mordan has joined #bitcoin-core-dev
176 2017-07-29T19:43:42  *** jamesob has quit IRC
177 2017-07-29T19:47:50  *** AaronvanW has joined #bitcoin-core-dev
178 2017-07-29T19:48:07  *** zmin has joined #bitcoin-core-dev
179 2017-07-29T19:53:37  *** AaronvanW has quit IRC
180 2017-07-29T19:57:36  *** praxeology has joined #bitcoin-core-dev
181 2017-07-29T20:18:57  *** Guyver2 has quit IRC
182 2017-07-29T20:23:30  *** justan0theruser has joined #bitcoin-core-dev
183 2017-07-29T20:25:56  *** justanotheruser has quit IRC
184 2017-07-29T20:26:56  *** dermoth has quit IRC
185 2017-07-29T20:27:36  *** jeep-ss has joined #bitcoin-core-dev
186 2017-07-29T20:28:56  *** jamesob has joined #bitcoin-core-dev
187 2017-07-29T20:30:28  *** SopaXorzTaker has quit IRC
188 2017-07-29T20:39:53  *** AaronvanW has joined #bitcoin-core-dev
189 2017-07-29T20:42:20  *** dermoth has joined #bitcoin-core-dev
190 2017-07-29T20:43:28  *** zmin has quit IRC
191 2017-07-29T20:52:51  *** Giszmo has quit IRC
192 2017-07-29T20:55:06  <jamesob> how welcome are readability improvement & documentation PRs? low-priority distraction or actually welcome? I see a few things in validation.cpp that could be made a bit more readable.
193 2017-07-29T20:57:17  <gmaxwell> jamesob: they're welcome if that is what they do; but "change the code to my personal style; because I'm not involved with the project enough to distinguish what I'd like with what other contributors would like" wouldn't be, and it's not always easy to tell unless you're heavily involved.
194 2017-07-29T20:57:44  <jamesob> gotcha. maybe I'll save them for when my intuition is better :)
195 2017-07-29T20:58:18  <gmaxwell> comments are probably always good, though they take a fair amount of work to review .. since they need to be right. :)
196 2017-07-29T20:58:33  <jamesob> e.g. this conditional wraps the entirety of this function; I think an early return might be clearer https://github.com/bitcoin/bitcoin/blob/c86b77fc44c74628f5c890c9015338600c69739b/src/validation.cpp#L1238-L1241
197 2017-07-29T21:00:46  <gmaxwell> I think that would be a fine change.  oh also on these kinds of changes, if they're ones that provably don't change behavior (e.g. stripped object code is the same) that's always helpful.
198 2017-07-29T21:01:32  <jamesob> gmaxwell does that amount to comparing the checksum of `bitcoind` before and after change?
199 2017-07-29T21:02:01  <jamesob> probably something a little more granular...
200 2017-07-29T21:02:31  <gmaxwell> .o of the relevant file is more granular.  diffing and objdump of the .o
201 2017-07-29T21:03:05  <jamesob> cool, thanks
202 2017-07-29T21:05:19  <gmaxwell> In any case, our threshold for taking improvements like this is lower if it doesn't change the binary. It's also useful to seperate changes into ones that change the binary and ones that don't-- if it doesn't change the binary we only need to review for style. If it changes it we have to worry about subtle mistakes that break the software. :)
203 2017-07-29T21:07:45  <jamesob> great, good to know. I'm not keen on flooding the PR list with a bunch of [trivial] titles, but I figure if I'm in the neighborhood and can offer some marginal improvement, maybe it's worthwhile.
204 2017-07-29T21:11:25  *** jeep-ss_ has joined #bitcoin-core-dev
205 2017-07-29T21:11:59  *** Giszmo has joined #bitcoin-core-dev
206 2017-07-29T21:12:25  *** d_t has quit IRC
207 2017-07-29T21:12:36  *** jeep-ss has quit IRC
208 2017-07-29T21:12:45  *** jeep-ss_ is now known as jeep-ss
209 2017-07-29T21:12:57  *** d_t has joined #bitcoin-core-dev
210 2017-07-29T21:13:51  <gmaxwell> one thing to do is just rate limit yourself. Do a couple, sleep on it, submit the best of them. Collect feedback, revise the others, submit another later.  You can also earn review attention by making an effort to do things that other people want done but don't want to do.
211 2017-07-29T21:14:15  *** Ylbam has joined #bitcoin-core-dev
212 2017-07-29T21:14:33  <gmaxwell> Or by doing some things which everyone reconizes as clearly useful (clarity fixups are not as universally reconized as useful as writing non-trivial tests, for example)
213 2017-07-29T21:14:39  *** Aaronvan_ has joined #bitcoin-core-dev
214 2017-07-29T21:14:48  *** cysm has quit IRC
215 2017-07-29T21:17:48  *** AaronvanW has quit IRC
216 2017-07-29T21:18:57  <jamesob> roger that!
217 2017-07-29T21:19:18  *** cysm has joined #bitcoin-core-dev
218 2017-07-29T21:31:02  *** Mordan has quit IRC
219 2017-07-29T21:42:36  *** justanotheruser has joined #bitcoin-core-dev
220 2017-07-29T21:43:19  *** justanotheruser has joined #bitcoin-core-dev
221 2017-07-29T21:44:48  *** justan0theruser has quit IRC
222 2017-07-29T22:02:57  *** intcat has quit IRC
223 2017-07-29T22:08:30  *** Deacydal has quit IRC
224 2017-07-29T22:14:41  *** intcat has joined #bitcoin-core-dev
225 2017-07-29T22:17:55  *** Aaronvan_ has quit IRC
226 2017-07-29T22:19:09  *** snq has quit IRC
227 2017-07-29T22:19:27  *** snq has joined #bitcoin-core-dev
228 2017-07-29T22:21:26  *** AaronvanW has joined #bitcoin-core-dev
229 2017-07-29T22:23:04  *** Aaronvan_ has joined #bitcoin-core-dev
230 2017-07-29T22:26:52  *** AaronvanW has quit IRC
231 2017-07-29T22:58:24  *** intcat has quit IRC
232 2017-07-29T22:59:36  *** intcat has joined #bitcoin-core-dev
233 2017-07-29T23:08:24  *** Javon has joined #bitcoin-core-dev
234 2017-07-29T23:24:40  *** Deacyde has joined #bitcoin-core-dev
235 2017-07-29T23:26:38  *** marcoagner has joined #bitcoin-core-dev
236 2017-07-29T23:31:46  *** deep-book-gk_ has joined #bitcoin-core-dev
237 2017-07-29T23:32:05  *** deep-book-gk_ has left #bitcoin-core-dev
238 2017-07-29T23:32:33  *** goatpig has quit IRC
239 2017-07-29T23:54:15  <bitcoin-git> [bitcoin] sipa closed pull request #10946: Add chainwork to getchaintxstats (master...20170727_chainworkstats) https://github.com/bitcoin/bitcoin/pull/10946