1 2017-08-16T00:10:01 *** d9b4bef9 has quit IRC
2 2017-08-16T00:11:08 *** d9b4bef9 has joined #bitcoin-core-dev
3 2017-08-16T00:13:08 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7db65c363a0c...b6a48914c506
4 2017-08-16T00:13:09 <bitcoin-git> bitcoin/master 6e8c48d practicalswift: Add const to methods that do not modify the object for which it is called
5 2017-08-16T00:13:09 <bitcoin-git> bitcoin/master b6a4891 MarcoFalke: Merge #9964: Add const to methods that do not modify the object for which it is called...
6 2017-08-16T00:13:20 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9964: Add const to methods that do not modify the object for which it is called (master...const) https://github.com/bitcoin/bitcoin/pull/9964
7 2017-08-16T00:17:11 *** chjj has joined #bitcoin-core-dev
8 2017-08-16T00:20:50 *** Austindoggie_ has quit IRC
9 2017-08-16T00:20:53 <gmaxwell> 0.15 branch has a warning now
10 2017-08-16T00:20:54 <gmaxwell> wallet/wallet.cpp:3668:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
11 2017-08-16T00:20:58 <gmaxwell> return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT));
12 2017-08-16T00:21:01 <gmaxwell> ^
13 2017-08-16T00:21:03 <gmaxwell> wallet/wallet.cpp:3668:80: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
14 2017-08-16T00:21:06 <gmaxwell> return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT));
15 2017-08-16T00:24:41 <BlueMatt> well we're gonna do an rc2 anyway, for the version issue, right?
16 2017-08-16T00:27:05 <Lightsword> has anyone verified that getentropy is getting built for release builds on osx?
17 2017-08-16T00:32:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6a48914c506...655970d9c60a
18 2017-08-16T00:32:35 <bitcoin-git> bitcoin/master 9862550 practicalswift: Use the noexcept specifier (C++11) instead of deprecated throw()
19 2017-08-16T00:32:36 <bitcoin-git> bitcoin/master 655970d MarcoFalke: Merge #10965: Replace deprecated throw() with noexcept specifier (C++11)...
20 2017-08-16T00:33:07 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10965: Replace deprecated throw() with noexcept specifier (C++11) (master...noexcept) https://github.com/bitcoin/bitcoin/pull/10965
21 2017-08-16T00:34:07 <jimpo> Is it preferred to have function/method comments in the header files or cpp files? (I would think header?)
22 2017-08-16T00:34:59 <sipa> yes, header
23 2017-08-16T00:35:04 <sipa> unless they're implementation details
24 2017-08-16T00:36:06 *** Cheeseo has joined #bitcoin-core-dev
25 2017-08-16T00:37:21 <gmaxwell> jimpo: header should comment the interface, cpp the implementation, generally. (I don't think we've documented it in our coding style docs, but it's my preference)
26 2017-08-16T00:37:45 <jimpo> Understood, thx
27 2017-08-16T00:46:43 *** Murch has quit IRC
28 2017-08-16T00:47:14 *** RoyceX has joined #bitcoin-core-dev
29 2017-08-16T00:48:30 *** Cheeseo has quit IRC
30 2017-08-16T00:48:38 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/655970d9c60a...a46a671e2535
31 2017-08-16T00:48:39 <bitcoin-git> bitcoin/master 3eb53b8 practicalswift: Avoid returning a BIP9Stats object with uninitialized values...
32 2017-08-16T00:48:39 <bitcoin-git> bitcoin/master a46a671 MarcoFalke: Merge #10957: Avoid returning a BIP9Stats object with uninitialized values...
33 2017-08-16T00:49:06 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10957: Avoid returning a BIP9Stats object with uninitialized values (master...bip9status) https://github.com/bitcoin/bitcoin/pull/10957
34 2017-08-16T00:50:57 *** Deacydal has quit IRC
35 2017-08-16T00:51:28 *** Deacydal has joined #bitcoin-core-dev
36 2017-08-16T00:52:41 *** Cheeseo has joined #bitcoin-core-dev
37 2017-08-16T00:55:10 *** RoyceX has quit IRC
38 2017-08-16T01:08:25 *** dabura667 has joined #bitcoin-core-dev
39 2017-08-16T01:15:08 *** twistedline has quit IRC
40 2017-08-16T01:15:22 *** twistedline has joined #bitcoin-core-dev
41 2017-08-16T01:20:26 *** Cheeseo has quit IRC
42 2017-08-16T01:25:47 <bitcoin-git> [bitcoin] jimpo opened pull request #11058: Comments: More comments on functions/globals in standard.h. (master...standard-comments) https://github.com/bitcoin/bitcoin/pull/11058
43 2017-08-16T01:32:25 *** dabura667 has quit IRC
44 2017-08-16T01:32:35 *** jimpo has quit IRC
45 2017-08-16T01:32:46 *** dabura667 has joined #bitcoin-core-dev
46 2017-08-16T01:40:49 *** jtimon has joined #bitcoin-core-dev
47 2017-08-16T01:41:21 *** trippysalmon has quit IRC
48 2017-08-16T01:52:59 *** Chris_Stewart_5 has quit IRC
49 2017-08-16T01:54:26 *** trippysalmon has joined #bitcoin-core-dev
50 2017-08-16T02:03:02 *** jimpo has joined #bitcoin-core-dev
51 2017-08-16T02:05:01 *** Austindoggie has joined #bitcoin-core-dev
52 2017-08-16T02:13:32 *** jtimon has quit IRC
53 2017-08-16T02:15:14 <bitcoin-git> [bitcoin] Ilikenumber0 opened pull request #11059: Its just for education, not a real pull request (master...master) https://github.com/bitcoin/bitcoin/pull/11059
54 2017-08-16T02:17:42 <bitcoin-git> [bitcoin] sipa closed pull request #11059: Its just for education, not a real pull request (master...master) https://github.com/bitcoin/bitcoin/pull/11059
55 2017-08-16T02:25:59 *** d_t has quit IRC
56 2017-08-16T02:59:11 *** Deacyded has joined #bitcoin-core-dev
57 2017-08-16T03:02:31 *** Deacydal has quit IRC
58 2017-08-16T03:08:05 *** jimpo has quit IRC
59 2017-08-16T03:10:23 *** Austindoggie_ has joined #bitcoin-core-dev
60 2017-08-16T03:14:25 *** Austindoggie has quit IRC
61 2017-08-16T03:29:20 *** Chris_Stewart_5 has joined #bitcoin-core-dev
62 2017-08-16T03:45:14 *** jimpo has joined #bitcoin-core-dev
63 2017-08-16T03:57:29 *** Chris_Stewart_5 has quit IRC
64 2017-08-16T04:00:52 *** jimpo has quit IRC
65 2017-08-16T04:02:02 *** d9b4bef9 has quit IRC
66 2017-08-16T04:03:08 *** d9b4bef9 has joined #bitcoin-core-dev
67 2017-08-16T04:04:01 *** d9b4bef9 has quit IRC
68 2017-08-16T04:05:07 *** d9b4bef9 has joined #bitcoin-core-dev
69 2017-08-16T04:09:47 *** jimpo has joined #bitcoin-core-dev
70 2017-08-16T04:17:12 *** jimpo has quit IRC
71 2017-08-16T04:30:31 *** chjj has quit IRC
72 2017-08-16T04:59:41 *** Deacydal has joined #bitcoin-core-dev
73 2017-08-16T05:03:40 *** Deacyded has quit IRC
74 2017-08-16T05:08:14 *** arubi has quit IRC
75 2017-08-16T05:09:37 *** miknotauro has joined #bitcoin-core-dev
76 2017-08-16T05:16:44 *** arubi has joined #bitcoin-core-dev
77 2017-08-16T05:17:17 *** treebear_ has quit IRC
78 2017-08-16T05:22:39 *** jimpo has joined #bitcoin-core-dev
79 2017-08-16T05:26:31 *** d_t has joined #bitcoin-core-dev
80 2017-08-16T05:30:03 *** treebeardd has joined #bitcoin-core-dev
81 2017-08-16T05:41:44 *** elkalamar has quit IRC
82 2017-08-16T05:51:59 *** d_t has quit IRC
83 2017-08-16T05:56:56 *** Deacyded has joined #bitcoin-core-dev
84 2017-08-16T05:58:25 *** chjj has joined #bitcoin-core-dev
85 2017-08-16T06:00:19 *** Deacydal has quit IRC
86 2017-08-16T06:11:40 *** Deacydal has joined #bitcoin-core-dev
87 2017-08-16T06:15:01 *** Deacyded has quit IRC
88 2017-08-16T06:22:13 <wumpus> cfields_: as long as it is deterministic, it is no big deal
89 2017-08-16T06:30:39 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a46a671e2535...d451d0bcf15d
90 2017-08-16T06:30:39 <bitcoin-git> bitcoin/master 844b73e Gregory Sanders: disable jni in builds
91 2017-08-16T06:30:40 <bitcoin-git> bitcoin/master d451d0b Wladimir J. van der Laan: Merge #11056: disable jni in builds...
92 2017-08-16T06:31:19 <bitcoin-git> [bitcoin] laanwj closed pull request #11056: disable jni in builds (master...disablejni) https://github.com/bitcoin/bitcoin/pull/11056
93 2017-08-16T06:40:35 *** jimpo has quit IRC
94 2017-08-16T06:57:37 *** BashCo has quit IRC
95 2017-08-16T06:58:52 *** klebs has joined #bitcoin-core-dev
96 2017-08-16T07:02:53 *** klebs has quit IRC
97 2017-08-16T07:03:16 *** promag has joined #bitcoin-core-dev
98 2017-08-16T07:17:26 *** BashCo has joined #bitcoin-core-dev
99 2017-08-16T07:18:08 *** treebeardd has quit IRC
100 2017-08-16T07:19:38 *** cfields_ is now known as cfields
101 2017-08-16T07:20:25 *** cfields has joined #bitcoin-core-dev
102 2017-08-16T07:36:47 <wumpus> as I had to test binary upload I've already uploaded rc1 to both sites https://bitcoin.org/bin/bitcoin-core-0.15.0/test.rc1/ https://bitcoincore.org/bin/bitcoin-core-0.15.0/test.rc1/ - but we should wait with announcing this publicly until there's at least two more gitian sigs for the code-signed executables
103 2017-08-16T07:50:09 *** cryptapus has joined #bitcoin-core-dev
104 2017-08-16T07:56:10 *** promag has quit IRC
105 2017-08-16T07:58:02 *** promag has joined #bitcoin-core-dev
106 2017-08-16T08:06:40 *** promag has quit IRC
107 2017-08-16T08:12:41 *** Austindoggie_ has quit IRC
108 2017-08-16T08:25:22 <bitcoin-git> [bitcoin] kallewoof opened pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (master...mempool-alreadythere) https://github.com/bitcoin/bitcoin/pull/11062
109 2017-08-16T08:31:06 *** fanquake has joined #bitcoin-core-dev
110 2017-08-16T08:31:13 <fanquake> wumpus I've pushed up signed sigs
111 2017-08-16T08:42:34 *** Austindoggie_ has joined #bitcoin-core-dev
112 2017-08-16T08:46:36 *** vicenteH has joined #bitcoin-core-dev
113 2017-08-16T08:52:30 *** Austindoggie_ has quit IRC
114 2017-08-16T08:58:03 *** grandfso has joined #bitcoin-core-dev
115 2017-08-16T09:20:07 *** goatpig has joined #bitcoin-core-dev
116 2017-08-16T09:22:56 *** miknotauro has quit IRC
117 2017-08-16T09:35:30 *** Guyver2 has joined #bitcoin-core-dev
118 2017-08-16T09:40:50 *** justan0theruser has quit IRC
119 2017-08-16T10:07:43 *** JackH has quit IRC
120 2017-08-16T10:23:33 *** AaronvanW has joined #bitcoin-core-dev
121 2017-08-16T10:48:18 <wumpus> fanquake: thanks!
122 2017-08-16T10:59:59 *** shesek has joined #bitcoin-core-dev
123 2017-08-16T11:00:08 *** shesek has joined #bitcoin-core-dev
124 2017-08-16T11:19:51 *** promag has joined #bitcoin-core-dev
125 2017-08-16T11:26:57 *** AaronvanW has quit IRC
126 2017-08-16T11:31:33 *** AaronvanW has joined #bitcoin-core-dev
127 2017-08-16T11:37:29 *** jtimon has joined #bitcoin-core-dev
128 2017-08-16T11:39:47 *** grandfso_ has joined #bitcoin-core-dev
129 2017-08-16T11:42:57 *** grandfso has quit IRC
130 2017-08-16T11:50:05 *** grandfso_ has quit IRC
131 2017-08-16T11:50:12 *** grandfso has joined #bitcoin-core-dev
132 2017-08-16T11:57:41 *** Deacyde has joined #bitcoin-core-dev
133 2017-08-16T11:59:46 *** Deacydal has quit IRC
134 2017-08-16T12:09:42 *** fanquake has quit IRC
135 2017-08-16T12:12:43 *** dabura667 has quit IRC
136 2017-08-16T12:46:28 *** justanotheruser has joined #bitcoin-core-dev
137 2017-08-16T12:51:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
138 2017-08-16T13:02:17 *** promag has quit IRC
139 2017-08-16T13:26:38 *** promag has joined #bitcoin-core-dev
140 2017-08-16T13:37:26 *** jtimon has quit IRC
141 2017-08-16T13:59:06 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d451d0bcf15d...c484ec6c9b85
142 2017-08-16T13:59:06 <bitcoin-git> bitcoin/master 36d326e practicalswift: Use nullptr instead of zero (0) as the null pointer constant
143 2017-08-16T13:59:07 <bitcoin-git> bitcoin/master c484ec6 MarcoFalke: Merge #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant...
144 2017-08-16T13:59:26 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant (master...welcome-nullptr-goodbye-0) https://github.com/bitcoin/bitcoin/pull/10645
145 2017-08-16T14:00:49 *** arubi has quit IRC
146 2017-08-16T14:01:19 *** arubi has joined #bitcoin-core-dev
147 2017-08-16T14:12:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c484ec6c9b85...22e301a3d56d
148 2017-08-16T14:12:48 <bitcoin-git> bitcoin/master a622a17 João Barbosa: Fix constness of ArgsManager methods
149 2017-08-16T14:12:50 <bitcoin-git> bitcoin/master 22e301a MarcoFalke: Merge #10901: Fix constness of ArgsManager methods...
150 2017-08-16T14:13:20 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10901: Fix constness of ArgsManager methods (master...2017-07-args-manager-constness) https://github.com/bitcoin/bitcoin/pull/10901
151 2017-08-16T14:45:13 *** Chris_Stewart_5 has quit IRC
152 2017-08-16T14:45:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
153 2017-08-16T14:50:04 *** Skynets has quit IRC
154 2017-08-16T14:50:24 *** Cheeseo has joined #bitcoin-core-dev
155 2017-08-16T14:50:29 *** Murch has joined #bitcoin-core-dev
156 2017-08-16T14:51:20 *** Skynets has joined #bitcoin-core-dev
157 2017-08-16T14:58:54 *** grandfso has quit IRC
158 2017-08-16T15:07:27 <BlueMatt> alrighty, what should I be reviewing?
159 2017-08-16T15:20:54 *** hwl3o has joined #bitcoin-core-dev
160 2017-08-16T15:24:01 <promag> BlueMatt: #11006 it's one line :P
161 2017-08-16T15:28:42 <bitcoin-git> [bitcoin] practicalswift opened pull request #11066: Document the preference of nullptr over NULL or (void*)0 (master...document-nullptr-preference) https://github.com/bitcoin/bitcoin/pull/11066
162 2017-08-16T15:36:06 <gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
163 2017-08-16T15:49:55 <BlueMatt> cfields: can you rebase #10756 ?
164 2017-08-16T15:51:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11067: [qa] TestNode: Add wait_until_node_stopped helper method (master...Mf1708-qaTestnodeWaitStopHelper) https://github.com/bitcoin/bitcoin/pull/11067
165 2017-08-16T15:51:53 <cfields> BlueMatt: sure
166 2017-08-16T15:55:39 *** BashCo has quit IRC
167 2017-08-16T16:01:17 <gribble> https://github.com/bitcoin/bitcoin/issues/10756 | net processing: swap out signals for an interface class by theuni · Pull Request #10756 · bitcoin/bitcoin · GitHub
168 2017-08-16T16:08:01 <BlueMatt> cfields: thnks, gonna take a crack at rebasing on it :)
169 2017-08-16T16:14:42 *** BashCo has joined #bitcoin-core-dev
170 2017-08-16T16:17:43 *** SopaXorzTaker has quit IRC
171 2017-08-16T16:19:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11068: [WIP] qa: Replace wait_until with wait_until_mn (scripted) (master...Mf1708-qaWaitUntilMiniNode) https://github.com/bitcoin/bitcoin/pull/11068
172 2017-08-16T16:25:00 *** d_t has joined #bitcoin-core-dev
173 2017-08-16T16:56:16 <bitcoin-git> [bitcoin] popenkomaksim opened pull request #11069: Trivial: Lossless image optimization. (master...master) https://github.com/bitcoin/bitcoin/pull/11069
174 2017-08-16T17:03:47 *** jtimon has joined #bitcoin-core-dev
175 2017-08-16T17:04:52 *** PaulCapestany has quit IRC
176 2017-08-16T17:15:59 *** Chris_Stewart_5 has quit IRC
177 2017-08-16T17:17:03 *** Giszmo has joined #bitcoin-core-dev
178 2017-08-16T17:17:57 *** ekerstein has joined #bitcoin-core-dev
179 2017-08-16T17:17:57 *** promag has quit IRC
180 2017-08-16T17:18:08 *** PaulCapestany has joined #bitcoin-core-dev
181 2017-08-16T17:18:46 *** paveljanik has quit IRC
182 2017-08-16T17:18:59 *** paveljanik has joined #bitcoin-core-dev
183 2017-08-16T17:19:47 *** paveljanik has quit IRC
184 2017-08-16T17:19:57 *** Chris_Stewart_5 has joined #bitcoin-core-dev
185 2017-08-16T17:31:48 <cfields> morcos: ping
186 2017-08-16T17:33:17 <cfields> morcos: while profiling some new net code yesterday, i noticed that TxConfirmStats::UpdateMovingAverages is a notable hotspot
187 2017-08-16T17:34:00 <cfields> during IBD, it accounted for ~5-10% of the message handler thread
188 2017-08-16T17:34:59 *** cheese_ has joined #bitcoin-core-dev
189 2017-08-16T17:35:46 <cfields> cpu usage, that is
190 2017-08-16T17:37:28 *** vicenteH has quit IRC
191 2017-08-16T17:38:09 *** Austindoggie_ has joined #bitcoin-core-dev
192 2017-08-16T17:39:19 <sipa> cfields: during IBD? :o
193 2017-08-16T17:39:52 <cfields> sipa: that was my thought :\
194 2017-08-16T17:40:03 <cfields> IBD up to 200k blocks, anyway
195 2017-08-16T17:45:23 <BlueMatt> cfields: well, it'll be in the background in 16 :/
196 2017-08-16T17:46:12 <cfields> BlueMatt: surely it's not necessary until we're nearly caught up?
197 2017-08-16T17:51:40 <sdaftuar> cfields: i'd guess the implementation is probably just trying to make sure that the estimates properly decay when a node is catching up after being down for a while
198 2017-08-16T17:55:07 <cfields> well i have a quick optim to speed up that function, but i figured it'd just result in a discussion about avoiding it during early IBD
199 2017-08-16T17:55:24 <gmaxwell> I assume a simple branch to skip decays when everything is zero would speed that right up.
200 2017-08-16T17:55:46 <cfields> I'll PR the speedup, and create an issue to discuss avoidance
201 2017-08-16T17:56:22 <gmaxwell> sipa: we test too much with reindex chainstate
202 2017-08-16T17:56:23 *** Austindoggie_ has quit IRC
203 2017-08-16T17:56:50 <cfields> gmaxwell: ah, i was wondering why you hadn't nagged about it :)
204 2017-08-16T18:04:12 *** To7 has quit IRC
205 2017-08-16T18:06:21 *** RoyceX has joined #bitcoin-core-dev
206 2017-08-16T18:08:50 *** Cheeseo has quit IRC
207 2017-08-16T18:11:26 *** RoyceX has quit IRC
208 2017-08-16T18:20:28 *** jimpo has joined #bitcoin-core-dev
209 2017-08-16T18:20:58 *** jtimon has quit IRC
210 2017-08-16T18:21:28 *** owowo has quit IRC
211 2017-08-16T18:22:53 <cfields> BlueMatt: rebased
212 2017-08-16T18:26:29 *** owowo has joined #bitcoin-core-dev
213 2017-08-16T18:37:50 *** Giszmo has quit IRC
214 2017-08-16T18:44:56 *** elkalamar has joined #bitcoin-core-dev
215 2017-08-16T18:45:20 *** SopaXorzTaker has joined #bitcoin-core-dev
216 2017-08-16T18:55:46 *** ekerstein has quit IRC
217 2017-08-16T18:58:50 <BlueMatt> gmaxwell: well its gonna be slow after sync anyway, so just move it into the background where it wont slow down ibd at all and will be fast later, too :p
218 2017-08-16T18:58:52 <BlueMatt> cfields: thanks
219 2017-08-16T19:00:10 <gmaxwell> BlueMatt: well I agree, but a branch on already zero is perhaps a four line change.
220 2017-08-16T19:03:44 *** ekerstein has joined #bitcoin-core-dev
221 2017-08-16T19:04:17 <BlueMatt> gmaxwell: a branch to put it in the background is probably 3 at this point :p
222 2017-08-16T19:06:28 <BlueMatt> can someone remind me whats left to switch the sync.h stuff to std::mutex?
223 2017-08-16T19:06:41 <BlueMatt> looks like it may be needed for #10923
224 2017-08-16T19:07:05 <gribble> https://github.com/bitcoin/bitcoin/issues/10923 | Use -Wthread-safety-analysis if available (+ -Werror=[â¦] if --enable-werror) by practicalswift · Pull Request #10923 · bitcoin/bitcoin · GitHub
225 2017-08-16T19:13:51 *** goatpig has quit IRC
226 2017-08-16T19:15:05 *** Chris_Stewart_5 has quit IRC
227 2017-08-16T19:15:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
228 2017-08-16T19:22:26 *** ekerstein has quit IRC
229 2017-08-16T19:27:44 *** justanotheruser has quit IRC
230 2017-08-16T19:33:39 *** ekerstein has joined #bitcoin-core-dev
231 2017-08-16T19:34:28 <bitcoin-git> [bitcoin] practicalswift opened pull request #11071: Use static_assert(â¦, â¦) instead of assert(â¦) where appropriate (master...static_assert) https://github.com/bitcoin/bitcoin/pull/11071
232 2017-08-16T19:37:11 <morcos> cfields: hmm... that's somewhat surprising, but yes i guess if all the other operations are basically very quick with the early blocks, that one takes just as long
233 2017-08-16T19:37:19 <morcos> i'd be happy to look at your speedup
234 2017-08-16T19:38:15 <morcos> i think we could also do something relatively simple to avoid doing it if blocks are less than some reasonable checkpointed height or something
235 2017-08-16T19:38:47 *** Austindoggie_ has joined #bitcoin-core-dev
236 2017-08-16T19:42:09 *** ekerstei_ has joined #bitcoin-core-dev
237 2017-08-16T19:42:13 *** eck has quit IRC
238 2017-08-16T19:42:28 *** ekerstein has quit IRC
239 2017-08-16T19:42:32 *** eck has joined #bitcoin-core-dev
240 2017-08-16T19:42:57 *** Chris_Stewart_5 has quit IRC
241 2017-08-16T19:44:13 *** eck has quit IRC
242 2017-08-16T19:44:31 *** eck has joined #bitcoin-core-dev
243 2017-08-16T19:44:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
244 2017-08-16T19:46:13 *** eck has quit IRC
245 2017-08-16T19:46:40 *** eck has joined #bitcoin-core-dev
246 2017-08-16T19:48:20 *** eck has joined #bitcoin-core-dev
247 2017-08-16T19:52:58 *** Chris_Stewart_5 has quit IRC
248 2017-08-16T19:54:27 *** SopaXorzTaker has quit IRC
249 2017-08-16T19:55:05 <BlueMatt> morcos: the height-at-which-0.15-was-released is sufficient, cause your estimates get wiped anyway :p
250 2017-08-16T19:55:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
251 2017-08-16T20:01:09 *** Skynets has quit IRC
252 2017-08-16T20:02:58 *** Chris_Stewart_5 has quit IRC
253 2017-08-16T20:03:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
254 2017-08-16T20:04:54 *** vicenteH has joined #bitcoin-core-dev
255 2017-08-16T20:32:30 *** Austindoggie_ has quit IRC
256 2017-08-16T20:39:28 *** Austindoggie_ has joined #bitcoin-core-dev
257 2017-08-16T20:54:43 *** treebeardd has joined #bitcoin-core-dev
258 2017-08-16T21:00:45 <jimpo> If I rebroadcast an already-confirmed transaction, will Bitcoin Core nodes add it as an orphan tx?
259 2017-08-16T21:03:14 <sipa> it may
260 2017-08-16T21:04:54 <jimpo> I see this https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L545
261 2017-08-16T21:05:42 <jimpo> When would an old output be in the pcoinsTip cache?
262 2017-08-16T21:06:14 <sipa> because its output isn't spent yet
263 2017-08-16T21:06:37 <jimpo> OK, makes sense
264 2017-08-16T21:17:11 <jimpo> So in the case where you rebroadcast a transaction with all spent outputs, and it is added as an orphan, the node will then reject all of the parent transactions to that one?
265 2017-08-16T21:17:20 <jimpo> request* not reject
266 2017-08-16T21:17:40 <sipa> right, which other peers likely don't have anymore
267 2017-08-16T21:23:28 *** jimpo has quit IRC
268 2017-08-16T21:31:08 *** harrymm1 has joined #bitcoin-core-dev
269 2017-08-16T21:32:20 *** harrymm has quit IRC
270 2017-08-16T21:34:51 *** jimpo has joined #bitcoin-core-dev
271 2017-08-16T21:48:50 *** Chris_Stewart_5 has quit IRC
272 2017-08-16T21:50:09 *** Guyver2 has quit IRC
273 2017-08-16T21:55:33 *** ekerstei_ has quit IRC
274 2017-08-16T23:30:29 *** echonaut has quit IRC
275 2017-08-16T23:30:51 *** echonaut has joined #bitcoin-core-dev
276 2017-08-16T23:35:42 *** shesek has quit IRC
277 2017-08-16T23:36:36 *** jtimon has joined #bitcoin-core-dev
278 2017-08-16T23:39:01 *** juscamarena has joined #bitcoin-core-dev
279 2017-08-16T23:39:25 *** juscamarena is now known as Guest18809
280 2017-08-16T23:41:01 *** juscamarena_ has quit IRC
281 2017-08-16T23:46:30 *** Murch has quit IRC
282 2017-08-16T23:47:01 *** d9b4bef9 has quit IRC
283 2017-08-16T23:48:07 *** d9b4bef9 has joined #bitcoin-core-dev
284 2017-08-16T23:52:12 *** justanotheruser has joined #bitcoin-core-dev
285 2017-08-16T23:52:56 *** justanotheruser has joined #bitcoin-core-dev
286 2017-08-16T23:59:20 *** belcher has quit IRC