1 2017-08-25T00:14:59  *** Aaronvan_ has quit IRC
  2 2017-08-25T00:19:42  *** davec has joined #bitcoin-core-dev
  3 2017-08-25T00:23:21  *** RoyceX has quit IRC
  4 2017-08-25T00:29:24  *** promag has joined #bitcoin-core-dev
  5 2017-08-25T00:32:07  *** pandabull has joined #bitcoin-core-dev
  6 2017-08-25T00:33:06  *** promag has quit IRC
  7 2017-08-25T00:34:01  *** promag has joined #bitcoin-core-dev
  8 2017-08-25T00:34:16  *** chjj has quit IRC
  9 2017-08-25T00:35:25  *** promag has quit IRC
 10 2017-08-25T00:37:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 11 2017-08-25T00:41:47  *** goatpig has quit IRC
 12 2017-08-25T00:42:39  *** owowo has quit IRC
 13 2017-08-25T00:42:52  *** promag has joined #bitcoin-core-dev
 14 2017-08-25T00:46:08  *** chjj has joined #bitcoin-core-dev
 15 2017-08-25T00:49:17  *** jtimon has quit IRC
 16 2017-08-25T00:53:22  *** promag has quit IRC
 17 2017-08-25T00:54:18  *** owowo has joined #bitcoin-core-dev
 18 2017-08-25T00:56:14  *** LeandroBellini has joined #bitcoin-core-dev
 19 2017-08-25T00:57:27  *** praxeology1 has quit IRC
 20 2017-08-25T00:57:38  *** promag has joined #bitcoin-core-dev
 21 2017-08-25T00:58:09  *** LeandroBellini has quit IRC
 22 2017-08-25T00:59:39  *** dabura667 has joined #bitcoin-core-dev
 23 2017-08-25T01:00:41  *** promag has quit IRC
 24 2017-08-25T01:01:38  *** promag has joined #bitcoin-core-dev
 25 2017-08-25T01:02:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/77fc469fc78c...3f726c99f819
 26 2017-08-25T01:02:43  <bitcoin-git> bitcoin/master f1708ef practicalswift: Add recommendation: By default, declare single-argument constructors `explicit`
 27 2017-08-25T01:02:44  <bitcoin-git> bitcoin/master 3f726c9 MarcoFalke: Merge #11112: [developer-notes] By default, declare single-argument constructors "explicit"...
 28 2017-08-25T01:03:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11112: [developer-notes] By default, declare single-argument constructors "explicit" (master...declare-single-argument-constructors-explicit) https://github.com/bitcoin/bitcoin/pull/11112
 29 2017-08-25T01:13:24  *** sniip3r has quit IRC
 30 2017-08-25T01:13:59  *** andreacab has joined #bitcoin-core-dev
 31 2017-08-25T01:30:05  *** andreacab has quit IRC
 32 2017-08-25T01:33:20  *** Chris_Stewart_5 has quit IRC
 33 2017-08-25T01:58:57  *** shesek has quit IRC
 34 2017-08-25T02:19:34  *** instagibbs has quit IRC
 35 2017-08-25T02:20:21  *** instagibbs has joined #bitcoin-core-dev
 36 2017-08-25T02:23:26  *** Deadhand has quit IRC
 37 2017-08-25T02:24:35  *** sipa has quit IRC
 38 2017-08-25T02:25:29  *** sipa has joined #bitcoin-core-dev
 39 2017-08-25T02:27:17  *** Murch has quit IRC
 40 2017-08-25T02:29:47  *** Deadhand has joined #bitcoin-core-dev
 41 2017-08-25T02:32:51  *** praxeology has joined #bitcoin-core-dev
 42 2017-08-25T02:37:09  *** shesek has joined #bitcoin-core-dev
 43 2017-08-25T02:39:41  *** arubi has quit IRC
 44 2017-08-25T02:39:56  *** praxeology1 has joined #bitcoin-core-dev
 45 2017-08-25T02:40:02  *** arubi has joined #bitcoin-core-dev
 46 2017-08-25T02:41:50  *** praxeology1 has left #bitcoin-core-dev
 47 2017-08-25T02:42:40  *** praxeology has quit IRC
 48 2017-08-25T02:47:38  *** praxeology1 has joined #bitcoin-core-dev
 49 2017-08-25T03:01:14  *** Murch has joined #bitcoin-core-dev
 50 2017-08-25T03:09:03  <luke-jr> hm, do we still warn about BIP91?
 51 2017-08-25T03:28:11  *** ghost43 has quit IRC
 52 2017-08-25T03:28:32  *** Deadhand has quit IRC
 53 2017-08-25T03:28:35  *** ghost43 has joined #bitcoin-core-dev
 54 2017-08-25T03:31:48  <meshcollider> sipa: gmaxwell is the idea that the full serialised transaction has to be obtainable just from the compressed transaction, for hashing, etc? i.e. no throwing away of data even if it's unused but hashed?
 55 2017-08-25T03:31:50  *** Deadhand has joined #bitcoin-core-dev
 56 2017-08-25T03:39:12  *** dermoth has quit IRC
 57 2017-08-25T03:45:03  <Lightsword> luke-jr, warn about what in regards to BIP91?
 58 2017-08-25T03:46:14  <sipa> meshcollider: indeed
 59 2017-08-25T03:46:48  <luke-jr> Lightsword: unknown versionbit deployment
 60 2017-08-25T03:47:28  <Lightsword> luke-jr, why would it be showing anything anymore? it didn’t use.a 2016 block activation period so it shouldn’t show as activated
 61 2017-08-25T03:49:05  <Lightsword> hmm, well I do see “Warning: Unknown block versions being mined! It's possible unknown rules are in effect” but that’s not a version bit specific warning right?
 62 2017-08-25T03:49:27  *** Deacyded has joined #bitcoin-core-dev
 63 2017-08-25T03:49:47  <Lightsword> warning='59 of last 100 blocks have unexpected version'
 64 2017-08-25T03:50:16  <sipa> Lightsword: those are from miners who are still signalling segwit
 65 2017-08-25T03:50:26  <sipa> not bip91
 66 2017-08-25T03:50:30  <Lightsword> yep…guess I’ll tell them to turn that off
 67 2017-08-25T03:52:30  *** Deacydal has quit IRC
 68 2017-08-25T04:03:23  <luke-jr> ah
 69 2017-08-25T04:10:05  *** dermoth has joined #bitcoin-core-dev
 70 2017-08-25T04:10:33  <gmaxwell> meshcollider: because the hashes are normative there is no unused data.
 71 2017-08-25T04:17:21  *** promag has quit IRC
 72 2017-08-25T04:18:09  <meshcollider> i mean unused in the sense of having no actual function, not just unused in general. E.g. the transaction locktime, if all the sequence numbers are set to 0xffffffff
 73 2017-08-25T04:19:54  <gmaxwell> meshcollider: almost always the locktime is zero in that case, however.
 74 2017-08-25T04:23:12  <meshcollider> yeah I'd imagine so, so most of the time it would be encoded in the TxHeader in that case right 👍
 75 2017-08-25T04:25:30  <meshcollider> what is the reason for choosing 0-14 for the nLockTime = TxVersionCode? Why 14?
 76 2017-08-25T04:30:23  <gmaxwell> that is a misprint, that is nVersion = TxVersionCode.
 77 2017-08-25T04:30:48  <gmaxwell> (because why would nLocktime be _versionCode_ :) )
 78 2017-08-25T04:31:13  <gmaxwell> so tx versions 0-14 are explicitly coded, and any version greater than that ends up as a uint32.
 79 2017-08-25T04:32:10  <meshcollider> mhm I did wonder haha, seemed odd. sipa, you might want to update that
 80 2017-08-25T04:32:24  <gmaxwell> the document isn't really intended for public consumption.
 81 2017-08-25T04:33:06  <gmaxwell> (not to say that he won't fix it, but this is just working notes)
 82 2017-08-25T04:36:24  <meshcollider> regardless, was there any specific reason for choosing 14 for the version code?
 83 2017-08-25T04:37:39  *** gmac83 has joined #bitcoin-core-dev
 84 2017-08-25T04:38:53  <gmaxwell> because it room for plenty of transaction versions, and leaves space to signal future encoding versions.
 85 2017-08-25T04:40:54  *** gmac83 has left #bitcoin-core-dev
 86 2017-08-25T04:42:01  *** treebeardd has joined #bitcoin-core-dev
 87 2017-08-25T04:45:23  <meshcollider> makes sense :) are the blank sections not thought out or just not written up
 88 2017-08-25T04:46:13  <meshcollider> guessing the latter because back references sounds like something which wouldn't just be added in without a plan
 89 2017-08-25T04:53:54  <gmaxwell> it's just not written up. pieter implemented an encoder, which is how we know what the space savings is.
 90 2017-08-25T04:54:27  <gmaxwell> (actually it looks like all the parts are actually describe in the bulleted lists, but not explained)
 91 2017-08-25T05:03:06  *** treebeardd has quit IRC
 92 2017-08-25T05:14:27  <meshcollider> it looks really well thought out and comprehensive to me, that's awesome :) so would compressed blocks just have a new compressed block header and contain compressed transactions like this?
 93 2017-08-25T05:16:03  <luke-jr> meshcollider: blocks aren't typically transmitted as a big data blob anymore anyway
 94 2017-08-25T05:16:25  <gmaxwell> except in ibd.
 95 2017-08-25T05:16:42  <gmaxwell> it's just an alternative encoding of transactions, and blocks are transmited as a header and a bunch of transactions.
 96 2017-08-25T05:18:01  <meshcollider> Ah I guess block headers are only 80 bytes anyway, probably not worth even trying to compress them more?
 97 2017-08-25T05:18:33  <luke-jr> they're already compressed somewhat IIRC
 98 2017-08-25T05:18:46  <gmaxwell> well for headers messages it's useful to compact them, but thats pretty orthorgonal to blocks.
 99 2017-08-25T05:18:47  <luke-jr> (when sent as a chain, the prevblock part is skipped)
100 2017-08-25T05:19:10  <gmaxwell> in a message that sends a lot of headers you can roughly halve their size.
101 2017-08-25T05:25:11  *** laurentmt has joined #bitcoin-core-dev
102 2017-08-25T05:25:50  *** laurentmt has quit IRC
103 2017-08-25T05:41:55  *** Bluewolf33 has quit IRC
104 2017-08-25T05:58:04  *** Bluewolf33 has joined #bitcoin-core-dev
105 2017-08-25T06:02:55  *** Bluewolf33 has quit IRC
106 2017-08-25T06:42:19  *** Giszmo has quit IRC
107 2017-08-25T06:45:28  *** laurentmt has joined #bitcoin-core-dev
108 2017-08-25T06:47:38  *** ghost43 has quit IRC
109 2017-08-25T06:48:08  *** ghost43 has joined #bitcoin-core-dev
110 2017-08-25T06:51:02  *** BashCo has quit IRC
111 2017-08-25T06:59:35  *** Giszmo has joined #bitcoin-core-dev
112 2017-08-25T07:04:28  *** MarcoFalke has quit IRC
113 2017-08-25T07:05:57  *** MarcoFalke has joined #bitcoin-core-dev
114 2017-08-25T07:06:01  *** laurentmt has quit IRC
115 2017-08-25T07:07:57  <gmaxwell> ::sigh::
116 2017-08-25T07:08:08  <gmaxwell> 2017-08-25 06:50:40.485126 UpdateTip: new best=0000000000000000007a3061573f5bba379cc02eb472e96f0941d37548fd2982 height=481946 version=0x20000002 log2_work=86.989803 tx=249281504 date='2017-08-25 06:50:23' progress=1.000000 cache=14.2MiB(50014txo) warning='60 of last 100 blocks have unexpected version'
117 2017-08-25T07:15:35  *** BashCo has joined #bitcoin-core-dev
118 2017-08-25T07:17:34  <gmaxwell> wumpus: gonna updates submittx for segwit?
119 2017-08-25T07:18:16  <wumpus> gmaxwell: it's in the plans
120 2017-08-25T07:18:30  *** JackH has joined #bitcoin-core-dev
121 2017-08-25T07:24:49  <gmaxwell> wumpus: hurray.
122 2017-08-25T07:42:11  *** promag has joined #bitcoin-core-dev
123 2017-08-25T07:52:15  <Murch> gmaxwell: Am I correct to assume that SegWit will be supported in 0.15.1 and that could be expected shortly after 0.15?
124 2017-08-25T07:54:30  <gmaxwell> yes, thats our current tenative plan.
125 2017-08-25T07:54:49  <gmaxwell> (I say tenative just because the work hasn't been done yet, people are working on it)
126 2017-08-25T07:55:19  <gmaxwell> (of course, much of the backend wallet support was already done as part of the development of segwit itself... just not the more user facing parts)
127 2017-08-25T07:56:33  *** arubi has quit IRC
128 2017-08-25T07:57:16  *** promag has quit IRC
129 2017-08-25T07:59:07  <Murch> okay
130 2017-08-25T08:00:12  <Murch> By the way that was our TX: https://www.smartbit.com.au/tx/bf031d49f30565e2c66a9ee736d1bf6ccebcadb46c922ee899d179aa1e1aaf45 :)
131 2017-08-25T08:01:55  *** afk11 has quit IRC
132 2017-08-25T08:02:16  *** afk11 has joined #bitcoin-core-dev
133 2017-08-25T08:04:51  *** Murch has quit IRC
134 2017-08-25T08:07:48  *** ghost43 has quit IRC
135 2017-08-25T08:08:29  *** ghost43 has joined #bitcoin-core-dev
136 2017-08-25T08:22:17  *** goatpig has joined #bitcoin-core-dev
137 2017-08-25T08:29:32  *** promag has joined #bitcoin-core-dev
138 2017-08-25T08:32:35  *** promag has quit IRC
139 2017-08-25T08:38:33  <gmaxwell> 00000000000000000139cb443e16442fcd07a4a0e0788dd045ee3cf268982016  ... A block larger than 1MB!
140 2017-08-25T08:38:54  <gmaxwell> also, three cheers for bc.i for actually displaying this fact! https://blockchain.info/block-height/481947
141 2017-08-25T08:39:27  <gmaxwell> murch: congrats on your txn.
142 2017-08-25T08:39:52  *** promag has joined #bitcoin-core-dev
143 2017-08-25T08:49:40  *** promag has quit IRC
144 2017-08-25T08:52:54  *** promag has joined #bitcoin-core-dev
145 2017-08-25T08:54:44  *** vicenteH has joined #bitcoin-core-dev
146 2017-08-25T08:55:56  *** promag has quit IRC
147 2017-08-25T08:56:53  *** alreadylate has joined #bitcoin-core-dev
148 2017-08-25T08:57:03  *** Dyaheon has quit IRC
149 2017-08-25T08:58:47  *** alreadylate has quit IRC
150 2017-08-25T08:59:52  *** Dyaheon has joined #bitcoin-core-dev
151 2017-08-25T09:01:10  *** promag has joined #bitcoin-core-dev
152 2017-08-25T09:04:02  *** promag1 has joined #bitcoin-core-dev
153 2017-08-25T09:08:03  *** promag has quit IRC
154 2017-08-25T09:09:14  *** promag1 has quit IRC
155 2017-08-25T09:10:41  *** juscamarena has joined #bitcoin-core-dev
156 2017-08-25T09:11:28  *** promag has joined #bitcoin-core-dev
157 2017-08-25T09:11:55  <juscamarena> I made this one that made it go over 1MB https://blockchain.info/tx/8ef2d3c3e8ff4d937746aa39677b347c043287c1fbfeda34b9c241f1e85173ec thanks again for segwit! Works great!
158 2017-08-25T09:13:13  <gmaxwell> juscamarena: thanks. we noticed the block earlier.
159 2017-08-25T09:13:28  <gmaxwell> we need to do more work reaching out to miners and getting them to fix their settings, lots of confusion.
160 2017-08-25T09:13:52  <gmaxwell> (there have been several other points where my node would have mined a greater than 1MB block... but the miner that got the block had a 1MB limit.)
161 2017-08-25T09:13:57  <juscamarena> We would have gotten an earlier one but yeah
162 2017-08-25T09:17:13  *** AaronvanW has joined #bitcoin-core-dev
163 2017-08-25T09:20:58  *** promag has quit IRC
164 2017-08-25T09:21:38  *** promag has joined #bitcoin-core-dev
165 2017-08-25T09:26:45  *** arubi has joined #bitcoin-core-dev
166 2017-08-25T09:30:54  *** AaronvanW has quit IRC
167 2017-08-25T09:31:31  *** AaronvanW has joined #bitcoin-core-dev
168 2017-08-25T09:41:10  *** promag has joined #bitcoin-core-dev
169 2017-08-25T09:49:25  *** ghost43 has quit IRC
170 2017-08-25T09:49:51  *** ghost43 has joined #bitcoin-core-dev
171 2017-08-25T09:56:20  *** dabura667 has quit IRC
172 2017-08-25T10:11:22  *** alreadylate has joined #bitcoin-core-dev
173 2017-08-25T10:25:11  *** ghost43 has quit IRC
174 2017-08-25T10:26:01  *** ghost43 has joined #bitcoin-core-dev
175 2017-08-25T10:26:44  *** jtimon has joined #bitcoin-core-dev
176 2017-08-25T10:44:34  *** tiagotrs has joined #bitcoin-core-dev
177 2017-08-25T10:47:33  *** tiagotrs has quit IRC
178 2017-08-25T10:47:34  *** tiagotrs has joined #bitcoin-core-dev
179 2017-08-25T10:58:05  *** riemann has joined #bitcoin-core-dev
180 2017-08-25T10:59:05  <bitcoin-git> [bitcoin] laanwj opened pull request #11131: rpc: Write authcookie atomically (master...2017_08_atomic_cookie) https://github.com/bitcoin/bitcoin/pull/11131
181 2017-08-25T11:06:21  *** Austindoggie has joined #bitcoin-core-dev
182 2017-08-25T11:06:43  *** Jimmy_ has joined #bitcoin-core-dev
183 2017-08-25T11:17:02  *** johnpark_pj has quit IRC
184 2017-08-25T11:22:27  *** tiagotrs has quit IRC
185 2017-08-25T11:22:41  *** tiagotrs has joined #bitcoin-core-dev
186 2017-08-25T11:25:16  *** schnerchi has quit IRC
187 2017-08-25T11:31:51  *** tiagotrs has quit IRC
188 2017-08-25T11:31:51  *** tiagotrs has joined #bitcoin-core-dev
189 2017-08-25T11:33:30  *** alreadylate has quit IRC
190 2017-08-25T11:41:18  *** schnerchi has joined #bitcoin-core-dev
191 2017-08-25T11:54:09  *** alreadylate has joined #bitcoin-core-dev
192 2017-08-25T11:57:28  <sturles> Is there a patch to make segwit addresses for change outputs?
193 2017-08-25T12:32:46  *** SopaXorzTaker has quit IRC
194 2017-08-25T12:32:46  *** jannes has quit IRC
195 2017-08-25T12:32:46  *** earlz has quit IRC
196 2017-08-25T12:32:46  *** mr_burdell has quit IRC
197 2017-08-25T12:32:47  *** zxzzt has quit IRC
198 2017-08-25T12:32:47  *** morcos has quit IRC
199 2017-08-25T12:32:58  *** morcos has joined #bitcoin-core-dev
200 2017-08-25T12:33:01  *** mr_burdell has joined #bitcoin-core-dev
201 2017-08-25T12:33:01  *** earlz has joined #bitcoin-core-dev
202 2017-08-25T12:33:07  *** zxzzt has joined #bitcoin-core-dev
203 2017-08-25T12:33:14  *** jannes has joined #bitcoin-core-dev
204 2017-08-25T12:33:15  *** SopaXorzTaker has joined #bitcoin-core-dev
205 2017-08-25T12:36:00  <bitcoin-git> [bitcoin] practicalswift opened pull request #11132: [wallet] Document assumptions that must be fulfilled to avoid NULL pointer dereferences (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/11132
206 2017-08-25T12:52:32  *** promag has joined #bitcoin-core-dev
207 2017-08-25T12:54:07  *** belcher has joined #bitcoin-core-dev
208 2017-08-25T12:59:51  *** alreadylate has quit IRC
209 2017-08-25T13:01:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11129: [qa] util: Poll cookie file size before reading (master...Mf1708-qaPollCookie) https://github.com/bitcoin/bitcoin/pull/11129
210 2017-08-25T13:14:23  *** ems has joined #bitcoin-core-dev
211 2017-08-25T13:19:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
212 2017-08-25T13:29:15  <instagibbs> what exactly does contrib/verify-commits/verify-commits.sh do?
213 2017-08-25T13:34:15  <MarcoFalke> read the commits, starting from HEAD, checking if there is at least one signed parent
214 2017-08-25T13:34:33  *** ghost43 has quit IRC
215 2017-08-25T13:34:42  <MarcoFalke> only taking into account the keys of maintainers
216 2017-08-25T13:34:50  *** ghost43 has joined #bitcoin-core-dev
217 2017-08-25T13:35:28  *** Dyaheon has quit IRC
218 2017-08-25T13:36:05  *** Eliel has joined #bitcoin-core-dev
219 2017-08-25T13:36:19  *** Guyver2 has joined #bitcoin-core-dev
220 2017-08-25T13:37:03  *** Dyaheon has joined #bitcoin-core-dev
221 2017-08-25T13:37:15  *** promag has quit IRC
222 2017-08-25T13:40:01  *** str4d has joined #bitcoin-core-dev
223 2017-08-25T13:47:35  *** promag has joined #bitcoin-core-dev
224 2017-08-25T14:00:08  *** guggero has joined #bitcoin-core-dev
225 2017-08-25T14:01:35  <bitcoin-git> [bitcoin] practicalswift opened pull request #11133: Document assumptions that must be fulfilled to avoid division by zero (master...div0) https://github.com/bitcoin/bitcoin/pull/11133
226 2017-08-25T14:11:32  *** Chris_Stewart_5 has quit IRC
227 2017-08-25T14:17:14  *** rafalcpp has quit IRC
228 2017-08-25T14:18:18  *** rafalcpp has joined #bitcoin-core-dev
229 2017-08-25T14:27:21  *** rafalcpp has quit IRC
230 2017-08-25T14:28:23  *** rafalcpp has joined #bitcoin-core-dev
231 2017-08-25T14:28:58  *** rafalcpp has joined #bitcoin-core-dev
232 2017-08-25T14:30:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
233 2017-08-25T14:37:28  <promag> Maybe we should make all RPC responses an JSON object, that way it is easier to avoid breaking changes cc instagibbs
234 2017-08-25T14:39:59  <instagibbs> promag, in general avoiding breakage is good, but I think verifytxoutproof is a bit less used(and isn't returning what's actually required to be entirely useful)
235 2017-08-25T14:41:11  <promag> yeah, I mean maybe add developer note for future calls.
236 2017-08-25T14:55:28  <bitcoin-git> [bitcoin] promag opened pull request #11135: Add RPC response notes (master...2017-08-rpc-response-notes) https://github.com/bitcoin/bitcoin/pull/11135
237 2017-08-25T14:57:25  *** riemann has quit IRC
238 2017-08-25T14:58:47  *** promag has quit IRC
239 2017-08-25T15:01:36  *** promag has joined #bitcoin-core-dev
240 2017-08-25T15:27:40  *** JackH has quit IRC
241 2017-08-25T15:32:30  *** Chris_Stewart_5 has quit IRC
242 2017-08-25T15:33:12  *** otoburb has joined #bitcoin-core-dev
243 2017-08-25T15:33:22  *** tiagotrs has quit IRC
244 2017-08-25T15:34:51  *** tiagotrs has joined #bitcoin-core-dev
245 2017-08-25T15:40:47  *** Dyaheon has quit IRC
246 2017-08-25T15:41:48  *** Dyaheon has joined #bitcoin-core-dev
247 2017-08-25T15:45:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
248 2017-08-25T15:47:45  *** vicenteH has quit IRC
249 2017-08-25T15:52:13  *** promag has quit IRC
250 2017-08-25T15:55:44  *** marcoagner has quit IRC
251 2017-08-25T15:58:31  *** hasten has joined #bitcoin-core-dev
252 2017-08-25T16:02:24  *** hasten has joined #bitcoin-core-dev
253 2017-08-25T16:03:06  *** t00tie has joined #bitcoin-core-dev
254 2017-08-25T16:03:30  *** t00tie has left #bitcoin-core-dev
255 2017-08-25T16:05:27  <bitcoin-git> [bitcoin] danra opened pull request #11136: Docs: Add python3 to list of dependencies on macOS (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11136
256 2017-08-25T16:07:17  *** marcoagner has joined #bitcoin-core-dev
257 2017-08-25T16:08:17  *** tiagotrs has quit IRC
258 2017-08-25T16:08:17  *** tiagotrs has joined #bitcoin-core-dev
259 2017-08-25T16:20:25  *** Dizzle has joined #bitcoin-core-dev
260 2017-08-25T16:21:31  *** praxeology1 has quit IRC
261 2017-08-25T16:24:04  <bitcoin-git> [bitcoin] danra opened pull request #11138: Compat: Simplify bswap_16 implementation (master...patch-2) https://github.com/bitcoin/bitcoin/pull/11138
262 2017-08-25T16:29:34  <luke-jr> jonasschnelli: what's the status of your stats_*_tmp branches? seems you added a typo? O.o
263 2017-08-25T16:29:45  <luke-jr> (precision -> percision)
264 2017-08-25T16:30:27  <luke-jr> hm, or maybe the rpc one is obsolete
265 2017-08-25T16:30:48  <luke-jr> or both are :x
266 2017-08-25T16:32:00  <bitcoin-git> [bitcoin] danra opened pull request #11139: Trivial: Whitespace in bswap_64 implementation (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11139
267 2017-08-25T16:32:18  *** Chris_Stewart_5 has quit IRC
268 2017-08-25T16:35:06  *** guggero has left #bitcoin-core-dev
269 2017-08-25T16:40:22  *** Austindoggie_ has joined #bitcoin-core-dev
270 2017-08-25T16:40:59  <bitcoin-git> [bitcoin] danra opened pull request #11140: Trivial: Improve #endif comments (master...patch-4) https://github.com/bitcoin/bitcoin/pull/11140
271 2017-08-25T16:44:07  *** Austindoggie has quit IRC
272 2017-08-25T16:46:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
273 2017-08-25T16:57:36  *** ems has quit IRC
274 2017-08-25T16:58:41  *** jimpo has joined #bitcoin-core-dev
275 2017-08-25T16:59:53  *** promag has joined #bitcoin-core-dev
276 2017-08-25T17:03:10  *** jimpo has quit IRC
277 2017-08-25T17:03:33  *** promag has quit IRC
278 2017-08-25T17:05:03  *** juscamarena has quit IRC
279 2017-08-25T17:08:34  *** ems has joined #bitcoin-core-dev
280 2017-08-25T17:11:20  <bitcoin-git> [bitcoin] wrapperband opened pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
281 2017-08-25T17:13:35  *** Giszmo has quit IRC
282 2017-08-25T17:17:08  *** rhavar has joined #bitcoin-core-dev
283 2017-08-25T17:17:46  *** Giszmo has joined #bitcoin-core-dev
284 2017-08-25T17:18:19  <rhavar> For a "pure" segwit transaction (p2sh) is this formula correct:  estimatedVSizeOfSegwitTransaction(inputCount, outputCount) { return 92 * inputCount + 12 + 32 * outputCount; }
285 2017-08-25T17:21:56  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
286 2017-08-25T17:28:14  <bitcoin-git> [bitcoin] danra opened pull request #11143: Fix include path for bitcoin-config.h (master...patch-5) https://github.com/bitcoin/bitcoin/pull/11143
287 2017-08-25T17:37:39  *** Austindoggie_ has quit IRC
288 2017-08-25T17:42:21  *** Austindoggie_ has joined #bitcoin-core-dev
289 2017-08-25T17:43:58  *** Dyaheon has quit IRC
290 2017-08-25T17:46:59  *** Dyaheon has joined #bitcoin-core-dev
291 2017-08-25T17:47:28  *** Austindoggie_ has quit IRC
292 2017-08-25T17:48:21  *** praxeology has joined #bitcoin-core-dev
293 2017-08-25T17:50:59  *** praxeology has left #bitcoin-core-dev
294 2017-08-25T17:59:46  *** promag has joined #bitcoin-core-dev
295 2017-08-25T18:07:10  *** Aaronvan_ has joined #bitcoin-core-dev
296 2017-08-25T18:08:41  *** promag has quit IRC
297 2017-08-25T18:10:09  *** AaronvanW has quit IRC
298 2017-08-25T18:21:44  *** Ixje has joined #bitcoin-core-dev
299 2017-08-25T18:39:45  *** ems has quit IRC
300 2017-08-25T18:43:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11139: Trivial: Whitespace in bswap_64 implementation (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11139
301 2017-08-25T18:49:50  *** Ixje has left #bitcoin-core-dev
302 2017-08-25T19:02:36  *** chjj has quit IRC
303 2017-08-25T19:03:42  *** BashCo has quit IRC
304 2017-08-25T19:04:16  *** jimpo has joined #bitcoin-core-dev
305 2017-08-25T19:04:21  *** BashCo has joined #bitcoin-core-dev
306 2017-08-25T19:06:52  *** jimpo has quit IRC
307 2017-08-25T19:07:41  *** jimpo has joined #bitcoin-core-dev
308 2017-08-25T19:08:39  *** BashCo has quit IRC
309 2017-08-25T19:13:40  <bitcoin-git> [bitcoin] danra opened pull request #11144: Move local include to before system includes (master...patch-6) https://github.com/bitcoin/bitcoin/pull/11144
310 2017-08-25T19:14:58  *** chjj has joined #bitcoin-core-dev
311 2017-08-25T19:16:21  *** vicenteH has joined #bitcoin-core-dev
312 2017-08-25T19:24:16  *** jtimon has quit IRC
313 2017-08-25T19:27:08  *** BashCo has joined #bitcoin-core-dev
314 2017-08-25T19:31:26  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3f726c99f819...07c92b98e2a0
315 2017-08-25T19:31:27  <bitcoin-git> bitcoin/master d97fe20 Russell Yanofsky: Move some static functions out of wallet.h/cpp...
316 2017-08-25T19:31:27  <bitcoin-git> bitcoin/master e7fe320 Russell Yanofsky: MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp
317 2017-08-25T19:31:28  <bitcoin-git> bitcoin/master f01103c Russell Yanofsky: MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp
318 2017-08-25T19:31:49  *** BashCo_ has joined #bitcoin-core-dev
319 2017-08-25T19:32:01  <bitcoin-git> [bitcoin] laanwj closed pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (master...pr/wmove) https://github.com/bitcoin/bitcoin/pull/10976
320 2017-08-25T19:32:58  *** eikzbtc has joined #bitcoin-core-dev
321 2017-08-25T19:33:21  *** BashCo has quit IRC
322 2017-08-25T19:49:05  *** Dyaheon has quit IRC
323 2017-08-25T19:51:12  *** Dyaheon has joined #bitcoin-core-dev
324 2017-08-25T20:04:10  <luke-jr> wumpus: can we get #7339 reopened and in? apparently it won't be n/a as early as expect
325 2017-08-25T20:11:54  *** promag has joined #bitcoin-core-dev
326 2017-08-25T20:14:15  *** eikzbtc has left #bitcoin-core-dev
327 2017-08-25T20:15:01  <bitcoin-git> [bitcoin] morcos opened pull request #11145: Fix rounding bug in calculation of minimum change (master...fixrounding) https://github.com/bitcoin/bitcoin/pull/11145
328 2017-08-25T20:15:16  <morcos> ok sorry guys if i killed 0.15 being on time, please review ^^ ASAP
329 2017-08-25T20:20:29  *** vicenteH has quit IRC
330 2017-08-25T20:20:36  *** vicenteH has joined #bitcoin-core-dev
331 2017-08-25T20:21:56  *** arubi has quit IRC
332 2017-08-25T20:22:49  *** Dizzle has quit IRC
333 2017-08-25T20:23:05  *** promag has quit IRC
334 2017-08-25T20:23:49  <instagibbs> you can blame the person reporting :P
335 2017-08-25T20:27:16  * sipa blames the person who merged the PR that introduced the error
336 2017-08-25T20:27:19  <sipa> oh, wait...
337 2017-08-25T20:31:03  <MarcoFalke> I blame Satoshi
338 2017-08-25T20:34:20  *** Svenson has joined #bitcoin-core-dev
339 2017-08-25T20:35:07  *** arubi has joined #bitcoin-core-dev
340 2017-08-25T20:36:32  *** jtimon has joined #bitcoin-core-dev
341 2017-08-25T20:39:08  <gmaxwell> well I'm very glad to have found this, would have been an irritating issue. "payments randomly fail" :(
342 2017-08-25T20:43:50  *** alreadylate has joined #bitcoin-core-dev
343 2017-08-25T20:44:01  *** juscamarena has joined #bitcoin-core-dev
344 2017-08-25T20:44:25  *** juscamarena is now known as Guest85153
345 2017-08-25T20:52:17  *** tiagotrs has quit IRC
346 2017-08-25T20:57:25  *** sipa has quit IRC
347 2017-08-25T20:57:25  *** sipa has joined #bitcoin-core-dev
348 2017-08-25T21:02:40  *** Aaronvan_ has quit IRC
349 2017-08-25T21:03:20  *** AaronvanW has joined #bitcoin-core-dev
350 2017-08-25T21:06:16  *** alreadylate has quit IRC
351 2017-08-25T21:07:02  *** alreadylate has joined #bitcoin-core-dev
352 2017-08-25T21:12:40  <bitcoin-git> [bitcoin] eaxvac opened pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (master...master) https://github.com/bitcoin/bitcoin/pull/11147
353 2017-08-25T21:12:54  <bitcoin-git> [bitcoin] eaxvac closed pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (master...master) https://github.com/bitcoin/bitcoin/pull/11147
354 2017-08-25T21:16:02  *** Deacydal has joined #bitcoin-core-dev
355 2017-08-25T21:17:41  <bitcoin-git> [bitcoin] danra opened pull request #11148: Trivial: Fix outdated comment (master...patch-7) https://github.com/bitcoin/bitcoin/pull/11148
356 2017-08-25T21:19:01  *** Guest85153 has quit IRC
357 2017-08-25T21:19:40  *** Deacyded has quit IRC
358 2017-08-25T21:20:59  *** Guest85153 has joined #bitcoin-core-dev
359 2017-08-25T21:21:03  *** Guyver2 has quit IRC
360 2017-08-25T21:21:35  <morcos> gmaxwell: yeah unfortunately there are a lot o changes in that code, where fees and change can be adjusted...  so its really hard to think through and be sure there isn't some edge case we're missing.
361 2017-08-25T21:22:37  <gmaxwell> I feel like we should have some kind of exceptional case flagging infrastructure. So that there are varrious exceptional cases which are triggerable, but should only be triggered by a specific test and otherwise we want to know about them.
362 2017-08-25T21:22:39  <morcos> it'll be nice to rewrite all this for 0.16...  and i think i still feel it's safer to error there rather than risk continuing in some way
363 2017-08-25T21:44:32  *** Svenson has quit IRC
364 2017-08-25T21:45:55  *** alreadylate has quit IRC
365 2017-08-25T21:47:09  *** alreadylate has joined #bitcoin-core-dev
366 2017-08-25T21:52:45  *** tiagotrs has joined #bitcoin-core-dev
367 2017-08-25T21:52:48  *** Guest85153 is now known as juscamarena
368 2017-08-25T21:58:11  *** belcher has quit IRC
369 2017-08-25T22:11:05  *** tiagotrs has quit IRC
370 2017-08-25T22:11:31  *** spinza has quit IRC
371 2017-08-25T22:11:35  *** marcoagner has quit IRC
372 2017-08-25T22:18:35  *** promag has joined #bitcoin-core-dev
373 2017-08-25T22:20:54  *** Yogaqueef has joined #bitcoin-core-dev
374 2017-08-25T22:25:39  <bitcoin-git> [bitcoin] danra opened pull request #11149: Use prefix instead of postfix increment/decrement for non-trivial typ… (master...prefix-increment) https://github.com/bitcoin/bitcoin/pull/11149
375 2017-08-25T22:33:23  *** spinza has joined #bitcoin-core-dev
376 2017-08-25T22:38:06  <bitcoin-git> [bitcoin] mess110 opened pull request #11150: [tests] Add getmininginfo functional tests (master...test_rpc_getmininginfo) https://github.com/bitcoin/bitcoin/pull/11150
377 2017-08-25T22:48:28  *** alreadylate has quit IRC
378 2017-08-25T22:52:38  <MarcoFalke> Where did juscamarena report the issue about the fee "rounding bug"?
379 2017-08-25T22:54:17  <instagibbs> MarcoFalke, originally to me, I forwarded to morcos since it was code he wrote(IIRC)
380 2017-08-25T22:55:41  *** cheese_ has joined #bitcoin-core-dev
381 2017-08-25T22:56:36  *** juscamarena has quit IRC
382 2017-08-25T22:57:04  *** juscamarena has joined #bitcoin-core-dev
383 2017-08-25T22:57:13  *** juscamarena is now known as juscamarena_
384 2017-08-25T22:59:34  *** juscamarena_ is now known as juscamarena
385 2017-08-25T23:04:08  *** juscamarena has quit IRC
386 2017-08-25T23:07:21  *** chjj has quit IRC
387 2017-08-25T23:09:56  <MarcoFalke> Ah
388 2017-08-25T23:10:01  *** alreadylate has joined #bitcoin-core-dev
389 2017-08-25T23:10:10  *** alreadylate has quit IRC
390 2017-08-25T23:10:26  <MarcoFalke> So the issue is that fees are *underpayed*
391 2017-08-25T23:10:56  *** str4d has quit IRC
392 2017-08-25T23:11:07  <MarcoFalke> s/payed/paid/
393 2017-08-25T23:21:13  *** chjj has joined #bitcoin-core-dev
394 2017-08-25T23:21:44  *** promag has quit IRC
395 2017-08-25T23:23:08  *** tiagotrs has joined #bitcoin-core-dev
396 2017-08-25T23:37:39  *** chjj has quit IRC
397 2017-08-25T23:39:31  *** RoyceX has joined #bitcoin-core-dev
398 2017-08-25T23:42:10  *** cheese_ has quit IRC
399 2017-08-25T23:49:21  <instagibbs> it re-tries assuming it has enough input value, then somehow doesn't, and panics
400 2017-08-25T23:49:54  *** chjj has joined #bitcoin-core-dev