12017-08-25T00:14:59  *** Aaronvan_ has quit IRC
  22017-08-25T00:19:42  *** davec has joined #bitcoin-core-dev
  32017-08-25T00:23:21  *** RoyceX has quit IRC
  42017-08-25T00:29:24  *** promag has joined #bitcoin-core-dev
  52017-08-25T00:32:07  *** pandabull has joined #bitcoin-core-dev
  62017-08-25T00:33:06  *** promag has quit IRC
  72017-08-25T00:34:01  *** promag has joined #bitcoin-core-dev
  82017-08-25T00:34:16  *** chjj has quit IRC
  92017-08-25T00:35:25  *** promag has quit IRC
 102017-08-25T00:37:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 112017-08-25T00:41:47  *** goatpig has quit IRC
 122017-08-25T00:42:39  *** owowo has quit IRC
 132017-08-25T00:42:52  *** promag has joined #bitcoin-core-dev
 142017-08-25T00:46:08  *** chjj has joined #bitcoin-core-dev
 152017-08-25T00:49:17  *** jtimon has quit IRC
 162017-08-25T00:53:22  *** promag has quit IRC
 172017-08-25T00:54:18  *** owowo has joined #bitcoin-core-dev
 182017-08-25T00:56:14  *** LeandroBellini has joined #bitcoin-core-dev
 192017-08-25T00:57:27  *** praxeology1 has quit IRC
 202017-08-25T00:57:38  *** promag has joined #bitcoin-core-dev
 212017-08-25T00:58:09  *** LeandroBellini has quit IRC
 222017-08-25T00:59:39  *** dabura667 has joined #bitcoin-core-dev
 232017-08-25T01:00:41  *** promag has quit IRC
 242017-08-25T01:01:38  *** promag has joined #bitcoin-core-dev
 252017-08-25T01:02:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/77fc469fc78c...3f726c99f819
 262017-08-25T01:02:43  <bitcoin-git> bitcoin/master f1708ef practicalswift: Add recommendation: By default, declare single-argument constructors `explicit`
 272017-08-25T01:02:44  <bitcoin-git> bitcoin/master 3f726c9 MarcoFalke: Merge #11112: [developer-notes] By default, declare single-argument constructors "explicit"...
 282017-08-25T01:03:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11112: [developer-notes] By default, declare single-argument constructors "explicit" (master...declare-single-argument-constructors-explicit) https://github.com/bitcoin/bitcoin/pull/11112
 292017-08-25T01:13:24  *** sniip3r has quit IRC
 302017-08-25T01:13:59  *** andreacab has joined #bitcoin-core-dev
 312017-08-25T01:30:05  *** andreacab has quit IRC
 322017-08-25T01:33:20  *** Chris_Stewart_5 has quit IRC
 332017-08-25T01:58:57  *** shesek has quit IRC
 342017-08-25T02:19:34  *** instagibbs has quit IRC
 352017-08-25T02:20:21  *** instagibbs has joined #bitcoin-core-dev
 362017-08-25T02:23:26  *** Deadhand has quit IRC
 372017-08-25T02:24:35  *** sipa has quit IRC
 382017-08-25T02:25:29  *** sipa has joined #bitcoin-core-dev
 392017-08-25T02:27:17  *** Murch has quit IRC
 402017-08-25T02:29:47  *** Deadhand has joined #bitcoin-core-dev
 412017-08-25T02:32:51  *** praxeology has joined #bitcoin-core-dev
 422017-08-25T02:37:09  *** shesek has joined #bitcoin-core-dev
 432017-08-25T02:39:41  *** arubi has quit IRC
 442017-08-25T02:39:56  *** praxeology1 has joined #bitcoin-core-dev
 452017-08-25T02:40:02  *** arubi has joined #bitcoin-core-dev
 462017-08-25T02:41:50  *** praxeology1 has left #bitcoin-core-dev
 472017-08-25T02:42:40  *** praxeology has quit IRC
 482017-08-25T02:47:38  *** praxeology1 has joined #bitcoin-core-dev
 492017-08-25T03:01:14  *** Murch has joined #bitcoin-core-dev
 502017-08-25T03:09:03  <luke-jr> hm, do we still warn about BIP91?
 512017-08-25T03:28:11  *** ghost43 has quit IRC
 522017-08-25T03:28:32  *** Deadhand has quit IRC
 532017-08-25T03:28:35  *** ghost43 has joined #bitcoin-core-dev
 542017-08-25T03:31:48  <meshcollider> sipa: gmaxwell is the idea that the full serialised transaction has to be obtainable just from the compressed transaction, for hashing, etc? i.e. no throwing away of data even if it's unused but hashed?
 552017-08-25T03:31:50  *** Deadhand has joined #bitcoin-core-dev
 562017-08-25T03:39:12  *** dermoth has quit IRC
 572017-08-25T03:45:03  <Lightsword> luke-jr, warn about what in regards to BIP91?
 582017-08-25T03:46:14  <sipa> meshcollider: indeed
 592017-08-25T03:46:48  <luke-jr> Lightsword: unknown versionbit deployment
 602017-08-25T03:47:28  <Lightsword> luke-jr, why would it be showing anything anymore? it didn’t use.a 2016 block activation period so it shouldn’t show as activated
 612017-08-25T03:49:05  <Lightsword> hmm, well I do see “Warning: Unknown block versions being mined! It's possible unknown rules are in effect” but that’s not a version bit specific warning right?
 622017-08-25T03:49:27  *** Deacyded has joined #bitcoin-core-dev
 632017-08-25T03:49:47  <Lightsword> warning='59 of last 100 blocks have unexpected version'
 642017-08-25T03:50:16  <sipa> Lightsword: those are from miners who are still signalling segwit
 652017-08-25T03:50:26  <sipa> not bip91
 662017-08-25T03:50:30  <Lightsword> yep…guess I’ll tell them to turn that off
 672017-08-25T03:52:30  *** Deacydal has quit IRC
 682017-08-25T04:03:23  <luke-jr> ah
 692017-08-25T04:10:05  *** dermoth has joined #bitcoin-core-dev
 702017-08-25T04:10:33  <gmaxwell> meshcollider: because the hashes are normative there is no unused data.
 712017-08-25T04:17:21  *** promag has quit IRC
 722017-08-25T04:18:09  <meshcollider> i mean unused in the sense of having no actual function, not just unused in general. E.g. the transaction locktime, if all the sequence numbers are set to 0xffffffff
 732017-08-25T04:19:54  <gmaxwell> meshcollider: almost always the locktime is zero in that case, however.
 742017-08-25T04:23:12  <meshcollider> yeah I'd imagine so, so most of the time it would be encoded in the TxHeader in that case right 👍
 752017-08-25T04:25:30  <meshcollider> what is the reason for choosing 0-14 for the nLockTime = TxVersionCode? Why 14?
 762017-08-25T04:30:23  <gmaxwell> that is a misprint, that is nVersion = TxVersionCode.
 772017-08-25T04:30:48  <gmaxwell> (because why would nLocktime be _versionCode_ :) )
 782017-08-25T04:31:13  <gmaxwell> so tx versions 0-14 are explicitly coded, and any version greater than that ends up as a uint32.
 792017-08-25T04:32:10  <meshcollider> mhm I did wonder haha, seemed odd. sipa, you might want to update that
 802017-08-25T04:32:24  <gmaxwell> the document isn't really intended for public consumption.
 812017-08-25T04:33:06  <gmaxwell> (not to say that he won't fix it, but this is just working notes)
 822017-08-25T04:36:24  <meshcollider> regardless, was there any specific reason for choosing 14 for the version code?
 832017-08-25T04:37:39  *** gmac83 has joined #bitcoin-core-dev
 842017-08-25T04:38:53  <gmaxwell> because it room for plenty of transaction versions, and leaves space to signal future encoding versions.
 852017-08-25T04:40:54  *** gmac83 has left #bitcoin-core-dev
 862017-08-25T04:42:01  *** treebeardd has joined #bitcoin-core-dev
 872017-08-25T04:45:23  <meshcollider> makes sense :) are the blank sections not thought out or just not written up
 882017-08-25T04:46:13  <meshcollider> guessing the latter because back references sounds like something which wouldn't just be added in without a plan
 892017-08-25T04:53:54  <gmaxwell> it's just not written up. pieter implemented an encoder, which is how we know what the space savings is.
 902017-08-25T04:54:27  <gmaxwell> (actually it looks like all the parts are actually describe in the bulleted lists, but not explained)
 912017-08-25T05:03:06  *** treebeardd has quit IRC
 922017-08-25T05:14:27  <meshcollider> it looks really well thought out and comprehensive to me, that's awesome :) so would compressed blocks just have a new compressed block header and contain compressed transactions like this?
 932017-08-25T05:16:03  <luke-jr> meshcollider: blocks aren't typically transmitted as a big data blob anymore anyway
 942017-08-25T05:16:25  <gmaxwell> except in ibd.
 952017-08-25T05:16:42  <gmaxwell> it's just an alternative encoding of transactions, and blocks are transmited as a header and a bunch of transactions.
 962017-08-25T05:18:01  <meshcollider> Ah I guess block headers are only 80 bytes anyway, probably not worth even trying to compress them more?
 972017-08-25T05:18:33  <luke-jr> they're already compressed somewhat IIRC
 982017-08-25T05:18:46  <gmaxwell> well for headers messages it's useful to compact them, but thats pretty orthorgonal to blocks.
 992017-08-25T05:18:47  <luke-jr> (when sent as a chain, the prevblock part is skipped)
1002017-08-25T05:19:10  <gmaxwell> in a message that sends a lot of headers you can roughly halve their size.
1012017-08-25T05:25:11  *** laurentmt has joined #bitcoin-core-dev
1022017-08-25T05:25:50  *** laurentmt has quit IRC
1032017-08-25T05:41:55  *** Bluewolf33 has quit IRC
1042017-08-25T05:58:04  *** Bluewolf33 has joined #bitcoin-core-dev
1052017-08-25T06:02:55  *** Bluewolf33 has quit IRC
1062017-08-25T06:42:19  *** Giszmo has quit IRC
1072017-08-25T06:45:28  *** laurentmt has joined #bitcoin-core-dev
1082017-08-25T06:47:38  *** ghost43 has quit IRC
1092017-08-25T06:48:08  *** ghost43 has joined #bitcoin-core-dev
1102017-08-25T06:51:02  *** BashCo has quit IRC
1112017-08-25T06:59:35  *** Giszmo has joined #bitcoin-core-dev
1122017-08-25T07:04:28  *** MarcoFalke has quit IRC
1132017-08-25T07:05:57  *** MarcoFalke has joined #bitcoin-core-dev
1142017-08-25T07:06:01  *** laurentmt has quit IRC
1152017-08-25T07:07:57  <gmaxwell> ::sigh::
1162017-08-25T07:08:08  <gmaxwell> 2017-08-25 06:50:40.485126 UpdateTip: new best=0000000000000000007a3061573f5bba379cc02eb472e96f0941d37548fd2982 height=481946 version=0x20000002 log2_work=86.989803 tx=249281504 date='2017-08-25 06:50:23' progress=1.000000 cache=14.2MiB(50014txo) warning='60 of last 100 blocks have unexpected version'
1172017-08-25T07:15:35  *** BashCo has joined #bitcoin-core-dev
1182017-08-25T07:17:34  <gmaxwell> wumpus: gonna updates submittx for segwit?
1192017-08-25T07:18:16  <wumpus> gmaxwell: it's in the plans
1202017-08-25T07:18:30  *** JackH has joined #bitcoin-core-dev
1212017-08-25T07:24:49  <gmaxwell> wumpus: hurray.
1222017-08-25T07:42:11  *** promag has joined #bitcoin-core-dev
1232017-08-25T07:52:15  <Murch> gmaxwell: Am I correct to assume that SegWit will be supported in 0.15.1 and that could be expected shortly after 0.15?
1242017-08-25T07:54:30  <gmaxwell> yes, thats our current tenative plan.
1252017-08-25T07:54:49  <gmaxwell> (I say tenative just because the work hasn't been done yet, people are working on it)
1262017-08-25T07:55:19  <gmaxwell> (of course, much of the backend wallet support was already done as part of the development of segwit itself... just not the more user facing parts)
1272017-08-25T07:56:33  *** arubi has quit IRC
1282017-08-25T07:57:16  *** promag has quit IRC
1292017-08-25T07:59:07  <Murch> okay
1302017-08-25T08:00:12  <Murch> By the way that was our TX: https://www.smartbit.com.au/tx/bf031d49f30565e2c66a9ee736d1bf6ccebcadb46c922ee899d179aa1e1aaf45 :)
1312017-08-25T08:01:55  *** afk11 has quit IRC
1322017-08-25T08:02:16  *** afk11 has joined #bitcoin-core-dev
1332017-08-25T08:04:51  *** Murch has quit IRC
1342017-08-25T08:07:48  *** ghost43 has quit IRC
1352017-08-25T08:08:29  *** ghost43 has joined #bitcoin-core-dev
1362017-08-25T08:22:17  *** goatpig has joined #bitcoin-core-dev
1372017-08-25T08:29:32  *** promag has joined #bitcoin-core-dev
1382017-08-25T08:32:35  *** promag has quit IRC
1392017-08-25T08:38:33  <gmaxwell> 00000000000000000139cb443e16442fcd07a4a0e0788dd045ee3cf268982016  ... A block larger than 1MB!
1402017-08-25T08:38:54  <gmaxwell> also, three cheers for bc.i for actually displaying this fact! https://blockchain.info/block-height/481947
1412017-08-25T08:39:27  <gmaxwell> murch: congrats on your txn.
1422017-08-25T08:39:52  *** promag has joined #bitcoin-core-dev
1432017-08-25T08:49:40  *** promag has quit IRC
1442017-08-25T08:52:54  *** promag has joined #bitcoin-core-dev
1452017-08-25T08:54:44  *** vicenteH has joined #bitcoin-core-dev
1462017-08-25T08:55:56  *** promag has quit IRC
1472017-08-25T08:56:53  *** alreadylate has joined #bitcoin-core-dev
1482017-08-25T08:57:03  *** Dyaheon has quit IRC
1492017-08-25T08:58:47  *** alreadylate has quit IRC
1502017-08-25T08:59:52  *** Dyaheon has joined #bitcoin-core-dev
1512017-08-25T09:01:10  *** promag has joined #bitcoin-core-dev
1522017-08-25T09:04:02  *** promag1 has joined #bitcoin-core-dev
1532017-08-25T09:08:03  *** promag has quit IRC
1542017-08-25T09:09:14  *** promag1 has quit IRC
1552017-08-25T09:10:41  *** juscamarena has joined #bitcoin-core-dev
1562017-08-25T09:11:28  *** promag has joined #bitcoin-core-dev
1572017-08-25T09:11:55  <juscamarena> I made this one that made it go over 1MB https://blockchain.info/tx/8ef2d3c3e8ff4d937746aa39677b347c043287c1fbfeda34b9c241f1e85173ec thanks again for segwit! Works great!
1582017-08-25T09:13:13  <gmaxwell> juscamarena: thanks. we noticed the block earlier.
1592017-08-25T09:13:28  <gmaxwell> we need to do more work reaching out to miners and getting them to fix their settings, lots of confusion.
1602017-08-25T09:13:52  <gmaxwell> (there have been several other points where my node would have mined a greater than 1MB block... but the miner that got the block had a 1MB limit.)
1612017-08-25T09:13:57  <juscamarena> We would have gotten an earlier one but yeah
1622017-08-25T09:17:13  *** AaronvanW has joined #bitcoin-core-dev
1632017-08-25T09:20:58  *** promag has quit IRC
1642017-08-25T09:21:38  *** promag has joined #bitcoin-core-dev
1652017-08-25T09:26:45  *** arubi has joined #bitcoin-core-dev
1662017-08-25T09:30:54  *** AaronvanW has quit IRC
1672017-08-25T09:31:31  *** AaronvanW has joined #bitcoin-core-dev
1682017-08-25T09:41:10  *** promag has joined #bitcoin-core-dev
1692017-08-25T09:49:25  *** ghost43 has quit IRC
1702017-08-25T09:49:51  *** ghost43 has joined #bitcoin-core-dev
1712017-08-25T09:56:20  *** dabura667 has quit IRC
1722017-08-25T10:11:22  *** alreadylate has joined #bitcoin-core-dev
1732017-08-25T10:25:11  *** ghost43 has quit IRC
1742017-08-25T10:26:01  *** ghost43 has joined #bitcoin-core-dev
1752017-08-25T10:26:44  *** jtimon has joined #bitcoin-core-dev
1762017-08-25T10:44:34  *** tiagotrs has joined #bitcoin-core-dev
1772017-08-25T10:47:33  *** tiagotrs has quit IRC
1782017-08-25T10:47:34  *** tiagotrs has joined #bitcoin-core-dev
1792017-08-25T10:58:05  *** riemann has joined #bitcoin-core-dev
1802017-08-25T10:59:05  <bitcoin-git> [bitcoin] laanwj opened pull request #11131: rpc: Write authcookie atomically (master...2017_08_atomic_cookie) https://github.com/bitcoin/bitcoin/pull/11131
1812017-08-25T11:06:21  *** Austindoggie has joined #bitcoin-core-dev
1822017-08-25T11:06:43  *** Jimmy_ has joined #bitcoin-core-dev
1832017-08-25T11:17:02  *** johnpark_pj has quit IRC
1842017-08-25T11:22:27  *** tiagotrs has quit IRC
1852017-08-25T11:22:41  *** tiagotrs has joined #bitcoin-core-dev
1862017-08-25T11:25:16  *** schnerchi has quit IRC
1872017-08-25T11:31:51  *** tiagotrs has quit IRC
1882017-08-25T11:31:51  *** tiagotrs has joined #bitcoin-core-dev
1892017-08-25T11:33:30  *** alreadylate has quit IRC
1902017-08-25T11:41:18  *** schnerchi has joined #bitcoin-core-dev
1912017-08-25T11:54:09  *** alreadylate has joined #bitcoin-core-dev
1922017-08-25T11:57:28  <sturles> Is there a patch to make segwit addresses for change outputs?
1932017-08-25T12:32:46  *** SopaXorzTaker has quit IRC
1942017-08-25T12:32:46  *** jannes has quit IRC
1952017-08-25T12:32:46  *** earlz has quit IRC
1962017-08-25T12:32:46  *** mr_burdell has quit IRC
1972017-08-25T12:32:47  *** zxzzt has quit IRC
1982017-08-25T12:32:47  *** morcos has quit IRC
1992017-08-25T12:32:58  *** morcos has joined #bitcoin-core-dev
2002017-08-25T12:33:01  *** mr_burdell has joined #bitcoin-core-dev
2012017-08-25T12:33:01  *** earlz has joined #bitcoin-core-dev
2022017-08-25T12:33:07  *** zxzzt has joined #bitcoin-core-dev
2032017-08-25T12:33:14  *** jannes has joined #bitcoin-core-dev
2042017-08-25T12:33:15  *** SopaXorzTaker has joined #bitcoin-core-dev
2052017-08-25T12:36:00  <bitcoin-git> [bitcoin] practicalswift opened pull request #11132: [wallet] Document assumptions that must be fulfilled to avoid NULL pointer dereferences (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/11132
2062017-08-25T12:52:32  *** promag has joined #bitcoin-core-dev
2072017-08-25T12:54:07  *** belcher has joined #bitcoin-core-dev
2082017-08-25T12:59:51  *** alreadylate has quit IRC
2092017-08-25T13:01:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11129: [qa] util: Poll cookie file size before reading (master...Mf1708-qaPollCookie) https://github.com/bitcoin/bitcoin/pull/11129
2102017-08-25T13:14:23  *** ems has joined #bitcoin-core-dev
2112017-08-25T13:19:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2122017-08-25T13:29:15  <instagibbs> what exactly does contrib/verify-commits/verify-commits.sh do?
2132017-08-25T13:34:15  <MarcoFalke> read the commits, starting from HEAD, checking if there is at least one signed parent
2142017-08-25T13:34:33  *** ghost43 has quit IRC
2152017-08-25T13:34:42  <MarcoFalke> only taking into account the keys of maintainers
2162017-08-25T13:34:50  *** ghost43 has joined #bitcoin-core-dev
2172017-08-25T13:35:28  *** Dyaheon has quit IRC
2182017-08-25T13:36:05  *** Eliel has joined #bitcoin-core-dev
2192017-08-25T13:36:19  *** Guyver2 has joined #bitcoin-core-dev
2202017-08-25T13:37:03  *** Dyaheon has joined #bitcoin-core-dev
2212017-08-25T13:37:15  *** promag has quit IRC
2222017-08-25T13:40:01  *** str4d has joined #bitcoin-core-dev
2232017-08-25T13:47:35  *** promag has joined #bitcoin-core-dev
2242017-08-25T14:00:08  *** guggero has joined #bitcoin-core-dev
2252017-08-25T14:01:35  <bitcoin-git> [bitcoin] practicalswift opened pull request #11133: Document assumptions that must be fulfilled to avoid division by zero (master...div0) https://github.com/bitcoin/bitcoin/pull/11133
2262017-08-25T14:11:32  *** Chris_Stewart_5 has quit IRC
2272017-08-25T14:17:14  *** rafalcpp has quit IRC
2282017-08-25T14:18:18  *** rafalcpp has joined #bitcoin-core-dev
2292017-08-25T14:27:21  *** rafalcpp has quit IRC
2302017-08-25T14:28:23  *** rafalcpp has joined #bitcoin-core-dev
2312017-08-25T14:28:58  *** rafalcpp has joined #bitcoin-core-dev
2322017-08-25T14:30:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2332017-08-25T14:37:28  <promag> Maybe we should make all RPC responses an JSON object, that way it is easier to avoid breaking changes cc instagibbs
2342017-08-25T14:39:59  <instagibbs> promag, in general avoiding breakage is good, but I think verifytxoutproof is a bit less used(and isn't returning what's actually required to be entirely useful)
2352017-08-25T14:41:11  <promag> yeah, I mean maybe add developer note for future calls.
2362017-08-25T14:55:28  <bitcoin-git> [bitcoin] promag opened pull request #11135: Add RPC response notes (master...2017-08-rpc-response-notes) https://github.com/bitcoin/bitcoin/pull/11135
2372017-08-25T14:57:25  *** riemann has quit IRC
2382017-08-25T14:58:47  *** promag has quit IRC
2392017-08-25T15:01:36  *** promag has joined #bitcoin-core-dev
2402017-08-25T15:27:40  *** JackH has quit IRC
2412017-08-25T15:32:30  *** Chris_Stewart_5 has quit IRC
2422017-08-25T15:33:12  *** otoburb has joined #bitcoin-core-dev
2432017-08-25T15:33:22  *** tiagotrs has quit IRC
2442017-08-25T15:34:51  *** tiagotrs has joined #bitcoin-core-dev
2452017-08-25T15:40:47  *** Dyaheon has quit IRC
2462017-08-25T15:41:48  *** Dyaheon has joined #bitcoin-core-dev
2472017-08-25T15:45:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2482017-08-25T15:47:45  *** vicenteH has quit IRC
2492017-08-25T15:52:13  *** promag has quit IRC
2502017-08-25T15:55:44  *** marcoagner has quit IRC
2512017-08-25T15:58:31  *** hasten has joined #bitcoin-core-dev
2522017-08-25T16:02:24  *** hasten has joined #bitcoin-core-dev
2532017-08-25T16:03:06  *** t00tie has joined #bitcoin-core-dev
2542017-08-25T16:03:30  *** t00tie has left #bitcoin-core-dev
2552017-08-25T16:05:27  <bitcoin-git> [bitcoin] danra opened pull request #11136: Docs: Add python3 to list of dependencies on macOS (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11136
2562017-08-25T16:07:17  *** marcoagner has joined #bitcoin-core-dev
2572017-08-25T16:08:17  *** tiagotrs has quit IRC
2582017-08-25T16:08:17  *** tiagotrs has joined #bitcoin-core-dev
2592017-08-25T16:20:25  *** Dizzle has joined #bitcoin-core-dev
2602017-08-25T16:21:31  *** praxeology1 has quit IRC
2612017-08-25T16:24:04  <bitcoin-git> [bitcoin] danra opened pull request #11138: Compat: Simplify bswap_16 implementation (master...patch-2) https://github.com/bitcoin/bitcoin/pull/11138
2622017-08-25T16:29:34  <luke-jr> jonasschnelli: what's the status of your stats_*_tmp branches? seems you added a typo? O.o
2632017-08-25T16:29:45  <luke-jr> (precision -> percision)
2642017-08-25T16:30:27  <luke-jr> hm, or maybe the rpc one is obsolete
2652017-08-25T16:30:48  <luke-jr> or both are :x
2662017-08-25T16:32:00  <bitcoin-git> [bitcoin] danra opened pull request #11139: Trivial: Whitespace in bswap_64 implementation (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11139
2672017-08-25T16:32:18  *** Chris_Stewart_5 has quit IRC
2682017-08-25T16:35:06  *** guggero has left #bitcoin-core-dev
2692017-08-25T16:40:22  *** Austindoggie_ has joined #bitcoin-core-dev
2702017-08-25T16:40:59  <bitcoin-git> [bitcoin] danra opened pull request #11140: Trivial: Improve #endif comments (master...patch-4) https://github.com/bitcoin/bitcoin/pull/11140
2712017-08-25T16:44:07  *** Austindoggie has quit IRC
2722017-08-25T16:46:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2732017-08-25T16:57:36  *** ems has quit IRC
2742017-08-25T16:58:41  *** jimpo has joined #bitcoin-core-dev
2752017-08-25T16:59:53  *** promag has joined #bitcoin-core-dev
2762017-08-25T17:03:10  *** jimpo has quit IRC
2772017-08-25T17:03:33  *** promag has quit IRC
2782017-08-25T17:05:03  *** juscamarena has quit IRC
2792017-08-25T17:08:34  *** ems has joined #bitcoin-core-dev
2802017-08-25T17:11:20  <bitcoin-git> [bitcoin] wrapperband opened pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
2812017-08-25T17:13:35  *** Giszmo has quit IRC
2822017-08-25T17:17:08  *** rhavar has joined #bitcoin-core-dev
2832017-08-25T17:17:46  *** Giszmo has joined #bitcoin-core-dev
2842017-08-25T17:18:19  <rhavar> For a "pure" segwit transaction (p2sh) is this formula correct:  estimatedVSizeOfSegwitTransaction(inputCount, outputCount) { return 92 * inputCount + 12 + 32 * outputCount; }
2852017-08-25T17:21:56  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
2862017-08-25T17:28:14  <bitcoin-git> [bitcoin] danra opened pull request #11143: Fix include path for bitcoin-config.h (master...patch-5) https://github.com/bitcoin/bitcoin/pull/11143
2872017-08-25T17:37:39  *** Austindoggie_ has quit IRC
2882017-08-25T17:42:21  *** Austindoggie_ has joined #bitcoin-core-dev
2892017-08-25T17:43:58  *** Dyaheon has quit IRC
2902017-08-25T17:46:59  *** Dyaheon has joined #bitcoin-core-dev
2912017-08-25T17:47:28  *** Austindoggie_ has quit IRC
2922017-08-25T17:48:21  *** praxeology has joined #bitcoin-core-dev
2932017-08-25T17:50:59  *** praxeology has left #bitcoin-core-dev
2942017-08-25T17:59:46  *** promag has joined #bitcoin-core-dev
2952017-08-25T18:07:10  *** Aaronvan_ has joined #bitcoin-core-dev
2962017-08-25T18:08:41  *** promag has quit IRC
2972017-08-25T18:10:09  *** AaronvanW has quit IRC
2982017-08-25T18:21:44  *** Ixje has joined #bitcoin-core-dev
2992017-08-25T18:39:45  *** ems has quit IRC
3002017-08-25T18:43:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11139: Trivial: Whitespace in bswap_64 implementation (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11139
3012017-08-25T18:49:50  *** Ixje has left #bitcoin-core-dev
3022017-08-25T19:02:36  *** chjj has quit IRC
3032017-08-25T19:03:42  *** BashCo has quit IRC
3042017-08-25T19:04:16  *** jimpo has joined #bitcoin-core-dev
3052017-08-25T19:04:21  *** BashCo has joined #bitcoin-core-dev
3062017-08-25T19:06:52  *** jimpo has quit IRC
3072017-08-25T19:07:41  *** jimpo has joined #bitcoin-core-dev
3082017-08-25T19:08:39  *** BashCo has quit IRC
3092017-08-25T19:13:40  <bitcoin-git> [bitcoin] danra opened pull request #11144: Move local include to before system includes (master...patch-6) https://github.com/bitcoin/bitcoin/pull/11144
3102017-08-25T19:14:58  *** chjj has joined #bitcoin-core-dev
3112017-08-25T19:16:21  *** vicenteH has joined #bitcoin-core-dev
3122017-08-25T19:24:16  *** jtimon has quit IRC
3132017-08-25T19:27:08  *** BashCo has joined #bitcoin-core-dev
3142017-08-25T19:31:26  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3f726c99f819...07c92b98e2a0
3152017-08-25T19:31:27  <bitcoin-git> bitcoin/master d97fe20 Russell Yanofsky: Move some static functions out of wallet.h/cpp...
3162017-08-25T19:31:27  <bitcoin-git> bitcoin/master e7fe320 Russell Yanofsky: MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp
3172017-08-25T19:31:28  <bitcoin-git> bitcoin/master f01103c Russell Yanofsky: MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp
3182017-08-25T19:31:49  *** BashCo_ has joined #bitcoin-core-dev
3192017-08-25T19:32:01  <bitcoin-git> [bitcoin] laanwj closed pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (master...pr/wmove) https://github.com/bitcoin/bitcoin/pull/10976
3202017-08-25T19:32:58  *** eikzbtc has joined #bitcoin-core-dev
3212017-08-25T19:33:21  *** BashCo has quit IRC
3222017-08-25T19:49:05  *** Dyaheon has quit IRC
3232017-08-25T19:51:12  *** Dyaheon has joined #bitcoin-core-dev
3242017-08-25T20:04:10  <luke-jr> wumpus: can we get #7339 reopened and in? apparently it won't be n/a as early as expect
3252017-08-25T20:11:54  *** promag has joined #bitcoin-core-dev
3262017-08-25T20:14:15  *** eikzbtc has left #bitcoin-core-dev
3272017-08-25T20:15:01  <bitcoin-git> [bitcoin] morcos opened pull request #11145: Fix rounding bug in calculation of minimum change (master...fixrounding) https://github.com/bitcoin/bitcoin/pull/11145
3282017-08-25T20:15:16  <morcos> ok sorry guys if i killed 0.15 being on time, please review ^^ ASAP
3292017-08-25T20:20:29  *** vicenteH has quit IRC
3302017-08-25T20:20:36  *** vicenteH has joined #bitcoin-core-dev
3312017-08-25T20:21:56  *** arubi has quit IRC
3322017-08-25T20:22:49  *** Dizzle has quit IRC
3332017-08-25T20:23:05  *** promag has quit IRC
3342017-08-25T20:23:49  <instagibbs> you can blame the person reporting :P
3352017-08-25T20:27:16  * sipa blames the person who merged the PR that introduced the error
3362017-08-25T20:27:19  <sipa> oh, wait...
3372017-08-25T20:31:03  <MarcoFalke> I blame Satoshi
3382017-08-25T20:34:20  *** Svenson has joined #bitcoin-core-dev
3392017-08-25T20:35:07  *** arubi has joined #bitcoin-core-dev
3402017-08-25T20:36:32  *** jtimon has joined #bitcoin-core-dev
3412017-08-25T20:39:08  <gmaxwell> well I'm very glad to have found this, would have been an irritating issue. "payments randomly fail" :(
3422017-08-25T20:43:50  *** alreadylate has joined #bitcoin-core-dev
3432017-08-25T20:44:01  *** juscamarena has joined #bitcoin-core-dev
3442017-08-25T20:44:25  *** juscamarena is now known as Guest85153
3452017-08-25T20:52:17  *** tiagotrs has quit IRC
3462017-08-25T20:57:25  *** sipa has quit IRC
3472017-08-25T20:57:25  *** sipa has joined #bitcoin-core-dev
3482017-08-25T21:02:40  *** Aaronvan_ has quit IRC
3492017-08-25T21:03:20  *** AaronvanW has joined #bitcoin-core-dev
3502017-08-25T21:06:16  *** alreadylate has quit IRC
3512017-08-25T21:07:02  *** alreadylate has joined #bitcoin-core-dev
3522017-08-25T21:12:40  <bitcoin-git> [bitcoin] eaxvac opened pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (master...master) https://github.com/bitcoin/bitcoin/pull/11147
3532017-08-25T21:12:54  <bitcoin-git> [bitcoin] eaxvac closed pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (master...master) https://github.com/bitcoin/bitcoin/pull/11147
3542017-08-25T21:16:02  *** Deacydal has joined #bitcoin-core-dev
3552017-08-25T21:17:41  <bitcoin-git> [bitcoin] danra opened pull request #11148: Trivial: Fix outdated comment (master...patch-7) https://github.com/bitcoin/bitcoin/pull/11148
3562017-08-25T21:19:01  *** Guest85153 has quit IRC
3572017-08-25T21:19:40  *** Deacyded has quit IRC
3582017-08-25T21:20:59  *** Guest85153 has joined #bitcoin-core-dev
3592017-08-25T21:21:03  *** Guyver2 has quit IRC
3602017-08-25T21:21:35  <morcos> gmaxwell: yeah unfortunately there are a lot o changes in that code, where fees and change can be adjusted...  so its really hard to think through and be sure there isn't some edge case we're missing.
3612017-08-25T21:22:37  <gmaxwell> I feel like we should have some kind of exceptional case flagging infrastructure. So that there are varrious exceptional cases which are triggerable, but should only be triggered by a specific test and otherwise we want to know about them.
3622017-08-25T21:22:39  <morcos> it'll be nice to rewrite all this for 0.16...  and i think i still feel it's safer to error there rather than risk continuing in some way
3632017-08-25T21:44:32  *** Svenson has quit IRC
3642017-08-25T21:45:55  *** alreadylate has quit IRC
3652017-08-25T21:47:09  *** alreadylate has joined #bitcoin-core-dev
3662017-08-25T21:52:45  *** tiagotrs has joined #bitcoin-core-dev
3672017-08-25T21:52:48  *** Guest85153 is now known as juscamarena
3682017-08-25T21:58:11  *** belcher has quit IRC
3692017-08-25T22:11:05  *** tiagotrs has quit IRC
3702017-08-25T22:11:31  *** spinza has quit IRC
3712017-08-25T22:11:35  *** marcoagner has quit IRC
3722017-08-25T22:18:35  *** promag has joined #bitcoin-core-dev
3732017-08-25T22:20:54  *** Yogaqueef has joined #bitcoin-core-dev
3742017-08-25T22:25:39  <bitcoin-git> [bitcoin] danra opened pull request #11149: Use prefix instead of postfix increment/decrement for non-trivial typ… (master...prefix-increment) https://github.com/bitcoin/bitcoin/pull/11149
3752017-08-25T22:33:23  *** spinza has joined #bitcoin-core-dev
3762017-08-25T22:38:06  <bitcoin-git> [bitcoin] mess110 opened pull request #11150: [tests] Add getmininginfo functional tests (master...test_rpc_getmininginfo) https://github.com/bitcoin/bitcoin/pull/11150
3772017-08-25T22:48:28  *** alreadylate has quit IRC
3782017-08-25T22:52:38  <MarcoFalke> Where did juscamarena report the issue about the fee "rounding bug"?
3792017-08-25T22:54:17  <instagibbs> MarcoFalke, originally to me, I forwarded to morcos since it was code he wrote(IIRC)
3802017-08-25T22:55:41  *** cheese_ has joined #bitcoin-core-dev
3812017-08-25T22:56:36  *** juscamarena has quit IRC
3822017-08-25T22:57:04  *** juscamarena has joined #bitcoin-core-dev
3832017-08-25T22:57:13  *** juscamarena is now known as juscamarena_
3842017-08-25T22:59:34  *** juscamarena_ is now known as juscamarena
3852017-08-25T23:04:08  *** juscamarena has quit IRC
3862017-08-25T23:07:21  *** chjj has quit IRC
3872017-08-25T23:09:56  <MarcoFalke> Ah
3882017-08-25T23:10:01  *** alreadylate has joined #bitcoin-core-dev
3892017-08-25T23:10:10  *** alreadylate has quit IRC
3902017-08-25T23:10:26  <MarcoFalke> So the issue is that fees are *underpayed*
3912017-08-25T23:10:56  *** str4d has quit IRC
3922017-08-25T23:11:07  <MarcoFalke> s/payed/paid/
3932017-08-25T23:21:13  *** chjj has joined #bitcoin-core-dev
3942017-08-25T23:21:44  *** promag has quit IRC
3952017-08-25T23:23:08  *** tiagotrs has joined #bitcoin-core-dev
3962017-08-25T23:37:39  *** chjj has quit IRC
3972017-08-25T23:39:31  *** RoyceX has joined #bitcoin-core-dev
3982017-08-25T23:42:10  *** cheese_ has quit IRC
3992017-08-25T23:49:21  <instagibbs> it re-tries assuming it has enough input value, then somehow doesn't, and panics
4002017-08-25T23:49:54  *** chjj has joined #bitcoin-core-dev