1 2017-09-01T00:02:02  *** Gunnie has joined #bitcoin-core-dev
  2 2017-09-01T00:03:06  *** Giszmo has joined #bitcoin-core-dev
  3 2017-09-01T00:07:50  *** Gunnie has quit IRC
  4 2017-09-01T00:08:34  *** JackH has quit IRC
  5 2017-09-01T00:09:08  *** JackH has joined #bitcoin-core-dev
  6 2017-09-01T00:09:44  *** JackH has quit IRC
  7 2017-09-01T00:10:29  *** JackH has joined #bitcoin-core-dev
  8 2017-09-01T00:12:45  *** chjj has joined #bitcoin-core-dev
  9 2017-09-01T00:13:00  *** JackH has quit IRC
 10 2017-09-01T00:13:35  *** JackH has joined #bitcoin-core-dev
 11 2017-09-01T00:13:43  *** dabura667 has joined #bitcoin-core-dev
 12 2017-09-01T00:17:47  *** JackH has quit IRC
 13 2017-09-01T00:20:55  <sipa> achow101: i overlooked it before; i've locked the comments on the first commit
 14 2017-09-01T00:21:11  <achow101> yay
 15 2017-09-01T00:21:28  <achow101> less spam
 16 2017-09-01T00:21:37  *** JackH has joined #bitcoin-core-dev
 17 2017-09-01T00:22:12  <gmaxwell> oh thats why achow was asking. :P
 18 2017-09-01T00:26:59  <jtimon> review beg https://github.com/bitcoin/bitcoin/pull/8994 now there's no exception for testing segwit.py and I left the loading of the parameters from aseparated file for later
 19 2017-09-01T00:33:45  <achow101> I think I am close to figuring out what happened with #11171, and it is not related to the off screen thing
 20 2017-09-01T00:37:12  *** Chris_Stewart_5 has quit IRC
 21 2017-09-01T00:40:10  *** Aaronvan_ is now known as AaronvanW
 22 2017-09-01T00:40:39  *** unholymachine has quit IRC
 23 2017-09-01T00:41:55  *** Deacyde has joined #bitcoin-core-dev
 24 2017-09-01T00:46:21  *** dabura667 has quit IRC
 25 2017-09-01T00:46:27  <achow101> well while trying to debug that thing, I found a different bug :/
 26 2017-09-01T00:47:08  *** unholymachine has joined #bitcoin-core-dev
 27 2017-09-01T01:05:05  <sipa> achow101: you're on a roll
 28 2017-09-01T01:06:38  <achow101> sipa: can you help? This is as far as I got: https://github.com/bitcoin/bitcoin/issues/11171#issuecomment-326457725
 29 2017-09-01T01:06:56  <achow101> I'm not sure if I've gone down the wrong rabbit hole or if I am just not seeing something
 30 2017-09-01T01:11:48  <sipa> achow101: calling a virtual method on a null pointer will cause a segfault, but this is not true for normal methods (though it's undefined behaviour, in practice the method just gets called with a this == nullptr)
 31 2017-09-01T01:12:11  <sipa> of course, if the called method tries to access any class fields, a segfault will occur
 32 2017-09-01T01:14:09  *** jonasschnelli has quit IRC
 33 2017-09-01T01:14:09  *** jonasschnelli has joined #bitcoin-core-dev
 34 2017-09-01T01:14:14  <achow101> is there a virtual method here?
 35 2017-09-01T01:14:37  <sipa> i don't know - i know almost nothing about the GUI code
 36 2017-09-01T01:20:33  *** belcher has quit IRC
 37 2017-09-01T01:22:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 38 2017-09-01T01:28:11  *** belcher has joined #bitcoin-core-dev
 39 2017-09-01T01:44:42  *** AaronvanW has quit IRC
 40 2017-09-01T01:56:32  *** Dyaheon has quit IRC
 41 2017-09-01T01:57:52  *** Dyaheon has joined #bitcoin-core-dev
 42 2017-09-01T02:38:06  *** dabura667 has joined #bitcoin-core-dev
 43 2017-09-01T02:40:01  *** Chris_Stewart_5 has quit IRC
 44 2017-09-01T02:41:04  *** dabura667 has quit IRC
 45 2017-09-01T02:51:18  *** Murch has quit IRC
 46 2017-09-01T03:11:58  *** dabura667 has joined #bitcoin-core-dev
 47 2017-09-01T03:12:49  *** JackH has quit IRC
 48 2017-09-01T03:14:15  *** JackH has joined #bitcoin-core-dev
 49 2017-09-01T03:38:06  *** lifeofguenter has quit IRC
 50 2017-09-01T03:42:34  *** lifeofguenter has joined #bitcoin-core-dev
 51 2017-09-01T04:07:27  <kallewoof> Ugh... I didn't realize the mempool propagated quite as slowly as it does. I have 3 public nodes (one has been up for months, one for a week or two, and one was started up yesterday). The mempools on each is quite different. 4827 entries for the longest running one, 2848 for the second and 802 for the third.
 52 2017-09-01T04:08:52  <sipa> that's not necessarily due to propagation
 53 2017-09-01T04:08:52  <kallewoof> What else could be causing it?
 54 2017-09-01T04:09:02  <sipa> if the differences are in transactions that (directly or indirectly) depend on unconfirmed transactions that were in the older running nodes but not in the newer ones, that's expected
 55 2017-09-01T04:09:12  <sipa> there is no mempool reconciliation
 56 2017-09-01T04:09:51  <kallewoof> So most of the extra cruft would be for low fee txs that are not making it into blocks for a long time?
 57 2017-09-01T04:10:05  <kallewoof> Oh wait, I see what you're saying
 58 2017-09-01T04:11:15  <kallewoof> Node gets a tx with an input that is unconfirmed and unknown and the node discards it. Or wait, it puts it in orphanTx vector, right? Maybe I can use that to get a better picture..
 59 2017-09-01T04:14:25  *** RubenSomsen has joined #bitcoin-core-dev
 60 2017-09-01T04:17:01  <kallewoof> sipa: Weird. It looks like a node will ask for parent txs if it runs into a tx with unknown inputs, presuming it hasn't rejected any of its parents before. Doesn't that address what you said?
 61 2017-09-01T04:18:19  <kallewoof> for loop over vin that does `if (!AlreadyHave(_inv)) pfrom->AskFor(_inv);` (net_processing.cpp somewhere around line 1900 or so)
 62 2017-09-01T04:18:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 63 2017-09-01T04:21:39  <sipa> kallewoof: perhaps they already have a conflict for the parent?
 64 2017-09-01T04:23:27  <kallewoof> I could see that be the case for a couple of transactions (having a double spent parent I guess? where one node sees one and the other sees the other), but the old node has 4x the # of txs compared to the 1 day old one. seems high.
 65 2017-09-01T04:24:06  <kallewoof> Connection counts are 63, 17, 14 which might mean that some txs simply don't get very far (need lots of peers to see them), but maybe there's another reason.
 66 2017-09-01T04:24:28  <kallewoof> s/which might mean/which might indicate/
 67 2017-09-01T04:25:13  *** Chris_Stewart_5 has quit IRC
 68 2017-09-01T04:44:24  *** Murch has joined #bitcoin-core-dev
 69 2017-09-01T04:51:36  *** JackH has quit IRC
 70 2017-09-01T04:59:43  *** JackH has joined #bitcoin-core-dev
 71 2017-09-01T05:00:30  *** ghost43 has quit IRC
 72 2017-09-01T05:08:43  *** ghost43 has joined #bitcoin-core-dev
 73 2017-09-01T05:09:49  *** luke-jr has quit IRC
 74 2017-09-01T05:11:45  *** luke-jr has joined #bitcoin-core-dev
 75 2017-09-01T05:23:02  *** Dyaheon has quit IRC
 76 2017-09-01T05:23:34  *** Dyaheon has joined #bitcoin-core-dev
 77 2017-09-01T05:38:26  *** meshcollider has joined #bitcoin-core-dev
 78 2017-09-01T05:47:42  *** Deadhand has quit IRC
 79 2017-09-01T05:50:20  *** Deadhand has joined #bitcoin-core-dev
 80 2017-09-01T06:00:54  *** Cory has joined #bitcoin-core-dev
 81 2017-09-01T06:04:02  *** c40d9b0743a91f40 has quit IRC
 82 2017-09-01T06:04:58  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 83 2017-09-01T06:07:41  *** RubenSomsen has quit IRC
 84 2017-09-01T06:08:55  *** c40d9b0743a91f40 has quit IRC
 85 2017-09-01T06:13:45  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 86 2017-09-01T06:14:13  *** c40d9b0743a91f40 has quit IRC
 87 2017-09-01T06:14:34  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 88 2017-09-01T06:16:41  *** Giszmo has quit IRC
 89 2017-09-01T06:18:35  *** sam_c has quit IRC
 90 2017-09-01T06:19:22  *** sam_c has joined #bitcoin-core-dev
 91 2017-09-01T06:22:11  *** lifeofguenter has quit IRC
 92 2017-09-01T06:26:32  *** c40d9b0743a91f40 has quit IRC
 93 2017-09-01T06:27:12  *** lifeofguenter has joined #bitcoin-core-dev
 94 2017-09-01T06:31:46  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 95 2017-09-01T06:33:16  *** arubi has quit IRC
 96 2017-09-01T06:34:26  *** c40d9b0743a91f40 has quit IRC
 97 2017-09-01T06:34:50  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 98 2017-09-01T06:37:06  <meshcollider> Since #11171 is being used to discuss the GUI bug could someone please reopen it :)
 99 2017-09-01T06:38:40  *** Gunnie has joined #bitcoin-core-dev
100 2017-09-01T06:41:20  *** lifeofguenter has quit IRC
101 2017-09-01T06:45:20  <meshcollider> Thanks sipa
102 2017-09-01T06:45:51  <sipa> yw!
103 2017-09-01T06:47:39  *** lifeofguenter has joined #bitcoin-core-dev
104 2017-09-01T06:50:51  <gmaxwell> kallewoof: it will fetch parents but its pretty limited in doing that. It won't fetch things that it just wasn't online to see.
105 2017-09-01T06:50:58  <gmaxwell> unless a child shows up.
106 2017-09-01T06:51:30  <gmaxwell> in my expirence it normally takes about 24 hours of operation before compact blocks reaches its full hitrate.
107 2017-09-01T06:52:21  <gmaxwell> and right now with a flood of very low fee txn you won't pick those up.
108 2017-09-01T06:53:04  *** BashCo has quit IRC
109 2017-09-01T06:56:02  *** JackH has quit IRC
110 2017-09-01T06:57:47  <jimpo> kallewoof: Do you mind dumping the mempools and sharing if you have RPC enabled? I'd be interested in taking a look.
111 2017-09-01T07:01:22  <gmaxwell> kallewoof: fwiw, it's a couple line patch to use the mempool rpc to cause a peer to inv you their whole mempool, it's pretty abusive so you should probably only do it to your own nodes. (e.g. make a patch that adds an rpc command to send a mempool message to a particular node id then use it)
112 2017-09-01T07:01:33  <gmaxwell> (or at least use it sparingly against anyone else.)
113 2017-09-01T07:16:48  *** BashCo has joined #bitcoin-core-dev
114 2017-09-01T07:18:07  *** jannes has joined #bitcoin-core-dev
115 2017-09-01T07:20:07  <kallewoof> jimpo: lemme see what they look like now after the rush of 8k txs first..
116 2017-09-01T07:20:22  <kallewoof> gmaxwell: ahh okay. well, i kind of want these nodes to behave as a normal average joe node so i don't want them to "cheat"
117 2017-09-01T07:20:58  <gmaxwell> kallewoof: sure, depends on what you're testing.
118 2017-09-01T07:21:47  *** arubi has joined #bitcoin-core-dev
119 2017-09-01T07:22:23  <kallewoof> jimpo: they seem to be a bit closer to what you'd expect now. {11022, 9101, 8525} txs for {69, 13, 17} connection count. still interested?
120 2017-09-01T07:23:20  <gmaxwell> connection count won't matter.
121 2017-09-01T07:23:37  <kallewoof> I assumed connection count would give you better coverage
122 2017-09-01T07:23:37  <gmaxwell> just having been online to see the whole backlog matters mostly.
123 2017-09-01T07:24:09  <gmaxwell> no, except with very few good peers or something everything gets flooded to every link.
124 2017-09-01T07:24:09  <gmaxwell> but old transactions are not sent.
125 2017-09-01T07:25:14  <jimpo> kallewoof: Yeah, I'm still interested. I'll see if I can replicate too, but your nodes have been up a lot longer.
126 2017-09-01T07:25:15  <kallewoof> one has only been up ~24h
127 2017-09-01T07:25:15  *** JackH has joined #bitcoin-core-dev
128 2017-09-01T07:25:15  <kallewoof> would getrawmempool output be enough or do you want more details?
129 2017-09-01T07:25:15  <jimpo> getrawmempool is great
130 2017-09-01T07:25:15  <gmaxwell> so you don't see things that were broadcast before you came online, except where they get pulled in by children. or by an occasional piece of 'helpful' custom software that connects to you and vomits a bunch of old txn at you for inexplicable reasons.
131 2017-09-01T07:25:54  *** laurentmt has joined #bitcoin-core-dev
132 2017-09-01T07:26:19  <jimpo> Yeah, that's probably why
133 2017-09-01T07:29:06  <kallewoof> jimpo: https://bc-2.jp/grm.zip
134 2017-09-01T07:29:30  *** laurentmt has quit IRC
135 2017-09-01T07:30:43  <kallewoof> gmaxwell: I thought txs were relayed randomly to enhance privacy
136 2017-09-01T07:30:52  <kallewoof> I must've gotten that mixezd up with something else.
137 2017-09-01T07:33:04  *** laurentmt has joined #bitcoin-core-dev
138 2017-09-01T07:38:15  <kallewoof> Hum. I don't think that's my issue, but if someone sent a tx with a fee so low it wouldn't go into mempoo, and someone else CPFP'd that, it wouldn't go into the mempool because parent was rejected, I think. That might not be ideal.
139 2017-09-01T07:42:02  <gmaxwell> kallewoof: you can't use CPFP to evade mempool minimums but they are very low.
140 2017-09-01T07:42:23  <gmaxwell> kallewoof: they are relayed with randomized delays, in sorted order, but all are relayed.
141 2017-09-01T07:43:06  <kallewoof> gmaxwell: OK, so that wouldn't explain the difference unless there had been a ton of new txs recently (which wasn't the case at the time).
142 2017-09-01T07:43:19  <gmaxwell> kallewoof: also peers (well, later than 0.12) will not relay you txn which are too low to go into your mempool.
143 2017-09-01T07:43:36  * kallewoof nods
144 2017-09-01T07:44:52  <gmaxwell> kallewoof: you can look at the recieved times on all the txn in your mempools, I expect that what you will find that all the txn missing from your lower uptime nodes have recieve times before it started.
145 2017-09-01T07:57:41  *** Austindoggie has joined #bitcoin-core-dev
146 2017-09-01T08:06:57  <kallewoof> gmaxwell: That's a good idea, yeah.
147 2017-09-01T08:23:01  *** timothy has joined #bitcoin-core-dev
148 2017-09-01T08:41:27  *** vicenteH has joined #bitcoin-core-dev
149 2017-09-01T09:10:41  *** Austindoggie has quit IRC
150 2017-09-01T09:11:16  *** Austindoggie has joined #bitcoin-core-dev
151 2017-09-01T09:11:26  *** Austindoggie has quit IRC
152 2017-09-01T09:12:00  *** harrymm has quit IRC
153 2017-09-01T09:17:08  *** SopaXorzTaker has joined #bitcoin-core-dev
154 2017-09-01T09:22:12  *** riemann has joined #bitcoin-core-dev
155 2017-09-01T09:23:21  *** AaronvanW has joined #bitcoin-core-dev
156 2017-09-01T09:39:13  *** chjj has quit IRC
157 2017-09-01T09:40:56  *** Giszmo has joined #bitcoin-core-dev
158 2017-09-01T10:16:27  *** laurentmt has quit IRC
159 2017-09-01T10:27:35  *** Murch has quit IRC
160 2017-09-01T10:34:11  *** Yogaqueef has joined #bitcoin-core-dev
161 2017-09-01T10:38:33  *** RubenSomsen has joined #bitcoin-core-dev
162 2017-09-01T10:43:16  *** Guyver2 has joined #bitcoin-core-dev
163 2017-09-01T10:53:05  <meshcollider> I've noticed src/test/testutil.cpp|h seem to basically provide nothing, is there anything wrong with removing those files and calling fs::temp_directory_path() directly instead of GetTempPath() ?
164 2017-09-01T11:03:31  *** JackH has quit IRC
165 2017-09-01T11:06:41  *** Gunnie has quit IRC
166 2017-09-01T11:20:07  *** alreadylate has joined #bitcoin-core-dev
167 2017-09-01T11:21:46  *** JackH has joined #bitcoin-core-dev
168 2017-09-01T11:22:50  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11210: Stop test_bitcoin-qt touching ~/.bitcoin (master...201708_qt_test_dir) https://github.com/bitcoin/bitcoin/pull/11210
169 2017-09-01T11:34:54  *** belcher has quit IRC
170 2017-09-01T11:45:35  *** shesek has quit IRC
171 2017-09-01T11:49:42  *** unholymachine has quit IRC
172 2017-09-01T11:52:07  *** unholymachine has joined #bitcoin-core-dev
173 2017-09-01T12:03:25  *** dabura667 has quit IRC
174 2017-09-01T12:06:39  *** RubenSomsen has quit IRC
175 2017-09-01T12:12:10  *** riemann has quit IRC
176 2017-09-01T12:12:16  *** dermoth_ has joined #bitcoin-core-dev
177 2017-09-01T12:12:33  *** dermoth has quit IRC
178 2017-09-01T12:12:35  *** dermoth_ is now known as dermoth
179 2017-09-01T12:21:14  *** laurentmt has joined #bitcoin-core-dev
180 2017-09-01T12:26:28  *** laurentmt has quit IRC
181 2017-09-01T12:27:03  *** RubenSomsen has joined #bitcoin-core-dev
182 2017-09-01T12:27:59  *** laurentmt has joined #bitcoin-core-dev
183 2017-09-01T13:10:45  *** cryptapus has quit IRC
184 2017-09-01T13:13:15  *** cryptapus has joined #bitcoin-core-dev
185 2017-09-01T13:13:15  *** cryptapus has joined #bitcoin-core-dev
186 2017-09-01T13:15:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
187 2017-09-01T13:21:25  *** harrymm has joined #bitcoin-core-dev
188 2017-09-01T13:30:41  *** Chris_Stewart_5 has quit IRC
189 2017-09-01T13:42:18  *** jtimon has quit IRC
190 2017-09-01T13:43:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
191 2017-09-01T13:52:16  *** Dyaheon has quit IRC
192 2017-09-01T13:52:32  *** cheese_ has joined #bitcoin-core-dev
193 2017-09-01T13:53:07  *** Dyaheon has joined #bitcoin-core-dev
194 2017-09-01T13:55:49  *** RoyceX has quit IRC
195 2017-09-01T14:08:11  *** meshcollider has quit IRC
196 2017-09-01T14:09:23  <bitcoin-git> [bitcoin] jjz opened pull request #11212: Change the type of BlockStatus to unsigned int  (master...master) https://github.com/bitcoin/bitcoin/pull/11212
197 2017-09-01T14:19:07  *** ChesterVal has left #bitcoin-core-dev
198 2017-09-01T14:20:56  *** SisterM has joined #bitcoin-core-dev
199 2017-09-01T14:27:35  *** esotericnonsense has quit IRC
200 2017-09-01T14:31:18  <bitcoin-git> [bitcoin] jnewbery opened pull request #11213: Fix getrawtransaction help for per-txout chainstate db (master...getrawtransactionhelp) https://github.com/bitcoin/bitcoin/pull/11213
201 2017-09-01T14:41:37  *** Chris_Stewart_5 has quit IRC
202 2017-09-01T14:42:12  *** esotericnonsense has joined #bitcoin-core-dev
203 2017-09-01T14:47:25  *** JackH has quit IRC
204 2017-09-01T14:48:12  *** paveljanik has joined #bitcoin-core-dev
205 2017-09-01T14:48:13  *** paveljanik has joined #bitcoin-core-dev
206 2017-09-01T14:49:10  *** RoyceX has joined #bitcoin-core-dev
207 2017-09-01T14:49:47  *** Murch has joined #bitcoin-core-dev
208 2017-09-01T14:51:33  *** Gunnie has joined #bitcoin-core-dev
209 2017-09-01T14:51:49  *** cheese_ has quit IRC
210 2017-09-01T15:23:15  *** BashCo has quit IRC
211 2017-09-01T15:23:50  *** BashCo has joined #bitcoin-core-dev
212 2017-09-01T15:28:07  *** BashCo has quit IRC
213 2017-09-01T15:46:14  *** SopaXorzTaker has quit IRC
214 2017-09-01T15:49:03  *** chjj has joined #bitcoin-core-dev
215 2017-09-01T15:53:27  *** alreadylate has quit IRC
216 2017-09-01T15:53:40  *** SisterM has quit IRC
217 2017-09-01T15:57:22  *** BashCo has joined #bitcoin-core-dev
218 2017-09-01T15:58:56  *** SopaXorzTaker has joined #bitcoin-core-dev
219 2017-09-01T16:01:32  *** ethforever has joined #bitcoin-core-dev
220 2017-09-01T16:10:56  <bitcoin-git> [bitcoin] jnewbery closed pull request #11213: [trivial] [rpc] Fix getrawtransaction help for per-txout chainstate db (master...getrawtransactionhelp) https://github.com/bitcoin/bitcoin/pull/11213
221 2017-09-01T16:30:59  *** Gabo has joined #bitcoin-core-dev
222 2017-09-01T16:34:36  *** Gabo has quit IRC
223 2017-09-01T16:37:07  *** RubenSomsen has quit IRC
224 2017-09-01T16:49:04  *** dagurval has joined #bitcoin-core-dev
225 2017-09-01T16:52:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/d81dccf191a4...28f788e47e58
226 2017-09-01T16:52:35  <bitcoin-git> bitcoin/master be2a2ab John Newbery: [tests] fix - use rpc_timeout as rpc timeout
227 2017-09-01T16:52:35  <bitcoin-git> bitcoin/master 36b6268 John Newbery: [tests] TestNode: separate add_node from start_node...
228 2017-09-01T16:52:36  <bitcoin-git> bitcoin/master 6cf094a John Newbery: [tests] Avoid passing around member variables in test_framework
229 2017-09-01T16:53:20  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11121: TestNode tidyups (master...test_node_tidyups) https://github.com/bitcoin/bitcoin/pull/11121
230 2017-09-01T16:56:24  *** RubenSomsen has joined #bitcoin-core-dev
231 2017-09-01T17:02:44  *** abpa has joined #bitcoin-core-dev
232 2017-09-01T17:05:29  *** CubicEarth has joined #bitcoin-core-dev
233 2017-09-01T17:10:37  <bitcoin-git> [bitcoin] practicalswift closed pull request #11190: [tests] Remove unused imports (script.OP_0 and script.sha256) (master...remove-unused-import-op_0) https://github.com/bitcoin/bitcoin/pull/11190
234 2017-09-01T17:16:33  *** Yogaqueef has quit IRC
235 2017-09-01T17:19:28  *** Aaronvan_ has joined #bitcoin-core-dev
236 2017-09-01T17:21:48  *** AaronvanW has quit IRC
237 2017-09-01T17:29:41  *** lifeofguenter has quit IRC
238 2017-09-01T17:31:24  *** lifeofguenter has joined #bitcoin-core-dev
239 2017-09-01T17:44:01  *** CubicEar_ has joined #bitcoin-core-dev
240 2017-09-01T17:44:42  *** CubicEarth has quit IRC
241 2017-09-01T17:54:52  <GAit> jnewbery: thanks for the more feedback, updated the PR let me know if/when you want me to squash
242 2017-09-01T18:05:53  *** Giszmo has quit IRC
243 2017-09-01T18:07:01  *** CubicEar_ has quit IRC
244 2017-09-01T18:07:22  <paveljanik> Please close #11202
245 2017-09-01T18:09:47  *** CubicEarth has joined #bitcoin-core-dev
246 2017-09-01T18:13:05  *** timothy has quit IRC
247 2017-09-01T18:21:00  <jnewbery> MarcoFalke : silent merge conflict for #11121 :( I'll open a fixup PR
248 2017-09-01T18:21:23  <jnewbery> (bitcoin_cli.py didn't have the set_test_params() override)
249 2017-09-01T18:24:17  *** CubicEarth has quit IRC
250 2017-09-01T18:26:01  <bitcoin-git> [bitcoin] jnewbery opened pull request #11215: [tests] fixups from set_test_params() (master...bitcoin_cli_set_test_params) https://github.com/bitcoin/bitcoin/pull/11215
251 2017-09-01T18:26:29  <jnewbery> #11215 fixes it. Master won't be able to pass travis until that's merged.
252 2017-09-01T18:27:05  <jnewbery> wumpus sipa ^^ 2 line change in test file - can review/merge please?
253 2017-09-01T18:36:41  *** Dyaheon has quit IRC
254 2017-09-01T18:38:57  *** Dyaheon has joined #bitcoin-core-dev
255 2017-09-01T19:22:29  *** Giszmo has joined #bitcoin-core-dev
256 2017-09-01T19:31:02  *** alreadylate has joined #bitcoin-core-dev
257 2017-09-01T19:35:52  *** alreadylate has quit IRC
258 2017-09-01T19:59:30  *** AaronvanW has joined #bitcoin-core-dev
259 2017-09-01T20:02:04  *** SopaXorzTaker has quit IRC
260 2017-09-01T20:02:57  *** Aaronvan_ has quit IRC
261 2017-09-01T20:42:57  *** Dyaheon has quit IRC
262 2017-09-01T20:45:05  *** Dyaheon has joined #bitcoin-core-dev
263 2017-09-01T21:06:29  *** Guyver2 has quit IRC
264 2017-09-01T21:13:13  *** CubicEarth has joined #bitcoin-core-dev
265 2017-09-01T21:14:32  *** CubicEarth has quit IRC
266 2017-09-01T21:14:50  *** meshcollider has joined #bitcoin-core-dev
267 2017-09-01T21:27:25  *** laurentmt has quit IRC
268 2017-09-01T21:41:15  *** Gunnie has quit IRC
269 2017-09-01T21:55:01  *** str4d has joined #bitcoin-core-dev
270 2017-09-01T21:55:50  *** paveljanik has quit IRC
271 2017-09-01T22:16:00  *** RubenSomsen has quit IRC
272 2017-09-01T22:20:02  *** praxeology1 has joined #bitcoin-core-dev
273 2017-09-01T22:23:35  *** praxeology has quit IRC
274 2017-09-01T22:52:22  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/28f788e47e58...ec20f01ba094
275 2017-09-01T22:52:22  <bitcoin-git> bitcoin/master 3918d93 John Newbery: [tests] fixups from set_test_params()
276 2017-09-01T22:52:23  <bitcoin-git> bitcoin/master ec20f01 Pieter Wuille: Merge #11215: [tests] fixups from set_test_params()...
277 2017-09-01T22:53:03  <bitcoin-git> [bitcoin] sipa closed pull request #11215: [tests] fixups from set_test_params() (master...bitcoin_cli_set_test_params) https://github.com/bitcoin/bitcoin/pull/11215
278 2017-09-01T23:04:47  *** Cheeseo has joined #bitcoin-core-dev
279 2017-09-01T23:14:07  *** elkalamar has joined #bitcoin-core-dev
280 2017-09-01T23:14:21  *** Cheeseo has quit IRC
281 2017-09-01T23:26:22  *** belcher has joined #bitcoin-core-dev
282 2017-09-01T23:31:01  *** elkalamar has quit IRC
283 2017-09-01T23:58:15  *** abpa has quit IRC