1 2017-09-12T00:13:01  *** Aaronvan_ has quit IRC
  2 2017-09-12T00:23:35  *** promag has joined #bitcoin-core-dev
  3 2017-09-12T00:26:10  *** chjj has joined #bitcoin-core-dev
  4 2017-09-12T00:28:03  *** promag has quit IRC
  5 2017-09-12T00:49:35  <BlueMatt> grrrr why is practicalswift not in the contributors list so I can auto-complete his long-ass name
  6 2017-09-12T00:50:19  <luke-jr> that would be too … practical
  7 2017-09-12T00:50:20  * luke-jr hides
  8 2017-09-12T00:51:35  <BlueMatt> lol, oh so punny
  9 2017-09-12T00:51:54  * sipa hoped:
 10 2017-09-12T00:52:01  <sipa> * luke-jr hides swiftly
 11 2017-09-12T00:56:59  <gmaxwell> luke-jr: you live!
 12 2017-09-12T00:57:38  <BlueMatt> (and have internet)
 13 2017-09-12T00:57:41  *** luke-jr has quit IRC
 14 2017-09-12T00:57:58  <BlueMatt> lol errrr maybe not
 15 2017-09-12T00:58:29  <kallewoof> he made puns, so he seems to be doing okay. :) i dont think i'd be punning if i was in trouble.
 16 2017-09-12T00:58:57  <BlueMatt> kallewoof: well he ping-timeout'd, so at least the internet part may not be so stable :p
 17 2017-09-12T01:00:04  <kallewoof> he'll be okay. he was trained in the art of no internet at tokyo core dev when he was without his computer for basically an entire day.
 18 2017-09-12T01:00:13  <BlueMatt> :O
 19 2017-09-12T01:00:32  <kallewoof> yeah. *shudders*
 20 2017-09-12T01:05:04  *** justanotheruser has quit IRC
 21 2017-09-12T01:07:51  <kallewoof> Running a modified master but I just ran into EXCEPTION: 15dbwrapper_error and Database corrupted abd Corruption: not an sstable (bad magic number) etc. I can provide access to the machine with the node if someone feels intrigued by this, or I will just try to fix it. sipa etc?
 22 2017-09-12T01:08:04  <sipa> meshcollider: you should be able to restart travis jobs now
 23 2017-09-12T01:08:18  <kallewoof> ^Cing gave Error: Error: A fatal internal error occurred, see debug.log for details a few times.
 24 2017-09-12T01:08:36  <sipa> kallewoof: very little i can do...
 25 2017-09-12T01:08:55  <kallewoof> Okay. Seemed like a nice debugging opportunity, but ah well.
 26 2017-09-12T01:09:18  <sipa> i'd like to hear about the circumstances that led to the corruption though
 27 2017-09-12T01:09:39  <kallewoof> Node crashed due to my code (which was logging stuff to a file).
 28 2017-09-12T01:10:10  *** promag has joined #bitcoin-core-dev
 29 2017-09-12T01:10:46  <kallewoof> It was also running from gdb. I suspect that may have been a problem too.
 30 2017-09-12T01:11:00  *** justanotheruser has joined #bitcoin-core-dev
 31 2017-09-12T01:11:05  <sipa> ouch.
 32 2017-09-12T01:11:12  <sipa> that shouldn't cause corruption
 33 2017-09-12T01:11:14  <kallewoof> To clarify, I ran in gdb, hit the crash, killed process, and then restarted node and it started spewing these.
 34 2017-09-12T01:11:23  <kallewoof> My kill may have caused it?
 35 2017-09-12T01:11:33  <sipa> killing a process shouldn't cause db corruption
 36 2017-09-12T01:13:57  <kallewoof> Yeah, I've done it all the time. I didn't really do anything else noteworthy.
 37 2017-09-12T01:14:26  *** promag has quit IRC
 38 2017-09-12T01:15:05  <kallewoof> As a sidenote, despite the "see debug.log for details" message, there was nothing in the debug.log related to this.
 39 2017-09-12T01:16:56  <sipa> wow, that must be very old, and referring to bdb's debug log?
 40 2017-09-12T01:18:39  <kallewoof> Ohhh..
 41 2017-09-12T01:19:32  <sipa> or perhaps not
 42 2017-09-12T01:19:49  <kallewoof> It's in AbortNode in validation.cpp so seems to be about bitcoin, yeah.
 43 2017-09-12T01:20:01  *** chjj has quit IRC
 44 2017-09-12T01:22:49  <kallewoof> This is on a digital ocean instance, btw, which I assume us running everything RAIDed, so an actual disk corruption doesn't sound likely.
 45 2017-09-12T01:36:25  <sipa> that's also irrelevant; it's not the OS or the hardware that crashed, just a process
 46 2017-09-12T01:38:00  <kallewoof> If an actual disk error (bad block/sector/etc) was present surely it could cause a corruption in the db
 47 2017-09-12T01:38:23  *** chjj has joined #bitcoin-core-dev
 48 2017-09-12T01:50:39  *** RubenSomsen has joined #bitcoin-core-dev
 49 2017-09-12T01:52:16  <kallewoof> In case someone else has the issue, restarting the node actually solved it on my side.
 50 2017-09-12T01:56:57  *** Chris_Stewart_5 has quit IRC
 51 2017-09-12T02:12:18  *** promag has joined #bitcoin-core-dev
 52 2017-09-12T02:14:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 53 2017-09-12T02:17:03  *** promag has quit IRC
 54 2017-09-12T02:19:43  *** Murch has quit IRC
 55 2017-09-12T02:24:08  *** luke-jr has joined #bitcoin-core-dev
 56 2017-09-12T02:30:31  *** zmin has joined #bitcoin-core-dev
 57 2017-09-12T02:46:56  *** Chris_Stewart_5 has quit IRC
 58 2017-09-12T02:58:52  *** promag has joined #bitcoin-core-dev
 59 2017-09-12T03:03:29  *** promag has quit IRC
 60 2017-09-12T03:09:17  *** tknp has joined #bitcoin-core-dev
 61 2017-09-12T03:10:53  *** dabura667 has joined #bitcoin-core-dev
 62 2017-09-12T03:13:42  *** dabura667 has quit IRC
 63 2017-09-12T03:13:55  *** btcdrak has joined #bitcoin-core-dev
 64 2017-09-12T03:22:26  *** ula has quit IRC
 65 2017-09-12T03:31:12  *** justanotheruser has quit IRC
 66 2017-09-12T03:40:12  *** wxxs has quit IRC
 67 2017-09-12T03:43:16  *** wxxs has joined #bitcoin-core-dev
 68 2017-09-12T03:44:00  *** luke-jr has quit IRC
 69 2017-09-12T03:52:38  *** justanotheruser has joined #bitcoin-core-dev
 70 2017-09-12T04:05:56  *** RubenSomsen has quit IRC
 71 2017-09-12T04:19:53  *** tknp has quit IRC
 72 2017-09-12T04:23:43  *** tknp has joined #bitcoin-core-dev
 73 2017-09-12T05:03:19  *** paveljanik has quit IRC
 74 2017-09-12T05:15:32  *** promag has joined #bitcoin-core-dev
 75 2017-09-12T05:19:59  *** promag has quit IRC
 76 2017-09-12T05:35:36  *** zmin has quit IRC
 77 2017-09-12T05:47:41  *** wxxs has quit IRC
 78 2017-09-12T05:50:39  *** wxxs has joined #bitcoin-core-dev
 79 2017-09-12T05:53:19  *** arubi has joined #bitcoin-core-dev
 80 2017-09-12T06:02:00  *** promag has joined #bitcoin-core-dev
 81 2017-09-12T06:06:24  *** promag has quit IRC
 82 2017-09-12T06:07:25  *** tknp has quit IRC
 83 2017-09-12T06:08:28  <sipa> should the "this wallet is segwit" flag be a version number or a separate key in the wallet?
 84 2017-09-12T06:08:50  *** dabura667 has joined #bitcoin-core-dev
 85 2017-09-12T06:25:01  *** d9b4bef9 has quit IRC
 86 2017-09-12T06:26:07  *** d9b4bef9 has joined #bitcoin-core-dev
 87 2017-09-12T06:48:42  *** promag has joined #bitcoin-core-dev
 88 2017-09-12T06:53:10  *** promag has quit IRC
 89 2017-09-12T07:01:02  *** alreadylate has joined #bitcoin-core-dev
 90 2017-09-12T07:06:56  *** HTTP_____GK1wmSU has joined #bitcoin-core-dev
 91 2017-09-12T07:07:12  *** HTTP_____GK1wmSU has left #bitcoin-core-dev
 92 2017-09-12T07:14:03  *** dabura667 has quit IRC
 93 2017-09-12T07:18:21  *** RoyceX has quit IRC
 94 2017-09-12T07:18:25  *** dabura667 has joined #bitcoin-core-dev
 95 2017-09-12T07:20:33  *** belcher has quit IRC
 96 2017-09-12T07:23:30  *** HTTP_____GK1wmSU has joined #bitcoin-core-dev
 97 2017-09-12T07:23:48  *** CryDeTaa1 has quit IRC
 98 2017-09-12T07:25:01  *** alreadylate has quit IRC
 99 2017-09-12T07:26:16  *** HTTP_____GK1wmSU has left #bitcoin-core-dev
100 2017-09-12T07:30:22  <sipa> wumpus morcos sdaftuar BlueMatt jonasschnelli achow101 ^
101 2017-09-12T07:42:40  *** dabura667 has quit IRC
102 2017-09-12T07:45:03  <MarcoFalke> sipa: If it is a new version, we'd have to backport the usehd change to 0.15.1. Is that desired?
103 2017-09-12T07:46:18  <sipa> MarcoFalke: if it's not a new version, downgrading to 0.15.0 may cause lost funds
104 2017-09-12T07:47:27  <sipa> (not disagreeing with you, but there are issues both ways - i'm just wondering whether this was discussed already)
105 2017-09-12T07:47:54  <MarcoFalke> right. So there will only be segwit HD wallets
106 2017-09-12T07:54:45  *** alreadylate has joined #bitcoin-core-dev
107 2017-09-12T07:58:47  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11305: [doc] Update release notes and manpages for 0.16 (master...Mf1709-doc016) https://github.com/bitcoin/bitcoin/pull/11305
108 2017-09-12T08:03:17  *** gribble has quit IRC
109 2017-09-12T08:03:32  *** laurentmt has joined #bitcoin-core-dev
110 2017-09-12T08:24:56  *** sanjeev has quit IRC
111 2017-09-12T08:26:13  *** gribble has joined #bitcoin-core-dev
112 2017-09-12T08:56:36  *** promag has joined #bitcoin-core-dev
113 2017-09-12T08:59:06  *** promag has quit IRC
114 2017-09-12T09:04:47  *** timothy has joined #bitcoin-core-dev
115 2017-09-12T09:17:46  *** promag has joined #bitcoin-core-dev
116 2017-09-12T09:19:59  *** rabidus has quit IRC
117 2017-09-12T09:20:33  *** promag has quit IRC
118 2017-09-12T09:21:44  *** rabidus has joined #bitcoin-core-dev
119 2017-09-12T09:28:27  *** rabidus has quit IRC
120 2017-09-12T09:29:55  *** rabidus has joined #bitcoin-core-dev
121 2017-09-12T09:37:27  *** Guyver2 has joined #bitcoin-core-dev
122 2017-09-12T09:54:56  *** promag has joined #bitcoin-core-dev
123 2017-09-12T09:57:56  *** AaronvanW has joined #bitcoin-core-dev
124 2017-09-12T10:03:03  *** promag has joined #bitcoin-core-dev
125 2017-09-12T10:07:28  *** promag has quit IRC
126 2017-09-12T10:16:32  *** alreadylate has quit IRC
127 2017-09-12T10:18:28  *** alreadylate has joined #bitcoin-core-dev
128 2017-09-12T10:19:43  *** ula has joined #bitcoin-core-dev
129 2017-09-12T10:20:43  *** alreadylate has quit IRC
130 2017-09-12T10:24:04  *** promag has joined #bitcoin-core-dev
131 2017-09-12T10:26:13  <bitcoin-git> [bitcoin] danra opened pull request #11306: Refactor: Move core files from src root to src/core and improve inclu… (master...refactor/core-files) https://github.com/bitcoin/bitcoin/pull/11306
132 2017-09-12T10:46:33  *** RubenSomsen has joined #bitcoin-core-dev
133 2017-09-12T10:50:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11307: wallet: Display non-HD error on first run (master...Mf1709-walletHDfirst) https://github.com/bitcoin/bitcoin/pull/11307
134 2017-09-12T11:04:46  *** SopaXorzTaker has joined #bitcoin-core-dev
135 2017-09-12T11:11:03  *** promag has quit IRC
136 2017-09-12T11:14:10  *** promag has joined #bitcoin-core-dev
137 2017-09-12T11:23:37  *** alreadylate has joined #bitcoin-core-dev
138 2017-09-12T11:25:05  *** vicenteH has quit IRC
139 2017-09-12T11:29:02  *** vicenteH has joined #bitcoin-core-dev
140 2017-09-12T11:36:36  <morcos> sipa: Why would it cause funds loss?  Isn't it adding the segwit scrips to the wallet, which would be recognized by lower versions of wallets?
141 2017-09-12T11:37:04  <morcos> Yes old backups wouldn't work, but that's true for 0.15.1 as well
142 2017-09-12T11:37:50  <morcos> I thought the idea was to fix that with 0.16.0 by essentially tripling every existing key in the wallet (for all the segwit scripts)
143 2017-09-12T11:39:58  <morcos> I think it would be helpful to write up an issue the explains the whole 0.15.1 wallet plan in one place (in english) and the 0.16.0 wallet plan.  just so we can think through everything now
144 2017-09-12T11:42:43  <meshcollider> morcos: by tripling, do you mean one P2PKH, one P2SH and one BIP173?
145 2017-09-12T11:42:51  *** promag has quit IRC
146 2017-09-12T11:43:30  <meshcollider> +1 for doing a write up
147 2017-09-12T11:44:40  *** JackH has joined #bitcoin-core-dev
148 2017-09-12T11:48:06  <morcos> yes, P2SH wrapped segwit script for the middle one..  (and that's not exactly right, b/c i think we might add more than P2PKH for the legacy, but thats the idea)
149 2017-09-12T11:53:09  <meshcollider> so will P2SH-P2WPKH will be treated identically to the same address in P2PKH from the users perspective
150 2017-09-12T11:53:51  *** promag has joined #bitcoin-core-dev
151 2017-09-12T11:56:43  *** promag has quit IRC
152 2017-09-12T11:59:25  *** promag has joined #bitcoin-core-dev
153 2017-09-12T11:59:29  <morcos> meshcollider: the goal is no.  you should not get paid at an address you did not give out.  so if you give out a P2PKH, then that is how you should be paid and no one should be trying to wrap that up in some script or program and paying you to it
154 2017-09-12T12:00:16  <morcos> but for backwards compatibility with the way 0.15.0 and previous wallets worked, once we implement that functionality, then on upgrade your wallet will treat it as if you've given out all 3 variations for pre existing keys
155 2017-09-12T12:00:25  <morcos> but future keys will only be used for 1 variation
156 2017-09-12T12:01:35  <morcos> but we need the writeup to make sure it all makes sense...  seems like sipa was assuming that some level of upgrade is happening at 0.15.1 , but i thought there was no upgrade until 0.16.0, and that we weren't marking 0.15.1 wallets as special
157 2017-09-12T12:01:54  <morcos> other than that we'd be adding segwit addresses to them by default
158 2017-09-12T12:07:23  *** promag has quit IRC
159 2017-09-12T12:08:23  *** promag has joined #bitcoin-core-dev
160 2017-09-12T12:09:20  *** harding has joined #bitcoin-core-dev
161 2017-09-12T12:12:21  *** promag has quit IRC
162 2017-09-12T12:16:30  *** luke-jr has joined #bitcoin-core-dev
163 2017-09-12T12:21:35  *** promag has joined #bitcoin-core-dev
164 2017-09-12T12:23:55  *** goatpig has joined #bitcoin-core-dev
165 2017-09-12T12:26:14  *** promag has quit IRC
166 2017-09-12T12:33:05  *** luke-jr has quit IRC
167 2017-09-12T12:38:04  *** venzen has joined #bitcoin-core-dev
168 2017-09-12T12:53:41  *** wxxs has quit IRC
169 2017-09-12T12:53:49  *** Aaronvan_ has joined #bitcoin-core-dev
170 2017-09-12T12:55:34  *** AaronvanW has quit IRC
171 2017-09-12T12:57:00  *** luke-jr has joined #bitcoin-core-dev
172 2017-09-12T12:58:04  *** wxxs has joined #bitcoin-core-dev
173 2017-09-12T13:15:24  *** SergioMassa has joined #bitcoin-core-dev
174 2017-09-12T13:23:21  *** promag has joined #bitcoin-core-dev
175 2017-09-12T13:27:36  *** promag has quit IRC
176 2017-09-12T13:44:38  *** promag has joined #bitcoin-core-dev
177 2017-09-12T13:47:10  *** promag_ has joined #bitcoin-core-dev
178 2017-09-12T13:48:09  <BlueMatt> sipa: yea, what morcos said...I didnt think we were adding a "this wallet is segwit" flag for 0.15.1
179 2017-09-12T13:48:22  <BlueMatt> (and then a version bump in 16ish when we do a second hd split
180 2017-09-12T13:48:22  <BlueMatt> )
181 2017-09-12T13:49:36  *** promag_ has quit IRC
182 2017-09-12T13:49:44  *** promag has quit IRC
183 2017-09-12T13:53:00  *** luke-jr has quit IRC
184 2017-09-12T13:53:12  *** promag has joined #bitcoin-core-dev
185 2017-09-12T13:54:02  *** harrymm has quit IRC
186 2017-09-12T13:54:48  *** luke-jr has joined #bitcoin-core-dev
187 2017-09-12T13:56:19  *** promag has quit IRC
188 2017-09-12T13:56:50  *** harrymm has joined #bitcoin-core-dev
189 2017-09-12T14:01:38  *** promag has joined #bitcoin-core-dev
190 2017-09-12T14:03:24  *** intcat has quit IRC
191 2017-09-12T14:03:55  *** promag_ has joined #bitcoin-core-dev
192 2017-09-12T14:07:06  *** promag has quit IRC
193 2017-09-12T14:07:21  *** Evel-Knievel has quit IRC
194 2017-09-12T14:08:29  *** Evel-Knievel has joined #bitcoin-core-dev
195 2017-09-12T14:10:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
196 2017-09-12T14:16:02  *** justanotheruser has quit IRC
197 2017-09-12T14:18:22  *** promag_ has quit IRC
198 2017-09-12T14:22:45  *** promag has joined #bitcoin-core-dev
199 2017-09-12T14:26:57  *** RealM9 has joined #bitcoin-core-dev
200 2017-09-12T14:30:05  *** vicenteH has quit IRC
201 2017-09-12T14:30:16  *** vicenteH has joined #bitcoin-core-dev
202 2017-09-12T14:30:34  <RealM9> What? ae you going to release 0.15.1 with SW address support?
203 2017-09-12T14:30:40  <RealM9> Are*
204 2017-09-12T14:32:52  *** Murch has joined #bitcoin-core-dev
205 2017-09-12T14:34:08  *** RealM9 has quit IRC
206 2017-09-12T14:38:17  *** alreadylate has quit IRC
207 2017-09-12T14:38:50  <MarcoFalke> jnewbery: I don't think we should be encouraging refactoring pulls that change all apostrophes into quotation marks in python code
208 2017-09-12T14:39:05  <MarcoFalke> re #11291
209 2017-09-12T14:39:07  <gribble> https://github.com/bitcoin/bitcoin/issues/11291 | Fix PEP8 warnings about formatting by dongsam · Pull Request #11291 · bitcoin/bitcoin · GitHub
210 2017-09-12T14:40:11  <MarcoFalke> Also, we don't bulk-rename vars to snake_case in python.
211 2017-09-12T14:40:26  <MarcoFalke> All of this is a pain to review
212 2017-09-12T14:40:59  *** promag has quit IRC
213 2017-09-12T14:43:28  *** alreadylate has joined #bitcoin-core-dev
214 2017-09-12T14:56:25  *** AaronvanW has joined #bitcoin-core-dev
215 2017-09-12T14:57:01  *** Aaronvan_ has quit IRC
216 2017-09-12T15:05:24  *** meshcollider has quit IRC
217 2017-09-12T15:08:28  *** AaronvanW has quit IRC
218 2017-09-12T15:09:51  *** alreadylate has quit IRC
219 2017-09-12T15:11:22  *** AaronvanW has joined #bitcoin-core-dev
220 2017-09-12T15:18:35  *** Chris_Stewart_5 has quit IRC
221 2017-09-12T15:24:30  *** alreadylate has joined #bitcoin-core-dev
222 2017-09-12T15:25:47  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11308: [qa] zapwallettxes: Wait up to 3s for mempool reload (master...Mf1709-qaZap3s) https://github.com/bitcoin/bitcoin/pull/11308
223 2017-09-12T15:29:04  *** TEE_ has joined #bitcoin-core-dev
224 2017-09-12T15:32:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
225 2017-09-12T15:35:19  <BlueMatt> does anyone have numbers on transaction confirmation for rbf replacement txn?  I have a feeling it might be time to start tracking those in fee estimation
226 2017-09-12T16:05:53  *** chjj has quit IRC
227 2017-09-12T16:08:59  *** Victor_sueca has joined #bitcoin-core-dev
228 2017-09-12T16:10:18  *** Victorsueca has quit IRC
229 2017-09-12T16:14:38  *** Guyver2 has quit IRC
230 2017-09-12T16:20:05  *** TEE_ has quit IRC
231 2017-09-12T16:32:08  *** laurentmt has quit IRC
232 2017-09-12T16:43:48  *** alreadylate has quit IRC
233 2017-09-12T16:44:35  *** JackH has quit IRC
234 2017-09-12T16:56:53  *** alreadylate has joined #bitcoin-core-dev
235 2017-09-12T16:59:50  <jnewbery> MarcoFalke : sure. I didn't push back because the PR also does the useful job of updating the os.path calls in the same file. I'm not too concerned about accepting those changes but saying 'in general we don't accept style-only PRs', but if you want to take a harder line I think that's also fine.
236 2017-09-12T17:01:36  *** Dizzle has joined #bitcoin-core-dev
237 2017-09-12T17:02:35  *** wxxs has quit IRC
238 2017-09-12T17:02:35  <MarcoFalke> I am not keen on reviewing that. If you feel like making sure that all the refactoring parts preserve functionality 100%, go ahead. I am not aware of a good way to do that when it is not a scripted diff. And a scripted diff is overkill for those formatting changes
239 2017-09-12T17:03:20  *** abpa has joined #bitcoin-core-dev
240 2017-09-12T17:05:48  *** wxxs has joined #bitcoin-core-dev
241 2017-09-12T17:08:42  <jnewbery> MarcoFalke : can you merge #11230 ? dbcrash.py is still failing
242 2017-09-12T17:08:43  <gribble> https://github.com/bitcoin/bitcoin/issues/11230 | [tests] fixup dbcrash interaction with add_nodes() by jnewbery · Pull Request #11230 · bitcoin/bitcoin · GitHub
243 2017-09-12T17:08:45  <bitcoin-git> [bitcoin] morcos opened pull request #11309: Minor cleanups for AcceptToMemoryPool (master...ATMP_cleanup) https://github.com/bitcoin/bitcoin/pull/11309
244 2017-09-12T17:16:44  *** JackH has joined #bitcoin-core-dev
245 2017-09-12T17:21:31  *** JackH has quit IRC
246 2017-09-12T17:24:56  <MarcoFalke> sure. Thx, somehow missed that
247 2017-09-12T17:28:45  *** rockhouse has quit IRC
248 2017-09-12T17:30:18  *** rockhouse has joined #bitcoin-core-dev
249 2017-09-12T17:30:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b9bceaf1c081...b37cab65c63e
250 2017-09-12T17:30:19  <bitcoin-git> bitcoin/master 8fdb6f9 John Newbery: [tests] fixup dbcrash interaction with add_nodes()
251 2017-09-12T17:30:20  <bitcoin-git> bitcoin/master b37cab6 MarcoFalke: Merge #11230: [tests] fixup dbcrash interaction with add_nodes()...
252 2017-09-12T17:30:59  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11230: [tests] fixup dbcrash interaction with add_nodes() (master...fixup_dbcrash) https://github.com/bitcoin/bitcoin/pull/11230
253 2017-09-12T17:32:11  *** JackH has joined #bitcoin-core-dev
254 2017-09-12T17:32:17  <jnewbery> MarcoFalke : thanks!
255 2017-09-12T17:36:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b37cab65c63e...c377feaad87f
256 2017-09-12T17:37:00  <bitcoin-git> bitcoin/master 24697c4 Wladimir J. van der Laan: rpc: update cli for estimatefee argument rename...
257 2017-09-12T17:37:00  <bitcoin-git> bitcoin/master 5acd82d Wladimir J. van der Laan: rpc: make estimatesmartfee argument naming consistent with documentation...
258 2017-09-12T17:37:01  <bitcoin-git> bitcoin/master c377fea MarcoFalke: Merge #11267: rpc: update cli for estimate*fee argument rename...
259 2017-09-12T17:37:35  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11267: rpc: update cli for estimate*fee argument rename (master...2017_09_renamed_estimatefee_arg) https://github.com/bitcoin/bitcoin/pull/11267
260 2017-09-12T17:39:20  *** timothy has quit IRC
261 2017-09-12T17:41:22  *** harrymm has quit IRC
262 2017-09-12T17:47:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c377feaad87f...b148803b181e
263 2017-09-12T17:47:17  <bitcoin-git> bitcoin/master b8d91e0 practicalswift: [Docs] Fix broken Markdown table in dependencies.md. Cleanups....
264 2017-09-12T17:47:17  <bitcoin-git> bitcoin/master b148803 MarcoFalke: Merge #11264: [doc] Fix broken Markdown table in dependencies.md...
265 2017-09-12T17:47:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11264: [doc] Fix broken Markdown table in dependencies.md (master...dependencies-capitalization) https://github.com/bitcoin/bitcoin/pull/11264
266 2017-09-12T17:54:05  *** Victor_sueca is now known as Victorsueca
267 2017-09-12T17:56:32  *** luke-jr has quit IRC
268 2017-09-12T18:03:53  <sipa> morcos: right, starting to remember
269 2017-09-12T18:04:34  <sipa> morcos: so really all we need is automatically addwitnessifying newly generated addresses (while properly marking them as change, ...)
270 2017-09-12T18:06:08  *** Chris_Stewart_5 has quit IRC
271 2017-09-12T18:07:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
272 2017-09-12T18:19:47  *** Chris_St1 has joined #bitcoin-core-dev
273 2017-09-12T18:20:48  *** Chris_Stewart_5 has quit IRC
274 2017-09-12T18:22:44  *** Dizzle has quit IRC
275 2017-09-12T18:22:48  *** alreadylate has quit IRC
276 2017-09-12T18:29:22  *** SopaXorzTaker has quit IRC
277 2017-09-12T18:33:58  *** JackH has quit IRC
278 2017-09-12T18:34:16  *** luke-jr has joined #bitcoin-core-dev
279 2017-09-12T18:36:35  *** Chris_St1 has quit IRC
280 2017-09-12T18:36:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
281 2017-09-12T18:43:01  *** luke-jr has quit IRC
282 2017-09-12T18:45:35  *** JackH has joined #bitcoin-core-dev
283 2017-09-12T18:58:54  <bitcoin-git> [bitcoin] mess110 opened pull request #11310: [tests] Test listwallets RPC (master...master) https://github.com/bitcoin/bitcoin/pull/11310
284 2017-09-12T19:01:34  <morcos> sipa: yes, i think.  depending on what you mean by properly marking them as change?
285 2017-09-12T19:06:38  <sipa> morcos: addwitnessaddress currently always assigns a label to the address, causing it to be treated as non-change
286 2017-09-12T19:09:11  <morcos> sipa: right ok, so sometimes you'll do that, and sometimes you won't depending on the path by which we got to that
287 2017-09-12T19:10:04  <sipa> right
288 2017-09-12T19:11:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b148803b181e...ce829855cfca
289 2017-09-12T19:11:53  <bitcoin-git> bitcoin/master 581c411 Kyuntae Ethan Kim: Properly comment about shutdown process in init.cpp file
290 2017-09-12T19:11:53  <bitcoin-git> bitcoin/master ce82985 MarcoFalke: Merge #10691: Trivial: Properly comment about shutdown process in init.cpp file....
291 2017-09-12T19:12:18  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10691: Trivial: Properly comment about shutdown process in init.cpp file. (master...master) https://github.com/bitcoin/bitcoin/pull/10691
292 2017-09-12T19:14:06  *** paveljanik has joined #bitcoin-core-dev
293 2017-09-12T19:14:06  *** paveljanik has joined #bitcoin-core-dev
294 2017-09-12T19:18:12  *** Chris_Stewart_5 has quit IRC
295 2017-09-12T19:28:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
296 2017-09-12T19:40:06  *** Cheeseo has joined #bitcoin-core-dev
297 2017-09-12T19:44:45  *** nelruk has joined #bitcoin-core-dev
298 2017-09-12T19:45:23  *** StopAndDecrypt has joined #bitcoin-core-dev
299 2017-09-12T19:54:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce829855cfca...801dd40666d1
300 2017-09-12T19:54:01  <bitcoin-git> bitcoin/master 8d82e13 Luke Dashjr: Travis: Remove bc tool from dependencies
301 2017-09-12T19:54:01  <bitcoin-git> bitcoin/master 6d2aac8 Luke Dashjr: Travis: Test build against system libs (& Qt4)
302 2017-09-12T19:54:02  <bitcoin-git> bitcoin/master 801dd40 MarcoFalke: Merge #7142: Travis: Test build against system libs (& Qt4)...
303 2017-09-12T20:03:38  *** alreadylate has joined #bitcoin-core-dev
304 2017-09-12T20:04:18  *** ghost43_ has joined #bitcoin-core-dev
305 2017-09-12T20:04:53  *** ghost43 has quit IRC
306 2017-09-12T20:05:29  *** belcher has joined #bitcoin-core-dev
307 2017-09-12T20:16:37  *** chjj has joined #bitcoin-core-dev
308 2017-09-12T20:16:57  *** StopAndDecrypt has quit IRC
309 2017-09-12T20:18:00  *** StopAndDecrypt has joined #bitcoin-core-dev
310 2017-09-12T20:29:57  *** alreadylate has quit IRC
311 2017-09-12T20:32:52  *** abpa has quit IRC
312 2017-09-12T20:35:59  *** sdaftuar has quit IRC
313 2017-09-12T20:38:35  *** jnewbery has quit IRC
314 2017-09-12T20:38:42  *** morcos has quit IRC
315 2017-09-12T20:40:16  *** abpa has joined #bitcoin-core-dev
316 2017-09-12T20:46:24  *** jnewbery has joined #bitcoin-core-dev
317 2017-09-12T20:56:28  *** nelruk has quit IRC
318 2017-09-12T20:58:36  *** meshcollider has joined #bitcoin-core-dev
319 2017-09-12T21:01:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11311: travis: Revert default datadir check (master...Mf1709-travisDatadirRevert) https://github.com/bitcoin/bitcoin/pull/11311
320 2017-09-12T21:02:59  *** paveljanik has quit IRC
321 2017-09-12T21:05:21  *** rabidus has quit IRC
322 2017-09-12T21:17:14  *** seone has joined #bitcoin-core-dev
323 2017-09-12T21:17:46  <seone> Heya all :)
324 2017-09-12T21:19:00  <seone> Though i should join here from time to time, if you mention me to be here on the Translations site xD
325 2017-09-12T21:20:24  *** RubenSomsen has quit IRC
326 2017-09-12T21:22:17  <sipa> ohai
327 2017-09-12T21:22:24  *** SergioMassa has quit IRC
328 2017-09-12T21:23:49  *** Cheeseo has quit IRC
329 2017-09-12T21:33:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/801dd40666d1...cce94c518a46
330 2017-09-12T21:33:02  <bitcoin-git> bitcoin/master fa4fad9 MarcoFalke: travis: Revert default datadir check
331 2017-09-12T21:33:03  <bitcoin-git> bitcoin/master cce94c5 MarcoFalke: Merge #11311: travis: Revert default datadir check...
332 2017-09-12T21:33:37  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11311: travis: Revert default datadir check (master...Mf1709-travisDatadirRevert) https://github.com/bitcoin/bitcoin/pull/11311
333 2017-09-12T21:41:01  *** goatpig has quit IRC
334 2017-09-12T21:47:15  *** StopAndDecrypt_ has joined #bitcoin-core-dev
335 2017-09-12T21:48:17  *** StopAndDecrypt has quit IRC
336 2017-09-12T21:58:27  *** rabidus has joined #bitcoin-core-dev
337 2017-09-12T21:58:58  *** tknp has joined #bitcoin-core-dev
338 2017-09-12T21:59:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cce94c518a46...96ac26e56627
339 2017-09-12T21:59:44  <bitcoin-git> bitcoin/master fb1f325 Cristian Mircea Messel: Add listwallets RPC test to multiwallet.py
340 2017-09-12T21:59:44  <bitcoin-git> bitcoin/master 96ac26e MarcoFalke: Merge #11310: [tests] Test listwallets RPC...
341 2017-09-12T22:00:27  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11310: [tests] Test listwallets RPC (master...master) https://github.com/bitcoin/bitcoin/pull/11310
342 2017-09-12T22:02:07  <BlueMatt> OK, 0.15 PPAs are (finally) up...just had to hack in xvfb and backport 11210...
343 2017-09-12T22:03:04  <BlueMatt> hmm, no, well x86 builds worked, test_bitcoin-qt still failed on arm :(
344 2017-09-12T22:03:29  *** Cheeseo has joined #bitcoin-core-dev
345 2017-09-12T22:05:21  *** LeMiner2 has quit IRC
346 2017-09-12T22:14:01  *** Chris_Stewart_5 has quit IRC
347 2017-09-12T22:20:40  *** ghost43_ is now known as ghost43
348 2017-09-12T22:30:25  *** Ylbam has joined #bitcoin-core-dev
349 2017-09-12T22:45:36  *** Cheeseo has quit IRC
350 2017-09-12T22:46:35  *** vicenteH has quit IRC
351 2017-09-12T22:46:55  *** harrymm has joined #bitcoin-core-dev
352 2017-09-12T23:10:53  *** strida has joined #bitcoin-core-dev
353 2017-09-12T23:29:34  *** luke-jr has joined #bitcoin-core-dev
354 2017-09-12T23:48:54  *** Anduck has quit IRC
355 2017-09-12T23:48:59  *** Anduck_ has joined #bitcoin-core-dev
356 2017-09-12T23:49:21  *** Alina-malina has quit IRC
357 2017-09-12T23:50:03  *** Alina-malina has joined #bitcoin-core-dev
358 2017-09-12T23:50:50  <bitcoin-git> [bitcoin] mess110 opened pull request #11314: Add abortrescan RPC test (master...add-abortrescan-rpc-test) https://github.com/bitcoin/bitcoin/pull/11314
359 2017-09-12T23:51:48  *** strida has quit IRC
360 2017-09-12T23:58:25  *** meshcollider has quit IRC
361 2017-09-12T23:58:29  *** abpa has quit IRC
362 2017-09-12T23:59:28  *** luke-jr has quit IRC