1 2017-09-15T00:18:23  *** Squidicuz has quit IRC
  2 2017-09-15T00:19:20  *** molz has joined #bitcoin-core-dev
  3 2017-09-15T00:20:51  *** Squidicuz has joined #bitcoin-core-dev
  4 2017-09-15T00:27:35  *** Alina-malina has quit IRC
  5 2017-09-15T00:28:23  *** Murch has quit IRC
  6 2017-09-15T00:28:46  *** Alina-malina has joined #bitcoin-core-dev
  7 2017-09-15T00:33:41  *** AaronvanW has quit IRC
  8 2017-09-15T00:58:50  *** dabura667 has joined #bitcoin-core-dev
  9 2017-09-15T01:01:42  *** harrymm has quit IRC
 10 2017-09-15T01:05:13  *** harrymm has joined #bitcoin-core-dev
 11 2017-09-15T01:12:56  *** dabura667 has quit IRC
 12 2017-09-15T01:14:06  *** clarkmoody has quit IRC
 13 2017-09-15T01:14:24  *** clarkmoody has joined #bitcoin-core-dev
 14 2017-09-15T01:16:20  *** dabura667 has joined #bitcoin-core-dev
 15 2017-09-15T01:19:17  *** Ylbam has quit IRC
 16 2017-09-15T01:27:09  *** AaronvanW has joined #bitcoin-core-dev
 17 2017-09-15T01:51:55  *** alxlu has joined #bitcoin-core-dev
 18 2017-09-15T01:52:53  *** pbase has joined #bitcoin-core-dev
 19 2017-09-15T01:55:40  *** RubenSomsen has joined #bitcoin-core-dev
 20 2017-09-15T02:04:34  *** fluidjax has quit IRC
 21 2017-09-15T02:05:52  *** dabura667_ has joined #bitcoin-core-dev
 22 2017-09-15T02:06:05  *** dabura667 has quit IRC
 23 2017-09-15T02:25:21  *** justan0theruser has joined #bitcoin-core-dev
 24 2017-09-15T02:43:23  *** AaronvanW has quit IRC
 25 2017-09-15T02:49:17  *** AaronvanW has joined #bitcoin-core-dev
 26 2017-09-15T03:09:20  *** jtimon has quit IRC
 27 2017-09-15T03:14:48  *** justan0theruser has quit IRC
 28 2017-09-15T03:31:22  *** justan0theruser has joined #bitcoin-core-dev
 29 2017-09-15T03:36:54  *** Giszmo has quit IRC
 30 2017-09-15T03:38:29  *** bane5000 has joined #bitcoin-core-dev
 31 2017-09-15T03:54:29  *** Alina-malina has quit IRC
 32 2017-09-15T03:54:30  *** Alina-malina has joined #bitcoin-core-dev
 33 2017-09-15T03:57:59  <achow101> was there any agreement on whether there would be a 0.15.0.1 with BlueMatt's fix for the customfeeradio thing?
 34 2017-09-15T03:58:44  <gmaxwell> No soap radio.
 35 2017-09-15T03:59:05  * luke-jr thinks it'd be better to do 0.15.1 with a few more fixes
 36 2017-09-15T03:59:47  <gmaxwell> achow101: I think the plan right now is that we will fix things and get them into the 0.15 branch ASAP, then wladimir will decide to do a release or not.
 37 2017-09-15T04:00:08  <achow101> ok
 38 2017-09-15T04:00:36  <achow101> I'm working on the permanent fix right now
 39 2017-09-15T04:01:18  <luke-jr> ie removing the radio entirely?
 40 2017-09-15T04:01:21  <gmaxwell> luke-jr: what other moderately important things are there that we know of now
 41 2017-09-15T04:01:37  <achow101> luke-jr: yes
 42 2017-09-15T04:02:28  <luke-jr> gmaxwell: if it was important, it'd have blocked 0.15.0; is there a reason *not* to backport the GUI positioning fix & similar stuff, if we're doing another RC cycle?
 43 2017-09-15T04:03:02  * luke-jr wonders what changed with PPA stuff to break the build there.
 44 2017-09-15T04:03:04  <gmaxwell> oh did we make a post 0.15 positioning fix too
 45 2017-09-15T04:03:25  <achow101> I don't think so
 46 2017-09-15T04:03:37  <luke-jr> #11208 ?
 47 2017-09-15T04:03:39  <gribble> https://github.com/bitcoin/bitcoin/issues/11208 | Fixing offscreen GUI issue by MeshCollider · Pull Request #11208 · bitcoin/bitcoin · GitHub
 48 2017-09-15T04:03:56  <achow101> I thought that was determined to not be a problem by jonasschnelli
 49 2017-09-15T04:04:17  <achow101> I believe the problem was I was testing on either an old version or with custom something that gave me the error
 50 2017-09-15T04:04:26  <achow101> s/error/issue
 51 2017-09-15T04:04:28  <jonasschnelli> achow101: it may be a problem for the PPA.
 52 2017-09-15T04:04:54  <jonasschnelli> From what I knew so far was that the offscreen issue only affected windows
 53 2017-09-15T04:05:10  <luke-jr> gitian binaries are not the only supported (or even preferred) deployment..
 54 2017-09-15T04:05:18  <gmaxwell> I believe there are still problems. Go position the window as far down and left as you can, then restart... But perhaps for 0.15.0.1 we would just disable remembered position rather than twiddling around with it.
 55 2017-09-15T04:05:21  <jonasschnelli> Offscreen situations are usually handled by the OS
 56 2017-09-15T04:06:10  *** pbase has quit IRC
 57 2017-09-15T04:06:17  <jonasschnelli> stop remembering position would be reducing a feature for a few having problem with it.
 58 2017-09-15T04:06:57  <gmaxwell> Yes, but the feature is minor (the software already takes a very long time to start) and the issue is very severe.
 59 2017-09-15T04:07:13  <gmaxwell> I'm not saying that I think it should go away forever.
 60 2017-09-15T04:07:26  <jonasschnelli> Some users arrange windows pixel by pixel.. :)
 61 2017-09-15T04:08:00  <gmaxwell> But if we want to make a quick release it would be an easy way to prevent it from being a problem for sure.
 62 2017-09-15T04:09:24  <meshcollider> 11208 checks for full window inclusion on the screen, and uses available screen geometry not full screen so that whatever taskbars or things dont get in the way either
 63 2017-09-15T04:09:49  <meshcollider> so I think its still an improvement even if the original issue is gone
 64 2017-09-15T04:10:08  <gmaxwell> meshcollider: that sounds like the right thing to do.  But also sounds like it deserves non-trivial testing with weird setups.
 65 2017-09-15T04:10:44  <bitcoin-git> [bitcoin] achow101 opened pull request #11334: Remove custom fee radio group and remove nCustomFeeRadio setting (master...rm-nCustomFeeRadio) https://github.com/bitcoin/bitcoin/pull/11334
 66 2017-09-15T04:10:49  <jonasschnelli> gmaxwell: I just moved the windows as far down as possible and it reopened there... is that a problem?
 67 2017-09-15T04:10:51  <jonasschnelli> Same happends to notepad.exe
 68 2017-09-15T04:10:57  <jonasschnelli> *happens
 69 2017-09-15T04:11:14  <jonasschnelli> (Windows 8.1)
 70 2017-09-15T04:12:11  <gmaxwell> can you get it back out of that position again
 71 2017-09-15T04:13:04  <jonasschnelli> Yes.
 72 2017-09-15T04:13:22  <jonasschnelli> (Testing 0.15)
 73 2017-09-15T04:13:28  <luke-jr> what if you use the keyboard to move it such that the titlebar isn't visible?
 74 2017-09-15T04:13:54  <bane5000> so i've enabled pruning on my core wallet (by creating bitcoin.conf in ~/.bitcoin/) and adding pruning=10000
 75 2017-09-15T04:14:14  <bane5000> i've restarted the bitcoin-qt, however, the old blocks do not seem to be disappearing, as my harddrive space has not been reduced
 76 2017-09-15T04:14:15  <luke-jr> bane5000: you mean prune=10000 ? note that user issues should be in #bitcoin though
 77 2017-09-15T04:14:29  <gmaxwell> e.g. if your screen is 1920x1080, what happens if the location is 1919,1079
 78 2017-09-15T04:14:41  <bane5000> luke-jr: Whoopsy :)
 79 2017-09-15T04:15:27  <bane5000> luke-jr: Would you recommend keeping a certain amount of blocks? Perhaps 20 gigs?
 80 2017-09-15T04:15:43  <luke-jr> bane5000: #bitcoin please
 81 2017-09-15T04:15:49  <bane5000> ugh :(
 82 2017-09-15T04:15:57  <bane5000> You probably give a better opinion though, but fine
 83 2017-09-15T04:16:04  <luke-jr> I'm there too
 84 2017-09-15T04:16:28  <jonasschnelli> gmaxwell: I guess you can only position to right-bottom -1,-1 with rededit.exe
 85 2017-09-15T04:16:51  <bane5000> okay :)
 86 2017-09-15T04:16:51  <jonasschnelli> IMO it reacts as expected and identical to any other window based windows application
 87 2017-09-15T04:17:27  <gmaxwell> jonasschnelli: I think you could do so pretty easily like this: increase your resolution, position it to the right bottom of your lower resolution, decrease resolution.
 88 2017-09-15T04:17:44  <gmaxwell> Though there may be other ways to end up there.
 89 2017-09-15T04:17:49  <meshcollider> but its not practical if it appears mostly offscreen, having to manually move it, even if thats what other windows do
 90 2017-09-15T04:18:08  <jonasschnelli> gmaxwell: I did change the screen size and it relocates to center at a certain point.
 91 2017-09-15T04:18:49  <jonasschnelli> Maybe (like in a flexible screen size vm like I test in) you can end up by only showing a single pixel of the window... but I guess the OS makes sure you always see the left-top icon
 92 2017-09-15T04:19:06  <jonasschnelli> However, I think this is not a problem anymore in 0.15 gitian binaries...
 93 2017-09-15T04:19:25  <gmaxwell> if the OS does then thats probably sufficient, but then I don't understand how we ended up completely off the screen.
 94 2017-09-15T04:19:32  <jonasschnelli> I'm unsure about compiling it manually ... though I'm not sure how you would do this on windows
 95 2017-09-15T04:19:55  <gmaxwell> jonasschnelli: we still support QT4 and earlier QT5 too.. it's not fixed unless we have a workaround or refuse to build with incompatible versions.
 96 2017-09-15T04:20:07  <jonasschnelli> gmaxwell: completely off the screen with 0.15 gitian binaries on Windows seems very unlikely (I could not reproduce it and I tried for 1-2 h)
 97 2017-09-15T04:20:48  <jonasschnelli> gmaxwell: I agree about Qt4. But I don't think anyone builds a Windows binary without our depends system. It would be a nightmare
 98 2017-09-15T04:20:58  <gmaxwell> maybe for windows you could argue to ignore anything but gitian but we could end up off screen on linux too.. can't we
 99 2017-09-15T04:21:50  <achow101> is qt4 supported only for the ppa?
100 2017-09-15T04:21:53  <jonasschnelli> I have testes offscreen on Ubuntu 14, 16 and could also not reproduce it (by fiddling with the QSettings to set if offscreen). But possible for Qt5.
101 2017-09-15T04:21:56  <jonasschnelli> Qt4, I meant
102 2017-09-15T04:22:25  <jonasschnelli> achow101: I think BlueMatt has a reason to build it against Qt4... some KDE or something
103 2017-09-15T04:22:40  <luke-jr> jonasschnelli: testing merely Ubuntu is not meaningful.. there are many WMs, and Ubuntu only uses one or two
104 2017-09-15T04:23:09  <jonasschnelli> luke-jr: Yes. I agree. But IMO this is why we use Qt. Offscreen is either a OS thing or a QT thing.
105 2017-09-15T04:23:25  <luke-jr> I suppose testing without a WM (X11 and Wayland?) might be a good approach
106 2017-09-15T04:23:36  <jonasschnelli> If we are going to add patch for every WM, we will have a horrific cross-platform source code base
107 2017-09-15T04:23:44  <jonasschnelli> *add patches
108 2017-09-15T04:24:01  <luke-jr> I don't see why that'd be necessary
109 2017-09-15T04:24:13  <luke-jr> fixing it for the dumb-WM-with-no-protection should fix it for all
110 2017-09-15T04:24:22  <jonasschnelli> Offscreen seems very upstreamish... we (or someone else) need to fix it there (if its really an issue)
111 2017-09-15T04:24:39  <luke-jr> that assumes we're using upstream correctly
112 2017-09-15T04:24:56  <gmaxwell> saving location _at all_ seems upstreamish, but we have an implementation of that-- it seems to me that if we're implementing it, we're probably stuck implementing it completely.
113 2017-09-15T04:25:14  <jonasschnelli> I'm happy to review a patch... but quick-cross-platform fixed did turn out to be much more complicated then often initially intended
114 2017-09-15T04:25:16  <luke-jr> gmaxwell: +1
115 2017-09-15T04:25:25  <jonasschnelli> gmaxwell: Indeed
116 2017-09-15T04:26:57  <jonasschnelli> related: http://doc.qt.io/qt-4.8/restoring-geometry.html
117 2017-09-15T04:27:16  <jonasschnelli> Document still available in the Qt5.9 docs: http://doc.qt.io/qt-5/restoring-geometry.html
118 2017-09-15T04:27:40  <achow101> jonasschnelli: can we not just do that then to support the fix for qt4 and 5?
119 2017-09-15T04:27:59  <jonasschnelli> achow101: do what?
120 2017-09-15T04:28:02  <meshcollider> Should I modify 11208 to just call restoreGeometry
121 2017-09-15T04:28:38  <luke-jr> we should investigate if Qt actually implements it sanely
122 2017-09-15T04:28:40  <achow101> jonasschnelli: whatever those pages say to restore geometry
123 2017-09-15T04:29:04  <meshcollider> Those pages suggest either using restoreGeometry OR doing it how 11208 does it I believe
124 2017-09-15T04:29:13  <luke-jr> "The restore function also checks if the restored geometry is outside the available screen geometry, and modifies it as appropriate if it is:" sounds hopeful
125 2017-09-15T04:29:20  <jonasschnelli> achow101: Yes. We should update to restoreGeometry... maybe this does internally check the bounds.
126 2017-09-15T04:29:45  <jonasschnelli> Seems the much better approach then fiddling with the position (which is what Qt is supposed to do)
127 2017-09-15T04:30:09  <jonasschnelli> luke-jr: +1
128 2017-09-15T04:31:39  <jonasschnelli> Yes should replace our own saveWindowGeometry/restoreWindowGeometry with the Qt ones (not directly possible for the save)
129 2017-09-15T04:32:23  <gmaxwell> I wonder how this stuff interacts with -geometry
130 2017-09-15T04:32:47  <achow101> jonasschnelli: I tried with gmaxwell's suggestion of 1919,1079 and the window is definitely not visible on screen
131 2017-09-15T04:33:10  <jonasschnelli> achow101: via regedit.exe?
132 2017-09-15T04:33:14  <achow101> yeah
133 2017-09-15T04:33:34  <jonasschnelli> 0.15.0 gitian binaries?
134 2017-09-15T04:33:39  <achow101> yes, from bitcoin.org
135 2017-09-15T04:33:57  <jonasschnelli> What happens if you place then +2 px?
136 2017-09-15T04:35:03  <jonasschnelli> achow101: Maybe this is the expected behavior: if you place the window in screen (manually with RedEdit.exe), you want to reopen there? To hit this by accident seems very unlikely
137 2017-09-15T04:35:33  <gmaxwell> jonasschnelli: I explained before. If you increase your resolution, position there. Shut down bitcoin. Reduce resolution.  You will be in this state.
138 2017-09-15T04:35:48  <jonasschnelli> gmaxwell: That's a different issue.. that is solved.
139 2017-09-15T04:35:55  <luke-jr> …
140 2017-09-15T04:35:57  <gmaxwell> It's a hard state to get into, but then "my bitcoins are gone!"   -- a typical user will not be able to recover without a tech guru friend at least.
141 2017-09-15T04:35:57  <jonasschnelli> achow101: placed it in-screen (-1,-1)
142 2017-09-15T04:36:11  <luke-jr> jonasschnelli: you can get (1919,1079) the way gmaxwell describes
143 2017-09-15T04:36:16  *** harrymm has quit IRC
144 2017-09-15T04:36:21  <jonasschnelli> luke-jr: how?
145 2017-09-15T04:36:32  <luke-jr> jonasschnelli: try to position it on the second monitor without snapping
146 2017-09-15T04:36:41  <achow101> jonasschnelli: anything that is technically on screen like 1919,1079 will not be fixed. but the user can't get to it
147 2017-09-15T04:37:03  <jonasschnelli> luke-jr: Thats indeed a viable argument
148 2017-09-15T04:37:21  <jonasschnelli> But wait...
149 2017-09-15T04:37:25  <gmaxwell> jonasschnelli: with a higher resolution you can easily drag to 1919,1079 (for example).
150 2017-09-15T04:37:28  <achow101> jonasschnelli: I increased the position so that I could see it. most of the window is off screen, but the corner that matters is
151 2017-09-15T04:37:42  <achow101> it can easily be covered up by the taskbar too so users can't get to it
152 2017-09-15T04:37:57  <jonasschnelli> I wonder how other applicationes (test Notepad.exe) would react in this case
153 2017-09-15T04:38:07  <luke-jr> stupidly IIRC
154 2017-09-15T04:38:20  <gmaxwell> (and there is probably a few pixel radius which is totally inaccessible but technically on the screen where the current behavior is not sufficient. But meshcollider's or hopefully QT's would be.
155 2017-09-15T04:38:54  <gmaxwell> Even if notepad is wrong (would be interesting to find out!) that still doesn't excuse bitcoin-- losing notepad is less serious then your wallet. :)
156 2017-09-15T04:38:59  <achow101> jonasschnelli: it does exactly the same thing; so long as the top left corner is technically on screen, it stays there
157 2017-09-15T04:39:06  <luke-jr> we can actually continue saving as we do now, but after restoring, call restoreWindowGeometry(saveWindowGeometry())…
158 2017-09-15T04:39:17  <luke-jr> gmaxwell: but my metadata!
159 2017-09-15T04:39:23  <meshcollider> Somethign like this: https://github.com/MeshCollider/bitcoin/commit/e70a784486fdda12a8a949dbb3f5fe5ea1054511
160 2017-09-15T04:39:26  <jonasschnelli> I think we should update our codebase to use the Qt designated functions for restoring geometry (also available on Qt4) and see if this is better,.. then decide to patch this edge-case explicit in our codebase
161 2017-09-15T04:39:26  <meshcollider> havent tested yet though
162 2017-09-15T04:39:44  <jonasschnelli> achow101: you mean with Notepad.exe?
163 2017-09-15T04:39:47  <gmaxwell> yea, well I think we have a target edge case to test now. Hopefully QT does the right thing.
164 2017-09-15T04:40:36  <achow101> jonasschnelli: yes
165 2017-09-15T04:40:43  <jonasschnelli> I'm still convinced that this issue needs to be fixed in the cross-platform layer (Qt) rather then in the application GUI logic
166 2017-09-15T04:41:21  <jonasschnelli> I saw many cross-platform projects struggle after adding to much cross-platform UI patches and glitch-foixes
167 2017-09-15T04:41:24  <jonasschnelli> *fixes
168 2017-09-15T04:41:58  <achow101> jonasschnelli: it shouldn't be a problem if we use the Qt sanctioned method, no?
169 2017-09-15T04:42:23  <jonasschnelli> achow101: you mean http://doc.qt.io/qt-5/qwidget.html#restoreGeometry?
170 2017-09-15T04:42:35  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11335: [WIP] Replace save|restoreWindowGeometry with Qt functions (master...201709_fix_offscreen_2) https://github.com/bitcoin/bitcoin/pull/11335
171 2017-09-15T04:42:41  <achow101> yes
172 2017-09-15T04:42:57  <jonasschnelli> I'm not sure if this would fix it... haven't tested it. Haven't checked the upstream by-platform code for restoreGeometry
173 2017-09-15T04:43:05  <jonasschnelli> But we should def. use it
174 2017-09-15T04:43:19  *** GypsyScotty has quit IRC
175 2017-09-15T04:43:20  <jonasschnelli> Rather then implementing it in our layer
176 2017-09-15T04:43:34  <meshcollider> Agreed
177 2017-09-15T04:43:51  <luke-jr> https://gist.github.com/5c7afe24d6d4cb512c9d0940c91d5ac4
178 2017-09-15T04:43:53  <achow101> well then lets try and see what it does
179 2017-09-15T04:44:03  <jonasschnelli> meshcollider: Oh. Great, ... you already PRed #11335
180 2017-09-15T04:44:04  <gribble> https://github.com/bitcoin/bitcoin/issues/11335 | [WIP] Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
181 2017-09-15T04:44:06  <jonasschnelli> I'll go a gitian build
182 2017-09-15T04:44:19  <jonasschnelli> *do
183 2017-09-15T04:45:01  <meshcollider> Oh that looks a lot better if it also checks for maximised and minimised right?
184 2017-09-15T04:45:14  <meshcollider> luke-jr: is that from Qt 4
185 2017-09-15T04:45:21  <gmaxwell> this code looks like it'll handle it.
186 2017-09-15T04:45:21  <meshcollider> or 5
187 2017-09-15T04:45:41  <luke-jr> meshcollider: 5.7
188 2017-09-15T04:46:03  <gmaxwell> might want to take a quick look at 4.x just to see if it still looks sufficient there.
189 2017-09-15T04:46:18  <luke-jr> so long as the current version works, IMO it's not our problem if older ones are broken
190 2017-09-15T04:46:48  <achow101> luke-jr: well qt4 is still used and supported, so we want to make sure that works too
191 2017-09-15T04:46:50  <luke-jr> (so long as we're outsourcing to Qt)
192 2017-09-15T04:46:59  <gmaxwell> luke-jr: meh, if we build with it, it should work. at least against serious issues (and I think the program being totally inoperable is serious)
193 2017-09-15T04:47:06  <meshcollider> speaking of Qt issues, does 5.9 fix any of the segfault crashes like #9683? (cf 10505)
194 2017-09-15T04:47:08  <gribble> https://github.com/bitcoin/bitcoin/issues/9683 | random abort running master/HEAD · Issue #9683 · bitcoin/bitcoin · GitHub
195 2017-09-15T04:47:11  <jonasschnelli> https://bitcoin.jonasschnelli.ch/build/305
196 2017-09-15T04:47:22  <luke-jr> gmaxwell: disable restoring position on Qt4? :p
197 2017-09-15T04:47:56  <achow101> luke-jr: qt4 has the same functions, we should check their behavior
198 2017-09-15T04:47:58  <gmaxwell> luke-jr: maybe you could argue that it was sufficient if the latest QT4 had it, in any case I expect it does have similar code.  This stuff seems like GUI101.
199 2017-09-15T04:48:00  <meshcollider> I'd imagine 4 would still have decent restoring function anyway lol
200 2017-09-15T04:48:01  <luke-jr> achow101: sure
201 2017-09-15T04:48:14  <jonasschnelli> Qt4 support doesn't need to support everything: https://github.com/bitcoin/bitcoin/blob/f65614726de21e116966366d6abdf025dfeb6db2/doc/build-osx.md#L27
202 2017-09-15T04:48:22  <luke-jr> gmaxwell: the Qt5 code there suggests it changed around 5.3
203 2017-09-15T04:48:23  <gmaxwell> thou shall not restore the window to a location which is completely inaccessible to the user.
204 2017-09-15T04:49:43  <jonasschnelli> Can we just get rid of Qt4 support? Qt 4.8 seems unmaintaned since a couple of years... very bad for a cross-platform layer
205 2017-09-15T04:51:10  <luke-jr> no objection from me anymore
206 2017-09-15T04:51:12  <luke-jr> fwiw
207 2017-09-15T04:51:15  <gmaxwell> I dont even understand why this is coming up here.
208 2017-09-15T04:51:30  <gmaxwell> Roughly the same code is in QT4. so it should be fine too.
209 2017-09-15T04:52:57  <jonasschnelli> Unrelated to the offscreen bug, yes.
210 2017-09-15T04:53:26  <jonasschnelli> Switching to Qt5 would allow to remove legacy code and use Qt5 features like lambdas, etc.
211 2017-09-15T04:53:29  <jonasschnelli> Simpler signal bindings
212 2017-09-15T04:53:45  <gmaxwell> Well, on all my machines Qt4 is the only version installed I think. I think it's still the default even in debian testing (though QT5 is available there).
213 2017-09-15T04:57:33  <luke-jr> oh :/
214 2017-09-15T04:57:49  <luke-jr> Now that you mention it, I do recall seeing Qt4 on Devuan
215 2017-09-15T04:59:04  <gmaxwell> I'm no expert and perhaps a fresh install would change some default.  And maybe we could just address by providing more install instructions.
216 2017-09-15T04:59:31  <achow101> gmaxwell: perhaps you need a new laptop :p
217 2017-09-15T05:03:10  <gmaxwell> your inside jokes might confuse people. :P  fwiw, on an up to date debian testing system, which was QT4 only, you can parallel install QT5, but it seems bitcoin-qt still builds using QT4 even with QT5 'installed'.
218 2017-09-15T05:10:13  *** Murch has joined #bitcoin-core-dev
219 2017-09-15T05:18:46  *** Lauda has quit IRC
220 2017-09-15T05:18:59  *** pbase has joined #bitcoin-core-dev
221 2017-09-15T05:18:59  *** Lauda has joined #bitcoin-core-dev
222 2017-09-15T05:23:26  *** tErik_mc has joined #bitcoin-core-dev
223 2017-09-15T05:29:05  *** RubenSomsen has quit IRC
224 2017-09-15T05:34:08  *** Ylbam has joined #bitcoin-core-dev
225 2017-09-15T05:49:19  <meshcollider> hmmm it seems that its working, but if you move it right to the very very edge of the screen you literally cant see it, you can grab it again with the mouse but theres no way you'd be able to find it again lol
226 2017-09-15T05:49:34  <meshcollider> that'd be a rare case though I'd imaging
227 2017-09-15T05:49:42  <meshcollider> s/imaging/imagine/
228 2017-09-15T05:52:37  <achow101> meshcollider: that's exactly the case that gmaxwell and I were testing earlier
229 2017-09-15T05:53:25  <achow101> and that case is kind of the worst case scenario, not off screen, but not on screen enough to be usable
230 2017-09-15T05:56:40  *** chriswakare has joined #bitcoin-core-dev
231 2017-09-15T05:59:18  *** Murch has quit IRC
232 2017-09-15T06:06:55  *** Guest65485 is now known as ndrst
233 2017-09-15T06:07:01  *** ndrst has joined #bitcoin-core-dev
234 2017-09-15T06:07:52  *** chriswakare has left #bitcoin-core-dev
235 2017-09-15T06:10:19  <meshcollider> mhm but if we rely on Qt restore and save, its not really fixable by us. I'd say its a non-issue if its exactly how other OS programs behave like notepad?
236 2017-09-15T06:10:57  <meshcollider> As long as its possible to get it back on screen with just the mouse, which it is, as long as you can find it lol
237 2017-09-15T06:21:32  *** Dummbatz has joined #bitcoin-core-dev
238 2017-09-15T06:21:46  <gmaxwell> bleh, I suppose. why do other things find that behavior tolerable.
239 2017-09-15T06:22:29  <sipa> there is some key shortcut to move a window
240 2017-09-15T06:23:01  <cfields_> ctrl+space gives you the min/max/move context-menu
241 2017-09-15T06:23:19  <cfields_> er, alt+space
242 2017-09-15T06:23:32  <meshcollider> yeah or you can shift+rightclick on the icon in the taskbar
243 2017-09-15T06:23:48  * cfields_ just can't seem to leave his windows days behind him
244 2017-09-15T06:24:40  <cfields_> and fwiw, i only know that because programs would end up out-of-view now and then
245 2017-09-15T06:27:36  <gmaxwell> things really can get out of view and then save and restore it across restarts... how the heck have they not fixed that.
246 2017-09-15T06:31:03  <meshcollider> huh I figured out an even easier way to get it back on screen, windows key + arrow
247 2017-09-15T06:31:05  <cfields_> gmaxwell: well i haven't messed with it since xp, I assume they've made some progress :)
248 2017-09-15T06:33:46  <midnightmagic> meh. it's qt. they only fix stuff for corps that have an upper-tier support contract.
249 2017-09-15T06:34:31  <cfields_> midnightmagic: regardless of qt, the window manager is ultimately in charge of positioning
250 2017-09-15T06:34:41  <cfields_> which i assume was gmaxwell's point
251 2017-09-15T06:37:08  <meshcollider> ^ use a tiling window manager and all your problems disappear ;)
252 2017-09-15T06:43:03  *** promag has joined #bitcoin-core-dev
253 2017-09-15T06:45:34  <midnightmagic> cfields_: no, memory of a window position is not something dwm does, and I use dwm-- "we" had issues with qt windows doing stupid things, fixing it was a pointless chore.
254 2017-09-15T06:46:56  <midnightmagic> xterm positioning for a new window is similar-- you pass in X geometry, and/or dwm guesses a top-left position for it, that's pretty much it
255 2017-09-15T06:47:25  *** promag has quit IRC
256 2017-09-15T06:49:19  <midnightmagic> eh, I might be misremembering. we had a lot of qt problems. a lot. lotta lot..
257 2017-09-15T06:56:00  *** DrOlmer has quit IRC
258 2017-09-15T06:56:59  *** DrOlmer has joined #bitcoin-core-dev
259 2017-09-15T07:09:51  *** pbase has quit IRC
260 2017-09-15T07:15:37  *** pbase has joined #bitcoin-core-dev
261 2017-09-15T07:44:00  *** harrymm has joined #bitcoin-core-dev
262 2017-09-15T07:47:46  *** timothy has joined #bitcoin-core-dev
263 2017-09-15T07:48:28  *** drizztbsd has joined #bitcoin-core-dev
264 2017-09-15T07:49:48  *** laurentmt has joined #bitcoin-core-dev
265 2017-09-15T07:50:04  *** laurentmt has quit IRC
266 2017-09-15T07:52:23  *** laurentmt has joined #bitcoin-core-dev
267 2017-09-15T07:52:58  *** timothy has quit IRC
268 2017-09-15T07:53:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f399a9ff227...ae233c4ec3d1
269 2017-09-15T07:53:04  <bitcoin-git> bitcoin/master dc2f737 danra: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY
270 2017-09-15T07:53:05  <bitcoin-git> bitcoin/master ae233c4 MarcoFalke: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY...
271 2017-09-15T07:53:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY (master...patch-10) https://github.com/bitcoin/bitcoin/pull/11330
272 2017-09-15T07:53:54  *** AaronvanW has quit IRC
273 2017-09-15T07:55:54  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae233c4ec3d1...09627b1dd41d
274 2017-09-15T07:55:54  <bitcoin-git> bitcoin/master cdaf3a1 Matt Corallo: Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected...
275 2017-09-15T07:55:55  <bitcoin-git> bitcoin/master 09627b1 Wladimir J. van der Laan: Merge #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt)...
276 2017-09-15T07:56:35  <bitcoin-git> [bitcoin] laanwj closed pull request #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) (master...2017/09/qsettings_1) https://github.com/bitcoin/bitcoin/pull/11332
277 2017-09-15T07:57:39  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/46c8d23dad216d990564014f4c8000b79fd36f4e
278 2017-09-15T07:57:39  <bitcoin-git> bitcoin/0.15 46c8d23 Matt Corallo: Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected...
279 2017-09-15T07:58:58  *** AaronvanW has joined #bitcoin-core-dev
280 2017-09-15T08:15:59  *** timothy has joined #bitcoin-core-dev
281 2017-09-15T08:16:25  *** drizztbsd has quit IRC
282 2017-09-15T08:18:16  <bitcoin-git> [bitcoin] danra opened pull request #11337: Fix code constness in CBlockIndex::GetAncestor() overloads (master...fix/const-get-ancestor) https://github.com/bitcoin/bitcoin/pull/11337
283 2017-09-15T08:44:39  <bitcoin-git> [bitcoin] laanwj closed pull request #11208: Fixing offscreen GUI issue (master...201709_offscreen_fix) https://github.com/bitcoin/bitcoin/pull/11208
284 2017-09-15T08:52:17  <wumpus> meshcollider: "mhm but if we rely on Qt restore and save, its not really fixable by us" <- well, as we never managed t oget it right in years of trying, please don't be angry at me for thinking maybe the qt devs know more about handling this and can do this better? :)
285 2017-09-15T08:52:49  <meshcollider> wumpus: yeah im not saying we should do it, I'm just saying its their problem now :)
286 2017-09-15T08:52:59  <wumpus> we can try this, give it one try, if it's flaky as well, I'd say we remove the functionality
287 2017-09-15T08:53:16  <meshcollider> their restore and save function have a lot more benefits than ours anyway, like the maximisation issue I mentioned in my PR
288 2017-09-15T08:53:22  <wumpus> it's not worth spending too much cycles on
289 2017-09-15T08:53:54  <wumpus> but I'd bet quite a lot that their function received significantly more testing than us
290 2017-09-15T08:53:59  <wumpus> ours*
291 2017-09-15T08:55:45  <wumpus> I don't understand why this triggers yet another qt 4 discussion though, the function has existed for about forever
292 2017-09-15T08:55:50  <wumpus> or is there some subtlety there?
293 2017-09-15T08:56:04  *** promag has joined #bitcoin-core-dev
294 2017-09-15T09:00:14  <promag> what does the "n" prefix means in nRPCConsoleWindow ?
295 2017-09-15T09:01:46  *** Ylbam has quit IRC
296 2017-09-15T09:01:49  *** rjak has joined #bitcoin-core-dev
297 2017-09-15T09:08:21  <wumpus> "number" I guess
298 2017-09-15T09:09:26  <wumpus> all of the qt settings have weird names, AFAIK it's based on satoshi's naming scheme for settings when they were still in the wallet
299 2017-09-15T09:10:10  <wumpus> anyhow it doesn't really matter what the names are, as long as the names are unique within bitcoin-qt
300 2017-09-15T09:10:53  <wumpus> for new settings I'd say use a plainer scheme
301 2017-09-15T09:11:09  <meshcollider> its a perfect time to change the nRPCConsoleWindow  and nWindow ones if you want to because theyre both new to this PR
302 2017-09-15T09:11:21  <meshcollider> nRPCConsoleWindowGeometry and nWindowGeometry
303 2017-09-15T09:11:27  <wumpus> but I don't care, no one is supposed to see them
304 2017-09-15T09:11:44  <wumpus> right
305 2017-09-15T09:12:33  <promag> yeah, I would rename since they hold a different value/type
306 2017-09-15T09:13:04  <promag> the suffix "Geometry" sounds enough
307 2017-09-15T09:14:04  <wumpus> yes, it's enough
308 2017-09-15T09:14:20  <meshcollider> so just get rid of the 'n' at the front?
309 2017-09-15T09:14:25  <meshcollider> RPCConsoleWindowGeometry and WindowGeometry ?
310 2017-09-15T09:14:30  <wumpus> sounds good to me
311 2017-09-15T09:14:44  <wumpus> maybe MainWindowGeometry
312 2017-09-15T09:15:43  <promag> was going to say the same
313 2017-09-15T09:16:58  <meshcollider> sweet done 👍
314 2017-09-15T09:19:48  <promag> so the old settings will stay?
315 2017-09-15T09:20:46  <meshcollider> the old settings weren't called Geometry anyway, they saved position and size seperately in nWindowPos and nWindowSize
316 2017-09-15T09:21:36  <meshcollider> But yeah those Pos and Size will stay in there unused
317 2017-09-15T09:22:51  <wumpus> adding upgrade handling code just to remove them sounds like overkill
318 2017-09-15T09:35:07  <promag> and for some reason the user can keep 2 versions installed
319 2017-09-15T09:36:10  *** promag has quit IRC
320 2017-09-15T09:37:58  *** promag has joined #bitcoin-core-dev
321 2017-09-15T09:38:13  *** promag has joined #bitcoin-core-dev
322 2017-09-15T09:43:12  <wumpus> right, or some sinister altcoin that uses the same settings directory :-)
323 2017-09-15T09:43:31  *** goatpig has joined #bitcoin-core-dev
324 2017-09-15T09:43:36  *** Dummbatz has left #bitcoin-core-dev
325 2017-09-15T09:45:31  *** promag has joined #bitcoin-core-dev
326 2017-09-15T09:47:44  *** promag has quit IRC
327 2017-09-15T09:49:48  *** ula has joined #bitcoin-core-dev
328 2017-09-15T09:57:31  <bitcoin-git> [bitcoin] laanwj opened pull request #11338: qt: Backup former GUI settings on `-resetguisettings` (master...2017_10_backup_resetguisettings) https://github.com/bitcoin/bitcoin/pull/11338
329 2017-09-15T10:11:11  <meshcollider> Are there any other goals for 0.15.1 other than the segwit wallet support sipa is working on?
330 2017-09-15T10:15:53  <bitcoin-git> [bitcoin] danra opened pull request #11339: Minor improvements to checkpoints code (master...refactor/checkpoints) https://github.com/bitcoin/bitcoin/pull/11339
331 2017-09-15T10:16:09  *** supay has joined #bitcoin-core-dev
332 2017-09-15T10:16:28  <supay> i was wondering if it would be possible to create a contact system where individuals grant access to another individuals contact information on top of the blockchain
333 2017-09-15T10:16:38  <supay> i believe a peer-to-peer ledger recording the level of access granted or revoked could enable an open social graph
334 2017-09-15T10:16:53  <supay> once there is a clean method to grant and update contact information across users, there is also now a social graph with information tiering, allowing a user-controlled and defined connection level between individuals.
335 2017-09-15T10:17:04  <meshcollider> supay: wrong channel, try #bitcoin
336 2017-09-15T10:17:58  <supay> meshcollider: tried :(
337 2017-09-15T10:18:25  *** SopaXorzTaker has joined #bitcoin-core-dev
338 2017-09-15T10:20:30  <venzen> supay: Namecoin provides namespaces for ID information
339 2017-09-15T10:21:56  <supay> venzen: but no open social graph!
340 2017-09-15T10:22:14  <supay> on #bitcoin ali1234 mentioned that there are still analog holes
341 2017-09-15T10:22:30  <meshcollider> supay venzen: this channel is only for discussion of bitcoin core, please take this discussion to another channel
342 2017-09-15T10:22:32  <supay> but i see this as a powerful p2p contact exchange and/or social graph
343 2017-09-15T10:22:38  <venzen> supay: we shouldn't really discuss that here, it's off-topic for this dev channel
344 2017-09-15T10:22:56  <supay> venzen: can i pm?
345 2017-09-15T10:23:14  <venzen> sure
346 2017-09-15T10:34:50  *** RubenSomsen has joined #bitcoin-core-dev
347 2017-09-15T10:36:25  <wumpus> meshcollider: no other features at least, bugfixes are always good of course
348 2017-09-15T10:44:19  <bitcoin-git> [bitcoin] danra opened pull request #11340: Trivial: Fix validation.cpp comment, BIP113 already deployed (master...patch-12) https://github.com/bitcoin/bitcoin/pull/11340
349 2017-09-15T11:15:29  <bitcoin-git> [bitcoin] danra closed pull request #11331: Trivial: Update outdated comment in validation.h (master...patch-11) https://github.com/bitcoin/bitcoin/pull/11331
350 2017-09-15T11:15:39  <bitcoin-git> [bitcoin] danra closed pull request #11328: Move comment about transaction/block weight calculation (master...fix/weight-comment) https://github.com/bitcoin/bitcoin/pull/11328
351 2017-09-15T11:27:16  <aj> wumpus: hey, now 0.15 is out, should i ping back about #10996 (network.conf) ? we were worrying about qt/bitcoind initialisation diverging and generally making that stuff harder to understand, and potentially tests and such
352 2017-09-15T11:27:18  <gribble> https://github.com/bitcoin/bitcoin/issues/10996 | [WIP] Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
353 2017-09-15T11:48:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
354 2017-09-15T12:16:30  <wumpus> aj: yes, agreed
355 2017-09-15T12:17:07  *** dabura667_ has quit IRC
356 2017-09-15T12:20:44  <wumpus> so, do a 0.15.0.1 with just #11332 or merge #11335 and maybe #11338 as well?
357 2017-09-15T12:20:46  <gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
358 2017-09-15T12:20:47  <gribble> https://github.com/bitcoin/bitcoin/issues/11335 | Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
359 2017-09-15T12:20:49  <gribble> https://github.com/bitcoin/bitcoin/issues/11338 | qt: Backup former GUI settings on `-resetguisettings` by laanwj · Pull Request #11338 · bitcoin/bitcoin · GitHub
360 2017-09-15T12:21:21  *** Chris_Stewart_5 has quit IRC
361 2017-09-15T12:21:40  <wumpus> all are necessary qt gui changes, though only the former is a crash issue
362 2017-09-15T12:24:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
363 2017-09-15T12:29:38  *** pit has joined #bitcoin-core-dev
364 2017-09-15T12:34:52  *** pit has quit IRC
365 2017-09-15T12:44:35  *** belcher has joined #bitcoin-core-dev
366 2017-09-15T12:53:33  <MarcoFalke> What is the deadline for 0.15.0.1?
367 2017-09-15T12:53:53  <MarcoFalke> I might prepare some qa backports, so that people won't run into the intermittent errors we saw on travis
368 2017-09-15T12:54:24  *** jtimon has joined #bitcoin-core-dev
369 2017-09-15T12:54:33  <wumpus> I don't know - would be nice to have something as soon as possible to recommend to people experiencing crashes, though
370 2017-09-15T12:54:34  *** promag has joined #bitcoin-core-dev
371 2017-09-15T12:54:52  <wumpus> that's the motivation for it
372 2017-09-15T12:55:34  <MarcoFalke> hmm, in which case it should be tagged today. To give some time for builders
373 2017-09-15T12:56:55  <wumpus> if we only include 11338 do we even need a RC phase?
374 2017-09-15T12:57:24  <wumpus> I guess it would be better to do one anyway, a very short one
375 2017-09-15T12:58:16  <wumpus> ok, will do the version bump, update translations and tag rc1
376 2017-09-15T13:00:21  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11341: [0.15.0] Bump manpages (0.15...Mf1709-docMan15) https://github.com/bitcoin/bitcoin/pull/11341
377 2017-09-15T13:00:43  <MarcoFalke> wumpus: Someone complained about the manpages ^
378 2017-09-15T13:02:02  <wumpus> ah yes, was just about to do that
379 2017-09-15T13:02:18  <wumpus> but need after the 0.15.0.1 bump
380 2017-09-15T13:05:13  <MarcoFalke> Maybe we don't need an rc phase for this 1 LOC change...
381 2017-09-15T13:05:40  <wumpus> yes, maybe not
382 2017-09-15T13:05:56  <MarcoFalke> If it is broken (despite testing) don't push the binaries.
383 2017-09-15T13:06:23  <wumpus> and make a 0.15.0.2? :)
384 2017-09-15T13:07:47  <MarcoFalke> ja :)
385 2017-09-15T13:09:15  <promag> wumpus: do you think the backup filename should have the datetime?
386 2017-09-15T13:11:05  <promag> also, if the file already exists it is appended, not really a backup imo
387 2017-09-15T13:11:37  <wumpus> no need for a datetime, it's a one-time thing
388 2017-09-15T13:11:38  <promag> *appended as in the settings are added or updated
389 2017-09-15T13:11:43  *** pbase has quit IRC
390 2017-09-15T13:11:44  <wumpus> oh, good point, it should be cleared first
391 2017-09-15T13:12:04  <promag> thats why I thought about the timestamp
392 2017-09-15T13:12:54  <wumpus> I'll just add a dst.clear()
393 2017-09-15T13:14:32  <wumpus> I prefer a fixed name as I don't want people to end up with zillions of files in their datadir
394 2017-09-15T13:16:06  <promag> allright
395 2017-09-15T13:16:36  <promag> nit: backupSettings(filename, src) swap: backupSettings(const QSettings &src, const fs::path &filename)? :P
396 2017-09-15T13:16:45  <wumpus> why?
397 2017-09-15T13:17:17  *** dermoth has joined #bitcoin-core-dev
398 2017-09-15T13:17:19  <promag> ah I see you prefer dst, src
399 2017-09-15T13:17:22  <wumpus> yes
400 2017-09-15T13:17:34  <promag> why? :P
401 2017-09-15T13:18:00  <wumpus> don't feel like arguing this
402 2017-09-15T13:19:11  <wumpus> both options are equally valid and it really doesn't matter here, it's an internal function not an official API
403 2017-09-15T13:19:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11339: Minor improvements to checkpoints code (master...refactor/checkpoints) https://github.com/bitcoin/bitcoin/pull/11339
404 2017-09-15T13:22:09  <warren> Does bitcoin-cli have any tool that will tell you the feerate of a rawtx?
405 2017-09-15T13:22:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/46c8d23dad21...7123b95bea5b
406 2017-09-15T13:22:30  <bitcoin-git> bitcoin/0.15 8432332 Wladimir J. van der Laan: build: Bump version to 0.15.0.1...
407 2017-09-15T13:22:31  <bitcoin-git> bitcoin/0.15 7123b95 Wladimir J. van der Laan: doc: Bump manpages to 0.15.0.1...
408 2017-09-15T13:24:21  <wumpus> warren: no, as that information is not in a raw transaction, it'd need the parent transactions (which aren't available without txindex)
409 2017-09-15T13:25:19  <promag> unless the transaction is in your wallet
410 2017-09-15T13:28:01  <promag> wumpus: in #11338 `T &x` should be `T& x`
411 2017-09-15T13:28:03  <gribble> https://github.com/bitcoin/bitcoin/issues/11338 | qt: Backup former GUI settings on `-resetguisettings` by laanwj · Pull Request #11338 · bitcoin/bitcoin · GitHub
412 2017-09-15T13:28:20  <wumpus> sure, but in that case you don't need a call that works on raw transactions, but would just use the wallet api...
413 2017-09-15T13:29:01  <wumpus> promag: can you please do minor nits the issue instead of IRC, otherwise I'm bound to forget about them
414 2017-09-15T13:30:21  <bitcoin-git> [bitcoin] laanwj closed pull request #11341: [0.15.0] Bump manpages (0.15...Mf1709-docMan15) https://github.com/bitcoin/bitcoin/pull/11341
415 2017-09-15T13:37:40  <promag> wumpus: sure, done
416 2017-09-15T13:37:52  <wumpus> thanks
417 2017-09-15T13:40:48  *** justan0theruser has quit IRC
418 2017-09-15T13:42:17  *** supay has quit IRC
419 2017-09-15T13:43:03  *** BashCo_ has quit IRC
420 2017-09-15T13:49:13  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/f266f2668bf8fd73015bf8265f0d00f5e858b577
421 2017-09-15T13:49:14  <bitcoin-git> bitcoin/0.15 f266f26 Wladimir J. van der Laan: qt: Translations update pre-0.15.0.1...
422 2017-09-15T13:51:04  *** Guyver2 has joined #bitcoin-core-dev
423 2017-09-15T13:55:08  <achow101> so is 0.15.0.1 just #11332?
424 2017-09-15T13:55:10  <gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
425 2017-09-15T13:55:46  <wumpus> yes
426 2017-09-15T13:57:44  <promag> Why #11332 removes nCustomFeeRadio usage? achow101
427 2017-09-15T13:57:49  <gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
428 2017-09-15T13:57:54  <achow101> promag: no need for it
429 2017-09-15T13:58:18  <wumpus> promag: see https://github.com/bitcoin/bitcoin/pull/11334
430 2017-09-15T13:58:19  <promag> no need for the checkbox?
431 2017-09-15T13:58:20  <achow101> it was only to store which of the custom fee radio buttons were selected, but now there is only one option, so no need for it
432 2017-09-15T13:59:17  *** BashCo has joined #bitcoin-core-dev
433 2017-09-15T13:59:19  <achow101> the checkbox is unrelated to that
434 2017-09-15T14:00:03  <promag> ops, meant radio button
435 2017-09-15T14:01:41  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/fb7b5293844ea6adc5dcf5ad0a0c5890b4495939
436 2017-09-15T14:01:41  <bitcoin-git> bitcoin/0.15 fb7b529 Wladimir J. van der Laan: doc: Release notes for 0.15.0.1...
437 2017-09-15T14:02:19  <promag> achow101: remove ui->labelCustomPerKilobyte->setEnable?
438 2017-09-15T14:02:53  <promag> IIRC setEnabled on labels does nothing
439 2017-09-15T14:02:55  <achow101> promag: no, that's required to make that row grayed out if checkBoxMinimumFee is checked
440 2017-09-15T14:02:58  <achow101> I think
441 2017-09-15T14:06:40  *** BashCo has quit IRC
442 2017-09-15T14:07:19  <wumpus> yes the proper fix needs more review, which is why we went with the minimal fix that avoids the crash in 0.15.0.1
443 2017-09-15T14:07:51  <wumpus>  * [new tag]         v0.15.0.1 -> v0.15.0.1
444 2017-09-15T14:15:34  *** DrOlmer has quit IRC
445 2017-09-15T14:15:44  *** BashCo has joined #bitcoin-core-dev
446 2017-09-15T14:18:00  *** pbase has joined #bitcoin-core-dev
447 2017-09-15T14:22:57  *** BashCo has quit IRC
448 2017-09-15T14:23:46  <promag> wumpus: do you think Copy/BackupSettings should be in src/qt/guiutil.cpp since they are "general function"
449 2017-09-15T14:24:02  <wumpus> not as long as they're only used in one place IMO
450 2017-09-15T14:24:24  <wumpus> guiutil is a grab-bag for common shared stuff
451 2017-09-15T14:24:28  *** BashCo has joined #bitcoin-core-dev
452 2017-09-15T14:24:45  <wumpus> if something is used in only one compilation unit, better to have it static and local
453 2017-09-15T14:24:57  <wumpus> can always be moved later
454 2017-09-15T14:25:04  <wumpus> let's not try to overdesign this anyhow
455 2017-09-15T14:25:52  <wumpus> another case of both choices being valid, it doesn't really matter
456 2017-09-15T14:27:10  *** Murch has joined #bitcoin-core-dev
457 2017-09-15T14:31:47  <meshcollider> sipa: why didn't you choose a 2 character HRP for bech32 regtest addresses if testnet and mainnet are both 2 characters? 'rb' or something?
458 2017-09-15T14:36:19  <wumpus> probably because he didn't want to 'burn' a 2 character code on regtest, which is only meant for local testing
459 2017-09-15T14:37:00  <wumpus> unlike testnet3 and mainnet it's not an 'official' network
460 2017-09-15T14:47:21  *** promag has quit IRC
461 2017-09-15T14:48:00  *** promag has joined #bitcoin-core-dev
462 2017-09-15T14:48:01  *** Chris_Stewart_5 has quit IRC
463 2017-09-15T14:53:55  *** zxzzt has quit IRC
464 2017-09-15T14:53:55  *** sdaftuar has quit IRC
465 2017-09-15T14:54:07  *** jnewbery has quit IRC
466 2017-09-15T14:54:48  *** zxzzt has joined #bitcoin-core-dev
467 2017-09-15T14:55:30  *** jnewbery has joined #bitcoin-core-dev
468 2017-09-15T14:55:31  *** sdaftuar has joined #bitcoin-core-dev
469 2017-09-15T14:55:31  *** sdaftuar has joined #bitcoin-core-dev
470 2017-09-15T15:00:44  <morcos> achow101: while you're playing around in the QT code, i think we want to eliminate the checkbox for "Pay only the required fee ..."
471 2017-09-15T15:00:59  <morcos> maybe separate PR in case we want to back port 11334
472 2017-09-15T15:01:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
473 2017-09-15T15:02:21  <achow101> why?
474 2017-09-15T15:03:12  *** AaronvanW has quit IRC
475 2017-09-15T15:06:34  <morcos> sorry, why what?
476 2017-09-15T15:09:36  *** AaronvanW has joined #bitcoin-core-dev
477 2017-09-15T15:10:15  *** promag has quit IRC
478 2017-09-15T15:12:20  <achow101> morcos: why remove that checkbox? It just means that you will be paying the minrelayfee
479 2017-09-15T15:12:31  <achow101> (although the wording on it probably needs to be changed)
480 2017-09-15T15:13:16  <morcos> achow101: because you can just select the minrelayfee in the custom box if you want to pay that
481 2017-09-15T15:13:36  <morcos> it doesn't seem like selecting it as a stand alone option really sends the right message
482 2017-09-15T15:13:42  <achow101> morcos: the user may not know what the minrelayfee is
483 2017-09-15T15:14:15  <achow101> also, doesn't it change if the mempool is full?
484 2017-09-15T15:14:23  <morcos> that number does not change
485 2017-09-15T15:14:32  <morcos> but regardless of getting rid of that checkbox
486 2017-09-15T15:14:59  <morcos> i am realizing that it's a bit annoying that you don't know what the minimum is you need to put on your transaction if you are selecting current fee
487 2017-09-15T15:15:14  <morcos> perhaps we want to output a : minimum to currently be accepted in the mempool fee
488 2017-09-15T15:15:29  <morcos> but i would suggest people be forced to type that into the box
489 2017-09-15T15:15:45  <morcos> making it too easy to select that implies it could could be a good idea
490 2017-09-15T15:15:52  <morcos> unless you're seeing that returned in fee estimation
491 2017-09-15T15:15:56  <morcos> it's proably not a good idea
492 2017-09-15T15:16:48  <achow101> we could change it to update the custom fee box with the fee rate that it would be using
493 2017-09-15T15:17:34  <morcos> not sure i follow
494 2017-09-15T15:17:44  <morcos> it uses the fee rate you give it
495 2017-09-15T15:17:59  <morcos> if you're using custom fee (as opposed to recommended)
496 2017-09-15T15:18:07  <morcos> even if such fee would not get you accepted to the mempool
497 2017-09-15T15:19:07  <achow101> I meant that if you check the box to use minrelayfee, it can display the fee rate that it is using in the custom fee rate box right above it
498 2017-09-15T15:19:44  <morcos> i just don't think we should give users an option to use the minimum
499 2017-09-15T15:20:28  <morcos> it has very limited benefit... the options should be..  recommended (for a given target) or you specify
500 2017-09-15T15:20:42  <morcos> we discussed in SF, and i thought there was other agreement with this idea
501 2017-09-15T15:22:01  <bitcoin-git> [bitcoin] danra opened pull request #11342: Add sanity assert in CheckSequenceLocks (master...patch-13) https://github.com/bitcoin/bitcoin/pull/11342
502 2017-09-15T15:22:08  <achow101> I'm afraid that if someone wants to use the minimum that they will accidentally enter 1 sat/kB (not 1000 sat/kB) in the box if they don't have the option to use the minimum
503 2017-09-15T15:22:25  <morcos> well, in that case it'll be changed to 1000 for them
504 2017-09-15T15:22:28  <achow101> although I suppose that can be fixed by lower bounding the box to the minrelayfee
505 2017-09-15T15:22:55  *** Dizzle has joined #bitcoin-core-dev
506 2017-09-15T15:23:44  <morcos> it already lower bounds.. but it doesn't really tell you it's going to
507 2017-09-15T15:24:27  <morcos> in any case, i suppose there are a lot of options for how to improve this area...  so maybe its not critical right now
508 2017-09-15T15:28:02  <gmaxwell> you could also put 0 in the custom box and get clamped to min relay fee. no
509 2017-09-15T15:28:50  <gmaxwell> oh nevermind
510 2017-09-15T15:29:20  <luke-jr> another reason I thought of, that people might want to keep it: this way you can check the min fee checkbox, while retaining the current saved value for the manual fee
511 2017-09-15T15:29:39  <luke-jr> but that use case might be better served by allowing users to define pre-set values
512 2017-09-15T15:30:23  <morcos> gmaxwell: yes that does work
513 2017-09-15T15:31:41  <gmaxwell> the nevermind was because on the line before mine you pointe dthat out. :)
514 2017-09-15T15:32:00  <morcos> i'm not sure of the QT mojo to do this easily, but seems like the best outcome might be to replace the checkbox with a display of what the mempool min fee is, and have a way to click that and have it populated into the custom box
515 2017-09-15T15:32:51  <morcos> then we're missing informing people of what the min relay fee is in case they actually wanted to do a tx that wouldn't yet be accepted into the mempool, but that seems pretty advanced, and maybe people will know that if they want to do it
516 2017-09-15T15:33:35  <morcos> submitting these super low fee txs does have the use case for manually managed rbf bumping
517 2017-09-15T15:37:52  *** jtimon has quit IRC
518 2017-09-15T15:39:07  *** PaulCapestany has quit IRC
519 2017-09-15T15:41:55  *** PaulCapestany has joined #bitcoin-core-dev
520 2017-09-15T15:51:32  *** Chris_Stewart_5 has quit IRC
521 2017-09-15T15:55:31  *** fengling has quit IRC
522 2017-09-15T15:55:37  *** promag has joined #bitcoin-core-dev
523 2017-09-15T15:55:39  *** fengling_ has joined #bitcoin-core-dev
524 2017-09-15T15:58:24  *** riemann has joined #bitcoin-core-dev
525 2017-09-15T16:04:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
526 2017-09-15T16:12:50  *** promag has quit IRC
527 2017-09-15T16:18:06  *** JackH has quit IRC
528 2017-09-15T16:37:22  *** meshcollider has quit IRC
529 2017-09-15T16:44:00  <bitcoin-git> [bitcoin] isghe opened pull request #11343: added `-walletallowsymboliclink` (default false) (0.15...wallet-allow-symbolic-link) https://github.com/bitcoin/bitcoin/pull/11343
530 2017-09-15T16:48:32  *** riemann has quit IRC
531 2017-09-15T17:05:46  *** timothy has quit IRC
532 2017-09-15T17:07:39  *** Lauda has quit IRC
533 2017-09-15T17:07:53  *** Lauda has joined #bitcoin-core-dev
534 2017-09-15T17:10:15  *** Aaronvan_ has joined #bitcoin-core-dev
535 2017-09-15T17:12:16  *** Ylbam has joined #bitcoin-core-dev
536 2017-09-15T17:12:58  *** AaronvanW has quit IRC
537 2017-09-15T17:13:27  *** promag has joined #bitcoin-core-dev
538 2017-09-15T17:14:26  *** abpa has joined #bitcoin-core-dev
539 2017-09-15T17:14:30  *** atroxes has quit IRC
540 2017-09-15T17:15:47  *** atroxes has joined #bitcoin-core-dev
541 2017-09-15T17:17:41  *** promag has quit IRC
542 2017-09-15T17:18:39  *** pergaminho has joined #bitcoin-core-dev
543 2017-09-15T17:21:30  *** Chris_Stewart_5 has quit IRC
544 2017-09-15T17:29:27  *** atroxes has quit IRC
545 2017-09-15T17:30:36  <warren> Yikes. I had been using my wallet as a symbolic link for years now.
546 2017-09-15T17:31:10  <sipa> i wasn't even aware that could work...
547 2017-09-15T17:31:23  *** atroxes has joined #bitcoin-core-dev
548 2017-09-15T17:31:43  <warren> It worked just fine.
549 2017-09-15T17:33:22  *** RubenSomsen has quit IRC
550 2017-09-15T17:35:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
551 2017-09-15T17:39:29  *** laurentmt has quit IRC
552 2017-09-15T17:41:05  <luke-jr> it shouldn't..?
553 2017-09-15T17:41:17  *** SopaXorzTaker has quit IRC
554 2017-09-15T17:44:36  <warren> It worked for me for years. #10885 sounds like it got more complicated with the possibility of the same wallet being opened multiple times after multi wallet was added
555 2017-09-15T17:44:39  <gribble> https://github.com/bitcoin/bitcoin/issues/10885 | Reject invalid wallets by promag · Pull Request #10885 · bitcoin/bitcoin · GitHub
556 2017-09-15T17:44:56  <warren> was there concern about single wallet being broken with a symlink? that worked for me for years
557 2017-09-15T17:47:41  <luke-jr> warren: the concern is situations like your own: it doesn't work in a way that is useful
558 2017-09-15T17:47:48  <gmaxwell> wallets being on different media than the /database directory will result in corruption.
559 2017-09-15T17:47:52  <luke-jr> warren: wallet.dat being on an encrypted fs doesn't provide you any security
560 2017-09-15T17:49:29  * BlueMatt also got someone on IRC asking why the PPA broke his wallet-symlink
561 2017-09-15T17:49:44  <BlueMatt> I was like "oh, please dont do that...I mean will usually work, but if your system crashes, you may get fucked"
562 2017-09-15T17:51:26  <warren> OK, maybe I was lucky to never run into problems.
563 2017-09-15T17:52:30  <BlueMatt> well we have a loop that compacts wallet like every 100ms, and (usually) if you crash post-compact pre-writing-new-stuff you're ok, but bdb makes no guarantees there, and certainly you can get screwed if you miss the time window there
564 2017-09-15T17:54:41  *** RubenSomsen has joined #bitcoin-core-dev
565 2017-09-15T17:55:01  *** promag has joined #bitcoin-core-dev
566 2017-09-15T17:58:01  <luke-jr> and I'd expect the wallet data to be written to the unencrypted database/ dir before getting into wallet.dat
567 2017-09-15T17:58:21  <BlueMatt> i believe it does, yes
568 2017-09-15T17:58:24  <BlueMatt> or the .log file
569 2017-09-15T17:58:48  <gmaxwell> everything written to wallet.dat first goes through the database/ dir. IIRC
570 2017-09-15T17:59:31  *** promag has quit IRC
571 2017-09-15T18:01:38  *** delinquentme has joined #bitcoin-core-dev
572 2017-09-15T18:01:39  *** Dizzle has quit IRC
573 2017-09-15T18:01:55  *** promag has joined #bitcoin-core-dev
574 2017-09-15T18:03:43  <delinquentme> running bitcoind w the option --assumevalid=<blah>  but Im not seeing an update in the   "verificationprogress" ... If i've given it a block that is only hours old ... shouldnt that verification shoot up?
575 2017-09-15T18:04:22  <gmaxwell> Nope.
576 2017-09-15T18:05:16  <gmaxwell> assume valid means skipping script processing, it doesn't (and cannot) avoid having to process blocks.
577 2017-09-15T18:06:57  <gmaxwell> also, setting an assumevalid right now won't do much, as the default is a fairly recent.
578 2017-09-15T18:07:58  <delinquentme> so if I've got a low compute node that I want this on, my best option for speeding up the verification is side loading it?
579 2017-09-15T18:08:25  *** adiabat has quit IRC
580 2017-09-15T18:08:37  *** adiabat has joined #bitcoin-core-dev
581 2017-09-15T18:09:13  <gmaxwell> delinquentme: yes, or just be patient, if your system is fast enough to keep up it will catch up.
582 2017-09-15T18:09:34  *** Dizzle has joined #bitcoin-core-dev
583 2017-09-15T18:11:36  <BlueMatt> also -dbcache
584 2017-09-15T18:12:15  <gmaxwell> BlueMatt: I didn't suggest that because most cpu starved things don't have ram.
585 2017-09-15T18:13:13  <BlueMatt> ah, well sure, just saying crank it if possible
586 2017-09-15T18:17:09  <delinquentme> yeah I've got that specd at 8 gigs on the machine doing the sideloading
587 2017-09-15T18:17:24  <delinquentme> I've got a total of 16 ... any reason I shouldn't make it 12g?
588 2017-09-15T18:22:24  <sipa> it won't use that much
589 2017-09-15T18:22:37  <sipa> i believe it maxes out at around dbcache=6000
590 2017-09-15T18:22:49  <sipa> but setting it higher won't hurt
591 2017-09-15T18:26:35  <BlueMatt> ha! https://github.com/bitcoin/bitcoin/pull/11226#issuecomment-329289991 <-- fuck yea, I add locks
592 2017-09-15T18:29:17  <sdaftuar> everyone needs a hobby! :)
593 2017-09-15T18:29:50  <StopAndDecrypt_> gmaxwell, how do you measure your sync time data?
594 2017-09-15T18:30:04  *** singhj has joined #bitcoin-core-dev
595 2017-09-15T18:30:04  <StopAndDecrypt_> pen and pencil or do you monitor with a tool?
596 2017-09-15T18:30:27  <BlueMatt> sdaftuar: considering my current push is refactoring the world to remove lockorder dependancies that may actually be true........
597 2017-09-15T18:30:29  <StopAndDecrypt_> im gonna be setting up 0.15 on a rapberry pi3 in the next few weeks if you want i can try and share the info
598 2017-09-15T18:30:37  <StopAndDecrypt_> if it would be useful
599 2017-09-15T18:32:46  *** singhj has quit IRC
600 2017-09-15T18:34:04  *** laurentmt has joined #bitcoin-core-dev
601 2017-09-15T18:35:29  <gmaxwell> StopAndDecrypt_: debug log timestamp differences.
602 2017-09-15T18:35:41  <gmaxwell> you can make the logs have microsecond precision too.
603 2017-09-15T18:36:15  <achow101> StopAndDecrypt_: Look at the debug.log file and check the timestamps for when you start the sync and when IsInitialBlockDownload is finished
604 2017-09-15T18:37:23  <StopAndDecrypt_> makes sense, just curious if that info would be useful.
605 2017-09-15T18:40:37  <bitcoin-git> [bitcoin] jnewbery opened pull request #11345: [tests] Check connectivity before sending in assumevalid.py (master...assume_valid_improvement) https://github.com/bitcoin/bitcoin/pull/11345
606 2017-09-15T18:46:17  *** RubenSomsen has quit IRC
607 2017-09-15T18:59:50  <BlueMatt> jonasschnelli: do you believe the latest qt only fixed the offscreen issue, or did you also intend to imply that it also fixed the setSortingEnabled thing?
608 2017-09-15T19:03:45  *** rpifan has joined #bitcoin-core-dev
609 2017-09-15T19:07:45  *** Alina-malina has quit IRC
610 2017-09-15T19:08:49  *** jtimon has joined #bitcoin-core-dev
611 2017-09-15T19:08:54  *** Chris_Stewart_5 has quit IRC
612 2017-09-15T19:09:45  *** Alina-malina has joined #bitcoin-core-dev
613 2017-09-15T19:09:46  *** Alina-malina has joined #bitcoin-core-dev
614 2017-09-15T19:13:30  *** Austindoggie has joined #bitcoin-core-dev
615 2017-09-15T19:22:05  *** tErik_mc has quit IRC
616 2017-09-15T19:22:57  *** pbase has quit IRC
617 2017-09-15T19:24:07  *** alreadylate has joined #bitcoin-core-dev
618 2017-09-15T19:31:44  *** riemann has joined #bitcoin-core-dev
619 2017-09-15T19:33:53  *** Alina-malina has quit IRC
620 2017-09-15T19:33:57  *** Cheeseo has joined #bitcoin-core-dev
621 2017-09-15T19:34:58  *** owowo has quit IRC
622 2017-09-15T19:38:09  *** Alina-malina has joined #bitcoin-core-dev
623 2017-09-15T19:39:40  *** promag has quit IRC
624 2017-09-15T19:40:25  *** Alina-malina has quit IRC
625 2017-09-15T19:40:25  *** Alina-malina has joined #bitcoin-core-dev
626 2017-09-15T19:41:16  *** owowo has joined #bitcoin-core-dev
627 2017-09-15T19:57:33  *** cheese_ has joined #bitcoin-core-dev
628 2017-09-15T19:58:32  *** Cheeseo has quit IRC
629 2017-09-15T19:59:23  *** Aaronvan_ has quit IRC
630 2017-09-15T20:00:00  *** AaronvanW has joined #bitcoin-core-dev
631 2017-09-15T20:02:07  *** promag has joined #bitcoin-core-dev
632 2017-09-15T20:05:19  *** laurentmt has quit IRC
633 2017-09-15T20:06:25  *** promag has quit IRC
634 2017-09-15T20:19:06  *** brianhoffman_ has quit IRC
635 2017-09-15T20:22:29  *** laurentmt has joined #bitcoin-core-dev
636 2017-09-15T20:23:06  *** laurentmt has quit IRC
637 2017-09-15T20:25:34  *** pergaminho has quit IRC
638 2017-09-15T20:38:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
639 2017-09-15T21:09:41  *** meshcollider has joined #bitcoin-core-dev
640 2017-09-15T21:11:51  *** RoyceX has joined #bitcoin-core-dev
641 2017-09-15T21:14:32  *** cheese_ has quit IRC
642 2017-09-15T21:20:40  *** alreadylate has quit IRC
643 2017-09-15T21:21:20  *** brianhoffman_ has joined #bitcoin-core-dev
644 2017-09-15T21:47:25  *** rpifan has quit IRC
645 2017-09-15T21:52:26  *** Guyver2 has quit IRC
646 2017-09-15T22:08:13  *** promag has joined #bitcoin-core-dev
647 2017-09-15T22:11:42  *** riemann_ has joined #bitcoin-core-dev
648 2017-09-15T22:13:26  *** Dizzle has quit IRC
649 2017-09-15T22:13:52  *** delinquentme has quit IRC
650 2017-09-15T22:14:01  *** riemann has quit IRC
651 2017-09-15T22:15:12  *** tknp has joined #bitcoin-core-dev
652 2017-09-15T22:24:25  *** delinquentme has joined #bitcoin-core-dev
653 2017-09-15T22:26:47  *** Chris_Stewart_5 has quit IRC
654 2017-09-15T22:39:48  *** riemann_ has quit IRC
655 2017-09-15T22:58:42  *** promag has quit IRC
656 2017-09-15T23:07:37  *** promag has joined #bitcoin-core-dev
657 2017-09-15T23:19:21  *** meshcollider has quit IRC
658 2017-09-15T23:24:27  *** promag has quit IRC
659 2017-09-15T23:26:23  *** cdodd has joined #bitcoin-core-dev
660 2017-09-15T23:30:06  *** meshcollider has joined #bitcoin-core-dev
661 2017-09-15T23:33:03  <jonasschnelli> BlueMatt: I don't think setSortingEnabled is fixed in newer Qt versions
662 2017-09-15T23:39:04  *** cdodd has quit IRC
663 2017-09-15T23:46:16  *** goatpig has quit IRC
664 2017-09-15T23:55:24  *** tknp has quit IRC
665 2017-09-15T23:57:34  *** abpa has quit IRC