1 2017-09-22T00:09:48  *** promag has quit IRC
  2 2017-09-22T00:11:26  <gmaxwell> Patches to AFL that let you target specific parts of code, e.g. to fuzz test a patch: https://github.com/aflgo/aflgo
  3 2017-09-22T00:12:30  *** promag has joined #bitcoin-core-dev
  4 2017-09-22T00:12:53  *** jl2012 has quit IRC
  5 2017-09-22T00:21:29  *** Deacyde has joined #bitcoin-core-dev
  6 2017-09-22T00:23:16  *** Geoffy has quit IRC
  7 2017-09-22T00:32:06  *** JackH has quit IRC
  8 2017-09-22T00:42:09  *** Ylbam has quit IRC
  9 2017-09-22T00:45:58  *** veleiro has joined #bitcoin-core-dev
 10 2017-09-22T00:47:06  *** dcousens has joined #bitcoin-core-dev
 11 2017-09-22T00:47:10  *** fengling_ has quit IRC
 12 2017-09-22T00:50:15  *** veleiro has quit IRC
 13 2017-09-22T00:51:47  *** Giszmo has quit IRC
 14 2017-09-22T01:00:10  *** dabura667 has joined #bitcoin-core-dev
 15 2017-09-22T01:07:28  *** veleiro has joined #bitcoin-core-dev
 16 2017-09-22T01:07:38  *** Giszmo has joined #bitcoin-core-dev
 17 2017-09-22T01:08:54  *** Miezel has quit IRC
 18 2017-09-22T01:13:55  *** fengling_ has joined #bitcoin-core-dev
 19 2017-09-22T01:16:01  *** Giszmo has quit IRC
 20 2017-09-22T01:17:35  *** Chris_Stewart_5 has quit IRC
 21 2017-09-22T01:26:17  *** promag has quit IRC
 22 2017-09-22T01:27:59  *** promag has joined #bitcoin-core-dev
 23 2017-09-22T01:32:18  *** promag has quit IRC
 24 2017-09-22T01:35:22  *** justanotheruser has joined #bitcoin-core-dev
 25 2017-09-22T01:47:27  *** Murch has quit IRC
 26 2017-09-22T01:59:20  *** Giszmo has joined #bitcoin-core-dev
 27 2017-09-22T02:15:30  *** owowo has quit IRC
 28 2017-09-22T02:16:29  *** tErik_mc has joined #bitcoin-core-dev
 29 2017-09-22T02:18:38  *** owowo has joined #bitcoin-core-dev
 30 2017-09-22T02:25:48  *** justanotheruser has quit IRC
 31 2017-09-22T02:45:51  *** justanotheruser has joined #bitcoin-core-dev
 32 2017-09-22T02:53:45  *** jl2012 has joined #bitcoin-core-dev
 33 2017-09-22T03:20:08  *** Miezel has joined #bitcoin-core-dev
 34 2017-09-22T03:49:01  *** d9b4bef9 has quit IRC
 35 2017-09-22T03:50:08  *** d9b4bef9 has joined #bitcoin-core-dev
 36 2017-09-22T03:59:11  *** veleiro has left #bitcoin-core-dev
 37 2017-09-22T04:03:20  *** ThomasV has joined #bitcoin-core-dev
 38 2017-09-22T04:17:37  *** jtimon has quit IRC
 39 2017-09-22T04:20:49  *** chjj has quit IRC
 40 2017-09-22T04:24:23  *** promag has joined #bitcoin-core-dev
 41 2017-09-22T04:28:28  *** promag has quit IRC
 42 2017-09-22T04:37:04  <ossifrage> FYI the twitching "Reindexing blocks on disk..." did not damp out as I made progress, now it is at 76% and twitching between 7 and 30 weeks
 43 2017-09-22T04:54:04  *** intcat has quit IRC
 44 2017-09-22T04:54:05  *** dermoth has quit IRC
 45 2017-09-22T04:54:05  *** afk11 has quit IRC
 46 2017-09-22T04:54:05  *** ghost43 has quit IRC
 47 2017-09-22T04:54:05  *** arubi has quit IRC
 48 2017-09-22T04:55:19  *** ghost43 has joined #bitcoin-core-dev
 49 2017-09-22T04:55:22  *** afk11 has joined #bitcoin-core-dev
 50 2017-09-22T04:58:28  *** arubi has joined #bitcoin-core-dev
 51 2017-09-22T05:06:32  *** harrymm has quit IRC
 52 2017-09-22T05:19:10  *** harrymm has joined #bitcoin-core-dev
 53 2017-09-22T05:28:48  <bitcoin-git> [bitcoin] Gazer022 opened pull request #11384: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/11384
 54 2017-09-22T05:29:37  <bitcoin-git> [bitcoin] Gazer022 closed pull request #11384: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/11384
 55 2017-09-22T05:30:07  *** intcat has joined #bitcoin-core-dev
 56 2017-09-22T05:38:39  *** Ylbam has joined #bitcoin-core-dev
 57 2017-09-22T05:43:58  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/49f3d57eeb66...6c4fecfaf7be
 58 2017-09-22T05:43:58  <bitcoin-git> bitcoin/master 2a07f87 Dan Raviv: Refactor: Modernize disallowed copy constructors/assignment...
 59 2017-09-22T05:43:59  <bitcoin-git> bitcoin/master 6c4fecf Pieter Wuille: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment...
 60 2017-09-22T05:44:39  <bitcoin-git> [bitcoin] sipa closed pull request #11351: Refactor: Modernize disallowed copy constructors/assignment (master...refactor/modernize-no-copy) https://github.com/bitcoin/bitcoin/pull/11351
 61 2017-09-22T05:47:24  *** ghost43 has quit IRC
 62 2017-09-22T05:47:50  *** ghost43 has joined #bitcoin-core-dev
 63 2017-09-22T06:03:12  *** ThomasV has quit IRC
 64 2017-09-22T06:05:03  *** SopaXorzTaker has joined #bitcoin-core-dev
 65 2017-09-22T06:05:10  *** SopaXorzTaker has quit IRC
 66 2017-09-22T06:05:48  *** SopaXorzTaker has joined #bitcoin-core-dev
 67 2017-09-22T06:06:52  *** SopaXorzTaker has quit IRC
 68 2017-09-22T06:07:10  *** SopaXorzTaker has joined #bitcoin-core-dev
 69 2017-09-22T06:25:58  *** promag has joined #bitcoin-core-dev
 70 2017-09-22T06:30:18  *** promag has quit IRC
 71 2017-09-22T06:34:35  *** lvmbdv has quit IRC
 72 2017-09-22T06:45:56  <bitcoin-git> [bitcoin] sipa opened pull request #11385: Remove some unused functions and methods (master...201709_misc_cleanups) https://github.com/bitcoin/bitcoin/pull/11385
 73 2017-09-22T06:47:25  *** ghost43 has quit IRC
 74 2017-09-22T06:47:53  *** ghost43 has joined #bitcoin-core-dev
 75 2017-09-22T06:54:15  *** lvmbdv has joined #bitcoin-core-dev
 76 2017-09-22T06:55:57  *** BashCo has quit IRC
 77 2017-09-22T07:11:27  *** promag has joined #bitcoin-core-dev
 78 2017-09-22T07:15:20  *** promag has quit IRC
 79 2017-09-22T07:16:04  *** promag has joined #bitcoin-core-dev
 80 2017-09-22T07:17:00  *** promag has quit IRC
 81 2017-09-22T07:17:35  *** BashCo has joined #bitcoin-core-dev
 82 2017-09-22T07:17:50  *** ThomasV has joined #bitcoin-core-dev
 83 2017-09-22T07:18:49  *** paveljanik has quit IRC
 84 2017-09-22T07:19:43  *** Ruben has joined #bitcoin-core-dev
 85 2017-09-22T07:21:37  *** RubenSomsen has quit IRC
 86 2017-09-22T07:22:14  *** promag has joined #bitcoin-core-dev
 87 2017-09-22T07:22:59  *** JackH has joined #bitcoin-core-dev
 88 2017-09-22T07:25:51  *** timothy has joined #bitcoin-core-dev
 89 2017-09-22T07:34:53  *** promag has quit IRC
 90 2017-09-22T07:35:35  *** Ruben has quit IRC
 91 2017-09-22T07:42:26  *** pbase has joined #bitcoin-core-dev
 92 2017-09-22T07:43:24  *** alreadylate has joined #bitcoin-core-dev
 93 2017-09-22T07:52:18  *** dcousens has quit IRC
 94 2017-09-22T07:59:04  *** laurentmt has joined #bitcoin-core-dev
 95 2017-09-22T07:59:34  <sipa> question: how to deal with existing tests that use getnewaddress/sendtoaddress? they often don't work without modification, as spends from segwit outputs don't work before segwit activates (in block 432 on regtest)
 96 2017-09-22T07:59:48  <sipa> 1) force all tests to stick with legacy addresses
 97 2017-09-22T08:00:32  *** ghost43 has quit IRC
 98 2017-09-22T08:00:33  *** arubi has quit IRC
 99 2017-09-22T08:00:33  *** afk11 has quit IRC
100 2017-09-22T08:00:33  *** intcat has quit IRC
101 2017-09-22T08:01:17  <sipa> 2) make getnewaddress etc fall back to legacy addresses before segwit activation (but that's not something you want on mainnet, as it could lead to accidentally creating a legacy address if you're too fast
102 2017-09-22T08:02:47  <sipa> 3) have an cmdline argument to make segwit activate from genesis in regtest (which would be on by default, excepr for tests that actually test the transition)
103 2017-09-22T08:04:16  <sipa> 4) use -prematurewitness liberally, for cases where it's only wallet logic that is being tested (not validation/consensus)
104 2017-09-22T08:04:21  *** tripleslash has quit IRC
105 2017-09-22T08:04:41  *** asoltys has quit IRC
106 2017-09-22T08:04:52  *** [b__b] has quit IRC
107 2017-09-22T08:04:52  *** timothy has quit IRC
108 2017-09-22T08:05:01  *** spinza has quit IRC
109 2017-09-22T08:05:01  *** eck has quit IRC
110 2017-09-22T08:05:11  *** [b__b] has joined #bitcoin-core-dev
111 2017-09-22T08:05:17  *** timothy has joined #bitcoin-core-dev
112 2017-09-22T08:05:41  *** tripleslash has joined #bitcoin-core-dev
113 2017-09-22T08:06:14  *** afk11 has joined #bitcoin-core-dev
114 2017-09-22T08:06:34  *** ghost43 has joined #bitcoin-core-dev
115 2017-09-22T08:06:56  *** intcat has joined #bitcoin-core-dev
116 2017-09-22T08:06:59  *** arubi has joined #bitcoin-core-dev
117 2017-09-22T08:07:01  *** asoltys has joined #bitcoin-core-dev
118 2017-09-22T08:07:05  <sipa> 5) adapt all tests to mine enough blocks up front (but that's a lot of changes... getbalance calls everywhere)
119 2017-09-22T08:08:01  *** phantomcircuit has quit IRC
120 2017-09-22T08:09:05  *** victorSN has quit IRC
121 2017-09-22T08:10:46  *** eck has joined #bitcoin-core-dev
122 2017-09-22T08:11:25  *** spinza has joined #bitcoin-core-dev
123 2017-09-22T08:12:22  *** phantomcircuit has joined #bitcoin-core-dev
124 2017-09-22T08:13:00  *** afk11 has quit IRC
125 2017-09-22T08:16:55  *** JackH has quit IRC
126 2017-09-22T08:17:09  *** JackH has joined #bitcoin-core-dev
127 2017-09-22T08:19:48  *** afk11 has joined #bitcoin-core-dev
128 2017-09-22T08:22:51  *** victorSN has joined #bitcoin-core-dev
129 2017-09-22T08:34:37  *** vicenteH has joined #bitcoin-core-dev
130 2017-09-22T08:35:12  *** dabura667 has quit IRC
131 2017-09-22T08:47:22  *** Ylbam has quit IRC
132 2017-09-22T08:53:49  *** Evel-Knievel has quit IRC
133 2017-09-22T09:02:12  <jl2012> sipa: I think 3) is the best, as it could also show all existing tests pass with the segwit getnewaddress
134 2017-09-22T09:03:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11343: added `-walletallowsymboliclink` (default false) (0.15...wallet-allow-symbolic-link) https://github.com/bitcoin/bitcoin/pull/11343
135 2017-09-22T09:04:26  <meshcollider> I agree, 2 is quite nice in theory but I think 3 is best practically
136 2017-09-22T09:06:46  *** Evel-Knievel has joined #bitcoin-core-dev
137 2017-09-22T09:07:48  <MarcoFalke> 5 is an ugly workaround, lets not do that.
138 2017-09-22T09:19:10  *** alreadylate has quit IRC
139 2017-09-22T09:19:27  *** alreadylate has joined #bitcoin-core-dev
140 2017-09-22T09:26:11  *** Geoffy has joined #bitcoin-core-dev
141 2017-09-22T09:35:27  *** dabura667 has joined #bitcoin-core-dev
142 2017-09-22T09:46:34  <gmaxwell> 5 is strictly worse than 3.  I like 3.  technically we could make mainnet activate segwit at the same time as p2sh, which would also result in regtest being born-segwit... but it would break transistion tests.
143 2017-09-22T09:47:04  <gmaxwell> I don't really think we need transition tests anymore, but they're probably also incidentally testing other useful things so probably not great to just drop them.
144 2017-09-22T09:53:00  *** niska has quit IRC
145 2017-09-22T09:57:07  *** jtimon has joined #bitcoin-core-dev
146 2017-09-22T09:57:59  *** niska has joined #bitcoin-core-dev
147 2017-09-22T09:58:24  *** ThomasV has quit IRC
148 2017-09-22T10:12:32  *** StopAndDecrypt_ has quit IRC
149 2017-09-22T10:16:32  *** StopAndDecrypt_ has joined #bitcoin-core-dev
150 2017-09-22T10:24:11  *** ThomasV has joined #bitcoin-core-dev
151 2017-09-22T10:28:17  *** Sentineo has quit IRC
152 2017-09-22T10:29:46  *** Shaun3811 has joined #bitcoin-core-dev
153 2017-09-22T10:35:17  *** Sentineo has joined #bitcoin-core-dev
154 2017-09-22T11:04:59  *** promag has joined #bitcoin-core-dev
155 2017-09-22T11:07:34  *** ThomasV has quit IRC
156 2017-09-22T11:16:52  *** Sentineo has quit IRC
157 2017-09-22T11:16:52  *** Sentineo has joined #bitcoin-core-dev
158 2017-09-22T11:18:01  *** adiabat has quit IRC
159 2017-09-22T11:26:22  *** promag has quit IRC
160 2017-09-22T11:30:29  *** ThomasV has joined #bitcoin-core-dev
161 2017-09-22T11:30:54  *** promag has joined #bitcoin-core-dev
162 2017-09-22T11:32:15  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c4fecfaf7be...390771be6276
163 2017-09-22T11:32:16  <bitcoin-git> bitcoin/master 6951a1c MeshCollider: Remove extremely outdated share/certs dir
164 2017-09-22T11:32:17  <bitcoin-git> bitcoin/master 390771b Wladimir J. van der Laan: Merge #11380: Remove outdated share/certs/ directory...
165 2017-09-22T11:32:51  <bitcoin-git> [bitcoin] laanwj closed pull request #11380: Remove outdated share/certs/ directory (master...201709_remove_old_certs) https://github.com/bitcoin/bitcoin/pull/11380
166 2017-09-22T11:34:06  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/390771be6276...94c9015bca86
167 2017-09-22T11:34:06  <bitcoin-git> bitcoin/master 46c9043 Pieter Wuille: Remove some unused functions and methods...
168 2017-09-22T11:34:07  <bitcoin-git> bitcoin/master 94c9015 Wladimir J. van der Laan: Merge #11385: Remove some unused functions and methods...
169 2017-09-22T11:34:47  <bitcoin-git> [bitcoin] laanwj closed pull request #11385: Remove some unused functions and methods (master...201709_misc_cleanups) https://github.com/bitcoin/bitcoin/pull/11385
170 2017-09-22T11:39:24  <wumpus> it's kind of sad that we never merged #9937 and no one followed up on it
171 2017-09-22T11:39:25  <gribble> https://github.com/bitcoin/bitcoin/issues/9937 | rpc: Prevent `dumpwallet` from overwriting files by laanwj · Pull Request #9937 · bitcoin/bitcoin · GitHub
172 2017-09-22T11:40:22  <wumpus> thinking about it, I don't really think "The change as written now allows to test the existence of any file." is a concern that should have prevented it from being merged, it's much better than being able to overwrite every file
173 2017-09-22T11:44:30  *** promag has quit IRC
174 2017-09-22T11:45:21  <bitcoin-git> [bitcoin] laanwj reopened pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937
175 2017-09-22T11:45:47  *** dcousens has joined #bitcoin-core-dev
176 2017-09-22T11:54:15  *** promag has joined #bitcoin-core-dev
177 2017-09-22T12:07:51  *** pbase has quit IRC
178 2017-09-22T12:08:10  *** promag has quit IRC
179 2017-09-22T12:10:47  *** promag has joined #bitcoin-core-dev
180 2017-09-22T12:11:40  <morcos> sipa: i'm in favor of 3 or even just dumping transition tests entirely.  i know sdaftuar was looking at these for his attempts to have segwit active earlier, we should get his opinion
181 2017-09-22T12:12:47  *** ThomasV has quit IRC
182 2017-09-22T12:15:27  *** promag has quit IRC
183 2017-09-22T12:20:07  *** dcousens has quit IRC
184 2017-09-22T12:21:29  *** promag has joined #bitcoin-core-dev
185 2017-09-22T12:23:29  *** dabura667 has quit IRC
186 2017-09-22T12:24:01  *** Miezel has joined #bitcoin-core-dev
187 2017-09-22T12:24:54  *** dabura667 has joined #bitcoin-core-dev
188 2017-09-22T12:28:52  <sdaftuar> sipa: i agree with 3) as the best idea for now.
189 2017-09-22T12:29:22  *** dabura667 has quit IRC
190 2017-09-22T12:30:43  <sdaftuar> gmaxwell: sipa: i was experimenting with moving segwit activation back to p2sh activation for mainnet, to see how much code simplification we could get
191 2017-09-22T12:30:56  <sdaftuar> it ended up being a lot messier than i thought and i got a little stuck on that project--
192 2017-09-22T12:31:31  <sdaftuar> moving SCRIPT_VERIFY_WITNESS enforcement back is a straightforward change, but the rules around witness commitments in the coinbase are not really changeable, as far as i can tell
193 2017-09-22T12:31:55  *** dabura667 has joined #bitcoin-core-dev
194 2017-09-22T12:32:51  <sdaftuar> the simplest example -- pre-segwit, someone mines a block with a witness commitment that commits to the transactions all not having a witness -- doesn't validate, because checking the commitment
195 2017-09-22T12:33:02  <sdaftuar> requires checking the witness nonce, which is not present
196 2017-09-22T12:33:27  <sdaftuar> never mind if there are blocks which have an incorrect commitment (pre-activation) -- i assume those exist too
197 2017-09-22T12:34:30  <sdaftuar> so i was left wondering if it was worth splitting segwit activation into two parts -- one where witness commitments are only checked at some height, but SCRIPT_VERIFY_WITNESS is enforced eg from genesis
198 2017-09-22T12:34:40  <sdaftuar> and my instinct was that was only complicating things, and not simplifying
199 2017-09-22T12:34:49  <sdaftuar> but i'd be interested in others' opinions
200 2017-09-22T12:35:53  *** dabura667 has quit IRC
201 2017-09-22T12:37:06  *** dabura667 has joined #bitcoin-core-dev
202 2017-09-22T12:37:57  *** dabura667 has quit IRC
203 2017-09-22T12:38:11  *** veleiro has joined #bitcoin-core-dev
204 2017-09-22T12:38:19  *** veleiro has left #bitcoin-core-dev
205 2017-09-22T12:54:22  *** veleiro has joined #bitcoin-core-dev
206 2017-09-22T12:55:28  *** promag has quit IRC
207 2017-09-22T13:07:39  *** Guyver2 has joined #bitcoin-core-dev
208 2017-09-22T13:39:16  *** alreadylate has quit IRC
209 2017-09-22T13:43:29  *** sdfgsdfg has quit IRC
210 2017-09-22T13:45:47  *** Miezel has quit IRC
211 2017-09-22T13:48:26  *** veleiro has quit IRC
212 2017-09-22T13:55:08  <jnewbery> sdaftuar: I think it's still worthwhile, even if you need to split SCRIPT_VERIFY_WITNESS enforcement from witness commitment verification. We could then change SCRIPT_VERIFY_WITNES activation height on regtest to 0 and remove all the transition tests (except one test for verifying that witness commitment verification is not enforced before witness commitment verification height)
213 2017-09-22T13:56:04  *** meshcollider has quit IRC
214 2017-09-22T13:57:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
215 2017-09-22T13:58:13  *** ThomasV has joined #bitcoin-core-dev
216 2017-09-22T13:58:20  <jnewbery> sipa: (3) is best for now. It'd be nice to eventually dump most transition tests if possible
217 2017-09-22T13:58:33  *** promag has joined #bitcoin-core-dev
218 2017-09-22T14:02:10  *** justanotheruser has quit IRC
219 2017-09-22T14:07:33  *** lifeofguenter has quit IRC
220 2017-09-22T14:13:26  *** lifeofguenter has joined #bitcoin-core-dev
221 2017-09-22T14:20:48  *** jtimon has quit IRC
222 2017-09-22T14:30:03  *** promag has quit IRC
223 2017-09-22T14:30:15  *** alreadylate has joined #bitcoin-core-dev
224 2017-09-22T14:30:40  *** promag has joined #bitcoin-core-dev
225 2017-09-22T14:32:27  *** veleiro has joined #bitcoin-core-dev
226 2017-09-22T14:36:47  *** veleiro has quit IRC
227 2017-09-22T14:38:49  *** promag has quit IRC
228 2017-09-22T14:42:31  *** promag has joined #bitcoin-core-dev
229 2017-09-22T14:44:48  *** promag has quit IRC
230 2017-09-22T14:47:02  *** promag has joined #bitcoin-core-dev
231 2017-09-22T14:57:00  *** AaronvanW has joined #bitcoin-core-dev
232 2017-09-22T15:13:08  *** newbie is now known as newbie--
233 2017-09-22T15:15:32  <instagibbs> how would people feel about removing mempoolreplacement arg? There's no tests, and I have yet to hear a reason to not allow it.(or people setting it to off)
234 2017-09-22T15:23:13  *** JackH has quit IRC
235 2017-09-22T15:27:02  *** promag has quit IRC
236 2017-09-22T15:29:21  <jonasschnelli> wumpus: Oh. I completely forgot #9937. We should have merged it, yes.
237 2017-09-22T15:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/9937 | rpc: Prevent `dumpwallet` from overwriting files by laanwj · Pull Request #9937 · bitcoin/bitcoin · GitHub
238 2017-09-22T15:30:39  <Sentineo>  /window 3
239 2017-09-22T15:33:43  *** RubenSomsen has joined #bitcoin-core-dev
240 2017-09-22T15:38:32  <jnewbery> luke-jr: I'm looking at #11383 (nice work btw!). I don't understand the comment about it requiring #10615. It looks like they're basically orthogonal (except a bit of overlap in the RPC console). I think it'll probably aid review if you separate them out so there's no cross-dependency.
241 2017-09-22T15:38:34  <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
242 2017-09-22T15:38:35  <gribble> https://github.com/bitcoin/bitcoin/issues/10615 | RPC: Allow rpcauth configs to specify a 4th parameter naming a specific wallet (multiwallet RPC support) by luke-jr · Pull Request #10615 · bitcoin/bitcoin · GitHub
243 2017-09-22T15:41:59  *** promag has joined #bitcoin-core-dev
244 2017-09-22T15:47:25  *** adiabat has joined #bitcoin-core-dev
245 2017-09-22T15:48:45  *** Murch has joined #bitcoin-core-dev
246 2017-09-22T15:51:33  *** promag has quit IRC
247 2017-09-22T16:00:36  *** alreadylate has quit IRC
248 2017-09-22T16:02:42  *** ThomasV has quit IRC
249 2017-09-22T16:07:55  *** BashCo has quit IRC
250 2017-09-22T16:10:41  *** ThomasV has joined #bitcoin-core-dev
251 2017-09-22T16:18:06  *** SopaXorzTaker has quit IRC
252 2017-09-22T16:21:25  *** SopaXorzTaker has joined #bitcoin-core-dev
253 2017-09-22T16:31:53  *** BashCo has joined #bitcoin-core-dev
254 2017-09-22T16:43:31  <luke-jr> jnewbery: 10615 has the commit resolving the wallet for RPC earlier, so GUI can assign it
255 2017-09-22T16:48:02  *** laurentmt has quit IRC
256 2017-09-22T16:50:12  *** ThomasV has quit IRC
257 2017-09-22T16:52:47  *** ThomasV has joined #bitcoin-core-dev
258 2017-09-22T16:56:12  *** abpa has joined #bitcoin-core-dev
259 2017-09-22T16:59:03  *** Chris_Stewart_5 has quit IRC
260 2017-09-22T17:07:03  *** promag has joined #bitcoin-core-dev
261 2017-09-22T17:10:49  *** Ylbam has joined #bitcoin-core-dev
262 2017-09-22T17:12:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
263 2017-09-22T17:17:21  *** timothy has quit IRC
264 2017-09-22T17:17:56  *** promag has quit IRC
265 2017-09-22T17:20:32  *** Giszmo has quit IRC
266 2017-09-22T17:20:35  *** Alina-malina has quit IRC
267 2017-09-22T17:21:06  *** Giszmo has joined #bitcoin-core-dev
268 2017-09-22T17:21:29  <jnewbery> luke-jr : That's only used for the RPC console. If I just cherry-pick all the commits apart from that, then it works fine without 10615. There are still several outstanding concerns in 10615, so I think it makes sense to separate the two PRs and allow them to be reviewed separately
269 2017-09-22T17:30:07  *** Alina-malina has joined #bitcoin-core-dev
270 2017-09-22T17:32:54  *** ThomasV has quit IRC
271 2017-09-22T17:34:41  *** Alina-malina has quit IRC
272 2017-09-22T17:34:42  *** Alina-malina has joined #bitcoin-core-dev
273 2017-09-22T17:35:50  *** ula has joined #bitcoin-core-dev
274 2017-09-22T17:38:37  *** promag has joined #bitcoin-core-dev
275 2017-09-22T17:38:51  *** promag has joined #bitcoin-core-dev
276 2017-09-22T17:40:52  *** alreadylate has joined #bitcoin-core-dev
277 2017-09-22T17:40:53  *** laurentmt has joined #bitcoin-core-dev
278 2017-09-22T17:43:31  *** Emcy has joined #bitcoin-core-dev
279 2017-09-22T17:45:37  *** Emcy_ has quit IRC
280 2017-09-22T17:55:21  *** abpa has quit IRC
281 2017-09-22T17:59:46  *** vicenteH has quit IRC
282 2017-09-22T18:04:22  *** alreadylate has quit IRC
283 2017-09-22T18:12:37  *** Emcy_ has joined #bitcoin-core-dev
284 2017-09-22T18:14:35  *** Emcy has quit IRC
285 2017-09-22T18:15:15  *** Emcy has joined #bitcoin-core-dev
286 2017-09-22T18:17:46  *** Emcy_ has quit IRC
287 2017-09-22T18:23:22  <luke-jr> jnewbery: it should be used by WalletModel too (although maybe it isn't yet)
288 2017-09-22T18:23:31  <luke-jr> (pretty sure it is tho)
289 2017-09-22T18:35:12  *** Emcy_ has joined #bitcoin-core-dev
290 2017-09-22T18:37:48  *** Emcy has quit IRC
291 2017-09-22T18:46:43  *** Emcy has joined #bitcoin-core-dev
292 2017-09-22T18:48:09  <achow101> .... wow. I managed to get bitcoin 0.1.0 to start syncing off of Core 0.15.99
293 2017-09-22T18:48:44  *** alreadylate has joined #bitcoin-core-dev
294 2017-09-22T18:49:21  *** Emcy_ has quit IRC
295 2017-09-22T18:49:50  <sipa> achow101: i assume you needed to patch 0.1.0 a bit?
296 2017-09-22T18:50:16  <achow101> sipa: I patched Core to speak 0.1.0
297 2017-09-22T18:50:35  <achow101> and apparently bitcoin.org's docs are wrong
298 2017-09-22T18:50:41  <sipa> fix them!
299 2017-09-22T18:50:45  <achow101> I will
300 2017-09-22T18:53:25  *** ThomasV has joined #bitcoin-core-dev
301 2017-09-22T18:53:55  <sipa> morcos: perhaps you can answer https://bitcoin.stackexchange.com/questions/59854/where-are-the-new-smart-fee-estimate-data-saved-can-the-file-be-re-used
302 2017-09-22T18:59:47  *** promag has quit IRC
303 2017-09-22T19:06:44  *** SopaXorzTaker has quit IRC
304 2017-09-22T19:07:35  *** jtimon has joined #bitcoin-core-dev
305 2017-09-22T19:08:35  <morcos> sipa: ok done
306 2017-09-22T19:08:51  <achow101> are coinbase transactions supposed to have witnesses?
307 2017-09-22T19:09:12  <achow101> I'm seeing coinbase transactions with witness fields of 32 bytes of 0's
308 2017-09-22T19:09:29  <achow101> *1 stack item of 32 bytes of 0's
309 2017-09-22T19:09:31  <sipa> achow101: yes
310 2017-09-22T19:09:42  <sipa> achow101: they're a field intended for extensibility
311 2017-09-22T19:10:11  <achow101> sipa: oh, ok. I don't see that in the BIPs though..
312 2017-09-22T19:10:38  <achow101> oh, nvm. found it in bip 141
313 2017-09-22T19:10:48  *** RubenSomsen has quit IRC
314 2017-09-22T19:10:57  <sipa> it's called 'witness reserved value' in the bip
315 2017-09-22T19:11:01  *** alreadylate has quit IRC
316 2017-09-22T19:18:25  *** afk11 has quit IRC
317 2017-09-22T19:18:45  *** afk11 has joined #bitcoin-core-dev
318 2017-09-22T19:22:03  *** Emcy_ has joined #bitcoin-core-dev
319 2017-09-22T19:22:23  *** SopaXorzTaker has joined #bitcoin-core-dev
320 2017-09-22T19:24:16  *** Emcy has quit IRC
321 2017-09-22T19:26:52  *** thomas__ has joined #bitcoin-core-dev
322 2017-09-22T19:27:52  <thomas__> Hey guys, new here. Does someone have to work on windows and has a good workflow set up ?
323 2017-09-22T19:28:11  <sipa> a good workflow for what?
324 2017-09-22T19:28:24  <thomas__> to dev
325 2017-09-22T19:30:49  *** promag has joined #bitcoin-core-dev
326 2017-09-22T19:31:57  <thomas__> I'll be rebuilding a lot this weekend to see how things work, if someone has a way to make it less painful I'd like to hear from him ^^
327 2017-09-22T19:32:14  <achow101> thomas__: use linux and read the Bitcoin Core docs
328 2017-09-22T19:33:01  <thomas__> damit, everyone has the same answer. I have an ubuntu set up on my computer, but I also have to do stuff on windows. I don't see myself switching 3 times a day between both.
329 2017-09-22T19:33:20  <achow101> thomas__: then use a VM
330 2017-09-22T19:33:22  *** Chris_Stewart_5 has quit IRC
331 2017-09-22T19:33:35  <achow101> developing things is infintely easier to do in a *nix environment than windows
332 2017-09-22T19:33:39  *** promag has quit IRC
333 2017-09-22T19:33:42  <sipa> how well does bash-on-windows work these days?
334 2017-09-22T19:34:17  <achow101> sipa: pretty well, but AFAIK, no gui support
335 2017-09-22T19:34:22  <thomas__> the wsl works if you keep all your file on the linux side
336 2017-09-22T19:34:27  <achow101> i.e. can't run bitcoin-qt
337 2017-09-22T19:35:05  <thomas__> I'm cross compiling right now, I'll know after that
338 2017-09-22T19:35:26  *** alreadylate has joined #bitcoin-core-dev
339 2017-09-22T19:35:39  <achow101> thomas__: I suppose you could use wsl and cross compile. note that cross compiling with ubuntu 15.10+ (wsl uses ubuntu 16.04) is a bit flaky
340 2017-09-22T19:35:43  *** Emcy has joined #bitcoin-core-dev
341 2017-09-22T19:37:10  <thomas__> Apparently mine uses: Description:    Ubuntu 14.04.5 LTS
342 2017-09-22T19:37:18  <thomas__> So should be ok then
343 2017-09-22T19:38:05  <bitcoin-git> [bitcoin] runn1ng opened pull request #11386: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (master...univalue_bikeshed) https://github.com/bitcoin/bitcoin/pull/11386
344 2017-09-22T19:38:17  *** SopaXorzTaker has quit IRC
345 2017-09-22T19:38:51  *** Emcy_ has quit IRC
346 2017-09-22T19:42:40  *** SopaXorzTaker has joined #bitcoin-core-dev
347 2017-09-22T19:53:36  *** SopaXorzTaker has quit IRC
348 2017-09-22T19:55:18  *** Emcy_ has joined #bitcoin-core-dev
349 2017-09-22T19:57:30  *** SopaXorzTaker has joined #bitcoin-core-dev
350 2017-09-22T19:57:41  *** Emcy has quit IRC
351 2017-09-22T20:03:36  *** SopaXorzTaker has quit IRC
352 2017-09-22T20:07:31  *** alreadylate has quit IRC
353 2017-09-22T20:12:54  *** alreadylate has joined #bitcoin-core-dev
354 2017-09-22T20:12:55  <achow101> with old versions of bitcoin (e.g. 0.1.0), what happens if they receive blocks out of order?
355 2017-09-22T20:14:29  *** alreadylate has quit IRC
356 2017-09-22T20:16:27  *** vicenteH has joined #bitcoin-core-dev
357 2017-09-22T20:17:35  <sipa> achow101: stored as orphans in memory until the parent is fetched
358 2017-09-22T20:18:09  <sipa> at some point we limited the size of the orphan block pool, which resulted in the same blocks being fetched over and over again
359 2017-09-22T20:18:12  *** Emcy has joined #bitcoin-core-dev
360 2017-09-22T20:18:15  <sipa> until headers-sync in 0.10
361 2017-09-22T20:21:05  *** Emcy_ has quit IRC
362 2017-09-22T20:25:50  *** laurentmt has quit IRC
363 2017-09-22T20:26:37  *** ossifrage has quit IRC
364 2017-09-22T20:27:50  *** Emcy_ has joined #bitcoin-core-dev
365 2017-09-22T20:30:05  *** SopaXorzTaker has joined #bitcoin-core-dev
366 2017-09-22T20:30:35  *** Emcy has quit IRC
367 2017-09-22T20:32:16  <esotericnonsense> thomas__: if you haven't spent much time working in VM's I'd really recommend it. on modern hardware it's a treat.
368 2017-09-22T20:32:47  <thomas__> A few years ago a lot of people were bitching about it and so I never took the time to really try
369 2017-09-22T20:32:49  * esotericnonsense is pleased to see virgl slowly working its way into kvm
370 2017-09-22T20:34:23  *** promag has joined #bitcoin-core-dev
371 2017-09-22T20:35:29  *** darkROL has joined #bitcoin-core-dev
372 2017-09-22T20:35:35  *** SopaXorzTaker has quit IRC
373 2017-09-22T20:38:35  *** promag has quit IRC
374 2017-09-22T20:38:43  *** Emcy has joined #bitcoin-core-dev
375 2017-09-22T20:41:46  *** Emcy_ has quit IRC
376 2017-09-22T20:47:06  *** abpa has joined #bitcoin-core-dev
377 2017-09-22T20:48:12  *** darkROL has quit IRC
378 2017-09-22T20:50:36  *** SopaXorzTaker has joined #bitcoin-core-dev
379 2017-09-22T20:50:49  <jonasschnelli> Should we tolerate lost GUI window positions in 0.16 (the window will recenter in 0.16 when merging #11335)
380 2017-09-22T20:50:52  <gribble> https://github.com/bitcoin/bitcoin/issues/11335 | Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
381 2017-09-22T20:52:58  *** laurentmt has joined #bitcoin-core-dev
382 2017-09-22T20:56:22  *** SopaXorzTaker has quit IRC
383 2017-09-22T20:57:05  *** danra has joined #bitcoin-core-dev
384 2017-09-22T20:58:20  *** laurentmt has quit IRC
385 2017-09-22T21:03:39  *** Emcy_ has joined #bitcoin-core-dev
386 2017-09-22T21:05:17  *** Emcy has quit IRC
387 2017-09-22T21:05:45  *** ThomasV has quit IRC
388 2017-09-22T21:10:05  *** Sinclair6 has joined #bitcoin-core-dev
389 2017-09-22T21:12:17  *** Guyver2 has quit IRC
390 2017-09-22T21:22:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
391 2017-09-22T21:22:34  * luke-jr ponders if BIP editor should be enabled to fix spelling/grammar without going through the author
392 2017-09-22T21:26:59  *** promag has joined #bitcoin-core-dev
393 2017-09-22T21:27:57  *** SopaXorzTaker has joined #bitcoin-core-dev
394 2017-09-22T21:33:48  *** SopaXorzTaker has quit IRC
395 2017-09-22T21:42:35  *** Chris_Stewart_5 has quit IRC
396 2017-09-22T21:43:12  *** Emcy has joined #bitcoin-core-dev
397 2017-09-22T21:45:54  *** Emcy_ has quit IRC
398 2017-09-22T21:50:54  *** SopaXorzTaker has joined #bitcoin-core-dev
399 2017-09-22T21:56:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
400 2017-09-22T21:59:03  *** danra has quit IRC
401 2017-09-22T22:02:09  *** Aaronvan_ has joined #bitcoin-core-dev
402 2017-09-22T22:02:34  *** Emcy_ has joined #bitcoin-core-dev
403 2017-09-22T22:02:56  *** Aaronvan_ has joined #bitcoin-core-dev
404 2017-09-22T22:04:37  *** Emcy has quit IRC
405 2017-09-22T22:05:09  *** AaronvanW has quit IRC
406 2017-09-22T22:07:54  *** Miezel has joined #bitcoin-core-dev
407 2017-09-22T22:09:35  *** SopaXorzTaker has quit IRC
408 2017-09-22T22:15:30  *** thomas__ has quit IRC
409 2017-09-22T22:18:54  *** promag has quit IRC
410 2017-09-22T22:23:28  *** fengling_ has quit IRC
411 2017-09-22T22:24:05  *** fengling_ has joined #bitcoin-core-dev
412 2017-09-22T22:25:58  *** chjj has joined #bitcoin-core-dev
413 2017-09-22T22:27:21  *** ossifrage has joined #bitcoin-core-dev
414 2017-09-22T22:27:21  *** ossifrage has joined #bitcoin-core-dev
415 2017-09-22T22:27:51  <ossifrage> That is really annoying chrome decided to eat up all the memory, but the oom killer took out bitcoin (while doing a reindex) and somehow the progress went from 99ish% to 85%, that is quite a bit of rollback
416 2017-09-22T22:31:35  *** Chris_Stewart_5 has quit IRC
417 2017-09-22T22:31:59  <esotericnonsense> ossifrage: how long does the entire reindex take? if it's the same mechanism as during IBD then with a high dbcache value it's just every N minutes/hours (don't remember the figure)
418 2017-09-22T22:32:53  <esotericnonsense> (sorry, that's a flush happening every N minutes/hours)
419 2017-09-22T22:33:06  <gmaxwell> ossifrage: it'll rollback to the last flush. In the future we'll hopefully switch to more incremental flushing which will roll back less far in the event of a crash during initial sync.
420 2017-09-22T22:34:11  <ossifrage> gmaxwell, I had a 4G dbcache which was part of the reason the oom killer picked on bitcoin
421 2017-09-22T22:34:22  <esotericnonsense> static const unsigned int DATABASE_FLUSH_INTERVAL = 24 * 60 * 60;
422 2017-09-22T22:34:39  <esotericnonsense> O_o
423 2017-09-22T22:34:42  <gmaxwell> I wish linux mem handling had a "shrink now or you're gonna get killed" signal.
424 2017-09-22T22:35:19  <gmaxwell> esotericnonsense: that means it'll force a flush once a day if it hasn't been triggered by the cache filling.
425 2017-09-22T22:35:31  <gmaxwell> during IBD cache filling triggers the flushes.
426 2017-09-22T22:35:35  *** To7 has joined #bitcoin-core-dev
427 2017-09-22T22:36:18  <ossifrage> esotericnonsense, I am generating the full tx index (txindex=1) and it is taking a very long time [I'm not sure when I started it, the debug.log got truncated]
428 2017-09-22T22:36:26  <ossifrage> >24 hours ago
429 2017-09-22T22:37:09  <gmaxwell> >24 hours with a 4gb dbcache. damn txindex.
430 2017-09-22T22:37:52  <esotericnonsense> think my laptop was sub 24hours when I did it and it's not super-fast or anything. though that was syncing over LAN rather than reindex.
431 2017-09-22T22:38:04  <esotericnonsense> (with txindex on).
432 2017-09-22T22:38:37  <esotericnonsense> is that on a HDD?
433 2017-09-22T22:38:44  <ossifrage> gmaxwell, it doesn't seem to be IO or CPU bound, but I am using spinning rust, it seemed wasteful to eat up a large % of my ssd on bitcoin
434 2017-09-22T22:38:49  <esotericnonsense> ah yeah.
435 2017-09-22T22:40:06  <gmaxwell> ossifrage: with a large dbcache it doesn't matter if you're on a SSD or rust when txindex is not in use, alas...
436 2017-09-22T22:40:47  <ossifrage> If I turn txindex off, do I have to start over again when I turn it back on?
437 2017-09-22T22:43:09  <ossifrage> The last log entry was 96% with a 2446MB dbcache and it rolled back to 84% (my memory of almost done was faulty)
438 2017-09-22T22:46:29  *** promag has joined #bitcoin-core-dev
439 2017-09-22T22:50:41  *** promag has quit IRC
440 2017-09-22T23:06:31  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/94c9015bca86...877678710800
441 2017-09-22T23:06:32  <bitcoin-git> bitcoin/master 6059182 Marko Bencun: add m_added_nodes to connman options
442 2017-09-22T23:06:32  <bitcoin-git> bitcoin/master 35e5c22 Marko Bencun: remove unused IsArgSet check...
443 2017-09-22T23:06:33  <bitcoin-git> bitcoin/master 8776787 Pieter Wuille: Merge #11301: add m_added_nodes to connman options...
444 2017-09-22T23:07:18  <bitcoin-git> [bitcoin] sipa closed pull request #11301: add m_added_nodes to connman options (master...addnode) https://github.com/bitcoin/bitcoin/pull/11301
445 2017-09-22T23:07:23  <esotericnonsense> ossifrage: if you have enough log, you can go back and find the time when dbcache reset, that will be the last flush probably at 84%.
446 2017-09-22T23:09:31  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/877678710800...c6223b3daab0
447 2017-09-22T23:09:31  <bitcoin-git> bitcoin/master 22fd04b Gregory Maxwell: Remove nBlockMaxSize from miner opt struct as it is no longer used.
448 2017-09-22T23:09:32  <bitcoin-git> bitcoin/master c6223b3 Pieter Wuille: Merge #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used....
449 2017-09-22T23:10:11  <bitcoin-git> [bitcoin] sipa closed pull request #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used. (master...2017_09_rm_nBlockMaxSize) https://github.com/bitcoin/bitcoin/pull/11362
450 2017-09-22T23:10:44  *** meshcollider has joined #bitcoin-core-dev
451 2017-09-22T23:12:05  *** dcousens has joined #bitcoin-core-dev
452 2017-09-22T23:16:28  <bitcoin-git> [bitcoin] theuni opened pull request #11387: net: remove more CConnman globals (master...more-connman-params) https://github.com/bitcoin/bitcoin/pull/11387
453 2017-09-22T23:18:08  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c6223b3daab0...aeed345c9bad
454 2017-09-22T23:18:09  <bitcoin-git> bitcoin/master e912118 Johnson Lau: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck
455 2017-09-22T23:18:09  <bitcoin-git> bitcoin/master 3a131b7 Johnson Lau: Rename out to m_tx_out in CScriptCheck
456 2017-09-22T23:18:10  <bitcoin-git> bitcoin/master aeed345 Pieter Wuille: Merge #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck...
457 2017-09-22T23:18:33  <bitcoin-git> [bitcoin] sipa closed pull request #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck (master...combine_script_amount) https://github.com/bitcoin/bitcoin/pull/10953
458 2017-09-22T23:35:54  *** dcousens has quit IRC
459 2017-09-22T23:41:19  *** Emcy has joined #bitcoin-core-dev
460 2017-09-22T23:43:08  *** promag has joined #bitcoin-core-dev
461 2017-09-22T23:43:18  *** Miezel has quit IRC
462 2017-09-22T23:44:09  *** Emcy_ has quit IRC
463 2017-09-22T23:46:16  *** promag has quit IRC
464 2017-09-22T23:46:33  *** promag has joined #bitcoin-core-dev
465 2017-09-22T23:50:56  *** promag has quit IRC
466 2017-09-22T23:51:03  *** Emcy_ has joined #bitcoin-core-dev
467 2017-09-22T23:52:21  *** justanotheruser has joined #bitcoin-core-dev
468 2017-09-22T23:52:48  *** Emcy has quit IRC