12017-10-13T00:19:57 *** jb55 has quit IRC
22017-10-13T00:27:46 *** belcher has joined #bitcoin-core-dev
32017-10-13T00:28:09 *** Ylbam has quit IRC
42017-10-13T00:30:34 *** gbr_ has quit IRC
52017-10-13T00:36:55 *** jb55 has joined #bitcoin-core-dev
62017-10-13T00:45:20 *** jb55 has quit IRC
72017-10-13T00:56:30 *** dabura667 has joined #bitcoin-core-dev
82017-10-13T01:00:13 *** btcdrak has joined #bitcoin-core-dev
92017-10-13T01:00:41 <btcdrak> Twitter have verified the @bitcoincoreorg twitter account, which now displays the verified checkmark https://twitter.com/bitcoincoreorg/status/918638354069164032
102017-10-13T01:01:55 <btcdrak> Twitter reached out shortly after taking down the impersonator account down. They apparently have done their research and were well aware of the situation.
112017-10-13T01:02:48 <esotericnonsense> \o/
122017-10-13T01:08:15 <sipa> btcdrak: cool, thanks!
132017-10-13T01:17:44 <meshcollider> btcdrak: good news :)
142017-10-13T01:18:48 <grubles> nice
152017-10-13T01:54:06 <Emcy> nice
162017-10-13T02:07:19 *** bigtim has joined #bitcoin-core-dev
172017-10-13T02:25:44 *** CubicEarth has joined #bitcoin-core-dev
182017-10-13T02:30:59 *** roadcrap has quit IRC
192017-10-13T02:34:58 *** roadcrap has joined #bitcoin-core-dev
202017-10-13T03:14:52 *** wxss has quit IRC
212017-10-13T03:18:25 *** luke-jr has quit IRC
222017-10-13T03:18:33 *** luke-jr has joined #bitcoin-core-dev
232017-10-13T03:22:58 *** promag has joined #bitcoin-core-dev
242017-10-13T03:27:24 *** promag has quit IRC
252017-10-13T03:28:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
262017-10-13T03:33:39 *** bigtim has quit IRC
272017-10-13T03:50:57 *** Chris_Stewart_5 has quit IRC
282017-10-13T04:08:35 *** Giszmo has joined #bitcoin-core-dev
292017-10-13T04:32:25 *** gmaxwell has quit IRC
302017-10-13T04:41:18 *** goatpig has joined #bitcoin-core-dev
312017-10-13T04:47:07 *** CubicEarth has quit IRC
322017-10-13T05:09:02 *** dabura667_ has joined #bitcoin-core-dev
332017-10-13T05:09:14 *** dabura667 has quit IRC
342017-10-13T05:27:49 *** jb55 has joined #bitcoin-core-dev
352017-10-13T05:27:53 *** Ylbam has joined #bitcoin-core-dev
362017-10-13T05:40:28 <bitcoin-git> [bitcoin] cherouvim opened pull request #11493: ultra trivial typo fix in docs (master...master) https://github.com/bitcoin/bitcoin/pull/11493
372017-10-13T05:53:50 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
382017-10-13T06:14:05 *** maaku has joined #bitcoin-core-dev
392017-10-13T06:15:24 <maaku> style question: when making something like an STL container, should I still adhere to the bitcoin style guide (e.g. CamelCase methods)?
402017-10-13T06:18:03 <sipa> at least for two examples of those (limitedmap and prevector), we follow STL naming conventions, but that's mostly because these are actually drop-in replacements
412017-10-13T06:22:15 *** meshcollider has quit IRC
422017-10-13T06:35:47 *** psyduck has joined #bitcoin-core-dev
432017-10-13T06:36:10 *** psyduck is now known as Guest76632
442017-10-13T06:36:46 <Guest76632> hi
452017-10-13T06:37:13 <Guest76632> How can I make a request to update the list of exchanges on bitcoin.org?
462017-10-13T06:37:52 *** sturles has quit IRC
472017-10-13T06:37:59 <sipa> https://github.com/bitcoin-dot-org/bitcoin.org/issues
482017-10-13T06:38:37 *** sturles has joined #bitcoin-core-dev
492017-10-13T06:38:37 *** sturles has joined #bitcoin-core-dev
502017-10-13T06:39:31 *** Guest76632 has quit IRC
512017-10-13T06:45:07 *** fanquake has joined #bitcoin-core-dev
522017-10-13T06:49:50 *** BashCo has quit IRC
532017-10-13T06:50:18 *** gmaxwell has joined #bitcoin-core-dev
542017-10-13T06:56:48 *** fanquake has quit IRC
552017-10-13T07:12:09 <bitcoin-git> [bitcoin] ajtowns opened pull request #11494: Clarify BIP9 behaviour when nTimeout <= 0 (master...vb_0_timeout) https://github.com/bitcoin/bitcoin/pull/11494
562017-10-13T07:13:48 *** BashCo has joined #bitcoin-core-dev
572017-10-13T07:15:31 *** fanquake has joined #bitcoin-core-dev
582017-10-13T07:16:16 *** esotericnonsense has quit IRC
592017-10-13T07:16:36 *** promag has joined #bitcoin-core-dev
602017-10-13T07:20:41 *** DrOlmer has quit IRC
612017-10-13T07:21:25 *** DrOlmer has joined #bitcoin-core-dev
622017-10-13T07:27:15 *** timothy has joined #bitcoin-core-dev
632017-10-13T07:27:23 *** meshcollider has joined #bitcoin-core-dev
642017-10-13T07:30:33 *** Guyver2 has joined #bitcoin-core-dev
652017-10-13T07:36:02 *** Guyver2 has quit IRC
662017-10-13T07:54:03 *** laurentmt has joined #bitcoin-core-dev
672017-10-13T08:01:09 *** SopaXorzTaker has joined #bitcoin-core-dev
682017-10-13T08:21:06 *** merehap_ has joined #bitcoin-core-dev
692017-10-13T08:23:04 *** promag has joined #bitcoin-core-dev
702017-10-13T08:33:57 *** jb55 has quit IRC
712017-10-13T08:35:54 *** promag has quit IRC
722017-10-13T08:39:20 *** promag has joined #bitcoin-core-dev
732017-10-13T08:46:43 *** fanquake has quit IRC
742017-10-13T08:55:15 <meshcollider> are any of the travis builds big endian
752017-10-13T09:00:28 *** promag has quit IRC
762017-10-13T09:04:32 *** Ylbam has quit IRC
772017-10-13T09:13:32 *** SopaXorzTaker has quit IRC
782017-10-13T09:19:20 *** SopaXorzTaker has joined #bitcoin-core-dev
792017-10-13T09:29:28 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11493: ultra trivial typo fix in docs (master...master) https://github.com/bitcoin/bitcoin/pull/11493
802017-10-13T09:52:36 *** Aaronvan_ has joined #bitcoin-core-dev
812017-10-13T09:55:34 *** AaronvanW has quit IRC
822017-10-13T10:01:32 *** wxss has joined #bitcoin-core-dev
832017-10-13T10:08:26 *** esotericnonsense has joined #bitcoin-core-dev
842017-10-13T10:11:41 *** dabura667_ has quit IRC
852017-10-13T10:43:35 *** m8tion has joined #bitcoin-core-dev
862017-10-13T10:48:15 *** promag has joined #bitcoin-core-dev
872017-10-13T10:51:07 *** promag has quit IRC
882017-10-13T10:52:40 *** promag has joined #bitcoin-core-dev
892017-10-13T11:33:13 *** Ofelia has quit IRC
902017-10-13T11:37:48 *** dermoth has quit IRC
912017-10-13T11:38:41 *** promag has quit IRC
922017-10-13T11:39:05 *** dermoth has joined #bitcoin-core-dev
932017-10-13T11:45:50 *** pbase has joined #bitcoin-core-dev
942017-10-13T11:57:05 *** promag has joined #bitcoin-core-dev
952017-10-13T11:59:20 *** rafalcpp has quit IRC
962017-10-13T12:01:35 *** promag has quit IRC
972017-10-13T12:09:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
982017-10-13T12:13:16 *** Aaronvan_ is now known as AaronvanW
992017-10-13T12:32:56 *** alreadylate has joined #bitcoin-core-dev
1002017-10-13T12:34:21 *** Chris_Stewart_5 has quit IRC
1012017-10-13T13:13:11 <pbase> hi i am currently syncing the core wallet which is pruned. Can i copy paste the entire downloaded data for a second wallet on a different computer (local). basically what i want to do is to save time in syncing the data on the second computer
1022017-10-13T13:22:26 *** ducdung has joined #bitcoin-core-dev
1032017-10-13T13:24:11 *** ducdung has left #bitcoin-core-dev
1042017-10-13T13:33:54 *** meshcollider has quit IRC
1052017-10-13T13:49:05 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1062017-10-13T13:55:15 <sdaftuar> ;;diff
1072017-10-13T13:55:16 <gribble> 1.123863285132E12
1082017-10-13T13:58:15 <timothy> pbase: yes
1092017-10-13T13:58:52 <pbase> timothy, just delete the wallet.dat on the new computer?
1102017-10-13T13:59:00 <pbase> second computer*
1112017-10-13T14:05:32 *** Guyver2 has joined #bitcoin-core-dev
1122017-10-13T14:10:09 *** Chris_Stewart_5 has quit IRC
1132017-10-13T14:16:02 *** DrOlmer has quit IRC
1142017-10-13T14:31:29 *** Jessyca has joined #bitcoin-core-dev
1152017-10-13T14:32:23 *** alreadylate has quit IRC
1162017-10-13T14:33:22 *** pbase has quit IRC
1172017-10-13T14:34:20 *** BashCo has quit IRC
1182017-10-13T14:36:29 *** promag has joined #bitcoin-core-dev
1192017-10-13T14:54:29 *** Cogito_Ergo_Sum has quit IRC
1202017-10-13T14:54:30 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1212017-10-13T14:57:18 *** rafalcpp has joined #bitcoin-core-dev
1222017-10-13T15:04:01 *** harrymm has quit IRC
1232017-10-13T15:07:38 *** BashCo has joined #bitcoin-core-dev
1242017-10-13T15:14:36 *** jb55 has joined #bitcoin-core-dev
1252017-10-13T15:17:05 *** harrymm has joined #bitcoin-core-dev
1262017-10-13T15:23:43 *** jb55 has quit IRC
1272017-10-13T15:32:26 *** Jessyca has quit IRC
1282017-10-13T15:33:00 <promag> ryanofsky: care to review? ty!
1292017-10-13T15:33:38 *** promag has quit IRC
1302017-10-13T15:35:45 *** dc0de has joined #bitcoin-core-dev
1312017-10-13T15:35:55 *** wraithm has joined #bitcoin-core-dev
1322017-10-13T15:54:01 *** CubicEarth has joined #bitcoin-core-dev
1332017-10-13T15:56:34 <CubicEarth> jonasschnelli: You here?
1342017-10-13T16:09:26 *** rafalcpp has quit IRC
1352017-10-13T16:10:08 *** rafalcpp has joined #bitcoin-core-dev
1362017-10-13T16:13:15 <jnewbery> sipa: what do you think of https://github.com/jnewbery/bitcoin/tree/pr11389.2 ? It's your original approach for #11389 rebased on a commit to pin P2SH to a block height. That seems more palatable than pretending P2SH is a VB deployment.
1372017-10-13T16:13:17 <gribble> https://github.com/bitcoin/bitcoin/issues/11389 | Support having SegWit always active in regtest by sipa · Pull Request #11389 · bitcoin/bitcoin · GitHub
1382017-10-13T16:20:03 <sipa> jnewbery: hmm, that's all that is needed?
1392017-10-13T16:21:22 <sdaftuar> jnewbery's branch looks correct to me (and simpler)
1402017-10-13T16:22:15 *** m8tion has quit IRC
1412017-10-13T16:26:00 *** AaronvanW has quit IRC
1422017-10-13T16:26:35 *** AaronvanW has joined #bitcoin-core-dev
1432017-10-13T16:27:49 <jnewbery> sipa: I believe so - I think the behaviour is equivalent to your change that uses version bits
1442017-10-13T16:28:02 <jnewbery> obviously needs thorough review though
1452017-10-13T16:28:07 <sipa> jnewbery: but not configurable
1462017-10-13T16:28:21 <sipa> i needed to at least modify one unit test
1472017-10-13T16:28:55 *** jb55 has joined #bitcoin-core-dev
1482017-10-13T16:29:33 <jnewbery> sipa: ah yes, you're right
1492017-10-13T16:37:27 <jnewbery> the failing test in miner_tests.cpp is testing that template creation fails when including a P2SH output. I think we can just remove it
1502017-10-13T16:38:24 *** wraithm has quit IRC
1512017-10-13T16:49:57 *** btcdrak has quit IRC
1522017-10-13T16:50:05 *** abpa has joined #bitcoin-core-dev
1532017-10-13T16:51:10 <sipa> jnewbery: fair
1542017-10-13T17:03:55 *** timothy has quit IRC
1552017-10-13T17:22:50 *** Ylbam has joined #bitcoin-core-dev
1562017-10-13T17:31:33 *** Rafael_ has joined #bitcoin-core-dev
1572017-10-13T17:32:49 *** Rafael_ has quit IRC
1582017-10-13T17:39:36 <sdaftuar> is there a reason we should not set fAddnode=true for -connect peers?
1592017-10-13T17:40:08 <sdaftuar> (asking because i am treating addnode peers specially for things like #11490, and it seems like -connect peers should get the same treatment)
1602017-10-13T17:40:10 <gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub
1612017-10-13T17:44:47 <sipa> sdaftuar: when using -connect, the normal connection-creation loop doesm't even run, so i guess that for most things it doesn't matter
1622017-10-13T17:45:06 <sipa> but if it does for 11490, it should probably be changed
1632017-10-13T17:46:01 <gmaxwell> sdaftuar: think it would be fine to addnode.
1642017-10-13T17:46:08 <sdaftuar> ok i'll throw a commit in that sets fAddnode, and if someone comes up with a reason to use a new bool I can switch
1652017-10-13T17:46:11 <sdaftuar> gmaxwell: thanks
1662017-10-13T18:04:40 *** laurentmt has quit IRC
1672017-10-13T18:05:49 *** promag has joined #bitcoin-core-dev
1682017-10-13T18:15:55 *** Cogito_Ergo_Sum has quit IRC
1692017-10-13T18:18:39 *** promag has quit IRC
1702017-10-13T18:38:39 <jnewbery> sipa: it was a bit more complicated than I thought. The miner_test was testing that having an invalid P2SH tx in the mempool would cause template creation to fail. Currently, P2SH is always enabled in the unit tests (because it's activated using system time). Pinning the activation height of P2SH means that P2SH is not active so the test was failing.
1712017-10-13T18:39:16 <jnewbery> Rearranging the ordering of the tests so that the P2SH test only happens after height 210,000 appears to be sufficient to fix it
1722017-10-13T18:41:06 <sipa> cool!
1732017-10-13T18:41:10 <sipa> have a branch?
1742017-10-13T18:41:57 <jnewbery> same branch. Final commit fixes the test
1752017-10-13T18:50:09 *** vicenteH` has joined #bitcoin-core-dev
1762017-10-13T18:51:58 *** vicenteH has quit IRC
1772017-10-13T19:16:46 *** promag has joined #bitcoin-core-dev
1782017-10-13T19:23:10 *** dgenr8 has joined #bitcoin-core-dev
1792017-10-13T19:25:46 <cfields> sdaftuar: fyi #11456 adds that
1802017-10-13T19:25:48 <gribble> https://github.com/bitcoin/bitcoin/issues/11456 | Replace relevant services logic with a function suite. by TheBlueMatt · Pull Request #11456 · bitcoin/bitcoin · GitHub
1812017-10-13T19:26:05 <sdaftuar> ah, haven't reviewed it yet, thanks
1822017-10-13T19:26:21 <cfields> np
1832017-10-13T19:27:08 <BlueMatt> sdaftuar: oh, i thought i mentioned to you i had a pr that changed the definition of fAddnode - I'd recommend you just pull that commit into your pr
1842017-10-13T19:27:50 <sdaftuar> i thought i remember you saying that we should treat connect peers the same as addnode peers, but didn't remember exactly what that entailed. cool, will do
1852017-10-13T19:34:31 <cfields> make sure to take the next one that renames too, to avoid colliding when rebasing
1862017-10-13T19:35:59 *** Cory has quit IRC
1872017-10-13T19:39:45 *** goatpig has quit IRC
1882017-10-13T19:45:58 <gmaxwell> sdaftuar: re your excemption of addnoded peers, I think thats right for now but perhaps not what we want long term.. consider the case where you've configured 20 addnode peers... 8 are connected (per the limits). Two of the eight are forked nodes... you'd probably prefer to drop them and try to replace them with some of your additional configured options.
1892017-10-13T19:46:47 <gmaxwell> so I think the longer term test should be "are my outbound connections of this type full, if not, don't disconnect anything from that type"
1902017-10-13T19:46:49 <sdaftuar> gmaxwell: i thought addnode peers are in addition to our 8 outbound peers nowadays, did i misunderstand?
1912017-10-13T19:47:10 <gmaxwell> yes, there are 8 additional addnode peers.
1922017-10-13T19:47:14 <sdaftuar> oh i see
1932017-10-13T19:47:23 <gmaxwell> (keeps people out of ignorance from addnoding the whole network to their detriment)
1942017-10-13T19:48:04 *** Cory has joined #bitcoin-core-dev
1952017-10-13T19:48:09 <gmaxwell> and in the above the definition of full also means "more to try are available"
1962017-10-13T19:48:23 <gmaxwell> if you have 8 or fewer addnodes configured you should never disconnect one.
1972017-10-13T19:48:47 <gmaxwell> in any case, I don't think we need to be smarter now.
1982017-10-13T19:49:11 <sdaftuar> i'm struggling a little to come up with an outbound peer evicter that kicks in when we haven't advanced our tip in a long time
1992017-10-13T19:49:17 <sdaftuar> it seems like that logic wants to live in net.cpp
2002017-10-13T19:49:40 <sipa> sdaftuar: net shouldn't know about a 'tip'
2012017-10-13T19:50:04 <sdaftuar> yeah i know... i think net_processing would fill in information, but net is the best place to look at your set of peers, i think?
2022017-10-13T19:50:11 <sdaftuar> like we do for inbound peer eviction
2032017-10-13T19:50:25 <sipa> right, it's a bit fuzzy for now
2042017-10-13T19:51:59 *** meshcollider has joined #bitcoin-core-dev
2052017-10-13T19:53:54 <cfields> sdaftuar: that set of peers is moving out, but it's not clear how we're going to accomplish that
2062017-10-13T19:54:50 <sipa> sdaftuar: i think eventually all the information that we'd use to determine who to evict will live in net_processing, apart perhaps from connection uptime (which it could easily query net for)
2072017-10-13T19:55:04 <cfields> sdaftuar: ideally, PeerLogicValidation (needs rename) holds a vector of CNodeState. But there are lots of locking issues to get through before we get there :(
2082017-10-13T19:55:38 <cfields> (the idea being that if you want to do something for each peer, you look there, rather than the CNodes in net)
2092017-10-13T19:56:01 <cfields> yes, what sipa said too
2102017-10-13T19:56:18 <sdaftuar> the thing i'm trying to do now is look at my set of outbound peers, pick the worst of them under some metric, and disconnect it -- but only if i'm full and am using up all my outbound slots
2112017-10-13T19:56:30 <sdaftuar> it doesn't seem easy to determine the last thing from net_processing
2122017-10-13T19:56:42 <sdaftuar> but the metric uses data that only net_processing knows
2132017-10-13T19:57:45 <cfields> sdaftuar: you can use a ForEachNode. That was kinda meant to be a stop-gap for stuff like this until it's all moved out.
2142017-10-13T19:57:58 <BlueMatt> sdaftuar: I think in that case you should prefer to add new state to CNodeState/net_processing.cpp static
2152017-10-13T19:58:11 <BlueMatt> (net_processing.cpp static will probably all eventually move into PeerLogicValidation as it gets renamed)
2162017-10-13T19:58:58 <sdaftuar> i think i need to expose ConnMan's nMaxOutbound in order to do this outside of net -- does that seem ok?
2172017-10-13T19:59:28 <BlueMatt> why is that not a #define anymore :(
2182017-10-13T20:00:58 <cfields> so that we can test changes exactly like this one :)
2192017-10-13T20:15:03 <cfields> sdaftuar: how about testing each node and marking exactly 1 at a time as preferred for eviction? Then the connection loop can check for !outgoing_full || outgoing_full-1 && have_evictable ?
2202017-10-13T20:16:11 <cfields> er, that logic's all busted but you get the point :)
2212017-10-13T20:16:40 <sdaftuar> ah, i think i like that
2222017-10-13T20:16:50 <sdaftuar> thanks, i'll give that a try!
2232017-10-13T20:16:56 <cfields> np
2242017-10-13T20:24:27 *** moctos has quit IRC
2252017-10-13T20:26:50 *** promag has quit IRC
2262017-10-13T20:32:38 *** wxss_ has joined #bitcoin-core-dev
2272017-10-13T20:32:46 *** maaku has left #bitcoin-core-dev
2282017-10-13T20:33:00 *** mess110 has joined #bitcoin-core-dev
2292017-10-13T20:34:47 *** wxss has quit IRC
2302017-10-13T20:35:00 *** wxss_ is now known as wxss
2312017-10-13T20:46:44 *** Cheeseo has quit IRC
2322017-10-13T20:57:12 *** promag has joined #bitcoin-core-dev
2332017-10-13T20:59:25 *** Cheeseo has joined #bitcoin-core-dev
2342017-10-13T21:00:59 *** cheese_ has joined #bitcoin-core-dev
2352017-10-13T21:04:15 *** Cheeseo has quit IRC
2362017-10-13T21:12:12 *** PaulCapestany has joined #bitcoin-core-dev
2372017-10-13T21:29:45 *** Guyver2 has quit IRC
2382017-10-13T21:29:55 *** thierry has joined #bitcoin-core-dev
2392017-10-13T21:30:09 <bitcoin-git> [bitcoin] jnewbery opened pull request #11495: [trivial] Make namespace explicit for is_regular_file (master...explicit_is_regular_file) https://github.com/bitcoin/bitcoin/pull/11495
2402017-10-13T21:31:01 *** thierry has quit IRC
2412017-10-13T21:49:27 *** jb55 has quit IRC
2422017-10-13T22:01:01 *** jb55 has joined #bitcoin-core-dev
2432017-10-13T22:20:45 *** promag has quit IRC
2442017-10-13T22:23:46 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/424be0330514...8c2de827e988
2452017-10-13T22:23:47 <bitcoin-git> bitcoin/master c77170f Jonas Schnelli: [Wallet] add rescanblockchain <start_height> <stop_height> RPC command
2462017-10-13T22:23:47 <bitcoin-git> bitcoin/master 7a91ceb Jonas Schnelli: [QA] Add RPC based rescan test
2472017-10-13T22:23:48 <bitcoin-git> bitcoin/master 8c2de82 Jonas Schnelli: Merge #7061: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"...
2482017-10-13T22:25:35 <meshcollider> \o?
2492017-10-13T22:25:42 <meshcollider> \o/ * lol
2502017-10-13T22:26:29 *** promag has joined #bitcoin-core-dev
2512017-10-13T22:27:26 <promag> \o/
2522017-10-13T22:28:32 *** abpa has quit IRC
2532017-10-13T22:30:38 <jonasschnelli> [15:25:33] <meshcollider> \o? <--- do you have a pirate hook arm?
2542017-10-13T22:31:09 <sipa> jonasschnelli: lol
2552017-10-13T22:31:28 <sipa> \orrrrrr
2562017-10-13T22:31:44 <bitcoin-git> [bitcoin] sipa pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c2de827e988...326a5652e0d2
2572017-10-13T22:31:45 <bitcoin-git> bitcoin/master 4440710 Matt Corallo: Replace relevant services logic with a function suite....
2582017-10-13T22:31:46 <bitcoin-git> bitcoin/master 57edc0b Matt Corallo: Rename fAddnode to a more-descriptive "manual_connection"
2592017-10-13T22:31:46 <bitcoin-git> bitcoin/master 5ee88b4 Matt Corallo: Clarify docs for requirements/handling of addnode/connect nodes
2602017-10-13T22:32:20 <bitcoin-git> [bitcoin] sipa closed pull request #11456: Replace relevant services logic with a function suite. (master...2017-09-service-flags-cleanups) https://github.com/bitcoin/bitcoin/pull/11456
2612017-10-13T22:32:21 <BlueMatt> \o/
2622017-10-13T22:33:20 *** ula has joined #bitcoin-core-dev
2632017-10-13T22:33:37 <meshcollider> jonasschnelli: lol yep that's it ;)
2642017-10-13T22:34:18 <jonasschnelli> Great,... 11456 is also merged.. time to review it. :)
2652017-10-13T22:35:07 <jonasschnelli> BlueMatt: I guess https://github.com/TheBlueMatt/bitcoin/commit/2017-09-service-flags-cleanups is now outdated for the NODE_NETWORK_LIMITED PR?
2662017-10-13T22:36:25 *** abpa has joined #bitcoin-core-dev
2672017-10-13T22:37:47 <BlueMatt> hmm?
2682017-10-13T22:37:56 <promag> mergefest? there you go #11006
2692017-10-13T22:37:58 <gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
2702017-10-13T22:38:53 <jonasschnelli> BlueMatt: is your comment (https://github.com/bitcoin/bitcoin/pull/10387#issuecomment-334490761) still relevant after a rebase with #v
2712017-10-13T22:38:56 <jonasschnelli> #11456
2722017-10-13T22:38:58 <gribble> https://github.com/bitcoin/bitcoin/issues/11456 | Replace relevant services logic with a function suite. by TheBlueMatt · Pull Request #11456 · bitcoin/bitcoin · GitHub
2732017-10-13T22:39:20 <jonasschnelli> promag, 11006 needs some acks first
2742017-10-13T22:39:28 <promag> oh :(
2752017-10-13T22:40:26 <BlueMatt> jonasschnelli: no?
2762017-10-13T22:40:33 <BlueMatt> thats the same branch that made the pr and got merged
2772017-10-13T22:40:40 <BlueMatt> so...I mean yes, but equally valid if you rebase on master?
2782017-10-13T22:41:01 <jonasschnelli> Okay... haven't checked... just arrived back in civilisation. Will take a closer look
2792017-10-13T22:43:00 *** promag has quit IRC
2802017-10-13T22:56:34 *** promag has joined #bitcoin-core-dev
2812017-10-13T23:02:13 *** promag has quit IRC
2822017-10-13T23:07:41 *** dc0de has quit IRC
2832017-10-13T23:23:02 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2842017-10-13T23:25:03 *** comboy has quit IRC
2852017-10-13T23:29:16 *** wasi has quit IRC
2862017-10-13T23:31:35 *** comboy has joined #bitcoin-core-dev
2872017-10-13T23:38:00 <bitcoin-git> [bitcoin] MeshCollider opened pull request #11496: [Trivial] Add missing comma from rescanblockchain example (master...201710_missing_comma) https://github.com/bitcoin/bitcoin/pull/11496
2882017-10-13T23:38:08 *** jb55 has quit IRC
2892017-10-13T23:39:22 *** jb55 has joined #bitcoin-core-dev
2902017-10-13T23:40:25 *** wxss has quit IRC
2912017-10-13T23:41:57 *** wasi has joined #bitcoin-core-dev
2922017-10-13T23:44:56 *** Deacydal has quit IRC