1 2017-10-17T00:14:28 *** jb55 has quit IRC
2 2017-10-17T00:15:19 *** vicenteH has quit IRC
3 2017-10-17T00:15:27 *** vicenteH has joined #bitcoin-core-dev
4 2017-10-17T00:33:53 *** Ylbam has quit IRC
5 2017-10-17T00:36:11 *** [Author] has quit IRC
6 2017-10-17T00:38:56 *** [Author] has joined #bitcoin-core-dev
7 2017-10-17T00:42:09 *** wumpus has quit IRC
8 2017-10-17T00:47:58 *** rafalcpp_ has joined #bitcoin-core-dev
9 2017-10-17T00:48:11 *** [Author] has quit IRC
10 2017-10-17T00:48:26 *** rafalcpp has quit IRC
11 2017-10-17T00:51:00 *** [Author] has joined #bitcoin-core-dev
12 2017-10-17T00:53:23 *** jb55 has joined #bitcoin-core-dev
13 2017-10-17T00:55:53 *** kiswe has joined #bitcoin-core-dev
14 2017-10-17T00:55:54 *** kiswe has left #bitcoin-core-dev
15 2017-10-17T00:56:43 *** wumpus has joined #bitcoin-core-dev
16 2017-10-17T00:56:50 *** promag has quit IRC
17 2017-10-17T00:57:50 *** dabura667 has joined #bitcoin-core-dev
18 2017-10-17T01:02:41 *** AaronvanW has quit IRC
19 2017-10-17T01:03:35 *** jb55 has quit IRC
20 2017-10-17T01:04:48 *** rafalcpp_ has quit IRC
21 2017-10-17T01:05:32 *** rafalcpp_ has joined #bitcoin-core-dev
22 2017-10-17T01:09:15 *** jb55 has joined #bitcoin-core-dev
23 2017-10-17T01:12:59 *** [Author] has quit IRC
24 2017-10-17T01:13:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
25 2017-10-17T01:18:08 *** [Author] has joined #bitcoin-core-dev
26 2017-10-17T01:19:07 *** Chris_Stewart_5 has quit IRC
27 2017-10-17T01:24:55 *** btcdrak has joined #bitcoin-core-dev
28 2017-10-17T01:26:37 *** BashCo_ has joined #bitcoin-core-dev
29 2017-10-17T01:26:57 *** BashCo has quit IRC
30 2017-10-17T01:27:24 *** [Author] has quit IRC
31 2017-10-17T01:29:32 *** [Author] has joined #bitcoin-core-dev
32 2017-10-17T01:42:35 *** dabura667 has quit IRC
33 2017-10-17T01:49:54 *** deikiyoch has joined #bitcoin-core-dev
34 2017-10-17T01:49:55 *** deikiyoch has left #bitcoin-core-dev
35 2017-10-17T01:53:08 *** dabura667 has joined #bitcoin-core-dev
36 2017-10-17T02:01:07 *** dabura667 has quit IRC
37 2017-10-17T02:05:18 *** rafalcpp_ has quit IRC
38 2017-10-17T02:06:03 *** rafalcpp_ has joined #bitcoin-core-dev
39 2017-10-17T02:07:48 <bitcoin-git> [bitcoin] jnewbery opened pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513
40 2017-10-17T02:09:03 *** JackH has quit IRC
41 2017-10-17T02:18:01 *** wxss has quit IRC
42 2017-10-17T02:22:53 *** dabura667 has joined #bitcoin-core-dev
43 2017-10-17T02:25:32 *** owowo has quit IRC
44 2017-10-17T02:30:02 *** owowo has joined #bitcoin-core-dev
45 2017-10-17T02:30:03 *** owowo has joined #bitcoin-core-dev
46 2017-10-17T02:53:32 *** jb55 has quit IRC
47 2017-10-17T03:08:39 *** rafalcpp_ has quit IRC
48 2017-10-17T03:09:24 *** rafalcpp_ has joined #bitcoin-core-dev
49 2017-10-17T03:14:20 *** eck has quit IRC
50 2017-10-17T03:14:58 *** eck has joined #bitcoin-core-dev
51 2017-10-17T03:17:06 *** dabura667 has quit IRC
52 2017-10-17T03:25:26 *** jb55 has joined #bitcoin-core-dev
53 2017-10-17T03:26:36 *** [Author] has quit IRC
54 2017-10-17T03:53:19 *** [Author] has joined #bitcoin-core-dev
55 2017-10-17T03:56:24 *** rafalcpp__ has joined #bitcoin-core-dev
56 2017-10-17T03:56:32 *** rafalcpp_ has quit IRC
57 2017-10-17T03:58:36 *** [Author] has quit IRC
58 2017-10-17T04:02:39 *** rafalcpp__ has quit IRC
59 2017-10-17T04:03:29 *** [Author] has joined #bitcoin-core-dev
60 2017-10-17T04:03:56 *** rafalcpp__ has joined #bitcoin-core-dev
61 2017-10-17T04:05:51 *** Apocalyptic has quit IRC
62 2017-10-17T04:08:10 *** Apocalyptic has joined #bitcoin-core-dev
63 2017-10-17T04:20:27 *** jb55 has quit IRC
64 2017-10-17T04:26:21 *** rafalcpp__ has quit IRC
65 2017-10-17T04:27:06 *** rafalcpp__ has joined #bitcoin-core-dev
66 2017-10-17T04:47:29 *** rafalcpp__ has quit IRC
67 2017-10-17T04:49:30 *** rafalcpp has joined #bitcoin-core-dev
68 2017-10-17T04:58:46 *** shesek has joined #bitcoin-core-dev
69 2017-10-17T05:07:45 *** harrymm_ has quit IRC
70 2017-10-17T05:21:16 *** harrymm_ has joined #bitcoin-core-dev
71 2017-10-17T05:23:58 *** Ylbam has joined #bitcoin-core-dev
72 2017-10-17T05:24:34 *** rafalcpp has quit IRC
73 2017-10-17T05:25:20 *** rafalcpp has joined #bitcoin-core-dev
74 2017-10-17T05:33:44 *** rafalcpp has quit IRC
75 2017-10-17T05:34:28 *** rafalcpp has joined #bitcoin-core-dev
76 2017-10-17T05:49:07 *** Emcy has quit IRC
77 2017-10-17T06:11:23 *** dermoth has quit IRC
78 2017-10-17T06:11:45 *** dermoth has joined #bitcoin-core-dev
79 2017-10-17T06:14:35 *** Emcy has joined #bitcoin-core-dev
80 2017-10-17T06:54:09 *** BashCo_ has quit IRC
81 2017-10-17T07:05:02 *** alreadylate has joined #bitcoin-core-dev
82 2017-10-17T07:14:21 *** dgenr8 has quit IRC
83 2017-10-17T07:15:22 *** dgenr8 has joined #bitcoin-core-dev
84 2017-10-17T07:16:23 *** BashCo has joined #bitcoin-core-dev
85 2017-10-17T07:18:55 *** harrymm_ has quit IRC
86 2017-10-17T07:20:01 *** dgenr8 has quit IRC
87 2017-10-17T07:20:21 *** alreadylate has quit IRC
88 2017-10-17T07:20:23 *** dabura667 has joined #bitcoin-core-dev
89 2017-10-17T07:20:27 *** dgenr8 has joined #bitcoin-core-dev
90 2017-10-17T07:21:18 *** alreadylate has joined #bitcoin-core-dev
91 2017-10-17T07:24:22 *** AaronvanW has joined #bitcoin-core-dev
92 2017-10-17T07:25:18 *** dermoth has quit IRC
93 2017-10-17T07:25:44 *** dermoth has joined #bitcoin-core-dev
94 2017-10-17T07:28:18 *** Emcy has quit IRC
95 2017-10-17T07:28:21 *** laurentmt has joined #bitcoin-core-dev
96 2017-10-17T07:29:03 *** Aaronvan_ has joined #bitcoin-core-dev
97 2017-10-17T07:32:07 *** harrymm_ has joined #bitcoin-core-dev
98 2017-10-17T07:32:42 *** AaronvanW has quit IRC
99 2017-10-17T07:36:20 *** Guyver2 has joined #bitcoin-core-dev
100 2017-10-17T07:42:27 *** AaronvanW has joined #bitcoin-core-dev
101 2017-10-17T07:44:12 *** goatpig has joined #bitcoin-core-dev
102 2017-10-17T07:44:46 *** Aaronvan_ has quit IRC
103 2017-10-17T07:47:08 *** sybarite has joined #bitcoin-core-dev
104 2017-10-17T07:52:08 *** ula has quit IRC
105 2017-10-17T07:54:37 *** [Author] has quit IRC
106 2017-10-17T08:03:37 *** Aaronvan_ has joined #bitcoin-core-dev
107 2017-10-17T08:03:39 *** btcdrak has quit IRC
108 2017-10-17T08:05:41 *** AaronvanW has quit IRC
109 2017-10-17T08:09:30 *** Emcy has joined #bitcoin-core-dev
110 2017-10-17T08:09:49 *** intcat has quit IRC
111 2017-10-17T08:25:42 *** intcat has joined #bitcoin-core-dev
112 2017-10-17T08:29:04 *** promag has joined #bitcoin-core-dev
113 2017-10-17T08:32:46 *** promag has quit IRC
114 2017-10-17T08:34:47 *** timothy has joined #bitcoin-core-dev
115 2017-10-17T08:38:26 *** [Author] has joined #bitcoin-core-dev
116 2017-10-17T08:38:35 *** Deckard has joined #bitcoin-core-dev
117 2017-10-17T08:39:54 *** Deckard has left #bitcoin-core-dev
118 2017-10-17T08:41:59 *** shesek has quit IRC
119 2017-10-17T08:45:57 *** TheLive1 has left #bitcoin-core-dev
120 2017-10-17T08:55:00 *** Ylbam has quit IRC
121 2017-10-17T08:55:44 *** alreadylate has quit IRC
122 2017-10-17T09:39:48 *** alreadylate has joined #bitcoin-core-dev
123 2017-10-17T09:40:57 *** alreadylate has quit IRC
124 2017-10-17T09:41:59 *** alreadylate has joined #bitcoin-core-dev
125 2017-10-17T09:44:47 *** oakley91 has quit IRC
126 2017-10-17T09:57:50 *** Emcy has quit IRC
127 2017-10-17T09:58:36 *** Emcy has joined #bitcoin-core-dev
128 2017-10-17T10:20:11 *** Guyver2 has quit IRC
129 2017-10-17T10:25:57 *** musalbas has quit IRC
130 2017-10-17T10:27:07 *** dabura667 has quit IRC
131 2017-10-17T10:35:06 *** jb55 has joined #bitcoin-core-dev
132 2017-10-17T10:45:22 *** jtimon has joined #bitcoin-core-dev
133 2017-10-17T10:50:41 *** jtimon has quit IRC
134 2017-10-17T11:02:41 *** AaronvanW has joined #bitcoin-core-dev
135 2017-10-17T11:05:02 *** jtimon has joined #bitcoin-core-dev
136 2017-10-17T11:06:13 *** Aaronvan_ has quit IRC
137 2017-10-17T11:10:59 *** Emcy has quit IRC
138 2017-10-17T11:11:15 *** Emcy has joined #bitcoin-core-dev
139 2017-10-17T11:24:31 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
140 2017-10-17T11:24:32 *** Cogito_Ergo_Sum has quit IRC
141 2017-10-17T11:24:32 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
142 2017-10-17T11:32:32 *** ula has joined #bitcoin-core-dev
143 2017-10-17T11:37:14 *** SopaXorzTaker has joined #bitcoin-core-dev
144 2017-10-17T11:40:35 *** jtimon has quit IRC
145 2017-10-17T12:04:08 *** jtimon has joined #bitcoin-core-dev
146 2017-10-17T12:15:08 *** reds-stripe has joined #bitcoin-core-dev
147 2017-10-17T12:17:02 *** Emcy has quit IRC
148 2017-10-17T12:17:21 *** Emcy has joined #bitcoin-core-dev
149 2017-10-17T12:21:14 *** Emcy has quit IRC
150 2017-10-17T12:21:51 *** Emcy has joined #bitcoin-core-dev
151 2017-10-17T12:24:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
152 2017-10-17T12:26:06 *** rafalcpp has quit IRC
153 2017-10-17T12:26:44 <aj> jtimon: re: getblockstats rpc tests, aren't tx sizes non-deterministic due to the signatures sometimes being a byte short due to a leading \x00 getting skipped due to DER encoding?
154 2017-10-17T12:30:39 *** intcat has quit IRC
155 2017-10-17T12:31:35 *** intcat has joined #bitcoin-core-dev
156 2017-10-17T12:32:42 <jtimon> aj: oh, right, that must be it...
157 2017-10-17T12:33:19 <jtimon> isn't there a way to solve that?
158 2017-10-17T12:34:14 *** Banzai10 has joined #bitcoin-core-dev
159 2017-10-17T12:39:45 <sipa> aj: how does thatmake them nondeterministic?
160 2017-10-17T12:39:53 <sipa> DER is deterministic
161 2017-10-17T12:42:16 *** BashCo has quit IRC
162 2017-10-17T12:52:49 <sipa> or you mean the low-S malleability?
163 2017-10-17T12:57:47 *** wxss has joined #bitcoin-core-dev
164 2017-10-17T13:04:20 *** promag has joined #bitcoin-core-dev
165 2017-10-17T13:11:16 <gmaxwell> sipa: I think he thinks the signature is non-determinstic?
166 2017-10-17T13:17:37 *** alreadylate has quit IRC
167 2017-10-17T13:20:59 *** BashCo has joined #bitcoin-core-dev
168 2017-10-17T13:22:47 *** Chris_Stewart_5 has quit IRC
169 2017-10-17T13:23:36 *** promag has quit IRC
170 2017-10-17T13:27:20 *** promag has joined #bitcoin-core-dev
171 2017-10-17T13:29:43 *** promag has quit IRC
172 2017-10-17T13:29:52 <aj> sipa: running the same test case repeatedly doesn't generate the same R each time does it?
173 2017-10-17T13:30:17 <gmaxwell> it will if the transaction is the same.
174 2017-10-17T13:30:33 <gmaxwell> (and key)
175 2017-10-17T13:32:06 <aj> context is https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-337212106 fwiw
176 2017-10-17T13:32:59 *** promag has joined #bitcoin-core-dev
177 2017-10-17T13:34:25 *** alreadylate has joined #bitcoin-core-dev
178 2017-10-17T13:37:37 *** roadcrap has quit IRC
179 2017-10-17T13:37:59 <sipa> aj: you can always choose to create a tx with a larger or smaller sig
180 2017-10-17T13:38:04 <sipa> by grinding
181 2017-10-17T13:38:24 *** jtimon has quit IRC
182 2017-10-17T13:38:51 <sipa> but if you have an actual tx, the serialization of that sig is fixed
183 2017-10-17T13:39:02 *** jtimon has joined #bitcoin-core-dev
184 2017-10-17T13:41:07 <aj> sipa: ack. but the test suite doesn't ensure it produces a deterministic chain, so txes will vary between test suite runs, yes/no?
185 2017-10-17T13:42:43 <sipa> no, our own signing is deterministic
186 2017-10-17T13:42:47 *** esotericnonsense has quit IRC
187 2017-10-17T13:43:17 <sipa> you can't assume that other's signatures are - but the ones we create ourselves are
188 2017-10-17T13:43:46 *** jtimon has quit IRC
189 2017-10-17T13:43:50 *** Chris_Stewart_5 has joined #bitcoin-core-dev
190 2017-10-17T13:47:18 *** jtimon has joined #bitcoin-core-dev
191 2017-10-17T13:53:37 *** jtimon has quit IRC
192 2017-10-17T13:53:46 *** jtimon_ has joined #bitcoin-core-dev
193 2017-10-17T13:56:02 *** alreadylate has quit IRC
194 2017-10-17T14:02:45 <aj> sipa: okay, again, correct me if i'm wrong, but i'm seeing "self.nodes[0].getnewaddress()" giving different results between test_runner.py invocations, which (even despite deterministic signing) should result in non-deterministic tx sizes aiui
195 2017-10-17T14:03:14 <sipa> aj: oh, sure
196 2017-10-17T14:03:19 <sipa> if the the transaction isn't the same
197 2017-10-17T14:03:45 *** jtimon_ has quit IRC
198 2017-10-17T14:03:54 *** jtimon has joined #bitcoin-core-dev
199 2017-10-17T14:04:37 <aj> sipa: yeah. i wasn't following whether the implication was that there was meant to be deterministic generation of addresses/chains to have the test suite results be deterministic
200 2017-10-17T14:04:47 *** reds-stripe has quit IRC
201 2017-10-17T14:05:15 <sipa> aj: i just read some more context of the discussion, i wasn't aware you were talking about entire tests being deterministic
202 2017-10-17T14:06:04 *** d_p has quit IRC
203 2017-10-17T14:08:17 <bitcoin-git> [bitcoin] promag opened pull request #11514: Iterate and remove nodes without container copy (master...201710-node-iterate-and-erase) https://github.com/bitcoin/bitcoin/pull/11514
204 2017-10-17T14:11:00 *** wasi has quit IRC
205 2017-10-17T14:11:09 <bitcoin-git> [bitcoin] promag opened pull request #11515: Assert cs_main is held when retrieving node state (master...201710-node-state-guard) https://github.com/bitcoin/bitcoin/pull/11515
206 2017-10-17T14:12:07 *** shesek has joined #bitcoin-core-dev
207 2017-10-17T14:12:08 *** shesek has joined #bitcoin-core-dev
208 2017-10-17T14:12:24 *** d_p has joined #bitcoin-core-dev
209 2017-10-17T14:12:43 *** meshcollider has quit IRC
210 2017-10-17T14:15:05 *** jtimon has quit IRC
211 2017-10-17T14:16:27 *** promag has quit IRC
212 2017-10-17T14:22:01 *** Emcy has quit IRC
213 2017-10-17T14:22:32 *** Emcy has joined #bitcoin-core-dev
214 2017-10-17T14:30:02 *** shesek has quit IRC
215 2017-10-17T14:33:07 *** clarkmoody has quit IRC
216 2017-10-17T14:35:25 *** Cogito_Ergo_Sum has quit IRC
217 2017-10-17T14:36:05 *** sybarite has quit IRC
218 2017-10-17T14:45:02 <bitcoin-git> [bitcoin] practicalswift opened pull request #11516: crypto: Avoid creating of one-past-the-end pointer and performing a noop memset call (HMAC-SHA{256,512}) (master...one-past-the-end) https://github.com/bitcoin/bitcoin/pull/11516
219 2017-10-17T14:56:35 <bitcoin-git> [bitcoin] simonmulser closed pull request #11510: Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER (master...add_log) https://github.com/bitcoin/bitcoin/pull/11510
220 2017-10-17T15:35:59 *** Chris_Stewart_5 has quit IRC
221 2017-10-17T15:38:58 *** pedrobranco has joined #bitcoin-core-dev
222 2017-10-17T15:42:51 <pedrobranco> Hello, any change of getting https://github.com/bitcoin/bitcoin/pull/11483 merged soon since it's a bug in importmulti?
223 2017-10-17T15:57:32 *** Dizzle has joined #bitcoin-core-dev
224 2017-10-17T16:08:45 <jonasschnelli> pedrobranco: Needs more reviews first..
225 2017-10-17T16:08:59 <jonasschnelli> Is it something we want to backport, right?
226 2017-10-17T16:21:33 <pedrobranco> jonasschnelli: Yes it needs more reviews.
227 2017-10-17T16:29:02 <bitcoin-git> [bitcoin] martinus opened pull request #11517: Tests: Improve benchmark precision by inlining performance critical code (master...improved-benchmarking) https://github.com/bitcoin/bitcoin/pull/11517
228 2017-10-17T16:33:01 <jonasschnelli> pedrobranco: I guess another one and we'll be fine. Its a simple change
229 2017-10-17T16:44:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
230 2017-10-17T16:59:11 *** timothy has quit IRC
231 2017-10-17T17:03:22 *** Banzai10 has quit IRC
232 2017-10-17T17:04:03 *** mess110 has joined #bitcoin-core-dev
233 2017-10-17T17:07:02 <pedrobranco> jonasschnelli: ty
234 2017-10-17T17:09:43 *** mmgen has joined #bitcoin-core-dev
235 2017-10-17T17:12:09 *** Ylbam has joined #bitcoin-core-dev
236 2017-10-17T17:15:39 *** pedrobranco has quit IRC
237 2017-10-17T17:15:47 *** pedrobranco has joined #bitcoin-core-dev
238 2017-10-17T17:22:50 *** Emcy has quit IRC
239 2017-10-17T17:25:00 *** mmgen has quit IRC
240 2017-10-17T17:25:01 *** intcat has quit IRC
241 2017-10-17T17:25:01 *** dermoth has quit IRC
242 2017-10-17T17:25:32 *** d_p has quit IRC
243 2017-10-17T17:25:33 *** arubi has quit IRC
244 2017-10-17T17:28:03 <BlueMatt> #11483 could get a merge, imo, dunno if anyone merging is around today, though
245 2017-10-17T17:28:05 <gribble> https://github.com/bitcoin/bitcoin/issues/11483 | Fix importmulti bug when importing an already imported key by pedrobranco · Pull Request #11483 · bitcoin/bitcoin · GitHub
246 2017-10-17T17:29:44 *** Aaronvan_ has joined #bitcoin-core-dev
247 2017-10-17T17:32:41 *** AaronvanW has quit IRC
248 2017-10-17T17:33:17 *** AaronvanW has joined #bitcoin-core-dev
249 2017-10-17T17:34:18 *** tripleslash has quit IRC
250 2017-10-17T17:34:25 *** Aaronvan_ has joined #bitcoin-core-dev
251 2017-10-17T17:37:23 *** laurentmt has quit IRC
252 2017-10-17T17:37:35 *** AaronvanW has quit IRC
253 2017-10-17T17:39:10 <mess110> hi, working on adding a proxy icon, wanted to ask for feedback.
254 2017-10-17T17:39:15 <mess110> do you think this icon https://ibb.co/eP9mGR is better than https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png ?
255 2017-10-17T17:39:19 <mess110> it is made out of chevron-left and 3 device-desktop from http://s-ings.com/typicons/
256 2017-10-17T17:46:04 *** arubi has joined #bitcoin-core-dev
257 2017-10-17T17:48:18 *** d_p_ has joined #bitcoin-core-dev
258 2017-10-17T17:53:40 *** intcat has joined #bitcoin-core-dev
259 2017-10-17T17:54:00 *** Aaronvan_ is now known as AaronvanW
260 2017-10-17T18:01:53 *** SopaXorzTaker has quit IRC
261 2017-10-17T18:04:49 *** meshcollider has joined #bitcoin-core-dev
262 2017-10-17T18:04:55 *** pedrobranco has quit IRC
263 2017-10-17T18:26:05 *** mess110 has quit IRC
264 2017-10-17T18:41:12 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
265 2017-10-17T18:41:12 *** Cogito_Ergo_Sum has quit IRC
266 2017-10-17T18:41:12 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
267 2017-10-17T18:42:31 *** pergaminho has joined #bitcoin-core-dev
268 2017-10-17T19:07:24 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c66cea2d186...14b860bf6402
269 2017-10-17T19:07:25 <bitcoin-git> bitcoin/master fc0176d John Newbery: [tests] use python3 for authproxy.py
270 2017-10-17T19:07:25 <bitcoin-git> bitcoin/master 323d8f6 John Newbery: [tests] fix flake8 warnings in authproxy.py
271 2017-10-17T19:07:26 <bitcoin-git> bitcoin/master 8f9e362 John Newbery: [tests] authproxy.py: tidy up __init__()
272 2017-10-17T19:08:00 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513
273 2017-10-17T19:38:39 *** laurentmt has joined #bitcoin-core-dev
274 2017-10-17T19:44:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/14b860bf6402...808c84f89d0e
275 2017-10-17T19:44:36 <bitcoin-git> bitcoin/master a44a215 Pedro Branco: Fix importmulti bug when importing an already imported key
276 2017-10-17T19:44:37 <bitcoin-git> bitcoin/master 808c84f MarcoFalke: Merge #11483: Fix importmulti bug when importing an already imported key...
277 2017-10-17T19:45:05 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483
278 2017-10-17T19:46:48 *** roadcrap has joined #bitcoin-core-dev
279 2017-10-17T19:47:06 *** mess110 has joined #bitcoin-core-dev
280 2017-10-17T19:47:22 *** mmgen has joined #bitcoin-core-dev
281 2017-10-17T19:53:27 *** musalbas has joined #bitcoin-core-dev
282 2017-10-17T19:56:33 *** Guyver2 has joined #bitcoin-core-dev
283 2017-10-17T20:01:16 *** pergaminho has quit IRC
284 2017-10-17T20:03:59 *** PaulCapestany has quit IRC
285 2017-10-17T20:06:47 *** PaulCapestany has joined #bitcoin-core-dev
286 2017-10-17T20:10:45 <cfields> sipa: i forget your preference. You like a github review (batch), or individual comments?
287 2017-10-17T20:17:50 *** chjj has quit IRC
288 2017-10-17T20:21:30 <BlueMatt> cfields: for the sake of (most peoples') inbox, batch
289 2017-10-17T20:23:19 <cfields> heh, fair enough. iirc someone complained about the batches because it screwed up their workflow.
290 2017-10-17T20:23:32 <cfields> hmm, maybe that was you, with your online/offline split?
291 2017-10-17T20:26:01 *** Cheeseo has joined #bitcoin-core-dev
292 2017-10-17T20:31:03 *** Giszmo has quit IRC
293 2017-10-17T20:34:45 *** laurentmt has quit IRC
294 2017-10-17T20:35:22 *** pergaminho has joined #bitcoin-core-dev
295 2017-10-17T20:39:38 <sdaftuar> cfields: i'm thinking about adding a way to mock out addrman for the purposes of regtest-testing our outbound peer logic. does that sound like a reasonable thing to do?
296 2017-10-17T20:40:10 <cfields> sdaftuar: yep! I've already got it halfway done, though...
297 2017-10-17T20:40:19 <sdaftuar> oh, cool
298 2017-10-17T20:40:29 <sdaftuar> any chance you have a commit i can steal then? :)
299 2017-10-17T20:40:45 <cfields> heh, it's just waiting on #11457
300 2017-10-17T20:40:47 <gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
301 2017-10-17T20:40:55 <cfields> sure
302 2017-10-17T20:41:08 <cfields> it's broken out the same way
303 2017-10-17T20:42:26 <cfields> sdaftuar: will push it up tonight, need to clean up/rebase
304 2017-10-17T20:42:43 <sdaftuar> cool, thanks. i'll takea look at 11457
305 2017-10-17T20:46:43 *** karelb has quit IRC
306 2017-10-17T20:48:10 <bitcoin-git> [bitcoin] jnewbery opened pull request #11518: [WIP] [tests] Simplify/clarify the NodeConn/NodeConnCB mininode classes (master...node_conn_big_refactor) https://github.com/bitcoin/bitcoin/pull/11518
307 2017-10-17T20:50:05 *** roadcrap has quit IRC
308 2017-10-17T21:00:10 *** lightningbot has joined #bitcoin-core-dev
309 2017-10-17T21:02:00 *** goatpig has quit IRC
310 2017-10-17T21:02:19 *** LeMiner has quit IRC
311 2017-10-17T21:02:57 *** laurentmt has joined #bitcoin-core-dev
312 2017-10-17T21:03:36 *** LeMiner has joined #bitcoin-core-dev
313 2017-10-17T21:06:39 *** Chris_Stewart_5 has quit IRC
314 2017-10-17T21:11:49 *** promag has joined #bitcoin-core-dev
315 2017-10-17T21:14:56 *** jb55 has quit IRC
316 2017-10-17T21:19:16 *** victorSN has quit IRC
317 2017-10-17T21:21:03 *** laurentmt has quit IRC
318 2017-10-17T21:23:13 *** jb55 has joined #bitcoin-core-dev
319 2017-10-17T21:29:27 *** jb55 has quit IRC
320 2017-10-17T21:31:05 *** pergaminho has quit IRC
321 2017-10-17T21:33:00 *** d_p_ has quit IRC
322 2017-10-17T21:35:54 *** chjj has joined #bitcoin-core-dev
323 2017-10-17T21:38:06 *** d_p has joined #bitcoin-core-dev
324 2017-10-17T21:43:51 *** Cheeseo has quit IRC
325 2017-10-17T21:50:51 *** pergaminho has joined #bitcoin-core-dev
326 2017-10-17T21:51:28 *** jb55 has joined #bitcoin-core-dev
327 2017-10-17T21:54:17 *** Guyver2 has quit IRC
328 2017-10-17T21:56:54 *** pergaminho has quit IRC
329 2017-10-17T22:01:35 *** jb55 has quit IRC
330 2017-10-17T22:06:15 *** jb55 has joined #bitcoin-core-dev
331 2017-10-17T22:06:28 *** Cogito_Ergo_Sum has quit IRC
332 2017-10-17T22:08:48 <promag> jnewbery: where is P2PInterface?
333 2017-10-17T22:10:02 <promag> jnewbery: https://travis-ci.org/bitcoin/bitcoin/jobs/289221884#L741
334 2017-10-17T22:11:33 <promag> nevermind 1st question
335 2017-10-17T22:12:22 *** mess110 has quit IRC
336 2017-10-17T22:13:26 *** d_p has quit IRC
337 2017-10-17T22:14:15 *** d_p_ has joined #bitcoin-core-dev
338 2017-10-17T22:17:16 *** tripleslash has joined #bitcoin-core-dev
339 2017-10-17T22:22:57 *** dgenr8 has quit IRC
340 2017-10-17T22:23:00 *** cheese_ has joined #bitcoin-core-dev
341 2017-10-17T22:23:48 *** dgenr8 has joined #bitcoin-core-dev
342 2017-10-17T22:44:35 *** promag has quit IRC
343 2017-10-17T22:55:41 *** vicenteH has quit IRC
344 2017-10-17T23:08:39 *** nds_ has joined #bitcoin-core-dev
345 2017-10-17T23:17:57 *** cheese_ has quit IRC
346 2017-10-17T23:31:46 *** Dizzle has quit IRC
347 2017-10-17T23:48:48 *** Emcy has joined #bitcoin-core-dev
348 2017-10-17T23:49:17 *** jb55 has quit IRC
349 2017-10-17T23:49:35 *** jb55 has joined #bitcoin-core-dev
350 2017-10-17T23:51:43 *** rhavar has joined #bitcoin-core-dev
351 2017-10-17T23:56:49 *** AaronvanW has quit IRC
352 2017-10-17T23:57:27 *** AaronvanW has joined #bitcoin-core-dev
353 2017-10-17T23:57:35 *** jb55 has quit IRC