12017-10-19T00:02:39  *** jb55 has quit IRC
  22017-10-19T00:24:22  *** BashCo has quit IRC
  32017-10-19T00:25:18  *** BashCo has joined #bitcoin-core-dev
  42017-10-19T00:28:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  52017-10-19T00:31:47  *** BashCo has quit IRC
  62017-10-19T00:39:00  *** Emcy has joined #bitcoin-core-dev
  72017-10-19T00:51:45  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #11523: [Refactor] CValidation State (master...dos-cleanup) https://github.com/bitcoin/bitcoin/pull/11523
  82017-10-19T00:52:57  *** dabura667 has joined #bitcoin-core-dev
  92017-10-19T00:56:55  *** jb55 has joined #bitcoin-core-dev
 102017-10-19T01:02:50  *** wxss has quit IRC
 112017-10-19T01:05:22  *** pergaminho has quit IRC
 122017-10-19T01:07:07  *** promag has joined #bitcoin-core-dev
 132017-10-19T01:13:52  *** BashCo has joined #bitcoin-core-dev
 142017-10-19T01:15:34  *** pergaminho has joined #bitcoin-core-dev
 152017-10-19T01:17:02  *** Ylbam has quit IRC
 162017-10-19T01:17:45  *** pergaminho has quit IRC
 172017-10-19T01:33:05  *** roadcrap has joined #bitcoin-core-dev
 182017-10-19T01:35:29  *** Chris_Stewart_5 has quit IRC
 192017-10-19T01:43:48  *** promag has quit IRC
 202017-10-19T02:06:00  *** Banzai10 has quit IRC
 212017-10-19T02:25:05  *** BashCo has quit IRC
 222017-10-19T02:25:39  *** BashCo has joined #bitcoin-core-dev
 232017-10-19T02:37:44  *** PaulCapestany has joined #bitcoin-core-dev
 242017-10-19T02:39:38  *** Banzai10 has joined #bitcoin-core-dev
 252017-10-19T02:40:38  *** Banzai10 has quit IRC
 262017-10-19T02:57:46  *** Banzai10 has joined #bitcoin-core-dev
 272017-10-19T02:58:47  *** Banzai10 has quit IRC
 282017-10-19T03:00:35  *** dermoth has joined #bitcoin-core-dev
 292017-10-19T03:05:20  *** merehap_ has quit IRC
 302017-10-19T03:05:23  *** merehap__ has joined #bitcoin-core-dev
 312017-10-19T03:13:19  *** wraithm has joined #bitcoin-core-dev
 322017-10-19T03:17:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 332017-10-19T03:17:53  *** wraithm has quit IRC
 342017-10-19T03:19:48  *** Chris_Stewart_5 has quit IRC
 352017-10-19T03:23:42  *** meshcollider has quit IRC
 362017-10-19T04:09:11  *** Nishadburhan has joined #bitcoin-core-dev
 372017-10-19T04:11:29  *** Nishadburhan has quit IRC
 382017-10-19T04:15:19  *** vicenteH` has joined #bitcoin-core-dev
 392017-10-19T04:16:51  *** vicenteH has quit IRC
 402017-10-19T04:21:18  *** lrvick has quit IRC
 412017-10-19T04:31:42  *** lrvick has joined #bitcoin-core-dev
 422017-10-19T04:45:29  *** meshcollider has joined #bitcoin-core-dev
 432017-10-19T04:58:34  *** BashCo has quit IRC
 442017-10-19T05:42:52  *** Ylbam has joined #bitcoin-core-dev
 452017-10-19T06:03:28  *** Emcy has quit IRC
 462017-10-19T06:03:51  *** Emcy has joined #bitcoin-core-dev
 472017-10-19T06:09:24  *** goksinen has joined #bitcoin-core-dev
 482017-10-19T06:14:05  *** goksinen has quit IRC
 492017-10-19T06:20:51  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 502017-10-19T06:20:52  *** Cogito_Ergo_Sum has quit IRC
 512017-10-19T06:20:52  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 522017-10-19T06:28:00  *** mmgen has joined #bitcoin-core-dev
 532017-10-19T06:28:14  *** goksinen has joined #bitcoin-core-dev
 542017-10-19T06:28:27  *** jb55 has quit IRC
 552017-10-19T06:31:14  *** chjj has quit IRC
 562017-10-19T06:33:04  *** goksinen has quit IRC
 572017-10-19T06:41:49  *** mmgen has quit IRC
 582017-10-19T06:53:12  *** cluelessperson has quit IRC
 592017-10-19T06:55:33  *** dcousens has quit IRC
 602017-10-19T06:59:08  *** cluelessperson has joined #bitcoin-core-dev
 612017-10-19T07:17:08  *** Barkhas has joined #bitcoin-core-dev
 622017-10-19T07:17:12  *** Guyver2 has joined #bitcoin-core-dev
 632017-10-19T07:17:42  *** Barkhas has quit IRC
 642017-10-19T07:34:49  *** dcousens has joined #bitcoin-core-dev
 652017-10-19T07:37:38  *** vicenteH` is now known as vicenteH
 662017-10-19T07:50:13  *** chjj has joined #bitcoin-core-dev
 672017-10-19T07:55:57  *** justanotheruser has quit IRC
 682017-10-19T07:56:19  *** Cogito_Ergo_Sum has quit IRC
 692017-10-19T08:03:50  <bitcoin-git> [bitcoin] tjps opened pull request #11524: [net] De-duplicate connection eviction logic (master...tjps_eviction) https://github.com/bitcoin/bitcoin/pull/11524
 702017-10-19T08:06:24  *** laurentmt has joined #bitcoin-core-dev
 712017-10-19T08:18:41  *** goksinen has joined #bitcoin-core-dev
 722017-10-19T08:21:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 732017-10-19T08:24:56  *** promag has joined #bitcoin-core-dev
 742017-10-19T08:25:16  *** dermoth has quit IRC
 752017-10-19T08:27:07  *** dermoth has joined #bitcoin-core-dev
 762017-10-19T08:27:34  *** Guyver2 has quit IRC
 772017-10-19T08:27:43  *** promag has quit IRC
 782017-10-19T08:28:45  *** goatpig has joined #bitcoin-core-dev
 792017-10-19T08:32:57  *** Emcy has quit IRC
 802017-10-19T08:33:16  *** promag has joined #bitcoin-core-dev
 812017-10-19T08:33:25  *** Emcy has joined #bitcoin-core-dev
 822017-10-19T08:38:17  *** Emcy_ has joined #bitcoin-core-dev
 832017-10-19T08:41:02  *** ghost43 has quit IRC
 842017-10-19T08:41:20  *** ghost43 has joined #bitcoin-core-dev
 852017-10-19T08:42:17  *** Emcy has quit IRC
 862017-10-19T08:51:50  *** Ylbam has quit IRC
 872017-10-19T09:02:45  *** timothy has joined #bitcoin-core-dev
 882017-10-19T09:15:54  *** m8tion has joined #bitcoin-core-dev
 892017-10-19T09:24:00  *** merehap__ has quit IRC
 902017-10-19T09:29:32  *** darthJarjar has joined #bitcoin-core-dev
 912017-10-19T09:29:41  <darthJarjar> hi to all
 922017-10-19T09:32:02  *** pedrobranco has joined #bitcoin-core-dev
 932017-10-19T09:40:23  *** wxss has joined #bitcoin-core-dev
 942017-10-19T09:46:40  *** Emcy_ has quit IRC
 952017-10-19T09:48:17  <bitcoin-git> [bitcoin] pierreN opened pull request #11525: Utils and libraries: fix warning -Wsign-compare in ConsumeDecimalNumber (master...fix_sign_compare_lvldb_logging) https://github.com/bitcoin/bitcoin/pull/11525
 962017-10-19T09:48:27  *** Emcy has joined #bitcoin-core-dev
 972017-10-19T09:51:32  <bitcoin-git> [bitcoin] fanquake closed pull request #11525: Utils and libraries: fix warning -Wsign-compare in ConsumeDecimalNumber (master...fix_sign_compare_lvldb_logging) https://github.com/bitcoin/bitcoin/pull/11525
 982017-10-19T10:00:50  *** Emcy has quit IRC
 992017-10-19T10:01:42  *** dabura667 has quit IRC
1002017-10-19T10:04:04  *** pergaminho has joined #bitcoin-core-dev
1012017-10-19T10:04:51  *** AaronvanW has joined #bitcoin-core-dev
1022017-10-19T10:13:06  <wallet42> Would it be a lot of change to have an -option so that when spending coins in the chainstate db instead of deleting the key, it will be renamed from c[txid][nout] to s[txid][nout] ? basically have it ever growing coins db?
1032017-10-19T10:13:36  *** BashCo has joined #bitcoin-core-dev
1042017-10-19T10:13:38  <wallet42> it would ease some of my analysis tools
1052017-10-19T10:21:45  <bitcoin-git> [bitcoin] sipsorcery opened pull request #11526: Visual Studio build configuration for Bitcoin Core. (master...build_msvc) https://github.com/bitcoin/bitcoin/pull/11526
1062017-10-19T10:22:57  *** sybarite has joined #bitcoin-core-dev
1072017-10-19T10:24:56  *** sybarite has quit IRC
1082017-10-19T10:27:00  *** BashCo has quit IRC
1092017-10-19T10:30:49  *** JackH has joined #bitcoin-core-dev
1102017-10-19T10:35:32  *** BashCo has joined #bitcoin-core-dev
1112017-10-19T10:36:35  *** Aaronvan_ has joined #bitcoin-core-dev
1122017-10-19T10:37:52  *** laurentmt has quit IRC
1132017-10-19T10:39:22  *** AaronvanW has quit IRC
1142017-10-19T10:40:28  *** BashCo has quit IRC
1152017-10-19T10:49:34  <bitcoin-git> [bitcoin] schildbach opened pull request #11527: Remove my testnet DNS seed as I currently don't have the capacity to … (master...remove-seed) https://github.com/bitcoin/bitcoin/pull/11527
1162017-10-19T10:50:02  *** laurentmt has joined #bitcoin-core-dev
1172017-10-19T10:51:15  *** AaronvanW has joined #bitcoin-core-dev
1182017-10-19T10:54:23  *** Aaronvan_ has quit IRC
1192017-10-19T11:03:02  *** W4RL0RD has joined #bitcoin-core-dev
1202017-10-19T11:10:38  *** pergaminho has quit IRC
1212017-10-19T11:11:28  *** owowo has quit IRC
1222017-10-19T11:18:57  *** moctos has quit IRC
1232017-10-19T11:19:05  *** esotericnonsense has quit IRC
1242017-10-19T11:23:30  *** Giszmo has joined #bitcoin-core-dev
1252017-10-19T11:26:28  *** JackH has quit IRC
1262017-10-19T11:28:57  *** gribble has quit IRC
1272017-10-19T11:58:17  *** gribble has joined #bitcoin-core-dev
1282017-10-19T12:05:04  *** SopaXorzTaker has joined #bitcoin-core-dev
1292017-10-19T12:07:17  *** Aaronvan_ has joined #bitcoin-core-dev
1302017-10-19T12:09:19  *** promag has quit IRC
1312017-10-19T12:09:27  *** AaronvanW has quit IRC
1322017-10-19T12:16:12  *** owowo has joined #bitcoin-core-dev
1332017-10-19T12:17:35  *** SlipperySlope has joined #bitcoin-core-dev
1342017-10-19T12:18:17  *** SlipperySlope has quit IRC
1352017-10-19T12:23:05  *** owowo has quit IRC
1362017-10-19T12:23:50  *** Banzai10 has joined #bitcoin-core-dev
1372017-10-19T12:33:38  *** rafalcpp has quit IRC
1382017-10-19T12:38:44  *** owowo has joined #bitcoin-core-dev
1392017-10-19T12:45:49  *** justanotheruser has joined #bitcoin-core-dev
1402017-10-19T12:46:35  *** rafalcpp has joined #bitcoin-core-dev
1412017-10-19T12:54:28  *** rafalcpp has quit IRC
1422017-10-19T12:55:07  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/02ac8c892b1f...b9e1299f048d
1432017-10-19T12:55:08  <bitcoin-git> bitcoin/master a86e81b Cory Fields: travis: move back to the minimal image...
1442017-10-19T12:55:08  <bitcoin-git> bitcoin/master 3d1c311 Cory Fields: Revert "travis: filter out pyenv"...
1452017-10-19T12:55:09  <bitcoin-git> bitcoin/master b9e1299 Wladimir J. van der Laan: Merge #11521: travis: move back to the minimal image...
1462017-10-19T12:55:45  <bitcoin-git> [bitcoin] laanwj closed pull request #11521: travis: move back to the minimal image (master...travis-minimal) https://github.com/bitcoin/bitcoin/pull/11521
1472017-10-19T12:56:09  <wumpus> cfields: ok, applied
1482017-10-19T12:56:12  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/1646f9c76036...ca0f3f734c46
1492017-10-19T12:56:12  <bitcoin-git> bitcoin/0.15 b28415b Cory Fields: travis: move back to the minimal image...
1502017-10-19T12:56:13  <bitcoin-git> bitcoin/0.15 ca0f3f7 Cory Fields: Revert "travis: filter out pyenv"...
1512017-10-19T12:58:45  *** promag has joined #bitcoin-core-dev
1522017-10-19T13:00:32  <wumpus> there are so many unmerged PRs tagged for 0.15.0.2, anything ready to merge?
1532017-10-19T13:02:09  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b9e1299f048d...13f53b750dc0
1542017-10-19T13:02:09  <bitcoin-git> bitcoin/master 132d322 Andreas Schildbach: Remove my testnet DNS seed as I currently don't have the capacity to keep it up to date.
1552017-10-19T13:02:09  <bitcoin-git> bitcoin/master 13f53b7 Wladimir J. van der Laan: Merge #11527: Remove my testnet DNS seed as I currently don't have the capacity to …...
1562017-10-19T13:02:38  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/a2bd86a5ff1d75d85089e4ba6c908ece83451c5c
1572017-10-19T13:02:39  <bitcoin-git> bitcoin/0.15 a2bd86a Andreas Schildbach: Remove my testnet DNS seed as I currently don't have the capacity to keep it up to date....
1582017-10-19T13:03:53  *** promag has quit IRC
1592017-10-19T13:04:04  <wumpus> #11476 seems to be ready
1602017-10-19T13:04:06  <gribble> https://github.com/bitcoin/bitcoin/issues/11476 | Avoid opening copied wallet databases simultaneously by ryanofsky · Pull Request #11476 · bitcoin/bitcoin · GitHub
1612017-10-19T13:04:40  <sipa> ack
1622017-10-19T13:14:41  *** dabura667 has joined #bitcoin-core-dev
1632017-10-19T13:42:03  *** goksinen_ has joined #bitcoin-core-dev
1642017-10-19T13:42:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1652017-10-19T13:45:05  *** goksinen has quit IRC
1662017-10-19T13:51:34  *** AaronvanW has joined #bitcoin-core-dev
1672017-10-19T13:53:21  *** Aaronvan_ has quit IRC
1682017-10-19T14:03:29  *** rafalcpp has joined #bitcoin-core-dev
1692017-10-19T14:06:32  <bitcoin-git> [bitcoin] sipsorcery opened pull request #11528: Minimal code changes to allow msvc compilation (master...code_msvc) https://github.com/bitcoin/bitcoin/pull/11528
1702017-10-19T14:16:55  *** pedrobranco has quit IRC
1712017-10-19T14:17:23  *** pedrobranco has joined #bitcoin-core-dev
1722017-10-19T14:17:48  *** pedrobranco has joined #bitcoin-core-dev
1732017-10-19T14:22:45  *** promag has joined #bitcoin-core-dev
1742017-10-19T14:31:04  <bitcoin-git> [bitcoin] promag opened pull request #11529: Avoid slow transaction search with txindex enabled (master...2017-10-txindex-get-transaction) https://github.com/bitcoin/bitcoin/pull/11529
1752017-10-19T14:32:27  <wumpus> huh didn't we already have that one
1762017-10-19T14:35:14  *** meshcollider has quit IRC
1772017-10-19T14:39:40  <promag> I can make it one line too, just one "return false;" if txindex
1782017-10-19T14:40:13  <promag> the thing is, there is no point in doing the slow search if txindex is enabled and doesn't have the given txid
1792017-10-19T14:40:52  <sipa> i prefer promag's approach slightly more
1802017-10-19T14:41:20  <promag> also, I would like to discuss what locks are required in each case
1812017-10-19T14:41:35  <promag> for instance, cs_main is not required to mempool.get right?
1822017-10-19T14:42:40  <promag> dunno about pblocktree
1832017-10-19T14:44:32  <sipa> pblocktree requires cs_main
1842017-10-19T14:44:39  <sipa> mempool has its own lock
1852017-10-19T14:44:48  *** wraithm has joined #bitcoin-core-dev
1862017-10-19T14:47:58  <promag> and pcoinsTip?
1872017-10-19T14:48:01  <wumpus> I prefer the smaller change, especially as it already had so many utACKS, the rationale for re-doing it in another way now is unclear to me
1882017-10-19T14:48:14  *** goksinen_ has quit IRC
1892017-10-19T14:48:44  <sipa> promag: cs_main
1902017-10-19T14:48:54  *** goksinen has joined #bitcoin-core-dev
1912017-10-19T14:49:00  <wumpus> feel free to explain it though if there's cases that it covers and the other one doesn't, but the PR isn't very clear
1922017-10-19T14:49:27  <sipa> wumpus: there's no difference afaik - but it's cleaner that the dependency on txindex in localized in one place
1932017-10-19T14:49:36  <sipa> but really no strong opinion
1942017-10-19T14:49:36  *** fluidjax has quit IRC
1952017-10-19T14:49:39  <wumpus> I mean the change is more complex and more ways to mess it up
1962017-10-19T14:50:14  <wumpus> it adds so much code!
1972017-10-19T14:50:24  <sipa> oh, the change is much bigger than i expected - i just knew the concept
1982017-10-19T14:50:27  <promag> wumpus: do you prefer this:
1992017-10-19T14:50:28  <promag> https://github.com/bitcoin/bitcoin/compare/master...promag:2017-10-txindex-get-transaction-2?expand=1
2002017-10-19T14:50:35  <sipa> promag showed a much smaller change earlier
2012017-10-19T14:51:01  <wumpus> ow diffing with w=1 makes it better
2022017-10-19T14:51:26  <wumpus> still I don't see why so much logic needs to be changed for this
2032017-10-19T14:51:31  <sipa> still, what i saw earlier was 1 line
2042017-10-19T14:51:43  <sipa> but inside GetTransaction rather than in the caller
2052017-10-19T14:51:48  <promag> see last link
2062017-10-19T14:51:58  <wumpus> sounds good to me
2072017-10-19T14:52:06  <sipa> ^ that
2082017-10-19T14:53:24  <promag> done
2092017-10-19T14:53:46  *** goksinen has quit IRC
2102017-10-19T14:53:52  <promag> although I think we can only lock cs_main after mempool lookup
2112017-10-19T14:54:11  <sipa> you can hold both
2122017-10-19T14:54:23  <sipa> but you need to grab main first, if you need both
2132017-10-19T14:54:43  <promag> really?
2142017-10-19T14:54:48  <sipa> yes
2152017-10-19T14:54:55  <sipa> there exists a lock order
2162017-10-19T14:55:10  <promag> ah got it, so the other commit was wrong
2172017-10-19T14:55:25  <sipa> which means that if there is one place in the code where A is being held while B is being taken, you can't have another place where A is being taken while B is held
2182017-10-19T14:55:37  <promag> ok
2192017-10-19T14:55:44  <sipa> the opposite is called lock order inversion, and is a risk for deadlocking
2202017-10-19T14:56:17  <sipa> -DDEBUG_LOCKORDER automatically detects lock order inversions
2212017-10-19T14:57:06  <promag> thanks for the explanation
2222017-10-19T14:57:08  *** m8tion has quit IRC
2232017-10-19T14:57:11  *** m8tion01 has joined #bitcoin-core-dev
2242017-10-19T15:02:45  *** promag has quit IRC
2252017-10-19T15:03:36  <wumpus> is there something wrong with travis again or is everyone just submitting PRs that break it? :)
2262017-10-19T15:10:57  *** timothy has quit IRC
2272017-10-19T15:19:10  *** goksinen has joined #bitcoin-core-dev
2282017-10-19T15:20:32  *** Victor_sueca has joined #bitcoin-core-dev
2292017-10-19T15:22:07  <Chris_Stewart_5> Is there numbers any where of how long it takes to validate/verify a block w/ 0.15.0
2302017-10-19T15:22:48  <wumpus> -debug=bench
2312017-10-19T15:23:21  *** Emcy has joined #bitcoin-core-dev
2322017-10-19T15:23:37  *** Victorsueca has quit IRC
2332017-10-19T15:24:04  *** goksinen has quit IRC
2342017-10-19T15:26:18  *** Victor_sueca is now known as Victorsueca
2352017-10-19T15:37:27  *** Emcy has quit IRC
2362017-10-19T15:43:34  *** wraithm has quit IRC
2372017-10-19T15:46:51  *** wraithm has joined #bitcoin-core-dev
2382017-10-19T15:51:15  *** Dizzle has joined #bitcoin-core-dev
2392017-10-19T15:56:44  *** Emcy has joined #bitcoin-core-dev
2402017-10-19T16:01:23  *** PaulCapestany has quit IRC
2412017-10-19T16:02:59  *** PaulCapestany has joined #bitcoin-core-dev
2422017-10-19T16:07:53  *** Emcy has quit IRC
2432017-10-19T16:10:26  <bitcoin-git> [bitcoin] laanwj closed pull request #11507: [RPC] Don't do slow transaction lookup when txindex is enabled (master...getrawtx-txindex) https://github.com/bitcoin/bitcoin/pull/11507
2442017-10-19T16:10:43  *** PaulCapestany has quit IRC
2452017-10-19T16:13:08  *** PaulCapestany has joined #bitcoin-core-dev
2462017-10-19T16:15:37  *** promag has joined #bitcoin-core-dev
2472017-10-19T16:16:35  *** eck has quit IRC
2482017-10-19T16:17:19  *** eck has joined #bitcoin-core-dev
2492017-10-19T16:17:22  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13f53b750dc0...99e93de6f8ab
2502017-10-19T16:17:22  <bitcoin-git> bitcoin/master 478a89c Russell Yanofsky: Avoid opening copied wallet databases simultaneously...
2512017-10-19T16:17:23  <bitcoin-git> bitcoin/master 99e93de Wladimir J. van der Laan: Merge #11476: Avoid opening copied wallet databases simultaneously...
2522017-10-19T16:17:57  <bitcoin-git> [bitcoin] laanwj closed pull request #11476: Avoid opening copied wallet databases simultaneously (master...pr/wid) https://github.com/bitcoin/bitcoin/pull/11476
2532017-10-19T16:21:53  *** Chris_Stewart_5 has quit IRC
2542017-10-19T16:23:31  *** m8tion01 has quit IRC
2552017-10-19T16:24:44  <promag> in travis, what's the point in running functional tests if make check fails?
2562017-10-19T16:28:25  *** Emcy has joined #bitcoin-core-dev
2572017-10-19T16:29:55  *** jb55 has joined #bitcoin-core-dev
2582017-10-19T16:31:21  *** dgenr8 has quit IRC
2592017-10-19T16:31:54  *** dgenr8 has joined #bitcoin-core-dev
2602017-10-19T16:57:50  *** pedrobranco has quit IRC
2612017-10-19T16:58:16  *** pedrobranco has joined #bitcoin-core-dev
2622017-10-19T17:03:49  <cfields> heh, all 0.15.0.2 issues are pretty closely intertwined.
2632017-10-19T17:04:00  *** pedrobranco has quit IRC
2642017-10-19T17:04:11  <cfields> #topicsuggestion ^^ :)
2652017-10-19T17:05:15  *** venky has joined #bitcoin-core-dev
2662017-10-19T17:07:07  *** owowo has quit IRC
2672017-10-19T17:09:10  <wumpus> promag: the functional tests also don't work like that, if one test fails it continues with the rest. I guess it's useful to see exactly what tests fail.
2682017-10-19T17:09:19  *** ecurrencyhodler_ has joined #bitcoin-core-dev
2692017-10-19T17:09:35  <wumpus> if it stops at the first failed test you need to re-run time after time after fixing a single test
2702017-10-19T17:10:07  *** W4RL0RD has quit IRC
2712017-10-19T17:10:13  *** pedrobranco has joined #bitcoin-core-dev
2722017-10-19T17:12:08  *** owowo has joined #bitcoin-core-dev
2732017-10-19T17:15:56  *** intcat has quit IRC
2742017-10-19T17:16:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2752017-10-19T17:20:06  *** goksinen has joined #bitcoin-core-dev
2762017-10-19T17:24:57  *** goksinen has quit IRC
2772017-10-19T17:25:32  *** ghost43 has quit IRC
2782017-10-19T17:27:22  *** wxss has quit IRC
2792017-10-19T17:28:04  *** wxss has joined #bitcoin-core-dev
2802017-10-19T17:28:43  *** venky has quit IRC
2812017-10-19T17:36:53  *** promag_ has joined #bitcoin-core-dev
2822017-10-19T17:38:09  *** owowo has quit IRC
2832017-10-19T17:39:13  *** promag has quit IRC
2842017-10-19T17:39:54  *** goksinen has joined #bitcoin-core-dev
2852017-10-19T17:40:45  *** laurentmt has quit IRC
2862017-10-19T17:42:11  *** owowo has joined #bitcoin-core-dev
2872017-10-19T17:42:16  *** cealex has joined #bitcoin-core-dev
2882017-10-19T17:43:53  *** griswaalt[m] has quit IRC
2892017-10-19T17:43:53  *** herzmeister[m] has quit IRC
2902017-10-19T17:44:10  *** Masaomi[m] has quit IRC
2912017-10-19T17:44:21  *** goksinen has quit IRC
2922017-10-19T17:44:29  *** kewde[m] has quit IRC
2932017-10-19T17:46:26  <ossifrage> That copy paste problem I reported earlier is an actual QT bug: "GUI: QXcbClipboard::setMimeData: Cannot set X11 selection owner"
2942017-10-19T17:46:41  *** owowo has quit IRC
2952017-10-19T17:47:54  *** cealex has quit IRC
2962017-10-19T17:48:03  *** intcat has joined #bitcoin-core-dev
2972017-10-19T17:48:36  <ossifrage> It seems to have been triggered by running a second instance of firefox as another user.
2982017-10-19T17:49:47  *** owowo has joined #bitcoin-core-dev
2992017-10-19T17:49:47  *** owowo has joined #bitcoin-core-dev
3002017-10-19T17:50:51  <ossifrage> It is possible that using the QClipboard wrapper instead of the QXcb* stuff will address some of these edge cases...
3012017-10-19T17:50:57  <wumpus> yea X has some interesting clipboard issues sometimes, especially combined with 'remote' windows, or with some software that tries to keep up to date with the clipboard and querying it all the time
3022017-10-19T17:51:35  *** ghost43 has joined #bitcoin-core-dev
3032017-10-19T17:51:45  <ossifrage> This one was a bit of a usability issue and I ended up having to use bitcoin-cli to copy and paste addresses without screwing up
3042017-10-19T17:51:50  <wumpus> I'm sure we don't use QXcb clipboard stuff directly in our code
3052017-10-19T17:52:33  <wumpus> it's possible to build bitcoin-qt w/ wayland, for example, and the clipboard works
3062017-10-19T17:52:44  <ossifrage> firefox, chrome, xfce-terminal where all un-effected, but gnome-terminal and bitcoin-qt where
3072017-10-19T17:53:45  <wumpus> xclip is a useful tool to probe around with X clipboards, did you know it actually has three of them?
3082017-10-19T17:53:51  <ossifrage> wumpus, the clipboard worked fine, I use it extensively with bitcoin-qt, until I launched a 'lazy sandboxed' firefox as another user
3092017-10-19T17:54:24  <ossifrage> wumpus, yeah I tried to use xclip to clear all 3 hoping that would magically reset whatever permissions it was confused about, with no love
3102017-10-19T17:54:40  <wumpus> lol it's such a mess
3112017-10-19T17:55:03  <ossifrage> Restarting gnome-terminal fixed the problem for it, but I didn't want to restart bitcoin-qt
3122017-10-19T17:55:14  <wumpus> but hey windows has to be better at something :)
3132017-10-19T17:55:19  <ossifrage> (I have some sort of uptime/connection count fetish)
3142017-10-19T17:56:00  <ossifrage> I used to run X stuff over ssh tunnels for years and never remember having a problem like this...
3152017-10-19T17:56:24  <wumpus> I've had more clipboard issues with X than I can even remember
3162017-10-19T17:56:53  <ossifrage> Weirdness yes, but complete failure to work, not so much...
3172017-10-19T17:57:12  <wumpus> it's most fun VNC or xpra and remote windows get involved, sometimes they get into a loop updating
3182017-10-19T17:57:39  <cfields> ossifrage: huh, very interesting. my Konsole copy/paste quit working yesterday.
3192017-10-19T17:57:42  <wumpus> or sometimes you suddenly get old clipboard contents back
3202017-10-19T17:58:15  <ossifrage> wumpus, yeah I've seen that before and I think clipboard managers make the problem even worse
3212017-10-19T17:58:20  <wumpus> and copy some password into something that aboslutely shouldn't have it
3222017-10-19T17:58:30  <wumpus> ossifrage: yup like the one that KDE comes with
3232017-10-19T17:59:01  <ossifrage> wumpus, I have a shell alias for clearing the clipboard after pasting a password :p
3242017-10-19T18:00:09  <wumpus> cfields: interesting, maybe it's some recent update that made it worse
3252017-10-19T18:00:39  <cfields> sounds reasonable
3262017-10-19T18:01:25  <cfields> I didn't investigate much because i use vim's yank for the most part. I just chalked it up to a Konsole bug.
3272017-10-19T18:02:11  *** abpa has joined #bitcoin-core-dev
3282017-10-19T18:05:23  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99e93de6f8ab...ff92fbf24739
3292017-10-19T18:05:23  <bitcoin-git> bitcoin/master 7a5f930 João Barbosa: Avoid slow transaction search with txindex enabled
3302017-10-19T18:05:24  <bitcoin-git> bitcoin/master ff92fbf Wladimir J. van der Laan: Merge #11529: Avoid slow transaction search with txindex enabled...
3312017-10-19T18:05:31  <wumpus> heh if you use one of the -x11 variants of vim, yank will also copy to the X clipboard
3322017-10-19T18:05:53  <cfields> ah, neat
3332017-10-19T18:05:57  <bitcoin-git> [bitcoin] laanwj closed pull request #11529: Avoid slow transaction search with txindex enabled (master...2017-10-txindex-get-transaction) https://github.com/bitcoin/bitcoin/pull/11529
3342017-10-19T18:07:05  <wumpus> well at least the clipboard becomes one of the yank registers, not the default one
3352017-10-19T18:07:23  <cfields> dammit, I've squashed/force-pushed this pr like 5 times now, I keep missing little things I forgot to address. I hope that's not blowing up anybody's mailbox?
3362017-10-19T18:07:53  <wumpus> oh wait, even two of them, + and *, for two differnt clipboards, of course
3372017-10-19T18:08:26  <wumpus> cfields: well not mine at least
3382017-10-19T18:09:02  <cfields> k. wasn't sure if you could subscribe to new commits, even if they're just a rebase
3392017-10-19T18:09:35  <wumpus> thinking of it, I don't get mails for pushes at all, just for comments
3402017-10-19T18:09:48  <wumpus> not that I know of
3412017-10-19T18:10:23  <cfields> I got them for pushes at some point. Can't remember if i turned it off for being to spammy, or if Github disabled that
3422017-10-19T18:10:31  <cfields> *too spammy
3432017-10-19T18:12:31  <achow101> I definitely get emails for new commits
3442017-10-19T18:12:33  <wumpus> you can enable mails for pushes to your repository https://help.github.com/articles/choosing-the-types-of-notifications-you-receive/
3452017-10-19T18:12:53  <wumpus> achow101: but also for PRs you're subscribed to?
3462017-10-19T18:13:01  <MarcoFalke> I get for pushes, but not for force pushes
3472017-10-19T18:13:14  <achow101> but there's a delay between pushing a commit or making a comment and then getting the email. I think github is smart enough to not send out too many mails if you make multiple pushes within a minute or two of each other
3482017-10-19T18:13:43  <achow101> wumpus: this is for PRs
3492017-10-19T18:14:01  <wumpus> ok, strange, well I don't really mind not getting them, I already get way too much mail
3502017-10-19T18:15:01  <cfields> achow101: ok. for future reference, did you just get about 5 from me for 11512? Or it skipped them all because they were force-pushes?
3512017-10-19T18:15:29  <cfields> er, 11457
3522017-10-19T18:15:54  <achow101> cfields: I did not get any emails about those force pushes
3532017-10-19T18:16:02  <cfields> great, thanks
3542017-10-19T18:18:26  <ryanofsky> i think github doesn't send "pushed commits" messages for prs when the new commits have the same subject lines as the old commits
3552017-10-19T18:21:14  <cfields> ryanofsky: well about 3 of my force-pushes right now were squashing "temp" and "fixup" commits that I accidentally left in. So it apparently doesn't notify on new ones, at least
3562017-10-19T18:21:38  <cfields> or, maybe only after some delay like achow101 said
3572017-10-19T18:22:58  <wumpus> it probably only mails when a new commit (or more) was added on top of the last known one
3582017-10-19T18:23:11  *** brianhoffman has joined #bitcoin-core-dev
3592017-10-19T18:23:18  <cfields> ah, that would make sense
3602017-10-19T18:33:03  *** esotericnonsense has joined #bitcoin-core-dev
3612017-10-19T18:34:49  *** goksinen has joined #bitcoin-core-dev
3622017-10-19T18:41:21  *** goksinen has quit IRC
3632017-10-19T18:48:41  *** goksinen has joined #bitcoin-core-dev
3642017-10-19T18:49:21  *** StopAndDecrypt__ has joined #bitcoin-core-dev
3652017-10-19T18:50:38  *** StopAndDecrypt has quit IRC
3662017-10-19T18:53:22  *** goksinen has quit IRC
3672017-10-19T18:54:49  *** meshcollider has joined #bitcoin-core-dev
3682017-10-19T18:55:53  *** clarkmoody has joined #bitcoin-core-dev
3692017-10-19T18:59:41  *** karelb has joined #bitcoin-core-dev
3702017-10-19T18:59:49  <wumpus> meeting time?
3712017-10-19T19:00:06  <jonasschnelli> jup
3722017-10-19T19:00:09  <meshcollider> Hi
3732017-10-19T19:00:32  <wumpus> #startmeeting
3742017-10-19T19:00:32  <lightningbot> Meeting started Thu Oct 19 19:00:32 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3752017-10-19T19:00:32  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3762017-10-19T19:00:34  <achow101> hi
3772017-10-19T19:00:53  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
3782017-10-19T19:01:06  <cfields> hi
3792017-10-19T19:01:12  <sipa> mildly present
3802017-10-19T19:01:17  <kanzure> hi.
3812017-10-19T19:01:20  <wumpus> primary topic I suppose is 0.15.0.2
3822017-10-19T19:01:34  <wumpus> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.15.0.2
3832017-10-19T19:02:23  <wumpus> anything that is close to merging, or that needs further discussion?
3842017-10-19T19:03:25  <cfields> BlueMatt: are you around to fill in some of the cb interactions with those PRs? They're hard to review because of subtleties I assume I'm not fully accounting for.
3852017-10-19T19:03:27  <achow101> I wasn't able to do as much as I wanted to this week because of exams. I'll fix up #11446 later today hopefully
3862017-10-19T19:03:29  <gribble> https://github.com/bitcoin/bitcoin/issues/11446 | Disconnect Peers for Duplicate Invalid blocks. by achow101 · Pull Request #11446 · bitcoin/bitcoin · GitHub
3872017-10-19T19:04:04  <BlueMatt> sdaftuar: (and somewhat I) worked out a replacement for #11487, that I need to rewrite and close the original
3882017-10-19T19:04:05  <gribble> https://github.com/bitcoin/bitcoin/issues/11487 | Check that new headers are not a descendant of an invalid block by TheBlueMatt · Pull Request #11487 · bitcoin/bitcoin · GitHub
3892017-10-19T19:04:21  *** goksinen has joined #bitcoin-core-dev
3902017-10-19T19:04:37  <BlueMatt> so I'll do that a bit later
3912017-10-19T19:05:02  <wumpus> ok
3922017-10-19T19:05:03  <sdaftuar> i updated #11490 with some bug fixes and addressed feedback.  i also added a unit test that passes locally but fails in travis :( workin gon it...
3932017-10-19T19:05:05  <gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub
3942017-10-19T19:05:28  *** kayamm has quit IRC
3952017-10-19T19:05:43  <wumpus> great!
3962017-10-19T19:06:27  <wumpus> travis has been having some issues the last few days, be sure it's related to your pull  and not some intermittent problem
3972017-10-19T19:08:28  *** goksinen has quit IRC
3982017-10-19T19:08:28  <wumpus> any other topics?
3992017-10-19T19:08:53  <achow101> any updates on segwit wallet stuff?
4002017-10-19T19:09:24  <wumpus> I doubt anyone has been working on that w/ the .2 release rushed before
4012017-10-19T19:09:40  <sipa> i've been distracted the past week
4022017-10-19T19:09:48  <achow101> ok
4032017-10-19T19:09:52  <wumpus> will get back to that when sanity has returned
4042017-10-19T19:09:58  <jnewbery> topic suggestion: Chaincode Residency (sorry for the shameless plug)
4052017-10-19T19:10:08  <sipa> next week i'll have more time (i'm in europe until the end of the month)
4062017-10-19T19:10:30  <wumpus> #topic Chaincode Residency
4072017-10-19T19:10:40  <jnewbery> Thanks!
4082017-10-19T19:10:55  <jnewbery> We're hosting another residency program in Jan/Feb 2018: http://hackerresidency.com/ https://medium.com/@ChaincodeLabs/chaincode-residency-2018-26cd8a65d5f7
4092017-10-19T19:11:22  <jnewbery> If you know anyone who might be suitable, please refer them to the website
4102017-10-19T19:11:26  <jnewbery> end topic
4112017-10-19T19:11:40  <wumpus> ok!
4122017-10-19T19:12:00  <cfields> woohoo! We'll be expecting at least 1 new jnewbery and 1 new ryanofsky.
4132017-10-19T19:12:11  <jnewbery> 1 jnewbery is quite enough
4142017-10-19T19:12:22  <wumpus> hehe
4152017-10-19T19:12:34  <jonasschnelli> ;-.)
4162017-10-19T19:12:48  <sipa> jnewbery: how do you know? have you ever met one?
4172017-10-19T19:12:48  <cfields> heh
4182017-10-19T19:13:01  <wumpus> doppelganger
4192017-10-19T19:13:09  <wumpus> okay, anyone else have anything to discuss?
4202017-10-19T19:13:41  *** Cheeseo has joined #bitcoin-core-dev
4212017-10-19T19:14:07  <jnewbery> sipa: I've been informed that 1 is at the upper range of most people's tolerance
4222017-10-19T19:15:27  <meshcollider> Hmm might be good to briefly discuss what the plan is for #7729 and #11497
4232017-10-19T19:15:30  <gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub
4242017-10-19T19:15:31  <gribble> https://github.com/bitcoin/bitcoin/issues/11497 | Hide accounts system behind deprecation switch by achow101 · Pull Request #11497 · bitcoin/bitcoin · GitHub
4252017-10-19T19:15:31  <wumpus> well as long as they keep the great patches coming :)
4262017-10-19T19:16:07  <wumpus> needs to be rebased and merged :p
4272017-10-19T19:16:21  <achow101> meshcollider: I'm thinking they should probably be done simultaneously. 11947 should probably be part of 7729
4282017-10-19T19:16:23  *** Ylbam has joined #bitcoin-core-dev
4292017-10-19T19:16:27  <jonasschnelli> Plans to rebase 7729 or waiting until someone picks it up?
4302017-10-19T19:16:41  <wumpus> sorry, yes, I really need to push it the last bit
4312017-10-19T19:16:47  <jnewbery> I'm not convinced on the approach for 11497 (using -deprecatedprc)
4322017-10-19T19:17:02  <jonasschnelli> wumpus: thanks!
4332017-10-19T19:17:24  <wumpus> jnewbery: what is your concern with it?
4342017-10-19T19:17:39  <jnewbery> Seems to me that the account/label switch is conceptually on the level of the wallet, not on the level of the node
4352017-10-19T19:17:56  <sipa> today again a user on SE who was confused about accounts
4362017-10-19T19:18:12  *** goksinen has joined #bitcoin-core-dev
4372017-10-19T19:18:18  <jnewbery> https://github.com/bitcoin/bitcoin/pull/11497#issuecomment-336991350
4382017-10-19T19:18:31  <jonasschnelli> lables / account are completely on the wallet level... yes.
4392017-10-19T19:19:15  <wumpus> yes, they're at the wallet level, I agree
4402017-10-19T19:19:26  <jnewbery> I don't think 11497 addresses the problem of migrating from an account system to a label system, although I may not have fully understood what the plan is
4412017-10-19T19:19:38  <achow101> yeah, I agree with that. 11497 was really just done in a fit of anger after I got too fed up with handling account things
4422017-10-19T19:19:39  <wumpus> though from the perspective of the database there's no difference, accounts and labels use the same underlying strucures
4432017-10-19T19:19:50  <meshcollider> Agreed but there were concerns bumping the wallet version because of HD wallets right
4442017-10-19T19:20:04  <sipa> meshcollider: has nothing to do with accounts
4452017-10-19T19:20:22  <wumpus> it doesn't need a  new wallet version
4462017-10-19T19:20:23  <jnewbery> meshcollider: yes. Is now a good time to raise the topic of feature flags on wallets?
4472017-10-19T19:20:41  <meshcollider> Oh I thought that was discussed in 7729
4482017-10-19T19:20:43  <wumpus> accounts do not introduce any new wallet features , at least this first incarnation simply does what the GUI does
4492017-10-19T19:20:43  <achow101> meshcollider: it's the same database structures, so that shouldn't matter
4502017-10-19T19:21:24  <meshcollider> Yeah I thought 7729 comments were discussing using the version number as a flag for the label/account switch
4512017-10-19T19:21:25  <wumpus> people are requesting things like allowing multiple labels for one address, which would need extensions to functionality, but the current one is simply what is already done by the GUI
4522017-10-19T19:21:33  <jonasschnelli> (another topic, but): we can bump the wallet version because all new wallets now must be HD, right?
4532017-10-19T19:21:34  <wumpus> seems unnecessary
4542017-10-19T19:21:37  <sipa> i think using -deprecatedrpc is fine for accounts - it's literally just removing some functionality
4552017-10-19T19:21:49  <wumpus> sipa: yeah, it removes functionaltiy from the RPC interface
4562017-10-19T19:21:52  <sipa> but we may first need to add label-based RPCs
4572017-10-19T19:21:53  <wumpus> it's an RPC interface thing
4582017-10-19T19:22:06  <wumpus> sipa: yes, 7729 needs to go in first
4592017-10-19T19:22:09  <sipa> okay
4602017-10-19T19:22:14  *** pedrobranco has quit IRC
4612017-10-19T19:22:28  *** goksinen has quit IRC
4622017-10-19T19:22:29  <wumpus> then the flag can select between the old account based interface and the new label based one
4632017-10-19T19:22:47  <wumpus> at least for 0.16, in 0.17 I suppose the old interface will simply go away
4642017-10-19T19:22:48  <achow101> maybe we should use a different flag than -deprecatedrpc
4652017-10-19T19:23:05  <meshcollider> So yeah jnewbery topic suggestion of wallet feature flags?
4662017-10-19T19:23:22  <wumpus> this won't lose compatiblity with old wallets
4672017-10-19T19:23:30  <wumpus> it just will lose access to any account info in them
4682017-10-19T19:23:45  <sipa> right, it's not a wallet feature
4692017-10-19T19:23:48  <wumpus> so it's not really a wallet versioning thing
4702017-10-19T19:23:49  <jonasschnelli> meshcollider: no flags required for the label/account switch (only changes on functional level)
4712017-10-19T19:23:55  <sipa> it's a sofrware feature that can be turned on or off
4722017-10-19T19:24:17  <jnewbery> ok, so it sounds like it's not necessary for accounts/labels. I'll go back and look at 7729 again.
4732017-10-19T19:24:50  * achow101 is confused now
4742017-10-19T19:25:23  <wumpus> #action implement and merge the label api finally
4752017-10-19T19:25:26  <wumpus> ok, next topic?
4762017-10-19T19:25:28  <sipa> achow101: the big idea is that all accounts functionality remains under the name "label", except the concept of an acount balance
4772017-10-19T19:25:47  <achow101> sipa: so it is a node thing and not wallet based?
4782017-10-19T19:25:53  <sipa> achow101: wut?
4792017-10-19T19:25:59  <sipa> achow101: no, it's an RPC thing
4802017-10-19T19:26:07  <sipa> the wallet or node are unaffected
4812017-10-19T19:26:12  <wumpus> right
4822017-10-19T19:26:24  <achow101> s/node thing/rpc thing/
4832017-10-19T19:26:30  <sipa> right
4842017-10-19T19:26:33  <jonasschnelli> the wallet structure is unaffected although the wallet code is
4852017-10-19T19:26:48  <sipa> is it?
4862017-10-19T19:27:04  <sipa> i wouldn't expect it to (until it is deleted entirely)
4872017-10-19T19:27:04  <jonasschnelli> if we consider rpcwallet as wallet code
4882017-10-19T19:27:04  <wumpus> some small changes are necessary
4892017-10-19T19:27:07  <sipa> ok
4902017-10-19T19:27:16  <sipa> anyway, details
4912017-10-19T19:27:26  <sipa> i'm going off soo
4922017-10-19T19:27:31  <jonasschnelli> meshcollider: in case you want to work on wallet flags (there is already a closed PR) #8369
4932017-10-19T19:27:31  <wumpus> there's some functionaltiy that would be in the label API but the GUI doesn't use at the moment, from what I remember, but anyhow yeah it's minimal
4942017-10-19T19:27:33  <gribble> https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
4952017-10-19T19:28:00  <jnewbery> Last comment from wumpus in 7729 included "Either label or account RPCs could be usable based on the wallet version." I think we probably need to look at that PR again to refresh our memories (I certainly do)
4962017-10-19T19:28:11  <meshcollider> jonasschnelli: Oh right, I'll have a look
4972017-10-19T19:28:14  <sipa> okay
4982017-10-19T19:28:16  <wumpus> jnewbery: what a dumb comment!
4992017-10-19T19:28:34  <wumpus> going to remove it immediately :-)
5002017-10-19T19:28:34  <jnewbery> I think it was in response to me, more as a 'this is how it could possibly work'
5012017-10-19T19:28:41  <sipa> pffft, fact based analysis, how boring
5022017-10-19T19:28:48  <meshcollider> Yeah that comments probably what I was thinking of
5032017-10-19T19:29:36  <wumpus> back then I probably thought using the wallet version was a useful way of doing that flagging, but I reconsider
5042017-10-19T19:29:49  <achow101> well now we have -deprecatedrpc
5052017-10-19T19:30:03  <sipa> right
5062017-10-19T19:30:07  <wumpus> yes
5072017-10-19T19:30:58  <sipa> no more topics?
5082017-10-19T19:31:06  <wumpus> nope
5092017-10-19T19:31:18  <sipa> #halfameeting
5102017-10-19T19:31:27  <wumpus> #endmeeting
5112017-10-19T19:31:27  <lightningbot> Meeting ended Thu Oct 19 19:31:27 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5122017-10-19T19:31:27  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-10-19-19.00.html
5132017-10-19T19:31:27  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-10-19-19.00.txt
5142017-10-19T19:31:27  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-10-19-19.00.log.html
5152017-10-19T19:32:06  <achow101> review/merge beg on #11415 #10583 #10579 (rpc split things for removing #ifdef enable wallet)
5162017-10-19T19:32:08  <gribble> https://github.com/bitcoin/bitcoin/issues/11415 | [RPC] Disallow using addresses in createmultisig by achow101 · Pull Request #11415 · bitcoin/bitcoin · GitHub
5172017-10-19T19:32:10  <gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
5182017-10-19T19:32:13  <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
5192017-10-19T19:32:26  <wumpus> or alternatively, everyone should be reviewing 0.15.0.2 PRs
5202017-10-19T19:32:46  <achow101> that too
5212017-10-19T19:33:09  <wumpus> we have kind of a strict deadline there
5222017-10-19T19:35:01  *** SopaXorzTaker has quit IRC
5232017-10-19T19:35:54  *** goksinen has joined #bitcoin-core-dev
5242017-10-19T19:36:08  *** jb55 has quit IRC
5252017-10-19T19:40:28  *** goksinen has quit IRC
5262017-10-19T19:49:11  *** ecurrencyhodler_ has quit IRC
5272017-10-19T19:49:13  *** goksinen has joined #bitcoin-core-dev
5282017-10-19T19:53:32  *** goksinen has quit IRC
5292017-10-19T20:03:42  *** Guyver2 has joined #bitcoin-core-dev
5302017-10-19T20:05:39  *** jb55 has joined #bitcoin-core-dev
5312017-10-19T20:07:34  *** goksinen has joined #bitcoin-core-dev
5322017-10-19T20:08:00  *** quantbot_ has joined #bitcoin-core-dev
5332017-10-19T20:10:02  *** Chris_Stewart_5 has quit IRC
5342017-10-19T20:12:00  *** goksinen has quit IRC
5352017-10-19T20:13:03  *** Lauda has quit IRC
5362017-10-19T20:13:03  *** Cheeseo has quit IRC
5372017-10-19T20:16:20  *** goksinen has joined #bitcoin-core-dev
5382017-10-19T20:16:33  *** Lauda has joined #bitcoin-core-dev
5392017-10-19T20:18:22  *** jb55 has quit IRC
5402017-10-19T20:20:50  *** goksinen has quit IRC
5412017-10-19T20:21:28  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11530: Add share/rpcuser to dist. source code archive (master...Mf1710-distShare) https://github.com/bitcoin/bitcoin/pull/11530
5422017-10-19T20:23:22  *** jb55 has joined #bitcoin-core-dev
5432017-10-19T20:35:24  *** goksinen has joined #bitcoin-core-dev
5442017-10-19T20:36:54  *** PaulCapestany has quit IRC
5452017-10-19T20:37:27  *** mightyminnie has joined #bitcoin-core-dev
5462017-10-19T20:40:04  *** goksinen has quit IRC
5472017-10-19T20:42:07  *** mightyminnie has quit IRC
5482017-10-19T20:51:10  *** goksinen has joined #bitcoin-core-dev
5492017-10-19T20:54:08  *** Banzai10 has quit IRC
5502017-10-19T20:56:10  *** goksinen has quit IRC
5512017-10-19T20:57:35  *** shesek has quit IRC
5522017-10-19T20:59:21  *** Banzai10 has joined #bitcoin-core-dev
5532017-10-19T21:00:37  *** Banzai10 has quit IRC
5542017-10-19T21:00:56  *** Magma has joined #bitcoin-core-dev
5552017-10-19T21:02:19  <earlz> In GetTime(), it uses time(NULL)'s result directly. The returned value doesn't appear to be standard guaranteed to be UTC/unix time though. Shouldn't GetTime use gmtime or something similar to correct ofr this?
5562017-10-19T21:03:36  *** goksinen has joined #bitcoin-core-dev
5572017-10-19T21:08:14  *** goksinen has quit IRC
5582017-10-19T21:08:30  *** Banzai10 has joined #bitcoin-core-dev
5592017-10-19T21:09:27  *** Dizzle has quit IRC
5602017-10-19T21:09:52  *** Banzai10 has quit IRC
5612017-10-19T21:12:04  *** laurentmt has joined #bitcoin-core-dev
5622017-10-19T21:15:52  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11531: Check that new headers are not a descendant of an invalid block (more effeciently) (master...2017-10-cache-invalid-indexes) https://github.com/bitcoin/bitcoin/pull/11531
5632017-10-19T21:17:16  *** Banzai10 has joined #bitcoin-core-dev
5642017-10-19T21:18:41  *** Banzai10 has quit IRC
5652017-10-19T21:21:17  *** laurentmt has quit IRC
5662017-10-19T21:21:26  *** goksinen has joined #bitcoin-core-dev
5672017-10-19T21:26:12  *** goksinen has quit IRC
5682017-10-19T21:26:26  *** Banzai10 has joined #bitcoin-core-dev
5692017-10-19T21:36:43  *** goksinen has joined #bitcoin-core-dev
5702017-10-19T21:41:10  *** goksinen has quit IRC
5712017-10-19T21:53:13  *** PaulCapestany has joined #bitcoin-core-dev
5722017-10-19T21:54:03  *** goksinen has joined #bitcoin-core-dev
5732017-10-19T21:56:48  *** Cogito_Ergo_Sum has quit IRC
5742017-10-19T21:57:24  *** griswaalt[m] has joined #bitcoin-core-dev
5752017-10-19T21:57:47  *** PaulCapestany has quit IRC
5762017-10-19T21:58:45  *** goksinen has quit IRC
5772017-10-19T22:08:36  *** kewde[m] has joined #bitcoin-core-dev
5782017-10-19T22:08:38  *** herzmeister[m] has joined #bitcoin-core-dev
5792017-10-19T22:08:39  *** Masaomi[m] has joined #bitcoin-core-dev
5802017-10-19T22:12:04  *** goksinen has joined #bitcoin-core-dev
5812017-10-19T22:12:51  *** dcousens has quit IRC
5822017-10-19T22:17:06  *** Guyver2 has quit IRC
5832017-10-19T22:17:18  *** goksinen has quit IRC
5842017-10-19T22:18:36  *** wraithm has quit IRC
5852017-10-19T22:24:53  *** goksinen has joined #bitcoin-core-dev
5862017-10-19T22:26:06  *** Banzai10 has quit IRC
5872017-10-19T22:27:30  *** Banzai10 has joined #bitcoin-core-dev
5882017-10-19T22:29:18  *** goksinen has quit IRC
5892017-10-19T22:32:24  *** Banzai10 has quit IRC
5902017-10-19T22:36:55  *** Banzai10 has joined #bitcoin-core-dev
5912017-10-19T22:37:38  *** goksinen has joined #bitcoin-core-dev
5922017-10-19T22:38:09  <meshcollider> That should be added to 0.15.0.2 milestone ^
5932017-10-19T22:38:16  *** Banzai10 has quit IRC
5942017-10-19T22:42:01  *** goksinen has quit IRC
5952017-10-19T22:43:54  *** jb55 has quit IRC
5962017-10-19T22:49:55  *** goksinen has joined #bitcoin-core-dev
5972017-10-19T22:54:25  *** goksinen has quit IRC
5982017-10-19T22:56:25  *** abpa has quit IRC
5992017-10-19T22:57:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6002017-10-19T22:59:13  *** roadcrap has quit IRC
6012017-10-19T23:03:26  *** jb55 has joined #bitcoin-core-dev
6022017-10-19T23:04:03  *** Banzai10 has joined #bitcoin-core-dev
6032017-10-19T23:04:27  *** Chris_Stewart_5 has quit IRC
6042017-10-19T23:05:23  *** Banzai10 has quit IRC
6052017-10-19T23:06:46  *** goatpig has quit IRC
6062017-10-19T23:08:29  *** goksinen has joined #bitcoin-core-dev
6072017-10-19T23:13:05  *** goksinen has quit IRC
6082017-10-19T23:13:08  *** Banzai10 has joined #bitcoin-core-dev
6092017-10-19T23:16:49  *** vicenteH has quit IRC
6102017-10-19T23:19:24  *** Alkhara has joined #bitcoin-core-dev
6112017-10-19T23:20:12  *** d_p_ has quit IRC
6122017-10-19T23:20:18  <Alkhara> Anyone local to the Boston area?
6132017-10-19T23:23:12  *** goksinen has joined #bitcoin-core-dev
6142017-10-19T23:24:14  *** Aaronvan_ has joined #bitcoin-core-dev
6152017-10-19T23:27:29  *** goksinen has quit IRC
6162017-10-19T23:27:44  *** AaronvanW has quit IRC
6172017-10-19T23:29:03  *** d_p has joined #bitcoin-core-dev
6182017-10-19T23:30:13  *** Aaronvan_ has quit IRC
6192017-10-19T23:33:10  *** dabura667 has quit IRC
6202017-10-19T23:36:46  *** goksinen has joined #bitcoin-core-dev
6212017-10-19T23:40:16  *** Banzai10 has joined #bitcoin-core-dev
6222017-10-19T23:40:57  *** goksinen has quit IRC
6232017-10-19T23:41:37  *** Banzai10 has quit IRC
6242017-10-19T23:55:11  *** goksinen has joined #bitcoin-core-dev
6252017-10-19T23:59:51  *** roadcrap has joined #bitcoin-core-dev
6262017-10-19T23:59:57  *** goksinen has quit IRC