1 2017-10-30T00:07:41  *** Chris_Stewart_5 has quit IRC
  2 2017-10-30T00:16:52  *** AaronvanW has quit IRC
  3 2017-10-30T00:20:27  *** jtimon has quit IRC
  4 2017-10-30T00:23:12  *** wxss has quit IRC
  5 2017-10-30T00:29:48  *** str4d has quit IRC
  6 2017-10-30T00:31:18  *** str4d has joined #bitcoin-core-dev
  7 2017-10-30T00:34:50  *** LumberCartel_ has joined #bitcoin-core-dev
  8 2017-10-30T00:36:16  *** LumberCartel has quit IRC
  9 2017-10-30T00:45:06  *** meshcollider has quit IRC
 10 2017-10-30T00:46:44  *** dc0de has quit IRC
 11 2017-10-30T00:49:08  *** PaulCapestany has quit IRC
 12 2017-10-30T00:52:03  *** quantbot has quit IRC
 13 2017-10-30T00:53:03  *** quantbot has joined #bitcoin-core-dev
 14 2017-10-30T00:53:21  *** quantbot has quit IRC
 15 2017-10-30T00:53:49  *** PaulCapestany has joined #bitcoin-core-dev
 16 2017-10-30T00:54:21  *** quantbot has joined #bitcoin-core-dev
 17 2017-10-30T00:54:49  *** quantbot has quit IRC
 18 2017-10-30T00:55:03  *** quantbot has joined #bitcoin-core-dev
 19 2017-10-30T00:55:53  *** quantbot has joined #bitcoin-core-dev
 20 2017-10-30T00:56:04  *** grio has joined #bitcoin-core-dev
 21 2017-10-30T00:56:33  *** quantbot has joined #bitcoin-core-dev
 22 2017-10-30T00:56:33  *** fanquake has joined #bitcoin-core-dev
 23 2017-10-30T00:57:39  <fanquake> cfields Could the fact that our GCC func attribute macro is missing the check for fallthrough be contributing to any issues?
 24 2017-10-30T00:57:55  *** dabura667 has joined #bitcoin-core-dev
 25 2017-10-30T00:58:54  *** goatpig has quit IRC
 26 2017-10-30T00:58:55  *** fanquake has quit IRC
 27 2017-10-30T00:58:57  *** LumberCartel_ has quit IRC
 28 2017-10-30T00:59:21  *** meshcollider has joined #bitcoin-core-dev
 29 2017-10-30T01:01:19  *** quantbot has quit IRC
 30 2017-10-30T01:04:59  *** fanquake has joined #bitcoin-core-dev
 31 2017-10-30T01:29:11  *** ula has quit IRC
 32 2017-10-30T01:47:31  *** uneeb has joined #bitcoin-core-dev
 33 2017-10-30T01:52:21  *** quantbot has joined #bitcoin-core-dev
 34 2017-10-30T01:56:46  *** grio has quit IRC
 35 2017-10-30T02:09:50  *** warxhead has joined #bitcoin-core-dev
 36 2017-10-30T02:32:04  *** grio has joined #bitcoin-core-dev
 37 2017-10-30T02:34:32  *** dermoth has quit IRC
 38 2017-10-30T02:34:57  *** dermoth has joined #bitcoin-core-dev
 39 2017-10-30T02:39:35  *** jb55 has joined #bitcoin-core-dev
 40 2017-10-30T03:10:30  <cluelessperson> ;;blocks
 41 2017-10-30T03:10:30  <gribble> 492291
 42 2017-10-30T03:10:34  <cluelessperson> WOOT
 43 2017-10-30T03:10:40  <cluelessperson> first pruned up up
 44 2017-10-30T03:12:26  <cluelessperson> looks like a pruned node of 550 MB took me from 2017-10-29 21:37:55 to 2017-10-30 03:10:21 to sync.
 45 2017-10-30T03:14:20  <esotericnonsense> \o/
 46 2017-10-30T03:14:45  <cluelessperson> End pruned size, 3.6 GB
 47 2017-10-30T03:15:07  <cluelessperson> 508Mblocks
 48 2017-10-30T03:15:14  <cluelessperson> 3.0Gchainstate
 49 2017-10-30T03:15:26  <cluelessperson> 115Mdebug.log
 50 2017-10-30T03:16:24  <esotericnonsense> cluelessperson: if the log is not sensitive it might be useful for https://github.com/bitcoin/bitcoin/pull/11359
 51 2017-10-30T03:16:58  <esotericnonsense> this PR does not seem popular (sdaftuar's comments on flushes will likely lead to a better solution)
 52 2017-10-30T03:17:21  <esotericnonsense> but from the log file it should be possible to guess at time wasted :)
 53 2017-10-30T03:21:33  <cluelessperson> esotericnonsense: These are just tests pointed at the localhost node, on a PCISSD, so yeah, I can share
 54 2017-10-30T03:21:44  <cluelessperson> esotericnonsense: you want me to just attach the log file to that link?
 55 2017-10-30T03:22:07  <esotericnonsense> cluelessperson: re your chat in #bitcoin if you actually want to and have time it would be nice to see a benchmark of non-pruning sync time against the same target (e.g. without network node variance)
 56 2017-10-30T03:22:21  <esotericnonsense> sure maybe gzip it or something though :P
 57 2017-10-30T03:23:09  <cluelessperson> esotericnonsense: to summarize agreed point, you'd like me to resync under the same conditions, without pruning?
 58 2017-10-30T03:23:19  <cluelessperson> esotericnonsense: allowing you to view pruned and non-pruned results?
 59 2017-10-30T03:23:45  <esotericnonsense> yeah. it's not that important, I already know the results, i'm just interested in precisely how much fastr it ends up being
 60 2017-10-30T03:23:47  <esotericnonsense> faster*
 61 2017-10-30T03:24:59  <cluelessperson> esotericnonsense: how much faster pruning ends up being? or not pruning ends up being than pruned?
 62 2017-10-30T03:25:07  <cluelessperson> and GO!
 63 2017-10-30T03:25:09  <cluelessperson> it's running
 64 2017-10-30T03:25:31  <esotericnonsense> cluelessperson: not pruning should be faster because the utxo cache gets flushed completely on every prune event
 65 2017-10-30T03:25:44  <esotericnonsense> which is every ~128mb
 66 2017-10-30T03:25:50  <cluelessperson> ah
 67 2017-10-30T03:26:37  <cluelessperson> esotericnonsense: for the record, these are my settings https://hastebin.com/raw/povagogajo
 68 2017-10-30T03:27:26  <cluelessperson> esotericnonsense: I have the dbcache set to 10000
 69 2017-10-30T03:30:36  <cluelessperson> esotericnonsense: it looks faster
 70 2017-10-30T03:31:55  <esotericnonsense> it won't make much difference until you get a sizeable dbcache but yeah it is faster. just wondering whether it's actually say half the time. i killed it at block 200K because I only have one ssd and need the space :P
 71 2017-10-30T03:32:57  <cluelessperson> esotericnonsense: it's already at 10%
 72 2017-10-30T03:57:44  *** twistedline has quit IRC
 73 2017-10-30T04:02:11  *** twistedline has joined #bitcoin-core-dev
 74 2017-10-30T04:12:16  *** quantbot has quit IRC
 75 2017-10-30T04:14:00  *** quantbot has joined #bitcoin-core-dev
 76 2017-10-30T04:35:24  <cluelessperson> esotericnonsense: well, unfortunately, I ran out of space
 77 2017-10-30T04:35:28  <cluelessperson> esotericnonsense: but it seems WAY faster
 78 2017-10-30T04:43:13  *** chjj has quit IRC
 79 2017-10-30T04:44:22  *** LumberCartel has joined #bitcoin-core-dev
 80 2017-10-30T05:03:41  *** uneeb has quit IRC
 81 2017-10-30T05:06:27  *** twistedline has quit IRC
 82 2017-10-30T05:11:36  *** twistedline has joined #bitcoin-core-dev
 83 2017-10-30T05:14:46  *** adiabat has quit IRC
 84 2017-10-30T05:15:57  *** twistedline has quit IRC
 85 2017-10-30T05:20:21  *** twistedline has joined #bitcoin-core-dev
 86 2017-10-30T05:38:04  *** d9b4bef9 has quit IRC
 87 2017-10-30T05:39:10  *** d9b4bef9 has joined #bitcoin-core-dev
 88 2017-10-30T05:49:21  *** grio has quit IRC
 89 2017-10-30T06:34:01  *** dermoth has quit IRC
 90 2017-10-30T06:34:26  *** dermoth has joined #bitcoin-core-dev
 91 2017-10-30T06:36:03  *** thebadguy has joined #bitcoin-core-dev
 92 2017-10-30T06:38:11  *** thebadguy has quit IRC
 93 2017-10-30T06:53:03  *** quantbot has quit IRC
 94 2017-10-30T07:10:25  *** justanotheruser has quit IRC
 95 2017-10-30T07:11:11  *** ula has joined #bitcoin-core-dev
 96 2017-10-30T07:13:03  *** sukdctliht has joined #bitcoin-core-dev
 97 2017-10-30T07:18:04  *** tripleslash has quit IRC
 98 2017-10-30T07:18:58  *** jouke has quit IRC
 99 2017-10-30T07:20:32  *** vzjrsrdtsu has joined #bitcoin-core-dev
100 2017-10-30T07:20:57  *** ygrkppfmsv has joined #bitcoin-core-dev
101 2017-10-30T07:30:30  *** tripleslash has joined #bitcoin-core-dev
102 2017-10-30T07:34:23  *** justanotheruser has joined #bitcoin-core-dev
103 2017-10-30T07:35:08  *** jouke has joined #bitcoin-core-dev
104 2017-10-30T07:41:35  *** jouke has quit IRC
105 2017-10-30T07:46:22  *** rlnbbyxnek has joined #bitcoin-core-dev
106 2017-10-30T07:53:16  *** mhldybpsda has joined #bitcoin-core-dev
107 2017-10-30T07:59:57  *** jouke has joined #bitcoin-core-dev
108 2017-10-30T08:11:46  *** AaronvanW has joined #bitcoin-core-dev
109 2017-10-30T08:21:03  *** laurentmt has joined #bitcoin-core-dev
110 2017-10-30T08:39:54  *** venzen has quit IRC
111 2017-10-30T09:15:31  *** Guyver2 has joined #bitcoin-core-dev
112 2017-10-30T09:21:03  *** d9b4bef9 has quit IRC
113 2017-10-30T09:22:20  *** d9b4bef9 has joined #bitcoin-core-dev
114 2017-10-30T09:27:05  *** wxss has joined #bitcoin-core-dev
115 2017-10-30T09:33:38  <bitcoin-git> [bitcoin] practicalswift opened pull request #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN (master...DEBUG_ADDRMAN-warnings) https://github.com/bitcoin/bitcoin/pull/11577
116 2017-10-30T09:37:20  *** timothy has joined #bitcoin-core-dev
117 2017-10-30T09:41:34  *** warxhead has quit IRC
118 2017-10-30T09:42:27  *** Emcy_ has quit IRC
119 2017-10-30T09:58:17  *** Emcy has joined #bitcoin-core-dev
120 2017-10-30T09:59:42  *** intcat has quit IRC
121 2017-10-30T10:00:39  *** intcat has joined #bitcoin-core-dev
122 2017-10-30T10:12:18  *** promag has joined #bitcoin-core-dev
123 2017-10-30T10:23:46  *** dabura667 has quit IRC
124 2017-10-30T10:39:07  *** xinxi has quit IRC
125 2017-10-30T10:39:41  *** xinxi has joined #bitcoin-core-dev
126 2017-10-30T10:40:44  *** m8tion has joined #bitcoin-core-dev
127 2017-10-30T11:00:08  *** xinxi has quit IRC
128 2017-10-30T11:01:49  *** xinxi has joined #bitcoin-core-dev
129 2017-10-30T11:06:02  *** xinxi has quit IRC
130 2017-10-30T11:09:12  *** promag has quit IRC
131 2017-10-30T11:15:10  *** promag has joined #bitcoin-core-dev
132 2017-10-30T11:22:11  *** Aaronvan_ has joined #bitcoin-core-dev
133 2017-10-30T11:22:36  *** Aaronvan_ is now known as AaronvanW_
134 2017-10-30T11:25:07  *** AaronvanW has quit IRC
135 2017-10-30T11:31:59  *** quantbot has joined #bitcoin-core-dev
136 2017-10-30T11:32:22  *** xinxi has joined #bitcoin-core-dev
137 2017-10-30T11:34:38  *** mmgen has joined #bitcoin-core-dev
138 2017-10-30T11:36:32  *** quantbot has quit IRC
139 2017-10-30T11:39:20  *** pergaminho has joined #bitcoin-core-dev
140 2017-10-30T11:47:57  *** str4d has quit IRC
141 2017-10-30T11:52:04  *** m8tion has quit IRC
142 2017-10-30T11:52:54  *** str4d has joined #bitcoin-core-dev
143 2017-10-30T12:04:57  *** str4d has quit IRC
144 2017-10-30T12:06:08  *** Deadhand has quit IRC
145 2017-10-30T12:06:16  *** Deadhandd has joined #bitcoin-core-dev
146 2017-10-30T12:10:09  *** Deadhandd has quit IRC
147 2017-10-30T12:10:56  *** Deadhand has joined #bitcoin-core-dev
148 2017-10-30T12:14:25  *** xinxi has quit IRC
149 2017-10-30T12:19:10  *** m8tion has joined #bitcoin-core-dev
150 2017-10-30T12:22:37  *** xinxi has joined #bitcoin-core-dev
151 2017-10-30T12:27:13  *** xinxi has quit IRC
152 2017-10-30T12:41:36  *** xinxi has joined #bitcoin-core-dev
153 2017-10-30T12:44:05  *** tripleslash has quit IRC
154 2017-10-30T12:47:56  *** tripleslash has joined #bitcoin-core-dev
155 2017-10-30T12:50:47  *** jtimon has joined #bitcoin-core-dev
156 2017-10-30T12:57:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
157 2017-10-30T13:06:07  *** promag has quit IRC
158 2017-10-30T13:21:31  *** pbase has joined #bitcoin-core-dev
159 2017-10-30T13:22:28  *** owowo has quit IRC
160 2017-10-30T13:25:06  *** meshcollider has quit IRC
161 2017-10-30T13:27:36  *** owowo has joined #bitcoin-core-dev
162 2017-10-30T13:32:04  *** d9b4bef9 has quit IRC
163 2017-10-30T13:32:42  *** promag has joined #bitcoin-core-dev
164 2017-10-30T13:33:10  *** quantbot has joined #bitcoin-core-dev
165 2017-10-30T13:33:19  *** d9b4bef9 has joined #bitcoin-core-dev
166 2017-10-30T13:33:41  *** quantbot has quit IRC
167 2017-10-30T13:33:44  *** grio has joined #bitcoin-core-dev
168 2017-10-30T13:34:06  *** quantbot has joined #bitcoin-core-dev
169 2017-10-30T13:35:03  *** quantbot has joined #bitcoin-core-dev
170 2017-10-30T13:36:44  *** mmgen has quit IRC
171 2017-10-30T13:36:57  <bitcoin-git> [bitcoin] practicalswift opened pull request #11578: net: Add missing lock in ProcessHeadersMessage(...) (master...ProcessHeadersMessage) https://github.com/bitcoin/bitcoin/pull/11578
172 2017-10-30T13:37:31  *** SopaXorzTaker has joined #bitcoin-core-dev
173 2017-10-30T13:38:15  *** quantbot has left #bitcoin-core-dev
174 2017-10-30T13:40:01  *** promag has quit IRC
175 2017-10-30T13:53:47  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
176 2017-10-30T13:53:47  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
177 2017-10-30T13:58:49  <bitcoin-git> [bitcoin] gladosconn opened pull request #11579: Fix int uint64_t comparison warning. (master...master) https://github.com/bitcoin/bitcoin/pull/11579
178 2017-10-30T14:09:03  *** mmgen has joined #bitcoin-core-dev
179 2017-10-30T14:12:10  *** promag has joined #bitcoin-core-dev
180 2017-10-30T14:20:57  *** AaronvanW_ is now known as AaronvanW
181 2017-10-30T14:27:00  *** JohnDoe_ has joined #bitcoin-core-dev
182 2017-10-30T14:28:26  *** LumberCartel_ has joined #bitcoin-core-dev
183 2017-10-30T14:30:30  *** quantbot_ has joined #bitcoin-core-dev
184 2017-10-30T14:31:02  *** LumberCartel has quit IRC
185 2017-10-30T14:31:38  <bitcoin-git> [bitcoin] gladosconn closed pull request #11579: Fix int uint64_t comparison warning. (master...master) https://github.com/bitcoin/bitcoin/pull/11579
186 2017-10-30T14:32:03  *** LumberCartel_ has quit IRC
187 2017-10-30T14:32:26  *** LumberCartel has joined #bitcoin-core-dev
188 2017-10-30T14:33:27  *** wolfspraul has quit IRC
189 2017-10-30T14:33:34  *** wolfspraul has joined #bitcoin-core-dev
190 2017-10-30T14:36:57  *** grio has quit IRC
191 2017-10-30T14:40:12  *** quantbot_ has quit IRC
192 2017-10-30T14:40:42  *** quantbot has joined #bitcoin-core-dev
193 2017-10-30T14:41:41  *** quantbot has joined #bitcoin-core-dev
194 2017-10-30T14:45:37  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11580: Do not send (potentially) invalid headers in response to getheaders (master...2017-10-getheaders-valid-only) https://github.com/bitcoin/bitcoin/pull/11580
195 2017-10-30T14:56:49  <wxss> sipa mentioned undocumented -stopatheight here yesterday. Is the opposite possible, to restart downloading at/from a specified block height?
196 2017-10-30T14:57:22  <promag> BlueMatt: mapBlockIndex can contain "invalid" blocks (where IsValid(BLOCK_VALID_SCRIPTS) is false)?
197 2017-10-30T15:01:35  <sipa> promag: yes, absolutely
198 2017-10-30T15:01:43  <sipa> as blocks are only validated after storing them
199 2017-10-30T15:01:53  <jimpo> promag: They wouldn't necessarily be "invalid", just not known to be valid.
200 2017-10-30T15:02:10  <sipa> mapBlockIndex only guarantees that the *headers* are valid
201 2017-10-30T15:02:22  <jimpo> Though I think the index includes invalid blocks as well
202 2017-10-30T15:02:31  <sipa> the blocks themselves are downloaded afterwards, and may turn out to be invalid
203 2017-10-30T15:02:52  <sipa> jimpo: yes, we store invalid blocks in the index
204 2017-10-30T15:03:15  <promag> and once invalid it is kept in the index?
205 2017-10-30T15:03:20  <sipa> yes
206 2017-10-30T15:03:27  <sipa> the header will be marked as invalid even
207 2017-10-30T15:04:13  *** quantbot has quit IRC
208 2017-10-30T15:04:36  <promag> so the following can be simplified:
209 2017-10-30T15:04:38  <promag> if (punish_duplicate_invalid && mapBlockIndex.find(first_invalid_header.GetHash()) != mapBlockIndex.end())
210 2017-10-30T15:04:39  *** quantbot has joined #bitcoin-core-dev
211 2017-10-30T15:04:58  <promag> because if the header is invalid then it is not in the block index right?
212 2017-10-30T15:05:30  *** quantbot has quit IRC
213 2017-10-30T15:05:36  *** quantbot has joined #bitcoin-core-dev
214 2017-10-30T15:06:10  <promag> since above you said "mapBlockIndex only guarantees that the *headers* are valid"
215 2017-10-30T15:07:05  *** pbase has quit IRC
216 2017-10-30T15:07:53  <luke-jr> hmm, is there a good overview of what is needed to add -usehd=0 back in?
217 2017-10-30T15:08:18  <BlueMatt> promag: you mean in sdaftuar's pr?
218 2017-10-30T15:08:21  <luke-jr> basically just make sure it works without a default key, right?
219 2017-10-30T15:08:42  <BlueMatt> promag: no, the point of that check is to see if the header was accepted (ie if it is known to be a valid header)
220 2017-10-30T15:09:19  *** quantbot has quit IRC
221 2017-10-30T15:09:46  *** quantbot has joined #bitcoin-core-dev
222 2017-10-30T15:13:31  *** fanquake has quit IRC
223 2017-10-30T15:14:07  *** quantbot has quit IRC
224 2017-10-30T15:15:57  <promag> @BlueMatt please correct me if this isn't the same: if (punish_duplicate_invalid && !first_invalid_header.IsNull())
225 2017-10-30T15:23:33  *** jb55 has quit IRC
226 2017-10-30T15:26:19  *** chjj has joined #bitcoin-core-dev
227 2017-10-30T15:35:23  *** Alkhara has quit IRC
228 2017-10-30T15:38:03  *** ghost43 has quit IRC
229 2017-10-30T15:38:27  *** ghost43 has joined #bitcoin-core-dev
230 2017-10-30T15:44:02  *** grio has joined #bitcoin-core-dev
231 2017-10-30T15:44:50  *** quantbot has joined #bitcoin-core-dev
232 2017-10-30T15:45:46  *** quantbot has joined #bitcoin-core-dev
233 2017-10-30T15:58:59  *** LumberCartel has quit IRC
234 2017-10-30T16:06:16  *** jb55 has joined #bitcoin-core-dev
235 2017-10-30T16:16:56  *** quantbot_ has joined #bitcoin-core-dev
236 2017-10-30T16:20:08  *** quantbot has quit IRC
237 2017-10-30T16:21:24  *** quantbot_ has quit IRC
238 2017-10-30T16:33:23  *** wolfspraul has quit IRC
239 2017-10-30T16:33:32  *** wolfspraul has joined #bitcoin-core-dev
240 2017-10-30T16:37:52  *** LumberCartel has joined #bitcoin-core-dev
241 2017-10-30T16:46:23  *** esotericnonsense has quit IRC
242 2017-10-30T16:55:36  *** Chris_Stewart_5 has quit IRC
243 2017-10-30T16:56:56  <sdaftuar> can someone tag #11578 for backport to 0.15.0.2?
244 2017-10-30T16:56:58  <gribble> https://github.com/bitcoin/bitcoin/issues/11578 | net: Add missing lock in ProcessHeadersMessage(...) by practicalswift · Pull Request #11578 · bitcoin/bitcoin · GitHub
245 2017-10-30T17:03:22  *** pergaminho has quit IRC
246 2017-10-30T17:03:23  *** jb55 has quit IRC
247 2017-10-30T17:04:39  <wumpus> sdaftuar: done
248 2017-10-30T17:04:46  <sdaftuar> thanks!
249 2017-10-30T17:05:14  *** pergaminho has joined #bitcoin-core-dev
250 2017-10-30T17:17:40  <achow101> luke-jr: it has to work without a default key and cannot be downgraded
251 2017-10-30T17:18:37  <achow101> promag: the first_invalid_header could be in mapBlockIndex
252 2017-10-30T17:19:42  *** jb55 has joined #bitcoin-core-dev
253 2017-10-30T17:21:49  <achow101> promag: specifically if a block was invalid but the header was valid, the header would be in mapBlockIndex. if another peer sent us the exact same header, it would still be in mapBlockIndex and that is what that if statement is checking for
254 2017-10-30T17:28:01  *** xinxi has quit IRC
255 2017-10-30T17:28:36  *** Dizzle has joined #bitcoin-core-dev
256 2017-10-30T17:28:36  *** xinxi has joined #bitcoin-core-dev
257 2017-10-30T17:46:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
258 2017-10-30T18:00:17  *** timothy has quit IRC
259 2017-10-30T18:01:45  *** Gnof has joined #bitcoin-core-dev
260 2017-10-30T18:02:56  *** SopaXorzTaker has quit IRC
261 2017-10-30T18:11:46  *** quantbot has joined #bitcoin-core-dev
262 2017-10-30T18:12:11  *** quantbot has joined #bitcoin-core-dev
263 2017-10-30T18:20:31  *** m8tion has quit IRC
264 2017-10-30T18:27:51  <sdaftuar> has travis been flaky lately?  i'm seeing a wallet.py error in one of the functional tests runs for #11560
265 2017-10-30T18:27:53  <gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub
266 2017-10-30T18:28:37  *** Chris_Stewart_5 has quit IRC
267 2017-10-30T18:29:38  <sipa> badstatusline
268 2017-10-30T18:29:44  *** quantbot has quit IRC
269 2017-10-30T18:29:46  <sipa> (line 2818)
270 2017-10-30T18:29:58  *** quantbot has joined #bitcoin-core-dev
271 2017-10-30T18:29:59  <sdaftuar> yeah i don't know what would cause that
272 2017-10-30T18:30:45  <sipa> let's try restarting
273 2017-10-30T18:32:14  <sdaftuar> restarted
274 2017-10-30T18:34:40  *** LumberCartel has quit IRC
275 2017-10-30T18:34:41  <BlueMatt> ryanofsky: did you actually see the test in #11531 hang?
276 2017-10-30T18:34:43  <gribble> https://github.com/bitcoin/bitcoin/issues/11531 | Check that new headers are not a descendant of an invalid block (more effeciently) by TheBlueMatt · Pull Request #11531 · bitcoin/bitcoin · GitHub
277 2017-10-30T18:34:45  <BlueMatt> I can bump the timeout there
278 2017-10-30T18:34:55  <ryanofsky> no
279 2017-10-30T18:35:39  <ryanofsky> the code just seems unnecessarily complicated and probably flaky
280 2017-10-30T18:36:35  <BlueMatt> I mean all I can do is bump the timeout there, really
281 2017-10-30T18:36:47  <BlueMatt> I think when i go to rewrite the dos logic stuff soon it will change behavior
282 2017-10-30T18:36:53  <BlueMatt> and no need for the test to test for it
283 2017-10-30T18:37:48  *** wxss has quit IRC
284 2017-10-30T18:39:05  <ryanofsky> can you simplify the test by skipping the ping and just waiting for the disconnect?
285 2017-10-30T18:40:08  <BlueMatt> no, because I believe it currently does not disconnect
286 2017-10-30T18:40:11  <BlueMatt> right now it uses the ping path
287 2017-10-30T18:40:17  <BlueMatt> but really it should be disconnecting
288 2017-10-30T18:41:26  <ryanofsky> then i don't see what you lose by dropping the exception handler completely and updating the test when you do add a disconnect
289 2017-10-30T18:41:42  <BlueMatt> because I'm probably gonna need the exception handler in like a month
290 2017-10-30T18:41:52  <BlueMatt> and testing for something that bitcoind really shouldnt be doing anyway is kinda nonsense
291 2017-10-30T18:42:27  <ryanofsky> how do you even know the exception handler works?
292 2017-10-30T18:43:48  <BlueMatt> i tested it :)
293 2017-10-30T18:44:20  <BlueMatt> iirc you can just change the dos points for whatever case its using to make the block invalid trivially and it'll keep chugging along
294 2017-10-30T18:48:22  <ryanofsky> ok well do what you want, but if were me i would opt for not adding a potentially flaky 1-sec timeout and confusing code that doesn't get executed
295 2017-10-30T18:50:07  <bitcoin-git> [bitcoin] luke-jr opened pull request #11582: wallet: Restore -usehd=0 option (master...usehd) https://github.com/bitcoin/bitcoin/pull/11582
296 2017-10-30T18:50:25  *** warxhead has joined #bitcoin-core-dev
297 2017-10-30T18:52:49  <BlueMatt> i mean its not like we dont have other timeouts in the tests, no?
298 2017-10-30T18:52:55  *** pergaminho has quit IRC
299 2017-10-30T18:52:57  <BlueMatt> I can set it higher if that makes it much less flaky
300 2017-10-30T18:53:40  *** wxss has joined #bitcoin-core-dev
301 2017-10-30T18:54:45  *** pergaminho has joined #bitcoin-core-dev
302 2017-10-30T18:58:29  *** intcat has quit IRC
303 2017-10-30T18:59:37  *** intcat has joined #bitcoin-core-dev
304 2017-10-30T19:00:43  *** pergaminho has quit IRC
305 2017-10-30T19:02:08  *** pergaminho has joined #bitcoin-core-dev
306 2017-10-30T19:03:53  *** quantbot has quit IRC
307 2017-10-30T19:04:29  *** quantbot has joined #bitcoin-core-dev
308 2017-10-30T19:05:18  *** quantbot has quit IRC
309 2017-10-30T19:05:33  *** quantbot has joined #bitcoin-core-dev
310 2017-10-30T19:12:47  *** laurentmt has quit IRC
311 2017-10-30T19:30:12  *** Cheeseo has joined #bitcoin-core-dev
312 2017-10-30T19:34:58  *** cheese_ has joined #bitcoin-core-dev
313 2017-10-30T19:38:31  *** Cheeseo has quit IRC
314 2017-10-30T19:43:34  *** esotericnonsense has joined #bitcoin-core-dev
315 2017-10-30T19:45:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
316 2017-10-30T19:50:27  *** jb55 has quit IRC
317 2017-10-30T19:58:34  *** Chris_Stewart_5 has quit IRC
318 2017-10-30T20:02:32  *** cheese_ has quit IRC
319 2017-10-30T20:03:01  *** cheese_ has joined #bitcoin-core-dev
320 2017-10-30T20:03:44  *** Dizzle has quit IRC
321 2017-10-30T20:06:45  *** meshcollider has joined #bitcoin-core-dev
322 2017-10-30T20:11:24  *** LumberCartel has joined #bitcoin-core-dev
323 2017-10-30T20:16:30  *** maaku has joined #bitcoin-core-dev
324 2017-10-30T20:17:03  <maaku> does anyone have a list of version bits currently being used, including unofficially?
325 2017-10-30T20:19:25  <ossifrage> I wonder what the 0.15.x based btc1 code did to break networking during initial block download (it runs for a while, then all the peers timeout, then I get nothing but version handshake timeouts and it makes minimal further progress with 0 or 1 peers)
326 2017-10-30T20:21:35  *** jb55 has joined #bitcoin-core-dev
327 2017-10-30T20:30:57  *** LumberCartel has quit IRC
328 2017-10-30T20:34:40  *** Gnof has quit IRC
329 2017-10-30T20:37:06  <gmaxwell> ossifrage: sounds like you're confirming something like wxss's result-- but sadly, this is offtopic for here, as we don't debug adversarial fork's problems here. :)
330 2017-10-30T20:38:38  <ossifrage> gmaxwell, I agree, I was just curious how it could break in such a odd way.
331 2017-10-30T20:41:58  *** maaku has left #bitcoin-core-dev
332 2017-10-30T20:55:33  <wxss> gmaxwell, absolutely agree. My issue was different, but this is not the place for analyzing it further
333 2017-10-30T20:57:39  *** quantbot has joined #bitcoin-core-dev
334 2017-10-30T21:01:24  *** quantbot has quit IRC
335 2017-10-30T21:02:00  *** quantbot has joined #bitcoin-core-dev
336 2017-10-30T21:04:26  *** quantbot has quit IRC
337 2017-10-30T21:04:39  *** quantbot has joined #bitcoin-core-dev
338 2017-10-30T21:15:31  *** quantbot has quit IRC
339 2017-10-30T21:17:27  *** mmgen has quit IRC
340 2017-10-30T21:20:49  *** quantbot has joined #bitcoin-core-dev
341 2017-10-30T21:38:09  *** jb55 has quit IRC
342 2017-10-30T21:40:03  *** RoyceX has joined #bitcoin-core-dev
343 2017-10-30T21:53:35  *** grio has quit IRC
344 2017-10-30T22:06:34  *** jb55 has joined #bitcoin-core-dev
345 2017-10-30T22:15:40  *** ghost43 has quit IRC
346 2017-10-30T22:16:03  *** ghost43 has joined #bitcoin-core-dev
347 2017-10-30T22:24:04  *** d9b4bef9 has quit IRC
348 2017-10-30T22:25:10  *** d9b4bef9 has joined #bitcoin-core-dev
349 2017-10-30T22:28:06  *** intcat has quit IRC
350 2017-10-30T22:32:33  *** intcat has joined #bitcoin-core-dev
351 2017-10-30T22:37:46  *** Cogito_Ergo_Sum has quit IRC
352 2017-10-30T22:39:35  *** Guyver2 has quit IRC
353 2017-10-30T23:00:38  *** Deacyde has joined #bitcoin-core-dev
354 2017-10-30T23:01:34  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11583: Do not make it trivial for inbound peers to generate log entries (master...2017-10-no-net-log) https://github.com/bitcoin/bitcoin/pull/11583
355 2017-10-30T23:07:09  *** LumberCartel has joined #bitcoin-core-dev
356 2017-10-30T23:12:58  *** cheese_ has quit IRC
357 2017-10-30T23:16:16  *** RoyceX has quit IRC
358 2017-10-30T23:21:27  *** LumberCartel has quit IRC
359 2017-10-30T23:21:41  *** Deacyde has quit IRC
360 2017-10-30T23:22:05  *** Deacyde has joined #bitcoin-core-dev
361 2017-10-30T23:27:07  *** Deacyde has quit IRC
362 2017-10-30T23:27:45  *** Deacyde has joined #bitcoin-core-dev
363 2017-10-30T23:29:40  *** Deacyde has joined #bitcoin-core-dev
364 2017-10-30T23:32:20  *** Deacyde has quit IRC
365 2017-10-30T23:32:50  *** Deacyde has joined #bitcoin-core-dev
366 2017-10-30T23:38:07  *** jb55 has quit IRC
367 2017-10-30T23:50:19  *** quantbot has quit IRC