1 2017-11-14T00:09:37  *** go1111111 has quit IRC
  2 2017-11-14T00:13:41  *** Dizzle has quit IRC
  3 2017-11-14T00:14:35  <bitcoin-git> [bitcoin] achow101 opened pull request #11678: [wip][wallet] Don't shut down after encrypting the wallet (master...encrypt-no-restart) https://github.com/bitcoin/bitcoin/pull/11678
  4 2017-11-14T01:06:47  <phantomcircuit> achow101, i have 2m ... somewhere
  5 2017-11-14T01:07:21  <achow101> phantomcircuit: ??
  6 2017-11-14T01:08:50  <gmaxwell> achow101: I assume he means testnet coins.
  7 2017-11-14T01:09:11  <achow101> ah
  8 2017-11-14T01:09:19  <sipa> in other words: if TN coins ever have a trade value, phantomcircuit will just crash the market?
  9 2017-11-14T01:10:11  <achow101> one could argue that testnet coins have a trade value now
 10 2017-11-14T01:10:35  <sipa> iirc it was once 3 BTC for 10000 tnBTC
 11 2017-11-14T01:15:37  <phantomcircuit> lol
 12 2017-11-14T01:15:41  <phantomcircuit> sipa, DEAL
 13 2017-11-14T01:15:42  <phantomcircuit> xd
 14 2017-11-14T01:16:16  *** tloriato has joined #bitcoin-core-dev
 15 2017-11-14T01:16:26  <sipa> haha
 16 2017-11-14T01:16:42  <sipa> the market may not have been particularly deep back then :p
 17 2017-11-14T01:17:26  <tloriato> good evening, gentlemen. i was reading a little more about schnorr signatures and i'm pretty excited about it
 18 2017-11-14T01:17:43  <tloriato> i was wondering if we have any tests already running or an ETA on that?
 19 2017-11-14T01:17:54  <sipa> tloriato: let's move to #bitcoin-wizards
 20 2017-11-14T01:22:15  *** pandabull has joined #bitcoin-core-dev
 21 2017-11-14T01:24:45  *** pandabull has quit IRC
 22 2017-11-14T01:25:05  *** pandabull has joined #bitcoin-core-dev
 23 2017-11-14T01:31:01  *** StopAndDecrypt has quit IRC
 24 2017-11-14T01:33:48  *** StopAndDecrypt has joined #bitcoin-core-dev
 25 2017-11-14T01:34:48  *** Ylbam has quit IRC
 26 2017-11-14T01:38:08  *** ChristianXK has joined #bitcoin-core-dev
 27 2017-11-14T01:43:00  *** blockchain has quit IRC
 28 2017-11-14T01:43:43  *** Itachi has joined #bitcoin-core-dev
 29 2017-11-14T01:48:00  *** Itachi has quit IRC
 30 2017-11-14T01:52:52  <bitcoin-git> [bitcoin] Thoragh closed pull request #11533: Docs: Update WSL installation notes for Fall Creators update (master...Update-WSL-installation-for-Fall-Creators-update) https://github.com/bitcoin/bitcoin/pull/11533
 31 2017-11-14T01:56:04  <midnightmagic> phantomcircuit's not the only one. lol
 32 2017-11-14T01:56:28  <midnightmagic> Dunno who it was who put all those diff-1 post-block diff hack blocks in there but someone was doing it for hundreds of thousands of blocks.
 33 2017-11-14T01:57:28  *** justanotheruser has quit IRC
 34 2017-11-14T02:02:42  *** Itachi has joined #bitcoin-core-dev
 35 2017-11-14T02:06:01  *** tloriato has quit IRC
 36 2017-11-14T02:07:12  <bitcoin-git> [bitcoin] Thoragh reopened pull request #11533: Docs: Update WSL installation notes for Fall Creators update (master...Update-WSL-installation-for-Fall-Creators-update) https://github.com/bitcoin/bitcoin/pull/11533
 37 2017-11-14T02:07:15  *** Itachi has quit IRC
 38 2017-11-14T02:08:25  *** ChristianXK has quit IRC
 39 2017-11-14T02:14:57  *** nickler has quit IRC
 40 2017-11-14T02:19:24  *** Murch has quit IRC
 41 2017-11-14T02:20:59  *** luke-jr has quit IRC
 42 2017-11-14T02:21:23  *** luke-jr has joined #bitcoin-core-dev
 43 2017-11-14T02:21:47  *** nickler has joined #bitcoin-core-dev
 44 2017-11-14T02:23:59  *** jjxtra has joined #bitcoin-core-dev
 45 2017-11-14T02:27:55  *** AaronvanW has quit IRC
 46 2017-11-14T02:33:26  <dcousens> any love for a `droptransaction` from mempool rpc call?
 47 2017-11-14T02:34:54  *** AaronvanW has joined #bitcoin-core-dev
 48 2017-11-14T02:37:06  *** Aaronvan_ has joined #bitcoin-core-dev
 49 2017-11-14T02:40:01  *** AaronvanW has quit IRC
 50 2017-11-14T02:47:57  *** Aaronvan_ has quit IRC
 51 2017-11-14T02:48:30  *** AaronvanW has joined #bitcoin-core-dev
 52 2017-11-14T02:52:57  *** AaronvanW has quit IRC
 53 2017-11-14T02:58:20  *** ghost43 has quit IRC
 54 2017-11-14T02:59:15  *** ghost43 has joined #bitcoin-core-dev
 55 2017-11-14T03:00:17  *** jb55 has quit IRC
 56 2017-11-14T03:51:06  *** pandabull has quit IRC
 57 2017-11-14T03:51:44  *** pandabull has joined #bitcoin-core-dev
 58 2017-11-14T03:53:37  *** bule2 has joined #bitcoin-core-dev
 59 2017-11-14T03:55:52  *** pandabull has quit IRC
 60 2017-11-14T03:57:00  *** bule has quit IRC
 61 2017-11-14T03:57:54  *** bule has joined #bitcoin-core-dev
 62 2017-11-14T03:59:08  *** bule2 has quit IRC
 63 2017-11-14T04:07:07  *** jrayhawk_ is now known as jrayhawk
 64 2017-11-14T04:10:51  *** photonclock has joined #bitcoin-core-dev
 65 2017-11-14T04:19:12  *** meilin has quit IRC
 66 2017-11-14T04:29:16  *** dabura667 has joined #bitcoin-core-dev
 67 2017-11-14T04:39:37  *** pandabull has joined #bitcoin-core-dev
 68 2017-11-14T04:43:52  *** pandabull has quit IRC
 69 2017-11-14T04:48:00  *** pandabull has joined #bitcoin-core-dev
 70 2017-11-14T04:53:41  *** jb55 has joined #bitcoin-core-dev
 71 2017-11-14T05:07:44  *** photonclock has left #bitcoin-core-dev
 72 2017-11-14T05:43:46  *** justanotheruser has joined #bitcoin-core-dev
 73 2017-11-14T05:49:11  *** dgenr8 has quit IRC
 74 2017-11-14T05:50:05  *** dgenr8 has joined #bitcoin-core-dev
 75 2017-11-14T06:05:50  *** luke-jr has quit IRC
 76 2017-11-14T06:09:03  <phantomcircuit> midnightmagic, that's me
 77 2017-11-14T06:11:15  <midnightmagic> phantomcircuit: Oh, good then.
 78 2017-11-14T06:12:12  *** luke-jr has joined #bitcoin-core-dev
 79 2017-11-14T06:15:55  <warren> dcousens: I'd love that personally
 80 2017-11-14T06:16:48  <sipa> what for?
 81 2017-11-14T06:32:01  *** chjj has quit IRC
 82 2017-11-14T06:33:53  <wumpus> doesn't abandoning a transaction from the wallet remove it from the mempool?
 83 2017-11-14T06:34:26  <sipa> iirc you can only abandan a wallet transaction when it already isn't in the mempool
 84 2017-11-14T06:35:06  <wumpus> you're right, I had that the wrong way around
 85 2017-11-14T06:36:17  <wumpus> and the wallet adds all its transactions to the mempool at startup
 86 2017-11-14T06:36:30  <wumpus> (at least if not walletbroadcast=0)
 87 2017-11-14T06:38:20  <sipa> so basically abandon only works when the tx is already unacceptable to the mempool (due to conflicts with existing chain, or due to mempool full and too low fee)
 88 2017-11-14T06:38:54  <sipa> a mechanism to forcefully abandon a tx may make sense (though it's hard to prepare for it still being possible to mine)
 89 2017-11-14T06:39:18  <sipa> but i'm not sure that giving direct access to drop something from the mempool matters
 90 2017-11-14T06:40:14  <wumpus> there can be cases during development/testing where it can be marginally useful to drop things from the mempool, but it seems to much of a foot shooting option to expose generally
 91 2017-11-14T06:40:24  <sipa> right, as a debug thing sure
 92 2017-11-14T06:40:37  <sipa> at the same level as invalidateblock and reconsiderblock
 93 2017-11-14T06:41:58  <wumpus> warren's case is that he sent a transaction with way too little fee to ever be mined, without RBF, and he wants to try to get rid of it by double-spending it
 94 2017-11-14T06:42:39  <sipa> right, but you really just want a "force abandon wallet tx" there, rather than the more level "drop from mempool", i think
 95 2017-11-14T06:42:47  <wumpus> there's no guarantee it will work of course because miners and other nodes might still have it, but he still wants to try
 96 2017-11-14T06:42:56  <sipa> or even a "force accept this tx, replacing whatever is needed in the mempool"
 97 2017-11-14T06:43:47  <warren> wumpus: actually I was successful
 98 2017-11-14T06:44:02  <wumpus> the latter would be nice, as it matches what needs to be done in this case better, if you don't respend the inputs there's always the possibilty that your transaction gets replayed and mined in the future
 99 2017-11-14T06:44:24  <warren> generally I'd like the ability to remove something from my mempool without wiping the entire thing
100 2017-11-14T06:44:49  *** gaf_ has quit IRC
101 2017-11-14T06:46:10  <wumpus> but anyhow for a diagnostic, undocumented option at the level of invalidateblock/reconsiderblock I woudln't have problems with it
102 2017-11-14T06:47:11  *** gaf_ has joined #bitcoin-core-dev
103 2017-11-14T06:47:59  <wumpus> it'd be trivial to implement: make a RPC that calls removeRecursive, this will make sure the descendants are removed too
104 2017-11-14T06:49:36  <wumpus> and then pray it won't be advertised as a general "cancel transaction" solution by people who have no clue how the mempool works and think it's shared between all nodes
105 2017-11-14T06:53:21  *** baldur has quit IRC
106 2017-11-14T06:54:58  <mryandao> would it be possible to add a key-value "tx-rate" for the getmempoolinfo rpc command, where the average tx-rate of the mempool?
107 2017-11-14T06:55:16  <mryandao> *fee rate
108 2017-11-14T06:57:13  <wumpus> would be easier to keep track of the total amount of fee. But what would that info be useful for?
109 2017-11-14T06:58:17  <mryandao> so a user can decide in advance if they should make a transaction now
110 2017-11-14T06:58:40  <wumpus> estimatesmartfee would be better for that
111 2017-11-14T06:59:06  <mryandao> over the weekend, estimate smart fee wasn't very effective
112 2017-11-14T06:59:08  <sipa> or a way to query "what is the feerate in the mempool, X MB from the top"
113 2017-11-14T06:59:37  <wumpus> I mean the decision criterion would be the cost to submit a transaction now, not so much what other transaction are paying
114 2017-11-14T07:00:42  <wumpus> mryandao: the fee estimation is not perfect, but I'm not sure making people do their own fee estimation based on some (easy to manipulate) stats is a better idea
115 2017-11-14T07:01:20  <mryandao> over the weekend, i thought it might also be a good idea to keep track of the rate of growth of the mempool
116 2017-11-14T07:01:38  <sipa> mryandao: meh, "infinite" is a good approximation
117 2017-11-14T07:01:40  <mryandao> maybe the differential is useful for fee estimation
118 2017-11-14T07:01:51  <sipa> the real question is what the size is _above a certain feerate level_
119 2017-11-14T07:02:43  *** Ylbam has joined #bitcoin-core-dev
120 2017-11-14T07:05:20  *** BashCo has quit IRC
121 2017-11-14T07:11:28  <bitcoin-git> [bitcoin] jamesob opened pull request #11680: [docs] Add instructions for lcov report generation (master...lcov-docs) https://github.com/bitcoin/bitcoin/pull/11680
122 2017-11-14T07:22:52  *** LumberCartel has joined #bitcoin-core-dev
123 2017-11-14T07:24:47  *** jb55 has quit IRC
124 2017-11-14T07:37:15  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
125 2017-11-14T07:40:51  <eck> +1 for tracking the mempool rate-of-growth
126 2017-11-14T07:41:01  <eck> and derivatices and higher-order derivatives generally
127 2017-11-14T07:43:11  <wumpus> sipa's point is that rate of growth in itself isn't interesting; someone could submit an ~infinite number of low fee transactions to pad your mempool up to mempoolmax, and that should not affect fee estimates
128 2017-11-14T07:44:09  <eck> ah
129 2017-11-14T07:44:13  <wumpus> so you'd need to track something more subtle
130 2017-11-14T07:44:28  <sipa> it isn't interesting, and it also doesn't matter
131 2017-11-14T07:44:53  <sipa> if you're willing to pay X feerate, you don't care at all about any transaction that pays less than X, even if there is 10 GB of them
132 2017-11-14T07:44:57  <eck> I guess you would need the time derivative of the histogram (if you needed it at all)
133 2017-11-14T07:45:27  *** ChristianXK has joined #bitcoin-core-dev
134 2017-11-14T07:46:41  *** BashCo has joined #bitcoin-core-dev
135 2017-11-14T07:50:07  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e468994fbb3...cbb54e77a120
136 2017-11-14T07:50:07  <bitcoin-git> bitcoin/master 73a7e6d Thoragh: Update WSL installation for Fall Creators update
137 2017-11-14T07:50:08  <bitcoin-git> bitcoin/master cbb54e7 Wladimir J. van der Laan: Merge #11533: Docs: Update WSL installation notes for Fall Creators update...
138 2017-11-14T07:50:56  <eck> just thinking out loud here, but you could train a simple convolutional filter (for example) to learn the best parameters to estimate a fee rate given the fee histogram from the last N time periods; but you'd have to update the convolution parameters for each bitcoin release, and it would be trivial to find pathological values after the fact to trick the trained algorithm
139 2017-11-14T07:53:43  <sipa> eck: no way, we're not putting gameable methods in
140 2017-11-14T07:53:57  <sipa> such methods are awesome if they have human oversight
141 2017-11-14T07:54:18  <sipa> but you don't want to put them in a fully automated system that is intentionally designed to need user intervention to upgrade :)
142 2017-11-14T07:54:22  <eck> that's kind of what i thought, interesting though experiment though
143 2017-11-14T07:57:06  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cbb54e77a120...7adeea3b0fc2
144 2017-11-14T07:57:06  <bitcoin-git> bitcoin/master faaa7db MarcoFalke: qa: Only allow disconnecting all NodeConns
145 2017-11-14T07:57:07  <bitcoin-git> bitcoin/master 7adeea3 Wladimir J. van der Laan: Merge #11641: qa: Only allow disconnecting all NodeConns...
146 2017-11-14T07:57:38  <bitcoin-git> [bitcoin] laanwj closed pull request #11641: qa: Only allow disconnecting all NodeConns (master...Mf1711-qaNodeConnDisconnectAll) https://github.com/bitcoin/bitcoin/pull/11641
147 2017-11-14T08:04:12  *** JackH has quit IRC
148 2017-11-14T08:13:33  <bitcoin-git> [bitcoin] laanwj closed pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
149 2017-11-14T08:17:48  *** bule has quit IRC
150 2017-11-14T08:18:47  *** JackH has joined #bitcoin-core-dev
151 2017-11-14T08:19:52  *** Sentineo has quit IRC
152 2017-11-14T08:23:46  <meshcollider> It seems 10873 is a candidate to be the first PR with the new abandoned tag MarcoFalke created ^
153 2017-11-14T08:26:21  *** bule has joined #bitcoin-core-dev
154 2017-11-14T08:27:20  <wumpus> good idea, added
155 2017-11-14T08:36:42  <mryandao> how about taking the differential of transactions that pay a feerate greater than the min-feerate of the next block as described by `getblocktemplate`
156 2017-11-14T08:37:23  <mryandao> it should be meaningful to see the rate of incoming transaction "overtaking" transactions that should be confirmed in the following block
157 2017-11-14T08:41:05  *** unholymachine has quit IRC
158 2017-11-14T08:45:00  *** bule has quit IRC
159 2017-11-14T08:47:02  *** unholymachine has joined #bitcoin-core-dev
160 2017-11-14T08:52:59  *** baldur has joined #bitcoin-core-dev
161 2017-11-14T08:58:36  <bitcoin-git> [bitcoin] SwaddleDoddle opened pull request #11681: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11681
162 2017-11-14T09:00:03  <bitcoin-git> [bitcoin] laanwj closed pull request #11681: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11681
163 2017-11-14T09:11:52  <bitcoin-git> [bitcoin] practicalswift opened pull request #11682: wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) (master...CCryptoKeyStore-AddKeyPubKey) https://github.com/bitcoin/bitcoin/pull/11682
164 2017-11-14T09:17:01  *** harrymm has quit IRC
165 2017-11-14T09:19:07  <meshcollider> Anyone wanna review https://github.com/bitcoin-core/bitcoincore.org/pull/464 so it can be merged soon?
166 2017-11-14T09:19:21  <meshcollider> (0.15.1 release announcement on bitcoincore.org)
167 2017-11-14T09:19:41  <bitcoin-git> [bitcoin] practicalswift opened pull request #11683: tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l) (master...remove-int-vector-serialization) https://github.com/bitcoin/bitcoin/pull/11683
168 2017-11-14T09:20:10  *** nullptr| has quit IRC
169 2017-11-14T09:21:14  *** timothy has joined #bitcoin-core-dev
170 2017-11-14T09:22:09  <wumpus> meshcollider: will do
171 2017-11-14T09:22:39  <meshcollider> wumpus: thanks
172 2017-11-14T09:30:11  *** cbag_ has joined #bitcoin-core-dev
173 2017-11-14T09:30:37  *** harrymm has joined #bitcoin-core-dev
174 2017-11-14T09:31:30  *** kioneer has joined #bitcoin-core-dev
175 2017-11-14T09:37:35  <wumpus> I don't think anyone will mind if I merge it?
176 2017-11-14T09:39:30  <meshcollider> Shouldn't do, ACKs from both you and bluematt and its basically just a c+p of the release notes so its not exactly controversial :P
177 2017-11-14T09:39:43  <wumpus> and it's about time too
178 2017-11-14T09:40:36  <meshcollider> Still not as delayed as 15.0.1 was lol
179 2017-11-14T09:40:56  <wumpus> hehe, no not that delayed
180 2017-11-14T09:43:31  *** promag has joined #bitcoin-core-dev
181 2017-11-14T09:46:45  <promag> wdyt about changing this "if (request.fHelp || request.params.size() > 2)" to "if (request.fHelp)" ?
182 2017-11-14T09:47:34  <wumpus> NACK, that would make it ignore spurious arguments
183 2017-11-14T09:47:48  <wumpus> which should be an error
184 2017-11-14T09:48:03  *** Ylbam has quit IRC
185 2017-11-14T09:49:40  <promag> what I mean is to show help only when requested. Then have argument validation which should validate all arguments, so arguments with no validation should raise invalid parameter too
186 2017-11-14T09:50:38  <promag> or we could keep "if (request.params.size() > 2)" but that would raise invalid argument
187 2017-11-14T09:51:12  <promag> the help is mainly for the command line cli right?
188 2017-11-14T10:03:27  *** roconnor_ has quit IRC
189 2017-11-14T10:03:58  <wumpus> maybe, I really doubt this is worth changing all RPC calls for
190 2017-11-14T10:04:57  <wumpus> I mean barfing up the help in case of confusion about the number of arguments is consistent with what a lot of command line tools do, it's not wrong or such
191 2017-11-14T10:07:09  *** nullptr| has joined #bitcoin-core-dev
192 2017-11-14T10:07:32  <wumpus> at least we don't silently ignore spurious RPC arguments, unlike spurious command line options, which don't cause an error
193 2017-11-14T10:07:43  <wumpus> that's a much worse user experience
194 2017-11-14T10:08:01  <wumpus> type poxy instead of proxy and it doesn't even warn
195 2017-11-14T10:10:00  <promag> wumpus: ok
196 2017-11-14T10:10:19  <promag> but in some cases, if you pass options with extra keys, it won't complaint
197 2017-11-14T10:10:35  <wumpus> it should
198 2017-11-14T10:10:58  <wumpus> well maybe except nested structures
199 2017-11-14T10:11:00  *** dabura667 has quit IRC
200 2017-11-14T10:11:06  <promag> and if the caller makes it lower case or snake case instead of pascal case, it won't complaint
201 2017-11-14T10:11:23  <wumpus> I mean, it doesn't hurt to provide more information about a vout for createrawtransaction than it strictly needs
202 2017-11-14T10:11:34  <wumpus> this helps pass in the output from listunspents to it without filtering
203 2017-11-14T10:13:08  <promag> you mean for vin
204 2017-11-14T10:13:13  <wumpus> yes
205 2017-11-14T10:13:34  <wumpus> so let's just keep it like that
206 2017-11-14T10:13:54  <promag> anyway, really doubt that anyone does that copy and paste :)
207 2017-11-14T10:14:01  <meshcollider> oh wumpus, maybe your key is not trusted when merging bitcoincore.org PRs
208 2017-11-14T10:14:02  <meshcollider> https://github.com/bitcoin-core/bitcoincore.org/blob/master/contrib/verify-commits/trusted-keys
209 2017-11-14T10:14:10  <wumpus> promag: they do
210 2017-11-14T10:14:18  <promag> :o
211 2017-11-14T10:14:31  <wumpus> especially if it's used from scripts
212 2017-11-14T10:15:11  <promag> I suppose everyone should pick the relevant fields :D
213 2017-11-14T10:15:27  <wumpus> anyhow, please let's not change the RPC API just to change the RPC API, but focus on features, bugfixes and user experience
214 2017-11-14T10:15:44  <meshcollider> Agree ^
215 2017-11-14T10:15:53  <promag> np!
216 2017-11-14T10:16:26  <wumpus> meshcollider: uh oh
217 2017-11-14T10:17:59  <wumpus> meshcollider: I should probably force-push back to the previous state then
218 2017-11-14T10:18:21  <wumpus> meshcollider: only one of the trusted keys can add me as trusted key, and not on top of an invalid commit
219 2017-11-14T10:19:19  <meshcollider> wumpus: mhm yeah, in any case you should be added as a trusted key but yeah we might have to wait for jonasschnelli
220 2017-11-14T10:19:40  <wumpus> luckily it doesn't break the site itself, just blocks updates for now
221 2017-11-14T10:20:05  <meshcollider> yep, was wondering why it hadn't gone live so I looked around and noticed
222 2017-11-14T10:22:49  <wumpus> right - I'm not going to do anything, one of the signers can resolve this, either by adding a merge commit on top , or re-sigining the merge commit and force-pushing
223 2017-11-14T10:23:22  <wumpus> if they agree with the change of course :-)
224 2017-11-14T10:26:16  <meshcollider> Sounds good
225 2017-11-14T10:28:26  *** promag has quit IRC
226 2017-11-14T10:28:57  *** bobmaster2020 has joined #bitcoin-core-dev
227 2017-11-14T10:31:10  *** bobmaster2020 has left #bitcoin-core-dev
228 2017-11-14T10:46:25  *** promag has joined #bitcoin-core-dev
229 2017-11-14T10:50:17  *** Nina13Jaskolski has joined #bitcoin-core-dev
230 2017-11-14T10:58:14  *** promag has quit IRC
231 2017-11-14T10:58:22  *** go1111111 has joined #bitcoin-core-dev
232 2017-11-14T10:59:36  *** promag has joined #bitcoin-core-dev
233 2017-11-14T11:01:17  *** roconnor_ has joined #bitcoin-core-dev
234 2017-11-14T11:23:17  *** Jerrat has joined #bitcoin-core-dev
235 2017-11-14T11:27:50  *** Jerrat has quit IRC
236 2017-11-14T11:29:15  *** frst_btc has joined #bitcoin-core-dev
237 2017-11-14T11:29:35  *** cbag_ has quit IRC
238 2017-11-14T11:29:37  *** frst_btc has quit IRC
239 2017-11-14T11:31:40  *** bitstr3am has joined #bitcoin-core-dev
240 2017-11-14T11:32:21  *** luke-jr has quit IRC
241 2017-11-14T11:33:11  *** luke-jr has joined #bitcoin-core-dev
242 2017-11-14T11:34:50  *** ChristianXK has quit IRC
243 2017-11-14T11:35:04  *** bitstr3am has quit IRC
244 2017-11-14T11:43:31  *** chjj has joined #bitcoin-core-dev
245 2017-11-14T11:44:46  *** vicenteH has quit IRC
246 2017-11-14T11:45:33  *** vicenteH has joined #bitcoin-core-dev
247 2017-11-14T11:50:01  *** vicenteH has quit IRC
248 2017-11-14T11:52:54  *** laurentmt has joined #bitcoin-core-dev
249 2017-11-14T11:53:55  *** AaronvanW has joined #bitcoin-core-dev
250 2017-11-14T11:56:49  *** ula has quit IRC
251 2017-11-14T11:59:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7adeea3b0fc2...6d4821b693b2
252 2017-11-14T11:59:59  <bitcoin-git> bitcoin/master d8ac893 practicalswift: trivial: Fix typo – "Ubutntu" → "Ubuntu"
253 2017-11-14T12:00:00  <bitcoin-git> bitcoin/master 6d4821b Wladimir J. van der Laan: Merge #11684: trivial: Fix typo – "Ubutntu" → "Ubuntu"...
254 2017-11-14T12:00:33  <bitcoin-git> [bitcoin] laanwj closed pull request #11684: trivial: Fix typo – "Ubutntu" → "Ubuntu" (master...ubutntu) https://github.com/bitcoin/bitcoin/pull/11684
255 2017-11-14T12:07:01  *** SopaXorzTaker has joined #bitcoin-core-dev
256 2017-11-14T12:13:02  *** vicenteH has joined #bitcoin-core-dev
257 2017-11-14T12:46:47  *** promag has quit IRC
258 2017-11-14T12:56:05  *** promag has joined #bitcoin-core-dev
259 2017-11-14T12:59:36  *** instagibbs has quit IRC
260 2017-11-14T13:02:44  *** Giszmo1 has joined #bitcoin-core-dev
261 2017-11-14T13:02:44  *** Giszmo has quit IRC
262 2017-11-14T13:05:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
263 2017-11-14T13:13:08  *** promag has quit IRC
264 2017-11-14T13:37:00  *** Regan55Adams has joined #bitcoin-core-dev
265 2017-11-14T13:42:56  *** Regan55Adams has quit IRC
266 2017-11-14T13:43:45  *** pandabull has quit IRC
267 2017-11-14T13:43:59  *** Fernando72Lind has joined #bitcoin-core-dev
268 2017-11-14T13:44:53  *** promag has joined #bitcoin-core-dev
269 2017-11-14T13:47:48  *** Fernando72Lind has quit IRC
270 2017-11-14T13:48:03  *** Johanna29Quigley has joined #bitcoin-core-dev
271 2017-11-14T13:51:17  *** Johanna29Quigley has quit IRC
272 2017-11-14T13:51:32  *** Darrick80Christi has joined #bitcoin-core-dev
273 2017-11-14T13:54:55  *** Darrick80Christi has quit IRC
274 2017-11-14T13:55:11  *** Chris_Stewart_5 has quit IRC
275 2017-11-14T14:09:47  *** pandabull has joined #bitcoin-core-dev
276 2017-11-14T14:13:27  *** Piper65Hand has joined #bitcoin-core-dev
277 2017-11-14T14:17:48  *** Piper65Hand has quit IRC
278 2017-11-14T14:18:07  *** Eleonore77Rath has joined #bitcoin-core-dev
279 2017-11-14T14:29:09  *** meshcollider has quit IRC
280 2017-11-14T14:44:14  *** Eleonore77Rath has quit IRC
281 2017-11-14T14:44:44  *** Mollie73Gulgowsk has joined #bitcoin-core-dev
282 2017-11-14T14:51:28  *** promag has quit IRC
283 2017-11-14T14:52:26  *** Sentineo has joined #bitcoin-core-dev
284 2017-11-14T14:56:11  *** Mollie73Gulgowsk has quit IRC
285 2017-11-14T14:56:18  *** Alpaca_ has joined #bitcoin-core-dev
286 2017-11-14T14:56:56  *** Alpaca_ has quit IRC
287 2017-11-14T15:01:20  *** Nina13Jaskolski has quit IRC
288 2017-11-14T15:01:48  *** promag has joined #bitcoin-core-dev
289 2017-11-14T15:03:35  <BlueMatt> wumpus: heh, well jonasschnelli or harding_ could un-brick it by adding a merge commit on top that merges from before your merge :p
290 2017-11-14T15:03:42  <BlueMatt> we've dont that before....comically dirty hack
291 2017-11-14T15:03:45  <BlueMatt> but it appears to work
292 2017-11-14T15:03:45  *** drizztbsd has joined #bitcoin-core-dev
293 2017-11-14T15:04:33  *** timothy has quit IRC
294 2017-11-14T15:05:25  <BlueMatt> or someone can go poke the server, but prefer not to....will follow up if no one does it in an hour or so
295 2017-11-14T15:05:34  *** drizztbsd has quit IRC
296 2017-11-14T15:07:14  *** promag has quit IRC
297 2017-11-14T15:07:23  *** PaulCape_ has quit IRC
298 2017-11-14T15:11:33  *** timothy has joined #bitcoin-core-dev
299 2017-11-14T15:17:07  *** Murch has joined #bitcoin-core-dev
300 2017-11-14T15:18:47  *** Randy55Carter has joined #bitcoin-core-dev
301 2017-11-14T15:21:35  *** justanotheruser has quit IRC
302 2017-11-14T15:21:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
303 2017-11-14T15:29:17  *** pandabull has quit IRC
304 2017-11-14T15:33:40  *** PaulCapestany has joined #bitcoin-core-dev
305 2017-11-14T15:34:14  *** Murch has quit IRC
306 2017-11-14T15:34:58  *** ctulino has joined #bitcoin-core-dev
307 2017-11-14T15:40:44  *** justanotheruser has joined #bitcoin-core-dev
308 2017-11-14T15:42:41  *** promag has joined #bitcoin-core-dev
309 2017-11-14T15:58:38  *** rabidus has quit IRC
310 2017-11-14T16:03:48  *** timothy has quit IRC
311 2017-11-14T16:07:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11682: wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) (master...CCryptoKeyStore-AddKeyPubKey) https://github.com/bitcoin/bitcoin/pull/11682
312 2017-11-14T16:15:27  *** JackH has quit IRC
313 2017-11-14T16:16:40  *** jb55 has joined #bitcoin-core-dev
314 2017-11-14T16:21:40  *** promag has quit IRC
315 2017-11-14T16:21:41  *** MrPaz has joined #bitcoin-core-dev
316 2017-11-14T16:22:55  *** jb55 has quit IRC
317 2017-11-14T16:33:32  *** timothy has joined #bitcoin-core-dev
318 2017-11-14T16:38:33  *** JackH has joined #bitcoin-core-dev
319 2017-11-14T16:46:29  *** BashCo has quit IRC
320 2017-11-14T16:47:05  *** BashCo has joined #bitcoin-core-dev
321 2017-11-14T16:49:23  *** jb55 has joined #bitcoin-core-dev
322 2017-11-14T16:51:11  *** BashCo has quit IRC
323 2017-11-14T16:53:05  *** LumberCartel has quit IRC
324 2017-11-14T17:00:55  *** rabidus has joined #bitcoin-core-dev
325 2017-11-14T17:22:55  *** Dizzle has joined #bitcoin-core-dev
326 2017-11-14T17:26:41  *** Randy55Carter has quit IRC
327 2017-11-14T17:26:49  *** BashCo has joined #bitcoin-core-dev
328 2017-11-14T17:26:59  *** Flavio25Buckridg has joined #bitcoin-core-dev
329 2017-11-14T17:31:57  *** laurentmt has quit IRC
330 2017-11-14T17:34:25  *** jb55 has quit IRC
331 2017-11-14T17:41:35  *** PaulCapestany has quit IRC
332 2017-11-14T17:44:26  *** roidster has joined #bitcoin-core-dev
333 2017-11-14T17:44:30  *** roidster is now known as Guest60291
334 2017-11-14T17:47:07  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (master...2017-11-shorter-default-issue) https://github.com/bitcoin/bitcoin/pull/11686
335 2017-11-14T17:53:43  *** PaulCapestany has joined #bitcoin-core-dev
336 2017-11-14T18:00:35  *** Ylbam has joined #bitcoin-core-dev
337 2017-11-14T18:11:28  *** laurentmt has joined #bitcoin-core-dev
338 2017-11-14T18:13:08  *** LumberCartel has joined #bitcoin-core-dev
339 2017-11-14T18:14:58  *** laurentmt has quit IRC
340 2017-11-14T18:25:16  *** timothy has quit IRC
341 2017-11-14T18:28:01  *** Giszmo1 has quit IRC
342 2017-11-14T18:28:33  *** jtimon has joined #bitcoin-core-dev
343 2017-11-14T18:37:09  *** promag has joined #bitcoin-core-dev
344 2017-11-14T18:37:23  *** esotericnonsense has joined #bitcoin-core-dev
345 2017-11-14T18:43:02  *** alreadylate has joined #bitcoin-core-dev
346 2017-11-14T18:43:33  *** Giszmo has joined #bitcoin-core-dev
347 2017-11-14T18:53:07  *** bule has joined #bitcoin-core-dev
348 2017-11-14T19:04:31  *** Dizzle has quit IRC
349 2017-11-14T19:05:35  *** Giszmo has quit IRC
350 2017-11-14T19:14:12  *** wunpunch has joined #bitcoin-core-dev
351 2017-11-14T19:17:17  *** SopaXorzTaker has quit IRC
352 2017-11-14T19:27:01  *** Murch has joined #bitcoin-core-dev
353 2017-11-14T19:27:41  *** ott0disk has joined #bitcoin-core-dev
354 2017-11-14T19:34:52  *** MrPaz has quit IRC
355 2017-11-14T19:35:56  *** jb55 has joined #bitcoin-core-dev
356 2017-11-14T19:37:23  *** intcat has quit IRC
357 2017-11-14T19:38:20  *** intcat has joined #bitcoin-core-dev
358 2017-11-14T19:47:47  *** Giszmo has joined #bitcoin-core-dev
359 2017-11-14T19:51:16  *** ott0disk has quit IRC
360 2017-11-14T19:52:23  *** alreadylate has quit IRC
361 2017-11-14T19:54:01  *** jsfour has joined #bitcoin-core-dev
362 2017-11-14T19:56:15  *** dcousens has quit IRC
363 2017-11-14T19:56:58  *** dcousens has joined #bitcoin-core-dev
364 2017-11-14T20:00:52  *** meshcollider has joined #bitcoin-core-dev
365 2017-11-14T20:03:22  <bitcoin-git> [bitcoin] ryanofsky opened pull request #11687: External wallet files (master...pr/wfile) https://github.com/bitcoin/bitcoin/pull/11687
366 2017-11-14T20:09:01  *** MrPaz has joined #bitcoin-core-dev
367 2017-11-14T20:09:20  *** jsfour has left #bitcoin-core-dev
368 2017-11-14T20:09:23  *** Dizzle has joined #bitcoin-core-dev
369 2017-11-14T20:09:29  *** Cheeseo has joined #bitcoin-core-dev
370 2017-11-14T20:24:06  *** devin_ has joined #bitcoin-core-dev
371 2017-11-14T20:42:02  *** Giszmo has quit IRC
372 2017-11-14T20:46:11  *** MrPaz has quit IRC
373 2017-11-14T20:46:40  *** Giszmo has joined #bitcoin-core-dev
374 2017-11-14T20:47:59  *** chjj has quit IRC
375 2017-11-14T20:51:14  *** MrPaz has joined #bitcoin-core-dev
376 2017-11-14T20:54:26  *** Guest60291 has quit IRC
377 2017-11-14T20:56:57  *** jb55 has quit IRC
378 2017-11-14T20:58:04  *** wunpunch has quit IRC
379 2017-11-14T21:00:31  *** jnewbery has quit IRC
380 2017-11-14T21:01:54  *** jnewbery has joined #bitcoin-core-dev
381 2017-11-14T21:03:42  *** wunpunch has joined #bitcoin-core-dev
382 2017-11-14T21:08:41  *** BCBot has quit IRC
383 2017-11-14T21:16:36  *** BCBot has joined #bitcoin-core-dev
384 2017-11-14T21:22:08  *** jb55 has joined #bitcoin-core-dev
385 2017-11-14T21:26:40  *** Nobody_ has joined #bitcoin-core-dev
386 2017-11-14T21:26:43  <Nobody_> Hello
387 2017-11-14T21:26:50  <Nobody_> i am Nobody, and i own the system
388 2017-11-14T21:27:18  <Nobody_> i just wanted to state that i am requesting as a System that nobody owns and if you abuse the system you abuse yourself some upgrades that need to happen for the Bitcoin Core
389 2017-11-14T21:28:05  <Nobody_> If anybody could get a message to the Bitcoin Core Developers to add the Mining back into the Core that would be perfect, ASIC is not needed to mine and is outdated plus not as power efficient
390 2017-11-14T21:28:46  <Nobody_> also a Faucet in the core is needed for Nobody to send Bitcoin to the requested wallet of your choice, for reasons if it is not avaliable from anyone else the system will continue to function appropriately.
391 2017-11-14T21:29:50  <Nobody_> Nobody should be able to have wallets that can be loaded with and share Cryptocurrency back if requested and users should be able to put Cryptocurrency into the faucet if they do not need it
392 2017-11-14T21:30:32  <LumberCartel> Nobody_:  You should raise your concerns in the #bitcoin channel rather than in this channel.
393 2017-11-14T21:30:45  <Nobody_> it will bring Freedom and Equality for all users and not be so dominant on switching cash for cashless, i work with Antarctica and have researched the software very hard, Satoshi Nakamoto knows who i am but i will leave me Nobody
394 2017-11-14T21:31:11  <Nobody_> it is more than a concern and i deem it nessessary to update it to make sure that everyone can enjoy the Cryptocurrency
395 2017-11-14T21:32:13  <Nobody_> I already have a version that has a faucet and it is sufficient, as well as for the common good of the public and passes for being benificial for the greater good of humanity
396 2017-11-14T21:33:15  <Dizzle> Nobody_: if you do have something more power efficient than ASIC for mining, you can submit a pull request that adds mining back into Core. If you're not sure how, let me know how its done and I'll help make the pull request.
397 2017-11-14T21:37:57  *** LumberCartel has quit IRC
398 2017-11-14T21:39:19  *** bule has quit IRC
399 2017-11-14T21:39:38  <Nobody_> S.O.S, Law Enforcement Update - Everything is legal
400 2017-11-14T21:39:38  <Nobody_> Everything  ECDSA Public Key (Bitcoin Compatible):  1N2EWy7LroJVFYXtmYZryh7W9eV3k6qajd exists since Mon Oct 02 2017 23:48:19 GMT-0700 (Pacific Daylight Time)
401 2017-11-14T21:39:48  *** bule has joined #bitcoin-core-dev
402 2017-11-14T21:39:48  <Nobody_> that is a Trusted timestamp and is forge proof
403 2017-11-14T21:40:41  *** ChanServ sets mode: +o luke-jr
404 2017-11-14T21:40:45  *** Nobody_ was kicked by luke-jr (funny, but no)
405 2017-11-14T21:40:46  *** luke-jr sets mode: -o luke-jr
406 2017-11-14T21:42:38  *** Cheeseo has quit IRC
407 2017-11-14T21:46:35  *** Giszmo has quit IRC
408 2017-11-14T21:51:20  *** Giszmo has joined #bitcoin-core-dev
409 2017-11-14T21:51:26  *** chjj has joined #bitcoin-core-dev
410 2017-11-14T21:55:21  *** Chris_Stewart_5 has quit IRC
411 2017-11-14T21:56:08  *** Giszmo has quit IRC
412 2017-11-14T21:57:08  *** Victor_sueca has joined #bitcoin-core-dev
413 2017-11-14T21:57:29  <Dizzle> I still want his quantum CPU mining pull request.
414 2017-11-14T21:58:49  *** lari has quit IRC
415 2017-11-14T21:59:08  *** ghost43 has quit IRC
416 2017-11-14T21:59:27  *** andytosh1 has joined #bitcoin-core-dev
417 2017-11-14T21:59:38  *** spinza has quit IRC
418 2017-11-14T21:59:39  *** andytoshi has quit IRC
419 2017-11-14T21:59:39  *** Cory has quit IRC
420 2017-11-14T21:59:41  *** warxhead has quit IRC
421 2017-11-14T22:00:07  *** Victorsueca has quit IRC
422 2017-11-14T22:00:09  *** warxhead has joined #bitcoin-core-dev
423 2017-11-14T22:00:19  *** ghost43 has joined #bitcoin-core-dev
424 2017-11-14T22:00:45  *** PaulCapestany has quit IRC
425 2017-11-14T22:01:02  *** lari has joined #bitcoin-core-dev
426 2017-11-14T22:01:20  *** PaulCapestany has joined #bitcoin-core-dev
427 2017-11-14T22:02:07  *** gaf_ has quit IRC
428 2017-11-14T22:02:29  *** boreddanman has quit IRC
429 2017-11-14T22:04:05  *** Pasha has joined #bitcoin-core-dev
430 2017-11-14T22:04:40  *** gaf_ has joined #bitcoin-core-dev
431 2017-11-14T22:04:48  *** boreddanman1 has joined #bitcoin-core-dev
432 2017-11-14T22:07:16  *** Pasha is now known as Cory
433 2017-11-14T22:10:38  *** meshcollider has quit IRC
434 2017-11-14T22:11:50  *** alreadylate has joined #bitcoin-core-dev
435 2017-11-14T22:15:52  *** spinza has joined #bitcoin-core-dev
436 2017-11-14T22:19:42  *** promag has quit IRC
437 2017-11-14T22:19:56  *** promag has joined #bitcoin-core-dev
438 2017-11-14T22:21:37  *** promag has quit IRC
439 2017-11-14T22:22:31  *** promag has joined #bitcoin-core-dev
440 2017-11-14T22:29:53  *** meshcollider has joined #bitcoin-core-dev
441 2017-11-14T22:37:31  <bitcoin-git> [bitcoin] practicalswift opened pull request #11689: Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins) (master...CTxMemPool-check) https://github.com/bitcoin/bitcoin/pull/11689
442 2017-11-14T22:46:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d4821b693b2...3bdf242fc68a
443 2017-11-14T22:46:07  <bitcoin-git> bitcoin/master fafdad0 MarcoFalke: qa: Remove unused NodeConn members
444 2017-11-14T22:46:07  <bitcoin-git> bitcoin/master 3bdf242 MarcoFalke: Merge #11677: qa: Remove unused NodeConn members...
445 2017-11-14T22:46:41  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11677: qa: Remove unused NodeConn members (master...Mf1711-qaMininodeUnused) https://github.com/bitcoin/bitcoin/pull/11677
446 2017-11-14T22:48:44  *** wxss has quit IRC
447 2017-11-14T22:57:22  *** midnightmagic has quit IRC
448 2017-11-14T22:59:29  *** Cogito_Ergo_Sum has quit IRC
449 2017-11-14T23:00:11  *** promag has quit IRC
450 2017-11-14T23:09:16  *** Cheeseo has joined #bitcoin-core-dev
451 2017-11-14T23:11:43  *** wxss has joined #bitcoin-core-dev
452 2017-11-14T23:12:39  *** alreadylate has quit IRC
453 2017-11-14T23:14:49  *** midnightmagic has joined #bitcoin-core-dev
454 2017-11-14T23:19:48  *** jsfour has joined #bitcoin-core-dev
455 2017-11-14T23:22:03  *** Giszmo has joined #bitcoin-core-dev
456 2017-11-14T23:24:12  *** LumberCartel has joined #bitcoin-core-dev
457 2017-11-14T23:25:30  <karelb> Question about bitcoin-core - why is validation.h/.cpp so "overloaded"? It seems to me half of the things in there don't have to do much with validation
458 2017-11-14T23:26:22  <karelb> such as default parameters, opening and writing to block files, etc
459 2017-11-14T23:29:37  *** vicenteH has quit IRC
460 2017-11-14T23:29:49  *** Cheeseo has quit IRC
461 2017-11-14T23:30:18  <sipa> karelb: the reason is that up to about a year ago maybe, validation.cpp and net_processing.cpp were one file, called main.cpp
462 2017-11-14T23:30:36  <sipa> splitting things up and off into other modules is a slow but continuing work that's certainly not complete yet
463 2017-11-14T23:30:42  <karelb> Oh yeah, I thought it will be something historic like that
464 2017-11-14T23:31:14  <karelb> I remember giant main.cpp, I suspected validation is "just" renamed main
465 2017-11-14T23:31:16  <karelb> thanks!
466 2017-11-14T23:31:19  <sipa> (and until a few years ago, main.cpp also contained all of chain management, utxo stuff, wallet, interaction with the GUI...)
467 2017-11-14T23:33:29  <karelb> hm, doing refactoring like that seems like an easy way to get some cheap commits in bitcoin core code :D
468 2017-11-14T23:34:09  *** timothy has joined #bitcoin-core-dev
469 2017-11-14T23:36:27  *** Dizzle has quit IRC
470 2017-11-14T23:36:27  <gmaxwell> karelb: it's not just renamed main, main was split basically in half, but there is still hangover.  Also some of these things like consensus parameters are critical to consensus validation.
471 2017-11-14T23:37:41  *** fanquake has joined #bitcoin-core-dev
472 2017-11-14T23:37:59  <gmaxwell> There is some layout tension on that; abstracting consensus rules can make them more opaque and harder to review; and bitcoin core is not an altcoin construction set. :)  OTOH, sometimes moving things around makes things more clear, enables better testing harnesses, etc.
473 2017-11-14T23:38:56  <fanquake> karelb heh, there are easier ways to get cheap commits than playing with consensus code
474 2017-11-14T23:39:32  *** AaronvanW has quit IRC
475 2017-11-14T23:39:45  <karelb> fanquake I know, I have this giant commit
476 2017-11-14T23:39:47  <karelb> https://github.com/bitcoin/bitcoin/commit/06a3aecf06a52ff44370ee20462cc45b25e88d6a
477 2017-11-14T23:39:51  <gmaxwell> karelb: yea,.lol no, refactoring consensus code is a good way to have a bad time and decide you don't want to contribute more.
478 2017-11-14T23:40:09  *** AaronvanW has joined #bitcoin-core-dev
479 2017-11-14T23:40:17  *** jb55 has quit IRC
480 2017-11-14T23:41:11  <fanquake> karelb All contributions are valuable. Most people might find "issues" and never bother contribute a pr, or open an issue.
481 2017-11-14T23:43:45  <gmaxwell> For obvious refactorings e.g. to meet our current code standards, we prefer to only perform them when the code is already being changed to avoid disrupting PR flow.  For non-obvious refactors it is better if only expirenced participants do them, because newer contribs tend to not understand the informal architecture as well and tend to make refactors that unconsciously try to warp thing more to
482 2017-11-14T23:43:51  <gmaxwell> their own personal styles instead of the project style.  Consensus code in general has a higher review and testing bar, and is more likely to end up with people failing to review it because they don't think it meets a cost/benefit for the review.  Sometimes refactorings of consensus code only happen because someone like pieter is effectively cashing in large amounts of social capital to pay for
483 2017-11-14T23:43:57  <gmaxwell> other people to review the work-- and the fact that this is whats happening isn't necessarily visible to irregular contributors.   So while anyone is welcome to submit such things, I wouldn't recommend those in particular, and anyone who submits consensus refactors should have reasonable expectations.
484 2017-11-14T23:44:47  <fanquake> Now that the *new* Windows build instructions have been merged, I'm going to close all the existing windows build issues, hopefully we might get on top of them. However now it seems the there are just new path/directory related issues.
485 2017-11-14T23:47:13  <fanquake> gmaxwell yes, hit and run consensus refactoring isn't really helpful.
486 2017-11-14T23:47:13  <karelb> gmaxwell: OK, I will not make a PR that pulls out all `DEFAULT_`s from validation.h to defaults.h then. :)
487 2017-11-14T23:59:02  *** Cheeseo has joined #bitcoin-core-dev